)]}'
{
  "commit": "37d64fa5ed0655fa3329f1d71583f2d42745fe41",
  "tree": "c941a76c6149b04375ceefc70d51f2d736388a3e",
  "parents": [
    "ef057fc59d3571f95c1c395c1923d044a746bb19"
  ],
  "author": {
    "name": "Eric Biggers",
    "email": "ebiggers@google.com",
    "time": "Mon Jan 22 18:16:02 2024 +0000"
  },
  "committer": {
    "name": "Eric Biggers",
    "email": "ebiggers@google.com",
    "time": "Mon Jan 22 19:14:24 2024 +0000"
  },
  "message": "LockPatternUtilsTest: use dependency injection for ILockSettings\n\nLockPatternUtilsTest is spying on LockPatternUtils to try to inject a\nmock ILockSettings.  Using \"spy\" is an anti-pattern, and it doesn\u0027t seem\nto work properly as the following test failure occurs:\n\n    [8/17] com.android.internal.util.LockPatternUtilsTest#isLockScreenDisabled_isSecureAndDemoUser_false: FAILED (3ms)\n\n    STACKTRACE:\n    java.lang.AssertionError\n            at org.junit.Assert.fail(Assert.java:87)\n            at org.junit.Assert.assertTrue(Assert.java:42)\n            at org.junit.Assert.assertFalse(Assert.java:65)\n            at org.junit.Assert.assertFalse(Assert.java:75)\n            at com.android.internal.util.LockPatternUtilsTest.isLockScreenDisabled_isSecureAndDemoUser_false(LockPatternUtilsTest.java:148)\n\nThis CL fixes the bug by making LockPatternUtils optionally take an\nILockSettings via constructor.\n\nNote: LockPatternUtils#getLockSettings() cannot yet be changed to\nprivate because it actually has a caller in non-test code.\n\nBug: 321737173\nIgnore-AOSP-First: Conflict due to security fix ag/25939141\nFlag: NA\nTest: atest FrameworksUtilTests:com.android.internal.util.LockPatternUtilsTest\nChange-Id: I242d3bdfe62c0be5a40df6028c6d34fad8f0abe2\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "757978b71a01b2c1fb8a67bdfb9ac73d53b759a9",
      "old_mode": 33188,
      "old_path": "core/java/com/android/internal/widget/LockPatternUtils.java",
      "new_id": "b5b3a48dacb7bb03c122ae97492f2484159c45cb",
      "new_mode": 33188,
      "new_path": "core/java/com/android/internal/widget/LockPatternUtils.java"
    },
    {
      "type": "modify",
      "old_id": "dcaf67660ffacbb971e21009d06e2e093228cec7",
      "old_mode": 33188,
      "old_path": "core/tests/utiltests/src/com/android/internal/util/LockPatternUtilsTest.java",
      "new_id": "7b4797a7d80f4b403bc1219443924f884823e720",
      "new_mode": 33188,
      "new_path": "core/tests/utiltests/src/com/android/internal/util/LockPatternUtilsTest.java"
    }
  ]
}