Remove ControlsProviderSelectorActivity finish on
ControlsFavoritingActivity start

When ControlsProviderSelectorActivity starts
ControlsFavouritingActivity it uses ControlsActivity instance for
transitions. ControlsActivity interacts with ControlsBindingController
to get a list of controls. This interaction prevents load from
happening because ControlsBindingController has a global state, and
prevents users from adding a second Controls app.

Removing finishing ControlsProviderSelectorActivity prevents
ControlsActivity from being started.

Test: manual with the steps from the bug
Test: atest ControlsProviderSelectorActivityTest
Fixes: 283070266
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:442c1002a8563c291c149d18e143e1880a82a27e)
Merged-In: I02ddaa5e823379510e9c81a8d803d5269e6d85ad
Change-Id: I02ddaa5e823379510e9c81a8d803d5269e6d85ad
2 files changed