)]}'
{
  "commit": "217caf6028b51df92a8ecb6281c002826083e3db",
  "tree": "631f1488adbe0628fd05203e0d0c0261902154be",
  "parents": [
    "3313823970d8338d6d3b5e99b59bae95ef8ed45d"
  ],
  "author": {
    "name": "Robin Lee",
    "email": "rgl@google.com",
    "time": "Thu Apr 14 19:06:05 2022 +0200"
  },
  "committer": {
    "name": "Cherrypicker Worker",
    "email": "android-build-cherrypicker-worker@google.com",
    "time": "Sat Apr 16 18:12:31 2022 +0000"
  },
  "message": "Make CentralSurfaces optional\n\nCentralSurfaces will instacrash on TV devices if it doesn\u0027t haave all\nof its dependencies available. Since it is included by SystemUIBinder\nvia CentralSurfacesModule, we need to remove SystemUIBinder from TV.\n\nWhen we do that, we find that BouncerSwipeTouchHandler has a hard\ndependency on phone.CentralSurfaces meaning that CentralSurfaces was\nnot actually optional any more.\n\nSo we need to convert the dependency there to Optional\u003c\u003e. In future\nthe fact that TV does not have a CentralSurfaces should guarantee\ncompile errors if this happens again and keep CentralSurfaces actually\nOptional as the javadocs say.\n\nWe also need to remove a lot of phone-specific assumptions under the\ndreams/touch area, as the following classes remain present even after\nthis change:\n\n - com.android.systemui.statusbar.phone.UnlockedScreenOffAnimationController\n - com.android.systemui.statusbar.phone.NotificationShadeWindowControllerImpl\n - com.android.systemui.statusbar.phone.ConfigurationControllerImpl\n - com.android.systemui.statusbar.phone.StatusBarKeyguardViewManager\n - com.android.systemui.statusbar.phone.DozeParameters\n\nBut that\u0027s a much larger task for another day.\n\nBug: 228414760\nChange-Id: Id0a5e35e113bb1d0268c7f687cbd54799a1d9b77\n(cherry picked from commit 0c673b11488c1b96a0cbb374b8c569b2761bb228)\nMerged-In: Id0a5e35e113bb1d0268c7f687cbd54799a1d9b77\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "517fce1b16a69fbfbc609e10af816d81a785e4c5",
      "old_mode": 33188,
      "old_path": "packages/SystemUI/src/com/android/systemui/dreams/touch/BouncerSwipeTouchHandler.java",
      "new_id": "56eb9d2ecdd57fad560a272550ab5aec2d05d7b3",
      "new_mode": 33188,
      "new_path": "packages/SystemUI/src/com/android/systemui/dreams/touch/BouncerSwipeTouchHandler.java"
    },
    {
      "type": "modify",
      "old_id": "6fdce1ae4ec28194aeeb9be441bee497316d9374",
      "old_mode": 33188,
      "old_path": "packages/SystemUI/src/com/android/systemui/tv/TvSysUIComponent.java",
      "new_id": "640adcc9dd9463f7a8de801d9d2fd832f96f3f72",
      "new_mode": 33188,
      "new_path": "packages/SystemUI/src/com/android/systemui/tv/TvSysUIComponent.java"
    },
    {
      "type": "modify",
      "old_id": "535023fa08c548c90df9a431cf1d89a6ca67bcf9",
      "old_mode": 33188,
      "old_path": "packages/SystemUI/tests/src/com/android/systemui/dreams/touch/BouncerSwipeTouchHandlerTest.java",
      "new_id": "ccbe6f7671007243dde852dc28c5475212608cac",
      "new_mode": 33188,
      "new_path": "packages/SystemUI/tests/src/com/android/systemui/dreams/touch/BouncerSwipeTouchHandlerTest.java"
    }
  ]
}
