M3UParser: make url on demand Bug: 77823362 Test: adb shell am start -a android.intent.action.VIEW -d http://10.42.0.1:8080 Change-Id: Ieaf8a13985277eee5b085ed243205a597627cf5e (cherry picked from commit 26e236bd426770869644a9962778dedea7bf59be)
diff --git a/media/libstagefright/httplive/M3UParser.cpp b/media/libstagefright/httplive/M3UParser.cpp index 9bdf895..52791b9 100644 --- a/media/libstagefright/httplive/M3UParser.cpp +++ b/media/libstagefright/httplive/M3UParser.cpp
@@ -57,7 +57,7 @@ const char *language, uint32_t flags); - bool getActiveURI(AString *uri) const; + bool getActiveURI(AString *uri, const char *baseURL) const; void pickRandomMediaItems(); status_t selectTrack(size_t index, bool select); @@ -76,6 +76,7 @@ AString mURI; AString mLanguage; uint32_t mFlags; + AString makeURL(const char *baseURL) const; }; Type mType; @@ -228,12 +229,12 @@ return format; } -bool M3UParser::MediaGroup::getActiveURI(AString *uri) const { +bool M3UParser::MediaGroup::getActiveURI(AString *uri, const char *baseURL) const { for (size_t i = 0; i < mMediaItems.size(); ++i) { if (mSelectedIndex >= 0 && i == (size_t)mSelectedIndex) { const Media &item = mMediaItems.itemAt(i); - *uri = item.mURI; + *uri = item.makeURL(baseURL); return true; } } @@ -322,7 +323,7 @@ } if (uri) { - *uri = mItems.itemAt(index).mURI; + *uri = mItems.itemAt(index).makeURL(mBaseURI.c_str()); } if (meta) { @@ -428,7 +429,7 @@ AString groupID; if (!meta->findString(key, &groupID)) { if (uri != NULL) { - *uri = mItems.itemAt(index).mURI; + *uri = mItems.itemAt(index).makeURL(mBaseURI.c_str()); } AString codecs; @@ -459,7 +460,7 @@ // don't care about the active URI (or if there is an active one) if (uri != NULL) { sp<MediaGroup> group = mMediaGroups.valueFor(groupID); - if (!group->getActiveURI(uri)) { + if (!group->getActiveURI(uri, mBaseURI.c_str())) { return false; } @@ -548,6 +549,18 @@ return true; } +AString M3UParser::Item::makeURL(const char *baseURL) const { + AString out; + CHECK(MakeURL(baseURL, mURI.c_str(), &out)); + return out; +} + +AString M3UParser::MediaGroup::Media::makeURL(const char *baseURL) const { + AString out; + CHECK(MakeURL(baseURL, mURI.c_str(), &out)); + return out; +} + status_t M3UParser::parse(const void *_data, size_t size) { int32_t lineNo = 0; @@ -678,7 +691,7 @@ mItems.push(); Item *item = &mItems.editItemAt(mItems.size() - 1); - CHECK(MakeURL(mBaseURI.c_str(), line.c_str(), &item->mURI)); + item->mURI = line; item->mMeta = itemMeta; @@ -1190,9 +1203,7 @@ AString tmp(val, 1, val.size() - 2); - if (!MakeURL(mBaseURI.c_str(), tmp.c_str(), &groupURI)) { - ALOGI("Failed to make absolute URI from '%s'.", tmp.c_str()); - } + groupURI = tmp; haveGroupURI = true; }
diff --git a/media/libstagefright/httplive/M3UParser.h b/media/libstagefright/httplive/M3UParser.h index fa648ed..c85335a 100644 --- a/media/libstagefright/httplive/M3UParser.h +++ b/media/libstagefright/httplive/M3UParser.h
@@ -64,6 +64,7 @@ struct Item { AString mURI; sp<AMessage> mMeta; + AString makeURL(const char *baseURL) const; }; status_t mInitCheck;