commit 20bac0dec6446b4eb75a1ffbefef7a9d31a97432
author Robert Shih <robertshih@google.com> Fri Mar 18 14:34:57 2016 -0700
committer The Android Automerger <android-build@google.com> Fri Mar 25 16:24:07 2016 -0700
tree aa3d06685b76e6bac9056e4c56aa8bea3c58ae2b
parent d9caaac7ee750d558dfdcdaa3ab342f5f6040cbe

NuPlayerStreamListener: NULL and bounds check before memcpy

Bug: 27533704
Change-Id: I992a7709b92b1cbc3114c97bec48a3fc5b22ba6e

media/libmediaplayerservice/nuplayer/NuPlayerStreamListener.cpp

diff --git a/media/libmediaplayerservice/nuplayer/NuPlayerStreamListener.cpp b/media/libmediaplayerservice/nuplayer/NuPlayerStreamListener.cpp
index f53afbd..ee70306 100644
--- a/media/libmediaplayerservice/nuplayer/NuPlayerStreamListener.cpp
+++ b/media/libmediaplayerservice/nuplayer/NuPlayerStreamListener.cpp
@@ -144,8 +144,17 @@
         copy = size;
     }
 
+    if (entry->mIndex >= mBuffers.size()) {
+        return ERROR_MALFORMED;
+    }
+
+    sp<IMemory> mem = mBuffers.editItemAt(entry->mIndex);
+    if (mem == NULL || mem->size() < copy || mem->size() - copy < entry->mOffset) {
+        return ERROR_MALFORMED;
+    }
+
     memcpy(data,
-           (const uint8_t *)mBuffers.editItemAt(entry->mIndex)->pointer()
+           (const uint8_t *)mem->pointer()
             + entry->mOffset,
            copy);