commit f7e5f22f98346bb19ca9ac7ea3912fea5b13131c
author andresp@webrtc.org <andresp@webrtc.org> Fri Sep 12 13:35:05 2014 +0000
committer andresp@webrtc.org <andresp@webrtc.org> Fri Sep 12 13:35:05 2014 +0000
tree 90324f251ef168f9eb0520e05307b60a9cf058cf
parent a0d7827b1631fa8e2cf8957a76736ab159cb962a

Fix stack limit exceeded in http client.

R=henrike@webrtc.org

Review URL: https://webrtc-codereview.appspot.com/23419004

git-svn-id: http://webrtc.googlecode.com/svn/trunk@7165 4adac7df-926f-26a2-2b94-8c16560cd09d

webrtc/base/httpclient.cc

diff --git a/webrtc/base/httpclient.cc b/webrtc/base/httpclient.cc
index 0bf3880..fe34f7c 100644
--- a/webrtc/base/httpclient.cc
+++ b/webrtc/base/httpclient.cc
@@ -18,6 +18,7 @@
 #include "webrtc/base/httpclient.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/pathutils.h"
+#include "webrtc/base/scoped_ptr.h"
 #include "webrtc/base/socketstream.h"
 #include "webrtc/base/stringencode.h"
 #include "webrtc/base/stringutils.h"
@@ -596,8 +597,10 @@
   if ((HE_NONE == error)
       && (HV_HEAD != request().verb)
       && response().document) {
-    char buffer[1024 * 64];
-    StreamResult result = Flow(stream.get(), buffer, ARRAY_SIZE(buffer),
+    // Allocate on heap to not explode the stack.
+    const int array_size = 1024 * 64;
+    scoped_ptr<char[]> buffer(new char[array_size]);
+    StreamResult result = Flow(stream.get(), buffer.get(), array_size,
                                response().document.get());
     if (SR_SUCCESS != result) {
       error = HE_STREAM;