commit | aa3d3b47935fa5d189ac2ff0d493b548c41ef497 | [log] [tgz] |
---|---|---|
author | Mirko Bonadei <mbonadei@webrtc.org> | Wed Sep 30 18:53:52 2020 +0000 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Sep 30 19:00:37 2020 +0000 |
tree | 0d370a716df783dd4e325329ae72694e404c9ead | |
parent | 45be0a9810826fd271a02ef3c1b48b74fd7e4c0f [diff] |
Revert "Reduce the amount of howling reduction in AEC3" This reverts commit 2978abb88c49362e296bdce3cb662f6255b17083. Reason for revert: Breaks ApmTest.Process. After trying to enable AVX2, we increased the amount of error we tolerate (kFloatNear) and this CL introduced a regression which makes the test fail after we reverted the enabling of AVX2 (restoring the old tolerance). With this CL: ../../modules/audio_processing/audio_processing_unittest.cc:1779: Failure The difference between test->rms_dbfs_average() and rms_dbfs_average is 0.00142669677734375, which exceeds kFloatNear, where test->rms_dbfs_average() evaluates to 52.907142639160156, rms_dbfs_average evaluates to 52.905715942382812, and kFloatNear evaluates to 0.00050000000000000001. [ FAILED ] ApmTest.Process (5347 ms) [----------] 1 test from ApmTest (5348 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (5350 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] ApmTest.Process After reverting it: [ OK ] ApmTest.Process (5345 ms) [----------] 1 test from ApmTest (5347 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (5350 ms total) [ PASSED ] 1 test. Original change's description: > Reduce the amount of howling reduction in AEC3 > > This CL backs off the howling protection functionality in AEC3. > The effect is increased transparency in some cases. No negative effects > have been identified in the hands-on testing. > > > A kill-switch is added that can be used to turn off the functionality. > > Bug: b/150764764 > Change-Id: I604c569c76f911799556a60bc8fd2fb43bbfe196 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186082 > Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> > Commit-Queue: Per Åhgren <peah@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32258} TBR=gustaf@webrtc.org,peah@webrtc.org Change-Id: I4723c5cd66e3046851089157ec586afab55c5ce8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/150764764 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/186122 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Per Åhgren <peah@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32261}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.