commit | 4cf8e17e92500cf52723edc82c20ff3be609081f | [log] [tgz] |
---|---|---|
author | Guido Urdaneta <guidou@webrtc.org> | Fri Oct 09 09:02:53 2020 +0000 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Oct 09 11:49:11 2020 +0000 |
tree | fe9511d1f5ede28c86b643cb1f4a36b0fc878338 | |
parent | 3fb94a488c7ad1cd42be3072584a676784dde662 [diff] |
Revert "Improve screen sharing with PipeWire on Wayland" This reverts commit 9b87037073f1811bcdae30967167f30b364e6879. Reason for revert: Causing compile failures that prevent rolling into chrome. See https://ci.chromium.org/p/chromium/builders/try/cast_shell_linux/726007 https://chromium-review.googlesource.com/c/chromium/src/+/2461647 Original change's description: > Improve screen sharing with PipeWire on Wayland > > Currently, sharing a screen or a window on Wayland opens unnecessary > preview dialog on Chromium side, which is then followed by a similar > dialog on xdg-desktop-portal side. The Chromium dialog is useless on > Wayland, as it doesn't show anything. This is because Chromium doesn't > have access to screen content as in case of X11 session. To fix this, we > want to avoid showing the preview dialog in case we find that we run on > Wayland and only pick a screen or a window from the dialog that comes > from xdg-desktop-portal. > > This patch splits BaseCapturerPipeWire class, moving portal related code > into XdgPortalBase, which does all the DBus communication and which is > supposed to be reused by BaseCapturerPipeWire when the user confirms > the dialog from xdg-desktop-portal. The XdgPortalBase is extended to > support multiple calls at once, where each call is identified by Id. > > Relevant change on Chromium side will be in a different review. > > Bug: chromium:682122 > Change-Id: If8afd36da66231eb154cdc00114908ac897ee4cf > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160649 > Commit-Queue: Tommi <tommi@webrtc.org> > Reviewed-by: Tommi <tommi@webrtc.org> > Reviewed-by: Erik Språng <sprang@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#32342} TBR=mbonadei@webrtc.org,jamiewalch@chromium.org,tommi@webrtc.org,sprang@webrtc.org,tomas.popela@gmail.com,grulja@gmail.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:682122 Change-Id: I41518f795e34b84374bc8208b711cfeb0a070578 No-Try: True Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/187352 Commit-Queue: Guido Urdaneta <guidou@webrtc.org> Reviewed-by: Guido Urdaneta <guidou@webrtc.org> Cr-Commit-Position: refs/heads/master@{#32365}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.