| commit | d9b75bef5d0749ea94b31cedab0105c241938954 | [log] [tgz] |
|---|---|---|
| author | nisse <nisse@webrtc.org> | Mon Nov 16 00:54:07 2015 -0800 |
| committer | Commit bot <commit-bot@chromium.org> | Mon Nov 16 08:54:10 2015 +0000 |
| tree | d3da038c525a3a5769ab68a0e4171f761608f439 | |
| parent | 6f14be8df8b67feb480f55b3a41e2b8cd06a836d [diff] |
Fix a data race in the thread unit tests. The flag used in thread_unittest.cc:FunctorB is subject to a (mostly harmless) data race. In a tsan build, reproduce using out/Release/rtc_unittests --gtest_filter=AsyncInvokeTest.FireAndForget There are additional tsan warnings, not all deterministic, when running all the rtc_unittets: Some data races related to destructors, and a locking-order-inversion warning. Hence applying this patch does not make the unit tests tsan-clean. I should also add that this is my very first cl, so I'm not at all familiar with the process. Review URL: https://codereview.webrtc.org/1439613004 Cr-Commit-Position: refs/heads/master@{#10645}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.