commit 18ee330a34ba369faa54d13e508da88998a702f7
author Ben Murdoch <benm@google.com> Tue Jan 26 18:02:54 2010 +0000
committer Ben Murdoch <benm@google.com> Tue Jan 26 18:08:57 2010 +0000
tree a14388fcadaf9f142cf8ed8df0fb1f17c7709e7b
parent 9c3f8716aa3ce8ca612b4200c02a8530cfd599ba

Remove dead code attached to the Touch object. This is no longer called, and keeping a ref to a child frame can cause a crash during GC if the event is the last ref and causes the Frame to be destructed.

Change-Id: Ic41adfa3e8b4a901887c87b8196360947ef9692c

WebCore/dom/Touch.cpp

diff --git a/WebCore/dom/Touch.cpp b/WebCore/dom/Touch.cpp
index 41d5c19..4ea83da 100644
--- a/WebCore/dom/Touch.cpp
+++ b/WebCore/dom/Touch.cpp
@@ -55,11 +55,10 @@
 
 Touch::Touch(Frame* frame, EventTarget* target, unsigned identifier, 
         int screenX, int screenY, int pageX, int pageY)
-    : m_frame(frame)
-    , m_target(target)
+    : m_target(target)
     , m_identifier(identifier)
-    , m_clientX(pageX - contentsX(m_frame.get()))
-    , m_clientY(pageY - contentsY(m_frame.get()))
+    , m_clientX(pageX - contentsX(frame))
+    , m_clientY(pageY - contentsY(frame))
     , m_screenX(screenX)
     , m_screenY(screenY)
     , m_pageX(pageX)
@@ -67,16 +66,6 @@
 {
 }
 
-void Touch::updateLocation(int screenX, int screenY, int pageX, int pageY)
-{
-    m_clientX = pageX - contentsX(m_frame.get());
-    m_clientY = pageY - contentsY(m_frame.get());
-    m_screenX = screenX;
-    m_screenY = screenY;
-    m_pageX = pageX;
-    m_pageY = pageY;
-}
-
 } // namespace WebCore
 
 #endif

WebCore/dom/Touch.h

diff --git a/WebCore/dom/Touch.h b/WebCore/dom/Touch.h
index cf39faf..ceb8ae7 100644
--- a/WebCore/dom/Touch.h
+++ b/WebCore/dom/Touch.h
@@ -45,9 +45,6 @@
                 screenY, pageX, pageY));
     }
 
-    void updateLocation(int screenX, int screenY, int pageX, int pageY);
-
-    Frame* frame() const { return m_frame.get(); }
     EventTarget* target() const { return m_target.get(); }
     unsigned identifier() const { return m_identifier; }
     int clientX() const { return m_clientX; }
@@ -61,7 +58,6 @@
     Touch(Frame* frame, EventTarget* target, unsigned identifier,
             int screenX, int screenY, int pageX, int pageY);
 
-    RefPtr<Frame> m_frame;
     RefPtr<EventTarget> m_target;
     unsigned m_identifier;
     int m_clientX;