)]}' { "log": [ { "commit": "135ac53c7583c423fdf71da765280a51e96c1230", "tree": "550d619e7696cb5095448e6bbaf8d12a257cc126", "parents": [ "24b7b68d0302b8b95809ccd30118123a0396f02b", "7bdee0e3545a73d6d093e319505283e747cd260d" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Mon Feb 24 02:57:43 2025 -0800" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Feb 24 02:57:43 2025 -0800" }, "message": "Upgrade vboot_reference to ae6ceb20d5e2938a366e22c2a550a02772788825 am: 7bdee0e354\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/vboot_reference/+/3500730\n\nChange-Id: I366ed52559ab281674ecc1bd6a73c1df16cb3844\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "7bdee0e3545a73d6d093e319505283e747cd260d", "tree": "550d619e7696cb5095448e6bbaf8d12a257cc126", "parents": [ "e0435a50df215bde2148366267dd55df48e60add", "ae6ceb20d5e2938a366e22c2a550a02772788825" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Wed Feb 19 12:22:55 2025 +0000" }, "committer": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Wed Feb 19 12:22:55 2025 +0000" }, "message": "Upgrade vboot_reference to ae6ceb20d5e2938a366e22c2a550a02772788825\n\nThis project was upgraded with external_updater.\nUsage: tools/external_updater/updater.sh update external/vboot_reference\nFor more info, check https://cs.android.com/android/platform/superproject/main/+/main:tools/external_updater/README.md\n\nTest: TreeHugger\nChange-Id: I23b306fe65922ea250a74e31804509d2ea3dfab0\n" }, { "commit": "ae6ceb20d5e2938a366e22c2a550a02772788825", "tree": "4d7309523aa675955c0172992cb57601c3618251", "parents": [ "2dde4ce9badcfcff593ee765a1db57ae0d1c97fe" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Thu Feb 13 15:21:21 2025 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Feb 17 05:46:19 2025 -0800" }, "message": "Android.bp: Make crossystem default to /vendor partition\n\ncrossystem was intended to live on /vendor partition from the beginning.\nIncorrect option was applied making it /vendor optional and /system\ndefault. This CL fixes this issue.\n\nBRANCH\u003dNone\nBUG\u003dNone\nTEST\u003dBuild android image and see /vendor/bin/crossystem\n\nChange-Id: I8048da9ee6ca5e659d36cc8918833c7d1ce2c325\nSigned-off-by: Jakub Czapiga \u003cczapiga@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6264664\nReviewed-by: Konrad Adamczyk \u003ckonrada@google.com\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "2dde4ce9badcfcff593ee765a1db57ae0d1c97fe", "tree": "238bb2dcb70015771ffa53aedc9e71673024c3e8", "parents": [ "993e0bf7bdbc72919b5a227348f5cdf0e54d7257" ], "author": { "name": "Mauricio Faria de Oliveira", "email": "mfo@igalia.com", "time": "Wed Feb 12 10:39:25 2025 -0300" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Feb 14 10:33:03 2025 -0800" }, "message": "cgpt: repair: handle drive size expansion\n\nCurrently, if the drive size increases, \u0027cgpt repair\u0027 correctly\nupdates/moves the Secondary GPT header/entries to end of drive,\nbut it does _NOT_ update headers to reflect the new drive size.\n\nIt \u0027must\u0027 as per section 5.3.2 GPT Header of the UEFI spec [1]:\n\n Both the primary and backup GPTs must be valid before\n an attempt is made to grow the size of a physical volume.\n [...]\n As soon as the volume size is increased the backup GPT must be\n be moved to the end of the volume, and the primary and backup\n GPT Headers must be updated to reflect the new volume size.\n\nThat prevents resizing/growing a partition to new available space\n(as Last Usable LBA is not updated and used in valid range check),\nand incorrectly points to the old secondary GPT header in primary\n(as Alternate LBA is not updated).\n\nChange CgptRepair() to check for (only) the secondary header and\nentries modified (i.e., moved to end of drive) and Alternate LBA\nin the primary header being less than My LBA in secondary header\n(i.e., confirm secondary header moved), then update both headers.\n\nBUG\u003db:396007118\nTEST\u003d`cgpt show -v $DEV | grep -E \u0027Alternate LBA:|Last LBA:|Sec GPT\u0027`\nafter drive size expansion and `cgpt repair`, then resize partition\nto all new available space (described below); and `run_cgpt_tests.sh`.\nBRANCH\u003dnone\n\nBefore:\n```\n $ dd if\u003d/dev/zero of\u003ddrive.img bs\u003d512 count\u003d2048\n $ ./build/cgpt/cgpt create drive.img\n $ ./build/cgpt/cgpt add -b 34 -s $((2048-33-34)) -t data drive.img\n $ ./build/cgpt/cgpt show -v drive.img 2\u003e\u00261 \\\n | grep -E \u0027(Alternate LBA:|Last LBA:|Sec GPT|INVALID|Label)\u0027\n Alternate LBA: 2047\n Last LBA: 2014\n 34 1981 1 Label: \"\"\n 2015 32 Sec GPT table\n 2047 1 Sec GPT header\n\n $ dd if\u003d/dev/zero of\u003ddrive.img bs\u003d512 seek\u003d4096 count\u003d0\n $ ./build/cgpt/cgpt repair drive.img\n WARNING: Secondary GPT header is invalid\n Secondary Entries is updated.\n Secondary Header is updated.\n\n $ ./build/cgpt/cgpt add -b 34 -s $((4096-33-34)) -i 1 drive.img\n ERROR: Entry outside of valid region\n ERROR: -i 1 -b 34 -s 4029\n\n $ ./build/cgpt/cgpt show -v drive.img 2\u003e\u00261 \\\n | grep -E \u0027(Alternate LBA:|Last LBA:|Sec GPT|INVALID|Label)\u0027\n Alternate LBA: 2047\n Last LBA: 2014\n 34 1981 1 Label: \"\"\n 4063 32 Sec GPT table\n 4095 1 Sec GPT header\n```\nAfter:\n```\n $ dd if\u003d/dev/zero of\u003ddrive.img bs\u003d512 count\u003d2048\n $ ./build/cgpt/cgpt create drive.img\n $ ./build/cgpt/cgpt add -b 34 -s $((2048-33-34)) -t data drive.img\n $ ./build/cgpt/cgpt show -v drive.img 2\u003e\u00261 \\\n | grep -E \u0027(Alternate LBA:|Last LBA:|Sec GPT|INVALID|Label)\u0027\n Alternate LBA: 2047\n Last LBA: 2014\n 34 1981 1 Label: \"\"\n 2015 32 Sec GPT table\n 2047 1 Sec GPT header\n\n $ dd if\u003d/dev/zero of\u003ddrive.img bs\u003d512 seek\u003d4096 count\u003d0\n $ ./build/cgpt/cgpt repair drive.img\n WARNING: Secondary GPT header is invalid\n Secondary Entries is updated.\n Secondary Header is updated.\n Drive size expansion detected; headers update required.\n Primary Header updated.\n Secondary Header updated.\n\n $ ./build/cgpt/cgpt add -b 34 -s $((4096-33-34)) -i 1 drive.img\n\n $ ./build/cgpt/cgpt show -v drive.img 2\u003e\u00261 \\\n | grep -E \u0027(Alternate LBA:|Last LBA:|Sec GPT|INVALID|Label)\u0027\n Alternate LBA: 4095\n Last LBA: 4062\n 34 4029 1 Label: \"\"\n 4063 32 Sec GPT table\n 4095 1 Sec GPT header\n```\n\n[1] https://uefi.org/sites/default/files/resources/UEFI_Spec_Final_2.11.pdf\n\nChange-Id: Iee372277546a4f6b7ef53b4a16df4c93819af031\nSigned-off-by: Mauricio Faria de Oliveira \u003cmfo@igalia.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6258636\nReviewed-by: Tomasz Michalec \u003ctmichalec@google.com\u003e\nReviewed-by: Jakub \"Kuba\" Czapiga \u003cczapiga@google.com\u003e\nCommit-Queue: Jakub \"Kuba\" Czapiga \u003cczapiga@google.com\u003e\n" }, { "commit": "993e0bf7bdbc72919b5a227348f5cdf0e54d7257", "tree": "c31e0bed07c74a83277f8aaa4e1f7222200a6286", "parents": [ "3a37ae87f637c1d7fbb12924e4cd12d6124b793e" ], "author": { "name": "Mauricio Faria de Oliveira", "email": "mfo@igalia.com", "time": "Wed Feb 12 10:23:34 2025 -0300" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Feb 14 10:33:01 2025 -0800" }, "message": "cgpt: create: calculate Last Usable LBA in DriveLastUsableLBA()\n\nWe\u0027ll need the Last Usable LBA elsewhere, so move this into a function.\n\nBUG\u003dnone\nTEST\u003dCreate GPT with `cgpt create [ -D $SIZE ] $DEV` and check for same\nLast Usable LBA with `cgpt show [ -D $SIZE ]-v $DEV | grep \u0027Last LBA:\u0027`\nbefore/after changes.\nBRANCH\u003dnone\n\nChange-Id: I82e56b54bbbb676dd83c7eae27566072f80403d4\nSigned-off-by: Mauricio Faria de Oliveira \u003cmfo@igalia.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6258635\nCommit-Queue: Jakub \"Kuba\" Czapiga \u003cczapiga@google.com\u003e\nReviewed-by: Jakub \"Kuba\" Czapiga \u003cczapiga@google.com\u003e\nReviewed-by: Tomasz Michalec \u003ctmichalec@google.com\u003e\n" }, { "commit": "3a37ae87f637c1d7fbb12924e4cd12d6124b793e", "tree": "8357dcf3dff94bec63899d2332fb068dbaf933d8", "parents": [ "6caf4cd6225fcd1a636fd681970bd2221d63455c" ], "author": { "name": "Subrata Banik", "email": "subratabanik@google.com", "time": "Fri Feb 07 16:11:51 2025 +0530" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Feb 07 18:22:37 2025 -0800" }, "message": "firmware/2lib: Refactor ec_sync_phase1 for clarity\n\nThis commit refactors ec_sync_phase1 to directly call ec_sync_allowed\nfor EC sync prerequisite checks. This improves code organization and\nreadability.\n\nBUG\u003db:395038430\nTEST\u003dBuilt and booted google/fatcat.\n\nChange-Id: I4b78cb25238c0e606806238f9b08d569a24c387a\nSigned-off-by: Subrata Banik \u003csubratabanik@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6242479\nTested-by: Subrata Banik \u003csubratabanik@chromium.org\u003e\nCommit-Queue: Subrata Banik \u003csubratabanik@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "6caf4cd6225fcd1a636fd681970bd2221d63455c", "tree": "ffb385389c3ed76f0d7903d5b0474e65814e940e", "parents": [ "1f8153d95a931dca93f710531cdd333207c57982" ], "author": { "name": "Subrata Banik", "email": "subratabanik@google.com", "time": "Fri Feb 07 16:05:15 2025 +0530" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Feb 07 18:22:35 2025 -0800" }, "message": "firmware/2lib: Remove redundant EC sync check in recovery\n\nThis patch removes the redundant EC sync check in recovery mode.\nThe check is already performed by vb2api_ec_sync, the caller of\n`ec_sync_phase2`/`ec_sync_phase1`.\n\nThis change also allows ec_sync_allowed to be used by `ec_sync_phase1`\nto ensure EC sync prerequisites are met.\n\nBUG\u003db:395038430\nTEST\u003dBuilt and booted google/fatcat.\n\nChange-Id: If64f1c5c768c4e7ddbcbae54500ce69f5631a07b\nSigned-off-by: Subrata Banik \u003csubratabanik@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6242478\nCommit-Queue: Subrata Banik \u003csubratabanik@chromium.org\u003e\nTested-by: Subrata Banik \u003csubratabanik@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "1f8153d95a931dca93f710531cdd333207c57982", "tree": "0ca4d236c8a0be892ae920a160bd2761a1f476fb", "parents": [ "6f63b28162cd90215c8639aae6eb61a9d93394aa" ], "author": { "name": "Wai-Hong Tam", "email": "waihong@google.com", "time": "Thu Jan 30 14:36:18 2025 -0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jan 30 23:52:38 2025 -0800" }, "message": "scripts/image_signing/swap_ec_rw: Print the versions of the AP image\n\nTo avoid confusion when working with multiple files, print the\nAP image versions at the end.\n\nBUG\u003db:325886850\nTEST\u003dmake runtestscripts\nBRANCH\u003dnone\n\nChange-Id: Id7b9e0d3555f91b8a4a4c77c9962aeeca224b53d\nSigned-off-by: Wai-Hong Tam \u003cwaihong@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6218283\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "6f63b28162cd90215c8639aae6eb61a9d93394aa", "tree": "241216d1001d9ccd05a2b00fdd6f74b4515d3bad", "parents": [ "177c0582ad4fcc8455c2f88d734d9d5907224380" ], "author": { "name": "Raul E Rangel", "email": "rrangel@google.com", "time": "Fri Jan 24 10:30:22 2025 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jan 24 18:13:26 2025 -0800" }, "message": "Makefile: Optimize dirname invocation\n\nInvoking `dirname` for every single source file is slow. This change\nswitches to the `-exec dirname {} +` variant that passes multiple args\nto `dirname`. With this change I no longer see `dirname` in `top` when\nwatching a build.\n\nBUG\u003db:392102378\nBRANCH\u003dnone\nTEST\u003demerge-brya coreboot\n\nChange-Id: I786b91df9516c70b34ff534c4144e228104bea2d\nSigned-off-by: Raul E Rangel \u003crrangel@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6198688\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nCommit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "177c0582ad4fcc8455c2f88d734d9d5907224380", "tree": "69e2169b972abcfdd59d8cca866f81de662033bb", "parents": [ "621899d6e89f39b7e1ecb8102fe8288b41ddc06b" ], "author": { "name": "Raul E Rangel", "email": "rrangel@google.com", "time": "Fri Jan 24 10:16:39 2025 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Jan 24 18:13:25 2025 -0800" }, "message": "Makefile: Remove $(shell) invocations from CFLAGS\n\nCFLAGS is a recursive variable, meaning it needs to be re-evaluated\nevery time it is referenced. By adding a `$(shell)` into CFLAGS we force\n`make` to invoke the shell commands every single time. This results in\na lot of unnecessary pkg-config calls.\n\nI straced the process to confirm the fix:\n\nBefore:\n```\n$ grep pkg-config /tmp/coreboot.strace| wc -l\n102973\n```\n\nAfter:\n```\n$ grep pkg-config /tmp/coreboot.fast.strace| wc -l\n3937\n```\n\nThis shaves off ~30 - 60 seconds on my machine when building brya.\n\nBUG\u003db:392102378\nBRANCH\u003dnone\nTEST\u003demerge-brya coreboot\n\nChange-Id: Ib23f1821e64f491e1a7929a8d6812c23f6ec85ad\nSigned-off-by: Raul E Rangel \u003crrangel@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6198687\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nCommit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "621899d6e89f39b7e1ecb8102fe8288b41ddc06b", "tree": "90a0fa565ea2b17c9d044bc529e2d96842769d30", "parents": [ "993ef3126919613ef9c69dfdcfda782332b6de8b" ], "author": { "name": "Grzegorz Bernacki", "email": "bernacki@google.com", "time": "Wed Jan 15 12:37:18 2025 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jan 16 23:18:00 2025 -0800" }, "message": "vboot: modify GptNextKernelEntry function\n\nThe GptNextKernelEntry function returns the start \u0026 size of the boot\npartition. These data are required for booting ChromeOS, but to boot\nAndroid we need a partition suffix. This change modifies\nGptNextKernelEntry, so it returns a pointer to GptEntry now. It will\nallow to determine which OS is going to be booted by entry type GUID\nand simplify fetching data required for a given OS.\n\nBUG\u003db:384095358\nTEST\u003d\u0027make runtest\u0027 and verify build ChromeOS on redrix\nBRANCH\u003dmain\n\nChange-Id: I6c3e4555db9f429cd7bcd96e29c8ab661330de55\nSigned-off-by: Grzegorz Bernacki \u003cbernacki@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6169943\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "993ef3126919613ef9c69dfdcfda782332b6de8b", "tree": "618ab52b49004528722c24cd52fa67bac64491cc", "parents": [ "7fdca50ac14f2358aae760d21c07adfb3285020a" ], "author": { "name": "Benjamin Shai", "email": "bshai@google.com", "time": "Thu Jan 16 10:30:06 2025 -0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jan 16 15:47:55 2025 -0800" }, "message": "uefi: only check for key existence in local key mode\n\nWhen the key is a pkcs11 key, we shouldn\u0027t check for the existence\nof the private key on disk.\n\nBUG\u003db:372702794\nTEST\u003dManual\n\nChange-Id: Icf0097c9dfd7b36a40581f19c6066f2a3c0309a8\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6180557\nTested-by: Benjamin Shai \u003cbshai@google.com\u003e\nCommit-Queue: Benjamin Shai \u003cbshai@google.com\u003e\nReviewed-by: Madeleine Hardt \u003chardtmad@google.com\u003e\nReviewed-by: Nicholas Bishop \u003cnicholasbishop@google.com\u003e\n" }, { "commit": "7fdca50ac14f2358aae760d21c07adfb3285020a", "tree": "df60604293d91fc0e64fbf1d0ddb43764223b0a6", "parents": [ "2e00eae8f9a0c07abad9243c564b1b7339ad9e09" ], "author": { "name": "Grzegorz Bernacki", "email": "bernacki@google.com", "time": "Tue Jan 14 12:13:18 2025 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jan 16 04:15:57 2025 -0800" }, "message": "Introduce new entry type for vbmeta\n\nBUG\u003db:384095358\nTEST\u003duse cgpt to create new type of partition\nBRANCH\u003dmain\n\nChange-Id: Ic68806e3b3a85e52cd6cf5deadc69aadf2625204\nSigned-off-by: Grzegorz Bernacki \u003cbernacki@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6174918\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-by: Raul Rangel \u003crrangel@chromium.org\u003e\n" }, { "commit": "2e00eae8f9a0c07abad9243c564b1b7339ad9e09", "tree": "9b6158f6666852670412ed17d5453c42630cb3b9", "parents": [ "7e5bda8a8210e4b50fb80cf890a20bd9e711648b" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Mon Jan 13 12:31:55 2025 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Jan 13 19:11:07 2025 -0800" }, "message": "firmware/2lib: Add a log for try_count used up\n\nFor bugs such as b/385224631 (where the device fails to boot up),\nshowing a warning log when the try_count is used up might help for\ndebugging.\n\nBUG\u003dnone\nTEST\u003demerge-geralt libpayload\nBRANCH\u003dnone\n\nChange-Id: I295cefc2707534099e82ff0164921c0a3d1bfe5f\nSigned-off-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6171750\nReviewed-by: Kapil Porwal \u003ckapilporwal@chromium.org\u003e\nReviewed-by: Subrata Banik \u003csubratabanik@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "7e5bda8a8210e4b50fb80cf890a20bd9e711648b", "tree": "52ecef5f6bf4ddaa502446a4593534249b35176b", "parents": [ "3498c54d26a9bf7c898ef4b69c507ffa4e6dc46b" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Fri Jan 10 14:47:11 2025 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Jan 13 04:38:30 2025 -0800" }, "message": "futility: updater: Increase try count from 13 to 17\n\nThe current try count is 13 for two reasons:\n\n1. As explained in CL:5690663, Rex needs 11 reboots in the worst case.\n2. In CL:5970064, we added an extra 2 boots to mitigate the problem of\n abrupt user poweroff during firmware update process.\n\nHowever, Nissa needs 13 reboots in the worst case.\n\n- Boot 0: Initial reboot with CSE in RW. To allow CSE update, reboot to\n switch to CSE RO.\n- Boot 1: Update CSE RW. Reboot to switch to CSE RW.\n- Boot 2: GSC needs update. Reset GSC to switch to the other partition.\n- Boot 3: CSE is back in RO due to GSC reset. Reboot to switch to RW.\n- Boot 4: EC needs update. Reboot to EC RO to allow EC sync.\n- Boot 5: CSE is back in RO due to EC reset. Reboot to switch to RW.\n- Boot 6: Attempt to perform EC sync, but need display to show the EC\n sync screen. Reboot to init display.\n- Boot 7: Perform EC sync. Under EFS2 NO_BOOT mode, reboot to EC RO to\n allow jumping to RW.\n- Boot 8: CSE is back in RO due to EC reset. Reboot to switch to RW.\n- Boot 9: Perform auxfw sync and reboot to EC RO.\n- Boot 10: CSE is back in RO due to EC reset. Reboot to switch to RW.\n- Boot 11: Everything is updated, but need to reboot again to unset\n display.\n- Boot 12: Boot to kernel, finally!\n\nThe only difference between Nissa and Rex is the display init. On Rex,\nthe display is always initialized for the splash screen. On Nissa, 2\nextra reboots are needed to enable and disable display, respectively.\n\nIn addition, the 2 boots reserved for poweroff mitigation are actually\nnot enough, because after the abrupt user poweroff, the CSE will go back\nto RO. For example, if the poweroff happens in Boot 9 (before auxfw\nsync), then the device will go back to Boot 8, resulting in 2 extra\nreboots.\n\nTherefore, to allow 2 cases of abrupt poweroff, we will need extra 4\nboots in the try count. Together with Nissa\u0027s worst-case scenario, we\nwill need an initial try count as large as 17.\n\nBUG\u003db:385224631\nTEST\u003dnone\nBRANCH\u003dnone\n\nChange-Id: I4503ef2f519f5368a4697861d1dffac5fbe1cfb5\nSigned-off-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6164433\nReviewed-by: Subrata Banik \u003csubratabanik@chromium.org\u003e\nTested-by: Subrata Banik \u003csubratabanik@chromium.org\u003e\nCommit-Queue: Subrata Banik \u003csubratabanik@chromium.org\u003e\n" }, { "commit": "3498c54d26a9bf7c898ef4b69c507ffa4e6dc46b", "tree": "5c65d75acab28069e6c310cefc40bf06f0b301fb", "parents": [ "c3f20ccfcf304808300fff2e0d9191ca15d9116c" ], "author": { "name": "Benjamin Shai", "email": "bshai@google.com", "time": "Thu Jan 09 10:45:54 2025 -0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jan 09 16:20:19 2025 -0800" }, "message": "signing: add condition for flexor\n\nLooking at `ImageType` enum in the proto def, we use a type\n`IMAGE_TYPE_FLEXOR_KERNEL` for uefi signing. The old signing\ninstructions would translate that to uefi, but new signing just strips\nthe prefix and passes through `flexor_kernel`. Instead of having to do\nmapping, let\u0027s just make all the code consistent and easier to reason\nabout.\n\nBUG\u003db:372702794\nTEST\u003dNone\n\nChange-Id: I90c0bfc9afe0daea23a3f4e2fc0cac6f88779fe5\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6165423\nReviewed-by: George Engelbrecht \u003cengeg@google.com\u003e\nCommit-Queue: ChromeOS Auto Retry \u003cchromeos-auto-retry@chromeos-bot.iam.gserviceaccount.com\u003e\nReviewed-by: Madeleine Hardt \u003chardtmad@google.com\u003e\nTested-by: Benjamin Shai \u003cbshai@google.com\u003e\n" }, { "commit": "c3f20ccfcf304808300fff2e0d9191ca15d9116c", "tree": "9e8b2b292ca420e1a8c9c98bab579ae4d69e5687", "parents": [ "3f94e2c7ed58c4e67d6e7dc6052ec615dbbb9bb4" ], "author": { "name": "Shou-Chieh Hsu", "email": "shouchieh@google.com", "time": "Thu Jan 09 09:25:29 2025 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Jan 09 07:20:59 2025 -0800" }, "message": "Makefile: Export swap_ec_rw script to OS image\n\nThe script could be useful for partners during device development\nwithout having complete ChromeOS SDK.\n\nBUG\u003db:388643063\nTEST\u003dbuild-packages \u0026\u0026 build-images \u0026\u0026\n check /usr/share/vboot/bin/swap_ec_rw exists\nBRANCH\u003dnone\n\nChange-Id: I8d9271fb17faf79f2d23e41a07ca36d20cf2953f\nSigned-off-by: Shou-Chieh Hsu \u003cshouchieh@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6162156\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "24b7b68d0302b8b95809ccd30118123a0396f02b", "tree": "445ff9c8bdd0131ac0c5565db9119ad588173e75", "parents": [ "84a91f7ed4a6ba41cb5988f5b4bb7be0c4ce0bef", "8fdd8424f346fe69ca528d29c1c708271ca38142" ], "author": { "name": "Xin Li", "email": "delphij@google.com", "time": "Fri Dec 20 13:39:43 2024 -0800" }, "committer": { "name": "Xin Li", "email": "delphij@google.com", "time": "Fri Dec 20 13:39:43 2024 -0800" }, "message": "Empty merge ab/12770256 into aosp-main-future\n\nMerged-In: Ice6da5d3d2961b8fcf1b47882a7a5bc01618e14c\nChange-Id: I0048ae440739d8d40c84e02438e5bfb7268cfd1a\n" }, { "commit": "84a91f7ed4a6ba41cb5988f5b4bb7be0c4ce0bef", "tree": "445ff9c8bdd0131ac0c5565db9119ad588173e75", "parents": [ "caa147826dfdaaaf3540cd3b50ce2a5a074fbeb0", "e0435a50df215bde2148366267dd55df48e60add" ], "author": { "name": "Sadaf Ebrahimi", "email": "sadafebrahimi@google.com", "time": "Thu Dec 19 11:06:07 2024 -0800" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Dec 19 11:06:07 2024 -0800" }, "message": "Add janitors to the OWNERS file am: e0435a50df\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/vboot_reference/+/3424199\n\nChange-Id: I85bc45664b691ff6e79a56c1f4980e4609bb9057\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "3f94e2c7ed58c4e67d6e7dc6052ec615dbbb9bb4", "tree": "5e90bceae43ffb05372312703105959c1bdca9a1", "parents": [ "44c19d1893aa48e0e2abe32023c6e34e75d173be" ], "author": { "name": "Carlos López", "email": "carlos.lopez@openchip.com", "time": "Fri Dec 13 17:08:29 2024 +0100" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Dec 18 16:14:28 2024 -0800" }, "message": "Makefile: Allow cross-compilation for RISC-V\n\nAllow setting FIRMWARE_ARCH\u003driscv to build vboot for the RISC-V\narchitecture. Note that building for 32-bit RISC-V requires additional\nCFLAGS.\n\nChange-Id: I5c72900494f465fb625f315f550849f5b69f3cca\nSigned-off-by: Carlos López \u003ccarlos.lopez@openchip.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6091368\nTested-by: Julius Werner \u003cjwerner@chromium.org\u003e\nCommit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "e0435a50df215bde2148366267dd55df48e60add", "tree": "445ff9c8bdd0131ac0c5565db9119ad588173e75", "parents": [ "dd9042aca8cb57fc93e40201542ffe3677e14b99" ], "author": { "name": "Sadaf Ebrahimi", "email": "sadafebrahimi@google.com", "time": "Wed Dec 18 20:43:31 2024 +0000" }, "committer": { "name": "Sadaf Ebrahimi", "email": "sadafebrahimi@google.com", "time": "Wed Dec 18 20:43:31 2024 +0000" }, "message": "Add janitors to the OWNERS file\n\nTest: TreeHugger\nChange-Id: I47122e0f479742dd9204e56ee4dd446b959e4c06\n" }, { "commit": "caa147826dfdaaaf3540cd3b50ce2a5a074fbeb0", "tree": "9fd31642388e3a05f0d5562a6cc50b2d852d7530", "parents": [ "4a06abd41480a4b200b350e66955e80c65839e8c", "dd9042aca8cb57fc93e40201542ffe3677e14b99" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Wed Dec 18 07:05:42 2024 -0800" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Dec 18 07:05:42 2024 -0800" }, "message": "Upgrade vboot_reference to 44c19d1893aa48e0e2abe32023c6e34e75d173be am: dd9042aca8\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/vboot_reference/+/3421839\n\nChange-Id: Ic574769b1ced441c19fd2a715c98f3bdb79c155c\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "dd9042aca8cb57fc93e40201542ffe3677e14b99", "tree": "9fd31642388e3a05f0d5562a6cc50b2d852d7530", "parents": [ "4a06abd41480a4b200b350e66955e80c65839e8c", "44c19d1893aa48e0e2abe32023c6e34e75d173be" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Wed Dec 18 13:29:32 2024 +0000" }, "committer": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Wed Dec 18 13:29:32 2024 +0000" }, "message": "Upgrade vboot_reference to 44c19d1893aa48e0e2abe32023c6e34e75d173be\n\nThis project was upgraded with external_updater.\nUsage: tools/external_updater/updater.sh update external/vboot_reference\nFor more info, check https://cs.android.com/android/platform/superproject/main/+/main:tools/external_updater/README.md\n\nTest: TreeHugger\nChange-Id: I292cc07f90dbbe6a07959008eff0f459ec0dd4dd\n" }, { "commit": "44c19d1893aa48e0e2abe32023c6e34e75d173be", "tree": "a404b0f89b6404f8cb5ef39b337545b4f33172e3", "parents": [ "d1813a4666d7de37fa210a2197bf6ce8cf56a3d5" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Thu Dec 12 17:15:23 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Dec 18 04:12:19 2024 -0800" }, "message": "futility/updater: Remove obsolete write protection help URL\n\nBRANCH\u003dmain\nBUG\u003dNone\nTEST\u003dNone\n\nChange-Id: I8342eb6d51482baf9a7d5c47905c67bae1a03723\nSigned-off-by: Jakub Czapiga \u003cczapiga@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6092872\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nTested-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Hsuan Ting Chen \u003croccochen@chromium.org\u003e\n" }, { "commit": "d1813a4666d7de37fa210a2197bf6ce8cf56a3d5", "tree": "9dcd94e05727e4d13f1269b52e930598f6361e64", "parents": [ "2935820d404e5ce5e4247b28a9056323a6fbf8df" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Thu Dec 12 17:08:38 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Dec 17 08:21:13 2024 -0800" }, "message": "futility: Add shell-parseable manifest format\n\nAdd --parseable-manifest options to print manifest in `futility show -P`\nformat.\nExample output:\nlink::host::image::image.bin\nlink::host::versions::ro::Google_Link.2695.1.133\nlink::host::versions::rw::Google_Link.2695.1.133\nlink::host::keys::recovery::7e74cd6d66f361da068c0419d2e0946b4d091e1c\nlink::host::keys::root::7b5c520ceabce86f13e02b7ca363cfb509fc5b98\n\nBRANCH\u003dmain\nBUG\u003db:356051231, b:370889644\nTEST\u003dfutility update --parseable-manifest -a \"${FWPATH}\"\nTEST\u003dsudo FEATURES\u003d\"test\" emerge vboot_reference\n\nChange-Id: Ib4016095048ae8c306da45cd49e18da20ea2b549\nSigned-off-by: Jakub Czapiga \u003cczapiga@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6092873\nReviewed-by: Konrad Adamczyk \u003ckonrada@google.com\u003e\nCommit-Queue: Konrad Adamczyk \u003ckonrada@google.com\u003e\n" }, { "commit": "4a06abd41480a4b200b350e66955e80c65839e8c", "tree": "8626a261074db708f79d77d3335f3c6b5d5a7b2d", "parents": [ "191cf10fba8548d88bf76c9d2a8c8e2ff4341405", "da45c5ac5a90ea3e25b304b7637eb49407af523b" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Tue Dec 10 17:57:10 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Dec 10 17:57:10 2024 +0000" }, "message": "Upgrade vboot_reference to 2935820d404e5ce5e4247b28a9056323a6fbf8df am: da45c5ac5a\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/vboot_reference/+/3401522\n\nChange-Id: I9bfd43030caca45543dd7cf84f34e5c300cf7aff\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "da45c5ac5a90ea3e25b304b7637eb49407af523b", "tree": "8626a261074db708f79d77d3335f3c6b5d5a7b2d", "parents": [ "191cf10fba8548d88bf76c9d2a8c8e2ff4341405", "2935820d404e5ce5e4247b28a9056323a6fbf8df" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Tue Dec 10 15:06:13 2024 +0000" }, "committer": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Tue Dec 10 15:06:14 2024 +0000" }, "message": "Upgrade vboot_reference to 2935820d404e5ce5e4247b28a9056323a6fbf8df\n\nThis project was upgraded with external_updater.\nUsage: tools/external_updater/updater.sh update external/vboot_reference\nFor more info, check https://cs.android.com/android/platform/superproject/main/+/main:tools/external_updater/README.md\n\nTest: TreeHugger\nChange-Id: I40fd6679fbc53283e15ada50b7a03ebdd943cca6\n" }, { "commit": "2935820d404e5ce5e4247b28a9056323a6fbf8df", "tree": "00edda368ca53b7e022695a5d54882b111393451", "parents": [ "c57a588f8029ac83675349e75b539ecdc4bcd280" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Fri Dec 06 14:00:36 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Dec 10 14:06:02 2024 +0000" }, "message": "vboot.rc: Mount tmpfs with SELinux context\n\nMount tmpfs with SELinux context of firmware tool.\nDepends on ag/29952894.\n\nBRANCH\u003dNone\nBUG\u003db:382654099\nTEST\u003dupdate-device -f\n\nChange-Id: Id74dfb20b9ea62861f8a6a5ae2e96ffe46a2a2ea\nSigned-off-by: Jakub Czapiga \u003cczapiga@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6074679\nReviewed-by: Konrad Adamczyk \u003ckonrada@google.com\u003e\n" }, { "commit": "c57a588f8029ac83675349e75b539ecdc4bcd280", "tree": "63efb9e330365134ca0071b5f9d32a442721c7f6", "parents": [ "3ff18c08ee7d6aa005eaa9e10db0c34a1c4d3be7" ], "author": { "name": "Julius Werner", "email": "jwerner@chromium.org", "time": "Thu Dec 05 16:10:19 2024 -0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sat Dec 07 06:42:42 2024 +0000" }, "message": "crossystem: Change cros_debug to rely on mainfw_type, not devsw_boot\n\ncros_debug?1 is true either when the kernel command line indicates that\nwe\u0027re running a developer image, or when devsw_boot indicates that the\ndeveloper switch is on. It is generally used to enable insecure\ndebugging features that we do not want to be available in secure mode.\n\nUnfortunately, devsw_boot is not the best way to test for this. It\nreflects the raw state of the developer switch and returns true\nregardless of boot mode (e.g. also in recovery mode). This means that\ncros_debug?1 cannot be relied upon to enable debug features in recovery\nimages because their initramfs environment is supposed to remain secure\neven if the developer switch is on.\n\nmainfw_type better reflects what we want here, since it will always be\n`recovery` in recovery mode and only return `developer` when booting\nfrom the developer screen. This patch changes cros_debug to test this\ninstead so it can be reliably used even in recovery contexts.\n\nBRANCH\u003dnone\nBUG\u003db:382540412\nTEST\u003dBooted CoachZ in secure, developer, recovery and dev+rec modes,\nconfirmed that cros_debug?1 always reflects the expected state.\n\nChange-Id: I5bd4ca2da081a7ed125a002a72d99f6ee4444715\nSigned-off-by: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6073625\nReviewed-by: Jae Hoon Kim \u003ckimjae@chromium.org\u003e\nOwners-Override: Jae Hoon Kim \u003ckimjae@chromium.org\u003e\n" }, { "commit": "3ff18c08ee7d6aa005eaa9e10db0c34a1c4d3be7", "tree": "4af6761020f487af5724f918fc61f1405a13be55", "parents": [ "dfd2b7c7404edc2bcf977fde32a514024ead1353" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Mon Dec 02 04:07:47 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Dec 02 08:40:43 2024 +0000" }, "message": "Android.bp: Remove host_supported for crossystem\n\nThe crossystem tool is not needed on the host. Remove host_supported for\nit.\n\nBUG\u003dnone\nTEST\u003dmmm external/vboot_reference # From Android tree\nBRANCH\u003dnone\n\nChange-Id: Id9caeeec6df742a5625049d6af4572b9637a79ad\nSigned-off-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6055499\nCommit-Queue: Jakub Czapiga \u003cczapiga@google.com\u003e\nReviewed-by: Jakub Czapiga \u003cczapiga@google.com\u003e\n" }, { "commit": "dfd2b7c7404edc2bcf977fde32a514024ead1353", "tree": "21a6457ca9c3dde06bb8ea5c6dff563dad0c78e1", "parents": [ "f8eb37d149352190a2634fb46891e39881434322" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Thu Nov 28 00:36:44 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Dec 02 08:40:41 2024 +0000" }, "message": "Android.bp: Remove unused static libraries for firmware builds\n\nStatic libraries tlcl.a and vboot_fw.a are used only for firmware\nbuilds. As userspace tools don\u0027t need them, remove them.\n\nBUG\u003dnone\nTEST\u003dmmm external/vboot_reference # From Android tree\nBRANCH\u003dnone\n\nChange-Id: I37bd2a3ae3a27f05aa2b895571ba08bb7db45480\nSigned-off-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6055516\nReviewed-by: Jakub Czapiga \u003cczapiga@google.com\u003e\nCommit-Queue: Jakub Czapiga \u003cczapiga@google.com\u003e\n" }, { "commit": "f8eb37d149352190a2634fb46891e39881434322", "tree": "6d80623b4151abb08d9eec1bfdaff95f7ed97762", "parents": [ "0d49b8fdf002fa9cfa573ca1509ed8a1a0cf26d5" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Thu Nov 28 00:39:10 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Nov 28 04:38:10 2024 +0000" }, "message": "Makefile: Drop vboot_fw.a dependency for futility\n\nThe futility binary is linked with libvboot_util.a, which already\ncontains all the objects in vboot_fw.a. Therefore, drop the unnecessary\ndependency vboot_fw.a for futility.\n\nBUG\u003dnone\nTEST\u003dmake futil\nBRANCH\u003dnone\n\nChange-Id: I2f5a6d032bfd2807797f2effa9765824dcd233c0\nSigned-off-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/6055498\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "8fdd8424f346fe69ca528d29c1c708271ca38142", "tree": "86f84f5fa66ed5ce42f20f4687f638682318a9c9", "parents": [ "01f578167b6089d40f95355dc92cee9d9930ee71", "191cf10fba8548d88bf76c9d2a8c8e2ff4341405" ], "author": { "name": "Grzegorz Bernacki", "email": "bernacki@google.com", "time": "Mon Nov 18 10:27:48 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Nov 18 10:27:48 2024 +0000" }, "message": "Upgrade vboot_reference to 0d49b8fdf002fa9cfa573ca1509ed8a1a0cf26d5 am: e89c16d8a8 am: 191cf10fba\n\nOriginal change: undetermined\n\nChange-Id: I70da973fad19f1c9c1934c08797e841161e2fecc\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "191cf10fba8548d88bf76c9d2a8c8e2ff4341405", "tree": "86f84f5fa66ed5ce42f20f4687f638682318a9c9", "parents": [ "bc7dbe278bc3b7a4fcc16efeb72590d689af9bdb", "e89c16d8a81380300f20893b44870e120a8578ef" ], "author": { "name": "Grzegorz Bernacki", "email": "bernacki@google.com", "time": "Mon Nov 18 09:55:19 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Nov 18 09:55:19 2024 +0000" }, "message": "Upgrade vboot_reference to 0d49b8fdf002fa9cfa573ca1509ed8a1a0cf26d5 am: e89c16d8a8\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/vboot_reference/+/3345073\n\nChange-Id: I13fa636bc1a1c8afbf824ef7ce61fdaff6ef3483\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "e89c16d8a81380300f20893b44870e120a8578ef", "tree": "86f84f5fa66ed5ce42f20f4687f638682318a9c9", "parents": [ "f1ba4a428d4f18afc41bc61ee2b4d2760c337899", "0d49b8fdf002fa9cfa573ca1509ed8a1a0cf26d5" ], "author": { "name": "Grzegorz Bernacki", "email": "bernacki@google.com", "time": "Wed Nov 13 07:56:20 2024 +0000" }, "committer": { "name": "Grzegorz Bernacki", "email": "bernacki@google.com", "time": "Wed Nov 13 07:56:21 2024 +0000" }, "message": "Upgrade vboot_reference to 0d49b8fdf002fa9cfa573ca1509ed8a1a0cf26d5\n\nThis project was upgraded with external_updater.\nUsage: tools/external_updater/updater.sh update external/vboot_reference\nFor more info, check https://cs.android.com/android/platform/superproject/main/+/main:tools/external_updater/README.md\n\nTest: TreeHugger\nChange-Id: I50a18a0a8d169ec783fffd9ee38a25998ccbafff\n" }, { "commit": "0d49b8fdf002fa9cfa573ca1509ed8a1a0cf26d5", "tree": "bc66afeccafcef256a1bf61cc0f29b62e7bfd81d", "parents": [ "1f7ca823da09f6c8cc451091a532b0cd60d90c34" ], "author": { "name": "Benjamin Shai", "email": "bshai@google.com", "time": "Tue Nov 05 23:32:37 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Nov 07 21:34:58 2024 +0000" }, "message": "recovery_kernel: add signing type recovery_kernel\n\nTaking as an input a recovery kernel, sign it with the recovery key (and\nmake sure to handle the old recovery keys tagged v1 too).\n\nBUG\u003db:371248380\nTEST\u003dmanual\nBRANCH\u003dNone\n\nChange-Id: I0631f9060bc5943c384f6b128a4d2389ba29dee0\nSigned-off-by: Benjamin Shai \u003cbshai@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5996750\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nCommit-Queue: ChromeOS Auto Runner \u003cchromeos-auto-runner@chromeos-bot.iam.gserviceaccount.com\u003e\n" }, { "commit": "1f7ca823da09f6c8cc451091a532b0cd60d90c34", "tree": "77894abd27a8e59f405779e3ba0db883aa086a29", "parents": [ "3662103165a35b422552e24aeb5af0b8ec051cb6" ], "author": { "name": "Tomasz Michalec", "email": "tmichalec@google.com", "time": "Thu Oct 10 11:56:45 2024 +0200" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Nov 07 11:59:43 2024 +0000" }, "message": "gpt_misc: Return uint64_t from GptGetEntrySize functions\n\nChange GptGetEntrySizeBytes and GptGetEntrySizeLba return type to\nuint64_t to prevent overflows for partitions with large size.\n\nBUG\u003dNone\nTEST\u003dPrint partition size using fastboot getvar all\nBRANCH\u003dmain\n\nChange-Id: I9bb5adcd727a350839638312dc97db3751d30342\nSigned-off-by: Tomasz Michalec \u003ctmichalec@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5922816\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "01f578167b6089d40f95355dc92cee9d9930ee71", "tree": "47847ac432497db06c4f596594ce6503df9945d2", "parents": [ "375e6f703b55b78bbed7315b2a1a0df8e5568d4a", "bc7dbe278bc3b7a4fcc16efeb72590d689af9bdb" ], "author": { "name": "Treehugger Robot", "email": "android-test-infra-autosubmit@system.gserviceaccount.com", "time": "Mon Nov 04 08:14:32 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Nov 04 08:14:32 2024 +0000" }, "message": "Merge \"Upgrade vboot_reference to 3662103165a35b422552e24aeb5af0b8ec051cb6\" into main am: f1ba4a428d am: bc7dbe278b\n\nOriginal change: undetermined\n\nChange-Id: I8cc3764d23a480b0c1987d63e121fcb7a1babaaf\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "bc7dbe278bc3b7a4fcc16efeb72590d689af9bdb", "tree": "47847ac432497db06c4f596594ce6503df9945d2", "parents": [ "6f7d9d03e39e9cfe446918282bdae74463fb318e", "f1ba4a428d4f18afc41bc61ee2b4d2760c337899" ], "author": { "name": "Treehugger Robot", "email": "android-test-infra-autosubmit@system.gserviceaccount.com", "time": "Mon Nov 04 07:59:53 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Nov 04 07:59:53 2024 +0000" }, "message": "Merge \"Upgrade vboot_reference to 3662103165a35b422552e24aeb5af0b8ec051cb6\" into main am: f1ba4a428d\n\nOriginal change: undetermined\n\nChange-Id: I0d4fe9628b6e5371cd7e2bac1f1e3a7dd553c88e\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "f1ba4a428d4f18afc41bc61ee2b4d2760c337899", "tree": "47847ac432497db06c4f596594ce6503df9945d2", "parents": [ "dbcfe4c509ef4695d23c75697e803b59b9ca97f2", "7c674c36d380b054e11500498152b4ff482b9dce" ], "author": { "name": "Treehugger Robot", "email": "android-test-infra-autosubmit@system.gserviceaccount.com", "time": "Mon Nov 04 07:39:15 2024 +0000" }, "committer": { "name": "Gerrit Code Review", "email": "noreply-gerritcodereview@google.com", "time": "Mon Nov 04 07:39:15 2024 +0000" }, "message": "Merge \"Upgrade vboot_reference to 3662103165a35b422552e24aeb5af0b8ec051cb6\" into main" }, { "commit": "7c674c36d380b054e11500498152b4ff482b9dce", "tree": "614e0a87fdac4ea84ddb6da753d24fb499e0269e", "parents": [ "179cd4aa6f7cbb69f1d7622d69bccd7f043786ff", "3662103165a35b422552e24aeb5af0b8ec051cb6" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Thu Oct 31 20:55:49 2024 +0000" }, "committer": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Thu Oct 31 20:55:49 2024 +0000" }, "message": "Upgrade vboot_reference to 3662103165a35b422552e24aeb5af0b8ec051cb6\n\nThis project was upgraded with external_updater.\nUsage: tools/external_updater/updater.sh update external/vboot_reference\nFor more info, check https://cs.android.com/android/platform/superproject/main/+/main:tools/external_updater/README.md\n\nTest: TreeHugger\nChange-Id: I85a450c3dfcdfa5921312c25cc6d67ea7d04ec9c\n" }, { "commit": "3662103165a35b422552e24aeb5af0b8ec051cb6", "tree": "919af3eca9d197c2a9f9f1c54289b39adb6353fe", "parents": [ "26e8011fd51765457a628c3f5317c99e8b485973" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Thu Oct 31 12:57:49 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Oct 31 16:53:36 2024 +0000" }, "message": "Reland \"host/lib/flashrom: Use flashrom provided in PATH\"\n\nThis reverts commit 38f9c255d31df24a4cc08334846ea2e6a1df4b36.\n\nReason for revert: Fixed by crrev/c/5915176\n\nOriginal change\u0027s description:\n\u003e Revert \"host/lib/flashrom: Use flashrom provided in PATH\"\n\u003e\n\u003e This reverts commit 24fd715c90e89df1a90191c8ee1d3d78a29af758.\n\u003e\n\u003e Reason for revert: Potentially break b/370374826\n\u003e\n\u003e Original change\u0027s description:\n\u003e \u003e host/lib/flashrom: Use flashrom provided in PATH\n\u003e \u003e\n\u003e \u003e Remove `/usr/sbin` path prefix from FLASHROM_EXEC_NAME path.\n\u003e \u003e The cbfstool is called this way, so there is no need to have differing\n\u003e \u003e requirements for other utility which needs to be provided anyway.\n\u003e \u003e\n\u003e \u003e BUG\u003db:369294243, b:369290629\n\u003e \u003e BRANCH\u003dNone\n\u003e \u003e TEST\u003dm; adb shell crossystem dev_boot_altfw\u003d1\n\u003e \u003e\n\u003e \u003e Change-Id: Iff9fcfb8b40287d301bc552487c7fefa804d4a13\n\u003e \u003e Signed-off-by: Jakub Czapiga \u003cczapiga@google.com\u003e\n\u003e \u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5890746\n\u003e \u003e Commit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\n\u003e \u003e Reviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n\u003e\n\u003e BUG\u003db:369294243, b:369290629\n\u003e\n\u003e Change-Id: I5414b8e323f1f9bfca222272618b2bd503a58074\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5915173\n\u003e Commit-Queue: Jakub Czapiga \u003cczapiga@google.com\u003e\n\u003e Bot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\n\u003e Reviewed-by: Allen Webb \u003callenwebb@google.com\u003e\n\u003e Reviewed-by: Jakub Czapiga \u003cczapiga@google.com\u003e\n\nBUG\u003db:369294243, b:369290629\n\nChange-Id: I68bf753e17ecdc096768a88711920e3c955f71ab\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5982923\nCommit-Queue: Allen Webb \u003callenwebb@google.com\u003e\nAuto-Submit: Jakub Czapiga \u003cczapiga@google.com\u003e\nCommit-Queue: Jakub Czapiga \u003cczapiga@google.com\u003e\nTested-by: Jakub Czapiga \u003cczapiga@google.com\u003e\nReviewed-by: Allen Webb \u003callenwebb@google.com\u003e\n" }, { "commit": "375e6f703b55b78bbed7315b2a1a0df8e5568d4a", "tree": "4577fbaf0e9ee4742002966408243d85bc5ed5f1", "parents": [ "a30c2e3e8fadf976d5e654eb32d8dc0162a1385e", "6f7d9d03e39e9cfe446918282bdae74463fb318e" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Thu Oct 31 16:26:26 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Oct 31 16:26:26 2024 +0000" }, "message": "OWNERS.android: Add bernacki@google.com am: dbcfe4c509 am: 6f7d9d03e3\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/vboot_reference/+/3327077\n\nChange-Id: I2fe05b84ea1d045ae6b330d8b6ce5307cf1f6fa4\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "6f7d9d03e39e9cfe446918282bdae74463fb318e", "tree": "4577fbaf0e9ee4742002966408243d85bc5ed5f1", "parents": [ "17fd5af814beca225869dee81a95e1023af0cabf", "dbcfe4c509ef4695d23c75697e803b59b9ca97f2" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Thu Oct 31 15:52:26 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Thu Oct 31 15:52:26 2024 +0000" }, "message": "OWNERS.android: Add bernacki@google.com am: dbcfe4c509\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/vboot_reference/+/3327077\n\nChange-Id: Id796e72809d4a229422b5de1c21fdcb859d1926d\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "dbcfe4c509ef4695d23c75697e803b59b9ca97f2", "tree": "4577fbaf0e9ee4742002966408243d85bc5ed5f1", "parents": [ "179cd4aa6f7cbb69f1d7622d69bccd7f043786ff" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Thu Oct 31 14:14:20 2024 +0000" }, "committer": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Thu Oct 31 14:14:20 2024 +0000" }, "message": "OWNERS.android: Add bernacki@google.com\n\nTest: None\nBug: None\nChange-Id: If92c2c22300d38b9a6e3af8ff9c6d54a7530d896\n" }, { "commit": "26e8011fd51765457a628c3f5317c99e8b485973", "tree": "2933c58be88354bbdfa2e8cbe6d4e6e176c2defd", "parents": [ "a0f83f9f3a0cd103d0bdcf16e8868e3eb87e7b49" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Mon Oct 14 07:25:22 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Oct 31 11:55:54 2024 +0000" }, "message": "Add configurable temporary directory path\n\nThis patch introduces common way to control the host temporary directory\npath via VBOOT_TMP_DIR variable. It also updates Android.bp to use\ncorrect paths on the target platforms as well as adds init script\ncreating all needed directories.\n\nBUG\u003db:376284266\nBRANCH\u003dNone\nTEST\u003dBuild and run futility on Android\n\nChange-Id: Idd125a4380142f87cac695ffa7d76ceec1880bce\nSigned-off-by: Jakub Czapiga \u003cczapiga@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5976624\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "a0f83f9f3a0cd103d0bdcf16e8868e3eb87e7b49", "tree": "ebce6e067b856bde3a92cc51b76435e25a548e7a", "parents": [ "862e250e672c0ed3a801dfa274198ec88d4a186d" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Wed Oct 30 12:08:48 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Oct 31 11:55:52 2024 +0000" }, "message": "futility: Drop futility execution logging to /tmp/futility.log\n\nThis functionality is not used anymore and is also a potential security\nvulnerability.\n\nBUG\u003dNone\nBRANCH\u003dNone\nTEST\u003dsudo FEATURES\u003dtest emerge vboot_reference\n\nChange-Id: Ie1bd38a26faa240f8cd00ab7717ed58489223e31\nSigned-off-by: Jakub Czapiga \u003cczapiga@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5972390\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "862e250e672c0ed3a801dfa274198ec88d4a186d", "tree": "4dc745a6271cf40df4f3288118e6be3d60c296f3", "parents": [ "3246e484ca08f2ab29935cb964fa52fc6d24f97b" ], "author": { "name": "Rob Barnes", "email": "robbarnes@google.com", "time": "Wed Oct 30 08:10:00 2024 -0600" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Oct 30 19:17:33 2024 +0000" }, "message": "crossystem: Make crossystem vendor_available\n\nMaking crossystem `vendor_available` instead of `vendor` means it can be\ninstalled in /system/bin/ or /vendor/bin/ depending on which target is\nused, `crossystem` or `crossystem.vendor` respectively.\n\nBUG\u003db:374130759\nTEST\u003dBuild\nBRANCH\u003dNone\n\nChange-Id: I9a27f92c975b23d95f9e8dbb9d2189a1cd7518d2\nSigned-off-by: Rob Barnes \u003crobbarnes@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5979089\nTested-by: Jakub Czapiga \u003cczapiga@google.com\u003e\nReviewed-by: Jakub Czapiga \u003cczapiga@google.com\u003e\nCommit-Queue: Jakub Czapiga \u003cczapiga@google.com\u003e\n" }, { "commit": "3246e484ca08f2ab29935cb964fa52fc6d24f97b", "tree": "4291ed7de4f94ed61d7a2923c21ed16619e63219", "parents": [ "2ab8888bddac82f94611b01f3133524f98e367ff" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Mon Oct 28 17:49:24 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Oct 30 00:26:45 2024 +0000" }, "message": "futility: updater: Increase try count from 11 to 13\n\nTheoretically 11 reboots are enough for firmware update in any\nsituation. However, a user may power off the device within 1 miniute\nafter bootup, causing chromeos-setgoodfirmware to not run. The result is\nthat, fw_result won\u0027t be set to \"success\" in that boot, so fw_try_count\nwill be further decreased by 1 in the next boot.\n\nGiven that the firmware cannot tell if the poweroff is intentional by\nthe user or unexpected by the system, the best we can do is to take this\nedge case into account in the initial fw_try_count value. Increase it\nfrom 11 to 13, so that users will be less unlikely to hit this edge\ncase. More precisely, they will need to power off the device within 1\nminute for 3 consecutive boots after firmware update, in order to hit\nthis issue.\n\nBUG\u003db:374893421\nTEST\u003dcq\nBRANCH\u003dnone\n\nChange-Id: Iec21a26b62bdcf6aa6ad44402cd39cebd70c24b8\nSigned-off-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5970064\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-by: Hung-Te Lin \u003chungte@chromium.org\u003e\n" }, { "commit": "2ab8888bddac82f94611b01f3133524f98e367ff", "tree": "2e1c72b2920afd7e379affc108c75e81cbc2f4bc", "parents": [ "3c2ef9400c0565144dc560150d2bca92a330ce6b" ], "author": { "name": "Arnaud Ferraris", "email": "arnaud.ferraris@collabora.corp-partner.google.com", "time": "Mon Oct 21 14:56:09 2024 +0200" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Oct 21 18:48:12 2024 +0000" }, "message": "make_dev_ssd: add upstream cmdline flag for ptracers\n\nThe downstream patch adding the flags allowing ptracers to write to\nproc/mem has been partly merged upstream. During the process, the\n`foll_force` cmdline option was renamed to `proc_mem.force_override`,\nwith the `ptracer` option being now simply `ptrace`.\n\nAs the upstreamed patch has been backported to all stable kernel\nbranches, which are currently being imported into ChromeOS kernels, we\nneed to add this option to ensure debugging can still work on dev/test\nimages.\n\nThe previous version of this option will be removed at a later point,\nonce all ChromeOS kernels are up-to-date with the corresponding stable\nbranches.\n\nBUG\u003db:325891891\nTEST\u003dBuilt prod/dev/test images and verify /proc/cmdline\nBRANCH\u003dmain\n\nChange-Id: Id4e340746b2c0938c889170cd7b1cfbfde8eceb0\nSigned-off-by: Arnaud Ferraris \u003carnaud.ferraris@collabora.corp-partner.google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5947523\nReviewed-by: Raul Rangel \u003crrangel@chromium.org\u003e\n" }, { "commit": "3c2ef9400c0565144dc560150d2bca92a330ce6b", "tree": "d57aaafda70fa65fffc1bf1b89e60538b70d89a1", "parents": [ "c5af1fd8490d07d28ab178364e6452da748cc320" ], "author": { "name": "Allen Webb", "email": "allenwebb@google.com", "time": "Fri Oct 18 19:50:57 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Oct 21 16:58:13 2024 +0000" }, "message": "Update Rust OWNERS file to include libchromeos-rs/OWNERS\n\nBUG\u003dNone\nTEST\u003dNone\n\nChange-Id: I207b4ed7ceb222a950d5acd697949d43494856c4\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5943542\nTested-by: Allen Webb \u003callenwebb@google.com\u003e\nReviewed-by: George Burgess \u003cgbiv@chromium.org\u003e\nAuto-Submit: Allen Webb \u003callenwebb@google.com\u003e\nCommit-Queue: George Burgess \u003cgbiv@chromium.org\u003e\n" }, { "commit": "a30c2e3e8fadf976d5e654eb32d8dc0162a1385e", "tree": "bd9ea96eb1dd2c00f80525ca930f73c557efe799", "parents": [ "187d63b5e06dba2286f29be94f94fc4f454a1b8b", "17fd5af814beca225869dee81a95e1023af0cabf" ], "author": { "name": "Xin Li", "email": "delphij@google.com", "time": "Fri Oct 18 22:55:47 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Fri Oct 18 22:55:47 2024 +0000" }, "message": "[automerger skipped] Mark 24Q4 as merged in aosp-main-future am: 17fd5af814 -s ours\n\nam skip reason: Merged-In I4857a53eb93dfd36e6aa6ae9df1b10e08b906ac6 with SHA-1 c9bfc260e7 is already in history\n\nOriginal change: https://googleplex-android-review.googlesource.com/c/platform/external/vboot_reference/+/29935587\n\nChange-Id: I51434c4f75e51091a7ac8d16607591ec05e318ef\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "17fd5af814beca225869dee81a95e1023af0cabf", "tree": "bd9ea96eb1dd2c00f80525ca930f73c557efe799", "parents": [ "5bcea9673b157a181c46a5565da1fe53a8c695bb", "4fa7d22675727d9081989634628766de7f2347cb" ], "author": { "name": "Xin Li", "email": "delphij@google.com", "time": "Thu Oct 17 11:03:36 2024 -0700" }, "committer": { "name": "Xin Li", "email": "delphij@google.com", "time": "Thu Oct 17 11:03:36 2024 -0700" }, "message": "Mark 24Q4 as merged in aosp-main-future\n\nBug: 373937381\nMerged-In: I4857a53eb93dfd36e6aa6ae9df1b10e08b906ac6\nChange-Id: Ib757fa332c6c8a0e14944b51f2741e04265e5856\n" }, { "commit": "c5af1fd8490d07d28ab178364e6452da748cc320", "tree": "cb3357ad4e4559b78bdcf5e09294f42afb6552a6", "parents": [ "38f9c255d31df24a4cc08334846ea2e6a1df4b36" ], "author": { "name": "Ross Zwisler", "email": "zwisler@google.com", "time": "Tue Oct 15 09:44:33 2024 -0600" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Oct 15 23:35:54 2024 +0000" }, "message": "make_dev_ssd.sh: avoid page cache aliasing\n\nPer http://b/307454713 we noticed that sometimes an `fflash` operation\nwould leave a device in a bad state where it would no longer boot. It\nturns out that this was due to a page cache aliasing issue that caused\nthe kernel partition to become corrupt. That issue worked like this on\nmy asurada system:\n\n1. fflash writes a new kernel image to slot A using /dev/mmcblk0p2\n\n2. Without rebooting, fflash then executes make_dev_ssd.sh to remove\n rootfs verification on slot A.\n\n3. make_dev_ssd.sh reads the kernel image from slot A, with the intent\n of modifying it and writing it back. However, instead of reading the\n image from /dev/mmcblk0p2, it reads the kernel image from\n /dev/mmcblk0 using offset and length arguments, i.e.:\n\n dd if\u003d/dev/mmcblk0 of\u003ddata bs\u003d512 skip\u003d69 count\u003d65536\n\n You can see that offset \u0026 length via `fdisk`:\n\n # fdisk -l /dev/mmcblk0\n Device Start End Sectors Size Type\n /dev/mmcblk0p2 69 65604 65536 32M ChromeOS kernel\n\n4. The page cache for /dev/mmcblk0p2 was still in the process of writing\n back its dirty data, so the data that make_dev_ssd.sh gets from its\n `dd` operation on /dev/mmcblk0 is a mix of old stale data and new\n data. It reads that data to a file, updates it to remove rootfs\n verification, and then writes it back again using the parent block\n device, offset and length.\n\n5. We now have a corrupt kernel image in slot A, and will fail to boot\n when `fflash` tries to reboot the system.\n\nThe root of this issue is that the partition /dev/mmcblk0p2 and the\nparent device /dev/mmcblk0 can have separate page cache entries for the\nsame disk blocks. We can work around this issue by making sure that the\nwriteback from the update operation is complete and that we\u0027ve cleared\nany stale, clean cache blocks before and after we do the make_dev_ssd.sh\nupdate to remove rootfs verification.\n\nWe could also potentially fix this by updating make_dev_ssd.sh use the\n/dev/mmcblk0p2 partition, but this seems more brittle because it\nrequires us to keep all update utilities (fflash, `cros flash`) in sync\nwith how they access block devices. The current solution tries to make\nmake_dev_ssd.sh updates atomic so they can work no matter how other\ntools use the disk.\n\nBUG\u003db:307454713\nBRANCH\u003dnone\nTEST\u003drunning these two operations in a loop:\n cros flash --no-stateful-update --no-reboot $DUT $DISK_IMAGE\n ssh $DUT \"/usr/share/vboot/bin/make_dev_ssd.sh -d \\\n\t --remove_rootfs_verification --partitions $PARTITION\"\nI was able to consistently recreate the cache aliasing issue on my\nasurada devices in about 5 minutes. With this fix I was able to run\nthat same test on 2 devices overnight without any issues.\n\nChange-Id: I41c96534ec8f69e5968af27bd24fa2d470422d7d\nSigned-off-by: Ross Zwisler \u003czwisler@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5934991\nReviewed-by: Allen Webb \u003callenwebb@google.com\u003e\nReviewed-by: Benjamin Gordon \u003cbmgordon@chromium.org\u003e\nReviewed-by: Raul Rangel \u003crrangel@chromium.org\u003e\n" }, { "commit": "38f9c255d31df24a4cc08334846ea2e6a1df4b36", "tree": "e50ed78efa83f1cd6fcb553bc2071bd5d9c3b80f", "parents": [ "7d4b23f9a0541523debae852bbb2b22609d605ee" ], "author": { "name": "Hsuan Ting Chen", "email": "roccochen@chromium.org", "time": "Tue Oct 08 05:07:58 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Oct 08 15:24:15 2024 +0000" }, "message": "Revert \"host/lib/flashrom: Use flashrom provided in PATH\"\n\nThis reverts commit 24fd715c90e89df1a90191c8ee1d3d78a29af758.\n\nReason for revert: Potentially break b/370374826\n\nOriginal change\u0027s description:\n\u003e host/lib/flashrom: Use flashrom provided in PATH\n\u003e\n\u003e Remove `/usr/sbin` path prefix from FLASHROM_EXEC_NAME path.\n\u003e The cbfstool is called this way, so there is no need to have differing\n\u003e requirements for other utility which needs to be provided anyway.\n\u003e\n\u003e BUG\u003db:369294243, b:369290629\n\u003e BRANCH\u003dNone\n\u003e TEST\u003dm; adb shell crossystem dev_boot_altfw\u003d1\n\u003e\n\u003e Change-Id: Iff9fcfb8b40287d301bc552487c7fefa804d4a13\n\u003e Signed-off-by: Jakub Czapiga \u003cczapiga@google.com\u003e\n\u003e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5890746\n\u003e Commit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\n\u003e Reviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n\nBUG\u003db:369294243, b:369290629\n\nChange-Id: I5414b8e323f1f9bfca222272618b2bd503a58074\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5915173\nCommit-Queue: Jakub Czapiga \u003cczapiga@google.com\u003e\nBot-Commit: Rubber Stamper \u003crubber-stamper@appspot.gserviceaccount.com\u003e\nReviewed-by: Allen Webb \u003callenwebb@google.com\u003e\nReviewed-by: Jakub Czapiga \u003cczapiga@google.com\u003e\n" }, { "commit": "7d4b23f9a0541523debae852bbb2b22609d605ee", "tree": "522e81b9b93332c67cffa876de760a2c56730bbf", "parents": [ "8494502d9f0bea4727fa6dfc7e504c99e400f568" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Mon Sep 23 20:53:31 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Oct 07 11:16:13 2024 +0000" }, "message": "futility: updater: Revise the test script\n\nThe `test_update.sh` was generating lots of test_update.sh.tmp* files in\nbuild/tests/futility_test_results/ that was mixed with other tests, and\nnot really cleaned up before execution if the previous test failed.\n\nThere are a few improvements here:\n- Change ${TMP}.XXX to ${TMP}/XXX, collecting all files in one folder.\n- Reset the folder before starting the tests.\n- Changed ${TMP}.XYZ.ABC to better names, for example ${EXPECTED}.\n\nBUG\u003dNone\nTEST\u003dmake runfutiltests -j\nBRANCH\u003dNone\n\nChange-Id: Id16d7642018a558756d5f93a0c63e1bbcada347a\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5882814\nCommit-Queue: Hung-Te Lin \u003chungte@chromium.org\u003e\nTested-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nAuto-Submit: Hung-Te Lin \u003chungte@chromium.org\u003e\n" }, { "commit": "8494502d9f0bea4727fa6dfc7e504c99e400f568", "tree": "bc1aa031de87f9cc6e6108c15aba07985e349571", "parents": [ "54be900d8e1ada40f384320b83c80909ab5c1d2b" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Mon Sep 23 20:27:10 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Oct 07 11:16:12 2024 +0000" }, "message": "futility: updater: Support emulation in the output mode\n\nThe emulation (`--emulate`) actually can work in the output mode.\nAlso remove the \u0027PD\u0027 in the help messages because we no longer supports\nthat.\n\nBUG\u003dNone\nTEST\u003dmake runfutiltests -j\nBRANCH\u003dNone\n\nChange-Id: I5ed39df6852769d8127d35a2aff8244de355b8d0\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5882813\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "54be900d8e1ada40f384320b83c80909ab5c1d2b", "tree": "f671afac31211586ce2efa9750709324b729163e", "parents": [ "2a78755815d64019c581428715e960069c79ddab" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Mon Oct 07 15:08:27 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Oct 07 11:16:09 2024 +0000" }, "message": "futility: updater: Handle flashrom read failure in load_system_firmware\n\nIn load_system_firmware, we have make sure the caller can still get the\nright \"system current firmware image\" because we may be running for the\nrecovery mode with a broken firmware.\n\nCurrently flashrom_read_image_impl will not free the allocated memory\neven if flashrom_image_read failed. So we should check the return value\nof flashrom_read_image, and release the firmware image structure on read\nfailure.\n\nBUG\u003db:251040363\nTEST\u003dmake runfutiltests -j\nBRANCH\u003dNone\n\nChange-Id: I420625c8852796d25e5bbf4cf1920cdc27df7362\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5905015\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "2a78755815d64019c581428715e960069c79ddab", "tree": "cad3b6f6f45cce72f42041e66f8586b7f894a697", "parents": [ "90f591700475b68715f1f27fd30a0d712037cac6" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Sat Sep 21 22:50:57 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Oct 07 11:16:07 2024 +0000" }, "message": "futility: updater: Drop `signature_id` from implementation\n\nThe \u0027signature_id\u0027 in the updater was used for a several different use\ncases, including the custom label tag in pre-unibuild archives, model\nname (unibuild), model name + custom label tag (unibuild with custom\nlabel), firmware manifest key, ... etc.\n\nGiven the `--model` has deprecated the `--signature_id`, we should also\nclean up the underlying implementation to prevent confusion. The quirk\n`override_signature_id` is now also renamed to `override_custom_label`.\n\nBUG\u003db:251040363\nTEST\u003dmake runfutiltests -j\nBRANCH\u003dNone\n\nCq-Depend: chromium:5872772\nChange-Id: I92adb148ca5e4b5db2fec2d9554061e11b81b6bb\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5872454\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "90f591700475b68715f1f27fd30a0d712037cac6", "tree": "0d184202e0eaa36268ab2edd24840613cced3578", "parents": [ "94d884d8a5bb0a237d24ff50423baa489be31df0" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Sun Sep 22 11:33:10 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sun Oct 06 17:33:04 2024 +0000" }, "message": "futility: updater: Add a new config \u0027output_only\u0027\n\nThere was no easy way to identify if the updater is running in\noutput-only mode (`--mode\u003doutput`). However, some setup process\n(especially the custom label tag processing) will want to know if it is\nappropriate to read the system firmware. For example, the ODMs and\nfactories will want to run `--mode\u003doutput` in the CrOS SDK to get\nthe preflash image, and definitely not reading the host system firmware.\n\nAfter `--signature_id` is deprecated, specifying `--model` without\ntags will trigger reading system firmware. As a result, we need to\nidentify if the updater is running in the output mode, and skip reading\nsystem firmware in that mode. Having the output_only will make it\nsimpler instead of having the `strcmp(arg-\u003emode, \"output\")` everywhere.\n\nBUG\u003db:251040363\nTEST\u003dmake runfutiltests -j\nBRANCH\u003dNone\n\nChange-Id: I5181c9a31df7db12e04fdd362fe02ca08be29916\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5879038\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "94d884d8a5bb0a237d24ff50423baa489be31df0", "tree": "36a95588d9f47ef4bc9081b51bb6c16b1446bd28", "parents": [ "24fd715c90e89df1a90191c8ee1d3d78a29af758" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Sat Sep 21 17:55:30 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Sun Oct 06 13:48:54 2024 +0000" }, "message": "futility: updater: Deprecate `--signature_id` by `--model`\n\nThe `--signature_id` was introduced to support specifying the custom\nlabel tag manually for debugging and generating pre-flash images.\nBefore Unified Build, the argument expects only the key name and not the\nmodel name. However after Unified Build, the signature_id includes both\nmodel name and the custom label tag name, which makes it looking\nduplicated that you need both params:\n\n futility update --model poppy --signature_id poppy-ctl ...\n\nAfter CL:5872452, the custom label models are now treated like normal\nmodels so actually we can combine the `model` and `signature_id`\narguments.\n\nPreviously you can\u0027t specify the model + tag into `--model` but now you\nshould do that as `--model MODEL-TAG` for the custom label devices.\n\nBUG\u003db:251040363\nTEST\u003dmake runfutiltests -j\nBRANCH\u003dNone\n\nCq-Depend: chromium:5872772\nChange-Id: I16ef3f355fda246955a86e4bb415626e8762021d\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5872453\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "187d63b5e06dba2286f29be94f94fc4f454a1b8b", "tree": "bd9ea96eb1dd2c00f80525ca930f73c557efe799", "parents": [ "4fa7d22675727d9081989634628766de7f2347cb", "5bcea9673b157a181c46a5565da1fe53a8c695bb" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Fri Sep 27 14:23:10 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Fri Sep 27 14:23:10 2024 +0000" }, "message": "Upgrade vboot_reference to 24fd715c90e89df1a90191c8ee1d3d78a29af758 am: 179cd4aa6f am: 5bcea9673b\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/vboot_reference/+/3284517\n\nChange-Id: I9d82573bcc6df596712f75838dc7dd18cadd9207\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "5bcea9673b157a181c46a5565da1fe53a8c695bb", "tree": "bd9ea96eb1dd2c00f80525ca930f73c557efe799", "parents": [ "88f74e02a7d01fd8707ab6f32be8c2f11cdd5f68", "179cd4aa6f7cbb69f1d7622d69bccd7f043786ff" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Fri Sep 27 13:51:38 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Fri Sep 27 13:51:38 2024 +0000" }, "message": "Upgrade vboot_reference to 24fd715c90e89df1a90191c8ee1d3d78a29af758 am: 179cd4aa6f\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/vboot_reference/+/3284517\n\nChange-Id: I14bfbfc34808c2d91b4e9e43d6e61bcabe093ac6\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "179cd4aa6f7cbb69f1d7622d69bccd7f043786ff", "tree": "bd9ea96eb1dd2c00f80525ca930f73c557efe799", "parents": [ "ef8f3c8635a6832738060a71e01c9ede579c6712", "24fd715c90e89df1a90191c8ee1d3d78a29af758" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Fri Sep 27 06:48:14 2024 +0000" }, "committer": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Fri Sep 27 06:48:15 2024 +0000" }, "message": "Upgrade vboot_reference to 24fd715c90e89df1a90191c8ee1d3d78a29af758\n\nThis project was upgraded with external_updater.\nUsage: tools/external_updater/updater.sh update external/vboot_reference\nFor more info, check https://cs.android.com/android/platform/superproject/main/+/main:tools/external_updater/README.md\n\nTest: TreeHugger\nChange-Id: Idb0c32f522d38a8809aa48092176572e6251eb20\n" }, { "commit": "24fd715c90e89df1a90191c8ee1d3d78a29af758", "tree": "4974cdf61a27203d20f4e79994141383eb9c9524", "parents": [ "ac49f1ca939bbe4df7a29d3cf9a7cce543e12fd6" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Wed Sep 25 09:15:08 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Sep 27 03:48:05 2024 +0000" }, "message": "host/lib/flashrom: Use flashrom provided in PATH\n\nRemove `/usr/sbin` path prefix from FLASHROM_EXEC_NAME path.\nThe cbfstool is called this way, so there is no need to have differing\nrequirements for other utility which needs to be provided anyway.\n\nBUG\u003db:369294243, b:369290629\nBRANCH\u003dNone\nTEST\u003dm; adb shell crossystem dev_boot_altfw\u003d1\n\nChange-Id: Iff9fcfb8b40287d301bc552487c7fefa804d4a13\nSigned-off-by: Jakub Czapiga \u003cczapiga@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5890746\nCommit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "ac49f1ca939bbe4df7a29d3cf9a7cce543e12fd6", "tree": "c86ca998f644c4ef18e7604adb11f07caa6efac6", "parents": [ "640fe19f5f9290be94cfc89634495e0f7b30ccee" ], "author": { "name": "Arthur Heymans", "email": "arthur@aheymans.xyz", "time": "Thu Aug 22 19:58:35 2024 +0200" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Sep 27 03:01:47 2024 +0000" }, "message": "Build thin archives\n\nThe clang linker frontend, which is required for LTO only works with\nthin archives: https://github.com/llvm/llvm-project/issues/98290\n\nChange-Id: Ifcb7145a13718acb3f249455672c1d5033054414\nSigned-off-by: Arthur Heymans \u003carthur@aheymans.xyz\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5803590\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nCommit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\nTested-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "640fe19f5f9290be94cfc89634495e0f7b30ccee", "tree": "dd1f4d28128e47e14608b6875e7eb1891a5ed859", "parents": [ "86b42b6a930c61e23b1df25c9994b75ef3bf48fb" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Mon Sep 23 14:15:53 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Sep 27 00:29:25 2024 +0000" }, "message": "host/lib/crossystem: Make CROSSYSTEM_LOCK_PATH configurable\n\nAndroid (and other systems) do not have `/run/lock` directory, which is\nused by crossystem by default to create a lockfile for its `set`\noperations. This issue can be circumvented by providing a way to\nconfigure this path via a define and making it configurable by `make`\nvariable.\n\nFor Android the `/data/local/tmp` was picked as it seems to be a default\nlocation for tools for this purpose. (See: Android gdbclient.py\ndebug_socket and server_remote_path). Although this directory is\npersistent across reboots, the lock file is not required to be and path\nan be changed later to other one with e.g. tmpfs.\n\nLinux uses /run/lock starting from Filesystem Hierarchy Standard 3.0.\nDarwin/Mac use /tmp ad there is no direct equivalent of /run/lock.\nWindows uses C:\\windows\\temp.\n\nIMPORTANT!!!: Windows and Darwin were not tested.\n\nBUG\u003db:369294243, b:369290629\nBRANCH\u003dNone\nTEST\u003dcrossystem dev_boot_usb\u003d1 # On Android\n\nChange-Id: I847f782fb5994185fbaf8f5dd23b60fc74a2c882\nSigned-off-by: Jakub Czapiga \u003cczapiga@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5882099\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nCommit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "86b42b6a930c61e23b1df25c9994b75ef3bf48fb", "tree": "97cf6e83d6975d03f80447cb6416e3e9d8ed0e5d", "parents": [ "da1d153b4eed5f53f40e89b4f8a706711cf0f0eb" ], "author": { "name": "Luzanne Batoon", "email": "batoon@google.com", "time": "Tue Aug 27 21:18:24 2024 -0700" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 26 03:18:55 2024 +0000" }, "message": "sign_android_image: calculate and store the vb meta digest\n\nFor verified boot, one of the boot parameters is the vb meta\ndigest. The vb meta digest will be set to the hash of the\nhashes of the system and vendor images. The hash will be\ncalculated and stored in a file in the same directory as the\nimages. Later, the file will be read to retrieve the value\nfor vb meta digest.\n\nARC Keymint CL: https://crrev.com/c/5809618\n\nBUG\u003db:350826304\nTEST\u003d./sign_android_unittests.sh\nTEST\u003dmanually compare arcvm_vbmeta_digest.sha256 and sha256sum\noutput on dut with locally signed image\nBRANCH\u003dnone\n\nChange-Id: Icab0a5002a6b0f6537c75b5124587b0a92270f26\nSigned-off-by: Luzanne Batoon \u003cbatoon@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5826996\nReviewed-by: Vaibhav Raheja \u003cvraheja@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "da1d153b4eed5f53f40e89b4f8a706711cf0f0eb", "tree": "766f022954545586aace020fc09a347e51ae67c1", "parents": [ "80955816aee0bcac10628c1f574b1a2a9b06f1c5" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Thu Sep 12 13:05:53 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Sep 24 07:18:15 2024 +0000" }, "message": "Move futility and cgpt to vendor partition\n\nThis patch is a cherrypick of:\ncommit ef8f3c8635a6 (\"Move futility and cgpt to vendor partition\")\nCherry-picked to synchronize ChromeOS and Android repos.\n\nBUG\u003db:366170141\nTEST\u003dm\nBRANCH\u003dNone\n\nTest: m\nBug: b:366170141\nChange-Id: I96b9b86868540d20e7d8488fbcb38e91b3d3b40e\nSigned-off-by: Jakub Czapiga \u003cczapiga@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5882100\nReviewed-by: Hung-Te Lin \u003chungte@chromium.org\u003e\n" }, { "commit": "80955816aee0bcac10628c1f574b1a2a9b06f1c5", "tree": "550025bd8ee82b1b3c2155dc3f6f548a17e24497", "parents": [ "7ad2b0ab50350df901de329a75aa40d189ef6f94" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Sun Sep 22 09:40:46 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Sep 23 21:52:17 2024 +0000" }, "message": "futility: updater: Remove \u0027allow_empty_custom_label_tag\u0027 quirk\n\nThe \u0027allow_empty_custom_label_tag\u0027 quirk was introduced for non-unified\nbuilds to support custom label devices without a tag (customization_id)\nset. The only device use it is Hana, which is now a unified build.\n\nAfter CL:5872452, we are now able to directly load the default keys\nusing the information provided by `signer_config.csv` even for Hana (and\nremoved where the quirk was previously used), so this quirk is no longer\nneeded.\n\nBUG\u003db:251040363\nTEST\u003dmake runfutiltests -j\nBRANCH\u003dNone\n\nChange-Id: I14edd5f89d3518a4ba936a6c4df5e91368d03783\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5879037\nCommit-Queue: ChromeOS Auto Retry \u003cchromeos-auto-retry@chromeos-bot.iam.gserviceaccount.com\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "7ad2b0ab50350df901de329a75aa40d189ef6f94", "tree": "5e693f06bc4dfb03a3066f1b18e47e17c24e9468", "parents": [ "13400d696a5edaff2b28c1305ca1069e6bbb9669" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Sat Sep 21 01:20:35 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Sep 23 16:00:19 2024 +0000" }, "message": "futility: updater: Process custom label as standard models\n\nOne advantage of switching to signer_config.csv and getting rid of\nsetvars.sh is we finally can know what custom label devices are\nsupported.\n\nIn `setvars.sh` or the pre-Unified-Build single package format, we have\nto scan the \u0027keyset/\u0027 folder to figure out what custom label tags may be\navailable. But when using signer_config.csv, all the custom label names\nare already included in the signer information.\n\nAs a result, we can finally remove the hacky way of patching custom\nlabel devices. One downside is we can no longer support custom label in\nnon-Unified-Build systems, but all active Chromebooks are now Unified\nBuild so that is not a problem. And for development using simple archive\nwithout `signer_config.csv`, there is no need to support custom label\nbecause we usually don\u0027t have signed keys.\n\nThis is also the first step to remove the custom label logic from the\nfirmware updater - preparation to let crosid handle custom label\nmatching for us. This also implies `--signature_id` is now equivalent to\n`--model` and can be deprecated in the follow up changes.\n\nBUG\u003db:251040363\nTEST\u003dmake runfutiltests -j\nBRANCH\u003dnone\n\nChange-Id: Ib4c62ba4d01b276472575625ea19397fc21b1589\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5872452\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "13400d696a5edaff2b28c1305ca1069e6bbb9669", "tree": "eeb76abb771db02167ace266e0be9297b92b5732", "parents": [ "f770c7d074a231c533c2ca0608eccfab8c807adb" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Thu Sep 05 01:02:43 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Sep 23 09:19:17 2024 +0000" }, "message": "futility: updater: Remove signature_id from manifest\n\nThe `signature_id` was a legacy data from `setvars.sh` and was not\navailable in the `signer_config.csv` data. Since we have fully\ndeprecated the `setvars.sh`, it is time to remove the unused data.\n\nBUG\u003db:251040363\nTEST\u003dmake runfutiltests -j\nBRANCH\u003dnone\n\nCq-Depend: chromium:5874495\nChange-Id: I7cb690b2bc4e0de96e062c7087b92483d440cda4\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5837957\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "f770c7d074a231c533c2ca0608eccfab8c807adb", "tree": "ae1b50ef9fc2c53af87a19aaad3ae77dad75088a", "parents": [ "ed4556edb968be5781237353eb0db56fcadaec1c" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Fri Aug 30 21:39:31 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Sep 23 09:19:15 2024 +0000" }, "message": "futility: updater: Remove the legacy \u0027setvars.sh\u0027 manifest\n\nThe `setvars.sh` has been deprecated by `signer_config.csv` for a while\n(M118~) and it is time to drop the setvars.sh from the updater.\n\nBUG\u003db:251040363\nTEST\u003dmake runfutiltests -j\nBRANCH\u003dnone\n\nCq-Depend: chromium:5826250\nChange-Id: I071f72c67a9aacd9d238c735d2a148fa8cd74cbd\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5826440\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "ed4556edb968be5781237353eb0db56fcadaec1c", "tree": "c882887eee40f30f4c61ff80dd44d7ca68d3948a", "parents": [ "2190262902561e5e57b088235f6e7302003f1c3b" ], "author": { "name": "DennisYeh", "email": "dennis.yeh@cienet.com", "time": "Mon Sep 16 17:07:54 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Sep 20 04:59:13 2024 +0000" }, "message": "tests/futility: Add test cases for unmodified RO\n\nTest the futility \u0027autoupdate\u0027 mode when the RO section is the same in\nboth the old and new firmware versions.\n\nRegardless of whether write protection (WP) is true or false, futility\nshould only update the inactive firmware (RWB).\n\nBUG\u003db:194910959\nTEST\u003dmanual on tentacruel.\nTEST\u003dunit tests passed.\n\nChange-Id: I35f9017f891e12bee8aff121d1eed8a008fbe4ae\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5869471\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nTested-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Jeremy Bettis \u003cjbettis@chromium.org\u003e\nTested-by: Dennis Yeh \u003cdennis.yeh@cienet.com\u003e\nCommit-Queue: Dennis Yeh \u003cdennis.yeh@cienet.com\u003e\n" }, { "commit": "4fa7d22675727d9081989634628766de7f2347cb", "tree": "6be0e60a0840fa3c4a812448245b95fdb8585447", "parents": [ "1e3709c78c3a30a7991c1d5aa4af5194a9ace552", "88f74e02a7d01fd8707ab6f32be8c2f11cdd5f68" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Wed Sep 18 16:43:45 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Sep 18 16:43:45 2024 +0000" }, "message": "Move futility and cgpt to vendor partition am: ef8f3c8635 am: 88f74e02a7\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/vboot_reference/+/3259716\n\nChange-Id: I2639907761000b276c57196e818cee658c74f94f\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "88f74e02a7d01fd8707ab6f32be8c2f11cdd5f68", "tree": "6be0e60a0840fa3c4a812448245b95fdb8585447", "parents": [ "e932a11f10207f70d5f9aa812420a3c5bb6652a0", "ef8f3c8635a6832738060a71e01c9ede579c6712" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Wed Sep 18 16:22:28 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Wed Sep 18 16:22:28 2024 +0000" }, "message": "Move futility and cgpt to vendor partition am: ef8f3c8635\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/vboot_reference/+/3259716\n\nChange-Id: I231883db140aed3c809ad43bcb7802e733075437\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "2190262902561e5e57b088235f6e7302003f1c3b", "tree": "75e809e5115f6993604ba6b470b99fb444cd225a", "parents": [ "f5924321909da88879e053a61a5b823de8858c44" ], "author": { "name": "Michał Kopeć", "email": "michal@nozomi.space", "time": "Mon Jul 08 11:25:54 2024 +0200" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Sep 13 00:17:43 2024 +0000" }, "message": "futility/file_type_bios.c: Skip keyblock checks if magic is invalid\n\nThe following warning messages appear every time upstream coreboot is\nbuilt with Vboot enabled:\n\n```\nWARNING: prepare_slot: VBLOCK_A keyblock is invalid.\nWARNING: prepare_slot: VBLOCK_B keyblock is invalid.\n```\n\nThis patch ensures that the warnings are not printed, by skipping checks\nif the keyblock magic is invalid. A new keyblock will be generated\nwithout extraneous warnings.\n\nChange-Id: If8e653036b4ca1d10f28bc3bab105b38b152edcd\nSigned-off-by: Michał Kopeć \u003cmichal@nozomi.space\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5682443\nTested-by: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nCommit-Queue: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "ef8f3c8635a6832738060a71e01c9ede579c6712", "tree": "6be0e60a0840fa3c4a812448245b95fdb8585447", "parents": [ "a1d96316b1677fa3e3a2c34ebe25b11c0726b1e7" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Thu Sep 12 13:05:53 2024 +0000" }, "committer": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Thu Sep 12 13:05:53 2024 +0000" }, "message": "Move futility and cgpt to vendor partition\n\nTest: m\nBub: b:366170141\nChange-Id: I96b9b86868540d20e7d8488fbcb38e91b3d3b40e\n" }, { "commit": "1e3709c78c3a30a7991c1d5aa4af5194a9ace552", "tree": "8edb624449b2f93619974d4858849497394d0329", "parents": [ "ed10f1022d4b0b8eeed763fc84ed9520c685087a", "e932a11f10207f70d5f9aa812420a3c5bb6652a0" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Tue Sep 10 16:49:36 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Sep 10 16:49:36 2024 +0000" }, "message": "OWNERS: Switch to OWNERS.android am: a1d96316b1 am: e932a11f10\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/vboot_reference/+/3261952\n\nChange-Id: Id96764925140f891c2eb564e8a4e4af2e2c31622\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "e932a11f10207f70d5f9aa812420a3c5bb6652a0", "tree": "8edb624449b2f93619974d4858849497394d0329", "parents": [ "eeea0d8329a1bc4fa929a11ea81e7d525ddc305b", "a1d96316b1677fa3e3a2c34ebe25b11c0726b1e7" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Tue Sep 10 16:29:52 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Tue Sep 10 16:29:52 2024 +0000" }, "message": "OWNERS: Switch to OWNERS.android am: a1d96316b1\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/vboot_reference/+/3261952\n\nChange-Id: Iff081a45bd3d52ac7ad5ea39e93f291783aeab57\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "a1d96316b1677fa3e3a2c34ebe25b11c0726b1e7", "tree": "8edb624449b2f93619974d4858849497394d0329", "parents": [ "eeea0d8329a1bc4fa929a11ea81e7d525ddc305b" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Tue Sep 10 14:05:47 2024 +0000" }, "committer": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Tue Sep 10 14:05:47 2024 +0000" }, "message": "OWNERS: Switch to OWNERS.android\n\nThe ChromeOS vboot_reference has its own OWNERS file.\nHaving divergence will cause merge issues if the file changes\nin the upstream. This commit restores original file contents and\nmoves owners to OWNERS.android\n\nTest: None\nBug: b:365494839\nChange-Id: Ie67ad70470d5200ee0dd524bc8bc69f764c7a8c5\n" }, { "commit": "f5924321909da88879e053a61a5b823de8858c44", "tree": "e20aaa4ca39b9ff40473a8635850515ec20ec2a0", "parents": [ "83f845b3b5dadec27307cb772490d0203d42a78e" ], "author": { "name": "Jae Hoon Kim", "email": "kimjae@chromium.org", "time": "Thu Sep 05 17:50:32 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Fri Sep 06 00:02:14 2024 +0000" }, "message": "Fix partition type check for miniOS B\n\n.. this should use partition 10 rather than 9.\n\nBUG\u003db:363466852\nTEST\u003dnone\nBRANCH\u003dNone\n\nChange-Id: I15364511f982c9410af0a5e3397655da4fd49d4c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5837192\nTested-by: George Engelbrecht \u003cengeg@google.com\u003e\nAuto-Submit: Jae Hoon Kim \u003ckimjae@chromium.org\u003e\nCommit-Queue: Jae Hoon Kim \u003ckimjae@chromium.org\u003e\nCommit-Queue: George Engelbrecht \u003cengeg@google.com\u003e\nTested-by: Jae Hoon Kim \u003ckimjae@chromium.org\u003e\nCommit-Queue: Benjamin Shai \u003cbshai@google.com\u003e\nReviewed-by: Benjamin Shai \u003cbshai@google.com\u003e\nReviewed-by: George Engelbrecht \u003cengeg@google.com\u003e\n" }, { "commit": "83f845b3b5dadec27307cb772490d0203d42a78e", "tree": "e16f90c709373bec862ab284ef4c111a30ee3db5", "parents": [ "dc5102f2f0614ec62924fa69cc1e364a9b73e391" ], "author": { "name": "Benjamin Shai", "email": "bshai@google.com", "time": "Thu Sep 05 19:01:54 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Sep 05 19:17:02 2024 +0000" }, "message": "signing: clean up owners\n\nRemove googlers no longer working here and add bshai@.\n\nBUG\u003dNone\nBRANCH\u003dNone\nTEST\u003dNone\n\nChange-Id: I2195ceea2e94a7659784453e60a46099d61b183d\nSigned-off-by: Benjamin Shai \u003cbshai@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5840434\nReviewed-by: George Engelbrecht \u003cengeg@google.com\u003e\nCommit-Queue: George Engelbrecht \u003cengeg@google.com\u003e\nTested-by: George Engelbrecht \u003cengeg@google.com\u003e\n" }, { "commit": "dc5102f2f0614ec62924fa69cc1e364a9b73e391", "tree": "11106bed72e48087473e5eec9e28c89c9fff5d64", "parents": [ "16e6aa8907fcfeaebfb479110abe1317b9111b2a" ], "author": { "name": "Benjamin Shai", "email": "bshai@google.com", "time": "Tue Sep 03 20:39:53 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Sep 04 13:41:46 2024 +0000" }, "message": "signing: miniOS signing in docker.\n\nFor some reason, lsblk reports null partition types in docker, even in\nprivileged\n(https://forums.docker.com/t/why-does-lsblk-report-partition-as-null-from-within-a-docker-container/139393).\nPrefer cgpt for checking the partition type, which appears to work, and\nfallback on lsblk (because the legacy signers only have that).\n\nThis commit also removed the check for the private key on disk because\nthe key lives in Cloud KMS, adds a newline to an info statement that\nwas getting concatenated to the previous log message, and unrolls the\nloop over all loop devices (opting to just explicitly check the two\nminios loop devices).\n\nBUG\u003db:363466852\nBRANCH\u003dNone\nTEST\u003dmanual\n\nChange-Id: I044c626dfac5ae7115b9f6b7e65e8303595544fb\nSigned-off-by: Benjamin Shai \u003cbshai@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5833916\nReviewed-by: Jae Hoon Kim \u003ckimjae@chromium.org\u003e\nReviewed-by: George Engelbrecht \u003cengeg@google.com\u003e\n" }, { "commit": "16e6aa8907fcfeaebfb479110abe1317b9111b2a", "tree": "5db6d8a5f1762e28b90ce440dc1928d2b0689949", "parents": [ "e56f3686526c54c45bf0044ab4068387a92e1cef" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Mon Aug 26 11:59:12 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Sep 02 08:53:44 2024 +0000" }, "message": "futility: updater: Provide default DUT properties for emulation\n\nWhen --emulate is specified, all the dut_get_property() calls would\nfail. The option --sys_props exists to allow overriding the DUT\nproperties. However, it\u0027s bothersome to specify it every time we want to\nrun the updater with emulation.\n\nTherefore, provide default DUT properties for emulation. The active\nfirmware slot is set to A. The TPM firmware version is set to 0x10001\n(to pass TPM key compatibility check). The platform version is set to 0.\nBoth hardware and software write protect states are assumed to be\ndisabled for convenience.\n\nSome of the --sys_props arguments in test_update.sh are simplified or\nomitted.\n\nBUG\u003dnone\nTEST\u003dmake runfutiltests -j\nTEST\u003dfutility update --emulate image.bin -i new.bin --mode\u003dfactory\nBRANCH\u003dnone\n\nChange-Id: I25202ad05a5c2e671b416c42951be8cdafee5689\nSigned-off-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5807011\nReviewed-by: Hung-Te Lin \u003chungte@chromium.org\u003e\n" }, { "commit": "e56f3686526c54c45bf0044ab4068387a92e1cef", "tree": "e193bc1ac42b5534069d5eaa434f09963dd6ebfa", "parents": [ "7e2828a1bacfbcbe3480378bf5482004c3901698" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Fri Aug 30 20:38:25 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Sep 02 08:53:42 2024 +0000" }, "message": "tests/futility/test_update: Fix --sys_props argument\n\nThe 0x10001 value is supposed to be for the tpm_fwver property, which is\nthe second element of the --sys_props argument. The error was introduced\nin CL:1189249, but has never been noticed because the test case happens\nto still pass with the incorrectly specified argument.\n\nBUG\u003dnone\nTEST\u003dmake runfutiltests -j\nBRANCH\u003dnone\n\nChange-Id: Ia05d441daa8848531892f686575ecd813e7ff916\nSigned-off-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5822915\nReviewed-by: Hung-Te Lin \u003chungte@chromium.org\u003e\n" }, { "commit": "7e2828a1bacfbcbe3480378bf5482004c3901698", "tree": "13b111c659299b9881e7b2819f7fe07ded73479f", "parents": [ "060efa0cf64d4b7ccbe3e88140c9da5f747355ee" ], "author": { "name": "Hung-Te Lin", "email": "hungte@chromium.org", "time": "Thu Aug 29 15:29:40 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Aug 29 10:56:51 2024 +0000" }, "message": "futility: updater: cleanup: Remove duplicated comments\n\nRemoved the comments above the public functions in the C files that have\nthe same comments in the header files. No real code changes.\n\nBUG\u003dNone\nTEST\u003dmake\nBRANCH\u003dNone\n\nChange-Id: I4846620584274985ae104bbe6c232fa66a711420\nSigned-off-by: Hung-Te Lin \u003chungte@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5822730\nCommit-Queue: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nTested-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "060efa0cf64d4b7ccbe3e88140c9da5f747355ee", "tree": "27917400a3c23e80dc01dba0e5dc9e4d987f68c7", "parents": [ "2fc6815bf6b50ae2fce305ed45f8f2dc6692514b" ], "author": { "name": "Nehemiah Dureus", "email": "ndureus@chromium.org", "time": "Mon Jun 24 17:58:50 2024 +0000" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Thu Aug 22 00:37:49 2024 +0000" }, "message": "vboot: Only execute TPM clear on nonchrome FW\n\nPrevent devices that are running ChromeOS FW from executing\na TPM clear request (designed for Flex), as it does not have\nthe HW to do so.\n\nBUG\u003db:328654919\nBRANCH\u003dnone\nTEST\u003dDeploy new changes to a flex liveboot and run the installer\n on a cb\n\nSigned-off-by: Nehemiah Dureus \u003cndureus@chromium.org\u003e\nChange-Id: Ia50d9065edaf1d398ce58bd6e189d9cac7eda38d\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5656183\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nReviewed-by: Yi Chou \u003cyich@google.com\u003e\n" }, { "commit": "2fc6815bf6b50ae2fce305ed45f8f2dc6692514b", "tree": "e42bbd074aea539e47f35ac939594bc23cfecd9b", "parents": [ "47658f3c89e2c1585e95ef47b3c19cb05b4be586" ], "author": { "name": "Madeleine Hardt", "email": "hardtmad@google.com", "time": "Wed Aug 21 09:20:33 2024 -0600" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Aug 21 18:45:25 2024 +0000" }, "message": "sign_official_build: Include full loem.ini path\n\nFor easier troubleshooting.\n\nBUG\u003db:356700724\nTEST\u003dNone\nBRANCH\u003dNone\n\nChange-Id: I581abb60b5da87b42bb7135afa68b8a932778ff8\nSigned-off-by: Madeleine Hardt \u003chardtmad@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5804351\nReviewed-by: Benjamin Shai \u003cbshai@google.com\u003e\nReviewed-by: George Engelbrecht \u003cengeg@google.com\u003e\n" }, { "commit": "47658f3c89e2c1585e95ef47b3c19cb05b4be586", "tree": "7d38c79fcff75b845b61022074704387e1e54b4f", "parents": [ "7cc2ce4c902b9ff1d6b725e72b0f7d152fe09e40" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Thu Aug 08 10:49:40 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Aug 21 05:28:11 2024 +0000" }, "message": "2lib/2load_kernel: Remove unused VB2_LOAD_PARTITION_WORKBUF_BYTES\n\nIn CL:2882527 we\u0027ve removed the `wb` argument from vb2_load_partition().\nNow the workbuf is allocated from that function. Therefore, remove the\nunused macro VB2_LOAD_PARTITION_WORKBUF_BYTES.\n\nBUG\u003dnone\nTEST\u003dcq\nBRANCH\u003dnone\n\nChange-Id: I70540ea40bac4fa6dd0f18ca7e0fbfbae34c09b1\nSigned-off-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5772312\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "7cc2ce4c902b9ff1d6b725e72b0f7d152fe09e40", "tree": "c0a97dd8cf0ee83a1e9d1d5eef0705c326b3f96b", "parents": [ "8365d546ce0698faffd22cf3cb44c0c854f74637" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Fri Aug 16 13:13:17 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Aug 21 02:50:27 2024 +0000" }, "message": "futility: Skip printing EC RW version if non-printable\n\nThe \"ecrw.version\" CBFS file may contain non-printable characters, for\nexample in Wilco (sarien \u0026 drallion) images. To make sure `futility\nupdate --manifest` produces valid JSON format, skip printing EC RW\nversion for those images.\n\nBUG\u003db:360198909\nTEST\u003dmake runtests -j\nBRANCH\u003dnone\n\nChange-Id: I072cb1a7aa2430ba180314ba876cb8b544ea228a\nSigned-off-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5792922\nReviewed-by: Hung-Te Lin \u003chungte@chromium.org\u003e\n" }, { "commit": "ed10f1022d4b0b8eeed763fc84ed9520c685087a", "tree": "2e5f7e1dc6b13e26cd7ed13c16c3e8c15d62a77f", "parents": [ "f4ee6686bb08f1ca7ce6757b155ff1472daf5d24", "eeea0d8329a1bc4fa929a11ea81e7d525ddc305b" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Mon Aug 19 10:18:12 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Aug 19 10:18:12 2024 +0000" }, "message": "Fix METADATA and OWNERS files am: de7a798d27 am: eeea0d8329\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/vboot_reference/+/3184806\n\nChange-Id: I943e61a343e47e97cd0f02ec1a9513b116953f37\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "f4ee6686bb08f1ca7ce6757b155ff1472daf5d24", "tree": "2e5f7e1dc6b13e26cd7ed13c16c3e8c15d62a77f", "parents": [ "486f4fb585dbdcd5e03eb600367d4f8e0e27a6bd", "fc66d4ab4354f417db347b6f73d6d212480c8a02" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Mon Aug 19 10:17:55 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Aug 19 10:17:55 2024 +0000" }, "message": "[automerger skipped] Merge remote-tracking branch \u0027aosp/mirror-chromium-main\u0027 am: 478bbbee6e am: fc66d4ab43 -s ours\n\nam skip reason: skipped by czapiga\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/vboot_reference/+/3179704\n\nChange-Id: Id6d9a5f6326338b4c8d1769da268aa4c20153bc9\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "486f4fb585dbdcd5e03eb600367d4f8e0e27a6bd", "tree": "2e5f7e1dc6b13e26cd7ed13c16c3e8c15d62a77f", "parents": [ "c9bfc260e70aa37d659433667bcb1bf0a4c107ac", "6429c0905eef2041f2a8d601ff7feddd657c388e" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Mon Aug 19 09:46:08 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Aug 19 09:46:08 2024 +0000" }, "message": "Add a empty change as a workaround of Error inserting change/patchset am: 6c52af401e am: 6429c0905e\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/vboot_reference/+/3179702\n\nChange-Id: I3ed67ed2a88d7fa4f27be0834fcd5aebf50cab38\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "eeea0d8329a1bc4fa929a11ea81e7d525ddc305b", "tree": "2e5f7e1dc6b13e26cd7ed13c16c3e8c15d62a77f", "parents": [ "fc66d4ab4354f417db347b6f73d6d212480c8a02", "de7a798d27ade0602fbdab0f57d5bf60f5770f36" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Mon Aug 19 09:30:20 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Aug 19 09:30:20 2024 +0000" }, "message": "Fix METADATA and OWNERS files am: de7a798d27\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/vboot_reference/+/3184806\n\nChange-Id: I4946e2f4afc9a9c5be6e879fe79beb517b79a64d\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "fc66d4ab4354f417db347b6f73d6d212480c8a02", "tree": "a62cce69c4f60b867a87be5b6953b4880b023a25", "parents": [ "6429c0905eef2041f2a8d601ff7feddd657c388e", "478bbbee6e1158dbad368a9dc7e116c7f5abddb9" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Mon Aug 19 09:30:11 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Aug 19 09:30:11 2024 +0000" }, "message": "Merge remote-tracking branch \u0027aosp/mirror-chromium-main\u0027 am: 478bbbee6e\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/vboot_reference/+/3179704\n\nChange-Id: Ife0a6fb333073a4374ffd4e12c23682018dd592d\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "6429c0905eef2041f2a8d601ff7feddd657c388e", "tree": "091176020462fc87022a319f8d06bcc49d59f4f9", "parents": [ "797bf3567d01d133ca7a0703ecbec1cfeb40bf23", "6c52af401e910c00bcdee969afdfa8b618974024" ], "author": { "name": "Jakub Czapiga", "email": "czapiga@google.com", "time": "Mon Aug 19 09:30:02 2024 +0000" }, "committer": { "name": "Automerger Merge Worker", "email": "android-build-automerger-merge-worker@system.gserviceaccount.com", "time": "Mon Aug 19 09:30:02 2024 +0000" }, "message": "Add a empty change as a workaround of Error inserting change/patchset am: 6c52af401e\n\nOriginal change: https://android-review.googlesource.com/c/platform/external/vboot_reference/+/3179702\n\nChange-Id: I882b9b7000ba734c1a3ae6848e4e9246e7b67d0d\nSigned-off-by: Automerger Merge Worker \u003candroid-build-automerger-merge-worker@system.gserviceaccount.com\u003e\n" }, { "commit": "8365d546ce0698faffd22cf3cb44c0c854f74637", "tree": "4d13777de143bf30edc5ff6860e6bf93fa1cbc52", "parents": [ "ec01126c04cd6ff985139d52f2c9eac486a2ae4c" ], "author": { "name": "Yu-Ping Wu", "email": "yupingso@chromium.org", "time": "Wed Aug 07 09:57:31 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Tue Aug 13 11:31:52 2024 +0000" }, "message": "futility/load_fmap: Erase remaining bytes if file smaller than area\n\nThe `futility load_fmap` subcommand allows the passed file to be smaller\nthan the corresponding FMAP area size. That\u0027s convenient for some use\ncases (such as EC\u0027s KEY_RO), because the caller doesn\u0027t need to have an\nextra step of enlarging the file to match the area size.\n\nHowever, the current implementation is to keep the remaining data in the\narea unmodified, which is often not the intention of the caller.\nTherefore, change the behavior by erasing the remaining bytes to 0xff.\n\nBUG\u003dnone\nTEST\u003dmake runfutiltests\nBRANCH\u003dnone\n\nChange-Id: Ib6575023801d995b7b25110bb411ec74d9a240f0\nSigned-off-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5768173\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" }, { "commit": "ec01126c04cd6ff985139d52f2c9eac486a2ae4c", "tree": "cc59b0b787e35729c499c99fe031a2e846b4e337", "parents": [ "b76d74dc08acd4f0905cd6baa2493a952f974b1a" ], "author": { "name": "Jack Rosenthal", "email": "jrosenth@chromium.org", "time": "Thu Aug 01 13:40:23 2024 -0600" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Aug 05 18:24:10 2024 +0000" }, "message": "swap_ec_rw: Search for keyset in source tree too\n\nWhen executing this script outside the SDK from the source tree,\n/usr/share/vboot/devkeys (the typical default for --keyset) won\u0027t be\navailable. Search for the devkeys inside vboot_reference too.\n\nBUG\u003db:352556657\nBRANCH\u003dnone\nTEST\u003dScript executes outside the SDK\n\nSigned-off-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nChange-Id: I1b7c8161acbd1d144208682cb7c035fa5f8d6e8d\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5757739\nReviewed-by: Yu-Ping Wu \u003cyupingso@chromium.org\u003e\n" }, { "commit": "b76d74dc08acd4f0905cd6baa2493a952f974b1a", "tree": "fdf518885645c76558585b11400c5e695637f832", "parents": [ "f1f70f46dc5482bb7c654e53ed58d4001e386df2" ], "author": { "name": "Ting Shen", "email": "phoenixshen@google.com", "time": "Wed Jul 31 16:30:02 2024 +0800" }, "committer": { "name": "Chromeos LUCI", "email": "chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Mon Aug 05 11:53:57 2024 +0000" }, "message": "futility/load_fmap: use WARN() on non-critical error\n\nFile size less than section size is not a critical error.\nThe wording causes user panic (e.g. b/356495697).\nChange ERROR() to WARN() to make the output message less scary.\n\nBRANCH\u003dnone\nBUG\u003dnone\nTEST\u003dbuild spikyrock EC, verify that the command output changed to\n \"WARNING: copy_to_area: ...\"\n\nChange-Id: Id1fc9050c9fdd95a12f605476b422921c0f4a751\nSigned-off-by: Ting Shen \u003cphoenixshen@google.com\u003e\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5751247\nCommit-Queue: Ting Shen \u003cphoenixshen@chromium.org\u003e\nTested-by: Ting Shen \u003cphoenixshen@chromium.org\u003e\nReviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\n" } ], "next": "f1f70f46dc5482bb7c654e53ed58d4001e386df2" }