Revert "vboot: update get system properties"
This reverts commit 8ef4f7a9a9a68bad49e8417d5ed346dc927e1d2c.
Reason for revert: Installer supposedly misuses API with
`VbGetSystemPropertyString("fw_try_next", NULL, 0);`
by passing a `NULL` ptr as dest and so not sized.
The call sites need checking.
BUG=b:280417931
TEST=none
Original change's description:
> vboot: update get system properties
>
> `VbGetSystemPropertyString` header promises that the property string
> will be read into the passed in dest buffer, however for some system
> properties the values are not placed in buffer but returned directly.
> this patch fixes that error
>
> Before, running `VbGetSystemPropertyString("minios_priority", buf,
> size):`
> ```
> buf: return value: B
> ```
> After, same command:
> ```
> buf: B return value: B
> ```
>
> BRANCH=none
> BUG=none
> TEST=Tested with an executable on brya
>
> Signed-off-by: Saketh Pothireddy <spothire@chromium.org>
>
> Change-Id: I87a0aa8638e719bc5bbea579ecaca4754a38c02e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4468208
> Reviewed-by: Jae Hoon Kim <kimjae@chromium.org>
> Reviewed-by: Julius Werner <jwerner@chromium.org>
> Commit-Queue: Saketh Pothireddy <spothire@google.com>
> Tested-by: Saketh Pothireddy <spothire@google.com>
Bug: none
Change-Id: Ie07363424db92832b485c9efae21edbf0d24fba5
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4508974
Commit-Queue: Edward O'Callaghan <quasisec@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Edward O'Callaghan <quasisec@chromium.org>
1 file changed
