Google GitGoogle Git
Sign in
android/platform/external/toolchain-utils/29c8cac9
commit
29c8cac9d0a133b96d213e28bb277f539582627b
[log]
author
George Burgess IV <gbiv@google.com>
Sat Oct 01 12:08:17 2022 -0700
committer
Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>
Mon Oct 03 20:29:42 2022 +0000
tree
27c8fb2291af29b65ef9e7c81682a675dd4eb47d
parent
8f7a10dd9cfe029803059de4043cf9ceb30c83ff [diff]
command: fix flaky test

If `exec` times out, we need to wrap the error it died with, rather than
embedding it in another error. This allows
`TestRunWithTimeoutReturnsErrorOnTimeout`'s `errors.Is` to correctly
detect that `err` is a `context.DeadlineExceeded`.

BUG=None
TEST=ran this test 1000x

Change-Id: I69e0dcea25dfd0cb01ac5ec0a2e8ce2f116deff7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/3932869
Auto-Submit: George Burgess <gbiv@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Tested-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
1 file changed
tree: 27c8fb2291af29b65ef9e7c81682a675dd4eb47d
  1. afdo_metadata/
  2. afdo_redaction/
  3. afdo_tools/
  4. bestflags/
  5. binary_search_tool/
  6. compiler_wrapper/
  7. cros_utils/
  8. crosperf/
  9. cwp/
  10. debug_info_test/
  11. go/
  12. heatmaps/
  13. llvm_extra/
  14. llvm_tools/
  15. orderfile/
  16. pgo_tools/
  17. pgo_tools_rust/
  18. rust-analyzer-chromiumos-wrapper/
  19. rust_tools/
  20. seccomp_tools/
  21. toolchain_utils_githooks/
  22. upstream_workon/
  23. .gitignore
  24. android_merge_from_upstream.sh
  25. auto_delete_nightly_test_data.py
  26. build_chromeos.py
  27. build_tc.py
  28. buildbot_test_llvm.py
  29. buildbot_test_toolchains.py
  30. chromiumos_image_diff.py
  31. compiler-test.sh
  32. crate_ebuild_help.py
  33. file_lock_machine.py
  34. file_lock_machine_test.py
  35. image_chromeos.py
  36. LICENSE
  37. lock_machine.py
  38. make_root_writable.py
  39. OWNERS
  40. OWNERS.toolchain
  41. PRESUBMIT.cfg
  42. pyrun
  43. README.chromium
  44. README.md
  45. remote_test.py
  46. run_tests_for.py
  47. tc_enter_chroot.py
  48. update_telemetry_defaults.py
README.md

toolchain-utils

Various utilities used by the ChromeOS toolchain team.

Note

To run Python scripts in this directory, first run:

export PYTHONPATH=$(readlink -f .):$PYTHONPATH

from this directory.

Then you can run any script.

To get help on any script, type in python <script> --help, or refer to the header of the script for more information.