commit 5bb8b44c587600b526360d00534457651437efc2
author Moreno Ambrosin <ambrosin@google.com> Fri Nov 25 04:36:48 2022 -0800
committer Copybara-Service <copybara-worker@google.com> Fri Nov 25 04:37:41 2022 -0800
tree 5972955a9bd553895148cad86ae31cb661690ffe
parent b1eb37685ff4b15a87d487c6d0f2b0ad7ced9afb

Split declaration of local variable from assignment to correctly propagate the exit code of the subshell

PiperOrigin-RevId: 490884671
Change-Id: Ie7d809d6efb2889c52eda360519f948ae899b790

kokoro/testutils/create_github_release.sh

diff --git a/kokoro/testutils/create_github_release.sh b/kokoro/testutils/create_github_release.sh
index 539cecb..7cbbf02 100755
--- a/kokoro/testutils/create_github_release.sh
+++ b/kokoro/testutils/create_github_release.sh
@@ -96,7 +96,11 @@
   readonly RELEASE_BRANCH="$(echo "${VERSION}" | cut -d'.' -f1,2)"
   readonly TAG="v${VERSION}"
 
-  local -r github_refs="$(git ls-remote ${GITHUB_REPO_URL})"
+  # Splitting declaration and assignment guarantees correct propagation of the
+  # exit code of the subshell.
+  local github_refs
+  github_refs="$(git ls-remote "${GITHUB_REPO_URL}")"
+  readonly github_refs
   local -r expected_release_branch="refs/heads/${RELEASE_BRANCH}"
   local -r expected_release_tag="refs/tags/${TAG}"
   if echo "${github_refs}" | grep "${expected_release_branch}" > /dev/null; then