commit d8bed4060ab0f5b089fe3c1ba045f7b15685cb62
author Mehdi Amini <aminim@google.com> Tue Dec 28 08:18:47 2021 -0800
committer TensorFlower Gardener <gardener@tensorflow.org> Tue Dec 28 08:28:17 2021 -0800
tree 5d4b422e1567cc9ca1022ca21575b8eff674867d
parent 1504b814525cb3708b13fbc802f275199ea4c7da

Apply clang-tidy fixes for llvm-else-after-return in hlo_ops.cc (NFC)

PiperOrigin-RevId: 418629867
Change-Id: I344d08d34771d83d9f833bdecddd9d0fca92765f

tensorflow/compiler/mlir/hlo/lib/Dialect/mhlo/IR/hlo_ops.cc

diff --git a/tensorflow/compiler/mlir/hlo/lib/Dialect/mhlo/IR/hlo_ops.cc b/tensorflow/compiler/mlir/hlo/lib/Dialect/mhlo/IR/hlo_ops.cc
index f84dd1f..d286d9a 100644
--- a/tensorflow/compiler/mlir/hlo/lib/Dialect/mhlo/IR/hlo_ops.cc
+++ b/tensorflow/compiler/mlir/hlo/lib/Dialect/mhlo/IR/hlo_ops.cc
@@ -1369,7 +1369,8 @@
     if (complex.getElementType().isa<FloatType>()) {
       return DenseElementsAttr::get(
           type, {splatOperandAttr.getSplatValue<std::complex<APFloat>>()});
-    } else if (complex.getElementType().isa<IntegerType>()) {
+    }
+    if (complex.getElementType().isa<IntegerType>()) {
       return DenseElementsAttr::get(
           type, {splatOperandAttr.getSplatValue<std::complex<APInt>>()});
     } else {
@@ -1507,7 +1508,8 @@
     if (complex.getElementType().isa<FloatType>()) {
       return DenseElementsAttr::get(
           type, {splatOperandAttr.getSplatValue<std::complex<APFloat>>()});
-    } else if (complex.getElementType().isa<IntegerType>()) {
+    }
+    if (complex.getElementType().isa<IntegerType>()) {
       return DenseElementsAttr::get(
           type, {splatOperandAttr.getSplatValue<std::complex<APInt>>()});
     } else {
@@ -1742,7 +1744,8 @@
 
   if (auto ranked_type = type.dyn_cast<RankedTensorType>()) {
     return RankedTensorType::get(ranked_type.getShape(), element_ty);
-  } else if (type.dyn_cast<UnrankedTensorType>()) {
+  }
+  if (type.dyn_cast<UnrankedTensorType>()) {
     return UnrankedTensorType::get(element_ty);
   }
 
@@ -3100,11 +3103,9 @@
     return failure();
 
   if (!reduceOpFntype || reduceOpFntype.getInputs().empty()) {
-    if (!reduceOpFntype)
-      return parser.emitError(loc, "expected function type");
-    else
-      return parser.emitError(loc,
-                              "input types missing in reduce-op function type");
+    if (!reduceOpFntype) return parser.emitError(loc, "expected function type");
+    return parser.emitError(loc,
+                            "input types missing in reduce-op function type");
   }
 
   // If location of reduce-op is explicitly provided, then use it; Else use
@@ -4569,7 +4570,8 @@
   if (etype.isa<IntegerType>()) {
     return FoldSlice<DenseElementsAttr::IntElementIterator, APInt>(
         this, elements.value_begin<APInt>());
-  } else if (etype.isa<FloatType>()) {
+  }
+  if (etype.isa<FloatType>()) {
     return FoldSlice<DenseElementsAttr::FloatElementIterator, APFloat>(
         this, elements.value_begin<APFloat>());
   }