Adding comments explaining why we don't use GTest's built in stacktraces. Also removed an unused header from stacktrace_handler.cc.
PiperOrigin-RevId: 263659753
diff --git a/tensorflow/core/BUILD b/tensorflow/core/BUILD
index 190319f..5e77577 100644
--- a/tensorflow/core/BUILD
+++ b/tensorflow/core/BUILD
@@ -804,7 +804,6 @@
hdrs = ["//tensorflow/core/platform:stacktrace_handler.h"],
deps = [
"//tensorflow/core/platform",
- "//tensorflow/core/platform:abi",
"//tensorflow/core/platform:stacktrace",
],
)
diff --git a/tensorflow/core/platform/stacktrace_handler.cc b/tensorflow/core/platform/stacktrace_handler.cc
index ff31c97..19fd4a3 100644
--- a/tensorflow/core/platform/stacktrace_handler.cc
+++ b/tensorflow/core/platform/stacktrace_handler.cc
@@ -30,7 +30,6 @@
#include <unistd.h>
#include <string>
-#include "tensorflow/core/platform/abi.h"
#include "tensorflow/core/platform/stacktrace.h"
#endif // defined(TF_GENERATE_STACKTRACE)
diff --git a/tensorflow/core/platform/stacktrace_handler.h b/tensorflow/core/platform/stacktrace_handler.h
index 9f118b9..aafafc8 100644
--- a/tensorflow/core/platform/stacktrace_handler.h
+++ b/tensorflow/core/platform/stacktrace_handler.h
@@ -20,6 +20,9 @@
namespace testing {
// Installs signal handlers to print out stack trace.
+// Although GoogleTest has support for generating stacktraces with abseil via
+// https://github.com/google/googletest/pull/1653, this doesn't cover our use
+// case of getting C++ stacktraces in our python tests.
void InstallStacktraceHandler();
} // namespace testing
