[Cleanup] Remove redundant inputs ref/unref during execution, since inputs are not set during instantiation.
PiperOrigin-RevId: 305897768
Change-Id: Ia1a697e198287aeadeb643cec7f11b918dd99bb4
diff --git a/tensorflow/core/distributed_runtime/eager/cluster_function_library_runtime.cc b/tensorflow/core/distributed_runtime/eager/cluster_function_library_runtime.cc
index 9322b13..1092485 100644
--- a/tensorflow/core/distributed_runtime/eager/cluster_function_library_runtime.cc
+++ b/tensorflow/core/distributed_runtime/eager/cluster_function_library_runtime.cc
@@ -154,6 +154,11 @@
EagerOperation* op = function_data->op.get();
+ if (!op->Inputs().empty()) {
+ done(errors::Internal("Inputs should not be set during instantiation."));
+ return;
+ }
+
eager::EnqueueRequest* request = new eager::EnqueueRequest;
request->set_context_id(context_id_);
eager::Operation* remote_op = request->add_queue()->mutable_operation();
@@ -183,17 +188,13 @@
op->Attrs().FillAttrValueMap(remote_op->mutable_attrs());
remote_op->set_device(function_data->target);
- for (auto handle : op->Inputs()) {
- handle->Ref();
- }
-
// StreamingEnqueueAsync may introduce a deadlock. When streaming RPC is
// disabled, Run() returns when the remote function execution completes, which
// might be blocked by a non-enqueued function execution.
EnqueueResponse* response = new EnqueueResponse;
eager_client->EnqueueAsync(
request, response,
- [op, request, response, rets, done = std::move(done)](const Status& s) {
+ [request, response, rets, done = std::move(done)](const Status& s) {
Status status = s;
auto cleanup = gtl::MakeCleanup([request, response, &status, &done] {
done(status);
@@ -201,9 +202,6 @@
delete response;
});
- for (auto handle : op->Inputs()) {
- handle->Unref();
- }
if (!status.ok()) {
return;
}
