tree a282203e391e58acfa5acc80b78ea248c7b25ed6
parent 63610e417b2d1bd99cb41e0bb5e129015b0aeb4e
author Denis Ovsienko <denis@ovsienko.info> 1601566605 +0100
committer Denis Ovsienko <denis@ovsienko.info> 1601568525 +0100

OpenFlow: Use bittok2str(), fix OF1.0 port status.

of_bitmap_print() used to have its own bitmap printing code, which would
yield a single closing parenthesis when none of the assigned tokens
matched (that was a bug, althought not triggered by any of the existing
tests). Simplify the function to use bittok2str() instead, then observe
some changes in OpenFlow 1.0 tests output. Apparently, the old code
implemented "match any" for multiple-bit tokens, and bittok2str() now
implements "match all".

However, in that protocol encoding bitmap tokens are always single-bit,
so examine the OFPPS_ props closer and realize that the "state" field of
the physical port structure includes both a tiny bitmap and a tiny code
point. Leave comments to clarify that, update the props and the printing
code. Update output for four tests.