commit 27bd41c876325b2b24155576c8a820d790f0d6ee
author Francois-Xavier Le Bail <devel.fx.lebail@orange.fr> Thu Nov 04 22:56:37 2021 +0100
committer Francois-Xavier Le Bail <devel.fx.lebail@orange.fr> Thu Nov 04 23:01:46 2021 +0100
tree ef64706b7a12ad7427eb74b6f9508ff63ee6e12b
parent 984685bef6884a772d1653b8588283c00f689343

EAP: Fix some undefined behaviors at runtime

The errors were like:
print-eap.c:179:25: runtime error: unsigned integer overflow:
  2 - 5 cannot be represented in type 'unsigned int'
print-eap.c:181:50: runtime error: unsigned integer overflow:
  2 - 5 cannot be represented in type 'unsigned int'
print-eap.c:186:25: runtime error: unsigned integer overflow:
  2 - 5 cannot be represented in type 'unsigned int'
print-eap.c:188:50: runtime error: unsigned integer overflow:
  2 - 5 cannot be represented in type 'unsigned int'

(cherry picked from commit 58a4ab67fc75b62968634cddec290c1f2e2c1ded)

print-eap.c

diff --git a/print-eap.c b/print-eap.c
index b0542ad..5d722ec 100644
--- a/print-eap.c
+++ b/print-eap.c
@@ -176,14 +176,14 @@
 
         switch (subtype) {
             case EAP_TYPE_IDENTITY:
-                if (len - 5 > 0) {
+                if (len > 5 ) {
                     ND_PRINT(", Identity: ");
                     nd_printjnp(ndo, cp + 5, len - 5);
                 }
                 break;
 
             case EAP_TYPE_NOTIFICATION:
-                if (len - 5 > 0) {
+                if (len > 5) {
                     ND_PRINT(", Notification: ");
                     nd_printjnp(ndo, cp + 5, len - 5);
                 }