tree 3edfe6af2197e01fdb80506d80e8e9150a743c75
parent cf228f9c23f69d71d7ab40e18026a1fc0186e6c3
author Leon Scroggins <scroggo@google.com> 1495546154 +0000
committer android-build-team Robot <android-build-team-robot@google.com> 1498509729 +0000

Cherry-pick a revert "sk_fgetsize to not use ftell."

Test: verified public sample documentation properly decodes
Bug: 62779478

This reverts commit eefa289a214ea3917e5e00554f231adb5ad6f712.

Reason for revert: Causing failures in BitmapFactoryTest. b/38233042

Original change's description:
> sk_fgetsize to not use ftell.
>
> The previous version of sk_fgetsize used ftell and fseek to compute
> the size of a file. There are so many issues with this that it is called
> out by securecoding.cert.org as FIO19-C as a thing not to do. We already
> have correct code for computing the size of a file in the mmap code, so
> use that instead.
>
> Change-Id: I1d771124989d0ec1523f6d858814ee563263213a
> Reviewed-on: https://skia-review.googlesource.com/9860
> Reviewed-by: Leon Scroggins <scroggo@google.com>
> Commit-Queue: Ben Wagner <bungeman@google.com>
>

TBR=bungeman@google.com,scroggo@google.com

Change-Id: Ie9392dde8747ae7c74ebfa00153705e316e841a2
Reviewed-on: https://skia-review.googlesource.com/17705
Reviewed-by: Leon Scroggins <scroggo@google.com>
Commit-Queue: Leon Scroggins <scroggo@google.com>
(cherry picked from commit e14a0aa7ea6a4494bbfae16864fab44c69b1f8d8)