| commit | ee525493eaa550a05c0b258c963be4babd241325 | [log] [tgz] |
|---|---|---|
| author | John Stiles <johnstiles@google.com> | Tue Nov 09 16:25:46 2021 -0500 |
| committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Tue Nov 09 22:09:49 2021 +0000 |
| tree | ab5bb60092a4979691120dc9a43bd303778d157f | |
| parent | 3b6e07098bd68c81367f6ffae7982d18d9c41877 [diff] |
Add test for incomplete expressions. The ExpressionStatement currently eliminates dangling references without reporting them as an error. This happens due to optimization; these expressions (being meaningless) have no side effects, and so the optimizer replaces them with Nop. When the optimizer is off, these programs trigger an assert: https://osscs.corp.google.com/skia/skia/+/main:src/sksl/SkSLAnalysis.cpp;l=582;drc=e7a953524787e3bd0c437ec52de4e40986689825 A followup CL will fix ExpressionStatements so that they report incomplete expressions as an error. Change-Id: Ica49166032e670749fc1b4e7a869fbab03364d4f Bug: skia:12472 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/469524 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com>