| commit | a6ec790e8c6a4740d2129a873741553d3244252b | [log] [tgz] |
|---|---|---|
| author | John Stiles <johnstiles@google.com> | Thu Mar 30 09:35:56 2023 -0400 |
| committer | SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> | Thu Mar 30 14:17:35 2023 +0000 |
| tree | efbe84a85a95a19efd48f1d14e00a5511662eb6d | |
| parent | 31e5cc84238dcfbca36181ced1d7d217d6ec87c0 [diff] |
Fix ordering of trace-exit and load-return-mask ops. Previously, we would emit a trace-exit op before restoring the return mask to the parent's value. This meant that trace-exit ops would not be present in the trace output, since the execution mask was off when `trace_exit` was encountered. In practice, this didn't affect all cases because we do not use the return mask in sufficiently simple functions, but it would cause tests like Mandelbrot to generate broken traces. (https://shaders.skia.org/?id=7cd08fc6b1b23121529c62e31e00b4bd6b49deba9a3904fd01fda3dc5c590050 Change-Id: Ic0a28e2f844245f98addd65ca331b9ef8892eeb9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/663916 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>