| commit | 41e377d1baf0dbf1355ec644a6fe40f6da48fc43 | [log] [tgz] |
|---|---|---|
| author | Brian Salomon <bsalomon@google.com> | Tue May 05 01:27:57 2020 +0000 |
| committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Tue May 05 01:28:11 2020 +0000 |
| tree | 46271636fccb3a807e17c9c3073741d4cfe53820 | |
| parent | 6d2febd632a2e47af46ca4190bc09208087bb04a [diff] |
Revert "Support large kernels on GPU in matrix convolution effect" This reverts commit 1ed4391fe7d218caf21754de0932b5e96043621e. Reason for revert: Looks like some bad images showed up at gold.skia.org and that the ProcessorCloneTest is crashing on Windows bots: https://logs.chromium.org/logs/skia/4bfabe0bad476911/+/steps/dm/0/stdout Original change's description: > Support large kernels on GPU in matrix convolution effect > > Currently matrix convolution falls back to CPU execution for large kernels, due to the argument limit for fragment shaders. > > Now for large kernels, we store them in a texture and sample them in a shader to sidestep the limit. > > Change-Id: Icc069a701ea8e9cd0adf75f4bfd149fd22e31afd > Bug: skia:8449 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/263495 > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > Commit-Queue: Adlai Holler <adlai@google.com> TBR=robertphillips@google.com,michaelludwig@google.com,adlai@google.com Change-Id: Iaf4858131046a343481bcf0fd9cc3919d9fc2bda No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:8449 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/287736 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>