Reject $pure functions with out parameters.

Pure functions should not change any state, and should be safe to
eliminate if their result is not used; this is incompatible with
out-parameters, so we forbid it here. (We don't exhaustively guard
against pure functions changing global state in other ways, though,
since they aren't allowed in user code.)

Bug: skia:14612
Change-Id: Ide15f04f288b9b819b525729e45098853f8196ec
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/721777
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: John Stiles <johnstiles@google.com>
12 files changed