commit 19f68c5de0d0181e5a11fcf918696ce4a0607ba0
author Oliver Kunz <okunz@google.com> Fri Nov 15 01:16:48 2024 -0800
committer Copybara-Service <copybara-worker@google.com> Fri Nov 15 01:17:33 2024 -0800
tree 1a5ffa997bd79e963965b32e9b6d5db4ece39be4
parent c5846a32f382a1f49066babc22f0b1523ccb7939

Explicitly don't support setting the remote address of a RemotePtr outside of the constructor.

This behaviour is in line with sapi::v::Proto.

PiperOrigin-RevId: 696800825
Change-Id: Ied6eaa6f464530b184b2e719e22080921fd226fa

sandboxed_api/var_ptr.h

diff --git a/sandboxed_api/var_ptr.h b/sandboxed_api/var_ptr.h
index 2c9894f..774e48e 100644
--- a/sandboxed_api/var_ptr.h
+++ b/sandboxed_api/var_ptr.h
@@ -22,6 +22,7 @@
 
 #include "absl/base/attributes.h"
 #include "absl/base/macros.h"
+#include "absl/log/log.h"
 #include "absl/strings/str_format.h"
 #include "sandboxed_api/var_abstract.h"
 #include "sandboxed_api/var_reg.h"
@@ -98,6 +99,10 @@
     pointed_obj_.SetRemote(remote_addr);
   }
 
+  void SetRemote(void* /* remote */) override {
+    LOG(FATAL) << "SetRemote not supported on RemotePtr";
+  }
+
  private:
   Reg<void*> pointed_obj_;
 };