commit a35d18bcdcf1018bad4f2c7f694bc3ed4453f197
author David Tolnay <dtolnay@gmail.com> Thu Jul 06 12:19:09 2023 -0700
committer David Tolnay <dtolnay@gmail.com> Thu Jul 06 12:19:14 2023 -0700
tree 5cdb57b3524e1ca349c79bea612f33ff9164cd7c
parent a6c1419a666c1cba68931d608b7c212177488df4

Resolve redundant_closure_for_method_calls pedantic clippy lint

    warning: redundant closure
      --> gen/src/cfg.rs:64:45
       |
    64 |             let value = string.as_ref().map(|string| string.value());
       |                                             ^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `syn::LitStr::value`
       |
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls
       = note: `-W clippy::redundant-closure-for-method-calls` implied by `-W clippy::pedantic`

gen/build/src/lib.rs

diff --git a/gen/build/src/lib.rs b/gen/build/src/lib.rs
index 262a258..9d681bd 100644
--- a/gen/build/src/lib.rs
+++ b/gen/build/src/lib.rs
@@ -66,7 +66,6 @@
     clippy::nonminimal_bool,
     clippy::option_if_let_else,
     clippy::or_fun_call,
-    clippy::redundant_closure_for_method_calls,
     clippy::redundant_else,
     clippy::semicolon_if_nothing_returned,
     clippy::shadow_unrelated,

gen/cmd/src/main.rs

diff --git a/gen/cmd/src/main.rs b/gen/cmd/src/main.rs
index 8952124..0bc0e1b 100644
--- a/gen/cmd/src/main.rs
+++ b/gen/cmd/src/main.rs
@@ -18,7 +18,6 @@
     clippy::nonminimal_bool,
     clippy::option_if_let_else,
     clippy::or_fun_call,
-    clippy::redundant_closure_for_method_calls,
     clippy::redundant_else,
     clippy::semicolon_if_nothing_returned,
     clippy::shadow_unrelated,

gen/lib/src/lib.rs

diff --git a/gen/lib/src/lib.rs b/gen/lib/src/lib.rs
index c6500d7..ddf0c44 100644
--- a/gen/lib/src/lib.rs
+++ b/gen/lib/src/lib.rs
@@ -29,7 +29,6 @@
     clippy::nonminimal_bool,
     clippy::option_if_let_else,
     clippy::or_fun_call,
-    clippy::redundant_closure_for_method_calls,
     clippy::redundant_else,
     clippy::semicolon_if_nothing_returned,
     clippy::shadow_unrelated,

gen/src/cfg.rs

diff --git a/gen/src/cfg.rs b/gen/src/cfg.rs
index da58908..adab6e5 100644
--- a/gen/src/cfg.rs
+++ b/gen/src/cfg.rs
@@ -4,7 +4,7 @@
 use crate::syntax::Api;
 use quote::quote;
 use std::collections::BTreeSet as Set;
-use syn::Error;
+use syn::{Error, LitStr};
 
 pub(super) struct UnsupportedCfgEvaluator;
 
@@ -61,7 +61,7 @@
         CfgExpr::Unconditional => Ok(true),
         CfgExpr::Eq(ident, string) => {
             let key = ident.to_string();
-            let value = string.as_ref().map(|string| string.value());
+            let value = string.as_ref().map(LitStr::value);
             match cfg_evaluator.eval(&key, value.as_deref()) {
                 CfgResult::True => Ok(true),
                 CfgResult::False => Ok(false),