commit f3ebf06e98342738fdda2b9619abdcbc6d4cab0d
author Peter Bell <peterbell10@live.co.uk> Tue Jan 25 13:57:07 2022 -0800
committer PyTorch MergeBot <pytorchmergebot@users.noreply.github.com> Tue Jan 25 22:30:48 2022 +0000
tree 2479cb65f23e645319c17db93dfb1ba501bb934b
parent dba42056d837ce453b8ad3e07ae118859c28a0a0

Release GIL when assigning to real or imag components (#71747)

Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/71747

The getter is trivial as it's just creating a view tensor, but the
setter is actually copying data so does call into kernel code.

Test Plan: Imported from OSS

Reviewed By: anjali411

Differential Revision: D33770046

Pulled By: albanD

fbshipit-source-id: f0a70acaef790ae1e5b2f68ac4ce046e850c9624
(cherry picked from commit 36a0109400b256b32a185fcd05f21f302197c081)

torch/csrc/autograd/python_variable.cpp

diff --git a/torch/csrc/autograd/python_variable.cpp b/torch/csrc/autograd/python_variable.cpp
index bec7012..2b16742 100644
--- a/torch/csrc/autograd/python_variable.cpp
+++ b/torch/csrc/autograd/python_variable.cpp
@@ -1061,9 +1061,13 @@
 {
   HANDLE_TH_ERRORS
   auto& self_ = THPVariable_Unpack(self);
-  auto self_real = at::real(self_);
-  self_real.copy_(THPVariable_Unpack(real));
-  return 0;
+  auto& real_ = THPVariable_Unpack(real);
+  {
+    pybind11::gil_scoped_release no_gil;
+    auto self_real = at::real(self_);
+    self_real.copy_(real_);
+    return 0;
+  }
   END_HANDLE_TH_ERRORS_RET(-1)
 }
 
@@ -1071,9 +1075,13 @@
 {
   HANDLE_TH_ERRORS
   auto& self_ = THPVariable_Unpack(self);
-  auto self_imag = at::imag(self_);
-  self_imag.copy_(THPVariable_Unpack(imag));
-  return 0;
+  auto& imag_ = THPVariable_Unpack(imag);
+  {
+    pybind11::gil_scoped_release no_gil;
+    auto self_imag = at::imag(self_);
+    self_imag.copy_(imag_);
+    return 0;
+  }
   END_HANDLE_TH_ERRORS_RET(-1)
 }