commit ec4be4e58c0dc11f1592aa432988573061ccb37e
author Gaurav Singh <gaurav1086@gmail.com> Tue Jan 21 11:26:22 2020 -0800
committer Facebook Github Bot <facebook-github-bot@users.noreply.github.com> Tue Jan 21 11:30:49 2020 -0800
tree 50d9ab61ce9ee71a1cdb2e02f34e171f3c97023a
parent 839fe714decfdffda6b7965966624b06388ae40e

Redundant condition (#32396)

Summary:
Optimize expression: 'A || (!A && B)' <=> 'A || B'

A: relErr <= maxRelErr
!A : relErr > maxRelErr
B: absErr <= absErrForRelErrFailure
Pull Request resolved: https://github.com/pytorch/pytorch/pull/32396

Differential Revision: D19499370

Pulled By: ezyang

fbshipit-source-id: c19bdcb2d4e7ff7806a8cd181c6e7e9e276b9979

caffe2/operators/conv_transpose_op_mobile_test.cc

diff --git a/caffe2/operators/conv_transpose_op_mobile_test.cc b/caffe2/operators/conv_transpose_op_mobile_test.cc
index 51d24da..29d3ab0 100644
--- a/caffe2/operators/conv_transpose_op_mobile_test.cc
+++ b/caffe2/operators/conv_transpose_op_mobile_test.cc
@@ -140,8 +140,7 @@
           // For small values / small difference, the relative error
           // can be huge but the absolute error will be small
           EXPECT_TRUE(relErr <= maxRelErr ||
-                      (relErr > maxRelErr &&
-                       absErr <= absErrForRelErrFailure)) <<
+                      (absErr <= absErrForRelErrFailure)) <<
             v1 << " " << v2 << " (rel err " << relErr << ") " <<
             "(" << n << " " << c << " " << h << " " << w << ") " <<
             "running N " << N << " inputC " << inputC <<