commit dad125a64bf2db534d074bce65478a87b964d090
author Dan Zimmerman <danzimm@meta.com> Wed Jul 31 13:41:56 2024 +0000
committer PyTorch MergeBot <pytorchmergebot@users.noreply.github.com> Wed Jul 31 13:41:56 2024 +0000
tree 7dbeb51aa01e57954ee9c11cdfe9c8ed48e18d29
parent 45e6a364ee1af5a75cf145fbb7da879a356785bd

Address clang-tidy nits in BFloat16 (#132203)

Summary: In https://github.com/pytorch/pytorch/pull/131359 I forgot to amend with clang-tidy fixes before merging. This addresses that.

Test Plan: CI

Pull Request resolved: https://github.com/pytorch/pytorch/pull/132203
Approved by: https://github.com/houseroad

c10/util/BFloat16.h

diff --git a/c10/util/BFloat16.h b/c10/util/BFloat16.h
index b5cd681..5f00e5e 100644
--- a/c10/util/BFloat16.h
+++ b/c10/util/BFloat16.h
@@ -76,8 +76,8 @@
   } else {
     // NOLINTNEXTLINE(cppcoreguidelines-pro-type-member-init)
     union {
-      uint32_t U32;
-      float F32;
+      uint32_t U32; // NOLINT(facebook-hte-BadMemberName)
+      float F32; // NOLINT(facebook-hte-BadMemberName)
     };
 
     F32 = src;
@@ -104,7 +104,7 @@
 
   constexpr C10_HOST_DEVICE BFloat16(unsigned short bits, from_bits_t)
       : x(bits) {}
-  inline C10_HOST_DEVICE BFloat16(float value);
+  /* implicit */ inline C10_HOST_DEVICE BFloat16(float value);
   inline C10_HOST_DEVICE operator float() const;
 
 #if defined(__CUDACC__)