| commit | c1356216a272a2a52479e87e183000922e1844fc | [log] [tgz] |
|---|---|---|
| author | Luke Yeager <lukeyeager@users.noreply.github.com> | Tue Aug 22 14:09:53 2017 -0700 |
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | Tue Aug 22 14:22:36 2017 -0700 |
| tree | 0402a7387fb499e5e9ba76918f8bc880c0db5eed | |
| parent | 5748e7140fc8fb07f253f9e19429218d90cb54d6 [diff] |
cmake: generate macros.h with configure_file() Summary: Using file(WRITE) caused the file to be rewritten for every CMake reconfigure, which was causing unnecessary full rebuilds of the project even when no source files changed. The new strategy has the added benefit of enforcing that the macros.h file is always generated correctly. When the main project relies on this header for macro definitions (instead of relying on add_definitions()), we can be more confident that the project will build correctly when used as a library (which is the whole point of the macros.h file). Upsides: * No more unnecessary rebuilds * Higher confidence that the project will compile properly as a third-party library Downsides: * Developers need to add an entry to `macros.h.in` whenever they would have added a new definition with `add_definitions()` Closes https://github.com/caffe2/caffe2/pull/1103 Differential Revision: D5680367 Pulled By: Yangqing fbshipit-source-id: 4db29c28589efda1b6a3f5f88752e3984260a0f2
Caffe2 is a lightweight, modular, and scalable deep learning framework. Building on the original Caffe, Caffe2 is designed with expression, speed, and modularity in mind.
Caffe2 research award competition request for proposals
Please use Github issues (https://github.com/caffe2/caffe2/issues) to ask questions, report bugs, and request new features.
Please participate in our survey (https://www.surveymonkey.com/r/caffe2). We will send you information about new releases and special developer events/webinars.
Caffe2 is released under the BSD 2-Clause license.