[PyTorch] Remove unused dump() methods in vec headers (#63533)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/63533
These methods don't seem to be used, and they use std::cout, which incurs a small code size overhead on platforms using libstdc++ due to std::__ioinit (see #61500). Seems like we can just delete them?
ghstack-source-id: 136163409
Test Plan:
CI
Reviwers: #sentinel, dhruvbird
Reviewed By: dskhudia
Differential Revision: D30412269
fbshipit-source-id: 380b9aa2f9aabc4107188b6b209d2afc1769c0ee
diff --git a/aten/src/ATen/cpu/vec/vec256/vec256_int.h b/aten/src/ATen/cpu/vec/vec256/vec256_int.h
index 86cf425..ab8e1d0 100644
--- a/aten/src/ATen/cpu/vec/vec256/vec256_int.h
+++ b/aten/src/ATen/cpu/vec/vec256/vec256_int.h
@@ -237,12 +237,6 @@
std::memcpy(ptr, tmp_values, count * sizeof(int32_t));
}
}
- void dump() const {
- for (size_t i = 0; i < size(); ++i) {
- std::cout << (int)((value_type*)&values)[i] << " ";
- }
- std::cout << std::endl;
- }
const int32_t& operator[](int idx) const = delete;
int32_t& operator[](int idx) = delete;
Vectorized<int32_t> abs() const {
diff --git a/aten/src/ATen/cpu/vec/vec256/vec256_qint.h b/aten/src/ATen/cpu/vec/vec256/vec256_qint.h
index dc5e833..b247d46 100644
--- a/aten/src/ATen/cpu/vec/vec256/vec256_qint.h
+++ b/aten/src/ATen/cpu/vec/vec256/vec256_qint.h
@@ -309,12 +309,6 @@
return _mm256_add_epi32(rounded, zero_point_v);
}
- void dump() const {
- for (size_t i = 0; i < 8; ++i) {
- std::cout << ((int32_t*)&vals)[i] << " ";
- }
- std::cout << std::endl;
- }
private:
// Load from memory constructor
Vectorized(const void* ptr) {
@@ -537,12 +531,6 @@
return RequantizeAvx2<value_type>(inp, multiplier_v, zero_point_v);
}
- void dump() const {
- for (size_t i = 0; i < size(); ++i) {
- std::cout << (int)((value_type*)&vals)[i] << " ";
- }
- std::cout << std::endl;
- }
private:
// Load from memory constructor
Vectorized(const void* ptr) {
@@ -702,12 +690,6 @@
return RequantizeAvx2<value_type>(inp, multiplier_v, zero_point_v);
}
- void dump() const {
- for (size_t i = 0; i < size(); ++i) {
- std::cout << (int)((value_type*)&vals)[i] << " ";
- }
- std::cout << std::endl;
- }
private:
// Load from memory constructor
@@ -792,13 +774,6 @@
return rv;
}
- void dump() const {
- for (int i = 0; i < size(); ++i) {
- std::cout << vals[i] << " ";
- }
- std::cout << std::endl;
- }
-
protected:
VectorizedQuantizedConverter() {}
};
diff --git a/aten/src/ATen/cpu/vec/vec256/vsx/vec256_qint32_vsx.h b/aten/src/ATen/cpu/vec/vec256/vsx/vec256_qint32_vsx.h
index ed457b9..5b1622e 100644
--- a/aten/src/ATen/cpu/vec/vec256/vsx/vec256_qint32_vsx.h
+++ b/aten/src/ATen/cpu/vec/vec256/vsx/vec256_qint32_vsx.h
@@ -196,18 +196,6 @@
return {veci0, veci1};
}
- void dump() const {
- std::cout << _vec0[0] << " ";
- std::cout << _vec0[1] << " ";
- std::cout << _vec0[2] << " ";
- std::cout << _vec0[3] << " ";
- std::cout << _vec1[0] << " ";
- std::cout << _vec1[1] << " ";
- std::cout << _vec1[2] << " ";
- std::cout << _vec1[3] << " ";
- std::cout << std::endl;
- }
-
DEFINE_MEMBER_OP(operator==, c10::qint32, vec_cmpeq)
DEFINE_MEMBER_OP(operator!=, c10::qint32, vec_cmpne)
DEFINE_MEMBER_OP(operator<, c10::qint32, vec_cmplt)
diff --git a/aten/src/ATen/cpu/vec/vec256/vsx/vec256_qint8_vsx.h b/aten/src/ATen/cpu/vec/vec256/vsx/vec256_qint8_vsx.h
index f2a8446..82b2530 100644
--- a/aten/src/ATen/cpu/vec/vec256/vsx/vec256_qint8_vsx.h
+++ b/aten/src/ATen/cpu/vec/vec256/vsx/vec256_qint8_vsx.h
@@ -361,15 +361,6 @@
return {vec0, vec1};
}
- void dump() const {
- value_type vals[size()];
- store((void*)vals);
- for (int i = 0; i < size(); ++i) {
- std::cout << (int)(vals[i]) << " ";
- }
- std::cout << std::endl;
- }
-
DEFINE_MEMBER_OP(operator==, c10::qint8, vec_cmpeq)
DEFINE_MEMBER_OP(operator!=, c10::qint8, vec_cmpne)
DEFINE_MEMBER_OP(operator<, c10::qint8, vec_cmplt)
diff --git a/aten/src/ATen/cpu/vec/vec512/vec512_int.h b/aten/src/ATen/cpu/vec/vec512/vec512_int.h
index cc866c0..f28c14e 100644
--- a/aten/src/ATen/cpu/vec/vec512/vec512_int.h
+++ b/aten/src/ATen/cpu/vec/vec512/vec512_int.h
@@ -270,12 +270,6 @@
std::memcpy(ptr, tmp_values, count * sizeof(int32_t));
}
}
- void dump() const {
- for (size_t i = 0; i < size(); ++i) {
- std::cout << (int)((value_type*)&values)[i] << " ";
- }
- std::cout << std::endl;
- }
const int32_t& operator[](int idx) const = delete;
int32_t& operator[](int idx) = delete;
Vectorized<int32_t> abs() const {
diff --git a/aten/src/ATen/cpu/vec/vec512/vec512_qint.h b/aten/src/ATen/cpu/vec/vec512/vec512_qint.h
index 5b5ac19..3a1eda8 100644
--- a/aten/src/ATen/cpu/vec/vec512/vec512_qint.h
+++ b/aten/src/ATen/cpu/vec/vec512/vec512_qint.h
@@ -321,12 +321,6 @@
return _mm512_add_epi32(rounded, zero_point_v);
}
- void dump() const {
- for (size_t i = 0; i < 16; ++i) {
- std::cout << ((int32_t*)&vals)[i] << " ";
- }
- std::cout << std::endl;
- }
private:
// Load from memory constructor
Vectorized(const void* ptr) {
@@ -549,12 +543,6 @@
return RequantizeAvx512<value_type>(inp, multiplier_v, zero_point_v);
}
- void dump() const {
- for (size_t i = 0; i < size(); ++i) {
- std::cout << (int)((value_type*)&vals)[i] << " ";
- }
- std::cout << std::endl;
- }
private:
// Load from memory constructor
Vectorized(const void* ptr) {
@@ -714,12 +702,6 @@
return RequantizeAvx512<value_type>(inp, multiplier_v, zero_point_v);
}
- void dump() const {
- for (size_t i = 0; i < size(); ++i) {
- std::cout << (int)((value_type*)&vals)[i] << " ";
- }
- std::cout << std::endl;
- }
private:
// Load from memory constructor
@@ -806,13 +788,6 @@
return rv;
}
- void dump() const {
- for (int i = 0; i < size(); ++i) {
- std::cout << vals[i] << " ";
- }
- std::cout << std::endl;
- }
-
protected:
VectorizedQuantizedConverter() {}
};
