Combine comparison methods and functions
The methods were separate because PyTorch supports multiple output types
for comparison methods. For example, for FloatTensors 'a' and 'b' both
calls are vaild:
torch.lt(a, b, out=<ByteTensor>)
torch.lt(a, b, out=<FloatTensor>)
ATen only supports ByteTensor outputs because the overloads have the
same static signature and would conflict. It would be nice to fix this
in the future like with the bernoulli function.
In the meantime, the separate function and method definitions with
different argument names make implementing VariableType more difficult.
diff --git a/aten/src/ATen/Declarations.cwrap b/aten/src/ATen/Declarations.cwrap
index c9deff3..5df05c7 100644
--- a/aten/src/ATen/Declarations.cwrap
+++ b/aten/src/ATen/Declarations.cwrap
@@ -886,6 +886,7 @@
name: lt
variants:
- method
+ - function
return: argument 0
options:
- cname: ltValue
@@ -919,42 +920,10 @@
- arg: THTensor* other
]]
[[
- name: lt
- variants:
- - function
- return: argument 0
- options:
- - cname: ltValue
- arguments:
- - arg: THBoolTensor* result
- output: True
- - THTensor* tensor
- - real value
- - cname: ltTensor
- arguments:
- - arg: THBoolTensor* result
- output: True
- - arg: THTensor* tensor
- broadcast: other fallback
- - THTensor* other
- - cname: ltValueT
- arguments:
- - arg: THTensor* result
- output: True
- - THTensor* tensor
- - real value
- - cname: ltTensorT
- arguments:
- - arg: THTensor* result
- output: True
- - arg: THTensor* tensor
- broadcast: other fallback
- - THTensor* other
-]]
-[[
name: gt
variants:
- method
+ - function
return: argument 0
options:
- cname: gtValue
@@ -988,43 +957,10 @@
- THTensor* other
]]
[[
- name: gt
- variants:
- - function
- return: argument 0
- options:
- - cname: gtValue
- arguments:
- - arg: THBoolTensor* result
- output: True
- - THTensor* tensor
- - real value
- - cname: gtTensor
- arguments:
- - arg: THBoolTensor* result
- output: True
- - arg: THTensor* tensor
- broadcast: other fallback
- - THTensor* other
- - cname: gtValueT
- arguments:
- - arg: THTensor* result
- output: True
- - THTensor* tensor
- - real value
- - cname: gtTensorT
- arguments:
- - arg: THTensor* result
- output: True
- - arg: THTensor* tensor
- broadcast: other fallback
- - THTensor* other
-
-]]
-[[
name: le
variants:
- method
+ - function
return: argument 0
options:
- cname: leValue
@@ -1058,42 +994,10 @@
- THTensor* other
]]
[[
- name: le
- variants:
- - function
- return: argument 0
- options:
- - cname: leValue
- arguments:
- - arg: THBoolTensor* result
- output: True
- - THTensor* tensor
- - real value
- - cname: leTensor
- arguments:
- - arg: THBoolTensor* result
- output: True
- - arg: THTensor* tensor
- broadcast: other fallback
- - THTensor* other
- - cname: leValueT
- arguments:
- - arg: THTensor* result
- output: True
- - THTensor* tensor
- - real value
- - cname: leTensorT
- arguments:
- - arg: THTensor* result
- output: True
- - arg: THTensor* tensor
- broadcast: other fallback
- - THTensor* other
-]]
-[[
name: ge
variants:
- method
+ - function
return: argument 0
options:
- cname: geValue
@@ -1127,42 +1031,10 @@
- THTensor* other
]]
[[
- name: ge
- variants:
- - function
- return: argument 0
- options:
- - cname: geValue
- arguments:
- - arg: THBoolTensor* result
- output: True
- - THTensor* tensor
- - real value
- - cname: geTensor
- arguments:
- - arg: THBoolTensor* result
- output: True
- - arg: THTensor* tensor
- broadcast: other fallback
- - THTensor* other
- - cname: geValueT
- arguments:
- - arg: THTensor* result
- output: True
- - THTensor* tensor
- - real value
- - cname: geTensorT
- arguments:
- - arg: THTensor* result
- output: True
- - arg: THTensor* tensor
- broadcast: other fallback
- - THTensor* other
-]]
-[[
name: eq
variants:
- method
+ - function
return: argument 0
options:
- cname: eqValue
@@ -1196,42 +1068,10 @@
- THTensor* other
]]
[[
- name: eq
- variants:
- - function
- return: argument 0
- options:
- - cname: eqValue
- arguments:
- - arg: THBoolTensor* result
- output: True
- - THTensor* tensor
- - real value
- - cname: eqTensor
- arguments:
- - arg: THBoolTensor* result
- output: True
- - arg: THTensor* tensor
- broadcast: other fallback
- - THTensor* other
- - cname: eqValueT
- arguments:
- - arg: THTensor* result
- output: True
- - THTensor* tensor
- - real value
- - cname: eqTensorT
- arguments:
- - arg: THTensor* result
- output: True
- - arg: THTensor* tensor
- broadcast: other fallback
- - THTensor* other
-]]
-[[
name: ne
variants:
- method
+ - function
return: argument 0
options:
- cname: neValue
@@ -1265,39 +1105,6 @@
- THTensor* other
]]
[[
- name: ne
- variants:
- - function
- return: argument 0
- options:
- - cname: neValue
- arguments:
- - arg: THBoolTensor* result
- output: True
- - THTensor* tensor
- - real value
- - cname: neTensor
- arguments:
- - arg: THBoolTensor* result
- output: True
- - arg: THTensor* tensor
- broadcast: other fallback
- - THTensor* other
- - cname: neValueT
- arguments:
- - arg: THTensor* result
- output: True
- - THTensor* tensor
- - real value
- - cname: neTensorT
- arguments:
- - arg: THTensor* result
- output: True
- - arg: THTensor* tensor
- broadcast: other fallback
- - THTensor* other
-]]
-[[
name: min
variants:
- method
