Remove useless code (#56230)
Summary:
Since we're using specific VS, we don't need to specify VC version.
In fact, the VC version is not used in CI now.
Why I make this change now?
I'm writing a robot to update the vs_install.ps1 (https://github.com/pytorch/pytorch/pull/56261/) every 2 weeks.
It will submit a PR to check if the latest VS is compatible with PyTorch automatically.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/56230
Reviewed By: bdhirsh
Differential Revision: D27856647
Pulled By: ezyang
fbshipit-source-id: b46f2bdf35ab5841fded470e23bbf7a01d5f60f4
diff --git a/.circleci/cimodel/data/windows_build_definitions.py b/.circleci/cimodel/data/windows_build_definitions.py
index 3c5164f..d4f8118 100644
--- a/.circleci/cimodel/data/windows_build_definitions.py
+++ b/.circleci/cimodel/data/windows_build_definitions.py
@@ -125,7 +125,7 @@
def TruePred(_):
return True
-_VC2019 = VcSpec(2019, ["14", "28", "29333"], hide_version=True)
+_VC2019 = VcSpec(2019)
WORKFLOW_DATA = [
# VS2019 CUDA-10.1
diff --git a/.circleci/config.yml b/.circleci/config.yml
index 403c340..06aa721 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -6786,7 +6786,7 @@
python_version: "3.6"
use_cuda: "1"
vc_product: BuildTools
- vc_version: "14.28.29333"
+ vc_version: ""
vc_year: "2019"
- pytorch_windows_test:
build_environment: pytorch-win-vs2019-cuda10-cudnn7-py3
@@ -6799,7 +6799,7 @@
test_name: pytorch-windows-test1
use_cuda: "1"
vc_product: BuildTools
- vc_version: "14.28.29333"
+ vc_version: ""
vc_year: "2019"
- pytorch_windows_test:
build_environment: pytorch-win-vs2019-cuda10-cudnn7-py3
@@ -6812,7 +6812,7 @@
test_name: pytorch-windows-test2
use_cuda: "1"
vc_product: BuildTools
- vc_version: "14.28.29333"
+ vc_version: ""
vc_year: "2019"
- pytorch_windows_build:
build_environment: pytorch-win-vs2019-cuda11-cudnn8-py3
@@ -6821,7 +6821,7 @@
python_version: "3.6"
use_cuda: "1"
vc_product: BuildTools
- vc_version: "14.28.29333"
+ vc_version: ""
vc_year: "2019"
- pytorch_windows_test:
build_environment: pytorch-win-vs2019-cuda11-cudnn8-py3
@@ -6840,7 +6840,7 @@
test_name: pytorch-windows-test1
use_cuda: "1"
vc_product: BuildTools
- vc_version: "14.28.29333"
+ vc_version: ""
vc_year: "2019"
- pytorch_windows_test:
build_environment: pytorch-win-vs2019-cuda11-cudnn8-py3
@@ -6859,7 +6859,7 @@
test_name: pytorch-windows-test2
use_cuda: "1"
vc_product: BuildTools
- vc_version: "14.28.29333"
+ vc_version: ""
vc_year: "2019"
- pytorch_windows_build:
build_environment: pytorch-win-vs2019-cpu-py3
@@ -6868,7 +6868,7 @@
python_version: "3.6"
use_cuda: "0"
vc_product: BuildTools
- vc_version: "14.28.29333"
+ vc_version: ""
vc_year: "2019"
- pytorch_windows_test:
build_environment: pytorch-win-vs2019-cpu-py3
@@ -6886,7 +6886,7 @@
test_name: pytorch-windows-test1
use_cuda: "0"
vc_product: BuildTools
- vc_version: "14.28.29333"
+ vc_version: ""
vc_year: "2019"
- pytorch_windows_test:
build_environment: pytorch-win-vs2019-cpu-py3
@@ -6904,7 +6904,7 @@
test_name: pytorch-windows-test2
use_cuda: "0"
vc_product: BuildTools
- vc_version: "14.28.29333"
+ vc_version: ""
vc_year: "2019"
- pytorch_windows_test:
build_environment: pytorch-win-vs2019-cuda10-cudnn7-py3
@@ -6922,7 +6922,7 @@
test_name: pytorch-windows-test1
use_cuda: "0"
vc_product: BuildTools
- vc_version: "14.28.29333"
+ vc_version: ""
vc_year: "2019"
- update_s3_htmls:
context: org-member