commit 7e81a89e13911c8324466d503d0cfd4c16f8637e
author Scott Wolchok <swolchok@fb.com> Tue Oct 19 11:28:09 2021 -0700
committer Facebook GitHub Bot <facebook-github-bot@users.noreply.github.com> Tue Oct 19 11:30:46 2021 -0700
tree 2105d9b1ce4329d9b830bb2ff45255c00ce836e0
parent 50f5689d602bcfe811aa361b19aa0bedb5a66c8e

[PyTorch] Fix performance-no-automatic-move clang tidy warnings in matchTypeVariables (#66720)

Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/66720

See the documentation for the warning. https://clang.llvm.org/extra/clang-tidy/checks/performance-no-automatic-move.html
ghstack-source-id: 140922952

Test Plan: CI

Reviewed By: suo

Differential Revision: D31697506

fbshipit-source-id: 26ce6c47d0f3b0c4e48ecc882f6792f1b5a45bac

aten/src/ATen/core/type.cpp

diff --git a/aten/src/ATen/core/type.cpp b/aten/src/ATen/core/type.cpp
index 6913361..6700b5d 100644
--- a/aten/src/ATen/core/type.cpp
+++ b/aten/src/ATen/core/type.cpp
@@ -435,11 +435,10 @@
     return ss.str();
   } else if (auto lt_formal = formal->castRaw<ListType>()) {
     if (auto lt_actual = actual->castRaw<ListType>()) {
-      const auto innerMatch = matchTypeVariables(
+      auto innerMatch = matchTypeVariables(
           lt_formal->getElementType(), lt_actual->getElementType(), type_env);
       if (!innerMatch.success()) {
         // propagate the errMsg onward
-        // NOLINTNEXTLINE(performance-no-automatic-move)
         return innerMatch;
       }
       return MatchTypeReturn::Success();
@@ -462,10 +461,9 @@
         return MatchTypeReturn("Cannot match tuples of mismatched size");
       }
       for (size_t i = 0; i < tp_formal->elements().size(); ++i) {
-        const auto result = matchTypeVariables(
+        auto result = matchTypeVariables(
             tp_formal->elements()[i], tp_actual->elements()[i], type_env);
         if (!result.success()) {
-          // NOLINTNEXTLINE(performance-no-automatic-move)
           return result;
         }
       }
@@ -477,10 +475,9 @@
     }
   } else if (auto lt_formal = formal->castRaw<FutureType>()) {
     if (auto lt_actual = actual->castRaw<FutureType>()) {
-      const auto innerMatch = matchTypeVariables(
+      auto innerMatch = matchTypeVariables(
           lt_formal->getElementType(), lt_actual->getElementType(), type_env);
       if (!innerMatch.success()) {
-        // NOLINTNEXTLINE(performance-no-automatic-move)
         return innerMatch;
       }
       return MatchTypeReturn::Success();
@@ -491,10 +488,9 @@
     }
   } else if (auto lt_formal = formal->castRaw<RRefType>()) {
     if (auto lt_actual = actual->castRaw<RRefType>()) {
-      const auto innerMatch = matchTypeVariables(
+      auto innerMatch = matchTypeVariables(
           lt_formal->getElementType(), lt_actual->getElementType(), type_env);
       if (!innerMatch.success()) {
-        // NOLINTNEXTLINE(performance-no-automatic-move)
         return innerMatch;
       }
       return MatchTypeReturn::Success();
@@ -505,10 +501,9 @@
     }
   } else if (auto opt_formal = formal->castRaw<OptionalType>()) {
     if (auto opt_actual = actual->castRaw<OptionalType>()) {
-      const auto optionedMatch = matchTypeVariables(
+      auto optionedMatch = matchTypeVariables(
           opt_formal->getElementType(), opt_actual->getElementType(), type_env);
       if (!optionedMatch.success()) {
-        // NOLINTNEXTLINE(performance-no-automatic-move)
         return optionedMatch;
       }
     } else if (!actual->isSubtypeOf(*NoneType::get())) {