commit 689c218c361089a49462aec96594a6407cf31cc6
author Victor Zverovich <viz@fb.com> Mon Jan 31 11:27:39 2022 -0800
committer PyTorch MergeBot <pytorchmergebot@users.noreply.github.com> Mon Jan 31 19:32:58 2022 +0000
tree e169b8ceb95777f716d9e4f51b22e45f9c4ece64
parent dbd090d61045336600b94f900ee4fb46040a716b

[caffe2] Rename c10d::detail::vformat to resolve conflict with fmt (#72039)

Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/72039

As it turned out calling the function `vformat` was a bad idea because it caused a subtle compilation error due to a conflict with `fmt::vformat` and as a result wrong function overload being found during lookup.

(Note: this ignores all push blocking failures!)

Test Plan:
```
buck build //caffe2:libtorch
```

Reviewed By: cbalioglu

Differential Revision: D33864790

fbshipit-source-id: 08f8a1cdb5dfe72707a00a4ab7a859ea0d33b847
(cherry picked from commit 6fbca57d5e76dea88e1fe60431c5a42ab3ff738b)

torch/csrc/distributed/c10d/logging.h

diff --git a/torch/csrc/distributed/c10d/logging.h b/torch/csrc/distributed/c10d/logging.h
index 917eca4..9e6d328 100644
--- a/torch/csrc/distributed/c10d/logging.h
+++ b/torch/csrc/distributed/c10d/logging.h
@@ -13,17 +13,17 @@
 namespace c10d {
 namespace detail {
 template <typename... T>
-std::string vformat(fmt::string_view fmt, T&&... args) {
-  return fmt::vformat(fmt, fmt::make_format_args(std::forward<T>(args)...));
+std::string log_vformat(fmt::string_view fmt, T&&... args) {
+  return fmt::vformat(fmt, fmt::make_format_args(args...));
 }
 }  // namespace detail
 }  // namespace c10d
 
 #define C10D_ERROR(...)\
-    LOG_IF(ERROR,   FLAGS_caffe2_log_level <= 2) << c10d::detail::vformat(__VA_ARGS__)
+    LOG_IF(ERROR,   FLAGS_caffe2_log_level <= 2) << c10d::detail::log_vformat(__VA_ARGS__)
 
 #define C10D_WARNING(...)\
-    LOG_IF(WARNING, FLAGS_caffe2_log_level <= 1) << c10d::detail::vformat(__VA_ARGS__)
+    LOG_IF(WARNING, FLAGS_caffe2_log_level <= 1) << c10d::detail::log_vformat(__VA_ARGS__)
 
 #define C10D_INFO(...)\
-    LOG_IF(INFO,    FLAGS_caffe2_log_level <= 0) << c10d::detail::vformat(__VA_ARGS__)
+    LOG_IF(INFO,    FLAGS_caffe2_log_level <= 0) << c10d::detail::log_vformat(__VA_ARGS__)