| commit | 65d568680c15d6b1084c446a249041d23a472f6b | [log] [tgz] |
|---|---|---|
| author | PyTorch MergeBot <pytorchmergebot@users.noreply.github.com> | Fri Mar 01 03:53:27 2024 +0000 |
| committer | PyTorch MergeBot <pytorchmergebot@users.noreply.github.com> | Fri Mar 01 03:53:27 2024 +0000 |
| tree | e36812c493c134cfb5bf8718ca8a311264fae3ed | |
| parent | e49f31ca02e5a7d6cee2f644de543718a63f0735 [diff] |
Revert "[Dynamo] Fix inspect.getattr_static doesn't work well for torch.utils._cxx_pytree.PyTreeSpec (#120812)" This reverts commit 1104e0798c8206e0226f2d68f6bb065645e6276f. Reverted https://github.com/pytorch/pytorch/pull/120812 on behalf of https://github.com/huydhn due to Sorry for reverting your change but the XLA failure test_simple_model look legit https://hud.pytorch.org/pytorch/pytorch/commit/1104e0798c8206e0226f2d68f6bb065645e6276f ([comment](https://github.com/pytorch/pytorch/pull/120812#issuecomment-1972460001))
diff --git a/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_namedtuple b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_namedtuple new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_namedtuple
diff --git a/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec0 b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec0 new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec0
diff --git a/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec1 b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec1 new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec1
diff --git a/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec2 b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec2 new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec2
diff --git a/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec3 b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec3 new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec3
diff --git a/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec4 b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec4 new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec4
diff --git a/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec5 b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec5 new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec5
diff --git a/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec6 b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec6 new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec6
diff --git a/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec7 b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec7 new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec7
diff --git a/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec8 b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec8 new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec8
diff --git a/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec9 b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec9 new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/test/dynamo_expected_failures/TestCxxPytree.test_pytree_serialize_spec9
diff --git a/torch/_dynamo/variables/user_defined.py b/torch/_dynamo/variables/user_defined.py index ad96886..7dc97d7 100644 --- a/torch/_dynamo/variables/user_defined.py +++ b/torch/_dynamo/variables/user_defined.py
@@ -697,9 +697,7 @@ def _getattr_static(self, name): if ( - isinstance( - self.value, (torch.nn.Module, torch.utils._cxx_pytree.PyTreeSpec) - ) + isinstance(self.value, torch.nn.Module) or "__slots__" in self.value.__class__.__dict__ or type(self.value) == threading.local ):