Build option USE_NUMA should only show up on Linux. (#23673)
Summary:
(intentionally left blank)
Pull Request resolved: https://github.com/pytorch/pytorch/pull/23673
Differential Revision: D16627453
Pulled By: vincentqb
fbshipit-source-id: df62f1b26901bec6369b5589b98124165f40e6f1
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 8018d9a..745de73 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -10,6 +10,12 @@
# ---[ Project and semantic versioning.
project(Caffe2 CXX C)
+if (${CMAKE_SYSTEM_NAME} STREQUAL "Linux")
+ set(LINUX TRUE)
+else()
+ set(LINUX FALSE)
+endif()
+
set(CMAKE_INSTALL_MESSAGE NEVER)
set(CMAKE_CXX_STANDARD 11)
@@ -121,7 +127,9 @@
"USE_NCCL" OFF)
option(USE_NNAPI "Use NNAPI" OFF)
option(USE_NNPACK "Use NNPACK" ON)
-option(USE_NUMA "Use NUMA (only available on Linux)" ON)
+cmake_dependent_option(
+ USE_NUMA "Use NUMA. Only available on Linux." ON
+ "LINUX" OFF)
cmake_dependent_option(
USE_NVRTC "Use NVRTC. Only available if USE_CUDA is on." OFF
"USE_CUDA" OFF)
diff --git a/cmake/Dependencies.cmake b/cmake/Dependencies.cmake
index 0fcc1b8..7cae7d0 100644
--- a/cmake/Dependencies.cmake
+++ b/cmake/Dependencies.cmake
@@ -499,10 +499,7 @@
# ---[ NUMA
if(USE_NUMA)
- if(NOT ${CMAKE_SYSTEM_NAME} STREQUAL "Linux")
- message(WARNING "NUMA is currently only supported under Linux.")
- caffe2_update_option(USE_NUMA OFF)
- else()
+ if(LINUX)
find_package(Numa)
if(NUMA_FOUND)
include_directories(SYSTEM ${Numa_INCLUDE_DIR})
@@ -511,6 +508,9 @@
message(WARNING "Not compiling with NUMA. Suppress this warning with -DUSE_NUMA=OFF")
caffe2_update_option(USE_NUMA OFF)
endif()
+ else()
+ message(WARNING "NUMA is currently only supported under Linux.")
+ caffe2_update_option(USE_NUMA OFF)
endif()
endif()
