tree 28c33c23faec72038fd65cd37d476e6b8ee3de2b
parent 4dea99f18eeef15a6d69236146793c801d12c329
author Gregory P. Smith <greg@krypto.org> 1662310496 -0700
committer GitHub <noreply@github.com> 1662310496 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJjFNhgCRBK7hj4Ov3rIwAA4VcIACPkCaSEEgpNe3+I4qbtiFKd
 gkTLyYP2BVuJN7woFSilMhP3vbkDT1QpntMvNpVZLzclbWDVxADnFfbS81uf3RuK
 reEtlbSy4GGYRfmyngCMYAhEWzoYh9Y7lXP7lpsy/XAlqnZbMoARnJWRfUURVbB0
 ysLI3C6nTQ/vF1fasZoHNaJsoPfXtGfqDswWE/WIK2r9sTvFystSEenlNy+z9k9p
 9lLsNoz/LMtlM6YsiQ00PpNDllNVZSHFYiMJoPHlCu8nJTnrq1ngU3YqftNz7f/h
 B2yEPzXrA2bPUKfJ422GSk7ZQoVir8BerR+X30a2iwlvBHAY4qyWh8JDmLrRB7A=
 =/ck1
 -----END PGP SIGNATURE-----
 

[3.10] gh-95778: Correctly pre-check for int-to-str conversion (GH-96537) (#96563)

Converting a large enough `int` to a decimal string raises `ValueError` as expected. However, the raise comes _after_ the quadratic-time base-conversion algorithm has run to completion. For effective DOS prevention, we need some kind of check before entering the quadratic-time loop. Oops! =)

The quick fix: essentially we catch _most_ values that exceed the threshold up front. Those that slip through will still be on the small side (read: sufficiently fast), and will get caught by the existing check so that the limit remains exact.

The justification for the current check. The C code check is:
```c
max_str_digits / (3 * PyLong_SHIFT) <= (size_a - 11) / 10
```

In GitHub markdown math-speak, writing $M$ for `max_str_digits`, $L$ for `PyLong_SHIFT` and $s$ for `size_a`, that check is:
$$\left\lfloor\frac{M}{3L}\right\rfloor \le \left\lfloor\frac{s - 11}{10}\right\rfloor$$

From this it follows that
$$\frac{M}{3L} < \frac{s-1}{10}$$
hence that
$$\frac{L(s-1)}{M} > \frac{10}{3} > \log_2(10).$$
So
$$2^{L(s-1)} > 10^M.$$
But our input integer $a$ satisfies $|a| \ge 2^{L(s-1)}$, so $|a|$ is larger than $10^M$. This shows that we don't accidentally capture anything _below_ the intended limit in the check.

<!-- gh-issue-number: gh-95778 -->
* Issue: gh-95778
<!-- /gh-issue-number -->

Co-authored-by: Gregory P. Smith [Google LLC] <greg@krypto.org>
(cherry picked from commit b126196838bbaf5f4d35120e0e6bcde435b0b480)

Co-authored-by: Mark Dickinson <dickinsm@gmail.com>