commit dbbe317b4fbcf16c3c0b63b6799abcb28b6d6ea5
author Martijn Vels <mvels@google.com> Thu Mar 23 13:10:28 2023 -0700
committer Copybara-Service <copybara-worker@google.com> Thu Mar 23 13:11:52 2023 -0700
tree cdb5b20638adbcec27c70a9a4eecadf59d42d75d
parent ef53613b42ad24a75d7757b0070e630876ea3664

Small optimization: move TcParser::Error() out of line

PiperOrigin-RevId: 518943474

src/google/protobuf/generated_message_tctable_impl.h

diff --git a/src/google/protobuf/generated_message_tctable_impl.h b/src/google/protobuf/generated_message_tctable_impl.h
index 2551b7a..bf20515 100644
--- a/src/google/protobuf/generated_message_tctable_impl.h
+++ b/src/google/protobuf/generated_message_tctable_impl.h
@@ -907,14 +907,6 @@
   return ptr;
 }
 
-inline PROTOBUF_ALWAYS_INLINE const char* TcParser::Error(
-    PROTOBUF_TC_PARAM_NO_DATA_DECL) {
-  (void)ctx;
-  (void)ptr;
-  SyncHasbits(msg, hasbits, table);
-  return nullptr;
-}
-
 }  // namespace internal
 }  // namespace protobuf
 }  // namespace google

src/google/protobuf/generated_message_tctable_lite.cc

diff --git a/src/google/protobuf/generated_message_tctable_lite.cc b/src/google/protobuf/generated_message_tctable_lite.cc
index cd63500..999d9d6 100644
--- a/src/google/protobuf/generated_message_tctable_lite.cc
+++ b/src/google/protobuf/generated_message_tctable_lite.cc
@@ -269,6 +269,13 @@
                   field_index + 1);
 }
 
+PROTOBUF_NOINLINE const char* TcParser::Error(PROTOBUF_TC_PARAM_NO_DATA_DECL) {
+  (void)ctx;
+  (void)ptr;
+  SyncHasbits(msg, hasbits, table);
+  return nullptr;
+}
+
 template <bool export_called_function>
 inline PROTOBUF_ALWAYS_INLINE const char* TcParser::MiniParse(
     PROTOBUF_TC_PARAM_DECL) {