commit c0d297f767f12c19e095eb37f1c82582df8663b1
author Protobuf Team Bot <protobuf-github-bot@google.com> Mon Aug 28 08:25:41 2023 -0700
committer Copybara-Service <copybara-worker@google.com> Mon Aug 28 08:39:50 2023 -0700
tree 230ef64e4cf6bfdfe54f6cb6ac969f02038b535c
parent 78907f8e6c87eeb73472e58596c2434034e5fac8

Use virtual destructor for Protobuf Messages.

PiperOrigin-RevId: 560717708

src/google/protobuf/repeated_ptr_field.cc

diff --git a/src/google/protobuf/repeated_ptr_field.cc b/src/google/protobuf/repeated_ptr_field.cc
index e51c1a1..36dac0e 100644
--- a/src/google/protobuf/repeated_ptr_field.cc
+++ b/src/google/protobuf/repeated_ptr_field.cc
@@ -185,6 +185,10 @@
   return result;
 }
 
+void InternalOutOfLineDeleteMessageLite(MessageLite* message) {
+  delete message;
+}
+
 }  // namespace internal
 
 }  // namespace protobuf

src/google/protobuf/repeated_ptr_field.h

diff --git a/src/google/protobuf/repeated_ptr_field.h b/src/google/protobuf/repeated_ptr_field.h
index 5b5d770..9839852 100644
--- a/src/google/protobuf/repeated_ptr_field.h
+++ b/src/google/protobuf/repeated_ptr_field.h
@@ -843,6 +843,8 @@
   void* tagged_rep_or_elem_;
 };
 
+void InternalOutOfLineDeleteMessageLite(MessageLite* message);
+
 template <typename GenericType>
 class GenericTypeHandler {
  public:
@@ -860,9 +862,18 @@
     return New(arena);
   }
   static inline void Delete(GenericType* value, Arena* arena) {
-    if (arena == nullptr) {
+    if (arena != nullptr) return;
+#ifdef __cpp_if_constexpr
+    if constexpr (std::is_base_of<MessageLite, GenericType>::value) {
+      // Using virtual destructor to reduce generated code size that would have
+      // happened otherwise due to inlined `~GenericType`.
+      InternalOutOfLineDeleteMessageLite(value);
+    } else {
       delete value;
     }
+#else
+    delete value;
+#endif
   }
   static inline Arena* GetOwningArena(GenericType* value) {
     return Arena::InternalGetOwningArena(value);