commit | 85d2d0d0732629832b0b3ab0755363e6d982e499 | [log] [tgz] |
---|---|---|
author | Jonathon Reinhart <jrreinhart@google.com> | Mon Jul 10 19:00:24 2023 +0000 |
committer | CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jul 10 19:00:24 2023 +0000 |
tree | 6d72bb4c091b1c88f1ddeacd0bbda62769a4d6ce | |
parent | c58ca4f0b6dba12916c8caea162ea208d99e6036 [diff] |
pw_system: Make Optional Device constructor args truly optional Even though detokenizer and timestamp_decoder are annotated as Optional, no default parameter value (i.e., = None) is provided, so the caller must still provide an argument. Add `= None` to allow these arguments to be truly optional. A cursory look indicates that None is properly handled for both, and other code is successfully passing None. The only in-tree use is in pw_system.console which explicitly passes a value for both args. Update that use-case to pass a named argument for clarity. Change-Id: I11b9e1d437c393ff38c5f867541d6eb70cec0ca8 Reviewed-on: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/154710 Reviewed-by: Carlos Chinchilla <cachinchilla@google.com> Pigweed-Auto-Submit: Jonathon Reinhart <jrreinhart@google.com> Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Octavian Purdila <tavip@google.com> Commit-Queue: Auto-Submit <auto-submit@pigweed.google.com.iam.gserviceaccount.com>
Pigweed is an open source collection of embedded-targeted libraries–or as we like to call them, modules. These modules are building blocks and infrastructure that enable faster and more reliable development on small-footprint MMU-less 32-bit microcontrollers like the STMicroelectronics STM32L452 or the Nordic nRF52832.
For more information please see our website: https://pigweed.dev/.