upgraded to most recent version of findbugs
git-svn-id: http://owasp-java-html-sanitizer.googlecode.com/svn/trunk@155 ad8eed46-c659-4a31-e19d-951d88f54425
diff --git a/Makefile b/Makefile
index f2480d3..3e87f53 100644
--- a/Makefile
+++ b/Makefile
@@ -122,7 +122,7 @@
cat $^
out/findbugs.txt: out/tests.tstamp
find out/classes/org -type d | \
- xargs tools/findbugs-1.3.9/bin/findbugs -textui -effort:max \
+ xargs tools/findbugs/bin/findbugs -textui -effort:max \
-auxclasspath ${TEST_CLASSPATH} > $@
# Runs a benchmark that compares performance.
diff --git a/src/main/org/owasp/html/HtmlStreamRenderer.java b/src/main/org/owasp/html/HtmlStreamRenderer.java
index 1090d90..0e7c3c8 100644
--- a/src/main/org/owasp/html/HtmlStreamRenderer.java
+++ b/src/main/org/owasp/html/HtmlStreamRenderer.java
@@ -320,6 +320,8 @@
escapingTextSpanStart = -1;
}
break;
+ default:
+ break;
}
}
if (escapingTextSpanStart >= 0) {
diff --git a/src/main/org/owasp/html/PolicyFactory.java b/src/main/org/owasp/html/PolicyFactory.java
index 4e36bf3..c4bb86e 100644
--- a/src/main/org/owasp/html/PolicyFactory.java
+++ b/src/main/org/owasp/html/PolicyFactory.java
@@ -30,6 +30,7 @@
import java.util.Map;
+import javax.annotation.Nonnull;
import javax.annotation.Nullable;
import javax.annotation.concurrent.Immutable;
import javax.annotation.concurrent.ThreadSafe;
@@ -62,7 +63,7 @@
}
/** Produces a sanitizer that emits tokens to {@code out}. */
- public HtmlSanitizer.Policy apply(HtmlStreamEventReceiver out) {
+ public HtmlSanitizer.Policy apply(@Nonnull HtmlStreamEventReceiver out) {
return new ElementAndAttributePolicyBasedSanitizerPolicy(
out, policies, textContainers);
}
diff --git a/src/tests/org/owasp/html/AntiSamyTest.java b/src/tests/org/owasp/html/AntiSamyTest.java
index 57aa195..4a61437 100644
--- a/src/tests/org/owasp/html/AntiSamyTest.java
+++ b/src/tests/org/owasp/html/AntiSamyTest.java
@@ -146,7 +146,9 @@
"http://deadspin.com/",
}) {
URLConnection conn = new URL(url).openConnection();
- InputStreamReader in = new InputStreamReader(conn.getInputStream());
+ String ct = conn.getContentType();
+ if (ct == null) { ct = "UTF-8"; }
+ InputStreamReader in = new InputStreamReader(conn.getInputStream(), ct);
StringBuilder out = new StringBuilder();
char[] buffer = new char[5000];
int read = 0;
@@ -384,7 +386,9 @@
*/
public void testIllegalXML() throws Exception {
for (int i = 0; i < BASE64_BAD_XML_STRINGS.length; i++) {
- String testStr = new String(Base64.decodeBase64(BASE64_BAD_XML_STRINGS[i].getBytes()));
+ String testStr = new String(
+ Base64.decodeBase64(BASE64_BAD_XML_STRINGS[i]),
+ "UTF-8");
sanitize(testStr);
sanitize(testStr);
}
diff --git a/src/tests/org/owasp/html/HtmlChangeReporterTest.java b/src/tests/org/owasp/html/HtmlChangeReporterTest.java
index 0824bee..bfbba1f 100644
--- a/src/tests/org/owasp/html/HtmlChangeReporterTest.java
+++ b/src/tests/org/owasp/html/HtmlChangeReporterTest.java
@@ -32,21 +32,25 @@
public class HtmlChangeReporterTest extends TestCase {
+ static class Context {
+ // Opaque test value compared via equality.
+ }
+
public final void testChangeReporting() {
- final Integer testContext = 123;
+ final Context testContext = new Context();
StringBuilder out = new StringBuilder();
final StringBuilder log = new StringBuilder();
HtmlStreamRenderer renderer = HtmlStreamRenderer.create(
out, Handler.DO_NOTHING);
- HtmlChangeListener<Integer> listener = new HtmlChangeListener<Integer>() {
- public void discardedTag(Integer context, String elementName) {
+ HtmlChangeListener<Context> listener = new HtmlChangeListener<Context>() {
+ public void discardedTag(Context context, String elementName) {
assertSame(testContext, context);
log.append('<').append(elementName).append("> ");
}
public void discardedAttributes(
- Integer context, String tagName, String... attributeNames) {
+ Context context, String tagName, String... attributeNames) {
assertSame(testContext, context);
log.append('<').append(tagName);
for (String attributeName : attributeNames) {
@@ -55,7 +59,7 @@
log.append("> ");
}
};
- HtmlChangeReporter<Integer> hcr = new HtmlChangeReporter<Integer>(
+ HtmlChangeReporter<Context> hcr = new HtmlChangeReporter<Context>(
renderer, listener, testContext);
hcr.setPolicy(Sanitizers.FORMATTING.apply(hcr.getWrappedRenderer()));
diff --git a/src/tests/org/owasp/html/HtmlPolicyBuilderFuzzerTest.java b/src/tests/org/owasp/html/HtmlPolicyBuilderFuzzerTest.java
index 0475c35..56363b4 100644
--- a/src/tests/org/owasp/html/HtmlPolicyBuilderFuzzerTest.java
+++ b/src/tests/org/owasp/html/HtmlPolicyBuilderFuzzerTest.java
@@ -32,6 +32,7 @@
import com.google.common.base.Throwables;
import com.google.common.collect.Lists;
+import java.io.IOException;
import java.io.StringReader;
import java.util.List;
import java.util.Random;
@@ -40,6 +41,7 @@
import org.w3c.dom.NamedNodeMap;
import org.w3c.dom.Node;
import org.xml.sax.InputSource;
+import org.xml.sax.SAXException;
import nu.validator.htmlparser.dom.HtmlDocumentBuilder;
@@ -83,7 +85,8 @@
"href", "id", "class", "onclick", "checked", "style",
};
- public final void testFuzzedOutput() {
+ public final void testFuzzedOutput() throws IOException, SAXException {
+ boolean passed = false;
try {
for (int i = 1000; --i >= 0;) {
StringBuilder sb = new StringBuilder();
@@ -92,7 +95,8 @@
policy.openDocument();
List<String> attributes = Lists.newArrayList();
for (int j = 50; --j >= 0;) {
- switch (rnd.nextInt(3)) {
+ int r = rnd.nextInt(3);
+ switch (r) {
case 0:
attributes.clear();
if (rnd.nextBoolean()) {
@@ -109,6 +113,9 @@
case 2:
policy.text(pickChunk(rnd));
break;
+ default:
+ throw new AssertionError(
+ "Randomly chosen number in [0-3) was " + r);
}
}
policy.closeDocument();
@@ -119,9 +126,11 @@
new InputSource(new StringReader(html)), "body");
checkSafe(node, html);
}
- } catch (Exception ex) {
- System.err.println("Using seed " + seed + "L");
- Throwables.propagate(ex);
+ passed = true;
+ } finally {
+ if (!passed) {
+ System.err.println("Using seed " + seed + "L");
+ }
}
}
diff --git a/tools/findbugs-1.3.9/LICENSE-mysql-connector.txt b/tools/findbugs-1.3.9/LICENSE-mysql-connector.txt
deleted file mode 100644
index e2e0c4b..0000000
--- a/tools/findbugs-1.3.9/LICENSE-mysql-connector.txt
+++ /dev/null
@@ -1,45 +0,0 @@
-MySQL Connector/J @MYSQL_CJ_VERSION@ (formerly MM.MySQL)
-Sun Microsystem's JDBC Driver for MySQL
-Copyright 2003-2008 MySQL AB, 2008 Sun Microsystems
-
-CONTENTS
-
-* License
-* Documentation Location
-
-
-LICENSE
-
-MySQL Connector/J is licensed under the GPL or a commercial license
-from Sun Microsystems.
-
-If you have licensed this product under the GPL, please see the COPYING
-file for more information.
-
-There are special exceptions to the terms and conditions of the GPL
-as it is applied to this software. View the full text of the
-exception in file EXCEPTIONS-CONNECTOR-J in the directory of this
-software distribution.
-
-If you have licensed this product under a commercial license from
-MySQL AB, please see the file "LICENSE.mysql" that comes with this
-distribution for the terms of the license.
-
-If you need non-GPL licenses for commercial distribution please contact
-me <mark@mysql.com> or <sales@mysql.com>.
-
-
-DOCUMENTATION LOCATION
-
-The documentation formerly contained in this file has moved into the
-'doc' directory, where it is available in HTML, PDF and plaintext
-forms.
-
-You may also find the latest copy of the documentation on the MySQL
-website at http://dev.mysql.com/doc/refman/5.0/en/connector-j.html
-
---
-This software is OSI Certified Open Source Software.
-OSI Certified is a certification mark of the Open Source Initiative.
-
-
diff --git a/tools/findbugs-1.3.9/bin/deprecated/updateBugs b/tools/findbugs-1.3.9/bin/deprecated/updateBugs
deleted file mode 100755
index f3b6910..0000000
--- a/tools/findbugs-1.3.9/bin/deprecated/updateBugs
+++ /dev/null
@@ -1,78 +0,0 @@
-#! /bin/sh
-
-# Merge a historical bug collection and a bug collection, producing an updated
-# historical bug collection
-
-program="$0"
-
-# Follow symlinks until we get to the actual file.
-while [ -h "$program" ]; do
- link=`ls -ld "$program"`
- link=`expr "$link" : '.*-> \(.*\)'`
- if [ "`expr "$link" : '/.*'`" = 0 ]; then
- # Relative
- dir=`dirname "$program"`
- program="$dir/$link"
- else
- # Absolute
- program="$link"
- fi
-done
-
-# Assume findbugs home directory is the parent
-# of the directory containing the script (which should
-# normally be "$findbugs_home/bin").
-dir=`dirname "$program"`
-findbugs_home="$dir/.."
-
-# Handle FHS-compliant installations (e.g., Fink)
-if [ -d "$findbugs_home/share/findbugs" ]; then
- findbugs_home="$findbugs_home/share/findbugs"
-fi
-
-# Make absolute
-findbugs_home=`cd "$findbugs_home" && pwd`
-
-fb_pathsep=':'
-
-# Handle cygwin, courtesy of Peter D. Stout
-fb_osname=`uname`
-if [ `expr "$fb_osname" : CYGWIN` -ne 0 ]; then
- findbugs_home=`cygpath --mixed "$findbugs_home"`
- fb_pathsep=';'
-fi
-# Handle MKS, courtesy of Kelly O'Hair
-if [ "${fb_osname}" = "Windows_NT" ]; then
- fb_pathsep=';'
-fi
-
-if [ ! -d "$findbugs_home" ]; then
- echo "The path $findbugs_home,"
- echo "which is where I think FindBugs is located,"
- echo "does not seem to be a directory."
- exit 1
-fi
-
-# Choose default java binary
-fb_javacmd=java
-if [ ! -z "$JAVA_HOME" ] && [ -x "$JAVA_HOME/bin/java" ]; then
- if [ `expr "$fb_osname" : CYGWIN` -ne 0 ]; then
- fb_javacmd=`cygpath --mixed "$JAVA_HOME"`/bin/java
- else
- fb_javacmd="$JAVA_HOME/bin/java"
- fi
-fi
-
-fb_mainclass=edu.umd.cs.findbugs.workflow.Update
-
-fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
-fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
-set -f
-#echo command: \
-exec "$fb_javacmd" \
- -classpath "$fb_appjar$fb_pathsep$CLASSPATH" \
- -Dfindbugs.home="$findbugs_home"\
- $fb_maxheap $fb_jvmargs $fb_mainclass ${@:+"$@"} $fb_appargs
-
-# vim:ts=3
diff --git a/tools/findbugs-1.3.9/bin/unionBugs b/tools/findbugs-1.3.9/bin/unionBugs
deleted file mode 100755
index fdbfb6a..0000000
--- a/tools/findbugs-1.3.9/bin/unionBugs
+++ /dev/null
@@ -1,80 +0,0 @@
-#! /bin/sh
-
-# Deprecated
-
-# Create the union of two results files, preserving
-# annotations in both files in the result.
-
-program="$0"
-
-# Follow symlinks until we get to the actual file.
-while [ -h "$program" ]; do
- link=`ls -ld "$program"`
- link=`expr "$link" : '.*-> \(.*\)'`
- if [ "`expr "$link" : '/.*'`" = 0 ]; then
- # Relative
- dir=`dirname "$program"`
- program="$dir/$link"
- else
- # Absolute
- program="$link"
- fi
-done
-
-# Assume findbugs home directory is the parent
-# of the directory containing the script (which should
-# normally be "$findbugs_home/bin").
-dir=`dirname "$program"`
-findbugs_home="$dir/.."
-
-# Handle FHS-compliant installations (e.g., Fink)
-if [ -d "$findbugs_home/share/findbugs" ]; then
- findbugs_home="$findbugs_home/share/findbugs"
-fi
-
-# Make absolute
-findbugs_home=`cd "$findbugs_home" && pwd`
-
-fb_pathsep=':'
-
-# Handle cygwin, courtesy of Peter D. Stout
-fb_osname=`uname`
-if [ `expr "$fb_osname" : CYGWIN` -ne 0 ]; then
- findbugs_home=`cygpath --mixed "$findbugs_home"`
- fb_pathsep=';'
-fi
-# Handle MKS, courtesy of Kelly O'Hair
-if [ "${fb_osname}" = "Windows_NT" ]; then
- fb_pathsep=';'
-fi
-
-if [ ! -d "$findbugs_home" ]; then
- echo "The path $findbugs_home,"
- echo "which is where I think FindBugs is located,"
- echo "does not seem to be a directory."
- exit 1
-fi
-
-# Choose default java binary
-fb_javacmd=java
-if [ ! -z "$JAVA_HOME" ] && [ -x "$JAVA_HOME/bin/java" ]; then
- if [ `expr "$fb_osname" : CYGWIN` -ne 0 ]; then
- fb_javacmd=`cygpath --mixed "$JAVA_HOME"`/bin/java
- else
- fb_javacmd="$JAVA_HOME/bin/java"
- fi
-fi
-
-fb_mainclass=edu.umd.cs.findbugs.workflow.UnionResults
-
-fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
-fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
-set -f
-#echo command: \
-exec "$fb_javacmd" \
- -classpath "$fb_appjar$fb_pathsep$CLASSPATH" \
- -Dfindbugs.home="$findbugs_home"\
- $fb_maxheap $fb_jvmargs $fb_mainclass ${@:+"$@"} $fb_appargs
-
-# vim:ts=3
diff --git a/tools/findbugs-1.3.9/doc/Changes.html b/tools/findbugs-1.3.9/doc/Changes.html
deleted file mode 100644
index f89cd3d..0000000
--- a/tools/findbugs-1.3.9/doc/Changes.html
+++ /dev/null
@@ -1,3464 +0,0 @@
-<html>
- <head>
- <title>FindBugs Change Log</title>
- <link rel="stylesheet" type="text/css" href="findbugs.css">
-
- </head>
-
- <body>
-
- <table width="100%">
- <tr>
-
-
-<td bgcolor="#b9b9fe" valign="top" align="left" width="20%">
-<table width="100%" cellspacing="0" border="0">
-<tr><td><a class="sidebar" href="index.html"><img src="umdFindbugs.png" alt="FindBugs"></a></td></tr>
-
-<tr><td> </td></tr>
-
-<tr><td><b>Docs and Info</b></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="factSheet.html">Fact sheet</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="manual/index.html">Manual</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="ja/manual/index.html">Manual(ja/日本語)</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="FAQ.html">FAQ</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="bugDescriptions.html">Bug descriptions</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="mailingLists.html">Mailing lists</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="publications.html">Documents and Publications</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="links.html">Links</a></font></td></tr>
-
-<tr><td> </td></tr>
-
-<tr><td><a class="sidebar" href="downloads.html"><b>Downloads</b></a></td></tr>
-
-<tr><td> </td></tr>
-
-<tr><td><a class="sidebar" href="http://www.cafeshops.com/findbugs"><b>FindBugs Swag</b></a></td></tr>
-
-<tr><td> </td></tr>
-
-<tr><td><b>Development</b></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="http://sourceforge.net/tracker/?group_id=96405">Open bugs</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="reportingBugs.html">Reporting bugs</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="contributing.html">Contributing</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="team.html">Dev team</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="api/index.html">API</a> <a class="sidebar" href="api/overview-summary.html">[no frames]</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="Changes.html">Change log</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="http://sourceforge.net/projects/findbugs">SF project page</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="http://code.google.com/p/findbugs/source/browse/">Browse source</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="http://code.google.com/p/findbugs/source/list">Latest code changes</a></font></td></tr>
-</table>
-</td>
-
- <td align="left" valign="top">
-
-
- <h1>
- FindBugs Change Log, Version 1.3.9
- </h1>
-
-
- <p> Changes since version 1.3.8</p>
- <ul>
- <li>New bug patterns; in some cases, bugs previous reported as other bug patterns are reported as instances
- of these new bug patterns in order to make it easier for developers to understand the bug reports</li>
- <ul>
- <li><a href="http://findbugs.sourceforge.net/bugDescriptions.html#BC_IMPOSSIBLE_DOWNCAST ">BC_IMPOSSIBLE_DOWNCAST </a>
- <li><a href="http://findbugs.sourceforge.net/bugDescriptions.html#BC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY ">BC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY </a>
- <li><a href="http://findbugs.sourceforge.net/bugDescriptions.html#EC_INCOMPATIBLE_ARRAY_COMPARE ">EC_INCOMPATIBLE_ARRAY_COMPARE </a>
- <li><a href="http://findbugs.sourceforge.net/bugDescriptions.html#JLM_JSR166_UTILCONCURRENT_MONITORENTER ">JLM_JSR166_UTILCONCURRENT_MONITORENTER </a>
- <li><a href="http://findbugs.sourceforge.net/bugDescriptions.html#LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE ">LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE </a>
- <li><a href="http://findbugs.sourceforge.net/bugDescriptions.html#NP_CLOSING_NULL ">NP_CLOSING_NULL </a>
- <li><a href="http://findbugs.sourceforge.net/bugDescriptions.html#RC_REF_COMPARISON_BAD_PRACTICE ">RC_REF_COMPARISON_BAD_PRACTICE </a> <li><a href="http://findbugs.sourceforge.net/bugDescriptions.html#RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN ">RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN </a> <li><a href="http://findbugs.sourceforge.net/bugDescriptions.html#RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED ">RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED </a> <li><a href="http://findbugs.sourceforge.net/bugDescriptions.html#SIC_THREADLOCAL_DEADLY_EMBRACE ">SIC_THREADLOCAL_DEADLY_EMBRACE </a> <li><a href="http://findbugs.sourceforge.net/bugDescriptions.html#UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR ">UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR </a> <li><a href="http://findbugs.sourceforge.net/bugDescriptions.html#VA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIED ">VA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIED </a>
- </ul>
- <li>Providing a bug rank (1-20), and the ability to filter by bug rank. Eventually,
- it will be possible to specify your own rules for ranking bugs, but the procedure for doing so hasn't been specified yet.
- <li>Fixed about <a href="https://sourceforge.net/search/index.php?group_id=96405&search_summary=1&search_details=1&type_of_search=artifact&group_artifact_id%5B%5D=614693&open_date_start=2009-03-16&open_date_end=2009-08-20&form_submit=Search">45 bugs filed</a> through SourceForge
- <li>Various reclassifications and priority tweaks
- <li>Added more bug annotations to a variety of bug reports.
- This provides more context for understanding bug reports
- (e.g., if the value in question was is the return value
- of a method, the method is described as the source of
- the value in a bug annotation). This also provide more
- accurate tracking of issues across versions of the code
- being analyzed, but has the downside that when comparing
- results from FindBugs 1.3.8 and FindBugs 1.3.9 on the
- same version of code being analyzed,
- FindBugs may think that mistakenly believe that the
- issue reported by 1.3.8 was fixed and a new issue was
- introduced that was reported by FindBugs 1.3.9. While
- annoying, it would be unusual for more than a dozen
- issues per million
- lines of codes to be mistracked.
- <li> Lots of internal changes moving towards FindBugs 2.0, but these
- features are undocumented, not yet officially supported, and subject to
- radical changes before FindBugs 2.0 is released.
-
-
- </ul>
- <p> Changes since version 1.3.7</p>
- <ul>
- <li>Primarily another small bugfix release.</li>
- <li>FindBugs base:</li>
- <ul>
- <li>New Reports:</li>
- <ul>
- <li>SF_SWITCH_NO_DEFAULT: missing default case in switch statement.</li>
- <li>SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH_TO_THROW: value ignored when switch fallthrough leads to
- thrown exception.</li>
- <li>INT_VACUOUS_BIT_OPERATION: bit operations that don't do any meaningful work.</li>
- <li>FB_UNEXPECTED_WARNING: warning generated that conflicts with @NoWarning FindBugs annotation.</li>
- <li>FB_MISSING_EXPECTED_WARNING: warning not generated despite presence of @ExpectedWarning FindBugs annotation.</li>
- <li>NOISE category: intended for use in data mining experiments.</li>
- <ul>
- <li>NOISE_NULL_DEREFERENCE: fake null point dereference warning.</li>
- <li>NOISE_METHOD_CALL: fake method call warning.</li>
- <li>NOISE_FIELD_REFERENCE: fake field dereference warning.</li>
- <li>NOISE_OPERATION: fake operation warning.</li>
- </ul>
- </ul>
- <li>Other:</li>
- <ul>
- <li>Garvin Leclaire has created a new Apache Maven repository for FindBugs at
- <a href="http://code.google.com/p/findbugs/">the Google Code FindBugs SVN repository</a>. (Thanks Garvin!)</li>
- </ul>
- <li>Fixes:</li>
- <ul>
- <li>[ 2317842 ] Highlighting broken in Windows</li>
- <li>[ 2515908 ] check for oddness should track sign of argument</li>
- <li>[ 2487936 ] "L B GC" false pos cast from Map.Entry.getKey() to Map.get()</li>
- <li>[ 2528264 ] Ant tasks not compatible with Ant 1.7.1</li>
- <li>[ 2539590 ] SF_SWITCH_FALLTHROUGH wrong message reported </li>
- <li>[ 2020066 ] Bug history displayed in fancy-hist.xsl is incorrect</li>
- <li>[ 2545098 ] Invalid character in analysis results file</li>
- <li>[ 2492673 ] Plugin sites should specify 'requires Eclipse 3.3 or newer'</li>
- <li>[ 2588044 ] a tiny typing error</li>
- <li>[ 2589048 ] Documentation for convertXmlToText insufficient</li>
- <li>[ 2638739 ] NullPointerException when building</li>
- </ul>
- <li>Patches:</li>
- <ul>
- <li>[ 2538184 ] Make BugCollection implement Iterable<BugInstance> (thanks to Tomas Pollak)</li>
- <li>[ 2249771 ] Add Maven2 Findbugs plugin link to the Links page (thanks to Garvin Leclaire)</li>
- <li>[ 2609526 ] Japanese manual update (thanks to K. Hashimoto)</li>
- <li>[ 2119482 ] CheckBcel checks for nonexistent classes (thanks to Jerry James)</li>
- </ul>
- </ul>
- <li>FindBugs Eclipse plugin:</li>
- <ul>
- <li>Major feature enhancements (thanks to Andrei Loskutov).
- See <a href="http://andrei.gmxhome.de/findbugs/index.html">this overview</a> for more information.</li>
- <li>Major test improvements (thanks to Tomas Pollak).</li>
- <li>Fixes:</li>
- <ul>
- <li>[ 2532365 ] Compiler warning</li>
- <li>[ 2522989 ] Fix filter files selection</li>
- <li>[ 2504068 ] NullPointerException</li>
- <li>[ 2640849 ] NPE in Eclipse plugin 1.3.7 and Eclipse 3.5 M5</li>
- </ul>
- <li>Patches:</li>
- <ul>
- <li>[ 2143140 ] Unchecked conversion fixes for Eclipse plugin (thanks to Jerry James)
- </ul>
- </ul>
- </ul>
- </ul>
-
- <p> Changes since version 1.3.6</p>
- <ul>
- <li>Overall, a small bugfix release.
- <li>New detection of accidental vacuous/useless calls to EasyMock methods,
- and of generic signatures that proclaim the use of unhashable classes
- in ways that require that they be hashed.
- <li>Eliminate some false positives where we were warning about
- a useless call (e.g., comparing two incompatible types for equality),
- but the only thing the code was doing with the result was
- passing it to assertFalse.
- <li>Japanese localization and manual by K.Hashimoto. (Thanks!)
- <li>Added -exclude and -outputDir command line options to rejarForAnalysis
- <li>Extended -adjustPriorities option to FindBugs analysis textui so that you
- can modify the priorities of individual bug patterns as well as visitors,
- and also completely suppress individual bug patterns or visitors.
- <ul>
- <li> e.g., -adjustPriority MS_SHOULD_BE_FINAL=suppress,MS_PKGPROTECT=suppress,EI_EXPOSE_REP=suppress,EI_EXPOSE_REP2=suppress,PZLA_PREFER_ZERO_LENGTH_ARRAYS=raise
- </ul>
- </ul>
-
-
- <p> Changes since version 1.3.5</p>
- <ul>
- <li>Added fairly exhaustive static analysis
- of uses of format strings, checking for missing or
- extra arguements, invalid format specifiers,
- or mismatched format specifiers and arguments (e.g,
- passing a String value for a %d format specifier).
- The logic for doing so is derived from Sun's java.util.Formatter class,
- and available separately from FindBugs as part of the
- <a href="https://jformatstring.dev.java.net/">jFormatString</a> project.
-
- <li>More tuning of the unsatisfied obligation detector. Since this
- detector is still rather noisy and an unfinished research project,
- I've moved the generated issues to a new category: EXPERIMENTAL.
-
- <li>Added check for <a href="http://findbugs.sourceforge.net/bugDescriptions.html#BIT_ADD_OF_SIGNED_BYTE">BIT_ADD_OF_SIGNED_BYTE</a>; similar to <a href="http://findbugs.sourceforge.net/bugDescriptions.html#BIT_IOR_OF_SIGNED_BYTE">BIT_IOR_OF_SIGNED_BYTE</a>, except that
- addition is being used to combine shifted signed bytes.
-
- <li>Changed detection of EI_EXPOSE_REP2, so we only report it if the value stored
- is guaranteed to be the same value that was passed in as a parameter.
-
- <li>Added <a href="http://findbugs.sourceforge.net/bugDescriptions.html#EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS">EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS</a>, a warning when
- an equals method checks to see if an operand is an instance of a class not
- compatible with itself. For example, if the Foo class checks to see if the argument
- is an instance of String. This is either a questionable design decision or a coding mistake.
- <li>Added <a href="http://findbugs.sourceforge.net/bugDescriptions.html#DMI_INVOKING_HASHCODE_ON_ARRAY">DMI_INVOKING_HASHCODE_ON_ARRAY</a>,
- which checks for invoking <code>hashCode()</code> on an array, which returns a hash code that ignores the contents of the array.
- <li>Added checks for using <code>x.removeAll(x)</code> to rather than <code>x.clear()</code>
- to clear an array.
- <li>Add checks for calls such as <code>x.contains(x)</code>, <code>x.remove(x)</code> and <code>x.containsAll(x)</code>.
- <li>Improvements to Eclipse plugin (thanks to Andrei Loskutov):
- <ul>
- <li>Report separate markers for each occurrence of an issue that appears multiple times in a method
- <li> fine tuning for reported markers: add only one marker for fields, add marker on right position
- <li> link bugs selected in bug explorer view to the opened editor and vice versa
- <li> select bugs selected in editor ruler in the opened bug explorer view
- <li> consistent abbreviations used in both bug explorer and bug details view
- <li> added "Expand All" button to the bug explorer view
- <li> added "Go Into/Go Up" buttons to the bug explorer view
- <li> added "Copy to clipboard" menu/functionality to the details view list widget
- <li> fix for CNF exception if loading the backup solution for broken browser widget
-
- </ul></ul>
-
-
-
- <p> Changes since version 1.3.4</p>
- <ul>
- <li>Analysis about 15% faster
- <li><a href="http://sourceforge.net/tracker/?atid=614693&group_id=96405&func=browse&status=closed">38 bugs closed</a></li>
- <li>New defect warnings:
- <ul>
- <li>calls to methods that always throw
- UnsupportedOperationException (DMI_UNSUPPORTED_METHOD)
- <li>repeated conditional tests (e.g.,
- <code>if (x < 0 || x < 0) ...</code>)
- (RpC_REPEATED_CONDITIONAL_TEST)
- <li>Complete rewrite of detector for format string problems.
- More accurate, finds more problems, generates
- more descriptive reports, several different
- bug pattern
- (VA_FORMAT_STRING_EXTRA_ARGUMENTS_PASSED,
- VA_FORMAT_STRING_ILLEGAL,
- VA_FORMAT_STRING_MISSING_ARGUMENT,
- VA_FORMAT_STRING_BAD_ARGUMENT,
- VA_FORMAT_STRING_NO_PREVIOUS_ARGUMENT)
-
- <li>Fairly complete implementation of JSR-305 custom type qualifier
- analysis (no support for custom validators yet).
- (TQ_MAYBE_SOURCE_VALUE_REACHES_NEVER_SINK
- TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK
- TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK)
- <li>New detector for unsatisfied obligations such forgetting to
- close a file (OBL_UNSATISFIED_OBLIGATION).
- <li>Warning when a parameter is marked as nullable, but is
- always dereferenced.
- (NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE)
- <lI>Separate warning for dereference the result of readLine (NP_DEREFERENCE_OF_READLINE_VALUE)
- </ul>
- <li>When XML is generated with messages, the project stats now
- include <FileStat> elements.
- For each source file, this gives the path for the file,
- the total number of warnings for that file, and a bugHash
- for the file. While the instanceHash for a bug is intended
- to be version invariant (ignoring line numbers, etc), the
- bugHash for a file is intended to reflect all the information
- about the warnings in that file. The intended use case is that
- if the bugHash for a file is the same in two analysis runs,
- then <em>nothing</em> has changed about any of the warnings
- reported for that file between the two analysis runs.
- <li>More merging of similar issues within a method. For example,
- if the result of readLine() is dereferences multiple times
- within a method, it will be reported as a single warning
- with occurrences at multiple source lines.
- </ul>
- <p> Changes since version 1.3.3</p>
-
- <ul>
- <li>FindBugs base
- <ul>
- <li>New Reports:</li>
- <ul>
- <li>EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC:
- equals method overrides equals in superclass and may not be symmetric</li>
- <li>EQ_ALWAYS_TRUE:
- equals method always returns true</li>
- <li>EQ_ALWAYS_FALSE:
- equals method always returns false</li>
- <li>EQ_COMPARING_CLASS_NAMES:
- equals method compares class names rather than class objects</li>
- <li>EQ_UNUSUAL: Unusual equals method</li>
- <li>EQ_GETCLASS_AND_CLASS_CONSTANT:
- equals method fails for subtypes</li>
- <li>SE_READ_RESOLVE_IS_STATIC:
- The readResolve method must not be declared as a static method.</li>
- <li>SE_PRIVATE_READ_RESOLVE_NOT_INHERITED:
- private readResolve method not inherited by subclasses</li>
- <li>MSF_MUTABLE_SERVLET_FIELD: Mutable servlet field</li>
- <li>XSS_REQUEST_PARAMETER_TO_SEND_ERROR:
- Servlet reflected cross site scripting vulnerability</li>
- <li>SKIPPED_CLASS_TOO_BIG: Class too big for analysis</li>
- </ul>
- <li>Other:</li>
- <ul>
- <li>Value-number analysis now more space-efficient</li>
- <li>Enhancements to reduce memory overhead when
- analyzing very large classes</li>
- <li>Now skips very large classes that would otherwise
- take too much time and memory to analyze</li>
- <li>Infrastructure for tracking effectively-constant/
- effectively-final fields</li>
- <li>Added more cweids</li>
- <li>Enhanced taint tracking for taint-based detectors</li>
- <li>Ignore doomed calls to equals if result is used
- as an argument to assertFalse</li>
- <li>EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC handles compareTo</li>
- <li>Priority tweak for ICAST_INTEGER_MULTIPLY_CAST_TO_LONG
- (only low priority if multiplying by 1000)</li>
- <li>Improved tracking of fields across method calls</li>
- </ul>
- <li>Fixes:</li>
- <ul>
- <li>[ 1941450 ] DLS_DEAD_LOCAL_STORE not reported</li>
- <li>[ 1953323 ] Omitted break statement in SynchronizeAndNullCheckField</li>
- <li>[ 1942620 ] Source Directories selection dialog interface confusion (partial)</li>
- <li>[ 1948275 ] Unhelpful "Load of known null"</li>
- <li>[ 1933922 ] MWM error in findbugs</li>
- <li>[ 1934772 ] 1.3.3 appears to rely on JDK 1.6, JNLP still specifies 1.5</li>
- <li>[ 1933945 ] -loadbugs doesn't work</li>
- <li>Fixed problems for class names starting with '$'</li>
- <li>Fixed bugs and incomplete handling of annotations in
- VersionInsensitiveBugComparator</li>
- </ul>
- <li>Patches:</li>
- <ul>
- <li>[ 1955106 ] Javadoc fixes</li>
- <li>[ 1951930 ] Superfluous import statements (thanks to Jerry James)</li>
- <li>[ 1951907 ] Missing @Deprecated annotations (thanks to Jerry James)</li>
- <li>[ 1951876 ] Infonode Docking Windows compile fix (thanks to Jerry James)</li>
- <li>[ 1936055 ] bugfix for findbugs.de.comment not working (thanks to Peter Fokkinga)
- </ul>
- </ul>
- <li>FindBugs BlueJ plugin</li>
- <ul>
- <li>Updated to use FindBugs 1.3.4 (first new release since 1.1.3)</li>
- </ul>
- </ul>
-
- <p> Changes since version 1.3.2</p>
-
- <ul>
- <li>FindBugs base</li>
- <ul>
- <li>New Detectors:</li>
- <ul>
- <li>FieldItemSummary: Produces summary information
- for what is stored into fields </li>
- <li>SynchronizeOnClassLiteralNotGetClass: Look for
- code that synchronizes on the results of getClass
- rather than on class literals</li>
- <li>SynchronizingOnContentsOfFieldToProtectField: This
- detector looks for code that seems to be
- synchronizing on a field in order to guard updates
- of that field </li>
- </ul>
- <li>New BugCode:</li>
- <ul>
- <li> HRS: HTTP Response splitting vulnerability </li>
- <li> WL: Possible locking on wrong object </li>
- </ul>
- <li>New Reports:</li>
- <ul>
- <li>DMI_CONSTANT_DB_PASSWORD:
- This code creates a database connect using a hard coded, constant password </li>
- <li>HRS_REQUEST_PARAMETER_TO_COOKIE:
- HTTP cookie formed from untrusted input </li>
- <li>HRS_REQUEST_PARAMETER_TO_HTTP_HEADER:
- HTTP parameter directly written to HTTP header output </li>
- <li>CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE:
- Class defines clone() but doesn't implement Cloneable </li>
- <li>DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE:
- Synchronization on boxed primitive could lead to deadlock </li>
- <li> DL_SYNCHRONIZATION_ON_BOOLEAN:
- Synchronization on Boolean could lead to deadlock </li>
- <li> ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD:
- Synchronization on field in futile attempt to guard that field </li>
- <li> DLS_DEAD_LOCAL_STORE_IN_RETURN:
- Useless assignment in return statement </li>
- <li> WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL:
- Synchronization on getClass rather than class literal </li>
- </ul>
- <li>Other:</li>
- <ul>
- <li>Many enhancements to cross-site scripting detector and its documentation</li>
- <li> Enhanced switch fall through handling </li>
- <li> Enhanced unread field handling (look for IF_ACMPEQ and IF_ACMPNE) </li>
- <li> Clarified documentation for @Nullable in manual </li>
- <li> Fewer DeadLocalStore false positives </li>
- <li> Fewer UnreadField false positives </li>
- <li> Fewer StaticCalendarDetector false positives </li>
- <li> Performance fix for slow file system IO e.g. Clearcase repositories (thanks, Andrei!) </li>
- <li> Other, general performance enhancements (thanks, Andrei!) </li>
- <li> Enhancements for using FindBugs scripts with MKS on Windows (thanks, Kelly O'Hair!) </li>
- <li> Noted in the manual that jsr305.jar must be present for annotations to compile </li>
- <li> Added and fine-tuned default-nullness annotations </li>
- <li> More CWE IDs added </li>
- <li> Check and warning for unexpected BCEL version in classpath </li>
- </ul>
- <li>Fixes:</li>
- <ul>
- <li>Bug fix to handling of local variable tables in BCEL</li>
- <li>Refined documentation for MTIA_SUSPECT_STRUTS_INSTANCE_FIELD</li>
- <li>[ 1927295 ] NPE when called on project root</li>
- <li>[ 1926405 ] Incorrect dead store warning</li>
- <li>[ 1926409 ] Incorrect redundant nullcheck warning</li>
- <li>[ 1926389 ] Wrong line number printed/highlighted in bug</li>
- <li>[ 1927040 ] typo in bug description</li>
- <li>[ 1926263 ] Minor glitch in HTML output</li>
- <li>[ 1926240 ] Minor error in standard options in manual</li>
- <li>[ 1926236 ] Minor bug in installation section of manual</li>
- <li>[ 1925539 ] ZIP is default file system code base</li>
- <li>[ 1894701 ] Livelock / memory leak in ObjectTypeFactory (thanks, Andrei!)</li>
- <li>[ 1867491 ] Doesn't reload annotations after code changes in IDE (thanks, Andrei!)</li>
- <li>[ 1921399 ] -project option not supported</li>
- <li>[ 1913834 ] "Dead" store to variable with method call</li>
- <li>[ 1917352 ] H B se:...field in serializable class</li>
- <li>[ 1911617 ] CloneIdiom relies on getNameConstantOperand for INSTANCEOF</li>
- <li>[ 1911620 ] False +: DLS predecrement before return</li>
- <li>[ 1871376 ] False negative: non-serializable Map field</li>
- <li>[ 1871051 ] non standard clone() method</li>
- <li>[ 1908854 ] Error in TestASM</li>
- <li>[ 1907539 ] 22 minor errors in bug checker documentation</li>
- <li>[ 1897323 ] EJB implementation class false positives</li>
- <li>[ 1899648 ] Crash on startup on Vista with Java 1.6.0_04</li>
- </ul>
- </ul>
- <li>FindBugs Eclipse plugin (change log by Andrei Loskutov)</li>
- <ul>
- <li> new feature: export basic FindBugs numbers for projects via File->Export->Java->BugCounts (Andrei Loskutov) </li>
- <li> new feature: jobs for different projects will be run in parallel per default if running on a
- multi-core PC ("fb.allowParallelBuild" system property not used anymore) (Andrei Loskutov) </li>
- <li> fixed performance slowdown in the multi-threaded build, caused by workspace operation locks during
- assigning marker attributes (Andrei Loskutov)</li>
- </ul>
- </ul>
-
- <p> Changes since version 1.3.1</p>
-
- <ul>
- <li>FindBugs base</li>
- <ul>
- <li>New Bug Category:</li>
- <ul>
- <li>SECURITY (Abbrev: S), A use of untrusted input in
- a way that could create a remotely exploitable
- security vulnerability</li>
- </ul>
- <li>New Detectors:</li>
- <ul>
- <li>CrossSiteScripting: This detector looks for
- obvious/blatant cases of cross site scripting
- vulnerabilities</li>
- </ul>
- <li>New BugCode:</li>
- <ul>
- <li>XSS: Cross site scripting</li>
- </ul>
- <li>New Reports:</li>
- <ul>
- <li>XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER: HTTP
- parameter directly written to Servlet output,
- giving XSS vulnerability</li>
- <li>XSS_REQUEST_PARAMETER_TO_JSP_WRITER: HTTP
- parameter directly written to JSP output, giving
- XSS vulnerability</li>
- <li>EQ_OTHER_USE_OBJECT: equals() method defined that
- doesn't override Object.equals(Object)</li>
- <li>EQ_OTHER_NO_OBJECT: equals() method inherits
- rather than overrides equals(Object)</li>
- <li>NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE:
- Possible null pointer dereference on path that
- might be infeasible</li>
- </ul>
- <li>Other:</li>
- <ul>
- <li>Added -noClassOk command-line parameter to
- command-line and ant interfaces; when -noClassOk
- is specified and no classfiles are given, FindBugs
- will print a warning message and output a well-
- formed file with no warnings</li>
- <li>Fewer false positives for null pointer bugs</li>
- <li>Suppress dead-local-store false positives in .jsp
- code</li>
- <li>Type fixes in warning messages</li>
- <li>Better warning message for
- NP_NULL_ON_SOME_PATH</li>
- <li>"WMI" bug code description renamed from "Wrong
- Map Iterator" to "Inefficient Map Iterator"</li>
- </ul>
- <li>Fixes:</li>
- <ul>
- <li>[ 1893048 ] FindBugs confused by a findbugs.xml file</li>
- <li>[ 1878528 ] XSL xforms don't support history features</li>
- <li>[ 1876584 ] two default.xsl flaws</li>
- <li>[ 1874856 ] Format string bug detector doesn't handle special operators</li>
- <li>[ 1872645 ] computeBugHistory - java.lang.IllegalArgumentException</li>
- <li>[ 1872237 ] Ant task fails when no .class files</li>
- <li>[ 1868670 ] Filters: include AND exclude don't allowed</li>
- <li>[ 1868666 ] check-for-oddness reported, but array length can never be negative</li>
- <li>[ 1866108 ] SetBugDatabaseInfoTask strips dir from output filename</li>
- <li>[ 1866021 ] MineBugHistoryTask strips dir of output filename</li>
- <li>[ 1865265 ] code doesn't handle StringBuffer.append([CII) right</li>
- <li>[ 1864793 ] Warning when casting a null reference compared to a String</li>
- <li>[ 1863376 ] Typo in manual chap 8: Filter Files</li>
- <li>[ 1862705 ] Transient fields that default to null</li>
- <li>[ 1842545 ] DLS on catch variable (with priority tweaking)</li>
- <li>[ 1816258 ] false positive BC_IMPOSSIBLE_CAST</li>
- <li>[ 1551732 ] Get erroneous DLS with while loop</li>
- </ul>
- </ul>
- <li>FindBugs Eclipse plugin (change log by Andrei Loskutov)</li>
- <ul>
- <li>new feature: added Bug explorer view (replacing Bug tree view), based on Common Navigator framework (Andrei Loskutov)</li>
- <li>bug 1873860 fixed: empty projects are no longer shown in Bug tree view (Andrei Loskutov)</li>
- <li>new feature: bug counts decorators for projects, folders and files (has to be activated
- via Preferences -> general -> appearance -> label decorations)(Andrei Loskutov)</li>
- <li>patch 1746499: better icons (Alessandro Nistico)</li>
- <li>patch 1893685: Find bug actions on change sets bug (Alessandro Nistico)</li>
- <li>fixed bug 1855384: Bug configuration is broken in Eclipse (Andrei Loskutov)</li>
- <li>refactored FindBugs properties page (Andrei Loskutov)</li>
- <li>refactored FindBugs worker/builder/run action (Andrei Loskutov)</li>
- <li>FB detects now only bugs from classes on project's classpath (no double work on
- duplicated class files) (Andrei Loskutov)</li>
- <li>fixed bug introduced by the bad patch for 1867951: FB cannot be executed incrementally
- on a folder of file (Andrei Loskutov)</li>
- <li>fixed job rule: now jobs for different projects may run in parallel if running on a
- multi-core PC and "fb.allowParallelBuild" system property is set to true (Andrei Loskutov)</li>
- <li>fixed FB auto-build not started if .fbprefs or .classpath was changed (Andrei Loskutov)</li>
- <li>fixed not reporting bugs on secondary types (classes defined in java files with
- different name) (Andrei Loskutov) </li>
- </ul>
- </ul>
-
- <p> Changes since version 1.3.0</p>
- <ul>
- <li>New Reports</li>
- <ul>
- <li>VA_FORMAT_STRING_ARG_MISMATCH:
- A format-string method with a variable number of arguments is called,
- but the number of arguments passed does not match with the number of
- % placeholders in the format string. This is probably not what the
- author intended.
- <li>IO_APPENDING_TO_OBJECT_OUTPUT_STREAM:
- This code opens a file in append mode and that wraps the result in an object output stream.
- This won't allow you to append to an existing object output stream stored in a file. If you want to be
- able to append to an object output stream, you need to keep the object output stream open.
- The only situation in which opening a file in append mode and the writing an object output stream
- could work is if on reading the file you plan to open it in random access mode and seek to the byte offset
- where the append started.
- <li>NP_BOOLEAN_RETURN_NULL:
- A method that returns either Boolean.TRUE, Boolean.FALSE or null is an accident waiting to happen.
- This method can be invoked as though it returned a value of type boolean, and
- the compiler will insert automatic unboxing of the Boolean value. If a null value is returned,
- this will result in a NullPointerException.
- </ul>
- <li>Changes to Existing Reports</li>
- <ul>
- <li>RV_DONT_JUST_NULL_CHECK_READLINE: CORRECTNESS -> STYLE</li>
- <li>DMI_INVOKING_TOSTRING_ON_ARRAY: Long description mentions array name whenever possible</li>
- </ul>
- <li>Fixes:</li>
- <ul>
- <li>Updated manual to mention that Java 1.5 is now a requirement for running FindBugs
- <li>Applied patch 1840206 fixing issue "Ant task does not work when presetdef is used" - thanks to phejl
- <li>Applied patch 1778690 fixing issue "Ant task: tolerate but complain about invalid auxClasspath" - thanks to David Schmidt
- <li>Applied patch 1852125 adding a Chinese-language GUI bundle props file - thanks to fifi
- <li>Applied patch 1845903 adding ability to load XML results with the Eclipse plugin - thanks to Alex Mont
- <li>Fixed issue 1844671 - "FP for "reversed" null check in catch for stream close"
- <li>Fixed issue 1836050 - "-onlyAnalyze broken"
- <li>Fixed issue 1853011 - "Typo: Field names should start with aN lower case letter"
- <li>Fixed issue 1844181 - "JNLP file does not contain all necessary JARs"
- <li>Fixed issue 1840245 - "xxxException class does not derive from Exception"
- <li>Fixed issue 1840277 - "[M D EC] Typo in bug documentation"
- <li>Fixed issue 1782447 - "OutOfMemoryError if i activate Findbugs on my project"
- <li>Fixed issue 1830576 - "[regression] keySet/entrySet false positive"
- </ul>
- <li>Other:</li>
- <ul>
- <li>New bug code: "IO" (for IO_APPENDING_TO_OBJECT_OUTPUT_STREAM)</li>
- <li>Added "-onlyMostRecent" option for computeBugHistory script/ant task
- <li>More explicit language in RV_RETURN_VALUE_IGNORED_BAD_PRACTICE messages
- <li>Modified ResourceValueAnalysis to correctly identify null == X or null != X as a null check (for issue 1844671)
- <li>Modified DMI_HARDCODED_ABSOLUTE_FILENAME logic in DumbMethodInvocations to ignore files from /etc or /dev and increase priority of files from /home
- <li>Better bug details for infinite loop warnings
- <li>Modified unread-fields detector to reduce false positives from reflective fields
- <li>build.xml "classes" target now builds all sources in one step
- </ul>
- </ul>
-
- <p> Changes since version 1.2.1</p>
- <ul>
- <li>New Detectors and Reports</li>
- <ul>
- <li>SynchronizationOnSharedBuiltinConstant</li>
- <ul>
- <li>DL_SYNCHRONIZATION_ON_SHARED_CONSTANT:
- The code synchronizes on a shared primitive
- constant, such as an interned String. Such
- constants are interned and shared across all other
- classes loaded by the JVM. Thus, this could be
- locking on something that other code might also be
- locking. This could result in very strange and hard
- to diagnose blocking and deadlock behavior. See
- <a href="http://www.javalobby.org/java/forums/t96352.html">http://www.javalobby.org/java/forums/t96352.html</a>
- and
- <a href="http://jira.codehaus.org/browse/JETTY-352">http://jira.codehaus.org/browse/JETTY-352</a>.
- </ul>
- <li>OverridingEqualsNotSymmetrical</li>
- <ul>
- <li>EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC:
- Looks for equals methods that override equals
- methods in a superclass where the equivalence
- relationship might not be symmetrical.
- </ul>
- <li>CheckTypeQualifiers</li>
- <ul>
- <li>TQ_ALWAYS_VALUE_USED_WHERE_NEVER_REQUIRED:
- A value specified as carrying a type qualifier
- annotation is consumed in a location or locations
- requiring that the value not carry that annotation.
- More precisely, a value annotated with a type
- qualifier specifying when=ALWAYS is guaranteed to reach
- a use or uses where the same type qualifier specifies
- when=NEVER.
- </li>
- <li>TQ_NEVER_VALUE_USED_WHERE_ALWAYS_REQUIRED:
- A value specified as not carrying a type qualifier
- annotation is guaranteed to be consumed in a location
- or locations requiring that the value does carry that
- annotation. More precisely, a value annotated with a
- type qualifier specifying when=NEVER is guaranteed to
- reach a use or uses where the same type qualifier
- specifies when=ALWAYS.
- </li>
- <li>TQ_MAYBE_SOURCE_VALUE_REACHES_ALWAYS_SINK:
- A value that might not carry a type qualifier
- annotation reaches a use which requires that
- annotation.
- </li>
- <li>TQ_MAYBE_SOURCE_VALUE_REACHES_NEVER_SINK:
- A value which might carry a type qualifier annotation
- reaches a use which forbids values carrying that
- annotation.
- </li>
- </ul>
- </ul>
- <li>New Reports (existing detectors)</li>
- <ul>
- <li>FindHEmismatch</li>
- <ul>
- <li>EQ_DOESNT_OVERRIDE_EQUALS:
- This class extends a class that defines an equals
- method and adds fields, but doesn't define an equals
- method itself. Thus, equality on instances of this
- class will ignore the identity of the subclass and the
- added fields. Be sure this is what is intended, and
- that you don't need to override the equals method. Even
- if you don't need to override the equals method,
- consider overriding it anyway to document the fact that
- the equals method for the subclass just return the
- result of invoking super.equals(o).
- </li>
- </ul>
- <li>Naming
- <ul>
- <li>NM_WRONG_PACKAGE, NM_WRONG_PACKAGE_INTENTIONAL:
- The method in the subclass doesn't override a similar
- method in a superclass because the type of a parameter
- doesn't exactly match the type of the corresponding
- parameter in the superclass.
- </li>
- <li>NM_SAME_SIMPLE_NAME_AS_SUPERCLASS:
- This class has a simple name that is identical to that
- of its superclass, except that its superclass is in a
- different package (e.g., <code>alpha.Foo</code>
- extends <code>beta.Foo</code>). This can be
- exceptionally confusing, create lots of situations in
- which you have to look at import statements to resolve
- references and creates many opportunities to
- accidently define methods that do not override methods
- in their superclasses.
- </li>
- <li>NM_SAME_SIMPLE_NAME_AS_INTERFACE:
- This class/interface has a simple name that is
- identical to that of an implemented/extended
- interface, except that the interface is in a different
- package (e.g., <code>alpha.Foo</code> extends
- <code>beta.Foo</code>). This can be exceptionally
- confusing, create lots of situations in which you have
- to look at import statements to resolve references and
- creates many opportunities to accidently define methods
- that do not override methods in their superclasses.
- </li>
- </ul>
- <li>FindRefComparison</li>
- <ul>
- <li>EC_UNRELATED_TYPES_USING_POINTER_EQUALITY:
- This method uses using pointer equality to compare two
- references that seem to be of different types. The
- result of this comparison will always be false at
- runtime.
- </li>
- </ul>
- <li>IncompatMask</li>
- <ul>
- <li>BIT_SIGNED_CHECK, BIT_SIGNED_CHECK_HIGH_BIT:
- This method compares an expression such as
- <tt>((event.detail & SWT.SELECTED) > 0)</tt>. Using
- bit arithmetic and then comparing with the greater than
- operator can lead to unexpected results (of course
- depending on the value of SWT.SELECTED). If
- SWT.SELECTED is a negative number, this is a candidate
- for a bug. Even when SWT.SELECTED is not negative, it
- seems good practice to use '!= 0' instead of '> 0'.
- </li>
- </ul>
- <li>LazyInit</li>
- <ul>
- <li>LI_LAZY_INIT_UPDATE_STATIC:
- This method contains an unsynchronized lazy
- initialization of a static field. After the field is
- set, the object stored into that location is further
- accessed. The setting of the field is visible to other
- threads as soon as it is set. If the further accesses in
- the method that set the field serve to initialize the
- object, then you have a <em>very serious</em>
- multithreading bug, unless something else prevents any
- other thread from accessing the stored object until it
- is fully initialized.
- </li>
- </ul>
- <li>FindDeadLocalStores</li>
- <ul>
- <li>DLS_DEAD_STORE_OF_CLASS_LITERAL:
- This instruction assigns a class literal to a variable
- and then never uses it.
- <a href="//java.sun.com/j2se/1.5.0/compatibility.html#literal">The behavior of this differs in Java 1.4 and in Java 5.</a>
- In Java 1.4 and earlier, a reference to
- <code>Foo.class</code> would force the static
- initializer for <code>Foo</code> to be executed, if it
- has not been executed already. In Java 5 and later, it
- does not. See Sun's
- <a href="//java.sun.com/j2se/1.5.0/compatibility.html#literal">article on Java SE compatibility</a>
- for more details and examples, and suggestions on how
- to force class initialization in Java 5.
- </li>
- </ul>
- <li>MethodReturnCheck</li>
- <ul>
- <li>RV_RETURN_VALUE_IGNORED_BAD_PRACTICE:
- This method returns a value that is not checked. The
- return value should be checked since it can indication
- an unusual or unexpected function execution. For
- example, the <code>File.delete()</code> method returns
- false if the file could not be successfully deleted
- (rather than throwing an Exception). If you don't
- check the result, you won't notice if the method
- invocation signals unexpected behavior by returning an
- atypical return value.
- </li>
- <li>RV_EXCEPTION_NOT_THROWN:
- This code creates an exception (or error) object, but
- doesn't do anything with it.
- </li>
- </ul>
- </ul>
- <li>Changes to Existing Reports</li>
- <ul>
- <li>NS_NON_SHORT_CIRCUIT: BAD_PRACTICE -> STYLE</li>
- <li>NS_DANGEROUS_NON_SHORT_CIRCUIT: CORRECTNESS -> STYLE</li>
- <li>RC_REF_COMPARISON: CORRECTNESS -> BAD_PRACTICE</li>
- </ul>
- <li>GUI Changes</li>
- <ul>
- <li>Added importing and exporting of bug filters</li>
- <li>Better handling of failed analysis runs</li>
- <li>Added "-look" parameter for selecting look-and-feel</li>
- <li>Fixed incorrect package filtering</li>
- <li>Fixed issue where "synchronized" was not syntax-highlighted</li>
- </ul>
- <li>Ant-task Changes</li>
- <ul>
- <li>Refactored common ant-task code to AbstractFindBugsTask</li>
- <li>Added tasks for computeBugHistory, convertXmlToText, filterBugs, mineBugHistory, setBugDatabaseInfo</li>
- </ul>
- <li>Manual</li>
- <ul>
- <li>Updates to GUI section, including new screenshots</li>
- <li>Added description of rejarForAnalysis</li>
- <li>Revamp of data-mining section</li>
- </ul>
- <li>Other Major</li>
- <ul>
- <li>Internal restructuring for lower memory overhead</li>
- </ul>
- <li>Other Minor</li>
- <ul>
- <li>Fixed typo: was STCAL_STATIC_SIMPLE_DATA_FORMAT_INSTANCE now STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE</li>
- <li>-outputFile parameter became -output</li>
- <li>More sensitivity and specificity inLazyInit detector</li>
- <li>More sensitivity and specificity in Naming detector</li>
- <li>More sensitivity and specificity in UnreadFields detector</li>
- <li>More sensitivity in FindNullDeref detector</li>
- <li>More sensitivity in FindBadCast2 detector</li>
- <li>More specificity in FindReturnRef detector</li>
- <li>Many other tweaks and bug fixes</li>
- </ul>
- </ul>
-
- <p> Changes since version 1.2.0</p>
- <ul>
- <li>Bug fixes:
- <ul>
- <li><a href="http://fisheye2.cenqua.com/changelog/findbugs/?cs=8219">Fix</a> <a href="http://sourceforge.net/tracker/index.php?func=detail&aid=1726946&group_id=96405&atid=614693">bug</a> with detectors that were requested to be disabled but were enabled due to requirements of other detectors.</li>
- <li>Fix bugs in incremental analysis within Eclipse plugin</li>
- <li>Fix some analysis errors</li>
- <li>Fix some threading bugs in GUI2</li>
- <li>Report version as version when it was compiled, not when it was run</li>
- <li>Copy analysis time stamp when filtering or transforming analysis files.</li>
- </ul>
- <li>Enabled StaticCalendarDetector
- </li>
- <li>Reworked GUI2 to use standard FindBugs filters
- </li>
- <ul>
- <li>Allow a suppression filter to be stored in a project and persisted to the XML representation of a project.
- </li>
- </ul>
-
- <li>Move away from old GUI2 save format (a directory containing an xml file and another file containing serialized filters).
- </li>
- <li>Support/recommend use of two new file extensions/formats:
- <dl><dt>.fba - FindBugs Analysis File</dt>
- <dd>Exactly the same as an existing bug collection file stored in XML format, but using a distinct file extension
- to make it easier to figure out which xml files contain FindBugs results.</dd>
- <dt>.fbp - FindBugs Project File</dt><dd>Contains just the information needed to run FindBugs and display the results (e.g., the files to be analyzed, the auxiliary class path and the location of source files)</dl></li>
- </ul>
- <p> Changes since version 1.1.3</p>
- <ul>
- <li>Added -xml:withAbridgedMessages option to generate xml containing shorter messages.
- The messages will be shorted by doing things like eliding package names, and leaving off
- the source line from the LongMessage.
- These messages are appropriate if being used in a context where
- the non-message components of the bug annotations will be used to provide more information
- (e.g., clicking on the message for a MethodAnnotation will display the source for the method).
- <ul><li>FindBugsDisplayFeatures.setAbridgedMessages(true) can be used to generate abridged messages
- when FindBugs is being accessed directly (not via generated XML) from a GUI or IDE.
- </li>
- </ul>
- <li>In null pointer analysis, try to be better about always showing two locations: where it is known null and
- where it is dereferenced.
- <li>Interprocedural analysis of which methods return nonnull values
- <li>Use method calls to select order in which classes are analyzed, and order in which methods
- are analyzed, to improve interprocedural analysis results.
- <li>Significant improvements in memory footprint, memory allocation and CPU utilization
- (20-30% reduction in all three)
- <li>Added a project name, to provide better descriptions in the HTML output.
- <li>Added new bug pattern: Casting to char, or bit masking with nonnegative value, and then checking to see
- if the result is negative.
- <li>Stopped reporting transient fields
- of classes not marked as serializable. Transient is used by other persistence frameworks.
- <li>Improvements to detector for SQL injection (Thanks to <a href="http://www.clock.org/~matt">Matt Hargett</a> for
- his contributions
- <li>Changed open/save options in GUI2 to not distinguish between FindBugs projects
- and saved FindBugs analysis results.
- <li>Improvements to detection of serious non-short-circuit evaluation.
- <li>Updated Japanese localization (thanks to Ruimo Uno)
-
- <li>Eclipse plugin changes:
- <ul>
- <li>Created Bug User Annotations and Bug Tree Views
- <li>Use different icons for different bug priorities
- <li>Provide more information in Bug Details view
- </ul>
- </ul>
-
- <p>
- Changes since version 1.1.2:
- </p>
- <ul>
- <li>Fixed broken Ant task
- <li>Added running ant task to smoke test
- <li>Added validating xml and html output to smoke test
- <li>Fixed some (but not all) issues with html output validation
- <li>Added check for x.equals(x) and x.compareTo(x)
- <li>Various bug fixes
- </ul>
- <p>
- Changes since version 1.1.1:
- </p>
- <ul>
- <li>
- Added check for infinite iterative loops
- </li>
- <li>
- Added check for use of incompatible types in a collection (e.g.,
- checking to see if a Set<String> contains a StringBuffer).
- </li>
- <li>
- Added check for invocations of equals or hashCode on a URL,
- which,
- <a
- href="http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html">surprising
- many people</a>, requires DNS resolution.
- </li>
- <li>
- Added check for classes that define compareTo but not equals;
- such classes can exhibit some anomalous behavior (e.g., they are
- treated differently by PriorityQueues in Java 5 and Java 6).
- </li>
- <li>
- Added a check for useless self operations (e.g., x < x or x ^ x).
- </li>
- <li>
- Fixed a data race that could cause the GUI to fail on startup
- </li>
- <li>
- Partial internationalization of the new GUI
- </li>
- <li>
- Fix bug in "Redo analysis" option of new GUI
- </li>
- <li>
- Tuning to reduce false positives
- </li>
- <li>
- Fixed a bug in null pointer analysis that was generating false
- positive null pointer warnings on exception paths. Fixing this
- bug eliminates about 1/4 of the warnings on null pointer
- exceptions on exception paths.
- </li>
- <li>
- Fixed a bug in the processing of phi nodes for fields in the null
- pointer analysis
- </li>
- <li>
- Applied contributed patch that provides more quick fixes in
- Eclipse plugin.
- </li>
- <li>
- Fixed a number of bugs in the Eclipse auto update sites, and in the way
- date qualifiers were being used in the Eclipse plugin. You may need to manually
- disable your existing version of the plugin and download the 1.1.2 from the update
- site to get the automatic update function working correctly.
- The Eclipse update sites are described at <a href="http://findbugs.cs.umd.edu/eclipse/">http://findbugs.cs.umd.edu/eclipse/</a>.
-
- </li>
- <li>
- Fixed progress bar in Eclipse plugin
- </li>
- <li>
- A number of other bug fixes.
- </li>
- </ul>
-
- <p>
- Changes since version 1.1.0:
- </p>
- <ul>
- <li>
- less scanning of classes not on the analysis path (This was
- causing some performance problems.)
- </li>
- <li>
- no unread field warnings for fields annotated with
- javax.persistent or javax.ejb3
- </li>
- <li>
- Eclipse plugin
- <ul>
- <li>
- bug annotation info displayed in Bug Details tab
- </li>
- <li>
- .fbwarnings data file now stored in .metadata (not in the
- project itself)
- </li>
- </ul>
- </li>
- <li>
- new SE_BAD_FIELD_INNER_CLASS pattern
- </li>
- <li>
- updates to Japanese translation (ruimo)
- </li>
- <li>
- fix some internal slashed/dotted path confusion
- </li>
- <li>
- other minor improvements
- </li>
- </ul>
-
- <p>
- Changes since version 1.0.0:
- </p>
-
- <ul>
- <li>
- Overall, the change from FindBugs 1.0.0 to FindBugs 1.1.0 has
- been a big change. We've done a lot of work in a lot of areas,
- and aren't even going to try to enumerate all the changes.
- </li>
- <li>
- We spent a lot of time reviewing the results generated by
- FindBugs for open source and commercial code bases, and made a
- number of changes, small and large, to minimize the number of
- false positives. Our primary focus for this was warnings reported
- as high and medium priority correctness warnings. Our internal
- evaluation is that we produce very few high/medium priority
- correctness warnings where the analysis is actually wrong, and
- that more than 75% of the high/medium priority correctness
- warnings correspond to real coding defects that need addressing
- in the source code. The remaining 25% are largely cases such as a
- branch or statement that if taken would lead to an error, but in
- fact is a dead branch or statement that can never be taken. Such
- coding is confusing and hard to maintain, so it should arguably
- be fixed, but it is unlikely to actually result in an error
- during execution. Thus, some might classify those warnings as
- false positives.
-
- </li>
- <li>
- We've substantially improved the analysis for errors that could
- result in null pointer dereferences. Overall, our experience has
- been that these changes have roughly doubled the number of null
- pointer errors we detect, without increasing the number of false
- positives (in fact, our false positive rate has gone down). The
- improvements are due to four factors:
- <ul>
- <li>
- By default, we now do some interprocedural analysis to
- determine methods that unconditionally dereference their
- parameters.
- </li>
- <li>
- FindBugs also comes with a model of which JDK methods
- unconditionally dereference their parameters.
- </li>
- <li>
- We do limited tracking of fields, so that we can detect null
- values stored in fields that lead to exceptions.
- </li>
- <li>
- We implemented a new analysis technique to find guaranteed
- dereferences. Consider the following example:
-
- <code>
- <pre>public int f(Object x, boolean b) {
- int result = 0;
- if (x == null) result++;
- else result--;
- // at this point, we know x is null on a simple path
- if (b) {
- // at this point, x is only null on a complex path
- // we don't know if the path in which x is null and b is true is feasible
- return result + x.hashCode();
- }
- else {
- // at this point, x is only null on a complex path
- // we don't know if the path in which x is null and b is false is feasible
- return result - x.hashCode();
- }
-</pre>
- </code>
-
- <p>
- FindBugs 1.0 used forward dataflow analysis to determine
- whether each value is definitely null, null on a simple path,
- possible null on a complex path, or definitely nonnull. Thus,
- at the statement where
- <code>
- result
- </code>
- is decremented, we know that
- <code>
- x
- </code>
- is definitely null, and at the point before
- <code>
- if (b)
- </code>
- , we know that
- <code>
- x
- </code>
- is null on a simple path. If
- <code>
- x
- </code>
- were to be dereferenced here, we would generate a warning,
- because if the else branch of the
- <code>
- if (x == null)
- </code>
- were ever taken, a null pointer exception would result.
- </p>
-
- <p>
- However, in both the then and else branches of the
- <code>
- if (b)
- </code>
- statement,
- <code>
- x
- </code>
- is only null on a complex path that may be infeasible. It
- might be that the program logic is such that if
- <code>
- x
- </code>
- is null, then
- <code>
- b
- </code>
- is never true, so generating a warning about the dereference
- in the then clause might be a false positive. We could try to
- analyze the program to determine whether it is possible for
- <code>
- x
- </code>
- to be null and
- <code>
- b
- </code>
- to be true, but that can be a hard analysis problem.
- </p>
-
- <p>
- However,
- <code>
- x
- </code>
- is dereferenced in both the then
- <em>and</em> else branches of the
- <code>
- if (b)
- </code>
- statement. So at the point immediately before
- <code>
- if (b)
- </code>
- , we know that
- <code>
- x
- </code>
- is null on a simple path
- <em>and</em> that
- <code>
- x
- </code>
- is guaranteed to be dereferenced on all paths from this point
- forward. FindBugs 1.1 performs a backwards data flow analysis
- to determine the values that are guaranteed to be
- dereferenced, and will generate a warning in this case.
- </p>
- </li>
- </ul>
- <p>
- The following screen shot of our new GUI shows an example of
- this analysis, as well as showing off our new GUI and points out
- a limitation of our current plugins for Eclipse and NetBeans.
- The screen shot shows a null pointer bug in HelpDisplay.java.
- The test for
- <code>
- href!=null
- </code>
- on line 78 suggests that
- <code>
- href
- </code>
- could be null. If it is, then
- <code>
- href
- </code>
- will be dereferenced on either line 87 or on line 90, generating
- a NPE. Note that our analysis here also understands that passing
- <code>
- href
- </code>
- to
- <code>
- URLEncoder.encode
- </code>
- will deference it, and thus treats line 87 as a dereference,
- even though
- <code>
- href
- </code>
- is not actually dereferenced at that line. Within our new GUI,
- all of these locations are highlighted and listed in the summary
- panel. In the original GUI (and in HTML output) we list all of
- the locations, but only the primary location is highlighted by
- the original GUI. In the Eclipse and NetBeans plugins, only the
- primary location is displayed; fixing this is on our todo list
- (contributions welcome).
- </p>
- <p>
- <img src="guaranteedDereference.png" alt="">
-
-
- </p>
-
- </li>
- <li>
- Preliminary support for detectors using the frameworks other than
- BCEL, such as the
- <a href="http://asm.objectweb.org/">ASM</a> bytecode framework.
- You may experiment with writing ASM-based detectors, but beware
- the API may still change (which could possibly also affect
- BCEL-based detectors). In general, we've started trying to move
- away from a deep dependence on BCEL, but that change is only
- partially complete. Probably best to just avoid this until we
- complete more work on this. This change is only visible to
- FindBugs plugin developers, and shouldn't be visible to FindBugs
- users.
- </li>
- <li>
- <p>
- Bug categories (CORRECTNESS, MT_CORRECTNESS, etc.) are no longer
- hard-coded, but rather defined in xml files associated with
- plugins, including the core plugin which defines the standard
- categories. Third-party plugins can define their own categories.
- </p>
- </li>
- <li>
- <p>
- Several bug patterns have been moved from CORRECTNESS and STYLE
- into a new category, BAD_PRACTICE. The English localization of
- STYLE has changed from "Style" to "Dodgy."
- </p>
- <p>
- In general, we've worked very hard to limit CORRECTNESS bugs to
- be real programming errors and sins of commission. We have
- reclassified as BAD_PRACTICE a number of bad design practices
- that result in overly fragile code, such as defining an equals
- method that doesn't accept null or defining class with a equals
- method that inherits hashCode from class Object.
- </p>
- <p>
- In general, our guidelines for deciding whether a bug should be
- classified as CORRECTNESS, BAD_PRACTICE or STYLE are:
- </p>
- <dl>
- <dt>
- CORRECTNESS
- </dt>
- <dd>
- A problem that we can recognize with high confidence and is an
- issue that we believe almost all developers would want to
- examine and address. We recommend that software teams review
- all high and medium priority warnings in their entire code
- base.
- </dd>
- <dt>
- BAD_PRACTICE
- </dt>
- <dd>
- A problem that we can recognize with high confidence and
- represents a clear violation of recommended and standard coding
- practice. We believe each software team should decide which bad
- practices identified by FindBugs it wants to prohibit in the
- team's coding standard, and take action to remedy violations of
- those coding standards.
- </dd>
- <dt>
- STYLE
- </dt>
- <dd>
- These are places where something strange or dodgy is going on,
- such as a dead store to a local variable. Typically, less than
- half of these represent actionable programming defects.
- Reviewing these warnings in any code under active development
- is probably a good idea, but reviewing all such warnings in
- your entire code base might be appropriate only in some
- situations. Individual or team programming styles can
- substantially influence the effectiveness of each of these
- warnings (e.g., you might have a coding practice or style in
- your group that confuses one of the detectors into generating a
- lot of STYLE warnings); you will likely want to selectively
- suppress or report the STYLE warnings that are effective for
- your group.
- </dd>
- </dl>
- </li>
- <li>
- Released a preliminary version of a new GUI (known internally as
- GUI2 -- not very creative, huh?)
- </li>
- <li>
- Provided standard ways to mark user designations of bug warnings
- (e.g., as NOT_A_BUG or SHOULD_FIX). The internal logic now
- records this, it is represented in the XML file, and GUI2 allows
- the designations to be applied (along with free-form user
- annotations about each warning). The user designations and
- annotations are not yet supported by the Eclipse plugin, but we
- clearly want to support it in Eclipse shortly.
- </li>
- <li>
- Added a check for a bad comparison with a signed byte with a
- value not in the range -128..127. For example:
- <code>
- <pre>boolean find200(byte b[]) {
- for(int i = 0; i < b.length; i++) if (b[i] == 200) return i;
- return -1;
-}
-</pre>
- </code>
- </li>
- <li>
- Added a checking for testing if a value is equal to Double.NaN
- (no value is equal to NaN, not even NaN).
- </li>
- <li>
- Added a check for using a class with an equals method but no
- hashCode method in a hashed data structure.
- </li>
- <li>
- Added check for uncallable method of an anonymous inner class.
- For example, in the following code, it is impossible to invoke
- the initalValue method (because the name is misspelled and as a
- result is doesn't override a method in ThreadLocal).
- <code>
- <pre>private static ThreadLocal serialNum = new ThreadLocal() {
- protected synchronized Object initalValue() {
- return new Integer(nextSerialNum++);
- }
- };
-</pre>
- </code>
- </li>
- <li>
- Added check for a dead local store caused by a switch statement
- fall through
- </li>
- <li>
- Added check for computing the absolute value of a random 32 bit
- integer or of a hashcode. This is broken because
- <code>
- Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE
- </code>
- , and thus result of calling Math.abs, which is expected to be
- nonnegative, will in fact be negative one time out of 2
- <sup>
- 32
- </sup>
- , which will invariably be the time your boss is demoing the
- software to your customers.
-
- </li>
- <li>
- More careful resolution of inherited methods and fields. Some of
- the shortcuts we were taking in FindBugs 1.0.0 were leading to
- inaccurate results, and it was fairly easy to address this by
- making the analysis more accurate.
- </li>
- <li>
- Overall, analysis times are about 1.6 times longer in FindBugs
- 1.1.0 than in FindBugs 1.0.0. This is because we have enabled
- substantial additional analysis at the default effort level (the
- actual analysis engine is significantly faster than in FindBugs
- 1.0). On a recent AMD Athlon processor, analyzing JDK1.6.0 (about
- 1 million lines of code) requires about 15 minutes of wall clock
- time.
- </li>
- <li>
- Provided class and script (printClass) to print classfile in the
- human readable format produced by BCEL
- </li>
- <li>
- Provided -findSource option to setBugDatabaseInfo
- </li>
- </ul>
-
-
- <p>
- Changes since version 0.9.7:
- </p>
-
- <ul>
- <li>
- fix ObjectTypeFactory bug that was suppressing some bugs
- </li>
- <li>
- opcode stack may determine definite zeros on some paths
- </li>
- <li>
- opcode stack can track some constant string concatenations
- (dbrosius)
- </li>
- <li>
- default effort performs iterative opcode analysis (but min effort
- does not)
- </li>
- <li>
- default heap size upped to 384m
- </li>
- <li>
- schema for XML output available: bugcollection.xsd
- </li>
- <li>
- fixed some internal confusion between dotted and slashed class
- names
- </li>
- <li>
- New detectors
- <ul>
- <li>
- CheckImmutableAnnotation.java: checks JCIP annotations
- </li>
- </ul>
- </li>
- <li>
- Updated detectors
- <ul>
- <li>
- BadRegEx.java: understands Pattern.LITERAL, warns about "."
- </li>
- <li>
- FindUnreleasedLock.java: fewer false positives
- </li>
- <li>
- DumbMethods.java: check for vacuous comparisons to MAX_INTEGER
- or MIN_INTEGER, fix bugs detecting DM_NEXTINT_VIA_NEXTDOUBLE
- </li>
- <li>
- FindPuzzlers.java: detect
- <tt>n%2==1</tt>, detect toString() on array types
- </li>
- <li>
- FindInconsistentSync2.java: detects IS_FIELD_NOT_GUARDED
- </li>
- <li>
- MethodReturnCheck.java: add check for discarded newly
- constructed values, increase priority of some ignored
- constructed exceptions, better handling of bytecode compiled by
- Eclipse
- </li>
- <li>
- FindEmptySynchronizedBlock.java: better handling of bytecode
- compiled by Eclipse
- </li>
- <li>
- DoInsideDoPrivileged.java: warn if call to setAccessible isn't
- in doPriviledged, don't report private methods
- </li>
- <li>
- LoadOfKnownNullValue.java: fix bug that was reporting false
- positives on
- <code>
- finally
- </code>
- blocks
- </li>
- <li>
- CheckReturnAnnotationDatabase.java: better checks for unstarted
- threads
- </li>
- <li>
- ConfusionBetweenInheritedAndOuterMethod.java: fewer false
- positives, fixed a package-handling bug
- </li>
- <li>
- BadResultSetAccess.java: separate bug pattern for
- PreparedStatements,
- <code>
- BRZA
- </code>
- category folded into
- <code>
- SQL
- </code>
- category
- </li>
- <li>
- FindDeadLocalStores.java, FindBadCast2.java, DumbMethods.java,
- RuntimeExceptionCapture.java: coalesce similar bugs within a
- method into a single bug instance with multiple source lines
- </li>
- </ul>
- </li>
- <li>
- Eclipse plugin
- <ul>
- <li>
- plugin ID changed from
- <tt>de.tobject.findbugs</tt> to
- <tt>edu.umd.cs.findbugs.plugin.eclipse</tt>
- </li>
- <li>
- support for findbugs eclipse auto-update site
- </li>
- </ul>
- </li>
- <li>
- Updated test case files
- <ul>
- <li>
- BadRegEx.java
- </li>
- <li>
- JSR166.java
- </li>
- <li>
- ConcurrentModificationBug.java
- </li>
- <li>
- DeadStore.java
- </li>
- <li>
- InstanceOf.java
- </li>
- <li>
- LoadKnownNull.java
- </li>
- <li>
- NeedsToCheckReturnValue.java
- </li>
- <li>
- BadResultSetAccessTest.java
- </li>
- <li>
- DeadStore.java
- </li>
- <li>
- TestNonNull2.java
- </li>
- <li>
- TestImmutable.java
- </li>
- <li>
- TestGuardedBy.java
- </li>
- <li>
- BadRandomInt.java
- </li>
- <li>
- six test cases added to new
- <code>
- TigerTraps
- </code>
- directory
- </li>
- </ul>
- </li>
- <li>
- fix bug that was generating duplicate uids
- </li>
- <li>
- fix bug with
- <code>
- -onlyAnalyze some.package.*
- </code>
- on jdk1.4
- </li>
- <li>
- fix regression bug in DismantleByteCode.getRefConstantOperand()
- </li>
- <li>
- fix some minor bugs with the Swing GUI
- </li>
- <li>
- reordered some bugInstances so that source line annotations come
- last
- </li>
- <li>
- removed references to unused java system properties
- </li>
- <li>
- French translation updates (David Cotton)
- </li>
- <li>
- Japanese translation updates (Hanai Shisei)
- </li>
- <li>
- content cleanup for findbugs.xml and messages.xml
- </li>
- <li>
- references to cvs hostname updated to
- findbugs.cvs.sourceforge.net
- </li>
- <li>
- documented xdoc output options, new
- mineBugHistory/computeBugHistory options
- </li>
- </ul>
-
- <p>
- Changes since version 0.9.6:
- </p>
-
- <ul>
- <li>
- performance improvements
- </li>
- <li>
- ObjectType instances are cached to reduce memory footprint
- </li>
- <li>
- for performance and memory reasons stateless detectors are no
- longer cloned, must clear their own state between .class files
- </li>
- <li>
- fixed bug in bytecode-set lookup for methods (was causing bad
- results for IS2, perhaps others)
- </li>
- <li>
- fix some OpcodeStack bugs with integer and long operations,
- perform iterative analysis when effort is
- <tt>max</tt>
- </li>
- <li>
- HTML output includes LongMessage text again (regression in 0.95 -
- 0.96)
- </li>
- <li>
- New detectors
- <ul>
- <li>
- CalledMethods.java: builds a list of invoked methods for other
- detectors to consult (non-reporting)
- </li>
- <li>
- UncallableMethodOfAnonymousClass.java: detect anonymous inner
- classes that define methods that are probably intended to but
- do not override methods in a superclass.
- </li>
- </ul>
- </li>
- <li>
- Updated detectors
- <ul>
- <li>
- FindFieldSelfAssignment.java: recognize separate fields with
- the same name (one from superclass)
- </li>
- <li>
- FindLocalSelfAssignment2.java: handles backward branches better
- (Dave Brosius)
- </li>
- <li>
- FindBadCast2.java: BC_NULL_INSTANCEOF changed to
- NP_NULL_INSTANCEOF
- </li>
- <li>
- FindPuzzlers.java: eliminate false positive on setDate() (Dave
- Brosius)
- </li>
- </ul>
- </li>
- <li>
- Eclipse plugin
- <ul>
- <li>
- fix serious threading bug
- </li>
- <li>
- preferences for Filters and effort (Peter Hendriks)
- </li>
- <li>
- French localization (David Cotton)
- </li>
- <li>
- fix bug when reporting inner classes (Peter Friese)
- </li>
- </ul>
- </li>
- <li>
- Updated test case files
- <ul>
- <li>
- Mwn.java (Carl Burke/Dave Brosius)
- </li>
- <li>
- DumbMethodInvocations.java (Anto paul/Dave Brosius)
- </li>
- <!--sic-->
- </ul>
- </li>
- <li>
- XML output includes garbage collection duration
- </li>
- <li>
- French messages updated (David Cotton)
- </li>
- <li>
- Swing GUI shows file name after Load Bugs command
- </li>
- <li>
- Ant task to launch the findbugs frame (Mark McKay)
- </li>
- <li>
- miscellaneous code cleanup
- </li>
- </ul>
-
- <p>
- Changes since version 0.9.5:
- </p>
-
- <ul>
- <li>
- Updated detectors
- <ul>
- <li>
- FindNullDeref.java: respect NonNull and CheckForNull field
- annotations
- </li>
- <li>
- SerializableIdiom.java: detect non-private readObject and
- writeObject methods
- </li>
- <li>
- FindRefComparison.java: smarter array comparison detection
- </li>
- <li>
- IsNullValueAnalysis.java: detect
- <tt>null instanceof</tt>
- </li>
- <li>
- FindLocalSelfAssignment2.java: suppress some false positives
- (Dave Brosius)
- </li>
- <li>
- FindUnreleasedLock.java: don't waste time processing classes
- that don't refer to java.util.concurrent.locks
- </li>
- <li>
- MutableStaticFields.java: report the source line (Dave Brosius)
- </li>
- <li>
- SwitchFallthrough.java: better handling of System.exit() (Dave
- Brosius)
- </li>
- <li>
- MultithreadedInstanceAccess.java: better handling of
- Servlet.init() (Dave Brosius)
- </li>
- <li>
- ConfusionBetweenInheritedAndOuterMethod.java: now enabled
- </li>
- </ul>
- </li>
- <li>
- Eclipse plugin
- <ul>
- <li>
- background processing (Peter Friese)
- </li>
- <li>
- internationalization, Japanese localization (Takashi Okamoto)
- </li>
- </ul>
- </li>
- <li>
- findbugs
- <tt>-onlyAnalyze</tt> option now works on windows platforms
- </li>
- <li>
- mineBugHistory
- <tt>-noTabs</tt> option for better alignment of output columns
- </li>
- <li>
- filterBugs
- <tt>-fixed</tt> option (also: will now recognize the most recent
- version string)
- </li>
- <li>
- XML output includes running time and memory usage data
- </li>
- <li>
- miscellaneous minor corrections to the manual
- </li>
- <li>
- better bytecode analysis of the
- <tt>iinc</tt> instruction
- </li>
- <li>
- fix bug in null pointer analysis
- </li>
- <li>
- improved catch block heuristics
- </li>
- <li>
- some type analysis tweaks
- </li>
- <li>
- Bug priority changes
- <ul>
- <li>
- DumbMethodInvocations.java: decrease priority of hard-coded
- <tt>/tmp</tt> filenames
- </li>
- <li>
- ComparatorIdiom.java: decrease priority of non-serializable
- anonymous comparators
- </li>
- <li>
- FindSqlInjection.java: decrease priority of appending a
- constant or a static
- </li>
- </ul>
- </li>
- <li>
- Updated bug explanations
- <ul>
- <li>
- NM_VERY_CONFUSING (Dave Brosius)
- </li>
- </ul>
- </li>
- <li>
- Updated test case files
- <ul>
- <li>
- BadStoreOfNonSerializableObject.java
- </li>
- <li>
- BadRandomInt.java
- </li>
- <li>
- TestFieldAnnotations.java
- </li>
- <li>
- UseInitCause.java
- </li>
- <li>
- SqlInjection.java
- </li>
- <li>
- ArrayEquality.java
- </li>
- <li>
- BadIntegerOperations.java
- </li>
- <li>
- Pilhuhn.java
- </li>
- <li>
- InstanceOf.java
- </li>
- <li>
- SwitchFallthrough.java (Dave Brosius)
- </li>
- </ul>
- </li>
- <li>
- fix URL decoding bug when running under Java Web Start (Dave
- Brosius)
- </li>
- <li>
- distribution includes
- <tt>project.xml</tt> file for NetBeans
- </li>
- </ul>
-
- <p>
- Changes since version 0.9.4:
- </p>
- <ul>
- <li>
- New detectors
- <ul>
- <li>
- VarArgsProblems.java
- </li>
- <li>
- FindSqlInjection.java: now enabled
- </li>
- <li>
- ComparatorIdiom.java: comparators usually implement
- serializable
- </li>
- <li>
- Naming.java: detect methods not overridden due to eponymously
- typed args from different packages
- </li>
- </ul>
- </li>
- <li>
- Updated detectors
- <ul>
- <li>
- SwitchFallthrough.java: surpress some false positives
- </li>
- <li>
- DuplicateBranches.java: surpress some false positives
- </li>
- <li>
- IteratorIdioms.java: surpress some false positives
- </li>
- <li>
- FindHEmismatch.java: surpress some false positives
- </li>
- <li>
- QuestionableBooleanAssignment.java: finds more cases of
- <tt>if (b=true)</tt> ilk
- </li>
- <li>
- DumbMethods.java: detect int remainder by 1, delayed gc errors
- </li>
- <li>
- SerializableIdiom.java: detect store of nonserializable object
- into field of serializable class
- </li>
- <li>
- FindNullDeref.java: fix potential exception
- </li>
- <li>
- IsNullValue.java: fix potential exception
- </li>
- <li>
- MultithreadedInstanceAccess.java: fix potential exception
- </li>
- <li>
- PreferZeroLengthArrays.java: flag the method, not the line
- </li>
- </ul>
- </li>
- <li>
- Remove some inadvertent dependencies on JDK 1.5
- </li>
- <li>
- Sort order should be more consistent
- </li>
- <li>
- XML output changes
- <ul>
- <li>
- Option to sort XML bug output
- </li>
- <li>
- Now contains instance IDs
- </li>
- <li>
- uid no longer missing (was causing problems with fancy HTML
- output)
- </li>
- <li>
- Typo fixed
- </li>
- </ul>
- </li>
- <li>
- Internal changes to track source files,
- <tt>-sourceInfo</tt> option
- </li>
- <li>
- Bug matching: first try exact bug pattern matching, option to
- compare priorities, option to disable package moves
- </li>
- <li>
- Architecture documentation in
- <tt>design/architecture</tt>
- </li>
- <li>
- Test cases move into their own CVS project
- </li>
- <li>
- Don't report warnings that occur outside the analyzed classes
- </li>
- <li>
- Fixes to the build.xml files
- </li>
- <li>
- Better handling of @CheckReturnValue and @CheckForNull
- annotations (also, some additional methods searched for check
- return value and check for null)
- </li>
- <li>
- Fixed some stream-closing bugs (one by
- <tt>z-fb-user</tt>/Dave Brosius)
- </li>
- <li>
- Bug priority changes
- <ul>
- <li>
- increase priority of ignoring return value of
- java.sql.Connection methods
- </li>
- <li>
- increase priority of comparing classes like Integer using
- <tt>==</tt>
- </li>
- <li>
- decrease priority of IT_NO_SUCH_ELEMENT if we see any call to
- <tt>next()</tt>
- </li>
- <li>
- tweak priority of NM_METHOD_CONSTRUCTOR_CONFUSION
- </li>
- <li>
- decrease priority of RV_RETURN_VALUE_IGNORED for an inherited
- annotation that doesn't return same type as class
- </li>
- </ul>
- </li>
- <li>
- Updated bug explanations
- <ul>
- <li>
- RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE
- </li>
- <li>
- DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED
- </li>
- <li>
- IMA_INEFFICIENT_MEMBER_ACCESS (Dave Brosius)
- </li>
- <li>
- some Japanese improvements to messages_ja.xml (
- <tt>ruimo</tt>)
- </li>
- <li>
- some German improvements to findbugs_de.properties (Dave
- Brosius,
- <tt>dvholten</tt>)
- </li>
- </ul>
- </li>
- <li>
- Updated test case files
- <ul>
- <li>
- BadIntegerOperations.java
- </li>
- <li>
- SecondKaboom.java
- </li>
- <li>
- OpenDatabase.java (Dave Brosius)
- </li>
- <li>
- FindOpenStream.java (Dave Brosius)
- </li>
- <li>
- BadRandomInt.java
- </li>
- </ul>
- </li>
- <li>
- Source-lines info maintained for methods (handy for abstract and
- native methods)
- </li>
- <li>
- Remove surrounding opcodes from source line annotations
- </li>
- <li>
- Better error when can't read file
- </li>
- <li>
- Swing GUI: removed console pane from FindBugsFrame, fix missing
- classes bug
- </li>
- <li>
- Fixes to OpcodeStack.java
- </li>
- <li>
- Detectors may attach a custom value to an OpcodeStack.Item (Dave
- Brosius)
- </li>
- <li>
- Filter.java: ability to add text messages to XML output, fix bug
- with
- <tt>-withMessages</tt>
- </li>
- <li>
- SourceInfoMap supports ranges of source lines
- </li>
- <li>
- Ant task supports the
- <tt>timestampNow</tt> attribute
- </li>
- </ul>
-
- <p>
- Changes since version 0.9.3:
- </p>
- <ul>
- <li>
- Substantial rework of datamining code
- </li>
- <li>
- Removed bogus warnings about await on things other than Condition
- not being in a loop
- </li>
- <li>
- Fixed bug in OpcodeStack handling of dup2 of long/double values
- </li>
- <li>
- Don't report array types as missing classes
- </li>
- <li>
- Adjustment of some warnings on ignored return values
- </li>
- <li>
- Added thread safety annotations from Java Concurrency in Practice
- (no detectors written for these yet)
- </li>
- <li>
- Added annotation for methods that, if overridden, should be
- invoked by overriding methods via a call to super
- </li>
- <li>
- Updated -html:fancy.xsl (Etienne Giraudy)
- </li>
- </ul>
-
- <p>
- Note: there was no version 0.9.2
- </p>
-
- <p>
- Changes since version 0.9.1:
- </p>
- <ul>
- <!-- New detectors -->
- <li>
- Embellish USM to find abstract methods that implement an
- interface method (Dave Brosius)
- </li>
- <li>
- New detector to find stores of literal booleans inside if or
- while expressions (Dave Brosius)
- </li>
- <li>
- New style detector to find final classes that declare protected
- fields (Dave Brosius)
- </li>
- <li>
- New detector to find subclass methods that simply forward,
- verbatim, to the super class (Dave Brosius)
- </li>
- <li>
- Detector to find instances where code is attempting to write an
- object out via an implementation of DataOutput, but the object is
- not guaranteed to be Serializable (Jon Christiansen, Bill Pugh)
- </li>
-
- <!-- Feature enhancements -->
- <li>
- Large (35%) analysis speedup (Bill Pugh)
- </li>
- <li>
- Add line numbers to Swing GUI code panel (Dave Brosius)
- </li>
- <li>
- Added effort options to Swing GUI (Dave Brosius)
- </li>
- <li>
- Add ability to specify bugs file to open from command line for
- GUI version, through -loadbugs (Phillip Martin)
- </li>
- <li>
- New stylesheet for generating HTML: use option
- <tt>-html:plain.xsl</tt> (Chris Nappin)
- </li>
- <li>
- New stylesheet for generating HTML: use option
- <tt>-html:fancy.xsl</tt> (Etienne Giraudy)
- </li>
- <li>
- Updated Japanese bug message translations (Shisei Hanai)
- </li>
-
- <!-- Bug fixes -->
- <li>
- XHTML compliance fixes for bug details (Etienne Giraudy)
- </li>
- <li>
- Various detector fixes (Shisei Hanai)
- </li>
- <li>
- Fixed bugs in the project preferences dialog int the Eclipse
- plugin (Takashi Okamoto, Thomas Einwaller)
- </li>
- <li>
- Lowered priority of analysis thread in Swing GUI (David
- Hovemeyer, suggested by Shisei Hanai and Jeffrey W. Badorek)
- </li>
- <li>
- Fixed EclipsePlugin to correctly pick up auxclasspath entries
- (Jon Christiansen)
- </li>
- </ul>
-
- <p>
- Changes since version 0.9.0:
- </p>
- <ul>
- <li>
- Fixed dependence on JRE 1.5: all features should work on JRE 1.4
- again
- </li>
- <li>
- Fixed -effort command line option handling for Swing GUI
- </li>
- <li>
- Fixed conserveSpace and workHard attributes int Ant task
- </li>
- <li>
- Added support for effort attribute in Ant task
- </li>
- </ul>
-
- <p>
- Changes since version 0.8.8:
- </p>
- <ul>
- <!-- New detectors and bug patterns -->
- <li>
- XMLFactoryBypass detector to find direct allocation of xml class
- implementations (Dave Brosius)
- </li>
- <li>
- InefficientMemberAccess detector to find accesses to owning class
- private members (Dave Brosius)
- </li>
- <li>
- DuplicateBranches detector checks switch statements too (Dave
- Brosius)
- </li>
-
- <!-- Feature enhancements -->
- <li>
- FindBugs available from findbugs.sourceforge.net as Java Web
- Start application (Dave Brosius)
- </li>
- <li>
- Updated Japanese bug message translations (Shisei Hanai)
- </li>
- <li>
- Improved bug detail message for covariant equals() (Shisei Hanai)
- </li>
- <li>
- Modeling of instanceof checks is now enabled by default, making
- the bad cast detector much more useful (Bill Pugh, David
- Hovemeyer)
- </li>
- <li>
- Support for detector ordering constraints in plugin descriptor
- (David Hovemeyer)
- </li>
- <li>
- Simpler option to control analysis effort: -effort:
- <i>value</i>, where
- <i>value</i> is one of
- <code>
- min
- </code>
- ,
- <code>
- default
- </code>
- , or
- <code>
- max
- </code>
- (David Hovemeyer)
- </li>
- <li>
- Using -effort:max, FindNullDeref checks for null arguments passed
- to methods which dereference them unconditionally (David
- Hovemeyer)
- </li>
- <li>
- FindNullDeref checks @Null and @NonNull annotations for
- parameters and return values (David Hovemeyer)
- </li>
-
- <!-- Bug fixes -->
- </ul>
-
- <p>
- Changes since version 0.8.7:
- </p>
-
- <ul>
- <!-- New detectors and bug patterns -->
- <li>
- New detector to find duplicate code in if/else statements (Dave
- Brosius)
- </li>
- <li>
- Look for calls to wait() on Condition objects (David Hovemeyer)
- </li>
- <li>
- Look for java.util.concurrent.Lock objects not released on every
- path out of method (David Hovemeyer)
- </li>
- <li>
- Look for calls to Thread.sleep() with a lock held (David
- Hovemeyer)
- </li>
- <li>
- More accurate detection of impossible casts (Bill Pugh, David
- Hovemeyer)
- </li>
-
- <!-- Feature enhancements -->
- <li>
- Saved XML now contains project statistics (Jay Dunning)
- </li>
- <li>
- Filter files can select by bug pattern type and warning priority
- (David Hovemeyer)
- </li>
-
- <!-- Bug fixes -->
- <li>
- Restored some files inadvertently omitted from previous release
- (Rohan Lloyd, David Hovemeyer)
- </li>
- <li>
- Make sure detectors requiring JDK 1.5 runtime classes are only
- executed if those classes are available (David Hovemeyer)
- </li>
- <li>
- Don't display analysis error dialog unless there is really an
- error (David Hovemeyer)
- </li>
- <li>
- Updated and expanded French translations of bug patterns and
- Swing GUI (Olivier Parent)
- </li>
- <li>
- Fixed invalid character encoding in German Swing GUI translation
- (Olivier Parent)
- </li>
- <li>
- Fix locale used for date format in project stats (K. Hashimoto)
- </li>
- <li>
- Fixed LongDescription elements in xml:withMessages output format
- (K. Hashimoto)
- </li>
- </ul>
-
- <p>
- Changes since version 0.8.6:
- </p>
-
- <ul>
- <!-- new detectors -->
- <li>
- Extend Naming detector to look for classes that are named
- XXXException but that are not Exceptions (Dave Brosius)
- </li>
- <li>
- New detector to find classes that expose semaphores in the public
- implementation through the 'this' reference. (Dave Brosius)
- </li>
- <li>
- New Style detector to find Struts Action/Servlet derived classes
- that reference instance member variable not in synchronized
- blocks. (Dave Brosius)
- </li>
- <li>
- New Style detector to find classes that declare implementation of
- interfaces that are already implemented by super classes (Dave
- Brosius)
- </li>
- <li>
- New Style detector to find circular dependencies between classes
- (Dave Brosius)
- </li>
- <li>
- New Style detector to find unnecessary math on constants (Dave
- Brosius)
- </li>
- <li>
- New detector to find equality comparisons using floating point
- math (Jay Dunning)
- </li>
- <li>
- New faster detector to find local self assignments (Bill Pugh)
- </li>
- <li>
- New detector to find infinite recursive loops (Bill Pugh)
- </li>
- <li>
- New detector to find for loops with an incorrect increment (Bill
- Pugh)
- </li>
- <li>
- New detector to find suspicious uses of BufferedReader.readLine()
- and String.indexOf() (Bill Pugh)
- </li>
- <li>
- New detector to find suspicious integer to double casts (David
- Hovemeyer, Bill Pugh)
- </li>
- <li>
- New detector to find invalid regular expression patterns (Bill
- Pugh)
- </li>
- <li>
- New detector to find Bloch/Gafter Java puzzlers (Bill Pugh)
- </li>
-
- <!-- feature enhancements -->
- <li>
- New system property to suppress reporting of DLS based on local
- variable name (Glenn Boysko)
- </li>
- <li>
- Enhancements to configuration dialog in Eclipse plugin, allow for
- saving enabled detectors in Eclipse projects (Phil Crosby)
- </li>
- <li>
- Sortable columns in detector dialog (Dave Brosius)
- </li>
- <li>
- New tab in gui for showing bugs grouped by category (Dave
- Brosius)
- </li>
- <li>
- Improved German translation of Swing GUI (Thomas Kuehne)
- </li>
- <li>
- Improved source file reporting in Emacs output format (Len Trigg)
- </li>
- <li>
- Improvements to redundant null comparison detector (Bill Pugh)
- </li>
- <li>
- Localization of run analysis and analysis error dialogs in Swing
- GUI (K. Hashimoto)
- </li>
-
- <!-- Bug fixes -->
- <li>
- Don't scan equals methods in FindHEMismatch if code is native
- (Greg Bentz)
- </li>
- <li>
- French translation fixes (David Cotton)
- </li>
- <li>
- Internationalization report fixes (K. Hashimoto)
- </li>
- <li>
- Japanese translations updates (SHISEI Hanai)
- </li>
- </ul>
-
- <p>
- Changes since version 0.8.5:
-
- </p>
- <ul>
- <!-- new detectors -->
- <li>
- New detector to find catch blocks that may inadvertently catch
- runtime exceptions (Brian Goetz)
- </li>
- <li>
- New detector to find objects that are instantiated based on
- classes that only have static methods and fields, using the
- synthesized constructor (Dave Brosius)
- </li>
- <li>
- New detector to find calls to Thread.interrupted() in a non
- static context, and especially with non currentThread() threads
- (Dave Brosius)
- </li>
- <li>
- New detector to find calls to equals() methods that use Object's
- version. (Dave Brosius)
- </li>
- <li>
- New detector to find Applets that call methods in the constructor
- refering to the AppletStub (Dave Brosius)
- </li>
- <li>
- New detector to find some cases of infinite recursion (Bill Pugh)
- </li>
- <li>
- New detector to find dead stores to local variables (David
- Hovemeyer, Bill Pugh)
- </li>
- <li>
- Extend Dumb Method detector for toUpperCase(), toLowerCase()
- without a locale, new Integer(1).toString(), new
- XXX().getClass(), and new Thread() without a run implementation
- (Dave Brosius)
- <!-- feature enhancements -->
- </li>
- <li>
- Ant task supports "errorProperty" attribute, which sets an Ant
- property to "true" if an error occurs running FindBugs (Michael
- Tamm)
- </li>
- <li>
- Eclipse plugin allows filtering of warnings by bug category,
- priority (David Hovemeyer)
- </li>
- <li>
- Swing GUI allows filtering of warnings by bug category (David
- Hovemeyer)
- </li>
- <li>
- Ability to annotate methods using Java 1.5 annotations that
- suppress FindBugs warnings (Bill Pugh)
- </li>
- <li>
- New -adjustExperimental for lowering priority of BugPatterns that
- are experimental (Dave Brosius)
- </li>
- <li>
- Allow for command line options 'files' using the @ symbol (David
- Hovemeyer)
- </li>
- <li>
- New -adjustPriority command line option to for adjusting bug
- priorites (David Hovemeyer)
- </li>
- <li>
- Added an Edit menu (cut/copy/paste) to Swing GUI (Dave Brosius)
- </li>
- <li>
- French translation supplied (David Cotton)
- <!-- Bug fixes -->
- </li>
- </ul>
-
- <p>
- Changes since version 0.8.4:
-
- </p>
- <ul>
- <!-- new detectors -->
- <li>
- New detector for volatile references to arrays (Bill Pugh)
- </li>
- <li>
- New detector to find instanceof usage where inheritance can be
- determined statically (Dave Brosius)
- </li>
- <li>
- New detector to find ResultSet.getXXX updateXXX calls using index
- 0 (Dave Brosius)
- </li>
- <li>
- New detector to find empty zip or jar entries (Bill Pugh)
-
- <!-- feature enhancements -->
- </li>
- <li>
- HTML output generation using built-in XSLT stylesheet or
- user-defined stylesheet (David Hovemeyer)
- </li>
- <li>
- Allow URLs to be specified to analyze zip/jar files, local
- directories, and single classfiles (David Hovemeyer)
- </li>
- <li>
- New command line option -onlyAnalyze restricts analysis to
- selected classes and packages without reducing accuracy (David
- Hovemeyer)
- </li>
- <li>
- Allow Swing GUI to show source code in jar files on Windows
- systems (Dave Brosius)
-
- <!-- Bug fixes -->
- </li>
- <li>
- Fix the Switch Fall Thru detector (Dave Brosius, David Hovemeyer,
- Bill Pugh)
- </li>
- <li>
- MacOS GUI fixes (Rohan Lloyd)
- </li>
- <li>
- Fix false positive in BOA in case where method is correctly and
- 'incorrectly' overridden (Dave Brosius)
- </li>
- <li>
- Fixed memory blowup when analyzing methods which access a large
- number of fields (David Hovemeyer)
- </li>
- </ul>
-
- <p>
- Changes since version 0.8.3:
- </p>
- <ul>
- <li>
- Initial and preliminary localization of the Swing GUI.
- Translations by:
- <ul>
- <li>
- German - Peter D. Stout, Holger Stenzhorn
- </li>
- <li>
- Finnish - Juha Knuutila
- </li>
- <li>
- Estonian - Tanel Lebedev
- </li>
- <li>
- Japanese - Hanai Shisei
- </li>
- </ul>
- </li>
- <li>
- Eliminated debug print statements inadvertently left enabled
- </li>
- <li>
- Reverted some changes in the open stream detector: this should
- fix some false positives that were introduced in the previous
- release
- </li>
- <li>
- Fixed a couple missing class reports
- </li>
- </ul>
-
- <p>
- Changes since version 0.8.2:
- </p>
- <ul>
-
- <!-- New detectors -->
- <li>
- New detector to find improperly overridden GUI Adapter classes
- (Dave Brosius)
- </li>
- <li>
- New detector to find improperly setup JUnit TestCases (Dave
- Brosius)
- </li>
- <li>
- New detector to find variables that mask class level fields (Dave
- Brosius)
- </li>
- <li>
- New detector to find comparisons of values computed with bitwise
- operators that always yield the same result (Tom Truscott)
- </li>
- <li>
- New detector to find unsafe getClass().getResource() calls (Bill
- Pugh)
- </li>
- <li>
- New detector to find GUI changes not in GUI thread but in static
- main (Bill Pugh)
- </li>
- <li>
- New detector to find calls to Collection.toArray() with
- zero-length array argument; it is more efficient to pass an array
- the size of the collection, which can be populated and returned
- as the result (Dave Brosius)
-
- <!-- Analysis improvements -->
- </li>
- <li>
- Better suppression of false warnings in various detectors (Bill
- Pugh, David Hovemeyer)
- </li>
- <li>
- Enhancement to ReadReturnShouldBeChecked detector for skip()
- (Dave Brosius)
- </li>
- <li>
- Enhancement to DumbMethods detector (Dave Brosius)
- </li>
- <li>
- Open stream detector does not report wrappers of streams passed
- as method parameters (David Hovemeyer)
-
- <!-- Feature enhancements -->
- </li>
- <li>
- Cancel confirmation dialog in Swing GUI (Pete Angstadt)
- </li>
- <li>
- Better relative path saving in Project file (Dave Brosius)
- </li>
- <li>
- Detector Priority in GUI is now saved in prefs file (Dave
- Brosius)
- </li>
- <li>
- Controls in GUI to reorder source and classpath entries, and
- ability to flip between Project details and bugs pages (Dave
- Brosius)
- </li>
- <li>
- In Swing GUI, analysis error dialog supports "Select All" and
- "Copy" operations for easy generation of error reports (Dave
- Brosius)
- </li>
- <li>
- Complete translation of bug descriptions and messages into
- Japanese (Hanai Shisei)
-
- <!-- Bug fixes -->
- </li>
- <li>
- Fixed bug in DroppedException detector (Dave Brosius)
-
- <!-- Development stuff -->
- </li>
- <li>
- The source distribution defaults to using JDK 1.5 javac to
- compile, but support for compiling with JSR-14 prototype is still
- supported
- </li>
- </ul>
-
- <p>
- Changes since version 0.8.1:
- </p>
- <ul>
- <li>
- Fixed a critical ClassCastException bug (triggered if the
- -workHard option was used, and an exception type was merged with
- an array type during type inference)
- </li>
- </ul>
-
- <p>
- Changes since version 0.8.0:
-
- </p>
- <ul>
- <li>
- Disabled SwitchFallthrough detector to work around
- NullPointerExceptions
- </li>
- <li>
- Added some additional false positive suppression heuristics
- </li>
- </ul>
-
- <p>
- Also, two contributors to the 0.8.0 release were inadvertently
- left out of the credits:
-
- </p>
- <ul>
- <li>
- Pete Angstadt fixed several problems in the Swing GUI
- </li>
- <li>
- Francis Lalonde provided a task resource file for the FindBugs
- Ant task
- </li>
- </ul>
-
- <p>
- Changes since version 0.7.4:
-
- </p>
- <ul>
- <li>
- New detector to look for uses of "+" operator to concatenate
- String objects in a loop (Dave Brosius)
- </li>
- <li>
- Reference comparison detector looks for places where the argument
- passed to the equals(Object) method isn't the same type as the
- receiver object
- </li>
- <li>
- Better suppression of false warnings in many detectors
- </li>
- <li>
- Many improvements to Eclipse plugin (Andrei Loskutov, Peter
- Friese)
- </li>
- <li>
- Fixed problem with building Eclipse plugin on Windows (Thomas
- Klaeger)
- </li>
- <li>
- Open stream detector looks for unclosed PreparedStatement objects
- (Thomas Klaeger, Rohan Lloyd)
- </li>
- <li>
- Fix for open stream detector: it wasn't detecting close() methods
- called through an invokeinterface instruction (Thomas Klaeger)
- </li>
- <li>
- Refactoring of visitor classes to enforce use of accessors for
- visited class features (Brian Goetz)
- </li>
- </ul>
-
- <p>
- Changes since version 0.7.3:
-
- </p>
- <ul>
- <li>
- Experimental modification of open stream detector to look for
- non-escaping JDBC resources (connections and statements) that
- aren't closed on all paths out of method
- </li>
- <li>
- Eclipse plugin fixed so it compiles and runs on Eclipse 2.1.x
- (Peter Friese)
- </li>
- <li>
- Option to Swing GUI and command line to generate project file
- using relative paths for archives, source directories, and aux
- classpath entries (Dave Brosius)
- </li>
- <li>
- Improvements to findbugs.bat script for launching FindBugs on
- Windows (Dave Brosius)
- </li>
- <li>
- Updated Japanese message translations (Hiroshi Okugawa)
- </li>
- <li>
- Uncalled private methods are now reported as low priority, unless
- they have the same name as another method in the class (which is
- more likely to indicate an actual bug)
- </li>
- <li>
- Added some missing data in the bug messages XML files
- </li>
- <li>
- Fixed some problems building from source on Windows systems
- </li>
- <li>
- Various minor bug fixes
- </li>
- </ul>
-
- <p>
- Changes since version 0.7.2:
-
- </p>
- <ul>
- <li>
- Enhanced Eclipse plugin, which displays the detailed bug
- description in a view (Phil Crosby)
- </li>
- <li>
- Various tweaks to existing detectors to reduce false warnings
- </li>
- <li>
- New command line option
- <code>
- -workHard
- </code>
- enables pruning of infeasible or unlikely exception edges, which
- results in better accuracy in the open stream detector, at the
- expense of a 30%-100% slowdown
- </li>
- <li>
- New website and HTML documentation design
- </li>
- <li>
- Documentation includes an HTML document with descriptions of all
- bug patterns reported by FindBugs
- </li>
- <li>
- Web page has a link to a
- <a href="http://www.simeji.com/findbugs/doc/manual_ja/index.html">Japanese
- translation</a> of the FindBugs manual, contributed by Hiroshi
- Okugawa
- </li>
- <li>
- Changed the Inconsistent Synchronization detector so that fields
- synchronized 50% of the time (or more) are reported as medium
- priority bugs (previously they were reported as low)
- </li>
- <li>
- New detector to find code that catches
- IllegalMonitorStateException
- </li>
- <li>
- New detector to find private methods that are never called
- </li>
- <li>
- New detector to find suspicious uses of non-short-circuiting
- boolean operators (
- <code>
- &
- </code>
- and
- <code>
- |
- </code>
- , rather than
- <code>
- &&
- </code>
- and
- <code>
- ||
- </code>
- )
- </li>
- </ul>
-
- <p>
- Changes since version 0.7.1:
-
- </p>
- <ul>
- <li>
- Incorporated patched version of BCEL, which allows classes
- compiled with JDK 1.5.0 beta to be analyzed
- </li>
- <li>
- Fixed some bugs related to lookups of array classes
- </li>
- <li>
- Fixed bug that prevented GUI from loading XML result files when
- running under JDK 1.5.0 beta
- </li>
- <li>
- Added new experimental bug detector, LazyInit, which looks for
- potentially buggy lazy initializations of static fields
- </li>
- <li>
- Because of long filenames, switched to distributing the source
- archive as a zip file rather than a tar file
- </li>
- <li>
- The 0.7.1 source tarfile was botched - 0.7.2 has a valid source
- archive
- </li>
- <li>
- Fixed some problems in the Ant build script
- </li>
- <li>
- Fixed NullPointerException when checking Class-Path attribute for
- Jar files without manifests
- </li>
- <li>
- Generate version numbers for the core and UI Eclipse plugins
- using the Version class; all version numbers are now in a common
- location
- </li>
- </ul>
-
- <p>
- Changes since version 0.7.0:
-
- </p>
- <ul>
- <li>
- Eclipse plugin (contributed by Peter Friese)
- </li>
- <li>
- Source package structure rearranged: all source (other than
- Eclipse plugin UI) is in the edu.umd.cs.findbugs package, or a
- subpackage
- </li>
- <li>
- Class-Path attributes of manifests of analyzed jar files are used
- to set the aux classpath automatically (Peter D. Stout)
- </li>
- <li>
- GUI starts in directory specified by user.home property (Peter D.
- Stout)
- </li>
- <li>
- Added -project option to GUI (Mikko T.)
- </li>
- <li>
- Added -look:{plastic,gtk,native} option to GUI, for setting look
- and feel (Mikko T.)
- </li>
- <li>
- Fixed DataflowAnalysisException in inconsistent synchronization
- detector
- </li>
- <li>
- Ant task supports failOnError parameter (Rohan Lloyd)
- </li>
- <li>
- Serializable class warnings are downgraded to low priority for
- GUI classes
- </li>
- <li>
- MWN detector will only report calls to wait(), notify(), and
- notifyAll() methods that have the correct signature
- </li>
- <li>
- FindBugs works with latest CVS version of BCEL
- </li>
- <li>
- Zip and Jar files may be added to the source path
- </li>
- <li>
- The GUI will automatically find source files residing in analyzed
- Zip or Jar files
- </li>
- </ul>
-
- <p>
- Note that the version number jumped from 0.6.6 to 0.6.9; there
- were no 0.6.7 or 0.6.8 releases.
-
- </p>
- <p>
- Changes since version 0.6.9:
- </p>
- <ul>
- <li>
- Added -conserveSpace option to reduce memory use at the expense
- of analysis precision
- </li>
- <li>
- Bug fixes in findbugs.bat script: JAVA_HOME handling,
- autodetection of FINDBUGS_HOME, missing output with -textui
- </li>
- <li>
- Fixed NullPointerException when a missing class is encountered
- </li>
- </ul>
-
- <p>
- Changes since version 0.6.6:
-
- </p>
- <ul>
- <li>
- The null pointer dereference detector is more powerful
- </li>
- <li>
- Significantly improved heuristics and bug fixes in inconsistent
- synchronization detector
- </li>
- <li>
- Improved heuristics in open stream and dropped exception
- detectors; fewer false positives should be reported
- </li>
- <li>
- Save HTML summary in XML results files, rather than recomputing;
- this makes loading results in GUI much faster
- </li>
- <li>
- Report at most one String comparison using == or != per method
- </li>
- <li>
- The findbugs.bat script on Windows autodetects FINDBUGS_HOME, and
- doesn't open a DOS window when launching the GUI (contributed by
- TJSB)
- </li>
- <li>
- Emacs reporting format (contributed by David Li)
- </li>
- <li>
- Various bug fixes
- </li>
- </ul>
-
- <p>
- Changes since 0.6.5:
-
- </p>
- <ul>
- <li>
- Rewritten inconsistent synchronization detector; accuracy is
- significantly improved, and bug reports are prioritized
- </li>
- <li>
- New detector to find self assignment (x=x) of local variables
- (suggested by Jeff Martin)
- </li>
- <li>
- New detector to find calls to wait(), notify(), and notifyAll()
- on an object which is not obviously locked
- </li>
- <li>
- Open stream detector now reports Readers and Writers
- </li>
- <li>
- Fixed bug in finalizer idioms detector which caused spurious
- warnings about failure to call super.finalize() (reported by Jim
- Menard)
- </li>
- <li>
- Fixed bug where output stream was not closed using non-XML output
- (reported by Sigiswald Madou)
- </li>
- <li>
- Fixed corrupted HTML bug detail message (reported by Trevor
- Harmon)
- </li>
- </ul>
-
- <p>
- Changes since version 0.6.4:
-
- </p>
- <ul>
- <li>
- For redundant comparison of reference values, fixed false
- positives resulting from duplication of code in finally blocks
- </li>
- <li>
- Fixed false positives resulting from wrapped byte array streams
- left open
- </li>
- <li>
- Fixed bug in Ant task preventing output file from working
- properly if a relative path was used
- </li>
- </ul>
-
- <p>
- Changes since version 0.6.3:
-
- </p>
- <ul>
- <li>
- Fixed bug in Ant task where output would be corrupted, and added
- a
- <code>
- timeout
- </code>
- attribute
- </li>
- <li>
- Added -outputFile option to text UI, for explicitly specifying an
- output file
- </li>
- <li>
- GUI has a summary window, for statistics about overall bug
- densities (contributed by Mike Fagan)
- </li>
- <li>
- Find redundant comparisons of reference values
- </li>
- <li>
- More accurate detection of Strings compared with == and !=
- operators
- </li>
- <li>
- Detection of other reference types which should generally not be
- compared with == and != operators; Boolean, Integer, etc.
- </li>
- <li>
- Find non-transient non-serializable instance fields in
- Serializable classes
- </li>
- <li>
- Source code may be compiled with latest early access
- generics-enabled javac (version 2.2)
- </li>
- </ul>
-
- <p>
- Changes since version 0.6.2:
-
- </p>
- <ul>
- <li>
- GUI supports filtering bugs by priority
- </li>
- <li>
- Ant task rewritten; supports all functionality offered by Text UI
- (contributed by Mike Fagan)
- </li>
- <li>
- Ant task is fully documented in the manual
- </li>
- <li>
- Classes in nested archives are analyzed; this allows full support
- for analyzing .ear and .war files (contributed by Mike Fagan)
- </li>
- <li>
- DepthFirstSearch changed to use non-recursive implementation;
- this should fix the StackOverflowErrors that several users
- reported
- </li>
- <li>
- Various minor bugfixes and improvements
- </li>
- </ul>
-
- <p>
- Changes since version 0.6.1:
-
- </p>
- <ul>
- <li>
- New detector to look for useless control flow (suggested by
- Richard P. King and Mike Fagan)
- </li>
- <li>
- Look for places where return value of
- java.io.File.createNewFile() is ignored (suggested by Richard P.
- King)
- </li>
- <li>
- Fixed bug in resolution of source files (only the first source
- directory was searched)
- </li>
- <li>
- Fixed a NullPointerException in the bytecode pattern matching
- code
- </li>
- <li>
- Ant task supports project files (contributed by Mike Fagan)
- </li>
- <li>
- Unix findbugs script honors the
- <code>
- JAVA_HOME
- </code>
- environment variable (contributed by Pedro Morais)
- </li>
- <li>
- Allow .war and .ear files to be analyzed
- </li>
- </ul>
-
- <p>
- Changes since version 0.6.0:
-
- </p>
- <ul>
- <li>
- New bug pattern detector which looks for places where a null
- pointer might be dereferenced
- </li>
- <li>
- New bug pattern detector which looks for IO streams that are
- opened, do not escape the method, and are not closed on all paths
- out of the method
- </li>
- <li>
- New bug pattern detector to find methods that can return null
- instead of a zero-length array
- </li>
- <li>
- New bug pattern detector to find places where the == or !=
- operators are used to compare String objects
- </li>
- <li>
- Command line interface can save bugs as XML
- </li>
- <li>
- GUI can save bugs to and load bugs from XML
- </li>
- <li>
- An "Annotations" window in the GUI allows the user to add textual
- annotations to bug reports; these annotations are preserved when
- bugs are saved as XML
- </li>
- <li>
- In this release, the Japanese bug summary translations by Germano
- Leichsenring are really included (they were inadvertently omitted
- in the previous release)
- </li>
- <li>
- Completely rewrote the control flow graph builder, hopefully for
- the last time
- </li>
- <li>
- Simplified implementation of control flow graphs, which should
- reduce memory use and possibly improve performance
- </li>
- <li>
- Improvements to command line interface (list bug priorities,
- filter by priority, specify aux classpath, specify project to
- analyze)
- </li>
- <li>
- Various bug fixes and enhancements
- </li>
- </ul>
-
- <p>
- Changes since version 0.5.4
-
- </p>
- <ul>
- <li>
- Added an
- <a href="http://ant.apache.org/">Ant</a> task for FindBugs,
- contributed by Mike Fagan.
- </li>
- <li>
- Added a GUI dialog which allows individual bug pattern detectors
- to be enabled or disabled. Disabling certain slow detectors
- can greatly speed up analysis of large programs, at the expense
- of reducing the number of potential bugs found.
- </li>
- <li>
- Added a new detector for finding improperly ignored return values
- for methods such as
- <code>
- String.trim()
- </code>
- . Suggested by Andreas Mandel.
- </li>
- <li>
- Japanese translations of the bug summaries, contributed by
- Germano Leichsenring.
- </li>
- <li>
- Filtering of results is supported in command line interface. See
- the
- <a href="manual/index.html">FindBugs manual</a> for details.
- </li>
- <li>
- Added "byte code patterns", a general pattern matching
- infrastructure for bytecode instructions. This feature
- significantly reduces the complexity of implementing new bug
- pattern detectors.
- </li>
- <li>
- Enabled a new general dataflow analysis to track values in
- methods.
- </li>
- <li>
- Switched to new control-flow graph builder implementation.
- </li>
- </ul>
-
- <p>
- Changes since version 0.5.3
-
- </p>
- <ul>
- <li>
- Fixed a bug in the script used to launch FindBugs on Windows
- platforms.
- </li>
- <li>
- Fixed crashes when analyzing class files without source line
- information.
- </li>
- <li>
- All major errors are reported using an error dialog; file not
- found errors are more informative.
- </li>
- <li>
- Minor GUI improvements.
- </li>
- </ul>
-
- <p>
- Changes since version 0.5.2
-
- </p>
- <ul>
- <li>
- All of the source code and related files are in a single
- directory tree.
- </li>
- <li>
- Updated some of the detectors to produce source line information.
- </li>
- <li>
- <a href="http://ant.apache.org/">Ant</a> build script and several
- GUI enhancements and fixes contributed by Mike Fagan.
- </li>
- <li>
- Converted to use a
- <a href="AddingDetectors.txt">plugin architecture</a> for loading
- bug detectors.
- </li>
- <li>
- Eliminated generics-related compiler warnings.
- </li>
- <li>
- More complete documentation has been added.
- </li>
- </ul>
-
- <p>
- Changes since version 0.5.1:
- </p>
- <ul>
- <li>
- Fixed a large number of bugs in the BCEL Repository and
- FindBugs's use of the Repository. With these changes,
- FindBugs should
- <em>never</em> crash or otherwise misbehave because of Repository
- lookup failures. Because of these changes, you must use a
- modified version of
- <code>
- bcel.jar
- </code>
- with FindBugs. This jar file is included in the FindBugs
- 0.5.2 binary release. A complete patch containing the
- <a
- href="http://faculty.ycp.edu/~dhovemey/bcel-30-April-2003.patch">modifications
- against the BCEL CVS main branch as of April 30, 2003</a> is also
- available.
- </li>
- <li>
- Implemented the "auxiliary classpath entry list". Aux
- classpath entries can be added to a project to provide classes
- that are referenced by the analyzed application, but should not
- themselves be analyzed. Having all referenced classes
- available allows FindBugs to produce more accurate results.
- </li>
- </ul>
-
- <p>
- Changes since version 0.5.0:
- </p>
- <ul>
- <li>
- Many user interface bugs have been fixed.
- </li>
- <li>
- Upgraded to a recent CVS version of BCEL, with some bug
- fixes. This should prevent FindBugs from crashing when
- there is a failure to find a class on the classpath.
- </li>
- <li>
- Added support for Plastic look and feel from
- <a href="http://www.jgoodies.com/">jgoodies.com</a>.
- </li>
- <li>
- Major overhaul of infrastructure for doing dataflow analysis.
- </li>
- </ul>
-
-
-<hr> <p>
-<script language="JavaScript" type="text/javascript">
-<!---//hide script from old browsers
-document.write( "Last updated "+ document.lastModified + "." );
-//end hiding contents --->
-</script>
-<p> Send comments to <a class="sidebar" href="mailto:findbugs@cs.umd.edu">findbugs@cs.umd.edu</a>
-<p>
-<A href="http://sourceforge.net"><IMG src="http://sourceforge.net/sflogo.php?group_id=96405&type=5" width="210" height="62" border="0" alt="SourceForge.net Logo" /></A>
-
- </td>
-
- </tr>
- </table>
-
- </body>
-
-</html>
diff --git a/tools/findbugs-1.3.9/doc/allBugDescriptions.html b/tools/findbugs-1.3.9/doc/allBugDescriptions.html
deleted file mode 100644
index 67a32b3..0000000
--- a/tools/findbugs-1.3.9/doc/allBugDescriptions.html
+++ /dev/null
@@ -1,4820 +0,0 @@
-<html><head><title>FindBugs Bug Descriptions (Unabridged)</title>
-<link rel="stylesheet" type="text/css" href="findbugs.css"/>
-<link rel="shortcut icon" href="favicon.ico" type="image/x-icon"/>
-</head><body>
-
-<table width="100%"><tr>
-
-<td bgcolor="#b9b9fe" valign="top" align="left" width="20%">
-<table width="100%" cellspacing="0" border="0">
-<tr><td><a class="sidebar" href="index.html"><img src="umdFindbugs.png" alt="FindBugs"></a></td></tr>
-
-<tr><td> </td></tr>
-
-<tr><td><b>Docs and Info</b></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="factSheet.html">Fact sheet</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="manual/index.html">Manual</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="ja/manual/index.html">Manual(ja/日本語)</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="FAQ.html">FAQ</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="bugDescriptions.html">Bug descriptions</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="mailingLists.html">Mailing lists</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="publications.html">Documents and Publications</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="links.html">Links</a></font></td></tr>
-
-<tr><td> </td></tr>
-
-<tr><td><a class="sidebar" href="downloads.html"><b>Downloads</b></a></td></tr>
-
-<tr><td> </td></tr>
-
-<tr><td><a class="sidebar" href="http://www.cafeshops.com/findbugs"><b>FindBugs Swag</b></a></td></tr>
-
-<tr><td> </td></tr>
-
-<tr><td><b>Development</b></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="http://sourceforge.net/tracker/?group_id=96405">Open bugs</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="reportingBugs.html">Reporting bugs</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="contributing.html">Contributing</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="team.html">Dev team</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="api/index.html">API</a> <a class="sidebar" href="api/overview-summary.html">[no frames]</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="Changes.html">Change log</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="http://sourceforge.net/projects/findbugs">SF project page</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="http://code.google.com/p/findbugs/source/browse/">Browse source</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="http://code.google.com/p/findbugs/source/list">Latest code changes</a></font></td></tr>
-</table>
-</td>
-<td align="left" valign="top">
-<h1>FindBugs Bug Descriptions (Unabridged)</h1>
-<p>This document lists all of the bug patterns reported by the
-latest development version of
-<a href="http://findbugs.sourceforge.net">FindBugs</a>. Note that this may include
-bug patterns not available in any released version of FindBugs,
-as well as bug patterns that are not enabled by default.
-<h2>Summary</h2>
-<table width="100%">
-<tr bgcolor="#b9b9fe"><th>Description</th><th>Category</th></tr>
-<tr bgcolor="#eeeeee"><td><a href="#AM_CREATES_EMPTY_JAR_FILE_ENTRY">AM: Creates an empty jar file entry</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#AM_CREATES_EMPTY_ZIP_FILE_ENTRY">AM: Creates an empty zip file entry</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS">BC: Equals method should not assume anything about the type of its argument</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DMI_RANDOM_USED_ONLY_ONCE">BC: Random object created and used only once</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#BIT_SIGNED_CHECK">BIT: Check for sign of bitwise operation</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#CN_IDIOM">CN: Class implements Cloneable but does not define or use clone method</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#CN_IDIOM_NO_SUPER_CALL">CN: clone method does not call super.clone()</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE">CN: Class defines clone() but doesn't implement Cloneable</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#CO_ABSTRACT_SELF">Co: Abstract class defines covariant compareTo() method</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#CO_SELF_NO_OBJECT">Co: Covariant compareTo() method defined</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DE_MIGHT_DROP">DE: Method might drop exception</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DE_MIGHT_IGNORE">DE: Method might ignore exception</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_USING_REMOVEALL_TO_CLEAR_COLLECTION">DMI: Don't use removeAll to clear a collection</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED">DP: Classloaders should only be created inside doPrivileged block</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DP_DO_INSIDE_DO_PRIVILEGED">DP: Method invoked that should be only be invoked inside a doPrivileged block</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DM_EXIT">Dm: Method invokes System.exit(...)</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DM_RUN_FINALIZERS_ON_EXIT">Dm: Method invokes dangerous method runFinalizersOnExit</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#ES_COMPARING_PARAMETER_STRING_WITH_EQ">ES: Comparison of String parameter using == or !=</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#ES_COMPARING_STRINGS_WITH_EQ">ES: Comparison of String objects using == or !=</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EQ_ABSTRACT_SELF">Eq: Abstract class defines covariant equals() method</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS">Eq: Equals checks for noncompatible operand</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EQ_COMPARETO_USE_OBJECT_EQUALS">Eq: Class defines compareTo(...) and uses Object.equals()</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#EQ_GETCLASS_AND_CLASS_CONSTANT">Eq: equals method fails for subtypes</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EQ_SELF_NO_OBJECT">Eq: Covariant equals() method defined</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#FI_EMPTY">FI: Empty finalizer should be deleted</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#FI_EXPLICIT_INVOCATION">FI: Explicit invocation of finalizer</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#FI_FINALIZER_NULLS_FIELDS">FI: Finalizer nulls fields</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#FI_FINALIZER_ONLY_NULLS_FIELDS">FI: Finalizer only nulls fields</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#FI_MISSING_SUPER_CALL">FI: Finalizer does not call superclass finalizer</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#FI_NULLIFY_SUPER">FI: Finalizer nullifies superclass finalizer</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#FI_USELESS">FI: Finalizer does nothing but call superclass finalizer</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#GC_UNCHECKED_TYPE_IN_GENERIC_CALL">GC: Unchecked type in generic call</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#HE_EQUALS_NO_HASHCODE">HE: Class defines equals() but not hashCode()</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#HE_EQUALS_USE_HASHCODE">HE: Class defines equals() and uses Object.hashCode()</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#HE_HASHCODE_NO_EQUALS">HE: Class defines hashCode() but not equals()</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#HE_HASHCODE_USE_OBJECT_EQUALS">HE: Class defines hashCode() and uses Object.equals()</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#HE_INHERITS_EQUALS_USE_HASHCODE">HE: Class inherits equals() and uses Object.hashCode()</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IC_SUPERCLASS_USES_SUBCLASS_DURING_INITIALIZATION">IC: Superclass uses subclass during initialization</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IMSE_DONT_CATCH_IMSE">IMSE: Dubious catching of IllegalMonitorStateException</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#ISC_INSTANTIATE_STATIC_CLASS">ISC: Needless instantiation of class that only supplies static methods</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IT_NO_SUCH_ELEMENT">It: Iterator next() method can't throw NoSuchElementException</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#J2EE_STORE_OF_NON_SERIALIZABLE_OBJECT_INTO_SESSION">J2EE: Store of non serializable object into HttpSession</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#JCIP_FIELD_ISNT_FINAL_IN_IMMUTABLE_CLASS">JCIP: Fields of immutable classes should be final</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_BOOLEAN_RETURN_NULL">NP: Method with Boolean return type returns explicit null</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_CLONE_COULD_RETURN_NULL">NP: Clone method may return null</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT">NP: equals() method does not check for null argument</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_TOSTRING_COULD_RETURN_NULL">NP: toString method may return null</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NM_CLASS_NAMING_CONVENTION">Nm: Class names should start with an upper case letter</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NM_CLASS_NOT_EXCEPTION">Nm: Class is not derived from an Exception, even though it is named as such</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NM_CONFUSING">Nm: Confusing method names</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NM_FIELD_NAMING_CONVENTION">Nm: Field names should start with a lower case letter</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NM_FUTURE_KEYWORD_USED_AS_IDENTIFIER">Nm: Use of identifier that is a keyword in later versions of Java</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NM_FUTURE_KEYWORD_USED_AS_MEMBER_IDENTIFIER">Nm: Use of identifier that is a keyword in later versions of Java</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NM_METHOD_NAMING_CONVENTION">Nm: Method names should start with a lower case letter</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NM_SAME_SIMPLE_NAME_AS_INTERFACE">Nm: Class names shouldn't shadow simple name of implemented interface</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NM_SAME_SIMPLE_NAME_AS_SUPERCLASS">Nm: Class names shouldn't shadow simple name of superclass</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NM_VERY_CONFUSING_INTENTIONAL">Nm: Very confusing method names (but perhaps intentional)</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NM_WRONG_PACKAGE_INTENTIONAL">Nm: Method doesn't override method in superclass due to wrong package for parameter</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#ODR_OPEN_DATABASE_RESOURCE">ODR: Method may fail to close database resource</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#ODR_OPEN_DATABASE_RESOURCE_EXCEPTION_PATH">ODR: Method may fail to close database resource on exception</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#OS_OPEN_STREAM">OS: Method may fail to close stream</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#OS_OPEN_STREAM_EXCEPTION_PATH">OS: Method may fail to close stream on exception</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RC_REF_COMPARISON_BAD_PRACTICE">RC: Suspicious reference comparison to constant</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN">RC: Suspicious reference comparison of Boolean values</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RR_NOT_CHECKED">RR: Method ignores results of InputStream.read()</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SR_NOT_CHECKED">RR: Method ignores results of InputStream.skip()</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE">RV: Method ignores exceptional return value</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SI_INSTANCE_BEFORE_FINALS_ASSIGNED">SI: Static initializer creates instance before all static final fields assigned</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SW_SWING_METHODS_INVOKED_IN_SWING_THREAD">SW: Certain swing methods needs to be invoked in Swing thread</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SE_BAD_FIELD">Se: Non-transient non-serializable instance field in serializable class</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SE_BAD_FIELD_INNER_CLASS">Se: Non-serializable class has a serializable inner class</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SE_BAD_FIELD_STORE">Se: Non-serializable value stored into instance field of a serializable class</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE">Se: Comparator doesn't implement Serializable</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SE_INNER_CLASS">Se: Serializable inner class</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SE_NONFINAL_SERIALVERSIONID">Se: serialVersionUID isn't final</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SE_NONLONG_SERIALVERSIONID">Se: serialVersionUID isn't long</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SE_NONSTATIC_SERIALVERSIONID">Se: serialVersionUID isn't static</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SE_NO_SUITABLE_CONSTRUCTOR">Se: Class is Serializable but its superclass doesn't define a void constructor</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SE_NO_SUITABLE_CONSTRUCTOR_FOR_EXTERNALIZATION">Se: Class is Externalizable but doesn't define a void constructor</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SE_READ_RESOLVE_MUST_RETURN_OBJECT">Se: The readResolve method must be declared with a return type of Object. </a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SE_TRANSIENT_FIELD_NOT_RESTORED">Se: Transient field that isn't set by deserialization. </a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SE_NO_SERIALVERSIONID">SnVI: Class is Serializable, but doesn't define serialVersionUID</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#UI_INHERITANCE_UNSAFE_GETRESOURCE">UI: Usage of GetResource may be unsafe if class is extended</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#BC_IMPOSSIBLE_CAST">BC: Impossible cast</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#BC_IMPOSSIBLE_DOWNCAST">BC: Impossible downcast</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#BC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY">BC: Impossible downcast of toArray() result</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#BC_IMPOSSIBLE_INSTANCEOF">BC: instanceof will always return false</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#BIT_ADD_OF_SIGNED_BYTE">BIT: Bitwise add of signed byte value</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#BIT_AND">BIT: Incompatible bit masks</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#BIT_AND_ZZ">BIT: Check to see if ((...) & 0) == 0</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#BIT_IOR">BIT: Incompatible bit masks</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#BIT_IOR_OF_SIGNED_BYTE">BIT: Bitwise OR of signed byte value</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#BIT_SIGNED_CHECK_HIGH_BIT">BIT: Check for sign of bitwise operation</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#BOA_BADLY_OVERRIDDEN_ADAPTER">BOA: Class overrides a method implemented in super class Adapter wrongly</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#ICAST_BAD_SHIFT_AMOUNT">BSHIFT: 32 bit int shifted by an amount not in the range 0..31</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#BX_UNBOXED_AND_COERCED_FOR_TERNARY_OPERATOR">Bx: Primitive value is unboxed and coerced for ternary operator</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DLS_DEAD_STORE_OF_CLASS_LITERAL">DLS: Dead store of class literal</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DLS_OVERWRITTEN_INCREMENT">DLS: Overwritten increment</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_BAD_MONTH">DMI: Bad constant value for month</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DMI_CALLING_NEXT_FROM_HASNEXT">DMI: hasNext method invokes next</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVES">DMI: Collections should not contain themselves</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DMI_INVOKING_HASHCODE_ON_ARRAY">DMI: Invocation of hashCode on an array</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_LONG_BITS_TO_DOUBLE_INVOKED_ON_INT">DMI: Double.longBitsToDouble invoked on an int</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DMI_VACUOUS_SELF_COLLECTION_CALL">DMI: Vacuous call to collections</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_ANNOTATION_IS_NOT_VISIBLE_TO_REFLECTION">Dm: Can't use reflection to check for presence of annotation without runtime retention</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DMI_FUTILE_ATTEMPT_TO_CHANGE_MAXPOOL_SIZE_OF_SCHEDULED_THREAD_POOL_EXECUTOR">Dm: Futile attempt to change max pool size of ScheduledThreadPoolExecutor</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_SCHEDULED_THREAD_POOL_EXECUTOR_WITH_ZERO_CORE_THREADS">Dm: Creation of ScheduledThreadPoolExecutor with zero core threads</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DMI_VACUOUS_CALL_TO_EASYMOCK_METHOD">Dm: Useless/vacuous call to EasyMock method</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#EC_ARRAY_AND_NONARRAY">EC: equals() used to compare array and nonarray</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EC_BAD_ARRAY_COMPARE">EC: Invocation of equals() on an array, which is equivalent to ==</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#EC_INCOMPATIBLE_ARRAY_COMPARE">EC: equals(...) used to compare incompatible arrays</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EC_NULL_ARG">EC: Call to equals() with null argument</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#EC_UNRELATED_CLASS_AND_INTERFACE">EC: Call to equals() comparing unrelated class and interface</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EC_UNRELATED_INTERFACES">EC: Call to equals() comparing different interface types</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#EC_UNRELATED_TYPES">EC: Call to equals() comparing different types</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EC_UNRELATED_TYPES_USING_POINTER_EQUALITY">EC: Using pointer equality to compare different types</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#EQ_ALWAYS_FALSE">Eq: equals method always returns false</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EQ_ALWAYS_TRUE">Eq: equals method always returns true</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#EQ_COMPARING_CLASS_NAMES">Eq: equals method compares class names rather than class objects</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EQ_DONT_DEFINE_EQUALS_FOR_ENUM">Eq: Covariant equals() method defined for enum</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#EQ_OTHER_NO_OBJECT">Eq: equals() method defined that doesn't override equals(Object)</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EQ_OTHER_USE_OBJECT">Eq: equals() method defined that doesn't override Object.equals(Object)</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC">Eq: equals method overrides equals in superclass and may not be symmetric</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EQ_SELF_USE_OBJECT">Eq: Covariant equals() method defined, Object.equals(Object) inherited</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#FE_TEST_IF_EQUAL_TO_NOT_A_NUMBER">FE: Doomed test for equality to NaN</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#VA_FORMAT_STRING_BAD_ARGUMENT">FS: Format string placeholder incompatible with passed argument</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#VA_FORMAT_STRING_BAD_CONVERSION">FS: The type of a supplied argument doesn't match format specifier</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#VA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIED">FS: MessageFormat supplied where printf style format expected</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#VA_FORMAT_STRING_EXTRA_ARGUMENTS_PASSED">FS: More arguments are passed than are actually used in the format string</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#VA_FORMAT_STRING_ILLEGAL">FS: Illegal format string</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#VA_FORMAT_STRING_MISSING_ARGUMENT">FS: Format string references missing argument</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#VA_FORMAT_STRING_NO_PREVIOUS_ARGUMENT">FS: No previous argument for format string</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#GC_UNRELATED_TYPES">GC: No relationship between generic parameter and method argument</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS">HE: Signature declares use of unhashable class in hashed construct</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#HE_USE_OF_UNHASHABLE_CLASS">HE: Use of class without a hashCode() method in a hashed data structure</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL">ICAST: integral value cast to double and then passed to Math.ceil</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#ICAST_INT_CAST_TO_FLOAT_PASSED_TO_ROUND">ICAST: int value cast to float and then passed to Math.round</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IJU_ASSERT_METHOD_INVOKED_FROM_RUN_METHOD">IJU: JUnit assertion in run method will not be noticed by JUnit</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IJU_BAD_SUITE_METHOD">IJU: TestCase declares a bad suite method </a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IJU_NO_TESTS">IJU: TestCase has no tests</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IJU_SETUP_NO_SUPER">IJU: TestCase defines setUp that doesn't call super.setUp()</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IJU_SUITE_NOT_STATIC">IJU: TestCase implements a non-static suite method </a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IJU_TEARDOWN_NO_SUPER">IJU: TestCase defines tearDown that doesn't call super.tearDown()</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IL_CONTAINER_ADDED_TO_ITSELF">IL: A collection is added to itself</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IL_INFINITE_LOOP">IL: An apparent infinite loop</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IL_INFINITE_RECURSIVE_LOOP">IL: An apparent infinite recursive loop</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IM_MULTIPLYING_RESULT_OF_IREM">IM: Integer multiply of result of integer remainder</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE">INT: Bad comparison of nonnegative value with negative constant</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#INT_BAD_COMPARISON_WITH_SIGNED_BYTE">INT: Bad comparison of signed byte</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IO_APPENDING_TO_OBJECT_OUTPUT_STREAM">IO: Doomed attempt to append to an object output stream</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN">IP: A parameter is dead upon entry to a method but overwritten</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#MF_CLASS_MASKS_FIELD">MF: Class defines field that masks a superclass field</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#MF_METHOD_MASKS_FIELD">MF: Method defines a variable that obscures a field</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_ALWAYS_NULL">NP: Null pointer dereference</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_ALWAYS_NULL_EXCEPTION">NP: Null pointer dereference in method on exception path</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_ARGUMENT_MIGHT_BE_NULL">NP: Method does not check for null argument</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_CLOSING_NULL">NP: close() invoked on a value that is always null</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_GUARANTEED_DEREF">NP: Null value is guaranteed to be dereferenced</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH">NP: Value is null and guaranteed to be dereferenced on exception path</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_NONNULL_PARAM_VIOLATION">NP: Method call passes null to a nonnull parameter </a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_NONNULL_RETURN_VIOLATION">NP: Method may return null, but is declared @NonNull</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_NULL_INSTANCEOF">NP: A known null value is checked to see if it is an instance of a type</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_NULL_ON_SOME_PATH">NP: Possible null pointer dereference</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_NULL_ON_SOME_PATH_EXCEPTION">NP: Possible null pointer dereference in method on exception path</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_NULL_PARAM_DEREF">NP: Method call passes null for nonnull parameter</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS">NP: Method call passes null for nonnull parameter</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_NULL_PARAM_DEREF_NONVIRTUAL">NP: Non-virtual method call passes null for nonnull parameter</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_STORE_INTO_NONNULL_FIELD">NP: Store of null value into field annotated NonNull</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_UNWRITTEN_FIELD">NP: Read of unwritten field</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NM_BAD_EQUAL">Nm: Class defines equal(Object); should it be equals(Object)?</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NM_LCASE_HASHCODE">Nm: Class defines hashcode(); should it be hashCode()?</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NM_LCASE_TOSTRING">Nm: Class defines tostring(); should it be toString()?</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NM_METHOD_CONSTRUCTOR_CONFUSION">Nm: Apparent method/constructor confusion</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NM_VERY_CONFUSING">Nm: Very confusing method names</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NM_WRONG_PACKAGE">Nm: Method doesn't override method in superclass due to wrong package for parameter</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#QBA_QUESTIONABLE_BOOLEAN_ASSIGNMENT">QBA: Method assigns boolean literal in boolean expression</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RC_REF_COMPARISON">RC: Suspicious reference comparison</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">RCN: Nullcheck of value previously dereferenced</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RE_BAD_SYNTAX_FOR_REGULAR_EXPRESSION">RE: Invalid syntax for regular expression</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RE_CANT_USE_FILE_SEPARATOR_AS_REGULAR_EXPRESSION">RE: File.separator used for regular expression</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RE_POSSIBLE_UNINTENDED_PATTERN">RE: "." used for regular expression</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RV_01_TO_INT">RV: Random value from 0 to 1 is coerced to the integer 0</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RV_ABSOLUTE_VALUE_OF_HASHCODE">RV: Bad attempt to compute absolute value of signed 32-bit hashcode </a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RV_ABSOLUTE_VALUE_OF_RANDOM_INT">RV: Bad attempt to compute absolute value of signed 32-bit random integer</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RV_EXCEPTION_NOT_THROWN">RV: Exception created and dropped rather than thrown</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RV_RETURN_VALUE_IGNORED">RV: Method ignores return value</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RpC_REPEATED_CONDITIONAL_TEST">RpC: Repeated conditional tests</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SA_FIELD_DOUBLE_ASSIGNMENT">SA: Double assignment of field</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SA_FIELD_SELF_ASSIGNMENT">SA: Self assignment of field</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SA_FIELD_SELF_COMPARISON">SA: Self comparison of field with itself</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SA_FIELD_SELF_COMPUTATION">SA: Nonsensical self computation involving a field (e.g., x & x)</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SA_LOCAL_SELF_COMPARISON">SA: Self comparison of value with itself</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SA_LOCAL_SELF_COMPUTATION">SA: Nonsensical self computation involving a variable (e.g., x & x)</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH">SF: Dead store due to switch statement fall through</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH_TO_THROW">SF: Dead store due to switch statement fall through to throw</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SIC_THREADLOCAL_DEADLY_EMBRACE">SIC: Deadly embrace of non-static inner class and thread local</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SIO_SUPERFLUOUS_INSTANCEOF">SIO: Unnecessary type check done using instanceof operator</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SQL_BAD_PREPARED_STATEMENT_ACCESS">SQL: Method attempts to access a prepared statement parameter with index 0</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SQL_BAD_RESULTSET_ACCESS">SQL: Method attempts to access a result set field with index 0</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#STI_INTERRUPTED_ON_CURRENTTHREAD">STI: Unneeded use of currentThread() call, to call interrupted() </a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#STI_INTERRUPTED_ON_UNKNOWNTHREAD">STI: Static Thread.interrupted() method invoked on thread instance</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SE_METHOD_MUST_BE_PRIVATE">Se: Method must be private in order for serialization to work</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SE_READ_RESOLVE_IS_STATIC">Se: The readResolve method must not be declared as a static method. </a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#TQ_ALWAYS_VALUE_USED_WHERE_NEVER_REQUIRED">TQ: Value annotated as carrying a type qualifier used where a value that must not carry that qualifier is required</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#TQ_MAYBE_SOURCE_VALUE_REACHES_ALWAYS_SINK">TQ: Value that might not carry a type qualifier is always used in a way requires that type qualifier</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#TQ_MAYBE_SOURCE_VALUE_REACHES_NEVER_SINK">TQ: Value that might carry a type qualifier is always used in a way prohibits it from having that type qualifier</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#TQ_NEVER_VALUE_USED_WHERE_ALWAYS_REQUIRED">TQ: Value annotated as never carrying a type qualifier used where value carrying that qualifier is required</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS">UMAC: Uncallable method defined in anonymous class</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#UR_UNINIT_READ">UR: Uninitialized read of field in constructor</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR">UR: Uninitialized read of field method called from constructor of superclass</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY">USELESS_STRING: Invocation of toString on an array</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DMI_INVOKING_TOSTRING_ON_ARRAY">USELESS_STRING: Invocation of toString on an array</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#VA_FORMAT_STRING_BAD_CONVERSION_FROM_ARRAY">USELESS_STRING: Array formatted in useless way using format string</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#UWF_NULL_FIELD">UwF: Field only ever set to null</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#UWF_UNWRITTEN_FIELD">UwF: Unwritten field</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#VA_PRIMITIVE_ARRAY_PASSED_TO_OBJECT_VARARG">VA: Primitive array passed to function expecting a variable number of object arguments</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE">LG: Potential lost logger changes due to weak reference in OpenJDK</a></td><td>Experimental</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#OBL_UNSATISFIED_OBLIGATION">OBL: Method may fail to clean up stream or resource</a></td><td>Experimental</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DM_CONVERT_CASE">Dm: Consider using Locale parameterized version of invoked method</a></td><td>Internationalization</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EI_EXPOSE_REP">EI: May expose internal representation by returning reference to mutable object</a></td><td>Malicious code vulnerability</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#EI_EXPOSE_REP2">EI2: May expose internal representation by incorporating reference to mutable object</a></td><td>Malicious code vulnerability</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#FI_PUBLIC_SHOULD_BE_PROTECTED">FI: Finalizer should be protected, not public</a></td><td>Malicious code vulnerability</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#EI_EXPOSE_STATIC_REP2">MS: May expose internal static state by storing a mutable object into a static field</a></td><td>Malicious code vulnerability</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#MS_CANNOT_BE_FINAL">MS: Field isn't final and can't be protected from malicious code</a></td><td>Malicious code vulnerability</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#MS_EXPOSE_REP">MS: Public static method may expose internal representation by returning array</a></td><td>Malicious code vulnerability</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#MS_FINAL_PKGPROTECT">MS: Field should be both final and package protected</a></td><td>Malicious code vulnerability</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#MS_MUTABLE_ARRAY">MS: Field is a mutable array</a></td><td>Malicious code vulnerability</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#MS_MUTABLE_HASHTABLE">MS: Field is a mutable Hashtable</a></td><td>Malicious code vulnerability</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#MS_OOI_PKGPROTECT">MS: Field should be moved out of an interface and made package protected</a></td><td>Malicious code vulnerability</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#MS_PKGPROTECT">MS: Field should be package protected</a></td><td>Malicious code vulnerability</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#MS_SHOULD_BE_FINAL">MS: Field isn't final but should be</a></td><td>Malicious code vulnerability</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DC_DOUBLECHECK">DC: Possible double check of field</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DL_SYNCHRONIZATION_ON_BOOLEAN">DL: Synchronization on Boolean could lead to deadlock</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE">DL: Synchronization on boxed primitive could lead to deadlock</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DL_SYNCHRONIZATION_ON_SHARED_CONSTANT">DL: Synchronization on interned String could lead to deadlock</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DL_SYNCHRONIZATION_ON_UNSHARED_BOXED_PRIMITIVE">DL: Synchronization on boxed primitive values</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DM_MONITOR_WAIT_ON_CONDITION">Dm: Monitor wait() called on Condition</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DM_USELESS_THREAD">Dm: A thread was created using the default empty run method</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#ESync_EMPTY_SYNC">ESync: Empty synchronized block</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IS2_INCONSISTENT_SYNC">IS: Inconsistent synchronization</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IS_FIELD_NOT_GUARDED">IS: Field not guarded against concurrent access</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#JLM_JSR166_LOCK_MONITORENTER">JLM: Synchronization performed on Lock</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#LI_LAZY_INIT_STATIC">LI: Incorrect lazy initialization of static field</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#LI_LAZY_INIT_UPDATE_STATIC">LI: Incorrect lazy initialization and update of static field</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD">ML: Synchronization on field in futile attempt to guard that field</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#ML_SYNC_ON_UPDATED_FIELD">ML: Method synchronizes on an updated field</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#MSF_MUTABLE_SERVLET_FIELD">MSF: Mutable servlet field</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#MWN_MISMATCHED_NOTIFY">MWN: Mismatched notify()</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#MWN_MISMATCHED_WAIT">MWN: Mismatched wait()</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NN_NAKED_NOTIFY">NN: Naked notify</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_SYNC_AND_NULL_CHECK_FIELD">NP: Synchronize and null check on the same field.</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NO_NOTIFY_NOT_NOTIFYALL">No: Using notify() rather than notifyAll()</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RS_READOBJECT_SYNC">RS: Class's readObject() method is synchronized</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED">RV: Return value of putIfAbsent ignored, value passed to putIfAbsent reused</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RU_INVOKE_RUN">Ru: Invokes run on a thread (did you mean to start it instead?)</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SC_START_IN_CTOR">SC: Constructor invokes Thread.start()</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SP_SPIN_ON_FIELD">SP: Method spins on field</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#STCAL_INVOKE_ON_STATIC_CALENDAR_INSTANCE">STCAL: Call to static Calendar</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE">STCAL: Call to static DateFormat</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#STCAL_STATIC_CALENDAR_INSTANCE">STCAL: Static Calendar</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE">STCAL: Static DateFormat</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SWL_SLEEP_WITH_LOCK_HELD">SWL: Method calls Thread.sleep() with a lock held</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#TLW_TWO_LOCK_WAIT">TLW: Wait with two locks held</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#UG_SYNC_SET_UNSYNC_GET">UG: Unsynchronized get method, synchronized set method</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#UL_UNRELEASED_LOCK">UL: Method does not release lock on all paths</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#UL_UNRELEASED_LOCK_EXCEPTION_PATH">UL: Method does not release lock on all exception paths</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#UW_UNCOND_WAIT">UW: Unconditional wait</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#VO_VOLATILE_REFERENCE_TO_ARRAY">VO: A volatile reference to an array doesn't treat the array elements as volatile</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL">WL: Sychronization on getClass rather than class literal</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#WS_WRITEOBJECT_SYNC">WS: Class's writeObject() method is synchronized but nothing else is</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#WA_AWAIT_NOT_IN_LOOP">Wa: Condition.await() not in loop </a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#WA_NOT_IN_LOOP">Wa: Wait not in loop </a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#BX_BOXING_IMMEDIATELY_UNBOXED">Bx: Primitive value is boxed and then immediately unboxed</a></td><td>Performance</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION">Bx: Primitive value is boxed then unboxed to perform primitive coercion</a></td><td>Performance</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DM_BOXED_PRIMITIVE_TOSTRING">Bx: Method allocates a boxed primitive just to call toString</a></td><td>Performance</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DM_FP_NUMBER_CTOR">Bx: Method invokes inefficient floating-point Number constructor; use static valueOf instead</a></td><td>Performance</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DM_NUMBER_CTOR">Bx: Method invokes inefficient Number constructor; use static valueOf instead</a></td><td>Performance</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DMI_BLOCKING_METHODS_ON_URL">Dm: The equals and hashCode methods of URL are blocking</a></td><td>Performance</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_COLLECTION_OF_URLS">Dm: Maps and sets of URLs can be performance hogs</a></td><td>Performance</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DM_BOOLEAN_CTOR">Dm: Method invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead</a></td><td>Performance</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DM_GC">Dm: Explicit garbage collection; extremely dubious except in benchmarking code</a></td><td>Performance</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DM_NEW_FOR_GETCLASS">Dm: Method allocates an object, only to get the class object</a></td><td>Performance</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DM_NEXTINT_VIA_NEXTDOUBLE">Dm: Use the nextInt method of Random rather than nextDouble to generate a random integer</a></td><td>Performance</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DM_STRING_CTOR">Dm: Method invokes inefficient new String(String) constructor</a></td><td>Performance</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DM_STRING_TOSTRING">Dm: Method invokes toString() method on a String</a></td><td>Performance</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DM_STRING_VOID_CTOR">Dm: Method invokes inefficient new String() constructor</a></td><td>Performance</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#HSC_HUGE_SHARED_STRING_CONSTANT">HSC: Huge string constants is duplicated across multiple class files</a></td><td>Performance</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#ITA_INEFFICIENT_TO_ARRAY">ITA: Method uses toArray() with zero-length array argument</a></td><td>Performance</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SBSC_USE_STRINGBUFFER_CONCATENATION">SBSC: Method concatenates strings using + in a loop</a></td><td>Performance</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SIC_INNER_SHOULD_BE_STATIC">SIC: Should be a static inner class</a></td><td>Performance</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SIC_INNER_SHOULD_BE_STATIC_ANON">SIC: Could be refactored into a named static inner class</a></td><td>Performance</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS">SIC: Could be refactored into a static inner class</a></td><td>Performance</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SS_SHOULD_BE_STATIC">SS: Unread field: should this field be static?</a></td><td>Performance</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#UM_UNNECESSARY_MATH">UM: Method calls static Math class method on a constant value</a></td><td>Performance</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#UPM_UNCALLED_PRIVATE_METHOD">UPM: Private method is never called</a></td><td>Performance</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#URF_UNREAD_FIELD">UrF: Unread field</a></td><td>Performance</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#UUF_UNUSED_FIELD">UuF: Unused field</a></td><td>Performance</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#WMI_WRONG_MAP_ITERATOR">WMI: Inefficient use of keySet iterator instead of entrySet iterator</a></td><td>Performance</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_CONSTANT_DB_PASSWORD">Dm: Hardcoded constant database password</a></td><td>Security</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DMI_EMPTY_DB_PASSWORD">Dm: Empty database password</a></td><td>Security</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#HRS_REQUEST_PARAMETER_TO_COOKIE">HRS: HTTP cookie formed from untrusted input</a></td><td>Security</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#HRS_REQUEST_PARAMETER_TO_HTTP_HEADER">HRS: HTTP Response splitting vulnerability</a></td><td>Security</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE">SQL: Nonconstant string passed to execute method on an SQL statement</a></td><td>Security</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING">SQL: A prepared statement is generated from a nonconstant String</a></td><td>Security</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#XSS_REQUEST_PARAMETER_TO_JSP_WRITER">XSS: JSP reflected cross site scripting vulnerability</a></td><td>Security</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#XSS_REQUEST_PARAMETER_TO_SEND_ERROR">XSS: Servlet reflected cross site scripting vulnerability</a></td><td>Security</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER">XSS: Servlet reflected cross site scripting vulnerability</a></td><td>Security</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#BC_BAD_CAST_TO_ABSTRACT_COLLECTION">BC: Questionable cast to abstract collection </a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#BC_BAD_CAST_TO_CONCRETE_COLLECTION">BC: Questionable cast to concrete collection</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#BC_UNCONFIRMED_CAST">BC: Unchecked/unconfirmed cast</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#BC_VACUOUS_INSTANCEOF">BC: instanceof will always return true</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#ICAST_QUESTIONABLE_UNSIGNED_RIGHT_SHIFT">BSHIFT: Unsigned right shift cast to short/byte</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#CI_CONFUSED_INHERITANCE">CI: Class is final but declares protected field</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DB_DUPLICATE_BRANCHES">DB: Method uses the same code for two branches</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DB_DUPLICATE_SWITCH_CLAUSES">DB: Method uses the same code for two switch clauses</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DLS_DEAD_LOCAL_STORE">DLS: Dead store to local variable</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DLS_DEAD_LOCAL_STORE_IN_RETURN">DLS: Useless assignment in return statement</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DLS_DEAD_LOCAL_STORE_OF_NULL">DLS: Dead store of null to local variable</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_HARDCODED_ABSOLUTE_FILENAME">DMI: Code contains a hard coded reference to an absolute pathname</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DMI_NONSERIALIZABLE_OBJECT_WRITTEN">DMI: Non serializable object written to ObjectOutput</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_USELESS_SUBSTRING">DMI: Invocation of substring(0), which returns the original value</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DMI_THREAD_PASSED_WHERE_RUNNABLE_EXPECTED">Dm: Thread passed where Runnable expected</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#EQ_DOESNT_OVERRIDE_EQUALS">Eq: Class doesn't override equals in superclass</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EQ_UNUSUAL">Eq: Unusual equals method </a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#FE_FLOATING_POINT_EQUALITY">FE: Test for floating point equality</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#VA_FORMAT_STRING_BAD_CONVERSION_TO_BOOLEAN">FS: Non-Boolean argument formatted using %b format specifier</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD">IA: Ambiguous invocation of either an inherited or outer method</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IC_INIT_CIRCULARITY">IC: Initialization circularity</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#ICAST_IDIV_CAST_TO_DOUBLE">ICAST: integral division result cast to double or float</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#ICAST_INTEGER_MULTIPLY_CAST_TO_LONG">ICAST: Result of integer multiplication cast to long</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IM_AVERAGE_COMPUTATION_COULD_OVERFLOW">IM: Computation of average could overflow</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IM_BAD_CHECK_FOR_ODD">IM: Check for oddness that won't work for negative numbers </a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#INT_BAD_REM_BY_1">INT: Integer remainder modulo 1</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#INT_VACUOUS_COMPARISON">INT: Vacuous comparison of integer value</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#MTIA_SUSPECT_SERVLET_INSTANCE_FIELD">MTIA: Class extends Servlet class and uses instance variables</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#MTIA_SUSPECT_STRUTS_INSTANCE_FIELD">MTIA: Class extends Struts Action class and uses instance variables</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_DEREFERENCE_OF_READLINE_VALUE">NP: Dereference of the result of readLine() without nullcheck</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_IMMEDIATE_DEREFERENCE_OF_READLINE">NP: Immediate dereference of the result of readLine()</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_LOAD_OF_KNOWN_NULL_VALUE">NP: Load of known null value</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE">NP: Possible null pointer dereference due to return value of called method</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE">NP: Possible null pointer dereference on path that might be infeasible</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE">NP: Parameter must be nonnull but is marked as nullable</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NS_DANGEROUS_NON_SHORT_CIRCUIT">NS: Potentially dangerous use of non-short-circuit logic</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NS_NON_SHORT_CIRCUIT">NS: Questionable use of non-short-circuit logic</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#PZLA_PREFER_ZERO_LENGTH_ARRAYS">PZLA: Consider returning a zero length array rather than null</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#QF_QUESTIONABLE_FOR_LOOP">QF: Complicated, subtle or wrong increment in for-loop </a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE">RCN: Redundant comparison of non-null value to null</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RCN_REDUNDANT_COMPARISON_TWO_NULL_VALUES">RCN: Redundant comparison of two null values</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE">RCN: Redundant nullcheck of value known to be non-null</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE">RCN: Redundant nullcheck of value known to be null</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#REC_CATCH_EXCEPTION">REC: Exception is caught when Exception is not thrown</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RI_REDUNDANT_INTERFACES">RI: Class implements same interface as superclass</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RV_CHECK_FOR_POSITIVE_INDEXOF">RV: Method checks to see if result of String.indexOf is positive</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RV_DONT_JUST_NULL_CHECK_READLINE">RV: Method discards result of readLine after checking if it is nonnull</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RV_REM_OF_HASHCODE">RV: Remainder of hashCode could be negative</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RV_REM_OF_RANDOM_INT">RV: Remainder of 32-bit signed random integer</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SA_LOCAL_DOUBLE_ASSIGNMENT">SA: Double assignment of local variable </a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SA_LOCAL_SELF_ASSIGNMENT">SA: Self assignment of local variable</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SF_SWITCH_FALLTHROUGH">SF: Switch statement found where one case falls through to the next case</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SF_SWITCH_NO_DEFAULT">SF: Switch statement found where default case is missing</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD">ST: Write to static field from instance method</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SE_PRIVATE_READ_RESOLVE_NOT_INHERITED">Se: private readResolve method not inherited by subclasses</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS">Se: Transient field of class that isn't Serializable. </a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK">TQ: Explicit annotation inconsistent with use</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK">TQ: Explicit annotation inconsistent with use</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#UCF_USELESS_CONTROL_FLOW">UCF: Useless control flow</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#UCF_USELESS_CONTROL_FLOW_NEXT_LINE">UCF: Useless control flow to next line</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR">UwF: Field not initialized in constructor</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#XFB_XML_FACTORY_BYPASS">XFB: Method directly allocates a specific implementation of xml interfaces</a></td><td>Dodgy</td></tr>
-</table>
-<h2>Descriptions</h2>
-<h3><a name="AM_CREATES_EMPTY_JAR_FILE_ENTRY">AM: Creates an empty jar file entry (AM_CREATES_EMPTY_JAR_FILE_ENTRY)</a></h3>
-
-
-<p>The code calls <code>putNextEntry()</code>, immediately
-followed by a call to <code>closeEntry()</code>. This results
-in an empty JarFile entry. The contents of the entry
-should be written to the JarFile between the calls to
-<code>putNextEntry()</code> and
-<code>closeEntry()</code>.</p>
-
-
-<h3><a name="AM_CREATES_EMPTY_ZIP_FILE_ENTRY">AM: Creates an empty zip file entry (AM_CREATES_EMPTY_ZIP_FILE_ENTRY)</a></h3>
-
-
-<p>The code calls <code>putNextEntry()</code>, immediately
-followed by a call to <code>closeEntry()</code>. This results
-in an empty ZipFile entry. The contents of the entry
-should be written to the ZipFile between the calls to
-<code>putNextEntry()</code> and
-<code>closeEntry()</code>.</p>
-
-
-<h3><a name="BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS">BC: Equals method should not assume anything about the type of its argument (BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS)</a></h3>
-
-
-<p>
-The <code>equals(Object o)</code> method shouldn't make any assumptions
-about the type of <code>o</code>. It should simply return
-false if <code>o</code> is not the same type as <code>this</code>.
-</p>
-
-
-<h3><a name="DMI_RANDOM_USED_ONLY_ONCE">BC: Random object created and used only once (DMI_RANDOM_USED_ONLY_ONCE)</a></h3>
-
-
-<p> This code creates a java.util.Random object, uses it to generate one random number, and then discards
-the Random object. This produces mediocre quality random numbers and is inefficient.
-If possible, rewrite the code so that the Random object is created once and saved, and each time a new random number
-is required invoke a method on the existing Random object to obtain it.
-</p>
-
-<p>If it is important that the generated Random numbers not be guessable, you <em>must</em> not create a new Random for each random
-number; the values are too easily guessable. You should strongly consider using a java.security.SecureRandom instead
-(and avoid allocating a new SecureRandom for each random number needed).
-</p>
-
-
-<h3><a name="BIT_SIGNED_CHECK">BIT: Check for sign of bitwise operation (BIT_SIGNED_CHECK)</a></h3>
-
-
-<p> This method compares an expression such as
-<pre>((event.detail & SWT.SELECTED) > 0)</pre>.
-Using bit arithmetic and then comparing with the greater than operator can
-lead to unexpected results (of course depending on the value of
-SWT.SELECTED). If SWT.SELECTED is a negative number, this is a candidate
-for a bug. Even when SWT.SELECTED is not negative, it seems good practice
-to use '!= 0' instead of '> 0'.
-</p>
-<p>
-<em>Boris Bokowski</em>
-</p>
-
-
-<h3><a name="CN_IDIOM">CN: Class implements Cloneable but does not define or use clone method (CN_IDIOM)</a></h3>
-
-
-<p>
- Class implements Cloneable but does not define or
- use the clone method.</p>
-
-
-<h3><a name="CN_IDIOM_NO_SUPER_CALL">CN: clone method does not call super.clone() (CN_IDIOM_NO_SUPER_CALL)</a></h3>
-
-
-<p> This non-final class defines a clone() method that does not call super.clone().
-If this class ("<i>A</i>") is extended by a subclass ("<i>B</i>"),
-and the subclass <i>B</i> calls super.clone(), then it is likely that
-<i>B</i>'s clone() method will return an object of type <i>A</i>,
-which violates the standard contract for clone().</p>
-
-<p> If all clone() methods call super.clone(), then they are guaranteed
-to use Object.clone(), which always returns an object of the correct type.</p>
-
-
-<h3><a name="CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE">CN: Class defines clone() but doesn't implement Cloneable (CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE)</a></h3>
-
-
-<p> This class defines a clone() method but the class doesn't implement Cloneable.
-There are some situations in which this is OK (e.g., you want to control how subclasses
-can clone themselves), but just make sure that this is what you intended.
-</p>
-
-
-<h3><a name="CO_ABSTRACT_SELF">Co: Abstract class defines covariant compareTo() method (CO_ABSTRACT_SELF)</a></h3>
-
-
- <p> This class defines a covariant version of <code>compareTo()</code>.
- To correctly override the <code>compareTo()</code> method in the
- <code>Comparable</code> interface, the parameter of <code>compareTo()</code>
- must have type <code>java.lang.Object</code>.</p>
-
-
-<h3><a name="CO_SELF_NO_OBJECT">Co: Covariant compareTo() method defined (CO_SELF_NO_OBJECT)</a></h3>
-
-
- <p> This class defines a covariant version of <code>compareTo()</code>.
- To correctly override the <code>compareTo()</code> method in the
- <code>Comparable</code> interface, the parameter of <code>compareTo()</code>
- must have type <code>java.lang.Object</code>.</p>
-
-
-<h3><a name="DE_MIGHT_DROP">DE: Method might drop exception (DE_MIGHT_DROP)</a></h3>
-
-
- <p> This method might drop an exception. In general, exceptions
- should be handled or reported in some way, or they should be thrown
- out of the method.</p>
-
-
-<h3><a name="DE_MIGHT_IGNORE">DE: Method might ignore exception (DE_MIGHT_IGNORE)</a></h3>
-
-
- <p> This method might ignore an exception. In general, exceptions
- should be handled or reported in some way, or they should be thrown
- out of the method.</p>
-
-
-<h3><a name="DMI_USING_REMOVEALL_TO_CLEAR_COLLECTION">DMI: Don't use removeAll to clear a collection (DMI_USING_REMOVEALL_TO_CLEAR_COLLECTION)</a></h3>
-
-
- <p> If you want to remove all elements from a collection <code>c</code>, use <code>c.clear</code>,
-not <code>c.removeAll(c)</code>. Calling <code>c.removeAll(c)</code> to clear a collection
-is less clear, susceptible to errors from typos, less efficient and
-for some collections, might throw a <code>ConcurrentModificationException</code>.
- </p>
-
-
-<h3><a name="DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED">DP: Classloaders should only be created inside doPrivileged block (DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED)</a></h3>
-
-
- <p> This code creates a classloader, which requires a security manager.
- If this code will be granted security permissions, but might be invoked by code that does not
- have security permissions, then the classloader creation needs to occur inside a doPrivileged block.</p>
-
-
-<h3><a name="DP_DO_INSIDE_DO_PRIVILEGED">DP: Method invoked that should be only be invoked inside a doPrivileged block (DP_DO_INSIDE_DO_PRIVILEGED)</a></h3>
-
-
- <p> This code invokes a method that requires a security permission check.
- If this code will be granted security permissions, but might be invoked by code that does not
- have security permissions, then the invocation needs to occur inside a doPrivileged block.</p>
-
-
-<h3><a name="DM_EXIT">Dm: Method invokes System.exit(...) (DM_EXIT)</a></h3>
-
-
- <p> Invoking System.exit shuts down the entire Java virtual machine. This
- should only been done when it is appropriate. Such calls make it
- hard or impossible for your code to be invoked by other code.
- Consider throwing a RuntimeException instead.</p>
-
-
-<h3><a name="DM_RUN_FINALIZERS_ON_EXIT">Dm: Method invokes dangerous method runFinalizersOnExit (DM_RUN_FINALIZERS_ON_EXIT)</a></h3>
-
-
- <p> <em>Never call System.runFinalizersOnExit
-or Runtime.runFinalizersOnExit for any reason: they are among the most
-dangerous methods in the Java libraries.</em> -- Joshua Bloch</p>
-
-
-<h3><a name="ES_COMPARING_PARAMETER_STRING_WITH_EQ">ES: Comparison of String parameter using == or != (ES_COMPARING_PARAMETER_STRING_WITH_EQ)</a></h3>
-
-
- <p>This code compares a <code>java.lang.String</code> parameter for reference
-equality using the == or != operators. Requiring callers to
-pass only String constants or interned strings to a method is unnecessarily
-fragile, and rarely leads to measurable performance gains. Consider
-using the <code>equals(Object)</code> method instead.</p>
-
-
-<h3><a name="ES_COMPARING_STRINGS_WITH_EQ">ES: Comparison of String objects using == or != (ES_COMPARING_STRINGS_WITH_EQ)</a></h3>
-
-
- <p>This code compares <code>java.lang.String</code> objects for reference
-equality using the == or != operators.
-Unless both strings are either constants in a source file, or have been
-interned using the <code>String.intern()</code> method, the same string
-value may be represented by two different String objects. Consider
-using the <code>equals(Object)</code> method instead.</p>
-
-
-<h3><a name="EQ_ABSTRACT_SELF">Eq: Abstract class defines covariant equals() method (EQ_ABSTRACT_SELF)</a></h3>
-
-
- <p> This class defines a covariant version of <code>equals()</code>.
- To correctly override the <code>equals()</code> method in
- <code>java.lang.Object</code>, the parameter of <code>equals()</code>
- must have type <code>java.lang.Object</code>.</p>
-
-
-<h3><a name="EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS">Eq: Equals checks for noncompatible operand (EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS)</a></h3>
-
-
- <p> This equals method is checking to see if the argument is some incompatible type
-(i.e., a class that is neither a supertype nor subtype of the class that defines
-the equals method). For example, the Foo class might have an equals method
-that looks like:
-
-<p><code><pre>
-public boolean equals(Object o) {
- if (o instanceof Foo)
- return name.equals(((Foo)o).name);
- else if (o instanceof String)
- return name.equals(o);
- else return false;
-</pre></code></p>
-
-<p>This is considered bad practice, as it makes it very hard to implement an equals method that
-is symmetric and transitive. Without those properties, very unexpected behavoirs are possible.
-</p>
-
-
-<h3><a name="EQ_COMPARETO_USE_OBJECT_EQUALS">Eq: Class defines compareTo(...) and uses Object.equals() (EQ_COMPARETO_USE_OBJECT_EQUALS)</a></h3>
-
-
- <p> This class defines a <code>compareTo(...)</code> method but inherits its
- <code>equals()</code> method from <code>java.lang.Object</code>.
- Generally, the value of compareTo should return zero if and only if
- equals returns true. If this is violated, weird and unpredictable
- failures will occur in classes such as PriorityQueue.
- In Java 5 the PriorityQueue.remove method uses the compareTo method,
- while in Java 6 it uses the equals method.
-
-<p>From the JavaDoc for the compareTo method in the Comparable interface:
-<blockquote>
-It is strongly recommended, but not strictly required that <code>(x.compareTo(y)==0) == (x.equals(y))</code>.
-Generally speaking, any class that implements the Comparable interface and violates this condition
-should clearly indicate this fact. The recommended language
-is "Note: this class has a natural ordering that is inconsistent with equals."
-</blockquote>
-
-
-<h3><a name="EQ_GETCLASS_AND_CLASS_CONSTANT">Eq: equals method fails for subtypes (EQ_GETCLASS_AND_CLASS_CONSTANT)</a></h3>
-
-
- <p> This class has an equals method that will be broken if it is inherited by subclasses.
-It compares a class literal with the class of the argument (e.g., in class <code>Foo</code>
-it might check if <code>Foo.class == o.getClass()</code>).
-It is better to check if <code>this.getClass() == o.getClass()</code>.
-</p>
-
-
-<h3><a name="EQ_SELF_NO_OBJECT">Eq: Covariant equals() method defined (EQ_SELF_NO_OBJECT)</a></h3>
-
-
- <p> This class defines a covariant version of <code>equals()</code>.
- To correctly override the <code>equals()</code> method in
- <code>java.lang.Object</code>, the parameter of <code>equals()</code>
- must have type <code>java.lang.Object</code>.</p>
-
-
-<h3><a name="FI_EMPTY">FI: Empty finalizer should be deleted (FI_EMPTY)</a></h3>
-
-
- <p> Empty <code>finalize()</code> methods are useless, so they should
- be deleted.</p>
-
-
-<h3><a name="FI_EXPLICIT_INVOCATION">FI: Explicit invocation of finalizer (FI_EXPLICIT_INVOCATION)</a></h3>
-
-
- <p> This method contains an explicit invocation of the <code>finalize()</code>
- method on an object. Because finalizer methods are supposed to be
- executed once, and only by the VM, this is a bad idea.</p>
-<p>If a connected set of objects beings finalizable, then the VM will invoke the
-finalize method on all the finalizable object, possibly at the same time in different threads.
-Thus, it is a particularly bad idea, in the finalize method for a class X, invoke finalize
-on objects referenced by X, because they may already be getting finalized in a separate thread.
-
-
-<h3><a name="FI_FINALIZER_NULLS_FIELDS">FI: Finalizer nulls fields (FI_FINALIZER_NULLS_FIELDS)</a></h3>
-
-
- <p> This finalizer nulls out fields. This is usually an error, as it does not aid garbage collection,
- and the object is going to be garbage collected anyway.
-
-
-<h3><a name="FI_FINALIZER_ONLY_NULLS_FIELDS">FI: Finalizer only nulls fields (FI_FINALIZER_ONLY_NULLS_FIELDS)</a></h3>
-
-
- <p> This finalizer does nothing except null out fields. This is completely pointless, and requires that
-the object be garbage collected, finalized, and then garbage collected again. You should just remove the finalize
-method.
-
-
-<h3><a name="FI_MISSING_SUPER_CALL">FI: Finalizer does not call superclass finalizer (FI_MISSING_SUPER_CALL)</a></h3>
-
-
- <p> This <code>finalize()</code> method does not make a call to its
- superclass's <code>finalize()</code> method. So, any finalizer
- actions defined for the superclass will not be performed.
- Add a call to <code>super.finalize()</code>.</p>
-
-
-<h3><a name="FI_NULLIFY_SUPER">FI: Finalizer nullifies superclass finalizer (FI_NULLIFY_SUPER)</a></h3>
-
-
- <p> This empty <code>finalize()</code> method explicitly negates the
- effect of any finalizer defined by its superclass. Any finalizer
- actions defined for the superclass will not be performed.
- Unless this is intended, delete this method.</p>
-
-
-<h3><a name="FI_USELESS">FI: Finalizer does nothing but call superclass finalizer (FI_USELESS)</a></h3>
-
-
- <p> The only thing this <code>finalize()</code> method does is call
- the superclass's <code>finalize()</code> method, making it
- redundant. Delete it.</p>
-
-
-<h3><a name="GC_UNCHECKED_TYPE_IN_GENERIC_CALL">GC: Unchecked type in generic call (GC_UNCHECKED_TYPE_IN_GENERIC_CALL)</a></h3>
-
-
- <p> This call to a generic collection method passes an argument
- while compile type Object where a specific type from
- the generic type parameters is expected.
- Thus, neither the standard Java type system nor static analysis
- can provide useful information on whether the
- object being passed as a parameter is of an appropriate type.
- </p>
-
-
-<h3><a name="HE_EQUALS_NO_HASHCODE">HE: Class defines equals() but not hashCode() (HE_EQUALS_NO_HASHCODE)</a></h3>
-
-
- <p> This class overrides <code>equals(Object)</code>, but does not
- override <code>hashCode()</code>. Therefore, the class may violate the
- invariant that equal objects must have equal hashcodes.</p>
-
-
-<h3><a name="HE_EQUALS_USE_HASHCODE">HE: Class defines equals() and uses Object.hashCode() (HE_EQUALS_USE_HASHCODE)</a></h3>
-
-
- <p> This class overrides <code>equals(Object)</code>, but does not
- override <code>hashCode()</code>, and inherits the implementation of
- <code>hashCode()</code> from <code>java.lang.Object</code> (which returns
- the identity hash code, an arbitrary value assigned to the object
- by the VM). Therefore, the class is very likely to violate the
- invariant that equal objects must have equal hashcodes.</p>
-
-<p>If you don't think instances of this class will ever be inserted into a HashMap/HashTable,
-the recommended <code>hashCode</code> implementation to use is:</p>
-<pre>public int hashCode() {
- assert false : "hashCode not designed";
- return 42; // any arbitrary constant will do
- }</pre>
-
-
-<h3><a name="HE_HASHCODE_NO_EQUALS">HE: Class defines hashCode() but not equals() (HE_HASHCODE_NO_EQUALS)</a></h3>
-
-
- <p> This class defines a <code>hashCode()</code> method but not an
- <code>equals()</code> method. Therefore, the class may
- violate the invariant that equal objects must have equal hashcodes.</p>
-
-
-<h3><a name="HE_HASHCODE_USE_OBJECT_EQUALS">HE: Class defines hashCode() and uses Object.equals() (HE_HASHCODE_USE_OBJECT_EQUALS)</a></h3>
-
-
- <p> This class defines a <code>hashCode()</code> method but inherits its
- <code>equals()</code> method from <code>java.lang.Object</code>
- (which defines equality by comparing object references). Although
- this will probably satisfy the contract that equal objects must have
- equal hashcodes, it is probably not what was intended by overriding
- the <code>hashCode()</code> method. (Overriding <code>hashCode()</code>
- implies that the object's identity is based on criteria more complicated
- than simple reference equality.)</p>
-<p>If you don't think instances of this class will ever be inserted into a HashMap/HashTable,
-the recommended <code>hashCode</code> implementation to use is:</p>
-<p><pre>public int hashCode() {
- assert false : "hashCode not designed";
- return 42; // any arbitrary constant will do
- }</pre></p>
-
-
-<h3><a name="HE_INHERITS_EQUALS_USE_HASHCODE">HE: Class inherits equals() and uses Object.hashCode() (HE_INHERITS_EQUALS_USE_HASHCODE)</a></h3>
-
-
- <p> This class inherits <code>equals(Object)</code> from an abstract
- superclass, and <code>hashCode()</code> from
-<code>java.lang.Object</code> (which returns
- the identity hash code, an arbitrary value assigned to the object
- by the VM). Therefore, the class is very likely to violate the
- invariant that equal objects must have equal hashcodes.</p>
-
- <p>If you don't want to define a hashCode method, and/or don't
- believe the object will ever be put into a HashMap/Hashtable,
- define the <code>hashCode()</code> method
- to throw <code>UnsupportedOperationException</code>.</p>
-
-
-<h3><a name="IC_SUPERCLASS_USES_SUBCLASS_DURING_INITIALIZATION">IC: Superclass uses subclass during initialization (IC_SUPERCLASS_USES_SUBCLASS_DURING_INITIALIZATION)</a></h3>
-
-
- <p> During the initialization of a class, the class makes an active use of a subclass.
-That subclass will not yet be initialized at the time of this use.
-For example, in the following code, <code>foo</code> will be null.</p>
-
-<pre>
-public class CircularClassInitialization {
- static class InnerClassSingleton extends CircularClassInitialization {
- static InnerClassSingleton singleton = new InnerClassSingleton();
- }
-
- static CircularClassInitialization foo = InnerClassSingleton.singleton;
-}
-</pre>
-
-
-
-<h3><a name="IMSE_DONT_CATCH_IMSE">IMSE: Dubious catching of IllegalMonitorStateException (IMSE_DONT_CATCH_IMSE)</a></h3>
-
-
-<p>IllegalMonitorStateException is generally only
- thrown in case of a design flaw in your code (calling wait or
- notify on an object you do not hold a lock on).</p>
-
-
-<h3><a name="ISC_INSTANTIATE_STATIC_CLASS">ISC: Needless instantiation of class that only supplies static methods (ISC_INSTANTIATE_STATIC_CLASS)</a></h3>
-
-
-<p> This class allocates an object that is based on a class that only supplies static methods. This object
-does not need to be created, just access the static methods directly using the class name as a qualifier.</p>
-
-
-<h3><a name="IT_NO_SUCH_ELEMENT">It: Iterator next() method can't throw NoSuchElementException (IT_NO_SUCH_ELEMENT)</a></h3>
-
-
- <p> This class implements the <code>java.util.Iterator</code> interface.
- However, its <code>next()</code> method is not capable of throwing
- <code>java.util.NoSuchElementException</code>. The <code>next()</code>
- method should be changed so it throws <code>NoSuchElementException</code>
- if is called when there are no more elements to return.</p>
-
-
-<h3><a name="J2EE_STORE_OF_NON_SERIALIZABLE_OBJECT_INTO_SESSION">J2EE: Store of non serializable object into HttpSession (J2EE_STORE_OF_NON_SERIALIZABLE_OBJECT_INTO_SESSION)</a></h3>
-
-
-<p>
-This code seems to be storing a non-serializable object into an HttpSession.
-If this session is passivated or migrated, an error will result.
-</p>
-
-
-<h3><a name="JCIP_FIELD_ISNT_FINAL_IN_IMMUTABLE_CLASS">JCIP: Fields of immutable classes should be final (JCIP_FIELD_ISNT_FINAL_IN_IMMUTABLE_CLASS)</a></h3>
-
-
- <p> The class is annotated with net.jcip.annotations.Immutable, and the rules for that annotation require
-that all fields are final.
- .</p>
-
-
-<h3><a name="NP_BOOLEAN_RETURN_NULL">NP: Method with Boolean return type returns explicit null (NP_BOOLEAN_RETURN_NULL)</a></h3>
-
-
- <p>
- A method that returns either Boolean.TRUE, Boolean.FALSE or null is an accident waiting to happen.
- This method can be invoked as though it returned a value of type boolean, and
- the compiler will insert automatic unboxing of the Boolean value. If a null value is returned,
- this will result in a NullPointerException.
- </p>
-
-
-<h3><a name="NP_CLONE_COULD_RETURN_NULL">NP: Clone method may return null (NP_CLONE_COULD_RETURN_NULL)</a></h3>
-
-
- <p>
- This clone method seems to return null in some circumstances, but clone is never
- allowed to return a null value. If you are convinced this path is unreachable, throw an AssertionError
- instead.
- </p>
-
-
-<h3><a name="NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT">NP: equals() method does not check for null argument (NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT)</a></h3>
-
-
- <p>
- This implementation of equals(Object) violates the contract defined
- by java.lang.Object.equals() because it does not check for null
- being passed as the argument. All equals() methods should return
- false if passed a null value.
- </p>
-
-
-<h3><a name="NP_TOSTRING_COULD_RETURN_NULL">NP: toString method may return null (NP_TOSTRING_COULD_RETURN_NULL)</a></h3>
-
-
- <p>
- This toString method seems to return null in some circumstances. A liberal reading of the
- spec could be interpreted as allowing this, but it is probably a bad idea and could cause
- other code to break. Return the empty string or some other appropriate string rather than null.
- </p>
-
-
-<h3><a name="NM_CLASS_NAMING_CONVENTION">Nm: Class names should start with an upper case letter (NM_CLASS_NAMING_CONVENTION)</a></h3>
-
-
- <p> Class names should be nouns, in mixed case with the first letter of each internal word capitalized. Try to keep your class names simple and descriptive. Use whole words-avoid acronyms and abbreviations (unless the abbreviation is much more widely used than the long form, such as URL or HTML).
-</p>
-
-
-<h3><a name="NM_CLASS_NOT_EXCEPTION">Nm: Class is not derived from an Exception, even though it is named as such (NM_CLASS_NOT_EXCEPTION)</a></h3>
-
-
-<p> This class is not derived from another exception, but ends with 'Exception'. This will
-be confusing to users of this class.</p>
-
-
-<h3><a name="NM_CONFUSING">Nm: Confusing method names (NM_CONFUSING)</a></h3>
-
-
- <p> The referenced methods have names that differ only by capitalization.</p>
-
-
-<h3><a name="NM_FIELD_NAMING_CONVENTION">Nm: Field names should start with a lower case letter (NM_FIELD_NAMING_CONVENTION)</a></h3>
-
-
- <p>
-Names of fields that are not final should be in mixed case with a lowercase first letter and the first letters of subsequent words capitalized.
-</p>
-
-
-<h3><a name="NM_FUTURE_KEYWORD_USED_AS_IDENTIFIER">Nm: Use of identifier that is a keyword in later versions of Java (NM_FUTURE_KEYWORD_USED_AS_IDENTIFIER)</a></h3>
-
-
-<p>The identifier is a word that is reserved as a keyword in later versions of Java, and your code will need to be changed
-in order to compile it in later versions of Java.</p>
-
-
-
-<h3><a name="NM_FUTURE_KEYWORD_USED_AS_MEMBER_IDENTIFIER">Nm: Use of identifier that is a keyword in later versions of Java (NM_FUTURE_KEYWORD_USED_AS_MEMBER_IDENTIFIER)</a></h3>
-
-
-<p>This identifier is used as a keyword in later versions of Java. This code, and
-any code that references this API,
-will need to be changed in order to compile it in later versions of Java.</p>
-
-
-
-<h3><a name="NM_METHOD_NAMING_CONVENTION">Nm: Method names should start with a lower case letter (NM_METHOD_NAMING_CONVENTION)</a></h3>
-
-
- <p>
-Methods should be verbs, in mixed case with the first letter lowercase, with the first letter of each internal word capitalized.
-</p>
-
-
-<h3><a name="NM_SAME_SIMPLE_NAME_AS_INTERFACE">Nm: Class names shouldn't shadow simple name of implemented interface (NM_SAME_SIMPLE_NAME_AS_INTERFACE)</a></h3>
-
-
- <p> This class/interface has a simple name that is identical to that of an implemented/extended interface, except
-that the interface is in a different package (e.g., <code>alpha.Foo</code> extends <code>beta.Foo</code>).
-This can be exceptionally confusing, create lots of situations in which you have to look at import statements
-to resolve references and creates many
-opportunities to accidently define methods that do not override methods in their superclasses.
-</p>
-
-
-<h3><a name="NM_SAME_SIMPLE_NAME_AS_SUPERCLASS">Nm: Class names shouldn't shadow simple name of superclass (NM_SAME_SIMPLE_NAME_AS_SUPERCLASS)</a></h3>
-
-
- <p> This class has a simple name that is identical to that of its superclass, except
-that its superclass is in a different package (e.g., <code>alpha.Foo</code> extends <code>beta.Foo</code>).
-This can be exceptionally confusing, create lots of situations in which you have to look at import statements
-to resolve references and creates many
-opportunities to accidently define methods that do not override methods in their superclasses.
-</p>
-
-
-<h3><a name="NM_VERY_CONFUSING_INTENTIONAL">Nm: Very confusing method names (but perhaps intentional) (NM_VERY_CONFUSING_INTENTIONAL)</a></h3>
-
-
- <p> The referenced methods have names that differ only by capitalization.
-This is very confusing because if the capitalization were
-identical then one of the methods would override the other. From the existence of other methods, it
-seems that the existence of both of these methods is intentional, but is sure is confusing.
-You should try hard to eliminate one of them, unless you are forced to have both due to frozen APIs.
-</p>
-
-
-<h3><a name="NM_WRONG_PACKAGE_INTENTIONAL">Nm: Method doesn't override method in superclass due to wrong package for parameter (NM_WRONG_PACKAGE_INTENTIONAL)</a></h3>
-
-
- <p> The method in the subclass doesn't override a similar method in a superclass because the type of a parameter doesn't exactly match
-the type of the corresponding parameter in the superclass. For example, if you have:</p>
-
-<blockquote>
-<pre>
-import alpha.Foo;
-public class A {
- public int f(Foo x) { return 17; }
-}
-----
-import beta.Foo;
-public class B extends A {
- public int f(Foo x) { return 42; }
- public int f(alpha.Foo x) { return 27; }
-}
-</pre>
-</blockquote>
-
-<p>The <code>f(Foo)</code> method defined in class <code>B</code> doesn't
-override the
-<code>f(Foo)</code> method defined in class <code>A</code>, because the argument
-types are <code>Foo</code>'s from different packages.
-</p>
-
-<p>In this case, the subclass does define a method with a signature identical to the method in the superclass,
-so this is presumably understood. However, such methods are exceptionally confusing. You should strongly consider
-removing or deprecating the method with the similar but not identical signature.
-</p>
-
-
-<h3><a name="ODR_OPEN_DATABASE_RESOURCE">ODR: Method may fail to close database resource (ODR_OPEN_DATABASE_RESOURCE)</a></h3>
-
-
-<p> The method creates a database resource (such as a database connection
-or row set), does not assign it to any
-fields, pass it to other methods, or return it, and does not appear to close
-the object on all paths out of the method. Failure to
-close database resources on all paths out of a method may
-result in poor performance, and could cause the application to
-have problems communicating with the database.
-</p>
-
-
-<h3><a name="ODR_OPEN_DATABASE_RESOURCE_EXCEPTION_PATH">ODR: Method may fail to close database resource on exception (ODR_OPEN_DATABASE_RESOURCE_EXCEPTION_PATH)</a></h3>
-
-
-<p> The method creates a database resource (such as a database connection
-or row set), does not assign it to any
-fields, pass it to other methods, or return it, and does not appear to close
-the object on all exception paths out of the method. Failure to
-close database resources on all paths out of a method may
-result in poor performance, and could cause the application to
-have problems communicating with the database.</p>
-
-
-<h3><a name="OS_OPEN_STREAM">OS: Method may fail to close stream (OS_OPEN_STREAM)</a></h3>
-
-
-<p> The method creates an IO stream object, does not assign it to any
-fields, pass it to other methods that might close it,
-or return it, and does not appear to close
-the stream on all paths out of the method. This may result in
-a file descriptor leak. It is generally a good
-idea to use a <code>finally</code> block to ensure that streams are
-closed.</p>
-
-
-<h3><a name="OS_OPEN_STREAM_EXCEPTION_PATH">OS: Method may fail to close stream on exception (OS_OPEN_STREAM_EXCEPTION_PATH)</a></h3>
-
-
-<p> The method creates an IO stream object, does not assign it to any
-fields, pass it to other methods, or return it, and does not appear to close
-it on all possible exception paths out of the method.
-This may result in a file descriptor leak. It is generally a good
-idea to use a <code>finally</code> block to ensure that streams are
-closed.</p>
-
-
-<h3><a name="RC_REF_COMPARISON_BAD_PRACTICE">RC: Suspicious reference comparison to constant (RC_REF_COMPARISON_BAD_PRACTICE)</a></h3>
-
-
-<p> This method compares a reference value to a constant using the == or != operator,
-where the correct way to compare instances of this type is generally
-with the equals() method.
-It is possible to create distinct instances that are equal but do not compare as == since
-they are different objects.
-Examples of classes which should generally
-not be compared by reference are java.lang.Integer, java.lang.Float, etc.</p>
-
-
-<h3><a name="RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN">RC: Suspicious reference comparison of Boolean values (RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN)</a></h3>
-
-
-<p> This method compares two Boolean values using the == or != operator.
-Normally, there are only two Boolean values (Boolean.TRUE and Boolean.FALSE),
-but it is possible to create other Boolean objects using the <code>new Boolean(b)</code>
-constructor. It is best to avoid such objects, but if they do exist,
-then checking Boolean objects for equality using == or != will give results
-than are different than you would get using <code>.equals(...)</code>
-</p>
-
-
-<h3><a name="RR_NOT_CHECKED">RR: Method ignores results of InputStream.read() (RR_NOT_CHECKED)</a></h3>
-
-
- <p> This method ignores the return value of one of the variants of
- <code>java.io.InputStream.read()</code> which can return multiple bytes.
- If the return value is not checked, the caller will not be able to correctly
- handle the case where fewer bytes were read than the caller requested.
- This is a particularly insidious kind of bug, because in many programs,
- reads from input streams usually do read the full amount of data requested,
- causing the program to fail only sporadically.</p>
-
-
-<h3><a name="SR_NOT_CHECKED">RR: Method ignores results of InputStream.skip() (SR_NOT_CHECKED)</a></h3>
-
-
- <p> This method ignores the return value of
- <code>java.io.InputStream.skip()</code> which can skip multiple bytes.
- If the return value is not checked, the caller will not be able to correctly
- handle the case where fewer bytes were skipped than the caller requested.
- This is a particularly insidious kind of bug, because in many programs,
- skips from input streams usually do skip the full amount of data requested,
- causing the program to fail only sporadically. With Buffered streams, however,
- skip() will only skip data in the buffer, and will routinely fail to skip the
- requested number of bytes.</p>
-
-
-<h3><a name="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE">RV: Method ignores exceptional return value (RV_RETURN_VALUE_IGNORED_BAD_PRACTICE)</a></h3>
-
-
- <p> This method returns a value that is not checked. The return value should be checked
-since it can indicate an unusual or unexpected function execution. For
-example, the <code>File.delete()</code> method returns false
-if the file could not be successfully deleted (rather than
-throwing an Exception).
-If you don't check the result, you won't notice if the method invocation
-signals unexpected behavior by returning an atypical return value.
-</p>
-
-
-<h3><a name="SI_INSTANCE_BEFORE_FINALS_ASSIGNED">SI: Static initializer creates instance before all static final fields assigned (SI_INSTANCE_BEFORE_FINALS_ASSIGNED)</a></h3>
-
-
-<p> The class's static initializer creates an instance of the class
-before all of the static final fields are assigned.</p>
-
-
-<h3><a name="SW_SWING_METHODS_INVOKED_IN_SWING_THREAD">SW: Certain swing methods needs to be invoked in Swing thread (SW_SWING_METHODS_INVOKED_IN_SWING_THREAD)</a></h3>
-
-
-<p>(<a href="http://java.sun.com/developer/JDCTechTips/2003/tt1208.html#1">From JDC Tech Tip</a>): The Swing methods
-show(), setVisible(), and pack() will create the associated peer for the frame.
-With the creation of the peer, the system creates the event dispatch thread.
-This makes things problematic because the event dispatch thread could be notifying
-listeners while pack and validate are still processing. This situation could result in
-two threads going through the Swing component-based GUI -- it's a serious flaw that
-could result in deadlocks or other related threading issues. A pack call causes
-components to be realized. As they are being realized (that is, not necessarily
-visible), they could trigger listener notification on the event dispatch thread.</p>
-
-
-
-<h3><a name="SE_BAD_FIELD">Se: Non-transient non-serializable instance field in serializable class (SE_BAD_FIELD)</a></h3>
-
-
-<p> This Serializable class defines a non-primitive instance field which is neither transient,
-Serializable, or <code>java.lang.Object</code>, and does not appear to implement
-the <code>Externalizable</code> interface or the
-<code>readObject()</code> and <code>writeObject()</code> methods.
-Objects of this class will not be deserialized correctly if a non-Serializable
-object is stored in this field.</p>
-
-
-<h3><a name="SE_BAD_FIELD_INNER_CLASS">Se: Non-serializable class has a serializable inner class (SE_BAD_FIELD_INNER_CLASS)</a></h3>
-
-
-<p> This Serializable class is an inner class of a non-serializable class.
-Thus, attempts to serialize it will also attempt to associate instance of the outer
-class with which it is associated, leading to a runtime error.
-</p>
-<p>If possible, making the inner class a static inner class should solve the
-problem. Making the outer class serializable might also work, but that would
-mean serializing an instance of the inner class would always also serialize the instance
-of the outer class, which it often not what you really want.
-
-
-<h3><a name="SE_BAD_FIELD_STORE">Se: Non-serializable value stored into instance field of a serializable class (SE_BAD_FIELD_STORE)</a></h3>
-
-
-<p> A non-serializable value is stored into a non-transient field
-of a serializable class.</p>
-
-
-<h3><a name="SE_COMPARATOR_SHOULD_BE_SERIALIZABLE">Se: Comparator doesn't implement Serializable (SE_COMPARATOR_SHOULD_BE_SERIALIZABLE)</a></h3>
-
-
- <p> This class implements the <code>Comparator</code> interface. You
-should consider whether or not it should also implement the <code>Serializable</code>
-interface. If a comparator is used to construct an ordered collection
-such as a <code>TreeMap</code>, then the <code>TreeMap</code>
-will be serializable only if the comparator is also serializable.
-As most comparators have little or no state, making them serializable
-is generally easy and good defensive programming.
-</p>
-
-
-<h3><a name="SE_INNER_CLASS">Se: Serializable inner class (SE_INNER_CLASS)</a></h3>
-
-
-<p> This Serializable class is an inner class. Any attempt to serialize
-it will also serialize the associated outer instance. The outer instance is serializable,
-so this won't fail, but it might serialize a lot more data than intended.
-If possible, making the inner class a static inner class (also known as a nested class) should solve the
-problem.
-
-
-<h3><a name="SE_NONFINAL_SERIALVERSIONID">Se: serialVersionUID isn't final (SE_NONFINAL_SERIALVERSIONID)</a></h3>
-
-
- <p> This class defines a <code>serialVersionUID</code> field that is not final.
- The field should be made final
- if it is intended to specify
- the version UID for purposes of serialization.</p>
-
-
-<h3><a name="SE_NONLONG_SERIALVERSIONID">Se: serialVersionUID isn't long (SE_NONLONG_SERIALVERSIONID)</a></h3>
-
-
- <p> This class defines a <code>serialVersionUID</code> field that is not long.
- The field should be made long
- if it is intended to specify
- the version UID for purposes of serialization.</p>
-
-
-<h3><a name="SE_NONSTATIC_SERIALVERSIONID">Se: serialVersionUID isn't static (SE_NONSTATIC_SERIALVERSIONID)</a></h3>
-
-
- <p> This class defines a <code>serialVersionUID</code> field that is not static.
- The field should be made static
- if it is intended to specify
- the version UID for purposes of serialization.</p>
-
-
-<h3><a name="SE_NO_SUITABLE_CONSTRUCTOR">Se: Class is Serializable but its superclass doesn't define a void constructor (SE_NO_SUITABLE_CONSTRUCTOR)</a></h3>
-
-
- <p> This class implements the <code>Serializable</code> interface
- and its superclass does not. When such an object is deserialized,
- the fields of the superclass need to be initialized by
- invoking the void constructor of the superclass.
- Since the superclass does not have one,
- serialization and deserialization will fail at runtime.</p>
-
-
-<h3><a name="SE_NO_SUITABLE_CONSTRUCTOR_FOR_EXTERNALIZATION">Se: Class is Externalizable but doesn't define a void constructor (SE_NO_SUITABLE_CONSTRUCTOR_FOR_EXTERNALIZATION)</a></h3>
-
-
- <p> This class implements the <code>Externalizable</code> interface, but does
- not define a void constructor. When Externalizable objects are deserialized,
- they first need to be constructed by invoking the void
- constructor. Since this class does not have one,
- serialization and deserialization will fail at runtime.</p>
-
-
-<h3><a name="SE_READ_RESOLVE_MUST_RETURN_OBJECT">Se: The readResolve method must be declared with a return type of Object. (SE_READ_RESOLVE_MUST_RETURN_OBJECT)</a></h3>
-
-
- <p> In order for the readResolve method to be recognized by the serialization
-mechanism, it must be declared to have a return type of Object.
-</p>
-
-
-<h3><a name="SE_TRANSIENT_FIELD_NOT_RESTORED">Se: Transient field that isn't set by deserialization. (SE_TRANSIENT_FIELD_NOT_RESTORED)</a></h3>
-
-
- <p> This class contains a field that is updated at multiple places in the class, thus it seems to be part of the state of the class. However, since the field is marked as transient and not set in readObject or readResolve, it will contain the default value in any
-deserialized instance of the class.
-</p>
-
-
-<h3><a name="SE_NO_SERIALVERSIONID">SnVI: Class is Serializable, but doesn't define serialVersionUID (SE_NO_SERIALVERSIONID)</a></h3>
-
-
- <p> This class implements the <code>Serializable</code> interface, but does
- not define a <code>serialVersionUID</code> field.
- A change as simple as adding a reference to a .class object
- will add synthetic fields to the class,
- which will unfortunately change the implicit
- serialVersionUID (e.g., adding a reference to <code>String.class</code>
- will generate a static field <code>class$java$lang$String</code>).
- Also, different source code to bytecode compilers may use different
- naming conventions for synthetic variables generated for
- references to class objects or inner classes.
- To ensure interoperability of Serializable across versions,
- consider adding an explicit serialVersionUID.</p>
-
-
-<h3><a name="UI_INHERITANCE_UNSAFE_GETRESOURCE">UI: Usage of GetResource may be unsafe if class is extended (UI_INHERITANCE_UNSAFE_GETRESOURCE)</a></h3>
-
-
-<p>Calling <code>this.getClass().getResource(...)</code> could give
-results other than expected if this class is extended by a class in
-another package.</p>
-
-
-<h3><a name="BC_IMPOSSIBLE_CAST">BC: Impossible cast (BC_IMPOSSIBLE_CAST)</a></h3>
-
-
-<p>
-This cast will always throw a ClassCastException.
-FindBugs tracks type information from instanceof checks,
-and also uses more precise information about the types
-of values returned from methods and loaded from fields.
-Thus, it may have more precise information that just
-the declared type of a variable, and can use this to determine
-that a cast will always throw an exception at runtime.
-
-</p>
-
-
-<h3><a name="BC_IMPOSSIBLE_DOWNCAST">BC: Impossible downcast (BC_IMPOSSIBLE_DOWNCAST)</a></h3>
-
-
-<p>
-This cast will always throw a ClassCastException.
-The analysis believes it knows
-the precise type of the value being cast, and the attempt to
-downcast it to a subtype will always fail by throwing a ClassCastException.
-</p>
-
-
-<h3><a name="BC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY">BC: Impossible downcast of toArray() result (BC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY)</a></h3>
-
-
-<p>
-This code is casting the result of calling <code>toArray()</code> on a collection
-to a type more specific than <code>Object[]</code>, as in:
-<pre>
-String[] getAsArray(Collection<String> c) {
- return (String[]) c.toArray();
- }
-</pre>
-<p>This will usually fail by throwing a ClassCastException. The <code>toArray()</code>
-of almost all collections return an <code>Object[]</code>. They can't really do anything else,
-since the Collection object has no reference to the declared generic type of the collection.
-<p>The correct way to do get an array of a specific type from a collection is to use
- <code>c.toArray(new String[]);</code>
- or <code>c.toArray(new String[c.size()]);</code> (the latter is slightly more efficient).
-<p>There is one common/known exception exception to this. The <code>toArray()</code>
-method of lists returned by <code>Arrays.asList(...)</code> will return a covariantly
-typed array. For example, <code>Arrays.asArray(new String[] { "a" }).toArray()</code>
-will return a <code>String []</code>. FindBugs attempts to detect and suppress
-such cases, but may miss some.
-</p>
-
-
-<h3><a name="BC_IMPOSSIBLE_INSTANCEOF">BC: instanceof will always return false (BC_IMPOSSIBLE_INSTANCEOF)</a></h3>
-
-
-<p>
-This instanceof test will always return false. Although this is safe, make sure it isn't
-an indication of some misunderstanding or some other logic error.
-</p>
-
-
-<h3><a name="BIT_ADD_OF_SIGNED_BYTE">BIT: Bitwise add of signed byte value (BIT_ADD_OF_SIGNED_BYTE)</a></h3>
-
-
-<p> Adds a byte value and a value which is known to the 8 lower bits clear.
-Values loaded from a byte array are sign extended to 32 bits
-before any any bitwise operations are performed on the value.
-Thus, if <code>b[0]</code> contains the value <code>0xff</code>, and
-<code>x</code> is initially 0, then the code
-<code>((x << 8) + b[0])</code> will sign extend <code>0xff</code>
-to get <code>0xffffffff</code>, and thus give the value
-<code>0xffffffff</code> as the result.
-</p>
-
-<p>In particular, the following code for packing a byte array into an int is badly wrong: </p>
-<pre>
-int result = 0;
-for(int i = 0; i < 4; i++)
- result = ((result << 8) + b[i]);
-</pre>
-
-<p>The following idiom will work instead: </p>
-<pre>
-int result = 0;
-for(int i = 0; i < 4; i++)
- result = ((result << 8) + (b[i] & 0xff));
-</pre>
-
-
-
-<h3><a name="BIT_AND">BIT: Incompatible bit masks (BIT_AND)</a></h3>
-
-
-<p> This method compares an expression of the form (e & C) to D,
-which will always compare unequal
-due to the specific values of constants C and D.
-This may indicate a logic error or typo.</p>
-
-
-<h3><a name="BIT_AND_ZZ">BIT: Check to see if ((...) & 0) == 0 (BIT_AND_ZZ)</a></h3>
-
-
-<p> This method compares an expression of the form (e & 0) to 0,
-which will always compare equal.
-This may indicate a logic error or typo.</p>
-
-
-<h3><a name="BIT_IOR">BIT: Incompatible bit masks (BIT_IOR)</a></h3>
-
-
-<p> This method compares an expression of the form (e | C) to D.
-which will always compare unequal
-due to the specific values of constants C and D.
-This may indicate a logic error or typo.</p>
-
-<p> Typically, this bug occurs because the code wants to perform
-a membership test in a bit set, but uses the bitwise OR
-operator ("|") instead of bitwise AND ("&").</p>
-
-
-<h3><a name="BIT_IOR_OF_SIGNED_BYTE">BIT: Bitwise OR of signed byte value (BIT_IOR_OF_SIGNED_BYTE)</a></h3>
-
-
-<p> Loads a value from a byte array and performs a bitwise OR with
-that value. Values loaded from a byte array are sign extended to 32 bits
-before any any bitwise operations are performed on the value.
-Thus, if <code>b[0]</code> contains the value <code>0xff</code>, and
-<code>x</code> is initially 0, then the code
-<code>((x << 8) | b[0])</code> will sign extend <code>0xff</code>
-to get <code>0xffffffff</code>, and thus give the value
-<code>0xffffffff</code> as the result.
-</p>
-
-<p>In particular, the following code for packing a byte array into an int is badly wrong: </p>
-<pre>
-int result = 0;
-for(int i = 0; i < 4; i++)
- result = ((result << 8) | b[i]);
-</pre>
-
-<p>The following idiom will work instead: </p>
-<pre>
-int result = 0;
-for(int i = 0; i < 4; i++)
- result = ((result << 8) | (b[i] & 0xff));
-</pre>
-
-
-
-<h3><a name="BIT_SIGNED_CHECK_HIGH_BIT">BIT: Check for sign of bitwise operation (BIT_SIGNED_CHECK_HIGH_BIT)</a></h3>
-
-
-<p> This method compares an expression such as
-<pre>((event.detail & SWT.SELECTED) > 0)</pre>.
-Using bit arithmetic and then comparing with the greater than operator can
-lead to unexpected results (of course depending on the value of
-SWT.SELECTED). If SWT.SELECTED is a negative number, this is a candidate
-for a bug. Even when SWT.SELECTED is not negative, it seems good practice
-to use '!= 0' instead of '> 0'.
-</p>
-<p>
-<em>Boris Bokowski</em>
-</p>
-
-
-<h3><a name="BOA_BADLY_OVERRIDDEN_ADAPTER">BOA: Class overrides a method implemented in super class Adapter wrongly (BOA_BADLY_OVERRIDDEN_ADAPTER)</a></h3>
-
-
-<p> This method overrides a method found in a parent class, where that class is an Adapter that implements
-a listener defined in the java.awt.event or javax.swing.event package. As a result, this method will not
-get called when the event occurs.</p>
-
-
-<h3><a name="ICAST_BAD_SHIFT_AMOUNT">BSHIFT: 32 bit int shifted by an amount not in the range 0..31 (ICAST_BAD_SHIFT_AMOUNT)</a></h3>
-
-
-<p>
-The code performs shift of a 32 bit int by a constant amount outside
-the range 0..31.
-The effect of this is to use the lower 5 bits of the integer
-value to decide how much to shift by (e.g., shifting by 40 bits is the same as shifting by 8 bits,
-and shifting by 32 bits is the same as shifting by zero bits). This probably isn't want was expected,
-and it at least confusing.
-</p>
-
-
-<h3><a name="BX_UNBOXED_AND_COERCED_FOR_TERNARY_OPERATOR">Bx: Primitive value is unboxed and coerced for ternary operator (BX_UNBOXED_AND_COERCED_FOR_TERNARY_OPERATOR)</a></h3>
-
-
- <p>A wrapped primitive value is unboxed and converted to another primitive type as part of the
-evaluation of a conditional ternary operator (the <code> b ? e1 : e2</code> operator). The
-semantics of Java mandate that if <code>e1</code> and <code>e2</code> are wrapped
-numeric values, the values are unboxed and converted/coerced to their common type (e.g,
-if <code>e1</code> is of type <code>Integer</code>
-and <code>e2</code> is of type <code>Float</code>, then <code>e1</code> is unboxed,
-converted to a floating point value, and boxed. See JLS Section 15.25.
-</p>
-
-
-<h3><a name="DLS_DEAD_STORE_OF_CLASS_LITERAL">DLS: Dead store of class literal (DLS_DEAD_STORE_OF_CLASS_LITERAL)</a></h3>
-
-
-<p>
-This instruction assigns a class literal to a variable and then never uses it.
-<a href="//java.sun.com/j2se/1.5.0/compatibility.html#literal">The behavior of this differs in Java 1.4 and in Java 5.</a>
-In Java 1.4 and earlier, a reference to <code>Foo.class</code> would force the static initializer
-for <code>Foo</code> to be executed, if it has not been executed already.
-In Java 5 and later, it does not.
-</p>
-<p>See Sun's <a href="//java.sun.com/j2se/1.5.0/compatibility.html#literal">article on Java SE compatibility</a>
-for more details and examples, and suggestions on how to force class initialization in Java 5.
-</p>
-
-
-<h3><a name="DLS_OVERWRITTEN_INCREMENT">DLS: Overwritten increment (DLS_OVERWRITTEN_INCREMENT)</a></h3>
-
-
-<p>
-The code performs an increment operation (e.g., <code>i++</code>) and then
-immediately overwrites it. For example, <code>i = i++</code> immediately
-overwrites the incremented value with the original value.
-</p>
-
-
-<h3><a name="DMI_BAD_MONTH">DMI: Bad constant value for month (DMI_BAD_MONTH)</a></h3>
-
-
-<p>
-This code passes a constant month
-value outside the expected range of 0..11 to a method.
-</p>
-
-
-<h3><a name="DMI_CALLING_NEXT_FROM_HASNEXT">DMI: hasNext method invokes next (DMI_CALLING_NEXT_FROM_HASNEXT)</a></h3>
-
-
-<p>
-The hasNext() method invokes the next() method. This is almost certainly wrong,
-since the hasNext() method is not supposed to change the state of the iterator,
-and the next method is supposed to change the state of the iterator.
-</p>
-
-
-<h3><a name="DMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVES">DMI: Collections should not contain themselves (DMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVES)</a></h3>
-
-
- <p> This call to a generic collection's method would only make sense if a collection contained
-itself (e.g., if <code>s.contains(s)</code> were true). This is unlikely to be true and would cause
-problems if it were true (such as the computation of the hash code resulting in infinite recursion).
-It is likely that the wrong value is being passed as a parameter.
- </p>
-
-
-<h3><a name="DMI_INVOKING_HASHCODE_ON_ARRAY">DMI: Invocation of hashCode on an array (DMI_INVOKING_HASHCODE_ON_ARRAY)</a></h3>
-
-
-<p>
-The code invokes hashCode on an array. Calling hashCode on
-an array returns the same value as System.identityHashCode, and ingores
-the contents and length of the array. If you need a hashCode that
-depends on the contents of an array <code>a</code>,
-use <code>java.util.Arrays.hashCode(a)</code>.
-
-</p>
-
-
-<h3><a name="DMI_LONG_BITS_TO_DOUBLE_INVOKED_ON_INT">DMI: Double.longBitsToDouble invoked on an int (DMI_LONG_BITS_TO_DOUBLE_INVOKED_ON_INT)</a></h3>
-
-
-<p> The Double.longBitsToDouble method is invoked, but a 32 bit int value is passed
- as an argument. This almostly certainly is not intended and is unlikely
- to give the intended result.
-</p>
-
-
-<h3><a name="DMI_VACUOUS_SELF_COLLECTION_CALL">DMI: Vacuous call to collections (DMI_VACUOUS_SELF_COLLECTION_CALL)</a></h3>
-
-
- <p> This call doesn't make sense. For any collection <code>c</code>, calling <code>c.containsAll(c)</code> should
-always be true, and <code>c.retainAll(c)</code> should have no effect.
- </p>
-
-
-<h3><a name="DMI_ANNOTATION_IS_NOT_VISIBLE_TO_REFLECTION">Dm: Can't use reflection to check for presence of annotation without runtime retention (DMI_ANNOTATION_IS_NOT_VISIBLE_TO_REFLECTION)</a></h3>
-
-
- <p> Unless an annotation has itself been annotated with @Retention(RetentionPolicy.RUNTIME), the annotation can't be observed using reflection
-(e.g., by using the isAnnotationPresent method).
- .</p>
-
-
-<h3><a name="DMI_FUTILE_ATTEMPT_TO_CHANGE_MAXPOOL_SIZE_OF_SCHEDULED_THREAD_POOL_EXECUTOR">Dm: Futile attempt to change max pool size of ScheduledThreadPoolExecutor (DMI_FUTILE_ATTEMPT_TO_CHANGE_MAXPOOL_SIZE_OF_SCHEDULED_THREAD_POOL_EXECUTOR)</a></h3>
-
-
- <p>(<a href="http://java.sun.com/javase/6/docs/api/java/util/concurrent/ScheduledThreadPoolExecutor.html">Javadoc</a>)
-While ScheduledThreadPoolExecutor inherits from ThreadPoolExecutor, a few of the inherited tuning methods are not useful for it. In particular, because it acts as a fixed-sized pool using corePoolSize threads and an unbounded queue, adjustments to maximumPoolSize have no useful effect.
- </p>
-
-
-
-<h3><a name="DMI_SCHEDULED_THREAD_POOL_EXECUTOR_WITH_ZERO_CORE_THREADS">Dm: Creation of ScheduledThreadPoolExecutor with zero core threads (DMI_SCHEDULED_THREAD_POOL_EXECUTOR_WITH_ZERO_CORE_THREADS)</a></h3>
-
-
- <p>(<a href="http://java.sun.com/javase/6/docs/api/java/util/concurrent/ScheduledThreadPoolExecutor.html#ScheduledThreadPoolExecutor(int)">Javadoc</a>)
-A ScheduledThreadPoolExecutor with zero core threads will never execute anything; changes to the max pool size are ignored.
-</p>
-
-
-
-<h3><a name="DMI_VACUOUS_CALL_TO_EASYMOCK_METHOD">Dm: Useless/vacuous call to EasyMock method (DMI_VACUOUS_CALL_TO_EASYMOCK_METHOD)</a></h3>
-
-
- <p>This call doesn't pass any objects to the EasyMock method, so the call doesn't do anything.
-</p>
-
-
-
-<h3><a name="EC_ARRAY_AND_NONARRAY">EC: equals() used to compare array and nonarray (EC_ARRAY_AND_NONARRAY)</a></h3>
-
-
-<p>
-This method invokes the .equals(Object o) to compare an array and a reference that doesn't seem
-to be an array. If things being compared are of different types, they are guaranteed to be unequal
-and the comparison is almost certainly an error. Even if they are both arrays, the equals method
-on arrays only determines of the two arrays are the same object.
-To compare the
-contents of the arrays, use java.util.Arrays.equals(Object[], Object[]).
-</p>
-
-
-<h3><a name="EC_BAD_ARRAY_COMPARE">EC: Invocation of equals() on an array, which is equivalent to == (EC_BAD_ARRAY_COMPARE)</a></h3>
-
-
-<p>
-This method invokes the .equals(Object o) method on an array. Since arrays do not override the equals
-method of Object, calling equals on an array is the same as comparing their addresses. To compare the
-contents of the arrays, use <code>java.util.Arrays.equals(Object[], Object[])</code>.
-To compare the addresses of the arrays, it would be
-less confusing to explicitly pointer equality using <code>==</code>.
-</p>
-
-
-<h3><a name="EC_INCOMPATIBLE_ARRAY_COMPARE">EC: equals(...) used to compare incompatible arrays (EC_INCOMPATIBLE_ARRAY_COMPARE)</a></h3>
-
-
-<p>
-This method invokes the .equals(Object o) to compare two arrays, but the arrays of
-of incompatible types (e.g., String[] and StringBuffer[], or String[] and int[]).
-They will never be equal. In addition, when equals(...) is used to compare arrays it
-only checks to see if they are the same array, and ignores the contents of the arrays.
-</p>
-
-
-<h3><a name="EC_NULL_ARG">EC: Call to equals() with null argument (EC_NULL_ARG)</a></h3>
-
-
-<p> This method calls equals(Object), passing a null value as
-the argument. According to the contract of the equals() method,
-this call should always return <code>false</code>.</p>
-
-
-<h3><a name="EC_UNRELATED_CLASS_AND_INTERFACE">EC: Call to equals() comparing unrelated class and interface (EC_UNRELATED_CLASS_AND_INTERFACE)</a></h3>
-
-
-<p>
-This method calls equals(Object) on two references, one of which is a class
-and the other an interface, where neither the class nor any of its
-non-abstract subclasses implement the interface.
-Therefore, the objects being compared
-are unlikely to be members of the same class at runtime
-(unless some application classes were not analyzed, or dynamic class
-loading can occur at runtime).
-According to the contract of equals(),
-objects of different
-classes should always compare as unequal; therefore, according to the
-contract defined by java.lang.Object.equals(Object),
-the result of this comparison will always be false at runtime.
-</p>
-
-
-<h3><a name="EC_UNRELATED_INTERFACES">EC: Call to equals() comparing different interface types (EC_UNRELATED_INTERFACES)</a></h3>
-
-
-<p> This method calls equals(Object) on two references of unrelated
-interface types, where neither is a subtype of the other,
-and there are no known non-abstract classes which implement both interfaces.
-Therefore, the objects being compared
-are unlikely to be members of the same class at runtime
-(unless some application classes were not analyzed, or dynamic class
-loading can occur at runtime).
-According to the contract of equals(),
-objects of different
-classes should always compare as unequal; therefore, according to the
-contract defined by java.lang.Object.equals(Object),
-the result of this comparison will always be false at runtime.
-</p>
-
-
-<h3><a name="EC_UNRELATED_TYPES">EC: Call to equals() comparing different types (EC_UNRELATED_TYPES)</a></h3>
-
-
-<p> This method calls equals(Object) on two references of different
-class types with no common subclasses.
-Therefore, the objects being compared
-are unlikely to be members of the same class at runtime
-(unless some application classes were not analyzed, or dynamic class
-loading can occur at runtime).
-According to the contract of equals(),
-objects of different
-classes should always compare as unequal; therefore, according to the
-contract defined by java.lang.Object.equals(Object),
-the result of this comparison will always be false at runtime.
-</p>
-
-
-<h3><a name="EC_UNRELATED_TYPES_USING_POINTER_EQUALITY">EC: Using pointer equality to compare different types (EC_UNRELATED_TYPES_USING_POINTER_EQUALITY)</a></h3>
-
-
-<p> This method uses using pointer equality to compare two references that seem to be of
-different types. The result of this comparison will always be false at runtime.
-</p>
-
-
-<h3><a name="EQ_ALWAYS_FALSE">Eq: equals method always returns false (EQ_ALWAYS_FALSE)</a></h3>
-
-
- <p> This class defines an equals method that always returns false. This means that an object is not equal to itself, and it is impossible to create useful Maps or Sets of this class. More fundamentally, it means
-that equals is not reflexive, one of the requirements of the equals method.</p>
-<p>The likely intended semantics are object identity: that an object is equal to itself. This is the behavior inherited from class <code>Object</code>. If you need to override an equals inherited from a different
-superclass, you can use use:
-<pre>
-public boolean equals(Object o) { return this == o; }
-</pre>
-</p>
-
-
-<h3><a name="EQ_ALWAYS_TRUE">Eq: equals method always returns true (EQ_ALWAYS_TRUE)</a></h3>
-
-
- <p> This class defines an equals method that always returns true. This is imaginative, but not very smart.
-Plus, it means that the equals method is not symmetric.
-</p>
-
-
-<h3><a name="EQ_COMPARING_CLASS_NAMES">Eq: equals method compares class names rather than class objects (EQ_COMPARING_CLASS_NAMES)</a></h3>
-
-
- <p> This method checks to see if two objects are the same class by checking to see if the names
-of their classes are equal. You can have different classes with the same name if they are loaded by
-different class loaders. Just check to see if the class objects are the same.
-</p>
-
-
-<h3><a name="EQ_DONT_DEFINE_EQUALS_FOR_ENUM">Eq: Covariant equals() method defined for enum (EQ_DONT_DEFINE_EQUALS_FOR_ENUM)</a></h3>
-
-
- <p> This class defines an enumeration, and equality on enumerations are defined
-using object identity. Defining a covariant equals method for an enumeration
-value is exceptionally bad practice, since it would likely result
-in having two different enumeration values that compare as equals using
-the covariant enum method, and as not equal when compared normally.
-Don't do it.
-</p>
-
-
-<h3><a name="EQ_OTHER_NO_OBJECT">Eq: equals() method defined that doesn't override equals(Object) (EQ_OTHER_NO_OBJECT)</a></h3>
-
-
- <p> This class defines an <code>equals()</code>
- method, that doesn't override the normal <code>equals(Object)</code> method
- defined in the base <code>java.lang.Object</code> class. Instead, it
- inherits an <code>equals(Object)</code> method from a superclass.
- The class should probably define a <code>boolean equals(Object)</code> method.
- </p>
-
-
-<h3><a name="EQ_OTHER_USE_OBJECT">Eq: equals() method defined that doesn't override Object.equals(Object) (EQ_OTHER_USE_OBJECT)</a></h3>
-
-
- <p> This class defines an <code>equals()</code>
- method, that doesn't override the normal <code>equals(Object)</code> method
- defined in the base <code>java.lang.Object</code> class.
- The class should probably define a <code>boolean equals(Object)</code> method.
- </p>
-
-
-<h3><a name="EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC">Eq: equals method overrides equals in superclass and may not be symmetric (EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC)</a></h3>
-
-
- <p> This class defines an equals method that overrides an equals method in a superclass. Both equals methods
-methods use <code>instanceof</code> in the determination of whether two objects are equal. This is fraught with peril,
-since it is important that the equals method is symmetrical (in other words, <code>a.equals(b) == b.equals(a)</code>).
-If B is a subtype of A, and A's equals method checks that the argument is an instanceof A, and B's equals method
-checks that the argument is an instanceof B, it is quite likely that the equivalence relation defined by these
-methods is not symmetric.
-</p>
-
-
-<h3><a name="EQ_SELF_USE_OBJECT">Eq: Covariant equals() method defined, Object.equals(Object) inherited (EQ_SELF_USE_OBJECT)</a></h3>
-
-
- <p> This class defines a covariant version of the <code>equals()</code>
- method, but inherits the normal <code>equals(Object)</code> method
- defined in the base <code>java.lang.Object</code> class.
- The class should probably define a <code>boolean equals(Object)</code> method.
- </p>
-
-
-<h3><a name="FE_TEST_IF_EQUAL_TO_NOT_A_NUMBER">FE: Doomed test for equality to NaN (FE_TEST_IF_EQUAL_TO_NOT_A_NUMBER)</a></h3>
-
-
- <p>
- This code checks to see if a floating point value is equal to the special
- Not A Number value (e.g., <code>if (x == Double.NaN)</code>). However,
- because of the special semantics of <code>NaN</code>, no value
- is equal to <code>Nan</code>, including <code>NaN</code>. Thus,
- <code>x == Double.NaN</code> always evaluates to false.
-
- To check to see if a value contained in <code>x</code>
- is the special Not A Number value, use
- <code>Double.isNaN(x)</code> (or <code>Float.isNaN(x)</code> if
- <code>x</code> is floating point precision).
- </p>
-
-
-<h3><a name="VA_FORMAT_STRING_BAD_ARGUMENT">FS: Format string placeholder incompatible with passed argument (VA_FORMAT_STRING_BAD_ARGUMENT)</a></h3>
-
-
-<p>
-The format string placeholder is incompatible with the corresponding
-argument. For example,
-<code>
- System.out.println("%d\n", "hello");
-</code>
-<p>The %d placeholder requires a numeric argument, but a string value is
-passed instead.
-A runtime exception will occur when
-this statement is executed.
-</p>
-
-
-<h3><a name="VA_FORMAT_STRING_BAD_CONVERSION">FS: The type of a supplied argument doesn't match format specifier (VA_FORMAT_STRING_BAD_CONVERSION)</a></h3>
-
-
-<p>
-One of the arguments is uncompatible with the corresponding format string specifier.
-As a result, this will generate a runtime exception when executed.
-For example, <code>String.format("%d", "1")</code> will generate an exception, since
-the String "1" is incompatible with the format specifier %d.
-</p>
-
-
-<h3><a name="VA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIED">FS: MessageFormat supplied where printf style format expected (VA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIED)</a></h3>
-
-
-<p>
-A method is called that expects a Java printf format string and a list of arguments.
-However, the format string doesn't contain any format specifiers (e.g., %s) but
-does contain message format elements (e.g., {0}). It is likely
-that the code is supplying a MessageFormat string when a printf-style format string
-is required. At runtime, all of the arguments will be ignored
-and the format string will be returned exactly as provided without any formatting.
-</p>
-</p>
-
-
-<h3><a name="VA_FORMAT_STRING_EXTRA_ARGUMENTS_PASSED">FS: More arguments are passed than are actually used in the format string (VA_FORMAT_STRING_EXTRA_ARGUMENTS_PASSED)</a></h3>
-
-
-<p>
-A format-string method with a variable number of arguments is called,
-but more arguments are passed than are actually used by the format string.
-This won't cause a runtime exception, but the code may be silently omitting
-information that was intended to be included in the formatted string.
-</p>
-
-
-<h3><a name="VA_FORMAT_STRING_ILLEGAL">FS: Illegal format string (VA_FORMAT_STRING_ILLEGAL)</a></h3>
-
-
-<p>
-The format string is syntactically invalid,
-and a runtime exception will occur when
-this statement is executed.
-</p>
-
-
-<h3><a name="VA_FORMAT_STRING_MISSING_ARGUMENT">FS: Format string references missing argument (VA_FORMAT_STRING_MISSING_ARGUMENT)</a></h3>
-
-
-<p>
-Not enough arguments are passed to satisfy a placeholder in the format string.
-A runtime exception will occur when
-this statement is executed.
-</p>
-
-
-<h3><a name="VA_FORMAT_STRING_NO_PREVIOUS_ARGUMENT">FS: No previous argument for format string (VA_FORMAT_STRING_NO_PREVIOUS_ARGUMENT)</a></h3>
-
-
-<p>
-The format string specifies a relative index to request that the argument for the previous format specifier
-be reused. However, there is no previous argument.
-For example,
-</p>
-<p><code>formatter.format("%<s %s", "a", "b")</code>
-</p>
-<p>would throw a MissingFormatArgumentException when executed.
-</p>
-
-
-<h3><a name="GC_UNRELATED_TYPES">GC: No relationship between generic parameter and method argument (GC_UNRELATED_TYPES)</a></h3>
-
-
- <p> This call to a generic collection method contains an argument
- with an incompatible class from that of the collection's parameter
- (i.e., the type of the argument is neither a supertype nor a subtype
- of the corresponding generic type argument).
- Therefore, it is unlikely that the collection contains any objects
- that are equal to the method argument used here.
- Most likely, the wrong value is being passed to the method.</p>
- <p>In general, instances of two unrelated classes are not equal.
- For example, if the <code>Foo</code> and <code>Bar</code> classes
- are not related by subtyping, then an instance of <code>Foo</code>
- should not be equal to an instance of <code>Bar</code>.
- Among other issues, doing so will likely result in an equals method
- that is not symmetrical. For example, if you define the <code>Foo</code> class
- so that a <code>Foo</code> can be equal to a <code>String</code>,
- your equals method isn't symmetrical since a <code>String</code> can only be equal
- to a <code>String</code>.
- </p>
- <p>In rare cases, people do define nonsymmetrical equals methods and still manage to make
- their code work. Although none of the APIs document or guarantee it, it is typically
- the case that if you check if a <code>Collection<String></code> contains
- a <code>Foo</code>, the equals method of argument (e.g., the equals method of the
- <code>Foo</code> class) used to perform the equality checks.
- </p>
-
-
-<h3><a name="HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS">HE: Signature declares use of unhashable class in hashed construct (HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS)</a></h3>
-
-
- <p> A method, field or class declares a generic signature where a non-hashable class
-is used in context where a hashable class is required.
-A class that declares an equals method but inherits a hashCode() method
-from Object is unhashable, since it doesn't fulfill the requirement that
-equal objects have equal hashCodes.
-</p>
-
-
-<h3><a name="HE_USE_OF_UNHASHABLE_CLASS">HE: Use of class without a hashCode() method in a hashed data structure (HE_USE_OF_UNHASHABLE_CLASS)</a></h3>
-
-
- <p> A class defines an equals(Object) method but not a hashCode() method,
-and thus doesn't fulfill the requirement that equal objects have equal hashCodes.
-An instance of this class is used in a hash data structure, making the need to
-fix this problem of highest importance.
-
-
-<h3><a name="ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL">ICAST: integral value cast to double and then passed to Math.ceil (ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL)</a></h3>
-
-
-<p>
-This code converts an integral value (e.g., int or long)
-to a double precision
-floating point number and then
-passing the result to the Math.ceil() function, which rounds a double to
-the next higher integer value. This operation should always be a no-op,
-since the converting an integer to a double should give a number with no fractional part.
-It is likely that the operation that generated the value to be passed
-to Math.ceil was intended to be performed using double precision
-floating point arithmetic.
-</p>
-
-
-
-<h3><a name="ICAST_INT_CAST_TO_FLOAT_PASSED_TO_ROUND">ICAST: int value cast to float and then passed to Math.round (ICAST_INT_CAST_TO_FLOAT_PASSED_TO_ROUND)</a></h3>
-
-
-<p>
-This code converts an int value to a float precision
-floating point number and then
-passing the result to the Math.round() function, which returns the int/long closest
-to the argument. This operation should always be a no-op,
-since the converting an integer to a float should give a number with no fractional part.
-It is likely that the operation that generated the value to be passed
-to Math.round was intended to be performed using
-floating point arithmetic.
-</p>
-
-
-
-<h3><a name="IJU_ASSERT_METHOD_INVOKED_FROM_RUN_METHOD">IJU: JUnit assertion in run method will not be noticed by JUnit (IJU_ASSERT_METHOD_INVOKED_FROM_RUN_METHOD)</a></h3>
-
-
-<p> A JUnit assertion is performed in a run method. Failed JUnit assertions
-just result in exceptions being thrown.
-Thus, if this exception occurs in a thread other than the thread that invokes
-the test method, the exception will terminate the thread but not result
-in the test failing.
-</p>
-
-
-<h3><a name="IJU_BAD_SUITE_METHOD">IJU: TestCase declares a bad suite method (IJU_BAD_SUITE_METHOD)</a></h3>
-
-
-<p> Class is a JUnit TestCase and defines a suite() method.
-However, the suite method needs to be declared as either
-<pre>public static junit.framework.Test suite()</pre>
-or
-<pre>public static junit.framework.TestSuite suite()</pre>
-</p>
-
-
-<h3><a name="IJU_NO_TESTS">IJU: TestCase has no tests (IJU_NO_TESTS)</a></h3>
-
-
-<p> Class is a JUnit TestCase but has not implemented any test methods</p>
-
-
-<h3><a name="IJU_SETUP_NO_SUPER">IJU: TestCase defines setUp that doesn't call super.setUp() (IJU_SETUP_NO_SUPER)</a></h3>
-
-
-<p> Class is a JUnit TestCase and implements the setUp method. The setUp method should call
-super.setUp(), but doesn't.</p>
-
-
-<h3><a name="IJU_SUITE_NOT_STATIC">IJU: TestCase implements a non-static suite method (IJU_SUITE_NOT_STATIC)</a></h3>
-
-
-<p> Class is a JUnit TestCase and implements the suite() method.
- The suite method should be declared as being static, but isn't.</p>
-
-
-<h3><a name="IJU_TEARDOWN_NO_SUPER">IJU: TestCase defines tearDown that doesn't call super.tearDown() (IJU_TEARDOWN_NO_SUPER)</a></h3>
-
-
-<p> Class is a JUnit TestCase and implements the tearDown method. The tearDown method should call
-super.tearDown(), but doesn't.</p>
-
-
-<h3><a name="IL_CONTAINER_ADDED_TO_ITSELF">IL: A collection is added to itself (IL_CONTAINER_ADDED_TO_ITSELF)</a></h3>
-
-
-<p>A collection is added to itself. As a result, computing the hashCode of this
-set will throw a StackOverflowException.
-</p>
-
-
-<h3><a name="IL_INFINITE_LOOP">IL: An apparent infinite loop (IL_INFINITE_LOOP)</a></h3>
-
-
-<p>This loop doesn't seem to have a way to terminate (other than by perhaps
-throwing an exception).</p>
-
-
-<h3><a name="IL_INFINITE_RECURSIVE_LOOP">IL: An apparent infinite recursive loop (IL_INFINITE_RECURSIVE_LOOP)</a></h3>
-
-
-<p>This method unconditionally invokes itself. This would seem to indicate
-an infinite recursive loop that will result in a stack overflow.</p>
-
-
-<h3><a name="IM_MULTIPLYING_RESULT_OF_IREM">IM: Integer multiply of result of integer remainder (IM_MULTIPLYING_RESULT_OF_IREM)</a></h3>
-
-
-<p>
-The code multiplies the result of an integer remaining by an integer constant.
-Be sure you don't have your operator precedence confused. For example
-i % 60 * 1000 is (i % 60) * 1000, not i % (60 * 1000).
-</p>
-
-
-<h3><a name="INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE">INT: Bad comparison of nonnegative value with negative constant (INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE)</a></h3>
-
-
-<p> This code compares a value that is guaranteed to be non-negative with a negative constant.
-</p>
-
-
-<h3><a name="INT_BAD_COMPARISON_WITH_SIGNED_BYTE">INT: Bad comparison of signed byte (INT_BAD_COMPARISON_WITH_SIGNED_BYTE)</a></h3>
-
-
-<p> Signed bytes can only have a value in the range -128 to 127. Comparing
-a signed byte with a value outside that range is vacuous and likely to be incorrect.
-To convert a signed byte <code>b</code> to an unsigned value in the range 0..255,
-use <code>0xff & b</code>
-</p>
-
-
-<h3><a name="IO_APPENDING_TO_OBJECT_OUTPUT_STREAM">IO: Doomed attempt to append to an object output stream (IO_APPENDING_TO_OBJECT_OUTPUT_STREAM)</a></h3>
-
-
- <p>
- This code opens a file in append mode and then wraps the result in an object output stream.
- This won't allow you to append to an existing object output stream stored in a file. If you want to be
- able to append to an object output stream, you need to keep the object output stream open.
- </p>
- <p>The only situation in which opening a file in append mode and the writing an object output stream
- could work is if on reading the file you plan to open it in random access mode and seek to the byte offset
- where the append started.
- </p>
-
- <p>
- TODO: example.
- </p>
-
-
-<h3><a name="IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN">IP: A parameter is dead upon entry to a method but overwritten (IP_PARAMETER_IS_DEAD_BUT_OVERWRITTEN)</a></h3>
-
-
-<p>
-The initial value of this parameter is ignored, and the parameter
-is overwritten here. This often indicates a mistaken belief that
-the write to the parameter will be conveyed back to
-the caller.
-</p>
-
-
-<h3><a name="MF_CLASS_MASKS_FIELD">MF: Class defines field that masks a superclass field (MF_CLASS_MASKS_FIELD)</a></h3>
-
-
-<p> This class defines a field with the same name as a visible
-instance field in a superclass. This is confusing, and
-may indicate an error if methods update or access one of
-the fields when they wanted the other.</p>
-
-
-<h3><a name="MF_METHOD_MASKS_FIELD">MF: Method defines a variable that obscures a field (MF_METHOD_MASKS_FIELD)</a></h3>
-
-
-<p> This method defines a local variable with the same name as a field
-in this class or a superclass. This may cause the method to
-read an uninitialized value from the field, leave the field uninitialized,
-or both.</p>
-
-
-<h3><a name="NP_ALWAYS_NULL">NP: Null pointer dereference (NP_ALWAYS_NULL)</a></h3>
-
-
-<p> A null pointer is dereferenced here. This will lead to a
-<code>NullPointerException</code> when the code is executed.</p>
-
-
-<h3><a name="NP_ALWAYS_NULL_EXCEPTION">NP: Null pointer dereference in method on exception path (NP_ALWAYS_NULL_EXCEPTION)</a></h3>
-
-
-<p> A pointer which is null on an exception path is dereferenced here.
-This will lead to a <code>NullPointerException</code> when the code is executed.
-Note that because FindBugs currently does not prune infeasible exception paths,
-this may be a false warning.</p>
-
-<p> Also note that FindBugs considers the default case of a switch statement to
-be an exception path, since the default case is often infeasible.</p>
-
-
-<h3><a name="NP_ARGUMENT_MIGHT_BE_NULL">NP: Method does not check for null argument (NP_ARGUMENT_MIGHT_BE_NULL)</a></h3>
-
-
- <p>
- A parameter to this method has been identified as a value that should
- always be checked to see whether or not it is null, but it is being dereferenced
- without a preceding null check.
- </p>
-
-
-<h3><a name="NP_CLOSING_NULL">NP: close() invoked on a value that is always null (NP_CLOSING_NULL)</a></h3>
-
-
-<p> close() is being invoked on a value that is always null. If this statement is executed,
-a null pointer exception will occur. But the big risk here you never close
-something that should be closed.
-
-
-<h3><a name="NP_GUARANTEED_DEREF">NP: Null value is guaranteed to be dereferenced (NP_GUARANTEED_DEREF)</a></h3>
-
-
- <p>
- There is a statement or branch that if executed guarantees that
- a value is null at this point, and that
- value that is guaranteed to be dereferenced
- (except on forward paths involving runtime exceptions).
- </p>
-
-
-<h3><a name="NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH">NP: Value is null and guaranteed to be dereferenced on exception path (NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH)</a></h3>
-
-
- <p>
- There is a statement or branch on an exception path
- that if executed guarantees that
- a value is null at this point, and that
- value that is guaranteed to be dereferenced
- (except on forward paths involving runtime exceptions).
- </p>
-
-
-<h3><a name="NP_NONNULL_PARAM_VIOLATION">NP: Method call passes null to a nonnull parameter (NP_NONNULL_PARAM_VIOLATION)</a></h3>
-
-
- <p>
- This method passes a null value as the parameter of a method which
- must be nonnull. Either this parameter has been explicitly marked
- as @Nonnull, or analysis has determined that this parameter is
- always dereferenced.
- </p>
-
-
-<h3><a name="NP_NONNULL_RETURN_VIOLATION">NP: Method may return null, but is declared @NonNull (NP_NONNULL_RETURN_VIOLATION)</a></h3>
-
-
- <p>
- This method may return a null value, but the method (or a superclass method
- which it overrides) is declared to return @NonNull.
- </p>
-
-
-<h3><a name="NP_NULL_INSTANCEOF">NP: A known null value is checked to see if it is an instance of a type (NP_NULL_INSTANCEOF)</a></h3>
-
-
-<p>
-This instanceof test will always return false, since the value being checked is guaranteed to be null.
-Although this is safe, make sure it isn't
-an indication of some misunderstanding or some other logic error.
-</p>
-
-
-<h3><a name="NP_NULL_ON_SOME_PATH">NP: Possible null pointer dereference (NP_NULL_ON_SOME_PATH)</a></h3>
-
-
-<p> There is a branch of statement that, <em>if executed,</em> guarantees that
-a null value will be dereferenced, which
-would generate a <code>NullPointerException</code> when the code is executed.
-Of course, the problem might be that the branch or statement is infeasible and that
-the null pointer exception can't ever be executed; deciding that is beyond the ability of FindBugs.
-</p>
-
-
-<h3><a name="NP_NULL_ON_SOME_PATH_EXCEPTION">NP: Possible null pointer dereference in method on exception path (NP_NULL_ON_SOME_PATH_EXCEPTION)</a></h3>
-
-
-<p> A reference value which is null on some exception control path is
-dereferenced here. This may lead to a <code>NullPointerException</code>
-when the code is executed.
-Note that because FindBugs currently does not prune infeasible exception paths,
-this may be a false warning.</p>
-
-<p> Also note that FindBugs considers the default case of a switch statement to
-be an exception path, since the default case is often infeasible.</p>
-
-
-<h3><a name="NP_NULL_PARAM_DEREF">NP: Method call passes null for nonnull parameter (NP_NULL_PARAM_DEREF)</a></h3>
-
-
- <p>
- This method call passes a null value for a nonnull method parameter.
- Either the parameter is annotated as a parameter that should
- always be nonnull, or analysis has shown that it will always be
- dereferenced.
- </p>
-
-
-<h3><a name="NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS">NP: Method call passes null for nonnull parameter (NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS)</a></h3>
-
-
- <p>
- A possibly-null value is passed at a call site where all known
- target methods require the parameter to be nonnull.
- Either the parameter is annotated as a parameter that should
- always be nonnull, or analysis has shown that it will always be
- dereferenced.
- </p>
-
-
-<h3><a name="NP_NULL_PARAM_DEREF_NONVIRTUAL">NP: Non-virtual method call passes null for nonnull parameter (NP_NULL_PARAM_DEREF_NONVIRTUAL)</a></h3>
-
-
- <p>
- A possibly-null value is passed to a nonnull method parameter.
- Either the parameter is annotated as a parameter that should
- always be nonnull, or analysis has shown that it will always be
- dereferenced.
- </p>
-
-
-<h3><a name="NP_STORE_INTO_NONNULL_FIELD">NP: Store of null value into field annotated NonNull (NP_STORE_INTO_NONNULL_FIELD)</a></h3>
-
-
-<p> A value that could be null is stored into a field that has been annotated as NonNull. </p>
-
-
-<h3><a name="NP_UNWRITTEN_FIELD">NP: Read of unwritten field (NP_UNWRITTEN_FIELD)</a></h3>
-
-
- <p> The program is dereferencing a field that does not seem to ever have a non-null value written to it.
-Dereferencing this value will generate a null pointer exception.
-</p>
-
-
-<h3><a name="NM_BAD_EQUAL">Nm: Class defines equal(Object); should it be equals(Object)? (NM_BAD_EQUAL)</a></h3>
-
-
-<p> This class defines a method <code>equal(Object)</code>. This method does
-not override the <code>equals(Object)</code> method in <code>java.lang.Object</code>,
-which is probably what was intended.</p>
-
-
-<h3><a name="NM_LCASE_HASHCODE">Nm: Class defines hashcode(); should it be hashCode()? (NM_LCASE_HASHCODE)</a></h3>
-
-
- <p> This class defines a method called <code>hashcode()</code>. This method
- does not override the <code>hashCode()</code> method in <code>java.lang.Object</code>,
- which is probably what was intended.</p>
-
-
-<h3><a name="NM_LCASE_TOSTRING">Nm: Class defines tostring(); should it be toString()? (NM_LCASE_TOSTRING)</a></h3>
-
-
- <p> This class defines a method called <code>tostring()</code>. This method
- does not override the <code>toString()</code> method in <code>java.lang.Object</code>,
- which is probably what was intended.</p>
-
-
-<h3><a name="NM_METHOD_CONSTRUCTOR_CONFUSION">Nm: Apparent method/constructor confusion (NM_METHOD_CONSTRUCTOR_CONFUSION)</a></h3>
-
-
- <p> This regular method has the same name as the class it is defined in. It is likely that this was intended to be a constructor.
- If it was intended to be a constructor, remove the declaration of a void return value.
- If you had accidently defined this method, realized the mistake, defined a proper constructor
- but can't get rid of this method due to backwards compatibility, deprecate the method.
-</p>
-
-
-<h3><a name="NM_VERY_CONFUSING">Nm: Very confusing method names (NM_VERY_CONFUSING)</a></h3>
-
-
- <p> The referenced methods have names that differ only by capitalization.
-This is very confusing because if the capitalization were
-identical then one of the methods would override the other.
-</p>
-
-
-<h3><a name="NM_WRONG_PACKAGE">Nm: Method doesn't override method in superclass due to wrong package for parameter (NM_WRONG_PACKAGE)</a></h3>
-
-
- <p> The method in the subclass doesn't override a similar method in a superclass because the type of a parameter doesn't exactly match
-the type of the corresponding parameter in the superclass. For example, if you have:</p>
-
-<blockquote>
-<pre>
-import alpha.Foo;
-public class A {
- public int f(Foo x) { return 17; }
-}
-----
-import beta.Foo;
-public class B extends A {
- public int f(Foo x) { return 42; }
-}
-</pre>
-</blockquote>
-
-<p>The <code>f(Foo)</code> method defined in class <code>B</code> doesn't
-override the
-<code>f(Foo)</code> method defined in class <code>A</code>, because the argument
-types are <code>Foo</code>'s from different packages.
-</p>
-
-
-<h3><a name="QBA_QUESTIONABLE_BOOLEAN_ASSIGNMENT">QBA: Method assigns boolean literal in boolean expression (QBA_QUESTIONABLE_BOOLEAN_ASSIGNMENT)</a></h3>
-
-
- <p>
- This method assigns a literal boolean value (true or false) to a boolean variable inside
- an if or while expression. Most probably this was supposed to be a boolean comparison using
- ==, not an assignment using =.
- </p>
-
-
-<h3><a name="RC_REF_COMPARISON">RC: Suspicious reference comparison (RC_REF_COMPARISON)</a></h3>
-
-
-<p> This method compares two reference values using the == or != operator,
-where the correct way to compare instances of this type is generally
-with the equals() method.
-It is possible to create distinct instances that are equal but do not compare as == since
-they are different objects.
-Examples of classes which should generally
-not be compared by reference are java.lang.Integer, java.lang.Float, etc.</p>
-
-
-<h3><a name="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">RCN: Nullcheck of value previously dereferenced (RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE)</a></h3>
-
-
-<p> A value is checked here to see whether it is null, but this value can't
-be null because it was previously dereferenced and if it were null a null pointer
-exception would have occurred at the earlier dereference.
-Essentially, this code and the previous dereference
-disagree as to whether this value is allowed to be null. Either the check is redundant
-or the previous dereference is erroneous.</p>
-
-
-<h3><a name="RE_BAD_SYNTAX_FOR_REGULAR_EXPRESSION">RE: Invalid syntax for regular expression (RE_BAD_SYNTAX_FOR_REGULAR_EXPRESSION)</a></h3>
-
-
-<p>
-The code here uses a regular expression that is invalid according to the syntax
-for regular expressions. This statement will throw a PatternSyntaxException when
-executed.
-</p>
-
-
-<h3><a name="RE_CANT_USE_FILE_SEPARATOR_AS_REGULAR_EXPRESSION">RE: File.separator used for regular expression (RE_CANT_USE_FILE_SEPARATOR_AS_REGULAR_EXPRESSION)</a></h3>
-
-
-<p>
-The code here uses <code>File.separator</code>
-where a regular expression is required. This will fail on Windows
-platforms, where the <code>File.separator</code> is a backslash, which is interpreted in a
-regular expression as an escape character. Amoung other options, you can just use
-<code>File.separatorChar=='\\' ? "\\\\" : File.separator</code> instead of
-<code>File.separator</code>
-
-</p>
-
-
-<h3><a name="RE_POSSIBLE_UNINTENDED_PATTERN">RE: "." used for regular expression (RE_POSSIBLE_UNINTENDED_PATTERN)</a></h3>
-
-
-<p>
-A String function is being invoked and "." is being passed
-to a parameter that takes a regular expression as an argument. Is this what you intended?
-For example
-s.replaceAll(".", "/") will return a String in which <em>every</em>
-character has been replaced by a / character,
-and s.split(".") <em>always</em> returns a zero length array of String.
-</p>
-
-
-<h3><a name="RV_01_TO_INT">RV: Random value from 0 to 1 is coerced to the integer 0 (RV_01_TO_INT)</a></h3>
-
-
- <p>A random value from 0 to 1 is being coerced to the integer value 0. You probably
-want to multiple the random value by something else before coercing it to an integer, or use the <code>Random.nextInt(n)</code> method.
-</p>
-
-
-<h3><a name="RV_ABSOLUTE_VALUE_OF_HASHCODE">RV: Bad attempt to compute absolute value of signed 32-bit hashcode (RV_ABSOLUTE_VALUE_OF_HASHCODE)</a></h3>
-
-
-<p> This code generates a hashcode and then computes
-the absolute value of that hashcode. If the hashcode
-is <code>Integer.MIN_VALUE</code>, then the result will be negative as well (since
-<code>Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE</code>).
-</p>
-<p>One out of 2^32 strings have a hashCode of Integer.MIN_VALUE,
-including "polygenelubricants" "GydZG_" and ""DESIGNING WORKHOUSES".
-</p>
-
-
-<h3><a name="RV_ABSOLUTE_VALUE_OF_RANDOM_INT">RV: Bad attempt to compute absolute value of signed 32-bit random integer (RV_ABSOLUTE_VALUE_OF_RANDOM_INT)</a></h3>
-
-
-<p> This code generates a random signed integer and then computes
-the absolute value of that random integer. If the number returned by the random number
-generator is <code>Integer.MIN_VALUE</code>, then the result will be negative as well (since
-<code>Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE</code>).
-</p>
-
-
-<h3><a name="RV_EXCEPTION_NOT_THROWN">RV: Exception created and dropped rather than thrown (RV_EXCEPTION_NOT_THROWN)</a></h3>
-
-
- <p> This code creates an exception (or error) object, but doesn't do anything with it. For example,
-something like </p>
-<blockquote>
-<pre>
-if (x < 0)
- new IllegalArgumentException("x must be nonnegative");
-</pre>
-</blockquote>
-<p>It was probably the intent of the programmer to throw the created exception:</p>
-<blockquote>
-<pre>
-if (x < 0)
- throw new IllegalArgumentException("x must be nonnegative");
-</pre>
-</blockquote>
-
-
-<h3><a name="RV_RETURN_VALUE_IGNORED">RV: Method ignores return value (RV_RETURN_VALUE_IGNORED)</a></h3>
-
-
- <p> The return value of this method should be checked. One common
-cause of this warning is to invoke a method on an immutable object,
-thinking that it updates the object. For example, in the following code
-fragment,</p>
-<blockquote>
-<pre>
-String dateString = getHeaderField(name);
-dateString.trim();
-</pre>
-</blockquote>
-<p>the programmer seems to be thinking that the trim() method will update
-the String referenced by dateString. But since Strings are immutable, the trim()
-function returns a new String value, which is being ignored here. The code
-should be corrected to: </p>
-<blockquote>
-<pre>
-String dateString = getHeaderField(name);
-dateString = dateString.trim();
-</pre>
-</blockquote>
-
-
-<h3><a name="RpC_REPEATED_CONDITIONAL_TEST">RpC: Repeated conditional tests (RpC_REPEATED_CONDITIONAL_TEST)</a></h3>
-
-
-<p>The code contains a conditional test is performed twice, one right after the other
-(e.g., <code>x == 0 || x == 0</code>). Perhaps the second occurrence is intended to be something else
-(e.g., <code>x == 0 || y == 0</code>).
-</p>
-
-
-<h3><a name="SA_FIELD_DOUBLE_ASSIGNMENT">SA: Double assignment of field (SA_FIELD_DOUBLE_ASSIGNMENT)</a></h3>
-
-
-<p> This method contains a double assignment of a field; e.g.
-</p>
-<pre>
- int x,y;
- public void foo() {
- x = x = 17;
- }
-</pre>
-<p>Assigning to a field twice is useless, and may indicate a logic error or typo.</p>
-
-
-<h3><a name="SA_FIELD_SELF_ASSIGNMENT">SA: Self assignment of field (SA_FIELD_SELF_ASSIGNMENT)</a></h3>
-
-
-<p> This method contains a self assignment of a field; e.g.
-</p>
-<pre>
- int x;
- public void foo() {
- x = x;
- }
-</pre>
-<p>Such assignments are useless, and may indicate a logic error or typo.</p>
-
-
-<h3><a name="SA_FIELD_SELF_COMPARISON">SA: Self comparison of field with itself (SA_FIELD_SELF_COMPARISON)</a></h3>
-
-
-<p> This method compares a field with itself, and may indicate a typo or
-a logic error. Make sure that you are comparing the right things.
-</p>
-
-
-<h3><a name="SA_FIELD_SELF_COMPUTATION">SA: Nonsensical self computation involving a field (e.g., x & x) (SA_FIELD_SELF_COMPUTATION)</a></h3>
-
-
-<p> This method performs a nonsensical computation of a field with another
-reference to the same field (e.g., x&x or x-x). Because of the nature
-of the computation, this operation doesn't seem to make sense,
-and may indicate a typo or
-a logic error. Double check the computation.
-</p>
-
-
-<h3><a name="SA_LOCAL_SELF_COMPARISON">SA: Self comparison of value with itself (SA_LOCAL_SELF_COMPARISON)</a></h3>
-
-
-<p> This method compares a local variable with itself, and may indicate a typo or
-a logic error. Make sure that you are comparing the right things.
-</p>
-
-
-<h3><a name="SA_LOCAL_SELF_COMPUTATION">SA: Nonsensical self computation involving a variable (e.g., x & x) (SA_LOCAL_SELF_COMPUTATION)</a></h3>
-
-
-<p> This method performs a nonsensical computation of a local variable with another
-reference to the same variable (e.g., x&x or x-x). Because of the nature
-of the computation, this operation doesn't seem to make sense,
-and may indicate a typo or
-a logic error. Double check the computation.
-</p>
-
-
-<h3><a name="SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH">SF: Dead store due to switch statement fall through (SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH)</a></h3>
-
-
- <p> A value stored in the previous switch case is overwritten here due to a switch fall through. It is likely that
- you forgot to put a break or return at the end of the previous case.
-</p>
-
-
-<h3><a name="SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH_TO_THROW">SF: Dead store due to switch statement fall through to throw (SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH_TO_THROW)</a></h3>
-
-
- <p> A value stored in the previous switch case is ignored here due to a switch fall through to a place where
- an exception is thrown. It is likely that
- you forgot to put a break or return at the end of the previous case.
-</p>
-
-
-<h3><a name="SIC_THREADLOCAL_DEADLY_EMBRACE">SIC: Deadly embrace of non-static inner class and thread local (SIC_THREADLOCAL_DEADLY_EMBRACE)</a></h3>
-
-
- <p> This class is an inner class, but should probably be a static inner class.
- As it is, there is a serious danger of a deadly embrace between the inner class
- and the thread local in the outer class. Because the inner class isn't static,
- it retains a reference to the outer class.
- If the thread local contains a reference to an instance of the inner
- class, the inner and outer instance will both be reachable
- and not eligible for garbage collection.
-</p>
-
-
-<h3><a name="SIO_SUPERFLUOUS_INSTANCEOF">SIO: Unnecessary type check done using instanceof operator (SIO_SUPERFLUOUS_INSTANCEOF)</a></h3>
-
-
-<p> Type check performed using the instanceof operator where it can be statically determined whether the object
-is of the type requested. </p>
-
-
-<h3><a name="SQL_BAD_PREPARED_STATEMENT_ACCESS">SQL: Method attempts to access a prepared statement parameter with index 0 (SQL_BAD_PREPARED_STATEMENT_ACCESS)</a></h3>
-
-
-<p> A call to a setXXX method of a prepared statement was made where the
-parameter index is 0. As parameter indexes start at index 1, this is always a mistake.</p>
-
-
-<h3><a name="SQL_BAD_RESULTSET_ACCESS">SQL: Method attempts to access a result set field with index 0 (SQL_BAD_RESULTSET_ACCESS)</a></h3>
-
-
-<p> A call to getXXX or updateXXX methods of a result set was made where the
-field index is 0. As ResultSet fields start at index 1, this is always a mistake.</p>
-
-
-<h3><a name="STI_INTERRUPTED_ON_CURRENTTHREAD">STI: Unneeded use of currentThread() call, to call interrupted() (STI_INTERRUPTED_ON_CURRENTTHREAD)</a></h3>
-
-
-<p>
-This method invokes the Thread.currentThread() call, just to call the interrupted() method. As interrupted() is a
-static method, is more simple and clear to use Thread.interrupted().
-</p>
-
-
-<h3><a name="STI_INTERRUPTED_ON_UNKNOWNTHREAD">STI: Static Thread.interrupted() method invoked on thread instance (STI_INTERRUPTED_ON_UNKNOWNTHREAD)</a></h3>
-
-
-<p>
-This method invokes the Thread.interrupted() method on a Thread object that appears to be a Thread object that is
-not the current thread. As the interrupted() method is static, the interrupted method will be called on a different
-object than the one the author intended.
-</p>
-
-
-<h3><a name="SE_METHOD_MUST_BE_PRIVATE">Se: Method must be private in order for serialization to work (SE_METHOD_MUST_BE_PRIVATE)</a></h3>
-
-
- <p> This class implements the <code>Serializable</code> interface, and defines a method
- for custom serialization/deserialization. But since that method isn't declared private,
- it will be silently ignored by the serialization/deserialization API.</p>
-
-
-<h3><a name="SE_READ_RESOLVE_IS_STATIC">Se: The readResolve method must not be declared as a static method. (SE_READ_RESOLVE_IS_STATIC)</a></h3>
-
-
- <p> In order for the readResolve method to be recognized by the serialization
-mechanism, it must not be declared as a static method.
-</p>
-
-
-<h3><a name="TQ_ALWAYS_VALUE_USED_WHERE_NEVER_REQUIRED">TQ: Value annotated as carrying a type qualifier used where a value that must not carry that qualifier is required (TQ_ALWAYS_VALUE_USED_WHERE_NEVER_REQUIRED)</a></h3>
-
-
- <p>
- A value specified as carrying a type qualifier annotation is
- consumed in a location or locations requiring that the value not
- carry that annotation.
- </p>
-
- <p>
- More precisely, a value annotated with a type qualifier specifying when=ALWAYS
- is guaranteed to reach a use or uses where the same type qualifier specifies when=NEVER.
- </p>
-
- <p>
- For example, say that @NonNegative is a nickname for
- the type qualifier annotation @Negative(when=When.NEVER).
- The following code will generate this warning because
- the return statement requires a @NonNegative value,
- but receives one that is marked as @Negative.
- </p>
- <blockquote>
-<pre>
-public @NonNegative Integer example(@Negative Integer value) {
- return value;
-}
-</pre>
- </blockquote>
-
-
-<h3><a name="TQ_MAYBE_SOURCE_VALUE_REACHES_ALWAYS_SINK">TQ: Value that might not carry a type qualifier is always used in a way requires that type qualifier (TQ_MAYBE_SOURCE_VALUE_REACHES_ALWAYS_SINK)</a></h3>
-
-
- <p>
- A value that is annotated as possibility not being an instance of
- the values denoted by the type qualifier, and the value is guaranteed to be used
- in a way that requires values denoted by that type qualifier.
- </p>
-
-
-<h3><a name="TQ_MAYBE_SOURCE_VALUE_REACHES_NEVER_SINK">TQ: Value that might carry a type qualifier is always used in a way prohibits it from having that type qualifier (TQ_MAYBE_SOURCE_VALUE_REACHES_NEVER_SINK)</a></h3>
-
-
- <p>
- A value that is annotated as possibility being an instance of
- the values denoted by the type qualifier, and the value is guaranteed to be used
- in a way that prohibits values denoted by that type qualifier.
- </p>
-
-
-<h3><a name="TQ_NEVER_VALUE_USED_WHERE_ALWAYS_REQUIRED">TQ: Value annotated as never carrying a type qualifier used where value carrying that qualifier is required (TQ_NEVER_VALUE_USED_WHERE_ALWAYS_REQUIRED)</a></h3>
-
-
- <p>
- A value specified as not carrying a type qualifier annotation is guaranteed
- to be consumed in a location or locations requiring that the value does
- carry that annotation.
- </p>
-
- <p>
- More precisely, a value annotated with a type qualifier specifying when=NEVER
- is guaranteed to reach a use or uses where the same type qualifier specifies when=ALWAYS.
- </p>
-
- <p>
- TODO: example
- </p>
-
-
-<h3><a name="UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS">UMAC: Uncallable method defined in anonymous class (UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS)</a></h3>
-
-
-<p> This anonymous class defined a method that is not directly invoked and does not override
-a method in a superclass. Since methods in other classes cannot directly invoke methods
-declared in an anonymous class, it seems that this method is uncallable. The method
-might simply be dead code, but it is also possible that the method is intended to
-override a method declared in a superclass, and due to an typo or other error the method does not,
-in fact, override the method it is intended to.
-</p>
-
-
-<h3><a name="UR_UNINIT_READ">UR: Uninitialized read of field in constructor (UR_UNINIT_READ)</a></h3>
-
-
- <p> This constructor reads a field which has not yet been assigned a value.
- This is often caused when the programmer mistakenly uses the field instead
- of one of the constructor's parameters.</p>
-
-
-<h3><a name="UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR">UR: Uninitialized read of field method called from constructor of superclass (UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR)</a></h3>
-
-
- <p> This method is invoked in the constructor of of the superclass. At this point,
- the fields of the class have not yet initialized.</p>
-<p>To make this more concrete, consider the following classes:</p>
-<pre>abstract class A {
- int hashCode;
- abstract Object getValue();
- A() {
- hashCode = getValue().hashCode();
- }
- }
-class B extends A {
- Object value;
- B(Object v) {
- this.value = v;
- }
- Object getValue() {
- return value;
- }
- }</pre>
-<p>When a <code>B</code> is constructed,
-the constructor for the <code>A</code> class is invoked
-<em>before</em> the constructor for <code>B</code> sets <code>value</code>.
-Thus, when the constructor for <code>A</code> invokes <code>getValue</code>,
-an uninitialized value is read for <code>value</code>
-</p>
-
-
-<h3><a name="DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY">USELESS_STRING: Invocation of toString on an array (DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY)</a></h3>
-
-
-<p>
-The code invokes toString on an (anonymous) array. Calling toString on an array generates a fairly useless result
-such as [C@16f0472. Consider using Arrays.toString to convert the array into a readable
-String that gives the contents of the array. See Programming Puzzlers, chapter 3, puzzle 12.
-</p>
-
-
-<h3><a name="DMI_INVOKING_TOSTRING_ON_ARRAY">USELESS_STRING: Invocation of toString on an array (DMI_INVOKING_TOSTRING_ON_ARRAY)</a></h3>
-
-
-<p>
-The code invokes toString on an array, which will generate a fairly useless result
-such as [C@16f0472. Consider using Arrays.toString to convert the array into a readable
-String that gives the contents of the array. See Programming Puzzlers, chapter 3, puzzle 12.
-</p>
-
-
-<h3><a name="VA_FORMAT_STRING_BAD_CONVERSION_FROM_ARRAY">USELESS_STRING: Array formatted in useless way using format string (VA_FORMAT_STRING_BAD_CONVERSION_FROM_ARRAY)</a></h3>
-
-
-<p>
-One of the arguments being formatted with a format string is an array. This will be formatted
-using a fairly useless format, such as [I@304282, which doesn't actually show the contents
-of the array.
-Consider wrapping the array using <code>Arrays.asList(...)</code> before handling it off to a formatted.
-</p>
-
-
-<h3><a name="UWF_NULL_FIELD">UwF: Field only ever set to null (UWF_NULL_FIELD)</a></h3>
-
-
- <p> All writes to this field are of the constant value null, and thus
-all reads of the field will return null.
-Check for errors, or remove it if it is useless.</p>
-
-
-<h3><a name="UWF_UNWRITTEN_FIELD">UwF: Unwritten field (UWF_UNWRITTEN_FIELD)</a></h3>
-
-
- <p> This field is never written. All reads of it will return the default
-value. Check for errors (should it have been initialized?), or remove it if it is useless.</p>
-
-
-<h3><a name="VA_PRIMITIVE_ARRAY_PASSED_TO_OBJECT_VARARG">VA: Primitive array passed to function expecting a variable number of object arguments (VA_PRIMITIVE_ARRAY_PASSED_TO_OBJECT_VARARG)</a></h3>
-
-
-<p>
-This code passes a primitive array to a function that takes a variable number of object arguments.
-This creates an array of length one to hold the primitive array and passes it to the function.
-</p>
-
-
-<h3><a name="LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE">LG: Potential lost logger changes due to weak reference in OpenJDK (LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE)</a></h3>
-
-
-<p>OpenJDK introduces a potential incompatibility.
- In particular, the java.util.logging.Logger behavior has
- changed. Instead of using strong references, it now uses weak references
- internally. That's a reasonable change, but unfortunately some code relies on
- the old behavior - when changing logger configuration, it simply drops the
- logger reference. That means that the garbage collector is free to reclaim
- that memory, which means that the logger configuration is lost. For example,
-consider:
-</p>
-
-<p><pre>public static void initLogging() throws Exception {
- Logger logger = Logger.getLogger("edu.umd.cs");
- logger.addHandler(new FileHandler()); // call to change logger configuration
- logger.setUseParentHandlers(false); // another call to change logger configuration
-}</pre></p>
-
-<p>The logger reference is lost at the end of the method (it doesn't
-escape the method), so if you have a garbage collection cycle just
-after the call to initLogging, the logger configuration is lost
-(because Logger only keeps weak references).</p>
-
-<p><pre>public static void main(String[] args) throws Exception {
- initLogging(); // adds a file handler to the logger
- System.gc(); // logger configuration lost
- Logger.getLogger("edu.umd.cs").info("Some message"); // this isn't logged to the file as expected
-}</pre></p>
-<p><em>Ulf Ochsenfahrt and Eric Fellheimer</em></p>
-
-
-<h3><a name="OBL_UNSATISFIED_OBLIGATION">OBL: Method may fail to clean up stream or resource (OBL_UNSATISFIED_OBLIGATION)</a></h3>
-
-
- <p>
- This method may fail to clean up (close, dispose of) a stream,
- database object, or other
- resource requiring an explicit cleanup operation.
- </p>
-
- <p>
- In general, if a method opens a stream or other resource,
- the method should use a try/finally block to ensure that
- the stream or resource is cleaned up before the method
- returns.
- </p>
-
- <p>
- This bug pattern is essentially the same as the
- OS_OPEN_STREAM and ODR_OPEN_DATABASE_RESOURCE
- bug patterns, but is based on a different
- (and hopefully better) static analysis technique.
- We are interested is getting feedback about the
- usefulness of this bug pattern.
- To send feedback, either:
- </p>
- <ul>
- <li>send email to findbugs@cs.umd.edu</li>
- <li>file a bug report: <a href="http://findbugs.sourceforge.net/reportingBugs.html">http://findbugs.sourceforge.net/reportingBugs.html</a></li>
- </ul>
-
- <p>
- In particular,
- the false-positive suppression heuristics for this
- bug pattern have not been extensively tuned, so
- reports about false positives are helpful to us.
- </p>
-
- <p>
- See Weimer and Necula, <i>Finding and Preventing Run-Time Error Handling Mistakes</i>, for
- a description of the analysis technique.
- </p>
-
-
-<h3><a name="DM_CONVERT_CASE">Dm: Consider using Locale parameterized version of invoked method (DM_CONVERT_CASE)</a></h3>
-
-
- <p> A String is being converted to upper or lowercase, using the platform's default encoding. This may
- result in improper conversions when used with international characters. Use the </p>
- <ul>
- <li>String.toUpperCase( Locale l )</li>
- <li>String.toLowerCase( Locale l )</li>
- </ul>
- <p>versions instead.</p>
-
-
-<h3><a name="EI_EXPOSE_REP">EI: May expose internal representation by returning reference to mutable object (EI_EXPOSE_REP)</a></h3>
-
-
- <p> Returning a reference to a mutable object value stored in one of the object's fields
- exposes the internal representation of the object.
- If instances
- are accessed by untrusted code, and unchecked changes to
- the mutable object would compromise security or other
- important properties, you will need to do something different.
- Returning a new copy of the object is better approach in many situations.</p>
-
-
-<h3><a name="EI_EXPOSE_REP2">EI2: May expose internal representation by incorporating reference to mutable object (EI_EXPOSE_REP2)</a></h3>
-
-
- <p> This code stores a reference to an externally mutable object into the
- internal representation of the object.
- If instances
- are accessed by untrusted code, and unchecked changes to
- the mutable object would compromise security or other
- important properties, you will need to do something different.
- Storing a copy of the object is better approach in many situations.</p>
-
-
-<h3><a name="FI_PUBLIC_SHOULD_BE_PROTECTED">FI: Finalizer should be protected, not public (FI_PUBLIC_SHOULD_BE_PROTECTED)</a></h3>
-
-
- <p> A class's <code>finalize()</code> method should have protected access,
- not public.</p>
-
-
-<h3><a name="EI_EXPOSE_STATIC_REP2">MS: May expose internal static state by storing a mutable object into a static field (EI_EXPOSE_STATIC_REP2)</a></h3>
-
-
- <p> This code stores a reference to an externally mutable object into a static
- field.
- If unchecked changes to
- the mutable object would compromise security or other
- important properties, you will need to do something different.
- Storing a copy of the object is better approach in many situations.</p>
-
-
-<h3><a name="MS_CANNOT_BE_FINAL">MS: Field isn't final and can't be protected from malicious code (MS_CANNOT_BE_FINAL)</a></h3>
-
-
- <p>
- A mutable static field could be changed by malicious code or
- by accident from another package.
- Unfortunately, the way the field is used doesn't allow
- any easy fix to this problem.</p>
-
-
-<h3><a name="MS_EXPOSE_REP">MS: Public static method may expose internal representation by returning array (MS_EXPOSE_REP)</a></h3>
-
-
- <p> A public static method returns a reference to
- an array that is part of the static state of the class.
- Any code that calls this method can freely modify
- the underlying array.
- One fix is to return a copy of the array.</p>
-
-
-<h3><a name="MS_FINAL_PKGPROTECT">MS: Field should be both final and package protected (MS_FINAL_PKGPROTECT)</a></h3>
-
-
- <p>
- A mutable static field could be changed by malicious code or
- by accident from another package.
- The field could be made package protected and/or made final
- to avoid
- this vulnerability.</p>
-
-
-<h3><a name="MS_MUTABLE_ARRAY">MS: Field is a mutable array (MS_MUTABLE_ARRAY)</a></h3>
-
-
-<p> A final static field references an array
- and can be accessed by malicious code or
- by accident from another package.
- This code can freely modify the contents of the array.</p>
-
-
-<h3><a name="MS_MUTABLE_HASHTABLE">MS: Field is a mutable Hashtable (MS_MUTABLE_HASHTABLE)</a></h3>
-
-
- <p>A final static field references a Hashtable
- and can be accessed by malicious code or
- by accident from another package.
- This code can freely modify the contents of the Hashtable.</p>
-
-
-<h3><a name="MS_OOI_PKGPROTECT">MS: Field should be moved out of an interface and made package protected (MS_OOI_PKGPROTECT)</a></h3>
-
-
-<p>
- A final static field that is
-defined in an interface references a mutable
- object such as an array or hashtable.
- This mutable object could
- be changed by malicious code or
- by accident from another package.
- To solve this, the field needs to be moved to a class
- and made package protected
- to avoid
- this vulnerability.</p>
-
-
-<h3><a name="MS_PKGPROTECT">MS: Field should be package protected (MS_PKGPROTECT)</a></h3>
-
-
- <p> A mutable static field could be changed by malicious code or
- by accident.
- The field could be made package protected to avoid
- this vulnerability.</p>
-
-
-<h3><a name="MS_SHOULD_BE_FINAL">MS: Field isn't final but should be (MS_SHOULD_BE_FINAL)</a></h3>
-
-
- <p>
- A mutable static field could be changed by malicious code or
- by accident from another package.
- The field could be made final to avoid
- this vulnerability.</p>
-
-
-<h3><a name="DC_DOUBLECHECK">DC: Possible double check of field (DC_DOUBLECHECK)</a></h3>
-
-
- <p> This method may contain an instance of double-checked locking.
- This idiom is not correct according to the semantics of the Java memory
- model. For more information, see the web page
- <a href="http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html"
- >http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html</a>.</p>
-
-
-<h3><a name="DL_SYNCHRONIZATION_ON_BOOLEAN">DL: Synchronization on Boolean could lead to deadlock (DL_SYNCHRONIZATION_ON_BOOLEAN)</a></h3>
-
-
- <p> The code synchronizes on a boxed primitive constant, such as an Boolean.
-<pre>
-private static Boolean inited = Boolean.FALSE;
-...
- synchronized(inited) {
- if (!inited) {
- init();
- inited = Boolean.TRUE;
- }
- }
-...
-</pre>
-</p>
-<p>Since there normally exist only two Boolean objects, this code could be synchronizing on the same object as other, unrelated code, leading to unresponsiveness
-and possible deadlock</p>
-
-
-<h3><a name="DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE">DL: Synchronization on boxed primitive could lead to deadlock (DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE)</a></h3>
-
-
- <p> The code synchronizes on a boxed primitive constant, such as an Integer.
-<pre>
-private static Integer count = 0;
-...
- synchronized(count) {
- count++;
- }
-...
-</pre>
-</p>
-<p>Since Integer objects can be cached and shared,
-this code could be synchronizing on the same object as other, unrelated code, leading to unresponsiveness
-and possible deadlock</p>
-
-
-<h3><a name="DL_SYNCHRONIZATION_ON_SHARED_CONSTANT">DL: Synchronization on interned String could lead to deadlock (DL_SYNCHRONIZATION_ON_SHARED_CONSTANT)</a></h3>
-
-
- <p> The code synchronizes on interned String.
-<pre>
-private static String LOCK = "LOCK";
-...
- synchronized(LOCK) { ...}
-...
-</pre>
-</p>
-<p>Constant Strings are interned and shared across all other classes loaded by the JVM. Thus, this could
-is locking on something that other code might also be locking. This could result in very strange and hard to diagnose
-blocking and deadlock behavior. See <a href="http://www.javalobby.org/java/forums/t96352.html">http://www.javalobby.org/java/forums/t96352.html</a> and <a href="http://jira.codehaus.org/browse/JETTY-352">http://jira.codehaus.org/browse/JETTY-352</a>.
-</p>
-
-
-<h3><a name="DL_SYNCHRONIZATION_ON_UNSHARED_BOXED_PRIMITIVE">DL: Synchronization on boxed primitive values (DL_SYNCHRONIZATION_ON_UNSHARED_BOXED_PRIMITIVE)</a></h3>
-
-
- <p> The code synchronizes on an apparently unshared boxed primitive,
-such as an Integer.
-<pre>
-private static final Integer fileLock = new Integer(1);
-...
- synchronized(fileLock) {
- .. do something ..
- }
-...
-</pre>
-</p>
-<p>It would be much better, in this code, to redeclare fileLock as
-<pre>
-private static final Object fileLock = new Object();
-</pre>
-The existing code might be OK, but it is confusing and a
-future refactoring, such as the "Remove Boxing" refactoring in IntelliJ,
-might replace this with the use of an interned Integer object shared
-throughout the JVM, leading to very confusing behavior and potential deadlock.
-</p>
-
-
-<h3><a name="DM_MONITOR_WAIT_ON_CONDITION">Dm: Monitor wait() called on Condition (DM_MONITOR_WAIT_ON_CONDITION)</a></h3>
-
-
- <p>
- This method calls <code>wait()</code> on a
- <code>java.util.concurrent.locks.Condition</code> object.
- Waiting for a <code>Condition</code> should be done using one of the <code>await()</code>
- methods defined by the <code>Condition</code> interface.
- </p>
-
-
-<h3><a name="DM_USELESS_THREAD">Dm: A thread was created using the default empty run method (DM_USELESS_THREAD)</a></h3>
-
-
- <p>This method creates a thread without specifying a run method either by deriving from the Thread class, or
- by passing a Runnable object. This thread, then, does nothing but waste time.
-</p>
-
-
-<h3><a name="ESync_EMPTY_SYNC">ESync: Empty synchronized block (ESync_EMPTY_SYNC)</a></h3>
-
-
- <p> The code contains an empty synchronized block:</p>
-<pre>
-synchronized() {}
-</pre>
-<p>Empty synchronized blocks are far more subtle and hard to use correctly
-than most people recognize, and empty synchronized blocks
-are almost never a better solution
-than less contrived solutions.
-</p>
-
-
-<h3><a name="IS2_INCONSISTENT_SYNC">IS: Inconsistent synchronization (IS2_INCONSISTENT_SYNC)</a></h3>
-
-
- <p> The fields of this class appear to be accessed inconsistently with respect
- to synchronization. This bug report indicates that the bug pattern detector
- judged that
- </p>
- <ul>
- <li> The class contains a mix of locked and unlocked accesses,</li>
- <li> At least one locked access was performed by one of the class's own methods, and</li>
- <li> The number of unsynchronized field accesses (reads and writes) was no more than
- one third of all accesses, with writes being weighed twice as high as reads</li>
- </ul>
-
- <p> A typical bug matching this bug pattern is forgetting to synchronize
- one of the methods in a class that is intended to be thread-safe.</p>
-
- <p> You can select the nodes labeled "Unsynchronized access" to show the
- code locations where the detector believed that a field was accessed
- without synchronization.</p>
-
- <p> Note that there are various sources of inaccuracy in this detector;
- for example, the detector cannot statically detect all situations in which
- a lock is held. Also, even when the detector is accurate in
- distinguishing locked vs. unlocked accesses, the code in question may still
- be correct.</p>
-
-
-
-<h3><a name="IS_FIELD_NOT_GUARDED">IS: Field not guarded against concurrent access (IS_FIELD_NOT_GUARDED)</a></h3>
-
-
- <p> This field is annotated with net.jcip.annotations.GuardedBy,
-but can be accessed in a way that seems to violate the annotation.</p>
-
-
-<h3><a name="JLM_JSR166_LOCK_MONITORENTER">JLM: Synchronization performed on Lock (JLM_JSR166_LOCK_MONITORENTER)</a></h3>
-
-
-<p> This method performs synchronization an object that implements
-java.util.concurrent.locks.Lock. Such an object is locked/unlocked
-using
-<code>acquire()</code>/<code>release()</code> rather
-than using the <code>synchronized (...)</code> construct.
-</p>
-
-
-<h3><a name="LI_LAZY_INIT_STATIC">LI: Incorrect lazy initialization of static field (LI_LAZY_INIT_STATIC)</a></h3>
-
-
-<p> This method contains an unsynchronized lazy initialization of a non-volatile static field.
-Because the compiler or processor may reorder instructions,
-threads are not guaranteed to see a completely initialized object,
-<em>if the method can be called by multiple threads</em>.
-You can make the field volatile to correct the problem.
-For more information, see the
-<a href="http://www.cs.umd.edu/~pugh/java/memoryModel/">Java Memory Model web site</a>.
-</p>
-
-
-<h3><a name="LI_LAZY_INIT_UPDATE_STATIC">LI: Incorrect lazy initialization and update of static field (LI_LAZY_INIT_UPDATE_STATIC)</a></h3>
-
-
-<p> This method contains an unsynchronized lazy initialization of a static field.
-After the field is set, the object stored into that location is further updated or accessed.
-The setting of the field is visible to other threads as soon as it is set. If the
-futher accesses in the method that set the field serve to initialize the object, then
-you have a <em>very serious</em> multithreading bug, unless something else prevents
-any other thread from accessing the stored object until it is fully initialized.
-</p>
-<p>Even if you feel confident that the method is never called by multiple
-threads, it might be better to not set the static field until the value
-you are setting it to is fully populated/initialized.
-
-
-<h3><a name="ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD">ML: Synchronization on field in futile attempt to guard that field (ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD)</a></h3>
-
-
- <p> This method synchronizes on a field in what appears to be an attempt
-to guard against simultaneous updates to that field. But guarding a field
-gets a lock on the referenced object, not on the field. This may not
-provide the mutual exclusion you need, and other threads might
-be obtaining locks on the referenced objects (for other purposes). An example
-of this pattern would be:
-
-<p><pre>
-private Long myNtfSeqNbrCounter = new Long(0);
-private Long getNotificationSequenceNumber() {
- Long result = null;
- synchronized(myNtfSeqNbrCounter) {
- result = new Long(myNtfSeqNbrCounter.longValue() + 1);
- myNtfSeqNbrCounter = new Long(result.longValue());
- }
- return result;
- }
-</pre>
-
-
-</p>
-
-
-<h3><a name="ML_SYNC_ON_UPDATED_FIELD">ML: Method synchronizes on an updated field (ML_SYNC_ON_UPDATED_FIELD)</a></h3>
-
-
- <p> This method synchronizes on an object
- referenced from a mutable field.
- This is unlikely to have useful semantics, since different
-threads may be synchronizing on different objects.</p>
-
-
-<h3><a name="MSF_MUTABLE_SERVLET_FIELD">MSF: Mutable servlet field (MSF_MUTABLE_SERVLET_FIELD)</a></h3>
-
-
-<p>A web server generally only creates one instance of servlet or jsp class (i.e., treats
-the class as a Singleton),
-and will
-have multiple threads invoke methods on that instance to service multiple
-simultaneous requests.
-Thus, having a mutable instance field generally creates race conditions.
-
-
-<h3><a name="MWN_MISMATCHED_NOTIFY">MWN: Mismatched notify() (MWN_MISMATCHED_NOTIFY)</a></h3>
-
-
-<p> This method calls Object.notify() or Object.notifyAll() without obviously holding a lock
-on the object. Calling notify() or notifyAll() without a lock held will result in
-an <code>IllegalMonitorStateException</code> being thrown.</p>
-
-
-<h3><a name="MWN_MISMATCHED_WAIT">MWN: Mismatched wait() (MWN_MISMATCHED_WAIT)</a></h3>
-
-
-<p> This method calls Object.wait() without obviously holding a lock
-on the object. Calling wait() without a lock held will result in
-an <code>IllegalMonitorStateException</code> being thrown.</p>
-
-
-<h3><a name="NN_NAKED_NOTIFY">NN: Naked notify (NN_NAKED_NOTIFY)</a></h3>
-
-
- <p> A call to <code>notify()</code> or <code>notifyAll()</code>
- was made without any (apparent) accompanying
- modification to mutable object state. In general, calling a notify
- method on a monitor is done because some condition another thread is
- waiting for has become true. However, for the condition to be meaningful,
- it must involve a heap object that is visible to both threads.</p>
-
- <p> This bug does not necessarily indicate an error, since the change to
- mutable object state may have taken place in a method which then called
- the method containing the notification.</p>
-
-
-<h3><a name="NP_SYNC_AND_NULL_CHECK_FIELD">NP: Synchronize and null check on the same field. (NP_SYNC_AND_NULL_CHECK_FIELD)</a></h3>
-
-
-<p>Since the field is synchronized on, it seems not likely to be null.
-If it is null and then synchronized on a NullPointerException will be
-thrown and the check would be pointless. Better to synchronize on
-another field.</p>
-
-
-
-<h3><a name="NO_NOTIFY_NOT_NOTIFYALL">No: Using notify() rather than notifyAll() (NO_NOTIFY_NOT_NOTIFYALL)</a></h3>
-
-
- <p> This method calls <code>notify()</code> rather than <code>notifyAll()</code>.
- Java monitors are often used for multiple conditions. Calling <code>notify()</code>
- only wakes up one thread, meaning that the thread woken up might not be the
- one waiting for the condition that the caller just satisfied.</p>
-
-
-<h3><a name="RS_READOBJECT_SYNC">RS: Class's readObject() method is synchronized (RS_READOBJECT_SYNC)</a></h3>
-
-
- <p> This serializable class defines a <code>readObject()</code> which is
- synchronized. By definition, an object created by deserialization
- is only reachable by one thread, and thus there is no need for
- <code>readObject()</code> to be synchronized. If the <code>readObject()</code>
- method itself is causing the object to become visible to another thread,
- that is an example of very dubious coding style.</p>
-
-
-<h3><a name="RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED">RV: Return value of putIfAbsent ignored, value passed to putIfAbsent reused (RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED)</a></h3>
-
-
- The <code>putIfAbsent</code> method is typically used to ensure that a
- single value is associated with a given key (the first value for which put
- if absent succeeds).
- If you ignore the return value and retain a reference to the value passed in,
- you run the risk of retaining a value that is not the one that is associated with the key in the map.
- If it matters which one you use and you use the one that isn't stored in the map,
- your program will behave incorrectly.
-
-
-<h3><a name="RU_INVOKE_RUN">Ru: Invokes run on a thread (did you mean to start it instead?) (RU_INVOKE_RUN)</a></h3>
-
-
- <p> This method explicitly invokes <code>run()</code> on an object.
- In general, classes implement the <code>Runnable</code> interface because
- they are going to have their <code>run()</code> method invoked in a new thread,
- in which case <code>Thread.start()</code> is the right method to call.</p>
-
-
-<h3><a name="SC_START_IN_CTOR">SC: Constructor invokes Thread.start() (SC_START_IN_CTOR)</a></h3>
-
-
- <p> The constructor starts a thread. This is likely to be wrong if
- the class is ever extended/subclassed, since the thread will be started
- before the subclass constructor is started.</p>
-
-
-<h3><a name="SP_SPIN_ON_FIELD">SP: Method spins on field (SP_SPIN_ON_FIELD)</a></h3>
-
-
- <p> This method spins in a loop which reads a field. The compiler
- may legally hoist the read out of the loop, turning the code into an
- infinite loop. The class should be changed so it uses proper
- synchronization (including wait and notify calls).</p>
-
-
-<h3><a name="STCAL_INVOKE_ON_STATIC_CALENDAR_INSTANCE">STCAL: Call to static Calendar (STCAL_INVOKE_ON_STATIC_CALENDAR_INSTANCE)</a></h3>
-
-
-<p>Even though the JavaDoc does not contain a hint about it, Calendars are inherently unsafe for multihtreaded use.
-The detector has found a call to an instance of Calendar that has been obtained via a static
-field. This looks suspicous.</p>
-<p>For more information on this see <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6231579">Sun Bug #6231579</a>
-and <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6178997">Sun Bug #6178997</a>.</p>
-
-
-<h3><a name="STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE">STCAL: Call to static DateFormat (STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE)</a></h3>
-
-
-<p>As the JavaDoc states, DateFormats are inherently unsafe for multithreaded use.
-The detector has found a call to an instance of DateFormat that has been obtained via a static
-field. This looks suspicous.</p>
-<p>For more information on this see <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6231579">Sun Bug #6231579</a>
-and <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6178997">Sun Bug #6178997</a>.</p>
-
-
-<h3><a name="STCAL_STATIC_CALENDAR_INSTANCE">STCAL: Static Calendar (STCAL_STATIC_CALENDAR_INSTANCE)</a></h3>
-
-
-<p>Even though the JavaDoc does not contain a hint about it, Calendars are inherently unsafe for multihtreaded use.
-Sharing a single instance across thread boundaries without proper synchronization will result in erratic behavior of the
-application. Under 1.4 problems seem to surface less often than under Java 5 where you will probably see
-random ArrayIndexOutOfBoundsExceptions or IndexOutOfBoundsExceptions in sun.util.calendar.BaseCalendar.getCalendarDateFromFixedDate().</p>
-<p>You may also experience serialization problems.</p>
-<p>Using an instance field is recommended.</p>
-<p>For more information on this see <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6231579">Sun Bug #6231579</a>
-and <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6178997">Sun Bug #6178997</a>.</p>
-
-
-<h3><a name="STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE">STCAL: Static DateFormat (STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE)</a></h3>
-
-
-<p>As the JavaDoc states, DateFormats are inherently unsafe for multithreaded use.
-Sharing a single instance across thread boundaries without proper synchronization will result in erratic behavior of the
-application.</p>
-<p>You may also experience serialization problems.</p>
-<p>Using an instance field is recommended.</p>
-<p>For more information on this see <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6231579">Sun Bug #6231579</a>
-and <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6178997">Sun Bug #6178997</a>.</p>
-
-
-<h3><a name="SWL_SLEEP_WITH_LOCK_HELD">SWL: Method calls Thread.sleep() with a lock held (SWL_SLEEP_WITH_LOCK_HELD)</a></h3>
-
-
- <p>
- This method calls Thread.sleep() with a lock held. This may result
- in very poor performance and scalability, or a deadlock, since other threads may
- be waiting to acquire the lock. It is a much better idea to call
- wait() on the lock, which releases the lock and allows other threads
- to run.
- </p>
-
-
-<h3><a name="TLW_TWO_LOCK_WAIT">TLW: Wait with two locks held (TLW_TWO_LOCK_WAIT)</a></h3>
-
-
- <p> Waiting on a monitor while two locks are held may cause
- deadlock.
-
- Performing a wait only releases the lock on the object
- being waited on, not any other locks.
-
-This not necessarily a bug, but is worth examining
- closely.</p>
-
-
-<h3><a name="UG_SYNC_SET_UNSYNC_GET">UG: Unsynchronized get method, synchronized set method (UG_SYNC_SET_UNSYNC_GET)</a></h3>
-
-
- <p> This class contains similarly-named get and set
- methods where the set method is synchronized and the get method is not.
- This may result in incorrect behavior at runtime, as callers of the get
- method will not necessarily see a consistent state for the object.
- The get method should be made synchronized.</p>
-
-
-<h3><a name="UL_UNRELEASED_LOCK">UL: Method does not release lock on all paths (UL_UNRELEASED_LOCK)</a></h3>
-
-
-<p> This method acquires a JSR-166 (<code>java.util.concurrent</code>) lock,
-but does not release it on all paths out of the method. In general, the correct idiom
-for using a JSR-166 lock is:
-</p>
-<pre>
- Lock l = ...;
- l.lock();
- try {
- // do something
- } finally {
- l.unlock();
- }
-</pre>
-
-
-<h3><a name="UL_UNRELEASED_LOCK_EXCEPTION_PATH">UL: Method does not release lock on all exception paths (UL_UNRELEASED_LOCK_EXCEPTION_PATH)</a></h3>
-
-
-<p> This method acquires a JSR-166 (<code>java.util.concurrent</code>) lock,
-but does not release it on all exception paths out of the method. In general, the correct idiom
-for using a JSR-166 lock is:
-</p>
-<pre>
- Lock l = ...;
- l.lock();
- try {
- // do something
- } finally {
- l.unlock();
- }
-</pre>
-
-
-<h3><a name="UW_UNCOND_WAIT">UW: Unconditional wait (UW_UNCOND_WAIT)</a></h3>
-
-
- <p> This method contains a call to <code>java.lang.Object.wait()</code> which
- is not guarded by conditional control flow. The code should
- verify that condition it intends to wait for is not already satisfied
- before calling wait; any previous notifications will be ignored.
- </p>
-
-
-<h3><a name="VO_VOLATILE_REFERENCE_TO_ARRAY">VO: A volatile reference to an array doesn't treat the array elements as volatile (VO_VOLATILE_REFERENCE_TO_ARRAY)</a></h3>
-
-
-<p>This declares a volatile reference to an array, which might not be what
-you want. With a volatile reference to an array, reads and writes of
-the reference to the array are treated as volatile, but the array elements
-are non-volatile. To get volatile array elements, you will need to use
-one of the atomic array classes in java.util.concurrent (provided
-in Java 5.0).</p>
-
-
-<h3><a name="WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL">WL: Sychronization on getClass rather than class literal (WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL)</a></h3>
-
-
- <p>
- This instance method synchronizes on <code>this.getClass()</code>. If this class is subclassed,
- subclasses will synchronize on the class object for the subclass, which isn't likely what was intended.
- For example, consider this code from java.awt.Label:
- <pre>
- private static final String base = "label";
- private static int nameCounter = 0;
- String constructComponentName() {
- synchronized (getClass()) {
- return base + nameCounter++;
- }
- }
- </pre></p>
- <p>Subclasses of <code>Label</code> won't synchronize on the same subclass, giving rise to a datarace.
- Instead, this code should be synchronizing on <code>Label.class</code>
- <pre>
- private static final String base = "label";
- private static int nameCounter = 0;
- String constructComponentName() {
- synchronized (Label.class) {
- return base + nameCounter++;
- }
- }
- </pre></p>
- <p>Bug pattern contributed by Jason Mehrens</p>
-
-
-<h3><a name="WS_WRITEOBJECT_SYNC">WS: Class's writeObject() method is synchronized but nothing else is (WS_WRITEOBJECT_SYNC)</a></h3>
-
-
- <p> This class has a <code>writeObject()</code> method which is synchronized;
- however, no other method of the class is synchronized.</p>
-
-
-<h3><a name="WA_AWAIT_NOT_IN_LOOP">Wa: Condition.await() not in loop (WA_AWAIT_NOT_IN_LOOP)</a></h3>
-
-
- <p> This method contains a call to <code>java.util.concurrent.await()</code>
- (or variants)
- which is not in a loop. If the object is used for multiple conditions,
- the condition the caller intended to wait for might not be the one
- that actually occurred.</p>
-
-
-<h3><a name="WA_NOT_IN_LOOP">Wa: Wait not in loop (WA_NOT_IN_LOOP)</a></h3>
-
-
- <p> This method contains a call to <code>java.lang.Object.wait()</code>
- which is not in a loop. If the monitor is used for multiple conditions,
- the condition the caller intended to wait for might not be the one
- that actually occurred.</p>
-
-
-<h3><a name="BX_BOXING_IMMEDIATELY_UNBOXED">Bx: Primitive value is boxed and then immediately unboxed (BX_BOXING_IMMEDIATELY_UNBOXED)</a></h3>
-
-
- <p>A primitive is boxed, and then immediately unboxed. This probably is due to a manual
- boxing in a place where an unboxed value is required, thus forcing the compiler
-to immediately undo the work of the boxing.
-</p>
-
-
-<h3><a name="BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION">Bx: Primitive value is boxed then unboxed to perform primitive coercion (BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION)</a></h3>
-
-
- <p>A primitive boxed value constructed and then immediately converted into a different primitive type
-(e.g., <code>new Double(d).intValue()</code>). Just perform direct primitive coercion (e.g., <code>(int) d</code>).</p>
-
-
-<h3><a name="DM_BOXED_PRIMITIVE_TOSTRING">Bx: Method allocates a boxed primitive just to call toString (DM_BOXED_PRIMITIVE_TOSTRING)</a></h3>
-
-
- <p>A boxed primitive is allocated just to call toString(). It is more effective to just use the static
- form of toString which takes the primitive value. So,</p>
- <table>
- <tr><th>Replace...</th><th>With this...</th></tr>
- <tr><td>new Integer(1).toString()</td><td>Integer.toString(1)</td></tr>
- <tr><td>new Long(1).toString()</td><td>Long.toString(1)</td></tr>
- <tr><td>new Float(1.0).toString()</td><td>Float.toString(1.0)</td></tr>
- <tr><td>new Double(1.0).toString()</td><td>Double.toString(1.0)</td></tr>
- <tr><td>new Byte(1).toString()</td><td>Byte.toString(1)</td></tr>
- <tr><td>new Short(1).toString()</td><td>Short.toString(1)</td></tr>
- <tr><td>new Boolean(true).toString()</td><td>Boolean.toString(true)</td></tr>
- </table>
-
-
-<h3><a name="DM_FP_NUMBER_CTOR">Bx: Method invokes inefficient floating-point Number constructor; use static valueOf instead (DM_FP_NUMBER_CTOR)</a></h3>
-
-
- <p>
- Using <code>new Double(double)</code> is guaranteed to always result in a new object whereas
- <code>Double.valueOf(double)</code> allows caching of values to be done by the compiler, class library, or JVM.
- Using of cached values avoids object allocation and the code will be faster.
- </p>
- <p>
- Unless the class must be compatible with JVMs predating Java 1.5,
- use either autoboxing or the <code>valueOf()</code> method when creating instances of <code>Double</code> and <code>Float</code>.
- </p>
-
-
-<h3><a name="DM_NUMBER_CTOR">Bx: Method invokes inefficient Number constructor; use static valueOf instead (DM_NUMBER_CTOR)</a></h3>
-
-
- <p>
- Using <code>new Integer(int)</code> is guaranteed to always result in a new object whereas
- <code>Integer.valueOf(int)</code> allows caching of values to be done by the compiler, class library, or JVM.
- Using of cached values avoids object allocation and the code will be faster.
- </p>
- <p>
- Values between -128 and 127 are guaranteed to have corresponding cached instances
- and using <code>valueOf</code> is approximately 3.5 times faster than using constructor.
- For values outside the constant range the performance of both styles is the same.
- </p>
- <p>
- Unless the class must be compatible with JVMs predating Java 1.5,
- use either autoboxing or the <code>valueOf()</code> method when creating instances of
- <code>Long</code>, <code>Integer</code>, <code>Short</code>, <code>Character</code>, and <code>Byte</code>.
- </p>
-
-
-<h3><a name="DMI_BLOCKING_METHODS_ON_URL">Dm: The equals and hashCode methods of URL are blocking (DMI_BLOCKING_METHODS_ON_URL)</a></h3>
-
-
- <p> The equals and hashCode
-method of URL perform domain name resolution, this can result in a big performance hit.
-See <a href="http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html">http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html</a> for more information.
-Consider using <code>java.net.URI</code> instead.
- </p>
-
-
-<h3><a name="DMI_COLLECTION_OF_URLS">Dm: Maps and sets of URLs can be performance hogs (DMI_COLLECTION_OF_URLS)</a></h3>
-
-
- <p> This method or field is or uses a Map or Set of URLs. Since both the equals and hashCode
-method of URL perform domain name resolution, this can result in a big performance hit.
-See <a href="http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html">http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html</a> for more information.
-Consider using <code>java.net.URI</code> instead.
- </p>
-
-
-<h3><a name="DM_BOOLEAN_CTOR">Dm: Method invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead (DM_BOOLEAN_CTOR)</a></h3>
-
-
- <p> Creating new instances of <code>java.lang.Boolean</code> wastes
- memory, since <code>Boolean</code> objects are immutable and there are
- only two useful values of this type. Use the <code>Boolean.valueOf()</code>
- method (or Java 1.5 autoboxing) to create <code>Boolean</code> objects instead.</p>
-
-
-<h3><a name="DM_GC">Dm: Explicit garbage collection; extremely dubious except in benchmarking code (DM_GC)</a></h3>
-
-
- <p> Code explicitly invokes garbage collection.
- Except for specific use in benchmarking, this is very dubious.</p>
- <p>In the past, situations where people have explicitly invoked
- the garbage collector in routines such as close or finalize methods
- has led to huge performance black holes. Garbage collection
- can be expensive. Any situation that forces hundreds or thousands
- of garbage collections will bring the machine to a crawl.</p>
-
-
-<h3><a name="DM_NEW_FOR_GETCLASS">Dm: Method allocates an object, only to get the class object (DM_NEW_FOR_GETCLASS)</a></h3>
-
-
- <p>This method allocates an object just to call getClass() on it, in order to
- retrieve the Class object for it. It is simpler to just access the .class property of the class.</p>
-
-
-<h3><a name="DM_NEXTINT_VIA_NEXTDOUBLE">Dm: Use the nextInt method of Random rather than nextDouble to generate a random integer (DM_NEXTINT_VIA_NEXTDOUBLE)</a></h3>
-
-
- <p>If <code>r</code> is a <code>java.util.Random</code>, you can generate a random number from <code>0</code> to <code>n-1</code>
-using <code>r.nextInt(n)</code>, rather than using <code>(int)(r.nextDouble() * n)</code>.
-</p>
-
-
-<h3><a name="DM_STRING_CTOR">Dm: Method invokes inefficient new String(String) constructor (DM_STRING_CTOR)</a></h3>
-
-
- <p> Using the <code>java.lang.String(String)</code> constructor wastes memory
- because the object so constructed will be functionally indistinguishable
- from the <code>String</code> passed as a parameter. Just use the
- argument <code>String</code> directly.</p>
-
-
-<h3><a name="DM_STRING_TOSTRING">Dm: Method invokes toString() method on a String (DM_STRING_TOSTRING)</a></h3>
-
-
- <p> Calling <code>String.toString()</code> is just a redundant operation.
- Just use the String.</p>
-
-
-<h3><a name="DM_STRING_VOID_CTOR">Dm: Method invokes inefficient new String() constructor (DM_STRING_VOID_CTOR)</a></h3>
-
-
- <p> Creating a new <code>java.lang.String</code> object using the
- no-argument constructor wastes memory because the object so created will
- be functionally indistinguishable from the empty string constant
- <code>""</code>. Java guarantees that identical string constants
- will be represented by the same <code>String</code> object. Therefore,
- you should just use the empty string constant directly.</p>
-
-
-<h3><a name="HSC_HUGE_SHARED_STRING_CONSTANT">HSC: Huge string constants is duplicated across multiple class files (HSC_HUGE_SHARED_STRING_CONSTANT)</a></h3>
-
-
- <p>
- A large String constant is duplicated across multiple class files.
- This is likely because a final field is initialized to a String constant, and the Java language
- mandates that all references to a final field from other classes be inlined into
-that classfile. See <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6447475">JDK bug 6447475</a>
- for a description of an occurrence of this bug in the JDK and how resolving it reduced
- the size of the JDK by 1 megabyte.
-</p>
-
-
-<h3><a name="ITA_INEFFICIENT_TO_ARRAY">ITA: Method uses toArray() with zero-length array argument (ITA_INEFFICIENT_TO_ARRAY)</a></h3>
-
-
-<p> This method uses the toArray() method of a collection derived class, and passes
-in a zero-length prototype array argument. It is more efficient to use
-<code>myCollection.toArray(new Foo[myCollection.size()])</code>
-If the array passed in is big enough to store all of the
-elements of the collection, then it is populated and returned
-directly. This avoids the need to create a second array
-(by reflection) to return as the result.</p>
-
-
-<h3><a name="SBSC_USE_STRINGBUFFER_CONCATENATION">SBSC: Method concatenates strings using + in a loop (SBSC_USE_STRINGBUFFER_CONCATENATION)</a></h3>
-
-
-<p> The method seems to be building a String using concatenation in a loop.
-In each iteration, the String is converted to a StringBuffer/StringBuilder,
- appended to, and converted back to a String.
- This can lead to a cost quadratic in the number of iterations,
- as the growing string is recopied in each iteration. </p>
-
-<p>Better performance can be obtained by using
-a StringBuffer (or StringBuilder in Java 1.5) explicitly.</p>
-
-<p> For example:</p>
-<pre>
- // This is bad
- String s = "";
- for (int i = 0; i < field.length; ++i) {
- s = s + field[i];
- }
-
- // This is better
- StringBuffer buf = new StringBuffer();
- for (int i = 0; i < field.length; ++i) {
- buf.append(field[i]);
- }
- String s = buf.toString();
-</pre>
-
-
-<h3><a name="SIC_INNER_SHOULD_BE_STATIC">SIC: Should be a static inner class (SIC_INNER_SHOULD_BE_STATIC)</a></h3>
-
-
- <p> This class is an inner class, but does not use its embedded reference
- to the object which created it. This reference makes the instances
- of the class larger, and may keep the reference to the creator object
- alive longer than necessary. If possible, the class should be
- made static.
-</p>
-
-
-<h3><a name="SIC_INNER_SHOULD_BE_STATIC_ANON">SIC: Could be refactored into a named static inner class (SIC_INNER_SHOULD_BE_STATIC_ANON)</a></h3>
-
-
- <p> This class is an inner class, but does not use its embedded reference
- to the object which created it. This reference makes the instances
- of the class larger, and may keep the reference to the creator object
- alive longer than necessary. If possible, the class should be
- made into a <em>static</em> inner class. Since anonymous inner
-classes cannot be marked as static, doing this will require refactoring
-the inner class so that it is a named inner class.</p>
-
-
-<h3><a name="SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS">SIC: Could be refactored into a static inner class (SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS)</a></h3>
-
-
- <p> This class is an inner class, but does not use its embedded reference
- to the object which created it except during construction of the
-inner object. This reference makes the instances
- of the class larger, and may keep the reference to the creator object
- alive longer than necessary. If possible, the class should be
- made into a <em>static</em> inner class. Since the reference to the
- outer object is required during construction of the inner instance,
- the inner class will need to be refactored so as to
- pass a reference to the outer instance to the constructor
- for the inner class.</p>
-
-
-<h3><a name="SS_SHOULD_BE_STATIC">SS: Unread field: should this field be static? (SS_SHOULD_BE_STATIC)</a></h3>
-
-
- <p> This class contains an instance final field that
- is initialized to a compile-time static value.
- Consider making the field static.</p>
-
-
-<h3><a name="UM_UNNECESSARY_MATH">UM: Method calls static Math class method on a constant value (UM_UNNECESSARY_MATH)</a></h3>
-
-
-<p> This method uses a static method from java.lang.Math on a constant value. This method's
-result in this case, can be determined statically, and is faster and sometimes more accurate to
-just use the constant. Methods detected are:
-</p>
-<table>
-<tr>
- <th>Method</th> <th>Parameter</th>
-</tr>
-<tr>
- <td>abs</td> <td>-any-</td>
-</tr>
-<tr>
- <td>acos</td> <td>0.0 or 1.0</td>
-</tr>
-<tr>
- <td>asin</td> <td>0.0 or 1.0</td>
-</tr>
-<tr>
- <td>atan</td> <td>0.0 or 1.0</td>
-</tr>
-<tr>
- <td>atan2</td> <td>0.0</td>
-</tr>
-<tr>
- <td>cbrt</td> <td>0.0 or 1.0</td>
-</tr>
-<tr>
- <td>ceil</td> <td>-any-</td>
-</tr>
-<tr>
- <td>cos</td> <td>0.0</td>
-</tr>
-<tr>
- <td>cosh</td> <td>0.0</td>
-</tr>
-<tr>
- <td>exp</td> <td>0.0 or 1.0</td>
-</tr>
-<tr>
- <td>expm1</td> <td>0.0</td>
-</tr>
-<tr>
- <td>floor</td> <td>-any-</td>
-</tr>
-<tr>
- <td>log</td> <td>0.0 or 1.0</td>
-</tr>
-<tr>
- <td>log10</td> <td>0.0 or 1.0</td>
-</tr>
-<tr>
- <td>rint</td> <td>-any-</td>
-</tr>
-<tr>
- <td>round</td> <td>-any-</td>
-</tr>
-<tr>
- <td>sin</td> <td>0.0</td>
-</tr>
-<tr>
- <td>sinh</td> <td>0.0</td>
-</tr>
-<tr>
- <td>sqrt</td> <td>0.0 or 1.0</td>
-</tr>
-<tr>
- <td>tan</td> <td>0.0</td>
-</tr>
-<tr>
- <td>tanh</td> <td>0.0</td>
-</tr>
-<tr>
- <td>toDegrees</td> <td>0.0 or 1.0</td>
-</tr>
-<tr>
- <td>toRadians</td> <td>0.0</td>
-</tr>
-</table>
-
-
-<h3><a name="UPM_UNCALLED_PRIVATE_METHOD">UPM: Private method is never called (UPM_UNCALLED_PRIVATE_METHOD)</a></h3>
-
-
-<p> This private method is never called. Although it is
-possible that the method will be invoked through reflection,
-it is more likely that the method is never used, and should be
-removed.
-</p>
-
-
-<h3><a name="URF_UNREAD_FIELD">UrF: Unread field (URF_UNREAD_FIELD)</a></h3>
-
-
- <p> This field is never read. Consider removing it from the class.</p>
-
-
-<h3><a name="UUF_UNUSED_FIELD">UuF: Unused field (UUF_UNUSED_FIELD)</a></h3>
-
-
- <p> This field is never used. Consider removing it from the class.</p>
-
-
-<h3><a name="WMI_WRONG_MAP_ITERATOR">WMI: Inefficient use of keySet iterator instead of entrySet iterator (WMI_WRONG_MAP_ITERATOR)</a></h3>
-
-
-<p> This method accesses the value of a Map entry, using a key that was retrieved from
-a keySet iterator. It is more efficient to use an iterator on the entrySet of the map, to avoid the
-Map.get(key) lookup.</p>
-
-
-<h3><a name="DMI_CONSTANT_DB_PASSWORD">Dm: Hardcoded constant database password (DMI_CONSTANT_DB_PASSWORD)</a></h3>
-
-
- <p>This code creates a database connect using a hardcoded, constant password. Anyone with access to either the source code or the compiled code can
- easily learn the password.
-</p>
-
-
-
-<h3><a name="DMI_EMPTY_DB_PASSWORD">Dm: Empty database password (DMI_EMPTY_DB_PASSWORD)</a></h3>
-
-
- <p>This code creates a database connect using a blank or empty password. This indicates that the database is not protected by a password.
-</p>
-
-
-
-<h3><a name="HRS_REQUEST_PARAMETER_TO_COOKIE">HRS: HTTP cookie formed from untrusted input (HRS_REQUEST_PARAMETER_TO_COOKIE)</a></h3>
-
-
- <p>This code constructs an HTTP Cookie using an untrusted HTTP parameter. If this cookie is added to an HTTP response, it will allow a HTTP response splitting
-vulnerability. See <a href="http://en.wikipedia.org/wiki/HTTP_response_splitting">http://en.wikipedia.org/wiki/HTTP_response_splitting</a>
-for more information.</p>
-<p>FindBugs looks only for the most blatant, obvious cases of HTTP response splitting.
-If FindBugs found <em>any</em>, you <em>almost certainly</em> have more
-vulnerabilities that FindBugs doesn't report. If you are concerned about HTTP response splitting, you should seriously
-consider using a commercial static analysis or pen-testing tool.
-</p>
-
-
-
-<h3><a name="HRS_REQUEST_PARAMETER_TO_HTTP_HEADER">HRS: HTTP Response splitting vulnerability (HRS_REQUEST_PARAMETER_TO_HTTP_HEADER)</a></h3>
-
-
- <p>This code directly writes an HTTP parameter to an HTTP header, which allows for a HTTP response splitting
-vulnerability. See <a href="http://en.wikipedia.org/wiki/HTTP_response_splitting">http://en.wikipedia.org/wiki/HTTP_response_splitting</a>
-for more information.</p>
-<p>FindBugs looks only for the most blatant, obvious cases of HTTP response splitting.
-If FindBugs found <em>any</em>, you <em>almost certainly</em> have more
-vulnerabilities that FindBugs doesn't report. If you are concerned about HTTP response splitting, you should seriously
-consider using a commercial static analysis or pen-testing tool.
-</p>
-
-
-
-<h3><a name="SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE">SQL: Nonconstant string passed to execute method on an SQL statement (SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE)</a></h3>
-
-
- <p>The method invokes the execute method on an SQL statement with a String that seems
-to be dynamically generated. Consider using
-a prepared statement instead. It is more efficient and less vulnerable to
-SQL injection attacks.
-</p>
-
-
-<h3><a name="SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING">SQL: A prepared statement is generated from a nonconstant String (SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING)</a></h3>
-
-
- <p>The code creates an SQL prepared statement from a nonconstant String.
-If unchecked, tainted data from a user is used in building this String, SQL injection could
-be used to make the prepared statement do something unexpected and undesirable.
-</p>
-
-
-<h3><a name="XSS_REQUEST_PARAMETER_TO_JSP_WRITER">XSS: JSP reflected cross site scripting vulnerability (XSS_REQUEST_PARAMETER_TO_JSP_WRITER)</a></h3>
-
-
- <p>This code directly writes an HTTP parameter to JSP output, which allows for a cross site scripting
-vulnerability. See <a href="http://en.wikipedia.org/wiki/Cross-site_scripting">http://en.wikipedia.org/wiki/Cross-site_scripting</a>
-for more information.</p>
-<p>FindBugs looks only for the most blatant, obvious cases of cross site scripting.
-If FindBugs found <em>any</em>, you <em>almost certainly</em> have more cross site scripting
-vulnerabilities that FindBugs doesn't report. If you are concerned about cross site scripting, you should seriously
-consider using a commercial static analysis or pen-testing tool.
-</p>
-
-
-<h3><a name="XSS_REQUEST_PARAMETER_TO_SEND_ERROR">XSS: Servlet reflected cross site scripting vulnerability (XSS_REQUEST_PARAMETER_TO_SEND_ERROR)</a></h3>
-
-
- <p>This code directly writes an HTTP parameter to a Server error page (using HttpServletResponse.sendError). Echoing this untrusted input allows
-for a reflected cross site scripting
-vulnerability. See <a href="http://en.wikipedia.org/wiki/Cross-site_scripting">http://en.wikipedia.org/wiki/Cross-site_scripting</a>
-for more information.</p>
-<p>FindBugs looks only for the most blatant, obvious cases of cross site scripting.
-If FindBugs found <em>any</em>, you <em>almost certainly</em> have more cross site scripting
-vulnerabilities that FindBugs doesn't report. If you are concerned about cross site scripting, you should seriously
-consider using a commercial static analysis or pen-testing tool.
-</p>
-
-
-
-<h3><a name="XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER">XSS: Servlet reflected cross site scripting vulnerability (XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER)</a></h3>
-
-
- <p>This code directly writes an HTTP parameter to Servlet output, which allows for a reflected cross site scripting
-vulnerability. See <a href="http://en.wikipedia.org/wiki/Cross-site_scripting">http://en.wikipedia.org/wiki/Cross-site_scripting</a>
-for more information.</p>
-<p>FindBugs looks only for the most blatant, obvious cases of cross site scripting.
-If FindBugs found <em>any</em>, you <em>almost certainly</em> have more cross site scripting
-vulnerabilities that FindBugs doesn't report. If you are concerned about cross site scripting, you should seriously
-consider using a commercial static analysis or pen-testing tool.
-</p>
-
-
-
-<h3><a name="BC_BAD_CAST_TO_ABSTRACT_COLLECTION">BC: Questionable cast to abstract collection (BC_BAD_CAST_TO_ABSTRACT_COLLECTION)</a></h3>
-
-
-<p>
-This code casts a Collection to an abstract collection
-(such as <code>List</code>, <code>Set</code>, or <code>Map</code>).
-Ensure that you are guaranteed that the object is of the type
-you are casting to. If all you need is to be able
-to iterate through a collection, you don't need to cast it to a Set or List.
-</p>
-
-
-<h3><a name="BC_BAD_CAST_TO_CONCRETE_COLLECTION">BC: Questionable cast to concrete collection (BC_BAD_CAST_TO_CONCRETE_COLLECTION)</a></h3>
-
-
-<p>
-This code casts an abstract collection (such as a Collection, List, or Set)
-to a specific concrete implementation (such as an ArrayList or HashSet).
-This might not be correct, and it may make your code fragile, since
-it makes it harder to switch to other concrete implementations at a future
-point. Unless you have a particular reason to do so, just use the abstract
-collection class.
-</p>
-
-
-<h3><a name="BC_UNCONFIRMED_CAST">BC: Unchecked/unconfirmed cast (BC_UNCONFIRMED_CAST)</a></h3>
-
-
-<p>
-This cast is unchecked, and not all instances of the type casted from can be cast to
-the type it is being cast to. Ensure that your program logic ensures that this
-cast will not fail.
-</p>
-
-
-<h3><a name="BC_VACUOUS_INSTANCEOF">BC: instanceof will always return true (BC_VACUOUS_INSTANCEOF)</a></h3>
-
-
-<p>
-This instanceof test will always return true (unless the value being tested is null).
-Although this is safe, make sure it isn't
-an indication of some misunderstanding or some other logic error.
-If you really want to test the value for being null, perhaps it would be clearer to do
-better to do a null test rather than an instanceof test.
-</p>
-
-
-<h3><a name="ICAST_QUESTIONABLE_UNSIGNED_RIGHT_SHIFT">BSHIFT: Unsigned right shift cast to short/byte (ICAST_QUESTIONABLE_UNSIGNED_RIGHT_SHIFT)</a></h3>
-
-
-<p>
-The code performs an unsigned right shift, whose result is then
-cast to a short or byte, which discards the upper bits of the result.
-Since the upper bits are discarded, there may be no difference between
-a signed and unsigned right shift (depending upon the size of the shift).
-</p>
-
-
-<h3><a name="CI_CONFUSED_INHERITANCE">CI: Class is final but declares protected field (CI_CONFUSED_INHERITANCE)</a></h3>
-
-
- <p>
- This class is declared to be final, but declares fields to be protected. Since the class
- is final, it can not be derived from, and the use of protected is confusing. The access
- modifier for the field should be changed to private or public to represent the true
- use for the field.
- </p>
-
-
-<h3><a name="DB_DUPLICATE_BRANCHES">DB: Method uses the same code for two branches (DB_DUPLICATE_BRANCHES)</a></h3>
-
-
- <p>
- This method uses the same code to implement two branches of a conditional branch.
- Check to ensure that this isn't a coding mistake.
- </p>
-
-
-<h3><a name="DB_DUPLICATE_SWITCH_CLAUSES">DB: Method uses the same code for two switch clauses (DB_DUPLICATE_SWITCH_CLAUSES)</a></h3>
-
-
- <p>
- This method uses the same code to implement two clauses of a switch statement.
- This could be a case of duplicate code, but it might also indicate
- a coding mistake.
- </p>
-
-
-<h3><a name="DLS_DEAD_LOCAL_STORE">DLS: Dead store to local variable (DLS_DEAD_LOCAL_STORE)</a></h3>
-
-
-<p>
-This instruction assigns a value to a local variable,
-but the value is not read or used in any subsequent instruction.
-Often, this indicates an error, because the value computed is never
-used.
-</p>
-<p>
-Note that Sun's javac compiler often generates dead stores for
-final local variables. Because FindBugs is a bytecode-based tool,
-there is no easy way to eliminate these false positives.
-</p>
-
-
-<h3><a name="DLS_DEAD_LOCAL_STORE_IN_RETURN">DLS: Useless assignment in return statement (DLS_DEAD_LOCAL_STORE_IN_RETURN)</a></h3>
-
-
-<p>
-This statement assigns to a local variable in a return statement. This assignment
-has effect. Please verify that this statement does the right thing.
-</p>
-
-
-<h3><a name="DLS_DEAD_LOCAL_STORE_OF_NULL">DLS: Dead store of null to local variable (DLS_DEAD_LOCAL_STORE_OF_NULL)</a></h3>
-
-
-<p>The code stores null into a local variable, and the stored value is not
-read. This store may have been introduced to assist the garbage collector, but
-as of Java SE 6.0, this is no longer needed or useful.
-</p>
-
-
-<h3><a name="DMI_HARDCODED_ABSOLUTE_FILENAME">DMI: Code contains a hard coded reference to an absolute pathname (DMI_HARDCODED_ABSOLUTE_FILENAME)</a></h3>
-
-
-<p>This code constructs a File object using a hard coded to an absolute pathname
-(e.g., <code>new File("/home/dannyc/workspace/j2ee/src/share/com/sun/enterprise/deployment");</code>
-</p>
-
-
-<h3><a name="DMI_NONSERIALIZABLE_OBJECT_WRITTEN">DMI: Non serializable object written to ObjectOutput (DMI_NONSERIALIZABLE_OBJECT_WRITTEN)</a></h3>
-
-
-<p>
-This code seems to be passing a non-serializable object to the ObjectOutput.writeObject method.
-If the object is, indeed, non-serializable, an error will result.
-</p>
-
-
-<h3><a name="DMI_USELESS_SUBSTRING">DMI: Invocation of substring(0), which returns the original value (DMI_USELESS_SUBSTRING)</a></h3>
-
-
-<p>
-This code invokes substring(0) on a String, which returns the original value.
-</p>
-
-
-<h3><a name="DMI_THREAD_PASSED_WHERE_RUNNABLE_EXPECTED">Dm: Thread passed where Runnable expected (DMI_THREAD_PASSED_WHERE_RUNNABLE_EXPECTED)</a></h3>
-
-
- <p> A Thread object is passed as a parameter to a method where
-a Runnable is expected. This is rather unusual, and may indicate a logic error
-or cause unexpected behavior.
- </p>
-
-
-<h3><a name="EQ_DOESNT_OVERRIDE_EQUALS">Eq: Class doesn't override equals in superclass (EQ_DOESNT_OVERRIDE_EQUALS)</a></h3>
-
-
- <p> This class extends a class that defines an equals method and adds fields, but doesn't
-define an equals method itself. Thus, equality on instances of this class will
-ignore the identity of the subclass and the added fields. Be sure this is what is intended,
-and that you don't need to override the equals method. Even if you don't need to override
-the equals method, consider overriding it anyway to document the fact
-that the equals method for the subclass just return the result of
-invoking super.equals(o).
- </p>
-
-
-<h3><a name="EQ_UNUSUAL">Eq: Unusual equals method (EQ_UNUSUAL)</a></h3>
-
-
- <p> This class doesn't do any of the patterns we recognize for checking that the type of the argument
-is compatible with the type of the <code>this</code> object. There might not be anything wrong with
-this code, but it is worth reviewing.
-</p>
-
-
-<h3><a name="FE_FLOATING_POINT_EQUALITY">FE: Test for floating point equality (FE_FLOATING_POINT_EQUALITY)</a></h3>
-
-
- <p>
- This operation compares two floating point values for equality.
- Because floating point calculations may involve rounding,
- calculated float and double values may not be accurate.
- For values that must be precise, such as monetary values,
- consider using a fixed-precision type such as BigDecimal.
- For values that need not be precise, consider comparing for equality
- within some range, for example:
- <code>if ( Math.abs(x - y) < .0000001 )</code>.
- See the Java Language Specification, section 4.2.4.
- </p>
-
-
-<h3><a name="VA_FORMAT_STRING_BAD_CONVERSION_TO_BOOLEAN">FS: Non-Boolean argument formatted using %b format specifier (VA_FORMAT_STRING_BAD_CONVERSION_TO_BOOLEAN)</a></h3>
-
-
-<p>
-An argument not of type Boolean is being formatted with a %b format specifier. This won't throw an
-exception; instead, it will print true for any nonnull value, and false for null.
-This feature of format strings is strange, and may not be what you intended.
-</p>
-
-
-<h3><a name="IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD">IA: Ambiguous invocation of either an inherited or outer method (IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD)</a></h3>
-
-
- <p> An inner class is invoking a method that could be resolved to either a inherited method or a method defined in an outer class. By the Java semantics,
-it will be resolved to invoke the inherited method, but this may not be want
-you intend. If you really intend to invoke the inherited method,
-invoke it by invoking the method on super (e.g., invoke super.foo(17)), and
-thus it will be clear to other readers of your code and to FindBugs
-that you want to invoke the inherited method, not the method in the outer class.
-</p>
-
-
-<h3><a name="IC_INIT_CIRCULARITY">IC: Initialization circularity (IC_INIT_CIRCULARITY)</a></h3>
-
-
- <p> A circularity was detected in the static initializers of the two
- classes referenced by the bug instance. Many kinds of unexpected
- behavior may arise from such circularity.</p>
-
-
-<h3><a name="ICAST_IDIV_CAST_TO_DOUBLE">ICAST: integral division result cast to double or float (ICAST_IDIV_CAST_TO_DOUBLE)</a></h3>
-
-
-<p>
-This code casts the result of an integral division (e.g., int or long division)
-operation to double or
-float.
-Doing division on integers truncates the result
-to the integer value closest to zero. The fact that the result
-was cast to double suggests that this precision should have been retained.
-What was probably meant was to cast one or both of the operands to
-double <em>before</em> performing the division. Here is an example:
-</p>
-<blockquote>
-<pre>
-int x = 2;
-int y = 5;
-// Wrong: yields result 0.0
-double value1 = x / y;
-
-// Right: yields result 0.4
-double value2 = x / (double) y;
-</pre>
-</blockquote>
-
-
-<h3><a name="ICAST_INTEGER_MULTIPLY_CAST_TO_LONG">ICAST: Result of integer multiplication cast to long (ICAST_INTEGER_MULTIPLY_CAST_TO_LONG)</a></h3>
-
-
-<p>
-This code performs integer multiply and then converts the result to a long,
-as in:
-<code>
-<pre>
- long convertDaysToMilliseconds(int days) { return 1000*3600*24*days; }
-</pre></code>
-If the multiplication is done using long arithmetic, you can avoid
-the possibility that the result will overflow. For example, you
-could fix the above code to:
-<code>
-<pre>
- long convertDaysToMilliseconds(int days) { return 1000L*3600*24*days; }
-</pre></code>
-or
-<code>
-<pre>
- static final long MILLISECONDS_PER_DAY = 24L*3600*1000;
- long convertDaysToMilliseconds(int days) { return days * MILLISECONDS_PER_DAY; }
-</pre></code>
-</p>
-
-
-
-<h3><a name="IM_AVERAGE_COMPUTATION_COULD_OVERFLOW">IM: Computation of average could overflow (IM_AVERAGE_COMPUTATION_COULD_OVERFLOW)</a></h3>
-
-
-<p>The code computes the average of two integers using either division or signed right shift,
-and then uses the result as the index of an array.
-If the values being averaged are very large, this can overflow (resulting in the computation
-of a negative average). Assuming that the result is intended to be nonnegative, you
-can use an unsigned right shift instead. In other words, rather that using <code>(low+high)/2</code>,
-use <code>(low+high) >>> 1</code>
-</p>
-<p>This bug exists in many earlier implementations of binary search and merge sort.
-Martin Buchholz <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6412541">found and fixed it</a>
-in the JDK libraries, and Joshua Bloch
-<a href="http://googleresearch.blogspot.com/2006/06/extra-extra-read-all-about-it-nearly.html">widely
-publicized the bug pattern</a>.
-</p>
-
-
-<h3><a name="IM_BAD_CHECK_FOR_ODD">IM: Check for oddness that won't work for negative numbers (IM_BAD_CHECK_FOR_ODD)</a></h3>
-
-
-<p>
-The code uses x % 2 == 1 to check to see if a value is odd, but this won't work
-for negative numbers (e.g., (-5) % 2 == -1). If this code is intending to check
-for oddness, consider using x & 1 == 1, or x % 2 != 0.
-</p>
-
-
-<h3><a name="INT_BAD_REM_BY_1">INT: Integer remainder modulo 1 (INT_BAD_REM_BY_1)</a></h3>
-
-
-<p> Any expression (exp % 1) is guaranteed to always return zero.
-Did you mean (exp & 1) or (exp % 2) instead?
-</p>
-
-
-<h3><a name="INT_VACUOUS_COMPARISON">INT: Vacuous comparison of integer value (INT_VACUOUS_COMPARISON)</a></h3>
-
-
-<p> There is an integer comparison that always returns
-the same value (e.g., x <= Integer.MAX_VALUE).
-</p>
-
-
-<h3><a name="MTIA_SUSPECT_SERVLET_INSTANCE_FIELD">MTIA: Class extends Servlet class and uses instance variables (MTIA_SUSPECT_SERVLET_INSTANCE_FIELD)</a></h3>
-
-
- <p>
- This class extends from a Servlet class, and uses an instance member variable. Since only
- one instance of a Servlet class is created by the J2EE framework, and used in a
- multithreaded way, this paradigm is highly discouraged and most likely problematic. Consider
- only using method local variables.
- </p>
-
-
-<h3><a name="MTIA_SUSPECT_STRUTS_INSTANCE_FIELD">MTIA: Class extends Struts Action class and uses instance variables (MTIA_SUSPECT_STRUTS_INSTANCE_FIELD)</a></h3>
-
-
- <p>
- This class extends from a Struts Action class, and uses an instance member variable. Since only
- one instance of a struts Action class is created by the Struts framework, and used in a
- multithreaded way, this paradigm is highly discouraged and most likely problematic. Consider
- only using method local variables. Only instance fields that are written outside of a monitor
- are reported.
- </p>
-
-
-<h3><a name="NP_DEREFERENCE_OF_READLINE_VALUE">NP: Dereference of the result of readLine() without nullcheck (NP_DEREFERENCE_OF_READLINE_VALUE)</a></h3>
-
-
- <p> The result of invoking readLine() is dereferenced without checking to see if the result is null. If there are no more lines of text
-to read, readLine() will return null and dereferencing that will generate a null pointer exception.
-</p>
-
-
-<h3><a name="NP_IMMEDIATE_DEREFERENCE_OF_READLINE">NP: Immediate dereference of the result of readLine() (NP_IMMEDIATE_DEREFERENCE_OF_READLINE)</a></h3>
-
-
- <p> The result of invoking readLine() is immediately dereferenced. If there are no more lines of text
-to read, readLine() will return null and dereferencing that will generate a null pointer exception.
-</p>
-
-
-<h3><a name="NP_LOAD_OF_KNOWN_NULL_VALUE">NP: Load of known null value (NP_LOAD_OF_KNOWN_NULL_VALUE)</a></h3>
-
-
- <p> The variable referenced at this point is known to be null due to an earlier
- check against null. Although this is valid, it might be a mistake (perhaps you
-intended to refer to a different variable, or perhaps the earlier check to see if the
-variable is null should have been a check to see if it was nonnull).
-</p>
-
-
-<h3><a name="NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE">NP: Possible null pointer dereference due to return value of called method (NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE)</a></h3>
-
-
-<p> The return value from a method is dereferenced without a null check,
-and the return value of that method is one that should generally be checked
-for null. This may lead to a <code>NullPointerException</code> when the code is executed.
-</p>
-
-
-<h3><a name="NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE">NP: Possible null pointer dereference on path that might be infeasible (NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE)</a></h3>
-
-
-<p> There is a branch of statement that, <em>if executed,</em> guarantees that
-a null value will be dereferenced, which
-would generate a <code>NullPointerException</code> when the code is executed.
-Of course, the problem might be that the branch or statement is infeasible and that
-the null pointer exception can't ever be executed; deciding that is beyond the ability of FindBugs.
-Due to the fact that this value had been previously tested for nullness, this is a definite possibility.
-</p>
-
-
-<h3><a name="NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE">NP: Parameter must be nonnull but is marked as nullable (NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE)</a></h3>
-
-
-<p> This parameter is always used in a way that requires it to be nonnull,
-but the parameter is explicitly annotated as being Nullable. Either the use
-of the parameter or the annotation is wrong.
-</p>
-
-
-<h3><a name="NS_DANGEROUS_NON_SHORT_CIRCUIT">NS: Potentially dangerous use of non-short-circuit logic (NS_DANGEROUS_NON_SHORT_CIRCUIT)</a></h3>
-
-
- <p> This code seems to be using non-short-circuit logic (e.g., &
-or |)
-rather than short-circuit logic (&& or ||). In addition,
-it seem possible that, depending on the value of the left hand side, you might not
-want to evaluate the right hand side (because it would have side effects, could cause an exception
-or could be expensive.</p>
-<p>
-Non-short-circuit logic causes both sides of the expression
-to be evaluated even when the result can be inferred from
-knowing the left-hand side. This can be less efficient and
-can result in errors if the left-hand side guards cases
-when evaluating the right-hand side can generate an error.
-</p>
-
-<p>See <a href="http://java.sun.com/docs/books/jls/third_edition/html/expressions.html#15.22.2">the Java
-Language Specification</a> for details
-
-</p>
-
-
-<h3><a name="NS_NON_SHORT_CIRCUIT">NS: Questionable use of non-short-circuit logic (NS_NON_SHORT_CIRCUIT)</a></h3>
-
-
- <p> This code seems to be using non-short-circuit logic (e.g., &
-or |)
-rather than short-circuit logic (&& or ||).
-Non-short-circuit logic causes both sides of the expression
-to be evaluated even when the result can be inferred from
-knowing the left-hand side. This can be less efficient and
-can result in errors if the left-hand side guards cases
-when evaluating the right-hand side can generate an error.
-
-<p>See <a href="http://java.sun.com/docs/books/jls/third_edition/html/expressions.html#15.22.2">the Java
-Language Specification</a> for details
-
-</p>
-
-
-<h3><a name="PZLA_PREFER_ZERO_LENGTH_ARRAYS">PZLA: Consider returning a zero length array rather than null (PZLA_PREFER_ZERO_LENGTH_ARRAYS)</a></h3>
-
-
-<p> It is often a better design to
-return a length zero array rather than a null reference to indicate that there
-are no results (i.e., an empty list of results).
-This way, no explicit check for null is needed by clients of the method.</p>
-
-<p>On the other hand, using null to indicate
-"there is no answer to this question" is probably appropriate.
-For example, <code>File.listFiles()</code> returns an empty list
-if given a directory containing no files, and returns null if the file
-is not a directory.</p>
-
-
-<h3><a name="QF_QUESTIONABLE_FOR_LOOP">QF: Complicated, subtle or wrong increment in for-loop (QF_QUESTIONABLE_FOR_LOOP)</a></h3>
-
-
- <p>Are you sure this for loop is incrementing the correct variable?
- It appears that another variable is being initialized and checked
- by the for loop.
-</p>
-
-
-<h3><a name="RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE">RCN: Redundant comparison of non-null value to null (RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE)</a></h3>
-
-
-<p> This method contains a reference known to be non-null with another reference
-known to be null.</p>
-
-
-<h3><a name="RCN_REDUNDANT_COMPARISON_TWO_NULL_VALUES">RCN: Redundant comparison of two null values (RCN_REDUNDANT_COMPARISON_TWO_NULL_VALUES)</a></h3>
-
-
-<p> This method contains a redundant comparison of two references known to
-both be definitely null.</p>
-
-
-<h3><a name="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE">RCN: Redundant nullcheck of value known to be non-null (RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)</a></h3>
-
-
-<p> This method contains a redundant check of a known non-null value against
-the constant null.</p>
-
-
-<h3><a name="RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE">RCN: Redundant nullcheck of value known to be null (RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE)</a></h3>
-
-
-<p> This method contains a redundant check of a known null value against
-the constant null.</p>
-
-
-<h3><a name="REC_CATCH_EXCEPTION">REC: Exception is caught when Exception is not thrown (REC_CATCH_EXCEPTION)</a></h3>
-
-
- <p>
- This method uses a try-catch block that catches Exception objects, but Exception is not
- thrown within the try block, and RuntimeException is not explicitly caught. It is a common bug pattern to
- say try { ... } catch (Exception e) { something } as a shorthand for catching a number of types of exception
- each of whose catch blocks is identical, but this construct also accidentally catches RuntimeException as well,
- masking potential bugs.
- </p>
-
-
-<h3><a name="RI_REDUNDANT_INTERFACES">RI: Class implements same interface as superclass (RI_REDUNDANT_INTERFACES)</a></h3>
-
-
- <p>
- This class declares that it implements an interface that is also implemented by a superclass.
- This is redundant because once a superclass implements an interface, all subclasses by default also
- implement this interface. It may point out that the inheritance hierarchy has changed since
- this class was created, and consideration should be given to the ownership of
- the interface's implementation.
- </p>
-
-
-<h3><a name="RV_CHECK_FOR_POSITIVE_INDEXOF">RV: Method checks to see if result of String.indexOf is positive (RV_CHECK_FOR_POSITIVE_INDEXOF)</a></h3>
-
-
- <p> The method invokes String.indexOf and checks to see if the result is positive or non-positive.
- It is much more typical to check to see if the result is negative or non-negative. It is
- positive only if the substring checked for occurs at some place other than at the beginning of
- the String.</p>
-
-
-<h3><a name="RV_DONT_JUST_NULL_CHECK_READLINE">RV: Method discards result of readLine after checking if it is nonnull (RV_DONT_JUST_NULL_CHECK_READLINE)</a></h3>
-
-
- <p> The value returned by readLine is discarded after checking to see if the return
-value is non-null. In almost all situations, if the result is non-null, you will want
-to use that non-null value. Calling readLine again will give you a different line.</p>
-
-
-<h3><a name="RV_REM_OF_HASHCODE">RV: Remainder of hashCode could be negative (RV_REM_OF_HASHCODE)</a></h3>
-
-
-<p> This code computes a hashCode, and then computes
-the remainder of that value modulo another value. Since the hashCode
-can be negative, the result of the remainder operation
-can also be negative. </p>
-<p> Assuming you want to ensure that the result of your computation is nonnegative,
-you may need to change your code.
-If you know the divisor is a power of 2,
-you can use a bitwise and operator instead (i.e., instead of
-using <code>x.hashCode()%n</code>, use <code>x.hashCode()&(n-1)</code>.
-This is probably faster than computing the remainder as well.
-If you don't know that the divisor is a power of 2, take the absolute
-value of the result of the remainder operation (i.e., use
-<code>Math.abs(x.hashCode()%n)</code>
-</p>
-
-
-<h3><a name="RV_REM_OF_RANDOM_INT">RV: Remainder of 32-bit signed random integer (RV_REM_OF_RANDOM_INT)</a></h3>
-
-
-<p> This code generates a random signed integer and then computes
-the remainder of that value modulo another value. Since the random
-number can be negative, the result of the remainder operation
-can also be negative. Be sure this is intended, and strongly
-consider using the Random.nextInt(int) method instead.
-</p>
-
-
-<h3><a name="SA_LOCAL_DOUBLE_ASSIGNMENT">SA: Double assignment of local variable (SA_LOCAL_DOUBLE_ASSIGNMENT)</a></h3>
-
-
-<p> This method contains a double assignment of a local variable; e.g.
-</p>
-<pre>
- public void foo() {
- int x,y;
- x = x = 17;
- }
-</pre>
-<p>Assigning the same value to a variable twice is useless, and may indicate a logic error or typo.</p>
-
-
-<h3><a name="SA_LOCAL_SELF_ASSIGNMENT">SA: Self assignment of local variable (SA_LOCAL_SELF_ASSIGNMENT)</a></h3>
-
-
-<p> This method contains a self assignment of a local variable; e.g.</p>
-<pre>
- public void foo() {
- int x = 3;
- x = x;
- }
-</pre>
-<p>
-Such assignments are useless, and may indicate a logic error or typo.
-</p>
-
-
-<h3><a name="SF_SWITCH_FALLTHROUGH">SF: Switch statement found where one case falls through to the next case (SF_SWITCH_FALLTHROUGH)</a></h3>
-
-
- <p> This method contains a switch statement where one case branch will fall through to the next case.
- Usually you need to end this case with a break or return.</p>
-
-
-<h3><a name="SF_SWITCH_NO_DEFAULT">SF: Switch statement found where default case is missing (SF_SWITCH_NO_DEFAULT)</a></h3>
-
-
- <p> This method contains a switch statement where default case is missing.
- Usually you need to provide a default case.</p>
-
-
-<h3><a name="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD">ST: Write to static field from instance method (ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)</a></h3>
-
-
- <p> This instance method writes to a static field. This is tricky to get
-correct if multiple instances are being manipulated,
-and generally bad practice.
-</p>
-
-
-<h3><a name="SE_PRIVATE_READ_RESOLVE_NOT_INHERITED">Se: private readResolve method not inherited by subclasses (SE_PRIVATE_READ_RESOLVE_NOT_INHERITED)</a></h3>
-
-
- <p> This class defines a private readResolve method. Since it is private, it won't be inherited by subclasses.
-This might be intentional and OK, but should be reviewed to ensure it is what is intended.
-</p>
-
-
-<h3><a name="SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS">Se: Transient field of class that isn't Serializable. (SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS)</a></h3>
-
-
- <p> The field is marked as transient, but the class isn't Serializable, so marking it as transient
-has absolutely no effect.
-This may be leftover marking from a previous version of the code in which the class was transient, or
-it may indicate a misunderstanding of how serialization works.
-</p>
-
-
-<h3><a name="TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK">TQ: Explicit annotation inconsistent with use (TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK)</a></h3>
-
-
- <p>
- A value is used in a way that requires it to be always be a value denoted by a type qualifier, but
- there is an explicit annotation stating that it is not known where the value is required to have that type qualifier.
- Either the usage or the annotation is incorrect.
- </p>
-
-
-<h3><a name="TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK">TQ: Explicit annotation inconsistent with use (TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK)</a></h3>
-
-
- <p>
- A value is used in a way that requires it to be never be a value denoted by a type qualifier, but
- there is an explicit annotation stating that it is not known where the value is prohibited from having that type qualifier.
- Either the usage or the annotation is incorrect.
- </p>
-
-
-<h3><a name="UCF_USELESS_CONTROL_FLOW">UCF: Useless control flow (UCF_USELESS_CONTROL_FLOW)</a></h3>
-
-
-<p> This method contains a useless control flow statement, where
-control flow continues onto the same place regardless of whether or not
-the branch is taken. For example,
-this is caused by having an empty statement
-block for an <code>if</code> statement:</p>
-<pre>
- if (argv.length == 0) {
- // TODO: handle this case
- }
-</pre>
-
-
-<h3><a name="UCF_USELESS_CONTROL_FLOW_NEXT_LINE">UCF: Useless control flow to next line (UCF_USELESS_CONTROL_FLOW_NEXT_LINE)</a></h3>
-
-
-<p> This method contains a useless control flow statement in which control
-flow follows to the same or following line regardless of whether or not
-the branch is taken.
-Often, this is caused by inadvertently using an empty statement as the
-body of an <code>if</code> statement, e.g.:</p>
-<pre>
- if (argv.length == 1);
- System.out.println("Hello, " + argv[0]);
-</pre>
-
-
-<h3><a name="UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR">UwF: Field not initialized in constructor (UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR)</a></h3>
-
-
- <p> This field is never initialized within any constructor, and is therefore could be null after
-the object is constructed.
-This could be a either an error or a questionable design, since
-it means a null pointer exception will be generated if that field is dereferenced
-before being initialized.
-</p>
-
-
-<h3><a name="XFB_XML_FACTORY_BYPASS">XFB: Method directly allocates a specific implementation of xml interfaces (XFB_XML_FACTORY_BYPASS)</a></h3>
-
-
- <p>
- This method allocates a specific implementation of an xml interface. It is preferable to use
- the supplied factory classes to create these objects so that the implementation can be
- changed at runtime. See
- </p>
- <ul>
- <li>javax.xml.parsers.DocumentBuilderFactory</li>
- <li>javax.xml.parsers.SAXParserFactory</li>
- <li>javax.xml.transform.TransformerFactory</li>
- <li>org.w3c.dom.Document.create<i>XXXX</i></li>
- </ul>
- <p>for details.</p>
-
-
-
-
-<hr> <p>
-<script language="JavaScript" type="text/javascript">
-<!---//hide script from old browsers
-document.write( "Last updated "+ document.lastModified + "." );
-//end hiding contents --->
-</script>
-<p> Send comments to <a class="sidebar" href="mailto:findbugs@cs.umd.edu">findbugs@cs.umd.edu</a>
-<p>
-<A href="http://sourceforge.net"><IMG src="http://sourceforge.net/sflogo.php?group_id=96405&type=5" width="210" height="62" border="0" alt="SourceForge.net Logo" /></A>
-</td></tr></table>
-</body></html>
diff --git a/tools/findbugs-1.3.9/doc/commons-modeler.html b/tools/findbugs-1.3.9/doc/commons-modeler.html
deleted file mode 100644
index c2ceff2..0000000
--- a/tools/findbugs-1.3.9/doc/commons-modeler.html
+++ /dev/null
@@ -1,841 +0,0 @@
-<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
-<html xmlns="http://www.w3.org/1999/xhtml">
-<head>
-<title>FindBugs Report</title>
-<style type="text/css">
- .tablerow0 {
- background: #EEEEEE;
- }
-
- .tablerow1 {
- background: white;
- }
-
- .detailrow0 {
- background: #EEEEEE;
- }
-
- .detailrow1 {
- background: white;
- }
-
- .tableheader {
- background: #b9b9fe;
- font-size: larger;
- }
-
- .tablerow0:hover, .tablerow1:hover {
- background: #aaffaa;
- }
- </style>
-<script type="text/javascript">
- function toggleRow(elid) {
- if (document.getElementById) {
- element = document.getElementById(elid);
- if (element) {
- if (element.style.display == 'none') {
- element.style.display = 'block';
- //window.status = 'Toggle on!';
- } else {
- element.style.display = 'none';
- //window.status = 'Toggle off!';
- }
- }
- }
- }
- </script>
-
-</head>
-<body>
-<h1>FindBugs Report</h1>
-<h2>Project Information</h2>
-<p>Project: /export/home/daveho/commons-modeler-1.1/commons-modeler.fb</p>
-<p>FindBugs version: 0.8.7</p>
-<p>Code analyzed:</p>
-<ul>
-<li>/export/home/daveho/commons-modeler-1.1/commons-modeler.jar</li>
-</ul>
-<h2>Contents</h2>
-<ul>
-<li>
-<a href="#Warnings_CORRECTNESS">Correctness Warnings</a>
-</li>
-<li>
-<a href="#Warnings_I18N">Internationalization Warnings</a>
-</li>
-<li>
-<a href="#Warnings_MT_CORRECTNESS">Multithreaded Correctness Warnings</a>
-</li>
-<li>
-<a href="#Warnings_MALICIOUS_CODE">Malicious Code Vulnerability Warnings</a>
-</li>
-<li>
-<a href="#Warnings_PERFORMANCE">Performance Warnings</a>
-</li>
-<li>
-<a href="#Warnings_STYLE">Style Warnings</a>
-</li>
-<li>
-<a href="#Details">Details</a>
-</li>
-</ul>
-<h1>Warnings</h1>
-<p>Click on a warning row to see full context information.</p>
-<h2>
-<a name="Warnings_CORRECTNESS">Correctness Warnings</a>
-</h2>
-<table class="warningtable" width="100%" cellspacing="0">
-<tr class="tableheader">
-<th align="left">Code </th>
-<th align="left">Warning</th>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N66047');">
-<td>IL</td>
-<td> There is an apparent infinite recursive loop in org.apache.commons.modeler.Registry.setServer(javax.management.MBeanServer).</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N66047" style="display: none;">
-<a href="#IL_INFINITE_RECURSIVE_LOOP">Bug type IL_INFINITE_RECURSIVE_LOOP (click for details)</a>
-<br/>In class org.apache.commons.modeler.Registry
-<br/>In method org.apache.commons.modeler.Registry.setServer(javax.management.MBeanServer)
-<br/>At Registry.java:[line 551]</p>
-</td>
-</tr>
-<tr class="tablerow0" onclick="toggleRow('N65687');">
-<td>NP</td>
-<td> Read of unwritten field in org.apache.commons.modeler.JndiJmx.handleNotification(javax.management.Notification,Object)</td>
-</tr>
-<tr class="detailrow0">
-<td/>
-<td>
-<p id="N65687" style="display: none;">
-<a href="#NP_UNWRITTEN_FIELD">Bug type NP_UNWRITTEN_FIELD (click for details)</a>
-<br/>In class org.apache.commons.modeler.JndiJmx
-<br/>In method org.apache.commons.modeler.JndiJmx.handleNotification(javax.management.Notification,Object)
-<br/>At JndiJmx.java:[line 173]</p>
-</td>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N66381');">
-<td>NP</td>
-<td> Read of unwritten field in org.apache.commons.modeler.mbeans.SimpleRemoteConnector.refreshAttributes()</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N66381" style="display: none;">
-<a href="#NP_UNWRITTEN_FIELD">Bug type NP_UNWRITTEN_FIELD (click for details)</a>
-<br/>In class org.apache.commons.modeler.mbeans.SimpleRemoteConnector
-<br/>In method org.apache.commons.modeler.mbeans.SimpleRemoteConnector.refreshAttributes()
-<br/>At SimpleRemoteConnector.java:[line 312]</p>
-</td>
-</tr>
-<tr class="tablerow0" onclick="toggleRow('N66193');">
-<td>NP</td>
-<td> Possible null pointer dereference in org.apache.commons.modeler.Registry.findManagedBeans(String)</td>
-</tr>
-<tr class="detailrow0">
-<td/>
-<td>
-<p id="N66193" style="display: none;">
-<a href="#NP_NULL_ON_SOME_PATH">Bug type NP_NULL_ON_SOME_PATH (click for details)</a>
-<br/>In class org.apache.commons.modeler.Registry
-<br/>In method org.apache.commons.modeler.Registry.findManagedBeans(String)
-<br/>At Registry.java:[line 507]</p>
-</td>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N66720');">
-<td>NP</td>
-<td> Possible null pointer dereference in org.apache.commons.modeler.util.IntrospectionUtils.findMethod(Class,String,Class[])</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N66720" style="display: none;">
-<a href="#NP_NULL_ON_SOME_PATH">Bug type NP_NULL_ON_SOME_PATH (click for details)</a>
-<br/>In class org.apache.commons.modeler.util.IntrospectionUtils
-<br/>In method org.apache.commons.modeler.util.IntrospectionUtils.findMethod(Class,String,Class[])
-<br/>At IntrospectionUtils.java:[line 858]</p>
-</td>
-</tr>
-<tr class="tablerow0" onclick="toggleRow('N65584');">
-<td>UCF</td>
-<td> Useless control flow in org.apache.commons.modeler.BaseNotificationBroadcaster.registerNotifications(FixedNotificationFilter)</td>
-</tr>
-<tr class="detailrow0">
-<td/>
-<td>
-<p id="N65584" style="display: none;">
-<a href="#UCF_USELESS_CONTROL_FLOW">Bug type UCF_USELESS_CONTROL_FLOW (click for details)</a>
-<br/>In class org.apache.commons.modeler.BaseNotificationBroadcaster
-<br/>In method org.apache.commons.modeler.BaseNotificationBroadcaster.registerNotifications(FixedNotificationFilter)
-<br/>At BaseNotificationBroadcaster.java:[line 280]</p>
-</td>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N65724');">
-<td>UwF</td>
-<td> Unwritten field: org.apache.commons.modeler.JndiJmx.mserver</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N65724" style="display: none;">
-<a href="#UWF_UNWRITTEN_FIELD">Bug type UWF_UNWRITTEN_FIELD (click for details)</a>
-<br/>In class org.apache.commons.modeler.JndiJmx
-<br/>Field org.apache.commons.modeler.JndiJmx.mserver</p>
-</td>
-</tr>
-<tr class="tablerow0" onclick="toggleRow('N66462');">
-<td>UwF</td>
-<td> Unwritten field: org.apache.commons.modeler.mbeans.SimpleRemoteConnector.mserver</td>
-</tr>
-<tr class="detailrow0">
-<td/>
-<td>
-<p id="N66462" style="display: none;">
-<a href="#UWF_UNWRITTEN_FIELD">Bug type UWF_UNWRITTEN_FIELD (click for details)</a>
-<br/>In class org.apache.commons.modeler.mbeans.SimpleRemoteConnector
-<br/>Field org.apache.commons.modeler.mbeans.SimpleRemoteConnector.mserver</p>
-</td>
-</tr>
-</table>
-<h2>
-<a name="Warnings_I18N">Internationalization Warnings</a>
-</h2>
-<table class="warningtable" width="100%" cellspacing="0">
-<tr class="tableheader">
-<th align="left">Code </th>
-<th align="left">Warning</th>
-</tr>
-</table>
-<h2>
-<a name="Warnings_MT_CORRECTNESS">Multithreaded Correctness Warnings</a>
-</h2>
-<table class="warningtable" width="100%" cellspacing="0">
-<tr class="tableheader">
-<th align="left">Code </th>
-<th align="left">Warning</th>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N66084');">
-<td>IS2</td>
-<td> Inconsistent synchronization of org.apache.commons.modeler.Registry.server; locked 66% of time</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N66084" style="display: none;">
-<a href="#IS2_INCONSISTENT_SYNC">Bug type IS2_INCONSISTENT_SYNC (click for details)</a>
-<br/>In class org.apache.commons.modeler.Registry
-<br/>Field org.apache.commons.modeler.Registry.server
-<br/>Synchronized 66% of the time
-<br/>Unsynchronized access at Registry.java:[line 1057]
-<br/>Unsynchronized access at Registry.java:[line 1016]
-<br/>Synchronized access at Registry.java:[line 658]
-<br/>Synchronized access at Registry.java:[line 671]
-<br/>Synchronized access at Registry.java:[line 665]
-<br/>Synchronized access at Registry.java:[line 660]</p>
-</td>
-</tr>
-</table>
-<h2>
-<a name="Warnings_MALICIOUS_CODE">Malicious Code Vulnerability Warnings</a>
-</h2>
-<table class="warningtable" width="100%" cellspacing="0">
-<tr class="tableheader">
-<th align="left">Code </th>
-<th align="left">Warning</th>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N65643');">
-<td>EI</td>
-<td> org.apache.commons.modeler.ConstructorInfo.getSignature() may expose internal representation by returning org.apache.commons.modeler.ConstructorInfo.parameters</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N65643" style="display: none;">
-<a href="#EI_EXPOSE_REP">Bug type EI_EXPOSE_REP (click for details)</a>
-<br/>In class org.apache.commons.modeler.ConstructorInfo
-<br/>In method org.apache.commons.modeler.ConstructorInfo.getSignature()
-<br/>Field org.apache.commons.modeler.ConstructorInfo.parameters
-<br/>At ConstructorInfo.java:[line 139]</p>
-</td>
-</tr>
-<tr class="tablerow0" onclick="toggleRow('N65746');">
-<td>EI</td>
-<td> org.apache.commons.modeler.ManagedBean.getAttributes() may expose internal representation by returning org.apache.commons.modeler.ManagedBean.attributes</td>
-</tr>
-<tr class="detailrow0">
-<td/>
-<td>
-<p id="N65746" style="display: none;">
-<a href="#EI_EXPOSE_REP">Bug type EI_EXPOSE_REP (click for details)</a>
-<br/>In class org.apache.commons.modeler.ManagedBean
-<br/>In method org.apache.commons.modeler.ManagedBean.getAttributes()
-<br/>Field org.apache.commons.modeler.ManagedBean.attributes
-<br/>At ManagedBean.java:[line 136]</p>
-</td>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N65790');">
-<td>EI</td>
-<td> org.apache.commons.modeler.ManagedBean.getConstructors() may expose internal representation by returning org.apache.commons.modeler.ManagedBean.constructors</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N65790" style="display: none;">
-<a href="#EI_EXPOSE_REP">Bug type EI_EXPOSE_REP (click for details)</a>
-<br/>In class org.apache.commons.modeler.ManagedBean
-<br/>In method org.apache.commons.modeler.ManagedBean.getConstructors()
-<br/>Field org.apache.commons.modeler.ManagedBean.constructors
-<br/>At ManagedBean.java:[line 160]</p>
-</td>
-</tr>
-<tr class="tablerow0" onclick="toggleRow('N65834');">
-<td>EI</td>
-<td> org.apache.commons.modeler.ManagedBean.getNotifications() may expose internal representation by returning org.apache.commons.modeler.ManagedBean.notifications</td>
-</tr>
-<tr class="detailrow0">
-<td/>
-<td>
-<p id="N65834" style="display: none;">
-<a href="#EI_EXPOSE_REP">Bug type EI_EXPOSE_REP (click for details)</a>
-<br/>In class org.apache.commons.modeler.ManagedBean
-<br/>In method org.apache.commons.modeler.ManagedBean.getNotifications()
-<br/>Field org.apache.commons.modeler.ManagedBean.notifications
-<br/>At ManagedBean.java:[line 230]</p>
-</td>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N65878');">
-<td>EI</td>
-<td> org.apache.commons.modeler.ManagedBean.getOperations() may expose internal representation by returning org.apache.commons.modeler.ManagedBean.operations</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N65878" style="display: none;">
-<a href="#EI_EXPOSE_REP">Bug type EI_EXPOSE_REP (click for details)</a>
-<br/>In class org.apache.commons.modeler.ManagedBean
-<br/>In method org.apache.commons.modeler.ManagedBean.getOperations()
-<br/>Field org.apache.commons.modeler.ManagedBean.operations
-<br/>At ManagedBean.java:[line 238]</p>
-</td>
-</tr>
-<tr class="tablerow0" onclick="toggleRow('N65922');">
-<td>EI</td>
-<td> org.apache.commons.modeler.NotificationInfo.getNotifTypes() may expose internal representation by returning org.apache.commons.modeler.NotificationInfo.notifTypes</td>
-</tr>
-<tr class="detailrow0">
-<td/>
-<td>
-<p id="N65922" style="display: none;">
-<a href="#EI_EXPOSE_REP">Bug type EI_EXPOSE_REP (click for details)</a>
-<br/>In class org.apache.commons.modeler.NotificationInfo
-<br/>In method org.apache.commons.modeler.NotificationInfo.getNotifTypes()
-<br/>Field org.apache.commons.modeler.NotificationInfo.notifTypes
-<br/>At NotificationInfo.java:[line 124]</p>
-</td>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N65966');">
-<td>EI</td>
-<td> org.apache.commons.modeler.OperationInfo.getSignature() may expose internal representation by returning org.apache.commons.modeler.OperationInfo.parameters</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N65966" style="display: none;">
-<a href="#EI_EXPOSE_REP">Bug type EI_EXPOSE_REP (click for details)</a>
-<br/>In class org.apache.commons.modeler.OperationInfo
-<br/>In method org.apache.commons.modeler.OperationInfo.getSignature()
-<br/>Field org.apache.commons.modeler.OperationInfo.parameters
-<br/>At OperationInfo.java:[line 212]</p>
-</td>
-</tr>
-<tr class="tablerow0" onclick="toggleRow('N66171');">
-<td>MS</td>
-<td> org.apache.commons.modeler.Registry.MODELER_MANIFEST isn't final but should be</td>
-</tr>
-<tr class="detailrow0">
-<td/>
-<td>
-<p id="N66171" style="display: none;">
-<a href="#MS_SHOULD_BE_FINAL">Bug type MS_SHOULD_BE_FINAL (click for details)</a>
-<br/>In class org.apache.commons.modeler.Registry
-<br/>Field org.apache.commons.modeler.Registry.MODELER_MANIFEST</p>
-</td>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N66698');">
-<td>MS</td>
-<td> org.apache.commons.modeler.util.IntrospectionUtils.PATH_SEPARATOR isn't final but should be</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N66698" style="display: none;">
-<a href="#MS_SHOULD_BE_FINAL">Bug type MS_SHOULD_BE_FINAL (click for details)</a>
-<br/>In class org.apache.commons.modeler.util.IntrospectionUtils
-<br/>Field org.apache.commons.modeler.util.IntrospectionUtils.PATH_SEPARATOR</p>
-</td>
-</tr>
-</table>
-<h2>
-<a name="Warnings_PERFORMANCE">Performance Warnings</a>
-</h2>
-<table class="warningtable" width="100%" cellspacing="0">
-<tr class="tableheader">
-<th align="left">Code </th>
-<th align="left">Warning</th>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N66010');">
-<td>Dm</td>
-<td> org.apache.commons.modeler.Registry.convertValue(String,String) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N66010" style="display: none;">
-<a href="#DM_BOOLEAN_CTOR">Bug type DM_BOOLEAN_CTOR (click for details)</a>
-<br/>In class org.apache.commons.modeler.Registry
-<br/>In method org.apache.commons.modeler.Registry.convertValue(String,String)
-<br/>At Registry.java:[line 761]</p>
-</td>
-</tr>
-<tr class="tablerow0" onclick="toggleRow('N66661');">
-<td>Dm</td>
-<td> org.apache.commons.modeler.util.IntrospectionUtils.setProperty(Object,String,String) invokes dubious Boolean constructor; use Boolean.valueOf(...) instead</td>
-</tr>
-<tr class="detailrow0">
-<td/>
-<td>
-<p id="N66661" style="display: none;">
-<a href="#DM_BOOLEAN_CTOR">Bug type DM_BOOLEAN_CTOR (click for details)</a>
-<br/>In class org.apache.commons.modeler.util.IntrospectionUtils
-<br/>In method org.apache.commons.modeler.util.IntrospectionUtils.setProperty(Object,String,String)
-<br/>At IntrospectionUtils.java:[line 347]</p>
-</td>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N66252');">
-<td>UrF</td>
-<td> Unread field: org.apache.commons.modeler.ant.MLETTask.archive</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N66252" style="display: none;">
-<a href="#URF_UNREAD_FIELD">Bug type URF_UNREAD_FIELD (click for details)</a>
-<br/>In class org.apache.commons.modeler.ant.MLETTask
-<br/>Field org.apache.commons.modeler.ant.MLETTask.archive</p>
-</td>
-</tr>
-<tr class="tablerow0" onclick="toggleRow('N66274');">
-<td>UrF</td>
-<td> Unread field: org.apache.commons.modeler.ant.MLETTask.codebase</td>
-</tr>
-<tr class="detailrow0">
-<td/>
-<td>
-<p id="N66274" style="display: none;">
-<a href="#URF_UNREAD_FIELD">Bug type URF_UNREAD_FIELD (click for details)</a>
-<br/>In class org.apache.commons.modeler.ant.MLETTask
-<br/>Field org.apache.commons.modeler.ant.MLETTask.codebase</p>
-</td>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N66318');">
-<td>UrF</td>
-<td> Unread field: org.apache.commons.modeler.ant.ModelerTask.log</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N66318" style="display: none;">
-<a href="#URF_UNREAD_FIELD">Bug type URF_UNREAD_FIELD (click for details)</a>
-<br/>In class org.apache.commons.modeler.ant.ModelerTask
-<br/>Field org.apache.commons.modeler.ant.ModelerTask.log</p>
-</td>
-</tr>
-<tr class="tablerow0" onclick="toggleRow('N66340');">
-<td>UrF</td>
-<td> Unread field: org.apache.commons.modeler.ant.RegistryTask.log</td>
-</tr>
-<tr class="detailrow0">
-<td/>
-<td>
-<p id="N66340" style="display: none;">
-<a href="#URF_UNREAD_FIELD">Bug type URF_UNREAD_FIELD (click for details)</a>
-<br/>In class org.apache.commons.modeler.ant.RegistryTask
-<br/>Field org.apache.commons.modeler.ant.RegistryTask.log</p>
-</td>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N65621');">
-<td>UrF</td>
-<td> Unread field: org.apache.commons.modeler.BaseNotificationBroadcaster.hookCount</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N65621" style="display: none;">
-<a href="#URF_UNREAD_FIELD">Bug type URF_UNREAD_FIELD (click for details)</a>
-<br/>In class org.apache.commons.modeler.BaseNotificationBroadcaster
-<br/>Field org.apache.commons.modeler.BaseNotificationBroadcaster.hookCount</p>
-</td>
-</tr>
-<tr class="tablerow0" onclick="toggleRow('N66418');">
-<td>UrF</td>
-<td> Unread field: org.apache.commons.modeler.mbeans.SimpleRemoteConnector.prefix</td>
-</tr>
-<tr class="detailrow0">
-<td/>
-<td>
-<p id="N66418" style="display: none;">
-<a href="#URF_UNREAD_FIELD">Bug type URF_UNREAD_FIELD (click for details)</a>
-<br/>In class org.apache.commons.modeler.mbeans.SimpleRemoteConnector
-<br/>Field org.apache.commons.modeler.mbeans.SimpleRemoteConnector.prefix</p>
-</td>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N66521');">
-<td>UrF</td>
-<td> Unread field: org.apache.commons.modeler.modules.MbeansDescriptorsDOMSource.type</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N66521" style="display: none;">
-<a href="#URF_UNREAD_FIELD">Bug type URF_UNREAD_FIELD (click for details)</a>
-<br/>In class org.apache.commons.modeler.modules.MbeansDescriptorsDOMSource
-<br/>Field org.apache.commons.modeler.modules.MbeansDescriptorsDOMSource.type</p>
-</td>
-</tr>
-<tr class="tablerow0" onclick="toggleRow('N66543');">
-<td>UrF</td>
-<td> Unread field: org.apache.commons.modeler.modules.MbeansDescriptorsSerSource.type</td>
-</tr>
-<tr class="detailrow0">
-<td/>
-<td>
-<p id="N66543" style="display: none;">
-<a href="#URF_UNREAD_FIELD">Bug type URF_UNREAD_FIELD (click for details)</a>
-<br/>In class org.apache.commons.modeler.modules.MbeansDescriptorsSerSource
-<br/>Field org.apache.commons.modeler.modules.MbeansDescriptorsSerSource.type</p>
-</td>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N66639');">
-<td>UrF</td>
-<td> Unread field: org.apache.commons.modeler.modules.MbeansSource.type</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N66639" style="display: none;">
-<a href="#URF_UNREAD_FIELD">Bug type URF_UNREAD_FIELD (click for details)</a>
-<br/>In class org.apache.commons.modeler.modules.MbeansSource
-<br/>Field org.apache.commons.modeler.modules.MbeansSource.type</p>
-</td>
-</tr>
-<tr class="tablerow0" onclick="toggleRow('N66230');">
-<td>UrF</td>
-<td> Unread field: org.apache.commons.modeler.Registry.key</td>
-</tr>
-<tr class="detailrow0">
-<td/>
-<td>
-<p id="N66230" style="display: none;">
-<a href="#URF_UNREAD_FIELD">Bug type URF_UNREAD_FIELD (click for details)</a>
-<br/>In class org.apache.commons.modeler.Registry
-<br/>Field org.apache.commons.modeler.Registry.key</p>
-</td>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N66296');">
-<td>UuF</td>
-<td> Unused field: org.apache.commons.modeler.ant.MLETTask.loaderRef</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N66296" style="display: none;">
-<a href="#UUF_UNUSED_FIELD">Bug type UUF_UNUSED_FIELD (click for details)</a>
-<br/>In class org.apache.commons.modeler.ant.MLETTask
-<br/>Field org.apache.commons.modeler.ant.MLETTask.loaderRef</p>
-</td>
-</tr>
-<tr class="tablerow0" onclick="toggleRow('N66440');">
-<td>UuF</td>
-<td> Unused field: org.apache.commons.modeler.mbeans.SimpleRemoteConnector.localDomain</td>
-</tr>
-<tr class="detailrow0">
-<td/>
-<td>
-<p id="N66440" style="display: none;">
-<a href="#UUF_UNUSED_FIELD">Bug type UUF_UNUSED_FIELD (click for details)</a>
-<br/>In class org.apache.commons.modeler.mbeans.SimpleRemoteConnector
-<br/>Field org.apache.commons.modeler.mbeans.SimpleRemoteConnector.localDomain</p>
-</td>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N66484');">
-<td>WMI</td>
-<td> Method org.apache.commons.modeler.mbeans.SimpleRemoteConnector.refreshAttributes() makes inefficient use of keySet iterator instead of entrySet iterator</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N66484" style="display: none;">
-<a href="#WMI_WRONG_MAP_ITERATOR">Bug type WMI_WRONG_MAP_ITERATOR (click for details)</a>
-<br/>In class org.apache.commons.modeler.mbeans.SimpleRemoteConnector
-<br/>In method org.apache.commons.modeler.mbeans.SimpleRemoteConnector.refreshAttributes()
-<br/>At SimpleRemoteConnector.java:[line 272]</p>
-</td>
-</tr>
-</table>
-<h2>
-<a name="Warnings_STYLE">Style Warnings</a>
-</h2>
-<table class="warningtable" width="100%" cellspacing="0">
-<tr class="tableheader">
-<th align="left">Code </th>
-<th align="left">Warning</th>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N66362');">
-<td>CD</td>
-<td> Class org.apache.commons.modeler.mbeans.SimpleRemoteConnector has a circular dependency with other classes.</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N66362" style="display: none;">
-<a href="#CD_CIRCULAR_DEPENDENCY">Bug type CD_CIRCULAR_DEPENDENCY (click for details)</a>
-<br/>In class org.apache.commons.modeler.mbeans.SimpleRemoteConnector
-<br/>In class org.apache.commons.modeler.mbeans.MBeanProxy</p>
-</td>
-</tr>
-<tr class="tablerow0" onclick="toggleRow('N65547');">
-<td>DLS</td>
-<td> Dead store to local variable in method org.apache.commons.modeler.BaseModelMBean.setAttributes(javax.management.AttributeList)</td>
-</tr>
-<tr class="detailrow0">
-<td/>
-<td>
-<p id="N65547" style="display: none;">
-<a href="#DLS_DEAD_LOCAL_STORE">Bug type DLS_DEAD_LOCAL_STORE (click for details)</a>
-<br/>In class org.apache.commons.modeler.BaseModelMBean
-<br/>In method org.apache.commons.modeler.BaseModelMBean.setAttributes(javax.management.AttributeList)
-<br/>At BaseModelMBean.java:[line 723]</p>
-</td>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N66565');">
-<td>REC</td>
-<td> Method org.apache.commons.modeler.modules.MbeansSource.execute() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N66565" style="display: none;">
-<a href="#REC_CATCH_EXCEPTION">Bug type REC_CATCH_EXCEPTION (click for details)</a>
-<br/>In class org.apache.commons.modeler.modules.MbeansSource
-<br/>In method org.apache.commons.modeler.modules.MbeansSource.execute()
-<br/>At MbeansSource.java:[line 226]</p>
-</td>
-</tr>
-<tr class="tablerow0" onclick="toggleRow('N66602');">
-<td>REC</td>
-<td> Method org.apache.commons.modeler.modules.MbeansSource.execute() catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught</td>
-</tr>
-<tr class="detailrow0">
-<td/>
-<td>
-<p id="N66602" style="display: none;">
-<a href="#REC_CATCH_EXCEPTION">Bug type REC_CATCH_EXCEPTION (click for details)</a>
-<br/>In class org.apache.commons.modeler.modules.MbeansSource
-<br/>In method org.apache.commons.modeler.modules.MbeansSource.execute()
-<br/>At MbeansSource.java:[line 250]</p>
-</td>
-</tr>
-<tr class="tablerow1" onclick="toggleRow('N66757');">
-<td>REC</td>
-<td> Method org.apache.commons.modeler.util.IntrospectionUtils.setProperty(Object,String) catches Exception, but Exception is not thrown in the try block and RuntimeException is not explicitly caught</td>
-</tr>
-<tr class="detailrow1">
-<td/>
-<td>
-<p id="N66757" style="display: none;">
-<a href="#REC_CATCH_EXCEPTION">Bug type REC_CATCH_EXCEPTION (click for details)</a>
-<br/>In class org.apache.commons.modeler.util.IntrospectionUtils
-<br/>In method org.apache.commons.modeler.util.IntrospectionUtils.setProperty(Object,String)
-<br/>At IntrospectionUtils.java:[line 479]</p>
-</td>
-</tr>
-</table>
-<h1>
-<a name="Details">Details</a>
-</h1>
-<h2>
-<a name="CD_CIRCULAR_DEPENDENCY">CD_CIRCULAR_DEPENDENCY: Test for circular dependencies among classes.</a>
-</h2>
-
- <p>
- This class has a circular dependency with other classes. This makes building these classes
- difficult, as each is dependent on the other to build correctly. Consider using interfaces
- to break the hard dependency.
- </p>
-
-
-<h2>
-<a name="DLS_DEAD_LOCAL_STORE">DLS_DEAD_LOCAL_STORE: Dead store to local variable</a>
-</h2>
-
-<p>
-This instruction assigns a value to a local variable,
-but the value is not read by any subsequent instruction.
-Often, this indicates an error, because the value computed
-is never used.
-</p>
-
-
-<h2>
-<a name="DM_BOOLEAN_CTOR">DM_BOOLEAN_CTOR: Method invokes dubious Boolean constructor; use Boolean.valueOf(...) instead</a>
-</h2>
-
- <p> Creating new instances of <code>java.lang.Boolean</code> wastes
- memory, since <code>Boolean</code> objects are immutable and there are
- only two useful values of this type. Use the <code>Boolean.valueOf()</code>
- method to create <code>Boolean</code> objects instead.</p>
-
-
-<h2>
-<a name="EI_EXPOSE_REP">EI_EXPOSE_REP: Method may expose internal representation by returning reference to mutable object</a>
-</h2>
-
- <p> Returning a reference to a mutable object value stored in one of the object's fields
- exposes the internal representation of the object.
- If instances
- are accessed by untrusted code, and unchecked changes to
- the mutable object would compromise security or other
- important properties, you will need to do something different.
- Returning a new copy of the object is better approach in many situations.</p>
-
-
-<h2>
-<a name="IL_INFINITE_RECURSIVE_LOOP">IL_INFINITE_RECURSIVE_LOOP: An apparent infinite recursive loop.</a>
-</h2>
-
-<p>This method unconditionally invokes itself. This would seem to indicate
-an infinite recursive loop that will result in a stack overflow.</p>
-
-
-<h2>
-<a name="IS2_INCONSISTENT_SYNC">IS2_INCONSISTENT_SYNC: Inconsistent synchronization</a>
-</h2>
-
- <p> The fields of this class appear to be accessed inconsistently with respect
- to synchronization. This bug report indicates that the bug pattern detector
- judged that
- <ol>
- <li> The class contains a mix of locked and unlocked accesses,</li>
- <li> At least one locked access was performed by one of the class's own methods, and</li>
- <li> The number of unsynchronized field accesses (reads and writes) was no more than
- one third of all accesses, with writes being weighed twice as high as reads</li>
- </ol>
- </p>
-
- <p> A typical bug matching this bug pattern is forgetting to synchronize
- one of the methods in a class that is intended to be thread-safe.</p>
-
- <p> You can select the nodes labeled "Unsynchronized access" to show the
- code locations where the detector believed that a field was accessed
- without synchronization.</p>
-
- <p> Note that there are various sources of inaccuracy in this detector;
- for example, the detector cannot statically detect all situations in which
- a lock is held. Also, even when the detector is accurate in
- distinguishing locked vs. unlocked accesses, the code in question may still
- be correct.</p>
-
- <p> This description refers to the "IS2" version of the pattern detector,
- which has more accurate ways of detecting locked vs. unlocked accesses
- than the older "IS" detector.</p>
-
-
-<h2>
-<a name="MS_SHOULD_BE_FINAL">MS_SHOULD_BE_FINAL: Field isn't final but should be</a>
-</h2>
-
- <p>
- A mutable static field could be changed by malicious code or
- by accident from another package.
- The field could be made final to avoid
- this vulnerability.</p>
-
-
-<h2>
-<a name="NP_NULL_ON_SOME_PATH">NP_NULL_ON_SOME_PATH: Possible null pointer dereference in method</a>
-</h2>
-
-<p> A reference value dereferenced here might be null at runtime.
-This may lead to a <code>NullPointerException</code> when the code is executed.</p>
-
-
-<h2>
-<a name="NP_UNWRITTEN_FIELD">NP_UNWRITTEN_FIELD: Read of unwritten field</a>
-</h2>
-
- <p> The program is deferencing a field that does not seem to ever be
-written to. Deferencing this value will generate a null pointer exception.
-</p>
-
-
-<h2>
-<a name="REC_CATCH_EXCEPTION">REC_CATCH_EXCEPTION: java.lang.Exception is caught when Exception is not thrown</a>
-</h2>
-
- <p>
- This method uses a try-catch block that catches Exception objects, but Exception is not
- thrown within the try block, and RuntimeException is not explicitly caught. It is a common bug pattern to
- say try { ... } catch (Exception e) { something } as a shorthand for catching a number of types of exception
- each of whose catch blocks is identical, but this construct also accidentally catches RuntimeException as well,
- masking potential bugs.
- </p>
-
-
-<h2>
-<a name="UCF_USELESS_CONTROL_FLOW">UCF_USELESS_CONTROL_FLOW: Useless control flow in method</a>
-</h2>
-
-<p> This method contains a useless control flow statement.
-Often, this is caused by inadvertently using an empty statement as the
-body of an <code>if</code> statement, e.g.:</p>
-<pre>
- if (argv.length == 1);
- System.out.println("Hello, " + argv[0]);
-</pre>
-
-
-<h2>
-<a name="URF_UNREAD_FIELD">URF_UNREAD_FIELD: Unread field</a>
-</h2>
-
- <p> This field is never read. Consider removing it from the class.</p>
-
-
-<h2>
-<a name="UUF_UNUSED_FIELD">UUF_UNUSED_FIELD: Unused field</a>
-</h2>
-
- <p> This field is never used. Consider removing it from the class.</p>
-
-
-<h2>
-<a name="UWF_UNWRITTEN_FIELD">UWF_UNWRITTEN_FIELD: Unwritten field</a>
-</h2>
-
- <p> This field is never written. All reads of it will return the default
-value. Check for errors (should it have been initialized?), or remove it if it is useless.</p>
-
-
-<h2>
-<a name="WMI_WRONG_MAP_ITERATOR">WMI_WRONG_MAP_ITERATOR: Inefficient use of keySet iterator instead of entrySet iterator</a>
-</h2>
-
-<p> This method accesses the value of a Map entry, using a key that was retrieved from
-a keySet iterator. It is more efficient to use an iterator on the entrySet of the map, to avoid the
-Map.get(key) lookup.</p>
-
- </body>
-</html>
diff --git a/tools/findbugs-1.3.9/doc/index.html b/tools/findbugs-1.3.9/doc/index.html
deleted file mode 100644
index 519ed2b..0000000
--- a/tools/findbugs-1.3.9/doc/index.html
+++ /dev/null
@@ -1,327 +0,0 @@
-<html>
- <head>
- <title>FindBugs™ - Find Bugs in Java Programs</title>
- <link rel="stylesheet" type="text/css" href="findbugs.css" />
-
- </head>
-
- <body>
-
- <table width="100%">
- <tr>
-
-
-<td bgcolor="#b9b9fe" valign="top" align="left" width="20%">
-<table width="100%" cellspacing="0" border="0">
-<tr><td><a class="sidebar" href="index.html"><img src="umdFindbugs.png" alt="FindBugs"></a></td></tr>
-
-<tr><td> </td></tr>
-
-<tr><td><b>Docs and Info</b></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="factSheet.html">Fact sheet</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="manual/index.html">Manual</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="ja/manual/index.html">Manual(ja/日本語)</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="FAQ.html">FAQ</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="bugDescriptions.html">Bug descriptions</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="mailingLists.html">Mailing lists</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="publications.html">Documents and Publications</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="links.html">Links</a></font></td></tr>
-
-<tr><td> </td></tr>
-
-<tr><td><a class="sidebar" href="downloads.html"><b>Downloads</b></a></td></tr>
-
-<tr><td> </td></tr>
-
-<tr><td><a class="sidebar" href="http://www.cafeshops.com/findbugs"><b>FindBugs Swag</b></a></td></tr>
-
-<tr><td> </td></tr>
-
-<tr><td><b>Development</b></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="http://sourceforge.net/tracker/?group_id=96405">Open bugs</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="reportingBugs.html">Reporting bugs</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="contributing.html">Contributing</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="team.html">Dev team</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="api/index.html">API</a> <a class="sidebar" href="api/overview-summary.html">[no frames]</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="Changes.html">Change log</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="http://sourceforge.net/projects/findbugs">SF project page</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="http://code.google.com/p/findbugs/source/browse/">Browse source</a></font></td></tr>
-<tr><td><font size="-1"><a class="sidebar" href="http://code.google.com/p/findbugs/source/list">Latest code changes</a></font></td></tr>
-</table>
-</td>
-
- <td align="left" valign="top">
-
- <p>
- <table><tr>
- <td valign="center">
- <a href="http://findbugs.sourceforge.net/"><img src="buggy-sm.png"
- alt="FindBugs logo" border="0" /> </a>
- <td valign="center"> <a href="http://www.umd.edu/"><img src="informal.png"
- alt="UMD logo" border="0" /> </a>
- </tr></table>
-
- <h1>
- FindBugs™ - Find Bugs in Java Programs
- </h1>
-
- <p>
- This is the web page for FindBugs, a program which uses static analysis
- to look for bugs
- in Java code. It is free software, distributed under the
- terms of the
- <a href="http://www.gnu.org/licenses/lgpl.html">Lesser GNU
- Public License</a>. The name FindBugs™ and the
- <a href="buggy-sm.png">FindBugs logo</a> are trademarked by
- <a href="http://www.umd.edu">The University of Maryland</a>.
- As of July, 2008, FindBugs has been downloaded more than 700,000 times.
- </p>
-
-
- <p>
- FindBugs requires JRE (or JDK) 1.5.0 or later to run.
- However, it can analyze programs compiled for any version of Java.
- The current version of FindBugs is 1.3.9, released on
- 16:39:49 EDT, 21 August, 2009.
- <a href="reportingBugs.html">We are very interested in getting feedback on how to improve
- FindBugs</a>.
- </p>
-
- <p>
- <a href="#changes">Changes</a> |
- <a href="#talks">Talks</a> |
- <a href="#papers">Papers </a> |
- <a href="#sponsors">Sponsors</a> |
- <a href="#support">Support</a>
- </p>
- <h1>New</h1>
-
-<ul>
-<li><p><b>JavaOne talk</b>:
- <a href="http://www.cs.umd.edu/~pugh/MistakesThatMatter.pdf">Slides</a> from my JavaOne talk,
- Mistakes That Matter.
- <li><p><b>FindBugs community review</b>: We are previewing FindBugs community review,
- in which anyone can review issues in open source projects (i.e., mark
- issues as "must fix" or "mostly harmless"), and those reviews
- are automatically shared with other reviewers.
- <p>This is a pre-beta release, not ready for deployment. The implementation
- will be undergoing significant changes before general availability.
- <p>Initially, we are posting results for:
- <ul>
- <li>
- <a href="http://findbugs.cs.umd.edu/cloud/jdk7.jnlp">Sun's JDK 7</a>
- <li>
- <a href="http://findbugs.cs.umd.edu/cloud/eclipse.jnlp">Eclipse 3.5</a>
- </ul>
-
-
-<li><b>Google FindBugs Fixit</b>: Google has a tradition of <a href="http://www.nytimes.com/2007/10/21/jobs/21pre.html">engineering fixits</a>, special days where they try to get all of their engineers focused on some specific problem or technique for improving the systems at Google. A fixit might work to improve web accessibility, internal testing, removing TODO's from internal software, etc.
-
-<p>On May 13-14, Google held a global fixit for UMD's FindBugs tool a static analysis tool for finding coding mistakes in Java software. The focus of the fixit was to get feedback on the 4,000 highest confidence issues found by FindBugs at Google, and let Google engineers decide which issues, if any, needed fixing.
-
-
-
-<p>More than 700 engineers ran FindBugs from dozens of offices. More than 250 of them entered more than 8,000 reviews of the issues. A review is a classification of an issue as must-fix, should-fix, mostly-harmless, not-a-bug, and several other categories. More than 75% of the reviews classified issues as must fix, should fix or I will fix. Many of the scariest issues received more than 10 reviews each.
-
-<p>Engineers have already submitted changes that made more than 1,100 of the 3,800 issues go away. Engineers filed more than 1,700 bug reports, of which 600 have already been marked as fixed Work continues on addressing the issues raised by the fixit, and on supporting the integration of FindBugs into the software development process at Google.
-
-<p>The fixit at Google showcased new capabilities of FindBugs that provide a cloud computing / social networking backdrop. Reviews of issues are immediately persisted into a central store, where they can be seen by other developers, and FindBugs is integrated into the internal Google tools for filing and viewing bug reports and for viewing the version control history of source files. For the Fixit, FindBugs was configured in a mode where engineers could not see reviews from other engineers until they had entered their own; after the fixit, the configuration will be changed to a more open configuration where engineers can see reviews from others without having to provide their own review first. These capabilities have all been contributed to UMD's open source FindBugs tool, although a fair bit of engineering remains to prepare the capabilities for general release and make sure they can integrate into systems outside of Google. The new capabilities are expected to be ready for general release in Fall 2009.
-
-
- </ul>
-
- <h1>
- <a name="changes">Change history</a>
- </h1>
- <p> The current version of FindBugs is s 1.3.9.</p>
-
-
- <p> Changes since version 1.3.7</p>
- <ul>
- <li>Primarily another small bugfix release.</li>
- <li>FindBugs base:</li>
- <ul>
- <li>New Reports:</li>
- <ul>
- <li>SF_SWITCH_NO_DEFAULT: missing default case in switch statement.</li>
- <li>SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH_TO_THROW: value ignored when switch fallthrough leads to
- thrown exception.</li>
- <li>INT_VACUOUS_BIT_OPERATION: bit operations that don't do any meaningful work.</li>
- <li>FB_UNEXPECTED_WARNING: warning generated that conflicts with @NoWarning FindBugs annotation.</li>
- <li>FB_MISSING_EXPECTED_WARNING: warning not generated despite presence of @ExpectedWarning FindBugs annotation.</li>
- <li>NOISE category: intended for use in data mining experiments.</li>
- <ul>
- <li>NOISE_NULL_DEREFERENCE: fake null point dereference warning.</li>
- <li>NOISE_METHOD_CALL: fake method call warning.</li>
- <li>NOISE_FIELD_REFERENCE: fake field dereference warning.</li>
- <li>NOISE_OPERATION: fake operation warning.</li>
- </ul>
- </ul>
- <li>Other:</li>
- <ul>
- <li>Garvin Leclaire has created a new Apache Maven repository for FindBugs at
- <a href="http://code.google.com/p/findbugs/">the Google Code FindBugs SVN repository</a>. (Thanks Garvin!)</li>
- </ul>
- <li>Fixes:</li>
- <ul>
- <li>[ 2317842 ] Highlighting broken in Windows</li>
- <li>[ 2515908 ] check for oddness should track sign of argument</li>
- <li>[ 2487936 ] "L B GC" false pos cast from Map.Entry.getKey() to Map.get()</li>
- <li>[ 2528264 ] Ant tasks not compatible with Ant 1.7.1</li>
- <li>[ 2539590 ] SF_SWITCH_FALLTHROUGH wrong message reported </li>
- <li>[ 2020066 ] Bug history displayed in fancy-hist.xsl is incorrect</li>
- <li>[ 2545098 ] Invalid character in analysis results file</li>
- <li>[ 2492673 ] Plugin sites should specify 'requires Eclipse 3.3 or newer'</li>
- <li>[ 2588044 ] a tiny typing error</li>
- <li>[ 2589048 ] Documentation for convertXmlToText insufficient</li>
- <li>[ 2638739 ] NullPointerException when building</li>
- </ul>
- <li>Patches:</li>
- <ul>
- <li>[ 2538184 ] Make BugCollection implement Iterable<BugInstance> (thanks to Tomas Pollak)</li>
- <li>[ 2249771 ] Add Maven2 Findbugs plugin link to the Links page (thanks to Garvin Leclaire)</li>
- <li>[ 2609526 ] Japanese manual update (thanks to K. Hashimoto)</li>
- <li>[ 2119482 ] CheckBcel checks for nonexistent classes (thanks to Jerry James)</li>
- </ul>
- </ul>
- <li>FindBugs Eclipse plugin:</li>
- <ul>
- <li>Major feature enhancements (thanks to Andrei Loskutov).
- See <a href="http://andrei.gmxhome.de/findbugs/index.html">this overview</a> for more information.</li>
- <li>Major test improvements (thanks to Tomas Pollak).</li>
- <li>Fixes:</li>
- <ul>
- <li>[ 2532365 ] Compiler warning</li>
- <li>[ 2522989 ] Fix filter files selection</li>
- <li>[ 2504068 ] NullPointerException</li>
- <li>[ 2640849 ] NPE in Eclipse plugin 1.3.7 and Eclipse 3.5 M5</li>
- </ul>
- <li>Patches:</li>
- <ul>
- <li>[ 2143140 ] Unchecked conversion fixes for Eclipse plugin (thanks to Jerry James)
- </ul>
- </ul>
- </ul>
- </ul>
-
-
- <p>
- <a href="Changes.html">Older versions...</a>
- </p>
-
- <h1>
- <a name="talks">Talks about FindBugs</a>
- </h1>
- <ul>
- <p><a href="http://www.cs.umd.edu/~pugh/MistakesThatMatter.pdf">Mistakes That Matter</a>, JavaOne, 2009
-
- <li>
- <a href="http://findbugs.cs.umd.edu/talks/findbugs.mov">Quicktime
- movie</a> showing of demo of our new GUI to view some of the null
- pointer bugs in Eclipse (Big file warning: 23 Megabytes)
-
- </li>
- <li><a href="http://findbugs.cs.umd.edu/talks/JavaOne2007-TS2007.pdf">JavaOne 2007 talk on Improving Software Quality Using Static Analysis</a>
- <li>
- <a href="http://findbugs.cs.umd.edu/talks/fb-sdbp-2006.pdf">Talk</a>
- Bill Pugh gave at
- <a href="http://www.sdexpo.com/2006/sdbp/">SD Best Practices</a>,
- Sept 14th (more of a handle on tutorial about using FindBugs)
- </li>
- <li>
- <a href="http://findbugs.cs.umd.edu/talks/fb-Sept1213-2006.pdf">Talk</a>
- Bill Pugh gave at
- <a href="http://itasoftware.com/">ITA Software</a> and
- <a href="http://www.csail.mit.edu/">MIT</a>, Sept 12th and 13th
- (more of a research focus)
- </li>
- <li>
- <a
- href="http://video.google.com/videoplay?docid=-8150751070230264609">Video
- of talk</a> Bill Pugh gave at
- <a href="http://www.google.com">Google</a>, July 6th, 2006
- </li>
- <li>
- <a href="http://javaposse.com/index.php?post_id=95780">Java
- Posse podcast interview with Bill Pugh and Brian Goetz</a>
- </li>
- </ul>
- <h1><a name="papers">Papers about FindBugs</a></h1>
- <ul>
- <li><a href="http://findbugs.cs.umd.edu/papers/MoreNullPointerBugs07.pdf">Finding More Null Pointer Bugs,
- But Not Too Many</a>, by
- <a href="http://faculty.ycp.edu/~dhovemey/">David Hovemeyer</a>, York College of Pennsylvania
- and <a href="http://www.cs.umd.edu/~pugh/">William Pugh</a>, Univ. of Maryland,
- <a href="http://paste07.cs.washington.edu/">7th ACM SIGPLAN-SIGSOFT Workshop on Program Analysis for Software Tools and Engineering</a>,
- June, 2007
-
- <li><a href="http://findbugs.cs.umd.edu/papers/FindBugsExperiences07.pdf">Evaluating Static Analysis
- Defect Warnings On Production Software,</a>
- <a href="http://www.cs.umd.edu/~nat/">Nathaniel Ayewah and <a href="http://www.cs.umd.edu/~pugh/">William Pugh</a>, Univ. of Maryland, and
- J. David Morgenthaler, John Penix and YuQian Zhou, Google, Inc.,
- <a href="http://paste07.cs.washington.edu/">7th ACM SIGPLAN-SIGSOFT Workshop on Program Analysis for Software Tools and Engineering</a>,
- June, 2007
- </ul>
-
-
- <h1>
- <a name="sponsors">Sponsors</a>
- </h1>
- <p>None, at the moment. We'd be very interested in any offers of support or
- sponsorship.
-
- <h1><a name="support">Additional Support</a></h1>
- <p>
- YourKit is kindly supporting open source projects with its full-featured Java Profiler.
- YourKit, LLC is creator of innovative and intelligent tools for profiling
- Java and .NET applications. Take a look at YourKit's leading software products:
- <a href="http://www.yourkit.com/java/profiler/index.jsp">YourKit Java Profiler</a> and
- <a href="http://www.yourkit.com/.net/profiler/index.jsp">YourKit .NET Profiler</a>.
- </p>
- <p>
- The FindBugs project also uses
- <a href="http://www.atlassian.com/software/fisheye/">FishEye</a> and
- <a href="http://www.atlassian.com/software/clover/">Clover</a>,
- which are generously provided by
- <a href="http://www.cenqua.com/">Cenqua/Atlassian</a>.
- </p>
- <p>
- Additional financial support for the FindBugs project has been provided by
- <a href="http://www.google.com">Google</a>,
- <a href="http://www.sun.com">Sun Microsystems</a>,
- <a href="http://www.nsf.gov">National Science Foundation</a>
- grants ASC9720199 and CCR-0098162,
- <a href="http://www.fortify.com/">Fortify Software</a>,
- <a href="http://www.surelogic.com/">SureLogic</a>,
-
-
-and by a 2004
- <a
- href="http://www-306.ibm.com/software/info/university/products/eclipse/eig-2004.html">IBM
- Eclipse Innovation award</a>.
- </p>
- <p>
- Any opinions, findings and conclusions or recommendations
- expressed in this material are those of the author(s) and do not
- necessarily reflect the views of the National Science Foundation
- (NSF).
-<hr> <p>
-<script language="JavaScript" type="text/javascript">
-<!---//hide script from old browsers
-document.write( "Last updated "+ document.lastModified + "." );
-//end hiding contents --->
-</script>
-<p> Send comments to <a class="sidebar" href="mailto:findbugs@cs.umd.edu">findbugs@cs.umd.edu</a>
-<p>
-<A href="http://sourceforge.net"><IMG src="http://sourceforge.net/sflogo.php?group_id=96405&type=5" width="210" height="62" border="0" alt="SourceForge.net Logo" /></A>
-
- </p>
- </td>
- </tr>
- </table>
-
- </body>
-</html>
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/acknowledgments.html b/tools/findbugs-1.3.9/doc/ja/manual/acknowledgments.html
deleted file mode 100644
index 4b68828..0000000
--- a/tools/findbugs-1.3.9/doc/ja/manual/acknowledgments.html
+++ /dev/null
@@ -1,123 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>第14章 謝辞</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ マニュアル"><link rel="up" href="index.html" title="FindBugs™ マニュアル"><link rel="prev" href="license.html" title="第13章 ライセンス"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">第14章 謝辞</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="license.html">前のページ</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> </td></tr></table><hr></div><div class="chapter" lang="ja"><div class="titlepage"><div><div><h2 class="title"><a name="acknowledgments"></a>第14章 謝辞</h2></div></div></div><div class="toc"><p><b>目次</b></p><dl><dt><span class="sect1"><a href="acknowledgments.html#d0e3438">1. 貢献者</a></span></dt><dt><span class="sect1"><a href="acknowledgments.html#d0e3561">2. 使用しているソフトウェア</a></span></dt></dl></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e3438"></a>1. 貢献者</h2></div></div></div><p><span class="application">FindBugs</span> was originally written by Bill Pugh (<code class="email"><<a href="mailto:pugh@cs.umd.edu">pugh@cs.umd.edu</a>></code>).
-David Hovemeyer (<code class="email"><<a href="mailto:daveho@cs.umd.edu">daveho@cs.umd.edu</a>></code>) implemented some of the
-detectors, added the Swing GUI, and is a co-maintainer.</p><p>Mike Fagan (<code class="email"><<a href="mailto:mfagan@tde.com">mfagan@tde.com</a>></code>) contributed the <span class="application">Ant</span> build script,
-the <span class="application">Ant</span> task, and several enhancements and bug fixes to the GUI.</p><p>Germano Leichsenring contributed Japanese translations of the bug
-summaries.</p><p>David Li contributed the Emacs bug report format.</p><p>Peter D. Stout contributed recursive detection of Class-Path
-attributes in analyzed Jar files, German translations of
-text used in the Swing GUI, and other fixes.</p><p>Peter Friese wrote the <span class="application">FindBugs</span> Eclipse plugin.</p><p>Rohan Lloyd contributed several Mac OS X enhancements,
-bug detector improvements,
-and maintains the Fink package for <span class="application">FindBugs</span>.</p><p>Hiroshi Okugawa translated the <span class="application">FindBugs</span> manual and
-more of the bug summaries into Japanese.</p><p>Phil Crosby enhanced the Eclipse plugin to add a view
-to display the bug details.</p><p>Dave Brosius fixed a number of bugs, added user preferences
-to the Swing GUI, improved several bug detectors, and
-contributed the string concatenation detector.</p><p>Thomas Klaeger contributed a number of bug fixes and
-bug detector improvements.</p><p>Andrei Loskutov made a number of improvements to the
-Eclipse plugin.</p><p>Brian Goetz contributed a major refactoring of the
-visitor classes to improve readability and understandability.</p><p> Pete Angstadt fixed several problems in the Swing GUI.</p><p>Francis Lalonde provided a task resource file for the
-FindBugs Ant task.</p><p>Garvin LeClaire contributed support for output in
-Xdocs format, for use by Maven.</p><p>Holger Stenzhorn contributed improved German translations of items
-in the Swing GUI.</p><p>Juha Knuutila contributed Finnish translations of items
-in the Swing GUI.</p><p>Tanel Lebedev contributed Estonian translations of items
-in the Swing GUI.</p><p>Hanai Shisei (ruimo) contributed full Japanese translations of
-bug messages, and text used in the Swing GUI.</p><p>David Cotton contributed Fresh translations for bug
-messages and for the Swing GUI.</p><p>Michael Tamm contributed support for the "errorProperty" attribute
-in the Ant task.</p><p>Thomas Kuehne improved the German translation of the Swing GUI.</p><p>Len Trigg improved source file support for the Emacs output mode.</p><p>Greg Bentz provided a fix for the hashcode/equals detector.</p><p>K. Hashimoto contributed internationalization fixes and several other
- bug fixes.</p><p>
- Glenn Boysko contributed support for ignoring specified local
- variables in the dead local store detector.
-</p><p>
- Jay Dunning contributed a detector to find equality comparisons
- of floating-point values, and overhauled the analysis summary
- report and its representation in the saved XML format.
-</p><p>
- Olivier Parent contributed updated French translations for bug descriptions and
- Swing GUI.
-</p><p>
- Chris Nappin contributed the <code class="filename">plain.xsl</code>
- stylesheet.
-</p><p>
- Etienne Giraudy contributed the <code class="filename">fancy.xsl</code> and <code class="filename">fancy-hist.xsl</code>
- stylesheets, and made improvements to the <span><strong class="command">-xml:withMessages</strong></span>
- option.
-</p><p>
- Takashi Okamoto fixed bugs in the project preferences dialog
- in the Eclipse plugin, and contributed to its internationalization and localization.
-</p><p>Thomas Einwaller fixed bugs in the project preferences dialog in the Eclipse plugin.</p><p>Jeff Knox contributed support for the warningsProperty attribute
-in the Ant task.</p><p>Peter Hendriks extended the Eclipse plugin preferences,
-and fixed a bug related to renaming the Eclipse plugin ID.</p><p>Mark McKay contributed an Ant task to launch the findbugs frame.</p><p>Dieter von Holten (dvholten) contributed
-some German improvements to findbugs_de.properties.</p><p>If you have contributed to <span class="application">FindBugs</span>, but aren't mentioned above,
-please send email to <code class="email"><<a href="mailto:findbugs@cs.umd.edu">findbugs@cs.umd.edu</a>></code> (and also accept
-our humble apologies).</p></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e3561"></a>2. 使用しているソフトウェア</h2></div></div></div><p><span class="application">FindBugs</span> は、いくつかのオープンソースソフトウェアパッケージを使用しています。これらがなければ、 <span class="application">FindBugs</span> の開発は、より一層困難なものになったことでしょう。</p><div class="sect2" lang="ja"><div class="titlepage"><div><div><h3 class="title"><a name="d0e3571"></a>2.1. BCEL</h3></div></div></div><p><span class="application">FindBugs</span> includes software developed by the Apache Software Foundation
-(<a href="http://www.apache.org/" target="_top">http://www.apache.org/</a>).
-Specifically, it uses the <a href="http://jakarta.apache.org/bcel/" target="_top">Byte Code
-Engineering Library</a>.</p></div><div class="sect2" lang="ja"><div class="titlepage"><div><div><h3 class="title"><a name="d0e3584"></a>2.2. ASM</h3></div></div></div><p><span class="application">FindBugs</span> uses the <a href="http://asm.objectweb.org/" target="_top">ASM</a>
-bytecode framework, which is distributed under the following license:</p><div class="blockquote"><blockquote class="blockquote"><p>
-Copyright (c) 2000-2005 INRIA, France Telecom
-All rights reserved.
-</p><p>
-Redistribution and use in source and binary forms, with or without
-modification, are permitted provided that the following conditions
-are met:
-</p><div class="orderedlist"><ol type="1"><li><p>
- Redistributions of source code must retain the above copyright
- notice, this list of conditions and the following disclaimer.
- </p></li><li><p>
- Redistributions in binary form must reproduce the above copyright
- notice, this list of conditions and the following disclaimer in the
- documentation and/or other materials provided with the distribution.
- </p></li><li><p>
- Neither the name of the copyright holders nor the names of its
- contributors may be used to endorse or promote products derived from
- this software without specific prior written permission.
- </p></li></ol></div><p>
-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
-AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
-ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
-LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
-CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
-SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
-INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
-CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
-ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
-THE POSSIBILITY OF SUCH DAMAGE.
-</p></blockquote></div></div><div class="sect2" lang="ja"><div class="titlepage"><div><div><h3 class="title"><a name="d0e3611"></a>2.3. DOM4J</h3></div></div></div><p><span class="application">FindBugs</span> uses <a href="http://dom4j.org" target="_top">DOM4J</a>, which is
-distributed under the following license:</p><div class="blockquote"><blockquote class="blockquote"><p>
-Copyright 2001 (C) MetaStuff, Ltd. All Rights Reserved.
-</p><p>
-Redistribution and use of this software and associated documentation
-("Software"), with or without modification, are permitted provided that
-the following conditions are met:
-</p><div class="orderedlist"><ol type="1"><li><p>
- Redistributions of source code must retain copyright statements and
- notices. Redistributions must also contain a copy of this document.
- </p></li><li><p>
- Redistributions in binary form must reproduce the above copyright
- notice, this list of conditions and the following disclaimer in the
- documentation and/or other materials provided with the distribution.
- </p></li><li><p>
- The name "DOM4J" must not be used to endorse or promote products
- derived from this Software without prior written permission
- of MetaStuff, Ltd. For written permission, please contact
- <code class="email"><<a href="mailto:dom4j-info@metastuff.com">dom4j-info@metastuff.com</a>></code>.
- </p></li><li><p>
- Products derived from this Software may not be called "DOM4J" nor may
- "DOM4J" appear in their names without prior written permission of
- MetaStuff, Ltd. DOM4J is a registered trademark of MetaStuff, Ltd.
- </p></li><li><p>
- Due credit should be given to the DOM4J Project (<a href="http://dom4j.org/" target="_top">http://dom4j.org/</a>).
- </p></li></ol></div><p>
-THIS SOFTWARE IS PROVIDED BY METASTUFF, LTD. AND CONTRIBUTORS ``AS IS''
-AND ANY EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
-THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
-PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL METASTUFF, LTD. OR ITS
-CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
-EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
-PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
-PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
-LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
-NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
-SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-</p></blockquote></div></div></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="license.html">前のページ</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> </td></tr><tr><td width="40%" align="left" valign="top">第13章 ライセンス </td><td width="20%" align="center"><a accesskey="h" href="index.html">ホーム</a></td><td width="40%" align="right" valign="top"> </td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/analysisprops.html b/tools/findbugs-1.3.9/doc/ja/manual/analysisprops.html
deleted file mode 100644
index 5e1648b..0000000
--- a/tools/findbugs-1.3.9/doc/ja/manual/analysisprops.html
+++ /dev/null
@@ -1,6 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>第9章 分析プロパティー</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ マニュアル"><link rel="up" href="index.html" title="FindBugs™ マニュアル"><link rel="prev" href="filter.html" title="第8章 フィルターファイル"><link rel="next" href="annotations.html" title="第10章 アノテーション"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">第9章 分析プロパティー</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="filter.html">前のページ</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="annotations.html">次のページ</a></td></tr></table><hr></div><div class="chapter" lang="ja"><div class="titlepage"><div><div><h2 class="title"><a name="analysisprops"></a>第9章 分析プロパティー</h2></div></div></div><p><span class="application">FindBugs</span> は分析する場合にいくつかの観点を持っています。そして、観点をカスタマイズして実行することができます。システムプロパティーを使って、それらのオプションを設定します。この章では、分析オプションの設定方法を説明します。</p><p>分析オプションの主な目的は、 2 つあります。1 番目は、 <span class="application">FindBugs</span> に対して分析されるアプリケーションのメソッドの意味を伝えることです。そうすることで <span class="application">FindBugs</span> がより正確な結果を出すことができ、誤検出を減らすことができます。2 番目に、分析を行うに当たりその精度を設定できるようにすることです。分析の精度を落とすことで、メモリ使用量と分析時間を減らすことができます。ただし、本当のバグを見逃したり、誤検出の数が増えるという代償があります。</p><p>コマンドラインオプション <span><strong class="command">-property</strong></span> を使って、分析オプションを設定することができます。次に、例を示します:</p><pre class="screen">
-<code class="prompt">$ </code><span><strong class="command">findbugs -textui -property "cfg.noprune=true" <em class="replaceable"><code>myApp.jar</code></em></strong></span>
-</pre><p>
-</p><p>設定することができる分析オプションの一覧を <a href="analysisprops.html#analysisproptable" title="表 9.1. 設定可能な分析プロパティー">表 9.1. 「設定可能な分析プロパティー」</a> に示します。</p><div class="table"><a name="analysisproptable"></a><p class="title"><b>表 9.1. 設定可能な分析プロパティー</b></p><div class="table-contents"><table summary="設定可能な分析プロパティー" border="1"><colgroup><col><col><col></colgroup><thead><tr><th align="left">プロパティー名</th><th align="left">設定値</th><th align="left">目的</th></tr></thead><tbody><tr><td align="left">findbugs.assertionmethods</td><td align="left">コンマ区切りの完全修飾メソッド名リスト : 例、 "com.foo.MyClass.checkAssertion"</td><td align="left">このプロパティーには、プログラムが正しいことをチェックするために使われるメソッドを指定します。これらのメソッドを指定することで、 チェックメソッドで確認した値に対する null 参照アクセスディテクタの誤検出を回避できます。</td></tr><tr><td align="left">findbugs.de.comment</td><td align="left">true または false</td><td align="left">true に設定すると、 DroppedException (無視された例外) ディテクタは空の catch ブロック にコメントが無いか探します。そして、コメントがみつかった場合には警告が報告されません。</td></tr><tr><td align="left">findbugs.maskedfields.locals</td><td align="left">true または false</td><td align="left">true に設定すると、フィールドを隠蔽しているローカル変数に対して優先度(低)の警告が発行されます。デフォルトは、 false です。</td></tr><tr><td align="left">findbugs.nullderef.assumensp</td><td align="left">true または false</td><td align="left">使用されません。 (意図 : true に設定すると、null 参照アクセスディテクタはメソッドからの戻り値、または、メソッドに受け渡される引数を null であると仮定します。デフォルトは、 false です。このプロパティーを有効にすると、大量の誤検出が生成されるであろうことに注意してください。)</td></tr><tr><td align="left">findbugs.refcomp.reportAll</td><td align="left">true または false</td><td align="left">true に設定すると、 == および != 演算子を使っている疑わしい参照比較がすべて報告されます。 false に設定すると、同様の警告は 1 メソッドにつき 1 つしか発行されません。デフォルトは、 false です。</td></tr><tr><td align="left">findbugs.sf.comment</td><td align="left">true または false</td><td align="left">true に設定すると、 SwitchFallthrough ディテクタはソースコードに「fall」または「nobreak」という単語を含んだコメントを記載していない caseラベル に限り警告を報告します。(この機能が正しく動作するためには、正確なソースパスが必要です。) これにより、意図的ではない switch 文の fallthrough を発見し易くなります。</td></tr></tbody></table></div></div><br class="table-break"></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="filter.html">前のページ</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="annotations.html">次のページ</a></td></tr><tr><td width="40%" align="left" valign="top">第8章 フィルターファイル </td><td width="20%" align="center"><a accesskey="h" href="index.html">ホーム</a></td><td width="40%" align="right" valign="top"> 第10章 アノテーション</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/annotations.html b/tools/findbugs-1.3.9/doc/ja/manual/annotations.html
deleted file mode 100644
index 153033a..0000000
--- a/tools/findbugs-1.3.9/doc/ja/manual/annotations.html
+++ /dev/null
@@ -1,67 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>第10章 アノテーション</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ マニュアル"><link rel="up" href="index.html" title="FindBugs™ マニュアル"><link rel="prev" href="analysisprops.html" title="第9章 分析プロパティー"><link rel="next" href="rejarForAnalysis.html" title="第11章 rejarForAnalysis の使用方法"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">第10章 アノテーション</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="analysisprops.html">前のページ</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="rejarForAnalysis.html">次のページ</a></td></tr></table><hr></div><div class="chapter" lang="ja"><div class="titlepage"><div><div><h2 class="title"><a name="annotations"></a>第10章 アノテーション</h2></div></div></div><p><span class="application">FindBugs</span> はいくつかのアノテーションをサポートしています。開発者の意図を明確にすることで、 FindBugs はより的確に警告を発行することができます。アノテーションを使用するためには Java 5 が必要であり、 annotations.jar および jsr305.jar ファイルをコンパイル時のクラスパスに含める必要があります。</p><div class="variablelist"><dl><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.CheckForNull</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Field, Method, Parameter
- <p>アノテーションをつけた要素は、 null である可能性があります。したがって、当該要素を使用する際は null チェックをするべきです。このアノテーションをメソッドに適用すると、メソッドの戻り値に適用されます。</p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.CheckReturnValue</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Method, Constructor
- <div class="variablelist"><dl><dt><span class="term"><span><strong class="command">[Parameter]</strong></span></span></dt><dd><p>
- <span><strong class="command">priority:</strong></span> 警告の優先度を指定します (HIGH, MEDIUM, LOW, IGNORE) 。デフォルト値 :MEDIUM。</p><p>
- <span><strong class="command">explanation:</strong></span>戻り値をチェックしなけばならない理由をテキストで説明します。デフォルト値 :""。</p></dd></dl></div><p>このアノテーションを使用して、呼出し後に戻り値をチェックすべきメソッドを表すことができます。</p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.DefaultAnnotation</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Type, Package
- <div class="variablelist"><dl><dt><span class="term"><span><strong class="command">[Parameter]</strong></span></span></dt><dd><p>
- <span><strong class="command">value:</strong></span>アノテーションクラスのclassオブジェクト。複数のクラスを指定することができます。</p><p>
- <span><strong class="command">priority:</strong></span>省略時の優先度を指定します (HIGH, MEDIUM, LOW, IGNORE) 。デフォルト値 :MEDIUM。</p></dd></dl></div><p>
-Indicates that all members of the class or package should be annotated with the default
-value of the supplied annotation classes. This would be used for behavior annotations
-such as @NonNull, @CheckForNull, or @CheckReturnValue. In particular, you can use
-@DefaultAnnotation(NonNull.class) on a class or package, and then use @Nullable only
-on those parameters, methods or fields that you want to allow to be null.
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.DefaultAnnotationForFields</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Type, Package
- <div class="variablelist"><dl><dt><span class="term"><span><strong class="command">[Parameter]</strong></span></span></dt><dd><p>
- <span><strong class="command">value:</strong></span>アノテーションクラスのclassオブジェクト。複数のクラスを指定することができます。</p><p>
- <span><strong class="command">priority:</strong></span>省略時の優先度を指定します (HIGH, MEDIUM, LOW, IGNORE) 。デフォルト値 :MEDIUM。</p></dd></dl></div><p>
-This is same as the DefaultAnnotation except it only applys to fields.
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.DefaultAnnotationForMethods</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Type, Package
- <div class="variablelist"><dl><dt><span class="term"><span><strong class="command">[Parameter]</strong></span></span></dt><dd><p>
- <span><strong class="command">value:</strong></span>アノテーションクラスのclassオブジェクト。複数のクラスを指定することができます。</p><p>
- <span><strong class="command">priority:</strong></span>省略時の優先度を指定します (HIGH, MEDIUM, LOW, IGNORE) 。デフォルト値 :MEDIUM。</p></dd></dl></div><p>
-This is same as the DefaultAnnotation except it only applys to methods.
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.DefaultAnnotationForParameters</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Type, Package
- <div class="variablelist"><dl><dt><span class="term"><span><strong class="command">[Parameter]</strong></span></span></dt><dd><p>
- <span><strong class="command">value:</strong></span>アノテーションクラスのclassオブジェクト。複数のクラスを指定することができます。</p><p>
- <span><strong class="command">priority:</strong></span>省略時の優先度を指定します (HIGH, MEDIUM, LOW, IGNORE) 。デフォルト値 :MEDIUM。</p></dd></dl></div><p>
-This is same as the DefaultAnnotation except it only applys to method parameters.
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.NonNull</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Field, Method, Parameter
- <p>アノテーションをつけた要素は、 null であってはいけません。アノテーションをつけたフィールドは、構築完了後 null であってはいけません。アノテーションをつけたメソッドは、 null ではない値を戻り値としなければなりません。</p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.Nullable</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Field, Method, Parameter
- <p>アノテーションをつけた要素は、 null であってはいけません。In general, this means developers will have to read the documentation to determine when a null value is acceptable and whether it is neccessary to check for a null value. FindBugs will treat the annotated items as though they had no annotation.</p><p>
-In pratice this annotation is useful only for overriding an overarching NonNull
-annotation.
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.OverrideMustInvoke</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Method
- <div class="variablelist"><dl><dt><span class="term"><span><strong class="command">[Parameter]</strong></span></span></dt><dd><p>
- <span><strong class="command">value:</strong></span>Specify when the super invocation should be
- performed (FIRST, ANYTIME, LAST). Default value:ANYTIME.
- </p></dd></dl></div><p>
-Used to annotate a method that, if overridden, must (or should) be invoke super
-in the overriding method. Examples of such methods include finalize() and clone().
-The argument to the method indicates when the super invocation should occur:
-at any time, at the beginning of the overriding method, or at the end of the overriding method.
-(This anotation is not implmemented in FindBugs as of September 8, 2006).
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.PossiblyNull</strong></span></span></dt><dd><p>
-This annotation is deprecated. Use CheckForNull instead.
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.SuppressWarnings</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Type, Field, Method, Parameter, Constructor, Package
- <div class="variablelist"><dl><dt><span class="term"><span><strong class="command">[Parameter]</strong></span></span></dt><dd><p>
- <span><strong class="command">value:</strong></span>The name of the warning. More than one name can be specified.
- </p><p>
- <span><strong class="command">justification:</strong></span>Reason why the warning should be ignored. デフォルト値 :""。</p></dd></dl></div><p>
-The set of warnings that are to be suppressed by the compiler in the annotated element.
-Duplicate names are permitted. The second and successive occurrences of a name are ignored.
-The presence of unrecognized warning names is <span class="emphasis"><em>not</em></span> an error: Compilers
-must ignore any warning names they do not recognize. They are, however, free to emit a
-warning if an annotation contains an unrecognized warning name. Compiler vendors should
-document the warning names they support in conjunction with this annotation type. They
-are encouraged to cooperate to ensure that the same names work across multiple compilers.
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.UnknownNullness</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Field, Method, Parameter
- <p>
-Used to indicate that the nullness of the target is unknown, or my vary in unknown ways in subclasses.
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.UnknownNullness</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Field, Method, Parameter
- <p>
-Used to indicate that the nullness of the target is unknown, or my vary in unknown ways in subclasses.
- </p></dd></dl></div><p>また、 <span class="application">FindBugs</span> 次に示すアノテーションもサポートしています。 :</p><div class="itemizedlist"><ul type="disc"><li>net.jcip.annotations.GuardedBy</li><li>net.jcip.annotations.Immutable</li><li>net.jcip.annotations.NotThreadSafe</li><li>net.jcip.annotations.ThreadSafe</li></ul></div><p>
-</p><p><a href="http://jcip.net/" target="_top">Java Concurrency in Practice</a> の <a href="http://jcip.net/annotations/doc/index.html" target="_top"> API ドキュメント</a> を参照してください。</p></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="analysisprops.html">前のページ</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="rejarForAnalysis.html">次のページ</a></td></tr><tr><td width="40%" align="left" valign="top">第9章 分析プロパティー </td><td width="20%" align="center"><a accesskey="h" href="index.html">ホーム</a></td><td width="40%" align="right" valign="top"> 第11章 rejarForAnalysis の使用方法</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/anttask.html b/tools/findbugs-1.3.9/doc/ja/manual/anttask.html
deleted file mode 100644
index eca22f6..0000000
--- a/tools/findbugs-1.3.9/doc/ja/manual/anttask.html
+++ /dev/null
@@ -1,40 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>第6章 FindBugs™ Ant タスクの使用方法</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ マニュアル"><link rel="up" href="index.html" title="FindBugs™ マニュアル"><link rel="prev" href="gui.html" title="第5章 FindBugs GUI の使用方法"><link rel="next" href="eclipse.html" title="第7章 FindBugs™ Eclipse プラグインの使用方法"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">第6章 <span class="application">FindBugs</span>™ <span class="application">Ant</span> タスクの使用方法</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="gui.html">前のページ</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="eclipse.html">次のページ</a></td></tr></table><hr></div><div class="chapter" lang="ja"><div class="titlepage"><div><div><h2 class="title"><a name="anttask"></a>第6章 <span class="application">FindBugs</span>™ <span class="application">Ant</span> タスクの使用方法</h2></div></div></div><div class="toc"><p><b>目次</b></p><dl><dt><span class="sect1"><a href="anttask.html#d0e1173">1. <span class="application">Ant</span> タスクのインストール</a></span></dt><dt><span class="sect1"><a href="anttask.html#d0e1209">2. build.xml の書き方</a></span></dt><dt><span class="sect1"><a href="anttask.html#d0e1278">3. タスクの実行</a></span></dt><dt><span class="sect1"><a href="anttask.html#d0e1303">4. パラメーター</a></span></dt></dl></div><p>この章では、 <span class="application">FindBugs</span> を <a href="http://ant.apache.org/" target="_top"><span class="application">Ant</span></a> のビルドスクリプトに組み入れる方法について説明します。 <a href="http://ant.apache.org/" target="_top"><span class="application">Ant</span></a> は、ビルドや配備を行うことができる Java でよく使用されるツールです。<span class="application">FindBugs</span> <span class="application">Ant</span> タスクを使用すると、 ビルドスクリプトを作成して機械的に <span class="application">FindBugs</span> による Java コードの分析を実行することができます。</p><p>この <span class="application">Ant</span> タスクは、 Mike Fagan 氏の多大な貢献によるものです。</p><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1173"></a>1. <span class="application">Ant</span> タスクのインストール</h2></div></div></div><p><span class="application">Ant</span> タスクのインストールは、 <code class="filename"><em class="replaceable"><code>$FINDBUGS_HOME</code></em>/lib/findbugs-ant.jar</code> を <span class="application">Ant</span> インストールディレクトリーの<code class="filename">lib</code> サブディレクトリーにコピーするだけです。</p><div class="note" style="margin-left: 0.5in; margin-right: 0.5in;"><table border="0" summary="Note"><tr><td rowspan="2" align="center" valign="top" width="25"><img alt="[注意]" src="note.png"></td><th align="left">注意</th></tr><tr><td align="left" valign="top"><p>使用する <span class="application">Ant</span> タスクと <span class="application">FindBugs</span> 本体は、同梱されていた同じバージョンのものを使用することを強く推奨します。別のバージョンの <span class="application">FindBugs</span> に含まれていた <span class="application">Ant</span> タスク Jar ファイルでの動作は保証しません。</p></td></tr></table></div><p>
-</p></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1209"></a>2. build.xml の書き方</h2></div></div></div><p><span class="application">FindBugs</span> を <code class="filename">build.xml</code> (<span class="application">Ant</span> ビルドスクリプト) に組み入れるためにはまず、タスク定義を記述する必要があります。タスク定義は次のように記述します。:</p><pre class="screen">
- <taskdef name="findbugs" classname="edu.umd.cs.findbugs.anttask.FindBugsTask"/>
-</pre><p>タスク定義は、 <code class="literal">findbugs</code> 要素を <code class="filename">build.xml</code> 上に記述したとき、そのタスクの実行に使用されるクラスを指定します。</p><p>タスク定義の記述をすれば、<code class="literal">findbugs</code> タスクを使ってターゲットを定義できます。次に示すのは、 Apache <a href="http://jakarta.apache.org/bcel/" target="_top">BCEL</a> ライブラリーを分析する場合を想定した <code class="filename">build.xml</code> の記述例です。</p><pre class="screen">
- <property name="findbugs.home" value="/export/home/daveho/work/findbugs" />
-
- <target name="findbugs" depends="jar">
- <findbugs home="${findbugs.home}"
- output="xml"
- outputFile="bcel-fb.xml" >
- <auxClasspath path="${basedir}/lib/Regex.jar" />
- <sourcePath path="${basedir}/src/java" />
- <class location="${basedir}/bin/bcel.jar" />
- </findbugs>
- </target>
-</pre><p><code class="literal">findbugs</code> 要素には、 <code class="literal">home</code> 属性が必須です。 <span class="application">FindBugs</span> のインストールディレクトリーすなわち <em class="replaceable"><code>$FINDBUGS_HOME</code></em> の値を設定します。<a href="installing.html" title="第2章 FindBugs™ のインストール">章 2. <i><span class="application">FindBugs</span>™ のインストール</i></a> を参照してください。</p><p>このターゲットは <code class="filename">bcel.jar</code> に対して <span class="application">FindBugs</span> を実行します。この Jar ファイルは、 BCEL ビルドスクリプトによって作成されるものです。(上記のターゲットが「jar」ターゲットに依存している (depends) と設定することにより、 <span class="application">FindBugs</span> が実行される前に当該ライブラリーが完全にコンパイルされていることを保証しています。) <span class="application">FindBugs</span> の出力は、 XML 形式で <code class="filename">bcel-fb.xml</code> ファイルに保存されます。補助 Jar ファイル <code class="filename">Regex.jar</code> を aux classpath に記述しています。なぜなら、当該 Jar ファイルが BCEL メイン･ライブラリーから参照されるからです。source path を指定することで、保存されるバグデータに BCEL ソースコードへの正確な参照が記述されます。</p></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1278"></a>3. タスクの実行</h2></div></div></div><p>コマンドラインから <span class="application">Ant</span> を起動する例を次に示します。前述の <code class="literal">findbugs</code> ターゲットを使用しています。</p><pre class="screen">
- <code class="prompt">[daveho@noir]$</code> <span><strong class="command">ant findbugs</strong></span>
- Buildfile: build.xml
-
- init:
-
- compile:
-
- examples:
-
- jar:
-
- findbugs:
- [findbugs] Running FindBugs...
- [findbugs] Bugs were found
- [findbugs] Output saved to bcel-fb.xml
-
- BUILD SUCCESSFUL
- Total time: 35 seconds
-</pre><p>この事例においては、XML ファイルでバグ検索結果を保存しているので、 <span class="application">FindBugs</span> GUI を使って結果を参照することができます。 <a href="running.html" title="第4章 FindBugs™ の実行">章 4. <i><span class="application">FindBugs</span>™ の実行</i></a> を参照してください。</p></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1303"></a>4. パラメーター</h2></div></div></div><p>このセクションでは、 <span class="application">FindBugs</span> タスクを使用する際に、指定することができるパラメーターについて説明します。</p><div class="variablelist"><dl><dt><span class="term"><code class="literal">class</code></span></dt><dd><p>分析の対象となるクラス群を指定するためのネストされる要素です。<code class="literal">class</code> 要素には <code class="literal">location</code> 属性の指定が必須です。分析対象となるアーカイブファイル (jar, zip, 他)、ディレクトリーまたはクラスファイルの名前を記述します。1 つの <code class="literal">findbugs</code> 要素に対して、複数の <code class="literal">class</code> 子要素を指定することができます。</p></dd><dt><span class="term"><code class="literal">auxClasspath</code></span></dt><dd><p>任意指定のネストされる要素です。分析対象のライブラリーまたはアプリケーションによって使用されているが分析の対象にはしたくないクラスを含んでいるクラスパス (Jar ファイルまたはディレクトリー) を指定します。 <span class="application">Ant</span> の Java タスクにある <code class="literal">classpath</code> 要素 と同じ方法で指定することができます。</p></dd><dt><span class="term"><code class="literal">sourcePath</code></span></dt><dd><p>任意指定のネストされる要素です。分析対象 Java コードのコンパイル時に使用したソースファイルを含んでいるソースディレクトリーへのパスを指定します。ソースパスを指定することにより、生成される XML のバグ出力結果に完全なソース情報をもたせることができ、後になって GUI で参照することができます。</p></dd><dt><span class="term"><code class="literal">home</code></span></dt><dd><p>必須属性です。<span class="application">FindBugs</span> がインストールされているディレクトリー名を設定します。</p></dd><dt><span class="term"><code class="literal">quietErrors</code></span></dt><dd><p>任意指定のブール値属性です。true を設定すると、深刻な分析エラー発生やクラスがみつからないといった情報が <span class="application">FindBugs</span> 出力に記録されません。デフォルトは、 false です。</p></dd><dt><span class="term"><code class="literal">reportLevel</code></span></dt><dd><p>任意指定の属性です。報告されるバグの優先度のしきい値を指定します。「low」に設定すると、すべてのバグが報告されます。「medium」 (デフォルト) に設定すると、優先度 (中)および優先度 (高)のバグが報告されます。「high」に設定すると、優先度 (高) のバグのみが報告されます。</p></dd><dt><span class="term"><code class="literal">output</code></span></dt><dd><p>任意指定の属性です。出力形式を指定します。「xml」 (デフォルト) に設定すると、出力は XML 形式になります。「xml:withMessages」 に設定すると、出力は人間が読めるメッセージ が追加された XML 形式になります。(XSL スタイルシートを使ってレポートを作成することを計画している場合はこの形式を使用してください。) 「html」に設定すると、出力は HTML 形式(デフォルトのスタイルシートは default.xsl) になります。 「text」に設定すると、出力は特別なテキスト形式になります。「emacs」に設定すると、出力は <a href="http://www.gnu.org/software/emacs/" target="_top">Emacs</a> エラーメッセージ形式になります。「xdocs」に設定すると、出力は Apache Maven で使用できる xdoc XML になります。</p></dd><dt><span class="term"><code class="literal">stylesheet</code></span></dt><dd><p>任意指定の属性です。output 属性 に html を指定した場合に、 HTML 出力作成に使用されるスタイルシートを指定します。FindBugs 配布物に含まれているスタイルシートは、 default.xsl、 fancy.xsl 、 fancy-hist.xsl 、 plain.xsl および summary.xsl です。デフォルト値は default.xsl です。</p></dd><dt><span class="term"><code class="literal">sort</code></span></dt><dd><p>任意指定の属性です。<code class="literal">output</code> 属性に「text」を指定した場合に、バグの報告をクラス順にソートするかどうかを <code class="literal">sort</code> 属性で指定します。デフォルトは、 true です。</p></dd><dt><span class="term"><code class="literal">outputFile</code></span></dt><dd><p>任意指定の属性です。指定した場合、<span class="application">FindBugs</span> の出力はその名前のファイルへと保存されます。省略時、出力は <span class="application">Ant</span> によって直接表示されます。</p></dd><dt><span class="term"><code class="literal">debug</code></span></dt><dd><p>任意指定のブール値属性です。true に設定すると、 <span class="application">FindBugs</span> は 診断情報を出力します。どのクラスを分析しているか、どのパグパターンディテクタが実行されているか、という情報が表示されます。デフォルトは、 false です。</p></dd><dt><span class="term"><code class="literal">effort</code></span></dt><dd><p>分析の活動レベルを設定します。<code class="literal">min</code> 、<code class="literal">default</code> または <code class="literal">max</code> のいずれかの値を設定してください。分析レベルの設定に関する詳細情報は、 <a href="running.html#commandLineOptions" title="3. コマンドラインオプション">項3. 「コマンドラインオプション」</a> を参照してください。</p></dd><dt><span class="term"><code class="literal">conserveSpace</code></span></dt><dd><p>effort="min" と同義です。</p></dd><dt><span class="term"><code class="literal">workHard</code></span></dt><dd><p>effort="max" と同義です。</p></dd><dt><span class="term"><code class="literal">visitors</code></span></dt><dd><p>任意指定の属性です。どのバグディテクタを実行するかをコンマ区切りのリストで指定します。バグディテクタはパッケージ指定なしのクラス名で指定します。省略時、デフォルトで無効化されているものを除くすべてのディテクタが実行されます。</p></dd><dt><span class="term"><code class="literal">omitVisitors</code></span></dt><dd><p>任意指定の属性です。<code class="literal">visitors</code> 属性と似ていますが、こちらは <span class="emphasis"><em>実行されない</em></span> ディテクタを指定します。</p></dd><dt><span class="term"><code class="literal">excludeFilter</code></span></dt><dd><p>任意指定の属性です。フィルターファイル名を指定します。報告から除外されるバグを指定します。<a href="filter.html" title="第8章 フィルターファイル">章 8. <i>フィルターファイル</i></a> を参照してください。</p></dd><dt><span class="term"><code class="literal">includeFilter</code></span></dt><dd><p>任意指定の属性です。フィルターファイル名を指定します。報告されるバグを指定します。<a href="filter.html" title="第8章 フィルターファイル">章 8. <i>フィルターファイル</i></a> を参照してください。</p></dd><dt><span class="term"><code class="literal">projectFile</code></span></dt><dd><p>任意指定の属性です。プロジェクトファイル名を指定します。プロジェクトファイルは、 <span class="application">FindBugs</span> GUI で作成します。分析されるクラス、および、補助クラスパス、ソースディレクトリーが記入されてます。プロジェクトファイルを指定した場合は、 <code class="literal">class</code> 要素・ <code class="literal">auxClasspath</code> 属性および <code class="literal">sourcePath</code> 属性を設定する必要はありません。プロジェクトの作成方法は、 <a href="running.html" title="第4章 FindBugs™ の実行">章 4. <i><span class="application">FindBugs</span>™ の実行</i></a> を参照してください。</p></dd><dt><span class="term"><code class="literal">jvmargs</code></span></dt><dd><p>任意指定の属性です。<span class="application">FindBugs</span> を実行している Java 仮想マシンに対して受け渡される引数を指定します。巨大なプログラムを分析する場合に、 JVM が使用するメモリ容量を増やす指定をするためにこの引数を利用する必要があるかもしれません。</p></dd><dt><span class="term"><code class="literal">systemProperty</code></span></dt><dd><p>任意指定のネストされる要素です。指定した場合、Java システムプロパティーを定義します。<code class="literal">name</code> 属性にはシステムプロパティーの名前を指定します。そして、 <code class="literal">value</code> 属性にはシステムプロパティの値を指定します。</p></dd><dt><span class="term"><code class="literal">timeout</code></span></dt><dd><p>任意指定の属性です。<span class="application">FindBugs</span> を実行している Java プロセス の実行許容時間をミリ秒単位で指定します。時間を超過するとハングアップしていると判断してプロセスが終了されます。デフォルトは、 600,000 ミリ秒 (10 分) です。巨大なプログラムの場合は、 <span class="application">FindBugs</span> が分析を完了するまでに 10 分 以上掛かる可能性があることに注意してください。</p></dd><dt><span class="term"><code class="literal">failOnError</code></span></dt><dd><p>任意指定のブール値属性です。<span class="application">FindBugs</span> の実行中にエラーがあった場合に、ビルドプロセス自体を打ち切って異常終了させるかどうかを指定します。デフォルトは、「false」です。</p></dd><dt><span class="term"><code class="literal">errorProperty</code></span></dt><dd><p>任意指定の属性です。<span class="application">FindBugs</span> の実行中にエラーが発生した場合に、「true」が設定されるプロパティーの名前を指定します。</p></dd><dt><span class="term"><code class="literal">warningsProperty</code></span></dt><dd><p>任意指定の属性です。<span class="application">FindBugs</span> が分析したプログラムにバグ報告が 1 件でもある場合に、「true」が設定されるプロパティーの名前を指定します。</p></dd></dl></div><p>
-
-
-</p></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="gui.html">前のページ</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="eclipse.html">次のページ</a></td></tr><tr><td width="40%" align="left" valign="top">第5章 <span class="application">FindBugs</span> GUI の使用方法 </td><td width="20%" align="center"><a accesskey="h" href="index.html">ホーム</a></td><td width="40%" align="right" valign="top"> 第7章 <span class="application">FindBugs</span>™ Eclipse プラグインの使用方法</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/building.html b/tools/findbugs-1.3.9/doc/ja/manual/building.html
deleted file mode 100644
index d88fea0..0000000
--- a/tools/findbugs-1.3.9/doc/ja/manual/building.html
+++ /dev/null
@@ -1,40 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>第3章 FindBugs™ のソールからのビルド</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ マニュアル"><link rel="up" href="index.html" title="FindBugs™ マニュアル"><link rel="prev" href="installing.html" title="第2章 FindBugs™ のインストール"><link rel="next" href="running.html" title="第4章 FindBugs™ の実行"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">第3章 <span class="application">FindBugs</span>™ のソールからのビルド</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="installing.html">前のページ</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="running.html">次のページ</a></td></tr></table><hr></div><div class="chapter" lang="ja"><div class="titlepage"><div><div><h2 class="title"><a name="building"></a>第3章 <span class="application">FindBugs</span>™ のソールからのビルド</h2></div></div></div><div class="toc"><p><b>目次</b></p><dl><dt><span class="sect1"><a href="building.html#d0e175">1. 前提条件</a></span></dt><dt><span class="sect1"><a href="building.html#d0e258">2. ソース配布物の展開</a></span></dt><dt><span class="sect1"><a href="building.html#d0e271">3. <code class="filename">local.properties</code> の修正</a></span></dt><dt><span class="sect1"><a href="building.html#d0e326">4. <span class="application">Ant</span> の実行</a></span></dt><dt><span class="sect1"><a href="building.html#d0e420">5. ソースディレクトリーからの <span class="application">FindBugs</span>™ の実行</a></span></dt></dl></div><p>この章では、 <span class="application">FindBugs</span> をソースコードからビルドする方法を説明します。<span class="application">FindBugs</span> を修正することに興味がないのであれば、 <a href="running.html" title="第4章 FindBugs™ の実行">次の章</a> に進んでください。</p><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e175"></a>1. 前提条件</h2></div></div></div><p>ソースから <span class="application">FindBugs</span> をコンパイルするためには、以下のものが必要です。</p><div class="itemizedlist"><ul type="disc"><li><p><a href="http://prdownloads.sourceforge.net/findbugs/findbugs-1.3.9-source.zip?download" target="_top"><span class="application">FindBugs</span> のソース配布物</a>
- </p></li><li><p>
- <a href="http://java.sun.com/j2se/" target="_top">JDK 1.5.0 ベータ またはそれ以降</a>
- </p></li><li><p>
- <a href="http://ant.apache.org/" target="_top">Apache <span class="application">Ant</span></a>, バージョン 1.6.3 またはそれ以降</p></li></ul></div><p>
-</p><div class="warning" style="margin-left: 0.5in; margin-right: 0.5in;"><table border="0" summary="Warning"><tr><td rowspan="2" align="center" valign="top" width="25"><img alt="[警告]" src="warning.png"></td><th align="left">警告</th></tr><tr><td align="left" valign="top"><p>Redhat Linux システムの <code class="filename">/usr/bin/ant</code> に同梱されている <span class="application">Ant</span> のバージョンでは、 <span class="application">FindBugs</span> のコンパイルは<span class="emphasis"><em>うまくできません</em></span>。<a href="http://ant.apache.org/" target="_top"><span class="application">Ant</span> web サイト</a>からバイナリ配布物をダウンロードしてインストールすることを推奨します。<span class="application">Ant</span> を実行する場合は、 環境変数 <em class="replaceable"><code>JAVA_HOME</code></em> が JDK 1.5 (またはそれ以降)をインストールしたディレクトリーを指していることを確認してください。</p></td></tr></table></div><p>体裁の整った <span class="application">FindBugs</span> のドキュメントを生成したい場合は、以下のソフトウェアも必要となります:</p><div class="itemizedlist"><ul type="disc"><li><p><a href="http://docbook.sourceforge.net/projects/xsl/index.html" target="_top">DocBook XSL スタイルシート</a>。<span class="application">FindBugs</span> のマニュアルを HTML に変換するのに必要です。</p></li><li><p><a href="http://saxon.sourceforge.net/" target="_top"><span class="application">Saxon</span> XSLT プロセッサー</a>。(同様に、 <span class="application">FindBugs</span> のマニュアルを HTML に変換するのに必要です。)</p></li></ul></div><p>
-</p></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e258"></a>2. ソース配布物の展開</h2></div></div></div><p>ソース配布物をダウンロードした後に、それを作業用ディレクトリーに展開する必要があります。通常は、次のようなコマンドで展開を行います:</p><pre class="screen">
-<code class="prompt">$ </code><span><strong class="command">unzip findbugs-1.3.9-source.zip</strong></span>
-</pre><p>
-
-</p></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e271"></a>3. <code class="filename">local.properties</code> の修正</h2></div></div></div><p>FindBugs のドキュメントをビルドするためには、 <code class="filename">local.properties</code> ファイルを修正する必要があります。このファイルは、 <span class="application">FindBugs</span> をビルドする際に <a href="http://ant.apache.org/" target="_top"><span class="application">Ant</span></a> <code class="filename">build.xml</code> ファイルが参照します。FindBugs のドキュメントをビルドしない場合は、このファイルは無視してもかまいません。</p><p><code class="filename">local.properties</code> での定義は、 <code class="filename">build.properties</code> ファイルでの定義に優先します。<code class="filename">build.properties</code> は次のような内容です:</p><pre class="programlisting">
-
-# User Configuration:
-# This section must be modified to reflect your system.
-
-local.software.home =/export/home/daveho/linux
-
-# Set this to the directory containing the DocBook Modular XSL Stylesheets
-# from http://docbook.sourceforge.net/projects/xsl/
-
-xsl.stylesheet.home =${local.software.home}/docbook/docbook-xsl-1.71.1
-
-# Set this to the directory where Saxon (http://saxon.sourceforge.net/)
-# is installed.
-
-saxon.home =${local.software.home}/java/saxon-6.5.5
-
-</pre><p>
-</p><p><code class="varname">xsl.stylesheet.home</code> プロパティーには、<a href="http://docbook.sourceforge.net/projects/xsl/" target="_top">DocBook Modular XSL スタイルシート</a>がインストールしてあるディレクトリーの絶対パスを指定します。<span class="application">FindBugs</span> ドキュメントを生成しようと考えている場合にのみ、このプロパティーを指定する必要があります。</p><p><code class="varname">saxon.home</code> プロパティーには、<a href="http://saxon.sourceforge.net/" target="_top"><span class="application">Saxon</span> XSLT プロセッサー</a>がインストールしてあるディレクトリーの絶対パスを指定します。<span class="application">FindBugs</span> ドキュメントを生成しようと考えている場合にのみ、このプロパティーを指定する必要があります。</p></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e326"></a>4. <span class="application">Ant</span> の実行</h2></div></div></div><p>ソース配布物の展開、 <span class="application">Ant</span> のインストール、<code class="filename">build.properties</code>(<code class="filename">local.properties</code>) の修正 (これは任意) およびツール (<span class="application">Saxon</span> など)の環境構築ができれば、 <span class="application">FindBugs</span> をビルドするための準備は完了です。<span class="application">Ant</span> の起動する方法は、単にコマンドを実行するだけです。</p><pre class="screen">
-<code class="prompt">$ </code><span><strong class="command">ant <em class="replaceable"><code>target</code></em></strong></span>
-</pre><p><em class="replaceable"><code>target</code></em> には以下のいずれかを指定します: </p><div class="variablelist"><dl><dt><span class="term"><span><strong class="command">build</strong></span></span></dt><dd><p>このターゲットは、 <span class="application">FindBugs</span> のコードをコンパイルします。これは、デフォルトのターゲットです。</p></dd><dt><span class="term"><span><strong class="command">docs</strong></span></span></dt><dd><p>このターゲットは、ドキュメントの整形を行います(また、副作用としていくつかのソースのコンパイルも行います。)</p></dd><dt><span class="term"><span><strong class="command">runjunit</strong></span></span></dt><dd><p>このターゲットは、コンパイルを行い <span class="application">FindBugs</span> が持っている JUnit テストを実行します。ユニットテストが失敗した場合は、エラーメッセージが表示されます。</p></dd><dt><span class="term"><span><strong class="command">bindist</strong></span></span></dt><dd><p><span class="application">FindBugs</span> のバイナリ配布物を構築します。このターゲットは、 <code class="filename">.zip</code> および <code class="filename">.tar.gz</code> のアーカイブをそれぞれ作成します。</p></dd></dl></div><p>
-</p><p><span class="application">Ant</span> コマンドの実行後、次のような出力が表示されるはずです。 (この前に <span class="application">Ant</span> が実行したタスクに関するメッセージもいくらか出力されます。):</p><pre class="screen">
-<code class="computeroutput">
-BUILD SUCCESSFUL
-Total time: 17 seconds
-</code>
-</pre><p>
-</p></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e420"></a>5. ソースディレクトリーからの <span class="application">FindBugs</span>™ の実行</h2></div></div></div><p><span><strong class="command">build</strong></span> ターゲットの実行が終了すると、バイナリ配布物と同様の状態が作業ディレクトリーに構築されるように <span class="application">FindBugs</span> の<span class="application">Ant</span> ビルドスクリプトは記述されています。したがって、<a href="running.html" title="第4章 FindBugs™ の実行">章 4. <i><span class="application">FindBugs</span>™ の実行</i></a> の <span class="application">FindBugs</span> の実行に関する情報はソース配布物の場合にも応用できます。</p></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="installing.html">前のページ</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="running.html">次のページ</a></td></tr><tr><td width="40%" align="left" valign="top">第2章 <span class="application">FindBugs</span>™ のインストール </td><td width="20%" align="center"><a accesskey="h" href="index.html">ホーム</a></td><td width="40%" align="right" valign="top"> 第4章 <span class="application">FindBugs</span>™ の実行</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/datamining.html b/tools/findbugs-1.3.9/doc/ja/manual/datamining.html
deleted file mode 100644
index 86d5c8e..0000000
--- a/tools/findbugs-1.3.9/doc/ja/manual/datamining.html
+++ /dev/null
@@ -1,280 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>第12章 FindBugs™ によるデータ・マイニング</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ マニュアル"><link rel="up" href="index.html" title="FindBugs™ マニュアル"><link rel="prev" href="rejarForAnalysis.html" title="第11章 rejarForAnalysis の使用方法"><link rel="next" href="license.html" title="第13章 ライセンス"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">第12章 <span class="application">FindBugs</span>™ によるデータ・マイニング</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="rejarForAnalysis.html">前のページ</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="license.html">次のページ</a></td></tr></table><hr></div><div class="chapter" lang="ja"><div class="titlepage"><div><div><h2 class="title"><a name="datamining"></a>第12章 <span class="application">FindBugs</span>™ によるデータ・マイニング</h2></div></div></div><div class="toc"><p><b>目次</b></p><dl><dt><span class="sect1"><a href="datamining.html#commands">1. コマンド</a></span></dt><dt><span class="sect1"><a href="datamining.html#examples">2. 例</a></span></dt><dt><span class="sect1"><a href="datamining.html#antexample">3. Ant の例</a></span></dt></dl></div><p>バグデータベースへの高機能の問い合わせ機能、および、調査対象のコードの複数のバージョンにわたる警告の追跡記録機能を、 FindBugs は内蔵しています。これらを使って次のようなことができます。すなわち、いつバグが最初持ち込まれたかを捜し出すこと、最終リリース以後持ち込まれた警告の分析を行うこと、または、無限再起ループの数を時間軸でグラフにすることです。</p><p>これらの技術は、 FindBugs が警告の保存に使う XML 書式を使用します。これらの XML ファイルは、通常、特定の 1 分析に対する警告が入れられています。しかしそれらには、一連のソフトウェアのビルドやバージョンに対する分析結果を格納することもできます。</p><p>すべての FindBugs XML バグデータベースには、バージョン名とタイム・スタンプ が入れられています。FindBugs は分析が行われるファイルの更新時刻からタイム・スタンプを計算します (例えば、タイム・スタンプはクラスファイルの生成時刻になるようになっています。分析が行われた時刻ではありません) 。各々のバグデータベースには、バージョン名も入れられています。バージョン名とタイム・スタンプは、 <span><strong class="command">setBugDatabaseInfo</strong></span> (<a href="datamining.html#setBugDatabaseInfo" title="1.7. setBugDatabaseInfo">項1.7. 「setBugDatabaseInfo」</a>) コマンドを使用して手動で設定することもできます。</p><p>複数バージョンを格納するバグデータベースにおいては、分析されるコードの各バージョンごとにシーケンス番号が割り当てられます。これらのシーケンス番号は単に 0 から始まる連続する整数値です (例えば、 4 つのコードバージョンを格納するバグデータベースには、バージョン 0~3 が入れられます) 。バグデータベースにはまた、各バージョンの名前とタイム・スタンプがそれぞれ記録されます。<span><strong class="command">filterBugs</strong></span> コマンドを使用すると、シーケンス番号、バージョン名またはタイム・スタンプからバージョンを参照することができます。</p><p>1 バージョンを格納するバグデータベースの集合から、 1 個の複数バージョンバグデータベースを作成することができます。また、複数バージョンバグデータベースに対して、それ以後に作成された 1 バージョンのバグデータベースを結合することができます。</p><p>これらのコマンドのいくつかは、 ant タスクとして実行することができます。コマンドの実行方法および属性・引数の詳細は、以下を参照してください。以下のすべての例においては、 <code class="literal">findbugs.lib</code> <code class="literal">refid</code> が正しく設定されていることを前提としています。設定方法の一例を次に示します :</p><pre class="programlisting">
-
- <!-- findbugs タスク定義 -->
- <property name="findbugs.home" value="/your/path/to/findbugs" />
- <path id="findbugs.lib">
- <fileset dir="${findbugs.home}/lib">
- <include name="findbugs-ant.jar"/>
- </fileset>
- </path>
-
-</pre><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="commands"></a>1. コマンド</h2></div></div></div><p>FindBugs データ・マイニング ツールはすべてコマンドラインから実行することができます。また、いくつかのより有用なコマンドは、 ant ビルドファイルから実行することができます。</p><p>コマンドラインツールについて簡単に説明します :</p><div class="variablelist"><dl><dt><span class="term"><span><strong class="command"><a href="datamining.html#unionBugs" title="1.1. unionBugs">unionBugs</a></strong></span></span></dt><dd><p>別のクラスに対する別個の分析結果を結合します。</p></dd><dt><span class="term"><span><strong class="command"><a href="datamining.html#computeBugHistory" title="1.2. computeBugHistory">computeBugHistory</a></strong></span></span></dt><dd><p>複数バージョンから得られた複数のバグ警告を、マージして 1 個の複数バージョンバグデータベースにします。これを使って、既存の複数バージョンバグデータベースに更にバージョンを追加したり、 1 バージョンを格納するバグデータベースの集合から 1 個の複数バージョンバグデータベースを作成したり、できます。</p></dd><dt><span class="term"><span><strong class="command"><a href="datamining.html#setBugDatabaseInfo" title="1.7. setBugDatabaseInfo">setBugDatabaseInfo</a></strong></span></span></dt><dd><p>リビジョン名やタイム・スタンプなどの情報を XML データベースに設定します。</p></dd><dt><span class="term"><span><strong class="command"><a href="datamining.html#listBugDatabaseInfo" title="1.8. listBugDatabaseInfo">listBugDatabaseInfo</a></strong></span></span></dt><dd><p>XML データベースにあるリビジョン名やタイム・スタンプなどの情報を一覧表示します。</p></dd><dt><span class="term"><span><strong class="command"><a href="datamining.html#filterBugs" title="1.3. filterBugs">filterBugs</a></strong></span></span></dt><dd><p>バグデータベースの部分集合を選択します。</p></dd><dt><span class="term"><span><strong class="command"><a href="datamining.html#mineBugHistory" title="1.4. mineBugHistory">mineBugHistory</a></strong></span></span></dt><dd><p>複数バージョンバグデータベースの各バージョン毎の警告数を一覧にした表を作成します。</p></dd><dt><span class="term"><span><strong class="command"><a href="datamining.html#defectDensity" title="1.5. defectDensity">defectDensity</a></strong></span></span></dt><dd><p>プロジェクト全体およびクラス毎・パッケージ毎の不良密度 (1000 NCSS 毎の警告数) に関する情報を一覧表示します。</p></dd><dt><span class="term"><span><strong class="command"><a href="datamining.html#convertXmlToText" title="1.6. convertXmlToText">convertXmlToText</a></strong></span></span></dt><dd><p>XML 形式のバグ警告を、 1 行 1 バグのテキスト形式、または、HTML形式に変換します。</p></dd></dl></div><div class="sect2" lang="ja"><div class="titlepage"><div><div><h3 class="title"><a name="unionBugs"></a>1.1. unionBugs</h3></div></div></div><p>分析するのにアプリケーションの jar ファイルを分割している場合、このコマンドを使用することで、別個に生成された XML バグ警告ファイルをすべての警告を含んでいる 1 つの ファイルにすることができます。</p><p>同じファイルの異なるバージョンを分析した結果を結合する場合は、このコマンドを<span class="emphasis"><em>使用しないでください</em></span>。代わりに <span><strong class="command">computeBugHistory</strong></span> を使用してください。</p><p>XML ファイルは、コマンドラインで指定してください。結果は、標準出力に送られます。</p></div><div class="sect2" lang="ja"><div class="titlepage"><div><div><h3 class="title"><a name="computeBugHistory"></a>1.2. computeBugHistory</h3></div></div></div><p>このコマンドを使用することで、分析するソフトウェアの異なるビルドまたはバージョンの情報を含むバグデータベースを生成することができます入力として提供したファイルの 1 番目のファイルから履歴が取得されます。後に続くファイルは 1 バージョンのバグデータベースであるようにしてください (もし、履歴を持っていたとしても無視されます) 。</p><p>デフォルトでは、結果は標準出力に送られます。</p><p>この機能は、 ant からも使用することができます。まず次に示すように、ビルドファイルに <span><strong class="command">computeBugHistory</strong></span> を taskdef で定義します :</p><pre class="programlisting">
-
-<taskdef name="computeBugHistory" classname="edu.umd.cs.findbugs.anttask.ComputeBugHistoryTask">
- <classpath refid="findbugs.lib" />
-</taskdef>
-
-</pre><p>この ant タスクに指定できる属性を、下表に一覧で示します。入力ファイルを指定するには、 <code class="literal"><datafile></code> 要素を入れ子にして入れてください。次に、例を示します:</p><pre class="programlisting">
-
-<computeBugHistory home="${findbugs.home}" ...>
- <datafile name="analyze1.xml"/>
- <datafile name="analyze2.xml"/>
-</computeBugHistory>
-
-</pre><div class="table"><a name="computeBugHistoryTable"></a><p class="title"><b>表 12.1. computeBugHistory コマンドのオプション一覧</b></p><div class="table-contents"><table summary="computeBugHistory コマンドのオプション一覧" border="1"><colgroup><col><col><col></colgroup><thead><tr><th align="left">コマンドラインオプション</th><th align="left">Ant 属性</th><th align="left">目的</th></tr></thead><tbody><tr><td align="left">-output <file></td><td align="left">output="<file>"</td><td align="left">出力結果を保存するファイル名を指定します。 (同時に入力ファイルにもなりえます)</td></tr><tr><td align="left">-overrideRevisionNames[:truth]</td><td align="left">overrideRevisionNames="[true|false]"</td><td align="left">ファイル名から算出されるそれぞれのバージョン名を指定変更します。</td></tr><tr><td align="left">-noPackageMoves[:truth]</td><td align="left">noPackageMoves="[true|false]"</td><td align="left">パッケージを移動したクラスがある場合、当該クラスの警告は別の存在として扱われます。</td></tr><tr><td align="left">-preciseMatch[:truth]</td><td align="left">preciseMatch="[true|false]"</td><td align="left">バグパターンが正確に一致することを要求します。</td></tr><tr><td align="left">-precisePriorityMatch[:truth]</td><td align="left">precisePriorityMatch="[true|false]"</td><td align="left">優先度が正確に一致した場合のみ警告が同一であると判断されます。</td></tr><tr><td align="left">-quiet[:truth]</td><td align="left">quiet="[true|false]"</td><td align="left">エラーが発生しない限り、標準出力には何も表示されません。</td></tr><tr><td align="left">-withMessages[:truth]</td><td align="left">withMessages="[true|false]"</td><td align="left">出力 XML に人間が読むことができるバグメッセージが含まれます。</td></tr></tbody></table></div></div><br class="table-break"></div><div class="sect2" lang="ja"><div class="titlepage"><div><div><h3 class="title"><a name="filterBugs"></a>1.3. filterBugs</h3></div></div></div><p>このコマンドを使用することで、 FindBugs XML 警告ファイルから一部分を選び出して新規 FindBugs 警告ファイルに選択された部分を書き込むことができます。</p><p>このコマンドには、オプション群に続いて 0 個から 2 個の findbugs xml バグファイルを指定することができます。</p><p>ファイル名をひとつも指定しない場合は、標準入力から読んで標準出力に出力されます。ファイル名を 1 個 指定した場合は、指定したファイルから読んで標準出力に出力されます。ファイル名を 2 個 指定した場合は、 1 番目に指定したファイルから読んで 2 番目に指定したファイルに出力されます。</p><p>この機能は、 ant からも使用することができます。まず次に示すように、ビルドファイルに <span><strong class="command">filterBugs</strong></span> を taskdef で定義します :</p><pre class="programlisting">
-
-<taskdef name="filterBugs" classname="edu.umd.cs.findbugs.anttask.FilterBugsTask">
- <classpath refid="findbugs.lib" />
-</taskdef>
-
-</pre><p>この ant タスクに指定できる属性を、下表に一覧で示します。入力ファイルを指定するには、 <code class="literal">input</code> 属性を使用するか、 <code class="literal"><datafile></code> 要素を入れ子にして入れてください。次に、例を示します:</p><pre class="programlisting">
-
-<filterBugs home="${findbugs.home}" ...>
- <datafile name="analyze.xml"/>
-</filterBugs>
-
-</pre><div class="table"><a name="filterOptionsTable"></a><p class="title"><b>表 12.2. filterBugs コマンドのオプション一覧</b></p><div class="table-contents"><table summary="filterBugs コマンドのオプション一覧" border="1"><colgroup><col><col><col></colgroup><thead><tr><th align="left">コマンドラインオプション</th><th align="left">Ant 属性</th><th align="left">目的</th></tr></thead><tbody><tr><td align="left"> </td><td align="left">input="<file>"</td><td align="left">入力ファイルを指定します。</td></tr><tr><td align="left"> </td><td align="left">output="<file>"</td><td align="left">出力ファイルを指定します。</td></tr><tr><td align="left">-not</td><td align="left">not="[true|false]"</td><td align="left">フィルターのスイッチを反転します。</td></tr><tr><td align="left">-withSource[:truth]</td><td align="left">withSource="[true|false]"</td><td align="left">ソースが入手可能な警告のみ出力されます。</td></tr><tr><td align="left">-exclude <filter file></td><td align="left">exclude="<filter file>"</td><td align="left">フィルターに一致するバグが除外されます。</td></tr><tr><td align="left">-include <filter file></td><td align="left">include="<filter file>"</td><td align="left">フィルターに一致するバグのみを含まれます。</td></tr><tr><td align="left">-annotation <text></td><td align="left">annotation="<text>"</td><td align="left">手で入力した注釈に指定した文言を含む警告のみ出力されます。</td></tr><tr><td align="left">-after <when></td><td align="left">after="<when>"</td><td align="left">指定したバージョンより後に初めて出現した警告のみ出力されます。</td></tr><tr><td align="left">-before <when></td><td align="left">before="<when>"</td><td align="left">指定したバージョンより前に初めて出現した警告のみ出力されます。</td></tr><tr><td align="left">-first <when></td><td align="left">first="<when>"</td><td align="left">指定したバージョンに初めて出現した警告のみ出力されます。</td></tr><tr><td align="left">-last <when></td><td align="left">last="<when>"</td><td align="left">指定したバージョンが出現した最後である警告のみ出力されます。</td></tr><tr><td align="left">-fixed <when></td><td align="left">fixed="<when>"</td><td align="left">指定したバージョンの前回のバージョンが出現した最後である警告のみ出力されます。 (<code class="option">-last</code> に優先します)。</td></tr><tr><td align="left">-present <when></td><td align="left">present="<when>"</td><td align="left">指定したバージョンに存在する警告のみ出力されます。</td></tr><tr><td align="left">-absent <when></td><td align="left">absent="<when>"</td><td align="left">指定したバージョンに存在しない警告のみ出力されます。</td></tr><tr><td align="left">-active[:truth]</td><td align="left">active="[true|false]"</td><td align="left">最終通番に存在する警告のみ出力されます。</td></tr><tr><td align="left">-introducedByChange[:truth]</td><td align="left">introducedByChange="[true|false]"</td><td align="left">存在するクラスの変更によってもたらされた警告のみ出力されます。</td></tr><tr><td align="left">-removedByChange[:truth]</td><td align="left">removedByChange="[true|false]"</td><td align="left">存在するクラスの変更によって除去された警告のみ出力されます。</td></tr><tr><td align="left">-newCode[:truth]</td><td align="left">newCode="[true|false]"</td><td align="left">新クラスの追加によってもたらされた警告のみ出力されます。</td></tr><tr><td align="left">-removedCode[:truth]</td><td align="left">removedCode="[true|false]"</td><td align="left">クラスの削除によって除去された警告のみ出力されます。</td></tr><tr><td align="left">-priority <level></td><td align="left">priority="<level>"</td><td align="left">指定した優先度以上の優先度をもつ警告のみ出力されます。</td></tr><tr><td align="left">-class <pattern></td><td align="left">class="<class>"</td><td align="left">指定したパターンに一致する主クラスをもつ警告のみ出力されます。</td></tr><tr><td align="left">-bugPattern <pattern></td><td align="left">bugPattern="<pattern>"</td><td align="left">指定したパターンに一致するバグ種別をもつ警告のみ出力されます。</td></tr><tr><td align="left">-category <category></td><td align="left">category="<category>"</td><td align="left">指定した文字列で始まるカテゴリーの警告のみ出力されます。</td></tr><tr><td align="left">-designation <designation></td><td align="left">designation="<designation>"</td><td align="left">指定したバグ分類指定をもつ警告のみ出力されます。 (例、 -designation SHOULD_FIX)</td></tr><tr><td align="left">-withMessages[:truth] </td><td align="left">withMessages="[true|false]"</td><td align="left">テキストメッセージを含んだ XML が生成されます。</td></tr></tbody></table></div></div><br class="table-break"></div><div class="sect2" lang="ja"><div class="titlepage"><div><div><h3 class="title"><a name="mineBugHistory"></a>1.4. mineBugHistory</h3></div></div></div><p>このコマンドを使用することで、複数バージョンバグデータベースの各バージョン毎の警告数を一覧にした表を作成することができます。</p><p>この機能は、 ant からも使用することができます。まず次に示すように、ビルドファイルに <span><strong class="command">mineBugHistory</strong></span> を taskdef で定義します :</p><pre class="programlisting">
-
-<taskdef name="mineBugHistory" classname="edu.umd.cs.findbugs.anttask.MineBugHistoryTask">
- <classpath refid="findbugs.lib" />
-</taskdef>
-
-</pre><p>この ant タスクに指定できる属性を、下表に一覧で示します。入力ファイルを指定するには、 <code class="literal">input</code> 属性を使用するか、 <code class="literal"><datafile></code> 要素を入れ子にして入れてください。次に、例を示します:</p><pre class="programlisting">
-
-<mineBugHistory home="${findbugs.home}" ...>
- <datafile name="analyze.xml"/>
-</mineBugHistory>
-
-</pre><div class="table"><a name="mineBugHistoryOptionsTable"></a><p class="title"><b>表 12.3. mineBugHistory コマンドのオプション一覧</b></p><div class="table-contents"><table summary="mineBugHistory コマンドのオプション一覧" border="1"><colgroup><col><col><col></colgroup><thead><tr><th align="left">コマンドラインオプション</th><th align="left">Ant 属性</th><th align="left">目的</th></tr></thead><tbody><tr><td align="left"> </td><td align="left">input="<file>"</td><td align="left">入力ファイルを指定します。</td></tr><tr><td align="left"> </td><td align="left">output="<file>"</td><td align="left">出力ファイルを指定します。</td></tr><tr><td align="left">-formatDates</td><td align="left">formatDates="[true|false]"</td><td align="left">データがテキスト形式で描画されます。</td></tr><tr><td align="left">-noTabs</td><td align="left">noTabs="[true|false]"</td><td align="left">タブの代わりに複数スペースでカラムが区切られます (下記参照)。</td></tr><tr><td align="left">-summary</td><td align="left">summary="[true|false]"</td><td align="left">最新 10 件の変更の要約が出力されます。</td></tr></tbody></table></div></div><br class="table-break"><p><code class="option">-noTabs</code> 出力を使うことで、固定幅フォントのシェルで読み易くなります。数値カラムは右寄せされるので、スペースがカラム値の前に挿入されます。また、このオプションを使用した場合、 <code class="option">-formatDates</code> を指定したときに要約の日付を描画するのに空白が埋め込まれなくなります。</p><p>出力される表は、 (<code class="option">-noTabs</code> が無ければ) タブ区切りで次に示すカラムから成ります :</p><div class="table"><a name="mineBugHistoryColumns"></a><p class="title"><b>表 12.4. mineBugHistory 出力のカラム一覧</b></p><div class="table-contents"><table summary="mineBugHistory 出力のカラム一覧" border="1"><colgroup><col><col></colgroup><thead><tr><th align="left">表題</th><th align="left">目的</th></tr></thead><tbody><tr><td align="left">seq</td><td align="left">シーケンス番号 (0 始まりの連続した整数値)</td></tr><tr><td align="left">version</td><td align="left">バージョン名</td></tr><tr><td align="left">time</td><td align="left">リリースされた日時</td></tr><tr><td align="left">classes</td><td align="left">分析されたクラス数</td></tr><tr><td align="left">NCSS</td><td align="left">コメント文を除いた命令数 (Non Commenting Source Statements)</td></tr><tr><td align="left">added</td><td align="left">前回のバージョンに存在したクラスにおける新規警告数</td></tr><tr><td align="left">newCode</td><td align="left">前回のバージョンに存在しなかったクラスにおける新規警告数</td></tr><tr><td align="left">fixed</td><td align="left">現在のバージョンに存在するクラスにおける除去された警告数</td></tr><tr><td align="left">removed</td><td align="left">現在のバージョンに存在しないクラスの前回のバージョンにおける警告数</td></tr><tr><td align="left">retained</td><td align="left">現在のバージョンと前回のバージョンの両方に存在する警告の数</td></tr><tr><td align="left">dead</td><td align="left">以前のバージョンに存在したが現在のバージョンにも直前のバージョンにも存在しない警告の数</td></tr><tr><td align="left">active</td><td align="left">現在のバージョンに存在する警告総数</td></tr></tbody></table></div></div><br class="table-break"></div><div class="sect2" lang="ja"><div class="titlepage"><div><div><h3 class="title"><a name="defectDensity"></a>1.5. defectDensity</h3></div></div></div><p>このコマンドを使用することで、プロジェクト全体およびクラス毎・パッケージ毎の不良密度 (1000 NCSS 毎の警告数) に関する情報を一覧表示できます。標準入力から読み込む場合はファイル指定なしで、そうでなければ、コマンドラインでファイルを指定して、このコマンドを実行します。</p><p>出力される表は、次に示すカラムから成ります。また、プロジェクト全体情報の行、および、4 個以上の警告を含んでいる各パッケージ情報または各クラス情報の行も出力されます。</p><div class="table"><a name="defectDensityColumns"></a><p class="title"><b>表 12.5. defectDensity 出力のカラム一覧</b></p><div class="table-contents"><table summary="defectDensity 出力のカラム一覧" border="1"><colgroup><col><col></colgroup><thead><tr><th align="left">表題</th><th align="left">目的</th></tr></thead><tbody><tr><td align="left">kind</td><td align="left">プロジェクト (project)、パッケージ (package) またはクラス (class)</td></tr><tr><td align="left">name</td><td align="left">プロジェクト、パッケージまたはクラスの名前</td></tr><tr><td align="left">density</td><td align="left"> 1000 NCSS 毎の警告数</td></tr><tr><td align="left">bugs</td><td align="left">警告数</td></tr><tr><td align="left">NCSS</td><td align="left">コメント文を除いた命令数 (Non Commenting Source Statements) </td></tr></tbody></table></div></div><br class="table-break"></div><div class="sect2" lang="ja"><div class="titlepage"><div><div><h3 class="title"><a name="convertXmlToText"></a>1.6. convertXmlToText</h3></div></div></div><p>このコマンドを使用することで、XML 形式のバグ警告を、 1 行 1 バグのテキスト形式、または、HTML形式に変換することができます。</p><p>この機能は、 ant からも使用することができます。まず次に示すように、ビルドファイルに <span><strong class="command">convertXmlToText</strong></span> を taskdef で定義します :</p><pre class="programlisting">
-
-<taskdef name="convertXmlToText" classname="edu.umd.cs.findbugs.anttask.ConvertXmlToTextTask">
- <classpath refid="findbugs.lib" />
-</taskdef>
-
-</pre><p>この ant タスクに指定できる属性を、下表に一覧で示します。</p><div class="table"><a name="convertXmlToTextTable"></a><p class="title"><b>表 12.6. convertXmlToText コマンドのオプション一覧</b></p><div class="table-contents"><table summary="convertXmlToText コマンドのオプション一覧" border="1"><colgroup><col><col><col></colgroup><thead><tr><th align="left">コマンドラインオプション</th><th align="left">Ant 属性</th><th align="left">目的</th></tr></thead><tbody><tr><td align="left"> </td><td align="left">input="<filename>"</td><td align="left">入力ファイルを指定します。</td></tr><tr><td align="left"> </td><td align="left">output="<filename>"</td><td align="left">出力ファイルを指定します。</td></tr><tr><td align="left">-longBugCodes</td><td align="left">longBugCodes="[true|false]"</td><td align="left">2 文字のバグ略称の代わりに、省略なしのバグパターンコードを使用します。</td></tr><tr><td align="left"> </td><td align="left">format="text"</td><td align="left">プレーンテキストの出力が作成されます。1 行につき 1 つのバグが出力されます。コマンドライン時のデフォルトです。</td></tr><tr><td align="left">-html[:stylesheet]</td><td align="left">format="html:<stylesheet>"</td><td align="left">指定されたスタイルシートを使用して出力が作成されます (下記参照) 。省略した場合は、 default.xsl が使用されます。</td></tr></tbody></table></div></div><br class="table-break"><p>-html/format オプションには、plain.xsl 、 default.xsl 、 fancy.xsl 、 fancy-hist.xsl または ユーザ自身が作成した XSL スタイルシートのいずれかを指定することができます。オプション名をよそに、 html 以外の形式を出力するスタイルシートを指定することもできます。FindBugs に含まれているスタイルシート(上述)以外のスタイルシートを使用する場合は、オプション -html/format で当該スタイルシートへのパスまたは URL を指定してください。</p></div><div class="sect2" lang="ja"><div class="titlepage"><div><div><h3 class="title"><a name="setBugDatabaseInfo"></a>1.7. setBugDatabaseInfo</h3></div></div></div><p>このコマンドを使用することで、指定したバグ警告にメタ情報を設定することができます。このコマンドには次に示すオプションがあります:</p><p>この機能は、 ant からも使用することができます。まず次に示すように、ビルドファイルに <span><strong class="command">setBugDatabaseInfo</strong></span> を taskdef で定義します :</p><pre class="programlisting">
-
-<taskdef name="setBugDatabaseInfo" classname="edu.umd.cs.findbugs.anttask.SetBugDatabaseInfoTask">
- <classpath refid="findbugs.lib" />
-</taskdef>
-
-</pre><p>この ant タスクに指定できる属性を、下表に一覧で示します。入力ファイルを指定するには、 <code class="literal">input</code> 属性を使用するか、 <code class="literal"><datafile></code> 要素を入れ子にして入れてください。次に、例を示します:</p><pre class="programlisting">
-
-<setBugDatabaseInfo home="${findbugs.home}" ...>
- <datafile name="analyze.xml"/>
-</setBugDatabaseInfo>
-
-</pre><div class="table"><a name="setBugDatabaseInfoOptions"></a><p class="title"><b>表 12.7. setBugDatabaseInfo オプション一覧</b></p><div class="table-contents"><table summary="setBugDatabaseInfo オプション一覧" border="1"><colgroup><col><col><col></colgroup><thead><tr><th align="left">コマンドラインオプション</th><th align="left">Ant 属性</th><th align="left">目的</th></tr></thead><tbody><tr><td align="left"> </td><td align="left">input="<file>"</td><td align="left">入力ファイルを指定します。</td></tr><tr><td align="left"> </td><td align="left">output="<file>"</td><td align="left">出力ファイルを指定します。</td></tr><tr><td align="left">-name <name></td><td align="left">name="<name>"</td><td align="left">最新リビジョンの名前を設定します。</td></tr><tr><td align="left">-timestamp <when></td><td align="left">timestamp="<when>"</td><td align="left">最新リビジョンのタイム・スタンプを設定します。</td></tr><tr><td align="left">-source <directory></td><td align="left">source="<directory>"</td><td align="left">ソースを検索するディレクトリーを追加指定します。</td></tr><tr><td align="left">-findSource <directory></td><td align="left">findSource="<directory>"</td><td align="left">指定したディレクトリー内を検索して関連するソースの場所を追加します。</td></tr><tr><td align="left">-suppress <filter file></td><td align="left">suppress="<filter file>"</td><td align="left">指定したファイルに一致する警告を抑止します (以前に指定した抑止設定は置き換えられます)。</td></tr><tr><td align="left">-withMessages</td><td align="left">withMessages="[true|false]"</td><td align="left">XMLにテキストメッセージを追加します。</td></tr><tr><td align="left">-resetSource</td><td align="left">resetSource="[true|false]"</td><td align="left">ソース検索パスをすべて削除します。</td></tr></tbody></table></div></div><br class="table-break"></div><div class="sect2" lang="ja"><div class="titlepage"><div><div><h3 class="title"><a name="listBugDatabaseInfo"></a>1.8. listBugDatabaseInfo</h3></div></div></div><p>このコマンドの実行においては、コマンドラインで 0 個以上の xml バグデータベースファイル名を指定します。ファイル名を1つも指定しなければ、標準出力から読み込みを行いテーブルのヘッダーは生成されません。</p><p>このコマンドには 1 つだけオプションがあります : <code class="option">-formatDates</code> を指定するとテキスト形式でデータが描画されます。</p><p>出力される表は、各バグデータベースごとに行を持ち、次に示すカラムから成ります :</p><div class="table"><a name="listBugDatabaseInfoColumns"></a><p class="title"><b>表 12.8. listBugDatabaseInfo カラム一覧</b></p><div class="table-contents"><table summary="listBugDatabaseInfo カラム一覧" border="1"><colgroup><col><col></colgroup><thead><tr><th align="left">カラム</th><th align="left">目的</th></tr></thead><tbody><tr><td align="left">version</td><td align="left">バージョン名</td></tr><tr><td align="left">time</td><td align="left">リリースされた日時</td></tr><tr><td align="left">classes</td><td align="left">分析されたクラス数</td></tr><tr><td align="left">NCSS</td><td align="left">コメント文を除いた命令数 (Non Commenting Source Statements)</td></tr><tr><td align="left">total</td><td align="left">全警告数</td></tr><tr><td align="left">high</td><td align="left">優先度(高)の警告の総数</td></tr><tr><td align="left">medium</td><td align="left">優先度(中)の警告の総数</td></tr><tr><td align="left">low</td><td align="left">優先度(低)の警告の総数</td></tr><tr><td align="left">filename</td><td align="left">データベースのファイル名</td></tr></tbody></table></div></div><br class="table-break"></div></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="examples"></a>2. 例</h2></div></div></div><div class="sect2" lang="ja"><div class="titlepage"><div><div><h3 class="title"><a name="unixscriptsexamples"></a>2.1. 提供されたシェル・スクリプトを使用しての履歴マイニング</h3></div></div></div><p>以下はすべて、 jdk1.6.0-b12, jdk1.6.0-b13, ..., jdk1.6.0-b60 のディレクトリに対してコマンドを実行しています。</p><p>以下のコマンドを実行してみます :</p><pre class="screen">
-computeBugHistory jdk1.6.0-b* | filterBugs -bugPattern IL_ | mineBugHistory -formatDates
-</pre><p>すると、次のような出力が行われます :</p><pre class="screen">
-seq version time classes NCSS added newCode fixed removed retained dead active
-0 jdk1.6.0-b12 "Thu Nov 11 09:07:20 EST 2004" 13128 811569 0 4 0 0 0 0 4
-1 jdk1.6.0-b13 "Thu Nov 18 06:02:06 EST 2004" 13128 811570 0 0 0 0 4 0 4
-2 jdk1.6.0-b14 "Thu Dec 02 06:12:26 EST 2004" 13145 811786 0 0 2 0 2 0 2
-3 jdk1.6.0-b15 "Thu Dec 09 06:07:04 EST 2004" 13174 811693 0 0 1 0 1 2 1
-4 jdk1.6.0-b16 "Thu Dec 16 06:21:28 EST 2004" 13175 811715 0 0 0 0 1 3 1
-5 jdk1.6.0-b17 "Thu Dec 23 06:27:22 EST 2004" 13176 811974 0 0 0 0 1 3 1
-6 jdk1.6.0-b19 "Thu Jan 13 06:41:16 EST 2005" 13176 812011 0 0 0 0 1 3 1
-7 jdk1.6.0-b21 "Thu Jan 27 05:57:52 EST 2005" 13177 812173 0 0 0 0 1 3 1
-8 jdk1.6.0-b23 "Thu Feb 10 05:44:36 EST 2005" 13179 812188 0 0 0 0 1 3 1
-9 jdk1.6.0-b26 "Thu Mar 03 06:04:02 EST 2005" 13199 811770 0 0 0 0 1 3 1
-10 jdk1.6.0-b27 "Thu Mar 10 04:48:38 EST 2005" 13189 812440 0 0 0 0 1 3 1
-11 jdk1.6.0-b28 "Thu Mar 17 02:54:22 EST 2005" 13185 812056 0 0 0 0 1 3 1
-12 jdk1.6.0-b29 "Thu Mar 24 03:09:20 EST 2005" 13117 809468 0 0 0 0 1 3 1
-13 jdk1.6.0-b30 "Thu Mar 31 02:53:32 EST 2005" 13118 809501 0 0 0 0 1 3 1
-14 jdk1.6.0-b31 "Thu Apr 07 03:00:14 EDT 2005" 13117 809572 0 0 0 0 1 3 1
-15 jdk1.6.0-b32 "Thu Apr 14 02:56:56 EDT 2005" 13169 811096 0 0 0 0 1 3 1
-16 jdk1.6.0-b33 "Thu Apr 21 02:46:22 EDT 2005" 13187 811942 0 0 0 0 1 3 1
-17 jdk1.6.0-b34 "Thu Apr 28 02:49:00 EDT 2005" 13195 813488 0 1 0 0 1 3 2
-18 jdk1.6.0-b35 "Thu May 05 02:49:04 EDT 2005" 13457 829837 0 0 0 0 2 3 2
-19 jdk1.6.0-b36 "Thu May 12 02:59:46 EDT 2005" 13462 831278 0 0 0 0 2 3 2
-20 jdk1.6.0-b37 "Thu May 19 02:55:08 EDT 2005" 13464 831971 0 0 0 0 2 3 2
-21 jdk1.6.0-b38 "Thu May 26 03:08:16 EDT 2005" 13564 836565 0 0 0 0 2 3 2
-22 jdk1.6.0-b39 "Fri Jun 03 03:10:48 EDT 2005" 13856 849992 0 1 0 0 2 3 3
-23 jdk1.6.0-b40 "Thu Jun 09 03:30:28 EDT 2005" 15972 959619 0 2 0 0 3 3 5
-24 jdk1.6.0-b41 "Thu Jun 16 03:19:22 EDT 2005" 15972 959619 0 0 0 0 5 3 5
-25 jdk1.6.0-b42 "Fri Jun 24 03:38:54 EDT 2005" 15966 958581 0 0 0 0 5 3 5
-26 jdk1.6.0-b43 "Thu Jul 14 03:09:34 EDT 2005" 16041 960544 0 0 0 0 5 3 5
-27 jdk1.6.0-b44 "Thu Jul 21 03:05:54 EDT 2005" 16041 960547 0 0 0 0 5 3 5
-28 jdk1.6.0-b45 "Thu Jul 28 03:26:10 EDT 2005" 16037 960606 0 0 1 0 4 3 4
-29 jdk1.6.0-b46 "Thu Aug 04 03:02:48 EDT 2005" 15936 951355 0 0 0 0 4 4 4
-30 jdk1.6.0-b47 "Thu Aug 11 03:18:56 EDT 2005" 15964 952387 0 0 1 0 3 4 3
-31 jdk1.6.0-b48 "Thu Aug 18 08:10:40 EDT 2005" 15970 953421 0 0 0 0 3 5 3
-32 jdk1.6.0-b49 "Thu Aug 25 03:24:38 EDT 2005" 16048 958940 0 0 0 0 3 5 3
-33 jdk1.6.0-b50 "Thu Sep 01 01:52:40 EDT 2005" 16287 974937 1 0 0 0 3 5 4
-34 jdk1.6.0-b51 "Thu Sep 08 01:55:36 EDT 2005" 16362 979377 0 0 0 0 4 5 4
-35 jdk1.6.0-b52 "Thu Sep 15 02:04:08 EDT 2005" 16477 979399 0 0 0 0 4 5 4
-36 jdk1.6.0-b53 "Thu Sep 22 02:00:28 EDT 2005" 16019 957900 0 0 1 0 3 5 3
-37 jdk1.6.0-b54 "Thu Sep 29 01:54:34 EDT 2005" 16019 957900 0 0 0 0 3 6 3
-38 jdk1.6.0-b55 "Thu Oct 06 01:54:14 EDT 2005" 16051 959014 0 0 0 0 3 6 3
-39 jdk1.6.0-b56 "Thu Oct 13 01:54:12 EDT 2005" 16211 970835 0 0 0 0 3 6 3
-40 jdk1.6.0-b57 "Thu Oct 20 01:55:26 EDT 2005" 16279 971627 0 0 0 0 3 6 3
-41 jdk1.6.0-b58 "Thu Oct 27 01:56:30 EDT 2005" 16283 971945 0 0 0 0 3 6 3
-42 jdk1.6.0-b59 "Thu Nov 03 01:56:58 EST 2005" 16232 972193 0 0 0 0 3 6 3
-43 jdk1.6.0-b60 "Thu Nov 10 01:54:18 EST 2005" 16235 972346 0 0 0 0 3 6 3
-</pre><p>次に示すコマンドを実行すると、db.xml 中間ファイルを生成することなく直接同じ情報を作成できます。</p><pre class="screen">
-computeBugHistory jdk1.6.0-b*/jre/lib/rt.xml | filterBugs -bugPattern IL_ db.xml | mineBugHistory -formatDates
-</pre><p>この情報を使って、 Sun JDK1.6.0 の各ビルドにおいて FindBugs によって発見された無限再起ループの数を表すグラフを表示します。青色の領域は、当該ビルドにおける無限再起ループの数を表しています。その上に描かれている赤色の領域は、以前のバージョンには存在したが当該バージョンでは除去された無限再起ループの数を表しています。 (したがって、赤色の領域と青色の領域を足し合わせた高さは決して減少しないことが保証されています。そして、新たに無限再起ループのバグが持ち込まれた時点で増加します) 。赤色の領域の高さは、当該バージョンにおいて修正または削除されたバグ数の合計で算出されます。バージョン 13 および 14 において見られる減少は、 FindBugs を使用して見つかった JDK のバグの報告を Sun が受け取ったことによるものです。</p><div class="mediaobject"><img src="infiniteRecursiveLoops.png"></div><p>db.xml ファイルは、 jdk1.6.0 のすべてのビルドに対する検索結果を保持しています。したがって、次に示すコマンドを実行することで、優先度(高)または優先度(低)の正確性に関する警告の履歴が表示されます :</p><pre class="screen">
-filterBugs -priority M -category C db.xml | mineBugHistory -formatDates
-</pre><p>作成される表の例 :</p><pre class="screen">
-seq version time classes NCSS added newCode fixed removed retained dead active
-0 jdk1.6.0-b12 "Thu Nov 11 09:07:20 EST 2004" 13128 811569 0 1075 0 0 0 0 1075
-1 jdk1.6.0-b13 "Thu Nov 18 06:02:06 EST 2004" 13128 811570 0 0 0 0 1075 0 1075
-2 jdk1.6.0-b14 "Thu Dec 02 06:12:26 EST 2004" 13145 811786 3 0 6 0 1069 0 1072
-3 jdk1.6.0-b15 "Thu Dec 09 06:07:04 EST 2004" 13174 811693 2 1 3 0 1069 6 1072
-4 jdk1.6.0-b16 "Thu Dec 16 06:21:28 EST 2004" 13175 811715 0 0 1 0 1071 9 1071
-5 jdk1.6.0-b17 "Thu Dec 23 06:27:22 EST 2004" 13176 811974 0 0 1 0 1070 10 1070
-6 jdk1.6.0-b19 "Thu Jan 13 06:41:16 EST 2005" 13176 812011 0 0 0 0 1070 11 1070
-7 jdk1.6.0-b21 "Thu Jan 27 05:57:52 EST 2005" 13177 812173 0 0 1 0 1069 11 1069
-8 jdk1.6.0-b23 "Thu Feb 10 05:44:36 EST 2005" 13179 812188 0 0 0 0 1069 12 1069
-9 jdk1.6.0-b26 "Thu Mar 03 06:04:02 EST 2005" 13199 811770 0 0 2 1 1066 12 1066
-10 jdk1.6.0-b27 "Thu Mar 10 04:48:38 EST 2005" 13189 812440 1 0 1 1 1064 15 1065
-11 jdk1.6.0-b28 "Thu Mar 17 02:54:22 EST 2005" 13185 812056 0 0 0 0 1065 17 1065
-12 jdk1.6.0-b29 "Thu Mar 24 03:09:20 EST 2005" 13117 809468 3 0 8 26 1031 17 1034
-13 jdk1.6.0-b30 "Thu Mar 31 02:53:32 EST 2005" 13118 809501 0 0 0 0 1034 51 1034
-14 jdk1.6.0-b31 "Thu Apr 07 03:00:14 EDT 2005" 13117 809572 0 0 0 0 1034 51 1034
-15 jdk1.6.0-b32 "Thu Apr 14 02:56:56 EDT 2005" 13169 811096 1 1 0 1 1033 51 1035
-16 jdk1.6.0-b33 "Thu Apr 21 02:46:22 EDT 2005" 13187 811942 3 0 2 1 1032 52 1035
-17 jdk1.6.0-b34 "Thu Apr 28 02:49:00 EDT 2005" 13195 813488 0 1 0 0 1035 55 1036
-18 jdk1.6.0-b35 "Thu May 05 02:49:04 EDT 2005" 13457 829837 0 36 2 0 1034 55 1070
-19 jdk1.6.0-b36 "Thu May 12 02:59:46 EDT 2005" 13462 831278 0 0 0 0 1070 57 1070
-20 jdk1.6.0-b37 "Thu May 19 02:55:08 EDT 2005" 13464 831971 0 1 1 0 1069 57 1070
-21 jdk1.6.0-b38 "Thu May 26 03:08:16 EDT 2005" 13564 836565 1 7 2 6 1062 58 1070
-22 jdk1.6.0-b39 "Fri Jun 03 03:10:48 EDT 2005" 13856 849992 6 39 5 0 1065 66 1110
-23 jdk1.6.0-b40 "Thu Jun 09 03:30:28 EDT 2005" 15972 959619 7 147 11 0 1099 71 1253
-24 jdk1.6.0-b41 "Thu Jun 16 03:19:22 EDT 2005" 15972 959619 0 0 0 0 1253 82 1253
-25 jdk1.6.0-b42 "Fri Jun 24 03:38:54 EDT 2005" 15966 958581 3 0 1 2 1250 82 1253
-26 jdk1.6.0-b43 "Thu Jul 14 03:09:34 EDT 2005" 16041 960544 5 11 15 8 1230 85 1246
-27 jdk1.6.0-b44 "Thu Jul 21 03:05:54 EDT 2005" 16041 960547 0 0 0 0 1246 108 1246
-28 jdk1.6.0-b45 "Thu Jul 28 03:26:10 EDT 2005" 16037 960606 19 0 2 0 1244 108 1263
-29 jdk1.6.0-b46 "Thu Aug 04 03:02:48 EDT 2005" 15936 951355 13 1 1 32 1230 110 1244
-30 jdk1.6.0-b47 "Thu Aug 11 03:18:56 EDT 2005" 15964 952387 163 8 7 20 1217 143 1388
-31 jdk1.6.0-b48 "Thu Aug 18 08:10:40 EDT 2005" 15970 953421 0 0 0 0 1388 170 1388
-32 jdk1.6.0-b49 "Thu Aug 25 03:24:38 EDT 2005" 16048 958940 1 11 1 0 1387 170 1399
-33 jdk1.6.0-b50 "Thu Sep 01 01:52:40 EDT 2005" 16287 974937 19 27 16 7 1376 171 1422
-34 jdk1.6.0-b51 "Thu Sep 08 01:55:36 EDT 2005" 16362 979377 1 15 3 0 1419 194 1435
-35 jdk1.6.0-b52 "Thu Sep 15 02:04:08 EDT 2005" 16477 979399 0 0 1 1 1433 197 1433
-36 jdk1.6.0-b53 "Thu Sep 22 02:00:28 EDT 2005" 16019 957900 13 12 16 20 1397 199 1422
-37 jdk1.6.0-b54 "Thu Sep 29 01:54:34 EDT 2005" 16019 957900 0 0 0 0 1422 235 1422
-38 jdk1.6.0-b55 "Thu Oct 06 01:54:14 EDT 2005" 16051 959014 1 4 7 0 1415 235 1420
-39 jdk1.6.0-b56 "Thu Oct 13 01:54:12 EDT 2005" 16211 970835 6 8 37 0 1383 242 1397
-40 jdk1.6.0-b57 "Thu Oct 20 01:55:26 EDT 2005" 16279 971627 0 0 0 0 1397 279 1397
-41 jdk1.6.0-b58 "Thu Oct 27 01:56:30 EDT 2005" 16283 971945 0 1 1 0 1396 279 1397
-42 jdk1.6.0-b59 "Thu Nov 03 01:56:58 EST 2005" 16232 972193 6 0 5 0 1392 280 1398
-43 jdk1.6.0-b60 "Thu Nov 10 01:54:18 EST 2005" 16235 972346 0 0 0 0 1398 285 1398
-44 jdk1.6.0-b61 "Thu Nov 17 01:58:42 EST 2005" 16202 971134 2 0 4 0 1394 285 1396
-</pre></div><div class="sect2" lang="ja"><div class="titlepage"><div><div><h3 class="title"><a name="incrementalhistory"></a>2.2. 増分履歴メンテナンス</h3></div></div></div><p>仮に、 db.xml がビルド b12 - b60 に対する findbugs 実行結果を保持している場合、次に示すコマンドを実行することで、 db.xml に b61 に対する実行結果を追加することができます :</p><pre class="screen">
-computeBugHistory -output db.xml db.xml jdk1.6.0-b61/jre/lib/rt.xml
-</pre></div></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="antexample"></a>3. Ant の例</h2></div></div></div><p>findbugs の実行とその後のデータ・マイニングツールの活用の両方を実行している ant スクリプトの完全な例を以下に示します :</p><pre class="screen">
-
-<project name="analyze_asm_util" default="findbugs">
- <!-- findbugs タスク定義 -->
- <property name="findbugs.home" value="/Users/ben/Documents/workspace/findbugs/findbugs" />
- <property name="jvmargs" value="-server -Xss1m -Xmx800m -Duser.language=en -Duser.region=EN -Dfindbugs.home=${findbugs.home}" />
-
- <path id="findbugs.lib">
- <fileset dir="${findbugs.home}/lib">
- <include name="findbugs-ant.jar"/>
- </fileset>
- </path>
-
- <taskdef name="findbugs" classname="edu.umd.cs.findbugs.anttask.FindBugsTask">
- <classpath refid="findbugs.lib" />
- </taskdef>
-
- <taskdef name="computeBugHistory" classname="edu.umd.cs.findbugs.anttask.ComputeBugHistoryTask">
- <classpath refid="findbugs.lib" />
- </taskdef>
-
- <taskdef name="setBugDatabaseInfo" classname="edu.umd.cs.findbugs.anttask.SetBugDatabaseInfoTask">
- <classpath refid="findbugs.lib" />
- </taskdef>
-
- <taskdef name="mineBugHistory" classname="edu.umd.cs.findbugs.anttask.MineBugHistoryTask">
- <classpath refid="findbugs.lib" />
- </taskdef>
-
- <!-- findbugs タスク定義 -->
- <target name="findbugs">
- <antcall target="analyze" />
- <antcall target="mine" />
- </target>
-
- <!-- 分析を行うタスク-->
- <target name="analyze">
- <!-- asm-util に対して findbugs を実行する -->
- <findbugs home="${findbugs.home}"
- output="xml:withMessages"
- timeout="90000000"
- reportLevel="experimental"
- workHard="true"
- effort="max"
- adjustExperimental="true"
- jvmargs="${jvmargs}"
- failOnError="true"
- outputFile="out.xml"
- projectName="Findbugs"
- debug="false">
- <class location="asm-util-3.0.jar" />
- </findbugs>
- </target>
-
- <target name="mine">
-
- <!-- 最新の分析結果に情報を設定する -->
- <setBugDatabaseInfo home="${findbugs.home}"
- withMessages="true"
- name="asm-util-3.0.jar"
- input="out.xml"
- output="out-rel.xml"/>
-
- <!-- 履歴ファイル (out-hist.xml) が既に存在するかどうかを確認する -->
- <condition property="mining.historyfile.available">
- <available file="out-hist.xml"/>
- </condition>
- <condition property="mining.historyfile.notavailable">
- <not>
- <available file="out-hist.xml"/>
- </not>
- </condition>
-
- <!-- このターゲットは、履歴ファイルが存在しないとき (初回) だけ実行されます -->
- <antcall target="history-init">
- <param name="data.file" value="out-rel.xml" />
- <param name="hist.file" value="out-hist.xml" />
- </antcall>
- <!-- 上記以外の場合に実行されます -->
- <antcall target="history">
- <param name="data.file" value="out-rel.xml" />
- <param name="hist.file" value="out-hist.xml" />
- <param name="hist.summary.file" value="out-hist.txt" />
- </antcall>
- </target>
-
- <!-- 履歴ファイルを初期化します -->
- <target name="history-init" if="mining.historyfile.notavailable">
- <copy file="${data.file}" tofile="${hist.file}" />
- </target>
-
- <!-- バグ履歴を算出します -->
- <target name="history" if="mining.historyfile.available">
- <!-- ${data.file} を ${hist.file} にマージします -->
- <computeBugHistory home="${findbugs.home}"
- withMessages="true"
- output="${hist.file}">
- <dataFile name="${hist.file}"/>
- <dataFile name="${data.file}"/>
- </computeBugHistory>
-
- <!-- 履歴を算出して ${hist.summary.file} に出力します -->
- <mineBugHistory home="${findbugs.home}"
- formatDates="true"
- noTabs="true"
- input="${hist.file}"
- output="${hist.summary.file}"/>
- </target>
-
-</project>
-
-</pre></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="rejarForAnalysis.html">前のページ</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="license.html">次のページ</a></td></tr><tr><td width="40%" align="left" valign="top">第11章 rejarForAnalysis の使用方法 </td><td width="20%" align="center"><a accesskey="h" href="index.html">ホーム</a></td><td width="40%" align="right" valign="top"> 第13章 ライセンス</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/eclipse.html b/tools/findbugs-1.3.9/doc/ja/manual/eclipse.html
deleted file mode 100644
index e93a155..0000000
--- a/tools/findbugs-1.3.9/doc/ja/manual/eclipse.html
+++ /dev/null
@@ -1,3 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>第7章 FindBugs™ Eclipse プラグインの使用方法</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ マニュアル"><link rel="up" href="index.html" title="FindBugs™ マニュアル"><link rel="prev" href="anttask.html" title="第6章 FindBugs™ Ant タスクの使用方法"><link rel="next" href="filter.html" title="第8章 フィルターファイル"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">第7章 <span class="application">FindBugs</span>™ Eclipse プラグインの使用方法</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="anttask.html">前のページ</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="filter.html">次のページ</a></td></tr></table><hr></div><div class="chapter" lang="ja"><div class="titlepage"><div><div><h2 class="title"><a name="eclipse"></a>第7章 <span class="application">FindBugs</span>™ Eclipse プラグインの使用方法</h2></div></div></div><div class="toc"><p><b>目次</b></p><dl><dt><span class="sect1"><a href="eclipse.html#d0e1604">1. 必要条件</a></span></dt><dt><span class="sect1"><a href="eclipse.html#d0e1611">2. インストール</a></span></dt><dt><span class="sect1"><a href="eclipse.html#d0e1658">3. プラグインの使用方法</a></span></dt><dt><span class="sect1"><a href="eclipse.html#d0e1681">4. トラブルシューティング</a></span></dt></dl></div><p>FindBugs Eclipse プラグインを使用することによって、 <span class="application">FindBugs</span> を <a href="http://www.eclipse.org/" target="_top">Eclipse</a> IDE で使用することができるようになります。このFindBugs Eclipse プラグインは、 Peter Friese 氏の多大な貢献によるものです。Phil Crosby 氏 と Andrei Loskutov 氏は、プラグインの重要な改良に貢献しました。</p><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1604"></a>1. 必要条件</h2></div></div></div><p><span class="application">FindBugs</span> Eclipse Plugin を使用するためには、 Eclipse 3.3 あるいはそれ以降のバージョン、また、 JRE/JDK 1.5 あるいはそれ以降のバージョンが必要です。</p></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1611"></a>2. インストール</h2></div></div></div><p>更新サイトが提供されています。更新サイトを利用して、機械的に FindBugs を Eclipse にインストールできます。また自動的に、最新版のアップデートを照会してインストールすることもできます。内容の異なる 3 つの更新サイトが存在します。</p><div class="variablelist"><p class="title"><b>FindBugs Eclipse 更新サイト一覧</b></p><dl><dt><span class="term"><a href="http://findbugs.cs.umd.edu/eclipse/" target="_top">http://findbugs.cs.umd.edu/eclipse/</a></span></dt><dd><p>FindBugs の公式リリース物を提供します。</p></dd><dt><span class="term"><a href="http://findbugs.cs.umd.edu/eclipse-candidate/" target="_top">http://findbugs.cs.umd.edu/eclips-candidate/</a></span></dt><dd><p>FindBugsの公式リリース物に加えて、公式リリース候補版を提供します。</p></dd><dt><span class="term"><a href="http://findbugs.cs.umd.edu/eclipse-daily/" target="_top">http://findbugs.cs.umd.edu/eclipse-daily/</a></span></dt><dd><p>FindBugsの日次ビルド物を提供します。コンパイルができること以上のテストは行われていません。</p></dd></dl></div><p>また、次に示すリンクから手動でプラグインをダウンロードすることもできます : <a href="http://prdownloads.sourceforge.net/findbugs/edu.umd.cs.findbugs.plugin.eclipse_1.3.9.20090821.zip?download" target="_top">http://prdownloads.sourceforge.net/findbugs/edu.umd.cs.findbugs.plugin.eclipse_1.3.9.20090821.zip?download</a>. 展開して Eclipse の「plugins」サブディレクトリーに入れてください。(そうすると、 <eclipse インストールディレクトリー >/plugins/edu.umd.cs.findbugs.plugin.eclipse_1.3.9.20090821/findbugs.png が <span class="application">FindBugs</span> のロゴファイルへのパスになるはずです。)</p><p>プラグインの展開ができたら、 Eclipse を起動して <span class="guimenu">Help</span> → <span class="guimenuitem">About Eclipse Platform</span> → <span class="guimenuitem">Plug-in Details</span> を選択してください。「FindBugs Project」から提供された「FindBugs Plug-in」というプラグインがあることを確認してください。</p></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1658"></a>3. プラグインの使用方法</h2></div></div></div><p>実行するには、 Java プロジェクト上で右クリックして「Find Bugs」を選択します。<span class="application">FindBugs</span> が実行されて、バグパターンの実例の可能性があると識別されたコード箇所に問題マーカーがつきます。 (ソース画面および Eclipse 問題ビューに表示されます。)</p><p>Java プロジェクトのプロパティーダイアログを開いて「Findbugs」プロパティーページを選択することで、 <span class="application">FindBugs</span> の動作をカスタマイズすることができます。選択できる項目には次のようなものがあります :</p><div class="itemizedlist"><ul type="disc"><li><p>「Run FindBugs Automatically」チェックボックスの設定。チェックすると、プロジェクト内の Java クラスが修正されるたびに FindBugs が実行されます。</p></li><li><p>優先度とバグカテゴリーの選択。これらのオプションは、どの警告を表示するかを選択します。例えば、優先度で 「Medium」 を選択すると、優先度 (中) および優先度 (高) の警告のみが表示されます。同様に、「Style」チェックボックスのチェックマークを外すと、Style カテゴリーに属する警告は表示されません。</p></li><li><p>ディテクタの選択。表からプロジェクトで有効にしたいディテクタを選択することができます。</p></li></ul></div></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1681"></a>4. トラブルシューティング</h2></div></div></div><p><span class="application">FindBugs</span> Eclipse プラグインは、まだ実験段階です。このセクションでは、プラグインに関する一般的な問題と (判明していれば) それらの問題の解決方法を記述します。</p><div class="itemizedlist"><ul type="disc"><li><p><span class="application">FindBugs</span> 問題マーカーが (ソース画面および問題ビューに) 表示されない場合は、問題ビューのフィルター設定を変更してください。詳細情報は <a href="http://findbugs.sourceforge.net/FAQ.html#q7" target="_top">http://findbugs.sourceforge.net/FAQ.html#q7</a> を参照してください。</p></li></ul></div></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="anttask.html">前のページ</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="filter.html">次のページ</a></td></tr><tr><td width="40%" align="left" valign="top">第6章 <span class="application">FindBugs</span>™ <span class="application">Ant</span> タスクの使用方法 </td><td width="20%" align="center"><a accesskey="h" href="index.html">ホーム</a></td><td width="40%" align="right" valign="top"> 第8章 フィルターファイル</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/filter.html b/tools/findbugs-1.3.9/doc/ja/manual/filter.html
deleted file mode 100644
index 45c0224..0000000
--- a/tools/findbugs-1.3.9/doc/ja/manual/filter.html
+++ /dev/null
@@ -1,168 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>第8章 フィルターファイル</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ マニュアル"><link rel="up" href="index.html" title="FindBugs™ マニュアル"><link rel="prev" href="eclipse.html" title="第7章 FindBugs™ Eclipse プラグインの使用方法"><link rel="next" href="analysisprops.html" title="第9章 分析プロパティー"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">第8章 フィルターファイル</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="eclipse.html">前のページ</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="analysisprops.html">次のページ</a></td></tr></table><hr></div><div class="chapter" lang="ja"><div class="titlepage"><div><div><h2 class="title"><a name="filter"></a>第8章 フィルターファイル</h2></div></div></div><div class="toc"><p><b>目次</b></p><dl><dt><span class="sect1"><a href="filter.html#d0e1709">1. フィルターファイルの概要</a></span></dt><dt><span class="sect1"><a href="filter.html#d0e1759">2. マッチング条件の種類</a></span></dt><dt><span class="sect1"><a href="filter.html#d0e1958">3. Java 要素名マッチング</a></span></dt><dt><span class="sect1"><a href="filter.html#d0e1982">4. 留意事項</a></span></dt><dt><span class="sect1"><a href="filter.html#d0e2012">5. 例</a></span></dt><dt><span class="sect1"><a href="filter.html#d0e2065">6. 完全な例</a></span></dt></dl></div><p>フィルターファイルを使用することで、特定のクラスやメソッドをバグ報告に含めたりバグ報告から除外したりすることができます。この章では、フィルターファイルの使用方法を説明します。</p><div class="note" style="margin-left: 0.5in; margin-right: 0.5in;"><table border="0" summary="Note: 計画されている機能"><tr><td rowspan="2" align="center" valign="top" width="25"><img alt="[注意]" src="note.png"></td><th align="left">計画されている機能</th></tr><tr><td align="left" valign="top"><p>フィルターは現在、コマンドラインインタフェースでのみサポートされています。最終的には、フィルターのサポートは GUI にも追加される予定です。</p></td></tr></table></div><p>
-</p><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1709"></a>1. フィルターファイルの概要</h2></div></div></div><p>概念的に言えば、フィルターはバグ検索結果をある基準と照合します。フィルターを定義することで、 特別な取り扱いをするバグ検索結果を選択することができます。例えば、あるバグ検索結果をバグ報告に含めたり、バグ報告から除外したりすることができます。</p><p>フィルターファイルは、 <a href="http://www.w3.org/XML/" target="_top">XML</a> 文書です。最上位要素が　<code class="literal">FindBugsFilter</code> 要素 であり、その子要素として <code class="literal">Match</code> 要素を複数個定義します。それぞれの <code class="literal">Match</code> 要素は、生成されたバグ検索結果に適用される述部にあたります。通常、フィルターはバグ検索結果を除外するために使用します。次に、例を示します:</p><pre class="screen">
-<code class="prompt">$ </code><span><strong class="command">findbugs -textui -exclude <em class="replaceable"><code>myExcludeFilter.xml</code></em> <em class="replaceable"><code>myApp.jar</code></em></strong></span>
-</pre><p>また一方で、的をしぼった報告を得るためにバグ報告結果を選択するためにフィルターを使用することも考えられます :</p><pre class="screen">
-<code class="prompt">$ </code><span><strong class="command">findbugs -textui -include <em class="replaceable"><code>myIncludeFilter.xml</code></em> <em class="replaceable"><code>myApp.jar</code></em></strong></span>
-</pre><p>
-</p><p>
-<code class="literal">Match</code> 要素は子要素を持ちます。それらの子要素は論理積で述部になります。つまり、述部が真であるためには、すべての子要素が真である必要があります。</p></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1759"></a>2. マッチング条件の種類</h2></div></div></div><div class="variablelist"><dl><dt><span class="term"><code class="literal"><Bug></code></span></dt><dd><p>この要素は、バグパターンを指定して照合します。<code class="literal">pattern</code> 属性には、コンマ区切りでバグパターン類型のリストを指定します。どの警告がどのバグパターン類型にあたるかは、 <span><strong class="command">-xml</strong></span> オプションをつかって出力されたもの (<code class="literal">BugInstance</code> 要素の <code class="literal">type</code> 属性) を見るか、または、 <a href="../../bugDescriptions.html" target="_top">バグ解説ドキュメント</a>を参照してください。</p><p>もっと粒度の粗い照合を行いたいときは、 <code class="literal">code</code> 属性を使用してください。バグ略称のコンマ区切りのリストで指定できます。さらに粒度の粗い照合を行いたいときは、 <code class="literal">category</code> 属性を使用してください。次に示す、バグカテゴリー名のコンマ区切りのリストで指定できます : <code class="literal">CORRECTNESS</code>, <code class="literal">MT_CORRECTNESS</code>, <code class="literal">BAD_PRACTICICE</code>, <code class="literal">PERFORMANCE</code>, <code class="literal">STYLE</code>.</p><p>同じ <code class="literal"><Bug></code> 要素に上記の属性を複数指定した場合は、バグパターン名、バグ略称、バグカテゴリーのいずれか1つでも該当すれば、バグパターンは合致すると判定されます。</p><p>下位互換性を持たせたい場合は、 <code class="literal"><Bug></code> 要素の代わりに <code class="literal"><BugPattern></code> 要素および <code class="literal"><BugCode></code> 要素を使用してください。これらの要素はそれぞれ、 <code class="literal">name</code> 属性で値のリストを指定します。これらの要素は、将来サポートされなくなる可能性があります。</p></dd><dt><span class="term"><code class="literal"><Priority></code></span></dt><dd><p>この要素は、特定の優先度をもつ警告を照合します。<code class="literal">value</code> 属性には、整数値を指定します : 1 は優先度(高)、また、 2 は優先度(中) 、 3 は優先度(低) を示します。</p></dd><dt><span class="term"><code class="literal"><Package></code></span></dt><dd><p>この要素は、 <code class="literal">name</code> 属性で指定した特定のパッケージ内にあるクラスに関連した警告を照合します。入れ子のパッケージは含まれません (Java import 文に従っています) 。しかしながら、正規表現を使うと複数パッケージにマッチさせることは簡単にできます。</p></dd><dt><span class="term"><code class="literal"><Class></code></span></dt><dd><p>この要素は、特定のクラスに関連した警告を照合します。<code class="literal">name</code> 属性を使用して、照合するクラス名をクラス名そのものか、または、正規表現で指定します。</p><p>下位互換性を持たせたい場合は、この要素の代わりに <code class="literal">Match</code> 要素を使用してください。クラス名そのものの指定は <code class="literal">class</code> 属性を、クラス名を正規表現で指定する場合は <code class="literal">classregex</code> 属性をそれぞれ使用してください</p><p>もし <code class="literal">Match</code> 要素に <code class="literal">Class</code> 要素が無かったり、 <code class="literal">class</code> / <code class="literal">classregex</code> 属性が無かったりした場合は、すべてのクラスに適用されます。その場合、想定外に多くのバグ検索結果が一致してしまうことがあり得ます。その場合は、適当なメソッドやフィールドで絞り込んでください。</p></dd><dt><span class="term"><code class="literal"><Method></code></span></dt><dd><p>この要素は、メソッドを指定します。<code class="literal">name</code> 属性を使用して、照合するメソッド名をメソッド名そのものか、または、正規表現で指定します。<code class="literal">params</code> 属性には、コンマ区切りでメソッド引数の型のリストを指定します。<code class="literal">returns</code> 属性にはメソッドの戻り値の型を指定します。<code class="literal">params</code> および <code class="literal">returns</code> においては、クラス名は完全修飾名である必要があります。(例えば、単に "String" ではなく "java.lang.String" としてください。) <code class="literal">params</code> <code class="literal">returns</code> のどちらか一方を指定した場合は、もう一方の属性の指定も必須です。なぜならば、メソッドシグニチャーを構築のために必要だからです。<code class="literal">name</code> 属性、<code class="literal">params</code> 属性 および <code class="literal">returns</code> 属性または 3 つの 属性すべて、のどれかを条件とすることできることを意味しています。このように、名前とシグニチャーに基づく様々な種類の条件を規定できます。</p></dd><dt><span class="term"><code class="literal"><Field></code></span></dt><dd><p>この要素は、フィールドを指定します。<code class="literal">name</code> 属性を使用して、照合するフィールド名をフィールド名そのものか、または、正規表現で指定します。また、フィールドのシグニチャーに照らしたフィルタリングをすることができます。 <code class="literal">type</code> 属性を使用して、フィールドの型を完全修飾名で指定してください。名前とシグニチャーに基づく条件を規定するために、その2つの属性を両方とも指定することができます。</p></dd><dt><span class="term"><code class="literal"><Local></code></span></dt><dd><p>この要素は、ローカル変数を指定します。<code class="literal">name</code> 属性を使用して、照合するローカル変数名をローカル変数名そのものか、または、正規表現で指定します。ローカル変数とは、メソッド内で定義した変数です。</p></dd><dt><span class="term"><code class="literal"><Or></code></span></dt><dd><p>この要素は、論理和として <code class="literal">Match</code> 条項を結合します。すなわち、2つの <code class="literal">Method</code> 要素を <code class="literal">Or</code> 条項に入れることで、どちらか一方のメソッドでマッチさせることができます。</p></dd></dl></div></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1958"></a>3. Java 要素名マッチング</h2></div></div></div><p><code class="literal">Class</code> 、 <code class="literal">Method</code> または <code class="literal">Field</code> の <code class="literal">name</code> 属性が文字 ~ で始まっている場合は、属性値の残りの部分を Java の正規表現として解釈します。そうして、当該 Java 要素の名前に対しての照合が行われます。</p><p>パターンの照合は要素の名前全体に対して行われることに注意してください。そのため、部分一致照合を行いたい場合はパターン文字列の前後に .* を付加して使用する必要があります。</p><p>パターンの構文規則に関しては、 <a href="http://java.sun.com/j2se/1.5.0/ja/docs/ja/api/java/util/regex/Pattern.html" target="_top"><code class="literal">java.util.regex.Pattern</code></a> のドキュメントを参照してください。</p></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1982"></a>4. 留意事項</h2></div></div></div><p>
-<code class="literal">Match</code> 条項は、バグ検索結果に実際に含まれている情報にのみ一致します。すべてのバグ検索結果はクラスを持っています。したがって、一般的に言って、バグを除外するためにはクラスを用いて行うとうまくいくことが多いです。</p><p>バグ検索結果の中には、2個以上のクラスを保持しているものもあります。例えば、 DE (dropped exception : 例外の無視) バグは、 例外の無視が発生したメソッドを持っているクラスと、 無視された例外の型を表すクラスの両方を含んだ形で報告されます。<code class="literal">Match</code> 条項とは、 <span class="emphasis"><em>1番目</em></span> (主) のクラスのみが照合されます。したがって、例えば、クラス "com.foobar.A" 、 "com.foobar.B" 間での IC (initialization circularity : 初期化時の処理循環) バグ報告を抑止したい場合、以下に示すように 2つの <code class="literal">Match</code> 条項を使用します :</p><pre class="programlisting">
- <Match>
- <Class name="com.foobar.A" />
- <Bug code="IC" />
- </Match>
-
- <Match>
- <Class name="com.foobar.B" />
- <Bug code="IC" />
- </Match>
-</pre><p>明示的に両方のクラスで照合することによって、循環しているどちらのクラスがバグ検索結果の 1 番目になっているかに関係なく一致させることができます。(もちろんこの方法は、処理循環が "com.foobar.A" 、 "com.foobar.B" に加えて3番目のクラスも含んでいる場合は図らずも失敗してしまう恐れがあります。)</p><p>多くの種類のバグ報告は、自身が出現したメソッドを報告します。それらのバグ検索結果に対しては、 <code class="literal">Method</code> 条項を <code class="literal">Match</code> 要素に加えると期待通りの動作をするでしょう。</p></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e2012"></a>5. 例</h2></div></div></div><p>1. 特定のクラスに対するすべてのバグ報告に一致させます。</p><pre class="programlisting">
-
- <Match>
- <Class name="com.foobar.MyClass" />
- </Match>
-
-</pre><p>
-
-</p><p>2. バグ略称を指定して、特定のクラスに対する特定の検査項目に一致させます。</p><pre class="programlisting">
-
- <Match>
- <Class name="com.foobar.MyClass"/ >
- <Bug code="DE,UrF,SIC" />
- </Match>
-
-</pre><p>
-</p><p>3. バグ略称を指定して、すべてのクラスに対する特定の検査項目に一致させます。</p><pre class="programlisting">
-
- <Match>
- <Bug code="DE,UrF,SIC" />
- </Match>
-
-</pre><p>
-</p><p>4. バグカテゴリーを指定して、すべてのクラスに対する特定の検査項目に一致させます。</p><pre class="programlisting">
-
- <Match>
- <Bug category="PERFORMANCE" />
- </Match>
-
-</pre><p>
-</p><p>5. バグ略称を指定して、特定のクラスの指定されたメソッドに対する特定のバグ種別に一致させます。</p><pre class="programlisting">
-
- <Match>
- <Class name="com.foobar.MyClass" />
- <Or>
- <Method name="frob" params="int,java.lang.String" returns="void" />
- <Method name="blat" params="" returns="boolean" />
- </Or>
- <Bug code="DC" />
- </Match>
-
-</pre><p>
-</p><p>6. 特定のメソッドに対する特定のバグパターンに一致させます。</p><pre class="programlisting">
-
- <!-- open stream に関する誤検出があるメソッド。-->
- <Match>
- <Class name="com.foobar.MyClass" />
- <Method name="writeDataToFile" />
- <Bug pattern="OS_OPEN_STREAM" />
- </Match>
-
-</pre><p>
-</p><p>7. 特定のメソッドに対する特定の優先度を付与された特定のバグパターンに一致させます。</p><pre class="programlisting">
-
- <!-- dead local store (優先度 (中)) に関する誤検出があるメソッド。-->
- <Match>
- <Class name="com.foobar.MyClass" />
- <Method name="someMethod" />
- <Bug pattern="DLS_DEAD_LOCAL_STORE" />
- <Priority value="2" />
- </Match>
-
-</pre><p>
-</p><p>8. AspectJ コンパイラーによって引き起こされるマイナーバグに一致させます (AspectJ の開発者でもない限り、それらのバグに関心を持つことはないと考えます)。</p><pre class="programlisting">
-
- <Match>
- <Class name="~.*\$AjcClosure\d+" />
- <Bug pattern="DLS_DEAD_LOCAL_STORE" />
- <Method name="run" />
- </Match>
- <Match>
- <Bug pattern="UUF_UNUSED_FIELD" />
- <Field name="~ajc\$.*" />
- </Match>
-
-</pre><p>
-</p><p>9. 基盤コードの特定の部分に対するバグに一致させます</p><pre class="programlisting">
-
- <!-- すべてのパッケージにある Messages クラスに対する unused fields 警告に一致。 -->
- <Match>
- <Class name="~.*\.Messages" />
- <Bug code="UUF" />
- </Match>
- <!-- すべての internal パッケージ内の mutable statics 警告に一致。 -->
- <Match>
- <Package name="~.*\.internal" />
- <Bug code="MS" />
- </Match>
- <!-- ui パッケージ階層内の anonymoous inner classes 警告に一致。 -->
- <Match>
- <Package name="~com\.foobar\.fooproject\.ui.*" />
- <Bug pattern="SIC_INNER_SHOULD_BE_STATIC_ANON" />
- </Match>
-
-</pre><p>
-</p><p>10. 特定のシグニチャーを持つフィールドまたはメソッドのバグに一致させます。</p><pre class="programlisting">
-
- <!-- すべてのクラスの main(String[]) メソッドに対する System.exit(...) usage 警告に一致。 -->
- <Match>
- <Method returns="void" name="main" params="java.lang.String[]" />
- <Method pattern="DM_EXIT" />
- </Match>
- <!-- すべてのクラスの com.foobar.DebugInfo 型のフィールドに対する UuF 警告に一致。 -->
- <Match>
- <Field type="com.foobar.DebugInfo" />
- <Bug code="UuF" />
- </Match>
-
-</pre><p>
-
-</p></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e2065"></a>6. 完全な例</h2></div></div></div><pre class="programlisting">
-
-<FindBugsFilter>
- <Match>
- <Class name="com.foobar.ClassNotToBeAnalyzed" />
- </Match>
-
- <Match>
- <Class name="com.foobar.ClassWithSomeBugsMatched" />
- <Bug code="DE,UrF,SIC" />
- </Match>
-
- <!-- XYZ 違反に一致。-->
- <Match>
- <Bug code="XYZ" />
- </Match>
-
- <!-- "AnotherClass" の特定のメソッドの doublecheck 違反に一致。-->
- <Match>
- <Class name="com.foobar.AnotherClass" />
- <Or>
- <Method name="nonOverloadedMethod" />
- <Method name="frob" params="int,java.lang.String" returns="void" />
- <Method name="blat" params="" returns="boolean" />
- </Or>
- <Bug code="DC" />
- </Match>
-
- <!-- dead local store (優先度 (中)) に関する誤検出があるメソッド。-->
- <Match>
- <Class name="com.foobar.MyClass" />
- <Method name="someMethod" />
- <Bug pattern="DLS_DEAD_LOCAL_STORE" />
- <Priority value="2" />
- </Match>
-</FindBugsFilter>
-
-</pre></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="eclipse.html">前のページ</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="analysisprops.html">次のページ</a></td></tr><tr><td width="40%" align="left" valign="top">第7章 <span class="application">FindBugs</span>™ Eclipse プラグインの使用方法 </td><td width="20%" align="center"><a accesskey="h" href="index.html">ホーム</a></td><td width="40%" align="right" valign="top"> 第9章 分析プロパティー</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/gui.html b/tools/findbugs-1.3.9/doc/ja/manual/gui.html
deleted file mode 100644
index f89daf4..0000000
--- a/tools/findbugs-1.3.9/doc/ja/manual/gui.html
+++ /dev/null
@@ -1,5 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>第5章 FindBugs GUI の使用方法</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ マニュアル"><link rel="up" href="index.html" title="FindBugs™ マニュアル"><link rel="prev" href="running.html" title="第4章 FindBugs™ の実行"><link rel="next" href="anttask.html" title="第6章 FindBugs™ Ant タスクの使用方法"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">第5章 <span class="application">FindBugs</span> GUI の使用方法</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="running.html">前のページ</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="anttask.html">次のページ</a></td></tr></table><hr></div><div class="chapter" lang="ja"><div class="titlepage"><div><div><h2 class="title"><a name="gui"></a>第5章 <span class="application">FindBugs</span> GUI の使用方法</h2></div></div></div><div class="toc"><p><b>目次</b></p><dl><dt><span class="sect1"><a href="gui.html#d0e1058">1. プロジェクトの作成</a></span></dt><dt><span class="sect1"><a href="gui.html#d0e1099">2. 分析の実行</a></span></dt><dt><span class="sect1"><a href="gui.html#d0e1104">3. 結果の閲覧</a></span></dt><dt><span class="sect1"><a href="gui.html#d0e1119">4. 保存と読み込み</a></span></dt></dl></div><p>この章では、<span class="application">FindBugs</span> グラフィカルユーザーインタフェース (GUI) の使用方法を説明します。</p><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1058"></a>1. プロジェクトの作成</h2></div></div></div><p><span><strong class="command">findbugs</strong></span> コマンドで <span class="application">FindBugs</span> を起動してから、メニューで <span class="guimenu">File</span> → <span class="guimenuitem">New Project</span> を選択してください。そうすると、次のようなダイアログが表示されます:</p><div class="mediaobject"><img src="project-dialog.png"></div><p>
-</p><p>「Class archives and directories to analyze」テキストフィールドの横にある 「Add」ボタンを押すと、バグを分析する java クラスを含んでいる Java アーカイブファイル (zip, jar, ear, or war file) を選択して指定できます。複数の アーカイブ/ディレクトリーを追加することが可能です。</p><p>また、分析を行う Java アーカイブのソースコードを含んだソースディレクトリーを指定することもできます。そうすると、バグの可能性があるソースコードの場所が、<span class="application">FindBugs</span> 上でハイライトして表示されます。ソースディレクトリーは、Java パッケージ階層のルートディレクトリーを指定する必要があります。例えば、ユーザのアプリケーションが <code class="varname">org.foobar.myapp</code> パッケージの中にある場合は、 <code class="filename">org</code> ディレクトリーの親ディレクトリーをソースディレクトリーリストに指定する必要があります。</p><p>もうひとつ、任意指定の手順があります。それは、補助用の Jar ファイルおよびディレクトリーを 「Auxiliary classpath locations」のエントリーに追加することです。分析するアーカイブ/ディレクトリーにも標準の実行時クラスパスにも含まれていないクラスを、分析するアーカイブ/ディレクトリーが参照している場合は、この項目を設定した方がいいでしょう。クラス階層に関する情報を使用するバグディテクタが、 <span class="application">FindBugs</span> にはいくつかあります。したがって、<span class="application">FindBugs</span> が分析を行うクラスの完全なクラス階層を参照できれば、より正確な分析結果を取得することができます。</p></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1099"></a>2. 分析の実行</h2></div></div></div><p>アーカイブ、ディレクトリーおよびソースディレクトリーの指定ができれば、「Finish」ボタンを押して Jar ファイルに含まれるクラスに対する分析を実行します。巨大なプロジェクトを古いコンピュータ上で実行すると、かなりの時間(数十分)がかかることに注意してください。大容量メモリである最近のコンピュータなら、大きなプログラムであっても数分程度で分析できます。</p></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1104"></a>3. 結果の閲覧</h2></div></div></div><p>分析が完了すると、次のような画面が表示されます :</p><div class="mediaobject"><img src="example-details.png"></div><p>
-</p><p>左上のペインにはバグ階層ツリーが表示されます。これは、分析でみつかったバグの検索結果が階層的に表示されたものです。</p><p>上部のペインでバグ検索結果を選択すると、下部の「Details」ペインにバグの詳細説明が表示されます。更に、ソースがみつかれば、右上のソースコードペインにバグの出現箇所に該当するソースコードが表示されます。上図の例で表示されているバグは、ストリームオブジェクトがクローズされていないというものです。ソースコード・ウィンドウにおいて当該ストリームオブジェクトを生成している行がハイライトされています。</p><p>バグの検索結果に対してテキストで注釈を入れることができます。階層ツリー図のすぐ下にあるテキストボックスに注釈を入力してください。記録しておきたい情報を何でも自由に入力することができます。バグ結果ファイルの保存および読み込みを行ったときに、注釈も保存されます。</p></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1119"></a>4. 保存と読み込み</h2></div></div></div><p>メニュー項目から <span class="guimenu">File</span> → <span class="guimenuitem">Save as...</span> を選択すると、ユーザーの作業結果を保存することができます。「Save as...」ダイアログにあるドロップダウン・リストの中から「FindBugs analysis results (.xml)」を選択ことで、ユーザーが指定した jar ファイルリストやバグ検索結果などの作業結果を保存することができます。また、jar ファイルリストのみを保存する選択肢 (「FindBugs project file (.fbp)」) やバグ検索結果のみを保存する選択肢 (「FindBugs analysis file (.fba)」) もあります。保存したファイルは、メニュー項目から <span class="guimenu">File</span> → <span class="guimenuitem">Open...</span> を選択することで、読み込むことができます。</p></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="running.html">前のページ</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="anttask.html">次のページ</a></td></tr><tr><td width="40%" align="left" valign="top">第4章 <span class="application">FindBugs</span>™ の実行 </td><td width="20%" align="center"><a accesskey="h" href="index.html">ホーム</a></td><td width="40%" align="right" valign="top"> 第6章 <span class="application">FindBugs</span>™ <span class="application">Ant</span> タスクの使用方法</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/index.html b/tools/findbugs-1.3.9/doc/ja/manual/index.html
deleted file mode 100644
index 93b7356..0000000
--- a/tools/findbugs-1.3.9/doc/ja/manual/index.html
+++ /dev/null
@@ -1,3 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>FindBugs™ マニュアル</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ マニュアル"><link rel="next" href="introduction.html" title="第1章 はじめに"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center"><span class="application">FindBugs</span>™ マニュアル</th></tr><tr><td width="20%" align="left"> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="introduction.html">次のページ</a></td></tr></table><hr></div><div class="book" lang="ja"><div class="titlepage"><div><div><h1 class="title"><a name="findbugs-manual"></a><span class="application">FindBugs</span>™ マニュアル</h1></div><div><div class="authorgroup"><div class="author"><h3 class="author"><span class="surname">Hovemeyer</span> <span class="firstname">David</span> [FAMILY Given]</h3></div><div class="author"><h3 class="author"><span class="surname">Pugh</span> <span class="firstname">William</span> [FAMILY Given]</h3></div></div></div><div><p class="copyright">製作著作 © 2003, 2004, 2005, 2006, 2008 University of Maryland</p></div><div><div class="legalnotice"><a name="d0e35"></a><p>このマニュアルは、クリエイティブ・コモンズ表示-非営利-継承に基づく使用許諾がなされています。使用許諾書をご覧になる場合は、 <a href="http://creativecommons.org/licenses/by-nc-sa/1.0/deed.ja" target="_top">http://creativecommons.org/licenses/by-nc-sa/1.0/</a> にアクセスするか、クリエイティブ・コモンズ(559 Nathan Abbott Way, Stanford, California 94305, USA)に書簡を送付してください。</p><p>名称「FindBugs」および FindBugs のロゴは、メリーランド大学の登録商標です。</p></div></div><div><p class="pubdate">16:39:49 EDT, 21 August, 2009</p></div></div><hr></div><div class="toc"><p><b>目次</b></p><dl><dt><span class="chapter"><a href="introduction.html">1. はじめに</a></span></dt><dd><dl><dt><span class="sect1"><a href="introduction.html#d0e74">1. 必要条件</a></span></dt></dl></dd><dt><span class="chapter"><a href="installing.html">2. <span class="application">FindBugs</span>™ のインストール</a></span></dt><dd><dl><dt><span class="sect1"><a href="installing.html#d0e102">1. 配布物の展開</a></span></dt></dl></dd><dt><span class="chapter"><a href="building.html">3. <span class="application">FindBugs</span>™ のソールからのビルド</a></span></dt><dd><dl><dt><span class="sect1"><a href="building.html#d0e175">1. 前提条件</a></span></dt><dt><span class="sect1"><a href="building.html#d0e258">2. ソース配布物の展開</a></span></dt><dt><span class="sect1"><a href="building.html#d0e271">3. <code class="filename">local.properties</code> の修正</a></span></dt><dt><span class="sect1"><a href="building.html#d0e326">4. <span class="application">Ant</span> の実行</a></span></dt><dt><span class="sect1"><a href="building.html#d0e420">5. ソースディレクトリーからの <span class="application">FindBugs</span>™ の実行</a></span></dt></dl></dd><dt><span class="chapter"><a href="running.html">4. <span class="application">FindBugs</span>™ の実行</a></span></dt><dd><dl><dt><span class="sect1"><a href="running.html#d0e455">1. クイック・スタート</a></span></dt><dt><span class="sect1"><a href="running.html#d0e493">2. <span class="application">FindBugs</span> の起動</a></span></dt><dt><span class="sect1"><a href="running.html#commandLineOptions">3. コマンドラインオプション</a></span></dt></dl></dd><dt><span class="chapter"><a href="gui.html">5. <span class="application">FindBugs</span> GUI の使用方法</a></span></dt><dd><dl><dt><span class="sect1"><a href="gui.html#d0e1058">1. プロジェクトの作成</a></span></dt><dt><span class="sect1"><a href="gui.html#d0e1099">2. 分析の実行</a></span></dt><dt><span class="sect1"><a href="gui.html#d0e1104">3. 結果の閲覧</a></span></dt><dt><span class="sect1"><a href="gui.html#d0e1119">4. 保存と読み込み</a></span></dt></dl></dd><dt><span class="chapter"><a href="anttask.html">6. <span class="application">FindBugs</span>™ <span class="application">Ant</span> タスクの使用方法</a></span></dt><dd><dl><dt><span class="sect1"><a href="anttask.html#d0e1173">1. <span class="application">Ant</span> タスクのインストール</a></span></dt><dt><span class="sect1"><a href="anttask.html#d0e1209">2. build.xml の書き方</a></span></dt><dt><span class="sect1"><a href="anttask.html#d0e1278">3. タスクの実行</a></span></dt><dt><span class="sect1"><a href="anttask.html#d0e1303">4. パラメーター</a></span></dt></dl></dd><dt><span class="chapter"><a href="eclipse.html">7. <span class="application">FindBugs</span>™ Eclipse プラグインの使用方法</a></span></dt><dd><dl><dt><span class="sect1"><a href="eclipse.html#d0e1604">1. 必要条件</a></span></dt><dt><span class="sect1"><a href="eclipse.html#d0e1611">2. インストール</a></span></dt><dt><span class="sect1"><a href="eclipse.html#d0e1658">3. プラグインの使用方法</a></span></dt><dt><span class="sect1"><a href="eclipse.html#d0e1681">4. トラブルシューティング</a></span></dt></dl></dd><dt><span class="chapter"><a href="filter.html">8. フィルターファイル</a></span></dt><dd><dl><dt><span class="sect1"><a href="filter.html#d0e1709">1. フィルターファイルの概要</a></span></dt><dt><span class="sect1"><a href="filter.html#d0e1759">2. マッチング条件の種類</a></span></dt><dt><span class="sect1"><a href="filter.html#d0e1958">3. Java 要素名マッチング</a></span></dt><dt><span class="sect1"><a href="filter.html#d0e1982">4. 留意事項</a></span></dt><dt><span class="sect1"><a href="filter.html#d0e2012">5. 例</a></span></dt><dt><span class="sect1"><a href="filter.html#d0e2065">6. 完全な例</a></span></dt></dl></dd><dt><span class="chapter"><a href="analysisprops.html">9. 分析プロパティー</a></span></dt><dt><span class="chapter"><a href="annotations.html">10. アノテーション</a></span></dt><dt><span class="chapter"><a href="rejarForAnalysis.html">11. rejarForAnalysis の使用方法</a></span></dt><dt><span class="chapter"><a href="datamining.html">12. <span class="application">FindBugs</span>™ によるデータ・マイニング</a></span></dt><dd><dl><dt><span class="sect1"><a href="datamining.html#commands">1. コマンド</a></span></dt><dt><span class="sect1"><a href="datamining.html#examples">2. 例</a></span></dt><dt><span class="sect1"><a href="datamining.html#antexample">3. Ant の例</a></span></dt></dl></dd><dt><span class="chapter"><a href="license.html">13. ライセンス</a></span></dt><dt><span class="chapter"><a href="acknowledgments.html">14. 謝辞</a></span></dt><dd><dl><dt><span class="sect1"><a href="acknowledgments.html#d0e3438">1. 貢献者</a></span></dt><dt><span class="sect1"><a href="acknowledgments.html#d0e3561">2. 使用しているソフトウェア</a></span></dt></dl></dd></dl></div><div class="list-of-tables"><p><b>表目次</b></p><dl><dt>9.1. <a href="analysisprops.html#analysisproptable">設定可能な分析プロパティー</a></dt><dt>12.1. <a href="datamining.html#computeBugHistoryTable">computeBugHistory コマンドのオプション一覧</a></dt><dt>12.2. <a href="datamining.html#filterOptionsTable">filterBugs コマンドのオプション一覧</a></dt><dt>12.3. <a href="datamining.html#mineBugHistoryOptionsTable">mineBugHistory コマンドのオプション一覧</a></dt><dt>12.4. <a href="datamining.html#mineBugHistoryColumns">mineBugHistory 出力のカラム一覧</a></dt><dt>12.5. <a href="datamining.html#defectDensityColumns">defectDensity 出力のカラム一覧</a></dt><dt>12.6. <a href="datamining.html#convertXmlToTextTable">convertXmlToText コマンドのオプション一覧</a></dt><dt>12.7. <a href="datamining.html#setBugDatabaseInfoOptions">setBugDatabaseInfo オプション一覧</a></dt><dt>12.8. <a href="datamining.html#listBugDatabaseInfoColumns">listBugDatabaseInfo カラム一覧</a></dt></dl></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="introduction.html">次のページ</a></td></tr><tr><td width="40%" align="left" valign="top"> </td><td width="20%" align="center"> </td><td width="40%" align="right" valign="top"> 第1章 はじめに</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/installing.html b/tools/findbugs-1.3.9/doc/ja/manual/installing.html
deleted file mode 100644
index 2fd84cb..0000000
--- a/tools/findbugs-1.3.9/doc/ja/manual/installing.html
+++ /dev/null
@@ -1,9 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>第2章 FindBugs™ のインストール</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ マニュアル"><link rel="up" href="index.html" title="FindBugs™ マニュアル"><link rel="prev" href="introduction.html" title="第1章 はじめに"><link rel="next" href="building.html" title="第3章 FindBugs™ のソールからのビルド"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">第2章 <span class="application">FindBugs</span>™ のインストール</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="introduction.html">前のページ</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="building.html">次のページ</a></td></tr></table><hr></div><div class="chapter" lang="ja"><div class="titlepage"><div><div><h2 class="title"><a name="installing"></a>第2章 <span class="application">FindBugs</span>™ のインストール</h2></div></div></div><div class="toc"><p><b>目次</b></p><dl><dt><span class="sect1"><a href="installing.html#d0e102">1. 配布物の展開</a></span></dt></dl></div><p>この章では、 <span class="application">FindBugs</span> のインストール方法を説明します。</p><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e102"></a>1. 配布物の展開</h2></div></div></div><p><span class="application">FindBugs</span> をインストールする最も簡単な方法は、バイナリ配布物をダウンロードすることです。 バイナリ配布物は、 <a href="http://prdownloads.sourceforge.net/findbugs/findbugs-1.3.9.tar.gz?download" target="_top">gzipped tar 形式</a> および <a href="http://prdownloads.sourceforge.net/findbugs/findbugs-1.3.9.zip?download" target="_top">zip 形式</a> がそれぞれ入手可能です。バイナリ配布物をダウンロードしてきたら、それを任意のディレクトリーに展開します。</p><p>gzipped tar 形式配布物の展開方法例:</p><pre class="screen">
-<code class="prompt">$ </code><span><strong class="command">gunzip -c findbugs-1.3.9.tar.gz | tar xvf -</strong></span>
-</pre><p>
-</p><p>zip 形式配布物の展開方法例:</p><pre class="screen">
-<code class="prompt">C:\Software></code><span><strong class="command">unzip findbugs-1.3.9.zip</strong></span>
-</pre><p>
-</p><p>バイナリ配布物の展開すると、通常は <code class="filename">findbugs-1.3.9</code> ディレクトリーが作成されます。例えば、ディレクトリー <code class="filename">C:\Software</code> でバイナリ配布物を展開すると、ディレクトリー <code class="filename">C:\Software\findbugs-1.3.9</code> に <span class="application">FindBugs</span> は展開されます。このディレクトリーが <span class="application">FindBugs</span> のホームディレクトリーになります。このマニュアルでは、このホームディレクトリーを <em class="replaceable"><code>$FINDBUGS_HOME</code></em> (Windowsでは <em class="replaceable"><code>%FINDBUGS_HOME%</code></em>) を用いて参照します。</p></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="introduction.html">前のページ</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="building.html">次のページ</a></td></tr><tr><td width="40%" align="left" valign="top">第1章 はじめに </td><td width="20%" align="center"><a accesskey="h" href="index.html">ホーム</a></td><td width="40%" align="right" valign="top"> 第3章 <span class="application">FindBugs</span>™ のソールからのビルド</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/introduction.html b/tools/findbugs-1.3.9/doc/ja/manual/introduction.html
deleted file mode 100644
index e1f32dc..0000000
--- a/tools/findbugs-1.3.9/doc/ja/manual/introduction.html
+++ /dev/null
@@ -1,3 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>第1章 はじめに</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ マニュアル"><link rel="up" href="index.html" title="FindBugs™ マニュアル"><link rel="prev" href="index.html" title="FindBugs™ マニュアル"><link rel="next" href="installing.html" title="第2章 FindBugs™ のインストール"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">第1章 はじめに</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="index.html">前のページ</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="installing.html">次のページ</a></td></tr></table><hr></div><div class="chapter" lang="ja"><div class="titlepage"><div><div><h2 class="title"><a name="introduction"></a>第1章 はじめに</h2></div></div></div><div class="toc"><p><b>目次</b></p><dl><dt><span class="sect1"><a href="introduction.html#d0e74">1. 必要条件</a></span></dt></dl></div><p><span class="application">FindBugs</span>™ は、Java プログラムの中のバグを見つけるプログラムです。このプログラムは、「バグ パターン」の実例を探します。「バグ パターン」とは、エラーとなる可能性の高いコードの事例です。</p><p>この文書は、<span class="application">FindBugs</span> バージョン 1.3.9 について説明してます。私たちは、 <span class="application">FindBugs</span> に対するフィードバックを心待ちにしています。どうぞ、 <a href="http://findbugs.sourceforge.net" target="_top"><span class="application">FindBugs</span> Web ページ</a> にアクセスしてください。<span class="application">FindBugs</span> についての最新情報、連絡先および <span class="application">FindBugs</span> メーリングリストなどのサポート情報を入手することができます。</p><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e74"></a>1. 必要条件</h2></div></div></div><p><span class="application">FindBugs</span> を使用するには、 <a href="http://java.sun.com/j2se" target="_top">Java 2 Standard Edition</a>, バージョン 1.5 以降のバージョンと互換性のあるランタイム環境が必要です。<span class="application">FindBugs</span> は、プラットフォーム非依存であり、 GNU/Linux 、 Windows 、 MacOS X プラットフォーム上で動作することが知られています。</p><p><span class="application">FindBugs</span> を使用するためには、少なくとも 512 MB のメモリが必要です。巨大なプロジェクトを解析するためには、それより多くのメモリが必要とされることがあります。</p></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="index.html">前のページ</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="installing.html">次のページ</a></td></tr><tr><td width="40%" align="left" valign="top"><span class="application">FindBugs</span>™ マニュアル </td><td width="20%" align="center"><a accesskey="h" href="index.html">ホーム</a></td><td width="40%" align="right" valign="top"> 第2章 <span class="application">FindBugs</span>™ のインストール</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/license.html b/tools/findbugs-1.3.9/doc/ja/manual/license.html
deleted file mode 100644
index b81c479..0000000
--- a/tools/findbugs-1.3.9/doc/ja/manual/license.html
+++ /dev/null
@@ -1,3 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>第13章 ライセンス</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ マニュアル"><link rel="up" href="index.html" title="FindBugs™ マニュアル"><link rel="prev" href="datamining.html" title="第12章 FindBugs™ によるデータ・マイニング"><link rel="next" href="acknowledgments.html" title="第14章 謝辞"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">第13章 ライセンス</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="datamining.html">前のページ</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="acknowledgments.html">次のページ</a></td></tr></table><hr></div><div class="chapter" lang="ja"><div class="titlepage"><div><div><h2 class="title"><a name="license"></a>第13章 ライセンス</h2></div></div></div><p>名称「FindBugs」および FindBugs のロゴは、メリーランド大学の登録商標です。FindBugs はフリーソフトウェアであり、 <a href="http://www.gnu.org/licenses/lgpl.html" target="_top">Lesser GNU Public License</a> の条件で配布されています。使用承諾書を入手したい場合は、 <span class="application">FindBugs</span> 配布物に含まれる <code class="filename">LICENSE.txt</code> ファイルを参照してください。</p><p>最新バージョンの FindBugs および そのソースコードは <a href="http://findbugs.sourceforge.net" target="_top">FindBugs web ページ</a> で入手できます。</p></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="datamining.html">前のページ</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="acknowledgments.html">次のページ</a></td></tr><tr><td width="40%" align="left" valign="top">第12章 <span class="application">FindBugs</span>™ によるデータ・マイニング </td><td width="20%" align="center"><a accesskey="h" href="index.html">ホーム</a></td><td width="40%" align="right" valign="top"> 第14章 謝辞</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/rejarForAnalysis.html b/tools/findbugs-1.3.9/doc/ja/manual/rejarForAnalysis.html
deleted file mode 100644
index f00f7f7..0000000
--- a/tools/findbugs-1.3.9/doc/ja/manual/rejarForAnalysis.html
+++ /dev/null
@@ -1,3 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>第11章 rejarForAnalysis の使用方法</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ マニュアル"><link rel="up" href="index.html" title="FindBugs™ マニュアル"><link rel="prev" href="annotations.html" title="第10章 アノテーション"><link rel="next" href="datamining.html" title="第12章 FindBugs™ によるデータ・マイニング"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">第11章 rejarForAnalysis の使用方法</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="annotations.html">前のページ</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="datamining.html">次のページ</a></td></tr></table><hr></div><div class="chapter" lang="ja"><div class="titlepage"><div><div><h2 class="title"><a name="rejarForAnalysis"></a>第11章 rejarForAnalysis の使用方法</h2></div></div></div><p>プロジェクトに多くの jar ファイル があったり、 jar ファイルが多くのディレクトリに点在したりする場合は、 <span><strong class="command">rejarForAnalysis </strong></span> スクリプトを使用すると FindBugs の実行が比較的簡単になります。このスクリプトは、数多い jar ファイルを集めて 1 つの大きな jar ファイルに結合します。そうすると、分析時にFindBugs に jar ファイルを設定することが比較的簡単になります。このスクリプトは、 unix システムの 'find' コマンドと組み合わせるととりわけ有用になります ; 次に例を示します。 <span><strong class="command">find . -name '*.jar' | xargs rejarForAnalysis </strong></span>.</p><p>また、 <span><strong class="command">rejarForAnalysis</strong></span> スクリプトは巨大なプロジェクトを複数の jar ファイルに分割することに使用できます。プロジェクトのクラスファイルは、複数の jar ファイルに均等に配分されます。これは、プロジェクト全体に対して FindBugs を実行すると時間とメモリ消費が著しい場合に有用です。プロジェクト全体に対して FindBugs を実行する代わりに、 <span><strong class="command"> rejarForAnalysis</strong></span> ですべてのクラスを含む大きな jar ファイルを構築します。続いて、 <span><strong class="command">rejarForAnalysis</strong></span> を再び実行して複数の jar ファイルに分割します。そして、各々の jar ファイルに対して順に FindBugs を実行します。その際、 <span><strong class="command">-auxclasspath</strong></span> に最初に 1 つにまとめた jar ファイルを指定してください。</p><p><span><strong class="command">rejarForAnalysis</strong></span> スクリプトに指定することができるオプションを以下に示します :</p><div class="variablelist"><dl><dt><span class="term"><span><strong class="command">-maxAge</strong></span> <em class="replaceable"><code>日数</code></em></span></dt><dd><p>最後に更新された日からの経過時間を日単位で指定します (指定した日数より古い jar ファイルは無視されます)。</p></dd><dt><span class="term"><span><strong class="command">-inputFileList</strong></span> <em class="replaceable"><code>ファイル名</code></em></span></dt><dd><p>jar ファイル名を記載したテキストファイルを指定します。</p></dd><dt><span class="term"><span><strong class="command">-maxClasses</strong></span> <em class="replaceable"><code>クラス数</code></em></span></dt><dd><p>analysis*.jar ファイル 1 ファイルに対するクラスの最大数を指定します。</p></dd><dt><span class="term"><span><strong class="command">-prefix</strong></span> <em class="replaceable"><code>プレフィックス</code></em></span></dt><dd><p>分析するクラス名のプレフィックスを指定します (例、 edu.umd.cs.) 。</p></dd></dl></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="annotations.html">前のページ</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="datamining.html">次のページ</a></td></tr><tr><td width="40%" align="left" valign="top">第10章 アノテーション </td><td width="20%" align="center"><a accesskey="h" href="index.html">ホーム</a></td><td width="40%" align="right" valign="top"> 第12章 <span class="application">FindBugs</span>™ によるデータ・マイニング</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/running.html b/tools/findbugs-1.3.9/doc/ja/manual/running.html
deleted file mode 100644
index 8ca16d0..0000000
--- a/tools/findbugs-1.3.9/doc/ja/manual/running.html
+++ /dev/null
@@ -1,22 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>第4章 FindBugs™ の実行</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ マニュアル"><link rel="up" href="index.html" title="FindBugs™ マニュアル"><link rel="prev" href="building.html" title="第3章 FindBugs™ のソールからのビルド"><link rel="next" href="gui.html" title="第5章 FindBugs GUI の使用方法"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">第4章 <span class="application">FindBugs</span>™ の実行</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="building.html">前のページ</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="gui.html">次のページ</a></td></tr></table><hr></div><div class="chapter" lang="ja"><div class="titlepage"><div><div><h2 class="title"><a name="running"></a>第4章 <span class="application">FindBugs</span>™ の実行</h2></div></div></div><div class="toc"><p><b>目次</b></p><dl><dt><span class="sect1"><a href="running.html#d0e455">1. クイック・スタート</a></span></dt><dt><span class="sect1"><a href="running.html#d0e493">2. <span class="application">FindBugs</span> の起動</a></span></dt><dt><span class="sect1"><a href="running.html#commandLineOptions">3. コマンドラインオプション</a></span></dt></dl></div><p><span class="application">FindBugs</span> には2つのユーザーインタフェースがあります。すなわち、グラフィカルユーザーインタフェース (GUI) および コマンドラインインタフェースです。この章では、それぞれのインタフェースの実行方法について説明します。</p><div class="warning" style="margin-left: 0.5in; margin-right: 0.5in;"><table border="0" summary="Warning"><tr><td rowspan="2" align="center" valign="top" width="25"><img alt="[警告]" src="warning.png"></td><th align="left">警告</th></tr><tr><td align="left" valign="top"><p>この章は、現在書き直し中です。書き直しはまだ完了していません。</p></td></tr></table></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e455"></a>1. クイック・スタート</h2></div></div></div><p>Windows システムで <span class="application">FindBugs</span> を起動する場合は、 <code class="filename"><em class="replaceable"><code>%FINDBUGS_HOME%</code></em>\lib\findbugs.jar</code> ファイルをダブルクリックしてください。 <span class="application">FindBugs</span> GUI が起動します。</p><p>Unix 、 Linux または Mac OS X システムの場合は、<code class="filename"><em class="replaceable"><code>$FINDBUGS_HOME</code></em>/bin/findbugs</code> スクリプトを実行するか、以下のコマンドを実行します。</p><pre class="screen">
-<span><strong class="command">java -jar <em class="replaceable"><code>$FINDBUGS_HOME</code></em>/lib/findbugs.jar</strong></span></pre><p>これで、 <span class="application">FindBugs</span> GUI が起動します。</p><p>GUI の使用方法については、 <a href="gui.html" title="第5章 FindBugs GUI の使用方法">章 5. <i><span class="application">FindBugs</span> GUI の使用方法</i></a> を参照してください。</p></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e493"></a>2. <span class="application">FindBugs</span> の起動</h2></div></div></div><p>このセクションでは、 <span class="application">FindBugs</span> の起動方法を説明します。<span class="application">FindBugs</span> を起動するには2つの方法があります。すなわち、直接起動する方法、および、ラップしているスクリプトを使用する方法です。</p><div class="sect2" lang="ja"><div class="titlepage"><div><div><h3 class="title"><a name="directInvocation"></a>2.1. <span class="application">FindBugs</span> の直接起動</h3></div></div></div><p>最初に述べる <span class="application">FindBugs</span> の起動方法は、 <code class="filename"><em class="replaceable"><code>$FINDBUGS_HOME</code></em>/lib/findbugs.jar</code> を直接実行する方法です。JVM (<span><strong class="command">java</strong></span>) 実行プログラムの <span><strong class="command">-jar</strong></span> コマンドラインスイッチを使用します。(<span class="application">FindBugs</span>のバージョンが 1.3.5 より前の場合は、ラップしているスクリプトを使用する必要があります。)</p><p><span class="application">FindBugs</span> を直接起動するための、一般的な構文は以下のようになります。</p><pre class="screen">
- <span><strong class="command">java <em class="replaceable"><code>[JVM 引数]</code></em> -jar <em class="replaceable"><code>$FINDBUGS_HOME</code></em>/lib/findbugs.jar <em class="replaceable"><code>オプション…</code></em></strong></span>
-</pre><p>
- </p><div class="sect3" lang="ja"><div class="titlepage"><div><div><h4 class="title"><a name="chooseUI"></a>2.1.1. ユーザーインタフェースの選択</h4></div></div></div><p>1 番目のコマンドラインオプションは、起動する <span class="application">FindBugs</span> ユーザーインタフェースを選択するためのものです。指定可能な値は次の通りです:</p><div class="itemizedlist"><ul type="disc"><li><p>
- <span><strong class="command">-gui</strong></span>: グラフィカルユーザーインタフェース (GUI) を起動します。</p></li><li><p>
- <span><strong class="command">-textui</strong></span>: コマンドラインインタフェースを起動します。</p></li><li><p>
- <span><strong class="command">-version</strong></span>: <span class="application">FindBugs</span> のバージョン番号を表示します。</p></li><li><p>
- <span><strong class="command">-help</strong></span>: <span class="application">FindBugs</span> コマンドラインインタフェースのヘルプ情報を表示します。</p></li><li><p>
- <span><strong class="command">-gui1</strong></span>: 最初に作成された <span class="application">FindBugs</span> グラフィカルユーザーインタフェース(すでに廃止されサポートされていない)を起動します。</p></li></ul></div></div><div class="sect3" lang="ja"><div class="titlepage"><div><div><h4 class="title"><a name="jvmArgs"></a>2.1.2. Java 仮想マシン (JVM) 引数</h4></div></div></div><p><span class="application">FindBugs</span> を起動する際に有用な Java 仮想マシン 引数をいくつか紹介します。</p><div class="variablelist"><dl><dt><span class="term"><span><strong class="command">-Xmx<em class="replaceable"><code>NN</code></em>m</strong></span></span></dt><dd><p>Java ヒープサイズの最大値を <em class="replaceable"><code>NN</code></em> メガバイトに設定します。<span class="application">FindBugs</span> は一般的に大容量のメモリサイズを必要とします。大きなプロジェクトでは、 1500 メガバイトを使用することも珍しくありません。</p></dd><dt><span class="term"><span><strong class="command">-D<em class="replaceable"><code>name</code></em>=<em class="replaceable"><code>value</code></em></strong></span></span></dt><dd><p>Java システムプロパティーを設定します。例えば、引数 <span><strong class="command">-Duser.language=ja</strong></span> を使用すると GUI 文言が日本語で表示されます。</p></dd></dl></div></div></div><div class="sect2" lang="ja"><div class="titlepage"><div><div><h3 class="title"><a name="wrapperScript"></a>2.2. ラップしているスクリプトを使用した <span class="application">FindBugs</span> の起動</h3></div></div></div><p><span class="application">FindBugs</span> を起動するもうひとつの方法は、ラップしているスクリプトを使用する方法です。</p><p>Unix 系のシステムにおいては、次のようなコマンドでラップしているスクリプトを起動します :</p><pre class="screen">
-<code class="prompt">$ </code><span><strong class="command"><em class="replaceable"><code>$FINDBUGS_HOME</code></em>/bin/findbugs <em class="replaceable"><code>オプション…</code></em></strong></span>
-</pre><p>
-</p><p>Windows システムにおいては、ラップしているスクリプトを起動するコマンドは次のようになります。</p><pre class="screen">
-<code class="prompt">C:\My Directory></code><span><strong class="command"><em class="replaceable"><code>%FINDBUGS_HOME%</code></em>\bin\findbugs.bat <em class="replaceable"><code>オプション…</code></em></strong></span>
-</pre><p>
-</p><p>Unix 系システム および Windows システムのどちらにおいても、ディレクトリー <code class="filename"><em class="replaceable"><code>$FINDBUGS_HOME</code></em>/bin</code> を環境変数 <code class="filename">PATH</code> に追加するだけで、 <span><strong class="command">findbugs</strong></span> コマンドを使用して FindBugs を起動することができます。</p><div class="sect3" lang="ja"><div class="titlepage"><div><div><h4 class="title"><a name="wrapperOptions"></a>2.2.1. ラップしているスクリプトのコマンドラインオプション</h4></div></div></div><p><span class="application">FindBugs</span> のラップしているスクリプトは、次のようなコマンドラインオプションをサポートしています。これらのコマンドラインオプションは <span class="application">FindBugs</span> プログラム 自体が操作するのでは<span class="emphasis"><em>なく</em></span>、どちらかといえば、ラップしているスクリプトの方が処理を行います。</p><div class="variablelist"><dl><dt><span class="term"><span><strong class="command">-jvmArgs <em class="replaceable"><code>引数</code></em></strong></span></span></dt><dd><p>JVM に受け渡される引数を指定します。例えば、次のような JVM プロパティが設定できます:</p><pre class="screen">
-<code class="prompt">$ </code><span><strong class="command">findbugs -textui -jvmArgs "-Duser.language=ja" <em class="replaceable"><code>myApp.jar</code></em></strong></span>
-</pre><p>
- </p></dd><dt><span class="term"><span><strong class="command">-javahome <em class="replaceable"><code>ディレクトリー</code></em></strong></span></span></dt><dd><p><span class="application">FindBugs</span> の実行に使用する JRE (Java ランタイム環境) がインストールされているディレクトリーを指定します。</p></dd><dt><span class="term"><span><strong class="command">-maxHeap <em class="replaceable"><code>サイズ</code></em></strong></span></span></dt><dd><p>Java ヒープサイズの最大値をメガバイト単位で指定します。デフォルトは、 256 です。巨大なプログラムやライブラリを分析するには、もっと大きなメモリー容量が必要になる可能性があります。</p></dd><dt><span class="term"><span><strong class="command">-debug</strong></span></span></dt><dd><p>ディテクタ実行およびクラス分析のトレース情報が標準出力に出力されます。分析が予期せず失敗した際の、トラブルシューティングに有用です。</p></dd><dt><span class="term"><span><strong class="command">-property</strong></span> <em class="replaceable"><code>name=value</code></em></span></dt><dd><p>このオプションを使用してシステムプロパティーを設定することができます。 <span class="application">FindBugs</span> はシステムプロパティーを使用して分析特性の設定を行います。<a href="analysisprops.html" title="第9章 分析プロパティー">章 9. <i>分析プロパティー</i></a> を参照してください。このオプションを複数指定して、複数のシステムプロパティを設定することが可能です。注: Windows の多くのバージョンでは、 <em class="replaceable"><code>name=value</code></em> 文字列を引用符で囲む必要があります。</p></dd></dl></div></div></div></div><div class="sect1" lang="ja"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="commandLineOptions"></a>3. コマンドラインオプション</h2></div></div></div><p>このセクションでは、 <span class="application">FindBugs</span> がサポートするコマンドラインオプションについて説明します。ここで示すコマンドラインオプションは、 <span class="application">FindBugs</span> 直接起動、または、ラップしているスクリプトによる起動で使用できます。</p><div class="sect2" lang="ja"><div class="titlepage"><div><div><h3 class="title"><a name="d0e778"></a>3.1. 共通のコマンドラインオプション</h3></div></div></div><p>ここで示すオプションは、 GUI および コマンドラインインタフェースの両方で使用できます。</p><div class="variablelist"><dl><dt><span class="term"><span><strong class="command">-effort:min</strong></span></span></dt><dd><p>このオプションを指定すると、精度を上げるために大量のメモリーを消費する分析が無効になります。<span class="application">FindBugs</span> の実行時にメモリー不足になったり、分析を完了するまでに異常に長い時間がかかる場合に試してみてください。</p></dd><dt><span class="term"><span><strong class="command">-effort:max</strong></span></span></dt><dd><p>精度が高く、より多くのバグを検出する分析を有効にします。ただし、多くのメモリー容量を必要とし、また、完了までの時間が多くかかる可能性があります。</p></dd><dt><span class="term"><span><strong class="command">-project</strong></span> <em class="replaceable"><code>project</code></em></span></dt><dd><p>分析するプロジェクトを指定します。指定するプロジェクトファイルには、 GUI を使って作成したものを使用してください。ファイルの拡張子は、一般的には <code class="filename">.fb</code> または <code class="filename">.fbp</code> です。</p></dd></dl></div></div><div class="sect2" lang="ja"><div class="titlepage"><div><div><h3 class="title"><a name="d0e818"></a>3.2. GUI オプション</h3></div></div></div><p>ここで示すオプションは、グラフィカルユーザーインタフェースでのみ使用できます。</p><div class="variablelist"><dl><dt><span class="term"><span><strong class="command">-look:</strong></span><em class="replaceable"><code>plastic|gtk|native</code></em></span></dt><dd><p>Swing のルック・アンド・フィールを設定します。</p></dd></dl></div><p>
-</p></div><div class="sect2" lang="ja"><div class="titlepage"><div><div><h3 class="title"><a name="d0e834"></a>3.3. テキストユーザーインタフェースオプション</h3></div></div></div><p>ここで示すオプションは、テキストユーザーインタフェースでのみ使用できます。</p><div class="variablelist"><dl><dt><span class="term"><span><strong class="command">-sortByClass</strong></span></span></dt><dd><p>報告されるバグ検索結果をクラス名でソートします。</p></dd><dt><span class="term"><span><strong class="command">-include</strong></span> <em class="replaceable"><code>filterFile.xml</code></em></span></dt><dd><p><em class="replaceable"><code>filterFile.xml</code></em> で指定したフィルターに一致したバグ検索結果のみ報告されます。<a href="filter.html" title="第8章 フィルターファイル">章 8. <i>フィルターファイル</i></a> を参照してください。</p></dd><dt><span class="term"><span><strong class="command">-exclude</strong></span> <em class="replaceable"><code>filterFile.xml</code></em></span></dt><dd><p><em class="replaceable"><code>filterFile.xml</code></em> で指定したフィルターに一致したバグ検索結果は報告されません。<a href="filter.html" title="第8章 フィルターファイル">章 8. <i>フィルターファイル</i></a> を参照してください。</p></dd><dt><span class="term"><span><strong class="command">-onlyAnalyze</strong></span> <em class="replaceable"><code>com.foobar.MyClass,com.foobar.mypkg.*</code></em></span></dt><dd><p>コンマ区切りで指定したクラスおよびパッケージのみに限定して、バグ検出の分析を行うようにします。フィルターと違って、このオプションを使うと一致しないクラスおよびパッケージに対する分析の実行を回避することができます。大きなプロジェクトにおいて、このオプションを活用すると分析にかかる時間を大きく削減することができる可能性があります。(しかしながら、アプリケーションの全体で実行していないために不正確な結果を出してしまうディテクタがある可能性もあります。) クラスはパッケージも含んだ完全な名前を指定する必要があります。また、パッケージは、 Java の <code class="literal">import</code> 文でパッケージ下のすべてのクラスをインポートするときと同じ方法で指定します。 (すなわち、パッケージの完全な名前に <code class="literal">.*</code> を付け加えた形です。)<code class="literal">.*</code> の代わりに <code class="literal">.-</code> を指定すると、サブパッケージも含めてすべてが分析されます。</p></dd><dt><span class="term"><span><strong class="command">-low</strong></span></span></dt><dd><p>すべてのバグが報告されます。</p></dd><dt><span class="term"><span><strong class="command">-medium</strong></span></span></dt><dd><p>優先度 (中) および優先度 (高) のバグが報告されます。これは、デフォルトの設定値です。</p></dd><dt><span class="term"><span><strong class="command">-high</strong></span></span></dt><dd><p>優先度 (高) のバグのみが報告されます。</p></dd><dt><span class="term"><span><strong class="command">-relaxed</strong></span></span></dt><dd><p>手抜き報告モードです。このオプションを指定すると、多くのディテクタにおいて 誤検出を回避するためのヒューリスティック機能が抑止されます。</p></dd><dt><span class="term"><span><strong class="command">-xml</strong></span></span></dt><dd><p>バグ報告が XML で作成されます。作成された XML データは 、後で GUI で見ることができます。このオプションは <span><strong class="command">-xml:withMessages</strong></span> と指定することもできます。こうすると 出力 XML には 各バグに関して人間に読むことができるメッセージが含まれるようになります。このオプションで作成された XML ファイルは 報告書に変換するのが簡単です。</p></dd><dt><span class="term"><span><strong class="command">-html</strong></span></span></dt><dd><p>HTML 出力が生成されます。デフォルトでは <span class="application">FindBugs</span> は <code class="filename">default.xsl</code> <a href="http://www.w3.org/TR/xslt" target="_top">XSLT</a> スタイルシートを使用して HTML 出力を生成します: このファイルは、 <code class="filename">findbugs.jar</code> の中、または、 <span class="application">FindBugs</span> のソース配布物もしくはバイナリ配布物の中にあります。このオプションには、次のようなバリエーションも存在します。すなわち、 <span><strong class="command">-html:plain.xsl</strong></span> 、 <span><strong class="command">-html:fancy.xsl</strong></span> および <span><strong class="command">-html:fancy-hist.xsl</strong></span> です。<code class="filename">plain.xsl</code> スタイルシートは Javascript や DOM を利用しません。したがって、古いWeb ブラウザ使用時や印刷時にも比較的うまく表示されるでしょう。<code class="filename">fancy.xsl</code> スタイルシートは DOM と Javascript を利用してナビゲーションを行います。また、ビジュアル表示に CSS を使用します。<span><strong class="command">fancy-hist.xsl</strong></span> は <span><strong class="command">fancy.xsl</strong></span> スタイルシートを更に進化させたものです。DOM や Javascript をふんだんに駆使して、バグの一覧を動的にフィルタリングします。</p><p>ユーザー自身の XSLT スタイルシートを用いて HTML への変換を行いたい場合は、 <span><strong class="command">-html:<em class="replaceable"><code>myStylesheet.xsl</code></em></strong></span> のように指定してください。ここで、 <em class="replaceable"><code>myStylesheet.xsl</code></em> はユーザーが使用したいスタイルシートのファイル名です。</p></dd><dt><span class="term"><span><strong class="command">-emacs</strong></span></span></dt><dd><p>バグ報告が Emacs 形式で作成されます。</p></dd><dt><span class="term"><span><strong class="command">-xdocs</strong></span></span></dt><dd><p>バグ報告が xdoc XML 形式で作成されます。Apache Mavenで使用できます。</p></dd><dt><span class="term"><span><strong class="command">-output</strong></span> <em class="replaceable"><code>ファイル名</code></em></span></dt><dd><p>指定したファイルに出力結果が作成されます。</p></dd><dt><span class="term"><span><strong class="command">-outputFile</strong></span> <em class="replaceable"><code>ファイル名</code></em></span></dt><dd><p>この引数は、使用すべきではありません。代わりに、 <span><strong class="command">-output</strong></span> を使用してください。</p></dd><dt><span class="term"><span><strong class="command">-nested</strong></span><em class="replaceable"><code>[:true|false]</code></em></span></dt><dd><p>このオプションは、ファイルやディレクトリーの中で入れ子になった jar および zip ファイルを分析するかどうかを指定します。デフォルトでは、入れ子になった jar および zip ファイルも分析します。入れ子になった jar および zip ファイルの分析するを無効にする場合は、 <span><strong class="command">-nested:false</strong></span> をコマンドライン引数に追加してください。</p></dd><dt><span class="term"><span><strong class="command">-auxclasspath</strong></span> <em class="replaceable"><code>クラスパス</code></em></span></dt><dd><p>分析時に使用する補助クラスパスを設定します。分析するプログラムで使用するjarファイルやクラスディレクトリーをすべて指定してください。補助クラスパスに指定したクラスは分析の対象にはなりません。</p></dd></dl></div></div></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="building.html">前のページ</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="gui.html">次のページ</a></td></tr><tr><td width="40%" align="left" valign="top">第3章 <span class="application">FindBugs</span>™ のソールからのビルド </td><td width="20%" align="center"><a accesskey="h" href="index.html">ホーム</a></td><td width="40%" align="right" valign="top"> 第5章 <span class="application">FindBugs</span> GUI の使用方法</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/manual/acknowledgments.html b/tools/findbugs-1.3.9/doc/manual/acknowledgments.html
deleted file mode 100644
index 7204b8b..0000000
--- a/tools/findbugs-1.3.9/doc/manual/acknowledgments.html
+++ /dev/null
@@ -1,124 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>Chapter 14. Acknowledgments</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ Manual"><link rel="up" href="index.html" title="FindBugs™ Manual"><link rel="prev" href="license.html" title="Chapter 13. License"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">Chapter 14. Acknowledgments</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="license.html">Prev</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> </td></tr></table><hr></div><div class="chapter" lang="en"><div class="titlepage"><div><div><h2 class="title"><a name="acknowledgments"></a>Chapter 14. Acknowledgments</h2></div></div></div><div class="toc"><p><b>Table of Contents</b></p><dl><dt><span class="sect1"><a href="acknowledgments.html#d0e3476">1. Contributors</a></span></dt><dt><span class="sect1"><a href="acknowledgments.html#d0e3599">2. Software Used</a></span></dt></dl></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e3476"></a>1. Contributors</h2></div></div></div><p><span class="application">FindBugs</span> was originally written by Bill Pugh (<code class="email"><<a href="mailto:pugh@cs.umd.edu">pugh@cs.umd.edu</a>></code>).
-David Hovemeyer (<code class="email"><<a href="mailto:daveho@cs.umd.edu">daveho@cs.umd.edu</a>></code>) implemented some of the
-detectors, added the Swing GUI, and is a co-maintainer.</p><p>Mike Fagan (<code class="email"><<a href="mailto:mfagan@tde.com">mfagan@tde.com</a>></code>) contributed the <span class="application">Ant</span> build script,
-the <span class="application">Ant</span> task, and several enhancements and bug fixes to the GUI.</p><p>Germano Leichsenring contributed Japanese translations of the bug
-summaries.</p><p>David Li contributed the Emacs bug report format.</p><p>Peter D. Stout contributed recursive detection of Class-Path
-attributes in analyzed Jar files, German translations of
-text used in the Swing GUI, and other fixes.</p><p>Peter Friese wrote the <span class="application">FindBugs</span> Eclipse plugin.</p><p>Rohan Lloyd contributed several Mac OS X enhancements,
-bug detector improvements,
-and maintains the Fink package for <span class="application">FindBugs</span>.</p><p>Hiroshi Okugawa translated the <span class="application">FindBugs</span> manual and
-more of the bug summaries into Japanese.</p><p>Phil Crosby enhanced the Eclipse plugin to add a view
-to display the bug details.</p><p>Dave Brosius fixed a number of bugs, added user preferences
-to the Swing GUI, improved several bug detectors, and
-contributed the string concatenation detector.</p><p>Thomas Klaeger contributed a number of bug fixes and
-bug detector improvements.</p><p>Andrei Loskutov made a number of improvements to the
-Eclipse plugin.</p><p>Brian Goetz contributed a major refactoring of the
-visitor classes to improve readability and understandability.</p><p> Pete Angstadt fixed several problems in the Swing GUI.</p><p>Francis Lalonde provided a task resource file for the
-FindBugs Ant task.</p><p>Garvin LeClaire contributed support for output in
-Xdocs format, for use by Maven.</p><p>Holger Stenzhorn contributed improved German translations of items
-in the Swing GUI.</p><p>Juha Knuutila contributed Finnish translations of items
-in the Swing GUI.</p><p>Tanel Lebedev contributed Estonian translations of items
-in the Swing GUI.</p><p>Hanai Shisei (ruimo) contributed full Japanese translations of
-bug messages, and text used in the Swing GUI.</p><p>David Cotton contributed Fresh translations for bug
-messages and for the Swing GUI.</p><p>Michael Tamm contributed support for the "errorProperty" attribute
-in the Ant task.</p><p>Thomas Kuehne improved the German translation of the Swing GUI.</p><p>Len Trigg improved source file support for the Emacs output mode.</p><p>Greg Bentz provided a fix for the hashcode/equals detector.</p><p>K. Hashimoto contributed internationalization fixes and several other
- bug fixes.</p><p>
- Glenn Boysko contributed support for ignoring specified local
- variables in the dead local store detector.
-</p><p>
- Jay Dunning contributed a detector to find equality comparisons
- of floating-point values, and overhauled the analysis summary
- report and its representation in the saved XML format.
-</p><p>
- Olivier Parent contributed updated French translations for bug descriptions and
- Swing GUI.
-</p><p>
- Chris Nappin contributed the <code class="filename">plain.xsl</code>
- stylesheet.
-</p><p>
- Etienne Giraudy contributed the <code class="filename">fancy.xsl</code> and <code class="filename">fancy-hist.xsl</code>
- stylesheets, and made improvements to the <span><strong class="command">-xml:withMessages</strong></span>
- option.
-</p><p>
- Takashi Okamoto fixed bugs in the project preferences dialog
- in the Eclipse plugin, and contributed to its internationalization and localization.
-</p><p>Thomas Einwaller fixed bugs in the project preferences dialog in the Eclipse plugin.</p><p>Jeff Knox contributed support for the warningsProperty attribute
-in the Ant task.</p><p>Peter Hendriks extended the Eclipse plugin preferences,
-and fixed a bug related to renaming the Eclipse plugin ID.</p><p>Mark McKay contributed an Ant task to launch the findbugs frame.</p><p>Dieter von Holten (dvholten) contributed
-some German improvements to findbugs_de.properties.</p><p>If you have contributed to <span class="application">FindBugs</span>, but aren't mentioned above,
-please send email to <code class="email"><<a href="mailto:findbugs@cs.umd.edu">findbugs@cs.umd.edu</a>></code> (and also accept
-our humble apologies).</p></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e3599"></a>2. Software Used</h2></div></div></div><p><span class="application">FindBugs</span> uses several open-source software packages, without which its
-development would have been much more difficult.</p><div class="sect2" lang="en"><div class="titlepage"><div><div><h3 class="title"><a name="d0e3606"></a>2.1. BCEL</h3></div></div></div><p><span class="application">FindBugs</span> includes software developed by the Apache Software Foundation
-(<a href="http://www.apache.org/" target="_top">http://www.apache.org/</a>).
-Specifically, it uses the <a href="http://jakarta.apache.org/bcel/" target="_top">Byte Code
-Engineering Library</a>.</p></div><div class="sect2" lang="en"><div class="titlepage"><div><div><h3 class="title"><a name="d0e3619"></a>2.2. ASM</h3></div></div></div><p><span class="application">FindBugs</span> uses the <a href="http://asm.objectweb.org/" target="_top">ASM</a>
-bytecode framework, which is distributed under the following license:</p><div class="blockquote"><blockquote class="blockquote"><p>
-Copyright (c) 2000-2005 INRIA, France Telecom
-All rights reserved.
-</p><p>
-Redistribution and use in source and binary forms, with or without
-modification, are permitted provided that the following conditions
-are met:
-</p><div class="orderedlist"><ol type="1"><li><p>
- Redistributions of source code must retain the above copyright
- notice, this list of conditions and the following disclaimer.
- </p></li><li><p>
- Redistributions in binary form must reproduce the above copyright
- notice, this list of conditions and the following disclaimer in the
- documentation and/or other materials provided with the distribution.
- </p></li><li><p>
- Neither the name of the copyright holders nor the names of its
- contributors may be used to endorse or promote products derived from
- this software without specific prior written permission.
- </p></li></ol></div><p>
-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
-AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
-IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
-ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
-LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
-CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
-SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
-INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
-CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
-ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
-THE POSSIBILITY OF SUCH DAMAGE.
-</p></blockquote></div></div><div class="sect2" lang="en"><div class="titlepage"><div><div><h3 class="title"><a name="d0e3646"></a>2.3. DOM4J</h3></div></div></div><p><span class="application">FindBugs</span> uses <a href="http://dom4j.org" target="_top">DOM4J</a>, which is
-distributed under the following license:</p><div class="blockquote"><blockquote class="blockquote"><p>
-Copyright 2001 (C) MetaStuff, Ltd. All Rights Reserved.
-</p><p>
-Redistribution and use of this software and associated documentation
-("Software"), with or without modification, are permitted provided that
-the following conditions are met:
-</p><div class="orderedlist"><ol type="1"><li><p>
- Redistributions of source code must retain copyright statements and
- notices. Redistributions must also contain a copy of this document.
- </p></li><li><p>
- Redistributions in binary form must reproduce the above copyright
- notice, this list of conditions and the following disclaimer in the
- documentation and/or other materials provided with the distribution.
- </p></li><li><p>
- The name "DOM4J" must not be used to endorse or promote products
- derived from this Software without prior written permission
- of MetaStuff, Ltd. For written permission, please contact
- <code class="email"><<a href="mailto:dom4j-info@metastuff.com">dom4j-info@metastuff.com</a>></code>.
- </p></li><li><p>
- Products derived from this Software may not be called "DOM4J" nor may
- "DOM4J" appear in their names without prior written permission of
- MetaStuff, Ltd. DOM4J is a registered trademark of MetaStuff, Ltd.
- </p></li><li><p>
- Due credit should be given to the DOM4J Project (<a href="http://dom4j.org/" target="_top">http://dom4j.org/</a>).
- </p></li></ol></div><p>
-THIS SOFTWARE IS PROVIDED BY METASTUFF, LTD. AND CONTRIBUTORS ``AS IS''
-AND ANY EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
-THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
-PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL METASTUFF, LTD. OR ITS
-CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
-EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
-PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
-PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
-LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
-NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
-SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-</p></blockquote></div></div></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="license.html">Prev</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> </td></tr><tr><td width="40%" align="left" valign="top">Chapter 13. License </td><td width="20%" align="center"><a accesskey="h" href="index.html">Home</a></td><td width="40%" align="right" valign="top"> </td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/manual/analysisprops.html b/tools/findbugs-1.3.9/doc/manual/analysisprops.html
deleted file mode 100644
index 61d1364..0000000
--- a/tools/findbugs-1.3.9/doc/manual/analysisprops.html
+++ /dev/null
@@ -1,45 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>Chapter 9. Analysis Properties</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ Manual"><link rel="up" href="index.html" title="FindBugs™ Manual"><link rel="prev" href="filter.html" title="Chapter 8. Filter Files"><link rel="next" href="annotations.html" title="Chapter 10. Annotations"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">Chapter 9. Analysis Properties</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="filter.html">Prev</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="annotations.html">Next</a></td></tr></table><hr></div><div class="chapter" lang="en"><div class="titlepage"><div><div><h2 class="title"><a name="analysisprops"></a>Chapter 9. Analysis Properties</h2></div></div></div><p>
-<span class="application">FindBugs</span> allows several aspects of the analyses it performs to be
-customized. System properties are used to configure these options.
-This chapter describes the configurable analysis options.
-</p><p>
-The analysis options have two main purposes. First, they allow you
-to inform <span class="application">FindBugs</span> about the meaning of methods in your application,
-so that it can produce more accurate results, or produce fewer
-false warnings. Second, they allow you to configure the precision
-of the analysis performed. Reducing analysis precision can save
-memory and analysis time, at the expense of missing some real bugs,
-or producing more false warnings.
-</p><p>
-The analysis options are set using the <span><strong class="command">-property</strong></span>
-command line option. For example:
-</p><pre class="screen">
-<code class="prompt">$ </code><span><strong class="command">findbugs -textui -property "cfg.noprune=true" <em class="replaceable"><code>myApp.jar</code></em></strong></span>
-</pre><p>
-</p><p>
-The list of configurable analysis properties is shown in
-<a href="analysisprops.html#analysisproptable" title="Table 9.1. Configurable Analysis Properties">Table 9.1, “Configurable Analysis Properties”</a>.
-</p><div class="table"><a name="analysisproptable"></a><p class="title"><b>Table 9.1. Configurable Analysis Properties</b></p><div class="table-contents"><table summary="Configurable Analysis Properties" border="1"><colgroup><col><col><col></colgroup><thead><tr><th align="left">Property Name</th><th align="left">Value</th><th align="left">Meaning</th></tr></thead><tbody><tr><td align="left">findbugs.assertionmethods</td><td align="left">Comma-separated list of fully qualified method names:
- e.g., "com.foo.MyClass.checkAssertion"</td><td align="left">This property specifies the names of methods that are used
- to check program assertions. Specifying these methods allows
- the null pointer dereference bug detector to avoid reporting
- false warnings for values which are checked by assertion
- methods.</td></tr><tr><td align="left">findbugs.de.comment</td><td align="left">true or false</td><td align="left">If true, the DroppedException detector scans source code
- for empty catch blocks for a comment, and if one is found, does
- not report a warning.</td></tr><tr><td align="left">findbugs.maskedfields.locals</td><td align="left">true or false</td><td align="left">If true, emit low priority warnings for local variables
- which obscure fields. Default is false.</td></tr><tr><td align="left">findbugs.nullderef.assumensp</td><td align="left">true or false</td><td align="left">not used
- (intention: If true, the null dereference detector assumes that any
- reference value returned from a method or passed to a method
- in a parameter might be null. Default is false. Note that
- enabling this property will very likely cause a large number
- of false warnings to be produced.)</td></tr><tr><td align="left">findbugs.refcomp.reportAll</td><td align="left">true or false</td><td align="left">If true, all suspicious reference comparisons
- using the == and != operators are reported. If false,
- only one such warning is issued per method. Default
- is false.</td></tr><tr><td align="left">findbugs.sf.comment</td><td align="left">true or false</td><td align="left">If true, the SwitchFallthrough detector will only report
- warnings for cases where the source code does not have a comment
- containing the words "fall" or "nobreak". (An accurate source
- path must be used for this feature to work correctly.)
- This helps find cases where the switch fallthrough is likely
- to be unintentional.</td></tr></tbody></table></div></div><br class="table-break"></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="filter.html">Prev</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="annotations.html">Next</a></td></tr><tr><td width="40%" align="left" valign="top">Chapter 8. Filter Files </td><td width="20%" align="center"><a accesskey="h" href="index.html">Home</a></td><td width="40%" align="right" valign="top"> Chapter 10. Annotations</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/manual/annotations.html b/tools/findbugs-1.3.9/doc/manual/annotations.html
deleted file mode 100644
index 31e9e68..0000000
--- a/tools/findbugs-1.3.9/doc/manual/annotations.html
+++ /dev/null
@@ -1,101 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>Chapter 10. Annotations</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ Manual"><link rel="up" href="index.html" title="FindBugs™ Manual"><link rel="prev" href="analysisprops.html" title="Chapter 9. Analysis Properties"><link rel="next" href="rejarForAnalysis.html" title="Chapter 11. Using rejarForAnalysis"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">Chapter 10. Annotations</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="analysisprops.html">Prev</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="rejarForAnalysis.html">Next</a></td></tr></table><hr></div><div class="chapter" lang="en"><div class="titlepage"><div><div><h2 class="title"><a name="annotations"></a>Chapter 10. Annotations</h2></div></div></div><p>
-<span class="application">FindBugs</span> supports several annotations to express the developer's intent
-so that FindBugs can issue warnings more appropriately. You need to use
-Java 5 to use annotations, and must place the annotations.jar and jsr305.jar
-files in the classpath while compiling your program.
-</p><div class="variablelist"><dl><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.CheckForNull</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Field, Method, Parameter
- <p>
-The annotated element might be null, and uses of the element should check for null.
-When this annotation is applied to a method it applies to the method return value.
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.CheckReturnValue</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Method, Constructor
- <div class="variablelist"><dl><dt><span class="term"><span><strong class="command">[Parameter]</strong></span></span></dt><dd><p>
- <span><strong class="command">priority:</strong></span>The priority of the warning (HIGH, MEDIUM, LOW, IGNORE). Default value:MEDIUM.
- </p><p>
- <span><strong class="command">explanation:</strong></span>A textual explaination of why the return value should be checked. Default value:"".
- </p></dd></dl></div><p>
-This annotation is used to denote a method whose return value should always be checked after invoking the method.
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.DefaultAnnotation</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Type, Package
- <div class="variablelist"><dl><dt><span class="term"><span><strong class="command">[Parameter]</strong></span></span></dt><dd><p>
- <span><strong class="command">value:</strong></span>Annotation class objects. More than one class can be specified.
- </p><p>
- <span><strong class="command">priority:</strong></span>Default priority(HIGH, MEDIUM, LOW, IGNORE). Default value:MEDIUM.
- </p></dd></dl></div><p>
-Indicates that all members of the class or package should be annotated with the default
-value of the supplied annotation classes. This would be used for behavior annotations
-such as @NonNull, @CheckForNull, or @CheckReturnValue. In particular, you can use
-@DefaultAnnotation(NonNull.class) on a class or package, and then use @Nullable only
-on those parameters, methods or fields that you want to allow to be null.
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.DefaultAnnotationForFields</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Type, Package
- <div class="variablelist"><dl><dt><span class="term"><span><strong class="command">[Parameter]</strong></span></span></dt><dd><p>
- <span><strong class="command">value:</strong></span>Annotation class objects. More than one class can be specified.
- </p><p>
- <span><strong class="command">priority:</strong></span>Default priority(HIGH, MEDIUM, LOW, IGNORE). Default value:MEDIUM.
- </p></dd></dl></div><p>
-This is same as the DefaultAnnotation except it only applys to fields.
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.DefaultAnnotationForMethods</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Type, Package
- <div class="variablelist"><dl><dt><span class="term"><span><strong class="command">[Parameter]</strong></span></span></dt><dd><p>
- <span><strong class="command">value:</strong></span>Annotation class objects. More than one class can be specified.
- </p><p>
- <span><strong class="command">priority:</strong></span>Default priority(HIGH, MEDIUM, LOW, IGNORE). Default value:MEDIUM.
- </p></dd></dl></div><p>
-This is same as the DefaultAnnotation except it only applys to methods.
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.DefaultAnnotationForParameters</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Type, Package
- <div class="variablelist"><dl><dt><span class="term"><span><strong class="command">[Parameter]</strong></span></span></dt><dd><p>
- <span><strong class="command">value:</strong></span>Annotation class objects. More than one class can be specified.
- </p><p>
- <span><strong class="command">priority:</strong></span>Default priority(HIGH, MEDIUM, LOW, IGNORE). Default value:MEDIUM.
- </p></dd></dl></div><p>
-This is same as the DefaultAnnotation except it only applys to method parameters.
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.NonNull</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Field, Method, Parameter
- <p>
-The annotated element must not be null.
-Annotated fields must not be null after construction has completed. Annotated methods must have non-null return values.
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.Nullable</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Field, Method, Parameter
- <p>
-The annotated element could be null under some circumstances. In general, this means
-developers will have to read the documentation to determine when a null value is
-acceptable and whether it is neccessary to check for a null value. FindBugs will
-treat the annotated items as though they had no annotation.
- </p><p>
-In pratice this annotation is useful only for overriding an overarching NonNull
-annotation.
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.OverrideMustInvoke</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Method
- <div class="variablelist"><dl><dt><span class="term"><span><strong class="command">[Parameter]</strong></span></span></dt><dd><p>
- <span><strong class="command">value:</strong></span>Specify when the super invocation should be
- performed (FIRST, ANYTIME, LAST). Default value:ANYTIME.
- </p></dd></dl></div><p>
-Used to annotate a method that, if overridden, must (or should) be invoke super
-in the overriding method. Examples of such methods include finalize() and clone().
-The argument to the method indicates when the super invocation should occur:
-at any time, at the beginning of the overriding method, or at the end of the overriding method.
-(This anotation is not implmemented in FindBugs as of September 8, 2006).
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.PossiblyNull</strong></span></span></dt><dd><p>
-This annotation is deprecated. Use CheckForNull instead.
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.SuppressWarnings</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Type, Field, Method, Parameter, Constructor, Package
- <div class="variablelist"><dl><dt><span class="term"><span><strong class="command">[Parameter]</strong></span></span></dt><dd><p>
- <span><strong class="command">value:</strong></span>The name of the warning. More than one name can be specified.
- </p><p>
- <span><strong class="command">justification:</strong></span>Reason why the warning should be ignored. Default value:"".
- </p></dd></dl></div><p>
-The set of warnings that are to be suppressed by the compiler in the annotated element.
-Duplicate names are permitted. The second and successive occurrences of a name are ignored.
-The presence of unrecognized warning names is <span class="emphasis"><em>not</em></span> an error: Compilers
-must ignore any warning names they do not recognize. They are, however, free to emit a
-warning if an annotation contains an unrecognized warning name. Compiler vendors should
-document the warning names they support in conjunction with this annotation type. They
-are encouraged to cooperate to ensure that the same names work across multiple compilers.
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.UnknownNullness</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Field, Method, Parameter
- <p>
-Used to indicate that the nullness of the target is unknown, or my vary in unknown ways in subclasses.
- </p></dd><dt><span class="term"><span><strong class="command">edu.umd.cs.findbugs.annotations.UnknownNullness</strong></span></span></dt><dd><span><strong class="command">[Target]</strong></span> Field, Method, Parameter
- <p>
-Used to indicate that the nullness of the target is unknown, or my vary in unknown ways in subclasses.
- </p></dd></dl></div><p>
- <span class="application">FindBugs</span> also supports the following annotations:
-</p><div class="itemizedlist"><ul type="disc"><li>net.jcip.annotations.GuardedBy</li><li>net.jcip.annotations.Immutable</li><li>net.jcip.annotations.NotThreadSafe</li><li>net.jcip.annotations.ThreadSafe</li></ul></div><p>
-</p><p>
-You can refer the JCIP annotation <a href="http://jcip.net/annotations/doc/index.html" target="_top">
-API documentation</a> at <a href="http://jcip.net/" target="_top">Java Concurrency in Practice</a>.
-</p></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="analysisprops.html">Prev</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="rejarForAnalysis.html">Next</a></td></tr><tr><td width="40%" align="left" valign="top">Chapter 9. Analysis Properties </td><td width="20%" align="center"><a accesskey="h" href="index.html">Home</a></td><td width="40%" align="right" valign="top"> Chapter 11. Using rejarForAnalysis</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/manual/anttask.html b/tools/findbugs-1.3.9/doc/manual/anttask.html
deleted file mode 100644
index c963e18..0000000
--- a/tools/findbugs-1.3.9/doc/manual/anttask.html
+++ /dev/null
@@ -1,203 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>Chapter 6. Using the FindBugs™ Ant task</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ Manual"><link rel="up" href="index.html" title="FindBugs™ Manual"><link rel="prev" href="gui.html" title="Chapter 5. Using the FindBugs GUI"><link rel="next" href="eclipse.html" title="Chapter 7. Using the FindBugs™ Eclipse plugin"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">Chapter 6. Using the <span class="application">FindBugs</span>™ <span class="application">Ant</span> task</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="gui.html">Prev</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="eclipse.html">Next</a></td></tr></table><hr></div><div class="chapter" lang="en"><div class="titlepage"><div><div><h2 class="title"><a name="anttask"></a>Chapter 6. Using the <span class="application">FindBugs</span>™ <span class="application">Ant</span> task</h2></div></div></div><div class="toc"><p><b>Table of Contents</b></p><dl><dt><span class="sect1"><a href="anttask.html#d0e1200">1. Installing the <span class="application">Ant</span> task</a></span></dt><dt><span class="sect1"><a href="anttask.html#d0e1238">2. Modifying build.xml</a></span></dt><dt><span class="sect1"><a href="anttask.html#d0e1309">3. Executing the task</a></span></dt><dt><span class="sect1"><a href="anttask.html#d0e1334">4. Parameters</a></span></dt></dl></div><p>
-This chapter describes how to integrate <span class="application">FindBugs</span> into a build script
-for <a href="http://ant.apache.org/" target="_top"><span class="application">Ant</span></a>, which is a popular Java build
-and deployment tool. Using the <span class="application">FindBugs</span> <span class="application">Ant</span> task, your build script can
-automatically run <span class="application">FindBugs</span> on your Java code.
-</p><p>
-The <span class="application">Ant</span> task was generously contributed by Mike Fagan.
-</p><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1200"></a>1. Installing the <span class="application">Ant</span> task</h2></div></div></div><p>
-To install the <span class="application">Ant</span> task, simply copy <code class="filename"><em class="replaceable"><code>$FINDBUGS_HOME</code></em>/lib/findbugs-ant.jar</code>
-into the <code class="filename">lib</code> subdirectory of your <span class="application">Ant</span> installation.
-
-</p><div class="note" style="margin-left: 0.5in; margin-right: 0.5in;"><table border="0" summary="Note"><tr><td rowspan="2" align="center" valign="top" width="25"><img alt="[Note]" src="note.png"></td><th align="left">Note</th></tr><tr><td align="left" valign="top"><p>It is strongly recommended that you use the <span class="application">Ant</span> task with the version
-of <span class="application">FindBugs</span> it was included with. We do not guarantee that the <span class="application">Ant</span> task Jar file
-will work with any version of <span class="application">FindBugs</span> other than the one it was included with.</p></td></tr></table></div><p>
-</p></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1238"></a>2. Modifying build.xml</h2></div></div></div><p>
-To incorporate <span class="application">FindBugs</span> into <code class="filename">build.xml</code> (the build script
-for <span class="application">Ant</span>), you first need to add a task definition. This should appear as follows:
-
-</p><pre class="screen">
- <taskdef name="findbugs" classname="edu.umd.cs.findbugs.anttask.FindBugsTask"/>
-</pre><p>
-
-The task definition specifies that when a <code class="literal">findbugs</code> element is
-seen in <code class="filename">build.xml</code>, it should use the indicated class to execute the task.
-</p><p>
-After you have added the task definition, you can define a target
-which uses the <code class="literal">findbugs</code> task. Here is an example
-which could be added to the <code class="filename">build.xml</code> for the
-Apache <a href="http://jakarta.apache.org/bcel/" target="_top">BCEL</a> library.
-
-</p><pre class="screen">
- <property name="findbugs.home" value="/export/home/daveho/work/findbugs" />
-
- <target name="findbugs" depends="jar">
- <findbugs home="${findbugs.home}"
- output="xml"
- outputFile="bcel-fb.xml" >
- <auxClasspath path="${basedir}/lib/Regex.jar" />
- <sourcePath path="${basedir}/src/java" />
- <class location="${basedir}/bin/bcel.jar" />
- </findbugs>
- </target>
-</pre><p>
-
-The <code class="literal">findbugs</code> element must have the <code class="literal">home</code>
-attribute set to the directory in which <span class="application">FindBugs</span> is installed; in other words,
-<em class="replaceable"><code>$FINDBUGS_HOME</code></em>. See <a href="installing.html" title="Chapter 2. Installing FindBugs™">Chapter 2, <i>Installing <span class="application">FindBugs</span>™</i></a>.
-</p><p>
-This target will execute <span class="application">FindBugs</span> on <code class="filename">bcel.jar</code>, which is the
-Jar file produced by BCEL's build script. (By making it depend on the "jar"
-target, we ensure that the library is fully compiled before running <span class="application">FindBugs</span> on it.)
-The output of <span class="application">FindBugs</span> will be saved in XML format to a file called
-<code class="filename">bcel-fb.xml</code>.
-An auxiliary Jar file, <code class="filename">Regex.jar</code>, is added to the aux classpath,
-because it is referenced by the main BCEL library. A source path is specified
-so that the saved bug data will have accurate references to the BCEL source code.
-</p></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1309"></a>3. Executing the task</h2></div></div></div><p>
-Here is an example of invoking <span class="application">Ant</span> from the command line, using the <code class="literal">findbugs</code>
-target defined above.
-
-</p><pre class="screen">
- <code class="prompt">[daveho@noir]$</code> <span><strong class="command">ant findbugs</strong></span>
- Buildfile: build.xml
-
- init:
-
- compile:
-
- examples:
-
- jar:
-
- findbugs:
- [findbugs] Running FindBugs...
- [findbugs] Bugs were found
- [findbugs] Output saved to bcel-fb.xml
-
- BUILD SUCCESSFUL
- Total time: 35 seconds
-</pre><p>
-
-In this case, because we saved the bug results in an XML file, we can
-use the <span class="application">FindBugs</span> GUI to view the results; see <a href="running.html" title="Chapter 4. Running FindBugs™">Chapter 4, <i>Running <span class="application">FindBugs</span>™</i></a>.
-</p></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1334"></a>4. Parameters</h2></div></div></div><p>This section describes the parameters that may be specified when
-using the <span class="application">FindBugs</span> task.
-
-</p><div class="variablelist"><dl><dt><span class="term"><code class="literal">class</code></span></dt><dd><p>
- A nested element specifying which classes to analyze. The <code class="literal">class</code>
- element must specify a <code class="literal">location</code> attribute which names the
- archive file (jar, zip, etc.), directory, or class file to be analyzed. Multiple <code class="literal">class</code>
- elements may be specified as children of a single <code class="literal">findbugs</code> element.
- </p></dd><dt><span class="term"><code class="literal">auxClasspath</code></span></dt><dd><p>
- An optional nested element which specifies a classpath (Jar files or directories)
- containing classes used by the analyzed library or application, but which
- you don't want to analyze. It is specified the same way as
- <span class="application">Ant</span>'s <code class="literal">classpath</code> element for the Java task.
- </p></dd><dt><span class="term"><code class="literal">sourcePath</code></span></dt><dd><p>
- An optional nested element which specifies a source directory path
- containing source files used to compile the Java code being analyzed.
- By specifying a source path, any generated XML bug output will have
- complete source information, which allows later viewing in the
- GUI.
- </p></dd><dt><span class="term"><code class="literal">home</code></span></dt><dd><p>
- A required attribute.
- It must be set to the name of the directory where <span class="application">FindBugs</span> is installed.
- </p></dd><dt><span class="term"><code class="literal">quietErrors</code></span></dt><dd><p>
- An optional boolean attribute.
- If true, reports of serious analysis errors and missing classes will
- be suppressed in the <span class="application">FindBugs</span> output. Default is false.
- </p></dd><dt><span class="term"><code class="literal">reportLevel</code></span></dt><dd><p>
- An optional attribute. It specifies
- the priority threshold for reporting bugs. If set to "low", all bugs are reported.
- If set to "medium" (the default), medium and high priority bugs are reported.
- If set to "high", only high priority bugs are reported.
- </p></dd><dt><span class="term"><code class="literal">output</code></span></dt><dd><p>
- Optional attribute.
- It specifies the output format. If set to "xml" (the default), output
- is in XML format.
- If set to "xml:withMessages", output is in XML format augmented with
- human-readable messages. (You should use this format if you plan
- to generate a report using an XSL stylesheet.)
- If set to "html", output is in HTML formatted (default stylesheet is default.xsl).
- If set to "text", output is in ad-hoc text format.
- If set to "emacs", output is in <a href="http://www.gnu.org/software/emacs/" target="_top">Emacs</a> error message format.
- If set to "xdocs", output is xdoc XML for use with Apache Maven.
- </p></dd><dt><span class="term"><code class="literal">stylesheet</code></span></dt><dd><p>
- Optional attribute.
- It specifies the stylesheet to use to generate html output when the output is set to html.
- Stylesheets included in the FindBugs distribution include default.xsl, fancy.xsl, fancy-hist.xsl, plain.xsl, and summary.xsl.
- The default value, if no stylesheet attribute is provided, is default.xsl.
-
- </p></dd><dt><span class="term"><code class="literal">sort</code></span></dt><dd><p>
- Optional attribute. If the <code class="literal">output</code> attribute
- is set to "text", then the <code class="literal">sort</code> attribute specifies
- whether or not reported bugs are sorted by class. Default is true.
- </p></dd><dt><span class="term"><code class="literal">outputFile</code></span></dt><dd><p>
- Optional attribute. If specified, names the output file in which the
- <span class="application">FindBugs</span> output will be saved. By default, the output is displayed
- directly by <span class="application">Ant</span>.
- </p></dd><dt><span class="term"><code class="literal">debug</code></span></dt><dd><p>
- Optional boolean attribute. If set to true, <span class="application">FindBugs</span> prints diagnostic
- information about which classes are being analyzed, and which bug pattern
- detectors are being run. Default is false.
- </p></dd><dt><span class="term"><code class="literal">effort</code></span></dt><dd><p>
- Set the analysis effort level. The value specified should be
- one of <code class="literal">min</code>, <code class="literal">default</code>,
- or <code class="literal">max</code>. See <a href="running.html#commandLineOptions" title="3. Command-line Options">Section 3, “Command-line Options”</a>
- for more information about setting the analysis level.
- </p></dd><dt><span class="term"><code class="literal">conserveSpace</code></span></dt><dd><p>Synonym for effort="min".</p></dd><dt><span class="term"><code class="literal">workHard</code></span></dt><dd><p>Synonym for effort="max".</p></dd><dt><span class="term"><code class="literal">visitors</code></span></dt><dd><p>
- Optional attribute. It specifies a comma-separated list of bug detectors
- which should be run. The bug detectors are specified by their class names,
- without any package qualification. By default, all detectors which are
- not disabled by default are run.
- </p></dd><dt><span class="term"><code class="literal">omitVisitors</code></span></dt><dd><p>
- Optional attribute. It is like the <code class="literal">visitors</code> attribute,
- except it specifies detectors which will <span class="emphasis"><em>not</em></span> be run.
- </p></dd><dt><span class="term"><code class="literal">excludeFilter</code></span></dt><dd><p>
- Optional attribute. It specifies the filename of a filter specifying bugs
- to exclude from being reported. See <a href="filter.html" title="Chapter 8. Filter Files">Chapter 8, <i>Filter Files</i></a>.
- </p></dd><dt><span class="term"><code class="literal">includeFilter</code></span></dt><dd><p>
- Optional attribute. It specifies the filename of a filter specifying
- which bugs are reported. See <a href="filter.html" title="Chapter 8. Filter Files">Chapter 8, <i>Filter Files</i></a>.
- </p></dd><dt><span class="term"><code class="literal">projectFile</code></span></dt><dd><p>
- Optional attribute. It specifies the name of a project file.
- Project files are created by the <span class="application">FindBugs</span> GUI, and specify classes,
- aux classpath entries, and source directories. By naming a project,
- you don't need to specify any <code class="literal">class</code> elements,
- nor do you need to specify <code class="literal">auxClasspath</code> or
- <code class="literal">sourcePath</code> attributes.
- See <a href="running.html" title="Chapter 4. Running FindBugs™">Chapter 4, <i>Running <span class="application">FindBugs</span>™</i></a> for how to create a project.
- </p></dd><dt><span class="term"><code class="literal">jvmargs</code></span></dt><dd><p>
- Optional attribute. It specifies any arguments that should be passed
- to the Java virtual machine used to run <span class="application">FindBugs</span>. You may need to
- use this attribute to specify flags to increase the amount of memory
- the JVM may use if you are analyzing a very large program.
- </p></dd><dt><span class="term"><code class="literal">systemProperty</code></span></dt><dd><p>
- Optional nested element. If specified, defines a system property.
- The <code class="literal">name</code> attribute specifies the name of the
- system property, and the <code class="literal">value</code> attribute specifies
- the value of the system property.
- </p></dd><dt><span class="term"><code class="literal">timeout</code></span></dt><dd><p>
- Optional attribute. It specifies the amount of time, in milliseconds,
- that the Java process executing <span class="application">FindBugs</span> may run before it is
- assumed to be hung and is terminated. The default is 600,000
- milliseconds, which is ten minutes. Note that for very large
- programs, <span class="application">FindBugs</span> may require more than ten minutes to complete its
- analysis.
- </p></dd><dt><span class="term"><code class="literal">failOnError</code></span></dt><dd><p>
- Optional boolean attribute. Whether to abort the build process if there is an
- error running <span class="application">FindBugs</span>. Defaults to "false"
- </p></dd><dt><span class="term"><code class="literal">errorProperty</code></span></dt><dd><p>
- Optional attribute which specifies the name of a property that
- will be set to "true" if an error occurs while running <span class="application">FindBugs</span>.
- </p></dd><dt><span class="term"><code class="literal">warningsProperty</code></span></dt><dd><p>
- Optional attribute which specifies the name of a property
- that will be set to "true" if any warnings are reported by
- <span class="application">FindBugs</span> on the analyzed program.
- </p></dd></dl></div><p>
-
-
-</p></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="gui.html">Prev</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="eclipse.html">Next</a></td></tr><tr><td width="40%" align="left" valign="top">Chapter 5. Using the <span class="application">FindBugs</span> GUI </td><td width="20%" align="center"><a accesskey="h" href="index.html">Home</a></td><td width="40%" align="right" valign="top"> Chapter 7. Using the <span class="application">FindBugs</span>™ Eclipse plugin</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/manual/building.html b/tools/findbugs-1.3.9/doc/manual/building.html
deleted file mode 100644
index be56102..0000000
--- a/tools/findbugs-1.3.9/doc/manual/building.html
+++ /dev/null
@@ -1,123 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>Chapter 3. Building FindBugs™ from Source</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ Manual"><link rel="up" href="index.html" title="FindBugs™ Manual"><link rel="prev" href="installing.html" title="Chapter 2. Installing FindBugs™"><link rel="next" href="running.html" title="Chapter 4. Running FindBugs™"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">Chapter 3. Building <span class="application">FindBugs</span>™ from Source</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="installing.html">Prev</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="running.html">Next</a></td></tr></table><hr></div><div class="chapter" lang="en"><div class="titlepage"><div><div><h2 class="title"><a name="building"></a>Chapter 3. Building <span class="application">FindBugs</span>™ from Source</h2></div></div></div><div class="toc"><p><b>Table of Contents</b></p><dl><dt><span class="sect1"><a href="building.html#d0e181">1. Prerequisites</a></span></dt><dt><span class="sect1"><a href="building.html#d0e270">2. Extracting the Source Distribution</a></span></dt><dt><span class="sect1"><a href="building.html#d0e283">3. Modifying <code class="filename">local.properties</code></a></span></dt><dt><span class="sect1"><a href="building.html#d0e341">4. Running <span class="application">Ant</span></a></span></dt><dt><span class="sect1"><a href="building.html#d0e435">5. Running <span class="application">FindBugs</span>™ from a source directory</a></span></dt></dl></div><p>
-This chapter describes how to build <span class="application">FindBugs</span> from source code. Unless you are
-interesting in modifying <span class="application">FindBugs</span>, you will probably want to skip to the
-<a href="running.html" title="Chapter 4. Running FindBugs™">next chapter</a>.
-</p><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e181"></a>1. Prerequisites</h2></div></div></div><p>
-To compile <span class="application">FindBugs</span> from source, you will need the following:
-</p><div class="itemizedlist"><ul type="disc"><li><p>
- The <a href="http://prdownloads.sourceforge.net/findbugs/findbugs-1.3.9-source.zip?download" target="_top"><span class="application">FindBugs</span> source distribution</a>
- </p></li><li><p>
- <a href="http://java.sun.com/j2se/" target="_top">JDK 1.5.0 beta or later</a>
- </p></li><li><p>
- <a href="http://ant.apache.org/" target="_top">Apache <span class="application">Ant</span></a>, version 1.6.3 or later
- </p></li></ul></div><p>
-</p><div class="warning" style="margin-left: 0.5in; margin-right: 0.5in;"><table border="0" summary="Warning"><tr><td rowspan="2" align="center" valign="top" width="25"><img alt="[Warning]" src="warning.png"></td><th align="left">Warning</th></tr><tr><td align="left" valign="top"><p>
- The version of <span class="application">Ant</span> included as <code class="filename">/usr/bin/ant</code> on
- Redhat Linux systems will <span class="emphasis"><em>not</em></span> work for compiling
- <span class="application">FindBugs</span>. We recommend you install a binary distribution of <span class="application">Ant</span>
- downloaded from the <a href="http://ant.apache.org/" target="_top"><span class="application">Ant</span> website</a>.
- Make sure that when you run <span class="application">Ant</span> your <em class="replaceable"><code>JAVA_HOME</code></em>
- environment variable points to the directory in which you installed
- JDK 1.5 (or later).
- </p></td></tr></table></div><p>
-If you want to be able to generate formatted versions of the <span class="application">FindBugs</span> documentation,
-you will also need the following software:
-</p><div class="itemizedlist"><ul type="disc"><li><p>
- The <a href="http://docbook.sourceforge.net/projects/xsl/index.html" target="_top">DocBook XSL Stylesheets</a>.
- These are required to convert the <span class="application">FindBugs</span> manual into HTML format.
- </p></li><li><p>
- The <a href="http://saxon.sourceforge.net/" target="_top"><span class="application">Saxon</span> XSLT Processor</a>.
- (Also required for converting the <span class="application">FindBugs</span> manual to HTML.)
- </p></li></ul></div><p>
-</p></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e270"></a>2. Extracting the Source Distribution</h2></div></div></div><p>
-After you download the source distribution, you'll need to extract it into
-a working directory. A typical command to do this is:
-
-</p><pre class="screen">
-<code class="prompt">$ </code><span><strong class="command">unzip findbugs-1.3.9-source.zip</strong></span>
-</pre><p>
-
-</p></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e283"></a>3. Modifying <code class="filename">local.properties</code></h2></div></div></div><p>
-If you intend to build the FindBugs documentation,
-you will need to modify the <code class="filename">local.properties</code> file
-used by the <a href="http://ant.apache.org/" target="_top"><span class="application">Ant</span></a>
-<code class="filename">build.xml</code> file to build <span class="application">FindBugs</span>.
-If you do not want to build the FindBugs documentation, then you
-can ignore this file.
-</p><p>
-The <code class="filename">local.properties</code> overrides definitions
-in the <code class="filename">build.properties</code> file.
-The <code class="filename">build.properties</code> file looks something like this:
-</p><pre class="programlisting">
-
-# User Configuration:
-# This section must be modified to reflect your system.
-
-local.software.home =/export/home/daveho/linux
-
-# Set this to the directory containing the DocBook Modular XSL Stylesheets
-# from http://docbook.sourceforge.net/projects/xsl/
-
-xsl.stylesheet.home =${local.software.home}/docbook/docbook-xsl-1.71.1
-
-# Set this to the directory where Saxon (http://saxon.sourceforge.net/)
-# is installed.
-
-saxon.home =${local.software.home}/java/saxon-6.5.5
-
-</pre><p>
-</p><p>
-The <code class="varname">xsl.stylesheet.home</code> property specifies the full
-path to the directory where you have installed the
-<a href="http://docbook.sourceforge.net/projects/xsl/" target="_top">DocBook Modular XSL
-Stylesheets</a>. You only need to specify this property if you will be
-generating the <span class="application">FindBugs</span> documentation.
-</p><p>
-The <code class="varname">saxon.home</code> property is the full path to the
-directory where you installed the <a href="http://saxon.sourceforge.net/" target="_top"><span class="application">Saxon</span> XSLT Processor</a>.
-You only need to specify this property if you will be
-generating the <span class="application">FindBugs</span> documentation.
-</p></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e341"></a>4. Running <span class="application">Ant</span></h2></div></div></div><p>
-Once you have extracted the source distribution,
-made sure that <span class="application">Ant</span> is installed,
-modified <code class="filename">build.properties</code> (optional),
-and configured the tools (such as <span class="application">Saxon</span>),
-you are ready to build <span class="application">FindBugs</span>. Invoking <span class="application">Ant</span> is a simple matter
-of running the command
-</p><pre class="screen">
-<code class="prompt">$ </code><span><strong class="command">ant <em class="replaceable"><code>target</code></em></strong></span>
-</pre><p>
-where <em class="replaceable"><code>target</code></em> is one of the following:
-</p><div class="variablelist"><dl><dt><span class="term"><span><strong class="command">build</strong></span></span></dt><dd><p>
- This target compiles the code for <span class="application">FindBugs</span>. It is the default target.
- </p></dd><dt><span class="term"><span><strong class="command">docs</strong></span></span></dt><dd><p>
- This target formats the documentation. (It also compiles some of
- the source code as a side-effect.)
- </p></dd><dt><span class="term"><span><strong class="command">runjunit</strong></span></span></dt><dd><p>
- This target compiles and runs the internal JUnit tests included
- in <span class="application">FindBugs</span>. It will print an error message if any unit
- tests fail.
- </p></dd><dt><span class="term"><span><strong class="command">bindist</strong></span></span></dt><dd><p>
- Builds a binary distribution of <span class="application">FindBugs</span>.
- The target creates both <code class="filename">.zip</code> and
- <code class="filename">.tar.gz</code> archives.
- </p></dd></dl></div><p>
-</p><p>
-After running an <span class="application">Ant</span> command, you should see output similar to
-the following (after some other messages regarding the tasks that
-<span class="application">Ant</span> is running):
-</p><pre class="screen">
-<code class="computeroutput">
-BUILD SUCCESSFUL
-Total time: 17 seconds
-</code>
-</pre><p>
-</p></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e435"></a>5. Running <span class="application">FindBugs</span>™ from a source directory</h2></div></div></div><p>
-The <span class="application">Ant</span> build script for <span class="application">FindBugs</span> is written such that after
-building the <span><strong class="command">build</strong></span> target, the working directory
-is set up just like a binary distribution. So, the information about
-running <span class="application">FindBugs</span> in <a href="running.html" title="Chapter 4. Running FindBugs™">Chapter 4, <i>Running <span class="application">FindBugs</span>™</i></a>
-applies to source distributions, too.
-</p></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="installing.html">Prev</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="running.html">Next</a></td></tr><tr><td width="40%" align="left" valign="top">Chapter 2. Installing <span class="application">FindBugs</span>™ </td><td width="20%" align="center"><a accesskey="h" href="index.html">Home</a></td><td width="40%" align="right" valign="top"> Chapter 4. Running <span class="application">FindBugs</span>™</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/manual/datamining.html b/tools/findbugs-1.3.9/doc/manual/datamining.html
deleted file mode 100644
index e24756b..0000000
--- a/tools/findbugs-1.3.9/doc/manual/datamining.html
+++ /dev/null
@@ -1,421 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>Chapter 12. Data mining of bugs with FindBugs™</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ Manual"><link rel="up" href="index.html" title="FindBugs™ Manual"><link rel="prev" href="rejarForAnalysis.html" title="Chapter 11. Using rejarForAnalysis"><link rel="next" href="license.html" title="Chapter 13. License"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">Chapter 12. Data mining of bugs with <span class="application">FindBugs</span>™</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="rejarForAnalysis.html">Prev</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="license.html">Next</a></td></tr></table><hr></div><div class="chapter" lang="en"><div class="titlepage"><div><div><h2 class="title"><a name="datamining"></a>Chapter 12. Data mining of bugs with <span class="application">FindBugs</span>™</h2></div></div></div><div class="toc"><p><b>Table of Contents</b></p><dl><dt><span class="sect1"><a href="datamining.html#commands">1. Commands</a></span></dt><dt><span class="sect1"><a href="datamining.html#examples">2. Examples</a></span></dt><dt><span class="sect1"><a href="datamining.html#antexample">3. Ant example</a></span></dt></dl></div><p>
-FindBugs incorporates an ability to perform sophisticated queries on bug
-databases and track warnings across multiple versions of code being
-studied, allowing you to do things such as seeing when a bug was first introduced, examining
-just the warnings that have been introduced since the last release, or graphing the number
-of infinite recursive loops in your code over time.</p><p>
-These techniques all depend upon the XML format used by FindBugs for storing warnings.
-These XML files usually contain just the warnings from one particular analysis run, but
-they can also store the results from analyzing a sequence of software builds or versions.
- </p><p>
-Any FindBugs XML bug database contains a version name and timestamp.
-FindBugs tries to compute a timestamp from the timestamps of the files that
-are analyzed (e.g., the timestamp is intended to be the time the class files
-were generated, not analyzed). Each bug database also contains a version name.
-Both the version name and timestamp can be set manually using the
-<span><strong class="command">setBugDatabaseInfo</strong></span> (<a href="datamining.html#setBugDatabaseInfo" title="1.7. setBugDatabaseInfo">Section 1.7, “setBugDatabaseInfo”</a>) command.
- </p><p>A multiversion bug database assigns a sequence number to each version of
-the analyzed code. These sequence numbers are simply successive integers,
-starting at 0 (e.g., a bug database for 4 versions of the code will contain
-versions 0..3). The bug database will also record the name and timestamp for
-each version. The <span><strong class="command">filterBugs</strong></span> command allows you to refer
-to a version by sequence number, name or timestamp.</p><p>
-You can take a sequence (or pair) of single version bug databases and create
-from them a multiversion bug database, or combine a multiversion bug database
-with a sequence of later single-version bug databases.</p><p>
-Some of these commands can be invoked as ant tasks. See below for specifics
-on how to invoke them and what attributes and arguments they take. All of
-the examples assume that the <code class="literal">findbugs.lib</code>
-<code class="literal">refid</code> is set correctly. Here is one way to set it:
-</p><pre class="programlisting">
-
- <!-- findbugs task definition -->
- <property name="findbugs.home" value="/your/path/to/findbugs" />
- <path id="findbugs.lib">
- <fileset dir="${findbugs.home}/lib">
- <include name="findbugs-ant.jar"/>
- </fileset>
- </path>
-
-</pre><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="commands"></a>1. Commands</h2></div></div></div><p>
-All tools for FindBugs data mining are can be invoked from the command line,
-and some of the more useful tools can also be invoked from an
-ant build file.</p><p>
-Briefly, the command-line tools are:</p><div class="variablelist"><dl><dt><span class="term"><span><strong class="command"><a href="datamining.html#unionBugs" title="1.1. unionBugs">unionBugs</a></strong></span></span></dt><dd><p>
- combine the results from separate analysis of disjoint
- classes
- </p></dd><dt><span class="term"><span><strong class="command"><a href="datamining.html#computeBugHistory" title="1.2. computeBugHistory">computeBugHistory</a></strong></span></span></dt><dd><p>Merge bug warnings from multiple versions of
- analyzed code into
- a single multiversion bug database. This can either be used
- to add more versions to an existing multiversion database,
- or to create a multiversion database from a sequence of single version
- bug warning databases.</p></dd><dt><span class="term"><span><strong class="command"><a href="datamining.html#setBugDatabaseInfo" title="1.7. setBugDatabaseInfo">setBugDatabaseInfo</a></strong></span></span></dt><dd><p>Set information such as the revision name or
-timestamp in an XML bug database</p></dd><dt><span class="term"><span><strong class="command"><a href="datamining.html#listBugDatabaseInfo" title="1.8. listBugDatabaseInfo">listBugDatabaseInfo</a></strong></span></span></dt><dd><p>List information such as the revision name and
-timestamp for a list of XML bug databases</p></dd><dt><span class="term"><span><strong class="command"><a href="datamining.html#filterBugs" title="1.3. filterBugs">filterBugs</a></strong></span></span></dt><dd><p>Select a subset of a bug database</p></dd><dt><span class="term"><span><strong class="command"><a href="datamining.html#mineBugHistory" title="1.4. mineBugHistory">mineBugHistory</a></strong></span></span></dt><dd><p>Generate a tabular listing of the number of warnings in each
- version of a multiversion bug database</p></dd><dt><span class="term"><span><strong class="command"><a href="datamining.html#defectDensity" title="1.5. defectDensity">defectDensity</a></strong></span></span></dt><dd><p>List information about defect density
- (warnings per 1000 NCSS)
- for the entire project and each class and package</p></dd><dt><span class="term"><span><strong class="command"><a href="datamining.html#convertXmlToText" title="1.6. convertXmlToText">convertXmlToText</a></strong></span></span></dt><dd><p>Convert bug warnings in XML format to
- a textual one-line-per-bug format, or to HTML</p></dd></dl></div><div class="sect2" lang="en"><div class="titlepage"><div><div><h3 class="title"><a name="unionBugs"></a>1.1. unionBugs</h3></div></div></div><p>
- If you have, for example, separately analyzing each jar file used in an application,
- you can use this command to combine the separately generated xml bug warning files into
- a single file containing all of the warnings.</p><p>Do <span class="emphasis"><em>not</em></span> use this command to combine results from analyzing different versions of the same
- file; use <span><strong class="command">computeBugHistory</strong></span> instead.</p><p>Specify the xml files on the command line. The result is sent to standard output.</p></div><div class="sect2" lang="en"><div class="titlepage"><div><div><h3 class="title"><a name="computeBugHistory"></a>1.2. computeBugHistory</h3></div></div></div><p>Use this command to generate a bug database containing information from different builds or versions
-of software you are analyzing.
-History is taken from the first file provided as input; any following
-files should be single version bug databases (if they contain history, the history in those
-files will be ignored).</p><p>By default, output is written to the standard output.
-</p><p>This functionality may also can be accessed from ant.
-First create a taskdef for <span><strong class="command">computeBugHistory</strong></span> in your
-build file:
-</p><pre class="programlisting">
-
-<taskdef name="computeBugHistory" classname="edu.umd.cs.findbugs.anttask.ComputeBugHistoryTask">
- <classpath refid="findbugs.lib" />
-</taskdef>
-
-</pre><p>Attributes for this ant task are listed in the following table.
-To specify input files, nest them inside with a
-<code class="literal"><datafile></code> element. For example:
-</p><pre class="programlisting">
-
-<computeBugHistory home="${findbugs.home}" ...>
- <datafile name="analyze1.xml"/>
- <datafile name="analyze2.xml"/>
-</computeBugHistory>
-
-</pre><div class="table"><a name="computeBugHistoryTable"></a><p class="title"><b>Table 12.1. Options for computeBugHistory command</b></p><div class="table-contents"><table summary="Options for computeBugHistory command" border="1"><colgroup><col><col><col></colgroup><thead><tr><th align="left">Command-line option</th><th align="left">Ant attribute</th><th align="left">Meaning</th></tr></thead><tbody><tr><td align="left">-output <file></td><td align="left">output="<file>"</td><td align="left">save output in the named file (may also be an input file)</td></tr><tr><td align="left">-overrideRevisionNames[:truth]</td><td align="left">overrideRevisionNames="[true|false]"</td><td align="left">override revision names for each version with names computed from the filenames</td></tr><tr><td align="left">-noPackageMoves[:truth]</td><td align="left">noPackageMoves="[true|false]"</td><td align="left">if a class has moved to another package, treat warnings in that class as seperate</td></tr><tr><td align="left">-preciseMatch[:truth]</td><td align="left">preciseMatch="[true|false]"</td><td align="left">require bug patterns to match precisely</td></tr><tr><td align="left">-precisePriorityMatch[:truth]</td><td align="left">precisePriorityMatch="[true|false]"</td><td align="left">consider two warnings as the same only if priorities match exactly</td></tr><tr><td align="left">-quiet[:truth]</td><td align="left">quiet="[true|false]"</td><td align="left">don't generate any output to standard out unless there is an error</td></tr><tr><td align="left">-withMessages[:truth]</td><td align="left">withMessages="[true|false]"</td><td align="left">include human-readable messages describing the warnings in XML output</td></tr></tbody></table></div></div><br class="table-break"></div><div class="sect2" lang="en"><div class="titlepage"><div><div><h3 class="title"><a name="filterBugs"></a>1.3. filterBugs</h3></div></div></div><p>This command is used to select a subset of warnings from a FindBugs XML warning file
-and write the selected subset to a new FindBugs warning file.</p><p>
-This command takes a sequence of options, and either zero, one or two
-filenames of findbugs xml bug files on the command line.</p><p>If no file names are provided, the command reads from standard input
-and writes to standard output. If one file name is provided,
-it reads from the file and writes to standard output.
-If two file names are provided, it reads from the first and writes the output
-to the second file name.</p><p>This functionality may also can be accessed from ant.
-First create a taskdef for <span><strong class="command">filterBugs</strong></span> in your
-build file:
-</p><pre class="programlisting">
-
-<taskdef name="filterBugs" classname="edu.umd.cs.findbugs.anttask.FilterBugsTask">
- <classpath refid="findbugs.lib" />
-</taskdef>
-
-</pre><p>Attributes for this ant task are listed in the following table.
-To specify an input file either use the input attribute or nest it inside
-the ant call with a <code class="literal"><datafile></code> element. For example:
-</p><pre class="programlisting">
-
-<filterBugs home="${findbugs.home}" ...>
- <datafile name="analyze.xml"/>
-</filterBugs>
-
-</pre><div class="table"><a name="filterOptionsTable"></a><p class="title"><b>Table 12.2. Options for filterBugs command</b></p><div class="table-contents"><table summary="Options for filterBugs command" border="1"><colgroup><col><col><col></colgroup><thead><tr><th align="left">Command-line option</th><th align="left">Ant attribute</th><th align="left">Meaning</th></tr></thead><tbody><tr><td align="left"> </td><td align="left">input="<file>"</td><td align="left">use file as input</td></tr><tr><td align="left"> </td><td align="left">output="<file>"</td><td align="left">output results to file</td></tr><tr><td align="left">-not</td><td align="left">not="[true|false]"</td><td align="left">reverse (all) switches for the filter</td></tr><tr><td align="left">-withSource[:truth]</td><td align="left">withSource="[true|false]"</td><td align="left">only warnings for switch source is available</td></tr><tr><td align="left">-exclude <filter file></td><td align="left">exclude="<filter file>"</td><td align="left">exclude bugs matching given filter</td></tr><tr><td align="left">-include <filter file></td><td align="left">include="<filter file>"</td><td align="left">include only bugs matching given filter</td></tr><tr><td align="left">-annotation <text></td><td align="left">annotation="<text>"</td><td align="left">allow only warnings containing this text in a manual annotation</td></tr><tr><td align="left">-after <when></td><td align="left">after="<when>"</td><td align="left">allow only warnings that first occurred after this version</td></tr><tr><td align="left">-before <when></td><td align="left">before="<when>"</td><td align="left">allow only warnings that first occurred before this version</td></tr><tr><td align="left">-first <when></td><td align="left">first="<when>"</td><td align="left">allow only warnings that first occurred in this version</td></tr><tr><td align="left">-last <when></td><td align="left">last="<when>"</td><td align="left">allow only warnings that last occurred in this version</td></tr><tr><td align="left">-fixed <when></td><td align="left">fixed="<when>"</td><td align="left">allow only warnings that last occurred in the previous version (clobbers <code class="option">-last</code>)</td></tr><tr><td align="left">-present <when></td><td align="left">present="<when>"</td><td align="left">allow only warnings present in this version</td></tr><tr><td align="left">-absent <when></td><td align="left">absent="<when>"</td><td align="left">allow only warnings absent in this version</td></tr><tr><td align="left">-active[:truth]</td><td align="left">active="[true|false]"</td><td align="left">allow only warnings alive in the last sequence number</td></tr><tr><td align="left">-introducedByChange[:truth]</td><td align="left">introducedByChange="[true|false]"</td><td align="left">allow only warnings introduced by a change of an existing class</td></tr><tr><td align="left">-removedByChange[:truth]</td><td align="left">removedByChange="[true|false]"</td><td align="left">allow only warnings removed by a change of a persisting class</td></tr><tr><td align="left">-newCode[:truth]</td><td align="left">newCode="[true|false]"</td><td align="left">allow only warnings introduced by the addition of a new class</td></tr><tr><td align="left">-removedCode[:truth]</td><td align="left">removedCode="[true|false]"</td><td align="left">allow only warnings removed by removal of a class</td></tr><tr><td align="left">-priority <level></td><td align="left">priority="<level>"</td><td align="left">allow only warnings with this priority or higher</td></tr><tr><td align="left">-class <pattern></td><td align="left">class="<class>"</td><td align="left">allow only bugs whose primary class name matches this pattern</td></tr><tr><td align="left">-bugPattern <pattern></td><td align="left">bugPattern="<pattern>"</td><td align="left">allow only bugs whose type matches this pattern</td></tr><tr><td align="left">-category <category></td><td align="left">category="<category>"</td><td align="left">allow only warnings with a category that starts with this string</td></tr><tr><td align="left">-designation <designation></td><td align="left">designation="<designation>"</td><td align="left">allow only warnings with this designation (e.g., -designation SHOULD_FIX)</td></tr><tr><td align="left">-withMessages[:truth] </td><td align="left">withMessages="[true|false]"</td><td align="left">the generated XML should contain textual messages</td></tr></tbody></table></div></div><br class="table-break"></div><div class="sect2" lang="en"><div class="titlepage"><div><div><h3 class="title"><a name="mineBugHistory"></a>1.4. mineBugHistory</h3></div></div></div><p>This command generates a table containing counts of the numbers of warnings
-in each version of a multiversion bug database.</p><p>This functionality may also can be accessed from ant.
-First create a taskdef for <span><strong class="command">mineBugHistory</strong></span> in your
-build file:
-</p><pre class="programlisting">
-
-<taskdef name="mineBugHistory" classname="edu.umd.cs.findbugs.anttask.MineBugHistoryTask">
- <classpath refid="findbugs.lib" />
-</taskdef>
-
-</pre><p>Attributes for this ant task are listed in the following table.
-To specify an input file either use the <code class="literal">input</code>
-attribute or nest it inside the ant call with a
-<code class="literal"><datafile></code> element. For example:
-</p><pre class="programlisting">
-
-<mineBugHistory home="${findbugs.home}" ...>
- <datafile name="analyze.xml"/>
-</mineBugHistory>
-
-</pre><div class="table"><a name="mineBugHistoryOptionsTable"></a><p class="title"><b>Table 12.3. Options for mineBugHistory command</b></p><div class="table-contents"><table summary="Options for mineBugHistory command" border="1"><colgroup><col><col><col></colgroup><thead><tr><th align="left">Command-line option</th><th align="left">Ant attribute</th><th align="left">Meaning</th></tr></thead><tbody><tr><td align="left"> </td><td align="left">input="<file>"</td><td align="left">use file as input</td></tr><tr><td align="left"> </td><td align="left">output="<file>"</td><td align="left">write output to file</td></tr><tr><td align="left">-formatDates</td><td align="left">formatDates="[true|false]"</td><td align="left">render dates in textual form</td></tr><tr><td align="left">-noTabs</td><td align="left">noTabs="[true|false]"</td><td align="left">delimit columns with groups of spaces instead of tabs (see below)</td></tr><tr><td align="left">-summary</td><td align="left">summary="[true|false]"</td><td align="left">output terse summary of changes over the last ten entries</td></tr></tbody></table></div></div><br class="table-break"><p>
- The <code class="option">-noTabs</code> output can be easier to read from a shell
- with a fixed-width font.
- Because numeric columns are right-justified, spaces may precede the
- first column value. This option also causes <code class="option">-formatDates</code>
- to render dates in terser format without embedded whitespace.
- </p><p>The table is a tab-separated (barring <code class="option">-noTabs</code>)
- table with the following columns:</p><div class="table"><a name="mineBugHistoryColumns"></a><p class="title"><b>Table 12.4. Columns in mineBugHistory output</b></p><div class="table-contents"><table summary="Columns in mineBugHistory output" border="1"><colgroup><col><col></colgroup><thead><tr><th align="left">Title</th><th align="left">Meaning</th></tr></thead><tbody><tr><td align="left">seq</td><td align="left">Sequence number (successive integers, starting at 0)</td></tr><tr><td align="left">version</td><td align="left">Version name</td></tr><tr><td align="left">time</td><td align="left">Release timestamp</td></tr><tr><td align="left">classes</td><td align="left">Number of classes analyzed</td></tr><tr><td align="left">NCSS</td><td align="left">Non Commenting Source Statements</td></tr><tr><td align="left">added</td><td align="left">Count of new warnings for a class that existed in the previous version</td></tr><tr><td align="left">newCode</td><td align="left">Count of new warnings for a class that did not exist in the previous version</td></tr><tr><td align="left">fixed</td><td align="left">Count of warnings removed from a class that remains in the current version</td></tr><tr><td align="left">removed</td><td align="left">Count of warnings in the previous version for a class that is not present in the current version</td></tr><tr><td align="left">retained</td><td align="left">Count of warnings that were in both the previous and current version</td></tr><tr><td align="left">dead</td><td align="left">Warnings that were present in earlier versions but in neither the current version or the immediately preceeding version</td></tr><tr><td align="left">active</td><td align="left">Total warnings present in the current version</td></tr></tbody></table></div></div><br class="table-break"></div><div class="sect2" lang="en"><div class="titlepage"><div><div><h3 class="title"><a name="defectDensity"></a>1.5. defectDensity</h3></div></div></div><p>
-This command lists information about defect density (warnings per 1000 NCSS) for the entire project and each class and package.
-It can either be invoked with no files specified on the command line (in which case it reads from standard input)
-or with one file specified on the command line.</p><p>It generates a table with the following columns, and with one
-row for the entire project, and one row for each package or class that contains at least
-4 warnings.</p><div class="table"><a name="defectDensityColumns"></a><p class="title"><b>Table 12.5. Columns in defectDensity output</b></p><div class="table-contents"><table summary="Columns in defectDensity output" border="1"><colgroup><col><col></colgroup><thead><tr><th align="left">Title</th><th align="left">Meaning</th></tr></thead><tbody><tr><td align="left">kind</td><td align="left">project, package or class</td></tr><tr><td align="left">name</td><td align="left">The name of the project, package or class</td></tr><tr><td align="left">density</td><td align="left">Number of warnings generated per 1000 lines of NCSS.</td></tr><tr><td align="left">bugs</td><td align="left">Number of warnings</td></tr><tr><td align="left">NCSS</td><td align="left">Calculated number of NCSS</td></tr></tbody></table></div></div><br class="table-break"></div><div class="sect2" lang="en"><div class="titlepage"><div><div><h3 class="title"><a name="convertXmlToText"></a>1.6. convertXmlToText</h3></div></div></div><p>
- This command converts a warning collection in XML format to a text
- format with one line per warning, or to HTML.
- </p><p>This functionality may also can be accessed from ant.
-First create a taskdef for <span><strong class="command">convertXmlToText</strong></span> in your
-build file:
-</p><pre class="programlisting">
-
-<taskdef name="convertXmlToText" classname="edu.umd.cs.findbugs.anttask.ConvertXmlToTextTask">
- <classpath refid="findbugs.lib" />
-</taskdef>
-
-</pre><p>Attributes for this ant task are listed in the following table.</p><div class="table"><a name="convertXmlToTextTable"></a><p class="title"><b>Table 12.6. Options for convertXmlToText command</b></p><div class="table-contents"><table summary="Options for convertXmlToText command" border="1"><colgroup><col><col><col></colgroup><thead><tr><th align="left">Command-line option</th><th align="left">Ant attribute</th><th align="left">Meaning</th></tr></thead><tbody><tr><td align="left"> </td><td align="left">input="<filename>"</td><td align="left">use file as input</td></tr><tr><td align="left"> </td><td align="left">output="<filename>"</td><td align="left">output results to file</td></tr><tr><td align="left">-longBugCodes</td><td align="left">longBugCodes="[true|false]"</td><td align="left">use the full bug pattern code instead of two-letter abbreviation</td></tr><tr><td align="left"> </td><td align="left">format="text"</td><td align="left">generate plain text output with one bug per line (command-line default)</td></tr><tr><td align="left">-html[:stylesheet]</td><td align="left">format="html:<stylesheet>"</td><td align="left">generate output with specified stylesheet (see below), or default.xsl if unspecified</td></tr></tbody></table></div></div><br class="table-break"><p>
- You may specify plain.xsl, default.xsl, fancy.xsl, fancy-hist.xsl,
- or your own XSL stylesheet for the -html/format option.
- Despite the name of this option, you may specify
- a stylesheet that emits something other than html.
- When applying a stylesheet other than those included
- with FindBugs (listed above), the -html/format option should be used
- with a path or URL to the stylesheet.
- </p></div><div class="sect2" lang="en"><div class="titlepage"><div><div><h3 class="title"><a name="setBugDatabaseInfo"></a>1.7. setBugDatabaseInfo</h3></div></div></div><p>
- This command sets meta-information in a specified warning collection.
- It takes the following options:
- </p><p>This functionality may also can be accessed from ant.
-First create a taskdef for <span><strong class="command">setBugDatabaseInfo</strong></span> in your
-build file:
-</p><pre class="programlisting">
-
-<taskdef name="setBugDatabaseInfo" classname="edu.umd.cs.findbugs.anttask.SetBugDatabaseInfoTask">
- <classpath refid="findbugs.lib" />
-</taskdef>
-
-</pre><p>Attributes for this ant task are listed in the following table.
-To specify an input file either use the <code class="literal">input</code>
-attribute or nest it inside the ant call with a
-<code class="literal"><datafile></code> element. For example:
-</p><pre class="programlisting">
-
-<setBugDatabaseInfo home="${findbugs.home}" ...>
- <datafile name="analyze.xml"/>
-</setBugDatabaseInfo>
-
-</pre><div class="table"><a name="setBugDatabaseInfoOptions"></a><p class="title"><b>Table 12.7. setBugDatabaseInfo Options</b></p><div class="table-contents"><table summary="setBugDatabaseInfo Options" border="1"><colgroup><col><col><col></colgroup><thead><tr><th align="left">Command-line option</th><th align="left">Ant attribute</th><th align="left">Meaning</th></tr></thead><tbody><tr><td align="left"> </td><td align="left">input="<file>"</td><td align="left">use file as input</td></tr><tr><td align="left"> </td><td align="left">output="<file>"</td><td align="left">write output to file</td></tr><tr><td align="left">-name <name></td><td align="left">name="<name>"</td><td align="left">set name for (last) revision</td></tr><tr><td align="left">-timestamp <when></td><td align="left">timestamp="<when>"</td><td align="left">set timestamp for (last) revision</td></tr><tr><td align="left">-source <directory></td><td align="left">source="<directory>"</td><td align="left">add specified directory to the source search path</td></tr><tr><td align="left">-findSource <directory></td><td align="left">findSource="<directory>"</td><td align="left">find and add all relevant source directions contained within specified directory</td></tr><tr><td align="left">-suppress <filter file></td><td align="left">suppress="<filter file>"</td><td align="left">suppress warnings matched by this file (replaces previous suppressions)</td></tr><tr><td align="left">-withMessages</td><td align="left">withMessages="[true|false]"</td><td align="left">add textual messages to XML</td></tr><tr><td align="left">-resetSource</td><td align="left">resetSource="[true|false]"</td><td align="left">remove all source search paths</td></tr></tbody></table></div></div><br class="table-break"></div><div class="sect2" lang="en"><div class="titlepage"><div><div><h3 class="title"><a name="listBugDatabaseInfo"></a>1.8. listBugDatabaseInfo</h3></div></div></div><p>This command takes a list of zero or more xml bug database filenames on the command line.
-If zero file names are provided, it reads from standard input and does not generate
-a table header.</p><p>There is only one option: <code class="option">-formatDates</code> renders dates
- in textual form.
- </p><p>The output is a table one row per bug database and the following columns:</p><div class="table"><a name="listBugDatabaseInfoColumns"></a><p class="title"><b>Table 12.8. listBugDatabaseInfo Columns</b></p><div class="table-contents"><table summary="listBugDatabaseInfo Columns" border="1"><colgroup><col><col></colgroup><thead><tr><th align="left">Column</th><th align="left">Meaning</th></tr></thead><tbody><tr><td align="left">version</td><td align="left">version name</td></tr><tr><td align="left">time</td><td align="left">Release timestamp</td></tr><tr><td align="left">classes</td><td align="left">Number of classes analyzed</td></tr><tr><td align="left">NCSS</td><td align="left">Non Commenting Source Statements analyzed</td></tr><tr><td align="left">total</td><td align="left">Total number of warnings of all kinds</td></tr><tr><td align="left">high</td><td align="left">Total number of high priority warnings of all kinds</td></tr><tr><td align="left">medium</td><td align="left">Total number of medium/normal priority warnings of all kinds</td></tr><tr><td align="left">low</td><td align="left">Total number of low priority warnings of all kinds</td></tr><tr><td align="left">filename</td><td align="left">filename of database</td></tr></tbody></table></div></div><br class="table-break"></div></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="examples"></a>2. Examples</h2></div></div></div><div class="sect2" lang="en"><div class="titlepage"><div><div><h3 class="title"><a name="unixscriptsexamples"></a>2.1. Mining history using proveded shell scrips</h3></div></div></div><p>In all of the following, the commands are given in a directory that contains
-directories jdk1.6.0-b12, jdk1.6.0-b13, ..., jdk1.6.0-b60.</p><p>You can use the command:</p><pre class="screen">
-computeBugHistory jdk1.6.0-b* | filterBugs -bugPattern IL_ | mineBugHistory -formatDates
-</pre><p>to generate the following output:</p><pre class="screen">
-seq version time classes NCSS added newCode fixed removed retained dead active
-0 jdk1.6.0-b12 "Thu Nov 11 09:07:20 EST 2004" 13128 811569 0 4 0 0 0 0 4
-1 jdk1.6.0-b13 "Thu Nov 18 06:02:06 EST 2004" 13128 811570 0 0 0 0 4 0 4
-2 jdk1.6.0-b14 "Thu Dec 02 06:12:26 EST 2004" 13145 811786 0 0 2 0 2 0 2
-3 jdk1.6.0-b15 "Thu Dec 09 06:07:04 EST 2004" 13174 811693 0 0 1 0 1 2 1
-4 jdk1.6.0-b16 "Thu Dec 16 06:21:28 EST 2004" 13175 811715 0 0 0 0 1 3 1
-5 jdk1.6.0-b17 "Thu Dec 23 06:27:22 EST 2004" 13176 811974 0 0 0 0 1 3 1
-6 jdk1.6.0-b19 "Thu Jan 13 06:41:16 EST 2005" 13176 812011 0 0 0 0 1 3 1
-7 jdk1.6.0-b21 "Thu Jan 27 05:57:52 EST 2005" 13177 812173 0 0 0 0 1 3 1
-8 jdk1.6.0-b23 "Thu Feb 10 05:44:36 EST 2005" 13179 812188 0 0 0 0 1 3 1
-9 jdk1.6.0-b26 "Thu Mar 03 06:04:02 EST 2005" 13199 811770 0 0 0 0 1 3 1
-10 jdk1.6.0-b27 "Thu Mar 10 04:48:38 EST 2005" 13189 812440 0 0 0 0 1 3 1
-11 jdk1.6.0-b28 "Thu Mar 17 02:54:22 EST 2005" 13185 812056 0 0 0 0 1 3 1
-12 jdk1.6.0-b29 "Thu Mar 24 03:09:20 EST 2005" 13117 809468 0 0 0 0 1 3 1
-13 jdk1.6.0-b30 "Thu Mar 31 02:53:32 EST 2005" 13118 809501 0 0 0 0 1 3 1
-14 jdk1.6.0-b31 "Thu Apr 07 03:00:14 EDT 2005" 13117 809572 0 0 0 0 1 3 1
-15 jdk1.6.0-b32 "Thu Apr 14 02:56:56 EDT 2005" 13169 811096 0 0 0 0 1 3 1
-16 jdk1.6.0-b33 "Thu Apr 21 02:46:22 EDT 2005" 13187 811942 0 0 0 0 1 3 1
-17 jdk1.6.0-b34 "Thu Apr 28 02:49:00 EDT 2005" 13195 813488 0 1 0 0 1 3 2
-18 jdk1.6.0-b35 "Thu May 05 02:49:04 EDT 2005" 13457 829837 0 0 0 0 2 3 2
-19 jdk1.6.0-b36 "Thu May 12 02:59:46 EDT 2005" 13462 831278 0 0 0 0 2 3 2
-20 jdk1.6.0-b37 "Thu May 19 02:55:08 EDT 2005" 13464 831971 0 0 0 0 2 3 2
-21 jdk1.6.0-b38 "Thu May 26 03:08:16 EDT 2005" 13564 836565 0 0 0 0 2 3 2
-22 jdk1.6.0-b39 "Fri Jun 03 03:10:48 EDT 2005" 13856 849992 0 1 0 0 2 3 3
-23 jdk1.6.0-b40 "Thu Jun 09 03:30:28 EDT 2005" 15972 959619 0 2 0 0 3 3 5
-24 jdk1.6.0-b41 "Thu Jun 16 03:19:22 EDT 2005" 15972 959619 0 0 0 0 5 3 5
-25 jdk1.6.0-b42 "Fri Jun 24 03:38:54 EDT 2005" 15966 958581 0 0 0 0 5 3 5
-26 jdk1.6.0-b43 "Thu Jul 14 03:09:34 EDT 2005" 16041 960544 0 0 0 0 5 3 5
-27 jdk1.6.0-b44 "Thu Jul 21 03:05:54 EDT 2005" 16041 960547 0 0 0 0 5 3 5
-28 jdk1.6.0-b45 "Thu Jul 28 03:26:10 EDT 2005" 16037 960606 0 0 1 0 4 3 4
-29 jdk1.6.0-b46 "Thu Aug 04 03:02:48 EDT 2005" 15936 951355 0 0 0 0 4 4 4
-30 jdk1.6.0-b47 "Thu Aug 11 03:18:56 EDT 2005" 15964 952387 0 0 1 0 3 4 3
-31 jdk1.6.0-b48 "Thu Aug 18 08:10:40 EDT 2005" 15970 953421 0 0 0 0 3 5 3
-32 jdk1.6.0-b49 "Thu Aug 25 03:24:38 EDT 2005" 16048 958940 0 0 0 0 3 5 3
-33 jdk1.6.0-b50 "Thu Sep 01 01:52:40 EDT 2005" 16287 974937 1 0 0 0 3 5 4
-34 jdk1.6.0-b51 "Thu Sep 08 01:55:36 EDT 2005" 16362 979377 0 0 0 0 4 5 4
-35 jdk1.6.0-b52 "Thu Sep 15 02:04:08 EDT 2005" 16477 979399 0 0 0 0 4 5 4
-36 jdk1.6.0-b53 "Thu Sep 22 02:00:28 EDT 2005" 16019 957900 0 0 1 0 3 5 3
-37 jdk1.6.0-b54 "Thu Sep 29 01:54:34 EDT 2005" 16019 957900 0 0 0 0 3 6 3
-38 jdk1.6.0-b55 "Thu Oct 06 01:54:14 EDT 2005" 16051 959014 0 0 0 0 3 6 3
-39 jdk1.6.0-b56 "Thu Oct 13 01:54:12 EDT 2005" 16211 970835 0 0 0 0 3 6 3
-40 jdk1.6.0-b57 "Thu Oct 20 01:55:26 EDT 2005" 16279 971627 0 0 0 0 3 6 3
-41 jdk1.6.0-b58 "Thu Oct 27 01:56:30 EDT 2005" 16283 971945 0 0 0 0 3 6 3
-42 jdk1.6.0-b59 "Thu Nov 03 01:56:58 EST 2005" 16232 972193 0 0 0 0 3 6 3
-43 jdk1.6.0-b60 "Thu Nov 10 01:54:18 EST 2005" 16235 972346 0 0 0 0 3 6 3
-</pre><p>
-We could also generate that information directly, without creating an intermediate db.xml file, using the command
-</p><pre class="screen">
-computeBugHistory jdk1.6.0-b*/jre/lib/rt.xml | filterBugs -bugPattern IL_ db.xml | mineBugHistory -formatDates
-</pre><p>We can then use that information to display a graph showing the number of infinite recursive loops
-found by FindBugs in each build of Sun's JDK1.6.0. The blue area indicates the number of infinite
-recursive loops in that build, the red area above it indicates the number of infinite recursive loops that existed
-in some previous version but not in the current version (thus, the combined height of the red and blue areas
-is guaranteed to never decrease, and goes up whenever a new infinite recursive loop bug is introduced). The height
-of the red area is computed as the sum of the fixed, removed and dead values for each version.
-The reductions in builds 13 and 14 came after Sun was notified about the bugs found by FindBugs in the JDK.
- </p><div class="mediaobject"><img src="infiniteRecursiveLoops.png"></div><p>
-Given the db.xml file that contains the results for all the jdk1.6.0 builds, the following command will show the history of high and medium priority correctness warnings:
-</p><pre class="screen">
-filterBugs -priority M -category C db.xml | mineBugHistory -formatDates
-</pre><p>
-generating the table:
-</p><pre class="screen">
-seq version time classes NCSS added newCode fixed removed retained dead active
-0 jdk1.6.0-b12 "Thu Nov 11 09:07:20 EST 2004" 13128 811569 0 1075 0 0 0 0 1075
-1 jdk1.6.0-b13 "Thu Nov 18 06:02:06 EST 2004" 13128 811570 0 0 0 0 1075 0 1075
-2 jdk1.6.0-b14 "Thu Dec 02 06:12:26 EST 2004" 13145 811786 3 0 6 0 1069 0 1072
-3 jdk1.6.0-b15 "Thu Dec 09 06:07:04 EST 2004" 13174 811693 2 1 3 0 1069 6 1072
-4 jdk1.6.0-b16 "Thu Dec 16 06:21:28 EST 2004" 13175 811715 0 0 1 0 1071 9 1071
-5 jdk1.6.0-b17 "Thu Dec 23 06:27:22 EST 2004" 13176 811974 0 0 1 0 1070 10 1070
-6 jdk1.6.0-b19 "Thu Jan 13 06:41:16 EST 2005" 13176 812011 0 0 0 0 1070 11 1070
-7 jdk1.6.0-b21 "Thu Jan 27 05:57:52 EST 2005" 13177 812173 0 0 1 0 1069 11 1069
-8 jdk1.6.0-b23 "Thu Feb 10 05:44:36 EST 2005" 13179 812188 0 0 0 0 1069 12 1069
-9 jdk1.6.0-b26 "Thu Mar 03 06:04:02 EST 2005" 13199 811770 0 0 2 1 1066 12 1066
-10 jdk1.6.0-b27 "Thu Mar 10 04:48:38 EST 2005" 13189 812440 1 0 1 1 1064 15 1065
-11 jdk1.6.0-b28 "Thu Mar 17 02:54:22 EST 2005" 13185 812056 0 0 0 0 1065 17 1065
-12 jdk1.6.0-b29 "Thu Mar 24 03:09:20 EST 2005" 13117 809468 3 0 8 26 1031 17 1034
-13 jdk1.6.0-b30 "Thu Mar 31 02:53:32 EST 2005" 13118 809501 0 0 0 0 1034 51 1034
-14 jdk1.6.0-b31 "Thu Apr 07 03:00:14 EDT 2005" 13117 809572 0 0 0 0 1034 51 1034
-15 jdk1.6.0-b32 "Thu Apr 14 02:56:56 EDT 2005" 13169 811096 1 1 0 1 1033 51 1035
-16 jdk1.6.0-b33 "Thu Apr 21 02:46:22 EDT 2005" 13187 811942 3 0 2 1 1032 52 1035
-17 jdk1.6.0-b34 "Thu Apr 28 02:49:00 EDT 2005" 13195 813488 0 1 0 0 1035 55 1036
-18 jdk1.6.0-b35 "Thu May 05 02:49:04 EDT 2005" 13457 829837 0 36 2 0 1034 55 1070
-19 jdk1.6.0-b36 "Thu May 12 02:59:46 EDT 2005" 13462 831278 0 0 0 0 1070 57 1070
-20 jdk1.6.0-b37 "Thu May 19 02:55:08 EDT 2005" 13464 831971 0 1 1 0 1069 57 1070
-21 jdk1.6.0-b38 "Thu May 26 03:08:16 EDT 2005" 13564 836565 1 7 2 6 1062 58 1070
-22 jdk1.6.0-b39 "Fri Jun 03 03:10:48 EDT 2005" 13856 849992 6 39 5 0 1065 66 1110
-23 jdk1.6.0-b40 "Thu Jun 09 03:30:28 EDT 2005" 15972 959619 7 147 11 0 1099 71 1253
-24 jdk1.6.0-b41 "Thu Jun 16 03:19:22 EDT 2005" 15972 959619 0 0 0 0 1253 82 1253
-25 jdk1.6.0-b42 "Fri Jun 24 03:38:54 EDT 2005" 15966 958581 3 0 1 2 1250 82 1253
-26 jdk1.6.0-b43 "Thu Jul 14 03:09:34 EDT 2005" 16041 960544 5 11 15 8 1230 85 1246
-27 jdk1.6.0-b44 "Thu Jul 21 03:05:54 EDT 2005" 16041 960547 0 0 0 0 1246 108 1246
-28 jdk1.6.0-b45 "Thu Jul 28 03:26:10 EDT 2005" 16037 960606 19 0 2 0 1244 108 1263
-29 jdk1.6.0-b46 "Thu Aug 04 03:02:48 EDT 2005" 15936 951355 13 1 1 32 1230 110 1244
-30 jdk1.6.0-b47 "Thu Aug 11 03:18:56 EDT 2005" 15964 952387 163 8 7 20 1217 143 1388
-31 jdk1.6.0-b48 "Thu Aug 18 08:10:40 EDT 2005" 15970 953421 0 0 0 0 1388 170 1388
-32 jdk1.6.0-b49 "Thu Aug 25 03:24:38 EDT 2005" 16048 958940 1 11 1 0 1387 170 1399
-33 jdk1.6.0-b50 "Thu Sep 01 01:52:40 EDT 2005" 16287 974937 19 27 16 7 1376 171 1422
-34 jdk1.6.0-b51 "Thu Sep 08 01:55:36 EDT 2005" 16362 979377 1 15 3 0 1419 194 1435
-35 jdk1.6.0-b52 "Thu Sep 15 02:04:08 EDT 2005" 16477 979399 0 0 1 1 1433 197 1433
-36 jdk1.6.0-b53 "Thu Sep 22 02:00:28 EDT 2005" 16019 957900 13 12 16 20 1397 199 1422
-37 jdk1.6.0-b54 "Thu Sep 29 01:54:34 EDT 2005" 16019 957900 0 0 0 0 1422 235 1422
-38 jdk1.6.0-b55 "Thu Oct 06 01:54:14 EDT 2005" 16051 959014 1 4 7 0 1415 235 1420
-39 jdk1.6.0-b56 "Thu Oct 13 01:54:12 EDT 2005" 16211 970835 6 8 37 0 1383 242 1397
-40 jdk1.6.0-b57 "Thu Oct 20 01:55:26 EDT 2005" 16279 971627 0 0 0 0 1397 279 1397
-41 jdk1.6.0-b58 "Thu Oct 27 01:56:30 EDT 2005" 16283 971945 0 1 1 0 1396 279 1397
-42 jdk1.6.0-b59 "Thu Nov 03 01:56:58 EST 2005" 16232 972193 6 0 5 0 1392 280 1398
-43 jdk1.6.0-b60 "Thu Nov 10 01:54:18 EST 2005" 16235 972346 0 0 0 0 1398 285 1398
-44 jdk1.6.0-b61 "Thu Nov 17 01:58:42 EST 2005" 16202 971134 2 0 4 0 1394 285 1396
-</pre></div><div class="sect2" lang="en"><div class="titlepage"><div><div><h3 class="title"><a name="incrementalhistory"></a>2.2. Incremental history maintenance</h3></div></div></div><p>
-If db.xml contains the results of running findbugs over builds b12 - b60, we can update db.xml to include the results of analyzing b61 with the commands:
-</p><pre class="screen">
-computeBugHistory -output db.xml db.xml jdk1.6.0-b61/jre/lib/rt.xml
-</pre></div></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="antexample"></a>3. Ant example</h2></div></div></div><p>
-Here is a complete ant script example for both running findbugs and running a chain of data-mining tools afterward:
-</p><pre class="screen">
-
-<project name="analyze_asm_util" default="findbugs">
- <!-- findbugs task definition -->
- <property name="findbugs.home" value="/Users/ben/Documents/workspace/findbugs/findbugs" />
- <property name="jvmargs" value="-server -Xss1m -Xmx800m -Duser.language=en -Duser.region=EN -Dfindbugs.home=${findbugs.home}" />
-
- <path id="findbugs.lib">
- <fileset dir="${findbugs.home}/lib">
- <include name="findbugs-ant.jar"/>
- </fileset>
- </path>
-
- <taskdef name="findbugs" classname="edu.umd.cs.findbugs.anttask.FindBugsTask">
- <classpath refid="findbugs.lib" />
- </taskdef>
-
- <taskdef name="computeBugHistory" classname="edu.umd.cs.findbugs.anttask.ComputeBugHistoryTask">
- <classpath refid="findbugs.lib" />
- </taskdef>
-
- <taskdef name="setBugDatabaseInfo" classname="edu.umd.cs.findbugs.anttask.SetBugDatabaseInfoTask">
- <classpath refid="findbugs.lib" />
- </taskdef>
-
- <taskdef name="mineBugHistory" classname="edu.umd.cs.findbugs.anttask.MineBugHistoryTask">
- <classpath refid="findbugs.lib" />
- </taskdef>
-
- <!-- findbugs task definition -->
- <target name="findbugs">
- <antcall target="analyze" />
- <antcall target="mine" />
- </target>
-
- <!-- analyze task -->
- <target name="analyze">
- <!-- run findbugs against asm-util -->
- <findbugs home="${findbugs.home}"
- output="xml:withMessages"
- timeout="90000000"
- reportLevel="experimental"
- workHard="true"
- effort="max"
- adjustExperimental="true"
- jvmargs="${jvmargs}"
- failOnError="true"
- outputFile="out.xml"
- projectName="Findbugs"
- debug="false">
- <class location="asm-util-3.0.jar" />
- </findbugs>
- </target>
-
- <target name="mine">
-
- <!-- Set info to the latest analysis -->
- <setBugDatabaseInfo home="${findbugs.home}"
- withMessages="true"
- name="asm-util-3.0.jar"
- input="out.xml"
- output="out-rel.xml"/>
-
- <!-- Checking if history file already exists (out-hist.xml) -->
- <condition property="mining.historyfile.available">
- <available file="out-hist.xml"/>
- </condition>
- <condition property="mining.historyfile.notavailable">
- <not>
- <available file="out-hist.xml"/>
- </not>
- </condition>
-
- <!-- this target is executed if the history file do not exist (first run) -->
- <antcall target="history-init">
- <param name="data.file" value="out-rel.xml" />
- <param name="hist.file" value="out-hist.xml" />
- </antcall>
- <!-- else this one is executed -->
- <antcall target="history">
- <param name="data.file" value="out-rel.xml" />
- <param name="hist.file" value="out-hist.xml" />
- <param name="hist.summary.file" value="out-hist.txt" />
- </antcall>
- </target>
-
- <!-- Initializing history file -->
- <target name="history-init" if="mining.historyfile.notavailable">
- <copy file="${data.file}" tofile="${hist.file}" />
- </target>
-
- <!-- Computing bug history -->
- <target name="history" if="mining.historyfile.available">
- <!-- Merging ${data.file} into ${hist.file} -->
- <computeBugHistory home="${findbugs.home}"
- withMessages="true"
- output="${hist.file}">
- <dataFile name="${hist.file}"/>
- <dataFile name="${data.file}"/>
- </computeBugHistory>
-
- <!-- Compute history into ${hist.summary.file} -->
- <mineBugHistory home="${findbugs.home}"
- formatDates="true"
- noTabs="true"
- input="${hist.file}"
- output="${hist.summary.file}"/>
- </target>
-
-</project>
-
-</pre></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="rejarForAnalysis.html">Prev</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="license.html">Next</a></td></tr><tr><td width="40%" align="left" valign="top">Chapter 11. Using rejarForAnalysis </td><td width="20%" align="center"><a accesskey="h" href="index.html">Home</a></td><td width="40%" align="right" valign="top"> Chapter 13. License</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/manual/eclipse.html b/tools/findbugs-1.3.9/doc/manual/eclipse.html
deleted file mode 100644
index 63f0c34..0000000
--- a/tools/findbugs-1.3.9/doc/manual/eclipse.html
+++ /dev/null
@@ -1,70 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>Chapter 7. Using the FindBugs™ Eclipse plugin</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ Manual"><link rel="up" href="index.html" title="FindBugs™ Manual"><link rel="prev" href="anttask.html" title="Chapter 6. Using the FindBugs™ Ant task"><link rel="next" href="filter.html" title="Chapter 8. Filter Files"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">Chapter 7. Using the <span class="application">FindBugs</span>™ Eclipse plugin</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="anttask.html">Prev</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="filter.html">Next</a></td></tr></table><hr></div><div class="chapter" lang="en"><div class="titlepage"><div><div><h2 class="title"><a name="eclipse"></a>Chapter 7. Using the <span class="application">FindBugs</span>™ Eclipse plugin</h2></div></div></div><div class="toc"><p><b>Table of Contents</b></p><dl><dt><span class="sect1"><a href="eclipse.html#d0e1636">1. Requirements</a></span></dt><dt><span class="sect1"><a href="eclipse.html#d0e1644">2. Installation</a></span></dt><dt><span class="sect1"><a href="eclipse.html#d0e1691">3. Using the Plugin</a></span></dt><dt><span class="sect1"><a href="eclipse.html#d0e1722">4. Troubleshooting</a></span></dt></dl></div><p>
-The FindBugs Eclipse plugin allows <span class="application">FindBugs</span> to be used within
-the <a href="http://www.eclipse.org/" target="_top">Eclipse</a> IDE.
-The FindBugs Eclipse plugin was generously contributed by Peter Friese.
-Phil Crosby and Andrei Loskutov contributed major improvements
-to the plugin.
-</p><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1636"></a>1. Requirements</h2></div></div></div><p>
-To use the <span class="application">FindBugs</span> Plugin for Eclipse, you need Eclipse 3.3 or later,
-and JRE/JDK 1.5 or later.
-</p></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1644"></a>2. Installation</h2></div></div></div><p>
- We provide update sites that allow you to automatically install FindBugs into Eclipse and also query and install updates.
- There are three different update sites</p><div class="variablelist"><p class="title"><b>FindBugs Eclipse update sites</b></p><dl><dt><span class="term"><a href="http://findbugs.cs.umd.edu/eclipse/" target="_top">http://findbugs.cs.umd.edu/eclipse/</a></span></dt><dd><p>
- Only provides official releases of FindBugs.
- </p></dd><dt><span class="term"><a href="http://findbugs.cs.umd.edu/eclipse-candidate/" target="_top">http://findbugs.cs.umd.edu/eclips-candidate/</a></span></dt><dd><p>
- Provides official releases and release candidates of FindBugs.
- </p></dd><dt><span class="term"><a href="http://findbugs.cs.umd.edu/eclipse-daily/" target="_top">http://findbugs.cs.umd.edu/eclipse-daily/</a></span></dt><dd><p>
- Provides the daily build of FindBugs. No testing other than that it compiles.
- </p></dd></dl></div><p>You can also manually
-download the plugin from the following link:
-<a href="http://prdownloads.sourceforge.net/findbugs/edu.umd.cs.findbugs.plugin.eclipse_1.3.9.20090821.zip?download" target="_top">http://prdownloads.sourceforge.net/findbugs/edu.umd.cs.findbugs.plugin.eclipse_1.3.9.20090821.zip?download</a>.
-Extract it in Eclipse's "plugins" subdirectory.
-(So <eclipse_install_dir>/plugins/edu.umd.cs.findbugs.plugin.eclipse_1.3.9.20090821/findbugs.png
-should be the path to the <span class="application">FindBugs</span> logo.)
-
-</p><p>
-Once the plugin is extracted, start Eclipse and choose
-<span class="guimenu">Help</span> → <span class="guimenuitem">About Eclipse Platform</span> → <span class="guimenuitem">Plug-in Details</span>.
-You should find a plugin called "FindBugs Plug-in" provided by "FindBugs Project".
-</p></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1691"></a>3. Using the Plugin</h2></div></div></div><p>
-To get started, right click on a Java project in Package Explorer,
-and select the option labeled "Find Bugs".
-<span class="application">FindBugs</span> will run, and problem markers (displayed in source
-windows, and also in the Eclipse Problems view) will point to
-locations in your code which have been identified as potential instances
-of bug patterns.
-</p><p>
-You can also run <span class="application">FindBugs</span> on existing java archives (jar, ear, zip, war etc). Simply
-create an empty Java project and attach archives to the project classpath. Having that, you
-can now right click the archive node in Package Explorer and select the option labeled
-"Find Bugs". If you additionally configure the source code locations for the binaries,
-<span class="application">FindBugs</span> will also link the generated warnings to the right source files.
-</p><p>
-You may customize how <span class="application">FindBugs</span> runs by opening the Properties
-dialog for a Java project, and choosing the "Findbugs" property page.
-Options you may choose include:
-</p><div class="itemizedlist"><ul type="disc"><li><p>
- Enable or disable the "Run FindBugs Automatically" checkbox.
- When enabled, FindBugs will run every time you modify a Java class
- within the project.
- </p></li><li><p>
- Choose minimum warning priority and enabled bug categories.
- These options will choose which warnings are shown.
- For example, if you select the "Medium" warning priority,
- only Medium and High priority warnings will be shown.
- Similarly, if you uncheck the "Style" checkbox, no warnings
- in the Style category will be displayed.
- </p></li><li><p>
- Select detectors. The table allows you to select which detectors
- you want to enable for your project.
- </p></li></ul></div></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1722"></a>4. Troubleshooting</h2></div></div></div><p>
-The <span class="application">FindBugs</span> Eclipse plugin is still experimental. This section
-lists common problems with the plugin and (if known) how to resolve them.
-</p><div class="itemizedlist"><ul type="disc"><li><p>
- If you do not see any <span class="application">FindBugs</span> problem markers (in your source
- windows or in the Problems View), you may need to change your
- Problems View filter settings. See
- <a href="http://findbugs.sourceforge.net/FAQ.html#q7" target="_top">http://findbugs.sourceforge.net/FAQ.html#q7</a> for more information.
- </p></li></ul></div></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="anttask.html">Prev</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="filter.html">Next</a></td></tr><tr><td width="40%" align="left" valign="top">Chapter 6. Using the <span class="application">FindBugs</span>™ <span class="application">Ant</span> task </td><td width="20%" align="center"><a accesskey="h" href="index.html">Home</a></td><td width="40%" align="right" valign="top"> Chapter 8. Filter Files</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/manual/filter.html b/tools/findbugs-1.3.9/doc/manual/filter.html
deleted file mode 100644
index 11b94c6..0000000
--- a/tools/findbugs-1.3.9/doc/manual/filter.html
+++ /dev/null
@@ -1,321 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>Chapter 8. Filter Files</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ Manual"><link rel="up" href="index.html" title="FindBugs™ Manual"><link rel="prev" href="eclipse.html" title="Chapter 7. Using the FindBugs™ Eclipse plugin"><link rel="next" href="analysisprops.html" title="Chapter 9. Analysis Properties"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">Chapter 8. Filter Files</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="eclipse.html">Prev</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="analysisprops.html">Next</a></td></tr></table><hr></div><div class="chapter" lang="en"><div class="titlepage"><div><div><h2 class="title"><a name="filter"></a>Chapter 8. Filter Files</h2></div></div></div><div class="toc"><p><b>Table of Contents</b></p><dl><dt><span class="sect1"><a href="filter.html#d0e1752">1. Introduction to Filter Files</a></span></dt><dt><span class="sect1"><a href="filter.html#d0e1802">2. Types of Match clauses</a></span></dt><dt><span class="sect1"><a href="filter.html#d0e1995">3. Java element name matching</a></span></dt><dt><span class="sect1"><a href="filter.html#d0e2020">4. Caveats</a></span></dt><dt><span class="sect1"><a href="filter.html#d0e2050">5. Examples</a></span></dt><dt><span class="sect1"><a href="filter.html#d0e2103">6. Complete Example</a></span></dt></dl></div><p>
-Filter files may be used to include or exclude bug reports for particular classes
-and methods. This chapter explains how to use filter files.
-
-</p><div class="note" style="margin-left: 0.5in; margin-right: 0.5in;"><table border="0" summary="Note: Planned Features"><tr><td rowspan="2" align="center" valign="top" width="25"><img alt="[Note]" src="note.png"></td><th align="left">Planned Features</th></tr><tr><td align="left" valign="top"><p>
- Filters are currently only supported by the Command Line interface.
- Eventually, filter support will be added to the GUI.
-</p></td></tr></table></div><p>
-</p><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1752"></a>1. Introduction to Filter Files</h2></div></div></div><p>
-Conceptually, a filter matches bug instances against a set of criteria.
-By defining a filter, you can select bug instances for special treatment;
-for example, to exclude or include them in a report.
-</p><p>
-A filter file is an <a href="http://www.w3.org/XML/" target="_top">XML</a> document with a top-level <code class="literal">FindBugsFilter</code> element
-which has some number of <code class="literal">Match</code> elements as children. Each <code class="literal">Match</code>
-element represents a predicate which is applied to generated bug instances.
-Usually, a filter will be used to exclude bug instances. For example:
-
-</p><pre class="screen">
-<code class="prompt">$ </code><span><strong class="command">findbugs -textui -exclude <em class="replaceable"><code>myExcludeFilter.xml</code></em> <em class="replaceable"><code>myApp.jar</code></em></strong></span>
-</pre><p>
-
-However, a filter could also be used to select bug instances to specifically
-report:
-
-</p><pre class="screen">
-<code class="prompt">$ </code><span><strong class="command">findbugs -textui -include <em class="replaceable"><code>myIncludeFilter.xml</code></em> <em class="replaceable"><code>myApp.jar</code></em></strong></span>
-</pre><p>
-</p><p>
-<code class="literal">Match</code> elements contain children, which are conjuncts of the predicate.
-In other words, each of the children must be true for the predicate to be true.
-</p></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1802"></a>2. Types of Match clauses</h2></div></div></div><div class="variablelist"><dl><dt><span class="term"><code class="literal"><Bug></code></span></dt><dd><p>
- This element specifies a particular bug pattern or patterns to match.
- The <code class="literal">pattern</code> attribute is a comma-separated list of
- bug pattern types. You can find the bug pattern types for particular
- warnings by looking at the output produced by the <span><strong class="command">-xml</strong></span>
- output option (the <code class="literal">type</code> attribute of <code class="literal">BugInstance</code>
- elements), or from the <a href="../bugDescriptions.html" target="_top">bug
- descriptions document</a>.
- </p><p>
- For more coarse-grained matching, use <code class="literal">code</code> attribute. It takes
- a comma-separated list of bug abbreviations. For most-coarse grained matching use
- <code class="literal">category</code> attriute, that takes a comma separated list of bug category names:
- <code class="literal">CORRECTNESS</code>, <code class="literal">MT_CORRECTNESS</code>,
- <code class="literal">BAD_PRACTICICE</code>, <code class="literal">PERFORMANCE</code>, <code class="literal">STYLE</code>.
- </p><p>
- If more than one of the attributes mentioned above are specified on the same
- <code class="literal"><Bug></code> element, all bug patterns that match either one of specified
- pattern names, or abreviations, or categories will be matched.
- </p><p>
- As a backwards compatibility measure, <code class="literal"><BugPattern></code> and
- <code class="literal"><BugCode></code> elements may be used instead of
- <code class="literal"><Bug></code> element. Each of these uses a
- <code class="literal">name</code> attribute for specifying accepted values list. Support for these
- elements may be removed in a future release.
- </p></dd><dt><span class="term"><code class="literal"><Priority></code></span></dt><dd><p>
- This element matches warnings with a particular priority.
- The <code class="literal">value</code> attribute should be an integer value:
- 1 to match high-priority warnings, 2 to match medium-priority warnings,
- or 3 to match low-priority warnings.
- </p></dd><dt><span class="term"><code class="literal"><Package></code></span></dt><dd><p>
- This element matches warnings associated with classes within the package specified
- using <code class="literal">name</code> attribute. Nested packages are not included (along the
- lines of Java import statement). However matching multiple packages can be achieved
- easily using regex name match.
- </p></dd><dt><span class="term"><code class="literal"><Class></code></span></dt><dd><p>
- This element matches warnings associated with a particular class. The
- <code class="literal">name</code> attribute is used to specify the exact or regex match pattern
- for the class name.
- </p><p>
- As a backward compatibility measure, instead of element of this type, you can use
- <code class="literal">class</code> attribute on a <code class="literal">Match</code> element to specify
- exact an class name or <code class="literal">classregex</code> attribute to specify a regular
- expression to match the class name against.
- </p><p>
- If the <code class="literal">Match</code> element contains neither a <code class="literal">Class</code> element,
- nor a <code class="literal">class</code> / <code class="literal">classregex</code> attribute, the predicate will apply
- to all classes. Such predicate is likely to match more bug instances than you want, unless it is
- refined further down with apropriate method or field predicates.
- </p></dd><dt><span class="term"><code class="literal"><Method></code></span></dt><dd><p>This element specifies a method. The <code class="literal">name</code> is used to specify
- the exact or regex match pattern for the method name.
- The <code class="literal">params</code> attribute is a comma-separated list
- of the types of the method's parameters. The <code class="literal">returns</code> attribute is
- the method's return type. In <code class="literal">params</code> and <code class="literal">returns</code>, class names
- must be fully qualified. (E.g., "java.lang.String" instead of just
- "String".) If one of the latter attributes is specified the other is required for creating a method signature.
- Note that you can provide either <code class="literal">name</code> attribute or <code class="literal">params</code>
- and <code class="literal">returns</code> attributes or all three of them. This way you can provide various kinds of
- name and signature based matches.
- </p></dd><dt><span class="term"><code class="literal"><Field></code></span></dt><dd><p>This element specifies a field. The <code class="literal">name</code> attribute is is used to specify
- the exact or regex match pattern for the field name. You can also filter fields according to their signature -
- use <code class="literal">type</code> attribute to specify fully qualified type of the field. You can specify eiter or both
- of these attributes in order to perform name / signature based matches.
- </p></dd><dt><span class="term"><code class="literal"><Local></code></span></dt><dd><p>This element specifies a local variable. The <code class="literal">name</code> attribute is is used to specify
- the exact or regex match pattern for the local variable name. Local variables are variables defined within a method.
- </p></dd><dt><span class="term"><code class="literal"><Or></code></span></dt><dd><p>
- This element combines <code class="literal">Match</code> clauses as disjuncts. I.e., you can put two
- <code class="literal">Method</code> elements in an <code class="literal">Or</code> clause in order to match either method.
- </p></dd></dl></div></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1995"></a>3. Java element name matching</h2></div></div></div><p>
-If the <code class="literal">name</code> attribute of <code class="literal">Class</code>, <code class="literal">Method</code> or
-<code class="literal">Field</code> starts with the ~ character the rest of attribute content is interpreted as
-a Java regular expression that is matched against the names of the Java element in question.
-</p><p>
-Note that the pattern is matched against whole element name and therefore .* clauses need to be used
-at pattern beginning and/or end to perform substring matching.
-</p><p>
-See <a href="http://java.sun.com/j2se/1.5.0/docs/api/java/util/regex/Pattern.html" target="_top"><code class="literal">java.util.regex.Pattern</code></a>
-documentation for pattern syntax.
-</p></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e2020"></a>4. Caveats</h2></div></div></div><p>
-<code class="literal">Match</code> clauses can only match information that is actually contained in the
-bug instances. Every bug instance has a class, so in general, excluding
-bugs by class will work.
-</p><p>
-Some bug instances have two (or more) classes. For example, the DE (dropped exception)
-bugs report both the class containing the method where the dropped exception
-happens, and the class which represents the type of the dropped exception.
-Only the <span class="emphasis"><em>first</em></span> (primary) class is matched against <code class="literal">Match</code> clauses.
-So, for example, if you want to suppress IC (initialization circularity)
-reports for classes "com.foobar.A" and "com.foobar.B", you would use
-two <code class="literal">Match</code> clauses:
-
-</p><pre class="programlisting">
- <Match>
- <Class name="com.foobar.A" />
- <Bug code="IC" />
- </Match>
-
- <Match>
- <Class name="com.foobar.B" />
- <Bug code="IC" />
- </Match>
-</pre><p>
-
-By explicitly matching both classes, you ensure that the IC bug instance will be
-matched regardless of which class involved in the circularity happens to be
-listed first in the bug instance. (Of course, this approach might accidentally
-supress circularities involving "com.foobar.A" or "com.foobar.B" and a third
-class.)
-</p><p>
-Many kinds of bugs report what method they occur in. For those bug instances,
-you can put <code class="literal">Method</code> clauses in the <code class="literal">Match</code> element and they should work
-as expected.
-</p></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e2050"></a>5. Examples</h2></div></div></div><p>
- 1. Match all bug reports for a class.
-
-</p><pre class="programlisting">
-
- <Match>
- <Class name="com.foobar.MyClass" />
- </Match>
-
-</pre><p>
-
-</p><p>
- 2. Match certain tests from a class by specifying their abbreviations.
-</p><pre class="programlisting">
-
- <Match>
- <Class name="com.foobar.MyClass"/ >
- <Bug code="DE,UrF,SIC" />
- </Match>
-
-</pre><p>
-</p><p>
- 3. Match certain tests from all classes by specifying their abbreviations.
-
-</p><pre class="programlisting">
-
- <Match>
- <Bug code="DE,UrF,SIC" />
- </Match>
-
-</pre><p>
-</p><p>
- 4. Match certain tests from all classes by specifying their category.
-
-</p><pre class="programlisting">
-
- <Match>
- <Bug category="PERFORMANCE" />
- </Match>
-
-</pre><p>
-</p><p>
- 5. Match bug types from specified methods of a class by their abbreviations.
-
-</p><pre class="programlisting">
-
- <Match>
- <Class name="com.foobar.MyClass" />
- <Or>
- <Method name="frob" params="int,java.lang.String" returns="void" />
- <Method name="blat" params="" returns="boolean" />
- </Or>
- <Bug code="DC" />
- </Match>
-
-</pre><p>
-</p><p>
- 6. Match a particular bug pattern in a particular method.
-
-</p><pre class="programlisting">
-
- <!-- A method with an open stream false positive. -->
- <Match>
- <Class name="com.foobar.MyClass" />
- <Method name="writeDataToFile" />
- <Bug pattern="OS_OPEN_STREAM" />
- </Match>
-
-</pre><p>
-</p><p>
- 7. Match a particular bug pattern with a given priority in a particular method.
-
-</p><pre class="programlisting">
-
- <!-- A method with a dead local store false positive (medium priority). -->
- <Match>
- <Class name="com.foobar.MyClass" />
- <Method name="someMethod" />
- <Bug pattern="DLS_DEAD_LOCAL_STORE" />
- <Priority value="2" />
- </Match>
-
-</pre><p>
-</p><p>
- 8. Match minor bugs introduced by AspectJ compiler (you are probably not interested in these unless
- you are an AspectJ developer).
-
-</p><pre class="programlisting">
-
- <Match>
- <Class name="~.*\$AjcClosure\d+" />
- <Bug pattern="DLS_DEAD_LOCAL_STORE" />
- <Method name="run" />
- </Match>
- <Match>
- <Bug pattern="UUF_UNUSED_FIELD" />
- <Field name="~ajc\$.*" />
- </Match>
-
-</pre><p>
-</p><p>
- 9. Match bugs in specific parts of the code base
-
-</p><pre class="programlisting">
-
- <!-- match unused fields warnings in Messages classes in all packages -->
- <Match>
- <Class name="~.*\.Messages" />
- <Bug code="UUF" />
- </Match>
- <!-- match mutable statics warnings in all internal packages -->
- <Match>
- <Package name="~.*\.internal" />
- <Bug code="MS" />
- </Match>
- <!-- match anonymoous inner classes warnings in ui package hierarchy -->
- <Match>
- <Package name="~com\.foobar\.fooproject\.ui.*" />
- <Bug pattern="SIC_INNER_SHOULD_BE_STATIC_ANON" />
- </Match>
-
-</pre><p>
-</p><p>
- 10. Match bugs on fieds or methods with specific signatures
-</p><pre class="programlisting">
-
- <!-- match System.exit(...) usage warnings in void main(String[]) methods in all classes -->
- <Match>
- <Method returns="void" name="main" params="java.lang.String[]" />
- <Method pattern="DM_EXIT" />
- </Match>
- <!-- match UuF warnings on fields of type com.foobar.DebugInfo on all classes -->
- <Match>
- <Field type="com.foobar.DebugInfo" />
- <Bug code="UuF" />
- </Match>
-
-</pre><p>
-
-</p></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e2103"></a>6. Complete Example</h2></div></div></div><pre class="programlisting">
-
-<FindBugsFilter>
- <Match>
- <Class name="com.foobar.ClassNotToBeAnalyzed" />
- </Match>
-
- <Match>
- <Class name="com.foobar.ClassWithSomeBugsMatched" />
- <Bug code="DE,UrF,SIC" />
- </Match>
-
- <!-- Match all XYZ violations. -->
- <Match>
- <Bug code="XYZ" />
- </Match>
-
- <!-- Match all doublecheck violations in these methods of "AnotherClass". -->
- <Match>
- <Class name="com.foobar.AnotherClass" />
- <Or>
- <Method name="nonOverloadedMethod" />
- <Method name="frob" params="int,java.lang.String" returns="void" />
- <Method name="blat" params="" returns="boolean" />
- </Or>
- <Bug code="DC" />
- </Match>
-
- <!-- A method with a dead local store false positive (medium priority). -->
- <Match>
- <Class name="com.foobar.MyClass" />
- <Method name="someMethod" />
- <Bug pattern="DLS_DEAD_LOCAL_STORE" />
- <Priority value="2" />
- </Match>
-</FindBugsFilter>
-
-</pre></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="eclipse.html">Prev</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="analysisprops.html">Next</a></td></tr><tr><td width="40%" align="left" valign="top">Chapter 7. Using the <span class="application">FindBugs</span>™ Eclipse plugin </td><td width="20%" align="center"><a accesskey="h" href="index.html">Home</a></td><td width="40%" align="right" valign="top"> Chapter 9. Analysis Properties</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/manual/gui.html b/tools/findbugs-1.3.9/doc/manual/gui.html
deleted file mode 100644
index 621371b..0000000
--- a/tools/findbugs-1.3.9/doc/manual/gui.html
+++ /dev/null
@@ -1,68 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>Chapter 5. Using the FindBugs GUI</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ Manual"><link rel="up" href="index.html" title="FindBugs™ Manual"><link rel="prev" href="running.html" title="Chapter 4. Running FindBugs™"><link rel="next" href="anttask.html" title="Chapter 6. Using the FindBugs™ Ant task"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">Chapter 5. Using the <span class="application">FindBugs</span> GUI</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="running.html">Prev</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="anttask.html">Next</a></td></tr></table><hr></div><div class="chapter" lang="en"><div class="titlepage"><div><div><h2 class="title"><a name="gui"></a>Chapter 5. Using the <span class="application">FindBugs</span> GUI</h2></div></div></div><div class="toc"><p><b>Table of Contents</b></p><dl><dt><span class="sect1"><a href="gui.html#d0e1087">1. Creating a Project</a></span></dt><dt><span class="sect1"><a href="gui.html#d0e1129">2. Running the Analysis</a></span></dt><dt><span class="sect1"><a href="gui.html#d0e1134">3. Browsing Results</a></span></dt><dt><span class="sect1"><a href="gui.html#d0e1149">4. Saving and Opening</a></span></dt></dl></div><p>
- This chapter describes how to use the <span class="application">FindBugs</span> graphical user interface (GUI).
- </p><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1087"></a>1. Creating a Project</h2></div></div></div><p>
-After you have started <span class="application">FindBugs</span> using the <span><strong class="command">findbugs</strong></span> command,
-choose the <span class="guimenu">File</span> → <span class="guimenuitem">New Project</span>
-menu item. You will see a dialog which looks like this:
-</p><div class="mediaobject"><img src="project-dialog.png"></div><p>
-</p><p>
-Use the "Add" button next to the "Class archives and directories to analyze" text field to select a Java archive
-file (zip, jar, ear, or war file) or directory containing java classes to analyze for bugs. You may add multiple
-archives/directories.
-</p><p>
-You can also add the source directories which contain
-the source code for the Java archives you are analyzing. This will enable
-<span class="application">FindBugs</span> to highlight the source code which contains a possible error.
-The source directories you add should be the roots of the Java
-package hierarchy. For example, if your application is contained in the
-<code class="varname">org.foobar.myapp</code> package, you should add the
-parent directory of the <code class="filename">org</code> directory
-to the source directory list for the project.
-</p><p>
-Another optional step is to add additional Jar files or directories as
-"Auxiliary classpath locations" entries. You should do this if the archives and directories you are analyzing
-have references to other classes which are not included in the analyzed
-archives/directories and are not in the standard runtime classpath. Some of the bug
-pattern detectors in <span class="application">FindBugs</span> make use of class hierarchy information,
-so you will get more accurate results if the entire class hierarchy is
-available which <span class="application">FindBugs</span> performs its analysis.
-</p></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1129"></a>2. Running the Analysis</h2></div></div></div><p>
-Once you have added all of the archives, directories, and source directories,
-click the "Finish" button to analyze the classes contained in the
-Jar files. Note that for a very large program on an older computer,
-this may take quite a while (tens of minutes). A recent computer with
-ample memory will typically be able to analyze a large program in only a
-few minutes.
-</p></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1134"></a>3. Browsing Results</h2></div></div></div><p>
-When the analysis completes, you will see a screen like the following:
-</p><div class="mediaobject"><img src="example-details.png"></div><p>
-</p><p>
-The upper left-hand pane of the window shows the bug tree; this is a hierarchical
-representation of all of the potential bugs detected in the analyzed
-Jar files.
-</p><p>
-When you select a particular bug instance in the top pane, you will
-see a description of the bug in the "Details" tab of the bottom pane.
-In addition, the source code pane on the upper-right will show the
-program source code where the potential bug occurs, if source is available.
-In the above example, the bug is a stream object that is not closed. The
-source code window highlights the line where the stream object is created.
-</p><p>
-You may add a textual annotations to bug instances. To do so, type them
-into the text box just below the hierarchical view. You can type any
-information which you would like to record. When you load and save bug
-results files, the annotations are preserved.
-</p></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e1149"></a>4. Saving and Opening</h2></div></div></div><p>
-You may use the <span class="guimenu">File</span> → <span class="guimenuitem">Save as...</span>
-menu option to save your work. To save your work, including the jar
-file lists you specified and all bug results, choose
-"FindBugs analysis results (.xml)" from the drop-down list in the
-"Save as..." dialog. There are also options for saving just the jar
-file lists ("FindBugs project file (.fbp)") or just the results
-("FindBugs analysis file (.fba)").
-A saved file may be loaded with the
-<span class="guimenu">File</span> → <span class="guimenuitem">Open...</span>
-menu option.
-</p></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="running.html">Prev</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="anttask.html">Next</a></td></tr><tr><td width="40%" align="left" valign="top">Chapter 4. Running <span class="application">FindBugs</span>™ </td><td width="20%" align="center"><a accesskey="h" href="index.html">Home</a></td><td width="40%" align="right" valign="top"> Chapter 6. Using the <span class="application">FindBugs</span>™ <span class="application">Ant</span> task</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/manual/index.html b/tools/findbugs-1.3.9/doc/manual/index.html
deleted file mode 100644
index 4547adb..0000000
--- a/tools/findbugs-1.3.9/doc/manual/index.html
+++ /dev/null
@@ -1,10 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>FindBugs™ Manual</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ Manual"><link rel="next" href="introduction.html" title="Chapter 1. Introduction"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center"><span class="application">FindBugs</span>™ Manual</th></tr><tr><td width="20%" align="left"> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="introduction.html">Next</a></td></tr></table><hr></div><div class="book" lang="en"><div class="titlepage"><div><div><h1 class="title"><a name="findbugs-manual"></a><span class="application">FindBugs</span>™ Manual</h1></div><div><div class="authorgroup"><div class="author"><h3 class="author"><span class="firstname">David</span> <span class="othername">H.</span> <span class="surname">Hovemeyer</span></h3></div><div class="author"><h3 class="author"><span class="firstname">William</span> <span class="othername">W.</span> <span class="surname">Pugh</span></h3></div></div></div><div><p class="copyright">Copyright © 2003, 2004, 2005, 2006, 2008 University of Maryland</p></div><div><div class="legalnotice"><a name="d0e35"></a><p>
-This manual is licensed under the Creative Commons Attribution-NonCommercial-ShareAlike License.
-To view a copy of this license, visit
-<a href="http://creativecommons.org/licenses/by-nc-sa/1.0/" target="_top">http://creativecommons.org/licenses/by-nc-sa/1.0/</a>
-or send a letter to Creative Commons, 559 Nathan Abbott Way, Stanford, California 94305, USA.
-</p><p>
-The name FindBugs and the FindBugs logo are trademarked by the University of Maryland.
-</p></div></div><div><p class="pubdate">16:39:49 EDT, 21 August, 2009</p></div></div><hr></div><div class="toc"><p><b>Table of Contents</b></p><dl><dt><span class="chapter"><a href="introduction.html">1. Introduction</a></span></dt><dd><dl><dt><span class="sect1"><a href="introduction.html#d0e75">1. Requirements</a></span></dt></dl></dd><dt><span class="chapter"><a href="installing.html">2. Installing <span class="application">FindBugs</span>™</a></span></dt><dd><dl><dt><span class="sect1"><a href="installing.html#d0e106">1. Extracting the Distribution</a></span></dt></dl></dd><dt><span class="chapter"><a href="building.html">3. Building <span class="application">FindBugs</span>™ from Source</a></span></dt><dd><dl><dt><span class="sect1"><a href="building.html#d0e181">1. Prerequisites</a></span></dt><dt><span class="sect1"><a href="building.html#d0e270">2. Extracting the Source Distribution</a></span></dt><dt><span class="sect1"><a href="building.html#d0e283">3. Modifying <code class="filename">local.properties</code></a></span></dt><dt><span class="sect1"><a href="building.html#d0e341">4. Running <span class="application">Ant</span></a></span></dt><dt><span class="sect1"><a href="building.html#d0e435">5. Running <span class="application">FindBugs</span>™ from a source directory</a></span></dt></dl></dd><dt><span class="chapter"><a href="running.html">4. Running <span class="application">FindBugs</span>™</a></span></dt><dd><dl><dt><span class="sect1"><a href="running.html#d0e473">1. Quick Start</a></span></dt><dt><span class="sect1"><a href="running.html#d0e511">2. Executing <span class="application">FindBugs</span></a></span></dt><dt><span class="sect1"><a href="running.html#commandLineOptions">3. Command-line Options</a></span></dt></dl></dd><dt><span class="chapter"><a href="gui.html">5. Using the <span class="application">FindBugs</span> GUI</a></span></dt><dd><dl><dt><span class="sect1"><a href="gui.html#d0e1087">1. Creating a Project</a></span></dt><dt><span class="sect1"><a href="gui.html#d0e1129">2. Running the Analysis</a></span></dt><dt><span class="sect1"><a href="gui.html#d0e1134">3. Browsing Results</a></span></dt><dt><span class="sect1"><a href="gui.html#d0e1149">4. Saving and Opening</a></span></dt></dl></dd><dt><span class="chapter"><a href="anttask.html">6. Using the <span class="application">FindBugs</span>™ <span class="application">Ant</span> task</a></span></dt><dd><dl><dt><span class="sect1"><a href="anttask.html#d0e1200">1. Installing the <span class="application">Ant</span> task</a></span></dt><dt><span class="sect1"><a href="anttask.html#d0e1238">2. Modifying build.xml</a></span></dt><dt><span class="sect1"><a href="anttask.html#d0e1309">3. Executing the task</a></span></dt><dt><span class="sect1"><a href="anttask.html#d0e1334">4. Parameters</a></span></dt></dl></dd><dt><span class="chapter"><a href="eclipse.html">7. Using the <span class="application">FindBugs</span>™ Eclipse plugin</a></span></dt><dd><dl><dt><span class="sect1"><a href="eclipse.html#d0e1636">1. Requirements</a></span></dt><dt><span class="sect1"><a href="eclipse.html#d0e1644">2. Installation</a></span></dt><dt><span class="sect1"><a href="eclipse.html#d0e1691">3. Using the Plugin</a></span></dt><dt><span class="sect1"><a href="eclipse.html#d0e1722">4. Troubleshooting</a></span></dt></dl></dd><dt><span class="chapter"><a href="filter.html">8. Filter Files</a></span></dt><dd><dl><dt><span class="sect1"><a href="filter.html#d0e1752">1. Introduction to Filter Files</a></span></dt><dt><span class="sect1"><a href="filter.html#d0e1802">2. Types of Match clauses</a></span></dt><dt><span class="sect1"><a href="filter.html#d0e1995">3. Java element name matching</a></span></dt><dt><span class="sect1"><a href="filter.html#d0e2020">4. Caveats</a></span></dt><dt><span class="sect1"><a href="filter.html#d0e2050">5. Examples</a></span></dt><dt><span class="sect1"><a href="filter.html#d0e2103">6. Complete Example</a></span></dt></dl></dd><dt><span class="chapter"><a href="analysisprops.html">9. Analysis Properties</a></span></dt><dt><span class="chapter"><a href="annotations.html">10. Annotations</a></span></dt><dt><span class="chapter"><a href="rejarForAnalysis.html">11. Using rejarForAnalysis</a></span></dt><dt><span class="chapter"><a href="datamining.html">12. Data mining of bugs with <span class="application">FindBugs</span>™</a></span></dt><dd><dl><dt><span class="sect1"><a href="datamining.html#commands">1. Commands</a></span></dt><dt><span class="sect1"><a href="datamining.html#examples">2. Examples</a></span></dt><dt><span class="sect1"><a href="datamining.html#antexample">3. Ant example</a></span></dt></dl></dd><dt><span class="chapter"><a href="license.html">13. License</a></span></dt><dt><span class="chapter"><a href="acknowledgments.html">14. Acknowledgments</a></span></dt><dd><dl><dt><span class="sect1"><a href="acknowledgments.html#d0e3476">1. Contributors</a></span></dt><dt><span class="sect1"><a href="acknowledgments.html#d0e3599">2. Software Used</a></span></dt></dl></dd></dl></div><div class="list-of-tables"><p><b>List of Tables</b></p><dl><dt>9.1. <a href="analysisprops.html#analysisproptable">Configurable Analysis Properties</a></dt><dt>12.1. <a href="datamining.html#computeBugHistoryTable">Options for computeBugHistory command</a></dt><dt>12.2. <a href="datamining.html#filterOptionsTable">Options for filterBugs command</a></dt><dt>12.3. <a href="datamining.html#mineBugHistoryOptionsTable">Options for mineBugHistory command</a></dt><dt>12.4. <a href="datamining.html#mineBugHistoryColumns">Columns in mineBugHistory output</a></dt><dt>12.5. <a href="datamining.html#defectDensityColumns">Columns in defectDensity output</a></dt><dt>12.6. <a href="datamining.html#convertXmlToTextTable">Options for convertXmlToText command</a></dt><dt>12.7. <a href="datamining.html#setBugDatabaseInfoOptions">setBugDatabaseInfo Options</a></dt><dt>12.8. <a href="datamining.html#listBugDatabaseInfoColumns">listBugDatabaseInfo Columns</a></dt></dl></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="introduction.html">Next</a></td></tr><tr><td width="40%" align="left" valign="top"> </td><td width="20%" align="center"> </td><td width="40%" align="right" valign="top"> Chapter 1. Introduction</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/manual/installing.html b/tools/findbugs-1.3.9/doc/manual/installing.html
deleted file mode 100644
index b02c237..0000000
--- a/tools/findbugs-1.3.9/doc/manual/installing.html
+++ /dev/null
@@ -1,29 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>Chapter 2. Installing FindBugs™</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ Manual"><link rel="up" href="index.html" title="FindBugs™ Manual"><link rel="prev" href="introduction.html" title="Chapter 1. Introduction"><link rel="next" href="building.html" title="Chapter 3. Building FindBugs™ from Source"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">Chapter 2. Installing <span class="application">FindBugs</span>™</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="introduction.html">Prev</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="building.html">Next</a></td></tr></table><hr></div><div class="chapter" lang="en"><div class="titlepage"><div><div><h2 class="title"><a name="installing"></a>Chapter 2. Installing <span class="application">FindBugs</span>™</h2></div></div></div><div class="toc"><p><b>Table of Contents</b></p><dl><dt><span class="sect1"><a href="installing.html#d0e106">1. Extracting the Distribution</a></span></dt></dl></div><p>
-This chapter explains how to install <span class="application">FindBugs</span>.
-</p><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e106"></a>1. Extracting the Distribution</h2></div></div></div><p>
-The easiest way to install <span class="application">FindBugs</span> is to download a binary distribution.
-Binary distributions are available in
-<a href="http://prdownloads.sourceforge.net/findbugs/findbugs-1.3.9.tar.gz?download" target="_top">gzipped tar format</a> and
-<a href="http://prdownloads.sourceforge.net/findbugs/findbugs-1.3.9.zip?download" target="_top">zip format</a>.
-Once you have downloaded a binary distribution, extract it into a directory of your choice.
-</p><p>
-Extracting a gzipped tar format distribution:
-</p><pre class="screen">
-<code class="prompt">$ </code><span><strong class="command">gunzip -c findbugs-1.3.9.tar.gz | tar xvf -</strong></span>
-</pre><p>
-</p><p>
-Extracting a zip format distribution:
-</p><pre class="screen">
-<code class="prompt">C:\Software></code><span><strong class="command">unzip findbugs-1.3.9.zip</strong></span>
-</pre><p>
-</p><p>
-Usually, extracting a binary distribution will create a directory ending in
-<code class="filename">findbugs-1.3.9</code>. For example, if you extracted
-the binary distribution from the <code class="filename">C:\Software</code>
-directory, then the <span class="application">FindBugs</span> software will be extracted into the directory
-<code class="filename">C:\Software\findbugs-1.3.9</code>.
-This directory is the <span class="application">FindBugs</span> home directory. We'll refer to it as
-<em class="replaceable"><code>$FINDBUGS_HOME</code></em> (or <em class="replaceable"><code>%FINDBUGS_HOME%</code></em> for Windows) throughout this manual.
-</p></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="introduction.html">Prev</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="building.html">Next</a></td></tr><tr><td width="40%" align="left" valign="top">Chapter 1. Introduction </td><td width="20%" align="center"><a accesskey="h" href="index.html">Home</a></td><td width="40%" align="right" valign="top"> Chapter 3. Building <span class="application">FindBugs</span>™ from Source</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/manual/introduction.html b/tools/findbugs-1.3.9/doc/manual/introduction.html
deleted file mode 100644
index 9e4f21d..0000000
--- a/tools/findbugs-1.3.9/doc/manual/introduction.html
+++ /dev/null
@@ -1,12 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>Chapter 1. Introduction</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ Manual"><link rel="up" href="index.html" title="FindBugs™ Manual"><link rel="prev" href="index.html" title="FindBugs™ Manual"><link rel="next" href="installing.html" title="Chapter 2. Installing FindBugs™"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">Chapter 1. Introduction</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="index.html">Prev</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="installing.html">Next</a></td></tr></table><hr></div><div class="chapter" lang="en"><div class="titlepage"><div><div><h2 class="title"><a name="introduction"></a>Chapter 1. Introduction</h2></div></div></div><div class="toc"><p><b>Table of Contents</b></p><dl><dt><span class="sect1"><a href="introduction.html#d0e75">1. Requirements</a></span></dt></dl></div><p> <span class="application">FindBugs</span>™ is a program to find bugs in Java programs. It looks for instances
-of "bug patterns" --- code instances that are likely to be errors.</p><p> This document describes version 1.3.9 of <span class="application">FindBugs</span>.We
-are very interested in getting your feedback on <span class="application">FindBugs</span>. Please visit
-the <a href="http://findbugs.sourceforge.net" target="_top"><span class="application">FindBugs</span> web page</a> for
-the latest information on <span class="application">FindBugs</span>, contact information, and support resources such
-as information about the <span class="application">FindBugs</span> mailing lists.</p><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e75"></a>1. Requirements</h2></div></div></div><p> To use <span class="application">FindBugs</span>, you need a runtime environment compatible with
-<a href="http://java.sun.com/j2se" target="_top">Java 2 Standard Edition</a>, version 1.5 or later.
-<span class="application">FindBugs</span> is platform independent, and is known to run on GNU/Linux, Windows, and
-MacOS X platforms.</p><p>You should have at least 512 MB of memory to use <span class="application">FindBugs</span>.
-To analyze very large projects, more memory may be needed.</p></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="index.html">Prev</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="installing.html">Next</a></td></tr><tr><td width="40%" align="left" valign="top"><span class="application">FindBugs</span>™ Manual </td><td width="20%" align="center"><a accesskey="h" href="index.html">Home</a></td><td width="40%" align="right" valign="top"> Chapter 2. Installing <span class="application">FindBugs</span>™</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/manual/license.html b/tools/findbugs-1.3.9/doc/manual/license.html
deleted file mode 100644
index 986a678..0000000
--- a/tools/findbugs-1.3.9/doc/manual/license.html
+++ /dev/null
@@ -1,13 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>Chapter 13. License</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ Manual"><link rel="up" href="index.html" title="FindBugs™ Manual"><link rel="prev" href="datamining.html" title="Chapter 12. Data mining of bugs with FindBugs™"><link rel="next" href="acknowledgments.html" title="Chapter 14. Acknowledgments"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">Chapter 13. License</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="datamining.html">Prev</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="acknowledgments.html">Next</a></td></tr></table><hr></div><div class="chapter" lang="en"><div class="titlepage"><div><div><h2 class="title"><a name="license"></a>Chapter 13. License</h2></div></div></div><p>
-The name FindBugs and the FindBugs logo is trademarked by the University
-of Maryland.
-FindBugs is free software distributed under the terms of the
-<a href="http://www.gnu.org/licenses/lgpl.html" target="_top">Lesser GNU Public License</a>.
-You should have received a copy of the license in the file <code class="filename">LICENSE.txt</code>
-in the <span class="application">FindBugs</span> distribution.
-</p><p>
-You can find the latest version of FindBugs, along with its source code, from the
-<a href="http://findbugs.sourceforge.net" target="_top">FindBugs web page</a>.
-</p></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="datamining.html">Prev</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="acknowledgments.html">Next</a></td></tr><tr><td width="40%" align="left" valign="top">Chapter 12. Data mining of bugs with <span class="application">FindBugs</span>™ </td><td width="20%" align="center"><a accesskey="h" href="index.html">Home</a></td><td width="40%" align="right" valign="top"> Chapter 14. Acknowledgments</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/manual/rejarForAnalysis.html b/tools/findbugs-1.3.9/doc/manual/rejarForAnalysis.html
deleted file mode 100644
index dae1f14..0000000
--- a/tools/findbugs-1.3.9/doc/manual/rejarForAnalysis.html
+++ /dev/null
@@ -1,33 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>Chapter 11. Using rejarForAnalysis</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ Manual"><link rel="up" href="index.html" title="FindBugs™ Manual"><link rel="prev" href="annotations.html" title="Chapter 10. Annotations"><link rel="next" href="datamining.html" title="Chapter 12. Data mining of bugs with FindBugs™"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">Chapter 11. Using rejarForAnalysis</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="annotations.html">Prev</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="datamining.html">Next</a></td></tr></table><hr></div><div class="chapter" lang="en"><div class="titlepage"><div><div><h2 class="title"><a name="rejarForAnalysis"></a>Chapter 11. Using rejarForAnalysis</h2></div></div></div><p>
-If your project consists of many jarfiles or the jarfiles are scattered
-over many directories, you may wish to use the <span><strong class="command">rejarForAnalysis
-</strong></span> script to make
-FindBugs invocation easier. The script collects many jarfiles and combines them
-into a single, large jarfile that can then be easily passed to FindBugs for
-analysis. This can be particularly useful in combination with the 'find' command
-on unix systems; e.g. <span><strong class="command">find . -name '*.jar' | xargs rejarForAnalysis
-</strong></span>.
-</p><p>
-The <span><strong class="command">rejarForAnalysis</strong></span> script
-can also be used to split a very large project up into a set of jarfiles with
-the project classfiles evenly divided between them. This is useful when running
-FindBugs on the entire project is not practical due to time or memory consumption.
-Instead of running FindBugs on the entire project, you may use <span><strong class="command">
-rejarForAnalysis</strong></span> build one large, all-inclusive jarfile
-containing all classes, invoke <span><strong class="command">rejarForAnalysis</strong></span>
-again to split the project into multiple jarfiles, then run FindBugs
-on each divided jarfiles in turn, specifying the the all-inclusive jarfile in
-the <span><strong class="command">-auxclasspath</strong></span>.
-</p><p>
-These are the options accepted by the <span><strong class="command">rejarForAnalysis</strong></span> script:
-</p><div class="variablelist"><dl><dt><span class="term"><span><strong class="command">-maxAge</strong></span> <em class="replaceable"><code>days</code></em></span></dt><dd><p>
- Maximum age in days (ignore jar files older than this).
- </p></dd><dt><span class="term"><span><strong class="command">-inputFileList</strong></span> <em class="replaceable"><code>filename</code></em></span></dt><dd><p>
- Text file containing names of jar files.
- </p></dd><dt><span class="term"><span><strong class="command">-maxClasses</strong></span> <em class="replaceable"><code>num</code></em></span></dt><dd><p>
- Maximum number of classes per analysis*.jar file.
- </p></dd><dt><span class="term"><span><strong class="command">-prefix</strong></span> <em class="replaceable"><code>class name prefix</code></em></span></dt><dd><p>
- Prefix of class names that should be analyzed (e.g., edu.umd.cs.).
- </p></dd></dl></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="annotations.html">Prev</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="datamining.html">Next</a></td></tr><tr><td width="40%" align="left" valign="top">Chapter 10. Annotations </td><td width="20%" align="center"><a accesskey="h" href="index.html">Home</a></td><td width="40%" align="right" valign="top"> Chapter 12. Data mining of bugs with <span class="application">FindBugs</span>™</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/doc/manual/running.html b/tools/findbugs-1.3.9/doc/manual/running.html
deleted file mode 100644
index 184cbb5..0000000
--- a/tools/findbugs-1.3.9/doc/manual/running.html
+++ /dev/null
@@ -1,203 +0,0 @@
-<html><head>
- <meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1">
- <title>Chapter 4. Running FindBugs™</title><meta name="generator" content="DocBook XSL Stylesheets V1.71.1"><link rel="start" href="index.html" title="FindBugs™ Manual"><link rel="up" href="index.html" title="FindBugs™ Manual"><link rel="prev" href="building.html" title="Chapter 3. Building FindBugs™ from Source"><link rel="next" href="gui.html" title="Chapter 5. Using the FindBugs GUI"></head><body bgcolor="white" text="black" link="#0000FF" vlink="#840084" alink="#0000FF"><div class="navheader"><table width="100%" summary="Navigation header"><tr><th colspan="3" align="center">Chapter 4. Running <span class="application">FindBugs</span>™</th></tr><tr><td width="20%" align="left"><a accesskey="p" href="building.html">Prev</a> </td><th width="60%" align="center"> </th><td width="20%" align="right"> <a accesskey="n" href="gui.html">Next</a></td></tr></table><hr></div><div class="chapter" lang="en"><div class="titlepage"><div><div><h2 class="title"><a name="running"></a>Chapter 4. Running <span class="application">FindBugs</span>™</h2></div></div></div><div class="toc"><p><b>Table of Contents</b></p><dl><dt><span class="sect1"><a href="running.html#d0e473">1. Quick Start</a></span></dt><dt><span class="sect1"><a href="running.html#d0e511">2. Executing <span class="application">FindBugs</span></a></span></dt><dt><span class="sect1"><a href="running.html#commandLineOptions">3. Command-line Options</a></span></dt></dl></div><p>
-<span class="application">FindBugs</span> has two user interfaces: a graphical user interface (GUI) and a
-command line user interface. This chapter describes
-how to run each of these user interfaces.
-</p><div class="warning" style="margin-left: 0.5in; margin-right: 0.5in;"><table border="0" summary="Warning"><tr><td rowspan="2" align="center" valign="top" width="25"><img alt="[Warning]" src="warning.png"></td><th align="left">Warning</th></tr><tr><td align="left" valign="top"><p>
- This chapter is in the process of being re-written.
- The rewrite is not complete yet.
- </p></td></tr></table></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e473"></a>1. Quick Start</h2></div></div></div><p>
- If you are running <span class="application">FindBugs</span> on a Windows system,
- double-click on the file <code class="filename"><em class="replaceable"><code>%FINDBUGS_HOME%</code></em>\lib\findbugs.jar</code> to start the <span class="application">FindBugs</span> GUI.
- </p><p>
- On a Unix, Linux, or Mac OS X system, run the <code class="filename"><em class="replaceable"><code>$FINDBUGS_HOME</code></em>/bin/findbugs</code>
- script, or run the command </p><pre class="screen">
-<span><strong class="command">java -jar <em class="replaceable"><code>$FINDBUGS_HOME</code></em>/lib/findbugs.jar</strong></span></pre><p>
- to run the <span class="application">FindBugs</span> GUI.
- </p><p>
- Refer to <a href="gui.html" title="Chapter 5. Using the FindBugs GUI">Chapter 5, <i>Using the <span class="application">FindBugs</span> GUI</i></a> for information on how to use the GUI.
- </p></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="d0e511"></a>2. Executing <span class="application">FindBugs</span></h2></div></div></div><p>
- This section describes how to invoke the <span class="application">FindBugs</span> program.
- There are two ways to invoke <span class="application">FindBugs</span>: directly, or using a
- wrapper script.
- </p><div class="sect2" lang="en"><div class="titlepage"><div><div><h3 class="title"><a name="directInvocation"></a>2.1. Direct invocation of <span class="application">FindBugs</span></h3></div></div></div><p>
- The preferred method of running <span class="application">FindBugs</span> is to directly execute
- <code class="filename"><em class="replaceable"><code>$FINDBUGS_HOME</code></em>/lib/findbugs.jar</code> using the <span><strong class="command">-jar</strong></span>
- command line switch of the JVM (<span><strong class="command">java</strong></span>) executable.
- (Versions of <span class="application">FindBugs</span> prior to 1.3.5 required a wrapper script
- to invoke <span class="application">FindBugs</span>.)
- </p><p>
- The general syntax of invoking <span class="application">FindBugs</span> directly is the following:
-</p><pre class="screen">
- <span><strong class="command">java <em class="replaceable"><code>[JVM arguments]</code></em> -jar <em class="replaceable"><code>$FINDBUGS_HOME</code></em>/lib/findbugs.jar <em class="replaceable"><code>options...</code></em></strong></span>
-</pre><p>
- </p><div class="sect3" lang="en"><div class="titlepage"><div><div><h4 class="title"><a name="chooseUI"></a>2.1.1. Choosing the User Interface</h4></div></div></div><p>
- The first command line option chooses the <span class="application">FindBugs</span> user interface to execute.
- Possible values are:
- </p><div class="itemizedlist"><ul type="disc"><li><p>
- <span><strong class="command">-gui</strong></span>: runs the graphical user interface (GUI)
- </p></li><li><p>
- <span><strong class="command">-textui</strong></span>: runs the command line user interface
- </p></li><li><p>
- <span><strong class="command">-version</strong></span>: displays the <span class="application">FindBugs</span> version number
- </p></li><li><p>
- <span><strong class="command">-help</strong></span>: displays help information for the
- <span class="application">FindBugs</span> command line user interface
- </p></li><li><p>
- <span><strong class="command">-gui1</strong></span>: executes the original (obsolete)
- <span class="application">FindBugs</span> graphical user interface
- </p></li></ul></div></div><div class="sect3" lang="en"><div class="titlepage"><div><div><h4 class="title"><a name="jvmArgs"></a>2.1.2. Java Virtual Machine (JVM) arguments</h4></div></div></div><p>
- Several Java Virtual Machine arguments are useful when invoking
- <span class="application">FindBugs</span>.
- </p><div class="variablelist"><dl><dt><span class="term"><span><strong class="command">-Xmx<em class="replaceable"><code>NN</code></em>m</strong></span></span></dt><dd><p>
- Set the maximum Java heap size to <em class="replaceable"><code>NN</code></em>
- megabytes. <span class="application">FindBugs</span> generally requires a large amount of
- memory. For a very large project, using 1500 megabytes
- is not unusual.
- </p></dd><dt><span class="term"><span><strong class="command">-D<em class="replaceable"><code>name</code></em>=<em class="replaceable"><code>value</code></em></strong></span></span></dt><dd><p>
- Set a Java system property. For example, you might use the
- argument <span><strong class="command">-Duser.language=ja</strong></span> to display
- GUI messages in Japanese.
- </p></dd></dl></div></div></div><div class="sect2" lang="en"><div class="titlepage"><div><div><h3 class="title"><a name="wrapperScript"></a>2.2. Invocation of <span class="application">FindBugs</span> using a wrapper script</h3></div></div></div><p>
- Another way to run <span class="application">FindBugs</span> is to use a wrapper script.
- </p><p>
-On Unix-like systems, use the following command to invoke the wrapper script:
-</p><pre class="screen">
-<code class="prompt">$ </code><span><strong class="command"><em class="replaceable"><code>$FINDBUGS_HOME</code></em>/bin/findbugs <em class="replaceable"><code>options...</code></em></strong></span>
-</pre><p>
-</p><p>
-On Windows systems, the command to invoke the wrapper script is
-</p><pre class="screen">
-<code class="prompt">C:\My Directory></code><span><strong class="command"><em class="replaceable"><code>%FINDBUGS_HOME%</code></em>\bin\findbugs.bat <em class="replaceable"><code>options...</code></em></strong></span>
-</pre><p>
-</p><p>
-On both Unix-like and Windows systems, you can simply add the <code class="filename"><em class="replaceable"><code>$FINDBUGS_HOME</code></em>/bin</code>
-directory to your <code class="filename">PATH</code> environment variable and then invoke
-FindBugs using the <span><strong class="command">findbugs</strong></span> command.
-</p><div class="sect3" lang="en"><div class="titlepage"><div><div><h4 class="title"><a name="wrapperOptions"></a>2.2.1. Wrapper script command line options</h4></div></div></div><p>The <span class="application">FindBugs</span> wrapper scripts support the following command-line options.
- Note that these command line options are <span class="emphasis"><em>not</em></span> handled by
- the <span class="application">FindBugs</span> program per se; rather, they are handled by the wrapper
- script.
- </p><div class="variablelist"><dl><dt><span class="term"><span><strong class="command">-jvmArgs <em class="replaceable"><code>args</code></em></strong></span></span></dt><dd><p>
- Specifies arguments to pass to the JVM. For example, you might want
- to set a JVM property:
-</p><pre class="screen">
-<code class="prompt">$ </code><span><strong class="command">findbugs -textui -jvmArgs "-Duser.language=ja" <em class="replaceable"><code>myApp.jar</code></em></strong></span>
-</pre><p>
- </p></dd><dt><span class="term"><span><strong class="command">-javahome <em class="replaceable"><code>directory</code></em></strong></span></span></dt><dd><p>
- Specifies the directory containing the JRE (Java Runtime Environment) to
- use to execute <span class="application">FindBugs</span>.
- </p></dd><dt><span class="term"><span><strong class="command">-maxHeap <em class="replaceable"><code>size</code></em></strong></span></span></dt><dd><p>
- Specifies the maximum Java heap size in megabytes. The default is 256.
- More memory may be required to analyze very large programs or libraries.
- </p></dd><dt><span class="term"><span><strong class="command">-debug</strong></span></span></dt><dd><p>
- Prints a trace of detectors run and classes analyzed to standard output.
- Useful for troubleshooting unexpected analysis failures.
- </p></dd><dt><span class="term"><span><strong class="command">-property</strong></span> <em class="replaceable"><code>name=value</code></em></span></dt><dd><p>
- This option sets a system property. <span class="application">FindBugs</span> uses system properties
- to configure analysis options. See <a href="analysisprops.html" title="Chapter 9. Analysis Properties">Chapter 9, <i>Analysis Properties</i></a>.
- You can use this option multiple times in order to set multiple properties.
- Note: In most versions of Windows, the <em class="replaceable"><code>name=value</code></em>
- string must be in quotes.
- </p></dd></dl></div></div></div></div><div class="sect1" lang="en"><div class="titlepage"><div><div><h2 class="title" style="clear: both"><a name="commandLineOptions"></a>3. Command-line Options</h2></div></div></div><p>
- This section describes the command line options supported by <span class="application">FindBugs</span>.
- These command line options may be used when invoking <span class="application">FindBugs</span> directly,
- or when using a wrapper script.
-</p><div class="sect2" lang="en"><div class="titlepage"><div><div><h3 class="title"><a name="d0e804"></a>3.1. Common command-line options</h3></div></div></div><p>
-These options may be used with both the GUI and command-line interfaces.
-</p><div class="variablelist"><dl><dt><span class="term"><span><strong class="command">-effort:min</strong></span></span></dt><dd><p>
- This option disables analyses that increase precision but also
- increase memory consumption. You may want to try this option if
- you find that <span class="application">FindBugs</span> runs out of memory, or takes an unusually
- long time to complete its analysis.
- </p></dd><dt><span class="term"><span><strong class="command">-effort:max</strong></span></span></dt><dd><p>
- Enable analyses which increase precision and find more bugs, but which
- may require more memory and take more time to complete.
- </p></dd><dt><span class="term"><span><strong class="command">-project</strong></span> <em class="replaceable"><code>project</code></em></span></dt><dd><p>
- Specify a project to be analyzed. The project file you specify should
- be one that was created using the GUI interface. It will typically end
- in the extension <code class="filename">.fb</code> or <code class="filename">.fbp</code>.
- </p></dd></dl></div></div><div class="sect2" lang="en"><div class="titlepage"><div><div><h3 class="title"><a name="d0e844"></a>3.2. GUI Options</h3></div></div></div><p>
-These options are only accepted by the Graphical User Interface.
-
-</p><div class="variablelist"><dl><dt><span class="term"><span><strong class="command">-look:</strong></span><em class="replaceable"><code>plastic|gtk|native</code></em></span></dt><dd><p>
- Set Swing look and feel.
- </p></dd></dl></div><p>
-</p></div><div class="sect2" lang="en"><div class="titlepage"><div><div><h3 class="title"><a name="d0e860"></a>3.3. Text UI Options</h3></div></div></div><p>
-These options are only accepted by the Text User Interface.
-</p><div class="variablelist"><dl><dt><span class="term"><span><strong class="command">-sortByClass</strong></span></span></dt><dd><p>
- Sort reported bug instances by class name.
- </p></dd><dt><span class="term"><span><strong class="command">-include</strong></span> <em class="replaceable"><code>filterFile.xml</code></em></span></dt><dd><p>
- Only report bug instances that match the filter specified by <em class="replaceable"><code>filterFile.xml</code></em>.
- See <a href="filter.html" title="Chapter 8. Filter Files">Chapter 8, <i>Filter Files</i></a>.
- </p></dd><dt><span class="term"><span><strong class="command">-exclude</strong></span> <em class="replaceable"><code>filterFile.xml</code></em></span></dt><dd><p>
- Report all bug instances except those matching the filter specified by <em class="replaceable"><code>filterFile.xml</code></em>.
- See <a href="filter.html" title="Chapter 8. Filter Files">Chapter 8, <i>Filter Files</i></a>.
- </p></dd><dt><span class="term"><span><strong class="command">-onlyAnalyze</strong></span> <em class="replaceable"><code>com.foobar.MyClass,com.foobar.mypkg.*</code></em></span></dt><dd><p>
- Restrict analysis to find bugs to given comma-separated list of
- classes and packages.
- Unlike filtering, this option avoids running analysis on
- classes and packages that are not explicitly matched:
- for large projects, this may greatly reduce the amount of time
- needed to run the analysis. (However, some detectors may produce
- inaccurate results if they aren't run on the entire application.)
- Classes should be specified using their full classnames (including
- package), and packages should be specified in the same way
- they would in a Java <code class="literal">import</code> statement to
- import all classes in the package (i.e., add <code class="literal">.*</code>
- to the full name of the package).
- Replace <code class="literal">.*</code> with <code class="literal">.-</code> to also
- analyze all subpackages.
- </p></dd><dt><span class="term"><span><strong class="command">-low</strong></span></span></dt><dd><p>
- Report all bugs.
- </p></dd><dt><span class="term"><span><strong class="command">-medium</strong></span></span></dt><dd><p>
- Report medium and high priority bugs. This is the default setting.
- </p></dd><dt><span class="term"><span><strong class="command">-high</strong></span></span></dt><dd><p>
- Report only high priority bugs.
- </p></dd><dt><span class="term"><span><strong class="command">-relaxed</strong></span></span></dt><dd><p>
- Relaxed reporting mode. For many detectors, this option
- suppresses the heuristics used to avoid reporting false positives.
- </p></dd><dt><span class="term"><span><strong class="command">-xml</strong></span></span></dt><dd><p>
- Produce the bug reports as XML. The XML data produced may be
- viewed in the GUI at a later time. You may also specify this
- option as <span><strong class="command">-xml:withMessages</strong></span>; when this variant
- of the option is used, the XML output will contain human-readable
- messages describing the warnings contained in the file.
- XML files generated this way are easy to transform into reports.
- </p></dd><dt><span class="term"><span><strong class="command">-html</strong></span></span></dt><dd><p>
- Generate HTML output. By default, <span class="application">FindBugs</span> will use the <code class="filename">default.xsl</code>
- <a href="http://www.w3.org/TR/xslt" target="_top">XSLT</a>
- stylesheet to generate the HTML: you can find this file in <code class="filename">findbugs.jar</code>,
- or in the <span class="application">FindBugs</span> source or binary distributions. Variants of this option include
- <span><strong class="command">-html:plain.xsl</strong></span>, <span><strong class="command">-html:fancy.xsl</strong></span> and <span><strong class="command">-html:fancy-hist.xsl</strong></span>.
- The <code class="filename">plain.xsl</code> stylesheet does not use Javascript or DOM,
- and may work better with older web browsers, or for printing. The <code class="filename">fancy.xsl</code>
- stylesheet uses DOM and Javascript for navigation and CSS for
- visual presentation. The <span><strong class="command">fancy-hist.xsl</strong></span> an evolution of <span><strong class="command">fancy.xsl</strong></span> stylesheet.
- It makes an extensive use of DOM and Javascript for dynamically filtering the lists of bugs.
- </p><p>
- If you want to specify your own
- XSLT stylesheet to perform the transformation to HTML, specify the option as
- <span><strong class="command">-html:<em class="replaceable"><code>myStylesheet.xsl</code></em></strong></span>,
- where <em class="replaceable"><code>myStylesheet.xsl</code></em> is the filename of the
- stylesheet you want to use.
- </p></dd><dt><span class="term"><span><strong class="command">-emacs</strong></span></span></dt><dd><p>
- Produce the bug reports in Emacs format.
- </p></dd><dt><span class="term"><span><strong class="command">-xdocs</strong></span></span></dt><dd><p>
- Produce the bug reports in xdoc XML format for use with Apache Maven.
- </p></dd><dt><span class="term"><span><strong class="command">-output</strong></span> <em class="replaceable"><code>filename</code></em></span></dt><dd><p>
- Produce the output in the specified file.
- </p></dd><dt><span class="term"><span><strong class="command">-outputFile</strong></span> <em class="replaceable"><code>filename</code></em></span></dt><dd><p>
- This argument is deprecated. Use <span><strong class="command">-output</strong></span> instead.
- </p></dd><dt><span class="term"><span><strong class="command">-nested</strong></span><em class="replaceable"><code>[:true|false]</code></em></span></dt><dd><p>
- This option enables or disables scanning of nested jar and zip files found in
- the list of files and directories to be analyzed.
- By default, scanning of nested jar/zip files is enabled.
- To disable it, add <span><strong class="command">-nested:false</strong></span> to the command line
- arguments.
- </p></dd><dt><span class="term"><span><strong class="command">-auxclasspath</strong></span> <em class="replaceable"><code>classpath</code></em></span></dt><dd><p>
- Set the auxiliary classpath for analysis. This classpath should include all
- jar files and directories containing classes that are part of the program
- being analyzed but you do not want to have analyzed for bugs.
- </p></dd></dl></div></div></div></div><div class="navfooter"><hr><table width="100%" summary="Navigation footer"><tr><td width="40%" align="left"><a accesskey="p" href="building.html">Prev</a> </td><td width="20%" align="center"> </td><td width="40%" align="right"> <a accesskey="n" href="gui.html">Next</a></td></tr><tr><td width="40%" align="left" valign="top">Chapter 3. Building <span class="application">FindBugs</span>™ from Source </td><td width="20%" align="center"><a accesskey="h" href="index.html">Home</a></td><td width="40%" align="right" valign="top"> Chapter 5. Using the <span class="application">FindBugs</span> GUI</td></tr></table></div></body></html>
\ No newline at end of file
diff --git a/tools/findbugs-1.3.9/lib/annotations.jar b/tools/findbugs-1.3.9/lib/annotations.jar
deleted file mode 100644
index ce70abe..0000000
--- a/tools/findbugs-1.3.9/lib/annotations.jar
+++ /dev/null
Binary files differ
diff --git a/tools/findbugs-1.3.9/lib/ant.jar b/tools/findbugs-1.3.9/lib/ant.jar
deleted file mode 100644
index 0a56a58..0000000
--- a/tools/findbugs-1.3.9/lib/ant.jar
+++ /dev/null
Binary files differ
diff --git a/tools/findbugs-1.3.9/lib/asm-3.1.jar b/tools/findbugs-1.3.9/lib/asm-3.1.jar
deleted file mode 100644
index b3baf3f..0000000
--- a/tools/findbugs-1.3.9/lib/asm-3.1.jar
+++ /dev/null
Binary files differ
diff --git a/tools/findbugs-1.3.9/lib/asm-analysis-3.1.jar b/tools/findbugs-1.3.9/lib/asm-analysis-3.1.jar
deleted file mode 100644
index c3a62a2..0000000
--- a/tools/findbugs-1.3.9/lib/asm-analysis-3.1.jar
+++ /dev/null
Binary files differ
diff --git a/tools/findbugs-1.3.9/lib/asm-commons-3.1.jar b/tools/findbugs-1.3.9/lib/asm-commons-3.1.jar
deleted file mode 100644
index 5f696ae..0000000
--- a/tools/findbugs-1.3.9/lib/asm-commons-3.1.jar
+++ /dev/null
Binary files differ
diff --git a/tools/findbugs-1.3.9/lib/asm-tree-3.1.jar b/tools/findbugs-1.3.9/lib/asm-tree-3.1.jar
deleted file mode 100644
index 5ad4cf2..0000000
--- a/tools/findbugs-1.3.9/lib/asm-tree-3.1.jar
+++ /dev/null
Binary files differ
diff --git a/tools/findbugs-1.3.9/lib/asm-util-3.1.jar b/tools/findbugs-1.3.9/lib/asm-util-3.1.jar
deleted file mode 100644
index 3702a14..0000000
--- a/tools/findbugs-1.3.9/lib/asm-util-3.1.jar
+++ /dev/null
Binary files differ
diff --git a/tools/findbugs-1.3.9/lib/asm-xml-3.1.jar b/tools/findbugs-1.3.9/lib/asm-xml-3.1.jar
deleted file mode 100644
index 8695f56..0000000
--- a/tools/findbugs-1.3.9/lib/asm-xml-3.1.jar
+++ /dev/null
Binary files differ
diff --git a/tools/findbugs-1.3.9/lib/bcel.jar b/tools/findbugs-1.3.9/lib/bcel.jar
deleted file mode 100644
index 8d1217b..0000000
--- a/tools/findbugs-1.3.9/lib/bcel.jar
+++ /dev/null
Binary files differ
diff --git a/tools/findbugs-1.3.9/lib/findbugs-ant.jar b/tools/findbugs-1.3.9/lib/findbugs-ant.jar
deleted file mode 100644
index 4fe8076..0000000
--- a/tools/findbugs-1.3.9/lib/findbugs-ant.jar
+++ /dev/null
Binary files differ
diff --git a/tools/findbugs-1.3.9/lib/findbugs.jar b/tools/findbugs-1.3.9/lib/findbugs.jar
deleted file mode 100644
index b070f5d..0000000
--- a/tools/findbugs-1.3.9/lib/findbugs.jar
+++ /dev/null
Binary files differ
diff --git a/tools/findbugs-1.3.9/lib/jFormatString.jar b/tools/findbugs-1.3.9/lib/jFormatString.jar
deleted file mode 100644
index eadfd91..0000000
--- a/tools/findbugs-1.3.9/lib/jFormatString.jar
+++ /dev/null
Binary files differ
diff --git a/tools/findbugs-1.3.9/lib/mysql-connector-java-5.1.7-bin.jar b/tools/findbugs-1.3.9/lib/mysql-connector-java-5.1.7-bin.jar
deleted file mode 100644
index ebfe068..0000000
--- a/tools/findbugs-1.3.9/lib/mysql-connector-java-5.1.7-bin.jar
+++ /dev/null
Binary files differ
diff --git a/tools/findbugs-1.3.9/plugin/README b/tools/findbugs-1.3.9/plugin/README
deleted file mode 100644
index ea251cc..0000000
--- a/tools/findbugs-1.3.9/plugin/README
+++ /dev/null
@@ -1,8 +0,0 @@
-
-Put the jar files for FindBugs plugins in this directory.
-For example, you can download the fb-contrib plugin from:
- http://fb-contrib.sourceforge.net/
-
-You should carefully evaluate any FindBugs plugins to determine whether
-the issues they report are suitable and appropriate for your project.
-
diff --git a/tools/findbugs-1.3.9/src/xsl/default.xsl b/tools/findbugs-1.3.9/src/xsl/default.xsl
deleted file mode 100644
index e8f30d4..0000000
--- a/tools/findbugs-1.3.9/src/xsl/default.xsl
+++ /dev/null
@@ -1,376 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-
-<!--
- FindBugs - Find bugs in Java programs
- Copyright (C) 2004,2005 University of Maryland
- Copyright (C) 2005, Chris Nappin
-
- This library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Lesser General Public
- License as published by the Free Software Foundation; either
- version 2.1 of the License, or (at your option) any later version.
-
- This library is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- Lesser General Public License for more details.
-
- You should have received a copy of the GNU Lesser General Public
- License along with this library; if not, write to the Free Software
- Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
--->
-
-<!--
- A simple XSLT stylesheet to transform FindBugs XML results
- annotated with messages into HTML.
-
- If you want to experiment with modifying this stylesheet,
- or write your own, you need to generate XML output from FindBugs
- using a special option which lets it know to include
- human-readable messages in the XML. Invoke the findbugs script
- as follows:
-
- findbugs -textui -xml:withMessages -project myProject.fb > results.xml
-
- Then you can use your favorite XSLT implementation to transform
- the XML output into HTML. (But don't use xsltproc. It generates well-nigh
- unreadable output, and generates incorrect output for the
- <script> element.)
-
- Authors:
- David Hovemeyer
- Chris Nappin (summary table)
--->
-
-<xsl:stylesheet
- version="1.0"
- xmlns="http://www.w3.org/1999/xhtml"
- xmlns:xsl="http://www.w3.org/1999/XSL/Transform">
-
-<xsl:output
- method="xml"
- indent="yes"
- omit-xml-declaration="yes"
- standalone="yes"
- doctype-system="http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"
- doctype-public="-//W3C//DTD XHTML 1.0 Transitional//EN"
- encoding="UTF-8"/>
-
-<xsl:variable name="literalNbsp">&nbsp;</xsl:variable>
-
-<!--xsl:key name="bug-category-key" match="/BugCollection/BugInstance" use="@category"/-->
-
-<xsl:variable name="bugTableHeader">
- <tr class="tableheader">
- <th align="left">Code</th>
- <th align="left">Warning</th>
- </tr>
-</xsl:variable>
-
-<xsl:template match="/">
- <html>
- <head>
- <title>FindBugs Report</title>
- <style type="text/css">
- .tablerow0 {
- background: #EEEEEE;
- }
-
- .tablerow1 {
- background: white;
- }
-
- .detailrow0 {
- background: #EEEEEE;
- }
-
- .detailrow1 {
- background: white;
- }
-
- .tableheader {
- background: #b9b9fe;
- font-size: larger;
- }
-
- .tablerow0:hover, .tablerow1:hover {
- background: #aaffaa;
- }
-
- .priority-1 {
- color: red;
- font-weight: bold;
- }
- .priority-2 {
- color: orange;
- font-weight: bold;
- }
- .priority-3 {
- color: green;
- font-weight: bold;
- }
- .priority-4 {
- color: blue;
- font-weight: bold;
- }
- </style>
- <script type="text/javascript">
- function toggleRow(elid) {
- if (document.getElementById) {
- element = document.getElementById(elid);
- if (element) {
- if (element.style.display == 'none') {
- element.style.display = 'block';
- //window.status = 'Toggle on!';
- } else {
- element.style.display = 'none';
- //window.status = 'Toggle off!';
- }
- }
- }
- }
- </script>
- </head>
-
- <xsl:variable name="unique-catkey" select="/BugCollection/BugCategory/@category"/>
- <!--xsl:variable name="unique-catkey" select="/BugCollection/BugInstance[generate-id() = generate-id(key('bug-category-key',@category))]/@category"/-->
-
- <body>
-
- <h1><a href="http://findbugs.sourceforge.net">FindBugs</a> Report</h1>
-
- <h2>Project Information</h2>
- <xsl:apply-templates select="/BugCollection/Project"/>
-
- <h2>Metrics</h2>
- <xsl:apply-templates select="/BugCollection/FindBugsSummary"/>
-
- <h2>Contents</h2>
- <ul>
- <xsl:for-each select="$unique-catkey">
- <xsl:sort select="." order="ascending"/>
- <xsl:variable name="catkey" select="."/>
- <xsl:variable name="catdesc" select="/BugCollection/BugCategory[@category=$catkey]/Description"/>
-
- <li><a href="#Warnings_{$catkey}"><xsl:value-of select="$catdesc"/> Warnings</a></li>
- </xsl:for-each>
-
- <li><a href="#Details">Details</a></li>
- </ul>
-
- <h1>Summary</h1>
- <table width="500" cellpadding="5" cellspacing="2">
- <tr class="tableheader">
- <th align="left">Warning Type</th>
- <th align="right">Number</th>
- </tr>
-
- <xsl:for-each select="$unique-catkey">
- <xsl:sort select="." order="ascending"/>
- <xsl:variable name="catkey" select="."/>
- <xsl:variable name="catdesc" select="/BugCollection/BugCategory[@category=$catkey]/Description"/>
- <xsl:variable name="styleclass">
- <xsl:choose><xsl:when test="position() mod 2 = 1">tablerow0</xsl:when>
- <xsl:otherwise>tablerow1</xsl:otherwise>
- </xsl:choose>
- </xsl:variable>
-
- <tr class="{$styleclass}">
- <td><a href="#Warnings_{$catkey}"><xsl:value-of select="$catdesc"/> Warnings</a></td>
- <td align="right"><xsl:value-of select="count(/BugCollection/BugInstance[(@category=$catkey) and not(@last)])"/></td>
- </tr>
- </xsl:for-each>
-
- <xsl:variable name="styleclass">
- <xsl:choose><xsl:when test="count($unique-catkey) mod 2 = 0">tablerow0</xsl:when>
- <xsl:otherwise>tablerow1</xsl:otherwise>
- </xsl:choose>
- </xsl:variable>
- <tr class="{$styleclass}">
- <td><b>Total</b></td>
- <td align="right"><b><xsl:value-of select="count(/BugCollection/BugInstance[not(@last)])"/></b></td>
- </tr>
- </table>
-
- <h1>Warnings</h1>
-
- <p>Click on a warning row to see full context information.</p>
-
- <xsl:for-each select="$unique-catkey">
- <xsl:sort select="." order="ascending"/>
- <xsl:variable name="catkey" select="."/>
- <xsl:variable name="catdesc" select="/BugCollection/BugCategory[@category=$catkey]/Description"/>
-
- <xsl:call-template name="generateWarningTable">
- <xsl:with-param name="warningSet" select="/BugCollection/BugInstance[(@category=$catkey) and not(@last)]"/>
- <xsl:with-param name="sectionTitle"><xsl:value-of select="$catdesc"/> Warnings</xsl:with-param>
- <xsl:with-param name="sectionId">Warnings_<xsl:value-of select="$catkey"/></xsl:with-param>
- </xsl:call-template>
- </xsl:for-each>
-
- <h1><a name="Details">Details</a></h1>
-
- <xsl:apply-templates select="/BugCollection/BugPattern">
- <xsl:sort select="@abbrev"/>
- <xsl:sort select="ShortDescription"/>
- </xsl:apply-templates>
-
- </body>
- </html>
-</xsl:template>
-
-<xsl:template match="Project">
- <p>Project:
- <xsl:choose>
- <xsl:when test='string-length(/BugCollection/Project/@projectName)>0'><xsl:value-of select="/BugCollection/Project/@projectName" /></xsl:when>
- <xsl:otherwise><xsl:value-of select="/BugCollection/Project/@filename" /></xsl:otherwise>
- </xsl:choose>
- </p>
- <p>FindBugs version: <xsl:value-of select="/BugCollection/@version"/></p>
-
- <p>Code analyzed:</p>
- <ul>
- <xsl:for-each select="./Jar">
- <li><xsl:value-of select="text()"/></li>
- </xsl:for-each>
- </ul>
- <p><br/><br/></p>
-</xsl:template>
-
-<xsl:template match="BugInstance[not(@last)]">
- <xsl:variable name="warningId"><xsl:value-of select="generate-id()"/></xsl:variable>
-
- <tr class="tablerow{position() mod 2}" onclick="toggleRow('{$warningId}');">
-
- <td>
- <span><xsl:attribute name="class">priority-<xsl:value-of select="@priority"/></xsl:attribute>
- <xsl:value-of select="@abbrev"/>
- </span>
- </td>
-
- <td>
- <xsl:value-of select="LongMessage"/>
- </td>
-
- </tr>
-
- <!-- Add bug annotation elements: Class, Method, Field, SourceLine, Field -->
- <tr class="detailrow{position() mod 2}">
- <td/>
- <td>
- <p id="{$warningId}" style="display: none;">
- <a href="#{@type}">Bug type <xsl:value-of select="@type"/> (click for details)</a>
- <xsl:for-each select="./*/Message">
- <br/><xsl:value-of select="text()" disable-output-escaping="no"/>
- </xsl:for-each>
- </p>
- </td>
- </tr>
-</xsl:template>
-
-<xsl:template match="BugPattern">
- <h2><a name="{@type}"><xsl:value-of select="@type"/>: <xsl:value-of select="ShortDescription"/></a></h2>
- <xsl:value-of select="Details" disable-output-escaping="yes"/>
-</xsl:template>
-
-<xsl:template name="generateWarningTable">
- <xsl:param name="warningSet"/>
- <xsl:param name="sectionTitle"/>
- <xsl:param name="sectionId"/>
-
- <h2><a name="{$sectionId}"><xsl:value-of select="$sectionTitle"/></a></h2>
- <table class="warningtable" width="100%" cellspacing="0">
- <xsl:copy-of select="$bugTableHeader"/>
- <xsl:apply-templates select="$warningSet">
- <xsl:sort select="@abbrev"/>
- <xsl:sort select="Class/@classname"/>
- </xsl:apply-templates>
- </table>
-</xsl:template>
-
-<xsl:template match="FindBugsSummary">
- <xsl:variable name="kloc" select="@total_size div 1000.0"/>
- <xsl:variable name="format" select="'#######0.00'"/>
-
- <p><xsl:value-of select="@total_size"/> lines of code analyzed,
- in <xsl:value-of select="@total_classes"/> classes,
- in <xsl:value-of select="@num_packages"/> packages.</p>
- <table width="500" cellpadding="5" cellspacing="2">
- <tr class="tableheader">
- <th align="left">Metric</th>
- <th align="right">Total</th>
- <th align="right">Density*</th>
- </tr>
- <tr class="tablerow0">
- <td>High Priority Warnings</td>
- <td align="right"><xsl:value-of select="@priority_1"/></td>
- <td align="right">
- <xsl:choose>
- <xsl:when test= "number($kloc) > 0.0 and number(@priority_1) > 0.0">
- <xsl:value-of select="format-number(@priority_1 div $kloc, $format)"/>
- </xsl:when>
- <xsl:otherwise>
- <xsl:value-of select="format-number(0.0, $format)"/>
- </xsl:otherwise>
- </xsl:choose>
- </td>
- </tr>
- <tr class="tablerow1">
- <td>Medium Priority Warnings</td>
- <td align="right"><xsl:value-of select="@priority_2"/></td>
- <td align="right">
- <xsl:choose>
- <xsl:when test= "number($kloc) > 0.0 and number(@priority_2) > 0.0">
- <xsl:value-of select="format-number(@priority_2 div $kloc, $format)"/>
- </xsl:when>
- <xsl:otherwise>
- <xsl:value-of select="format-number(0.0, $format)"/>
- </xsl:otherwise>
- </xsl:choose>
- </td>
- </tr>
-
- <xsl:choose>
- <xsl:when test="@priority_3">
- <tr class="tablerow1">
- <td>Low Priority Warnings</td>
- <td align="right"><xsl:value-of select="@priority_3"/></td>
- <td align="right">
- <xsl:choose>
- <xsl:when test= "number($kloc) > 0.0 and number(@priority_3) > 0.0">
- <xsl:value-of select="format-number(@priority_3 div $kloc, $format)"/>
- </xsl:when>
- <xsl:otherwise>
- <xsl:value-of select="format-number(0.0, $format)"/>
- </xsl:otherwise>
- </xsl:choose>
- </td>
- </tr>
- <xsl:variable name="totalClass" select="tablerow0"/>
- </xsl:when>
- <xsl:otherwise>
- <xsl:variable name="totalClass" select="tablerow1"/>
- </xsl:otherwise>
- </xsl:choose>
-
- <tr class="$totalClass">
- <td><b>Total Warnings</b></td>
- <td align="right"><b><xsl:value-of select="@total_bugs"/></b></td>
- <xsl:choose>
- <xsl:when test="number($kloc) > 0.0">
- <td align="right"><b><xsl:value-of select="format-number(@total_bugs div $kloc, $format)"/></b></td>
- </xsl:when>
- <xsl:otherwise>
- <td align="right"><b><xsl:value-of select="format-number(0.0, $format)"/></b></td>
- </xsl:otherwise>
- </xsl:choose>
- </tr>
- </table>
- <p><i>(* Defects per Thousand lines of non-commenting source statements)</i></p>
- <p><br/><br/></p>
-
-</xsl:template>
-
-</xsl:stylesheet>
-
-<!-- vim:set ts=4: -->
diff --git a/tools/findbugs-1.3.9/src/xsl/fancy-hist.xsl b/tools/findbugs-1.3.9/src/xsl/fancy-hist.xsl
deleted file mode 100644
index faa1b81..0000000
--- a/tools/findbugs-1.3.9/src/xsl/fancy-hist.xsl
+++ /dev/null
@@ -1,1197 +0,0 @@
-<?xml version="1.0" encoding="UTF-8" ?>
-<!--
- Copyright (C) 2005, 2006 Etienne Giraudy, InStranet Inc
- Copyright (C) 2005, 2007 Etienne Giraudy
-
- This library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Lesser General Public
- License as published by the Free Software Foundation; either
- version 2.1 of the License, or (at your option) any later version.
-
- This library is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- Lesser General Public License for more details.
-
- You should have received a copy of the GNU Lesser General Public
- License along with this library; if not, write to the Free Software
- Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
--->
-
-<xsl:transform xmlns:xsl="http://www.w3.org/1999/XSL/Transform" version="1.0" >
- <xsl:output
- method="xml" indent="yes"
- doctype-system="http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"
- doctype-public="-//W3C//DTD XHTML 1.0 Strict//EN"
- encoding="UTF-8"/>
-
- <xsl:variable name="apos" select=""'""/>
- <xsl:key name="lbc-code-key" match="/BugCollection/BugInstance" use="concat(@category,@abbrev)" />
- <xsl:key name="lbc-bug-key" match="/BugCollection/BugInstance" use="concat(@category,@abbrev,@type)" />
- <xsl:key name="lbp-class-b-t" match="/BugCollection/BugInstance" use="concat(Class/@classname,@type)" />
-
-<xsl:template match="/" >
-
-<html>
- <head>
- <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
- <title>
- FindBugs (<xsl:value-of select="/BugCollection/@version" />)
- Analysis for
- <xsl:choose>
- <xsl:when test='string-length(/BugCollection/Project/@projectName)>0'><xsl:value-of select="/BugCollection/Project/@projectName" /></xsl:when>
- <xsl:otherwise><xsl:value-of select="/BugCollection/Project/@filename" /></xsl:otherwise>
- </xsl:choose>
- </title>
- <style type="text/css">
- html, body, div, form {
- margin:0px;
- padding:0px;
- }
- body {
- padding:3px;
- }
- a, a:link , a:active, a:visited, a:hover {
- text-decoration: none; color: black;
- }
- #navlist {
- padding: 3px 0;
- margin-left: 0;
- border-bottom: 1px solid #778;
- font: bold 12px Verdana, sans-serif;
- }
- #navlist li {
- list-style: none;
- margin: 0;
- display: inline;
- }
- #navlist li a {
- padding: 3px 0.5em;
- margin-left: 3px;
- border: 1px solid #778;
- border-bottom: none;
- background: #DDE;
- text-decoration: none;
- }
- #navlist li a:link { color: #448; }
- #navlist li a:visited { color: #667; }
- #navlist li a:hover {
- color: #000;
- background: #AAE;
- border-color: #227;
- }
- #navlist li a.current {
- background: white;
- border-bottom: 1px solid white;
- }
- #filterWrapper {
- margin-bottom:5px;
- }
- #displayWrapper {
- margin-top:5px;
- }
- .message {
- background:#BBBBBB;
- border: 1px solid #778;
- }
- .displayContainer {
- border:1px solid #555555;
- margin-top:3px;
- padding: 3px;
- display:none;
- }
- #summaryContainer table,
- #historyContainer table {
- border:1px solid black;
- }
- #summaryContainer th,
- #historyContainer th {
- background: #aaaaaa;
- color: white;
- }
- #summaryContainer th, #summaryContainer td,
- #historyContainer th, #historyContainer td {
- padding: 2px 4px 2px 4px;
- }
- .summary-name {
- background: #eeeeee;
- text-align:left;
- }
- .summary-size {
- background: #eeeeee;
- text-align:center;
- }
- .summary-priority-all {
- background: #dddddd;
- text-align:center;
- }
- .summary-priority-1 {
- background: red;
- text-align:center;
- }
- .summary-priority-2 {
- background: orange;
- text-align:center;
- }
- .summary-priority-3 {
- background: green;
- text-align:center;
- }
- .summary-priority-4 {
- background: blue;
- text-align:center;
- }
-
- .bugList-level1 {
- margin-bottom:5px;
- }
- .bugList-level1, .bugList-level2, .bugList-level3, .bugList-level4 {
- background-color: #ffffff;
- margin-left:15px;
- padding-left:10px;
- }
- .bugList-level1-label, .bugList-level2-label, .bugList-level3-label, .bugList-level4-label {
- background-color: #bbbbbb;
- border: 1px solid black;
- padding: 1px 3px 1px 3px;;
- }
- .bugList-level2-label, .bugList-level3-label, .bugList-level4-label {
- border-width: 0px 1px 1px 1px;
- }
- .bugList-level4-label {
- background-color: #ffffff;
- border: 0px 0px 1px 0px;
- }
- .bugList-level4 {
- border: 0px 1px 1px 1px;
- }
-
- .bugList-level4-inner {
- border-style: solid;
- border-color: black;
- border-width: 0px 1px 1px 1px;
- }
- .b-r {
- font-size: 10pt; font-weight: bold; padding: 0 0 0 60px;
- }
- .b-d {
- font-weight: normal; background: #ccccc0;
- padding: 0 5px 0 5px; margin: 0px;
- }
- .b-1 {
- background: red; height: 0.5em; width: 1em;
- margin-right: 0.5em;
- }
- .b-2 {
- background: orange; height: 0.5em; width: 1em;
- margin-right: 0.5em;
- }
- .b-3 {
- background: green; height: 0.5em; width: 1em;
- margin-right: 0.5em;
- }
- .b-4 {
- background: blue; height: 0.5em; width: 1em;
- margin-right: 0.5em;
- }
-
- </style>
- <script type='text/javascript'><xsl:text disable-output-escaping='yes'><![CDATA[
- var menus = new Array('summary','info','history','listByCategories','listByPackages');
- var selectedMenuId = "summary";
- var selectedVersion = -1;
- var selectedPriority = 4;
- var lastVersion = 0;
- var includeFixedIntroducedBugs;
-
- var bPackageNamesPopulated = false;
-
- var filterContainerId = "filterWrapper";
- var historyControlContainerId = "historyControlWrapper";
- var messageContainerId = "messageContainer";
- var summaryContainerId = "summaryContainer";
- var infoContainerId = "infoContainer";
- var historyContainerId = "historyContainer";
- var listByCategoriesContainerId = "listByCategoriesContainer";
- var listByPackagesContainerId = "listByPackagesContainer";
-
- var idxCatKey = 0; var idxCatDescr = 1; var idxBugCat = 1;
- var idxCodeKey = 0; var idxCodeDescr = 1; var idxBugCode = 2;
- var idxPatternKey = 2; var idxPatternDescr = 3; var idxBugPattern = 3;
- var idxBugKey = 0; var idxBugDescr = 6;
- var idxBugClass = 6, idxBugPackage = 7;
-
- // main init function
- function init() {
- loadFilter();
- selectMenu(selectedMenuId);
- lastVersion = versions.length - 1;
- }
-
- // menu callback function
- function selectMenu(menuId) {
- document.getElementById(selectedMenuId).className="none";
- document.getElementById(menuId).className="current";
- if (menuId!=selectedMenuId) {
- hideMenu(selectedMenuId);
- selectedMenuId = menuId;
- }
- if (menuId=="summary") displaySummary();
- if (menuId=="info") displayInfo();
- if (menuId=="history") displayHistory();
- if (menuId=="listByCategories") displayListByCategories();
- if (menuId=="listByPackages") displayListByPackages();
- }
-
- // display filter
- function loadFilter() {
- var versionsBox = document.findbugsForm.versions.options;
- versionsBox[0] = new Option(" -- All Versions -- ","-1");
- versionsBox.selectedIndex = 0;
- if (versions.length>=1) {
- for (x=0; versions.length>1 && x<versions.length; x++) {
- versionsBox[x+1] = new Option(" Bugs at release: "+versions[versions.length-x-1][1], versions[versions.length-x-1][0]);
- }
- }
-
- var prioritiesBox = document.findbugsForm.priorities.options;
- prioritiesBox[0] = new Option(" -- All priorities -- ", "4");
- prioritiesBox[1] = new Option(" P1 bugs ", "1");
- prioritiesBox[2] = new Option(" P1 and P2 bugs ", "2");
- prioritiesBox[3] = new Option(" P1, P2 and P3 bugs ", "3");
- }
-
- // display a message
- function displayMessage(msg) {
- var container = document.getElementById(messageContainerId);
- container.innerHTML = "<div class='message'>"+msg+"</div>";
- }
-
- // reset displayed message
- function resetMessage() {
- var container = document.getElementById(messageContainerId);
- container.innerHTML = "";
- }
-
- function hideMenu(menuId) {
- var container = menuId+"Container";
- document.getElementById(container).style.display="none";
- }
-
- // filter callback function
- function filter() {
- var versionsBox = document.findbugsForm.versions.options;
- selectedVersion = versionsBox[versionsBox.selectedIndex].value;
-
- var prioritiesBox = document.findbugsForm.priorities.options;
- selectedPriority = prioritiesBox[prioritiesBox.selectedIndex].value;
-
- selectMenu(selectedMenuId);
- }
-
- // includeFixedBugs callback function
- function includeFixedIntroducedBugsInHistory() {
- includeFixedIntroducedBugs =
- document.findbugsHistoryControlForm.includeFixedIntroducedBugs.checked;
-
- selectMenu(selectedMenuId);
- }
-
- // display summary tab
- function displaySummary() {
- resetMessage();
- hide(filterContainerId);
- hide(historyControlContainerId);
- var container = document.getElementById(summaryContainerId);
- container.style.display="block";
- }
-
- // display info tab
- function displayInfo() {
- resetMessage();
- hide(filterContainerId);
- hide(historyControlContainerId);
- var container = document.getElementById(infoContainerId);
- container.style.display="block";
- }
-
- // display history tab
- function displayHistory() {
- displayMessage("Loading history...");
- hide(filterContainerId);
- show(historyControlContainerId);
- var container = document.getElementById(historyContainerId);
- var content = "";
- var i=0;
- var p = [0,0,0,0,0];
- var f = [0,0,0,0,0];
-
- content += "<table><tr><th>Release</th><th>Bugs</th><th>Bugs p1</th><th>Bugs p2</th><th>Bugs p3</th><th>Bugs Exp.</th></tr>";
-
- var aSpan = "<span title='Bugs introduced in this release that have not been fixed.'>";
- var fSpan = "<span title='Bugs fixed in this release.'>";
- var fiSpan = "<span title='Bugs introduced in this release that were fixed in later releases.'>";
- var afiSpan = "<span title='Total number of bugs introduced in this release.'>";
- var eSpan = "</span>";
-
- if(includeFixedIntroducedBugs) {
- for (i=(versions.length-1); i>0; i--) {
- v = countBugsVersion(i, 4);
- t = countTotalBugsVersion(i);
- o = countFixedButActiveBugsVersion(i);
- f = countFixedBugsInVersion(i);
- fi = countFixedBugsIntroducedInVersion(i);
- content += "<tr>";
- content += "<td class='summary-name'>" + versions[i][1] + "</td>";
- content += "<td class='summary-priority-all'> " + (t[0] + o[0]) + " (+" + afiSpan + (v[0] + fi[0]) + eSpan +
- " [" + aSpan + v[0] + eSpan + " / " + fiSpan + fi[0] + eSpan + "] " + eSpan + " / -" + fSpan + f[0] + eSpan + ") </td>";
- content += "<td class='summary-priority-1'> " + (t[1] + o[1]) + " (+" + afiSpan + (v[1] + fi[1]) + eSpan +
- " [" + aSpan + v[1] + eSpan + " / " + fiSpan + fi[1] + eSpan + "] " + eSpan + " / -" + fSpan + f[1] + eSpan + ") </td>";
- content += "<td class='summary-priority-2'> " + (t[2] + o[2]) + " (+" + afiSpan + (v[2] + fi[2]) + eSpan +
- " [" + aSpan + v[2] + eSpan + " / " + fiSpan + fi[2] + eSpan + "] " + eSpan + " / -" + fSpan + f[2] + eSpan + ") </td>";
- content += "<td class='summary-priority-3'> " + (t[3] + o[3]) + " (+" + afiSpan + (v[3] + fi[3]) + eSpan +
- " [" + aSpan + v[3] + eSpan + " / " + fiSpan + fi[3] + eSpan + "] " + eSpan + " / -" + fSpan + f[3] + eSpan + ") </td>";
- content += "<td class='summary-priority-4'> " + (t[4] + o[4]) + " (+" + afiSpan + (v[4] + fi[4]) + eSpan +
- " [" + aSpan + v[4] + eSpan + " / " + fiSpan + fi[4] + eSpan + "] " + eSpan + " / -" + fSpan + f[4] + eSpan + ") </td>";
- content += "</tr>";
- }
- } else {
- for (i=(versions.length-1); i>0; i--) {
- v = countBugsVersion(i, 4);
- t = countTotalBugsVersion(i);
- o = countFixedButActiveBugsVersion(i);
- f = countFixedBugsInVersion(i);
- content += "<tr>";
- content += "<td class='summary-name'>" + versions[i][1] + "</td>";
- content += "<td class='summary-priority-all'> " + (t[0] + o[0]) + " (+" + aSpan + v[0] + eSpan + " / -" + fSpan + f[0] + eSpan + ") </td>";
- content += "<td class='summary-priority-1' > " + (t[1] + o[1]) + " (+" + aSpan + v[1] + eSpan + " / -" + fSpan + f[1] + eSpan + ") </td>";
- content += "<td class='summary-priority-2' > " + (t[2] + o[2]) + " (+" + aSpan + v[2] + eSpan + " / -" + fSpan + f[2] + eSpan + ") </td>";
- content += "<td class='summary-priority-3' > " + (t[3] + o[3]) + " (+" + aSpan + v[3] + eSpan + " / -" + fSpan + f[3] + eSpan + ") </td>";
- content += "<td class='summary-priority-4' > " + (t[4] + o[4]) + " (+" + aSpan + v[4] + eSpan + " / -" + fSpan + f[4] + eSpan + ") </td>";
- content += "</tr>";
- }
- }
-
- t = countTotalBugsVersion(0);
- o = countFixedButActiveBugsVersion(0);
- content += "<tr>";
- content += "<td class='summary-name'>" + versions[0][1] + "</td>";
- content += "<td class='summary-priority-all'> " + (t[0] + o[0]) + " </td>";
- content += "<td class='summary-priority-1' > " + (t[1] + o[1]) + " </td>";
- content += "<td class='summary-priority-2' > " + (t[2] + o[2]) + " </td>";
- content += "<td class='summary-priority-3' > " + (t[3] + o[3]) + " </td>";
- content += "<td class='summary-priority-4' > " + (t[4] + o[4]) + " </td>";
- content += "</tr>";
-
- content += "</table>";
- container.innerHTML = content;
- container.style.display="block";
- resetMessage();
- }
-
- // display list by cat tab
- function displayListByCategories() {
- hide(historyControlContainerId);
- show(filterContainerId);
- var container = document.getElementById(listByCategoriesContainerId);
- container.innerHTML = "";
- container.style.display="block";
- displayMessage("Loading stats (categories)...");
- container.innerHTML = displayLevel1("lbc", "Stats by Bug Categories");
- resetMessage();
- }
-
- // display list by package tab
- function displayListByPackages() {
- hide(historyControlContainerId);
- show(filterContainerId);
- var container = document.getElementById(listByPackagesContainerId);
- container.style.display="block";
- if (!bPackageNamesPopulated) {
- displayMessage("Initializing...");
- populatePackageNames();
- }
- displayMessage("Loading stats (packages)...");
- container.innerHTML = displayLevel1("lbp", "Stats by Bug Package");
- resetMessage();
- }
-
- // callback function for list item click
- function toggleList(listType, containerId, id1, id2, id3) {
- var container = document.getElementById(containerId);
- if (container.style.display=="block") {
- container.style.display="none";
- } else {
- if (listType=="lbc") {
- if (id1.length>0 && id2.length==0 && id3.length==0) {
- displayCategoriesCodes(containerId, id1);
- } else if (id1.length>0 && id2.length>0 && id3.length==0) {
- displayCategoriesCodesPatterns(containerId, id1, id2);
- } else if (id1.length>0 && id2.length>0 && id3.length>0) {
- displayCategoriesCodesPatternsBugs(containerId, id1, id2, id3);
- } else {
- // ???
- }
- } else if (listType=="lbp") {
- if (id1.length>0 && id2.length==0 && id3.length==0) {
- displayPackageCodes(containerId, id1);
- } else if (id1.length>0 && id2.length>0 && id3.length==0) {
- displayPackageClassPatterns(containerId, id1, id2);
- } else if (id1.length>0 && id2.length>0 && id3.length>0) {
- displayPackageClassPatternsBugs(containerId, id1, id2, id3);
- } else {
- // ???
- }
- } else {
- // ????
- }
- }
- }
-
- // list by categories, display bug cat>codes
- function displayCategoriesCodes(containerId, catId) {
- displayMessage("Loading stats (codes)...");
- var container = document.getElementById(containerId);
- container.style.display="block";
- if (container.innerHTML=="Loading..." || container.innerHTML=="") {
- container.innerHTML = displayLevel2("lbc", catId);
- }
- resetMessage();
- }
-
- // list by categories, display bug package>codes
- function displayPackageCodes(containerId, packageId) {
- displayMessage("Loading stats (codes)...");
- var container = document.getElementById(containerId);
- container.style.display="block";
- if (container.innerHTML=="Loading..." || container.innerHTML=="") {
- container.innerHTML = displayLevel2("lbp", packageId);
- }
- resetMessage();
- }
-
- // list by categories, display bug cat>codes>patterns
- function displayCategoriesCodesPatterns(containerId, catId, codeId) {
- displayMessage("Loading stats (patterns)...");
- var container = document.getElementById(containerId);
- container.style.display="block";
- if (container.innerHTML=="Loading..." || container.innerHTML=="")
- container.innerHTML = displayLevel3("lbc", catId, codeId);
- resetMessage();
- }
-
- // list by package, display bug package>class>patterns
- function displayPackageClassPatterns(containerId, packageId, classId) {
- displayMessage("Loading stats (patterns)...");
- var container = document.getElementById(containerId);
- container.style.display="block";
- if (container.innerHTML=="Loading..." || container.innerHTML=="")
- container.innerHTML = displayLevel3("lbp", packageId, classId);
- resetMessage();
- }
-
- // list by categories, display bug cat>codes>patterns>bugs
- function displayCategoriesCodesPatternsBugs(containerId, catId, codeId, patternId) {
- displayMessage("Loading stats (bugs)...");
- var container = document.getElementById(containerId);
- container.style.display="block";
- if (container.innerHTML=="Loading..." || container.innerHTML=="")
- container.innerHTML = displayLevel4("lbc", catId, codeId, patternId);
- resetMessage();
- }
-
- // list by package, display bug package>class>patterns>bugs
- function displayPackageClassPatternsBugs(containerId, packageId, classId, patternId) {
- displayMessage("Loading stats (bugs)...");
- var container = document.getElementById(containerId);
- container.style.display="block";
- if (container.innerHTML=="Loading..." || container.innerHTML=="")
- container.innerHTML = displayLevel4("lbp", packageId, classId, patternId);
- resetMessage();
- }
-
- // generate level 1 list
- function displayLevel1(list, title) {
- var content = "";
- var content2 = "";
-
- content += "<h3>"+title+"</h3>";
- content += getPriorityLegend();
- content2 += "<div class='bugList'>";
-
- var id = "";
- var containerId = "";
- var subContainerId = "";
- var prefixSub = "";
- var prefixId = "";
- var p = [0,0,0,0,0];
- var numberOfBugs = 0;
- var label = "";
- var max = 0;
- if (list=="lbc") {
- max = categories.length;
- } else if (list=="lbp") {
- max = packageStats.length;
- }
-
- for (var x=0; x<max -1; x++) {
- if (list=="lbp" && packageStats[x][1]=="0") continue;
-
- if (list=="lbc") {
- id = categories[x][idxCatKey];
- label = categories[x][idxCatDescr];
- containerId = "categories-" + id;
- subContainerId = "cat-"+id;
- p = countBugsCat(selectedVersion, selectedPriority, id, idxBugCat);
- }
- if (list=="lbp") {
- id = packageStats[x][0];
- label = packageStats[x][0];
- containerId = "packages-" + id;
- subContainerId = "package-"+id;
- p = countBugsPackage(selectedVersion, selectedPriority, id, idxBugPackage);
- }
-
- subContainerId = prefixSub+id;
-
- var total = p[1]+p[2]+p[3]+p[4];
- if (total > 0) {
- content2 += addListItem( 1, containerId, label, total, p, subContainerId,
- "toggleList('" + list + "', '" + subContainerId + "', '"+ id + "', '', '')"
- );
- }
- numberOfBugs += total;
- }
- content2 += "</div>";
- content += "<h4>Total number of bugs";
- if (selectedVersion!=-1) {
- content += " (introduced in release " + versions[selectedVersion][1] +")";
- }
- content += ": "+numberOfBugs+"</h4>";
- return content+content2;
- }
-
- // generate level 2 list
- function displayLevel2(list, id1) {
- var content = "";
- var code = "";
- var containerId = "";
- var subContainerId = "";
- var p = [0,0,0,0,0];
- var max = 0;
- var id2 = "";
- if (list=="lbc") {
- max = codes.length;
- } else if (list=="lbp") {
- max = classStats.length;
- }
-
- for (var x=0; x<max -1; x++) {
- if (list=="lbp" && classStats[x][3]=="0") continue;
-
- if (list=="lbc") {
- id2 = codes[x][idxCodeKey];
- label = codes[x][idxCodeDescr];
- containerId = "codes-"+id1;
- subContainerId = "cat-" + id1 + "-code-" + id2;
- p = countBugsCode(selectedVersion, selectedPriority, id1, idxBugCat, id2, idxBugCode);
- }
- if (list=="lbp") {
- id2 = classStats[x][0];
- label = classStats[x][0];
- containerId = "packages-"+id1;
- subContainerId = "package-" + id1 + "-class-" + id2;
- p = countBugsClass(selectedVersion, selectedPriority, id1, idxBugPackage, id2, idxBugClass);
- }
-
- var total = p[1]+p[2]+p[3]+p[4];
- if (total > 0) {
- content += addListItem( 2, containerId, label, total, p, subContainerId,
- "toggleList('"+ list + "', '" + subContainerId + "', '"+ id1 + "', '"+ id2 + "', '')"
- );
- }
- }
- return content;
- }
-
- // generate level 3 list
- function displayLevel3(list, id1, id2) {
- var content = "";
- var containerId = "";
- var subContainerId = "";
- var p = [0,0,0,0,0];
- var max = 0;
- var label = "";
- var id3 = "";
-
- if (list=="lbc") {
- max = patterns.length;
- } else if (list=="lbp") {
- max = patterns.length;
- }
-
- for (var x=0; x<max -1; x++) {
- //if (list=="lbp" && (patterns[x][0]!=id1 || patterns[x][1]!=id2)) continue;
- //if (list=="lbp" && classStats[x][3]=="0") continue;
-
- if (list=="lbc") {
- id3 = patterns[x][idxPatternKey];;
- label = patterns[x][idxPatternDescr];
- containerId = "patterns-"+id1;
- subContainerId = "cat-" + id1 + "-code-" + id2 + "-pattern-" + id3;
- p = countBugsPattern(selectedVersion, selectedPriority, id1, idxBugCat, id2, idxBugCode, id3, idxBugPattern);
- }
- if (list=="lbp") {
- id3 = patterns[x][idxPatternKey];;
- label = patterns[x][idxPatternDescr];
- containerId = "classpatterns-"+id1;
- subContainerId = "package-" + id1 + "-class-" + id2 + "-pattern-" + id3;
- p = countBugsClassPattern(selectedVersion, selectedPriority, id2, idxBugClass, id3, idxBugPattern);
- }
-
- var total = p[1]+p[2]+p[3]+p[4];
- if (total > 0) {
- content += addListItem( 3, containerId, label, total, p, subContainerId,
- "toggleList('" + list + "', '" + subContainerId + "', '"+ id1 + "', '"+ id2 + "', '"+ id3 + "')"
- );
- }
- }
- return content;
- }
-
- // generate level 4 list
- function displayLevel4(list, id1, id2, id3) {
- var content = "";
- var bug = "";
- var bugP = 0;
- var containerId = "";
- var subContainerId = "";
- var bugId = "";
- var label = "";
- var p = [0,0,0,0,0];
- for (var x=0; x<bugs.length -1; x++) {
- bug = bugs[x];
- if (list=="lbc") {
- if ( bug[1]!=id1 || bug[2]!=id2 || bug[3]!=id3 ) continue;
- if ( selectedVersion!=-1
- && selectedVersion!=bug[5]) continue;
- if ( selectedPriority!=4
- && selectedPriority<bug[4]) continue;
-
- subContainerId = "cat-" + id1 + "-code-" + id2 + "-pattern-" + id3 + "-bug-" + bug[0];
- }
- if (list=="lbp") {
- if ( bug[7]!=id1 || bug[6]!=id2 || bug[3]!=id3 ) continue;
- if ( selectedVersion!=-1
- && selectedVersion!=bug[5]) continue;
- if ( selectedPriority!=4
- && selectedPriority<bug[4]) continue;
-
- subContainerId = "package-" + id1 + "-class-" + id2 + "-pattern-" + id3 + "-bug-" + bug[0];
- }
-
- bugId = "b-uid-" + bug[0];
- label = bug[idxBugDescr];
- containerId = "bugs-"+bugId;
- bugP = bug[4];
- p[bugP]++;
- var total = p[1]+p[2]+p[3]+p[4];
- if (total > 0) {
- content += addBug( 4, containerId, label, bugP, bug[5], subContainerId,
- "showbug('" + bugId + "', '" + subContainerId + "', '"+id3+"')");
- }
- }
- return content;
- }
-
-
- function addListItem(level, id, label, total, p, subId, onclick) {
- var content = "";
-
- content += "<div class='bugList-level"+level+"' >";
- content += "<div class='bugList-level"+level+"-label' id='"+id+"' >";
- content += "<a href='' onclick=\"" + onclick + ";return false;\" ";
- content += ">";
- content += "<strong>"+label+"</strong>";
- content += " "+total+" bugs";
- if (selectedPriority>1)
- content += " <em>("+p[1];
- if (selectedPriority>=2)
- content += "/"+p[2];
- if (selectedPriority>=3)
- content += "/"+p[3];
- if (selectedPriority>=4)
- content += "/"+p[4];
- if (selectedPriority>1)
- content += ")</em>";
- content += "</a>";
- content += "</div>";
- content += "<div class='bugList-level"+level+"-inner' id='"+subId+"' style='display:none;'>Loading...</div>";
- content += "</div>";
- return content;
- }
-
- function addBug( level, id, label, p, version, subId, onclick) {
- var content = "";
-
- content += "<div class='bugList-level" + level + "' id='" + id + "'>";
- content += "<div class='bugList-level" + level + "-label' id='" + id + "'>";
- content += "<span class='b-" + p + "'> </span>";
- content += "<a href='' onclick=\"" + onclick + ";return false;\">";
- if (version==lastVersion) {
- content += "<span style='color:red;font-weight:bold;'>NEW!</span> ";
- }
- content += "<strong>" + label + "</strong>";
- if (version==0) {
- content += " <em>since release first historized release</em>";
- } else {
- content += " <em>since release " + versions[version][1] + "</em>";
- }
- content += "</a>";
- content += "</div>";
- content += "<div class='bugList-level" + level + "-inner' id='" + subId + "' style='display:none;'>Loading...</div>";
- content += "</div>";
- return content;
- }
-
- function countBugsVersion(version, priority) {
- return countBugs(version, priority, "", -1, "", -1, "", -1, "", -1, "", -1);
- }
-
- function countBugsCat(version, priority, cat, idxCat) {
- return countBugs(version, priority, cat, idxCat, "", -1, "", -1, "", -1, "", -1);
- }
-
- function countBugsPackage(version, priority, packageId, idxPackage) {
- return countBugs(version, priority, "", -1, "", -1, "", -1, packageId, idxPackage, "", -1);
- }
-
- function countBugsCode(version, priority, cat, idxCat, code, idxCode) {
- return countBugs(version, priority, cat, idxCat, code, idxCode, "", -1, "", -1, "", -1);
- }
-
- function countBugsPattern(version, priority, cat, idxCat, code, idxCode, packageId, idxPattern) {
- return countBugs(version, priority, cat, idxCat, code, idxCode, packageId, idxPattern, "", -1, "", -1);
- }
-
- function countBugsClass(version, priority, id1, idxBugPackage, id2, idxBugClass) {
- return countBugs(version, priority, "", -1, "", -1, "", -1, id1, idxBugPackage, id2, idxBugClass);
- }
-
- function countBugsClassPattern(version, priority, id2, idxBugClass, id3, idxBugPattern) {
- return countBugs(version, priority, "", -1, "", -1, id3, idxBugPattern, "", -1, id2, idxBugClass);
- }
-
- function countBugs(version, priority, cat, idxCat, code, idxCode, pattern, idxPattern, packageId, idxPackage, classId, idxClass) {
- var count = [0,0,0,0,0];
- var last=1000000;
- for (var x=0; x<bugs.length-1; x++) {
- var bug = bugs[x];
-
- var bugCat = bug[idxCat];
- var bugP = bug[4];
- var bugCode = bug[idxCode];
- var bugPattern = bug[idxPattern];
-
- if ( (version==-1 || version==bug[5])
- && (priority==4 || priority>=bug[4])
- && (idxCat==-1 || bug[idxCat]==cat)
- && (idxCode==-1 || bug[idxCode]==code)
- && (idxPattern==-1 || bug[idxPattern]==pattern)
- && (idxPackage==-1 || bug[idxPackage]==packageId)
- && (idxClass==-1 || bug[idxClass]==classId)
- ) {
- count[bug[4]]++;
- }
- }
- count[0] = count[1] + count[2] + count[3] + count[4];
- return count;
- }
-
- function countFixedBugsInVersion(version) {
- var count = [0,0,0,0,0];
- var last=1000000;
- for (var x=0; x<fixedBugs.length-1; x++) {
- var bug = fixedBugs[x];
-
- var bugP = bug[4];
-
- if ( version==-1 || version==(bug[6]+1)) {
- count[bug[4]]++;
- }
- }
- count[0] = count[1] + count[2] + count[3] + count[4];
- return count;
- }
-
- function countFixedBugsIntroducedInVersion(version) {
- var count = [0,0,0,0,0];
- var last=1000000;
- for (var x=0; x<fixedBugs.length-1; x++) {
- var bug = fixedBugs[x];
-
- var bugP = bug[4];
-
- if ( version==-1 || version==(bug[5])) {
- count[bug[4]]++;
- }
- }
- count[0] = count[1] + count[2] + count[3] + count[4];
- return count;
- }
-
- function countFixedButActiveBugsVersion(version) {
- var count = [0,0,0,0,0];
- var last=1000000;
- for (var x=0; x<fixedBugs.length-1; x++) {
- var bug = fixedBugs[x];
-
- var bugP = bug[4];
-
- if ( version==-1 || (version >=bug[5] && version<=bug[6]) ) {
- count[bug[4]]++;
- }
- }
- count[0] = count[1] + count[2] + count[3] + count[4];
- return count;
- }
-
- function countTotalBugsVersion(version) {
- var count = [0,0,0,0,0];
- var last=1000000;
- for (var x=0; x<bugs.length-1; x++) {
- var bug = bugs[x];
-
- var bugP = bug[4];
-
- if (version==-1 || version>=bug[5]) {
- count[bug[4]]++;
- }
- }
- count[0] = count[1] + count[2] + count[3] + count[4];
- return count;
- }
-
- function getPriorityLegend() {
- var content = "";
- content += "<h5><span class='b-1'> </span> P1 ";
- content += "<span class='b-2'> </span> P2 ";
- content += "<span class='b-3'> </span> P3 ";
- content += "<span class='b-4'> </span> Exp ";
- content += "</h5>";
- return content;
- }
-
- function populatePackageNames() {
- for (var i=0; i<bugs.length; i++) {
- var classId = bugs[i][6];
- var idx = classId.lastIndexOf('.');
- var packageId = "";
-
- if (idx>0) {
- packageId = classId.substring(0, idx);
- }
-
- bugs[i][7] = packageId;
- }
- }
-
- function showbug(bugId, containerId, patternId) {
- var bugplaceholder = document.getElementById(containerId);
- var bug = document.getElementById(bugId);
-
- if ( bugplaceholder==null) {
- alert(buguid+'-ph-'+list+' - '+buguid+' - bugplaceholder==null');
- return;
- }
- if ( bug==null) {
- alert(buguid+'-ph-'+list+' - '+buguid+' - bug==null');
- return;
- }
-
- var newBug = bug.innerHTML;
- var pattern = document.getElementById('tip-'+patternId).innerHTML;
- toggle(containerId);
- bugplaceholder.innerHTML = newBug + pattern;
- }
- function toggle(foo) {
- if( document.getElementById(foo).style.display == "none") {
- show(foo);
- } else {
- if( document.getElementById(foo).style.display == "block") {
- hide(foo);
- } else {
- show(foo);
- }
- }
- }
- function show(foo) {
- document.getElementById(foo).style.display="block";
- }
- function hide(foo) {
- document.getElementById(foo).style.display="none";
- }
-
- window.onload = function(){
- init();
- };
- ]]></xsl:text></script>
- <script type='text/javascript'>
- // versions fields: release id, release label
- var versions = new Array(
- <xsl:for-each select="/BugCollection/History/AppVersion">
- [ "<xsl:value-of select="@sequence" />", "<xsl:value-of select="@release" />" ],
- </xsl:for-each>
- [ "<xsl:value-of select="/BugCollection/@sequence" />", "<xsl:value-of select="/BugCollection/@release" />" ]
- );
-
- // categories fields: category id, category label
- var categories = new Array(
- <xsl:for-each select="/BugCollection/BugCategory">
- <xsl:sort select="@category" order="ascending" />
- [ "<xsl:value-of select="@category" />", "<xsl:value-of select="Description" />" ],
- </xsl:for-each>
- [ "", "" ]
- );
-
- // codes fields: code id, code label
- var codes = new Array(
- <xsl:for-each select="/BugCollection/BugCode">
- <xsl:sort select="@abbrev" order="ascending" />
- [ "<xsl:value-of select="@abbrev" />", "<xsl:value-of select="Description" />" ],
- </xsl:for-each>
- [ "", "" ]
- );
-
- // patterns fields: category id, code id, pattern id, pattern label
- var patterns = new Array(
- <xsl:for-each select="/BugCollection/BugPattern">
- <xsl:sort select="@type" order="ascending" />
- [ "<xsl:value-of select="@category" />", "<xsl:value-of select="@abbrev" />", "<xsl:value-of select="@type" />", "<xsl:value-of select="translate(ShortDescription, '"', $apos)" />" ],
-
- </xsl:for-each>
- [ "", "", "", "" ]
- );
-
- // class stats fields: class name, package name, isInterface, total bugs, bugs p1, bugs p2, bugs p3, bugs p4
- var classStats = new Array(
- <xsl:for-each select="/BugCollection/FindBugsSummary/PackageStats/ClassStats">
- <xsl:sort select="@class" order="ascending" />
- [ "<xsl:value-of select="@class" />", "<xsl:value-of select="../@package" />", "<xsl:value-of select="@interface" />", "<xsl:value-of select="@bugs" />", "<xsl:value-of select="@priority_1" />", "<xsl:value-of select="@priority_2" />", "<xsl:value-of select="@priority_3" />", "<xsl:value-of select="@priority_4" />" ],
- </xsl:for-each>
- [ "", "", "", "", "", "", "", "" ]
- );
-
- // package stats fields: package name, total bugs, bugs p1, bugs p2, bugs p3, bugs p4
- var packageStats = new Array(
- <xsl:for-each select="/BugCollection/FindBugsSummary/PackageStats">
- <xsl:sort select="@package" order="ascending" />
- [ "<xsl:value-of select="@package" />", "<xsl:value-of select="@total_bugs" />", "<xsl:value-of select="@priority_1" />", "<xsl:value-of select="@priority_2" />", "<xsl:value-of select="@priority_3" />", "<xsl:value-of select="@priority_4" />" ],
- </xsl:for-each>
- [ "", "", "", "", "", "" ]
- );
-
-
- // bugs fields: bug id, category id, code id, pattern id, priority, release id, class name, packagename (populated by javascript)
- var bugs = new Array(
- <xsl:for-each select="/BugCollection/BugInstance[string-length(@last)=0]">
-
- [ "<xsl:value-of select="@instanceHash" />-<xsl:value-of select="@instanceOccurrenceNum" />",
- "<xsl:value-of select="@category" />",
- "<xsl:value-of select="@abbrev" />",
- "<xsl:value-of select="@type" />",
- <xsl:value-of select="@priority" />,
- <xsl:choose><xsl:when test='string-length(@first)=0'>0</xsl:when><xsl:otherwise><xsl:value-of select="@first" /></xsl:otherwise></xsl:choose>,
- "<xsl:value-of select="Class/@classname" />",
- ""],
- </xsl:for-each>
- [ "", "", "", "", 0, 0, "", "" ]
- );
-
- // bugs fields: bug id, category id, code id, pattern id, priority, first release id, fixed release id, class name
- var fixedBugs = new Array(
- <xsl:for-each select="/BugCollection/BugInstance[string-length(@last)>0]">
-
- [ "<xsl:value-of select="@instanceHash" />-<xsl:value-of select="@instanceOccurrenceNum" />",
- "<xsl:value-of select="@category" />",
- "<xsl:value-of select="@abbrev" />",
- "<xsl:value-of select="@type" />",
- <xsl:value-of select="@priority" />,
- <xsl:choose><xsl:when test='string-length(@first)=0'>0</xsl:when><xsl:otherwise><xsl:value-of select="@first" /></xsl:otherwise></xsl:choose>,
- <xsl:choose><xsl:when test='string-length(@last)>0'><xsl:value-of select="@last" /></xsl:when><xsl:otherwise>-42</xsl:otherwise></xsl:choose>,
- "<xsl:value-of select="Class/@classname" />" ],
- </xsl:for-each>
- [ "", "", "", "", 0, 0, 0, "" ]
- );
-
- </script>
- </head>
- <body>
- <h3>
- <a href="http://findbugs.sourceforge.net">FindBugs</a> (<xsl:value-of select="/BugCollection/@version" />)
- Analysis for
- <xsl:choose>
- <xsl:when test='string-length(/BugCollection/Project/@projectName)>0'><xsl:value-of select="/BugCollection/Project/@projectName" /></xsl:when>
- <xsl:otherwise><xsl:value-of select="/BugCollection/Project/@filename" /></xsl:otherwise>
- </xsl:choose>
- </h3>
-
- <div id='menuWrapper' style=''>
- <div id="navcontainer">
- <ul id="navlist">
- <li><a id='summary' class="current" href="#" onclick="selectMenu('summary'); return false;" >Summary</a></li>
- <li><a id='history' class="none" href="#" onclick="selectMenu('history'); return false;" >History</a></li>
- <li><a id='listByCategories' class="none" href="#" onclick="selectMenu('listByCategories'); return false;">Browse By Categories</a></li>
- <li><a id='listByPackages' class="none" href="#" onclick="selectMenu('listByPackages'); return false;" >Browse by Packages</a></li>
- <li><a id='info' class="none" href="#" onclick="selectMenu('info'); return false;" >Info</a></li>
- </ul>
- </div>
- </div>
-
- <div id='displayWrapper'>
-
- <div style='height:25px;'>
- <div id='messageContainer' style='float:right;'>
- Computing data...
- </div>
- <div id='filterWrapper' style='display:none;'>
- <form name='findbugsForm'>
- <div id='filterContainer' >
- <select name='versions' onchange='filter()'>
- <option value="loading">Loading filter...</option>
- </select>
- <select name='priorities' onchange='filter()'>
- <option value="loading">Loading filter...</option>
- </select>
- </div>
- </form>
- </div>
- <div id='historyControlWrapper' style='display:none;'>
- <form name="findbugsHistoryControlForm">
- <div id='historyControlContainer'>
- <input type='checkbox' name='includeFixedIntroducedBugs'
- value='checked' alt='Include fixed introduced bugs.'
- onclick='includeFixedIntroducedBugsInHistory()' />
- Include counts of introduced bugs that were fixed in later releases.
- </div>
- </form>
- </div>
- </div>
- <div id='summaryContainer' class='displayContainer'>
- <h3>Package Summary</h3>
- <table>
- <tr>
- <th>Package</th>
- <th>Code Size</th>
- <th>Bugs</th>
- <th>Bugs p1</th>
- <th>Bugs p2</th>
- <th>Bugs p3</th>
- <th>Bugs Exp.</th>
- </tr>
- <tr>
- <td class='summary-name'>
- Overall
- (<xsl:value-of select="/BugCollection/FindBugsSummary/@num_packages" /> packages),
- (<xsl:value-of select="/BugCollection/FindBugsSummary/@total_classes" /> classes)
- </td>
- <td class='summary-size'><xsl:value-of select="/BugCollection/FindBugsSummary/@total_size" /></td>
- <td class='summary-priority-all'><xsl:value-of select="/BugCollection/FindBugsSummary/@total_bugs" /></td>
- <td class='summary-priority-1'><xsl:value-of select="/BugCollection/FindBugsSummary/@priority_1" /></td>
- <td class='summary-priority-2'><xsl:value-of select="/BugCollection/FindBugsSummary/@priority_2" /></td>
- <td class='summary-priority-3'><xsl:value-of select="/BugCollection/FindBugsSummary/@priority_3" /></td>
- <td class='summary-priority-4'><xsl:value-of select="/BugCollection/FindBugsSummary/@priority_4" /></td>
- </tr>
- <xsl:for-each select="/BugCollection/FindBugsSummary/PackageStats">
- <xsl:sort select="@package" order="ascending" />
- <xsl:if test="@total_bugs!='0'" >
- <tr>
- <td class='summary-name'><xsl:value-of select="@package" /></td>
- <td class='summary-size'><xsl:value-of select="@total_size" /></td>
- <td class='summary-priority-all'><xsl:value-of select="@total_bugs" /></td>
- <td class='summary-priority-1'><xsl:value-of select="@priority_1" /></td>
- <td class='summary-priority-2'><xsl:value-of select="@priority_2" /></td>
- <td class='summary-priority-3'><xsl:value-of select="@priority_3" /></td>
- <td class='summary-priority-4'><xsl:value-of select="@priority_4" /></td>
- </tr>
- </xsl:if>
- </xsl:for-each>
- </table>
- </div>
-
- <div id='infoContainer' class='displayContainer'>
- <div id='analyzed-files'>
- <h3>Analyzed Files:</h3>
- <ul>
- <xsl:for-each select="/BugCollection/Project/Jar">
- <li><xsl:apply-templates /></li>
- </xsl:for-each>
- </ul>
- </div>
- <div id='used-libraries'>
- <h3>Used Libraries:</h3>
- <ul>
- <xsl:for-each select="/BugCollection/Project/AuxClasspathEntry">
- <li><xsl:apply-templates /></li>
- </xsl:for-each>
- <xsl:if test="count(/BugCollection/Project/AuxClasspathEntry)=0" >
- <li>None</li>
- </xsl:if>
- </ul>
- </div>
- <div id='analysis-error'>
- <h3>Analysis Errors:</h3>
- <ul>
- <xsl:variable name="error-count"
- select="count(/BugCollection/Errors/MissingClass)" />
- <xsl:if test="$error-count=0" >
- <li>None</li>
- </xsl:if>
- <xsl:if test="$error-count>0" >
- <li>Missing ref classes for analysis:
- <ul>
- <xsl:for-each select="/BugCollection/Errors/MissingClass">
- <li><xsl:apply-templates /></li>
- </xsl:for-each>
- </ul>
- </li>
- </xsl:if>
- </ul>
- </div>
- </div>
- <div id='historyContainer' class='displayContainer'>Loading...</div>
- <div id='listByCategoriesContainer' class='displayContainer'>Loading...</div>
- <div id='listByPackagesContainer' class='displayContainer'>Loading...</div>
- </div>
-
- <div id='bug-collection' style='display:none;'>
- <!-- advanced tooltips -->
- <xsl:for-each select="/BugCollection/BugPattern">
- <xsl:variable name="b-t"><xsl:value-of select="@type" /></xsl:variable>
- <div>
- <xsl:attribute name="id">tip-<xsl:value-of select="$b-t" /></xsl:attribute>
- <xsl:attribute name="class">tip</xsl:attribute>
- <xsl:value-of select="/BugCollection/BugPattern[@type=$b-t]/Details" disable-output-escaping="yes" />
- </div>
- </xsl:for-each>
-
- <!-- bug descriptions - hidden -->
- <xsl:for-each select="/BugCollection/BugInstance[not(@last)]">
- <div style="display:none;" class='bug'>
- <xsl:attribute name="id">b-uid-<xsl:value-of select="@instanceHash" />-<xsl:value-of select="@instanceOccurrenceNum" /></xsl:attribute>
- <xsl:for-each select="*/Message">
- <div class="b-r"><xsl:apply-templates /></div>
- </xsl:for-each>
- <div class="b-d">
- <xsl:value-of select="LongMessage" disable-output-escaping="no" />
- </div>
- </div>
- </xsl:for-each>
- </div>
- </body>
-</html>
-</xsl:template>
-
-
-</xsl:transform>
-
diff --git a/tools/findbugs-1.3.9/src/xsl/fancy.xsl b/tools/findbugs-1.3.9/src/xsl/fancy.xsl
deleted file mode 100644
index ed43d5c..0000000
--- a/tools/findbugs-1.3.9/src/xsl/fancy.xsl
+++ /dev/null
@@ -1,848 +0,0 @@
-<?xml version="1.0" encoding="UTF-8" ?>
-<!--
- Copyright (C) 2005, 2006 Etienne Giraudy, InStranet Inc
-
- This library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Lesser General Public
- License as published by the Free Software Foundation; either
- version 2.1 of the License, or (at your option) any later version.
-
- This library is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- Lesser General Public License for more details.
-
- You should have received a copy of the GNU Lesser General Public
- License along with this library; if not, write to the Free Software
- Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
--->
-
-<xsl:transform xmlns:xsl="http://www.w3.org/1999/XSL/Transform" version="1.0" >
- <xsl:output
- method="xml" indent="yes"
- doctype-system="http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"
- doctype-public="-//W3C//DTD XHTML 1.0 Transitional//EN"
- encoding="UTF-8"/>
-
- <!--
- Parameter for specifying HTMLized sources location; if current dir, use "./"
- If not passed, no links to sources are generated.
- because of back-compatibility reasons.
- The source filename should be package.class.java.html
- The source can have line no anchors like #11 -->
- <xsl:param name="htmlsrcpath"></xsl:param>
-
- <!--xsl:key name="lbc-category-key" match="/BugCollection/BugInstance" use="@category" /-->
- <xsl:key name="lbc-code-key" match="/BugCollection/BugInstance" use="concat(@category,@abbrev)" />
- <xsl:key name="lbc-bug-key" match="/BugCollection/BugInstance" use="concat(@category,@abbrev,@type)" />
- <xsl:key name="lbp-class-b-t" match="/BugCollection/BugInstance" use="concat(Class/@classname,@type)" />
-
-<xsl:template match="/" >
-
-<html>
- <head>
- <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/>
- <title>
- FindBugs (<xsl:value-of select="/BugCollection/@version" />)
- Analysis for
- <xsl:choose>
- <xsl:when test='string-length(/BugCollection/Project/@projectName)>0'><xsl:value-of select="/BugCollection/Project/@projectName" /></xsl:when>
- <xsl:otherwise><xsl:value-of select="/BugCollection/Project/@filename" /></xsl:otherwise>
- </xsl:choose>
- </title>
- <script type="text/javascript">
- function show(foo) {
- document.getElementById(foo).style.display="block";
- }
- function hide(foo) {
- document.getElementById(foo).style.display="none";
- }
- function toggle(foo) {
- if( document.getElementById(foo).style.display == "none") {
- show(foo);
- } else {
- if( document.getElementById(foo).style.display == "block") {
- hide(foo);
- } else {
- show(foo);
- }
- }
- }
-
- function showmenu(foo) {
- if( document.getElementById(foo).style.display == "none") {
- hide("bug-summary");
- document.getElementById("bug-summary-tab").className="menu-tab";
- hide("analysis-data");
- document.getElementById("analysis-data-tab").className="menu-tab";
- //hide("list-by-b-t");
- //document.getElementById("list-by-b-t-tab").className="menu-tab";
- hide("list-by-package");
- document.getElementById("list-by-package-tab").className="menu-tab";
- hide("list-by-category");
- document.getElementById("list-by-category-tab").className="menu-tab";
- document.getElementById(foo+"-tab").className="menu-tab-selected";
- show(foo);
-
- }
- // else menu already selected!
- }
- function showbug(buguid, list) {
- var bugplaceholder = document.getElementById(buguid+'-ph-'+list);
- var bug = document.getElementById(buguid);
-
- if ( bugplaceholder==null) {
- alert(buguid+'-ph-'+list+' - '+buguid+' - bugplaceholder==null');
- return;
- }
- if ( bug==null) {
- alert(buguid+'-ph-'+list+' - '+buguid+' - bug==null');
- return;
- }
-
- var oldBug = bugplaceholder.innerHTML;
- var newBug = bug.innerHTML;
- //alert(oldBug);
- //alert(newBug);
- toggle(buguid+'-ph-'+list);
- bugplaceholder.innerHTML = newBug;
- }
- </script>
- <script type='text/javascript'><xsl:text disable-output-escaping='yes'>
- /* <![CDATA[ */
- // Extended Tooltip Javascript
- // copyright 9th August 2002, 3rd July 2005
- // by Stephen Chapman, Felgall Pty Ltd
-
- // permission is granted to use this javascript provided that the below code is not altered
- var DH = 0;var an = 0;var al = 0;var ai = 0;if (document.getElementById) {ai = 1; DH = 1;}else {if (document.all) {al = 1; DH = 1;} else { browserVersion = parseInt(navigator.appVersion); if (navigator.appName.indexOf('Netscape') != -1) if (browserVersion == 4) {an = 1; DH = 1;}}}
- function fd(oi, wS) {if (ai) return wS ? document.getElementById(oi).style:document.getElementById(oi); if (al) return wS ? document.all[oi].style: document.all[oi]; if (an) return document.layers[oi];}
- function pw() {return window.innerWidth != null? window.innerWidth: document.body.clientWidth != null? document.body.clientWidth:null;}
- function mouseX(evt) {if (evt.pageX) return evt.pageX; else if (evt.clientX)return evt.clientX + (document.documentElement.scrollLeft ? document.documentElement.scrollLeft : document.body.scrollLeft); else return null;}
- function mouseY(evt) {if (evt.pageY) return evt.pageY; else if (evt.clientY)return evt.clientY + (document.documentElement.scrollTop ? document.documentElement.scrollTop : document.body.scrollTop); else return null;}
- function popUp(evt,oi) {if (DH) {var wp = pw(); ds = fd(oi,1); dm = fd(oi,0); st = ds.visibility; if (dm.offsetWidth) ew = dm.offsetWidth; else if (dm.clip.width) ew = dm.clip.width; if (st == "visible" || st == "show") { ds.visibility = "hidden"; } else {tv = mouseY(evt) + 20; lv = mouseX(evt) - (ew/4); if (lv < 2) lv = 2; else if (lv + ew > wp) lv -= ew/2; if (!an) {lv += 'px';tv += 'px';} ds.left = lv; ds.top = tv; ds.visibility = "visible";}}}
- /* ]]> */
-</xsl:text></script>
- <style type='text/css'>
- html, body {
- background-color: #ffffff;
- }
- a, a:link , a:active, a:visited, a:hover {
- text-decoration: none; color: black;
- }
- .b-r a {
- text-decoration: underline; color: blue;
- }
- div, span {
- vertical-align: top;
- }
- p {
- margin: 0px;
- }
- h1 {
- /*font-size: 14pt;*/
- color: red;
- }
- #menu {
- margin-bottom: 10px;
- }
- #menu ul {
- margin-left: 0;
- padding-left: 0;
- display: inline;
- }
- #menu ul li {
- margin-left: 0;
- margin-bottom: 0;
- padding: 2px 15px 5px;
- border: 1px solid #000;
- list-style: none;
- display: inline;
- }
- #menu ul li.here {
- border-bottom: 1px solid #ffc;
- list-style: none;
- display: inline;
- }
- .menu-tab {
- background: white;
- }
- .menu-tab:hover {
- background: grey;
- }
- .menu-tab-selected {
- background: #aaaaaa;
- }
- #analysis-data ul {
- margin-left: 15px;
- }
- #analyzed-files, #used-libraries, #analysis-error {
- margin: 2px;
- border: 1px black solid;
- padding: 2px;
- float: left;
- overflow:auto;
- }
- #analyzed-files {
- width: 25%;
- }
- #used-libraries {
- width: 25%;
- }
- #analysis-error {
- width: 40%;
- }
- div.summary {
- width:100%;
- text-align:left;
- }
- .summary table {
- border:1px solid black;
- }
- .summary th {
- background: #aaaaaa;
- color: white;
- }
- .summary th, .summary td {
- padding: 2px 4px 2px 4px;
- }
- .summary-name {
- background: #eeeeee;
- text-align:left;
- }
- .summary-size {
- background: #eeeeee;
- text-align:center;
- }
- .summary-ratio {
- background: #eeeeee;
- text-align:center;
- }
- .summary-priority-all {
- background: #dddddd;
- text-align:center;
- }
- .summary-priority-1 {
- background: red;
- text-align:center;
- }
- .summary-priority-2 {
- background: orange;
- text-align:center;
- }
- .summary-priority-3 {
- background: green;
- text-align:center;
- }
- .summary-priority-4 {
- background: blue;
- text-align:center;
- }
- .ob {
- border: 1px solid black;
- margin: 10px;
- }
- .ob-t {
- border-bottom: 1px solid #000000; font-size: 12pt; font-weight: bold;
- background: #cccccc; margin: 0; padding: 0 5px 0 5px;
- }
- .t-h {
- font-weight: normal;
- }
- .ib-1, .ib-2 {
- margin: 0 0 0 10px;
- }
- .ib-1-t, .ib-2-t {
- border-bottom: 1px solid #000000; border-left: 1px solid #000000;
- margin: 0; padding: 0 5px 0 5px;
- font-size: 12pt; font-weight: bold; background: #cccccc;
- }
- .bb {
- border-bottom: 1px solid #000000; border-left: 1px solid #000000;
- }
- .b-1 {
- background: red; height: 0.5em; width: 1em;
- margin-right: 0.5em;
- }
- .b-2 {
- background: orange; height: 0.5em; width: 1em;
- margin-right: 0.5em;
- }
- .b-3 {
- background: green; height: 0.5em; width: 1em;
- margin-right: 0.5em;
- }
- .b-4 {
- background: blue; height: 0.5em; width: 1em;
- margin-right: 0.5em;
- }
- .b-t {
- }
- .b-r {
- font-size: 10pt; font-weight: bold; padding: 0 0 0 60px;
- }
- .b-d {
- font-weight: normal; background: #eeeee0;
- padding: 0 5px 0 5px; margin: 0px;
- }
- .bug-placeholder {
- top:140px;
- border:1px solid black;
- display:none;
- }
- .tip {
- border:solid 1px #666666;
- width:600px;
- padding:3px;
- position:absolute;
- z-index:100;
- visibility:hidden;
- color:#333333;
- top:20px;
- left:90px;
- background-color:#ffffcc;
- layer-background-color:#ffffcc;
- }
-
-
- </style>
- </head>
- <body>
- <div id='content'>
- <h1>
- FindBugs (<xsl:value-of select="/BugCollection/@version" />)
- Analysis for
- <xsl:choose>
- <xsl:when test='string-length(/BugCollection/Project/@projectName)>0'><xsl:value-of select="/BugCollection/Project/@projectName" /></xsl:when>
- <xsl:otherwise><xsl:value-of select="/BugCollection/Project/@filename" /></xsl:otherwise>
- </xsl:choose>
- </h1>
- <div id="menu">
- <ul>
- <li id='bug-summary-tab' class='menu-tab-selected'>
- <xsl:attribute name="onclick">showmenu('bug-summary');return false;</xsl:attribute>
- <a href='' onclick='return false;'>Bug Summary</a>
- </li>
- <li id='analysis-data-tab' class='menu-tab'>
- <xsl:attribute name="onclick">showmenu('analysis-data');return false;</xsl:attribute>
- <a href='' onclick='return false;'>Analysis Information</a>
- </li>
- <li id='list-by-category-tab' class='menu-tab'>
- <xsl:attribute name="onclick">showmenu('list-by-category');return false;</xsl:attribute>
- <a href='' onclick='return false;'>List bugs by bug category</a>
- </li>
- <li id='list-by-package-tab' class='menu-tab'>
- <xsl:attribute name="onclick">showmenu('list-by-package');return false;</xsl:attribute>
- <a href='' onclick='return false;'>List bugs by package</a>
- </li>
- </ul>
- </div>
- <xsl:call-template name="generateSummary" />
- <xsl:call-template name="analysis-data" />
- <xsl:call-template name="list-by-category" />
- <xsl:call-template name="list-by-package" />
-
-
- <!-- advanced tooltips -->
- <xsl:for-each select="/BugCollection/BugPattern">
- <xsl:variable name="b-t"><xsl:value-of select="@type" /></xsl:variable>
- <div>
- <xsl:attribute name="id">tip-<xsl:value-of select="$b-t" /></xsl:attribute>
- <xsl:attribute name="class">tip</xsl:attribute>
- <b><xsl:value-of select="@abbrev" /> / <xsl:value-of select="@type" /></b><br/>
- <xsl:value-of select="/BugCollection/BugPattern[@type=$b-t]/Details" disable-output-escaping="yes" />
- </div>
- </xsl:for-each>
-
- <!-- bug descriptions - hidden -->
- <xsl:for-each select="/BugCollection/BugInstance[not(@last)]">
- <div style="display:none;">
- <xsl:attribute name="id">b-uid-<xsl:value-of select="@instanceHash" />-<xsl:value-of select="@instanceOccurrenceNum" /></xsl:attribute>
- <xsl:for-each select="*/Message">
- <xsl:choose>
- <xsl:when test="parent::SourceLine and $htmlsrcpath != '' ">
- <div class="b-r"><a>
- <xsl:attribute name="href"><xsl:value-of select="$htmlsrcpath"/><xsl:value-of select="../@sourcepath" />.html#<xsl:value-of select="../@start" /></xsl:attribute>
- <xsl:apply-templates />
- </a></div>
- </xsl:when>
- <xsl:otherwise>
- <div class="b-r"><xsl:apply-templates /></div>
- </xsl:otherwise>
- </xsl:choose>
- </xsl:for-each>
- <div class="b-d">
- <xsl:value-of select="LongMessage" disable-output-escaping="no" />
- </div>
- </div>
- </xsl:for-each>
- </div>
- <div id='fixedbox'>
- <div id='bug-placeholder'></div>
- </div>
- </body>
-</html>
-</xsl:template>
-
-<!-- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -->
-<!-- generate summary report from stats -->
-<xsl:template name="generateSummary" >
-<div class='summary' id='bug-summary'>
- <h2>FindBugs Analysis generated at: <xsl:value-of select="/BugCollection/FindBugsSummary/@timestamp" /></h2>
- <table>
- <tr>
- <th>Package</th>
- <th>Code Size</th>
- <th>Bugs</th>
- <th>Bugs p1</th>
- <th>Bugs p2</th>
- <th>Bugs p3</th>
- <th>Bugs Exp.</th>
- <th>Ratio</th>
- </tr>
- <tr>
- <td class='summary-name'>
- Overall
- (<xsl:value-of select="/BugCollection/FindBugsSummary/@num_packages" /> packages),
- (<xsl:value-of select="/BugCollection/FindBugsSummary/@total_classes" /> classes)
- </td>
- <td class='summary-size'><xsl:value-of select="/BugCollection/FindBugsSummary/@total_size" /></td>
- <td class='summary-priority-all'><xsl:value-of select="/BugCollection/FindBugsSummary/@total_bugs" /></td>
- <td class='summary-priority-1'><xsl:value-of select="/BugCollection/FindBugsSummary/@priority_1" /></td>
- <td class='summary-priority-2'><xsl:value-of select="/BugCollection/FindBugsSummary/@priority_2" /></td>
- <td class='summary-priority-3'><xsl:value-of select="/BugCollection/FindBugsSummary/@priority_3" /></td>
- <td class='summary-priority-4'><xsl:value-of select="/BugCollection/FindBugsSummary/@priority_4" /></td>
- <td class='summary-ratio'></td>
- </tr>
- <xsl:for-each select="/BugCollection/FindBugsSummary/PackageStats">
- <xsl:sort select="@package" />
- <xsl:if test="@total_bugs!='0'" >
- <tr>
- <td class='summary-name'><xsl:value-of select="@package" /></td>
- <td class='summary-size'><xsl:value-of select="@total_size" /></td>
- <td class='summary-priority-all'><xsl:value-of select="@total_bugs" /></td>
- <td class='summary-priority-1'><xsl:value-of select="@priority_1" /></td>
- <td class='summary-priority-2'><xsl:value-of select="@priority_2" /></td>
- <td class='summary-priority-3'><xsl:value-of select="@priority_3" /></td>
- <td class='summary-priority-4'><xsl:value-of select="@priority_4" /></td>
- <td class='summary-ratio'></td>
-<!--
- <xsl:for-each select="ClassStats">
- <xsl:if test="@bugs!='0'" >
- <li>
- <xsl:value-of select="@class" /> - total: <xsl:value-of select="@bugs" />
- </li>
- </xsl:if>
- </xsl:for-each>
--->
- </tr>
- </xsl:if>
- </xsl:for-each>
- </table>
-</div>
-</xsl:template>
-
-<!-- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -->
-<!-- display analysis info -->
-<xsl:template name="analysis-data">
- <div id='analysis-data' style='display:none;'>
- <div id='analyzed-files'>
- <h3>Analyzed Files:</h3>
- <ul>
- <xsl:for-each select="/BugCollection/Project/Jar">
- <li><xsl:apply-templates /></li>
- </xsl:for-each>
- </ul>
- </div>
- <div id='used-libraries'>
- <h3>Used Libraries:</h3>
- <ul>
- <xsl:for-each select="/BugCollection/Project/AuxClasspathEntry">
- <li><xsl:apply-templates /></li>
- </xsl:for-each>
- <xsl:if test="count(/BugCollection/Project/AuxClasspathEntry)=0" >
- <li>None</li>
- </xsl:if>
- </ul>
- </div>
- <div id='analysis-error'>
- <h3>Analysis Errors:</h3>
- <ul>
- <xsl:variable name="error-count"
- select="count(/BugCollection/Errors/MissingClass)" />
- <xsl:if test="$error-count=0" >
- <li>None</li>
- </xsl:if>
- <xsl:if test="$error-count>0" >
- <li>Missing ref classes for analysis:
- <ul>
- <xsl:for-each select="/BugCollection/Errors/MissingClass">
- <li><xsl:apply-templates /></li>
- </xsl:for-each>
- </ul>
- </li>
- </xsl:if>
- </ul>
- </div>
- </div>
-</xsl:template>
-
-<!-- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -->
-<!-- show priorities helper -->
-<xsl:template name="helpPriorities">
- <span>
- <xsl:attribute name="class">b-1</xsl:attribute>
-   
- </span> P1
- <span>
- <xsl:attribute name="class">b-2</xsl:attribute>
-   
- </span> P2
- <span>
- <xsl:attribute name="class">b-3</xsl:attribute>
-   
- </span> P3
- <span>
- <xsl:attribute name="class">b-4</xsl:attribute>
-   
- </span> Exp.
-</xsl:template>
-
-<!-- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -->
-<!-- display the details of a bug -->
-<xsl:template name="display-bug" >
- <xsl:param name="b-t" select="''" />
- <xsl:param name="bug-id" select="''" />
- <xsl:param name="which-list" select="''" />
- <div class="bb">
- <a>
- <xsl:attribute name="href"></xsl:attribute>
- <xsl:attribute name="onclick">showbug('b-uid-<xsl:value-of select="@instanceHash" />-<xsl:value-of select="@instanceOccurrenceNum" />','<xsl:value-of select="$which-list" />');return false;</xsl:attribute>
- <span>
- <xsl:attribute name="class">b-<xsl:value-of select="@priority"/></xsl:attribute>
-   
- </span>
- <span class="b-t"><xsl:value-of select="@abbrev" />: </span> <xsl:value-of select="Class/Message" />
- </a>
- <div style="display:none;">
- <xsl:attribute name="id">b-uid-<xsl:value-of select="@instanceHash" />-<xsl:value-of select="@instanceOccurrenceNum" />-ph-<xsl:value-of select="$which-list" /></xsl:attribute>
- loading...
- </div>
- </div>
-</xsl:template>
-
-<!-- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -->
-<!-- main template for the list by category -->
-<xsl:template name="list-by-category" >
- <div id='list-by-category' class='data-box' style='display:none;'>
- <xsl:call-template name="helpPriorities" />
- <xsl:variable name="unique-category" select="/BugCollection/BugCategory/@category"/>
- <xsl:for-each select="$unique-category">
- <xsl:sort select="." order="ascending" />
- <xsl:call-template name="categories">
- <xsl:with-param name="category" select="." />
- </xsl:call-template>
- </xsl:for-each>
- </div>
-</xsl:template>
-
-<xsl:template name="categories" >
- <xsl:param name="category" select="''" />
- <xsl:variable name="category-count"
- select="count(/BugCollection/BugInstance[@category=$category and not(@last)])" />
- <xsl:variable name="category-count-p1"
- select="count(/BugCollection/BugInstance[@category=$category and @priority='1' and not(@last)])" />
- <xsl:variable name="category-count-p2"
- select="count(/BugCollection/BugInstance[@category=$category and @priority='2' and not(@last)])" />
- <xsl:variable name="category-count-p3"
- select="count(/BugCollection/BugInstance[@category=$category and @priority='3' and not(@last)])" />
- <xsl:variable name="category-count-p4"
- select="count(/BugCollection/BugInstance[@category=$category and @priority='4' and not(@last)])" />
- <div class='ob'>
- <div class='ob-t'>
- <a>
- <xsl:attribute name="href"></xsl:attribute>
- <xsl:attribute name="onclick">toggle('category-<xsl:value-of select="$category" />');return false;</xsl:attribute>
- <xsl:value-of select="/BugCollection/BugCategory[@category=$category]/Description" />
- (<xsl:value-of select="$category-count" />:
- <span class='t-h'><xsl:value-of select="$category-count-p1" />/<xsl:value-of select="$category-count-p2" />/<xsl:value-of select="$category-count-p3" />/<xsl:value-of select="$category-count-p4" /></span>)
- </a>
- </div>
- <div style="display:none;">
- <xsl:attribute name="id">category-<xsl:value-of select="$category" /></xsl:attribute>
- <xsl:call-template name="list-by-category-and-code">
- <xsl:with-param name="category" select="$category" />
- </xsl:call-template>
- </div>
- </div>
-</xsl:template>
-
-<xsl:template name="list-by-category-and-code" >
- <xsl:param name="category" select="''" />
- <xsl:variable name="unique-code" select="/BugCollection/BugInstance[@category=$category and not(@last) and generate-id()= generate-id(key('lbc-code-key',concat(@category,@abbrev)))]/@abbrev" />
- <xsl:for-each select="$unique-code">
- <xsl:sort select="." order="ascending" />
- <xsl:call-template name="codes">
- <xsl:with-param name="category" select="$category" />
- <xsl:with-param name="code" select="." />
- </xsl:call-template>
- </xsl:for-each>
-</xsl:template>
-
-<xsl:template name="codes" >
- <xsl:param name="category" select="''" />
- <xsl:param name="code" select="''" />
- <xsl:variable name="code-count"
- select="count(/BugCollection/BugInstance[@category=$category and @abbrev=$code and not(@last)])" />
- <xsl:variable name="code-count-p1"
- select="count(/BugCollection/BugInstance[@category=$category and @abbrev=$code and @priority='1' and not(@last)])" />
- <xsl:variable name="code-count-p2"
- select="count(/BugCollection/BugInstance[@category=$category and @abbrev=$code and @priority='2' and not(@last)])" />
- <xsl:variable name="code-count-p3"
- select="count(/BugCollection/BugInstance[@category=$category and @abbrev=$code and @priority='3' and not(@last)])" />
- <xsl:variable name="code-count-p4"
- select="count(/BugCollection/BugInstance[@category=$category and @abbrev=$code and @priority='4' and not(@last)])" />
- <div class='ib-1'>
- <div class="ib-1-t">
- <a>
- <xsl:attribute name="href"></xsl:attribute>
- <xsl:attribute name="onclick">toggle('category-<xsl:value-of select="$category" />-and-code-<xsl:value-of select="$code" />');return false;</xsl:attribute>
- <xsl:value-of select="$code" />: <xsl:value-of select="/BugCollection/BugCode[@abbrev=$code]/Description" />
- (<xsl:value-of select="$code-count" />:
- <span class='t-h'><xsl:value-of select="$code-count-p1" />/<xsl:value-of select="$code-count-p2" />/<xsl:value-of select="$code-count-p3" />/<xsl:value-of select="$code-count-p4" /></span>)
- </a>
- </div>
- <div style="display:none;">
- <xsl:attribute name="id">category-<xsl:value-of select="$category" />-and-code-<xsl:value-of select="$code" /></xsl:attribute>
- <xsl:call-template name="list-by-category-and-code-and-bug">
- <xsl:with-param name="category" select="$category" />
- <xsl:with-param name="code" select="$code" />
- </xsl:call-template>
- </div>
- </div>
-</xsl:template>
-
-<xsl:template name="list-by-category-and-code-and-bug" >
- <xsl:param name="category" select="''" />
- <xsl:param name="code" select="''" />
- <xsl:variable name="unique-bug" select="/BugCollection/BugInstance[@category=$category and not(@last) and @abbrev=$code and generate-id()= generate-id(key('lbc-bug-key',concat(@category,@abbrev,@type)))]/@type" />
- <xsl:for-each select="$unique-bug">
- <xsl:sort select="." order="ascending" />
- <xsl:call-template name="bugs">
- <xsl:with-param name="category" select="$category" />
- <xsl:with-param name="code" select="$code" />
- <xsl:with-param name="bug" select="." />
- </xsl:call-template>
- </xsl:for-each>
-</xsl:template>
-
-<xsl:template name="bugs" >
- <xsl:param name="category" select="''" />
- <xsl:param name="code" select="''" />
- <xsl:param name="bug" select="''" />
- <xsl:variable name="bug-count"
- select="count(/BugCollection/BugInstance[@category=$category and @abbrev=$code and @type=$bug and not(@last)])" />
- <xsl:variable name="bug-count-p1"
- select="count(/BugCollection/BugInstance[@category=$category and @abbrev=$code and @type=$bug and @priority='1' and not(@last)])" />
- <xsl:variable name="bug-count-p2"
- select="count(/BugCollection/BugInstance[@category=$category and @abbrev=$code and @type=$bug and @priority='2' and not(@last)])" />
- <xsl:variable name="bug-count-p3"
- select="count(/BugCollection/BugInstance[@category=$category and @abbrev=$code and @type=$bug and @priority='3' and not(@last)])" />
- <xsl:variable name="bug-count-p4"
- select="count(/BugCollection/BugInstance[@category=$category and @abbrev=$code and @type=$bug and @priority='4' and not(@last)])" />
- <div class='ib-2'>
- <div class='ib-2-t'>
- <a>
- <xsl:attribute name="href"></xsl:attribute>
- <xsl:attribute name="onclick">toggle('category-<xsl:value-of select="$category" />-and-code-<xsl:value-of select="$code" />-and-bug-<xsl:value-of select="$bug" />');return false;</xsl:attribute>
- <xsl:attribute name="onmouseout">popUp(event,'tip-<xsl:value-of select="$bug" />');</xsl:attribute>
- <xsl:attribute name="onmouseover">popUp(event,'tip-<xsl:value-of select="$bug" />');</xsl:attribute>
- <xsl:value-of select="/BugCollection/BugPattern[@category=$category and @abbrev=$code and @type=$bug]/ShortDescription" />  
- (<xsl:value-of select="$bug-count" />:
- <span class='t-h'><xsl:value-of select="$bug-count-p1" />/<xsl:value-of select="$bug-count-p2" />/<xsl:value-of select="$bug-count-p3" />/<xsl:value-of select="$bug-count-p4" /></span>)
- </a>
- </div>
- <div style="display:none;">
- <xsl:attribute name="id">category-<xsl:value-of select="$category" />-and-code-<xsl:value-of select="$code" />-and-bug-<xsl:value-of select="$bug" /></xsl:attribute>
- <xsl:variable name="cat-code-type">category-<xsl:value-of select="$category" />-and-code-<xsl:value-of select="$code" />-and-bug-<xsl:value-of select="$bug" /></xsl:variable>
- <xsl:variable name="bug-id">b-uid-<xsl:value-of select="@instanceHash" />-<xsl:value-of select="@instanceOccurrenceNum" /></xsl:variable>
- <xsl:for-each select="/BugCollection/BugInstance[@category=$category and @abbrev=$code and @type=$bug and not(@last)]">
- <xsl:call-template name="display-bug">
- <xsl:with-param name="b-t" select="@type" />
- <xsl:with-param name="bug-id" select="$bug-id" />
- <xsl:with-param name="which-list" select="'c'" />
- </xsl:call-template>
- </xsl:for-each>
- </div>
- </div>
-</xsl:template>
-
-<!-- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ -->
-<!-- main template for the list by package -->
-<xsl:template name="list-by-package" >
- <div id='list-by-package' class='data-box' style='display:none;'>
- <xsl:call-template name="helpPriorities" />
- <xsl:for-each select="/BugCollection/FindBugsSummary/PackageStats[@total_bugs != '0']/@package">
- <xsl:sort select="." order="ascending" />
- <xsl:call-template name="packages">
- <xsl:with-param name="package" select="." />
- </xsl:call-template>
- </xsl:for-each>
- </div>
-</xsl:template>
-
-<xsl:template name="packages" >
- <xsl:param name="package" select="''" />
- <xsl:variable name="package-count-p1">
- <xsl:if test="not(/BugCollection/FindBugsSummary/PackageStats[@package=$package]/@priority_1 != '')">0</xsl:if>
- <xsl:if test="/BugCollection/FindBugsSummary/PackageStats[@package=$package]/@priority_1 != ''">
- <xsl:value-of select="/BugCollection/FindBugsSummary/PackageStats[@package=$package]/@priority_1" />
- </xsl:if>
- </xsl:variable>
- <xsl:variable name="package-count-p2">
- <xsl:if test="not(/BugCollection/FindBugsSummary/PackageStats[@package=$package]/@priority_2 != '')">0</xsl:if>
- <xsl:if test="/BugCollection/FindBugsSummary/PackageStats[@package=$package]/@priority_2 != ''">
- <xsl:value-of select="/BugCollection/FindBugsSummary/PackageStats[@package=$package]/@priority_2" />
- </xsl:if>
- </xsl:variable>
- <xsl:variable name="package-count-p3">
- <xsl:if test="not(/BugCollection/FindBugsSummary/PackageStats[@package=$package]/@priority_3 != '')">0</xsl:if>
- <xsl:if test="/BugCollection/FindBugsSummary/PackageStats[@package=$package]/@priority_3 != ''">
- <xsl:value-of select="/BugCollection/FindBugsSummary/PackageStats[@package=$package]/@priority_3" />
- </xsl:if>
- </xsl:variable>
- <xsl:variable name="package-count-p4">
- <xsl:if test="not(/BugCollection/FindBugsSummary/PackageStats[@package=$package]/@priority_4 != '')">0</xsl:if>
- <xsl:if test="/BugCollection/FindBugsSummary/PackageStats[@package=$package]/@priority_4 != ''">
- <xsl:value-of select="/BugCollection/FindBugsSummary/PackageStats[@package=$package]/@priority_4" />
- </xsl:if>
- </xsl:variable>
-
- <div class='ob'>
- <div class='ob-t'>
- <a>
- <xsl:attribute name="href"></xsl:attribute>
- <xsl:attribute name="onclick">toggle('package-<xsl:value-of select="$package" />');return false;</xsl:attribute>
- <xsl:value-of select="$package" />
- (<xsl:value-of select="/BugCollection/FindBugsSummary/PackageStats[@package=$package]/@total_bugs" />:
- <span class='t-h'><xsl:value-of select="$package-count-p1" />/<xsl:value-of select="$package-count-p2" />/<xsl:value-of select="$package-count-p3" />/<xsl:value-of select="$package-count-p4" /></span>)
- </a>
- </div>
- <div style="display:none;">
- <xsl:attribute name="id">package-<xsl:value-of select="$package" /></xsl:attribute>
- <xsl:call-template name="list-by-package-and-class">
- <xsl:with-param name="package" select="$package" />
- </xsl:call-template>
- </div>
- </div>
-</xsl:template>
-
-<xsl:template name="list-by-package-and-class" >
- <xsl:param name="package" select="''" />
- <xsl:for-each select="/BugCollection/FindBugsSummary/PackageStats[@package=$package]/ClassStats[@bugs != '0']/@class">
- <xsl:sort select="." order="ascending" />
- <xsl:call-template name="classes">
- <xsl:with-param name="package" select="$package" />
- <xsl:with-param name="class" select="." />
- </xsl:call-template>
- </xsl:for-each>
-</xsl:template>
-
-<xsl:template name="classes" >
- <xsl:param name="package" select="''" />
- <xsl:param name="class" select="''" />
- <xsl:variable name="class-count"
- select="/BugCollection/FindBugsSummary/PackageStats[@package=$package]/ClassStats[@class=$class and @bugs != '0']/@bugs" />
-
- <xsl:variable name="class-count-p1">
- <xsl:if test="not(/BugCollection/FindBugsSummary/PackageStats[@package=$package]/ClassStats[@class=$class and @bugs != '0']/@priority_1 != '')">0</xsl:if>
- <xsl:if test="/BugCollection/FindBugsSummary/PackageStats[@package=$package]/ClassStats[@class=$class and @bugs != '0']/@priority_1 != ''">
- <xsl:value-of select="/BugCollection/FindBugsSummary/PackageStats[@package=$package]/ClassStats[@class=$class and @bugs != '0']/@priority_1" />
- </xsl:if>
- </xsl:variable>
- <xsl:variable name="class-count-p2">
- <xsl:if test="not(/BugCollection/FindBugsSummary/PackageStats[@package=$package]/ClassStats[@class=$class and @bugs != '0']/@priority_2 != '')">0</xsl:if>
- <xsl:if test="/BugCollection/FindBugsSummary/PackageStats[@package=$package]/ClassStats[@class=$class and @bugs != '0']/@priority_2 != ''">
- <xsl:value-of select="/BugCollection/FindBugsSummary/PackageStats[@package=$package]/ClassStats[@class=$class and @bugs != '0']/@priority_2" />
- </xsl:if>
- </xsl:variable>
- <xsl:variable name="class-count-p3">
- <xsl:if test="not(/BugCollection/FindBugsSummary/PackageStats[@package=$package]/ClassStats[@class=$class and @bugs != '0']/@priority_3 != '')">0</xsl:if>
- <xsl:if test="/BugCollection/FindBugsSummary/PackageStats[@package=$package]/ClassStats[@class=$class and @bugs != '0']/@priority_3 != ''">
- <xsl:value-of select="/BugCollection/FindBugsSummary/PackageStats[@package=$package]/ClassStats[@class=$class and @bugs != '0']/@priority_3" />
- </xsl:if>
- </xsl:variable>
- <xsl:variable name="class-count-p4">
- <xsl:if test="not(/BugCollection/FindBugsSummary/PackageStats[@package=$package]/ClassStats[@class=$class and @bugs != '0']/@priority_4 != '')">0</xsl:if>
- <xsl:if test="/BugCollection/FindBugsSummary/PackageStats[@package=$package]/ClassStats[@class=$class and @bugs != '0']/@priority_4 != ''">
- <xsl:value-of select="/BugCollection/FindBugsSummary/PackageStats[@package=$package]/ClassStats[@class=$class and @bugs != '0']/@priority_4" />
- </xsl:if>
- </xsl:variable>
-
- <div class='ib-1'>
- <div class="ib-1-t">
- <a>
- <xsl:attribute name="href"></xsl:attribute>
- <xsl:attribute name="onclick">toggle('package-<xsl:value-of select="$package" />-and-class-<xsl:value-of select="$class" />');return false;</xsl:attribute>
- <xsl:value-of select="$class" /> (<xsl:value-of select="$class-count" />:
- <span class='t-h'><xsl:value-of select="$class-count-p1" />/<xsl:value-of select="$class-count-p2" />/<xsl:value-of select="$class-count-p3" />/<xsl:value-of select="$class-count-p4" /></span>)
- </a>
- </div>
- <div style="display:none;">
- <xsl:attribute name="id">package-<xsl:value-of select="$package" />-and-class-<xsl:value-of select="$class" /></xsl:attribute>
- <xsl:call-template name="list-by-package-and-class-and-bug">
- <xsl:with-param name="package" select="$package" />
- <xsl:with-param name="class" select="$class" />
- </xsl:call-template>
- </div>
- </div>
-</xsl:template>
-
-<xsl:template name="list-by-package-and-class-and-bug" >
- <xsl:param name="package" select="''" />
- <xsl:param name="class" select="''" />
- <xsl:variable name="unique-class-bugs" select="/BugCollection/BugInstance[not(@last) and Class[position()=1 and @classname=$class] and generate-id() = generate-id(key('lbp-class-b-t',concat(Class/@classname,@type)))]/@type" />
-
- <xsl:for-each select="$unique-class-bugs">
- <xsl:sort select="." order="ascending" />
- <xsl:call-template name="class-bugs">
- <xsl:with-param name="package" select="$package" />
- <xsl:with-param name="class" select="$class" />
- <xsl:with-param name="type" select="." />
- </xsl:call-template>
- </xsl:for-each>
-</xsl:template>
-
-<xsl:template name="class-bugs" >
- <xsl:param name="package" select="''" />
- <xsl:param name="class" select="''" />
- <xsl:param name="type" select="''" />
- <xsl:variable name="bug-count"
- select="count(/BugCollection/BugInstance[@type=$type and not(@last) and Class[position()=1 and @classname=$class]])" />
- <div class='ib-2'>
- <div class='ib-2-t'>
- <a>
- <xsl:attribute name="href"></xsl:attribute>
- <xsl:attribute name="onclick">toggle('package-<xsl:value-of select="$package" />-and-class-<xsl:value-of select="$class" />-and-type-<xsl:value-of select="$type" />');return false;</xsl:attribute>
- <xsl:attribute name="onmouseout">popUp(event,'tip-<xsl:value-of select="$type" />')</xsl:attribute>
- <xsl:attribute name="onmouseover">popUp(event,'tip-<xsl:value-of select="$type" />')</xsl:attribute>
- <xsl:value-of select="/BugCollection/BugPattern[@type=$type]/ShortDescription" />  
- (<xsl:value-of select="$bug-count" />)
- </a>
- </div>
- <div style="display:none;">
- <xsl:attribute name="id">package-<xsl:value-of select="$package" />-and-class-<xsl:value-of select="$class" />-and-type-<xsl:value-of select="$type" /></xsl:attribute>
- <xsl:variable name="package-class-type">package-<xsl:value-of select="$package" />-and-class-<xsl:value-of select="$class" />-and-type-<xsl:value-of select="$type" /></xsl:variable>
- <xsl:variable name="bug-id">b-uid-<xsl:value-of select="@instanceHash" />-<xsl:value-of select="@instanceOccurrenceNum" /></xsl:variable>
- <xsl:for-each select="/BugCollection/BugInstance[@type=$type and not(@last) and Class[position()=1 and @classname=$class]]">
- <xsl:call-template name="display-bug">
- <xsl:with-param name="b-t" select="@type" />
- <xsl:with-param name="bug-id" select="$bug-id" />
- <xsl:with-param name="which-list" select="'p'" />
- </xsl:call-template>
- </xsl:for-each>
- </div>
- </div>
-</xsl:template>
-
-</xsl:transform>
diff --git a/tools/findbugs-1.3.9/src/xsl/plain.xsl b/tools/findbugs-1.3.9/src/xsl/plain.xsl
deleted file mode 100644
index 80fff8d..0000000
--- a/tools/findbugs-1.3.9/src/xsl/plain.xsl
+++ /dev/null
@@ -1,306 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
- FindBugs - Find bugs in Java programs
- Copyright (C) 2004,2005 University of Maryland
- Copyright (C) 2005, Chris Nappin
-
- This library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Lesser General Public
- License as published by the Free Software Foundation; either
- version 2.1 of the License, or (at your option) any later version.
-
- This library is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- Lesser General Public License for more details.
-
- You should have received a copy of the GNU Lesser General Public
- License along with this library; if not, write to the Free Software
- Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
--->
-<xsl:stylesheet version="1.0"
- xmlns="http://www.w3.org/1999/xhtml"
- xmlns:xsl="http://www.w3.org/1999/XSL/Transform">
-
-<xsl:output
- method="xml"
- omit-xml-declaration="yes"
- standalone="yes"
- doctype-system="http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"
- doctype-public="-//W3C//DTD XHTML 1.0 Transitional//EN"
- indent="yes"
- encoding="UTF-8"/>
-
-<xsl:variable name="bugTableHeader">
- <tr class="tableheader">
- <th align="left">Warning</th>
- <th align="left">Priority</th>
- <th align="left">Details</th>
- </tr>
-</xsl:variable>
-
-<xsl:template match="/">
- <html>
- <head>
- <title>FindBugs Report</title>
- <style type="text/css">
- .tablerow0 {
- background: #EEEEEE;
- }
-
- .tablerow1 {
- background: white;
- }
-
- .detailrow0 {
- background: #EEEEEE;
- }
-
- .detailrow1 {
- background: white;
- }
-
- .tableheader {
- background: #b9b9fe;
- font-size: larger;
- }
- </style>
- </head>
-
- <xsl:variable name="unique-catkey" select="/BugCollection/BugCategory/@category"/>
-
- <body>
-
- <h1>FindBugs Report</h1>
- <p>Produced using <a href="http://findbugs.sourceforge.net">FindBugs</a> <xsl:value-of select="/BugCollection/@version"/>.</p>
- <p>Project:
- <xsl:choose>
- <xsl:when test='string-length(/BugCollection/Project/@projectName)>0'><xsl:value-of select="/BugCollection/Project/@projectName" /></xsl:when>
- <xsl:otherwise><xsl:value-of select="/BugCollection/Project/@filename" /></xsl:otherwise>
- </xsl:choose>
- </p>
- <h2>Metrics</h2>
- <xsl:apply-templates select="/BugCollection/FindBugsSummary"/>
-
- <h2>Summary</h2>
- <table width="500" cellpadding="5" cellspacing="2">
- <tr class="tableheader">
- <th align="left">Warning Type</th>
- <th align="right">Number</th>
- </tr>
-
- <xsl:for-each select="$unique-catkey">
- <xsl:sort select="." order="ascending"/>
- <xsl:variable name="catkey" select="."/>
- <xsl:variable name="catdesc" select="/BugCollection/BugCategory[@category=$catkey]/Description"/>
- <xsl:variable name="styleclass">
- <xsl:choose><xsl:when test="position() mod 2 = 1">tablerow0</xsl:when>
- <xsl:otherwise>tablerow1</xsl:otherwise>
- </xsl:choose>
- </xsl:variable>
-
- <tr class="{$styleclass}">
- <td><a href="#Warnings_{$catkey}"><xsl:value-of select="$catdesc"/> Warnings</a></td>
- <td align="right"><xsl:value-of select="count(/BugCollection/BugInstance[(@category=$catkey) and (not(@last))])"/></td>
- </tr>
- </xsl:for-each>
-
- <xsl:variable name="styleclass">
- <xsl:choose><xsl:when test="count($unique-catkey) mod 2 = 0">tablerow0</xsl:when>
- <xsl:otherwise>tablerow1</xsl:otherwise>
- </xsl:choose>
- </xsl:variable>
- <tr class="{$styleclass}">
- <td><b>Total</b></td>
- <td align="right"><b><xsl:value-of select="count(/BugCollection/BugInstance[not(@last)])"/></b></td>
- </tr>
- </table>
- <p><br/><br/></p>
-
- <h1>Warnings</h1>
-
- <p>Click on each warning link to see a full description of the issue, and
- details of how to resolve it.</p>
-
- <xsl:for-each select="$unique-catkey">
- <xsl:sort select="." order="ascending"/>
- <xsl:variable name="catkey" select="."/>
- <xsl:variable name="catdesc" select="/BugCollection/BugCategory[@category=$catkey]/Description"/>
-
- <xsl:call-template name="generateWarningTable">
- <xsl:with-param name="warningSet" select="/BugCollection/BugInstance[(@category=$catkey) and (not(@last))]"/>
- <xsl:with-param name="sectionTitle"><xsl:value-of select="$catdesc"/> Warnings</xsl:with-param>
- <xsl:with-param name="sectionId">Warnings_<xsl:value-of select="$catkey"/></xsl:with-param>
- </xsl:call-template>
- </xsl:for-each>
-
- <p><br/><br/></p>
- <h1><a name="Details">Warning Types</a></h1>
-
- <xsl:apply-templates select="/BugCollection/BugPattern">
- <xsl:sort select="@abbrev"/>
- <xsl:sort select="ShortDescription"/>
- </xsl:apply-templates>
-
- </body>
- </html>
-</xsl:template>
-
-<xsl:template match="BugInstance[not(@last)]">
- <xsl:variable name="warningId"><xsl:value-of select="generate-id()"/></xsl:variable>
-
- <tr class="tablerow{position() mod 2}">
- <td width="20%" valign="top">
- <a href="#{@type}"><xsl:value-of select="ShortMessage"/></a>
- </td>
- <td width="10%" valign="top">
- <xsl:choose>
- <xsl:when test="@priority = 1">High</xsl:when>
- <xsl:when test="@priority = 2">Medium</xsl:when>
- <xsl:when test="@priority = 3">Low</xsl:when>
- <xsl:otherwise>Unknown</xsl:otherwise>
- </xsl:choose>
- </td>
- <td width="70%">
- <p><xsl:value-of select="LongMessage"/><br/><br/>
-
- <!-- add source filename and line number(s), if any -->
- <xsl:if test="SourceLine">
- <br/>In file <xsl:value-of select="SourceLine/@sourcefile"/>,
- <xsl:choose>
- <xsl:when test="SourceLine/@start = SourceLine/@end">
- line <xsl:value-of select="SourceLine/@start"/>
- </xsl:when>
- <xsl:otherwise>
- lines <xsl:value-of select="SourceLine/@start"/>
- to <xsl:value-of select="SourceLine/@end"/>
- </xsl:otherwise>
- </xsl:choose>
- </xsl:if>
-
- <xsl:for-each select="./*/Message">
- <br/><xsl:value-of select="text()"/>
- </xsl:for-each>
- </p>
- </td>
- </tr>
-</xsl:template>
-
-<xsl:template match="BugPattern">
- <h2><a name="{@type}"><xsl:value-of select="ShortDescription"/></a></h2>
- <xsl:value-of select="Details" disable-output-escaping="yes"/>
- <p><br/><br/></p>
-</xsl:template>
-
-<xsl:template name="generateWarningTable">
- <xsl:param name="warningSet"/>
- <xsl:param name="sectionTitle"/>
- <xsl:param name="sectionId"/>
-
- <h2><a name="{$sectionId}"><xsl:value-of select="$sectionTitle"/></a></h2>
- <table class="warningtable" width="100%" cellspacing="2" cellpadding="5">
- <xsl:copy-of select="$bugTableHeader"/>
- <xsl:choose>
- <xsl:when test="count($warningSet) > 0">
- <xsl:apply-templates select="$warningSet">
- <xsl:sort select="@priority"/>
- <xsl:sort select="@abbrev"/>
- <xsl:sort select="Class/@classname"/>
- </xsl:apply-templates>
- </xsl:when>
- <xsl:otherwise>
- <tr><td colspan="2"><p><i>None</i></p></td></tr>
- </xsl:otherwise>
- </xsl:choose>
- </table>
- <p><br/><br/></p>
-</xsl:template>
-
-<xsl:template match="FindBugsSummary">
- <xsl:variable name="kloc" select="@total_size div 1000.0"/>
- <xsl:variable name="format" select="'#######0.00'"/>
-
- <p><xsl:value-of select="@total_size"/> lines of code analyzed,
- in <xsl:value-of select="@total_classes"/> classes,
- in <xsl:value-of select="@num_packages"/> packages.</p>
- <table width="500" cellpadding="5" cellspacing="2">
- <tr class="tableheader">
- <th align="left">Metric</th>
- <th align="right">Total</th>
- <th align="right">Density*</th>
- </tr>
- <tr class="tablerow0">
- <td>High Priority Warnings</td>
- <td align="right"><xsl:value-of select="@priority_1"/></td>
- <td align="right">
- <xsl:choose>
- <xsl:when test= "number($kloc) > 0.0">
- <xsl:value-of select="format-number(@priority_1 div $kloc, $format)"/>
- </xsl:when>
- <xsl:otherwise>
- <xsl:value-of select="format-number(0.0, $format)"/>
- </xsl:otherwise>
- </xsl:choose>
- </td>
- </tr>
- <tr class="tablerow1">
- <td>Medium Priority Warnings</td>
- <td align="right"><xsl:value-of select="@priority_2"/></td>
- <td align="right">
- <xsl:choose>
- <xsl:when test= "number($kloc) > 0.0">
- <xsl:value-of select="format-number(@priority_2 div $kloc, $format)"/>
- </xsl:when>
- <xsl:otherwise>
- <xsl:value-of select="format-number(0.0, $format)"/>
- </xsl:otherwise>
- </xsl:choose>
- </td>
- </tr>
-
- <xsl:choose>
- <xsl:when test="@priority_3">
- <tr class="tablerow1">
- <td>Low Priority Warnings</td>
- <td align="right"><xsl:value-of select="@priority_3"/></td>
- <td align="right">
- <xsl:choose>
- <xsl:when test= "number($kloc) > 0.0">
- <xsl:value-of select="format-number(@priority_3 div $kloc, $format)"/>
- </xsl:when>
- <xsl:otherwise>
- <xsl:value-of select="format-number(0.0, $format)"/>
- </xsl:otherwise>
- </xsl:choose>
- </td>
- </tr>
- <xsl:variable name="totalClass" select="tablerow0"/>
- </xsl:when>
- <xsl:otherwise>
- <xsl:variable name="totalClass" select="tablerow1"/>
- </xsl:otherwise>
- </xsl:choose>
-
- <tr class="$totalClass">
- <td><b>Total Warnings</b></td>
- <td align="right"><b><xsl:value-of select="@total_bugs"/></b></td>
- <td align="right">
- <b>
- <xsl:choose>
- <xsl:when test= "number($kloc) > 0.0">
- <xsl:value-of select="format-number(@total_bugs div $kloc, $format)"/>
- </xsl:when>
- <xsl:otherwise>
- <xsl:value-of select="format-number(0.0, $format)"/>
- </xsl:otherwise>
- </xsl:choose>
- </b>
- </td>
- </tr>
- </table>
- <p><i>(* Defects per Thousand lines of non-commenting source statements)</i></p>
- <p><br/><br/></p>
-
-</xsl:template>
-
-</xsl:stylesheet>
diff --git a/tools/findbugs-1.3.9/src/xsl/summary.xsl b/tools/findbugs-1.3.9/src/xsl/summary.xsl
deleted file mode 100644
index faf0131..0000000
--- a/tools/findbugs-1.3.9/src/xsl/summary.xsl
+++ /dev/null
@@ -1,252 +0,0 @@
-<?xml version="1.0"?>
-<xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform" version="1.0" >
-
-<xsl:output
- method="xml" indent="yes"
- doctype-system="http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"
- doctype-public="-//W3C//DTD XHTML 1.0 Transitional//EN"
- encoding="UTF-8"/>
-
-<xsl:param name="PAGE.TITLE" select="'Findbugs Summary Statistics'" />
-<xsl:param name="PAGE.FONT" select="'Arial'" />
-<xsl:param name="SUMMARY.HEADER" select="'Findbugs Summary Report'" />
-<xsl:param name="SUMMARY.LABEL" select="'Summary Analysis Generated at: '" />
-<xsl:param name="PACKAGE.HEADER" select="'Bugs By Package'" />
-<xsl:param name="PACKAGE.SORT.LABEL" select="'Sorted by Total Bugs'" />
-<xsl:param name="PACKAGE.LABEL" select="'Analysis of Package: '" />
-<xsl:param name="DEFAULT.PACKAGE.NAME" select="'default package'" />
-<xsl:param name="PACKAGE.BUGCLASS.LABEL" select="'Most Buggy Class in Package with #1 $1:'" />
-<xsl:param name="TOTAL.PACKAGES.LABEL" select="'#1 $1 Analyzed'" />
-
-<xsl:param name="BUGS.SINGLE.LABEL" select="'Bug'" />
-<xsl:param name="BUGS.PULURAL.LABEL" select="'Bugs'" />
-<xsl:param name="PACKAGE.SINGLE.LABEL" select="'Package'" />
-<xsl:param name="PACKAGE.PULURAL.LABEL" select="'Packages'" />
-
-
-<xsl:param name="TABLE.HEADING.TYPE" select="'Type Checked'" />
-<xsl:param name="TABLE.HEADING.COUNT" select="'Count'" />
-<xsl:param name="TABLE.HEADING.BUGS" select="'Bugs'" />
-<xsl:param name="TABLE.HEADING.PERCENT" select="'Percentage'" />
-<xsl:param name="TABLE.ROW.OUTER" select="'Outer Classes'" />
-<xsl:param name="TABLE.ROW.INNER" select="'Inner Classes'" />
-<xsl:param name="TABLE.ROW.INTERFACE" select="'Interfaces'" />
-<xsl:param name="TABLE.ROW.TOTAL" select="'Total'" />
-<xsl:param name="TABLE.WIDTH" select="'90%'" />
-
-<xsl:param name="PERCENTAGE.FORMAT" select="'#0.00%'" />
-
-<!-- This template drives the rest of the output -->
-<xsl:template match="/" >
- <html>
- <!-- JEditorPane gets really angry if it sees this
- WWP: Sorry, this needs to be explained better. Not a valid HTML document without a head.
- -->
- <head><title><xsl:value-of select="$PAGE.TITLE" /></title></head>
- <body>
- <h1 align="center"><a href="http://findbugs.sourceforge.net"><xsl:value-of select="$SUMMARY.HEADER" /></a></h1>
- <h2 align="center"> Analysis for
- <xsl:choose>
- <xsl:when test='string-length(/BugCollection/Project/@projectName)>0'>
- <xsl:value-of select="/BugCollection/Project/@projectName" /></xsl:when>
- <xsl:otherwise><xsl:value-of select="/BugCollection/Project/@filename" /></xsl:otherwise>
- </xsl:choose>
- </h2>
- <h2 align="center"><xsl:value-of select="$SUMMARY.LABEL" />
- <i><xsl:value-of select="//FindBugsSummary/@timestamp" /></i></h2>
- <xsl:apply-templates select="//FindBugsSummary" />
- <br/>
- <p align="center">
- <font face="{$PAGE.FONT}" size="6"><xsl:value-of select="$PACKAGE.HEADER" /></font>
- <br/><font face="{$PAGE.FONT}" size="4"><i>(<xsl:value-of select="$PACKAGE.SORT.LABEL"/>)</i></font>
- </p>
- <xsl:for-each select="//FindBugsSummary/PackageStats">
- <xsl:sort select="@total_bugs" data-type="number" order="descending" />
- <xsl:apply-templates select="." />
- </xsl:for-each>
- </body>
- </html>
-</xsl:template>
-
-<xsl:template name="status_table_row" >
- <xsl:param name="LABEL" select="''" />
- <xsl:param name="COUNT" select="1" />
- <xsl:param name="BUGS" select="0" />
- <xsl:param name="FONT_SIZE" select="4" />
- <tr>
- <td align="left"><font face="{$PAGE.FONT}" size="{$FONT_SIZE}"><xsl:value-of select="$LABEL" /></font></td>
- <td align="center"><font face="{$PAGE.FONT}" color="green" size="{$FONT_SIZE}"><xsl:value-of select="$COUNT" /></font></td>
- <td align="center"><font face="{$PAGE.FONT}" color="red" size="{$FONT_SIZE}"><xsl:value-of select="$BUGS" /></font></td>
- <td align="center"><font face="{$PAGE.FONT}" color="blue" size="{$FONT_SIZE}">
- <xsl:choose>
- <xsl:when test="$COUNT > 0">
- <xsl:value-of select="format-number(number($BUGS div $COUNT), $PERCENTAGE.FORMAT)"/>
- </xsl:when>
- <xsl:otherwise>
- <xsl:value-of select="format-number(0, $PERCENTAGE.FORMAT)"/>
- </xsl:otherwise>
- </xsl:choose>
- </font>
- </td>
- </tr>
-</xsl:template>
-
-<xsl:template name="table_header" >
- <tr>
- <th><font face="{$PAGE.FONT}" size="4"><xsl:value-of select="$TABLE.HEADING.TYPE"/></font></th>
- <th><font face="{$PAGE.FONT}" size="4"><xsl:value-of select="$TABLE.HEADING.COUNT"/></font></th>
- <th><font face="{$PAGE.FONT}" size="4"><xsl:value-of select="$TABLE.HEADING.BUGS"/></font></th>
- <th><font face="{$PAGE.FONT}" size="4"><xsl:value-of select="$TABLE.HEADING.PERCENT"/></font></th>
- </tr>
-</xsl:template>
-
-<xsl:template match="FindBugsSummary" >
- <table width="{$TABLE.WIDTH}" border="1" align="center">
- <xsl:call-template name="table_header" />
-
- <xsl:call-template name="status_table_row">
- <xsl:with-param name="LABEL" select="$TABLE.ROW.OUTER" />
- <xsl:with-param name="COUNT" select="count(PackageStats/ClassStats[@interface='false' and substring-after(@class,'$')=''])" />
- <xsl:with-param name="BUGS" select="sum(PackageStats/ClassStats[@interface='false' and substring-after(@class,'$')='']/@bugs)" />
- </xsl:call-template>
-
- <xsl:call-template name="status_table_row">
- <xsl:with-param name="LABEL" select="$TABLE.ROW.INNER" />
- <xsl:with-param name="COUNT" select="count(PackageStats/ClassStats[@interface='false' and substring-after(@class,'$')!=''])" />
- <xsl:with-param name="BUGS" select="sum(PackageStats/ClassStats[@interface='false' and substring-after(@class,'$')!='']/@bugs)" />
- </xsl:call-template>
-
- <xsl:call-template name="status_table_row">
- <xsl:with-param name="LABEL" select="$TABLE.ROW.INTERFACE" />
- <xsl:with-param name="COUNT" select="count(PackageStats/ClassStats[@interface='true'])" />
- <xsl:with-param name="BUGS" select="sum(PackageStats/ClassStats[@interface='true']/@bugs)" />
- </xsl:call-template>
-
- <xsl:call-template name="status_table_row">
- <xsl:with-param name="LABEL" select="$TABLE.ROW.TOTAL" />
- <xsl:with-param name="COUNT" select="@total_classes" />
- <xsl:with-param name="BUGS" select="@total_bugs"/>
- <xsl:with-param name="FONT_SIZE" select="5"/>
- </xsl:call-template>
- <xsl:variable name="num_packages" select="count(PackageStats)" />
- <tr><td align="center" colspan="4"><font face="{$PAGE.FONT}" size="4">
- <xsl:call-template name='string_format'>
- <xsl:with-param name="COUNT" select="$num_packages"/>
- <xsl:with-param name="STRING" select="$TOTAL.PACKAGES.LABEL"/>
- <xsl:with-param name="SINGLE" select="$PACKAGE.SINGLE.LABEL"/>
- <xsl:with-param name="PULURAL" select="$PACKAGE.PULURAL.LABEL"/>
- </xsl:call-template>
- </font></td>
- </tr>
- </table>
-</xsl:template>
-
-
-<xsl:template name='string_format'>
- <xsl:param name="COUNT" select="1"/>
- <xsl:param name="STRING" select="''"/>
- <xsl:param name="SINGLE" select="''"/>
- <xsl:param name="PULURAL" select="''"/>
- <xsl:variable name="count_str" select="concat(substring-before($STRING,'#1'), $COUNT, substring-after($STRING,'#1'))" />
-
- <xsl:choose>
- <xsl:when test="$COUNT > 1">
- <xsl:value-of select="concat(substring-before($count_str,'$1'), $PULURAL, substring-after($count_str,'$1'))" />
- </xsl:when>
- <xsl:otherwise>
- <xsl:value-of select="concat(substring-before($count_str,'$1'), $SINGLE, substring-after($count_str,'$1'))" />
- </xsl:otherwise>
- </xsl:choose>
-</xsl:template>
-
-
-<xsl:template match="PackageStats" >
- <xsl:variable name="package-name">
- <xsl:choose>
- <xsl:when test="@package = ''">
- <xsl:value-of select="$DEFAULT.PACKAGE.NAME"/>
- </xsl:when>
- <xsl:otherwise>
- <xsl:value-of select="@package"/>
- </xsl:otherwise>
- </xsl:choose>
- </xsl:variable>
- <xsl:variable name="package-prefix">
- <xsl:choose>
- <xsl:when test="@package = ''">
- <xsl:text></xsl:text>
- </xsl:when>
- <xsl:otherwise>
- <xsl:value-of select="concat(@package,'.')"/>
- </xsl:otherwise>
- </xsl:choose>
- </xsl:variable>
- <h2 align="center"><xsl:value-of select="$PACKAGE.LABEL"/><i><font color='green'><xsl:value-of select="$package-name" /></font></i></h2>
- <table width="{$TABLE.WIDTH}" border="1" align="center">
- <xsl:call-template name="table_header" />
-
- <xsl:call-template name="status_table_row">
- <xsl:with-param name="LABEL" select="$TABLE.ROW.OUTER" />
- <xsl:with-param name="COUNT" select="count(ClassStats[@interface='false' and substring-after(@class,'$')=''])" />
- <xsl:with-param name="BUGS" select="sum(ClassStats[@interface='false' and substring-after(@class,'$')='']/@bugs)" />
- </xsl:call-template>
-
- <xsl:call-template name="status_table_row">
- <xsl:with-param name="LABEL" select="$TABLE.ROW.INNER" />
- <xsl:with-param name="COUNT" select="count(ClassStats[@interface='false' and substring-after(@class,'$')!=''])" />
- <xsl:with-param name="BUGS" select="sum(ClassStats[@interface='false' and substring-after(@class,'$')!='']/@bugs)" />
- </xsl:call-template>
-
- <xsl:call-template name="status_table_row">
- <xsl:with-param name="LABEL" select="$TABLE.ROW.INTERFACE" />
- <xsl:with-param name="COUNT" select="count(ClassStats[@interface='true'])" />
- <xsl:with-param name="BUGS" select="sum(ClassStats[@interface='true']/@bugs)" />
- </xsl:call-template>
-
- <xsl:call-template name="status_table_row">
- <xsl:with-param name="LABEL" select="$TABLE.ROW.TOTAL" />
- <xsl:with-param name="COUNT" select="@total_types" />
- <xsl:with-param name="BUGS" select="@total_bugs" />
- <xsl:with-param name="FONT_SIZE" select="5"/>
- </xsl:call-template>
-
- </table>
- <xsl:if test="@total_bugs > 0">
- <table width="{$TABLE.WIDTH}" border="0" align="center">
- <xsl:variable name="max_bugs">
- <xsl:for-each select="ClassStats">
- <xsl:sort select="@bugs" data-type="number" order="descending"/>
- <xsl:if test="position()=1">
- <xsl:value-of select="@bugs"/>
- </xsl:if>
- </xsl:for-each>
- </xsl:variable>
-
- <tr>
- <td align="left" colspan="2">
- <font face="{$PAGE.FONT}" size="4">
- <xsl:call-template name='string_format'>
- <xsl:with-param name="COUNT" select="$max_bugs"/>
- <xsl:with-param name="STRING" select="$PACKAGE.BUGCLASS.LABEL"/>
- <xsl:with-param name="SINGLE" select="$BUGS.SINGLE.LABEL"/>
- <xsl:with-param name="PULURAL" select="$BUGS.PULURAL.LABEL"/>
- </xsl:call-template>
- </font>
- </td>
- </tr>
-
- <xsl:for-each select="ClassStats">
- <xsl:if test="@bugs = $max_bugs">
- <tr>
- <td>       </td>
- <td align="left"><font face="{$PAGE.FONT}" color="red" size="4"><i><xsl:value-of select="$package-prefix"/><xsl:value-of select="@class" /></i></font></td>
- </tr>
- </xsl:if>
- </xsl:for-each>
-
- </table>
- </xsl:if>
- <br/>
-</xsl:template>
-
-</xsl:stylesheet>
diff --git a/tools/findbugs-1.3.9/README.txt b/tools/findbugs/README.txt
similarity index 100%
rename from tools/findbugs-1.3.9/README.txt
rename to tools/findbugs/README.txt
diff --git a/tools/findbugs-1.3.9/bin/addMessages b/tools/findbugs/bin/addMessages
similarity index 97%
rename from tools/findbugs-1.3.9/bin/addMessages
rename to tools/findbugs/bin/addMessages
index d32aed3..5b9e5be 100755
--- a/tools/findbugs-1.3.9/bin/addMessages
+++ b/tools/findbugs/bin/addMessages
@@ -63,7 +63,7 @@
fb_mainclass=edu.umd.cs.findbugs.AddMessages
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/computeBugHistory b/tools/findbugs/bin/computeBugHistory
similarity index 97%
rename from tools/findbugs-1.3.9/bin/computeBugHistory
rename to tools/findbugs/bin/computeBugHistory
index f3b6910..24ce26c 100755
--- a/tools/findbugs-1.3.9/bin/computeBugHistory
+++ b/tools/findbugs/bin/computeBugHistory
@@ -66,7 +66,7 @@
fb_mainclass=edu.umd.cs.findbugs.workflow.Update
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/convertXmlToText b/tools/findbugs/bin/convertXmlToText
similarity index 97%
rename from tools/findbugs-1.3.9/bin/convertXmlToText
rename to tools/findbugs/bin/convertXmlToText
index 4ad7890..e8493d6 100755
--- a/tools/findbugs-1.3.9/bin/convertXmlToText
+++ b/tools/findbugs/bin/convertXmlToText
@@ -63,7 +63,7 @@
fb_mainclass=edu.umd.cs.findbugs.PrintingBugReporter
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/copyBuggySource b/tools/findbugs/bin/copyBuggySource
similarity index 97%
rename from tools/findbugs-1.3.9/bin/copyBuggySource
rename to tools/findbugs/bin/copyBuggySource
index 20eac2c..355819b 100755
--- a/tools/findbugs-1.3.9/bin/copyBuggySource
+++ b/tools/findbugs/bin/copyBuggySource
@@ -63,7 +63,7 @@
fb_mainclass=edu.umd.cs.findbugs.workflow.CopyBuggySource
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/defectDensity b/tools/findbugs/bin/defectDensity
similarity index 97%
rename from tools/findbugs-1.3.9/bin/defectDensity
rename to tools/findbugs/bin/defectDensity
index 19ae0b9..a297a03 100755
--- a/tools/findbugs-1.3.9/bin/defectDensity
+++ b/tools/findbugs/bin/defectDensity
@@ -65,7 +65,7 @@
fb_mainclass=edu.umd.cs.findbugs.workflow.DefectDensity
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/deprecated/bugHistory b/tools/findbugs/bin/deprecated/bugHistory
similarity index 97%
rename from tools/findbugs-1.3.9/bin/deprecated/bugHistory
rename to tools/findbugs/bin/deprecated/bugHistory
index ed6d123..5f5599b 100755
--- a/tools/findbugs-1.3.9/bin/deprecated/bugHistory
+++ b/tools/findbugs/bin/deprecated/bugHistory
@@ -63,7 +63,7 @@
fb_mainclass=edu.umd.cs.findbugs.workflow.BugHistory
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/deprecated/unionBugs b/tools/findbugs/bin/deprecated/unionBugs
similarity index 97%
rename from tools/findbugs-1.3.9/bin/deprecated/unionBugs
rename to tools/findbugs/bin/deprecated/unionBugs
index dc16c61..9da0b84 100755
--- a/tools/findbugs-1.3.9/bin/deprecated/unionBugs
+++ b/tools/findbugs/bin/deprecated/unionBugs
@@ -66,7 +66,7 @@
fb_mainclass=edu.umd.cs.findbugs.UnionResults
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/deprecated/unionResults b/tools/findbugs/bin/deprecated/unionResults
similarity index 97%
rename from tools/findbugs-1.3.9/bin/deprecated/unionResults
rename to tools/findbugs/bin/deprecated/unionResults
index fdbfb6a..01d2126 100755
--- a/tools/findbugs-1.3.9/bin/deprecated/unionResults
+++ b/tools/findbugs/bin/deprecated/unionResults
@@ -68,7 +68,7 @@
fb_mainclass=edu.umd.cs.findbugs.workflow.UnionResults
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/computeBugHistory b/tools/findbugs/bin/deprecated/updateBugs
similarity index 97%
copy from tools/findbugs-1.3.9/bin/computeBugHistory
copy to tools/findbugs/bin/deprecated/updateBugs
index f3b6910..24ce26c 100755
--- a/tools/findbugs-1.3.9/bin/computeBugHistory
+++ b/tools/findbugs/bin/deprecated/updateBugs
@@ -66,7 +66,7 @@
fb_mainclass=edu.umd.cs.findbugs.workflow.Update
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/rejarForAnalysis b/tools/findbugs/bin/experimental/backdateHistoryUsingSource
similarity index 93%
copy from tools/findbugs-1.3.9/bin/rejarForAnalysis
copy to tools/findbugs/bin/experimental/backdateHistoryUsingSource
index bab7bbb..55030fa 100755
--- a/tools/findbugs-1.3.9/bin/rejarForAnalysis
+++ b/tools/findbugs/bin/experimental/backdateHistoryUsingSource
@@ -60,10 +60,10 @@
fi
fi
-fb_mainclass=edu.umd.cs.findbugs.workflow.RejarClassesForAnalysis
+fb_mainclass=edu.umd.cs.findbugs.workflow.BackdateHistoryUsingSource
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/experimental/churn b/tools/findbugs/bin/experimental/churn
similarity index 97%
rename from tools/findbugs-1.3.9/bin/experimental/churn
rename to tools/findbugs/bin/experimental/churn
index f0aa13c..998de6a 100755
--- a/tools/findbugs-1.3.9/bin/experimental/churn
+++ b/tools/findbugs/bin/experimental/churn
@@ -63,7 +63,7 @@
fb_mainclass=edu.umd.cs.findbugs.workflow.Churn
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/copyBuggySource b/tools/findbugs/bin/experimental/obfuscate
similarity index 94%
copy from tools/findbugs-1.3.9/bin/copyBuggySource
copy to tools/findbugs/bin/experimental/obfuscate
index 20eac2c..ead5619 100755
--- a/tools/findbugs-1.3.9/bin/copyBuggySource
+++ b/tools/findbugs/bin/experimental/obfuscate
@@ -60,10 +60,10 @@
fi
fi
-fb_mainclass=edu.umd.cs.findbugs.workflow.CopyBuggySource
+fb_mainclass=edu.umd.cs.findbugs.workflow.ObfuscateBugs
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/experimental/treemapVisualization b/tools/findbugs/bin/experimental/treemapVisualization
similarity index 97%
rename from tools/findbugs-1.3.9/bin/experimental/treemapVisualization
rename to tools/findbugs/bin/experimental/treemapVisualization
index 07fc50c..9795ff8 100755
--- a/tools/findbugs-1.3.9/bin/experimental/treemapVisualization
+++ b/tools/findbugs/bin/experimental/treemapVisualization
@@ -63,7 +63,7 @@
fb_mainclass=edu.umd.cs.findbugs.workflow.TreemapVisualization
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/findbugs b/tools/findbugs/bin/fb
similarity index 91%
copy from tools/findbugs-1.3.9/bin/findbugs
copy to tools/findbugs/bin/fb
index b0d2769..4b96508 100755
--- a/tools/findbugs-1.3.9/bin/findbugs
+++ b/tools/findbugs/bin/fb
@@ -66,14 +66,13 @@
fi
fi
-maxheap=768
fb_appjar="$findbugs_home/lib/findbugs.jar"
ShowHelpAndExit() {
fb_mainclass="edu.umd.cs.findbugs.ShowHelp"
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
@@ -85,7 +84,7 @@
}
# Set defaults
-fb_mainclass="edu.umd.cs.findbugs.LaunchAppropriateUI"
+fb_mainclass="edu.umd.cs.findbugs.workflow.FB"
user_jvmargs=''
ea_arg=''
debug_arg=''
@@ -96,14 +95,6 @@
# Handle command line arguments.
while [ $# -gt 0 ]; do
case $1 in
- -gui)
- # this is the default
- ;;
-
- -gui1)
- user_props="-Dfindbugs.launchUI=1 $user_props"
- ;;
-
-textui)
fb_mainclass="edu.umd.cs.findbugs.FindBugs2"
;;
@@ -119,7 +110,7 @@
-maxHeap)
shift
- maxheap="$1"
+ fb_maxheap="-Xmx$1m"
;;
-javahome)
@@ -151,7 +142,7 @@
shift
done
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
@@ -177,7 +168,9 @@
done
fb_jvmargs="$user_jvmargs $debug_arg $conservespace_arg $workhard_arg $user_props $ea_arg"
-fb_maxheap="-Xmx${maxheap}m"
+if [ $maxheap ]; then
+ fb_maxheap="-Xmx${maxheap}m"
+fi
# Extra JVM args for MacOSX.
if [ $fb_osname = "Darwin" ]; then
@@ -187,7 +180,7 @@
fi
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/fbwrap b/tools/findbugs/bin/fbwrap
similarity index 97%
rename from tools/findbugs-1.3.9/bin/fbwrap
rename to tools/findbugs/bin/fbwrap
index b0ea7c4..85aba91 100755
--- a/tools/findbugs-1.3.9/bin/fbwrap
+++ b/tools/findbugs/bin/fbwrap
@@ -72,7 +72,7 @@
shift
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/filterBugs b/tools/findbugs/bin/filterBugs
similarity index 97%
rename from tools/findbugs-1.3.9/bin/filterBugs
rename to tools/findbugs/bin/filterBugs
index f2593d8..9116229 100755
--- a/tools/findbugs-1.3.9/bin/filterBugs
+++ b/tools/findbugs/bin/filterBugs
@@ -66,7 +66,7 @@
fb_mainclass=edu.umd.cs.findbugs.workflow.Filter
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/findbugs b/tools/findbugs/bin/findbugs
similarity index 95%
rename from tools/findbugs-1.3.9/bin/findbugs
rename to tools/findbugs/bin/findbugs
index b0d2769..471cf31 100755
--- a/tools/findbugs-1.3.9/bin/findbugs
+++ b/tools/findbugs/bin/findbugs
@@ -66,14 +66,12 @@
fi
fi
-maxheap=768
-
fb_appjar="$findbugs_home/lib/findbugs.jar"
ShowHelpAndExit() {
fb_mainclass="edu.umd.cs.findbugs.ShowHelp"
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
@@ -119,7 +117,7 @@
-maxHeap)
shift
- maxheap="$1"
+ fb_maxheap="-Xmx$1m"
;;
-javahome)
@@ -151,7 +149,7 @@
shift
done
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
@@ -177,7 +175,9 @@
done
fb_jvmargs="$user_jvmargs $debug_arg $conservespace_arg $workhard_arg $user_props $ea_arg"
-fb_maxheap="-Xmx${maxheap}m"
+if [ $maxheap ]; then
+ fb_maxheap="-Xmx${maxheap}m"
+fi
# Extra JVM args for MacOSX.
if [ $fb_osname = "Darwin" ]; then
@@ -187,7 +187,7 @@
fi
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/rejarForAnalysis b/tools/findbugs/bin/findbugs-csr
similarity index 93%
copy from tools/findbugs-1.3.9/bin/rejarForAnalysis
copy to tools/findbugs/bin/findbugs-csr
index bab7bbb..374d602 100755
--- a/tools/findbugs-1.3.9/bin/rejarForAnalysis
+++ b/tools/findbugs/bin/findbugs-csr
@@ -1,5 +1,6 @@
#! /bin/sh
+
program="$0"
# Follow symlinks until we get to the actual file.
@@ -60,10 +61,10 @@
fi
fi
-fb_mainclass=edu.umd.cs.findbugs.workflow.RejarClassesForAnalysis
+fb_mainclass=edu.umd.cs.findbugs.workflow.CloudSyncAndReport
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/findbugs-dbStats b/tools/findbugs/bin/findbugs-dbStats
similarity index 97%
rename from tools/findbugs-1.3.9/bin/findbugs-dbStats
rename to tools/findbugs/bin/findbugs-dbStats
index 5020e9f..1ada8ee 100755
--- a/tools/findbugs-1.3.9/bin/findbugs-dbStats
+++ b/tools/findbugs/bin/findbugs-dbStats
@@ -64,7 +64,7 @@
fb_mainclass=edu.umd.cs.findbugs.cloud.db.DBStats
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/findbugs-msv b/tools/findbugs/bin/findbugs-msv
similarity index 97%
rename from tools/findbugs-1.3.9/bin/findbugs-msv
rename to tools/findbugs/bin/findbugs-msv
index 7ab3a05..ab00dd2 100755
--- a/tools/findbugs-1.3.9/bin/findbugs-msv
+++ b/tools/findbugs/bin/findbugs-msv
@@ -64,7 +64,7 @@
fb_mainclass=edu.umd.cs.findbugs.workflow.MergeSummarizeAndView
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/findbugs.bat b/tools/findbugs/bin/findbugs.bat
similarity index 100%
rename from tools/findbugs-1.3.9/bin/findbugs.bat
rename to tools/findbugs/bin/findbugs.bat
diff --git a/tools/findbugs/bin/findbugs.ico b/tools/findbugs/bin/findbugs.ico
new file mode 100755
index 0000000..834ff37
--- /dev/null
+++ b/tools/findbugs/bin/findbugs.ico
Binary files differ
diff --git a/tools/findbugs-1.3.9/bin/findbugs2 b/tools/findbugs/bin/findbugs2
similarity index 100%
rename from tools/findbugs-1.3.9/bin/findbugs2
rename to tools/findbugs/bin/findbugs2
diff --git a/tools/findbugs-1.3.9/bin/listBugDatabaseInfo b/tools/findbugs/bin/listBugDatabaseInfo
similarity index 97%
rename from tools/findbugs-1.3.9/bin/listBugDatabaseInfo
rename to tools/findbugs/bin/listBugDatabaseInfo
index 21205bd..891f455 100755
--- a/tools/findbugs-1.3.9/bin/listBugDatabaseInfo
+++ b/tools/findbugs/bin/listBugDatabaseInfo
@@ -63,7 +63,7 @@
fb_mainclass=edu.umd.cs.findbugs.workflow.ListBugDatabaseInfo
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/mineBugHistory b/tools/findbugs/bin/mineBugHistory
similarity index 97%
rename from tools/findbugs-1.3.9/bin/mineBugHistory
rename to tools/findbugs/bin/mineBugHistory
index 24140ea..520aa83 100755
--- a/tools/findbugs-1.3.9/bin/mineBugHistory
+++ b/tools/findbugs/bin/mineBugHistory
@@ -63,7 +63,7 @@
fb_mainclass=edu.umd.cs.findbugs.workflow.MineBugHistory
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/printAppVersion b/tools/findbugs/bin/printAppVersion
similarity index 97%
rename from tools/findbugs-1.3.9/bin/printAppVersion
rename to tools/findbugs/bin/printAppVersion
index f82031d..7994b8c 100755
--- a/tools/findbugs-1.3.9/bin/printAppVersion
+++ b/tools/findbugs/bin/printAppVersion
@@ -63,7 +63,7 @@
fb_mainclass=edu.umd.cs.findbugs.workflow.PrintAppVersion
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/printClass b/tools/findbugs/bin/printClass
similarity index 97%
rename from tools/findbugs-1.3.9/bin/printClass
rename to tools/findbugs/bin/printClass
index 5e0ff89..0b76853 100755
--- a/tools/findbugs-1.3.9/bin/printClass
+++ b/tools/findbugs/bin/printClass
@@ -63,7 +63,7 @@
fb_mainclass=edu.umd.cs.findbugs.visitclass.PrintClass
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/rejarForAnalysis b/tools/findbugs/bin/rejarForAnalysis
similarity index 97%
rename from tools/findbugs-1.3.9/bin/rejarForAnalysis
rename to tools/findbugs/bin/rejarForAnalysis
index bab7bbb..20877ee 100755
--- a/tools/findbugs-1.3.9/bin/rejarForAnalysis
+++ b/tools/findbugs/bin/rejarForAnalysis
@@ -63,7 +63,7 @@
fb_mainclass=edu.umd.cs.findbugs.workflow.RejarClassesForAnalysis
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/setBugDatabaseInfo b/tools/findbugs/bin/setBugDatabaseInfo
similarity index 97%
rename from tools/findbugs-1.3.9/bin/setBugDatabaseInfo
rename to tools/findbugs/bin/setBugDatabaseInfo
index ab3ea23..b1e8ec7 100755
--- a/tools/findbugs-1.3.9/bin/setBugDatabaseInfo
+++ b/tools/findbugs/bin/setBugDatabaseInfo
@@ -63,7 +63,7 @@
fb_mainclass=edu.umd.cs.findbugs.workflow.SetBugDatabaseInfo
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/deprecated/unionResults b/tools/findbugs/bin/unionBugs
similarity index 97%
copy from tools/findbugs-1.3.9/bin/deprecated/unionResults
copy to tools/findbugs/bin/unionBugs
index fdbfb6a..01d2126 100755
--- a/tools/findbugs-1.3.9/bin/deprecated/unionResults
+++ b/tools/findbugs/bin/unionBugs
@@ -68,7 +68,7 @@
fb_mainclass=edu.umd.cs.findbugs.workflow.UnionResults
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/bin/xpathFind b/tools/findbugs/bin/xpathFind
similarity index 97%
rename from tools/findbugs-1.3.9/bin/xpathFind
rename to tools/findbugs/bin/xpathFind
index 780238e..c0bd5e9 100755
--- a/tools/findbugs-1.3.9/bin/xpathFind
+++ b/tools/findbugs/bin/xpathFind
@@ -63,7 +63,7 @@
fb_mainclass=edu.umd.cs.findbugs.xml.XPathFind
fb_javacmd=${fb_javacmd:-"java"}
-fb_maxheap=${fb_maxheap:-"-Xmx584m"}
+fb_maxheap=${fb_maxheap:-"-Xmx768m"}
fb_appjar=${fb_appjar:-"$findbugs_home/lib/findbugs.jar"}
set -f
#echo command: \
diff --git a/tools/findbugs-1.3.9/doc/AddingDetectors.txt b/tools/findbugs/doc/AddingDetectors.txt
similarity index 77%
rename from tools/findbugs-1.3.9/doc/AddingDetectors.txt
rename to tools/findbugs/doc/AddingDetectors.txt
index 109e004..131e690 100644
--- a/tools/findbugs-1.3.9/doc/AddingDetectors.txt
+++ b/tools/findbugs/doc/AddingDetectors.txt
@@ -15,6 +15,9 @@
file. That XML file registers instances of Detectors, as well
as particular "bug patterns" that the detector reports.
+Additionally to the findbugs.xml, bugrank.txt and messages.xml files are
+required for each FindBugs detector plugin.
+
At startup, FindBugs loads all plugin Jar files. At analysis time,
all detectors named in the findbugs.xml files from those plugins
are instantiated and applied to analyzed class files.
@@ -33,7 +36,7 @@
The "findbugs.xml" and "messages.xml" files used by the standard FindBugs
bug pattern detectors (coreplugin.jar) can be found in the "etc" directory
-of the findbugs source distribution.
+of the findbugs source distribution. Both files must be UTF-8 encoded.
============================
@@ -150,7 +153,7 @@
<BugCategory> elements optionally describe any categories you
may have created for your bug patterns. You can skip these if
you are using only the categories defined by the core plugin.
-
+
The <Description> child element has a brief (a word or three)
description of the category. The <Abbreviation> child element
is typically a single capital latter. The optional <Details>
@@ -171,23 +174,64 @@
BugPattern elements must have the following child elements:
<ShortDescription> this is used for when "View->Full Descriptions"
- is turned off in the GUI, and it's also used as the title for
+ is turned off in the GUI, and it's also used as the title for
descriptions in the Details window.
-
+
<LongDescription> this is used for when "View->Full Descriptions"
is turned on in the GUI, and for output using the command line UI.
The placeholders in the long description ({0}, {1}, etc.)
refer to BugAnnotations attached to the BugInstances reported by
the detector for this bug pattern. You may also use constructs
like {1.name} or {1.returnType}.
-
+
<Details> this is the descriptive text to be used in the Details
window. It consists of HTML markup to appear in the BODY element of an HTML
document. It should be specified in a CDATA section so that the HTML
tags are not misinterpreted as XML.
-
+
<BugCode> is the text which describes the common characteristic of all
of the BugPatterns which share an abbreviation. In the example above,
the abbreviation "UL" is for bugs in which a lock is not released.
The text of a BugCode element is shown for tree nodes in the GUI
which group bug instances by "bug type".
+
+======================================
+6. Meaning of elements in bugrank.txt
+======================================
+
+For the detailed and up to date information, please read the javadoc of the
+edu.umd.cs.findbugs.BugRanker class.
+
+============================================
+7. Using 3rd party libraries in the detector
+============================================
+
+FindBugs plugins may extend the default FindBugs classpath and use custom 3rd party
+libraries during the analysis. This libraries must be part of standard jar class path
+specified via "ClassPath" attribute in the META-INF/MANIFEST.MF file.
+
+======================================
+8. Adding detectors to Eclipse plugin
+======================================
+
+Since version 2.0.0 Eclipse plugin allows to configure or contribute custom detectors.
+
+7.1. It is possible to contribute custom detectors via standard Eclipse extensions mechanism.
+Please check the documentation of the "findBugsEclipsePlugin/schema/detectorPlugins.exsd"
+extension point how to update the plugin.xml. Existing FindBugs detector plugins can
+be easily "extended" to be full featured FindBugs & Eclipse detector plugins.
+Usually you only need to add META-INF/MANIFEST.MF and plugin.xml to the jar and
+update your build scripts to not to override the MANIFEST.MF during the build.
+
+7.2 It is possible to configure custom detectors via Eclipse workspace preferences.
+Go to "Window->Preferences->Java->FindBugs->Misc. Settings->Custom Detectors"
+and specify there locations of any additional plugin libraries.
+
+7.3 Plugins contributed via standard Eclipse extensions mechanism (see 7.1)
+may extend the default FindBugs classpath and use custom libraries during the analysis.
+This libraries must be part of standard Eclipse plugin dependencies specified via
+either "Require-Bundle" or "Bundle-ClassPath" attributes in the MANIFEST.MF file.
+In case custom detectors need access to this custom libraries at runtime, an
+extra line must be added to the MANIFEST.MF (without quotation marks):
+"Eclipse-RegisterBuddy: edu.umd.cs.findbugs.plugin.eclipse".
+
diff --git a/tools/findbugs/doc/Changes.html b/tools/findbugs/doc/Changes.html
new file mode 100644
index 0000000..e989bed
--- /dev/null
+++ b/tools/findbugs/doc/Changes.html
@@ -0,0 +1,2711 @@
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
+<html>
+<head>
+<title>FindBugs Change Log</title>
+<link rel="stylesheet" type="text/css" href="findbugs.css">
+
+</head>
+
+<body>
+
+ <table width="100%">
+ <tr>
+
+
+<td bgcolor="#b9b9fe" valign="top" align="left" width="20%">
+<table width="100%" cellspacing="0" border="0">
+<tr><td><a class="sidebar" href="index.html"><img src="umdFindbugs.png" alt="FindBugs"></a></td></tr>
+
+<tr><td> </td></tr>
+
+<tr><td><b>Docs and Info</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="findbugs2.html">FindBugs 2.0</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="factSheet.html">Fact sheet</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="manual/index.html">Manual</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="ja/manual/index.html">Manual(ja/日本語)</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="FAQ.html">FAQ</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="bugDescriptions.html">Bug descriptions</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="mailingLists.html">Mailing lists</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="publications.html">Documents and Publications</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="links.html">Links</a></font></td></tr>
+
+<tr><td> </td></tr>
+
+<tr><td><a class="sidebar" href="downloads.html"><b>Downloads</b></a></td></tr>
+
+<tr><td> </td></tr>
+
+<tr><td><a class="sidebar" href="http://www.cafeshops.com/findbugs"><b>FindBugs Swag</b></a></td></tr>
+
+<tr><td> </td></tr>
+
+<tr><td><b>Development</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://sourceforge.net/tracker/?group_id=96405">Open bugs</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="reportingBugs.html">Reporting bugs</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="contributing.html">Contributing</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="team.html">Dev team</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="api/index.html">API</a> <a class="sidebar" href="api/overview-summary.html">[no frames]</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="Changes.html">Change log</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://sourceforge.net/projects/findbugs">SF project page</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://code.google.com/p/findbugs/source/browse/">Browse source</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://code.google.com/p/findbugs/source/list">Latest code changes</a></font></td></tr>
+</table>
+</td>
+
+ <td align="left" valign="top">
+
+
+ <h1>FindBugs Change Log, Version 2.0.2</h1>
+ <ul>
+ <li>Fix false positions for <a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR">NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR</a>
+ - fixing <a
+ href="https://sourceforge.net/tracker/?func=detail&aid=3547559&group_id=96405&atid=614693">Bug3547559</a>,
+ <a
+ href="https://sourceforge.net/tracker/?func=detail&aid=3555408&group_id=96405&atid=614693">Bug3555408</a>,
+ <a
+ href="https://sourceforge.net/tracker/?func=detail&aid=3580266&group_id=96405&atid=614693">Bug3580266</a>
+ and <a
+ href="https://sourceforge.net/tracker/?func=detail&aid=3587164&group_id=96405&atid=614693">Bug3587164</a>.
+
+
+ </li>
+ <li>Fix false positives for <a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#SF_SWITCH_NO_DEFAULT">SF_SWITCH_NO_DEFAULT</a>
+ <li>Inline access methods for private fields,
+ fixing false positive in <a
+ href="https://sourceforge.net/tracker/?func=detail&aid=3484713&group_id=96405&atid=614693">Bug3484713</a>.
+
+ <li>Type qualifier annotations, including nullness
+ annotations, are now ignored on vararg parameters (including
+ default and inherited annotations), awaiting JSR308.
+ <li>Defined new bug pattern to give better explanations of
+ issues involving strict type qualifiers <a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#TQ_UNKNOWN_VALUE_USED_WHERE_ALWAYS_STRICTLY_REQUIRED">TQ_UNKNOWN_VALUE_USED_WHERE_ALWAYS_STRICTLY_REQUIRED</a>
+ <li>Adjusted analysis of type qualifiers, now giving warnings
+ where a computed value is used in a place where a value with a
+ strict type qualifier is required.
+ <li>Complain about missing classes only if they are
+ encountered while analyzing application classes; ignore missing
+ classes that are encounted while analyzing classes loaded from the
+ auxclasspath. Fix for <a
+ href="https://sourceforge.net/tracker/?func=detail&aid=3588379&group_id=96405&atid=614693">Bug3588379</a>
+ <li>Fixed false positive null pointer warning coming from
+ synthetic bridge methods, fixing <a
+ href="https://sourceforge.net/tracker/?func=detail&aid=3589328&group_id=96405&atid=614693">Bug3589328</a>
+ <li>In general, suppress warnings in synthetic methods.
+ <li>Fix some false positives involving <a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#GC_UNRELATED_TYPES">GC_UNRELATED_TYPES</a>
+ on classes that extend generic collection classes.
+
+ </li>
+ <li>Combine multiple identical warnings about
+ <a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#DM_DEFAULT_ENCODING">DM_DEFAULT_ENCODING</a>
+ that occur in the same method,
+ simplifying issue triage.
+
+ <li>Changes by Andrey Loskutov
+ <ul>
+ <li>fixed job scheduling errors in 3.8/4.2 Eclipse <a
+ href="https://bugs.eclipse.org/bugs/show_bug.cgi?id=393748">bug
+ report</a>
+ <li>more realistic progress bar updates for jobs
+ <li>added nullness annotations for some common Eclipse API
+ methods known to usually return null values
+ <li>Added support for org.eclipse.jdt.annotation.Nullable,
+ NonNull and NonNullByDefault annotations (introduced with
+ Eclipse 3.8/4.2)</li>
+ </ul>
+ <li>Documentation improvements
+ <li><a href="http://code.google.com/p/findbugs/source/list">lots
+ of other small changes</a>
+ </ul>
+ <h1>FindBugs Change Log, Version 2.0.1</h1>
+
+ <ul>
+ <li>New bug patterns; in some cases, bugs previous reported as
+ other bug patterns are reported as instances of these new bug
+ patterns in order to make it easier for developers to understand
+ the bug reports
+ <ul>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#PT_ABSOLUTE_PATH_TRAVERSAL">PT_ABSOLUTE_PATH_TRAVERSAL</a></li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#PT_RELATIVE_PATH_TRAVERSAL">PT_RELATIVE_PATH_TRAVERSAL</a></li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR">NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR</a></li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#MS_SHOULD_BE_REFACTORED_TO_BE_FINAL">MS_SHOULD_BE_REFACTORED_TO_BE_FINAL</a></li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#BC_UNCONFIRMED_CAST_OF_RETURN_VALUE">BC_UNCONFIRMED_CAST_OF_RETURN_VALUE</a></li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#PT_ABSOLUTE_PATH_TRAVERSAL">PT_ABSOLUTE_PATH_TRAVERSAL</a></li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#TQ_COMPARING_VALUES_WITH_INCOMPATIBLE_TYPE_QUALIFIERS">TQ_COMPARING_VALUES_WITH_INCOMPATIBLE_TYPE_QUALIFIERS</a></li>
+ </ul>
+ </li>
+
+ <li>Changes to fix false negatives for the following bug
+ patterns: <a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#BC_UNCONFIRMED_CAST">BC_UNCONFIRMED_CAST</a>,
+ <a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#EC_BAD_ARRAY_COMPARE">EC_BAD_ARRAY_COMPARE</a>,
+ <a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#EQ_UNUSUAL">EQ_UNUSUAL</a>,
+ <a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#GC_UNRELATED_TYPES">GC_UNRELATED_TYPES</a>,
+ and <a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE">NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE</a>.
+ </li>
+
+ <li>Changes to fix false positions for the following bug
+ patterns: <a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#DMI_DOH">DMI_DOH</a>,
+ <a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#EC_UNRELATED_TYPES">EC_UNRELATED_TYPES</a>,
+ and <a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#SE_BAD_FIELD">SE_BAD_FIELD</a>.
+ </li>
+ </ul>
+
+ <h1>FindBugs Change Log, Version 2.0.0</h1>
+
+ <h2>Changes since version 1.3.8</h2>
+ <ul>
+ <li>New bug patterns; in some cases, bugs previous reported as
+ other bug patterns are reported as instances of these new bug
+ patterns in order to make it easier for developers to understand
+ the bug reports
+ <ul>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#BC_IMPOSSIBLE_DOWNCAST ">BC_IMPOSSIBLE_DOWNCAST
+ </a></li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#BC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY ">BC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY
+ </a></li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#EC_INCOMPATIBLE_ARRAY_COMPARE ">EC_INCOMPATIBLE_ARRAY_COMPARE
+ </a></li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#JLM_JSR166_UTILCONCURRENT_MONITORENTER ">JLM_JSR166_UTILCONCURRENT_MONITORENTER
+ </a></li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE ">LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE
+ </a></li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#NP_CLOSING_NULL ">NP_CLOSING_NULL
+ </a></li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#RC_REF_COMPARISON_BAD_PRACTICE ">RC_REF_COMPARISON_BAD_PRACTICE
+ </a></li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN ">RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN
+ </a></li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED ">RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED
+ </a></li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#SIC_THREADLOCAL_DEADLY_EMBRACE ">SIC_THREADLOCAL_DEADLY_EMBRACE
+ </a></li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR ">UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR
+ </a></li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#VA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIED ">VA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIED
+ </a></li>
+ </ul>
+ </li>
+ <li>Providing a bug rank (1-20), and the ability to filter by
+ bug rank. Eventually, it will be possible to specify your own
+ rules for ranking bugs, but the procedure for doing so hasn't been
+ specified yet.</li>
+ <li>Fixed about <a
+ href="https://sourceforge.net/search/index.php?group_id=96405&search_summary=1&search_details=1&type_of_search=artifact&group_artifact_id%5B%5D=614693&open_date_start=2009-03-16&open_date_end=2009-08-20&form_submit=Search">45
+ bugs filed</a> through SourceForge
+ </li>
+ <li>Various reclassifications and priority tweaks</li>
+ <li>Added more bug annotations to a variety of bug reports.
+ This provides more context for understanding bug reports (e.g., if
+ the value in question was is the return value of a method, the
+ method is described as the source of the value in a bug
+ annotation). This also provide more accurate tracking of issues
+ across versions of the code being analyzed, but has the downside
+ that when comparing results from FindBugs 1.3.8 and FindBugs 1.3.9
+ on the same version of code being analyzed, FindBugs may think
+ that mistakenly believe that the issue reported by 1.3.8 was fixed
+ and a new issue was introduced that was reported by FindBugs
+ 1.3.9. While annoying, it would be unusual for more than a dozen
+ issues per million lines of codes to be mistracked.</li>
+ <li>Lots of internal changes moving towards FindBugs 2.0, but
+ these features are undocumented, not yet officially supported, and
+ subject to radical changes before FindBugs 2.0 is released.</li>
+ </ul>
+
+ <p>Changes since version 1.3.8</p>
+ <ul>
+ <li>New bug patterns; in some cases, bugs previous reported as
+ other bug patterns are reported as instances of these new bug
+ patterns in order to make it easier for developers to understand
+ the bug reports
+ <ul>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#BC_IMPOSSIBLE_DOWNCAST ">BC_IMPOSSIBLE_DOWNCAST
+ </a>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#BC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY ">BC_IMPOSSIBLE_DOWNCAST_OF_TOARRAY
+ </a>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#EC_INCOMPATIBLE_ARRAY_COMPARE ">EC_INCOMPATIBLE_ARRAY_COMPARE
+ </a>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#JLM_JSR166_UTILCONCURRENT_MONITORENTER ">JLM_JSR166_UTILCONCURRENT_MONITORENTER
+ </a>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE ">LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE
+ </a>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#NP_CLOSING_NULL ">NP_CLOSING_NULL
+ </a>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#RC_REF_COMPARISON_BAD_PRACTICE ">RC_REF_COMPARISON_BAD_PRACTICE
+ </a>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN ">RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN
+ </a>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED ">RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED
+ </a>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#SIC_THREADLOCAL_DEADLY_EMBRACE ">SIC_THREADLOCAL_DEADLY_EMBRACE
+ </a>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR ">UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR
+ </a>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#VA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIED ">VA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIED
+ </a>
+ </ul>
+ </li>
+ <li>Providing a bug rank (1-20), and the ability to filter by
+ bug rank. Eventually, it will be possible to specify your own
+ rules for ranking bugs, but the procedure for doing so hasn't been
+ specified yet.</li>
+ <li>Fixed about <a
+ href="https://sourceforge.net/search/index.php?group_id=96405&search_summary=1&search_details=1&type_of_search=artifact&group_artifact_id%5B%5D=614693&open_date_start=2009-03-16&open_date_end=2009-08-20&form_submit=Search">45
+ bugs filed</a> through SourceForge
+ </li>
+ <li>Various reclassifications and priority tweaks</li>
+ <li>Added more bug annotations to a variety of bug reports.
+ This provides more context for understanding bug reports (e.g., if
+ the value in question was is the return value of a method, the
+ method is described as the source of the value in a bug
+ annotation). This also provide more accurate tracking of issues
+ across versions of the code being analyzed, but has the downside
+ that when comparing results from FindBugs 1.3.8 and FindBugs 1.3.9
+ on the same version of code being analyzed, FindBugs may think
+ that mistakenly believe that the issue reported by 1.3.8 was fixed
+ and a new issue was introduced that was reported by FindBugs
+ 1.3.9. While annoying, it would be unusual for more than a dozen
+ issues per million lines of codes to be mistracked.</li>
+ <li>Lots of internal changes moving towards FindBugs 2.0, but
+ these features are undocumented, not yet officially supported, and
+ subject to radical changes before FindBugs 2.0 is released.</li>
+ </ul>
+
+ <p>Changes since version 1.3.7</p>
+ <ul>
+ <li>Primarily another small bugfix release.</li>
+ <li>FindBugs base:
+ <ul>
+ <li>New Reports:
+ <ul>
+ <li>SF_SWITCH_NO_DEFAULT: missing default case in switch
+ statement.</li>
+ <li>SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH_TO_THROW:
+ value ignored when switch fallthrough leads to thrown
+ exception.</li>
+ <li>INT_VACUOUS_BIT_OPERATION: bit operations that don't
+ do any meaningful work.</li>
+ <li>FB_UNEXPECTED_WARNING: warning generated that
+ conflicts with @NoWarning FindBugs annotation.</li>
+ <li>FB_MISSING_EXPECTED_WARNING: warning not generated
+ despite presence of @ExpectedWarning FindBugs annotation.</li>
+ <li>NOISE category: intended for use in data mining
+ experiments.
+ <ul>
+ <li>NOISE_NULL_DEREFERENCE: fake null point dereference
+ warning.</li>
+ <li>NOISE_METHOD_CALL: fake method call warning.</li>
+ <li>NOISE_FIELD_REFERENCE: fake field dereference
+ warning.</li>
+ <li>NOISE_OPERATION: fake operation warning.</li>
+ </ul>
+ </li>
+ </ul>
+ </li>
+ <li>Other:
+ <ul>
+ <li>Garvin Leclaire has created a new Apache Maven
+ repository for FindBugs at <a
+ href="http://code.google.com/p/findbugs/">the Google Code
+ FindBugs SVN repository</a>. (Thanks Garvin!)
+ </li>
+ </ul>
+ </li>
+ <li>Fixes:
+ <ul>
+ <li>[ 2317842 ] Highlighting broken in Windows</li>
+ <li>[ 2515908 ] check for oddness should track sign of
+ argument</li>
+ <li>[ 2487936 ] "L B GC" false pos cast from
+ Map.Entry.getKey() to Map.get()</li>
+ <li>[ 2528264 ] Ant tasks not compatible with Ant 1.7.1</li>
+ <li>[ 2539590 ] SF_SWITCH_FALLTHROUGH wrong message
+ reported</li>
+ <li>[ 2020066 ] Bug history displayed in fancy-hist.xsl is
+ incorrect</li>
+ <li>[ 2545098 ] Invalid character in analysis results file</li>
+ <li>[ 2492673 ] Plugin sites should specify "requires
+ Eclipse 3.3 or newer"</li>
+ <li>[ 2588044 ] a tiny typing error</li>
+ <li>[ 2589048 ] Documentation for convertXmlToText
+ insufficient</li>
+ <li>[ 2638739 ] NullPointerException when building</li>
+ </ul>
+ </li>
+ <li>Patches:
+ <ul>
+ <li>[ 2538184 ] Make BugCollection implement
+ Iterable<BugInstance> (thanks to Tomas Pollak)</li>
+ <li>[ 2249771 ] Add Maven2 Findbugs plugin link to the
+ Links page (thanks to Garvin Leclaire)</li>
+ <li>[ 2609526 ] Japanese manual update (thanks to K.
+ Hashimoto)</li>
+ <li>[ 2119482 ] CheckBcel checks for nonexistent classes
+ (thanks to Jerry James)</li>
+ </ul>
+ </li>
+ </ul>
+ </li>
+ <li>FindBugs Eclipse plugin:
+ <ul>
+ <li>Major feature enhancements (thanks to Andrey Loskutov).
+ See <a href="http://andrei.gmxhome.de/findbugs/index.html">this
+ overview</a> for more information.
+ </li>
+ <li>Major test improvements (thanks to Tomas Pollak).</li>
+ <li>Fixes:
+ <ul>
+ <li>[ 2532365 ] Compiler warning</li>
+ <li>[ 2522989 ] Fix filter files selection</li>
+ <li>[ 2504068 ] NullPointerException</li>
+ <li>[ 2640849 ] NPE in Eclipse plugin 1.3.7 and Eclipse
+ 3.5 M5</li>
+ </ul>
+ </li>
+ <li>Patches:
+ <ul>
+ <li>[ 2143140 ] Unchecked conversion fixes for Eclipse
+ plugin (thanks to Jerry James)
+ </ul>
+ </li>
+ </ul>
+ </li>
+ </ul>
+
+ <p>Changes since version 1.3.6</p>
+ <ul>
+ <li>Overall, a small bugfix release.
+ <li>New detection of accidental vacuous/useless calls to
+ EasyMock methods, and of generic signatures that proclaim the use
+ of unhashable classes in ways that require that they be hashed.
+ <li>Eliminate some false positives where we were warning about
+ a useless call (e.g., comparing two incompatible types for
+ equality), but the only thing the code was doing with the result
+ was passing it to assertFalse.
+ <li>Japanese localization and manual by K.Hashimoto. (Thanks!)
+
+ <li>Added -exclude and -outputDir command line options to
+ rejarForAnalysis
+ <li>Extended -adjustPriorities option to FindBugs analysis
+ textui so that you can modify the priorities of individual bug
+ patterns as well as visitors, and also completely suppress
+ individual bug patterns or visitors.
+ <ul>
+ <li>e.g., -adjustPriority
+ MS_SHOULD_BE_FINAL=suppress,MS_PKGPROTECT=suppress,EI_EXPOSE_REP=suppress,EI_EXPOSE_REP2=suppress,PZLA_PREFER_ZERO_LENGTH_ARRAYS=raise
+
+ </ul>
+ </ul>
+
+
+ <p>Changes since version 1.3.5</p>
+ <ul>
+ <li>Added fairly exhaustive static analysis of uses of format
+ strings, checking for missing or extra arguements, invalid format
+ specifiers, or mismatched format specifiers and arguments (e.g,
+ passing a String value for a %d format specifier). The logic for
+ doing so is derived from Sun's java.util.Formatter class, and
+ available separately from FindBugs as part of the <a
+ href="https://jformatstring.dev.java.net/">jFormatString</a>
+ project.
+ <li>More tuning of the unsatisfied obligation detector. Since
+ this detector is still rather noisy and an unfinished research
+ project, I've moved the generated issues to a new category:
+ EXPERIMENTAL.
+ <li>Added check for <a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#BIT_ADD_OF_SIGNED_BYTE">BIT_ADD_OF_SIGNED_BYTE</a>;
+ similar to <a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#BIT_IOR_OF_SIGNED_BYTE">BIT_IOR_OF_SIGNED_BYTE</a>,
+ except that addition is being used to combine shifted signed
+ bytes.
+ <li>Changed detection of EI_EXPOSE_REP2, so we only report it
+ if the value stored is guaranteed to be the same value that was
+ passed in as a parameter.
+ <li>Added <a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS">EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS</a>,
+ a warning when an equals method checks to see if an operand is an
+ instance of a class not compatible with itself. For example, if
+ the Foo class checks to see if the argument is an instance of
+ String. This is either a questionable design decision or a coding
+ mistake.
+ <li>Added <a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#DMI_INVOKING_HASHCODE_ON_ARRAY">DMI_INVOKING_HASHCODE_ON_ARRAY</a>,
+ which checks for invoking <code>hashCode()</code> on an array,
+ which returns a hash code that ignores the contents of the array.
+
+ <li>Added checks for using <code>x.removeAll(x)</code> to
+ rather than <code>x.clear()</code> to clear an array.
+ <li>Add checks for calls such as <code>x.contains(x)</code>, <code>x.remove(x)</code>
+ and <code>x.containsAll(x)</code>.
+ <li>Improvements to Eclipse plugin (thanks to Andrey
+ Loskutov):
+ <ul>
+ <li>Report separate markers for each occurrence of an issue
+ that appears multiple times in a method
+ <li>fine tuning for reported markers: add only one marker
+ for fields, add marker on right position
+ <li>link bugs selected in bug explorer view to the opened
+ editor and vice versa
+ <li>select bugs selected in editor ruler in the opened bug
+ explorer view
+ <li>consistent abbreviations used in both bug explorer and
+ bug details view
+ <li>added "Expand All" button to the bug explorer view
+ <li>added "Go Into/Go Up" buttons to the bug explorer view
+ <li>added "Copy to clipboard" menu/functionality to the
+ details view list widget
+ <li>fix for CNF exception if loading the backup solution for
+ broken browser widget
+ </ul>
+ </ul>
+
+
+
+ <p>Changes since version 1.3.4</p>
+ <ul>
+ <li>Analysis about 15% faster
+ <li><a
+ href="http://sourceforge.net/tracker/?atid=614693&group_id=96405&func=browse&status=closed">38
+ bugs closed</a></li>
+ <li>New defect warnings:
+ <ul>
+ <li>calls to methods that always throw
+ UnsupportedOperationException (DMI_UNSUPPORTED_METHOD)
+ <li>repeated conditional tests (e.g., <code>if (x
+ < 0 || x < 0) ...</code>) (RpC_REPEATED_CONDITIONAL_TEST)
+ <li>Complete rewrite of detector for format string problems.
+ More accurate, finds more problems, generates more descriptive
+ reports, several different bug pattern
+ (VA_FORMAT_STRING_EXTRA_ARGUMENTS_PASSED,
+ VA_FORMAT_STRING_ILLEGAL, VA_FORMAT_STRING_MISSING_ARGUMENT,
+ VA_FORMAT_STRING_BAD_ARGUMENT,
+ VA_FORMAT_STRING_NO_PREVIOUS_ARGUMENT)
+ <li>Fairly complete implementation of JSR-305 custom type
+ qualifier analysis (no support for custom validators yet).
+ (TQ_MAYBE_SOURCE_VALUE_REACHES_NEVER_SINK
+ TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK
+ TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK)
+ <li>New detector for unsatisfied obligations such forgetting
+ to close a file (OBL_UNSATISFIED_OBLIGATION).
+ <li>Warning when a parameter is marked as nullable, but is
+ always dereferenced.
+ (NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE)
+ <lI>Separate warning for dereference the result of readLine
+ (NP_DEREFERENCE_OF_READLINE_VALUE)
+ </ul>
+ <li>When XML is generated with messages, the project stats now
+ include <FileStat> elements. For each source file, this
+ gives the path for the file, the total number of warnings for that
+ file, and a bugHash for the file. While the instanceHash for a bug
+ is intended to be version invariant (ignoring line numbers, etc),
+ the bugHash for a file is intended to reflect all the information
+ about the warnings in that file. The intended use case is that if
+ the bugHash for a file is the same in two analysis runs, then <em>nothing</em>
+ has changed about any of the warnings reported for that file
+ between the two analysis runs.
+ <li>More merging of similar issues within a method. For
+ example, if the result of readLine() is dereferences multiple
+ times within a method, it will be reported as a single warning
+ with occurrences at multiple source lines.
+ </ul>
+ <p>Changes since version 1.3.3</p>
+
+ <ul>
+ <li>FindBugs base
+ <ul>
+ <li>New Reports:
+ <ul>
+ <li>EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC: equals method
+ overrides equals in superclass and may not be symmetric</li>
+ <li>EQ_ALWAYS_TRUE: equals method always returns true</li>
+ <li>EQ_ALWAYS_FALSE: equals method always returns false</li>
+ <li>EQ_COMPARING_CLASS_NAMES: equals method compares class
+ names rather than class objects</li>
+ <li>EQ_UNUSUAL: Unusual equals method</li>
+ <li>EQ_GETCLASS_AND_CLASS_CONSTANT: equals method fails
+ for subtypes</li>
+ <li>SE_READ_RESOLVE_IS_STATIC: The readResolve method must
+ not be declared as a static method.</li>
+ <li>SE_PRIVATE_READ_RESOLVE_NOT_INHERITED: private
+ readResolve method not inherited by subclasses</li>
+ <li>MSF_MUTABLE_SERVLET_FIELD: Mutable servlet field</li>
+ <li>XSS_REQUEST_PARAMETER_TO_SEND_ERROR: Servlet reflected
+ cross site scripting vulnerability</li>
+ <li>SKIPPED_CLASS_TOO_BIG: Class too big for analysis</li>
+ </ul>
+ </li>
+ <li>Other:
+ <ul>
+ <li>Value-number analysis now more space-efficient</li>
+ <li>Enhancements to reduce memory overhead when analyzing
+ very large classes</li>
+ <li>Now skips very large classes that would otherwise take
+ too much time and memory to analyze</li>
+ <li>Infrastructure for tracking effectively-constant/
+ effectively-final fields</li>
+ <li>Added more cweids</li>
+ <li>Enhanced taint tracking for taint-based detectors</li>
+ <li>Ignore doomed calls to equals if result is used as an
+ argument to assertFalse</li>
+ <li>EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC handles compareTo</li>
+ <li>Priority tweak for ICAST_INTEGER_MULTIPLY_CAST_TO_LONG
+ (only low priority if multiplying by 1000)</li>
+ <li>Improved tracking of fields across method calls</li>
+ </ul>
+ </li>
+ <li>Fixes:
+ <ul>
+ <li>[ 1941450 ] DLS_DEAD_LOCAL_STORE not reported</li>
+ <li>[ 1953323 ] Omitted break statement in
+ SynchronizeAndNullCheckField</li>
+ <li>[ 1942620 ] Source Directories selection dialog
+ interface confusion (partial)</li>
+ <li>[ 1948275 ] Unhelpful "Load of known null"</li>
+ <li>[ 1933922 ] MWM error in findbugs</li>
+ <li>[ 1934772 ] 1.3.3 appears to rely on JDK 1.6, JNLP
+ still specifies 1.5</li>
+ <li>[ 1933945 ] -loadbugs doesn't work</li>
+ <li>Fixed problems for class names starting with '$'</li>
+ <li>Fixed bugs and incomplete handling of annotations in
+ VersionInsensitiveBugComparator</li>
+ </ul>
+ </li>
+ <li>Patches:
+ <ul>
+ <li>[ 1955106 ] Javadoc fixes</li>
+ <li>[ 1951930 ] Superfluous import statements (thanks to
+ Jerry James)</li>
+ <li>[ 1951907 ] Missing @Deprecated annotations (thanks to
+ Jerry James)</li>
+ <li>[ 1951876 ] Infonode Docking Windows compile fix
+ (thanks to Jerry James)</li>
+ <li>[ 1936055 ] bugfix for findbugs.de.comment not working
+ (thanks to Peter Fokkinga)
+ </ul>
+ </li>
+ </ul>
+ <li>FindBugs BlueJ plugin
+ <ul>
+ <li>Updated to use FindBugs 1.3.4 (first new release since
+ 1.1.3)</li>
+ </ul>
+ </li>
+ </ul>
+
+ <p>Changes since version 1.3.2</p>
+
+ <ul>
+ <li>FindBugs base
+ <ul>
+ <li>New Detectors:
+ <ul>
+ <li>FieldItemSummary: Produces summary information for
+ what is stored into fields</li>
+ <li>SynchronizeOnClassLiteralNotGetClass: Look for code
+ that synchronizes on the results of getClass rather than on
+ class literals</li>
+ <li>SynchronizingOnContentsOfFieldToProtectField: This
+ detector looks for code that seems to be synchronizing on a
+ field in order to guard updates of that field</li>
+ </ul>
+ </li>
+ <li>New BugCode:
+ <ul>
+ <li>HRS: HTTP Response splitting vulnerability</li>
+ <li>WL: Possible locking on wrong object</li>
+ </ul>
+ </li>
+ <li>New Reports:
+ <ul>
+ <li>DMI_CONSTANT_DB_PASSWORD: This code creates a database
+ connect using a hard coded, constant password</li>
+ <li>HRS_REQUEST_PARAMETER_TO_COOKIE: HTTP cookie formed
+ from untrusted input</li>
+ <li>HRS_REQUEST_PARAMETER_TO_HTTP_HEADER: HTTP parameter
+ directly written to HTTP header output</li>
+ <li>CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE: Class defines
+ clone() but doesn't implement Cloneable</li>
+ <li>DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE: Synchronization
+ on boxed primitive could lead to deadlock</li>
+ <li>DL_SYNCHRONIZATION_ON_BOOLEAN: Synchronization on
+ Boolean could lead to deadlock</li>
+ <li>ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD:
+ Synchronization on field in futile attempt to guard that field
+ </li>
+ <li>DLS_DEAD_LOCAL_STORE_IN_RETURN: Useless assignment in
+ return statement</li>
+ <li>WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL:
+ Synchronization on getClass rather than class literal</li>
+ </ul>
+ </li>
+ <li>Other:
+ <ul>
+ <li>Many enhancements to cross-site scripting detector and
+ its documentation</li>
+ <li>Enhanced switch fall through handling</li>
+ <li>Enhanced unread field handling (look for IF_ACMPEQ and
+ IF_ACMPNE)</li>
+ <li>Clarified documentation for @Nullable in manual</li>
+ <li>Fewer DeadLocalStore false positives</li>
+ <li>Fewer UnreadField false positives</li>
+ <li>Fewer StaticCalendarDetector false positives</li>
+ <li>Performance fix for slow file system IO e.g. Clearcase
+ repositories (thanks, Andrei!)</li>
+ <li>Other, general performance enhancements (thanks,
+ Andrei!)</li>
+ <li>Enhancements for using FindBugs scripts with MKS on
+ Windows (thanks, Kelly O'Hair!)</li>
+ <li>Noted in the manual that jsr305.jar must be present
+ for annotations to compile</li>
+ <li>Added and fine-tuned default-nullness annotations</li>
+ <li>More CWE IDs added</li>
+ <li>Check and warning for unexpected BCEL version in
+ classpath</li>
+ </ul>
+ </li>
+ <li>Fixes:
+ <ul>
+ <li>Bug fix to handling of local variable tables in BCEL</li>
+ <li>Refined documentation for
+ MTIA_SUSPECT_STRUTS_INSTANCE_FIELD</li>
+ <li>[ 1927295 ] NPE when called on project root</li>
+ <li>[ 1926405 ] Incorrect dead store warning</li>
+ <li>[ 1926409 ] Incorrect redundant nullcheck warning</li>
+ <li>[ 1926389 ] Wrong line number printed/highlighted in
+ bug</li>
+ <li>[ 1927040 ] typo in bug description</li>
+ <li>[ 1926263 ] Minor glitch in HTML output</li>
+ <li>[ 1926240 ] Minor error in standard options in manual</li>
+ <li>[ 1926236 ] Minor bug in installation section of
+ manual</li>
+ <li>[ 1925539 ] ZIP is default file system code base</li>
+ <li>[ 1894701 ] Livelock / memory leak in
+ ObjectTypeFactory (thanks, Andrei!)</li>
+ <li>[ 1867491 ] Doesn't reload annotations after code
+ changes in IDE (thanks, Andrei!)</li>
+ <li>[ 1921399 ] -project option not supported</li>
+ <li>[ 1913834 ] "Dead" store to variable with method call</li>
+ <li>[ 1917352 ] H B se:...field in serializable class</li>
+ <li>[ 1911617 ] CloneIdiom relies on
+ getNameConstantOperand for INSTANCEOF</li>
+ <li>[ 1911620 ] False +: DLS predecrement before return</li>
+ <li>[ 1871376 ] False negative: non-serializable Map field</li>
+ <li>[ 1871051 ] non standard clone() method</li>
+ <li>[ 1908854 ] Error in TestASM</li>
+ <li>[ 1907539 ] 22 minor errors in bug checker
+ documentation</li>
+ <li>[ 1897323 ] EJB implementation class false positives</li>
+ <li>[ 1899648 ] Crash on startup on Vista with Java
+ 1.6.0_04</li>
+ </ul>
+ </li>
+ </ul>
+ </li>
+ <li>FindBugs Eclipse plugin (change log by Andrey Loskutov)
+ <ul>
+ <li>new feature: export basic FindBugs numbers for projects
+ via File->Export->Java->BugCounts (Andrey Loskutov)</li>
+ <li>new feature: jobs for different projects will be run in
+ parallel per default if running on a multi-core PC
+ ("fb.allowParallelBuild" system property not used anymore)
+ (Andrey Loskutov)</li>
+ <li>fixed performance slowdown in the multi-threaded build,
+ caused by workspace operation locks during assigning marker
+ attributes (Andrey Loskutov)</li>
+ </ul>
+ </li>
+ </ul>
+
+ <p>Changes since version 1.3.1</p>
+
+ <ul>
+ <li>FindBugs base
+ <ul>
+ <li>New Bug Category:
+ <ul>
+ <li>SECURITY (Abbrev: S), A use of untrusted input in a
+ way that could create a remotely exploitable security
+ vulnerability</li>
+ </ul>
+ </li>
+ <li>New Detectors:
+ <ul>
+ <li>CrossSiteScripting: This detector looks for
+ obvious/blatant cases of cross site scripting vulnerabilities</li>
+ </ul>
+ </li>
+ <li>New BugCode:
+ <ul>
+ <li>XSS: Cross site scripting</li>
+ </ul>
+ </li>
+ <li>New Reports:
+ <ul>
+ <li>XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER: HTTP
+ parameter directly written to Servlet output, giving XSS
+ vulnerability</li>
+ <li>XSS_REQUEST_PARAMETER_TO_JSP_WRITER: HTTP parameter
+ directly written to JSP output, giving XSS vulnerability</li>
+ <li>EQ_OTHER_USE_OBJECT: equals() method defined that
+ doesn't override Object.equals(Object)</li>
+ <li>EQ_OTHER_NO_OBJECT: equals() method inherits rather
+ than overrides equals(Object)</li>
+ <li>NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE: Possible
+ null pointer dereference on path that might be infeasible</li>
+ </ul>
+ </li>
+ <li>Other:
+ <ul>
+ <li>Added -noClassOk command-line parameter to
+ command-line and ant interfaces; when -noClassOk is specified
+ and no classfiles are given, FindBugs will print a warning
+ message and output a well- formed file with no warnings</li>
+ <li>Fewer false positives for null pointer bugs</li>
+ <li>Suppress dead-local-store false positives in .jsp code</li>
+ <li>Type fixes in warning messages</li>
+ <li>Better warning message for NP_NULL_ON_SOME_PATH</li>
+ <li>"WMI" bug code description renamed from "Wrong Map
+ Iterator" to "Inefficient Map Iterator"</li>
+ </ul>
+ </li>
+ <li>Fixes:
+ <ul>
+ <li>[ 1893048 ] FindBugs confused by a findbugs.xml file</li>
+ <li>[ 1878528 ] XSL xforms don't support history features</li>
+ <li>[ 1876584 ] two default.xsl flaws</li>
+ <li>[ 1874856 ] Format string bug detector doesn't handle
+ special operators</li>
+ <li>[ 1872645 ] computeBugHistory -
+ java.lang.IllegalArgumentException</li>
+ <li>[ 1872237 ] Ant task fails when no .class files</li>
+ <li>[ 1868670 ] Filters: include AND exclude don't allowed</li>
+ <li>[ 1868666 ] check-for-oddness reported, but array
+ length can never be negative</li>
+ <li>[ 1866108 ] SetBugDatabaseInfoTask strips dir from
+ output filename</li>
+ <li>[ 1866021 ] MineBugHistoryTask strips dir of output
+ filename</li>
+ <li>[ 1865265 ] code doesn't handle
+ StringBuffer.append([CII) right</li>
+ <li>[ 1864793 ] Warning when casting a null reference
+ compared to a String</li>
+ <li>[ 1863376 ] Typo in manual chap 8: Filter Files</li>
+ <li>[ 1862705 ] Transient fields that default to null</li>
+ <li>[ 1842545 ] DLS on catch variable (with priority
+ tweaking)</li>
+ <li>[ 1816258 ] false positive BC_IMPOSSIBLE_CAST</li>
+ <li>[ 1551732 ] Get erroneous DLS with while loop</li>
+ </ul>
+ </li>
+ </ul>
+ </li>
+ <li>FindBugs Eclipse plugin (change log by Andrey Loskutov)
+ <ul>
+ <li>new feature: added Bug explorer view (replacing Bug tree
+ view), based on Common Navigator framework (Andrey Loskutov)</li>
+ <li>bug 1873860 fixed: empty projects are no longer shown in
+ Bug tree view (Andrey Loskutov)</li>
+ <li>new feature: bug counts decorators for projects, folders
+ and files (has to be activated via Preferences -> general
+ -> appearance -> label decorations)(Andrey Loskutov)</li>
+ <li>patch 1746499: better icons (Alessandro Nistico)</li>
+ <li>patch 1893685: Find bug actions on change sets bug
+ (Alessandro Nistico)</li>
+ <li>fixed bug 1855384: Bug configuration is broken in
+ Eclipse (Andrey Loskutov)</li>
+ <li>refactored FindBugs properties page (Andrey Loskutov)</li>
+ <li>refactored FindBugs worker/builder/run action (Andrey
+ Loskutov)</li>
+ <li>FB detects now only bugs from classes on project's
+ classpath (no double work on duplicated class files) (Andrey
+ Loskutov)</li>
+ <li>fixed bug introduced by the bad patch for 1867951: FB
+ cannot be executed incrementally on a folder of file (Andrey
+ Loskutov)</li>
+ <li>fixed job rule: now jobs for different projects may run
+ in parallel if running on a multi-core PC and
+ "fb.allowParallelBuild" system property is set to true (Andrey
+ Loskutov)</li>
+ <li>fixed FB auto-build not started if .fbprefs or
+ .classpath was changed (Andrey Loskutov)</li>
+ <li>fixed not reporting bugs on secondary types (classes
+ defined in java files with different name) (Andrey Loskutov)</li>
+ </ul>
+ </li>
+ </ul>
+
+ <p>Changes since version 1.3.0</p>
+ <ul>
+ <li>New Reports
+ <ul>
+ <li>VA_FORMAT_STRING_ARG_MISMATCH: A format-string method
+ with a variable number of arguments is called, but the number of
+ arguments passed does not match with the number of %
+ placeholders in the format string. This is probably not what the
+ author intended.
+ <li>IO_APPENDING_TO_OBJECT_OUTPUT_STREAM: This code opens a
+ file in append mode and that wraps the result in an object
+ output stream. This won't allow you to append to an existing
+ object output stream stored in a file. If you want to be able to
+ append to an object output stream, you need to keep the object
+ output stream open. The only situation in which opening a file
+ in append mode and the writing an object output stream could
+ work is if on reading the file you plan to open it in random
+ access mode and seek to the byte offset where the append
+ started.
+ <li>NP_BOOLEAN_RETURN_NULL: A method that returns either
+ Boolean.TRUE, Boolean.FALSE or null is an accident waiting to
+ happen. This method can be invoked as though it returned a value
+ of type boolean, and the compiler will insert automatic unboxing
+ of the Boolean value. If a null value is returned, this will
+ result in a NullPointerException.
+ </ul>
+ </li>
+ <li>Changes to Existing Reports
+ <ul>
+ <li>RV_DONT_JUST_NULL_CHECK_READLINE: CORRECTNESS ->
+ STYLE</li>
+ <li>DMI_INVOKING_TOSTRING_ON_ARRAY: Long description
+ mentions array name whenever possible</li>
+ </ul>
+ </li>
+ <li>Fixes:
+ <ul>
+ <li>Updated manual to mention that Java 1.5 is now a
+ requirement for running FindBugs
+ <li>Applied patch 1840206 fixing issue "Ant task does not
+ work when presetdef is used" - thanks to phejl
+ <li>Applied patch 1778690 fixing issue "Ant task: tolerate
+ but complain about invalid auxClasspath" - thanks to David
+ Schmidt
+ <li>Applied patch 1852125 adding a Chinese-language GUI
+ bundle props file - thanks to fifi
+ <li>Applied patch 1845903 adding ability to load XML results
+ with the Eclipse plugin - thanks to Alex Mont
+ <li>Fixed issue 1844671 - "FP for "reversed" null check in
+ catch for stream close"
+ <li>Fixed issue 1836050 - "-onlyAnalyze broken"
+ <li>Fixed issue 1853011 - "Typo: Field names should start
+ with aN lower case letter"
+ <li>Fixed issue 1844181 - "JNLP file does not contain all
+ necessary JARs"
+ <li>Fixed issue 1840245 - "xxxException class does not
+ derive from Exception"
+ <li>Fixed issue 1840277 - "[M D EC] Typo in bug
+ documentation"
+ <li>Fixed issue 1782447 - "OutOfMemoryError if i activate
+ Findbugs on my project"
+ <li>Fixed issue 1830576 - "[regression] keySet/entrySet
+ false positive"
+ </ul>
+ </li>
+ <li>Other:
+ <ul>
+ <li>New bug code: "IO" (for
+ IO_APPENDING_TO_OBJECT_OUTPUT_STREAM)</li>
+ <li>Added "-onlyMostRecent" option for computeBugHistory
+ script/ant task
+ <li>More explicit language in
+ RV_RETURN_VALUE_IGNORED_BAD_PRACTICE messages
+ <li>Modified ResourceValueAnalysis to correctly identify
+ null == X or null != X as a null check (for issue 1844671)
+ <li>Modified DMI_HARDCODED_ABSOLUTE_FILENAME logic in
+ DumbMethodInvocations to ignore files from /etc or /dev and
+ increase priority of files from /home
+ <li>Better bug details for infinite loop warnings
+ <li>Modified unread-fields detector to reduce false
+ positives from reflective fields
+ <li>build.xml "classes" target now builds all sources in one
+ step
+ </ul>
+ </li>
+ </ul>
+
+ <p>Changes since version 1.2.1</p>
+ <ul>
+ <li>New Detectors and Reports
+ <ul>
+ <li>SynchronizationOnSharedBuiltinConstant
+ <ul>
+ <li>DL_SYNCHRONIZATION_ON_SHARED_CONSTANT: The code
+ synchronizes on a shared primitive constant, such as an
+ interned String. Such constants are interned and shared across
+ all other classes loaded by the JVM. Thus, this could be
+ locking on something that other code might also be locking.
+ This could result in very strange and hard to diagnose
+ blocking and deadlock behavior. See <a
+ href="http://www.javalobby.org/java/forums/t96352.html">http://www.javalobby.org/java/forums/t96352.html</a>
+ and <a href="http://jira.codehaus.org/browse/JETTY-352">http://jira.codehaus.org/browse/JETTY-352</a>.
+
+ </ul>
+ </li>
+ <li>OverridingEqualsNotSymmetrical
+ <ul>
+ <li>EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC: Looks for equals
+ methods that override equals methods in a superclass where the
+ equivalence relationship might not be symmetrical.
+ </ul>
+ </li>
+ <li>CheckTypeQualifiers
+ <ul>
+ <li>TQ_ALWAYS_VALUE_USED_WHERE_NEVER_REQUIRED: A value
+ specified as carrying a type qualifier annotation is consumed
+ in a location or locations requiring that the value not carry
+ that annotation. More precisely, a value annotated with a type
+ qualifier specifying when=ALWAYS is guaranteed to reach a use
+ or uses where the same type qualifier specifies when=NEVER.</li>
+ <li>TQ_NEVER_VALUE_USED_WHERE_ALWAYS_REQUIRED: A value
+ specified as not carrying a type qualifier annotation is
+ guaranteed to be consumed in a location or locations requiring
+ that the value does carry that annotation. More precisely, a
+ value annotated with a type qualifier specifying when=NEVER is
+ guaranteed to reach a use or uses where the same type
+ qualifier specifies when=ALWAYS.</li>
+ <li>TQ_MAYBE_SOURCE_VALUE_REACHES_ALWAYS_SINK: A value
+ that might not carry a type qualifier annotation reaches a use
+ which requires that annotation.</li>
+ <li>TQ_MAYBE_SOURCE_VALUE_REACHES_NEVER_SINK: A value
+ which might carry a type qualifier annotation reaches a use
+ which forbids values carrying that annotation.</li>
+ </ul>
+ </li>
+ </ul>
+ </li>
+ <li>New Reports (existing detectors)
+ <ul>
+ <li>FindHEmismatch
+ <ul>
+ <li>EQ_DOESNT_OVERRIDE_EQUALS: This class extends a class
+ that defines an equals method and adds fields, but doesn't
+ define an equals method itself. Thus, equality on instances of
+ this class will ignore the identity of the subclass and the
+ added fields. Be sure this is what is intended, and that you
+ don't need to override the equals method. Even if you don't
+ need to override the equals method, consider overriding it
+ anyway to document the fact that the equals method for the
+ subclass just return the result of invoking super.equals(o).</li>
+ </ul>
+ </li>
+ <li>Naming
+ <ul>
+ <li>NM_WRONG_PACKAGE, NM_WRONG_PACKAGE_INTENTIONAL: The
+ method in the subclass doesn't override a similar method in a
+ superclass because the type of a parameter doesn't exactly
+ match the type of the corresponding parameter in the
+ superclass.</li>
+ <li>NM_SAME_SIMPLE_NAME_AS_SUPERCLASS: This class has a
+ simple name that is identical to that of its superclass,
+ except that its superclass is in a different package (e.g., <code>alpha.Foo</code>
+ extends <code>beta.Foo</code>). This can be exceptionally
+ confusing, create lots of situations in which you have to look
+ at import statements to resolve references and creates many
+ opportunities to accidently define methods that do not
+ override methods in their superclasses.
+ </li>
+ <li>NM_SAME_SIMPLE_NAME_AS_INTERFACE: This class/interface
+ has a simple name that is identical to that of an
+ implemented/extended interface, except that the interface is
+ in a different package (e.g., <code>alpha.Foo</code> extends <code>beta.Foo</code>).
+ This can be exceptionally confusing, create lots of situations
+ in which you have to look at import statements to resolve
+ references and creates many opportunities to accidently define
+ methods that do not override methods in their superclasses.
+ </li>
+ </ul>
+ <li>FindRefComparison
+ <ul>
+ <li>EC_UNRELATED_TYPES_USING_POINTER_EQUALITY: This method
+ uses using pointer equality to compare two references that
+ seem to be of different types. The result of this comparison
+ will always be false at runtime.</li>
+ </ul>
+ </li>
+ <li>IncompatMask
+ <ul>
+ <li>BIT_SIGNED_CHECK, BIT_SIGNED_CHECK_HIGH_BIT: This
+ method compares an expression such as <tt>((event.detail
+ & SWT.SELECTED) > 0)</tt>. Using bit arithmetic and then
+ comparing with the greater than operator can lead to
+ unexpected results (of course depending on the value of
+ SWT.SELECTED). If SWT.SELECTED is a negative number, this is a
+ candidate for a bug. Even when SWT.SELECTED is not negative,
+ it seems good practice to use '!= 0' instead of '> 0'.
+ </li>
+ </ul>
+ </li>
+ <li>LazyInit
+ <ul>
+ <li>LI_LAZY_INIT_UPDATE_STATIC: This method contains an
+ unsynchronized lazy initialization of a static field. After
+ the field is set, the object stored into that location is
+ further accessed. The setting of the field is visible to other
+ threads as soon as it is set. If the further accesses in the
+ method that set the field serve to initialize the object, then
+ you have a <em>very serious</em> multithreading bug, unless
+ something else prevents any other thread from accessing the
+ stored object until it is fully initialized.
+ </li>
+ </ul>
+ </li>
+ <li>FindDeadLocalStores
+ <ul>
+ <li>DLS_DEAD_STORE_OF_CLASS_LITERAL: This instruction
+ assigns a class literal to a variable and then never uses it.
+ <a href="//java.sun.com/j2se/1.5.0/compatibility.html#literal">The
+ behavior of this differs in Java 1.4 and in Java 5.</a> In Java
+ 1.4 and earlier, a reference to <code>Foo.class</code> would
+ force the static initializer for <code>Foo</code> to be
+ executed, if it has not been executed already. In Java 5 and
+ later, it does not. See Sun's <a
+ href="//java.sun.com/j2se/1.5.0/compatibility.html#literal">article
+ on Java SE compatibility</a> for more details and examples, and
+ suggestions on how to force class initialization in Java 5.
+ </li>
+ </ul>
+ </li>
+ <li>MethodReturnCheck
+ <ul>
+ <li>RV_RETURN_VALUE_IGNORED_BAD_PRACTICE: This method
+ returns a value that is not checked. The return value should
+ be checked since it can indication an unusual or unexpected
+ function execution. For example, the <code>File.delete()</code>
+ method returns false if the file could not be successfully
+ deleted (rather than throwing an Exception). If you don't
+ check the result, you won't notice if the method invocation
+ signals unexpected behavior by returning an atypical return
+ value.
+ </li>
+ <li>RV_EXCEPTION_NOT_THROWN: This code creates an
+ exception (or error) object, but doesn't do anything with it.
+ </li>
+ </ul>
+ </li>
+ </ul>
+ </li>
+ <li>Changes to Existing Reports
+ <ul>
+ <li>NS_NON_SHORT_CIRCUIT: BAD_PRACTICE -> STYLE</li>
+ <li>NS_DANGEROUS_NON_SHORT_CIRCUIT: CORRECTNESS -> STYLE</li>
+ <li>RC_REF_COMPARISON: CORRECTNESS -> BAD_PRACTICE</li>
+ </ul>
+ </li>
+ <li>GUI Changes
+ <ul>
+ <li>Added importing and exporting of bug filters</li>
+ <li>Better handling of failed analysis runs</li>
+ <li>Added "-look" parameter for selecting look-and-feel</li>
+ <li>Fixed incorrect package filtering</li>
+ <li>Fixed issue where "synchronized" was not
+ syntax-highlighted</li>
+ </ul>
+ </li>
+ <li>Ant-task Changes
+ <ul>
+ <li>Refactored common ant-task code to AbstractFindBugsTask</li>
+ <li>Added tasks for computeBugHistory, convertXmlToText,
+ filterBugs, mineBugHistory, setBugDatabaseInfo</li>
+ </ul>
+ </li>
+ <li>Manual
+ <ul>
+ <li>Updates to GUI section, including new screenshots</li>
+ <li>Added description of rejarForAnalysis</li>
+ <li>Revamp of data-mining section</li>
+ </ul>
+ </li>
+ <li>Other Major
+ <ul>
+ <li>Internal restructuring for lower memory overhead</li>
+ </ul>
+ </li>
+ <li>Other Minor
+ <ul>
+ <li>Fixed typo: was STCAL_STATIC_SIMPLE_DATA_FORMAT_INSTANCE
+ now STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE</li>
+ <li>-outputFile parameter became -output</li>
+ <li>More sensitivity and specificity inLazyInit detector</li>
+ <li>More sensitivity and specificity in Naming detector</li>
+ <li>More sensitivity and specificity in UnreadFields
+ detector</li>
+ <li>More sensitivity in FindNullDeref detector</li>
+ <li>More sensitivity in FindBadCast2 detector</li>
+ <li>More specificity in FindReturnRef detector</li>
+ <li>Many other tweaks and bug fixes</li>
+ </ul>
+ </li>
+ </ul>
+
+ <p>Changes since version 1.2.0</p>
+ <ul>
+ <li>Bug fixes:
+ <ul>
+ <li><a
+ href="http://fisheye2.cenqua.com/changelog/findbugs/?cs=8219">Fix</a>
+ <a
+ href="http://sourceforge.net/tracker/index.php?func=detail&aid=1726946&group_id=96405&atid=614693">bug</a>
+ with detectors that were requested to be disabled but were
+ enabled due to requirements of other detectors.</li>
+ <li>Fix bugs in incremental analysis within Eclipse plugin</li>
+ <li>Fix some analysis errors</li>
+ <li>Fix some threading bugs in GUI2</li>
+ <li>Report version as version when it was compiled, not when
+ it was run</li>
+ <li>Copy analysis time stamp when filtering or transforming
+ analysis files.</li>
+ </ul>
+ <li>Enabled StaticCalendarDetector</li>
+ <li>Reworked GUI2 to use standard FindBugs filters
+ <ul>
+ <li>Allow a suppression filter to be stored in a project and
+ persisted to the XML representation of a project.</li>
+ </ul>
+ </li>
+
+ <li>Move away from old GUI2 save format (a directory
+ containing an xml file and another file containing serialized
+ filters).</li>
+ <li>Support/recommend use of two new file extensions/formats:
+ <dl>
+ <dt>.fba - FindBugs Analysis File</dt>
+ <dd>Exactly the same as an existing bug collection file
+ stored in XML format, but using a distinct file extension to
+ make it easier to figure out which xml files contain FindBugs
+ results.</dd>
+ <dt>.fbp - FindBugs Project File</dt>
+ <dd>Contains just the information needed to run FindBugs and
+ display the results (e.g., the files to be analyzed, the
+ auxiliary class path and the location of source files)
+ </dl>
+ </li>
+ </ul>
+ <p>Changes since version 1.1.3</p>
+ <ul>
+ <li>Added -xml:withAbridgedMessages option to generate xml
+ containing shorter messages. The messages will be shorted by doing
+ things like eliding package names, and leaving off the source line
+ from the LongMessage. These messages are appropriate if being used
+ in a context where the non-message components of the bug
+ annotations will be used to provide more information (e.g.,
+ clicking on the message for a MethodAnnotation will display the
+ source for the method).
+ <ul>
+ <li>FindBugsDisplayFeatures.setAbridgedMessages(true) can be
+ used to generate abridged messages when FindBugs is being
+ accessed directly (not via generated XML) from a GUI or IDE.</li>
+ </ul>
+ <li>In null pointer analysis, try to be better about always
+ showing two locations: where it is known null and where it is
+ dereferenced.
+ <li>Interprocedural analysis of which methods return nonnull
+ values
+ <li>Use method calls to select order in which classes are
+ analyzed, and order in which methods are analyzed, to improve
+ interprocedural analysis results.
+ <li>Significant improvements in memory footprint, memory
+ allocation and CPU utilization (20-30% reduction in all three)
+ <li>Added a project name, to provide better descriptions in
+ the HTML output.
+ <li>Added new bug pattern: Casting to char, or bit masking
+ with nonnegative value, and then checking to see if the result is
+ negative.
+ <li>Stopped reporting transient fields of classes not marked
+ as serializable. Transient is used by other persistence
+ frameworks.
+ <li>Improvements to detector for SQL injection (Thanks to <a
+ href="http://www.clock.org/~matt">Matt Hargett</a> for his
+ contributions
+ <li>Changed open/save options in GUI2 to not distinguish
+ between FindBugs projects and saved FindBugs analysis results.
+ <li>Improvements to detection of serious non-short-circuit
+ evaluation.
+ <li>Updated Japanese localization (thanks to Ruimo Uno)
+ <li>Eclipse plugin changes:
+ <ul>
+ <li>Created Bug User Annotations and Bug Tree Views
+ <li>Use different icons for different bug priorities
+ <li>Provide more information in Bug Details view
+ </ul>
+ </ul>
+
+ <p>Changes since version 1.1.2:</p>
+ <ul>
+ <li>Fixed broken Ant task
+ <li>Added running ant task to smoke test
+ <li>Added validating xml and html output to smoke test
+ <li>Fixed some (but not all) issues with html output
+ validation
+ <li>Added check for x.equals(x) and x.compareTo(x)
+ <li>Various bug fixes
+ </ul>
+ <p>Changes since version 1.1.1:</p>
+ <ul>
+ <li>Added check for infinite iterative loops</li>
+ <li>Added check for use of incompatible types in a collection
+ (e.g., checking to see if a Set<String> contains a
+ StringBuffer).</li>
+ <li>Added check for invocations of equals or hashCode on a
+ URL, which, <a
+ href="http://michaelscharf.blogspot.com/2006/11/javaneturlequals-and-hashcode-make.html">surprising
+ many people</a>, requires DNS resolution.
+ </li>
+ <li>Added check for classes that define compareTo but not
+ equals; such classes can exhibit some anomalous behavior (e.g.,
+ they are treated differently by PriorityQueues in Java 5 and Java
+ 6).</li>
+ <li>Added a check for useless self operations (e.g., x < x
+ or x ^ x).</li>
+ <li>Fixed a data race that could cause the GUI to fail on
+ startup</li>
+ <li>Partial internationalization of the new GUI</li>
+ <li>Fix bug in "Redo analysis" option of new GUI</li>
+ <li>Tuning to reduce false positives</li>
+ <li>Fixed a bug in null pointer analysis that was generating
+ false positive null pointer warnings on exception paths. Fixing
+ this bug eliminates about 1/4 of the warnings on null pointer
+ exceptions on exception paths.</li>
+ <li>Fixed a bug in the processing of phi nodes for fields in
+ the null pointer analysis</li>
+ <li>Applied contributed patch that provides more quick fixes
+ in Eclipse plugin.</li>
+ <li>Fixed a number of bugs in the Eclipse auto update sites,
+ and in the way date qualifiers were being used in the Eclipse
+ plugin. You may need to manually disable your existing version of
+ the plugin and download the 1.1.2 from the update site to get the
+ automatic update function working correctly. The Eclipse update
+ sites are described at <a
+ href="http://findbugs.cs.umd.edu/eclipse/">http://findbugs.cs.umd.edu/eclipse/</a>.
+
+ </li>
+ <li>Fixed progress bar in Eclipse plugin</li>
+ <li>A number of other bug fixes.</li>
+ </ul>
+
+ <p>Changes since version 1.1.0:</p>
+ <ul>
+ <li>less scanning of classes not on the analysis path (This
+ was causing some performance problems.)</li>
+ <li>no unread field warnings for fields annotated with
+ javax.persistent or javax.ejb3</li>
+ <li>Eclipse plugin
+ <ul>
+ <li>bug annotation info displayed in Bug Details tab</li>
+ <li>.fbwarnings data file now stored in .metadata (not in
+ the project itself)</li>
+ </ul>
+ </li>
+ <li>new SE_BAD_FIELD_INNER_CLASS pattern</li>
+ <li>updates to Japanese translation (ruimo)</li>
+ <li>fix some internal slashed/dotted path confusion</li>
+ <li>other minor improvements</li>
+ </ul>
+
+ <p>Changes since version 1.0.0:</p>
+
+ <ul>
+ <li>Overall, the change from FindBugs 1.0.0 to FindBugs 1.1.0
+ has been a big change. We've done a lot of work in a lot of areas,
+ and aren't even going to try to enumerate all the changes.</li>
+ <li>We spent a lot of time reviewing the results generated by
+ FindBugs for open source and commercial code bases, and made a
+ number of changes, small and large, to minimize the number of
+ false positives. Our primary focus for this was warnings reported
+ as high and medium priority correctness warnings. Our internal
+ evaluation is that we produce very few high/medium priority
+ correctness warnings where the analysis is actually wrong, and
+ that more than 75% of the high/medium priority correctness
+ warnings correspond to real coding defects that need addressing in
+ the source code. The remaining 25% are largely cases such as a
+ branch or statement that if taken would lead to an error, but in
+ fact is a dead branch or statement that can never be taken. Such
+ coding is confusing and hard to maintain, so it should arguably be
+ fixed, but it is unlikely to actually result in an error during
+ execution. Thus, some might classify those warnings as false
+ positives.</li>
+ <li>We've substantially improved the analysis for errors that
+ could result in null pointer dereferences. Overall, our experience
+ has been that these changes have roughly doubled the number of
+ null pointer errors we detect, without increasing the number of
+ false positives (in fact, our false positive rate has gone down).
+ The improvements are due to four factors:
+ <ul>
+ <li>By default, we now do some interprocedural analysis to
+ determine methods that unconditionally dereference their
+ parameters.</li>
+ <li>FindBugs also comes with a model of which JDK methods
+ unconditionally dereference their parameters.</li>
+ <li>We do limited tracking of fields, so that we can detect
+ null values stored in fields that lead to exceptions.</li>
+ <li>We implemented a new analysis technique to find
+ guaranteed dereferences. Consider the following example: <pre>public int f(Object x, boolean b) {
+ int result = 0;
+ if (x == null) result++;
+ else result--;
+ // at this point, we know x is null on a simple path
+ if (b) {
+ // at this point, x is only null on a complex path
+ // we don't know if the path in which x is null and b is true is feasible
+ return result + x.hashCode();
+ }
+ else {
+ // at this point, x is only null on a complex path
+ // we don't know if the path in which x is null and b is false is feasible
+ return result - x.hashCode();
+ }
+</pre>
+
+ <p>
+ FindBugs 1.0 used forward dataflow analysis to determine
+ whether each value is definitely null, null on a simple path,
+ possible null on a complex path, or definitely nonnull. Thus,
+ at the statement where
+ <code> result </code>
+ is decremented, we know that
+ <code> x </code>
+ is definitely null, and at the point before
+ <code> if (b) </code>
+ , we know that
+ <code> x </code>
+ is null on a simple path. If
+ <code> x </code>
+ were to be dereferenced here, we would generate a warning,
+ because if the else branch of the
+ <code> if (x == null) </code>
+ were ever taken, a null pointer exception would result.
+ </p>
+
+ <p>
+ However, in both the then and else branches of the
+ <code> if (b) </code>
+ statement,
+ <code> x </code>
+ is only null on a complex path that may be infeasible. It might
+ be that the program logic is such that if
+ <code> x </code>
+ is null, then
+ <code> b </code>
+ is never true, so generating a warning about the dereference in
+ the then clause might be a false positive. We could try to
+ analyze the program to determine whether it is possible for
+ <code> x </code>
+ to be null and
+ <code> b </code>
+ to be true, but that can be a hard analysis problem.
+ </p>
+
+ <p>
+ However,
+ <code> x </code>
+ is dereferenced in both the then <em>and</em> else branches of
+ the
+ <code> if (b) </code>
+ statement. So at the point immediately before
+ <code> if (b) </code>
+ , we know that
+ <code> x </code>
+ is null on a simple path <em>and</em> that
+ <code> x </code>
+ is guaranteed to be dereferenced on all paths from this point
+ forward. FindBugs 1.1 performs a backwards data flow analysis
+ to determine the values that are guaranteed to be dereferenced,
+ and will generate a warning in this case.
+ </p>
+ </li>
+ </ul>
+ <p>
+ The following screen shot of our new GUI shows an example of this
+ analysis, as well as showing off our new GUI and points out a
+ limitation of our current plugins for Eclipse and NetBeans. The
+ screen shot shows a null pointer bug in HelpDisplay.java. The
+ test for
+ <code> href!=null </code>
+ on line 78 suggests that
+ <code> href </code>
+ could be null. If it is, then
+ <code> href </code>
+ will be dereferenced on either line 87 or on line 90, generating
+ a NPE. Note that our analysis here also understands that passing
+ <code> href </code>
+ to
+ <code> URLEncoder.encode </code>
+ will deference it, and thus treats line 87 as a dereference, even
+ though
+ <code> href </code>
+ is not actually dereferenced at that line. Within our new GUI,
+ all of these locations are highlighted and listed in the summary
+ panel. In the original GUI (and in HTML output) we list all of
+ the locations, but only the primary location is highlighted by
+ the original GUI. In the Eclipse and NetBeans plugins, only the
+ primary location is displayed; fixing this is on our todo list
+ (contributions welcome).
+ </p>
+ <p>
+ <img src="guaranteedDereference.png" alt="">
+
+
+ </p>
+
+ </li>
+ <li>Preliminary support for detectors using the frameworks
+ other than BCEL, such as the <a href="http://asm.objectweb.org/">ASM</a>
+ bytecode framework. You may experiment with writing ASM-based
+ detectors, but beware the API may still change (which could
+ possibly also affect BCEL-based detectors). In general, we've
+ started trying to move away from a deep dependence on BCEL, but
+ that change is only partially complete. Probably best to just
+ avoid this until we complete more work on this. This change is
+ only visible to FindBugs plugin developers, and shouldn't be
+ visible to FindBugs users.
+ </li>
+ <li>
+ <p>Bug categories (CORRECTNESS, MT_CORRECTNESS, etc.) are no
+ longer hard-coded, but rather defined in xml files associated
+ with plugins, including the core plugin which defines the
+ standard categories. Third-party plugins can define their own
+ categories.</p>
+ </li>
+ <li>
+ <p>Several bug patterns have been moved from CORRECTNESS and
+ STYLE into a new category, BAD_PRACTICE. The English localization
+ of STYLE has changed from "Style" to "Dodgy."</p>
+ <p>In general, we've worked very hard to limit CORRECTNESS
+ bugs to be real programming errors and sins of commission. We
+ have reclassified as BAD_PRACTICE a number of bad design
+ practices that result in overly fragile code, such as defining an
+ equals method that doesn't accept null or defining class with a
+ equals method that inherits hashCode from class Object.</p>
+ <p>In general, our guidelines for deciding whether a bug
+ should be classified as CORRECTNESS, BAD_PRACTICE or STYLE are:</p>
+ <dl>
+ <dt>CORRECTNESS</dt>
+ <dd>A problem that we can recognize with high confidence and
+ is an issue that we believe almost all developers would want to
+ examine and address. We recommend that software teams review all
+ high and medium priority warnings in their entire code base.</dd>
+ <dt>BAD_PRACTICE</dt>
+ <dd>A problem that we can recognize with high confidence and
+ represents a clear violation of recommended and standard coding
+ practice. We believe each software team should decide which bad
+ practices identified by FindBugs it wants to prohibit in the
+ team's coding standard, and take action to remedy violations of
+ those coding standards.</dd>
+ <dt>STYLE</dt>
+ <dd>These are places where something strange or dodgy is
+ going on, such as a dead store to a local variable. Typically,
+ less than half of these represent actionable programming
+ defects. Reviewing these warnings in any code under active
+ development is probably a good idea, but reviewing all such
+ warnings in your entire code base might be appropriate only in
+ some situations. Individual or team programming styles can
+ substantially influence the effectiveness of each of these
+ warnings (e.g., you might have a coding practice or style in
+ your group that confuses one of the detectors into generating a
+ lot of STYLE warnings); you will likely want to selectively
+ suppress or report the STYLE warnings that are effective for
+ your group.</dd>
+ </dl>
+ </li>
+ <li>Released a preliminary version of a new GUI (known
+ internally as GUI2 -- not very creative, huh?)</li>
+ <li>Provided standard ways to mark user designations of bug
+ warnings (e.g., as NOT_A_BUG or SHOULD_FIX). The internal logic
+ now records this, it is represented in the XML file, and GUI2
+ allows the designations to be applied (along with free-form user
+ annotations about each warning). The user designations and
+ annotations are not yet supported by the Eclipse plugin, but we
+ clearly want to support it in Eclipse shortly.</li>
+ <li>Added a check for a bad comparison with a signed byte with
+ a value not in the range -128..127. For example: <pre>boolean find200(byte b[]) {
+ for(int i = 0; i < b.length; i++) if (b[i] == 200) return i;
+ return -1;
+}
+</pre>
+ </li>
+ <li>Added a checking for testing if a value is equal to
+ Double.NaN (no value is equal to NaN, not even NaN).</li>
+ <li>Added a check for using a class with an equals method but
+ no hashCode method in a hashed data structure.</li>
+ <li>Added check for uncallable method of an anonymous inner
+ class. For example, in the following code, it is impossible to
+ invoke the initalValue method (because the name is misspelled and
+ as a result is doesn't override a method in ThreadLocal). <pre>private static ThreadLocal serialNum = new ThreadLocal() {
+ protected synchronized Object initalValue() {
+ return new Integer(nextSerialNum++);
+ }
+ };
+</pre>
+ </li>
+ <li>Added check for a dead local store caused by a switch
+ statement fall through</li>
+ <li>Added check for computing the absolute value of a random
+ 32 bit integer or of a hashcode. This is broken because <code>
+ Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE </code> , and thus
+ result of calling Math.abs, which is expected to be nonnegative,
+ will in fact be negative one time out of 2 <sup> 32 </sup> , which
+ will invariably be the time your boss is demoing the software to
+ your customers.
+
+ </li>
+ <li>More careful resolution of inherited methods and fields.
+ Some of the shortcuts we were taking in FindBugs 1.0.0 were
+ leading to inaccurate results, and it was fairly easy to address
+ this by making the analysis more accurate.</li>
+ <li>Overall, analysis times are about 1.6 times longer in
+ FindBugs 1.1.0 than in FindBugs 1.0.0. This is because we have
+ enabled substantial additional analysis at the default effort
+ level (the actual analysis engine is significantly faster than in
+ FindBugs 1.0). On a recent AMD Athlon processor, analyzing
+ JDK1.6.0 (about 1 million lines of code) requires about 15 minutes
+ of wall clock time.</li>
+ <li>Provided class and script (printClass) to print classfile
+ in the human readable format produced by BCEL</li>
+ <li>Provided -findSource option to setBugDatabaseInfo</li>
+ </ul>
+
+
+ <p>Changes since version 0.9.7:</p>
+
+ <ul>
+ <li>fix ObjectTypeFactory bug that was suppressing some bugs</li>
+ <li>opcode stack may determine definite zeros on some paths</li>
+ <li>opcode stack can track some constant string concatenations
+ (dbrosius)</li>
+ <li>default effort performs iterative opcode analysis (but min
+ effort does not)</li>
+ <li>default heap size upped to 384m</li>
+ <li>schema for XML output available: bugcollection.xsd</li>
+ <li>fixed some internal confusion between dotted and slashed
+ class names</li>
+ <li>New detectors
+ <ul>
+ <li>CheckImmutableAnnotation.java: checks JCIP annotations</li>
+ </ul>
+ </li>
+ <li>Updated detectors
+ <ul>
+ <li>BadRegEx.java: understands Pattern.LITERAL, warns about
+ "."</li>
+ <li>FindUnreleasedLock.java: fewer false positives</li>
+ <li>DumbMethods.java: check for vacuous comparisons to
+ MAX_INTEGER or MIN_INTEGER, fix bugs detecting
+ DM_NEXTINT_VIA_NEXTDOUBLE</li>
+ <li>FindPuzzlers.java: detect <tt>n%2==1</tt>, detect
+ toString() on array types
+ </li>
+ <li>FindInconsistentSync2.java: detects IS_FIELD_NOT_GUARDED
+ </li>
+ <li>MethodReturnCheck.java: add check for discarded newly
+ constructed values, increase priority of some ignored
+ constructed exceptions, better handling of bytecode compiled by
+ Eclipse</li>
+ <li>FindEmptySynchronizedBlock.java: better handling of
+ bytecode compiled by Eclipse</li>
+ <li>DoInsideDoPrivileged.java: warn if call to setAccessible
+ isn't in doPriviledged, don't report private methods</li>
+ <li>LoadOfKnownNullValue.java: fix bug that was reporting
+ false positives on <code> finally </code> blocks
+ </li>
+ <li>CheckReturnAnnotationDatabase.java: better checks for
+ unstarted threads</li>
+ <li>ConfusionBetweenInheritedAndOuterMethod.java: fewer
+ false positives, fixed a package-handling bug</li>
+ <li>BadResultSetAccess.java: separate bug pattern for
+ PreparedStatements, <code> BRZA </code> category folded into <code>
+ SQL </code> category
+ </li>
+ <li>FindDeadLocalStores.java, FindBadCast2.java,
+ DumbMethods.java, RuntimeExceptionCapture.java: coalesce similar
+ bugs within a method into a single bug instance with multiple
+ source lines</li>
+ </ul>
+ </li>
+ <li>Eclipse plugin
+ <ul>
+ <li>plugin ID changed from <tt>de.tobject.findbugs</tt> to <tt>edu.umd.cs.findbugs.plugin.eclipse</tt>
+ </li>
+ <li>support for findbugs eclipse auto-update site</li>
+ </ul>
+ </li>
+ <li>Updated test case files
+ <ul>
+ <li>BadRegEx.java</li>
+ <li>JSR166.java</li>
+ <li>ConcurrentModificationBug.java</li>
+ <li>DeadStore.java</li>
+ <li>InstanceOf.java</li>
+ <li>LoadKnownNull.java</li>
+ <li>NeedsToCheckReturnValue.java</li>
+ <li>BadResultSetAccessTest.java</li>
+ <li>DeadStore.java</li>
+ <li>TestNonNull2.java</li>
+ <li>TestImmutable.java</li>
+ <li>TestGuardedBy.java</li>
+ <li>BadRandomInt.java</li>
+ <li>six test cases added to new <code> TigerTraps </code>
+ directory
+ </li>
+ </ul>
+ </li>
+ <li>fix bug that was generating duplicate uids</li>
+ <li>fix bug with <code> -onlyAnalyze some.package.* </code> on
+ jdk1.4
+ </li>
+ <li>fix regression bug in
+ DismantleByteCode.getRefConstantOperand()</li>
+ <li>fix some minor bugs with the Swing GUI</li>
+ <li>reordered some bugInstances so that source line
+ annotations come last</li>
+ <li>removed references to unused java system properties</li>
+ <li>French translation updates (David Cotton)</li>
+ <li>Japanese translation updates (Hanai Shisei)</li>
+ <li>content cleanup for findbugs.xml and messages.xml</li>
+ <li>references to cvs hostname updated to
+ findbugs.cvs.sourceforge.net</li>
+ <li>documented xdoc output options, new
+ mineBugHistory/computeBugHistory options</li>
+ </ul>
+
+ <p>Changes since version 0.9.6:</p>
+
+ <ul>
+ <li>performance improvements</li>
+ <li>ObjectType instances are cached to reduce memory footprint
+ </li>
+ <li>for performance and memory reasons stateless detectors are
+ no longer cloned, must clear their own state between .class files
+ </li>
+ <li>fixed bug in bytecode-set lookup for methods (was causing
+ bad results for IS2, perhaps others)</li>
+ <li>fix some OpcodeStack bugs with integer and long
+ operations, perform iterative analysis when effort is <tt>max</tt>
+ </li>
+ <li>HTML output includes LongMessage text again (regression in
+ 0.95 - 0.96)</li>
+ <li>New detectors
+ <ul>
+ <li>CalledMethods.java: builds a list of invoked methods for
+ other detectors to consult (non-reporting)</li>
+ <li>UncallableMethodOfAnonymousClass.java: detect anonymous
+ inner classes that define methods that are probably intended to
+ but do not override methods in a superclass.</li>
+ </ul>
+ </li>
+ <li>Updated detectors
+ <ul>
+ <li>FindFieldSelfAssignment.java: recognize separate fields
+ with the same name (one from superclass)</li>
+ <li>FindLocalSelfAssignment2.java: handles backward branches
+ better (Dave Brosius)</li>
+ <li>FindBadCast2.java: BC_NULL_INSTANCEOF changed to
+ NP_NULL_INSTANCEOF</li>
+ <li>FindPuzzlers.java: eliminate false positive on setDate()
+ (Dave Brosius)</li>
+ </ul>
+ </li>
+ <li>Eclipse plugin
+ <ul>
+ <li>fix serious threading bug</li>
+ <li>preferences for Filters and effort (Peter Hendriks)</li>
+ <li>French localization (David Cotton)</li>
+ <li>fix bug when reporting inner classes (Peter Friese)</li>
+ </ul>
+ </li>
+ <li>Updated test case files
+ <ul>
+ <li>Mwn.java (Carl Burke/Dave Brosius)</li>
+ <li>DumbMethodInvocations.java (Anto paul/Dave Brosius)</li>
+ <!--sic-->
+ </ul>
+ </li>
+ <li>XML output includes garbage collection duration</li>
+ <li>French messages updated (David Cotton)</li>
+ <li>Swing GUI shows file name after Load Bugs command</li>
+ <li>Ant task to launch the findbugs frame (Mark McKay)</li>
+ <li>miscellaneous code cleanup</li>
+ </ul>
+
+ <p>Changes since version 0.9.5:</p>
+
+ <ul>
+ <li>Updated detectors
+ <ul>
+ <li>FindNullDeref.java: respect NonNull and CheckForNull
+ field annotations</li>
+ <li>SerializableIdiom.java: detect non-private readObject
+ and writeObject methods</li>
+ <li>FindRefComparison.java: smarter array comparison
+ detection</li>
+ <li>IsNullValueAnalysis.java: detect <tt>null
+ instanceof</tt>
+ </li>
+ <li>FindLocalSelfAssignment2.java: suppress some false
+ positives (Dave Brosius)</li>
+ <li>FindUnreleasedLock.java: don't waste time processing
+ classes that don't refer to java.util.concurrent.locks</li>
+ <li>MutableStaticFields.java: report the source line (Dave
+ Brosius)</li>
+ <li>SwitchFallthrough.java: better handling of System.exit()
+ (Dave Brosius)</li>
+ <li>MultithreadedInstanceAccess.java: better handling of
+ Servlet.init() (Dave Brosius)</li>
+ <li>ConfusionBetweenInheritedAndOuterMethod.java: now
+ enabled</li>
+ </ul>
+ </li>
+ <li>Eclipse plugin
+ <ul>
+ <li>background processing (Peter Friese)</li>
+ <li>internationalization, Japanese localization (Takashi
+ Okamoto)</li>
+ </ul>
+ </li>
+ <li>findbugs <tt>-onlyAnalyze</tt> option now works on windows
+ platforms
+ </li>
+ <li>mineBugHistory <tt>-noTabs</tt> option for better
+ alignment of output columns
+ </li>
+ <li>filterBugs <tt>-fixed</tt> option (also: will now
+ recognize the most recent version string)
+ </li>
+ <li>XML output includes running time and memory usage data</li>
+ <li>miscellaneous minor corrections to the manual</li>
+ <li>better bytecode analysis of the <tt>iinc</tt> instruction
+ </li>
+ <li>fix bug in null pointer analysis</li>
+ <li>improved catch block heuristics</li>
+ <li>some type analysis tweaks</li>
+ <li>Bug priority changes
+ <ul>
+ <li>DumbMethodInvocations.java: decrease priority of
+ hard-coded <tt>/tmp</tt> filenames
+ </li>
+ <li>ComparatorIdiom.java: decrease priority of
+ non-serializable anonymous comparators</li>
+ <li>FindSqlInjection.java: decrease priority of appending a
+ constant or a static</li>
+ </ul>
+ </li>
+ <li>Updated bug explanations
+ <ul>
+ <li>NM_VERY_CONFUSING (Dave Brosius)</li>
+ </ul>
+ </li>
+ <li>Updated test case files
+ <ul>
+ <li>BadStoreOfNonSerializableObject.java</li>
+ <li>BadRandomInt.java</li>
+ <li>TestFieldAnnotations.java</li>
+ <li>UseInitCause.java</li>
+ <li>SqlInjection.java</li>
+ <li>ArrayEquality.java</li>
+ <li>BadIntegerOperations.java</li>
+ <li>Pilhuhn.java</li>
+ <li>InstanceOf.java</li>
+ <li>SwitchFallthrough.java (Dave Brosius)</li>
+ </ul>
+ </li>
+ <li>fix URL decoding bug when running under Java Web Start
+ (Dave Brosius)</li>
+ <li>distribution includes <tt>project.xml</tt> file for
+ NetBeans
+ </li>
+ </ul>
+
+ <p>Changes since version 0.9.4:</p>
+ <ul>
+ <li>New detectors
+ <ul>
+ <li>VarArgsProblems.java</li>
+ <li>FindSqlInjection.java: now enabled</li>
+ <li>ComparatorIdiom.java: comparators usually implement
+ serializable</li>
+ <li>Naming.java: detect methods not overridden due to
+ eponymously typed args from different packages</li>
+ </ul>
+ </li>
+ <li>Updated detectors
+ <ul>
+ <li>SwitchFallthrough.java: surpress some false positives</li>
+ <li>DuplicateBranches.java: surpress some false positives</li>
+ <li>IteratorIdioms.java: surpress some false positives</li>
+ <li>FindHEmismatch.java: surpress some false positives</li>
+ <li>QuestionableBooleanAssignment.java: finds more cases of
+ <tt>if (b=true)</tt> ilk
+ </li>
+ <li>DumbMethods.java: detect int remainder by 1, delayed gc
+ errors</li>
+ <li>SerializableIdiom.java: detect store of nonserializable
+ object into field of serializable class</li>
+ <li>FindNullDeref.java: fix potential exception</li>
+ <li>IsNullValue.java: fix potential exception</li>
+ <li>MultithreadedInstanceAccess.java: fix potential
+ exception</li>
+ <li>PreferZeroLengthArrays.java: flag the method, not the
+ line</li>
+ </ul>
+ </li>
+ <li>Remove some inadvertent dependencies on JDK 1.5</li>
+ <li>Sort order should be more consistent</li>
+ <li>XML output changes
+ <ul>
+ <li>Option to sort XML bug output</li>
+ <li>Now contains instance IDs</li>
+ <li>uid no longer missing (was causing problems with fancy
+ HTML output)</li>
+ <li>Typo fixed</li>
+ </ul>
+ </li>
+ <li>Internal changes to track source files, <tt>-sourceInfo</tt>
+ option
+ </li>
+ <li>Bug matching: first try exact bug pattern matching, option
+ to compare priorities, option to disable package moves</li>
+ <li>Architecture documentation in <tt>design/architecture</tt>
+ </li>
+ <li>Test cases move into their own CVS project</li>
+ <li>Don't report warnings that occur outside the analyzed
+ classes</li>
+ <li>Fixes to the build.xml files</li>
+ <li>Better handling of @CheckReturnValue and @CheckForNull
+ annotations (also, some additional methods searched for check
+ return value and check for null)</li>
+ <li>Fixed some stream-closing bugs (one by <tt>z-fb-user</tt>/Dave
+ Brosius)
+ </li>
+ <li>Bug priority changes
+ <ul>
+ <li>increase priority of ignoring return value of
+ java.sql.Connection methods</li>
+ <li>increase priority of comparing classes like Integer
+ using <tt>==</tt>
+ </li>
+ <li>decrease priority of IT_NO_SUCH_ELEMENT if we see any
+ call to <tt>next()</tt>
+ </li>
+ <li>tweak priority of NM_METHOD_CONSTRUCTOR_CONFUSION</li>
+ <li>decrease priority of RV_RETURN_VALUE_IGNORED for an
+ inherited annotation that doesn't return same type as class</li>
+ </ul>
+ </li>
+ <li>Updated bug explanations
+ <ul>
+ <li>RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE</li>
+ <li>DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED</li>
+ <li>IMA_INEFFICIENT_MEMBER_ACCESS (Dave Brosius)</li>
+ <li>some Japanese improvements to messages_ja.xml ( <tt>ruimo</tt>)
+ </li>
+ <li>some German improvements to findbugs_de.properties (Dave
+ Brosius, <tt>dvholten</tt>)
+ </li>
+ </ul>
+ </li>
+ <li>Updated test case files
+ <ul>
+ <li>BadIntegerOperations.java</li>
+ <li>SecondKaboom.java</li>
+ <li>OpenDatabase.java (Dave Brosius)</li>
+ <li>FindOpenStream.java (Dave Brosius)</li>
+ <li>BadRandomInt.java</li>
+ </ul>
+ </li>
+ <li>Source-lines info maintained for methods (handy for
+ abstract and native methods)</li>
+ <li>Remove surrounding opcodes from source line annotations</li>
+ <li>Better error when can't read file</li>
+ <li>Swing GUI: removed console pane from FindBugsFrame, fix
+ missing classes bug</li>
+ <li>Fixes to OpcodeStack.java</li>
+ <li>Detectors may attach a custom value to an OpcodeStack.Item
+ (Dave Brosius)</li>
+ <li>Filter.java: ability to add text messages to XML output,
+ fix bug with <tt>-withMessages</tt>
+ </li>
+ <li>SourceInfoMap supports ranges of source lines</li>
+ <li>Ant task supports the <tt>timestampNow</tt> attribute
+ </li>
+ </ul>
+
+ <p>Changes since version 0.9.3:</p>
+ <ul>
+ <li>Substantial rework of datamining code</li>
+ <li>Removed bogus warnings about await on things other than
+ Condition not being in a loop</li>
+ <li>Fixed bug in OpcodeStack handling of dup2 of long/double
+ values</li>
+ <li>Don't report array types as missing classes</li>
+ <li>Adjustment of some warnings on ignored return values</li>
+ <li>Added thread safety annotations from Java Concurrency in
+ Practice (no detectors written for these yet)</li>
+ <li>Added annotation for methods that, if overridden, should
+ be invoked by overriding methods via a call to super</li>
+ <li>Updated -html:fancy.xsl (Etienne Giraudy)</li>
+ </ul>
+
+ <p>Note: there was no version 0.9.2</p>
+
+ <p>Changes since version 0.9.1:</p>
+ <ul>
+ <!-- New detectors -->
+ <li>Embellish USM to find abstract methods that implement an
+ interface method (Dave Brosius)</li>
+ <li>New detector to find stores of literal booleans inside if
+ or while expressions (Dave Brosius)</li>
+ <li>New style detector to find final classes that declare
+ protected fields (Dave Brosius)</li>
+ <li>New detector to find subclass methods that simply forward,
+ verbatim, to the super class (Dave Brosius)</li>
+ <li>Detector to find instances where code is attempting to
+ write an object out via an implementation of DataOutput, but the
+ object is not guaranteed to be Serializable (Jon Christiansen,
+ Bill Pugh)</li>
+
+ <!-- Feature enhancements -->
+ <li>Large (35%) analysis speedup (Bill Pugh)</li>
+ <li>Add line numbers to Swing GUI code panel (Dave Brosius)</li>
+ <li>Added effort options to Swing GUI (Dave Brosius)</li>
+ <li>Add ability to specify bugs file to open from command line
+ for GUI version, through -loadbugs (Phillip Martin)</li>
+ <li>New stylesheet for generating HTML: use option <tt>-html:plain.xsl</tt>
+ (Chris Nappin)
+ </li>
+ <li>New stylesheet for generating HTML: use option <tt>-html:fancy.xsl</tt>
+ (Etienne Giraudy)
+ </li>
+ <li>Updated Japanese bug message translations (Shisei Hanai)</li>
+
+ <!-- Bug fixes -->
+ <li>XHTML compliance fixes for bug details (Etienne Giraudy)</li>
+ <li>Various detector fixes (Shisei Hanai)</li>
+ <li>Fixed bugs in the project preferences dialog int the
+ Eclipse plugin (Takashi Okamoto, Thomas Einwaller)</li>
+ <li>Lowered priority of analysis thread in Swing GUI (David
+ Hovemeyer, suggested by Shisei Hanai and Jeffrey W. Badorek)</li>
+ <li>Fixed EclipsePlugin to correctly pick up auxclasspath
+ entries (Jon Christiansen)</li>
+ </ul>
+
+ <p>Changes since version 0.9.0:</p>
+ <ul>
+ <li>Fixed dependence on JRE 1.5: all features should work on
+ JRE 1.4 again</li>
+ <li>Fixed -effort command line option handling for Swing GUI</li>
+ <li>Fixed conserveSpace and workHard attributes int Ant task</li>
+ <li>Added support for effort attribute in Ant task</li>
+ </ul>
+
+ <p>Changes since version 0.8.8:</p>
+ <ul>
+ <!-- New detectors and bug patterns -->
+ <li>XMLFactoryBypass detector to find direct allocation of xml
+ class implementations (Dave Brosius)</li>
+ <li>InefficientMemberAccess detector to find accesses to
+ owning class private members (Dave Brosius)</li>
+ <li>DuplicateBranches detector checks switch statements too
+ (Dave Brosius)</li>
+
+ <!-- Feature enhancements -->
+ <li>FindBugs available from findbugs.sourceforge.net as Java
+ Web Start application (Dave Brosius)</li>
+ <li>Updated Japanese bug message translations (Shisei Hanai)</li>
+ <li>Improved bug detail message for covariant equals() (Shisei
+ Hanai)</li>
+ <li>Modeling of instanceof checks is now enabled by default,
+ making the bad cast detector much more useful (Bill Pugh, David
+ Hovemeyer)</li>
+ <li>Support for detector ordering constraints in plugin
+ descriptor (David Hovemeyer)</li>
+ <li>Simpler option to control analysis effort: -effort: <i>value</i>,
+ where <i>value</i> is one of <code> min </code> , <code>
+ default </code> , or <code> max </code> (David Hovemeyer)
+ </li>
+ <li>Using -effort:max, FindNullDeref checks for null arguments
+ passed to methods which dereference them unconditionally (David
+ Hovemeyer)</li>
+ <li>FindNullDeref checks @Null and @NonNull annotations for
+ parameters and return values (David Hovemeyer)</li>
+
+ <!-- Bug fixes -->
+ </ul>
+
+ <p>Changes since version 0.8.7:</p>
+
+ <ul>
+ <!-- New detectors and bug patterns -->
+ <li>New detector to find duplicate code in if/else statements
+ (Dave Brosius)</li>
+ <li>Look for calls to wait() on Condition objects (David
+ Hovemeyer)</li>
+ <li>Look for java.util.concurrent.Lock objects not released on
+ every path out of method (David Hovemeyer)</li>
+ <li>Look for calls to Thread.sleep() with a lock held (David
+ Hovemeyer)</li>
+ <li>More accurate detection of impossible casts (Bill Pugh,
+ David Hovemeyer)</li>
+
+ <!-- Feature enhancements -->
+ <li>Saved XML now contains project statistics (Jay Dunning)</li>
+ <li>Filter files can select by bug pattern type and warning
+ priority (David Hovemeyer)</li>
+
+ <!-- Bug fixes -->
+ <li>Restored some files inadvertently omitted from previous
+ release (Rohan Lloyd, David Hovemeyer)</li>
+ <li>Make sure detectors requiring JDK 1.5 runtime classes are
+ only executed if those classes are available (David Hovemeyer)</li>
+ <li>Don't display analysis error dialog unless there is really
+ an error (David Hovemeyer)</li>
+ <li>Updated and expanded French translations of bug patterns
+ and Swing GUI (Olivier Parent)</li>
+ <li>Fixed invalid character encoding in German Swing GUI
+ translation (Olivier Parent)</li>
+ <li>Fix locale used for date format in project stats (K.
+ Hashimoto)</li>
+ <li>Fixed LongDescription elements in xml:withMessages output
+ format (K. Hashimoto)</li>
+ </ul>
+
+ <p>Changes since version 0.8.6:</p>
+
+ <ul>
+ <!-- new detectors -->
+ <li>Extend Naming detector to look for classes that are named
+ XXXException but that are not Exceptions (Dave Brosius)</li>
+ <li>New detector to find classes that expose semaphores in the
+ public implementation through the 'this' reference. (Dave Brosius)
+ </li>
+ <li>New Style detector to find Struts Action/Servlet derived
+ classes that reference instance member variable not in
+ synchronized blocks. (Dave Brosius)</li>
+ <li>New Style detector to find classes that declare
+ implementation of interfaces that are already implemented by super
+ classes (Dave Brosius)</li>
+ <li>New Style detector to find circular dependencies between
+ classes (Dave Brosius)</li>
+ <li>New Style detector to find unnecessary math on constants
+ (Dave Brosius)</li>
+ <li>New detector to find equality comparisons using floating
+ point math (Jay Dunning)</li>
+ <li>New faster detector to find local self assignments (Bill
+ Pugh)</li>
+ <li>New detector to find infinite recursive loops (Bill Pugh)
+ </li>
+ <li>New detector to find for loops with an incorrect increment
+ (Bill Pugh)</li>
+ <li>New detector to find suspicious uses of
+ BufferedReader.readLine() and String.indexOf() (Bill Pugh)</li>
+ <li>New detector to find suspicious integer to double casts
+ (David Hovemeyer, Bill Pugh)</li>
+ <li>New detector to find invalid regular expression patterns
+ (Bill Pugh)</li>
+ <li>New detector to find Bloch/Gafter Java puzzlers (Bill
+ Pugh)</li>
+
+ <!-- feature enhancements -->
+ <li>New system property to suppress reporting of DLS based on
+ local variable name (Glenn Boysko)</li>
+ <li>Enhancements to configuration dialog in Eclipse plugin,
+ allow for saving enabled detectors in Eclipse projects (Phil
+ Crosby)</li>
+ <li>Sortable columns in detector dialog (Dave Brosius)</li>
+ <li>New tab in gui for showing bugs grouped by category (Dave
+ Brosius)</li>
+ <li>Improved German translation of Swing GUI (Thomas Kuehne)</li>
+ <li>Improved source file reporting in Emacs output format (Len
+ Trigg)</li>
+ <li>Improvements to redundant null comparison detector (Bill
+ Pugh)</li>
+ <li>Localization of run analysis and analysis error dialogs in
+ Swing GUI (K. Hashimoto)</li>
+
+ <!-- Bug fixes -->
+ <li>Don't scan equals methods in FindHEMismatch if code is
+ native (Greg Bentz)</li>
+ <li>French translation fixes (David Cotton)</li>
+ <li>Internationalization report fixes (K. Hashimoto)</li>
+ <li>Japanese translations updates (SHISEI Hanai)</li>
+ </ul>
+
+ <p>Changes since version 0.8.5:</p>
+ <ul>
+ <!-- new detectors -->
+ <li>New detector to find catch blocks that may inadvertently
+ catch runtime exceptions (Brian Goetz)</li>
+ <li>New detector to find objects that are instantiated based
+ on classes that only have static methods and fields, using the
+ synthesized constructor (Dave Brosius)</li>
+ <li>New detector to find calls to Thread.interrupted() in a
+ non static context, and especially with non currentThread()
+ threads (Dave Brosius)</li>
+ <li>New detector to find calls to equals() methods that use
+ Object's version. (Dave Brosius)</li>
+ <li>New detector to find Applets that call methods in the
+ constructor refering to the AppletStub (Dave Brosius)</li>
+ <li>New detector to find some cases of infinite recursion
+ (Bill Pugh)</li>
+ <li>New detector to find dead stores to local variables (David
+ Hovemeyer, Bill Pugh)</li>
+ <li>Extend Dumb Method detector for toUpperCase(),
+ toLowerCase() without a locale, new Integer(1).toString(), new
+ XXX().getClass(), and new Thread() without a run implementation
+ (Dave Brosius) <!-- feature enhancements -->
+ </li>
+ <li>Ant task supports "errorProperty" attribute, which sets an
+ Ant property to "true" if an error occurs running FindBugs
+ (Michael Tamm)</li>
+ <li>Eclipse plugin allows filtering of warnings by bug
+ category, priority (David Hovemeyer)</li>
+ <li>Swing GUI allows filtering of warnings by bug category
+ (David Hovemeyer)</li>
+ <li>Ability to annotate methods using Java 1.5 annotations
+ that suppress FindBugs warnings (Bill Pugh)</li>
+ <li>New -adjustExperimental for lowering priority of
+ BugPatterns that are experimental (Dave Brosius)</li>
+ <li>Allow for command line options 'files' using the @ symbol
+ (David Hovemeyer)</li>
+ <li>New -adjustPriority command line option to for adjusting
+ bug priorites (David Hovemeyer)</li>
+ <li>Added an Edit menu (cut/copy/paste) to Swing GUI (Dave
+ Brosius)</li>
+ <li>French translation supplied (David Cotton) <!-- Bug fixes -->
+ </li>
+ </ul>
+
+ <p>Changes since version 0.8.4:</p>
+ <ul>
+ <!-- new detectors -->
+ <li>New detector for volatile references to arrays (Bill Pugh)
+ </li>
+ <li>New detector to find instanceof usage where inheritance
+ can be determined statically (Dave Brosius)</li>
+ <li>New detector to find ResultSet.getXXX updateXXX calls
+ using index 0 (Dave Brosius)</li>
+ <li>New detector to find empty zip or jar entries (Bill Pugh)
+
+ <!-- feature enhancements -->
+ </li>
+ <li>HTML output generation using built-in XSLT stylesheet or
+ user-defined stylesheet (David Hovemeyer)</li>
+ <li>Allow URLs to be specified to analyze zip/jar files, local
+ directories, and single classfiles (David Hovemeyer)</li>
+ <li>New command line option -onlyAnalyze restricts analysis to
+ selected classes and packages without reducing accuracy (David
+ Hovemeyer)</li>
+ <li>Allow Swing GUI to show source code in jar files on
+ Windows systems (Dave Brosius) <!-- Bug fixes -->
+ </li>
+ <li>Fix the Switch Fall Thru detector (Dave Brosius, David
+ Hovemeyer, Bill Pugh)</li>
+ <li>MacOS GUI fixes (Rohan Lloyd)</li>
+ <li>Fix false positive in BOA in case where method is
+ correctly and 'incorrectly' overridden (Dave Brosius)</li>
+ <li>Fixed memory blowup when analyzing methods which access a
+ large number of fields (David Hovemeyer)</li>
+ </ul>
+
+ <p>Changes since version 0.8.3:</p>
+ <ul>
+ <li>Initial and preliminary localization of the Swing
+ GUI. Translations by:
+ <ul>
+ <li>German - Peter D. Stout, Holger Stenzhorn</li>
+ <li>Finnish - Juha Knuutila</li>
+ <li>Estonian - Tanel Lebedev</li>
+ <li>Japanese - Hanai Shisei</li>
+ </ul>
+ </li>
+ <li>Eliminated debug print statements inadvertently left
+ enabled</li>
+ <li>Reverted some changes in the open stream detector: this
+ should fix some false positives that were introduced in the
+ previous release</li>
+ <li>Fixed a couple missing class reports</li>
+ </ul>
+
+ <p>Changes since version 0.8.2:</p>
+ <ul>
+
+ <!-- New detectors -->
+ <li>New detector to find improperly overridden GUI Adapter
+ classes (Dave Brosius)</li>
+ <li>New detector to find improperly setup JUnit TestCases
+ (Dave Brosius)</li>
+ <li>New detector to find variables that mask class level
+ fields (Dave Brosius)</li>
+ <li>New detector to find comparisons of values computed with
+ bitwise operators that always yield the same result (Tom Truscott)
+ </li>
+ <li>New detector to find unsafe getClass().getResource() calls
+ (Bill Pugh)</li>
+ <li>New detector to find GUI changes not in GUI thread but in
+ static main (Bill Pugh)</li>
+ <li>New detector to find calls to Collection.toArray() with
+ zero-length array argument; it is more efficient to pass an array
+ the size of the collection, which can be populated and returned as
+ the result (Dave Brosius) <!-- Analysis improvements -->
+ </li>
+ <li>Better suppression of false warnings in various detectors
+ (Bill Pugh, David Hovemeyer)</li>
+ <li>Enhancement to ReadReturnShouldBeChecked detector for
+ skip() (Dave Brosius)</li>
+ <li>Enhancement to DumbMethods detector (Dave Brosius)</li>
+ <li>Open stream detector does not report wrappers of streams
+ passed as method parameters (David Hovemeyer) <!-- Feature enhancements -->
+ </li>
+ <li>Cancel confirmation dialog in Swing GUI (Pete Angstadt)</li>
+ <li>Better relative path saving in Project file (Dave Brosius)
+ </li>
+ <li>Detector Priority in GUI is now saved in prefs file (Dave
+ Brosius)</li>
+ <li>Controls in GUI to reorder source and classpath entries,
+ and ability to flip between Project details and bugs pages (Dave
+ Brosius)</li>
+ <li>In Swing GUI, analysis error dialog supports "Select All"
+ and "Copy" operations for easy generation of error reports (Dave
+ Brosius)</li>
+ <li>Complete translation of bug descriptions and messages into
+ Japanese (Hanai Shisei) <!-- Bug fixes -->
+ </li>
+ <li>Fixed bug in DroppedException detector (Dave Brosius) <!-- Development stuff -->
+ </li>
+ <li>The source distribution defaults to using JDK 1.5 javac to
+ compile, but support for compiling with JSR-14 prototype is still
+ supported</li>
+ </ul>
+
+ <p>Changes since version 0.8.1:</p>
+ <ul>
+ <li>Fixed a critical ClassCastException bug (triggered if the
+ -workHard option was used, and an exception type was merged with
+ an array type during type inference)</li>
+ </ul>
+
+ <p>Changes since version 0.8.0:</p>
+ <ul>
+ <li>Disabled SwitchFallthrough detector to work around
+ NullPointerExceptions</li>
+ <li>Added some additional false positive suppression
+ heuristics</li>
+ </ul>
+
+ <p>Also, two contributors to the 0.8.0 release were
+ inadvertently left out of the credits:</p>
+ <ul>
+ <li>Pete Angstadt fixed several problems in the Swing GUI</li>
+ <li>Francis Lalonde provided a task resource file for the
+ FindBugs Ant task</li>
+ </ul>
+
+ <p>Changes since version 0.7.4:</p>
+ <ul>
+ <li>New detector to look for uses of "+" operator to
+ concatenate String objects in a loop (Dave Brosius)</li>
+ <li>Reference comparison detector looks for places where the
+ argument passed to the equals(Object) method isn't the same type
+ as the receiver object</li>
+ <li>Better suppression of false warnings in many detectors</li>
+ <li>Many improvements to Eclipse plugin (Andrey Loskutov,
+ Peter Friese)</li>
+ <li>Fixed problem with building Eclipse plugin on Windows
+ (Thomas Klaeger)</li>
+ <li>Open stream detector looks for unclosed PreparedStatement
+ objects (Thomas Klaeger, Rohan Lloyd)</li>
+ <li>Fix for open stream detector: it wasn't detecting close()
+ methods called through an invokeinterface instruction (Thomas
+ Klaeger)</li>
+ <li>Refactoring of visitor classes to enforce use of accessors
+ for visited class features (Brian Goetz)</li>
+ </ul>
+
+ <p>Changes since version 0.7.3:</p>
+ <ul>
+ <li>Experimental modification of open stream detector to look
+ for non-escaping JDBC resources (connections and statements) that
+ aren't closed on all paths out of method</li>
+ <li>Eclipse plugin fixed so it compiles and runs on Eclipse
+ 2.1.x (Peter Friese)</li>
+ <li>Option to Swing GUI and command line to generate project
+ file using relative paths for archives, source directories, and
+ aux classpath entries (Dave Brosius)</li>
+ <li>Improvements to findbugs.bat script for launching FindBugs
+ on Windows (Dave Brosius)</li>
+ <li>Updated Japanese message translations (Hiroshi Okugawa)</li>
+ <li>Uncalled private methods are now reported as low priority,
+ unless they have the same name as another method in the class
+ (which is more likely to indicate an actual bug)</li>
+ <li>Added some missing data in the bug messages XML files</li>
+ <li>Fixed some problems building from source on Windows
+ systems</li>
+ <li>Various minor bug fixes</li>
+ </ul>
+
+ <p>Changes since version 0.7.2:</p>
+ <ul>
+ <li>Enhanced Eclipse plugin, which displays the detailed bug
+ description in a view (Phil Crosby)</li>
+ <li>Various tweaks to existing detectors to reduce false
+ warnings</li>
+ <li>New command line option <code> -workHard </code> enables
+ pruning of infeasible or unlikely exception edges, which results
+ in better accuracy in the open stream detector, at the expense of
+ a 30%-100% slowdown
+ </li>
+ <li>New website and HTML documentation design</li>
+ <li>Documentation includes an HTML document with descriptions
+ of all bug patterns reported by FindBugs</li>
+ <li>Web page has a link to a <a
+ href="http://www.simeji.com/findbugs/doc/manual_ja/index.html">Japanese
+ translation</a> of the FindBugs manual, contributed by Hiroshi
+ Okugawa
+ </li>
+ <li>Changed the Inconsistent Synchronization detector so that
+ fields synchronized 50% of the time (or more) are reported as
+ medium priority bugs (previously they were reported as low)</li>
+ <li>New detector to find code that catches
+ IllegalMonitorStateException</li>
+ <li>New detector to find private methods that are never called
+ </li>
+ <li>New detector to find suspicious uses of
+ non-short-circuiting boolean operators ( <code> & </code> and
+ <code> | </code> , rather than <code> && </code> and <code>
+ || </code> )
+ </li>
+ </ul>
+
+ <p>Changes since version 0.7.1:</p>
+ <ul>
+ <li>Incorporated patched version of BCEL, which allows classes
+ compiled with JDK 1.5.0 beta to be analyzed</li>
+ <li>Fixed some bugs related to lookups of array classes</li>
+ <li>Fixed bug that prevented GUI from loading XML result files
+ when running under JDK 1.5.0 beta</li>
+ <li>Added new experimental bug detector, LazyInit, which looks
+ for potentially buggy lazy initializations of static fields</li>
+ <li>Because of long filenames, switched to distributing the
+ source archive as a zip file rather than a tar file</li>
+ <li>The 0.7.1 source tarfile was botched - 0.7.2 has a valid
+ source archive</li>
+ <li>Fixed some problems in the Ant build script</li>
+ <li>Fixed NullPointerException when checking Class-Path
+ attribute for Jar files without manifests</li>
+ <li>Generate version numbers for the core and UI Eclipse
+ plugins using the Version class; all version numbers are now in a
+ common location</li>
+ </ul>
+
+ <p>Changes since version 0.7.0:</p>
+ <ul>
+ <li>Eclipse plugin (contributed by Peter Friese)</li>
+ <li>Source package structure rearranged: all source (other
+ than Eclipse plugin UI) is in the edu.umd.cs.findbugs package, or
+ a subpackage</li>
+ <li>Class-Path attributes of manifests of analyzed jar files
+ are used to set the aux classpath automatically (Peter D. Stout)</li>
+ <li>GUI starts in directory specified by user.home property
+ (Peter D. Stout)</li>
+ <li>Added -project option to GUI (Mikko T.)</li>
+ <li>Added -look:{plastic,gtk,native} option to GUI, for
+ setting look and feel (Mikko T.)</li>
+ <li>Fixed DataflowAnalysisException in inconsistent
+ synchronization detector</li>
+ <li>Ant task supports failOnError parameter (Rohan Lloyd)</li>
+ <li>Serializable class warnings are downgraded to low priority
+ for GUI classes</li>
+ <li>MWN detector will only report calls to wait(), notify(),
+ and notifyAll() methods that have the correct signature</li>
+ <li>FindBugs works with latest CVS version of BCEL</li>
+ <li>Zip and Jar files may be added to the source path</li>
+ <li>The GUI will automatically find source files residing in
+ analyzed Zip or Jar files</li>
+ </ul>
+
+ <p>Note that the version number jumped from 0.6.6 to 0.6.9;
+ there were no 0.6.7 or 0.6.8 releases.</p>
+ <p>Changes since version 0.6.9:</p>
+ <ul>
+ <li>Added -conserveSpace option to reduce memory use at the
+ expense of analysis precision</li>
+ <li>Bug fixes in findbugs.bat script: JAVA_HOME handling,
+ autodetection of FINDBUGS_HOME, missing output with -textui</li>
+ <li>Fixed NullPointerException when a missing class is
+ encountered</li>
+ </ul>
+
+ <p>Changes since version 0.6.6:</p>
+ <ul>
+ <li>The null pointer dereference detector is more powerful</li>
+ <li>Significantly improved heuristics and bug fixes in
+ inconsistent synchronization detector</li>
+ <li>Improved heuristics in open stream and dropped exception
+ detectors; fewer false positives should be reported</li>
+ <li>Save HTML summary in XML results files, rather than
+ recomputing; this makes loading results in GUI much faster</li>
+ <li>Report at most one String comparison using == or != per
+ method</li>
+ <li>The findbugs.bat script on Windows autodetects
+ FINDBUGS_HOME, and doesn't open a DOS window when launching the
+ GUI (contributed by TJSB)</li>
+ <li>Emacs reporting format (contributed by David Li)</li>
+ <li>Various bug fixes</li>
+ </ul>
+
+ <p>Changes since 0.6.5:</p>
+ <ul>
+ <li>Rewritten inconsistent synchronization detector; accuracy
+ is significantly improved, and bug reports are prioritized</li>
+ <li>New detector to find self assignment (x=x) of local
+ variables (suggested by Jeff Martin)</li>
+ <li>New detector to find calls to wait(), notify(), and
+ notifyAll() on an object which is not obviously locked</li>
+ <li>Open stream detector now reports Readers and Writers</li>
+ <li>Fixed bug in finalizer idioms detector which caused
+ spurious warnings about failure to call super.finalize() (reported
+ by Jim Menard)</li>
+ <li>Fixed bug where output stream was not closed using non-XML
+ output (reported by Sigiswald Madou)</li>
+ <li>Fixed corrupted HTML bug detail message (reported by
+ Trevor Harmon)</li>
+ </ul>
+
+ <p>Changes since version 0.6.4:</p>
+ <ul>
+ <li>For redundant comparison of reference values, fixed false
+ positives resulting from duplication of code in finally blocks</li>
+ <li>Fixed false positives resulting from wrapped byte array
+ streams left open</li>
+ <li>Fixed bug in Ant task preventing output file from working
+ properly if a relative path was used</li>
+ </ul>
+
+ <p>Changes since version 0.6.3:</p>
+ <ul>
+ <li>Fixed bug in Ant task where output would be corrupted, and
+ added a <code> timeout </code> attribute
+ </li>
+ <li>Added -outputFile option to text UI, for explicitly
+ specifying an output file</li>
+ <li>GUI has a summary window, for statistics about overall bug
+ densities (contributed by Mike Fagan)</li>
+ <li>Find redundant comparisons of reference values</li>
+ <li>More accurate detection of Strings compared with == and !=
+ operators</li>
+ <li>Detection of other reference types which should generally
+ not be compared with == and != operators; Boolean, Integer, etc.</li>
+ <li>Find non-transient non-serializable instance fields in
+ Serializable classes</li>
+ <li>Source code may be compiled with latest early access
+ generics-enabled javac (version 2.2)</li>
+ </ul>
+
+ <p>Changes since version 0.6.2:</p>
+ <ul>
+ <li>GUI supports filtering bugs by priority</li>
+ <li>Ant task rewritten; supports all functionality offered by
+ Text UI (contributed by Mike Fagan)</li>
+ <li>Ant task is fully documented in the manual</li>
+ <li>Classes in nested archives are analyzed; this allows full
+ support for analyzing .ear and .war files (contributed by Mike
+ Fagan)</li>
+ <li>DepthFirstSearch changed to use non-recursive
+ implementation; this should fix the StackOverflowErrors that
+ several users reported</li>
+ <li>Various minor bugfixes and improvements</li>
+ </ul>
+
+ <p>Changes since version 0.6.1:</p>
+ <ul>
+ <li>New detector to look for useless control flow (suggested
+ by Richard P. King and Mike Fagan)</li>
+ <li>Look for places where return value of
+ java.io.File.createNewFile() is ignored (suggested by Richard P.
+ King)</li>
+ <li>Fixed bug in resolution of source files (only the first
+ source directory was searched)</li>
+ <li>Fixed a NullPointerException in the bytecode pattern
+ matching code</li>
+ <li>Ant task supports project files (contributed by Mike
+ Fagan)</li>
+ <li>Unix findbugs script honors the <code> JAVA_HOME </code>
+ environment variable (contributed by Pedro Morais)
+ </li>
+ <li>Allow .war and .ear files to be analyzed</li>
+ </ul>
+
+ <p>Changes since version 0.6.0:</p>
+ <ul>
+ <li>New bug pattern detector which looks for places where a
+ null pointer might be dereferenced</li>
+ <li>New bug pattern detector which looks for IO streams that
+ are opened, do not escape the method, and are not closed on all
+ paths out of the method</li>
+ <li>New bug pattern detector to find methods that can return
+ null instead of a zero-length array</li>
+ <li>New bug pattern detector to find places where the == or !=
+ operators are used to compare String objects</li>
+ <li>Command line interface can save bugs as XML</li>
+ <li>GUI can save bugs to and load bugs from XML</li>
+ <li>An "Annotations" window in the GUI allows the user to add
+ textual annotations to bug reports; these annotations are
+ preserved when bugs are saved as XML</li>
+ <li>In this release, the Japanese bug summary translations by
+ Germano Leichsenring are really included (they were inadvertently
+ omitted in the previous release)</li>
+ <li>Completely rewrote the control flow graph builder,
+ hopefully for the last time</li>
+ <li>Simplified implementation of control flow graphs, which
+ should reduce memory use and possibly improve performance</li>
+ <li>Improvements to command line interface (list bug
+ priorities, filter by priority, specify aux classpath, specify
+ project to analyze)</li>
+ <li>Various bug fixes and enhancements</li>
+ </ul>
+
+ <p>Changes since version 0.5.4</p>
+ <ul>
+ <li>Added an <a href="http://ant.apache.org/">Ant</a> task for
+ FindBugs, contributed by Mike Fagan.
+ </li>
+ <li>Added a GUI dialog which allows individual bug pattern
+ detectors to be enabled or disabled. Disabling certain slow
+ detectors can greatly speed up analysis of large programs, at the
+ expense of reducing the number of potential bugs found.</li>
+ <li>Added a new detector for finding improperly ignored return
+ values for methods such as <code> String.trim() </code> .
+ Suggested by Andreas Mandel.
+ </li>
+ <li>Japanese translations of the bug summaries, contributed by
+ Germano Leichsenring.</li>
+ <li>Filtering of results is supported in command line
+ interface. See the <a href="manual/index.html">FindBugs manual</a>
+ for details.
+ </li>
+ <li>Added "byte code patterns", a general pattern matching
+ infrastructure for bytecode instructions. This feature
+ significantly reduces the complexity of implementing new bug
+ pattern detectors.</li>
+ <li>Enabled a new general dataflow analysis to track values in
+ methods.</li>
+ <li>Switched to new control-flow graph builder implementation.
+ </li>
+ </ul>
+
+ <p>Changes since version 0.5.3</p>
+ <ul>
+ <li>Fixed a bug in the script used to launch FindBugs on
+ Windows platforms.</li>
+ <li>Fixed crashes when analyzing class files without source
+ line information.</li>
+ <li>All major errors are reported using an error dialog; file
+ not found errors are more informative.</li>
+ <li>Minor GUI improvements.</li>
+ </ul>
+
+ <p>Changes since version 0.5.2</p>
+ <ul>
+ <li>All of the source code and related files are in a single
+ directory tree.</li>
+ <li>Updated some of the detectors to produce source line
+ information.</li>
+ <li><a href="http://ant.apache.org/">Ant</a> build script and
+ several GUI enhancements and fixes contributed by Mike Fagan.</li>
+ <li>Converted to use a <a href="AddingDetectors.txt">plugin
+ architecture</a> for loading bug detectors.
+ </li>
+ <li>Eliminated generics-related compiler warnings.</li>
+ <li>More complete documentation has been added.</li>
+ </ul>
+
+ <p>Changes since version 0.5.1:</p>
+ <ul>
+ <li>Fixed a large number of bugs in the BCEL Repository and
+ FindBugs's use of the Repository. With these changes,
+ FindBugs should <em>never</em> crash or otherwise misbehave
+ because of Repository lookup failures. Because of these
+ changes, you must use a modified version of <code> bcel.jar
+ </code> with FindBugs. This jar file is included in the FindBugs
+ 0.5.2 binary release. A complete patch containing the <a
+ href="http://faculty.ycp.edu/~dhovemey/bcel-30-April-2003.patch">modifications
+ against the BCEL CVS main branch as of April 30, 2003</a> is also
+ available.
+ </li>
+ <li>Implemented the "auxiliary classpath entry list".
+ Aux classpath entries can be added to a project to provide classes
+ that are referenced by the analyzed application, but should not
+ themselves be analyzed. Having all referenced classes
+ available allows FindBugs to produce more accurate results.</li>
+ </ul>
+
+ <p>Changes since version 0.5.0:</p>
+ <ul>
+ <li>Many user interface bugs have been fixed.</li>
+ <li>Upgraded to a recent CVS version of BCEL, with some bug
+ fixes. This should prevent FindBugs from crashing when there
+ is a failure to find a class on the classpath.</li>
+ <li>Added support for Plastic look and feel from <a
+ href="http://www.jgoodies.com/">jgoodies.com</a>.
+ </li>
+ <li>Major overhaul of infrastructure for doing dataflow
+ analysis.</li>
+ </ul>
+<hr> <p>
+<script language="JavaScript" type="text/javascript">
+<!---//hide script from old browsers
+document.write( "Last updated "+ document.lastModified + "." );
+//end hiding contents --->
+</script>
+<p> Send comments to <a class="sidebar" href="mailto:findbugs@cs.umd.edu">findbugs@cs.umd.edu</a>
+<p>
+<A href="http://sourceforge.net"><IMG src="http://sourceforge.net/sflogo.php?group_id=96405&type=5" width="210" height="62" border="0" alt="SourceForge.net Logo" /></A>
+
+ </td>
+
+ </tr>
+ </table>
+
+</body>
+
+</html>
diff --git a/tools/findbugs-1.3.9/doc/FAQ.html b/tools/findbugs/doc/FAQ.html
similarity index 79%
rename from tools/findbugs-1.3.9/doc/FAQ.html
rename to tools/findbugs/doc/FAQ.html
index eeec743..d83b7ee 100644
--- a/tools/findbugs-1.3.9/doc/FAQ.html
+++ b/tools/findbugs/doc/FAQ.html
@@ -17,6 +17,7 @@
<tr><td> </td></tr>
<tr><td><b>Docs and Info</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="findbugs2.html">FindBugs 2.0</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
@@ -98,9 +99,9 @@
<pre>
java.lang.VerifyError: Cannot inherit from final class
- at java.lang.ClassLoader.defineClass0(Native Method)
- at java.lang.ClassLoader.defineClass(ClassLoader.java:537)
- ...
+ at java.lang.ClassLoader.defineClass0(Native Method)
+ at java.lang.ClassLoader.defineClass(ClassLoader.java:537)
+ ...
</pre>
<p> The problem here is that the wrong version of the
@@ -147,21 +148,6 @@
You can increase this using the <code>-maxHeap <i>n</i></code> option,
where <i>n</i> is the number of megabytes of heap space to allocate.
-<p>If you are using the GUI version of FindBugs, and have many classes to analyze,
-a good amount of memory is needed to generate the summary report. If the process
-appears to be hanging after all classes have been parsed, but before the final
-details have been shown, you can turn this summary report off, by specifying<br/>
-<code>-jvmArgs "-Dfindbugs.noSummary=true"</code><br/> on the command line.</p>
-
-<p> Version 0.6.9 of FindBugs introduced new types of analysis that
-improve precision, but require more memory and time to perform.
-In version 0.7.0 and later, you can disable these analyses by
-adding the <code>-conserveSpace</code> option to the FindBugs
-command line. E.g.:
-
-<pre>
- findbugs -textui -conserveSpace -xml -project myProject.fb -outputFile out.xml
-</pre>
<h2><a name="q4">Q4: What is the "auxiliary classpath"? Why should I specify it?</a></h2>
@@ -208,8 +194,8 @@
<p> The reason for this problem is that the Eclipse
plugin distributed with FindBugs
-does not work with 2.x versions of Eclipse.
-Please use Eclipse version 3.3 (June 2007) or newer.
+does not work with older 3.x versions of Eclipse.
+Please use Eclipse version 3.6 (June 2010) or newer.
<h2><a name="q6">Q6: I'm getting a lot of false "OS" and "ODR" warnings</a></h2>
@@ -228,55 +214,30 @@
<h2><a name="q7">Q7: The Eclipse plugin loads, but doesn't work correctly</a></h2>
-<p> In versions 0.0.6 and 0.0.7 of the FindBugs Eclipse plugin,
-which correspond to the 0.7.4 and 0.8.0 releases,
-bugs in the experimental SwitchFallthrough detector can prevent
-FindBugs from running properly within Eclipse.
+<p> Make sure the Java code you trying to analyze is built properly and has no
+classpath or compile errors.
-<p> To work around the problem, make sure that SwitchFallthrough
-is disabled in the FindBugs Properties of your project.
-Right click on your project, and choose "Properties".
-In the Properties dialog, choose "FindBugs",
-and disable the checkbox next to SwitchFallthrough.
+<p> Make sure the project and workspace FindBugs settings are valid - in doubt, revert them to defaults.
-<p> Another common problem with the Eclipse plugin is that
-the FindBugs warnings do not appear in the "Problems" view.
-Make sure that FindBugs warnings are enabled in the filters
-for this view. The Filters menu is accessible by
-clicking on the icon that looks like this:
-<blockquote>
-<img src="eclipse-filters-icon.png">
-</blockquote>
-Make sure the "FindBugs Problem" checkbox is enabled.
+<p> Make sure the Error log view does not show errors.
<h2><a name="q8">Q8: Where is the Maven plugin for FindBugs?</a></h2>
<p>
The <a href="http://maven.apache.org/">Maven</a> Plugin for FindBugs
-may be found <a href="http://maven-plugins.sourceforge.net/maven-findbugs-plugin/index.html">here</a>.
+may be found <a href="http://mojo.codehaus.org/findbugs-maven-plugin/">here</a>.
Please note that the Maven plugin is not maintained by the FindBugs developers,
so we can't answer questions about it.
</p>
<h2><a name="q9">Q9: Where is the NetBeans plugin for FindBugs?</a></h2>
-<p>
-The <a href="http://www.netbeans.org/">NetBeans</a> Plugin for FindBugs
-may be obtained by pointing UpdateCenter to
-<a href="https://sqe.dev.java.net/updatecenters/nbheaven-updatecenter.xml">
-https://sqe.dev.java.net/updatecenters/nbheaven-updatecenter.xml</a>.
-
-(An older human-readable page is <a href="http://fnleisurehacker.fn.funpic.de/wordpress/?page_id=102">here</a>.)
-
-This distribution apparently bundles the detectors from
-fb-contrib,
-which are not controlled by the FindBugs project.
-The lead FindBugs team does not vouch for the relevance, accuracy or wisdom of the warnings
- generated by any third-party plugin.
-and encourages all FindBugs users to carefully evaluate 3rd party plugins for FindBugs.
-</p>
-<p>
-Again, please note that the NetBeans plugin is not maintained by the FindBugs developers,
+<p>We recommend <a href="http://kenai.com/projects/sqe/pages/Home">SQE: Software Quality Environment</a>
+which bundles FindBugs, PMD and CheckStyle. Use the following
+update site:
+<a href="http://deadlock.netbeans.org/hudson/job/sqe/lastStableBuild/artifact/build/full-sqe-updatecenter/updates.xml
+">http://deadlock.netbeans.org/hudson/job/sqe/lastStableBuild/artifact/build/full-sqe-updatecenter/updates.xml</a>
+<p>Pease note that the SQE plugin is not maintained by the FindBugs developers,
so we can't answer questions about it.
</p>
diff --git a/tools/findbugs-1.3.9/doc/FilterFile.txt b/tools/findbugs/doc/FilterFile.txt
similarity index 100%
rename from tools/findbugs-1.3.9/doc/FilterFile.txt
rename to tools/findbugs/doc/FilterFile.txt
diff --git a/tools/findbugs-1.3.9/doc/bugDescriptions.html b/tools/findbugs/doc/allBugDescriptions.html
similarity index 79%
rename from tools/findbugs-1.3.9/doc/bugDescriptions.html
rename to tools/findbugs/doc/allBugDescriptions.html
index 9e4edf4..2ee84b3 100644
--- a/tools/findbugs-1.3.9/doc/bugDescriptions.html
+++ b/tools/findbugs/doc/allBugDescriptions.html
@@ -1,4 +1,5 @@
-<html><head><title>FindBugs Bug Descriptions</title>
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
+<html><head><title>FindBugs Bug Descriptions (Unabridged)</title>
<link rel="stylesheet" type="text/css" href="findbugs.css"/>
<link rel="shortcut icon" href="favicon.ico" type="image/x-icon"/>
</head><body>
@@ -12,6 +13,7 @@
<tr><td> </td></tr>
<tr><td><b>Docs and Info</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="findbugs2.html">FindBugs 2.0</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
@@ -47,43 +49,46 @@
</table>
</td>
<td align="left" valign="top">
-<h1>FindBugs Bug Descriptions</h1>
-<p>This document lists the standard bug patterns reported by
-<a href="http://findbugs.sourceforge.net">FindBugs</a> version 1.3.9.</p>
+<h1>FindBugs Bug Descriptions (Unabridged)</h1>
+<p>This document lists all of the bug patterns reported by the
+latest development version of
+<a href="http://findbugs.sourceforge.net">FindBugs</a>. Note that this may include
+bug patterns not available in any released version of FindBugs,
+as well as bug patterns that are not enabled by default.
<h2>Summary</h2>
<table width="100%">
<tr bgcolor="#b9b9fe"><th>Description</th><th>Category</th></tr>
<tr bgcolor="#eeeeee"><td><a href="#AM_CREATES_EMPTY_JAR_FILE_ENTRY">AM: Creates an empty jar file entry</a></td><td>Bad practice</td></tr>
<tr bgcolor="#ffffff"><td><a href="#AM_CREATES_EMPTY_ZIP_FILE_ENTRY">AM: Creates an empty zip file entry</a></td><td>Bad practice</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS">BC: Equals method should not assume anything about the type of its argument</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DMI_RANDOM_USED_ONLY_ONCE">BC: Random object created and used only once</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#BIT_SIGNED_CHECK">BIT: Check for sign of bitwise operation</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#CN_IDIOM">CN: Class implements Cloneable but does not define or use clone method</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#CN_IDIOM_NO_SUPER_CALL">CN: clone method does not call super.clone()</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE">CN: Class defines clone() but doesn't implement Cloneable</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#CO_ABSTRACT_SELF">Co: Abstract class defines covariant compareTo() method</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#CO_SELF_NO_OBJECT">Co: Covariant compareTo() method defined</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DE_MIGHT_DROP">DE: Method might drop exception</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DE_MIGHT_IGNORE">DE: Method might ignore exception</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_USING_REMOVEALL_TO_CLEAR_COLLECTION">DMI: Don't use removeAll to clear a collection</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED">DP: Classloaders should only be created inside doPrivileged block</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DP_DO_INSIDE_DO_PRIVILEGED">DP: Method invoked that should be only be invoked inside a doPrivileged block</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DM_EXIT">Dm: Method invokes System.exit(...)</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DM_RUN_FINALIZERS_ON_EXIT">Dm: Method invokes dangerous method runFinalizersOnExit</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#ES_COMPARING_PARAMETER_STRING_WITH_EQ">ES: Comparison of String parameter using == or !=</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#ES_COMPARING_STRINGS_WITH_EQ">ES: Comparison of String objects using == or !=</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EQ_ABSTRACT_SELF">Eq: Abstract class defines covariant equals() method</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS">Eq: Equals checks for noncompatible operand</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EQ_COMPARETO_USE_OBJECT_EQUALS">Eq: Class defines compareTo(...) and uses Object.equals()</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#EQ_GETCLASS_AND_CLASS_CONSTANT">Eq: equals method fails for subtypes</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EQ_SELF_NO_OBJECT">Eq: Covariant equals() method defined</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#FI_EMPTY">FI: Empty finalizer should be deleted</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#FI_EXPLICIT_INVOCATION">FI: Explicit invocation of finalizer</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#FI_FINALIZER_NULLS_FIELDS">FI: Finalizer nulls fields</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#FI_FINALIZER_ONLY_NULLS_FIELDS">FI: Finalizer only nulls fields</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#FI_MISSING_SUPER_CALL">FI: Finalizer does not call superclass finalizer</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#FI_NULLIFY_SUPER">FI: Finalizer nullifies superclass finalizer</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#FI_USELESS">FI: Finalizer does nothing but call superclass finalizer</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#BIT_SIGNED_CHECK">BIT: Check for sign of bitwise operation</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#CN_IDIOM">CN: Class implements Cloneable but does not define or use clone method</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#CN_IDIOM_NO_SUPER_CALL">CN: clone method does not call super.clone()</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE">CN: Class defines clone() but doesn't implement Cloneable</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#CO_ABSTRACT_SELF">Co: Abstract class defines covariant compareTo() method</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#CO_SELF_NO_OBJECT">Co: Covariant compareTo() method defined</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DE_MIGHT_DROP">DE: Method might drop exception</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DE_MIGHT_IGNORE">DE: Method might ignore exception</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS">DMI: Adding elements of an entry set may fail due to reuse of Entry objects</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DMI_RANDOM_USED_ONLY_ONCE">DMI: Random object created and used only once</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DMI_USING_REMOVEALL_TO_CLEAR_COLLECTION">DMI: Don't use removeAll to clear a collection</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DM_EXIT">Dm: Method invokes System.exit(...)</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DM_RUN_FINALIZERS_ON_EXIT">Dm: Method invokes dangerous method runFinalizersOnExit</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#ES_COMPARING_PARAMETER_STRING_WITH_EQ">ES: Comparison of String parameter using == or !=</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#ES_COMPARING_STRINGS_WITH_EQ">ES: Comparison of String objects using == or !=</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#EQ_ABSTRACT_SELF">Eq: Abstract class defines covariant equals() method</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS">Eq: Equals checks for incompatible operand</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#EQ_COMPARETO_USE_OBJECT_EQUALS">Eq: Class defines compareTo(...) and uses Object.equals()</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#EQ_GETCLASS_AND_CLASS_CONSTANT">Eq: equals method fails for subtypes</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#EQ_SELF_NO_OBJECT">Eq: Covariant equals() method defined</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#FI_EMPTY">FI: Empty finalizer should be deleted</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#FI_EXPLICIT_INVOCATION">FI: Explicit invocation of finalizer</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#FI_FINALIZER_NULLS_FIELDS">FI: Finalizer nulls fields</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#FI_FINALIZER_ONLY_NULLS_FIELDS">FI: Finalizer only nulls fields</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#FI_MISSING_SUPER_CALL">FI: Finalizer does not call superclass finalizer</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#FI_NULLIFY_SUPER">FI: Finalizer nullifies superclass finalizer</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#FI_USELESS">FI: Finalizer does nothing but call superclass finalizer</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#VA_FORMAT_STRING_USES_NEWLINE">FS: Format string should use %n rather than \n</a></td><td>Bad practice</td></tr>
<tr bgcolor="#ffffff"><td><a href="#GC_UNCHECKED_TYPE_IN_GENERIC_CALL">GC: Unchecked type in generic call</a></td><td>Bad practice</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#HE_EQUALS_NO_HASHCODE">HE: Class defines equals() but not hashCode()</a></td><td>Bad practice</td></tr>
<tr bgcolor="#ffffff"><td><a href="#HE_EQUALS_USE_HASHCODE">HE: Class defines equals() and uses Object.hashCode()</a></td><td>Bad practice</td></tr>
@@ -115,10 +120,12 @@
<tr bgcolor="#ffffff"><td><a href="#ODR_OPEN_DATABASE_RESOURCE_EXCEPTION_PATH">ODR: Method may fail to close database resource on exception</a></td><td>Bad practice</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#OS_OPEN_STREAM">OS: Method may fail to close stream</a></td><td>Bad practice</td></tr>
<tr bgcolor="#ffffff"><td><a href="#OS_OPEN_STREAM_EXCEPTION_PATH">OS: Method may fail to close stream on exception</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RC_REF_COMPARISON_BAD_PRACTICE">RC: Suspicious reference comparison to constant</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN">RC: Suspicious reference comparison of Boolean values</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RR_NOT_CHECKED">RR: Method ignores results of InputStream.read()</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SR_NOT_CHECKED">RR: Method ignores results of InputStream.skip()</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#PZ_DONT_REUSE_ENTRY_OBJECTS_IN_ITERATORS">PZ: Don't reuse entry objects in iterators</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RC_REF_COMPARISON_BAD_PRACTICE">RC: Suspicious reference comparison to constant</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN">RC: Suspicious reference comparison of Boolean values</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RR_NOT_CHECKED">RR: Method ignores results of InputStream.read()</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#SR_NOT_CHECKED">RR: Method ignores results of InputStream.skip()</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RV_NEGATING_RESULT_OF_COMPARETO">RV: Negating the result of compareTo()/compare()</a></td><td>Bad practice</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE">RV: Method ignores exceptional return value</a></td><td>Bad practice</td></tr>
<tr bgcolor="#ffffff"><td><a href="#SI_INSTANCE_BEFORE_FINALS_ASSIGNED">SI: Static initializer creates instance before all static final fields assigned</a></td><td>Bad practice</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#SW_SWING_METHODS_INVOKED_IN_SWING_THREAD">SW: Certain swing methods needs to be invoked in Swing thread</a></td><td>Bad practice</td></tr>
@@ -147,13 +154,17 @@
<tr bgcolor="#ffffff"><td><a href="#BIT_IOR_OF_SIGNED_BYTE">BIT: Bitwise OR of signed byte value</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#BIT_SIGNED_CHECK_HIGH_BIT">BIT: Check for sign of bitwise operation</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#BOA_BADLY_OVERRIDDEN_ADAPTER">BOA: Class overrides a method implemented in super class Adapter wrongly</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#ICAST_BAD_SHIFT_AMOUNT">BSHIFT: 32 bit int shifted by an amount not in the range 0..31</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#ICAST_BAD_SHIFT_AMOUNT">BSHIFT: 32 bit int shifted by an amount not in the range -31..31</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#BX_UNBOXED_AND_COERCED_FOR_TERNARY_OPERATOR">Bx: Primitive value is unboxed and coerced for ternary operator</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DLS_DEAD_STORE_OF_CLASS_LITERAL">DLS: Dead store of class literal</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DLS_OVERWRITTEN_INCREMENT">DLS: Overwritten increment</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#CO_COMPARETO_RESULTS_MIN_VALUE">Co: compareTo()/compare() returns Integer.MIN_VALUE</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DLS_DEAD_STORE_OF_CLASS_LITERAL">DLS: Dead store of class literal</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DLS_OVERWRITTEN_INCREMENT">DLS: Overwritten increment</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DMI_ARGUMENTS_WRONG_ORDER">DMI: Reversed method arguments</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#DMI_BAD_MONTH">DMI: Bad constant value for month</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DMI_CALLING_NEXT_FROM_HASNEXT">DMI: hasNext method invokes next</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVES">DMI: Collections should not contain themselves</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DMI_BIGDECIMAL_CONSTRUCTED_FROM_DOUBLE">DMI: BigDecimal constructed from double that isn't represented precisely</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DMI_CALLING_NEXT_FROM_HASNEXT">DMI: hasNext method invokes next</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVES">DMI: Collections should not contain themselves</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DMI_DOH">DMI: D'oh! A nonsensical method invocation</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#DMI_INVOKING_HASHCODE_ON_ARRAY">DMI: Invocation of hashCode on an array</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#DMI_LONG_BITS_TO_DOUBLE_INVOKED_ON_INT">DMI: Double.longBitsToDouble invoked on an int</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#DMI_VACUOUS_SELF_COLLECTION_CALL">DMI: Vacuous call to collections</a></td><td>Correctness</td></tr>
@@ -164,7 +175,7 @@
<tr bgcolor="#eeeeee"><td><a href="#EC_ARRAY_AND_NONARRAY">EC: equals() used to compare array and nonarray</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#EC_BAD_ARRAY_COMPARE">EC: Invocation of equals() on an array, which is equivalent to ==</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#EC_INCOMPATIBLE_ARRAY_COMPARE">EC: equals(...) used to compare incompatible arrays</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EC_NULL_ARG">EC: Call to equals() with null argument</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#EC_NULL_ARG">EC: Call to equals(null)</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#EC_UNRELATED_CLASS_AND_INTERFACE">EC: Call to equals() comparing unrelated class and interface</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#EC_UNRELATED_INTERFACES">EC: Call to equals() comparing different interface types</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#EC_UNRELATED_TYPES">EC: Call to equals() comparing different types</a></td><td>Correctness</td></tr>
@@ -188,18 +199,20 @@
<tr bgcolor="#eeeeee"><td><a href="#GC_UNRELATED_TYPES">GC: No relationship between generic parameter and method argument</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS">HE: Signature declares use of unhashable class in hashed construct</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#HE_USE_OF_UNHASHABLE_CLASS">HE: Use of class without a hashCode() method in a hashed data structure</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL">ICAST: integral value cast to double and then passed to Math.ceil</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#ICAST_INT_CAST_TO_FLOAT_PASSED_TO_ROUND">ICAST: int value cast to float and then passed to Math.round</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IJU_ASSERT_METHOD_INVOKED_FROM_RUN_METHOD">IJU: JUnit assertion in run method will not be noticed by JUnit</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IJU_BAD_SUITE_METHOD">IJU: TestCase declares a bad suite method </a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IJU_NO_TESTS">IJU: TestCase has no tests</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IJU_SETUP_NO_SUPER">IJU: TestCase defines setUp that doesn't call super.setUp()</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IJU_SUITE_NOT_STATIC">IJU: TestCase implements a non-static suite method </a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IJU_TEARDOWN_NO_SUPER">IJU: TestCase defines tearDown that doesn't call super.tearDown()</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IL_CONTAINER_ADDED_TO_ITSELF">IL: A collection is added to itself</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IL_INFINITE_LOOP">IL: An apparent infinite loop</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IL_INFINITE_RECURSIVE_LOOP">IL: An apparent infinite recursive loop</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IM_MULTIPLYING_RESULT_OF_IREM">IM: Integer multiply of result of integer remainder</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#ICAST_INT_2_LONG_AS_INSTANT">ICAST: int value converted to long and used as absolute time</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL">ICAST: integral value cast to double and then passed to Math.ceil</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#ICAST_INT_CAST_TO_FLOAT_PASSED_TO_ROUND">ICAST: int value cast to float and then passed to Math.round</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#IJU_ASSERT_METHOD_INVOKED_FROM_RUN_METHOD">IJU: JUnit assertion in run method will not be noticed by JUnit</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#IJU_BAD_SUITE_METHOD">IJU: TestCase declares a bad suite method </a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#IJU_NO_TESTS">IJU: TestCase has no tests</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#IJU_SETUP_NO_SUPER">IJU: TestCase defines setUp that doesn't call super.setUp()</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#IJU_SUITE_NOT_STATIC">IJU: TestCase implements a non-static suite method </a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#IJU_TEARDOWN_NO_SUPER">IJU: TestCase defines tearDown that doesn't call super.tearDown()</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#IL_CONTAINER_ADDED_TO_ITSELF">IL: A collection is added to itself</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#IL_INFINITE_LOOP">IL: An apparent infinite loop</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#IL_INFINITE_RECURSIVE_LOOP">IL: An apparent infinite recursive loop</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#IM_MULTIPLYING_RESULT_OF_IREM">IM: Integer multiply of result of integer remainder</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#INT_BAD_COMPARISON_WITH_INT_VALUE">INT: Bad comparison of int value with long constant</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE">INT: Bad comparison of nonnegative value with negative constant</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#INT_BAD_COMPARISON_WITH_SIGNED_BYTE">INT: Bad comparison of signed byte</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#IO_APPENDING_TO_OBJECT_OUTPUT_STREAM">IO: Doomed attempt to append to an object output stream</a></td><td>Correctness</td></tr>
@@ -212,38 +225,40 @@
<tr bgcolor="#eeeeee"><td><a href="#NP_CLOSING_NULL">NP: close() invoked on a value that is always null</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#NP_GUARANTEED_DEREF">NP: Null value is guaranteed to be dereferenced</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH">NP: Value is null and guaranteed to be dereferenced on exception path</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_NONNULL_PARAM_VIOLATION">NP: Method call passes null to a nonnull parameter </a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_NONNULL_RETURN_VIOLATION">NP: Method may return null, but is declared @NonNull</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_NULL_INSTANCEOF">NP: A known null value is checked to see if it is an instance of a type</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_NULL_ON_SOME_PATH">NP: Possible null pointer dereference</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_NULL_ON_SOME_PATH_EXCEPTION">NP: Possible null pointer dereference in method on exception path</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_NULL_PARAM_DEREF">NP: Method call passes null for nonnull parameter</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS">NP: Method call passes null for nonnull parameter</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_NULL_PARAM_DEREF_NONVIRTUAL">NP: Non-virtual method call passes null for nonnull parameter</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_STORE_INTO_NONNULL_FIELD">NP: Store of null value into field annotated NonNull</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_UNWRITTEN_FIELD">NP: Read of unwritten field</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NM_BAD_EQUAL">Nm: Class defines equal(Object); should it be equals(Object)?</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NM_LCASE_HASHCODE">Nm: Class defines hashcode(); should it be hashCode()?</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NM_LCASE_TOSTRING">Nm: Class defines tostring(); should it be toString()?</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NM_METHOD_CONSTRUCTOR_CONFUSION">Nm: Apparent method/constructor confusion</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NM_VERY_CONFUSING">Nm: Very confusing method names</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NM_WRONG_PACKAGE">Nm: Method doesn't override method in superclass due to wrong package for parameter</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#QBA_QUESTIONABLE_BOOLEAN_ASSIGNMENT">QBA: Method assigns boolean literal in boolean expression</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RC_REF_COMPARISON">RC: Suspicious reference comparison</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">RCN: Nullcheck of value previously dereferenced</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RE_BAD_SYNTAX_FOR_REGULAR_EXPRESSION">RE: Invalid syntax for regular expression</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RE_CANT_USE_FILE_SEPARATOR_AS_REGULAR_EXPRESSION">RE: File.separator used for regular expression</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RE_POSSIBLE_UNINTENDED_PATTERN">RE: "." used for regular expression</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RV_01_TO_INT">RV: Random value from 0 to 1 is coerced to the integer 0</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RV_ABSOLUTE_VALUE_OF_HASHCODE">RV: Bad attempt to compute absolute value of signed 32-bit hashcode </a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RV_ABSOLUTE_VALUE_OF_RANDOM_INT">RV: Bad attempt to compute absolute value of signed 32-bit random integer</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR">NP: Nonnull field is not initialized</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NP_NONNULL_PARAM_VIOLATION">NP: Method call passes null to a nonnull parameter </a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NP_NONNULL_RETURN_VIOLATION">NP: Method may return null, but is declared @NonNull</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NP_NULL_INSTANCEOF">NP: A known null value is checked to see if it is an instance of a type</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NP_NULL_ON_SOME_PATH">NP: Possible null pointer dereference</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NP_NULL_ON_SOME_PATH_EXCEPTION">NP: Possible null pointer dereference in method on exception path</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NP_NULL_PARAM_DEREF">NP: Method call passes null for nonnull parameter</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS">NP: Method call passes null for nonnull parameter</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NP_NULL_PARAM_DEREF_NONVIRTUAL">NP: Non-virtual method call passes null for nonnull parameter</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NP_STORE_INTO_NONNULL_FIELD">NP: Store of null value into field annotated NonNull</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NP_UNWRITTEN_FIELD">NP: Read of unwritten field</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NM_BAD_EQUAL">Nm: Class defines equal(Object); should it be equals(Object)?</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NM_LCASE_HASHCODE">Nm: Class defines hashcode(); should it be hashCode()?</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NM_LCASE_TOSTRING">Nm: Class defines tostring(); should it be toString()?</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NM_METHOD_CONSTRUCTOR_CONFUSION">Nm: Apparent method/constructor confusion</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NM_VERY_CONFUSING">Nm: Very confusing method names</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NM_WRONG_PACKAGE">Nm: Method doesn't override method in superclass due to wrong package for parameter</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#QBA_QUESTIONABLE_BOOLEAN_ASSIGNMENT">QBA: Method assigns boolean literal in boolean expression</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RC_REF_COMPARISON">RC: Suspicious reference comparison</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">RCN: Nullcheck of value previously dereferenced</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RE_BAD_SYNTAX_FOR_REGULAR_EXPRESSION">RE: Invalid syntax for regular expression</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#RE_CANT_USE_FILE_SEPARATOR_AS_REGULAR_EXPRESSION">RE: File.separator used for regular expression</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RE_POSSIBLE_UNINTENDED_PATTERN">RE: "." used for regular expression</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#RV_01_TO_INT">RV: Random value from 0 to 1 is coerced to the integer 0</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RV_ABSOLUTE_VALUE_OF_HASHCODE">RV: Bad attempt to compute absolute value of signed 32-bit hashcode </a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#RV_ABSOLUTE_VALUE_OF_RANDOM_INT">RV: Bad attempt to compute absolute value of signed random integer</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RV_CHECK_COMPARETO_FOR_SPECIFIC_RETURN_VALUE">RV: Code checks for specific values returned by compareTo</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#RV_EXCEPTION_NOT_THROWN">RV: Exception created and dropped rather than thrown</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#RV_RETURN_VALUE_IGNORED">RV: Method ignores return value</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#RpC_REPEATED_CONDITIONAL_TEST">RpC: Repeated conditional tests</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SA_FIELD_DOUBLE_ASSIGNMENT">SA: Double assignment of field</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SA_FIELD_SELF_ASSIGNMENT">SA: Self assignment of field</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SA_FIELD_SELF_COMPARISON">SA: Self comparison of field with itself</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SA_FIELD_SELF_COMPUTATION">SA: Nonsensical self computation involving a field (e.g., x & x)</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#SA_FIELD_SELF_ASSIGNMENT">SA: Self assignment of field</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#SA_FIELD_SELF_COMPARISON">SA: Self comparison of field with itself</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#SA_FIELD_SELF_COMPUTATION">SA: Nonsensical self computation involving a field (e.g., x & x)</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#SA_LOCAL_SELF_ASSIGNMENT_INSTEAD_OF_FIELD">SA: Self assignment of local rather than assignment to field</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#SA_LOCAL_SELF_COMPARISON">SA: Self comparison of value with itself</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#SA_LOCAL_SELF_COMPUTATION">SA: Nonsensical self computation involving a variable (e.g., x & x)</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH">SF: Dead store due to switch statement fall through</a></td><td>Correctness</td></tr>
@@ -257,13 +272,15 @@
<tr bgcolor="#ffffff"><td><a href="#SE_METHOD_MUST_BE_PRIVATE">Se: Method must be private in order for serialization to work</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#SE_READ_RESOLVE_IS_STATIC">Se: The readResolve method must not be declared as a static method. </a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#TQ_ALWAYS_VALUE_USED_WHERE_NEVER_REQUIRED">TQ: Value annotated as carrying a type qualifier used where a value that must not carry that qualifier is required</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#TQ_MAYBE_SOURCE_VALUE_REACHES_ALWAYS_SINK">TQ: Value that might not carry a type qualifier is always used in a way requires that type qualifier</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#TQ_MAYBE_SOURCE_VALUE_REACHES_NEVER_SINK">TQ: Value that might carry a type qualifier is always used in a way prohibits it from having that type qualifier</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#TQ_NEVER_VALUE_USED_WHERE_ALWAYS_REQUIRED">TQ: Value annotated as never carrying a type qualifier used where value carrying that qualifier is required</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#TQ_COMPARING_VALUES_WITH_INCOMPATIBLE_TYPE_QUALIFIERS">TQ: Comparing values with incompatible type qualifiers</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#TQ_MAYBE_SOURCE_VALUE_REACHES_ALWAYS_SINK">TQ: Value that might not carry a type qualifier is always used in a way requires that type qualifier</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#TQ_MAYBE_SOURCE_VALUE_REACHES_NEVER_SINK">TQ: Value that might carry a type qualifier is always used in a way prohibits it from having that type qualifier</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#TQ_NEVER_VALUE_USED_WHERE_ALWAYS_REQUIRED">TQ: Value annotated as never carrying a type qualifier used where value carrying that qualifier is required</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#TQ_UNKNOWN_VALUE_USED_WHERE_ALWAYS_STRICTLY_REQUIRED">TQ: Value without a type qualifier used where a value is required to have that qualifier</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS">UMAC: Uncallable method defined in anonymous class</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#UR_UNINIT_READ">UR: Uninitialized read of field in constructor</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR">UR: Uninitialized read of field method called from constructor of superclass</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY">USELESS_STRING: Invocation of toString on an array</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY">USELESS_STRING: Invocation of toString on an unnamed array</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#DMI_INVOKING_TOSTRING_ON_ARRAY">USELESS_STRING: Invocation of toString on an array</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#VA_FORMAT_STRING_BAD_CONVERSION_FROM_ARRAY">USELESS_STRING: Array formatted in useless way using format string</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#UWF_NULL_FIELD">UwF: Field only ever set to null</a></td><td>Correctness</td></tr>
@@ -271,7 +288,11 @@
<tr bgcolor="#ffffff"><td><a href="#VA_PRIMITIVE_ARRAY_PASSED_TO_OBJECT_VARARG">VA: Primitive array passed to function expecting a variable number of object arguments</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE">LG: Potential lost logger changes due to weak reference in OpenJDK</a></td><td>Experimental</td></tr>
<tr bgcolor="#ffffff"><td><a href="#OBL_UNSATISFIED_OBLIGATION">OBL: Method may fail to clean up stream or resource</a></td><td>Experimental</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DM_CONVERT_CASE">Dm: Consider using Locale parameterized version of invoked method</a></td><td>Internationalization</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE">OBL: Method may fail to clean up stream or resource on checked exception</a></td><td>Experimental</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DM_CONVERT_CASE">Dm: Consider using Locale parameterized version of invoked method</a></td><td>Internationalization</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DM_DEFAULT_ENCODING">Dm: Reliance on default encoding</a></td><td>Internationalization</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED">DP: Classloaders should only be created inside doPrivileged block</a></td><td>Malicious code vulnerability</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DP_DO_INSIDE_DO_PRIVILEGED">DP: Method invoked that should be only be invoked inside a doPrivileged block</a></td><td>Malicious code vulnerability</td></tr>
<tr bgcolor="#ffffff"><td><a href="#EI_EXPOSE_REP">EI: May expose internal representation by returning reference to mutable object</a></td><td>Malicious code vulnerability</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#EI_EXPOSE_REP2">EI2: May expose internal representation by incorporating reference to mutable object</a></td><td>Malicious code vulnerability</td></tr>
<tr bgcolor="#ffffff"><td><a href="#FI_PUBLIC_SHOULD_BE_PROTECTED">FI: Finalizer should be protected, not public</a></td><td>Malicious code vulnerability</td></tr>
@@ -284,10 +305,12 @@
<tr bgcolor="#eeeeee"><td><a href="#MS_OOI_PKGPROTECT">MS: Field should be moved out of an interface and made package protected</a></td><td>Malicious code vulnerability</td></tr>
<tr bgcolor="#ffffff"><td><a href="#MS_PKGPROTECT">MS: Field should be package protected</a></td><td>Malicious code vulnerability</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#MS_SHOULD_BE_FINAL">MS: Field isn't final but should be</a></td><td>Malicious code vulnerability</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#MS_SHOULD_BE_REFACTORED_TO_BE_FINAL">MS: Field isn't final but should be refactored to be so</a></td><td>Malicious code vulnerability</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION">AT: Sequence of calls to concurrent abstraction may not be atomic</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#DC_DOUBLECHECK">DC: Possible double check of field</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DL_SYNCHRONIZATION_ON_BOOLEAN">DL: Synchronization on Boolean could lead to deadlock</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE">DL: Synchronization on boxed primitive could lead to deadlock</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DL_SYNCHRONIZATION_ON_SHARED_CONSTANT">DL: Synchronization on interned String could lead to deadlock</a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DL_SYNCHRONIZATION_ON_BOOLEAN">DL: Synchronization on Boolean</a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE">DL: Synchronization on boxed primitive</a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DL_SYNCHRONIZATION_ON_SHARED_CONSTANT">DL: Synchronization on interned String </a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#DL_SYNCHRONIZATION_ON_UNSHARED_BOXED_PRIMITIVE">DL: Synchronization on boxed primitive values</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#DM_MONITOR_WAIT_ON_CONDITION">Dm: Monitor wait() called on Condition</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#DM_USELESS_THREAD">Dm: A thread was created using the default empty run method</a></td><td>Multithreaded correctness</td></tr>
@@ -295,6 +318,8 @@
<tr bgcolor="#ffffff"><td><a href="#IS2_INCONSISTENT_SYNC">IS: Inconsistent synchronization</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#IS_FIELD_NOT_GUARDED">IS: Field not guarded against concurrent access</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#JLM_JSR166_LOCK_MONITORENTER">JLM: Synchronization performed on Lock</a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#JLM_JSR166_UTILCONCURRENT_MONITORENTER">JLM: Synchronization performed on util.concurrent instance</a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#JML_JSR166_CALLING_WAIT_RATHER_THAN_AWAIT">JLM: Using monitor style wait methods on util.concurrent abstraction</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#LI_LAZY_INIT_STATIC">LI: Incorrect lazy initialization of static field</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#LI_LAZY_INIT_UPDATE_STATIC">LI: Incorrect lazy initialization and update of static field</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD">ML: Synchronization on field in futile attempt to guard that field</a></td><td>Multithreaded correctness</td></tr>
@@ -312,7 +337,7 @@
<tr bgcolor="#eeeeee"><td><a href="#SP_SPIN_ON_FIELD">SP: Method spins on field</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#STCAL_INVOKE_ON_STATIC_CALENDAR_INSTANCE">STCAL: Call to static Calendar</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE">STCAL: Call to static DateFormat</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#STCAL_STATIC_CALENDAR_INSTANCE">STCAL: Static Calendar</a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#STCAL_STATIC_CALENDAR_INSTANCE">STCAL: Static Calendar field</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE">STCAL: Static DateFormat</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#SWL_SLEEP_WITH_LOCK_HELD">SWL: Method calls Thread.sleep() with a lock held</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#TLW_TWO_LOCK_WAIT">TLW: Wait with two locks held</a></td><td>Multithreaded correctness</td></tr>
@@ -320,13 +345,15 @@
<tr bgcolor="#eeeeee"><td><a href="#UL_UNRELEASED_LOCK">UL: Method does not release lock on all paths</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#UL_UNRELEASED_LOCK_EXCEPTION_PATH">UL: Method does not release lock on all exception paths</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#UW_UNCOND_WAIT">UW: Unconditional wait</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#VO_VOLATILE_REFERENCE_TO_ARRAY">VO: A volatile reference to an array doesn't treat the array elements as volatile</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL">WL: Sychronization on getClass rather than class literal</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#WS_WRITEOBJECT_SYNC">WS: Class's writeObject() method is synchronized but nothing else is</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#WA_AWAIT_NOT_IN_LOOP">Wa: Condition.await() not in loop </a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#WA_NOT_IN_LOOP">Wa: Wait not in loop </a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#BX_BOXING_IMMEDIATELY_UNBOXED">Bx: Primitive value is boxed and then immediately unboxed</a></td><td>Performance</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION">Bx: Primitive value is boxed then unboxed to perform primitive coercion</a></td><td>Performance</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#VO_VOLATILE_INCREMENT">VO: An increment to a volatile field isn't atomic</a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#VO_VOLATILE_REFERENCE_TO_ARRAY">VO: A volatile reference to an array doesn't treat the array elements as volatile</a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL">WL: Synchronization on getClass rather than class literal</a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#WS_WRITEOBJECT_SYNC">WS: Class's writeObject() method is synchronized but nothing else is</a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#WA_AWAIT_NOT_IN_LOOP">Wa: Condition.await() not in loop </a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#WA_NOT_IN_LOOP">Wa: Wait not in loop </a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#BX_BOXING_IMMEDIATELY_UNBOXED">Bx: Primitive value is boxed and then immediately unboxed</a></td><td>Performance</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION">Bx: Primitive value is boxed then unboxed to perform primitive coercion</a></td><td>Performance</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#BX_UNBOXING_IMMEDIATELY_REBOXED">Bx: Boxed value is unboxed and then immediately reboxed</a></td><td>Performance</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#DM_BOXED_PRIMITIVE_TOSTRING">Bx: Method allocates a boxed primitive just to call toString</a></td><td>Performance</td></tr>
<tr bgcolor="#ffffff"><td><a href="#DM_FP_NUMBER_CTOR">Bx: Method invokes inefficient floating-point Number constructor; use static valueOf instead</a></td><td>Performance</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#DM_NUMBER_CTOR">Bx: Method invokes inefficient Number constructor; use static valueOf instead</a></td><td>Performance</td></tr>
@@ -355,73 +382,84 @@
<tr bgcolor="#ffffff"><td><a href="#DMI_EMPTY_DB_PASSWORD">Dm: Empty database password</a></td><td>Security</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#HRS_REQUEST_PARAMETER_TO_COOKIE">HRS: HTTP cookie formed from untrusted input</a></td><td>Security</td></tr>
<tr bgcolor="#ffffff"><td><a href="#HRS_REQUEST_PARAMETER_TO_HTTP_HEADER">HRS: HTTP Response splitting vulnerability</a></td><td>Security</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#PT_ABSOLUTE_PATH_TRAVERSAL">PT: Absolute path traversal in servlet</a></td><td>Security</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#PT_RELATIVE_PATH_TRAVERSAL">PT: Relative path traversal in servlet</a></td><td>Security</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE">SQL: Nonconstant string passed to execute method on an SQL statement</a></td><td>Security</td></tr>
<tr bgcolor="#ffffff"><td><a href="#SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING">SQL: A prepared statement is generated from a nonconstant String</a></td><td>Security</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#XSS_REQUEST_PARAMETER_TO_JSP_WRITER">XSS: JSP reflected cross site scripting vulnerability</a></td><td>Security</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#XSS_REQUEST_PARAMETER_TO_SEND_ERROR">XSS: Servlet reflected cross site scripting vulnerability</a></td><td>Security</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#XSS_REQUEST_PARAMETER_TO_SEND_ERROR">XSS: Servlet reflected cross site scripting vulnerability in error page</a></td><td>Security</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER">XSS: Servlet reflected cross site scripting vulnerability</a></td><td>Security</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#BC_BAD_CAST_TO_ABSTRACT_COLLECTION">BC: Questionable cast to abstract collection </a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#BC_BAD_CAST_TO_CONCRETE_COLLECTION">BC: Questionable cast to concrete collection</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#BC_UNCONFIRMED_CAST">BC: Unchecked/unconfirmed cast</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#BC_VACUOUS_INSTANCEOF">BC: instanceof will always return true</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#ICAST_QUESTIONABLE_UNSIGNED_RIGHT_SHIFT">BSHIFT: Unsigned right shift cast to short/byte</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#CI_CONFUSED_INHERITANCE">CI: Class is final but declares protected field</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DB_DUPLICATE_BRANCHES">DB: Method uses the same code for two branches</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DB_DUPLICATE_SWITCH_CLAUSES">DB: Method uses the same code for two switch clauses</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DLS_DEAD_LOCAL_STORE">DLS: Dead store to local variable</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DLS_DEAD_LOCAL_STORE_IN_RETURN">DLS: Useless assignment in return statement</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DLS_DEAD_LOCAL_STORE_OF_NULL">DLS: Dead store of null to local variable</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_HARDCODED_ABSOLUTE_FILENAME">DMI: Code contains a hard coded reference to an absolute pathname</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DMI_NONSERIALIZABLE_OBJECT_WRITTEN">DMI: Non serializable object written to ObjectOutput</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_USELESS_SUBSTRING">DMI: Invocation of substring(0), which returns the original value</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DMI_THREAD_PASSED_WHERE_RUNNABLE_EXPECTED">Dm: Thread passed where Runnable expected</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#EQ_DOESNT_OVERRIDE_EQUALS">Eq: Class doesn't override equals in superclass</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EQ_UNUSUAL">Eq: Unusual equals method </a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#FE_FLOATING_POINT_EQUALITY">FE: Test for floating point equality</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#VA_FORMAT_STRING_BAD_CONVERSION_TO_BOOLEAN">FS: Non-Boolean argument formatted using %b format specifier</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD">IA: Ambiguous invocation of either an inherited or outer method</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IC_INIT_CIRCULARITY">IC: Initialization circularity</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#ICAST_IDIV_CAST_TO_DOUBLE">ICAST: integral division result cast to double or float</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#ICAST_INTEGER_MULTIPLY_CAST_TO_LONG">ICAST: Result of integer multiplication cast to long</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IM_AVERAGE_COMPUTATION_COULD_OVERFLOW">IM: Computation of average could overflow</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IM_BAD_CHECK_FOR_ODD">IM: Check for oddness that won't work for negative numbers </a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#INT_BAD_REM_BY_1">INT: Integer remainder modulo 1</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#INT_VACUOUS_COMPARISON">INT: Vacuous comparison of integer value</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#MTIA_SUSPECT_SERVLET_INSTANCE_FIELD">MTIA: Class extends Servlet class and uses instance variables</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#MTIA_SUSPECT_STRUTS_INSTANCE_FIELD">MTIA: Class extends Struts Action class and uses instance variables</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_DEREFERENCE_OF_READLINE_VALUE">NP: Dereference of the result of readLine() without nullcheck</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_IMMEDIATE_DEREFERENCE_OF_READLINE">NP: Immediate dereference of the result of readLine()</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_LOAD_OF_KNOWN_NULL_VALUE">NP: Load of known null value</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE">NP: Possible null pointer dereference due to return value of called method</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE">NP: Possible null pointer dereference on path that might be infeasible</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE">NP: Parameter must be nonnull but is marked as nullable</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NS_DANGEROUS_NON_SHORT_CIRCUIT">NS: Potentially dangerous use of non-short-circuit logic</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NS_NON_SHORT_CIRCUIT">NS: Questionable use of non-short-circuit logic</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#PZLA_PREFER_ZERO_LENGTH_ARRAYS">PZLA: Consider returning a zero length array rather than null</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#QF_QUESTIONABLE_FOR_LOOP">QF: Complicated, subtle or wrong increment in for-loop </a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE">RCN: Redundant comparison of non-null value to null</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RCN_REDUNDANT_COMPARISON_TWO_NULL_VALUES">RCN: Redundant comparison of two null values</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE">RCN: Redundant nullcheck of value known to be non-null</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE">RCN: Redundant nullcheck of value known to be null</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#REC_CATCH_EXCEPTION">REC: Exception is caught when Exception is not thrown</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RI_REDUNDANT_INTERFACES">RI: Class implements same interface as superclass</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RV_CHECK_FOR_POSITIVE_INDEXOF">RV: Method checks to see if result of String.indexOf is positive</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RV_DONT_JUST_NULL_CHECK_READLINE">RV: Method discards result of readLine after checking if it is nonnull</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RV_REM_OF_HASHCODE">RV: Remainder of hashCode could be negative</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RV_REM_OF_RANDOM_INT">RV: Remainder of 32-bit signed random integer</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SA_LOCAL_DOUBLE_ASSIGNMENT">SA: Double assignment of local variable </a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SA_LOCAL_SELF_ASSIGNMENT">SA: Self assignment of local variable</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SF_SWITCH_FALLTHROUGH">SF: Switch statement found where one case falls through to the next case</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SF_SWITCH_NO_DEFAULT">SF: Switch statement found where default case is missing</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD">ST: Write to static field from instance method</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SE_PRIVATE_READ_RESOLVE_NOT_INHERITED">Se: private readResolve method not inherited by subclasses</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS">Se: Transient field of class that isn't Serializable. </a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK">TQ: Explicit annotation inconsistent with use</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK">TQ: Explicit annotation inconsistent with use</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#UCF_USELESS_CONTROL_FLOW">UCF: Useless control flow</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#UCF_USELESS_CONTROL_FLOW_NEXT_LINE">UCF: Useless control flow to next line</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR">UwF: Field not initialized in constructor</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#XFB_XML_FACTORY_BYPASS">XFB: Method directly allocates a specific implementation of xml interfaces</a></td><td>Dodgy</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#BC_BAD_CAST_TO_ABSTRACT_COLLECTION">BC: Questionable cast to abstract collection </a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#BC_BAD_CAST_TO_CONCRETE_COLLECTION">BC: Questionable cast to concrete collection</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#BC_UNCONFIRMED_CAST">BC: Unchecked/unconfirmed cast</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#BC_UNCONFIRMED_CAST_OF_RETURN_VALUE">BC: Unchecked/unconfirmed cast of return value from method</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#BC_VACUOUS_INSTANCEOF">BC: instanceof will always return true</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#ICAST_QUESTIONABLE_UNSIGNED_RIGHT_SHIFT">BSHIFT: Unsigned right shift cast to short/byte</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#CI_CONFUSED_INHERITANCE">CI: Class is final but declares protected field</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DB_DUPLICATE_BRANCHES">DB: Method uses the same code for two branches</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DB_DUPLICATE_SWITCH_CLAUSES">DB: Method uses the same code for two switch clauses</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DLS_DEAD_LOCAL_STORE">DLS: Dead store to local variable</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DLS_DEAD_LOCAL_STORE_IN_RETURN">DLS: Useless assignment in return statement</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DLS_DEAD_LOCAL_STORE_OF_NULL">DLS: Dead store of null to local variable</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DLS_DEAD_LOCAL_STORE_SHADOWS_FIELD">DLS: Dead store to local variable that shadows field</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DMI_HARDCODED_ABSOLUTE_FILENAME">DMI: Code contains a hard coded reference to an absolute pathname</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DMI_NONSERIALIZABLE_OBJECT_WRITTEN">DMI: Non serializable object written to ObjectOutput</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DMI_USELESS_SUBSTRING">DMI: Invocation of substring(0), which returns the original value</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DMI_THREAD_PASSED_WHERE_RUNNABLE_EXPECTED">Dm: Thread passed where Runnable expected</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#EQ_DOESNT_OVERRIDE_EQUALS">Eq: Class doesn't override equals in superclass</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#EQ_UNUSUAL">Eq: Unusual equals method </a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#FE_FLOATING_POINT_EQUALITY">FE: Test for floating point equality</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#VA_FORMAT_STRING_BAD_CONVERSION_TO_BOOLEAN">FS: Non-Boolean argument formatted using %b format specifier</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD">IA: Ambiguous invocation of either an inherited or outer method</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#IC_INIT_CIRCULARITY">IC: Initialization circularity</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#ICAST_IDIV_CAST_TO_DOUBLE">ICAST: integral division result cast to double or float</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#ICAST_INTEGER_MULTIPLY_CAST_TO_LONG">ICAST: Result of integer multiplication cast to long</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#IM_AVERAGE_COMPUTATION_COULD_OVERFLOW">IM: Computation of average could overflow</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#IM_BAD_CHECK_FOR_ODD">IM: Check for oddness that won't work for negative numbers </a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#INT_BAD_REM_BY_1">INT: Integer remainder modulo 1</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#INT_VACUOUS_BIT_OPERATION">INT: Vacuous bit mask operation on integer value</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#INT_VACUOUS_COMPARISON">INT: Vacuous comparison of integer value</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#MTIA_SUSPECT_SERVLET_INSTANCE_FIELD">MTIA: Class extends Servlet class and uses instance variables</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#MTIA_SUSPECT_STRUTS_INSTANCE_FIELD">MTIA: Class extends Struts Action class and uses instance variables</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NP_DEREFERENCE_OF_READLINE_VALUE">NP: Dereference of the result of readLine() without nullcheck</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NP_IMMEDIATE_DEREFERENCE_OF_READLINE">NP: Immediate dereference of the result of readLine()</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NP_LOAD_OF_KNOWN_NULL_VALUE">NP: Load of known null value</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE">NP: Possible null pointer dereference due to return value of called method</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE">NP: Possible null pointer dereference on branch that might be infeasible</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE">NP: Parameter must be nonnull but is marked as nullable</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD">NP: Read of unwritten public or protected field</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NS_DANGEROUS_NON_SHORT_CIRCUIT">NS: Potentially dangerous use of non-short-circuit logic</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NS_NON_SHORT_CIRCUIT">NS: Questionable use of non-short-circuit logic</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#PZLA_PREFER_ZERO_LENGTH_ARRAYS">PZLA: Consider returning a zero length array rather than null</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#QF_QUESTIONABLE_FOR_LOOP">QF: Complicated, subtle or wrong increment in for-loop </a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE">RCN: Redundant comparison of non-null value to null</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RCN_REDUNDANT_COMPARISON_TWO_NULL_VALUES">RCN: Redundant comparison of two null values</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE">RCN: Redundant nullcheck of value known to be non-null</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE">RCN: Redundant nullcheck of value known to be null</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#REC_CATCH_EXCEPTION">REC: Exception is caught when Exception is not thrown</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RI_REDUNDANT_INTERFACES">RI: Class implements same interface as superclass</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#RV_CHECK_FOR_POSITIVE_INDEXOF">RV: Method checks to see if result of String.indexOf is positive</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RV_DONT_JUST_NULL_CHECK_READLINE">RV: Method discards result of readLine after checking if it is nonnull</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#RV_REM_OF_HASHCODE">RV: Remainder of hashCode could be negative</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RV_REM_OF_RANDOM_INT">RV: Remainder of 32-bit signed random integer</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#RV_RETURN_VALUE_IGNORED_INFERRED">RV: Method ignores return value, is this OK?</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#SA_FIELD_DOUBLE_ASSIGNMENT">SA: Double assignment of field</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#SA_LOCAL_DOUBLE_ASSIGNMENT">SA: Double assignment of local variable </a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#SA_LOCAL_SELF_ASSIGNMENT">SA: Self assignment of local variable</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#SF_SWITCH_FALLTHROUGH">SF: Switch statement found where one case falls through to the next case</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#SF_SWITCH_NO_DEFAULT">SF: Switch statement found where default case is missing</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD">ST: Write to static field from instance method</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#SE_PRIVATE_READ_RESOLVE_NOT_INHERITED">Se: private readResolve method not inherited by subclasses</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS">Se: Transient field of class that isn't Serializable. </a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK">TQ: Value required to have type qualifier, but marked as unknown</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK">TQ: Value required to not have type qualifier, but marked as unknown</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#UCF_USELESS_CONTROL_FLOW">UCF: Useless control flow</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#UCF_USELESS_CONTROL_FLOW_NEXT_LINE">UCF: Useless control flow to next line</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD">UrF: Unread public/protected field</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD">UuF: Unused public or protected field</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR">UwF: Field not initialized in constructor but dereferenced without null check</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD">UwF: Unwritten public or protected field</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#XFB_XML_FACTORY_BYPASS">XFB: Method directly allocates a specific implementation of xml interfaces</a></td><td>Dodgy code</td></tr>
</table>
<h2>Descriptions</h2>
<h3><a name="AM_CREATES_EMPTY_JAR_FILE_ENTRY">AM: Creates an empty jar file entry (AM_CREATES_EMPTY_JAR_FILE_ENTRY)</a></h3>
@@ -456,27 +494,12 @@
</p>
-<h3><a name="DMI_RANDOM_USED_ONLY_ONCE">BC: Random object created and used only once (DMI_RANDOM_USED_ONLY_ONCE)</a></h3>
-
-
-<p> This code creates a java.util.Random object, uses it to generate one random number, and then discards
-the Random object. This produces mediocre quality random numbers and is inefficient.
-If possible, rewrite the code so that the Random object is created once and saved, and each time a new random number
-is required invoke a method on the existing Random object to obtain it.
-</p>
-
-<p>If it is important that the generated Random numbers not be guessable, you <em>must</em> not create a new Random for each random
-number; the values are too easily guessable. You should strongly consider using a java.security.SecureRandom instead
-(and avoid allocating a new SecureRandom for each random number needed).
-</p>
-
-
<h3><a name="BIT_SIGNED_CHECK">BIT: Check for sign of bitwise operation (BIT_SIGNED_CHECK)</a></h3>
-<p> This method compares an expression such as
+<p> This method compares an expression such as</p>
<pre>((event.detail & SWT.SELECTED) > 0)</pre>.
-Using bit arithmetic and then comparing with the greater than operator can
+<p>Using bit arithmetic and then comparing with the greater than operator can
lead to unexpected results (of course depending on the value of
SWT.SELECTED). If SWT.SELECTED is a negative number, this is a candidate
for a bug. Even when SWT.SELECTED is not negative, it seems good practice
@@ -512,7 +535,7 @@
<p> This class defines a clone() method but the class doesn't implement Cloneable.
-There are some situations in which this is OK (e.g., you want to control how subclasses
+There are some situations in which this is OK (e.g., you want to control how subclasses
can clone themselves), but just make sure that this is what you intended.
</p>
@@ -551,32 +574,44 @@
out of the method.</p>
+<h3><a name="DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS">DMI: Adding elements of an entry set may fail due to reuse of Entry objects (DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS)</a></h3>
+
+
+ <p> The entrySet() method is allowed to return a view of the
+ underlying Map in which a single Entry object is reused and returned
+ during the iteration. As of Java 1.6, both IdentityHashMap
+ and EnumMap did so. When iterating through such a Map,
+ the Entry value is only valid until you advance to the next iteration.
+ If, for example, you try to pass such an entrySet to an addAll method,
+ things will go badly wrong.
+ </p>
+
+
+<h3><a name="DMI_RANDOM_USED_ONLY_ONCE">DMI: Random object created and used only once (DMI_RANDOM_USED_ONLY_ONCE)</a></h3>
+
+
+<p> This code creates a java.util.Random object, uses it to generate one random number, and then discards
+the Random object. This produces mediocre quality random numbers and is inefficient.
+If possible, rewrite the code so that the Random object is created once and saved, and each time a new random number
+is required invoke a method on the existing Random object to obtain it.
+</p>
+
+<p>If it is important that the generated Random numbers not be guessable, you <em>must</em> not create a new Random for each random
+number; the values are too easily guessable. You should strongly consider using a java.security.SecureRandom instead
+(and avoid allocating a new SecureRandom for each random number needed).
+</p>
+
+
<h3><a name="DMI_USING_REMOVEALL_TO_CLEAR_COLLECTION">DMI: Don't use removeAll to clear a collection (DMI_USING_REMOVEALL_TO_CLEAR_COLLECTION)</a></h3>
<p> If you want to remove all elements from a collection <code>c</code>, use <code>c.clear</code>,
not <code>c.removeAll(c)</code>. Calling <code>c.removeAll(c)</code> to clear a collection
-is less clear, susceptible to errors from typos, less efficient and
+is less clear, susceptible to errors from typos, less efficient and
for some collections, might throw a <code>ConcurrentModificationException</code>.
- </p>
+ </p>
-<h3><a name="DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED">DP: Classloaders should only be created inside doPrivileged block (DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED)</a></h3>
-
-
- <p> This code creates a classloader, which requires a security manager.
- If this code will be granted security permissions, but might be invoked by code that does not
- have security permissions, then the classloader creation needs to occur inside a doPrivileged block.</p>
-
-
-<h3><a name="DP_DO_INSIDE_DO_PRIVILEGED">DP: Method invoked that should be only be invoked inside a doPrivileged block (DP_DO_INSIDE_DO_PRIVILEGED)</a></h3>
-
-
- <p> This code invokes a method that requires a security permission check.
- If this code will be granted security permissions, but might be invoked by code that does not
- have security permissions, then the invocation needs to occur inside a doPrivileged block.</p>
-
-
<h3><a name="DM_EXIT">Dm: Method invokes System.exit(...) (DM_EXIT)</a></h3>
@@ -598,7 +633,7 @@
<p>This code compares a <code>java.lang.String</code> parameter for reference
-equality using the == or != operators. Requiring callers to
+equality using the == or != operators. Requiring callers to
pass only String constants or interned strings to a method is unnecessarily
fragile, and rarely leads to measurable performance gains. Consider
using the <code>equals(Object)</code> method instead.</p>
@@ -624,22 +659,22 @@
must have type <code>java.lang.Object</code>.</p>
-<h3><a name="EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS">Eq: Equals checks for noncompatible operand (EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS)</a></h3>
+<h3><a name="EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS">Eq: Equals checks for incompatible operand (EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS)</a></h3>
<p> This equals method is checking to see if the argument is some incompatible type
(i.e., a class that is neither a supertype nor subtype of the class that defines
the equals method). For example, the Foo class might have an equals method
that looks like:
-
-<p><code><pre>
+</p>
+<pre>
public boolean equals(Object o) {
if (o instanceof Foo)
return name.equals(((Foo)o).name);
else if (o instanceof String)
return name.equals(o);
else return false;
-</pre></code></p>
+</pre>
<p>This is considered bad practice, as it makes it very hard to implement an equals method that
is symmetric and transitive. Without those properties, very unexpected behavoirs are possible.
@@ -651,17 +686,17 @@
<p> This class defines a <code>compareTo(...)</code> method but inherits its
<code>equals()</code> method from <code>java.lang.Object</code>.
- Generally, the value of compareTo should return zero if and only if
- equals returns true. If this is violated, weird and unpredictable
- failures will occur in classes such as PriorityQueue.
- In Java 5 the PriorityQueue.remove method uses the compareTo method,
- while in Java 6 it uses the equals method.
+ Generally, the value of compareTo should return zero if and only if
+ equals returns true. If this is violated, weird and unpredictable
+ failures will occur in classes such as PriorityQueue.
+ In Java 5 the PriorityQueue.remove method uses the compareTo method,
+ while in Java 6 it uses the equals method.
<p>From the JavaDoc for the compareTo method in the Comparable interface:
<blockquote>
-It is strongly recommended, but not strictly required that <code>(x.compareTo(y)==0) == (x.equals(y))</code>.
-Generally speaking, any class that implements the Comparable interface and violates this condition
-should clearly indicate this fact. The recommended language
+It is strongly recommended, but not strictly required that <code>(x.compareTo(y)==0) == (x.equals(y))</code>.
+Generally speaking, any class that implements the Comparable interface and violates this condition
+should clearly indicate this fact. The recommended language
is "Note: this class has a natural ordering that is inconsistent with equals."
</blockquote>
@@ -708,9 +743,9 @@
<p> This finalizer nulls out fields. This is usually an error, as it does not aid garbage collection,
- and the object is going to be garbage collected anyway.
+ and the object is going to be garbage collected anyway.
-
+
<h3><a name="FI_FINALIZER_ONLY_NULLS_FIELDS">FI: Finalizer only nulls fields (FI_FINALIZER_ONLY_NULLS_FIELDS)</a></h3>
@@ -718,7 +753,7 @@
the object be garbage collected, finalized, and then garbage collected again. You should just remove the finalize
method.
-
+
<h3><a name="FI_MISSING_SUPER_CALL">FI: Finalizer does not call superclass finalizer (FI_MISSING_SUPER_CALL)</a></h3>
@@ -745,16 +780,25 @@
redundant. Delete it.</p>
+<h3><a name="VA_FORMAT_STRING_USES_NEWLINE">FS: Format string should use %n rather than \n (VA_FORMAT_STRING_USES_NEWLINE)</a></h3>
+
+
+<p>
+This format string include a newline character (\n). In format strings, it is generally
+ preferable better to use %n, which will produce the platform-specific line separator.
+</p>
+
+
<h3><a name="GC_UNCHECKED_TYPE_IN_GENERIC_CALL">GC: Unchecked type in generic call (GC_UNCHECKED_TYPE_IN_GENERIC_CALL)</a></h3>
<p> This call to a generic collection method passes an argument
- while compile type Object where a specific type from
- the generic type parameters is expected.
- Thus, neither the standard Java type system nor static analysis
- can provide useful information on whether the
- object being passed as a parameter is of an appropriate type.
- </p>
+ while compile type Object where a specific type from
+ the generic type parameters is expected.
+ Thus, neither the standard Java type system nor static analysis
+ can provide useful information on whether the
+ object being passed as a parameter is of an appropriate type.
+ </p>
<h3><a name="HE_EQUALS_NO_HASHCODE">HE: Class defines equals() but not hashCode() (HE_EQUALS_NO_HASHCODE)</a></h3>
@@ -779,7 +823,7 @@
the recommended <code>hashCode</code> implementation to use is:</p>
<pre>public int hashCode() {
assert false : "hashCode not designed";
- return 42; // any arbitrary constant will do
+ return 42; // any arbitrary constant will do
}</pre>
@@ -804,10 +848,10 @@
than simple reference equality.)</p>
<p>If you don't think instances of this class will ever be inserted into a HashMap/HashTable,
the recommended <code>hashCode</code> implementation to use is:</p>
-<p><pre>public int hashCode() {
+<pre>public int hashCode() {
assert false : "hashCode not designed";
- return 42; // any arbitrary constant will do
- }</pre></p>
+ return 42; // any arbitrary constant will do
+ }</pre>
<h3><a name="HE_INHERITS_EQUALS_USE_HASHCODE">HE: Class inherits equals() and uses Object.hashCode() (HE_INHERITS_EQUALS_USE_HASHCODE)</a></h3>
@@ -835,11 +879,11 @@
<pre>
public class CircularClassInitialization {
- static class InnerClassSingleton extends CircularClassInitialization {
- static InnerClassSingleton singleton = new InnerClassSingleton();
- }
-
- static CircularClassInitialization foo = InnerClassSingleton.singleton;
+ static class InnerClassSingleton extends CircularClassInitialization {
+ static InnerClassSingleton singleton = new InnerClassSingleton();
+ }
+
+ static CircularClassInitialization foo = InnerClassSingleton.singleton;
}
</pre>
@@ -889,22 +933,22 @@
<h3><a name="NP_BOOLEAN_RETURN_NULL">NP: Method with Boolean return type returns explicit null (NP_BOOLEAN_RETURN_NULL)</a></h3>
-
- <p>
- A method that returns either Boolean.TRUE, Boolean.FALSE or null is an accident waiting to happen.
- This method can be invoked as though it returned a value of type boolean, and
- the compiler will insert automatic unboxing of the Boolean value. If a null value is returned,
- this will result in a NullPointerException.
- </p>
-
-
+
+ <p>
+ A method that returns either Boolean.TRUE, Boolean.FALSE or null is an accident waiting to happen.
+ This method can be invoked as though it returned a value of type boolean, and
+ the compiler will insert automatic unboxing of the Boolean value. If a null value is returned,
+ this will result in a NullPointerException.
+ </p>
+
+
<h3><a name="NP_CLONE_COULD_RETURN_NULL">NP: Clone method may return null (NP_CLONE_COULD_RETURN_NULL)</a></h3>
<p>
- This clone method seems to return null in some circumstances, but clone is never
- allowed to return a null value. If you are convinced this path is unreachable, throw an AssertionError
- instead.
+ This clone method seems to return null in some circumstances, but clone is never
+ allowed to return a null value. If you are convinced this path is unreachable, throw an AssertionError
+ instead.
</p>
@@ -923,9 +967,9 @@
<p>
- This toString method seems to return null in some circumstances. A liberal reading of the
- spec could be interpreted as allowing this, but it is probably a bad idea and could cause
- other code to break. Return the empty string or some other appropriate string rather than null.
+ This toString method seems to return null in some circumstances. A liberal reading of the
+ spec could be interpreted as allowing this, but it is probably a bad idea and could cause
+ other code to break. Return the empty string or some other appropriate string rather than null.
</p>
@@ -968,8 +1012,8 @@
<h3><a name="NM_FUTURE_KEYWORD_USED_AS_MEMBER_IDENTIFIER">Nm: Use of identifier that is a keyword in later versions of Java (NM_FUTURE_KEYWORD_USED_AS_MEMBER_IDENTIFIER)</a></h3>
-<p>This identifier is used as a keyword in later versions of Java. This code, and
-any code that references this API,
+<p>This identifier is used as a keyword in later versions of Java. This code, and
+any code that references this API,
will need to be changed in order to compile it in later versions of Java.</p>
@@ -986,7 +1030,7 @@
<p> This class/interface has a simple name that is identical to that of an implemented/extended interface, except
-that the interface is in a different package (e.g., <code>alpha.Foo</code> extends <code>beta.Foo</code>).
+that the interface is in a different package (e.g., <code>alpha.Foo</code> extends <code>beta.Foo</code>).
This can be exceptionally confusing, create lots of situations in which you have to look at import statements
to resolve references and creates many
opportunities to accidently define methods that do not override methods in their superclasses.
@@ -997,7 +1041,7 @@
<p> This class has a simple name that is identical to that of its superclass, except
-that its superclass is in a different package (e.g., <code>alpha.Foo</code> extends <code>beta.Foo</code>).
+that its superclass is in a different package (e.g., <code>alpha.Foo</code> extends <code>beta.Foo</code>).
This can be exceptionally confusing, create lots of situations in which you have to look at import statements
to resolve references and creates many
opportunities to accidently define methods that do not override methods in their superclasses.
@@ -1007,10 +1051,10 @@
<h3><a name="NM_VERY_CONFUSING_INTENTIONAL">Nm: Very confusing method names (but perhaps intentional) (NM_VERY_CONFUSING_INTENTIONAL)</a></h3>
- <p> The referenced methods have names that differ only by capitalization.
+ <p> The referenced methods have names that differ only by capitalization.
This is very confusing because if the capitalization were
identical then one of the methods would override the other. From the existence of other methods, it
-seems that the existence of both of these methods is intentional, but is sure is confusing.
+seems that the existence of both of these methods is intentional, but is sure is confusing.
You should try hard to eliminate one of them, unless you are forced to have both due to frozen APIs.
</p>
@@ -1037,7 +1081,7 @@
</blockquote>
<p>The <code>f(Foo)</code> method defined in class <code>B</code> doesn't
-override the
+override the
<code>f(Foo)</code> method defined in class <code>A</code>, because the argument
types are <code>Foo</code>'s from different packages.
</p>
@@ -1077,7 +1121,7 @@
<p> The method creates an IO stream object, does not assign it to any
-fields, pass it to other methods that might close it,
+fields, pass it to other methods that might close it,
or return it, and does not appear to close
the stream on all paths out of the method. This may result in
a file descriptor leak. It is generally a good
@@ -1096,12 +1140,26 @@
closed.</p>
+<h3><a name="PZ_DONT_REUSE_ENTRY_OBJECTS_IN_ITERATORS">PZ: Don't reuse entry objects in iterators (PZ_DONT_REUSE_ENTRY_OBJECTS_IN_ITERATORS)</a></h3>
+
+
+ <p> The entrySet() method is allowed to return a view of the
+ underlying Map in which an Iterator and Map.Entry. This clever
+ idea was used in several Map implementations, but introduces the possibility
+ of nasty coding mistakes. If a map <code>m</code> returns
+ such an iterator for an entrySet, then
+ <code>c.addAll(m.entrySet())</code> will go badly wrong. All of
+ the Map implementations in OpenJDK 1.7 have been rewritten to avoid this,
+ you should to.
+ </p>
+
+
<h3><a name="RC_REF_COMPARISON_BAD_PRACTICE">RC: Suspicious reference comparison to constant (RC_REF_COMPARISON_BAD_PRACTICE)</a></h3>
<p> This method compares a reference value to a constant using the == or != operator,
where the correct way to compare instances of this type is generally
-with the equals() method.
+with the equals() method.
It is possible to create distinct instances that are equal but do not compare as == since
they are different objects.
Examples of classes which should generally
@@ -1111,7 +1169,7 @@
<h3><a name="RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN">RC: Suspicious reference comparison of Boolean values (RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN)</a></h3>
-<p> This method compares two Boolean values using the == or != operator.
+<p> This method compares two Boolean values using the == or != operator.
Normally, there are only two Boolean values (Boolean.TRUE and Boolean.FALSE),
but it is possible to create other Boolean objects using the <code>new Boolean(b)</code>
constructor. It is best to avoid such objects, but if they do exist,
@@ -1146,13 +1204,24 @@
requested number of bytes.</p>
+<h3><a name="RV_NEGATING_RESULT_OF_COMPARETO">RV: Negating the result of compareTo()/compare() (RV_NEGATING_RESULT_OF_COMPARETO)</a></h3>
+
+
+ <p> This code negatives the return value of a compareTo or compare method.
+This is a questionable or bad programming practice, since if the return
+value is Integer.MIN_VALUE, negating the return value won't
+negate the sign of the result. You can achieve the same intended result
+by reversing the order of the operands rather than by negating the results.
+</p>
+
+
<h3><a name="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE">RV: Method ignores exceptional return value (RV_RETURN_VALUE_IGNORED_BAD_PRACTICE)</a></h3>
<p> This method returns a value that is not checked. The return value should be checked
since it can indicate an unusual or unexpected function execution. For
example, the <code>File.delete()</code> method returns false
-if the file could not be successfully deleted (rather than
+if the file could not be successfully deleted (rather than
throwing an Exception).
If you don't check the result, you won't notice if the method invocation
signals unexpected behavior by returning an atypical return value.
@@ -1169,7 +1238,7 @@
<h3><a name="SW_SWING_METHODS_INVOKED_IN_SWING_THREAD">SW: Certain swing methods needs to be invoked in Swing thread (SW_SWING_METHODS_INVOKED_IN_SWING_THREAD)</a></h3>
-<p>(<a href="http://java.sun.com/developer/JDCTechTips/2003/tt1208.html#1">From JDC Tech Tip</a>): The Swing methods
+<p>(<a href="http://web.archive.org/web/20090526170426/http://java.sun.com/developer/JDCTechTips/2003/tt1208.html">From JDC Tech Tip</a>): The Swing methods
show(), setVisible(), and pack() will create the associated peer for the frame.
With the creation of the peer, the system creates the event dispatch thread.
This makes things problematic because the event dispatch thread could be notifying
@@ -1199,7 +1268,7 @@
Thus, attempts to serialize it will also attempt to associate instance of the outer
class with which it is associated, leading to a runtime error.
</p>
-<p>If possible, making the inner class a static inner class should solve the
+<p>If possible, making the inner class a static inner class should solve the
problem. Making the outer class serializable might also work, but that would
mean serializing an instance of the inner class would always also serialize the instance
of the outer class, which it often not what you really want.
@@ -1231,8 +1300,8 @@
<p> This Serializable class is an inner class. Any attempt to serialize
it will also serialize the associated outer instance. The outer instance is serializable,
so this won't fail, but it might serialize a lot more data than intended.
-If possible, making the inner class a static inner class (also known as a nested class) should solve the
-problem.
+If possible, making the inner class a static inner class (also known as a nested class) should solve the
+problem.
<h3><a name="SE_NONFINAL_SERIALVERSIONID">Se: serialVersionUID isn't final (SE_NONFINAL_SERIALVERSIONID)</a></h3>
@@ -1294,7 +1363,7 @@
<h3><a name="SE_TRANSIENT_FIELD_NOT_RESTORED">Se: Transient field that isn't set by deserialization. (SE_TRANSIENT_FIELD_NOT_RESTORED)</a></h3>
- <p> This class contains a field that is updated at multiple places in the class, thus it seems to be part of the state of the class. However, since the field is marked as transient and not set in readObject or readResolve, it will contain the default value in any
+ <p> This class contains a field that is updated at multiple places in the class, thus it seems to be part of the state of the class. However, since the field is marked as transient and not set in readObject or readResolve, it will contain the default value in any
deserialized instance of the class.
</p>
@@ -1343,10 +1412,10 @@
<p>
-This cast will always throw a ClassCastException.
+This cast will always throw a ClassCastException.
The analysis believes it knows
the precise type of the value being cast, and the attempt to
-downcast it to a subtype will always fail by throwing a ClassCastException.
+downcast it to a subtype will always fail by throwing a ClassCastException.
</p>
@@ -1355,7 +1424,7 @@
<p>
This code is casting the result of calling <code>toArray()</code> on a collection
-to a type more specific than <code>Object[]</code>, as in:
+to a type more specific than <code>Object[]</code>, as in:</p>
<pre>
String[] getAsArray(Collection<String> c) {
return (String[]) c.toArray();
@@ -1387,11 +1456,11 @@
<h3><a name="BIT_ADD_OF_SIGNED_BYTE">BIT: Bitwise add of signed byte value (BIT_ADD_OF_SIGNED_BYTE)</a></h3>
-<p> Adds a byte value and a value which is known to the 8 lower bits clear.
+<p> Adds a byte value and a value which is known to have the 8 lower bits clear.
Values loaded from a byte array are sign extended to 32 bits
before any any bitwise operations are performed on the value.
Thus, if <code>b[0]</code> contains the value <code>0xff</code>, and
-<code>x</code> is initially 0, then the code
+<code>x</code> is initially 0, then the code
<code>((x << 8) + b[0])</code> will sign extend <code>0xff</code>
to get <code>0xffffffff</code>, and thus give the value
<code>0xffffffff</code> as the result.
@@ -1400,14 +1469,14 @@
<p>In particular, the following code for packing a byte array into an int is badly wrong: </p>
<pre>
int result = 0;
-for(int i = 0; i < 4; i++)
+for(int i = 0; i < 4; i++)
result = ((result << 8) + b[i]);
</pre>
<p>The following idiom will work instead: </p>
<pre>
int result = 0;
-for(int i = 0; i < 4; i++)
+for(int i = 0; i < 4; i++)
result = ((result << 8) + (b[i] & 0xff));
</pre>
@@ -1446,11 +1515,12 @@
<h3><a name="BIT_IOR_OF_SIGNED_BYTE">BIT: Bitwise OR of signed byte value (BIT_IOR_OF_SIGNED_BYTE)</a></h3>
-<p> Loads a value from a byte array and performs a bitwise OR with
-that value. Values loaded from a byte array are sign extended to 32 bits
+<p> Loads a byte value (e.g., a value loaded from a byte array or returned by a method
+with return type byte) and performs a bitwise OR with
+that value. Byte values are sign extended to 32 bits
before any any bitwise operations are performed on the value.
Thus, if <code>b[0]</code> contains the value <code>0xff</code>, and
-<code>x</code> is initially 0, then the code
+<code>x</code> is initially 0, then the code
<code>((x << 8) | b[0])</code> will sign extend <code>0xff</code>
to get <code>0xffffffff</code>, and thus give the value
<code>0xffffffff</code> as the result.
@@ -1459,14 +1529,14 @@
<p>In particular, the following code for packing a byte array into an int is badly wrong: </p>
<pre>
int result = 0;
-for(int i = 0; i < 4; i++)
+for(int i = 0; i < 4; i++)
result = ((result << 8) | b[i]);
</pre>
<p>The following idiom will work instead: </p>
<pre>
int result = 0;
-for(int i = 0; i < 4; i++)
+for(int i = 0; i < 4; i++)
result = ((result << 8) | (b[i] & 0xff));
</pre>
@@ -1475,9 +1545,9 @@
<h3><a name="BIT_SIGNED_CHECK_HIGH_BIT">BIT: Check for sign of bitwise operation (BIT_SIGNED_CHECK_HIGH_BIT)</a></h3>
-<p> This method compares an expression such as
+<p> This method compares an expression such as</p>
<pre>((event.detail & SWT.SELECTED) > 0)</pre>.
-Using bit arithmetic and then comparing with the greater than operator can
+<p>Using bit arithmetic and then comparing with the greater than operator can
lead to unexpected results (of course depending on the value of
SWT.SELECTED). If SWT.SELECTED is a negative number, this is a candidate
for a bug. Even when SWT.SELECTED is not negative, it seems good practice
@@ -1496,16 +1566,16 @@
get called when the event occurs.</p>
-<h3><a name="ICAST_BAD_SHIFT_AMOUNT">BSHIFT: 32 bit int shifted by an amount not in the range 0..31 (ICAST_BAD_SHIFT_AMOUNT)</a></h3>
+<h3><a name="ICAST_BAD_SHIFT_AMOUNT">BSHIFT: 32 bit int shifted by an amount not in the range -31..31 (ICAST_BAD_SHIFT_AMOUNT)</a></h3>
<p>
The code performs shift of a 32 bit int by a constant amount outside
-the range 0..31.
+the range -31..31.
The effect of this is to use the lower 5 bits of the integer
value to decide how much to shift by (e.g., shifting by 40 bits is the same as shifting by 8 bits,
-and shifting by 32 bits is the same as shifting by zero bits). This probably isn't want was expected,
-and it at least confusing.
+and shifting by 32 bits is the same as shifting by zero bits). This probably isn't what was expected,
+and it is at least confusing.
</p>
@@ -1516,12 +1586,23 @@
evaluation of a conditional ternary operator (the <code> b ? e1 : e2</code> operator). The
semantics of Java mandate that if <code>e1</code> and <code>e2</code> are wrapped
numeric values, the values are unboxed and converted/coerced to their common type (e.g,
-if <code>e1</code> is of type <code>Integer</code>
+if <code>e1</code> is of type <code>Integer</code>
and <code>e2</code> is of type <code>Float</code>, then <code>e1</code> is unboxed,
converted to a floating point value, and boxed. See JLS Section 15.25.
</p>
+<h3><a name="CO_COMPARETO_RESULTS_MIN_VALUE">Co: compareTo()/compare() returns Integer.MIN_VALUE (CO_COMPARETO_RESULTS_MIN_VALUE)</a></h3>
+
+
+ <p> In some situation, this compareTo or compare method returns
+the constant Integer.MIN_VALUE, which is an exceptionally bad practice.
+ The only thing that matters about the return value of compareTo is the sign of the result.
+ But people will sometimes negate the return value of compareTo, expecting that this will negate
+ the sign of the result. And it will, except in the case where the value returned is Integer.MIN_VALUE.
+ So just return -1 rather than Integer.MIN_VALUE.
+
+
<h3><a name="DLS_DEAD_STORE_OF_CLASS_LITERAL">DLS: Dead store of class literal (DLS_DEAD_STORE_OF_CLASS_LITERAL)</a></h3>
@@ -1547,6 +1628,15 @@
</p>
+<h3><a name="DMI_ARGUMENTS_WRONG_ORDER">DMI: Reversed method arguments (DMI_ARGUMENTS_WRONG_ORDER)</a></h3>
+
+
+<p> The arguments to this method call seem to be in the wrong order.
+For example, a call <code>Preconditions.checkNotNull("message", message)</code>
+has reserved arguments: the value to be checked is the first argument.
+</p>
+
+
<h3><a name="DMI_BAD_MONTH">DMI: Bad constant value for month (DMI_BAD_MONTH)</a></h3>
@@ -1556,6 +1646,19 @@
</p>
+<h3><a name="DMI_BIGDECIMAL_CONSTRUCTED_FROM_DOUBLE">DMI: BigDecimal constructed from double that isn't represented precisely (DMI_BIGDECIMAL_CONSTRUCTED_FROM_DOUBLE)</a></h3>
+
+
+ <p>
+This code creates a BigDecimal from a double value that doesn't translate well to a
+decimal number.
+For example, one might assume that writing new BigDecimal(0.1) in Java creates a BigDecimal which is exactly equal to 0.1 (an unscaled value of 1, with a scale of 1), but it is actually equal to 0.1000000000000000055511151231257827021181583404541015625.
+You probably want to use the BigDecimal.valueOf(double d) method, which uses the String representation
+of the double to create the BigDecimal (e.g., BigDecimal.valueOf(0.1) gives 0.1).
+</p>
+
+
+
<h3><a name="DMI_CALLING_NEXT_FROM_HASNEXT">DMI: hasNext method invokes next (DMI_CALLING_NEXT_FROM_HASNEXT)</a></h3>
@@ -1569,13 +1672,22 @@
<h3><a name="DMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVES">DMI: Collections should not contain themselves (DMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVES)</a></h3>
- <p> This call to a generic collection's method would only make sense if a collection contained
+ <p> This call to a generic collection's method would only make sense if a collection contained
itself (e.g., if <code>s.contains(s)</code> were true). This is unlikely to be true and would cause
problems if it were true (such as the computation of the hash code resulting in infinite recursion).
It is likely that the wrong value is being passed as a parameter.
- </p>
+ </p>
+<h3><a name="DMI_DOH">DMI: D'oh! A nonsensical method invocation (DMI_DOH)</a></h3>
+
+
+ <p>
+This partical method invocation doesn't make sense, for reasons that should be apparent from inspection.
+</p>
+
+
+
<h3><a name="DMI_INVOKING_HASHCODE_ON_ARRAY">DMI: Invocation of hashCode on an array (DMI_INVOKING_HASHCODE_ON_ARRAY)</a></h3>
@@ -1583,7 +1695,7 @@
The code invokes hashCode on an array. Calling hashCode on
an array returns the same value as System.identityHashCode, and ingores
the contents and length of the array. If you need a hashCode that
-depends on the contents of an array <code>a</code>,
+depends on the contents of an array <code>a</code>,
use <code>java.util.Arrays.hashCode(a)</code>.
</p>
@@ -1593,8 +1705,8 @@
<p> The Double.longBitsToDouble method is invoked, but a 32 bit int value is passed
- as an argument. This almostly certainly is not intended and is unlikely
- to give the intended result.
+ as an argument. This almostly certainly is not intended and is unlikely
+ to give the intended result.
</p>
@@ -1603,7 +1715,7 @@
<p> This call doesn't make sense. For any collection <code>c</code>, calling <code>c.containsAll(c)</code> should
always be true, and <code>c.retainAll(c)</code> should have no effect.
- </p>
+ </p>
<h3><a name="DMI_ANNOTATION_IS_NOT_VISIBLE_TO_REFLECTION">Dm: Can't use reflection to check for presence of annotation without runtime retention (DMI_ANNOTATION_IS_NOT_VISIBLE_TO_REFLECTION)</a></h3>
@@ -1617,16 +1729,16 @@
<h3><a name="DMI_FUTILE_ATTEMPT_TO_CHANGE_MAXPOOL_SIZE_OF_SCHEDULED_THREAD_POOL_EXECUTOR">Dm: Futile attempt to change max pool size of ScheduledThreadPoolExecutor (DMI_FUTILE_ATTEMPT_TO_CHANGE_MAXPOOL_SIZE_OF_SCHEDULED_THREAD_POOL_EXECUTOR)</a></h3>
- <p>(<a href="http://java.sun.com/javase/6/docs/api/java/util/concurrent/ScheduledThreadPoolExecutor.html">Javadoc</a>)
+ <p>(<a href="http://java.sun.com/javase/6/docs/api/java/util/concurrent/ScheduledThreadPoolExecutor.html">Javadoc</a>)
While ScheduledThreadPoolExecutor inherits from ThreadPoolExecutor, a few of the inherited tuning methods are not useful for it. In particular, because it acts as a fixed-sized pool using corePoolSize threads and an unbounded queue, adjustments to maximumPoolSize have no useful effect.
- </p>
+ </p>
<h3><a name="DMI_SCHEDULED_THREAD_POOL_EXECUTOR_WITH_ZERO_CORE_THREADS">Dm: Creation of ScheduledThreadPoolExecutor with zero core threads (DMI_SCHEDULED_THREAD_POOL_EXECUTOR_WITH_ZERO_CORE_THREADS)</a></h3>
- <p>(<a href="http://java.sun.com/javase/6/docs/api/java/util/concurrent/ScheduledThreadPoolExecutor.html#ScheduledThreadPoolExecutor(int)">Javadoc</a>)
+ <p>(<a href="http://java.sun.com/javase/6/docs/api/java/util/concurrent/ScheduledThreadPoolExecutor.html#ScheduledThreadPoolExecutor(int)">Javadoc</a>)
A ScheduledThreadPoolExecutor with zero core threads will never execute anything; changes to the max pool size are ignored.
</p>
@@ -1635,7 +1747,7 @@
<h3><a name="DMI_VACUOUS_CALL_TO_EASYMOCK_METHOD">Dm: Useless/vacuous call to EasyMock method (DMI_VACUOUS_CALL_TO_EASYMOCK_METHOD)</a></h3>
- <p>This call doesn't pass any objects to the EasyMock method, so the call doesn't do anything.
+ <p>This call doesn't pass any objects to the EasyMock method, so the call doesn't do anything.
</p>
@@ -1661,7 +1773,7 @@
method of Object, calling equals on an array is the same as comparing their addresses. To compare the
contents of the arrays, use <code>java.util.Arrays.equals(Object[], Object[])</code>.
To compare the addresses of the arrays, it would be
-less confusing to explicitly pointer equality using <code>==</code>.
+less confusing to explicitly check pointer equality using <code>==</code>.
</p>
@@ -1676,7 +1788,7 @@
</p>
-<h3><a name="EC_NULL_ARG">EC: Call to equals() with null argument (EC_NULL_ARG)</a></h3>
+<h3><a name="EC_NULL_ARG">EC: Call to equals(null) (EC_NULL_ARG)</a></h3>
<p> This method calls equals(Object), passing a null value as
@@ -1751,12 +1863,11 @@
<p> This class defines an equals method that always returns false. This means that an object is not equal to itself, and it is impossible to create useful Maps or Sets of this class. More fundamentally, it means
that equals is not reflexive, one of the requirements of the equals method.</p>
-<p>The likely intended semantics are object identity: that an object is equal to itself. This is the behavior inherited from class <code>Object</code>. If you need to override an equals inherited from a different
-superclass, you can use use:
+<p>The likely intended semantics are object identity: that an object is equal to itself. This is the behavior inherited from class <code>Object</code>. If you need to override an equals inherited from a different
+superclass, you can use use:</p>
<pre>
public boolean equals(Object o) { return this == o; }
</pre>
-</p>
<h3><a name="EQ_ALWAYS_TRUE">Eq: equals method always returns true (EQ_ALWAYS_TRUE)</a></h3>
@@ -1793,7 +1904,7 @@
<p> This class defines an <code>equals()</code>
method, that doesn't override the normal <code>equals(Object)</code> method
- defined in the base <code>java.lang.Object</code> class. Instead, it
+ defined in the base <code>java.lang.Object</code> class. Instead, it
inherits an <code>equals(Object)</code> method from a superclass.
The class should probably define a <code>boolean equals(Object)</code> method.
</p>
@@ -1836,15 +1947,15 @@
<p>
This code checks to see if a floating point value is equal to the special
- Not A Number value (e.g., <code>if (x == Double.NaN)</code>). However,
- because of the special semantics of <code>NaN</code>, no value
- is equal to <code>Nan</code>, including <code>NaN</code>. Thus,
- <code>x == Double.NaN</code> always evaluates to false.
+ Not A Number value (e.g., <code>if (x == Double.NaN)</code>). However,
+ because of the special semantics of <code>NaN</code>, no value
+ is equal to <code>Nan</code>, including <code>NaN</code>. Thus,
+ <code>x == Double.NaN</code> always evaluates to false.
- To check to see if a value contained in <code>x</code>
- is the special Not A Number value, use
- <code>Double.isNaN(x)</code> (or <code>Float.isNaN(x)</code> if
- <code>x</code> is floating point precision).
+ To check to see if a value contained in <code>x</code>
+ is the special Not A Number value, use
+ <code>Double.isNaN(x)</code> (or <code>Float.isNaN(x)</code> if
+ <code>x</code> is floating point precision).
</p>
@@ -1858,12 +1969,12 @@
System.out.println("%d\n", "hello");
</code>
<p>The %d placeholder requires a numeric argument, but a string value is
-passed instead.
-A runtime exception will occur when
+passed instead.
+A runtime exception will occur when
this statement is executed.
</p>
-
+
<h3><a name="VA_FORMAT_STRING_BAD_CONVERSION">FS: The type of a supplied argument doesn't match format specifier (VA_FORMAT_STRING_BAD_CONVERSION)</a></h3>
@@ -1874,7 +1985,7 @@
the String "1" is incompatible with the format specifier %d.
</p>
-
+
<h3><a name="VA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIED">FS: MessageFormat supplied where printf style format expected (VA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIED)</a></h3>
@@ -1886,80 +1997,79 @@
is required. At runtime, all of the arguments will be ignored
and the format string will be returned exactly as provided without any formatting.
</p>
-</p>
-
+
<h3><a name="VA_FORMAT_STRING_EXTRA_ARGUMENTS_PASSED">FS: More arguments are passed than are actually used in the format string (VA_FORMAT_STRING_EXTRA_ARGUMENTS_PASSED)</a></h3>
<p>
A format-string method with a variable number of arguments is called,
but more arguments are passed than are actually used by the format string.
-This won't cause a runtime exception, but the code may be silently omitting
+This won't cause a runtime exception, but the code may be silently omitting
information that was intended to be included in the formatted string.
</p>
-
+
<h3><a name="VA_FORMAT_STRING_ILLEGAL">FS: Illegal format string (VA_FORMAT_STRING_ILLEGAL)</a></h3>
<p>
-The format string is syntactically invalid,
-and a runtime exception will occur when
+The format string is syntactically invalid,
+and a runtime exception will occur when
this statement is executed.
</p>
-
+
<h3><a name="VA_FORMAT_STRING_MISSING_ARGUMENT">FS: Format string references missing argument (VA_FORMAT_STRING_MISSING_ARGUMENT)</a></h3>
<p>
Not enough arguments are passed to satisfy a placeholder in the format string.
-A runtime exception will occur when
+A runtime exception will occur when
this statement is executed.
</p>
-
+
<h3><a name="VA_FORMAT_STRING_NO_PREVIOUS_ARGUMENT">FS: No previous argument for format string (VA_FORMAT_STRING_NO_PREVIOUS_ARGUMENT)</a></h3>
<p>
The format string specifies a relative index to request that the argument for the previous format specifier
be reused. However, there is no previous argument.
-For example,
+For example,
</p>
<p><code>formatter.format("%<s %s", "a", "b")</code>
</p>
<p>would throw a MissingFormatArgumentException when executed.
</p>
-
+
<h3><a name="GC_UNRELATED_TYPES">GC: No relationship between generic parameter and method argument (GC_UNRELATED_TYPES)</a></h3>
<p> This call to a generic collection method contains an argument
with an incompatible class from that of the collection's parameter
- (i.e., the type of the argument is neither a supertype nor a subtype
- of the corresponding generic type argument).
- Therefore, it is unlikely that the collection contains any objects
- that are equal to the method argument used here.
- Most likely, the wrong value is being passed to the method.</p>
- <p>In general, instances of two unrelated classes are not equal.
- For example, if the <code>Foo</code> and <code>Bar</code> classes
- are not related by subtyping, then an instance of <code>Foo</code>
- should not be equal to an instance of <code>Bar</code>.
- Among other issues, doing so will likely result in an equals method
- that is not symmetrical. For example, if you define the <code>Foo</code> class
- so that a <code>Foo</code> can be equal to a <code>String</code>,
- your equals method isn't symmetrical since a <code>String</code> can only be equal
- to a <code>String</code>.
- </p>
- <p>In rare cases, people do define nonsymmetrical equals methods and still manage to make
- their code work. Although none of the APIs document or guarantee it, it is typically
- the case that if you check if a <code>Collection<String></code> contains
- a <code>Foo</code>, the equals method of argument (e.g., the equals method of the
- <code>Foo</code> class) used to perform the equality checks.
- </p>
+ (i.e., the type of the argument is neither a supertype nor a subtype
+ of the corresponding generic type argument).
+ Therefore, it is unlikely that the collection contains any objects
+ that are equal to the method argument used here.
+ Most likely, the wrong value is being passed to the method.</p>
+ <p>In general, instances of two unrelated classes are not equal.
+ For example, if the <code>Foo</code> and <code>Bar</code> classes
+ are not related by subtyping, then an instance of <code>Foo</code>
+ should not be equal to an instance of <code>Bar</code>.
+ Among other issues, doing so will likely result in an equals method
+ that is not symmetrical. For example, if you define the <code>Foo</code> class
+ so that a <code>Foo</code> can be equal to a <code>String</code>,
+ your equals method isn't symmetrical since a <code>String</code> can only be equal
+ to a <code>String</code>.
+ </p>
+ <p>In rare cases, people do define nonsymmetrical equals methods and still manage to make
+ their code work. Although none of the APIs document or guarantee it, it is typically
+ the case that if you check if a <code>Collection<String></code> contains
+ a <code>Foo</code>, the equals method of argument (e.g., the equals method of the
+ <code>Foo</code> class) used to perform the equality checks.
+ </p>
<h3><a name="HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS">HE: Signature declares use of unhashable class in hashed construct (HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS)</a></h3>
@@ -1982,11 +2092,39 @@
fix this problem of highest importance.
+<h3><a name="ICAST_INT_2_LONG_AS_INSTANT">ICAST: int value converted to long and used as absolute time (ICAST_INT_2_LONG_AS_INSTANT)</a></h3>
+
+
+<p>
+This code converts a 32-bit int value to a 64-bit long value, and then
+passes that value for a method parameter that requires an absolute time value.
+An absolute time value is the number
+of milliseconds since the standard base time known as "the epoch", namely January 1, 1970, 00:00:00 GMT.
+For example, the following method, intended to convert seconds since the epoc into a Date, is badly
+broken:</p>
+<pre>
+Date getDate(int seconds) { return new Date(seconds * 1000); }
+</pre>
+<p>The multiplication is done using 32-bit arithmetic, and then converted to a 64-bit value.
+When a 32-bit value is converted to 64-bits and used to express an absolute time
+value, only dates in December 1969 and January 1970 can be represented.</p>
+
+<p>Correct implementations for the above method are:</p>
+
+<pre>
+// Fails for dates after 2037
+Date getDate(int seconds) { return new Date(seconds * 1000L); }
+
+// better, works for all dates
+Date getDate(long seconds) { return new Date(seconds * 1000); }
+</pre>
+
+
<h3><a name="ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL">ICAST: integral value cast to double and then passed to Math.ceil (ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL)</a></h3>
<p>
-This code converts an integral value (e.g., int or long)
+This code converts an integral value (e.g., int or long)
to a double precision
floating point number and then
passing the result to the Math.ceil() function, which rounds a double to
@@ -2009,7 +2147,7 @@
to the argument. This operation should always be a no-op,
since the converting an integer to a float should give a number with no fractional part.
It is likely that the operation that generated the value to be passed
-to Math.round was intended to be performed using
+to Math.round was intended to be performed using
floating point arithmetic.
</p>
@@ -2030,11 +2168,10 @@
<p> Class is a JUnit TestCase and defines a suite() method.
-However, the suite method needs to be declared as either
+However, the suite method needs to be declared as either</p>
<pre>public static junit.framework.Test suite()</pre>
-or
+or
<pre>public static junit.framework.TestSuite suite()</pre>
-</p>
<h3><a name="IJU_NO_TESTS">IJU: TestCase has no tests (IJU_NO_TESTS)</a></h3>
@@ -2096,6 +2233,15 @@
</p>
+<h3><a name="INT_BAD_COMPARISON_WITH_INT_VALUE">INT: Bad comparison of int value with long constant (INT_BAD_COMPARISON_WITH_INT_VALUE)</a></h3>
+
+
+<p> This code compares an int value with a long constant that is outside
+the range of values that can be represented as an int value.
+This comparison is vacuous and possibily to be incorrect.
+</p>
+
+
<h3><a name="INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE">INT: Bad comparison of nonnegative value with negative constant (INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE)</a></h3>
@@ -2117,15 +2263,15 @@
<p>
- This code opens a file in append mode and then wraps the result in an object output stream.
+ This code opens a file in append mode and then wraps the result in an object output stream.
This won't allow you to append to an existing object output stream stored in a file. If you want to be
able to append to an object output stream, you need to keep the object output stream open.
</p>
<p>The only situation in which opening a file in append mode and the writing an object output stream
could work is if on reading the file you plan to open it in random access mode and seek to the byte offset
where the append started.
- </p>
-
+ </p>
+
<p>
TODO: example.
</p>
@@ -2183,9 +2329,9 @@
<p>
- A parameter to this method has been identified as a value that should
- always be checked to see whether or not it is null, but it is being dereferenced
- without a preceding null check.
+ A parameter to this method has been identified as a value that should
+ always be checked to see whether or not it is null, but it is being dereferenced
+ without a preceding null check.
</p>
@@ -2194,40 +2340,52 @@
<p> close() is being invoked on a value that is always null. If this statement is executed,
a null pointer exception will occur. But the big risk here you never close
-something that should be closed.
+something that should be closed.
<h3><a name="NP_GUARANTEED_DEREF">NP: Null value is guaranteed to be dereferenced (NP_GUARANTEED_DEREF)</a></h3>
-
- <p>
- There is a statement or branch that if executed guarantees that
- a value is null at this point, and that
- value that is guaranteed to be dereferenced
- (except on forward paths involving runtime exceptions).
- </p>
-
-
+
+ <p>
+ There is a statement or branch that if executed guarantees that
+ a value is null at this point, and that
+ value that is guaranteed to be dereferenced
+ (except on forward paths involving runtime exceptions).
+ </p>
+ <p>Note that a check such as
+ <code>if (x == null) throw new NullPointerException();</code>
+ is treated as a dereference of <code>x</code>.
+
+
<h3><a name="NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH">NP: Value is null and guaranteed to be dereferenced on exception path (NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH)</a></h3>
-
- <p>
- There is a statement or branch on an exception path
- that if executed guarantees that
- a value is null at this point, and that
- value that is guaranteed to be dereferenced
- (except on forward paths involving runtime exceptions).
- </p>
-
-
+
+ <p>
+ There is a statement or branch on an exception path
+ that if executed guarantees that
+ a value is null at this point, and that
+ value that is guaranteed to be dereferenced
+ (except on forward paths involving runtime exceptions).
+ </p>
+
+
+<h3><a name="NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR">NP: Nonnull field is not initialized (NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR)</a></h3>
+
+
+ <p> The field is marked as nonnull, but isn't written to by the constructor.
+ The field might be initialized elsewhere during constructor, or might always
+ be initialized before use.
+ </p>
+
+
<h3><a name="NP_NONNULL_PARAM_VIOLATION">NP: Method call passes null to a nonnull parameter (NP_NONNULL_PARAM_VIOLATION)</a></h3>
<p>
This method passes a null value as the parameter of a method which
- must be nonnull. Either this parameter has been explicitly marked
- as @Nonnull, or analysis has determined that this parameter is
- always dereferenced.
+ must be nonnull. Either this parameter has been explicitly marked
+ as @Nonnull, or analysis has determined that this parameter is
+ always dereferenced.
</p>
@@ -2279,9 +2437,9 @@
<p>
This method call passes a null value for a nonnull method parameter.
- Either the parameter is annotated as a parameter that should
- always be nonnull, or analysis has shown that it will always be
- dereferenced.
+ Either the parameter is annotated as a parameter that should
+ always be nonnull, or analysis has shown that it will always be
+ dereferenced.
</p>
@@ -2291,9 +2449,9 @@
<p>
A possibly-null value is passed at a call site where all known
target methods require the parameter to be nonnull.
- Either the parameter is annotated as a parameter that should
- always be nonnull, or analysis has shown that it will always be
- dereferenced.
+ Either the parameter is annotated as a parameter that should
+ always be nonnull, or analysis has shown that it will always be
+ dereferenced.
</p>
@@ -2302,9 +2460,9 @@
<p>
A possibly-null value is passed to a nonnull method parameter.
- Either the parameter is annotated as a parameter that should
- always be nonnull, or analysis has shown that it will always be
- dereferenced.
+ Either the parameter is annotated as a parameter that should
+ always be nonnull, or analysis has shown that it will always be
+ dereferenced.
</p>
@@ -2318,7 +2476,8 @@
<p> The program is dereferencing a field that does not seem to ever have a non-null value written to it.
-Dereferencing this value will generate a null pointer exception.
+Unless the field is initialized via some mechanism not seen by the analysis,
+dereferencing this value will generate a null pointer exception.
</p>
@@ -2351,15 +2510,15 @@
<p> This regular method has the same name as the class it is defined in. It is likely that this was intended to be a constructor.
If it was intended to be a constructor, remove the declaration of a void return value.
- If you had accidently defined this method, realized the mistake, defined a proper constructor
- but can't get rid of this method due to backwards compatibility, deprecate the method.
+ If you had accidently defined this method, realized the mistake, defined a proper constructor
+ but can't get rid of this method due to backwards compatibility, deprecate the method.
</p>
<h3><a name="NM_VERY_CONFUSING">Nm: Very confusing method names (NM_VERY_CONFUSING)</a></h3>
- <p> The referenced methods have names that differ only by capitalization.
+ <p> The referenced methods have names that differ only by capitalization.
This is very confusing because if the capitalization were
identical then one of the methods would override the other.
</p>
@@ -2386,7 +2545,7 @@
</blockquote>
<p>The <code>f(Foo)</code> method defined in class <code>B</code> doesn't
-override the
+override the
<code>f(Foo)</code> method defined in class <code>A</code>, because the argument
types are <code>Foo</code>'s from different packages.
</p>
@@ -2397,7 +2556,7 @@
<p>
This method assigns a literal boolean value (true or false) to a boolean variable inside
- an if or while expression. Most probably this was supposed to be a boolean comparison using
+ an if or while expression. Most probably this was supposed to be a boolean comparison using
==, not an assignment using =.
</p>
@@ -2407,7 +2566,7 @@
<p> This method compares two reference values using the == or != operator,
where the correct way to compare instances of this type is generally
-with the equals() method.
+with the equals() method.
It is possible to create distinct instances that are equal but do not compare as == since
they are different objects.
Examples of classes which should generally
@@ -2419,7 +2578,7 @@
<p> A value is checked here to see whether it is null, but this value can't
be null because it was previously dereferenced and if it were null a null pointer
-exception would have occurred at the earlier dereference.
+exception would have occurred at the earlier dereference.
Essentially, this code and the previous dereference
disagree as to whether this value is allowed to be null. Either the check is redundant
or the previous dereference is erroneous.</p>
@@ -2439,7 +2598,7 @@
<p>
-The code here uses <code>File.separator</code>
+The code here uses <code>File.separator</code>
where a regular expression is required. This will fail on Windows
platforms, where the <code>File.separator</code> is a backslash, which is interpreted in a
regular expression as an escape character. Amoung other options, you can just use
@@ -2474,8 +2633,8 @@
<p> This code generates a hashcode and then computes
-the absolute value of that hashcode. If the hashcode
-is <code>Integer.MIN_VALUE</code>, then the result will be negative as well (since
+the absolute value of that hashcode. If the hashcode
+is <code>Integer.MIN_VALUE</code>, then the result will be negative as well (since
<code>Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE</code>).
</p>
<p>One out of 2^32 strings have a hashCode of Integer.MIN_VALUE,
@@ -2483,16 +2642,25 @@
</p>
-<h3><a name="RV_ABSOLUTE_VALUE_OF_RANDOM_INT">RV: Bad attempt to compute absolute value of signed 32-bit random integer (RV_ABSOLUTE_VALUE_OF_RANDOM_INT)</a></h3>
+<h3><a name="RV_ABSOLUTE_VALUE_OF_RANDOM_INT">RV: Bad attempt to compute absolute value of signed random integer (RV_ABSOLUTE_VALUE_OF_RANDOM_INT)</a></h3>
<p> This code generates a random signed integer and then computes
the absolute value of that random integer. If the number returned by the random number
-generator is <code>Integer.MIN_VALUE</code>, then the result will be negative as well (since
-<code>Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE</code>).
+generator is <code>Integer.MIN_VALUE</code>, then the result will be negative as well (since
+<code>Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE</code>). (Same problem arised for long values as well).
</p>
+<h3><a name="RV_CHECK_COMPARETO_FOR_SPECIFIC_RETURN_VALUE">RV: Code checks for specific values returned by compareTo (RV_CHECK_COMPARETO_FOR_SPECIFIC_RETURN_VALUE)</a></h3>
+
+
+ <p> This code invoked a compareTo or compare method, and checks to see if the return value is a specific value,
+such as 1 or -1. When invoking these methods, you should only check the sign of the result, not for any specific
+non-zero value. While many or most compareTo and compare methods only return -1, 0 or 1, some of them
+will return other values.
+
+
<h3><a name="RV_EXCEPTION_NOT_THROWN">RV: Exception created and dropped rather than thrown (RV_EXCEPTION_NOT_THROWN)</a></h3>
@@ -2543,24 +2711,10 @@
<p>The code contains a conditional test is performed twice, one right after the other
(e.g., <code>x == 0 || x == 0</code>). Perhaps the second occurrence is intended to be something else
-(e.g., <code>x == 0 || y == 0</code>).
+(e.g., <code>x == 0 || y == 0</code>).
</p>
-<h3><a name="SA_FIELD_DOUBLE_ASSIGNMENT">SA: Double assignment of field (SA_FIELD_DOUBLE_ASSIGNMENT)</a></h3>
-
-
-<p> This method contains a double assignment of a field; e.g.
-</p>
-<pre>
- int x,y;
- public void foo() {
- x = x = 17;
- }
-</pre>
-<p>Assigning to a field twice is useless, and may indicate a logic error or typo.</p>
-
-
<h3><a name="SA_FIELD_SELF_ASSIGNMENT">SA: Self assignment of field (SA_FIELD_SELF_ASSIGNMENT)</a></h3>
@@ -2594,6 +2748,21 @@
</p>
+<h3><a name="SA_LOCAL_SELF_ASSIGNMENT_INSTEAD_OF_FIELD">SA: Self assignment of local rather than assignment to field (SA_LOCAL_SELF_ASSIGNMENT_INSTEAD_OF_FIELD)</a></h3>
+
+
+<p> This method contains a self assignment of a local variable, and there
+is a field with an identical name.
+assignment appears to have been ; e.g.</p>
+<pre>
+ int foo;
+ public void setFoo(int foo) {
+ foo = foo;
+ }
+</pre>
+<p>The assignment is useless. Did you mean to assign to the field instead?</p>
+
+
<h3><a name="SA_LOCAL_SELF_COMPARISON">SA: Self comparison of value with itself (SA_LOCAL_SELF_COMPARISON)</a></h3>
@@ -2617,7 +2786,7 @@
<p> A value stored in the previous switch case is overwritten here due to a switch fall through. It is likely that
- you forgot to put a break or return at the end of the previous case.
+ you forgot to put a break or return at the end of the previous case.
</p>
@@ -2625,8 +2794,8 @@
<p> A value stored in the previous switch case is ignored here due to a switch fall through to a place where
- an exception is thrown. It is likely that
- you forgot to put a break or return at the end of the previous case.
+ an exception is thrown. It is likely that
+ you forgot to put a break or return at the end of the previous case.
</p>
@@ -2636,7 +2805,7 @@
<p> This class is an inner class, but should probably be a static inner class.
As it is, there is a serious danger of a deadly embrace between the inner class
and the thread local in the outer class. Because the inner class isn't static,
- it retains a reference to the outer class.
+ it retains a reference to the outer class.
If the thread local contains a reference to an instance of the inner
class, the inner and outer instance will both be reachable
and not eligible for garbage collection.
@@ -2707,18 +2876,18 @@
consumed in a location or locations requiring that the value not
carry that annotation.
</p>
-
+
<p>
More precisely, a value annotated with a type qualifier specifying when=ALWAYS
is guaranteed to reach a use or uses where the same type qualifier specifies when=NEVER.
</p>
-
+
<p>
For example, say that @NonNegative is a nickname for
the type qualifier annotation @Negative(when=When.NEVER).
The following code will generate this warning because
the return statement requires a @NonNegative value,
- but receives one that is marked as @Negative.
+ but receives one that is marked as @Negative.
</p>
<blockquote>
<pre>
@@ -2729,13 +2898,42 @@
</blockquote>
+<h3><a name="TQ_COMPARING_VALUES_WITH_INCOMPATIBLE_TYPE_QUALIFIERS">TQ: Comparing values with incompatible type qualifiers (TQ_COMPARING_VALUES_WITH_INCOMPATIBLE_TYPE_QUALIFIERS)</a></h3>
+
+
+ <p>
+ A value specified as carrying a type qualifier annotation is
+ compared with a value that doesn't ever carry that qualifier.
+ </p>
+
+ <p>
+ More precisely, a value annotated with a type qualifier specifying when=ALWAYS
+ is compared with a value that where the same type qualifier specifies when=NEVER.
+ </p>
+
+ <p>
+ For example, say that @NonNegative is a nickname for
+ the type qualifier annotation @Negative(when=When.NEVER).
+ The following code will generate this warning because
+ the return statement requires a @NonNegative value,
+ but receives one that is marked as @Negative.
+ </p>
+ <blockquote>
+<pre>
+public boolean example(@Negative Integer value1, @NonNegative Integer value2) {
+ return value1.equals(value2);
+}
+</pre>
+ </blockquote>
+
+
<h3><a name="TQ_MAYBE_SOURCE_VALUE_REACHES_ALWAYS_SINK">TQ: Value that might not carry a type qualifier is always used in a way requires that type qualifier (TQ_MAYBE_SOURCE_VALUE_REACHES_ALWAYS_SINK)</a></h3>
<p>
A value that is annotated as possibility not being an instance of
- the values denoted by the type qualifier, and the value is guaranteed to be used
- in a way that requires values denoted by that type qualifier.
+ the values denoted by the type qualifier, and the value is guaranteed to be used
+ in a way that requires values denoted by that type qualifier.
</p>
@@ -2744,8 +2942,8 @@
<p>
A value that is annotated as possibility being an instance of
- the values denoted by the type qualifier, and the value is guaranteed to be used
- in a way that prohibits values denoted by that type qualifier.
+ the values denoted by the type qualifier, and the value is guaranteed to be used
+ in a way that prohibits values denoted by that type qualifier.
</p>
@@ -2757,7 +2955,7 @@
to be consumed in a location or locations requiring that the value does
carry that annotation.
</p>
-
+
<p>
More precisely, a value annotated with a type qualifier specifying when=NEVER
is guaranteed to reach a use or uses where the same type qualifier specifies when=ALWAYS.
@@ -2765,7 +2963,24 @@
<p>
TODO: example
- </p>
+ </p>
+
+
+<h3><a name="TQ_UNKNOWN_VALUE_USED_WHERE_ALWAYS_STRICTLY_REQUIRED">TQ: Value without a type qualifier used where a value is required to have that qualifier (TQ_UNKNOWN_VALUE_USED_WHERE_ALWAYS_STRICTLY_REQUIRED)</a></h3>
+
+
+ <p>
+ A value is being used in a way that requires the value be annotation with a type qualifier.
+ The type qualifier is strict, so the tool rejects any values that do not have
+ the appropriate annotation.
+ </p>
+
+ <p>
+ To coerce a value to have a strict annotation, define an identity function where the return value is annotated
+ with the strict annotation.
+ This is the only way to turn a non-annotated value into a value with a strict type qualifier annotation.
+ </p>
+
<h3><a name="UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS">UMAC: Uncallable method defined in anonymous class (UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS)</a></h3>
@@ -2792,7 +3007,7 @@
<p> This method is invoked in the constructor of of the superclass. At this point,
- the fields of the class have not yet initialized.</p>
+ the fields of the class have not yet initialized.</p>
<p>To make this more concrete, consider the following classes:</p>
<pre>abstract class A {
int hashCode;
@@ -2818,7 +3033,7 @@
</p>
-<h3><a name="DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY">USELESS_STRING: Invocation of toString on an array (DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY)</a></h3>
+<h3><a name="DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY">USELESS_STRING: Invocation of toString on an unnamed array (DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY)</a></h3>
<p>
@@ -2848,7 +3063,7 @@
Consider wrapping the array using <code>Arrays.asList(...)</code> before handling it off to a formatted.
</p>
-
+
<h3><a name="UWF_NULL_FIELD">UwF: Field only ever set to null (UWF_NULL_FIELD)</a></h3>
@@ -2875,7 +3090,7 @@
<h3><a name="LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE">LG: Potential lost logger changes due to weak reference in OpenJDK (LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE)</a></h3>
-
+
<p>OpenJDK introduces a potential incompatibility.
In particular, the java.util.logging.Logger behavior has
changed. Instead of using strong references, it now uses weak references
@@ -2886,80 +3101,145 @@
consider:
</p>
-<p><pre>public static void initLogging() throws Exception {
+<pre>public static void initLogging() throws Exception {
Logger logger = Logger.getLogger("edu.umd.cs");
logger.addHandler(new FileHandler()); // call to change logger configuration
logger.setUseParentHandlers(false); // another call to change logger configuration
-}</pre></p>
+}</pre>
<p>The logger reference is lost at the end of the method (it doesn't
escape the method), so if you have a garbage collection cycle just
after the call to initLogging, the logger configuration is lost
(because Logger only keeps weak references).</p>
-<p><pre>public static void main(String[] args) throws Exception {
+<pre>public static void main(String[] args) throws Exception {
initLogging(); // adds a file handler to the logger
System.gc(); // logger configuration lost
Logger.getLogger("edu.umd.cs").info("Some message"); // this isn't logged to the file as expected
-}</pre></p>
+}</pre>
<p><em>Ulf Ochsenfahrt and Eric Fellheimer</em></p>
-
-
+
+
<h3><a name="OBL_UNSATISFIED_OBLIGATION">OBL: Method may fail to clean up stream or resource (OBL_UNSATISFIED_OBLIGATION)</a></h3>
-
- <p>
- This method may fail to clean up (close, dispose of) a stream,
- database object, or other
- resource requiring an explicit cleanup operation.
- </p>
-
- <p>
- In general, if a method opens a stream or other resource,
- the method should use a try/finally block to ensure that
- the stream or resource is cleaned up before the method
- returns.
- </p>
-
- <p>
- This bug pattern is essentially the same as the
- OS_OPEN_STREAM and ODR_OPEN_DATABASE_RESOURCE
- bug patterns, but is based on a different
- (and hopefully better) static analysis technique.
- We are interested is getting feedback about the
- usefulness of this bug pattern.
- To send feedback, either:
- </p>
- <ul>
- <li>send email to findbugs@cs.umd.edu</li>
- <li>file a bug report: <a href="http://findbugs.sourceforge.net/reportingBugs.html">http://findbugs.sourceforge.net/reportingBugs.html</a></li>
- </ul>
-
- <p>
- In particular,
- the false-positive suppression heuristics for this
- bug pattern have not been extensively tuned, so
- reports about false positives are helpful to us.
- </p>
-
- <p>
- See Weimer and Necula, <i>Finding and Preventing Run-Time Error Handling Mistakes</i>, for
- a description of the analysis technique.
- </p>
-
-
+
+ <p>
+ This method may fail to clean up (close, dispose of) a stream,
+ database object, or other
+ resource requiring an explicit cleanup operation.
+ </p>
+
+ <p>
+ In general, if a method opens a stream or other resource,
+ the method should use a try/finally block to ensure that
+ the stream or resource is cleaned up before the method
+ returns.
+ </p>
+
+ <p>
+ This bug pattern is essentially the same as the
+ OS_OPEN_STREAM and ODR_OPEN_DATABASE_RESOURCE
+ bug patterns, but is based on a different
+ (and hopefully better) static analysis technique.
+ We are interested is getting feedback about the
+ usefulness of this bug pattern.
+ To send feedback, either:
+ </p>
+ <ul>
+ <li>send email to findbugs@cs.umd.edu</li>
+ <li>file a bug report: <a href="http://findbugs.sourceforge.net/reportingBugs.html">http://findbugs.sourceforge.net/reportingBugs.html</a></li>
+ </ul>
+
+ <p>
+ In particular,
+ the false-positive suppression heuristics for this
+ bug pattern have not been extensively tuned, so
+ reports about false positives are helpful to us.
+ </p>
+
+ <p>
+ See Weimer and Necula, <i>Finding and Preventing Run-Time Error Handling Mistakes</i>, for
+ a description of the analysis technique.
+ </p>
+
+
+<h3><a name="OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE">OBL: Method may fail to clean up stream or resource on checked exception (OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE)</a></h3>
+
+
+ <p>
+ This method may fail to clean up (close, dispose of) a stream,
+ database object, or other
+ resource requiring an explicit cleanup operation.
+ </p>
+
+ <p>
+ In general, if a method opens a stream or other resource,
+ the method should use a try/finally block to ensure that
+ the stream or resource is cleaned up before the method
+ returns.
+ </p>
+
+ <p>
+ This bug pattern is essentially the same as the
+ OS_OPEN_STREAM and ODR_OPEN_DATABASE_RESOURCE
+ bug patterns, but is based on a different
+ (and hopefully better) static analysis technique.
+ We are interested is getting feedback about the
+ usefulness of this bug pattern.
+ To send feedback, either:
+ </p>
+ <ul>
+ <li>send email to findbugs@cs.umd.edu</li>
+ <li>file a bug report: <a href="http://findbugs.sourceforge.net/reportingBugs.html">http://findbugs.sourceforge.net/reportingBugs.html</a></li>
+ </ul>
+
+ <p>
+ In particular,
+ the false-positive suppression heuristics for this
+ bug pattern have not been extensively tuned, so
+ reports about false positives are helpful to us.
+ </p>
+
+ <p>
+ See Weimer and Necula, <i>Finding and Preventing Run-Time Error Handling Mistakes</i>, for
+ a description of the analysis technique.
+ </p>
+
+
<h3><a name="DM_CONVERT_CASE">Dm: Consider using Locale parameterized version of invoked method (DM_CONVERT_CASE)</a></h3>
<p> A String is being converted to upper or lowercase, using the platform's default encoding. This may
result in improper conversions when used with international characters. Use the </p>
<ul>
- <li>String.toUpperCase( Locale l )</li>
- <li>String.toLowerCase( Locale l )</li>
- </ul>
+ <li>String.toUpperCase( Locale l )</li>
+ <li>String.toLowerCase( Locale l )</li>
+ </ul>
<p>versions instead.</p>
+<h3><a name="DM_DEFAULT_ENCODING">Dm: Reliance on default encoding (DM_DEFAULT_ENCODING)</a></h3>
+
+
+<p> Found a call to a method which will perform a byte to String (or String to byte) conversion, and will assume that the default platform encoding is suitable. This will cause the application behaviour to vary between platforms. Use an alternative API and specify a charset name or Charset object explicitly. </p>
+
+
+<h3><a name="DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED">DP: Classloaders should only be created inside doPrivileged block (DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED)</a></h3>
+
+
+ <p> This code creates a classloader, which needs permission if a security manage is installed.
+ If this code might be invoked by code that does not
+ have security permissions, then the classloader creation needs to occur inside a doPrivileged block.</p>
+
+
+<h3><a name="DP_DO_INSIDE_DO_PRIVILEGED">DP: Method invoked that should be only be invoked inside a doPrivileged block (DP_DO_INSIDE_DO_PRIVILEGED)</a></h3>
+
+
+ <p> This code invokes a method that requires a security permission check.
+ If this code will be granted security permissions, but might be invoked by code that does not
+ have security permissions, then the invocation needs to occur inside a doPrivileged block.</p>
+
+
<h3><a name="EI_EXPOSE_REP">EI: May expose internal representation by returning reference to mutable object (EI_EXPOSE_REP)</a></h3>
@@ -3080,12 +3360,34 @@
<p>
- A mutable static field could be changed by malicious code or
+This static field public but not final, and
+could be changed by malicious code or
by accident from another package.
The field could be made final to avoid
this vulnerability.</p>
+<h3><a name="MS_SHOULD_BE_REFACTORED_TO_BE_FINAL">MS: Field isn't final but should be refactored to be so (MS_SHOULD_BE_REFACTORED_TO_BE_FINAL)</a></h3>
+
+
+ <p>
+This static field public but not final, and
+could be changed by malicious code or
+by accident from another package.
+The field could be made final to avoid
+this vulnerability. However, the static initializer contains more than one write
+to the field, so doing so will require some refactoring.
+</p>
+
+
+<h3><a name="AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION">AT: Sequence of calls to concurrent abstraction may not be atomic (AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION)</a></h3>
+
+
+ <p>This code contains a sequence of calls to a concurrent abstraction
+ (such as a concurrent hash map).
+ These calls will not be executed atomically.
+
+
<h3><a name="DC_DOUBLECHECK">DC: Possible double check of field (DC_DOUBLECHECK)</a></h3>
@@ -3096,14 +3398,14 @@
>http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html</a>.</p>
-<h3><a name="DL_SYNCHRONIZATION_ON_BOOLEAN">DL: Synchronization on Boolean could lead to deadlock (DL_SYNCHRONIZATION_ON_BOOLEAN)</a></h3>
+<h3><a name="DL_SYNCHRONIZATION_ON_BOOLEAN">DL: Synchronization on Boolean (DL_SYNCHRONIZATION_ON_BOOLEAN)</a></h3>
- <p> The code synchronizes on a boxed primitive constant, such as an Boolean.
+ <p> The code synchronizes on a boxed primitive constant, such as an Boolean.</p>
<pre>
private static Boolean inited = Boolean.FALSE;
...
- synchronized(inited) {
+ synchronized(inited) {
if (!inited) {
init();
inited = Boolean.TRUE;
@@ -3111,67 +3413,67 @@
}
...
</pre>
-</p>
<p>Since there normally exist only two Boolean objects, this code could be synchronizing on the same object as other, unrelated code, leading to unresponsiveness
and possible deadlock</p>
+<p>See CERT <a href="https://www.securecoding.cert.org/confluence/display/java/CON08-J.+Do+not+synchronize+on+objects+that+may+be+reused">CON08-J. Do not synchronize on objects that may be reused</a> for more information.</p>
-<h3><a name="DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE">DL: Synchronization on boxed primitive could lead to deadlock (DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE)</a></h3>
+<h3><a name="DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE">DL: Synchronization on boxed primitive (DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE)</a></h3>
- <p> The code synchronizes on a boxed primitive constant, such as an Integer.
+ <p> The code synchronizes on a boxed primitive constant, such as an Integer.</p>
<pre>
private static Integer count = 0;
...
- synchronized(count) {
+ synchronized(count) {
count++;
}
...
</pre>
-</p>
<p>Since Integer objects can be cached and shared,
this code could be synchronizing on the same object as other, unrelated code, leading to unresponsiveness
and possible deadlock</p>
+<p>See CERT <a href="https://www.securecoding.cert.org/confluence/display/java/CON08-J.+Do+not+synchronize+on+objects+that+may+be+reused">CON08-J. Do not synchronize on objects that may be reused</a> for more information.</p>
-<h3><a name="DL_SYNCHRONIZATION_ON_SHARED_CONSTANT">DL: Synchronization on interned String could lead to deadlock (DL_SYNCHRONIZATION_ON_SHARED_CONSTANT)</a></h3>
+<h3><a name="DL_SYNCHRONIZATION_ON_SHARED_CONSTANT">DL: Synchronization on interned String (DL_SYNCHRONIZATION_ON_SHARED_CONSTANT)</a></h3>
- <p> The code synchronizes on interned String.
+ <p> The code synchronizes on interned String.</p>
<pre>
private static String LOCK = "LOCK";
...
synchronized(LOCK) { ...}
...
</pre>
-</p>
<p>Constant Strings are interned and shared across all other classes loaded by the JVM. Thus, this could
is locking on something that other code might also be locking. This could result in very strange and hard to diagnose
blocking and deadlock behavior. See <a href="http://www.javalobby.org/java/forums/t96352.html">http://www.javalobby.org/java/forums/t96352.html</a> and <a href="http://jira.codehaus.org/browse/JETTY-352">http://jira.codehaus.org/browse/JETTY-352</a>.
</p>
+<p>See CERT <a href="https://www.securecoding.cert.org/confluence/display/java/CON08-J.+Do+not+synchronize+on+objects+that+may+be+reused">CON08-J. Do not synchronize on objects that may be reused</a> for more information.</p>
<h3><a name="DL_SYNCHRONIZATION_ON_UNSHARED_BOXED_PRIMITIVE">DL: Synchronization on boxed primitive values (DL_SYNCHRONIZATION_ON_UNSHARED_BOXED_PRIMITIVE)</a></h3>
- <p> The code synchronizes on an apparently unshared boxed primitive,
-such as an Integer.
+ <p> The code synchronizes on an apparently unshared boxed primitive,
+such as an Integer.</p>
<pre>
private static final Integer fileLock = new Integer(1);
...
- synchronized(fileLock) {
+ synchronized(fileLock) {
.. do something ..
}
...
</pre>
-</p>
-<p>It would be much better, in this code, to redeclare fileLock as
+<p>It would be much better, in this code, to redeclare fileLock as</p>
<pre>
private static final Object fileLock = new Object();
</pre>
-The existing code might be OK, but it is confusing and a
+<p>
+The existing code might be OK, but it is confusing and a
future refactoring, such as the "Remove Boxing" refactoring in IntelliJ,
-might replace this with the use of an interned Integer object shared
+might replace this with the use of an interned Integer object shared
throughout the JVM, leading to very confusing behavior and potential deadlock.
</p>
@@ -3241,7 +3543,7 @@
<h3><a name="IS_FIELD_NOT_GUARDED">IS: Field not guarded against concurrent access (IS_FIELD_NOT_GUARDED)</a></h3>
- <p> This field is annotated with net.jcip.annotations.GuardedBy,
+ <p> This field is annotated with net.jcip.annotations.GuardedBy,
but can be accessed in a way that seems to violate the annotation.</p>
@@ -3250,12 +3552,42 @@
<p> This method performs synchronization an object that implements
java.util.concurrent.locks.Lock. Such an object is locked/unlocked
-using
+using
<code>acquire()</code>/<code>release()</code> rather
than using the <code>synchronized (...)</code> construct.
</p>
+<h3><a name="JLM_JSR166_UTILCONCURRENT_MONITORENTER">JLM: Synchronization performed on util.concurrent instance (JLM_JSR166_UTILCONCURRENT_MONITORENTER)</a></h3>
+
+
+<p> This method performs synchronization an object that is an instance of
+a class from the java.util.concurrent package (or its subclasses). Instances
+of these classes have their own concurrency control mechanisms that are orthogonal to
+the synchronization provided by the Java keyword <code>synchronized</code>. For example,
+synchronizing on an <code>AtomicBoolean</code> will not prevent other threads
+from modifying the <code>AtomicBoolean</code>.</p>
+<p>Such code may be correct, but should be carefully reviewed and documented,
+and may confuse people who have to maintain the code at a later date.
+</p>
+
+
+<h3><a name="JML_JSR166_CALLING_WAIT_RATHER_THAN_AWAIT">JLM: Using monitor style wait methods on util.concurrent abstraction (JML_JSR166_CALLING_WAIT_RATHER_THAN_AWAIT)</a></h3>
+
+
+<p> This method calls
+<code>wait()</code>,
+<code>notify()</code> or
+<code>notifyAll()()</code>
+on an object that also provides an
+<code>await()</code>,
+<code>signal()</code>,
+<code>signalAll()</code> method (such as util.concurrent Condition objects).
+This probably isn't what you want, and even if you do want it, you should consider changing
+your design, as other developers will find it exceptionally confusing.
+</p>
+
+
<h3><a name="LI_LAZY_INIT_STATIC">LI: Incorrect lazy initialization of static field (LI_LAZY_INIT_STATIC)</a></h3>
@@ -3289,12 +3621,11 @@
<p> This method synchronizes on a field in what appears to be an attempt
to guard against simultaneous updates to that field. But guarding a field
-gets a lock on the referenced object, not on the field. This may not
-provide the mutual exclusion you need, and other threads might
+gets a lock on the referenced object, not on the field. This may not
+provide the mutual exclusion you need, and other threads might
be obtaining locks on the referenced objects (for other purposes). An example
-of this pattern would be:
-
-<p><pre>
+of this pattern would be:</p>
+<pre>
private Long myNtfSeqNbrCounter = new Long(0);
private Long getNotificationSequenceNumber() {
Long result = null;
@@ -3306,9 +3637,6 @@
}
</pre>
-
-</p>
-
<h3><a name="ML_SYNC_ON_UPDATED_FIELD">ML: Method synchronizes on an updated field (ML_SYNC_ON_UPDATED_FIELD)</a></h3>
@@ -3323,9 +3651,9 @@
<p>A web server generally only creates one instance of servlet or jsp class (i.e., treats
-the class as a Singleton),
-and will
-have multiple threads invoke methods on that instance to service multiple
+the class as a Singleton),
+and will
+have multiple threads invoke methods on that instance to service multiple
simultaneous requests.
Thus, having a mutable instance field generally creates race conditions.
@@ -3366,7 +3694,7 @@
<p>Since the field is synchronized on, it seems not likely to be null.
If it is null and then synchronized on a NullPointerException will be
-thrown and the check would be pointless. Better to synchronize on
+thrown and the check would be pointless. Better to synchronize on
another field.</p>
@@ -3393,16 +3721,16 @@
<h3><a name="RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED">RV: Return value of putIfAbsent ignored, value passed to putIfAbsent reused (RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED)</a></h3>
-
- The <code>putIfAbsent</code> method is typically used to ensure that a
- single value is associated with a given key (the first value for which put
- if absent succeeds).
- If you ignore the return value and retain a reference to the value passed in,
- you run the risk of retaining a value that is not the one that is associated with the key in the map.
- If it matters which one you use and you use the one that isn't stored in the map,
- your program will behave incorrectly.
-
-
+
+ The <code>putIfAbsent</code> method is typically used to ensure that a
+ single value is associated with a given key (the first value for which put
+ if absent succeeds).
+ If you ignore the return value and retain a reference to the value passed in,
+ you run the risk of retaining a value that is not the one that is associated with the key in the map.
+ If it matters which one you use and you use the one that isn't stored in the map,
+ your program will behave incorrectly.
+
+
<h3><a name="RU_INVOKE_RUN">Ru: Invokes run on a thread (did you mean to start it instead?) (RU_INVOKE_RUN)</a></h3>
@@ -3432,7 +3760,7 @@
<h3><a name="STCAL_INVOKE_ON_STATIC_CALENDAR_INSTANCE">STCAL: Call to static Calendar (STCAL_INVOKE_ON_STATIC_CALENDAR_INSTANCE)</a></h3>
-<p>Even though the JavaDoc does not contain a hint about it, Calendars are inherently unsafe for multihtreaded use.
+<p>Even though the JavaDoc does not contain a hint about it, Calendars are inherently unsafe for multihtreaded use.
The detector has found a call to an instance of Calendar that has been obtained via a static
field. This looks suspicous.</p>
<p>For more information on this see <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6231579">Sun Bug #6231579</a>
@@ -3442,17 +3770,17 @@
<h3><a name="STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE">STCAL: Call to static DateFormat (STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE)</a></h3>
-<p>As the JavaDoc states, DateFormats are inherently unsafe for multithreaded use.
+<p>As the JavaDoc states, DateFormats are inherently unsafe for multithreaded use.
The detector has found a call to an instance of DateFormat that has been obtained via a static
field. This looks suspicous.</p>
<p>For more information on this see <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6231579">Sun Bug #6231579</a>
and <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6178997">Sun Bug #6178997</a>.</p>
-<h3><a name="STCAL_STATIC_CALENDAR_INSTANCE">STCAL: Static Calendar (STCAL_STATIC_CALENDAR_INSTANCE)</a></h3>
+<h3><a name="STCAL_STATIC_CALENDAR_INSTANCE">STCAL: Static Calendar field (STCAL_STATIC_CALENDAR_INSTANCE)</a></h3>
-<p>Even though the JavaDoc does not contain a hint about it, Calendars are inherently unsafe for multihtreaded use.
+<p>Even though the JavaDoc does not contain a hint about it, Calendars are inherently unsafe for multihtreaded use.
Sharing a single instance across thread boundaries without proper synchronization will result in erratic behavior of the
application. Under 1.4 problems seem to surface less often than under Java 5 where you will probably see
random ArrayIndexOutOfBoundsExceptions or IndexOutOfBoundsExceptions in sun.util.calendar.BaseCalendar.getCalendarDateFromFixedDate().</p>
@@ -3465,7 +3793,7 @@
<h3><a name="STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE">STCAL: Static DateFormat (STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE)</a></h3>
-<p>As the JavaDoc states, DateFormats are inherently unsafe for multithreaded use.
+<p>As the JavaDoc states, DateFormats are inherently unsafe for multithreaded use.
Sharing a single instance across thread boundaries without proper synchronization will result in erratic behavior of the
application.</p>
<p>You may also experience serialization problems.</p>
@@ -3550,11 +3878,20 @@
<p> This method contains a call to <code>java.lang.Object.wait()</code> which
is not guarded by conditional control flow. The code should
- verify that condition it intends to wait for is not already satisfied
- before calling wait; any previous notifications will be ignored.
+ verify that condition it intends to wait for is not already satisfied
+ before calling wait; any previous notifications will be ignored.
</p>
+<h3><a name="VO_VOLATILE_INCREMENT">VO: An increment to a volatile field isn't atomic (VO_VOLATILE_INCREMENT)</a></h3>
+
+
+<p>This code increments a volatile field. Increments of volatile fields aren't
+atomic. If more than one thread is incrementing the field at the same time,
+increments could be lost.
+</p>
+
+
<h3><a name="VO_VOLATILE_REFERENCE_TO_ARRAY">VO: A volatile reference to an array doesn't treat the array elements as volatile (VO_VOLATILE_REFERENCE_TO_ARRAY)</a></h3>
@@ -3566,13 +3903,13 @@
in Java 5.0).</p>
-<h3><a name="WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL">WL: Sychronization on getClass rather than class literal (WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL)</a></h3>
+<h3><a name="WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL">WL: Synchronization on getClass rather than class literal (WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL)</a></h3>
<p>
This instance method synchronizes on <code>this.getClass()</code>. If this class is subclassed,
subclasses will synchronize on the class object for the subclass, which isn't likely what was intended.
- For example, consider this code from java.awt.Label:
+ For example, consider this code from java.awt.Label:</p>
<pre>
private static final String base = "label";
private static int nameCounter = 0;
@@ -3581,9 +3918,9 @@
return base + nameCounter++;
}
}
- </pre></p>
+ </pre>
<p>Subclasses of <code>Label</code> won't synchronize on the same subclass, giving rise to a datarace.
- Instead, this code should be synchronizing on <code>Label.class</code>
+ Instead, this code should be synchronizing on <code>Label.class</code></p>
<pre>
private static final String base = "label";
private static int nameCounter = 0;
@@ -3592,7 +3929,7 @@
return base + nameCounter++;
}
}
- </pre></p>
+ </pre>
<p>Bug pattern contributed by Jason Mehrens</p>
@@ -3626,7 +3963,7 @@
<p>A primitive is boxed, and then immediately unboxed. This probably is due to a manual
- boxing in a place where an unboxed value is required, thus forcing the compiler
+ boxing in a place where an unboxed value is required, thus forcing the compiler
to immediately undo the work of the boxing.
</p>
@@ -3638,6 +3975,13 @@
(e.g., <code>new Double(d).intValue()</code>). Just perform direct primitive coercion (e.g., <code>(int) d</code>).</p>
+<h3><a name="BX_UNBOXING_IMMEDIATELY_REBOXED">Bx: Boxed value is unboxed and then immediately reboxed (BX_UNBOXING_IMMEDIATELY_REBOXED)</a></h3>
+
+
+ <p>A boxed value is unboxed and then immediately reboxed.
+</p>
+
+
<h3><a name="DM_BOXED_PRIMITIVE_TOSTRING">Bx: Method allocates a boxed primitive just to call toString (DM_BOXED_PRIMITIVE_TOSTRING)</a></h3>
@@ -3743,6 +4087,9 @@
<p>If <code>r</code> is a <code>java.util.Random</code>, you can generate a random number from <code>0</code> to <code>n-1</code>
using <code>r.nextInt(n)</code>, rather than using <code>(int)(r.nextDouble() * n)</code>.
</p>
+<p>The argument to nextInt must be positive. If, for example, you want to generate a random
+value from -99 to 0, use <code>-r.nextInt(100)</code>.
+</p>
<h3><a name="DM_STRING_CTOR">Dm: Method invokes inefficient new String(String) constructor (DM_STRING_CTOR)</a></h3>
@@ -3776,12 +4123,12 @@
<p>
- A large String constant is duplicated across multiple class files.
- This is likely because a final field is initialized to a String constant, and the Java language
- mandates that all references to a final field from other classes be inlined into
+ A large String constant is duplicated across multiple class files.
+ This is likely because a final field is initialized to a String constant, and the Java language
+ mandates that all references to a final field from other classes be inlined into
that classfile. See <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6447475">JDK bug 6447475</a>
- for a description of an occurrence of this bug in the JDK and how resolving it reduced
- the size of the JDK by 1 megabyte.
+ for a description of an occurrence of this bug in the JDK and how resolving it reduced
+ the size of the JDK by 1 megabyte.
</p>
@@ -3988,8 +4335,8 @@
<h3><a name="DMI_CONSTANT_DB_PASSWORD">Dm: Hardcoded constant database password (DMI_CONSTANT_DB_PASSWORD)</a></h3>
- <p>This code creates a database connect using a hardcoded, constant password. Anyone with access to either the source code or the compiled code can
- easily learn the password.
+ <p>This code creates a database connect using a hardcoded, constant password. Anyone with access to either the source code or the compiled code can
+ easily learn the password.
</p>
@@ -3997,7 +4344,7 @@
<h3><a name="DMI_EMPTY_DB_PASSWORD">Dm: Empty database password (DMI_EMPTY_DB_PASSWORD)</a></h3>
- <p>This code creates a database connect using a blank or empty password. This indicates that the database is not protected by a password.
+ <p>This code creates a database connect using a blank or empty password. This indicates that the database is not protected by a password.
</p>
@@ -4005,12 +4352,12 @@
<h3><a name="HRS_REQUEST_PARAMETER_TO_COOKIE">HRS: HTTP cookie formed from untrusted input (HRS_REQUEST_PARAMETER_TO_COOKIE)</a></h3>
- <p>This code constructs an HTTP Cookie using an untrusted HTTP parameter. If this cookie is added to an HTTP response, it will allow a HTTP response splitting
+ <p>This code constructs an HTTP Cookie using an untrusted HTTP parameter. If this cookie is added to an HTTP response, it will allow a HTTP response splitting
vulnerability. See <a href="http://en.wikipedia.org/wiki/HTTP_response_splitting">http://en.wikipedia.org/wiki/HTTP_response_splitting</a>
for more information.</p>
<p>FindBugs looks only for the most blatant, obvious cases of HTTP response splitting.
-If FindBugs found <em>any</em>, you <em>almost certainly</em> have more
-vulnerabilities that FindBugs doesn't report. If you are concerned about HTTP response splitting, you should seriously
+If FindBugs found <em>any</em>, you <em>almost certainly</em> have more
+vulnerabilities that FindBugs doesn't report. If you are concerned about HTTP response splitting, you should seriously
consider using a commercial static analysis or pen-testing tool.
</p>
@@ -4019,17 +4366,48 @@
<h3><a name="HRS_REQUEST_PARAMETER_TO_HTTP_HEADER">HRS: HTTP Response splitting vulnerability (HRS_REQUEST_PARAMETER_TO_HTTP_HEADER)</a></h3>
- <p>This code directly writes an HTTP parameter to an HTTP header, which allows for a HTTP response splitting
+ <p>This code directly writes an HTTP parameter to an HTTP header, which allows for a HTTP response splitting
vulnerability. See <a href="http://en.wikipedia.org/wiki/HTTP_response_splitting">http://en.wikipedia.org/wiki/HTTP_response_splitting</a>
for more information.</p>
<p>FindBugs looks only for the most blatant, obvious cases of HTTP response splitting.
-If FindBugs found <em>any</em>, you <em>almost certainly</em> have more
-vulnerabilities that FindBugs doesn't report. If you are concerned about HTTP response splitting, you should seriously
+If FindBugs found <em>any</em>, you <em>almost certainly</em> have more
+vulnerabilities that FindBugs doesn't report. If you are concerned about HTTP response splitting, you should seriously
consider using a commercial static analysis or pen-testing tool.
</p>
+<h3><a name="PT_ABSOLUTE_PATH_TRAVERSAL">PT: Absolute path traversal in servlet (PT_ABSOLUTE_PATH_TRAVERSAL)</a></h3>
+
+
+ <p>The software uses an HTTP request parameter to construct a pathname that should be within a restricted directory,
+but it does not properly neutralize absolute path sequences such as "/abs/path" that can resolve to a location that is outside of that directory.
+
+See <a href="http://cwe.mitre.org/data/definitions/36.html">http://cwe.mitre.org/data/definitions/36.html</a>
+for more information.</p>
+<p>FindBugs looks only for the most blatant, obvious cases of absolute path traversal.
+If FindBugs found <em>any</em>, you <em>almost certainly</em> have more
+vulnerabilities that FindBugs doesn't report. If you are concerned about absolute path traversal, you should seriously
+consider using a commercial static analysis or pen-testing tool.
+</p>
+
+
+
+<h3><a name="PT_RELATIVE_PATH_TRAVERSAL">PT: Relative path traversal in servlet (PT_RELATIVE_PATH_TRAVERSAL)</a></h3>
+
+
+ <p>The software uses an HTTP request parameter to construct a pathname that should be within a restricted directory, but it does not properly neutralize sequences such as ".." that can resolve to a location that is outside of that directory.
+
+See <a href="http://cwe.mitre.org/data/definitions/23.html">http://cwe.mitre.org/data/definitions/23.html</a>
+for more information.</p>
+<p>FindBugs looks only for the most blatant, obvious cases of relative path traversal.
+If FindBugs found <em>any</em>, you <em>almost certainly</em> have more
+vulnerabilities that FindBugs doesn't report. If you are concerned about relative path traversal, you should seriously
+consider using a commercial static analysis or pen-testing tool.
+</p>
+
+
+
<h3><a name="SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE">SQL: Nonconstant string passed to execute method on an SQL statement (SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE)</a></h3>
@@ -4052,26 +4430,26 @@
<h3><a name="XSS_REQUEST_PARAMETER_TO_JSP_WRITER">XSS: JSP reflected cross site scripting vulnerability (XSS_REQUEST_PARAMETER_TO_JSP_WRITER)</a></h3>
- <p>This code directly writes an HTTP parameter to JSP output, which allows for a cross site scripting
+ <p>This code directly writes an HTTP parameter to JSP output, which allows for a cross site scripting
vulnerability. See <a href="http://en.wikipedia.org/wiki/Cross-site_scripting">http://en.wikipedia.org/wiki/Cross-site_scripting</a>
for more information.</p>
<p>FindBugs looks only for the most blatant, obvious cases of cross site scripting.
If FindBugs found <em>any</em>, you <em>almost certainly</em> have more cross site scripting
-vulnerabilities that FindBugs doesn't report. If you are concerned about cross site scripting, you should seriously
+vulnerabilities that FindBugs doesn't report. If you are concerned about cross site scripting, you should seriously
consider using a commercial static analysis or pen-testing tool.
</p>
-<h3><a name="XSS_REQUEST_PARAMETER_TO_SEND_ERROR">XSS: Servlet reflected cross site scripting vulnerability (XSS_REQUEST_PARAMETER_TO_SEND_ERROR)</a></h3>
+<h3><a name="XSS_REQUEST_PARAMETER_TO_SEND_ERROR">XSS: Servlet reflected cross site scripting vulnerability in error page (XSS_REQUEST_PARAMETER_TO_SEND_ERROR)</a></h3>
- <p>This code directly writes an HTTP parameter to a Server error page (using HttpServletResponse.sendError). Echoing this untrusted input allows
+ <p>This code directly writes an HTTP parameter to a Server error page (using HttpServletResponse.sendError). Echoing this untrusted input allows
for a reflected cross site scripting
vulnerability. See <a href="http://en.wikipedia.org/wiki/Cross-site_scripting">http://en.wikipedia.org/wiki/Cross-site_scripting</a>
for more information.</p>
<p>FindBugs looks only for the most blatant, obvious cases of cross site scripting.
If FindBugs found <em>any</em>, you <em>almost certainly</em> have more cross site scripting
-vulnerabilities that FindBugs doesn't report. If you are concerned about cross site scripting, you should seriously
+vulnerabilities that FindBugs doesn't report. If you are concerned about cross site scripting, you should seriously
consider using a commercial static analysis or pen-testing tool.
</p>
@@ -4080,12 +4458,12 @@
<h3><a name="XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER">XSS: Servlet reflected cross site scripting vulnerability (XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER)</a></h3>
- <p>This code directly writes an HTTP parameter to Servlet output, which allows for a reflected cross site scripting
+ <p>This code directly writes an HTTP parameter to Servlet output, which allows for a reflected cross site scripting
vulnerability. See <a href="http://en.wikipedia.org/wiki/Cross-site_scripting">http://en.wikipedia.org/wiki/Cross-site_scripting</a>
for more information.</p>
<p>FindBugs looks only for the most blatant, obvious cases of cross site scripting.
If FindBugs found <em>any</em>, you <em>almost certainly</em> have more cross site scripting
-vulnerabilities that FindBugs doesn't report. If you are concerned about cross site scripting, you should seriously
+vulnerabilities that FindBugs doesn't report. If you are concerned about cross site scripting, you should seriously
consider using a commercial static analysis or pen-testing tool.
</p>
@@ -4121,7 +4499,18 @@
<p>
This cast is unchecked, and not all instances of the type casted from can be cast to
-the type it is being cast to. Ensure that your program logic ensures that this
+the type it is being cast to. Check that your program logic ensures that this
+cast will not fail.
+</p>
+
+
+<h3><a name="BC_UNCONFIRMED_CAST_OF_RETURN_VALUE">BC: Unchecked/unconfirmed cast of return value from method (BC_UNCONFIRMED_CAST_OF_RETURN_VALUE)</a></h3>
+
+
+<p>
+This code performs an unchecked cast of the return value of a method.
+The code might be calling the method in such a way that the cast is guaranteed to be
+safe, but FindBugs is unable to verify that the cast is safe. Check that your program logic ensures that this
cast will not fail.
</p>
@@ -4130,7 +4519,7 @@
<p>
-This instanceof test will always return true (unless the value being tested is null).
+This instanceof test will always return true (unless the value being tested is null).
Although this is safe, make sure it isn't
an indication of some misunderstanding or some other logic error.
If you really want to test the value for being null, perhaps it would be clearer to do
@@ -4165,7 +4554,7 @@
<p>
This method uses the same code to implement two branches of a conditional branch.
- Check to ensure that this isn't a coding mistake.
+ Check to ensure that this isn't a coding mistake.
</p>
@@ -4174,8 +4563,8 @@
<p>
This method uses the same code to implement two clauses of a switch statement.
- This could be a case of duplicate code, but it might also indicate
- a coding mistake.
+ This could be a case of duplicate code, but it might also indicate
+ a coding mistake.
</p>
@@ -4199,7 +4588,7 @@
<p>
-This statement assigns to a local variable in a return statement. This assignment
+This statement assigns to a local variable in a return statement. This assignment
has effect. Please verify that this statement does the right thing.
</p>
@@ -4213,6 +4602,18 @@
</p>
+<h3><a name="DLS_DEAD_LOCAL_STORE_SHADOWS_FIELD">DLS: Dead store to local variable that shadows field (DLS_DEAD_LOCAL_STORE_SHADOWS_FIELD)</a></h3>
+
+
+<p>
+This instruction assigns a value to a local variable,
+but the value is not read or used in any subsequent instruction.
+Often, this indicates an error, because the value computed is never
+used. There is a field with the same name as the local variable. Did you
+mean to assign to that variable instead?
+</p>
+
+
<h3><a name="DMI_HARDCODED_ABSOLUTE_FILENAME">DMI: Code contains a hard coded reference to an absolute pathname (DMI_HARDCODED_ABSOLUTE_FILENAME)</a></h3>
@@ -4241,7 +4642,7 @@
<h3><a name="DMI_THREAD_PASSED_WHERE_RUNNABLE_EXPECTED">Dm: Thread passed where Runnable expected (DMI_THREAD_PASSED_WHERE_RUNNABLE_EXPECTED)</a></h3>
- <p> A Thread object is passed as a parameter to a method where
+ <p> A Thread object is passed as a parameter to a method where
a Runnable is expected. This is rather unusual, and may indicate a logic error
or cause unexpected behavior.
</p>
@@ -4263,7 +4664,7 @@
<h3><a name="EQ_UNUSUAL">Eq: Unusual equals method (EQ_UNUSUAL)</a></h3>
- <p> This class doesn't do any of the patterns we recognize for checking that the type of the argument
+ <p> This class doesn't do any of the patterns we recognize for checking that the type of the argument
is compatible with the type of the <code>this</code> object. There might not be anything wrong with
this code, but it is worth reviewing.
</p>
@@ -4294,7 +4695,7 @@
This feature of format strings is strange, and may not be what you intended.
</p>
-
+
<h3><a name="IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD">IA: Ambiguous invocation of either an inherited or outer method (IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD)</a></h3>
@@ -4320,7 +4721,7 @@
<p>
This code casts the result of an integral division (e.g., int or long division)
-operation to double or
+operation to double or
float.
Doing division on integers truncates the result
to the integer value closest to zero. The fact that the result
@@ -4346,26 +4747,22 @@
<p>
This code performs integer multiply and then converts the result to a long,
-as in:
-<code>
-<pre>
- long convertDaysToMilliseconds(int days) { return 1000*3600*24*days; }
-</pre></code>
+as in:</p>
+<pre>
+ long convertDaysToMilliseconds(int days) { return 1000*3600*24*days; }
+</pre>
+<p>
If the multiplication is done using long arithmetic, you can avoid
the possibility that the result will overflow. For example, you
-could fix the above code to:
-<code>
-<pre>
- long convertDaysToMilliseconds(int days) { return 1000L*3600*24*days; }
-</pre></code>
-or
-<code>
-<pre>
- static final long MILLISECONDS_PER_DAY = 24L*3600*1000;
- long convertDaysToMilliseconds(int days) { return days * MILLISECONDS_PER_DAY; }
-</pre></code>
-</p>
-
+could fix the above code to:</p>
+<pre>
+ long convertDaysToMilliseconds(int days) { return 1000L*3600*24*days; }
+</pre>
+or
+<pre>
+ static final long MILLISECONDS_PER_DAY = 24L*3600*1000;
+ long convertDaysToMilliseconds(int days) { return days * MILLISECONDS_PER_DAY; }
+</pre>
<h3><a name="IM_AVERAGE_COMPUTATION_COULD_OVERFLOW">IM: Computation of average could overflow (IM_AVERAGE_COMPUTATION_COULD_OVERFLOW)</a></h3>
@@ -4374,7 +4771,7 @@
<p>The code computes the average of two integers using either division or signed right shift,
and then uses the result as the index of an array.
If the values being averaged are very large, this can overflow (resulting in the computation
-of a negative average). Assuming that the result is intended to be nonnegative, you
+of a negative average). Assuming that the result is intended to be nonnegative, you
can use an unsigned right shift instead. In other words, rather that using <code>(low+high)/2</code>,
use <code>(low+high) >>> 1</code>
</p>
@@ -4404,6 +4801,15 @@
</p>
+<h3><a name="INT_VACUOUS_BIT_OPERATION">INT: Vacuous bit mask operation on integer value (INT_VACUOUS_BIT_OPERATION)</a></h3>
+
+
+<p> This is an integer bit operation (and, or, or exclusive or) that doesn't do any useful work
+(e.g., <code>v & 0xffffffff</code>).
+
+</p>
+
+
<h3><a name="INT_VACUOUS_COMPARISON">INT: Vacuous comparison of integer value (INT_VACUOUS_COMPARISON)</a></h3>
@@ -4431,7 +4837,7 @@
one instance of a struts Action class is created by the Struts framework, and used in a
multithreaded way, this paradigm is highly discouraged and most likely problematic. Consider
only using method local variables. Only instance fields that are written outside of a monitor
- are reported.
+ are reported.
</p>
@@ -4470,7 +4876,7 @@
</p>
-<h3><a name="NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE">NP: Possible null pointer dereference on path that might be infeasible (NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE)</a></h3>
+<h3><a name="NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE">NP: Possible null pointer dereference on branch that might be infeasible (NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE)</a></h3>
<p> There is a branch of statement that, <em>if executed,</em> guarantees that
@@ -4478,7 +4884,8 @@
would generate a <code>NullPointerException</code> when the code is executed.
Of course, the problem might be that the branch or statement is infeasible and that
the null pointer exception can't ever be executed; deciding that is beyond the ability of FindBugs.
-Due to the fact that this value had been previously tested for nullness, this is a definite possibility.
+Due to the fact that this value had been previously tested for nullness,
+this is a definite possibility.
</p>
@@ -4491,12 +4898,22 @@
</p>
+<h3><a name="NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD">NP: Read of unwritten public or protected field (NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD)</a></h3>
+
+
+ <p> The program is dereferencing a public or protected
+field that does not seem to ever have a non-null value written to it.
+Unless the field is initialized via some mechanism not seen by the analysis,
+dereferencing this value will generate a null pointer exception.
+</p>
+
+
<h3><a name="NS_DANGEROUS_NON_SHORT_CIRCUIT">NS: Potentially dangerous use of non-short-circuit logic (NS_DANGEROUS_NON_SHORT_CIRCUIT)</a></h3>
<p> This code seems to be using non-short-circuit logic (e.g., &
or |)
-rather than short-circuit logic (&& or ||). In addition,
+rather than short-circuit logic (&& or ||). In addition,
it seem possible that, depending on the value of the left hand side, you might not
want to evaluate the right hand side (because it would have side effects, could cause an exception
or could be expensive.</p>
@@ -4594,6 +5011,16 @@
each of whose catch blocks is identical, but this construct also accidentally catches RuntimeException as well,
masking potential bugs.
</p>
+ <p>A better approach is to either explicitly catch the specific exceptions that are thrown,
+ or to explicitly catch RuntimeException exception, rethrow it, and then catch all non-Runtime Exceptions, as shown below:</p>
+ <pre>
+ try {
+ ...
+ } catch (RuntimeException e) {
+ throw e;
+ } catch (Exception e) {
+ ... deal with all non-runtime exceptions ...
+ }</pre>
<h3><a name="RI_REDUNDANT_INTERFACES">RI: Class implements same interface as superclass (RI_REDUNDANT_INTERFACES)</a></h3>
@@ -4636,7 +5063,7 @@
you may need to change your code.
If you know the divisor is a power of 2,
you can use a bitwise and operator instead (i.e., instead of
-using <code>x.hashCode()%n</code>, use <code>x.hashCode()&(n-1)</code>.
+using <code>x.hashCode()%n</code>, use <code>x.hashCode()&(n-1)</code>.
This is probably faster than computing the remainder as well.
If you don't know that the divisor is a power of 2, take the absolute
value of the result of the remainder operation (i.e., use
@@ -4655,6 +5082,37 @@
</p>
+<h3><a name="RV_RETURN_VALUE_IGNORED_INFERRED">RV: Method ignores return value, is this OK? (RV_RETURN_VALUE_IGNORED_INFERRED)</a></h3>
+
+
+<p>This code calls a method and ignores the return value. The return value
+is the same type as the type the method is invoked on, and from our analysis it looks
+like the return value might be important (e.g., like ignoring the
+return value of <code>String.toLowerCase()</code>).
+</p>
+<p>We are guessing that ignoring the return value might be a bad idea just from
+a simple analysis of the body of the method. You can use a @CheckReturnValue annotation
+to instruct FindBugs as to whether ignoring the return value of this method
+is important or acceptable.
+</p>
+<p>Please investigate this closely to decide whether it is OK to ignore the return value.
+</p>
+
+
+<h3><a name="SA_FIELD_DOUBLE_ASSIGNMENT">SA: Double assignment of field (SA_FIELD_DOUBLE_ASSIGNMENT)</a></h3>
+
+
+<p> This method contains a double assignment of a field; e.g.
+</p>
+<pre>
+ int x,y;
+ public void foo() {
+ x = x = 17;
+ }
+</pre>
+<p>Assigning to a field twice is useless, and may indicate a logic error or typo.</p>
+
+
<h3><a name="SA_LOCAL_DOUBLE_ASSIGNMENT">SA: Double assignment of local variable (SA_LOCAL_DOUBLE_ASSIGNMENT)</a></h3>
@@ -4696,6 +5154,8 @@
<p> This method contains a switch statement where default case is missing.
Usually you need to provide a default case.</p>
+ <p>Because the analysis only looks at the generated bytecode, this warning can be incorrect triggered if
+the default case is at the end of the switch statement and doesn't end with a break statement.
<h3><a name="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD">ST: Write to static field from instance method (ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)</a></h3>
@@ -4719,29 +5179,29 @@
<p> The field is marked as transient, but the class isn't Serializable, so marking it as transient
-has absolutely no effect.
+has absolutely no effect.
This may be leftover marking from a previous version of the code in which the class was transient, or
it may indicate a misunderstanding of how serialization works.
</p>
-<h3><a name="TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK">TQ: Explicit annotation inconsistent with use (TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK)</a></h3>
+<h3><a name="TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK">TQ: Value required to have type qualifier, but marked as unknown (TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK)</a></h3>
<p>
A value is used in a way that requires it to be always be a value denoted by a type qualifier, but
- there is an explicit annotation stating that it is not known where the value is required to have that type qualifier.
- Either the usage or the annotation is incorrect.
+ there is an explicit annotation stating that it is not known where the value is required to have that type qualifier.
+ Either the usage or the annotation is incorrect.
</p>
-<h3><a name="TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK">TQ: Explicit annotation inconsistent with use (TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK)</a></h3>
+<h3><a name="TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK">TQ: Value required to not have type qualifier, but marked as unknown (TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK)</a></h3>
<p>
A value is used in a way that requires it to be never be a value denoted by a type qualifier, but
- there is an explicit annotation stating that it is not known where the value is prohibited from having that type qualifier.
- Either the usage or the annotation is incorrect.
+ there is an explicit annotation stating that it is not known where the value is prohibited from having that type qualifier.
+ Either the usage or the annotation is incorrect.
</p>
@@ -4755,8 +5215,8 @@
block for an <code>if</code> statement:</p>
<pre>
if (argv.length == 0) {
- // TODO: handle this case
- }
+ // TODO: handle this case
+ }
</pre>
@@ -4774,17 +5234,42 @@
</pre>
-<h3><a name="UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR">UwF: Field not initialized in constructor (UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR)</a></h3>
+<h3><a name="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD">UrF: Unread public/protected field (URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)</a></h3>
+
+
+ <p> This field is never read.
+The field is public or protected, so perhaps
+ it is intended to be used with classes not seen as part of the analysis. If not,
+consider removing it from the class.</p>
+
+
+<h3><a name="UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD">UuF: Unused public or protected field (UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD)</a></h3>
+
+
+ <p> This field is never used.
+The field is public or protected, so perhaps
+ it is intended to be used with classes not seen as part of the analysis. If not,
+consider removing it from the class.</p>
+
+
+<h3><a name="UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR">UwF: Field not initialized in constructor but dereferenced without null check (UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR)</a></h3>
<p> This field is never initialized within any constructor, and is therefore could be null after
-the object is constructed.
+the object is constructed. Elsewhere, it is loaded and dereferenced without a null check.
This could be a either an error or a questionable design, since
it means a null pointer exception will be generated if that field is dereferenced
before being initialized.
</p>
+<h3><a name="UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD">UwF: Unwritten public or protected field (UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD)</a></h3>
+
+
+ <p> No writes were seen to this public/protected field. All reads of it will return the default
+value. Check for errors (should it have been initialized?), or remove it if it is useless.</p>
+
+
<h3><a name="XFB_XML_FACTORY_BYPASS">XFB: Method directly allocates a specific implementation of xml interfaces (XFB_XML_FACTORY_BYPASS)</a></h3>
diff --git a/tools/findbugs-1.3.9/doc/bug-logo.png b/tools/findbugs/doc/bug-logo.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/bug-logo.png
rename to tools/findbugs/doc/bug-logo.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/bugDescriptions.html b/tools/findbugs/doc/bugDescriptions.html
similarity index 79%
copy from tools/findbugs-1.3.9/doc/bugDescriptions.html
copy to tools/findbugs/doc/bugDescriptions.html
index 9e4edf4..31a17d4 100644
--- a/tools/findbugs-1.3.9/doc/bugDescriptions.html
+++ b/tools/findbugs/doc/bugDescriptions.html
@@ -1,3 +1,4 @@
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html><head><title>FindBugs Bug Descriptions</title>
<link rel="stylesheet" type="text/css" href="findbugs.css"/>
<link rel="shortcut icon" href="favicon.ico" type="image/x-icon"/>
@@ -12,6 +13,7 @@
<tr><td> </td></tr>
<tr><td><b>Docs and Info</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="findbugs2.html">FindBugs 2.0</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
@@ -49,41 +51,41 @@
<td align="left" valign="top">
<h1>FindBugs Bug Descriptions</h1>
<p>This document lists the standard bug patterns reported by
-<a href="http://findbugs.sourceforge.net">FindBugs</a> version 1.3.9.</p>
+<a href="http://findbugs.sourceforge.net">FindBugs</a> version 2.0.2.</p>
<h2>Summary</h2>
<table width="100%">
<tr bgcolor="#b9b9fe"><th>Description</th><th>Category</th></tr>
<tr bgcolor="#eeeeee"><td><a href="#AM_CREATES_EMPTY_JAR_FILE_ENTRY">AM: Creates an empty jar file entry</a></td><td>Bad practice</td></tr>
<tr bgcolor="#ffffff"><td><a href="#AM_CREATES_EMPTY_ZIP_FILE_ENTRY">AM: Creates an empty zip file entry</a></td><td>Bad practice</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS">BC: Equals method should not assume anything about the type of its argument</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DMI_RANDOM_USED_ONLY_ONCE">BC: Random object created and used only once</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#BIT_SIGNED_CHECK">BIT: Check for sign of bitwise operation</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#CN_IDIOM">CN: Class implements Cloneable but does not define or use clone method</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#CN_IDIOM_NO_SUPER_CALL">CN: clone method does not call super.clone()</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE">CN: Class defines clone() but doesn't implement Cloneable</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#CO_ABSTRACT_SELF">Co: Abstract class defines covariant compareTo() method</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#CO_SELF_NO_OBJECT">Co: Covariant compareTo() method defined</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DE_MIGHT_DROP">DE: Method might drop exception</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DE_MIGHT_IGNORE">DE: Method might ignore exception</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_USING_REMOVEALL_TO_CLEAR_COLLECTION">DMI: Don't use removeAll to clear a collection</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED">DP: Classloaders should only be created inside doPrivileged block</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DP_DO_INSIDE_DO_PRIVILEGED">DP: Method invoked that should be only be invoked inside a doPrivileged block</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DM_EXIT">Dm: Method invokes System.exit(...)</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DM_RUN_FINALIZERS_ON_EXIT">Dm: Method invokes dangerous method runFinalizersOnExit</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#ES_COMPARING_PARAMETER_STRING_WITH_EQ">ES: Comparison of String parameter using == or !=</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#ES_COMPARING_STRINGS_WITH_EQ">ES: Comparison of String objects using == or !=</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EQ_ABSTRACT_SELF">Eq: Abstract class defines covariant equals() method</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS">Eq: Equals checks for noncompatible operand</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EQ_COMPARETO_USE_OBJECT_EQUALS">Eq: Class defines compareTo(...) and uses Object.equals()</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#EQ_GETCLASS_AND_CLASS_CONSTANT">Eq: equals method fails for subtypes</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EQ_SELF_NO_OBJECT">Eq: Covariant equals() method defined</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#FI_EMPTY">FI: Empty finalizer should be deleted</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#FI_EXPLICIT_INVOCATION">FI: Explicit invocation of finalizer</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#FI_FINALIZER_NULLS_FIELDS">FI: Finalizer nulls fields</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#FI_FINALIZER_ONLY_NULLS_FIELDS">FI: Finalizer only nulls fields</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#FI_MISSING_SUPER_CALL">FI: Finalizer does not call superclass finalizer</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#FI_NULLIFY_SUPER">FI: Finalizer nullifies superclass finalizer</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#FI_USELESS">FI: Finalizer does nothing but call superclass finalizer</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#BIT_SIGNED_CHECK">BIT: Check for sign of bitwise operation</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#CN_IDIOM">CN: Class implements Cloneable but does not define or use clone method</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#CN_IDIOM_NO_SUPER_CALL">CN: clone method does not call super.clone()</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#CN_IMPLEMENTS_CLONE_BUT_NOT_CLONEABLE">CN: Class defines clone() but doesn't implement Cloneable</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#CO_ABSTRACT_SELF">Co: Abstract class defines covariant compareTo() method</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#CO_SELF_NO_OBJECT">Co: Covariant compareTo() method defined</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DE_MIGHT_DROP">DE: Method might drop exception</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DE_MIGHT_IGNORE">DE: Method might ignore exception</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS">DMI: Adding elements of an entry set may fail due to reuse of Entry objects</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DMI_RANDOM_USED_ONLY_ONCE">DMI: Random object created and used only once</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DMI_USING_REMOVEALL_TO_CLEAR_COLLECTION">DMI: Don't use removeAll to clear a collection</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DM_EXIT">Dm: Method invokes System.exit(...)</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DM_RUN_FINALIZERS_ON_EXIT">Dm: Method invokes dangerous method runFinalizersOnExit</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#ES_COMPARING_PARAMETER_STRING_WITH_EQ">ES: Comparison of String parameter using == or !=</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#ES_COMPARING_STRINGS_WITH_EQ">ES: Comparison of String objects using == or !=</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#EQ_ABSTRACT_SELF">Eq: Abstract class defines covariant equals() method</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS">Eq: Equals checks for incompatible operand</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#EQ_COMPARETO_USE_OBJECT_EQUALS">Eq: Class defines compareTo(...) and uses Object.equals()</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#EQ_GETCLASS_AND_CLASS_CONSTANT">Eq: equals method fails for subtypes</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#EQ_SELF_NO_OBJECT">Eq: Covariant equals() method defined</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#FI_EMPTY">FI: Empty finalizer should be deleted</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#FI_EXPLICIT_INVOCATION">FI: Explicit invocation of finalizer</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#FI_FINALIZER_NULLS_FIELDS">FI: Finalizer nulls fields</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#FI_FINALIZER_ONLY_NULLS_FIELDS">FI: Finalizer only nulls fields</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#FI_MISSING_SUPER_CALL">FI: Finalizer does not call superclass finalizer</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#FI_NULLIFY_SUPER">FI: Finalizer nullifies superclass finalizer</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#FI_USELESS">FI: Finalizer does nothing but call superclass finalizer</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#VA_FORMAT_STRING_USES_NEWLINE">FS: Format string should use %n rather than \n</a></td><td>Bad practice</td></tr>
<tr bgcolor="#ffffff"><td><a href="#GC_UNCHECKED_TYPE_IN_GENERIC_CALL">GC: Unchecked type in generic call</a></td><td>Bad practice</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#HE_EQUALS_NO_HASHCODE">HE: Class defines equals() but not hashCode()</a></td><td>Bad practice</td></tr>
<tr bgcolor="#ffffff"><td><a href="#HE_EQUALS_USE_HASHCODE">HE: Class defines equals() and uses Object.hashCode()</a></td><td>Bad practice</td></tr>
@@ -115,10 +117,12 @@
<tr bgcolor="#ffffff"><td><a href="#ODR_OPEN_DATABASE_RESOURCE_EXCEPTION_PATH">ODR: Method may fail to close database resource on exception</a></td><td>Bad practice</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#OS_OPEN_STREAM">OS: Method may fail to close stream</a></td><td>Bad practice</td></tr>
<tr bgcolor="#ffffff"><td><a href="#OS_OPEN_STREAM_EXCEPTION_PATH">OS: Method may fail to close stream on exception</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RC_REF_COMPARISON_BAD_PRACTICE">RC: Suspicious reference comparison to constant</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN">RC: Suspicious reference comparison of Boolean values</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RR_NOT_CHECKED">RR: Method ignores results of InputStream.read()</a></td><td>Bad practice</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SR_NOT_CHECKED">RR: Method ignores results of InputStream.skip()</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#PZ_DONT_REUSE_ENTRY_OBJECTS_IN_ITERATORS">PZ: Don't reuse entry objects in iterators</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RC_REF_COMPARISON_BAD_PRACTICE">RC: Suspicious reference comparison to constant</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN">RC: Suspicious reference comparison of Boolean values</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RR_NOT_CHECKED">RR: Method ignores results of InputStream.read()</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#SR_NOT_CHECKED">RR: Method ignores results of InputStream.skip()</a></td><td>Bad practice</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RV_NEGATING_RESULT_OF_COMPARETO">RV: Negating the result of compareTo()/compare()</a></td><td>Bad practice</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#RV_RETURN_VALUE_IGNORED_BAD_PRACTICE">RV: Method ignores exceptional return value</a></td><td>Bad practice</td></tr>
<tr bgcolor="#ffffff"><td><a href="#SI_INSTANCE_BEFORE_FINALS_ASSIGNED">SI: Static initializer creates instance before all static final fields assigned</a></td><td>Bad practice</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#SW_SWING_METHODS_INVOKED_IN_SWING_THREAD">SW: Certain swing methods needs to be invoked in Swing thread</a></td><td>Bad practice</td></tr>
@@ -147,13 +151,17 @@
<tr bgcolor="#ffffff"><td><a href="#BIT_IOR_OF_SIGNED_BYTE">BIT: Bitwise OR of signed byte value</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#BIT_SIGNED_CHECK_HIGH_BIT">BIT: Check for sign of bitwise operation</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#BOA_BADLY_OVERRIDDEN_ADAPTER">BOA: Class overrides a method implemented in super class Adapter wrongly</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#ICAST_BAD_SHIFT_AMOUNT">BSHIFT: 32 bit int shifted by an amount not in the range 0..31</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#ICAST_BAD_SHIFT_AMOUNT">BSHIFT: 32 bit int shifted by an amount not in the range -31..31</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#BX_UNBOXED_AND_COERCED_FOR_TERNARY_OPERATOR">Bx: Primitive value is unboxed and coerced for ternary operator</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DLS_DEAD_STORE_OF_CLASS_LITERAL">DLS: Dead store of class literal</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DLS_OVERWRITTEN_INCREMENT">DLS: Overwritten increment</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#CO_COMPARETO_RESULTS_MIN_VALUE">Co: compareTo()/compare() returns Integer.MIN_VALUE</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DLS_DEAD_STORE_OF_CLASS_LITERAL">DLS: Dead store of class literal</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DLS_OVERWRITTEN_INCREMENT">DLS: Overwritten increment</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DMI_ARGUMENTS_WRONG_ORDER">DMI: Reversed method arguments</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#DMI_BAD_MONTH">DMI: Bad constant value for month</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DMI_CALLING_NEXT_FROM_HASNEXT">DMI: hasNext method invokes next</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVES">DMI: Collections should not contain themselves</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DMI_BIGDECIMAL_CONSTRUCTED_FROM_DOUBLE">DMI: BigDecimal constructed from double that isn't represented precisely</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DMI_CALLING_NEXT_FROM_HASNEXT">DMI: hasNext method invokes next</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVES">DMI: Collections should not contain themselves</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DMI_DOH">DMI: D'oh! A nonsensical method invocation</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#DMI_INVOKING_HASHCODE_ON_ARRAY">DMI: Invocation of hashCode on an array</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#DMI_LONG_BITS_TO_DOUBLE_INVOKED_ON_INT">DMI: Double.longBitsToDouble invoked on an int</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#DMI_VACUOUS_SELF_COLLECTION_CALL">DMI: Vacuous call to collections</a></td><td>Correctness</td></tr>
@@ -164,7 +172,7 @@
<tr bgcolor="#eeeeee"><td><a href="#EC_ARRAY_AND_NONARRAY">EC: equals() used to compare array and nonarray</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#EC_BAD_ARRAY_COMPARE">EC: Invocation of equals() on an array, which is equivalent to ==</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#EC_INCOMPATIBLE_ARRAY_COMPARE">EC: equals(...) used to compare incompatible arrays</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EC_NULL_ARG">EC: Call to equals() with null argument</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#EC_NULL_ARG">EC: Call to equals(null)</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#EC_UNRELATED_CLASS_AND_INTERFACE">EC: Call to equals() comparing unrelated class and interface</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#EC_UNRELATED_INTERFACES">EC: Call to equals() comparing different interface types</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#EC_UNRELATED_TYPES">EC: Call to equals() comparing different types</a></td><td>Correctness</td></tr>
@@ -188,18 +196,20 @@
<tr bgcolor="#eeeeee"><td><a href="#GC_UNRELATED_TYPES">GC: No relationship between generic parameter and method argument</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS">HE: Signature declares use of unhashable class in hashed construct</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#HE_USE_OF_UNHASHABLE_CLASS">HE: Use of class without a hashCode() method in a hashed data structure</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL">ICAST: integral value cast to double and then passed to Math.ceil</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#ICAST_INT_CAST_TO_FLOAT_PASSED_TO_ROUND">ICAST: int value cast to float and then passed to Math.round</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IJU_ASSERT_METHOD_INVOKED_FROM_RUN_METHOD">IJU: JUnit assertion in run method will not be noticed by JUnit</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IJU_BAD_SUITE_METHOD">IJU: TestCase declares a bad suite method </a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IJU_NO_TESTS">IJU: TestCase has no tests</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IJU_SETUP_NO_SUPER">IJU: TestCase defines setUp that doesn't call super.setUp()</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IJU_SUITE_NOT_STATIC">IJU: TestCase implements a non-static suite method </a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IJU_TEARDOWN_NO_SUPER">IJU: TestCase defines tearDown that doesn't call super.tearDown()</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IL_CONTAINER_ADDED_TO_ITSELF">IL: A collection is added to itself</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IL_INFINITE_LOOP">IL: An apparent infinite loop</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IL_INFINITE_RECURSIVE_LOOP">IL: An apparent infinite recursive loop</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IM_MULTIPLYING_RESULT_OF_IREM">IM: Integer multiply of result of integer remainder</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#ICAST_INT_2_LONG_AS_INSTANT">ICAST: int value converted to long and used as absolute time</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL">ICAST: integral value cast to double and then passed to Math.ceil</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#ICAST_INT_CAST_TO_FLOAT_PASSED_TO_ROUND">ICAST: int value cast to float and then passed to Math.round</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#IJU_ASSERT_METHOD_INVOKED_FROM_RUN_METHOD">IJU: JUnit assertion in run method will not be noticed by JUnit</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#IJU_BAD_SUITE_METHOD">IJU: TestCase declares a bad suite method </a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#IJU_NO_TESTS">IJU: TestCase has no tests</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#IJU_SETUP_NO_SUPER">IJU: TestCase defines setUp that doesn't call super.setUp()</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#IJU_SUITE_NOT_STATIC">IJU: TestCase implements a non-static suite method </a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#IJU_TEARDOWN_NO_SUPER">IJU: TestCase defines tearDown that doesn't call super.tearDown()</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#IL_CONTAINER_ADDED_TO_ITSELF">IL: A collection is added to itself</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#IL_INFINITE_LOOP">IL: An apparent infinite loop</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#IL_INFINITE_RECURSIVE_LOOP">IL: An apparent infinite recursive loop</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#IM_MULTIPLYING_RESULT_OF_IREM">IM: Integer multiply of result of integer remainder</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#INT_BAD_COMPARISON_WITH_INT_VALUE">INT: Bad comparison of int value with long constant</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE">INT: Bad comparison of nonnegative value with negative constant</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#INT_BAD_COMPARISON_WITH_SIGNED_BYTE">INT: Bad comparison of signed byte</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#IO_APPENDING_TO_OBJECT_OUTPUT_STREAM">IO: Doomed attempt to append to an object output stream</a></td><td>Correctness</td></tr>
@@ -212,38 +222,40 @@
<tr bgcolor="#eeeeee"><td><a href="#NP_CLOSING_NULL">NP: close() invoked on a value that is always null</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#NP_GUARANTEED_DEREF">NP: Null value is guaranteed to be dereferenced</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH">NP: Value is null and guaranteed to be dereferenced on exception path</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_NONNULL_PARAM_VIOLATION">NP: Method call passes null to a nonnull parameter </a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_NONNULL_RETURN_VIOLATION">NP: Method may return null, but is declared @NonNull</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_NULL_INSTANCEOF">NP: A known null value is checked to see if it is an instance of a type</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_NULL_ON_SOME_PATH">NP: Possible null pointer dereference</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_NULL_ON_SOME_PATH_EXCEPTION">NP: Possible null pointer dereference in method on exception path</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_NULL_PARAM_DEREF">NP: Method call passes null for nonnull parameter</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS">NP: Method call passes null for nonnull parameter</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_NULL_PARAM_DEREF_NONVIRTUAL">NP: Non-virtual method call passes null for nonnull parameter</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_STORE_INTO_NONNULL_FIELD">NP: Store of null value into field annotated NonNull</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_UNWRITTEN_FIELD">NP: Read of unwritten field</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NM_BAD_EQUAL">Nm: Class defines equal(Object); should it be equals(Object)?</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NM_LCASE_HASHCODE">Nm: Class defines hashcode(); should it be hashCode()?</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NM_LCASE_TOSTRING">Nm: Class defines tostring(); should it be toString()?</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NM_METHOD_CONSTRUCTOR_CONFUSION">Nm: Apparent method/constructor confusion</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NM_VERY_CONFUSING">Nm: Very confusing method names</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NM_WRONG_PACKAGE">Nm: Method doesn't override method in superclass due to wrong package for parameter</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#QBA_QUESTIONABLE_BOOLEAN_ASSIGNMENT">QBA: Method assigns boolean literal in boolean expression</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RC_REF_COMPARISON">RC: Suspicious reference comparison</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">RCN: Nullcheck of value previously dereferenced</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RE_BAD_SYNTAX_FOR_REGULAR_EXPRESSION">RE: Invalid syntax for regular expression</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RE_CANT_USE_FILE_SEPARATOR_AS_REGULAR_EXPRESSION">RE: File.separator used for regular expression</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RE_POSSIBLE_UNINTENDED_PATTERN">RE: "." used for regular expression</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RV_01_TO_INT">RV: Random value from 0 to 1 is coerced to the integer 0</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RV_ABSOLUTE_VALUE_OF_HASHCODE">RV: Bad attempt to compute absolute value of signed 32-bit hashcode </a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RV_ABSOLUTE_VALUE_OF_RANDOM_INT">RV: Bad attempt to compute absolute value of signed 32-bit random integer</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR">NP: Nonnull field is not initialized</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NP_NONNULL_PARAM_VIOLATION">NP: Method call passes null to a nonnull parameter </a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NP_NONNULL_RETURN_VIOLATION">NP: Method may return null, but is declared @NonNull</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NP_NULL_INSTANCEOF">NP: A known null value is checked to see if it is an instance of a type</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NP_NULL_ON_SOME_PATH">NP: Possible null pointer dereference</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NP_NULL_ON_SOME_PATH_EXCEPTION">NP: Possible null pointer dereference in method on exception path</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NP_NULL_PARAM_DEREF">NP: Method call passes null for nonnull parameter</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NP_NULL_PARAM_DEREF_ALL_TARGETS_DANGEROUS">NP: Method call passes null for nonnull parameter</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NP_NULL_PARAM_DEREF_NONVIRTUAL">NP: Non-virtual method call passes null for nonnull parameter</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NP_STORE_INTO_NONNULL_FIELD">NP: Store of null value into field annotated NonNull</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NP_UNWRITTEN_FIELD">NP: Read of unwritten field</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NM_BAD_EQUAL">Nm: Class defines equal(Object); should it be equals(Object)?</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NM_LCASE_HASHCODE">Nm: Class defines hashcode(); should it be hashCode()?</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NM_LCASE_TOSTRING">Nm: Class defines tostring(); should it be toString()?</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NM_METHOD_CONSTRUCTOR_CONFUSION">Nm: Apparent method/constructor confusion</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NM_VERY_CONFUSING">Nm: Very confusing method names</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NM_WRONG_PACKAGE">Nm: Method doesn't override method in superclass due to wrong package for parameter</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#QBA_QUESTIONABLE_BOOLEAN_ASSIGNMENT">QBA: Method assigns boolean literal in boolean expression</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RC_REF_COMPARISON">RC: Suspicious reference comparison</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE">RCN: Nullcheck of value previously dereferenced</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RE_BAD_SYNTAX_FOR_REGULAR_EXPRESSION">RE: Invalid syntax for regular expression</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#RE_CANT_USE_FILE_SEPARATOR_AS_REGULAR_EXPRESSION">RE: File.separator used for regular expression</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RE_POSSIBLE_UNINTENDED_PATTERN">RE: "." used for regular expression</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#RV_01_TO_INT">RV: Random value from 0 to 1 is coerced to the integer 0</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RV_ABSOLUTE_VALUE_OF_HASHCODE">RV: Bad attempt to compute absolute value of signed 32-bit hashcode </a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#RV_ABSOLUTE_VALUE_OF_RANDOM_INT">RV: Bad attempt to compute absolute value of signed random integer</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RV_CHECK_COMPARETO_FOR_SPECIFIC_RETURN_VALUE">RV: Code checks for specific values returned by compareTo</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#RV_EXCEPTION_NOT_THROWN">RV: Exception created and dropped rather than thrown</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#RV_RETURN_VALUE_IGNORED">RV: Method ignores return value</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#RpC_REPEATED_CONDITIONAL_TEST">RpC: Repeated conditional tests</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SA_FIELD_DOUBLE_ASSIGNMENT">SA: Double assignment of field</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SA_FIELD_SELF_ASSIGNMENT">SA: Self assignment of field</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SA_FIELD_SELF_COMPARISON">SA: Self comparison of field with itself</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SA_FIELD_SELF_COMPUTATION">SA: Nonsensical self computation involving a field (e.g., x & x)</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#SA_FIELD_SELF_ASSIGNMENT">SA: Self assignment of field</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#SA_FIELD_SELF_COMPARISON">SA: Self comparison of field with itself</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#SA_FIELD_SELF_COMPUTATION">SA: Nonsensical self computation involving a field (e.g., x & x)</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#SA_LOCAL_SELF_ASSIGNMENT_INSTEAD_OF_FIELD">SA: Self assignment of local rather than assignment to field</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#SA_LOCAL_SELF_COMPARISON">SA: Self comparison of value with itself</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#SA_LOCAL_SELF_COMPUTATION">SA: Nonsensical self computation involving a variable (e.g., x & x)</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#SF_DEAD_STORE_DUE_TO_SWITCH_FALLTHROUGH">SF: Dead store due to switch statement fall through</a></td><td>Correctness</td></tr>
@@ -257,13 +269,15 @@
<tr bgcolor="#ffffff"><td><a href="#SE_METHOD_MUST_BE_PRIVATE">Se: Method must be private in order for serialization to work</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#SE_READ_RESOLVE_IS_STATIC">Se: The readResolve method must not be declared as a static method. </a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#TQ_ALWAYS_VALUE_USED_WHERE_NEVER_REQUIRED">TQ: Value annotated as carrying a type qualifier used where a value that must not carry that qualifier is required</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#TQ_MAYBE_SOURCE_VALUE_REACHES_ALWAYS_SINK">TQ: Value that might not carry a type qualifier is always used in a way requires that type qualifier</a></td><td>Correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#TQ_MAYBE_SOURCE_VALUE_REACHES_NEVER_SINK">TQ: Value that might carry a type qualifier is always used in a way prohibits it from having that type qualifier</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#TQ_NEVER_VALUE_USED_WHERE_ALWAYS_REQUIRED">TQ: Value annotated as never carrying a type qualifier used where value carrying that qualifier is required</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#TQ_COMPARING_VALUES_WITH_INCOMPATIBLE_TYPE_QUALIFIERS">TQ: Comparing values with incompatible type qualifiers</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#TQ_MAYBE_SOURCE_VALUE_REACHES_ALWAYS_SINK">TQ: Value that might not carry a type qualifier is always used in a way requires that type qualifier</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#TQ_MAYBE_SOURCE_VALUE_REACHES_NEVER_SINK">TQ: Value that might carry a type qualifier is always used in a way prohibits it from having that type qualifier</a></td><td>Correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#TQ_NEVER_VALUE_USED_WHERE_ALWAYS_REQUIRED">TQ: Value annotated as never carrying a type qualifier used where value carrying that qualifier is required</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#TQ_UNKNOWN_VALUE_USED_WHERE_ALWAYS_STRICTLY_REQUIRED">TQ: Value without a type qualifier used where a value is required to have that qualifier</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS">UMAC: Uncallable method defined in anonymous class</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#UR_UNINIT_READ">UR: Uninitialized read of field in constructor</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#UR_UNINIT_READ_CALLED_FROM_SUPER_CONSTRUCTOR">UR: Uninitialized read of field method called from constructor of superclass</a></td><td>Correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY">USELESS_STRING: Invocation of toString on an array</a></td><td>Correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY">USELESS_STRING: Invocation of toString on an unnamed array</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#DMI_INVOKING_TOSTRING_ON_ARRAY">USELESS_STRING: Invocation of toString on an array</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#VA_FORMAT_STRING_BAD_CONVERSION_FROM_ARRAY">USELESS_STRING: Array formatted in useless way using format string</a></td><td>Correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#UWF_NULL_FIELD">UwF: Field only ever set to null</a></td><td>Correctness</td></tr>
@@ -271,7 +285,11 @@
<tr bgcolor="#ffffff"><td><a href="#VA_PRIMITIVE_ARRAY_PASSED_TO_OBJECT_VARARG">VA: Primitive array passed to function expecting a variable number of object arguments</a></td><td>Correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE">LG: Potential lost logger changes due to weak reference in OpenJDK</a></td><td>Experimental</td></tr>
<tr bgcolor="#ffffff"><td><a href="#OBL_UNSATISFIED_OBLIGATION">OBL: Method may fail to clean up stream or resource</a></td><td>Experimental</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DM_CONVERT_CASE">Dm: Consider using Locale parameterized version of invoked method</a></td><td>Internationalization</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE">OBL: Method may fail to clean up stream or resource on checked exception</a></td><td>Experimental</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DM_CONVERT_CASE">Dm: Consider using Locale parameterized version of invoked method</a></td><td>Internationalization</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DM_DEFAULT_ENCODING">Dm: Reliance on default encoding</a></td><td>Internationalization</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED">DP: Classloaders should only be created inside doPrivileged block</a></td><td>Malicious code vulnerability</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DP_DO_INSIDE_DO_PRIVILEGED">DP: Method invoked that should be only be invoked inside a doPrivileged block</a></td><td>Malicious code vulnerability</td></tr>
<tr bgcolor="#ffffff"><td><a href="#EI_EXPOSE_REP">EI: May expose internal representation by returning reference to mutable object</a></td><td>Malicious code vulnerability</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#EI_EXPOSE_REP2">EI2: May expose internal representation by incorporating reference to mutable object</a></td><td>Malicious code vulnerability</td></tr>
<tr bgcolor="#ffffff"><td><a href="#FI_PUBLIC_SHOULD_BE_PROTECTED">FI: Finalizer should be protected, not public</a></td><td>Malicious code vulnerability</td></tr>
@@ -284,10 +302,12 @@
<tr bgcolor="#eeeeee"><td><a href="#MS_OOI_PKGPROTECT">MS: Field should be moved out of an interface and made package protected</a></td><td>Malicious code vulnerability</td></tr>
<tr bgcolor="#ffffff"><td><a href="#MS_PKGPROTECT">MS: Field should be package protected</a></td><td>Malicious code vulnerability</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#MS_SHOULD_BE_FINAL">MS: Field isn't final but should be</a></td><td>Malicious code vulnerability</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#MS_SHOULD_BE_REFACTORED_TO_BE_FINAL">MS: Field isn't final but should be refactored to be so</a></td><td>Malicious code vulnerability</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION">AT: Sequence of calls to concurrent abstraction may not be atomic</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#DC_DOUBLECHECK">DC: Possible double check of field</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DL_SYNCHRONIZATION_ON_BOOLEAN">DL: Synchronization on Boolean could lead to deadlock</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE">DL: Synchronization on boxed primitive could lead to deadlock</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DL_SYNCHRONIZATION_ON_SHARED_CONSTANT">DL: Synchronization on interned String could lead to deadlock</a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DL_SYNCHRONIZATION_ON_BOOLEAN">DL: Synchronization on Boolean</a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE">DL: Synchronization on boxed primitive</a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DL_SYNCHRONIZATION_ON_SHARED_CONSTANT">DL: Synchronization on interned String </a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#DL_SYNCHRONIZATION_ON_UNSHARED_BOXED_PRIMITIVE">DL: Synchronization on boxed primitive values</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#DM_MONITOR_WAIT_ON_CONDITION">Dm: Monitor wait() called on Condition</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#DM_USELESS_THREAD">Dm: A thread was created using the default empty run method</a></td><td>Multithreaded correctness</td></tr>
@@ -295,6 +315,8 @@
<tr bgcolor="#ffffff"><td><a href="#IS2_INCONSISTENT_SYNC">IS: Inconsistent synchronization</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#IS_FIELD_NOT_GUARDED">IS: Field not guarded against concurrent access</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#JLM_JSR166_LOCK_MONITORENTER">JLM: Synchronization performed on Lock</a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#JLM_JSR166_UTILCONCURRENT_MONITORENTER">JLM: Synchronization performed on util.concurrent instance</a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#JML_JSR166_CALLING_WAIT_RATHER_THAN_AWAIT">JLM: Using monitor style wait methods on util.concurrent abstraction</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#LI_LAZY_INIT_STATIC">LI: Incorrect lazy initialization of static field</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#LI_LAZY_INIT_UPDATE_STATIC">LI: Incorrect lazy initialization and update of static field</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD">ML: Synchronization on field in futile attempt to guard that field</a></td><td>Multithreaded correctness</td></tr>
@@ -312,7 +334,7 @@
<tr bgcolor="#eeeeee"><td><a href="#SP_SPIN_ON_FIELD">SP: Method spins on field</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#STCAL_INVOKE_ON_STATIC_CALENDAR_INSTANCE">STCAL: Call to static Calendar</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE">STCAL: Call to static DateFormat</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#STCAL_STATIC_CALENDAR_INSTANCE">STCAL: Static Calendar</a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#STCAL_STATIC_CALENDAR_INSTANCE">STCAL: Static Calendar field</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE">STCAL: Static DateFormat</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#SWL_SLEEP_WITH_LOCK_HELD">SWL: Method calls Thread.sleep() with a lock held</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#TLW_TWO_LOCK_WAIT">TLW: Wait with two locks held</a></td><td>Multithreaded correctness</td></tr>
@@ -320,13 +342,15 @@
<tr bgcolor="#eeeeee"><td><a href="#UL_UNRELEASED_LOCK">UL: Method does not release lock on all paths</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#ffffff"><td><a href="#UL_UNRELEASED_LOCK_EXCEPTION_PATH">UL: Method does not release lock on all exception paths</a></td><td>Multithreaded correctness</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#UW_UNCOND_WAIT">UW: Unconditional wait</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#VO_VOLATILE_REFERENCE_TO_ARRAY">VO: A volatile reference to an array doesn't treat the array elements as volatile</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL">WL: Sychronization on getClass rather than class literal</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#WS_WRITEOBJECT_SYNC">WS: Class's writeObject() method is synchronized but nothing else is</a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#WA_AWAIT_NOT_IN_LOOP">Wa: Condition.await() not in loop </a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#WA_NOT_IN_LOOP">Wa: Wait not in loop </a></td><td>Multithreaded correctness</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#BX_BOXING_IMMEDIATELY_UNBOXED">Bx: Primitive value is boxed and then immediately unboxed</a></td><td>Performance</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION">Bx: Primitive value is boxed then unboxed to perform primitive coercion</a></td><td>Performance</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#VO_VOLATILE_INCREMENT">VO: An increment to a volatile field isn't atomic</a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#VO_VOLATILE_REFERENCE_TO_ARRAY">VO: A volatile reference to an array doesn't treat the array elements as volatile</a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL">WL: Synchronization on getClass rather than class literal</a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#WS_WRITEOBJECT_SYNC">WS: Class's writeObject() method is synchronized but nothing else is</a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#WA_AWAIT_NOT_IN_LOOP">Wa: Condition.await() not in loop </a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#WA_NOT_IN_LOOP">Wa: Wait not in loop </a></td><td>Multithreaded correctness</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#BX_BOXING_IMMEDIATELY_UNBOXED">Bx: Primitive value is boxed and then immediately unboxed</a></td><td>Performance</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#BX_BOXING_IMMEDIATELY_UNBOXED_TO_PERFORM_COERCION">Bx: Primitive value is boxed then unboxed to perform primitive coercion</a></td><td>Performance</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#BX_UNBOXING_IMMEDIATELY_REBOXED">Bx: Boxed value is unboxed and then immediately reboxed</a></td><td>Performance</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#DM_BOXED_PRIMITIVE_TOSTRING">Bx: Method allocates a boxed primitive just to call toString</a></td><td>Performance</td></tr>
<tr bgcolor="#ffffff"><td><a href="#DM_FP_NUMBER_CTOR">Bx: Method invokes inefficient floating-point Number constructor; use static valueOf instead</a></td><td>Performance</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#DM_NUMBER_CTOR">Bx: Method invokes inefficient Number constructor; use static valueOf instead</a></td><td>Performance</td></tr>
@@ -355,73 +379,84 @@
<tr bgcolor="#ffffff"><td><a href="#DMI_EMPTY_DB_PASSWORD">Dm: Empty database password</a></td><td>Security</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#HRS_REQUEST_PARAMETER_TO_COOKIE">HRS: HTTP cookie formed from untrusted input</a></td><td>Security</td></tr>
<tr bgcolor="#ffffff"><td><a href="#HRS_REQUEST_PARAMETER_TO_HTTP_HEADER">HRS: HTTP Response splitting vulnerability</a></td><td>Security</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#PT_ABSOLUTE_PATH_TRAVERSAL">PT: Absolute path traversal in servlet</a></td><td>Security</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#PT_RELATIVE_PATH_TRAVERSAL">PT: Relative path traversal in servlet</a></td><td>Security</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE">SQL: Nonconstant string passed to execute method on an SQL statement</a></td><td>Security</td></tr>
<tr bgcolor="#ffffff"><td><a href="#SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING">SQL: A prepared statement is generated from a nonconstant String</a></td><td>Security</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#XSS_REQUEST_PARAMETER_TO_JSP_WRITER">XSS: JSP reflected cross site scripting vulnerability</a></td><td>Security</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#XSS_REQUEST_PARAMETER_TO_SEND_ERROR">XSS: Servlet reflected cross site scripting vulnerability</a></td><td>Security</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#XSS_REQUEST_PARAMETER_TO_SEND_ERROR">XSS: Servlet reflected cross site scripting vulnerability in error page</a></td><td>Security</td></tr>
<tr bgcolor="#eeeeee"><td><a href="#XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER">XSS: Servlet reflected cross site scripting vulnerability</a></td><td>Security</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#BC_BAD_CAST_TO_ABSTRACT_COLLECTION">BC: Questionable cast to abstract collection </a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#BC_BAD_CAST_TO_CONCRETE_COLLECTION">BC: Questionable cast to concrete collection</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#BC_UNCONFIRMED_CAST">BC: Unchecked/unconfirmed cast</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#BC_VACUOUS_INSTANCEOF">BC: instanceof will always return true</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#ICAST_QUESTIONABLE_UNSIGNED_RIGHT_SHIFT">BSHIFT: Unsigned right shift cast to short/byte</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#CI_CONFUSED_INHERITANCE">CI: Class is final but declares protected field</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DB_DUPLICATE_BRANCHES">DB: Method uses the same code for two branches</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DB_DUPLICATE_SWITCH_CLAUSES">DB: Method uses the same code for two switch clauses</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DLS_DEAD_LOCAL_STORE">DLS: Dead store to local variable</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DLS_DEAD_LOCAL_STORE_IN_RETURN">DLS: Useless assignment in return statement</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DLS_DEAD_LOCAL_STORE_OF_NULL">DLS: Dead store of null to local variable</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_HARDCODED_ABSOLUTE_FILENAME">DMI: Code contains a hard coded reference to an absolute pathname</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DMI_NONSERIALIZABLE_OBJECT_WRITTEN">DMI: Non serializable object written to ObjectOutput</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#DMI_USELESS_SUBSTRING">DMI: Invocation of substring(0), which returns the original value</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#DMI_THREAD_PASSED_WHERE_RUNNABLE_EXPECTED">Dm: Thread passed where Runnable expected</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#EQ_DOESNT_OVERRIDE_EQUALS">Eq: Class doesn't override equals in superclass</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#EQ_UNUSUAL">Eq: Unusual equals method </a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#FE_FLOATING_POINT_EQUALITY">FE: Test for floating point equality</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#VA_FORMAT_STRING_BAD_CONVERSION_TO_BOOLEAN">FS: Non-Boolean argument formatted using %b format specifier</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD">IA: Ambiguous invocation of either an inherited or outer method</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IC_INIT_CIRCULARITY">IC: Initialization circularity</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#ICAST_IDIV_CAST_TO_DOUBLE">ICAST: integral division result cast to double or float</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#ICAST_INTEGER_MULTIPLY_CAST_TO_LONG">ICAST: Result of integer multiplication cast to long</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#IM_AVERAGE_COMPUTATION_COULD_OVERFLOW">IM: Computation of average could overflow</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#IM_BAD_CHECK_FOR_ODD">IM: Check for oddness that won't work for negative numbers </a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#INT_BAD_REM_BY_1">INT: Integer remainder modulo 1</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#INT_VACUOUS_COMPARISON">INT: Vacuous comparison of integer value</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#MTIA_SUSPECT_SERVLET_INSTANCE_FIELD">MTIA: Class extends Servlet class and uses instance variables</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#MTIA_SUSPECT_STRUTS_INSTANCE_FIELD">MTIA: Class extends Struts Action class and uses instance variables</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_DEREFERENCE_OF_READLINE_VALUE">NP: Dereference of the result of readLine() without nullcheck</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_IMMEDIATE_DEREFERENCE_OF_READLINE">NP: Immediate dereference of the result of readLine()</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_LOAD_OF_KNOWN_NULL_VALUE">NP: Load of known null value</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE">NP: Possible null pointer dereference due to return value of called method</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE">NP: Possible null pointer dereference on path that might be infeasible</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE">NP: Parameter must be nonnull but is marked as nullable</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#NS_DANGEROUS_NON_SHORT_CIRCUIT">NS: Potentially dangerous use of non-short-circuit logic</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#NS_NON_SHORT_CIRCUIT">NS: Questionable use of non-short-circuit logic</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#PZLA_PREFER_ZERO_LENGTH_ARRAYS">PZLA: Consider returning a zero length array rather than null</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#QF_QUESTIONABLE_FOR_LOOP">QF: Complicated, subtle or wrong increment in for-loop </a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE">RCN: Redundant comparison of non-null value to null</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RCN_REDUNDANT_COMPARISON_TWO_NULL_VALUES">RCN: Redundant comparison of two null values</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE">RCN: Redundant nullcheck of value known to be non-null</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE">RCN: Redundant nullcheck of value known to be null</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#REC_CATCH_EXCEPTION">REC: Exception is caught when Exception is not thrown</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RI_REDUNDANT_INTERFACES">RI: Class implements same interface as superclass</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RV_CHECK_FOR_POSITIVE_INDEXOF">RV: Method checks to see if result of String.indexOf is positive</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RV_DONT_JUST_NULL_CHECK_READLINE">RV: Method discards result of readLine after checking if it is nonnull</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#RV_REM_OF_HASHCODE">RV: Remainder of hashCode could be negative</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#RV_REM_OF_RANDOM_INT">RV: Remainder of 32-bit signed random integer</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SA_LOCAL_DOUBLE_ASSIGNMENT">SA: Double assignment of local variable </a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SA_LOCAL_SELF_ASSIGNMENT">SA: Self assignment of local variable</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SF_SWITCH_FALLTHROUGH">SF: Switch statement found where one case falls through to the next case</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SF_SWITCH_NO_DEFAULT">SF: Switch statement found where default case is missing</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD">ST: Write to static field from instance method</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#SE_PRIVATE_READ_RESOLVE_NOT_INHERITED">Se: private readResolve method not inherited by subclasses</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS">Se: Transient field of class that isn't Serializable. </a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK">TQ: Explicit annotation inconsistent with use</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK">TQ: Explicit annotation inconsistent with use</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#UCF_USELESS_CONTROL_FLOW">UCF: Useless control flow</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#UCF_USELESS_CONTROL_FLOW_NEXT_LINE">UCF: Useless control flow to next line</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#ffffff"><td><a href="#UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR">UwF: Field not initialized in constructor</a></td><td>Dodgy</td></tr>
-<tr bgcolor="#eeeeee"><td><a href="#XFB_XML_FACTORY_BYPASS">XFB: Method directly allocates a specific implementation of xml interfaces</a></td><td>Dodgy</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#BC_BAD_CAST_TO_ABSTRACT_COLLECTION">BC: Questionable cast to abstract collection </a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#BC_BAD_CAST_TO_CONCRETE_COLLECTION">BC: Questionable cast to concrete collection</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#BC_UNCONFIRMED_CAST">BC: Unchecked/unconfirmed cast</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#BC_UNCONFIRMED_CAST_OF_RETURN_VALUE">BC: Unchecked/unconfirmed cast of return value from method</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#BC_VACUOUS_INSTANCEOF">BC: instanceof will always return true</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#ICAST_QUESTIONABLE_UNSIGNED_RIGHT_SHIFT">BSHIFT: Unsigned right shift cast to short/byte</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#CI_CONFUSED_INHERITANCE">CI: Class is final but declares protected field</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DB_DUPLICATE_BRANCHES">DB: Method uses the same code for two branches</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DB_DUPLICATE_SWITCH_CLAUSES">DB: Method uses the same code for two switch clauses</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DLS_DEAD_LOCAL_STORE">DLS: Dead store to local variable</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DLS_DEAD_LOCAL_STORE_IN_RETURN">DLS: Useless assignment in return statement</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DLS_DEAD_LOCAL_STORE_OF_NULL">DLS: Dead store of null to local variable</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DLS_DEAD_LOCAL_STORE_SHADOWS_FIELD">DLS: Dead store to local variable that shadows field</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DMI_HARDCODED_ABSOLUTE_FILENAME">DMI: Code contains a hard coded reference to an absolute pathname</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DMI_NONSERIALIZABLE_OBJECT_WRITTEN">DMI: Non serializable object written to ObjectOutput</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#DMI_USELESS_SUBSTRING">DMI: Invocation of substring(0), which returns the original value</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#DMI_THREAD_PASSED_WHERE_RUNNABLE_EXPECTED">Dm: Thread passed where Runnable expected</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#EQ_DOESNT_OVERRIDE_EQUALS">Eq: Class doesn't override equals in superclass</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#EQ_UNUSUAL">Eq: Unusual equals method </a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#FE_FLOATING_POINT_EQUALITY">FE: Test for floating point equality</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#VA_FORMAT_STRING_BAD_CONVERSION_TO_BOOLEAN">FS: Non-Boolean argument formatted using %b format specifier</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD">IA: Ambiguous invocation of either an inherited or outer method</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#IC_INIT_CIRCULARITY">IC: Initialization circularity</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#ICAST_IDIV_CAST_TO_DOUBLE">ICAST: integral division result cast to double or float</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#ICAST_INTEGER_MULTIPLY_CAST_TO_LONG">ICAST: Result of integer multiplication cast to long</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#IM_AVERAGE_COMPUTATION_COULD_OVERFLOW">IM: Computation of average could overflow</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#IM_BAD_CHECK_FOR_ODD">IM: Check for oddness that won't work for negative numbers </a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#INT_BAD_REM_BY_1">INT: Integer remainder modulo 1</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#INT_VACUOUS_BIT_OPERATION">INT: Vacuous bit mask operation on integer value</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#INT_VACUOUS_COMPARISON">INT: Vacuous comparison of integer value</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#MTIA_SUSPECT_SERVLET_INSTANCE_FIELD">MTIA: Class extends Servlet class and uses instance variables</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#MTIA_SUSPECT_STRUTS_INSTANCE_FIELD">MTIA: Class extends Struts Action class and uses instance variables</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NP_DEREFERENCE_OF_READLINE_VALUE">NP: Dereference of the result of readLine() without nullcheck</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NP_IMMEDIATE_DEREFERENCE_OF_READLINE">NP: Immediate dereference of the result of readLine()</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NP_LOAD_OF_KNOWN_NULL_VALUE">NP: Load of known null value</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE">NP: Possible null pointer dereference due to return value of called method</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE">NP: Possible null pointer dereference on branch that might be infeasible</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE">NP: Parameter must be nonnull but is marked as nullable</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD">NP: Read of unwritten public or protected field</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#NS_DANGEROUS_NON_SHORT_CIRCUIT">NS: Potentially dangerous use of non-short-circuit logic</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#NS_NON_SHORT_CIRCUIT">NS: Questionable use of non-short-circuit logic</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#PZLA_PREFER_ZERO_LENGTH_ARRAYS">PZLA: Consider returning a zero length array rather than null</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#QF_QUESTIONABLE_FOR_LOOP">QF: Complicated, subtle or wrong increment in for-loop </a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#RCN_REDUNDANT_COMPARISON_OF_NULL_AND_NONNULL_VALUE">RCN: Redundant comparison of non-null value to null</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RCN_REDUNDANT_COMPARISON_TWO_NULL_VALUES">RCN: Redundant comparison of two null values</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE">RCN: Redundant nullcheck of value known to be non-null</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE">RCN: Redundant nullcheck of value known to be null</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#REC_CATCH_EXCEPTION">REC: Exception is caught when Exception is not thrown</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RI_REDUNDANT_INTERFACES">RI: Class implements same interface as superclass</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#RV_CHECK_FOR_POSITIVE_INDEXOF">RV: Method checks to see if result of String.indexOf is positive</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RV_DONT_JUST_NULL_CHECK_READLINE">RV: Method discards result of readLine after checking if it is nonnull</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#RV_REM_OF_HASHCODE">RV: Remainder of hashCode could be negative</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#RV_REM_OF_RANDOM_INT">RV: Remainder of 32-bit signed random integer</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#RV_RETURN_VALUE_IGNORED_INFERRED">RV: Method ignores return value, is this OK?</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#SA_FIELD_DOUBLE_ASSIGNMENT">SA: Double assignment of field</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#SA_LOCAL_DOUBLE_ASSIGNMENT">SA: Double assignment of local variable </a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#SA_LOCAL_SELF_ASSIGNMENT">SA: Self assignment of local variable</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#SF_SWITCH_FALLTHROUGH">SF: Switch statement found where one case falls through to the next case</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#SF_SWITCH_NO_DEFAULT">SF: Switch statement found where default case is missing</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD">ST: Write to static field from instance method</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#SE_PRIVATE_READ_RESOLVE_NOT_INHERITED">Se: private readResolve method not inherited by subclasses</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#SE_TRANSIENT_FIELD_OF_NONSERIALIZABLE_CLASS">Se: Transient field of class that isn't Serializable. </a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK">TQ: Value required to have type qualifier, but marked as unknown</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK">TQ: Value required to not have type qualifier, but marked as unknown</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#UCF_USELESS_CONTROL_FLOW">UCF: Useless control flow</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#UCF_USELESS_CONTROL_FLOW_NEXT_LINE">UCF: Useless control flow to next line</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD">UrF: Unread public/protected field</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD">UuF: Unused public or protected field</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR">UwF: Field not initialized in constructor but dereferenced without null check</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#eeeeee"><td><a href="#UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD">UwF: Unwritten public or protected field</a></td><td>Dodgy code</td></tr>
+<tr bgcolor="#ffffff"><td><a href="#XFB_XML_FACTORY_BYPASS">XFB: Method directly allocates a specific implementation of xml interfaces</a></td><td>Dodgy code</td></tr>
</table>
<h2>Descriptions</h2>
<h3><a name="AM_CREATES_EMPTY_JAR_FILE_ENTRY">AM: Creates an empty jar file entry (AM_CREATES_EMPTY_JAR_FILE_ENTRY)</a></h3>
@@ -456,27 +491,12 @@
</p>
-<h3><a name="DMI_RANDOM_USED_ONLY_ONCE">BC: Random object created and used only once (DMI_RANDOM_USED_ONLY_ONCE)</a></h3>
-
-
-<p> This code creates a java.util.Random object, uses it to generate one random number, and then discards
-the Random object. This produces mediocre quality random numbers and is inefficient.
-If possible, rewrite the code so that the Random object is created once and saved, and each time a new random number
-is required invoke a method on the existing Random object to obtain it.
-</p>
-
-<p>If it is important that the generated Random numbers not be guessable, you <em>must</em> not create a new Random for each random
-number; the values are too easily guessable. You should strongly consider using a java.security.SecureRandom instead
-(and avoid allocating a new SecureRandom for each random number needed).
-</p>
-
-
<h3><a name="BIT_SIGNED_CHECK">BIT: Check for sign of bitwise operation (BIT_SIGNED_CHECK)</a></h3>
-<p> This method compares an expression such as
+<p> This method compares an expression such as</p>
<pre>((event.detail & SWT.SELECTED) > 0)</pre>.
-Using bit arithmetic and then comparing with the greater than operator can
+<p>Using bit arithmetic and then comparing with the greater than operator can
lead to unexpected results (of course depending on the value of
SWT.SELECTED). If SWT.SELECTED is a negative number, this is a candidate
for a bug. Even when SWT.SELECTED is not negative, it seems good practice
@@ -512,7 +532,7 @@
<p> This class defines a clone() method but the class doesn't implement Cloneable.
-There are some situations in which this is OK (e.g., you want to control how subclasses
+There are some situations in which this is OK (e.g., you want to control how subclasses
can clone themselves), but just make sure that this is what you intended.
</p>
@@ -551,32 +571,44 @@
out of the method.</p>
+<h3><a name="DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS">DMI: Adding elements of an entry set may fail due to reuse of Entry objects (DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS)</a></h3>
+
+
+ <p> The entrySet() method is allowed to return a view of the
+ underlying Map in which a single Entry object is reused and returned
+ during the iteration. As of Java 1.6, both IdentityHashMap
+ and EnumMap did so. When iterating through such a Map,
+ the Entry value is only valid until you advance to the next iteration.
+ If, for example, you try to pass such an entrySet to an addAll method,
+ things will go badly wrong.
+ </p>
+
+
+<h3><a name="DMI_RANDOM_USED_ONLY_ONCE">DMI: Random object created and used only once (DMI_RANDOM_USED_ONLY_ONCE)</a></h3>
+
+
+<p> This code creates a java.util.Random object, uses it to generate one random number, and then discards
+the Random object. This produces mediocre quality random numbers and is inefficient.
+If possible, rewrite the code so that the Random object is created once and saved, and each time a new random number
+is required invoke a method on the existing Random object to obtain it.
+</p>
+
+<p>If it is important that the generated Random numbers not be guessable, you <em>must</em> not create a new Random for each random
+number; the values are too easily guessable. You should strongly consider using a java.security.SecureRandom instead
+(and avoid allocating a new SecureRandom for each random number needed).
+</p>
+
+
<h3><a name="DMI_USING_REMOVEALL_TO_CLEAR_COLLECTION">DMI: Don't use removeAll to clear a collection (DMI_USING_REMOVEALL_TO_CLEAR_COLLECTION)</a></h3>
<p> If you want to remove all elements from a collection <code>c</code>, use <code>c.clear</code>,
not <code>c.removeAll(c)</code>. Calling <code>c.removeAll(c)</code> to clear a collection
-is less clear, susceptible to errors from typos, less efficient and
+is less clear, susceptible to errors from typos, less efficient and
for some collections, might throw a <code>ConcurrentModificationException</code>.
- </p>
+ </p>
-<h3><a name="DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED">DP: Classloaders should only be created inside doPrivileged block (DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED)</a></h3>
-
-
- <p> This code creates a classloader, which requires a security manager.
- If this code will be granted security permissions, but might be invoked by code that does not
- have security permissions, then the classloader creation needs to occur inside a doPrivileged block.</p>
-
-
-<h3><a name="DP_DO_INSIDE_DO_PRIVILEGED">DP: Method invoked that should be only be invoked inside a doPrivileged block (DP_DO_INSIDE_DO_PRIVILEGED)</a></h3>
-
-
- <p> This code invokes a method that requires a security permission check.
- If this code will be granted security permissions, but might be invoked by code that does not
- have security permissions, then the invocation needs to occur inside a doPrivileged block.</p>
-
-
<h3><a name="DM_EXIT">Dm: Method invokes System.exit(...) (DM_EXIT)</a></h3>
@@ -598,7 +630,7 @@
<p>This code compares a <code>java.lang.String</code> parameter for reference
-equality using the == or != operators. Requiring callers to
+equality using the == or != operators. Requiring callers to
pass only String constants or interned strings to a method is unnecessarily
fragile, and rarely leads to measurable performance gains. Consider
using the <code>equals(Object)</code> method instead.</p>
@@ -624,22 +656,22 @@
must have type <code>java.lang.Object</code>.</p>
-<h3><a name="EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS">Eq: Equals checks for noncompatible operand (EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS)</a></h3>
+<h3><a name="EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS">Eq: Equals checks for incompatible operand (EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS)</a></h3>
<p> This equals method is checking to see if the argument is some incompatible type
(i.e., a class that is neither a supertype nor subtype of the class that defines
the equals method). For example, the Foo class might have an equals method
that looks like:
-
-<p><code><pre>
+</p>
+<pre>
public boolean equals(Object o) {
if (o instanceof Foo)
return name.equals(((Foo)o).name);
else if (o instanceof String)
return name.equals(o);
else return false;
-</pre></code></p>
+</pre>
<p>This is considered bad practice, as it makes it very hard to implement an equals method that
is symmetric and transitive. Without those properties, very unexpected behavoirs are possible.
@@ -651,17 +683,17 @@
<p> This class defines a <code>compareTo(...)</code> method but inherits its
<code>equals()</code> method from <code>java.lang.Object</code>.
- Generally, the value of compareTo should return zero if and only if
- equals returns true. If this is violated, weird and unpredictable
- failures will occur in classes such as PriorityQueue.
- In Java 5 the PriorityQueue.remove method uses the compareTo method,
- while in Java 6 it uses the equals method.
+ Generally, the value of compareTo should return zero if and only if
+ equals returns true. If this is violated, weird and unpredictable
+ failures will occur in classes such as PriorityQueue.
+ In Java 5 the PriorityQueue.remove method uses the compareTo method,
+ while in Java 6 it uses the equals method.
<p>From the JavaDoc for the compareTo method in the Comparable interface:
<blockquote>
-It is strongly recommended, but not strictly required that <code>(x.compareTo(y)==0) == (x.equals(y))</code>.
-Generally speaking, any class that implements the Comparable interface and violates this condition
-should clearly indicate this fact. The recommended language
+It is strongly recommended, but not strictly required that <code>(x.compareTo(y)==0) == (x.equals(y))</code>.
+Generally speaking, any class that implements the Comparable interface and violates this condition
+should clearly indicate this fact. The recommended language
is "Note: this class has a natural ordering that is inconsistent with equals."
</blockquote>
@@ -708,9 +740,9 @@
<p> This finalizer nulls out fields. This is usually an error, as it does not aid garbage collection,
- and the object is going to be garbage collected anyway.
+ and the object is going to be garbage collected anyway.
-
+
<h3><a name="FI_FINALIZER_ONLY_NULLS_FIELDS">FI: Finalizer only nulls fields (FI_FINALIZER_ONLY_NULLS_FIELDS)</a></h3>
@@ -718,7 +750,7 @@
the object be garbage collected, finalized, and then garbage collected again. You should just remove the finalize
method.
-
+
<h3><a name="FI_MISSING_SUPER_CALL">FI: Finalizer does not call superclass finalizer (FI_MISSING_SUPER_CALL)</a></h3>
@@ -745,16 +777,25 @@
redundant. Delete it.</p>
+<h3><a name="VA_FORMAT_STRING_USES_NEWLINE">FS: Format string should use %n rather than \n (VA_FORMAT_STRING_USES_NEWLINE)</a></h3>
+
+
+<p>
+This format string include a newline character (\n). In format strings, it is generally
+ preferable better to use %n, which will produce the platform-specific line separator.
+</p>
+
+
<h3><a name="GC_UNCHECKED_TYPE_IN_GENERIC_CALL">GC: Unchecked type in generic call (GC_UNCHECKED_TYPE_IN_GENERIC_CALL)</a></h3>
<p> This call to a generic collection method passes an argument
- while compile type Object where a specific type from
- the generic type parameters is expected.
- Thus, neither the standard Java type system nor static analysis
- can provide useful information on whether the
- object being passed as a parameter is of an appropriate type.
- </p>
+ while compile type Object where a specific type from
+ the generic type parameters is expected.
+ Thus, neither the standard Java type system nor static analysis
+ can provide useful information on whether the
+ object being passed as a parameter is of an appropriate type.
+ </p>
<h3><a name="HE_EQUALS_NO_HASHCODE">HE: Class defines equals() but not hashCode() (HE_EQUALS_NO_HASHCODE)</a></h3>
@@ -779,7 +820,7 @@
the recommended <code>hashCode</code> implementation to use is:</p>
<pre>public int hashCode() {
assert false : "hashCode not designed";
- return 42; // any arbitrary constant will do
+ return 42; // any arbitrary constant will do
}</pre>
@@ -804,10 +845,10 @@
than simple reference equality.)</p>
<p>If you don't think instances of this class will ever be inserted into a HashMap/HashTable,
the recommended <code>hashCode</code> implementation to use is:</p>
-<p><pre>public int hashCode() {
+<pre>public int hashCode() {
assert false : "hashCode not designed";
- return 42; // any arbitrary constant will do
- }</pre></p>
+ return 42; // any arbitrary constant will do
+ }</pre>
<h3><a name="HE_INHERITS_EQUALS_USE_HASHCODE">HE: Class inherits equals() and uses Object.hashCode() (HE_INHERITS_EQUALS_USE_HASHCODE)</a></h3>
@@ -835,11 +876,11 @@
<pre>
public class CircularClassInitialization {
- static class InnerClassSingleton extends CircularClassInitialization {
- static InnerClassSingleton singleton = new InnerClassSingleton();
- }
-
- static CircularClassInitialization foo = InnerClassSingleton.singleton;
+ static class InnerClassSingleton extends CircularClassInitialization {
+ static InnerClassSingleton singleton = new InnerClassSingleton();
+ }
+
+ static CircularClassInitialization foo = InnerClassSingleton.singleton;
}
</pre>
@@ -889,22 +930,22 @@
<h3><a name="NP_BOOLEAN_RETURN_NULL">NP: Method with Boolean return type returns explicit null (NP_BOOLEAN_RETURN_NULL)</a></h3>
-
- <p>
- A method that returns either Boolean.TRUE, Boolean.FALSE or null is an accident waiting to happen.
- This method can be invoked as though it returned a value of type boolean, and
- the compiler will insert automatic unboxing of the Boolean value. If a null value is returned,
- this will result in a NullPointerException.
- </p>
-
-
+
+ <p>
+ A method that returns either Boolean.TRUE, Boolean.FALSE or null is an accident waiting to happen.
+ This method can be invoked as though it returned a value of type boolean, and
+ the compiler will insert automatic unboxing of the Boolean value. If a null value is returned,
+ this will result in a NullPointerException.
+ </p>
+
+
<h3><a name="NP_CLONE_COULD_RETURN_NULL">NP: Clone method may return null (NP_CLONE_COULD_RETURN_NULL)</a></h3>
<p>
- This clone method seems to return null in some circumstances, but clone is never
- allowed to return a null value. If you are convinced this path is unreachable, throw an AssertionError
- instead.
+ This clone method seems to return null in some circumstances, but clone is never
+ allowed to return a null value. If you are convinced this path is unreachable, throw an AssertionError
+ instead.
</p>
@@ -923,9 +964,9 @@
<p>
- This toString method seems to return null in some circumstances. A liberal reading of the
- spec could be interpreted as allowing this, but it is probably a bad idea and could cause
- other code to break. Return the empty string or some other appropriate string rather than null.
+ This toString method seems to return null in some circumstances. A liberal reading of the
+ spec could be interpreted as allowing this, but it is probably a bad idea and could cause
+ other code to break. Return the empty string or some other appropriate string rather than null.
</p>
@@ -968,8 +1009,8 @@
<h3><a name="NM_FUTURE_KEYWORD_USED_AS_MEMBER_IDENTIFIER">Nm: Use of identifier that is a keyword in later versions of Java (NM_FUTURE_KEYWORD_USED_AS_MEMBER_IDENTIFIER)</a></h3>
-<p>This identifier is used as a keyword in later versions of Java. This code, and
-any code that references this API,
+<p>This identifier is used as a keyword in later versions of Java. This code, and
+any code that references this API,
will need to be changed in order to compile it in later versions of Java.</p>
@@ -986,7 +1027,7 @@
<p> This class/interface has a simple name that is identical to that of an implemented/extended interface, except
-that the interface is in a different package (e.g., <code>alpha.Foo</code> extends <code>beta.Foo</code>).
+that the interface is in a different package (e.g., <code>alpha.Foo</code> extends <code>beta.Foo</code>).
This can be exceptionally confusing, create lots of situations in which you have to look at import statements
to resolve references and creates many
opportunities to accidently define methods that do not override methods in their superclasses.
@@ -997,7 +1038,7 @@
<p> This class has a simple name that is identical to that of its superclass, except
-that its superclass is in a different package (e.g., <code>alpha.Foo</code> extends <code>beta.Foo</code>).
+that its superclass is in a different package (e.g., <code>alpha.Foo</code> extends <code>beta.Foo</code>).
This can be exceptionally confusing, create lots of situations in which you have to look at import statements
to resolve references and creates many
opportunities to accidently define methods that do not override methods in their superclasses.
@@ -1007,10 +1048,10 @@
<h3><a name="NM_VERY_CONFUSING_INTENTIONAL">Nm: Very confusing method names (but perhaps intentional) (NM_VERY_CONFUSING_INTENTIONAL)</a></h3>
- <p> The referenced methods have names that differ only by capitalization.
+ <p> The referenced methods have names that differ only by capitalization.
This is very confusing because if the capitalization were
identical then one of the methods would override the other. From the existence of other methods, it
-seems that the existence of both of these methods is intentional, but is sure is confusing.
+seems that the existence of both of these methods is intentional, but is sure is confusing.
You should try hard to eliminate one of them, unless you are forced to have both due to frozen APIs.
</p>
@@ -1037,7 +1078,7 @@
</blockquote>
<p>The <code>f(Foo)</code> method defined in class <code>B</code> doesn't
-override the
+override the
<code>f(Foo)</code> method defined in class <code>A</code>, because the argument
types are <code>Foo</code>'s from different packages.
</p>
@@ -1077,7 +1118,7 @@
<p> The method creates an IO stream object, does not assign it to any
-fields, pass it to other methods that might close it,
+fields, pass it to other methods that might close it,
or return it, and does not appear to close
the stream on all paths out of the method. This may result in
a file descriptor leak. It is generally a good
@@ -1096,12 +1137,26 @@
closed.</p>
+<h3><a name="PZ_DONT_REUSE_ENTRY_OBJECTS_IN_ITERATORS">PZ: Don't reuse entry objects in iterators (PZ_DONT_REUSE_ENTRY_OBJECTS_IN_ITERATORS)</a></h3>
+
+
+ <p> The entrySet() method is allowed to return a view of the
+ underlying Map in which an Iterator and Map.Entry. This clever
+ idea was used in several Map implementations, but introduces the possibility
+ of nasty coding mistakes. If a map <code>m</code> returns
+ such an iterator for an entrySet, then
+ <code>c.addAll(m.entrySet())</code> will go badly wrong. All of
+ the Map implementations in OpenJDK 1.7 have been rewritten to avoid this,
+ you should to.
+ </p>
+
+
<h3><a name="RC_REF_COMPARISON_BAD_PRACTICE">RC: Suspicious reference comparison to constant (RC_REF_COMPARISON_BAD_PRACTICE)</a></h3>
<p> This method compares a reference value to a constant using the == or != operator,
where the correct way to compare instances of this type is generally
-with the equals() method.
+with the equals() method.
It is possible to create distinct instances that are equal but do not compare as == since
they are different objects.
Examples of classes which should generally
@@ -1111,7 +1166,7 @@
<h3><a name="RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN">RC: Suspicious reference comparison of Boolean values (RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN)</a></h3>
-<p> This method compares two Boolean values using the == or != operator.
+<p> This method compares two Boolean values using the == or != operator.
Normally, there are only two Boolean values (Boolean.TRUE and Boolean.FALSE),
but it is possible to create other Boolean objects using the <code>new Boolean(b)</code>
constructor. It is best to avoid such objects, but if they do exist,
@@ -1146,13 +1201,24 @@
requested number of bytes.</p>
+<h3><a name="RV_NEGATING_RESULT_OF_COMPARETO">RV: Negating the result of compareTo()/compare() (RV_NEGATING_RESULT_OF_COMPARETO)</a></h3>
+
+
+ <p> This code negatives the return value of a compareTo or compare method.
+This is a questionable or bad programming practice, since if the return
+value is Integer.MIN_VALUE, negating the return value won't
+negate the sign of the result. You can achieve the same intended result
+by reversing the order of the operands rather than by negating the results.
+</p>
+
+
<h3><a name="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE">RV: Method ignores exceptional return value (RV_RETURN_VALUE_IGNORED_BAD_PRACTICE)</a></h3>
<p> This method returns a value that is not checked. The return value should be checked
since it can indicate an unusual or unexpected function execution. For
example, the <code>File.delete()</code> method returns false
-if the file could not be successfully deleted (rather than
+if the file could not be successfully deleted (rather than
throwing an Exception).
If you don't check the result, you won't notice if the method invocation
signals unexpected behavior by returning an atypical return value.
@@ -1169,7 +1235,7 @@
<h3><a name="SW_SWING_METHODS_INVOKED_IN_SWING_THREAD">SW: Certain swing methods needs to be invoked in Swing thread (SW_SWING_METHODS_INVOKED_IN_SWING_THREAD)</a></h3>
-<p>(<a href="http://java.sun.com/developer/JDCTechTips/2003/tt1208.html#1">From JDC Tech Tip</a>): The Swing methods
+<p>(<a href="http://web.archive.org/web/20090526170426/http://java.sun.com/developer/JDCTechTips/2003/tt1208.html">From JDC Tech Tip</a>): The Swing methods
show(), setVisible(), and pack() will create the associated peer for the frame.
With the creation of the peer, the system creates the event dispatch thread.
This makes things problematic because the event dispatch thread could be notifying
@@ -1199,7 +1265,7 @@
Thus, attempts to serialize it will also attempt to associate instance of the outer
class with which it is associated, leading to a runtime error.
</p>
-<p>If possible, making the inner class a static inner class should solve the
+<p>If possible, making the inner class a static inner class should solve the
problem. Making the outer class serializable might also work, but that would
mean serializing an instance of the inner class would always also serialize the instance
of the outer class, which it often not what you really want.
@@ -1231,8 +1297,8 @@
<p> This Serializable class is an inner class. Any attempt to serialize
it will also serialize the associated outer instance. The outer instance is serializable,
so this won't fail, but it might serialize a lot more data than intended.
-If possible, making the inner class a static inner class (also known as a nested class) should solve the
-problem.
+If possible, making the inner class a static inner class (also known as a nested class) should solve the
+problem.
<h3><a name="SE_NONFINAL_SERIALVERSIONID">Se: serialVersionUID isn't final (SE_NONFINAL_SERIALVERSIONID)</a></h3>
@@ -1294,7 +1360,7 @@
<h3><a name="SE_TRANSIENT_FIELD_NOT_RESTORED">Se: Transient field that isn't set by deserialization. (SE_TRANSIENT_FIELD_NOT_RESTORED)</a></h3>
- <p> This class contains a field that is updated at multiple places in the class, thus it seems to be part of the state of the class. However, since the field is marked as transient and not set in readObject or readResolve, it will contain the default value in any
+ <p> This class contains a field that is updated at multiple places in the class, thus it seems to be part of the state of the class. However, since the field is marked as transient and not set in readObject or readResolve, it will contain the default value in any
deserialized instance of the class.
</p>
@@ -1343,10 +1409,10 @@
<p>
-This cast will always throw a ClassCastException.
+This cast will always throw a ClassCastException.
The analysis believes it knows
the precise type of the value being cast, and the attempt to
-downcast it to a subtype will always fail by throwing a ClassCastException.
+downcast it to a subtype will always fail by throwing a ClassCastException.
</p>
@@ -1355,7 +1421,7 @@
<p>
This code is casting the result of calling <code>toArray()</code> on a collection
-to a type more specific than <code>Object[]</code>, as in:
+to a type more specific than <code>Object[]</code>, as in:</p>
<pre>
String[] getAsArray(Collection<String> c) {
return (String[]) c.toArray();
@@ -1387,11 +1453,11 @@
<h3><a name="BIT_ADD_OF_SIGNED_BYTE">BIT: Bitwise add of signed byte value (BIT_ADD_OF_SIGNED_BYTE)</a></h3>
-<p> Adds a byte value and a value which is known to the 8 lower bits clear.
+<p> Adds a byte value and a value which is known to have the 8 lower bits clear.
Values loaded from a byte array are sign extended to 32 bits
before any any bitwise operations are performed on the value.
Thus, if <code>b[0]</code> contains the value <code>0xff</code>, and
-<code>x</code> is initially 0, then the code
+<code>x</code> is initially 0, then the code
<code>((x << 8) + b[0])</code> will sign extend <code>0xff</code>
to get <code>0xffffffff</code>, and thus give the value
<code>0xffffffff</code> as the result.
@@ -1400,14 +1466,14 @@
<p>In particular, the following code for packing a byte array into an int is badly wrong: </p>
<pre>
int result = 0;
-for(int i = 0; i < 4; i++)
+for(int i = 0; i < 4; i++)
result = ((result << 8) + b[i]);
</pre>
<p>The following idiom will work instead: </p>
<pre>
int result = 0;
-for(int i = 0; i < 4; i++)
+for(int i = 0; i < 4; i++)
result = ((result << 8) + (b[i] & 0xff));
</pre>
@@ -1446,11 +1512,12 @@
<h3><a name="BIT_IOR_OF_SIGNED_BYTE">BIT: Bitwise OR of signed byte value (BIT_IOR_OF_SIGNED_BYTE)</a></h3>
-<p> Loads a value from a byte array and performs a bitwise OR with
-that value. Values loaded from a byte array are sign extended to 32 bits
+<p> Loads a byte value (e.g., a value loaded from a byte array or returned by a method
+with return type byte) and performs a bitwise OR with
+that value. Byte values are sign extended to 32 bits
before any any bitwise operations are performed on the value.
Thus, if <code>b[0]</code> contains the value <code>0xff</code>, and
-<code>x</code> is initially 0, then the code
+<code>x</code> is initially 0, then the code
<code>((x << 8) | b[0])</code> will sign extend <code>0xff</code>
to get <code>0xffffffff</code>, and thus give the value
<code>0xffffffff</code> as the result.
@@ -1459,14 +1526,14 @@
<p>In particular, the following code for packing a byte array into an int is badly wrong: </p>
<pre>
int result = 0;
-for(int i = 0; i < 4; i++)
+for(int i = 0; i < 4; i++)
result = ((result << 8) | b[i]);
</pre>
<p>The following idiom will work instead: </p>
<pre>
int result = 0;
-for(int i = 0; i < 4; i++)
+for(int i = 0; i < 4; i++)
result = ((result << 8) | (b[i] & 0xff));
</pre>
@@ -1475,9 +1542,9 @@
<h3><a name="BIT_SIGNED_CHECK_HIGH_BIT">BIT: Check for sign of bitwise operation (BIT_SIGNED_CHECK_HIGH_BIT)</a></h3>
-<p> This method compares an expression such as
+<p> This method compares an expression such as</p>
<pre>((event.detail & SWT.SELECTED) > 0)</pre>.
-Using bit arithmetic and then comparing with the greater than operator can
+<p>Using bit arithmetic and then comparing with the greater than operator can
lead to unexpected results (of course depending on the value of
SWT.SELECTED). If SWT.SELECTED is a negative number, this is a candidate
for a bug. Even when SWT.SELECTED is not negative, it seems good practice
@@ -1496,16 +1563,16 @@
get called when the event occurs.</p>
-<h3><a name="ICAST_BAD_SHIFT_AMOUNT">BSHIFT: 32 bit int shifted by an amount not in the range 0..31 (ICAST_BAD_SHIFT_AMOUNT)</a></h3>
+<h3><a name="ICAST_BAD_SHIFT_AMOUNT">BSHIFT: 32 bit int shifted by an amount not in the range -31..31 (ICAST_BAD_SHIFT_AMOUNT)</a></h3>
<p>
The code performs shift of a 32 bit int by a constant amount outside
-the range 0..31.
+the range -31..31.
The effect of this is to use the lower 5 bits of the integer
value to decide how much to shift by (e.g., shifting by 40 bits is the same as shifting by 8 bits,
-and shifting by 32 bits is the same as shifting by zero bits). This probably isn't want was expected,
-and it at least confusing.
+and shifting by 32 bits is the same as shifting by zero bits). This probably isn't what was expected,
+and it is at least confusing.
</p>
@@ -1516,12 +1583,23 @@
evaluation of a conditional ternary operator (the <code> b ? e1 : e2</code> operator). The
semantics of Java mandate that if <code>e1</code> and <code>e2</code> are wrapped
numeric values, the values are unboxed and converted/coerced to their common type (e.g,
-if <code>e1</code> is of type <code>Integer</code>
+if <code>e1</code> is of type <code>Integer</code>
and <code>e2</code> is of type <code>Float</code>, then <code>e1</code> is unboxed,
converted to a floating point value, and boxed. See JLS Section 15.25.
</p>
+<h3><a name="CO_COMPARETO_RESULTS_MIN_VALUE">Co: compareTo()/compare() returns Integer.MIN_VALUE (CO_COMPARETO_RESULTS_MIN_VALUE)</a></h3>
+
+
+ <p> In some situation, this compareTo or compare method returns
+the constant Integer.MIN_VALUE, which is an exceptionally bad practice.
+ The only thing that matters about the return value of compareTo is the sign of the result.
+ But people will sometimes negate the return value of compareTo, expecting that this will negate
+ the sign of the result. And it will, except in the case where the value returned is Integer.MIN_VALUE.
+ So just return -1 rather than Integer.MIN_VALUE.
+
+
<h3><a name="DLS_DEAD_STORE_OF_CLASS_LITERAL">DLS: Dead store of class literal (DLS_DEAD_STORE_OF_CLASS_LITERAL)</a></h3>
@@ -1547,6 +1625,15 @@
</p>
+<h3><a name="DMI_ARGUMENTS_WRONG_ORDER">DMI: Reversed method arguments (DMI_ARGUMENTS_WRONG_ORDER)</a></h3>
+
+
+<p> The arguments to this method call seem to be in the wrong order.
+For example, a call <code>Preconditions.checkNotNull("message", message)</code>
+has reserved arguments: the value to be checked is the first argument.
+</p>
+
+
<h3><a name="DMI_BAD_MONTH">DMI: Bad constant value for month (DMI_BAD_MONTH)</a></h3>
@@ -1556,6 +1643,19 @@
</p>
+<h3><a name="DMI_BIGDECIMAL_CONSTRUCTED_FROM_DOUBLE">DMI: BigDecimal constructed from double that isn't represented precisely (DMI_BIGDECIMAL_CONSTRUCTED_FROM_DOUBLE)</a></h3>
+
+
+ <p>
+This code creates a BigDecimal from a double value that doesn't translate well to a
+decimal number.
+For example, one might assume that writing new BigDecimal(0.1) in Java creates a BigDecimal which is exactly equal to 0.1 (an unscaled value of 1, with a scale of 1), but it is actually equal to 0.1000000000000000055511151231257827021181583404541015625.
+You probably want to use the BigDecimal.valueOf(double d) method, which uses the String representation
+of the double to create the BigDecimal (e.g., BigDecimal.valueOf(0.1) gives 0.1).
+</p>
+
+
+
<h3><a name="DMI_CALLING_NEXT_FROM_HASNEXT">DMI: hasNext method invokes next (DMI_CALLING_NEXT_FROM_HASNEXT)</a></h3>
@@ -1569,13 +1669,22 @@
<h3><a name="DMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVES">DMI: Collections should not contain themselves (DMI_COLLECTIONS_SHOULD_NOT_CONTAIN_THEMSELVES)</a></h3>
- <p> This call to a generic collection's method would only make sense if a collection contained
+ <p> This call to a generic collection's method would only make sense if a collection contained
itself (e.g., if <code>s.contains(s)</code> were true). This is unlikely to be true and would cause
problems if it were true (such as the computation of the hash code resulting in infinite recursion).
It is likely that the wrong value is being passed as a parameter.
- </p>
+ </p>
+<h3><a name="DMI_DOH">DMI: D'oh! A nonsensical method invocation (DMI_DOH)</a></h3>
+
+
+ <p>
+This partical method invocation doesn't make sense, for reasons that should be apparent from inspection.
+</p>
+
+
+
<h3><a name="DMI_INVOKING_HASHCODE_ON_ARRAY">DMI: Invocation of hashCode on an array (DMI_INVOKING_HASHCODE_ON_ARRAY)</a></h3>
@@ -1583,7 +1692,7 @@
The code invokes hashCode on an array. Calling hashCode on
an array returns the same value as System.identityHashCode, and ingores
the contents and length of the array. If you need a hashCode that
-depends on the contents of an array <code>a</code>,
+depends on the contents of an array <code>a</code>,
use <code>java.util.Arrays.hashCode(a)</code>.
</p>
@@ -1593,8 +1702,8 @@
<p> The Double.longBitsToDouble method is invoked, but a 32 bit int value is passed
- as an argument. This almostly certainly is not intended and is unlikely
- to give the intended result.
+ as an argument. This almostly certainly is not intended and is unlikely
+ to give the intended result.
</p>
@@ -1603,7 +1712,7 @@
<p> This call doesn't make sense. For any collection <code>c</code>, calling <code>c.containsAll(c)</code> should
always be true, and <code>c.retainAll(c)</code> should have no effect.
- </p>
+ </p>
<h3><a name="DMI_ANNOTATION_IS_NOT_VISIBLE_TO_REFLECTION">Dm: Can't use reflection to check for presence of annotation without runtime retention (DMI_ANNOTATION_IS_NOT_VISIBLE_TO_REFLECTION)</a></h3>
@@ -1617,16 +1726,16 @@
<h3><a name="DMI_FUTILE_ATTEMPT_TO_CHANGE_MAXPOOL_SIZE_OF_SCHEDULED_THREAD_POOL_EXECUTOR">Dm: Futile attempt to change max pool size of ScheduledThreadPoolExecutor (DMI_FUTILE_ATTEMPT_TO_CHANGE_MAXPOOL_SIZE_OF_SCHEDULED_THREAD_POOL_EXECUTOR)</a></h3>
- <p>(<a href="http://java.sun.com/javase/6/docs/api/java/util/concurrent/ScheduledThreadPoolExecutor.html">Javadoc</a>)
+ <p>(<a href="http://java.sun.com/javase/6/docs/api/java/util/concurrent/ScheduledThreadPoolExecutor.html">Javadoc</a>)
While ScheduledThreadPoolExecutor inherits from ThreadPoolExecutor, a few of the inherited tuning methods are not useful for it. In particular, because it acts as a fixed-sized pool using corePoolSize threads and an unbounded queue, adjustments to maximumPoolSize have no useful effect.
- </p>
+ </p>
<h3><a name="DMI_SCHEDULED_THREAD_POOL_EXECUTOR_WITH_ZERO_CORE_THREADS">Dm: Creation of ScheduledThreadPoolExecutor with zero core threads (DMI_SCHEDULED_THREAD_POOL_EXECUTOR_WITH_ZERO_CORE_THREADS)</a></h3>
- <p>(<a href="http://java.sun.com/javase/6/docs/api/java/util/concurrent/ScheduledThreadPoolExecutor.html#ScheduledThreadPoolExecutor(int)">Javadoc</a>)
+ <p>(<a href="http://java.sun.com/javase/6/docs/api/java/util/concurrent/ScheduledThreadPoolExecutor.html#ScheduledThreadPoolExecutor(int)">Javadoc</a>)
A ScheduledThreadPoolExecutor with zero core threads will never execute anything; changes to the max pool size are ignored.
</p>
@@ -1635,7 +1744,7 @@
<h3><a name="DMI_VACUOUS_CALL_TO_EASYMOCK_METHOD">Dm: Useless/vacuous call to EasyMock method (DMI_VACUOUS_CALL_TO_EASYMOCK_METHOD)</a></h3>
- <p>This call doesn't pass any objects to the EasyMock method, so the call doesn't do anything.
+ <p>This call doesn't pass any objects to the EasyMock method, so the call doesn't do anything.
</p>
@@ -1661,7 +1770,7 @@
method of Object, calling equals on an array is the same as comparing their addresses. To compare the
contents of the arrays, use <code>java.util.Arrays.equals(Object[], Object[])</code>.
To compare the addresses of the arrays, it would be
-less confusing to explicitly pointer equality using <code>==</code>.
+less confusing to explicitly check pointer equality using <code>==</code>.
</p>
@@ -1676,7 +1785,7 @@
</p>
-<h3><a name="EC_NULL_ARG">EC: Call to equals() with null argument (EC_NULL_ARG)</a></h3>
+<h3><a name="EC_NULL_ARG">EC: Call to equals(null) (EC_NULL_ARG)</a></h3>
<p> This method calls equals(Object), passing a null value as
@@ -1751,12 +1860,11 @@
<p> This class defines an equals method that always returns false. This means that an object is not equal to itself, and it is impossible to create useful Maps or Sets of this class. More fundamentally, it means
that equals is not reflexive, one of the requirements of the equals method.</p>
-<p>The likely intended semantics are object identity: that an object is equal to itself. This is the behavior inherited from class <code>Object</code>. If you need to override an equals inherited from a different
-superclass, you can use use:
+<p>The likely intended semantics are object identity: that an object is equal to itself. This is the behavior inherited from class <code>Object</code>. If you need to override an equals inherited from a different
+superclass, you can use use:</p>
<pre>
public boolean equals(Object o) { return this == o; }
</pre>
-</p>
<h3><a name="EQ_ALWAYS_TRUE">Eq: equals method always returns true (EQ_ALWAYS_TRUE)</a></h3>
@@ -1793,7 +1901,7 @@
<p> This class defines an <code>equals()</code>
method, that doesn't override the normal <code>equals(Object)</code> method
- defined in the base <code>java.lang.Object</code> class. Instead, it
+ defined in the base <code>java.lang.Object</code> class. Instead, it
inherits an <code>equals(Object)</code> method from a superclass.
The class should probably define a <code>boolean equals(Object)</code> method.
</p>
@@ -1836,15 +1944,15 @@
<p>
This code checks to see if a floating point value is equal to the special
- Not A Number value (e.g., <code>if (x == Double.NaN)</code>). However,
- because of the special semantics of <code>NaN</code>, no value
- is equal to <code>Nan</code>, including <code>NaN</code>. Thus,
- <code>x == Double.NaN</code> always evaluates to false.
+ Not A Number value (e.g., <code>if (x == Double.NaN)</code>). However,
+ because of the special semantics of <code>NaN</code>, no value
+ is equal to <code>Nan</code>, including <code>NaN</code>. Thus,
+ <code>x == Double.NaN</code> always evaluates to false.
- To check to see if a value contained in <code>x</code>
- is the special Not A Number value, use
- <code>Double.isNaN(x)</code> (or <code>Float.isNaN(x)</code> if
- <code>x</code> is floating point precision).
+ To check to see if a value contained in <code>x</code>
+ is the special Not A Number value, use
+ <code>Double.isNaN(x)</code> (or <code>Float.isNaN(x)</code> if
+ <code>x</code> is floating point precision).
</p>
@@ -1858,12 +1966,12 @@
System.out.println("%d\n", "hello");
</code>
<p>The %d placeholder requires a numeric argument, but a string value is
-passed instead.
-A runtime exception will occur when
+passed instead.
+A runtime exception will occur when
this statement is executed.
</p>
-
+
<h3><a name="VA_FORMAT_STRING_BAD_CONVERSION">FS: The type of a supplied argument doesn't match format specifier (VA_FORMAT_STRING_BAD_CONVERSION)</a></h3>
@@ -1874,7 +1982,7 @@
the String "1" is incompatible with the format specifier %d.
</p>
-
+
<h3><a name="VA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIED">FS: MessageFormat supplied where printf style format expected (VA_FORMAT_STRING_EXPECTED_MESSAGE_FORMAT_SUPPLIED)</a></h3>
@@ -1886,80 +1994,79 @@
is required. At runtime, all of the arguments will be ignored
and the format string will be returned exactly as provided without any formatting.
</p>
-</p>
-
+
<h3><a name="VA_FORMAT_STRING_EXTRA_ARGUMENTS_PASSED">FS: More arguments are passed than are actually used in the format string (VA_FORMAT_STRING_EXTRA_ARGUMENTS_PASSED)</a></h3>
<p>
A format-string method with a variable number of arguments is called,
but more arguments are passed than are actually used by the format string.
-This won't cause a runtime exception, but the code may be silently omitting
+This won't cause a runtime exception, but the code may be silently omitting
information that was intended to be included in the formatted string.
</p>
-
+
<h3><a name="VA_FORMAT_STRING_ILLEGAL">FS: Illegal format string (VA_FORMAT_STRING_ILLEGAL)</a></h3>
<p>
-The format string is syntactically invalid,
-and a runtime exception will occur when
+The format string is syntactically invalid,
+and a runtime exception will occur when
this statement is executed.
</p>
-
+
<h3><a name="VA_FORMAT_STRING_MISSING_ARGUMENT">FS: Format string references missing argument (VA_FORMAT_STRING_MISSING_ARGUMENT)</a></h3>
<p>
Not enough arguments are passed to satisfy a placeholder in the format string.
-A runtime exception will occur when
+A runtime exception will occur when
this statement is executed.
</p>
-
+
<h3><a name="VA_FORMAT_STRING_NO_PREVIOUS_ARGUMENT">FS: No previous argument for format string (VA_FORMAT_STRING_NO_PREVIOUS_ARGUMENT)</a></h3>
<p>
The format string specifies a relative index to request that the argument for the previous format specifier
be reused. However, there is no previous argument.
-For example,
+For example,
</p>
<p><code>formatter.format("%<s %s", "a", "b")</code>
</p>
<p>would throw a MissingFormatArgumentException when executed.
</p>
-
+
<h3><a name="GC_UNRELATED_TYPES">GC: No relationship between generic parameter and method argument (GC_UNRELATED_TYPES)</a></h3>
<p> This call to a generic collection method contains an argument
with an incompatible class from that of the collection's parameter
- (i.e., the type of the argument is neither a supertype nor a subtype
- of the corresponding generic type argument).
- Therefore, it is unlikely that the collection contains any objects
- that are equal to the method argument used here.
- Most likely, the wrong value is being passed to the method.</p>
- <p>In general, instances of two unrelated classes are not equal.
- For example, if the <code>Foo</code> and <code>Bar</code> classes
- are not related by subtyping, then an instance of <code>Foo</code>
- should not be equal to an instance of <code>Bar</code>.
- Among other issues, doing so will likely result in an equals method
- that is not symmetrical. For example, if you define the <code>Foo</code> class
- so that a <code>Foo</code> can be equal to a <code>String</code>,
- your equals method isn't symmetrical since a <code>String</code> can only be equal
- to a <code>String</code>.
- </p>
- <p>In rare cases, people do define nonsymmetrical equals methods and still manage to make
- their code work. Although none of the APIs document or guarantee it, it is typically
- the case that if you check if a <code>Collection<String></code> contains
- a <code>Foo</code>, the equals method of argument (e.g., the equals method of the
- <code>Foo</code> class) used to perform the equality checks.
- </p>
+ (i.e., the type of the argument is neither a supertype nor a subtype
+ of the corresponding generic type argument).
+ Therefore, it is unlikely that the collection contains any objects
+ that are equal to the method argument used here.
+ Most likely, the wrong value is being passed to the method.</p>
+ <p>In general, instances of two unrelated classes are not equal.
+ For example, if the <code>Foo</code> and <code>Bar</code> classes
+ are not related by subtyping, then an instance of <code>Foo</code>
+ should not be equal to an instance of <code>Bar</code>.
+ Among other issues, doing so will likely result in an equals method
+ that is not symmetrical. For example, if you define the <code>Foo</code> class
+ so that a <code>Foo</code> can be equal to a <code>String</code>,
+ your equals method isn't symmetrical since a <code>String</code> can only be equal
+ to a <code>String</code>.
+ </p>
+ <p>In rare cases, people do define nonsymmetrical equals methods and still manage to make
+ their code work. Although none of the APIs document or guarantee it, it is typically
+ the case that if you check if a <code>Collection<String></code> contains
+ a <code>Foo</code>, the equals method of argument (e.g., the equals method of the
+ <code>Foo</code> class) used to perform the equality checks.
+ </p>
<h3><a name="HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS">HE: Signature declares use of unhashable class in hashed construct (HE_SIGNATURE_DECLARES_HASHING_OF_UNHASHABLE_CLASS)</a></h3>
@@ -1982,11 +2089,39 @@
fix this problem of highest importance.
+<h3><a name="ICAST_INT_2_LONG_AS_INSTANT">ICAST: int value converted to long and used as absolute time (ICAST_INT_2_LONG_AS_INSTANT)</a></h3>
+
+
+<p>
+This code converts a 32-bit int value to a 64-bit long value, and then
+passes that value for a method parameter that requires an absolute time value.
+An absolute time value is the number
+of milliseconds since the standard base time known as "the epoch", namely January 1, 1970, 00:00:00 GMT.
+For example, the following method, intended to convert seconds since the epoc into a Date, is badly
+broken:</p>
+<pre>
+Date getDate(int seconds) { return new Date(seconds * 1000); }
+</pre>
+<p>The multiplication is done using 32-bit arithmetic, and then converted to a 64-bit value.
+When a 32-bit value is converted to 64-bits and used to express an absolute time
+value, only dates in December 1969 and January 1970 can be represented.</p>
+
+<p>Correct implementations for the above method are:</p>
+
+<pre>
+// Fails for dates after 2037
+Date getDate(int seconds) { return new Date(seconds * 1000L); }
+
+// better, works for all dates
+Date getDate(long seconds) { return new Date(seconds * 1000); }
+</pre>
+
+
<h3><a name="ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL">ICAST: integral value cast to double and then passed to Math.ceil (ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL)</a></h3>
<p>
-This code converts an integral value (e.g., int or long)
+This code converts an integral value (e.g., int or long)
to a double precision
floating point number and then
passing the result to the Math.ceil() function, which rounds a double to
@@ -2009,7 +2144,7 @@
to the argument. This operation should always be a no-op,
since the converting an integer to a float should give a number with no fractional part.
It is likely that the operation that generated the value to be passed
-to Math.round was intended to be performed using
+to Math.round was intended to be performed using
floating point arithmetic.
</p>
@@ -2030,11 +2165,10 @@
<p> Class is a JUnit TestCase and defines a suite() method.
-However, the suite method needs to be declared as either
+However, the suite method needs to be declared as either</p>
<pre>public static junit.framework.Test suite()</pre>
-or
+or
<pre>public static junit.framework.TestSuite suite()</pre>
-</p>
<h3><a name="IJU_NO_TESTS">IJU: TestCase has no tests (IJU_NO_TESTS)</a></h3>
@@ -2096,6 +2230,15 @@
</p>
+<h3><a name="INT_BAD_COMPARISON_WITH_INT_VALUE">INT: Bad comparison of int value with long constant (INT_BAD_COMPARISON_WITH_INT_VALUE)</a></h3>
+
+
+<p> This code compares an int value with a long constant that is outside
+the range of values that can be represented as an int value.
+This comparison is vacuous and possibily to be incorrect.
+</p>
+
+
<h3><a name="INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE">INT: Bad comparison of nonnegative value with negative constant (INT_BAD_COMPARISON_WITH_NONNEGATIVE_VALUE)</a></h3>
@@ -2117,15 +2260,15 @@
<p>
- This code opens a file in append mode and then wraps the result in an object output stream.
+ This code opens a file in append mode and then wraps the result in an object output stream.
This won't allow you to append to an existing object output stream stored in a file. If you want to be
able to append to an object output stream, you need to keep the object output stream open.
</p>
<p>The only situation in which opening a file in append mode and the writing an object output stream
could work is if on reading the file you plan to open it in random access mode and seek to the byte offset
where the append started.
- </p>
-
+ </p>
+
<p>
TODO: example.
</p>
@@ -2183,9 +2326,9 @@
<p>
- A parameter to this method has been identified as a value that should
- always be checked to see whether or not it is null, but it is being dereferenced
- without a preceding null check.
+ A parameter to this method has been identified as a value that should
+ always be checked to see whether or not it is null, but it is being dereferenced
+ without a preceding null check.
</p>
@@ -2194,40 +2337,52 @@
<p> close() is being invoked on a value that is always null. If this statement is executed,
a null pointer exception will occur. But the big risk here you never close
-something that should be closed.
+something that should be closed.
<h3><a name="NP_GUARANTEED_DEREF">NP: Null value is guaranteed to be dereferenced (NP_GUARANTEED_DEREF)</a></h3>
-
- <p>
- There is a statement or branch that if executed guarantees that
- a value is null at this point, and that
- value that is guaranteed to be dereferenced
- (except on forward paths involving runtime exceptions).
- </p>
-
-
+
+ <p>
+ There is a statement or branch that if executed guarantees that
+ a value is null at this point, and that
+ value that is guaranteed to be dereferenced
+ (except on forward paths involving runtime exceptions).
+ </p>
+ <p>Note that a check such as
+ <code>if (x == null) throw new NullPointerException();</code>
+ is treated as a dereference of <code>x</code>.
+
+
<h3><a name="NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH">NP: Value is null and guaranteed to be dereferenced on exception path (NP_GUARANTEED_DEREF_ON_EXCEPTION_PATH)</a></h3>
-
- <p>
- There is a statement or branch on an exception path
- that if executed guarantees that
- a value is null at this point, and that
- value that is guaranteed to be dereferenced
- (except on forward paths involving runtime exceptions).
- </p>
-
-
+
+ <p>
+ There is a statement or branch on an exception path
+ that if executed guarantees that
+ a value is null at this point, and that
+ value that is guaranteed to be dereferenced
+ (except on forward paths involving runtime exceptions).
+ </p>
+
+
+<h3><a name="NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR">NP: Nonnull field is not initialized (NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR)</a></h3>
+
+
+ <p> The field is marked as nonnull, but isn't written to by the constructor.
+ The field might be initialized elsewhere during constructor, or might always
+ be initialized before use.
+ </p>
+
+
<h3><a name="NP_NONNULL_PARAM_VIOLATION">NP: Method call passes null to a nonnull parameter (NP_NONNULL_PARAM_VIOLATION)</a></h3>
<p>
This method passes a null value as the parameter of a method which
- must be nonnull. Either this parameter has been explicitly marked
- as @Nonnull, or analysis has determined that this parameter is
- always dereferenced.
+ must be nonnull. Either this parameter has been explicitly marked
+ as @Nonnull, or analysis has determined that this parameter is
+ always dereferenced.
</p>
@@ -2279,9 +2434,9 @@
<p>
This method call passes a null value for a nonnull method parameter.
- Either the parameter is annotated as a parameter that should
- always be nonnull, or analysis has shown that it will always be
- dereferenced.
+ Either the parameter is annotated as a parameter that should
+ always be nonnull, or analysis has shown that it will always be
+ dereferenced.
</p>
@@ -2291,9 +2446,9 @@
<p>
A possibly-null value is passed at a call site where all known
target methods require the parameter to be nonnull.
- Either the parameter is annotated as a parameter that should
- always be nonnull, or analysis has shown that it will always be
- dereferenced.
+ Either the parameter is annotated as a parameter that should
+ always be nonnull, or analysis has shown that it will always be
+ dereferenced.
</p>
@@ -2302,9 +2457,9 @@
<p>
A possibly-null value is passed to a nonnull method parameter.
- Either the parameter is annotated as a parameter that should
- always be nonnull, or analysis has shown that it will always be
- dereferenced.
+ Either the parameter is annotated as a parameter that should
+ always be nonnull, or analysis has shown that it will always be
+ dereferenced.
</p>
@@ -2318,7 +2473,8 @@
<p> The program is dereferencing a field that does not seem to ever have a non-null value written to it.
-Dereferencing this value will generate a null pointer exception.
+Unless the field is initialized via some mechanism not seen by the analysis,
+dereferencing this value will generate a null pointer exception.
</p>
@@ -2351,15 +2507,15 @@
<p> This regular method has the same name as the class it is defined in. It is likely that this was intended to be a constructor.
If it was intended to be a constructor, remove the declaration of a void return value.
- If you had accidently defined this method, realized the mistake, defined a proper constructor
- but can't get rid of this method due to backwards compatibility, deprecate the method.
+ If you had accidently defined this method, realized the mistake, defined a proper constructor
+ but can't get rid of this method due to backwards compatibility, deprecate the method.
</p>
<h3><a name="NM_VERY_CONFUSING">Nm: Very confusing method names (NM_VERY_CONFUSING)</a></h3>
- <p> The referenced methods have names that differ only by capitalization.
+ <p> The referenced methods have names that differ only by capitalization.
This is very confusing because if the capitalization were
identical then one of the methods would override the other.
</p>
@@ -2386,7 +2542,7 @@
</blockquote>
<p>The <code>f(Foo)</code> method defined in class <code>B</code> doesn't
-override the
+override the
<code>f(Foo)</code> method defined in class <code>A</code>, because the argument
types are <code>Foo</code>'s from different packages.
</p>
@@ -2397,7 +2553,7 @@
<p>
This method assigns a literal boolean value (true or false) to a boolean variable inside
- an if or while expression. Most probably this was supposed to be a boolean comparison using
+ an if or while expression. Most probably this was supposed to be a boolean comparison using
==, not an assignment using =.
</p>
@@ -2407,7 +2563,7 @@
<p> This method compares two reference values using the == or != operator,
where the correct way to compare instances of this type is generally
-with the equals() method.
+with the equals() method.
It is possible to create distinct instances that are equal but do not compare as == since
they are different objects.
Examples of classes which should generally
@@ -2419,7 +2575,7 @@
<p> A value is checked here to see whether it is null, but this value can't
be null because it was previously dereferenced and if it were null a null pointer
-exception would have occurred at the earlier dereference.
+exception would have occurred at the earlier dereference.
Essentially, this code and the previous dereference
disagree as to whether this value is allowed to be null. Either the check is redundant
or the previous dereference is erroneous.</p>
@@ -2439,7 +2595,7 @@
<p>
-The code here uses <code>File.separator</code>
+The code here uses <code>File.separator</code>
where a regular expression is required. This will fail on Windows
platforms, where the <code>File.separator</code> is a backslash, which is interpreted in a
regular expression as an escape character. Amoung other options, you can just use
@@ -2474,8 +2630,8 @@
<p> This code generates a hashcode and then computes
-the absolute value of that hashcode. If the hashcode
-is <code>Integer.MIN_VALUE</code>, then the result will be negative as well (since
+the absolute value of that hashcode. If the hashcode
+is <code>Integer.MIN_VALUE</code>, then the result will be negative as well (since
<code>Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE</code>).
</p>
<p>One out of 2^32 strings have a hashCode of Integer.MIN_VALUE,
@@ -2483,16 +2639,25 @@
</p>
-<h3><a name="RV_ABSOLUTE_VALUE_OF_RANDOM_INT">RV: Bad attempt to compute absolute value of signed 32-bit random integer (RV_ABSOLUTE_VALUE_OF_RANDOM_INT)</a></h3>
+<h3><a name="RV_ABSOLUTE_VALUE_OF_RANDOM_INT">RV: Bad attempt to compute absolute value of signed random integer (RV_ABSOLUTE_VALUE_OF_RANDOM_INT)</a></h3>
<p> This code generates a random signed integer and then computes
the absolute value of that random integer. If the number returned by the random number
-generator is <code>Integer.MIN_VALUE</code>, then the result will be negative as well (since
-<code>Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE</code>).
+generator is <code>Integer.MIN_VALUE</code>, then the result will be negative as well (since
+<code>Math.abs(Integer.MIN_VALUE) == Integer.MIN_VALUE</code>). (Same problem arised for long values as well).
</p>
+<h3><a name="RV_CHECK_COMPARETO_FOR_SPECIFIC_RETURN_VALUE">RV: Code checks for specific values returned by compareTo (RV_CHECK_COMPARETO_FOR_SPECIFIC_RETURN_VALUE)</a></h3>
+
+
+ <p> This code invoked a compareTo or compare method, and checks to see if the return value is a specific value,
+such as 1 or -1. When invoking these methods, you should only check the sign of the result, not for any specific
+non-zero value. While many or most compareTo and compare methods only return -1, 0 or 1, some of them
+will return other values.
+
+
<h3><a name="RV_EXCEPTION_NOT_THROWN">RV: Exception created and dropped rather than thrown (RV_EXCEPTION_NOT_THROWN)</a></h3>
@@ -2543,24 +2708,10 @@
<p>The code contains a conditional test is performed twice, one right after the other
(e.g., <code>x == 0 || x == 0</code>). Perhaps the second occurrence is intended to be something else
-(e.g., <code>x == 0 || y == 0</code>).
+(e.g., <code>x == 0 || y == 0</code>).
</p>
-<h3><a name="SA_FIELD_DOUBLE_ASSIGNMENT">SA: Double assignment of field (SA_FIELD_DOUBLE_ASSIGNMENT)</a></h3>
-
-
-<p> This method contains a double assignment of a field; e.g.
-</p>
-<pre>
- int x,y;
- public void foo() {
- x = x = 17;
- }
-</pre>
-<p>Assigning to a field twice is useless, and may indicate a logic error or typo.</p>
-
-
<h3><a name="SA_FIELD_SELF_ASSIGNMENT">SA: Self assignment of field (SA_FIELD_SELF_ASSIGNMENT)</a></h3>
@@ -2594,6 +2745,21 @@
</p>
+<h3><a name="SA_LOCAL_SELF_ASSIGNMENT_INSTEAD_OF_FIELD">SA: Self assignment of local rather than assignment to field (SA_LOCAL_SELF_ASSIGNMENT_INSTEAD_OF_FIELD)</a></h3>
+
+
+<p> This method contains a self assignment of a local variable, and there
+is a field with an identical name.
+assignment appears to have been ; e.g.</p>
+<pre>
+ int foo;
+ public void setFoo(int foo) {
+ foo = foo;
+ }
+</pre>
+<p>The assignment is useless. Did you mean to assign to the field instead?</p>
+
+
<h3><a name="SA_LOCAL_SELF_COMPARISON">SA: Self comparison of value with itself (SA_LOCAL_SELF_COMPARISON)</a></h3>
@@ -2617,7 +2783,7 @@
<p> A value stored in the previous switch case is overwritten here due to a switch fall through. It is likely that
- you forgot to put a break or return at the end of the previous case.
+ you forgot to put a break or return at the end of the previous case.
</p>
@@ -2625,8 +2791,8 @@
<p> A value stored in the previous switch case is ignored here due to a switch fall through to a place where
- an exception is thrown. It is likely that
- you forgot to put a break or return at the end of the previous case.
+ an exception is thrown. It is likely that
+ you forgot to put a break or return at the end of the previous case.
</p>
@@ -2636,7 +2802,7 @@
<p> This class is an inner class, but should probably be a static inner class.
As it is, there is a serious danger of a deadly embrace between the inner class
and the thread local in the outer class. Because the inner class isn't static,
- it retains a reference to the outer class.
+ it retains a reference to the outer class.
If the thread local contains a reference to an instance of the inner
class, the inner and outer instance will both be reachable
and not eligible for garbage collection.
@@ -2707,18 +2873,18 @@
consumed in a location or locations requiring that the value not
carry that annotation.
</p>
-
+
<p>
More precisely, a value annotated with a type qualifier specifying when=ALWAYS
is guaranteed to reach a use or uses where the same type qualifier specifies when=NEVER.
</p>
-
+
<p>
For example, say that @NonNegative is a nickname for
the type qualifier annotation @Negative(when=When.NEVER).
The following code will generate this warning because
the return statement requires a @NonNegative value,
- but receives one that is marked as @Negative.
+ but receives one that is marked as @Negative.
</p>
<blockquote>
<pre>
@@ -2729,13 +2895,42 @@
</blockquote>
+<h3><a name="TQ_COMPARING_VALUES_WITH_INCOMPATIBLE_TYPE_QUALIFIERS">TQ: Comparing values with incompatible type qualifiers (TQ_COMPARING_VALUES_WITH_INCOMPATIBLE_TYPE_QUALIFIERS)</a></h3>
+
+
+ <p>
+ A value specified as carrying a type qualifier annotation is
+ compared with a value that doesn't ever carry that qualifier.
+ </p>
+
+ <p>
+ More precisely, a value annotated with a type qualifier specifying when=ALWAYS
+ is compared with a value that where the same type qualifier specifies when=NEVER.
+ </p>
+
+ <p>
+ For example, say that @NonNegative is a nickname for
+ the type qualifier annotation @Negative(when=When.NEVER).
+ The following code will generate this warning because
+ the return statement requires a @NonNegative value,
+ but receives one that is marked as @Negative.
+ </p>
+ <blockquote>
+<pre>
+public boolean example(@Negative Integer value1, @NonNegative Integer value2) {
+ return value1.equals(value2);
+}
+</pre>
+ </blockquote>
+
+
<h3><a name="TQ_MAYBE_SOURCE_VALUE_REACHES_ALWAYS_SINK">TQ: Value that might not carry a type qualifier is always used in a way requires that type qualifier (TQ_MAYBE_SOURCE_VALUE_REACHES_ALWAYS_SINK)</a></h3>
<p>
A value that is annotated as possibility not being an instance of
- the values denoted by the type qualifier, and the value is guaranteed to be used
- in a way that requires values denoted by that type qualifier.
+ the values denoted by the type qualifier, and the value is guaranteed to be used
+ in a way that requires values denoted by that type qualifier.
</p>
@@ -2744,8 +2939,8 @@
<p>
A value that is annotated as possibility being an instance of
- the values denoted by the type qualifier, and the value is guaranteed to be used
- in a way that prohibits values denoted by that type qualifier.
+ the values denoted by the type qualifier, and the value is guaranteed to be used
+ in a way that prohibits values denoted by that type qualifier.
</p>
@@ -2757,7 +2952,7 @@
to be consumed in a location or locations requiring that the value does
carry that annotation.
</p>
-
+
<p>
More precisely, a value annotated with a type qualifier specifying when=NEVER
is guaranteed to reach a use or uses where the same type qualifier specifies when=ALWAYS.
@@ -2765,7 +2960,24 @@
<p>
TODO: example
- </p>
+ </p>
+
+
+<h3><a name="TQ_UNKNOWN_VALUE_USED_WHERE_ALWAYS_STRICTLY_REQUIRED">TQ: Value without a type qualifier used where a value is required to have that qualifier (TQ_UNKNOWN_VALUE_USED_WHERE_ALWAYS_STRICTLY_REQUIRED)</a></h3>
+
+
+ <p>
+ A value is being used in a way that requires the value be annotation with a type qualifier.
+ The type qualifier is strict, so the tool rejects any values that do not have
+ the appropriate annotation.
+ </p>
+
+ <p>
+ To coerce a value to have a strict annotation, define an identity function where the return value is annotated
+ with the strict annotation.
+ This is the only way to turn a non-annotated value into a value with a strict type qualifier annotation.
+ </p>
+
<h3><a name="UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS">UMAC: Uncallable method defined in anonymous class (UMAC_UNCALLABLE_METHOD_OF_ANONYMOUS_CLASS)</a></h3>
@@ -2792,7 +3004,7 @@
<p> This method is invoked in the constructor of of the superclass. At this point,
- the fields of the class have not yet initialized.</p>
+ the fields of the class have not yet initialized.</p>
<p>To make this more concrete, consider the following classes:</p>
<pre>abstract class A {
int hashCode;
@@ -2818,7 +3030,7 @@
</p>
-<h3><a name="DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY">USELESS_STRING: Invocation of toString on an array (DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY)</a></h3>
+<h3><a name="DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY">USELESS_STRING: Invocation of toString on an unnamed array (DMI_INVOKING_TOSTRING_ON_ANONYMOUS_ARRAY)</a></h3>
<p>
@@ -2848,7 +3060,7 @@
Consider wrapping the array using <code>Arrays.asList(...)</code> before handling it off to a formatted.
</p>
-
+
<h3><a name="UWF_NULL_FIELD">UwF: Field only ever set to null (UWF_NULL_FIELD)</a></h3>
@@ -2875,7 +3087,7 @@
<h3><a name="LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE">LG: Potential lost logger changes due to weak reference in OpenJDK (LG_LOST_LOGGER_DUE_TO_WEAK_REFERENCE)</a></h3>
-
+
<p>OpenJDK introduces a potential incompatibility.
In particular, the java.util.logging.Logger behavior has
changed. Instead of using strong references, it now uses weak references
@@ -2886,80 +3098,145 @@
consider:
</p>
-<p><pre>public static void initLogging() throws Exception {
+<pre>public static void initLogging() throws Exception {
Logger logger = Logger.getLogger("edu.umd.cs");
logger.addHandler(new FileHandler()); // call to change logger configuration
logger.setUseParentHandlers(false); // another call to change logger configuration
-}</pre></p>
+}</pre>
<p>The logger reference is lost at the end of the method (it doesn't
escape the method), so if you have a garbage collection cycle just
after the call to initLogging, the logger configuration is lost
(because Logger only keeps weak references).</p>
-<p><pre>public static void main(String[] args) throws Exception {
+<pre>public static void main(String[] args) throws Exception {
initLogging(); // adds a file handler to the logger
System.gc(); // logger configuration lost
Logger.getLogger("edu.umd.cs").info("Some message"); // this isn't logged to the file as expected
-}</pre></p>
+}</pre>
<p><em>Ulf Ochsenfahrt and Eric Fellheimer</em></p>
-
-
+
+
<h3><a name="OBL_UNSATISFIED_OBLIGATION">OBL: Method may fail to clean up stream or resource (OBL_UNSATISFIED_OBLIGATION)</a></h3>
-
- <p>
- This method may fail to clean up (close, dispose of) a stream,
- database object, or other
- resource requiring an explicit cleanup operation.
- </p>
-
- <p>
- In general, if a method opens a stream or other resource,
- the method should use a try/finally block to ensure that
- the stream or resource is cleaned up before the method
- returns.
- </p>
-
- <p>
- This bug pattern is essentially the same as the
- OS_OPEN_STREAM and ODR_OPEN_DATABASE_RESOURCE
- bug patterns, but is based on a different
- (and hopefully better) static analysis technique.
- We are interested is getting feedback about the
- usefulness of this bug pattern.
- To send feedback, either:
- </p>
- <ul>
- <li>send email to findbugs@cs.umd.edu</li>
- <li>file a bug report: <a href="http://findbugs.sourceforge.net/reportingBugs.html">http://findbugs.sourceforge.net/reportingBugs.html</a></li>
- </ul>
-
- <p>
- In particular,
- the false-positive suppression heuristics for this
- bug pattern have not been extensively tuned, so
- reports about false positives are helpful to us.
- </p>
-
- <p>
- See Weimer and Necula, <i>Finding and Preventing Run-Time Error Handling Mistakes</i>, for
- a description of the analysis technique.
- </p>
-
-
+
+ <p>
+ This method may fail to clean up (close, dispose of) a stream,
+ database object, or other
+ resource requiring an explicit cleanup operation.
+ </p>
+
+ <p>
+ In general, if a method opens a stream or other resource,
+ the method should use a try/finally block to ensure that
+ the stream or resource is cleaned up before the method
+ returns.
+ </p>
+
+ <p>
+ This bug pattern is essentially the same as the
+ OS_OPEN_STREAM and ODR_OPEN_DATABASE_RESOURCE
+ bug patterns, but is based on a different
+ (and hopefully better) static analysis technique.
+ We are interested is getting feedback about the
+ usefulness of this bug pattern.
+ To send feedback, either:
+ </p>
+ <ul>
+ <li>send email to findbugs@cs.umd.edu</li>
+ <li>file a bug report: <a href="http://findbugs.sourceforge.net/reportingBugs.html">http://findbugs.sourceforge.net/reportingBugs.html</a></li>
+ </ul>
+
+ <p>
+ In particular,
+ the false-positive suppression heuristics for this
+ bug pattern have not been extensively tuned, so
+ reports about false positives are helpful to us.
+ </p>
+
+ <p>
+ See Weimer and Necula, <i>Finding and Preventing Run-Time Error Handling Mistakes</i>, for
+ a description of the analysis technique.
+ </p>
+
+
+<h3><a name="OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE">OBL: Method may fail to clean up stream or resource on checked exception (OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE)</a></h3>
+
+
+ <p>
+ This method may fail to clean up (close, dispose of) a stream,
+ database object, or other
+ resource requiring an explicit cleanup operation.
+ </p>
+
+ <p>
+ In general, if a method opens a stream or other resource,
+ the method should use a try/finally block to ensure that
+ the stream or resource is cleaned up before the method
+ returns.
+ </p>
+
+ <p>
+ This bug pattern is essentially the same as the
+ OS_OPEN_STREAM and ODR_OPEN_DATABASE_RESOURCE
+ bug patterns, but is based on a different
+ (and hopefully better) static analysis technique.
+ We are interested is getting feedback about the
+ usefulness of this bug pattern.
+ To send feedback, either:
+ </p>
+ <ul>
+ <li>send email to findbugs@cs.umd.edu</li>
+ <li>file a bug report: <a href="http://findbugs.sourceforge.net/reportingBugs.html">http://findbugs.sourceforge.net/reportingBugs.html</a></li>
+ </ul>
+
+ <p>
+ In particular,
+ the false-positive suppression heuristics for this
+ bug pattern have not been extensively tuned, so
+ reports about false positives are helpful to us.
+ </p>
+
+ <p>
+ See Weimer and Necula, <i>Finding and Preventing Run-Time Error Handling Mistakes</i>, for
+ a description of the analysis technique.
+ </p>
+
+
<h3><a name="DM_CONVERT_CASE">Dm: Consider using Locale parameterized version of invoked method (DM_CONVERT_CASE)</a></h3>
<p> A String is being converted to upper or lowercase, using the platform's default encoding. This may
result in improper conversions when used with international characters. Use the </p>
<ul>
- <li>String.toUpperCase( Locale l )</li>
- <li>String.toLowerCase( Locale l )</li>
- </ul>
+ <li>String.toUpperCase( Locale l )</li>
+ <li>String.toLowerCase( Locale l )</li>
+ </ul>
<p>versions instead.</p>
+<h3><a name="DM_DEFAULT_ENCODING">Dm: Reliance on default encoding (DM_DEFAULT_ENCODING)</a></h3>
+
+
+<p> Found a call to a method which will perform a byte to String (or String to byte) conversion, and will assume that the default platform encoding is suitable. This will cause the application behaviour to vary between platforms. Use an alternative API and specify a charset name or Charset object explicitly. </p>
+
+
+<h3><a name="DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED">DP: Classloaders should only be created inside doPrivileged block (DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED)</a></h3>
+
+
+ <p> This code creates a classloader, which needs permission if a security manage is installed.
+ If this code might be invoked by code that does not
+ have security permissions, then the classloader creation needs to occur inside a doPrivileged block.</p>
+
+
+<h3><a name="DP_DO_INSIDE_DO_PRIVILEGED">DP: Method invoked that should be only be invoked inside a doPrivileged block (DP_DO_INSIDE_DO_PRIVILEGED)</a></h3>
+
+
+ <p> This code invokes a method that requires a security permission check.
+ If this code will be granted security permissions, but might be invoked by code that does not
+ have security permissions, then the invocation needs to occur inside a doPrivileged block.</p>
+
+
<h3><a name="EI_EXPOSE_REP">EI: May expose internal representation by returning reference to mutable object (EI_EXPOSE_REP)</a></h3>
@@ -3080,12 +3357,34 @@
<p>
- A mutable static field could be changed by malicious code or
+This static field public but not final, and
+could be changed by malicious code or
by accident from another package.
The field could be made final to avoid
this vulnerability.</p>
+<h3><a name="MS_SHOULD_BE_REFACTORED_TO_BE_FINAL">MS: Field isn't final but should be refactored to be so (MS_SHOULD_BE_REFACTORED_TO_BE_FINAL)</a></h3>
+
+
+ <p>
+This static field public but not final, and
+could be changed by malicious code or
+by accident from another package.
+The field could be made final to avoid
+this vulnerability. However, the static initializer contains more than one write
+to the field, so doing so will require some refactoring.
+</p>
+
+
+<h3><a name="AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION">AT: Sequence of calls to concurrent abstraction may not be atomic (AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION)</a></h3>
+
+
+ <p>This code contains a sequence of calls to a concurrent abstraction
+ (such as a concurrent hash map).
+ These calls will not be executed atomically.
+
+
<h3><a name="DC_DOUBLECHECK">DC: Possible double check of field (DC_DOUBLECHECK)</a></h3>
@@ -3096,14 +3395,14 @@
>http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html</a>.</p>
-<h3><a name="DL_SYNCHRONIZATION_ON_BOOLEAN">DL: Synchronization on Boolean could lead to deadlock (DL_SYNCHRONIZATION_ON_BOOLEAN)</a></h3>
+<h3><a name="DL_SYNCHRONIZATION_ON_BOOLEAN">DL: Synchronization on Boolean (DL_SYNCHRONIZATION_ON_BOOLEAN)</a></h3>
- <p> The code synchronizes on a boxed primitive constant, such as an Boolean.
+ <p> The code synchronizes on a boxed primitive constant, such as an Boolean.</p>
<pre>
private static Boolean inited = Boolean.FALSE;
...
- synchronized(inited) {
+ synchronized(inited) {
if (!inited) {
init();
inited = Boolean.TRUE;
@@ -3111,67 +3410,67 @@
}
...
</pre>
-</p>
<p>Since there normally exist only two Boolean objects, this code could be synchronizing on the same object as other, unrelated code, leading to unresponsiveness
and possible deadlock</p>
+<p>See CERT <a href="https://www.securecoding.cert.org/confluence/display/java/CON08-J.+Do+not+synchronize+on+objects+that+may+be+reused">CON08-J. Do not synchronize on objects that may be reused</a> for more information.</p>
-<h3><a name="DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE">DL: Synchronization on boxed primitive could lead to deadlock (DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE)</a></h3>
+<h3><a name="DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE">DL: Synchronization on boxed primitive (DL_SYNCHRONIZATION_ON_BOXED_PRIMITIVE)</a></h3>
- <p> The code synchronizes on a boxed primitive constant, such as an Integer.
+ <p> The code synchronizes on a boxed primitive constant, such as an Integer.</p>
<pre>
private static Integer count = 0;
...
- synchronized(count) {
+ synchronized(count) {
count++;
}
...
</pre>
-</p>
<p>Since Integer objects can be cached and shared,
this code could be synchronizing on the same object as other, unrelated code, leading to unresponsiveness
and possible deadlock</p>
+<p>See CERT <a href="https://www.securecoding.cert.org/confluence/display/java/CON08-J.+Do+not+synchronize+on+objects+that+may+be+reused">CON08-J. Do not synchronize on objects that may be reused</a> for more information.</p>
-<h3><a name="DL_SYNCHRONIZATION_ON_SHARED_CONSTANT">DL: Synchronization on interned String could lead to deadlock (DL_SYNCHRONIZATION_ON_SHARED_CONSTANT)</a></h3>
+<h3><a name="DL_SYNCHRONIZATION_ON_SHARED_CONSTANT">DL: Synchronization on interned String (DL_SYNCHRONIZATION_ON_SHARED_CONSTANT)</a></h3>
- <p> The code synchronizes on interned String.
+ <p> The code synchronizes on interned String.</p>
<pre>
private static String LOCK = "LOCK";
...
synchronized(LOCK) { ...}
...
</pre>
-</p>
<p>Constant Strings are interned and shared across all other classes loaded by the JVM. Thus, this could
is locking on something that other code might also be locking. This could result in very strange and hard to diagnose
blocking and deadlock behavior. See <a href="http://www.javalobby.org/java/forums/t96352.html">http://www.javalobby.org/java/forums/t96352.html</a> and <a href="http://jira.codehaus.org/browse/JETTY-352">http://jira.codehaus.org/browse/JETTY-352</a>.
</p>
+<p>See CERT <a href="https://www.securecoding.cert.org/confluence/display/java/CON08-J.+Do+not+synchronize+on+objects+that+may+be+reused">CON08-J. Do not synchronize on objects that may be reused</a> for more information.</p>
<h3><a name="DL_SYNCHRONIZATION_ON_UNSHARED_BOXED_PRIMITIVE">DL: Synchronization on boxed primitive values (DL_SYNCHRONIZATION_ON_UNSHARED_BOXED_PRIMITIVE)</a></h3>
- <p> The code synchronizes on an apparently unshared boxed primitive,
-such as an Integer.
+ <p> The code synchronizes on an apparently unshared boxed primitive,
+such as an Integer.</p>
<pre>
private static final Integer fileLock = new Integer(1);
...
- synchronized(fileLock) {
+ synchronized(fileLock) {
.. do something ..
}
...
</pre>
-</p>
-<p>It would be much better, in this code, to redeclare fileLock as
+<p>It would be much better, in this code, to redeclare fileLock as</p>
<pre>
private static final Object fileLock = new Object();
</pre>
-The existing code might be OK, but it is confusing and a
+<p>
+The existing code might be OK, but it is confusing and a
future refactoring, such as the "Remove Boxing" refactoring in IntelliJ,
-might replace this with the use of an interned Integer object shared
+might replace this with the use of an interned Integer object shared
throughout the JVM, leading to very confusing behavior and potential deadlock.
</p>
@@ -3241,7 +3540,7 @@
<h3><a name="IS_FIELD_NOT_GUARDED">IS: Field not guarded against concurrent access (IS_FIELD_NOT_GUARDED)</a></h3>
- <p> This field is annotated with net.jcip.annotations.GuardedBy,
+ <p> This field is annotated with net.jcip.annotations.GuardedBy,
but can be accessed in a way that seems to violate the annotation.</p>
@@ -3250,12 +3549,42 @@
<p> This method performs synchronization an object that implements
java.util.concurrent.locks.Lock. Such an object is locked/unlocked
-using
+using
<code>acquire()</code>/<code>release()</code> rather
than using the <code>synchronized (...)</code> construct.
</p>
+<h3><a name="JLM_JSR166_UTILCONCURRENT_MONITORENTER">JLM: Synchronization performed on util.concurrent instance (JLM_JSR166_UTILCONCURRENT_MONITORENTER)</a></h3>
+
+
+<p> This method performs synchronization an object that is an instance of
+a class from the java.util.concurrent package (or its subclasses). Instances
+of these classes have their own concurrency control mechanisms that are orthogonal to
+the synchronization provided by the Java keyword <code>synchronized</code>. For example,
+synchronizing on an <code>AtomicBoolean</code> will not prevent other threads
+from modifying the <code>AtomicBoolean</code>.</p>
+<p>Such code may be correct, but should be carefully reviewed and documented,
+and may confuse people who have to maintain the code at a later date.
+</p>
+
+
+<h3><a name="JML_JSR166_CALLING_WAIT_RATHER_THAN_AWAIT">JLM: Using monitor style wait methods on util.concurrent abstraction (JML_JSR166_CALLING_WAIT_RATHER_THAN_AWAIT)</a></h3>
+
+
+<p> This method calls
+<code>wait()</code>,
+<code>notify()</code> or
+<code>notifyAll()()</code>
+on an object that also provides an
+<code>await()</code>,
+<code>signal()</code>,
+<code>signalAll()</code> method (such as util.concurrent Condition objects).
+This probably isn't what you want, and even if you do want it, you should consider changing
+your design, as other developers will find it exceptionally confusing.
+</p>
+
+
<h3><a name="LI_LAZY_INIT_STATIC">LI: Incorrect lazy initialization of static field (LI_LAZY_INIT_STATIC)</a></h3>
@@ -3289,12 +3618,11 @@
<p> This method synchronizes on a field in what appears to be an attempt
to guard against simultaneous updates to that field. But guarding a field
-gets a lock on the referenced object, not on the field. This may not
-provide the mutual exclusion you need, and other threads might
+gets a lock on the referenced object, not on the field. This may not
+provide the mutual exclusion you need, and other threads might
be obtaining locks on the referenced objects (for other purposes). An example
-of this pattern would be:
-
-<p><pre>
+of this pattern would be:</p>
+<pre>
private Long myNtfSeqNbrCounter = new Long(0);
private Long getNotificationSequenceNumber() {
Long result = null;
@@ -3306,9 +3634,6 @@
}
</pre>
-
-</p>
-
<h3><a name="ML_SYNC_ON_UPDATED_FIELD">ML: Method synchronizes on an updated field (ML_SYNC_ON_UPDATED_FIELD)</a></h3>
@@ -3323,9 +3648,9 @@
<p>A web server generally only creates one instance of servlet or jsp class (i.e., treats
-the class as a Singleton),
-and will
-have multiple threads invoke methods on that instance to service multiple
+the class as a Singleton),
+and will
+have multiple threads invoke methods on that instance to service multiple
simultaneous requests.
Thus, having a mutable instance field generally creates race conditions.
@@ -3366,7 +3691,7 @@
<p>Since the field is synchronized on, it seems not likely to be null.
If it is null and then synchronized on a NullPointerException will be
-thrown and the check would be pointless. Better to synchronize on
+thrown and the check would be pointless. Better to synchronize on
another field.</p>
@@ -3393,16 +3718,16 @@
<h3><a name="RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED">RV: Return value of putIfAbsent ignored, value passed to putIfAbsent reused (RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED)</a></h3>
-
- The <code>putIfAbsent</code> method is typically used to ensure that a
- single value is associated with a given key (the first value for which put
- if absent succeeds).
- If you ignore the return value and retain a reference to the value passed in,
- you run the risk of retaining a value that is not the one that is associated with the key in the map.
- If it matters which one you use and you use the one that isn't stored in the map,
- your program will behave incorrectly.
-
-
+
+ The <code>putIfAbsent</code> method is typically used to ensure that a
+ single value is associated with a given key (the first value for which put
+ if absent succeeds).
+ If you ignore the return value and retain a reference to the value passed in,
+ you run the risk of retaining a value that is not the one that is associated with the key in the map.
+ If it matters which one you use and you use the one that isn't stored in the map,
+ your program will behave incorrectly.
+
+
<h3><a name="RU_INVOKE_RUN">Ru: Invokes run on a thread (did you mean to start it instead?) (RU_INVOKE_RUN)</a></h3>
@@ -3432,7 +3757,7 @@
<h3><a name="STCAL_INVOKE_ON_STATIC_CALENDAR_INSTANCE">STCAL: Call to static Calendar (STCAL_INVOKE_ON_STATIC_CALENDAR_INSTANCE)</a></h3>
-<p>Even though the JavaDoc does not contain a hint about it, Calendars are inherently unsafe for multihtreaded use.
+<p>Even though the JavaDoc does not contain a hint about it, Calendars are inherently unsafe for multihtreaded use.
The detector has found a call to an instance of Calendar that has been obtained via a static
field. This looks suspicous.</p>
<p>For more information on this see <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6231579">Sun Bug #6231579</a>
@@ -3442,17 +3767,17 @@
<h3><a name="STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE">STCAL: Call to static DateFormat (STCAL_INVOKE_ON_STATIC_DATE_FORMAT_INSTANCE)</a></h3>
-<p>As the JavaDoc states, DateFormats are inherently unsafe for multithreaded use.
+<p>As the JavaDoc states, DateFormats are inherently unsafe for multithreaded use.
The detector has found a call to an instance of DateFormat that has been obtained via a static
field. This looks suspicous.</p>
<p>For more information on this see <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6231579">Sun Bug #6231579</a>
and <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6178997">Sun Bug #6178997</a>.</p>
-<h3><a name="STCAL_STATIC_CALENDAR_INSTANCE">STCAL: Static Calendar (STCAL_STATIC_CALENDAR_INSTANCE)</a></h3>
+<h3><a name="STCAL_STATIC_CALENDAR_INSTANCE">STCAL: Static Calendar field (STCAL_STATIC_CALENDAR_INSTANCE)</a></h3>
-<p>Even though the JavaDoc does not contain a hint about it, Calendars are inherently unsafe for multihtreaded use.
+<p>Even though the JavaDoc does not contain a hint about it, Calendars are inherently unsafe for multihtreaded use.
Sharing a single instance across thread boundaries without proper synchronization will result in erratic behavior of the
application. Under 1.4 problems seem to surface less often than under Java 5 where you will probably see
random ArrayIndexOutOfBoundsExceptions or IndexOutOfBoundsExceptions in sun.util.calendar.BaseCalendar.getCalendarDateFromFixedDate().</p>
@@ -3465,7 +3790,7 @@
<h3><a name="STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE">STCAL: Static DateFormat (STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE)</a></h3>
-<p>As the JavaDoc states, DateFormats are inherently unsafe for multithreaded use.
+<p>As the JavaDoc states, DateFormats are inherently unsafe for multithreaded use.
Sharing a single instance across thread boundaries without proper synchronization will result in erratic behavior of the
application.</p>
<p>You may also experience serialization problems.</p>
@@ -3550,11 +3875,20 @@
<p> This method contains a call to <code>java.lang.Object.wait()</code> which
is not guarded by conditional control flow. The code should
- verify that condition it intends to wait for is not already satisfied
- before calling wait; any previous notifications will be ignored.
+ verify that condition it intends to wait for is not already satisfied
+ before calling wait; any previous notifications will be ignored.
</p>
+<h3><a name="VO_VOLATILE_INCREMENT">VO: An increment to a volatile field isn't atomic (VO_VOLATILE_INCREMENT)</a></h3>
+
+
+<p>This code increments a volatile field. Increments of volatile fields aren't
+atomic. If more than one thread is incrementing the field at the same time,
+increments could be lost.
+</p>
+
+
<h3><a name="VO_VOLATILE_REFERENCE_TO_ARRAY">VO: A volatile reference to an array doesn't treat the array elements as volatile (VO_VOLATILE_REFERENCE_TO_ARRAY)</a></h3>
@@ -3566,13 +3900,13 @@
in Java 5.0).</p>
-<h3><a name="WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL">WL: Sychronization on getClass rather than class literal (WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL)</a></h3>
+<h3><a name="WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL">WL: Synchronization on getClass rather than class literal (WL_USING_GETCLASS_RATHER_THAN_CLASS_LITERAL)</a></h3>
<p>
This instance method synchronizes on <code>this.getClass()</code>. If this class is subclassed,
subclasses will synchronize on the class object for the subclass, which isn't likely what was intended.
- For example, consider this code from java.awt.Label:
+ For example, consider this code from java.awt.Label:</p>
<pre>
private static final String base = "label";
private static int nameCounter = 0;
@@ -3581,9 +3915,9 @@
return base + nameCounter++;
}
}
- </pre></p>
+ </pre>
<p>Subclasses of <code>Label</code> won't synchronize on the same subclass, giving rise to a datarace.
- Instead, this code should be synchronizing on <code>Label.class</code>
+ Instead, this code should be synchronizing on <code>Label.class</code></p>
<pre>
private static final String base = "label";
private static int nameCounter = 0;
@@ -3592,7 +3926,7 @@
return base + nameCounter++;
}
}
- </pre></p>
+ </pre>
<p>Bug pattern contributed by Jason Mehrens</p>
@@ -3626,7 +3960,7 @@
<p>A primitive is boxed, and then immediately unboxed. This probably is due to a manual
- boxing in a place where an unboxed value is required, thus forcing the compiler
+ boxing in a place where an unboxed value is required, thus forcing the compiler
to immediately undo the work of the boxing.
</p>
@@ -3638,6 +3972,13 @@
(e.g., <code>new Double(d).intValue()</code>). Just perform direct primitive coercion (e.g., <code>(int) d</code>).</p>
+<h3><a name="BX_UNBOXING_IMMEDIATELY_REBOXED">Bx: Boxed value is unboxed and then immediately reboxed (BX_UNBOXING_IMMEDIATELY_REBOXED)</a></h3>
+
+
+ <p>A boxed value is unboxed and then immediately reboxed.
+</p>
+
+
<h3><a name="DM_BOXED_PRIMITIVE_TOSTRING">Bx: Method allocates a boxed primitive just to call toString (DM_BOXED_PRIMITIVE_TOSTRING)</a></h3>
@@ -3743,6 +4084,9 @@
<p>If <code>r</code> is a <code>java.util.Random</code>, you can generate a random number from <code>0</code> to <code>n-1</code>
using <code>r.nextInt(n)</code>, rather than using <code>(int)(r.nextDouble() * n)</code>.
</p>
+<p>The argument to nextInt must be positive. If, for example, you want to generate a random
+value from -99 to 0, use <code>-r.nextInt(100)</code>.
+</p>
<h3><a name="DM_STRING_CTOR">Dm: Method invokes inefficient new String(String) constructor (DM_STRING_CTOR)</a></h3>
@@ -3776,12 +4120,12 @@
<p>
- A large String constant is duplicated across multiple class files.
- This is likely because a final field is initialized to a String constant, and the Java language
- mandates that all references to a final field from other classes be inlined into
+ A large String constant is duplicated across multiple class files.
+ This is likely because a final field is initialized to a String constant, and the Java language
+ mandates that all references to a final field from other classes be inlined into
that classfile. See <a href="http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6447475">JDK bug 6447475</a>
- for a description of an occurrence of this bug in the JDK and how resolving it reduced
- the size of the JDK by 1 megabyte.
+ for a description of an occurrence of this bug in the JDK and how resolving it reduced
+ the size of the JDK by 1 megabyte.
</p>
@@ -3988,8 +4332,8 @@
<h3><a name="DMI_CONSTANT_DB_PASSWORD">Dm: Hardcoded constant database password (DMI_CONSTANT_DB_PASSWORD)</a></h3>
- <p>This code creates a database connect using a hardcoded, constant password. Anyone with access to either the source code or the compiled code can
- easily learn the password.
+ <p>This code creates a database connect using a hardcoded, constant password. Anyone with access to either the source code or the compiled code can
+ easily learn the password.
</p>
@@ -3997,7 +4341,7 @@
<h3><a name="DMI_EMPTY_DB_PASSWORD">Dm: Empty database password (DMI_EMPTY_DB_PASSWORD)</a></h3>
- <p>This code creates a database connect using a blank or empty password. This indicates that the database is not protected by a password.
+ <p>This code creates a database connect using a blank or empty password. This indicates that the database is not protected by a password.
</p>
@@ -4005,12 +4349,12 @@
<h3><a name="HRS_REQUEST_PARAMETER_TO_COOKIE">HRS: HTTP cookie formed from untrusted input (HRS_REQUEST_PARAMETER_TO_COOKIE)</a></h3>
- <p>This code constructs an HTTP Cookie using an untrusted HTTP parameter. If this cookie is added to an HTTP response, it will allow a HTTP response splitting
+ <p>This code constructs an HTTP Cookie using an untrusted HTTP parameter. If this cookie is added to an HTTP response, it will allow a HTTP response splitting
vulnerability. See <a href="http://en.wikipedia.org/wiki/HTTP_response_splitting">http://en.wikipedia.org/wiki/HTTP_response_splitting</a>
for more information.</p>
<p>FindBugs looks only for the most blatant, obvious cases of HTTP response splitting.
-If FindBugs found <em>any</em>, you <em>almost certainly</em> have more
-vulnerabilities that FindBugs doesn't report. If you are concerned about HTTP response splitting, you should seriously
+If FindBugs found <em>any</em>, you <em>almost certainly</em> have more
+vulnerabilities that FindBugs doesn't report. If you are concerned about HTTP response splitting, you should seriously
consider using a commercial static analysis or pen-testing tool.
</p>
@@ -4019,17 +4363,48 @@
<h3><a name="HRS_REQUEST_PARAMETER_TO_HTTP_HEADER">HRS: HTTP Response splitting vulnerability (HRS_REQUEST_PARAMETER_TO_HTTP_HEADER)</a></h3>
- <p>This code directly writes an HTTP parameter to an HTTP header, which allows for a HTTP response splitting
+ <p>This code directly writes an HTTP parameter to an HTTP header, which allows for a HTTP response splitting
vulnerability. See <a href="http://en.wikipedia.org/wiki/HTTP_response_splitting">http://en.wikipedia.org/wiki/HTTP_response_splitting</a>
for more information.</p>
<p>FindBugs looks only for the most blatant, obvious cases of HTTP response splitting.
-If FindBugs found <em>any</em>, you <em>almost certainly</em> have more
-vulnerabilities that FindBugs doesn't report. If you are concerned about HTTP response splitting, you should seriously
+If FindBugs found <em>any</em>, you <em>almost certainly</em> have more
+vulnerabilities that FindBugs doesn't report. If you are concerned about HTTP response splitting, you should seriously
consider using a commercial static analysis or pen-testing tool.
</p>
+<h3><a name="PT_ABSOLUTE_PATH_TRAVERSAL">PT: Absolute path traversal in servlet (PT_ABSOLUTE_PATH_TRAVERSAL)</a></h3>
+
+
+ <p>The software uses an HTTP request parameter to construct a pathname that should be within a restricted directory,
+but it does not properly neutralize absolute path sequences such as "/abs/path" that can resolve to a location that is outside of that directory.
+
+See <a href="http://cwe.mitre.org/data/definitions/36.html">http://cwe.mitre.org/data/definitions/36.html</a>
+for more information.</p>
+<p>FindBugs looks only for the most blatant, obvious cases of absolute path traversal.
+If FindBugs found <em>any</em>, you <em>almost certainly</em> have more
+vulnerabilities that FindBugs doesn't report. If you are concerned about absolute path traversal, you should seriously
+consider using a commercial static analysis or pen-testing tool.
+</p>
+
+
+
+<h3><a name="PT_RELATIVE_PATH_TRAVERSAL">PT: Relative path traversal in servlet (PT_RELATIVE_PATH_TRAVERSAL)</a></h3>
+
+
+ <p>The software uses an HTTP request parameter to construct a pathname that should be within a restricted directory, but it does not properly neutralize sequences such as ".." that can resolve to a location that is outside of that directory.
+
+See <a href="http://cwe.mitre.org/data/definitions/23.html">http://cwe.mitre.org/data/definitions/23.html</a>
+for more information.</p>
+<p>FindBugs looks only for the most blatant, obvious cases of relative path traversal.
+If FindBugs found <em>any</em>, you <em>almost certainly</em> have more
+vulnerabilities that FindBugs doesn't report. If you are concerned about relative path traversal, you should seriously
+consider using a commercial static analysis or pen-testing tool.
+</p>
+
+
+
<h3><a name="SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE">SQL: Nonconstant string passed to execute method on an SQL statement (SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE)</a></h3>
@@ -4052,26 +4427,26 @@
<h3><a name="XSS_REQUEST_PARAMETER_TO_JSP_WRITER">XSS: JSP reflected cross site scripting vulnerability (XSS_REQUEST_PARAMETER_TO_JSP_WRITER)</a></h3>
- <p>This code directly writes an HTTP parameter to JSP output, which allows for a cross site scripting
+ <p>This code directly writes an HTTP parameter to JSP output, which allows for a cross site scripting
vulnerability. See <a href="http://en.wikipedia.org/wiki/Cross-site_scripting">http://en.wikipedia.org/wiki/Cross-site_scripting</a>
for more information.</p>
<p>FindBugs looks only for the most blatant, obvious cases of cross site scripting.
If FindBugs found <em>any</em>, you <em>almost certainly</em> have more cross site scripting
-vulnerabilities that FindBugs doesn't report. If you are concerned about cross site scripting, you should seriously
+vulnerabilities that FindBugs doesn't report. If you are concerned about cross site scripting, you should seriously
consider using a commercial static analysis or pen-testing tool.
</p>
-<h3><a name="XSS_REQUEST_PARAMETER_TO_SEND_ERROR">XSS: Servlet reflected cross site scripting vulnerability (XSS_REQUEST_PARAMETER_TO_SEND_ERROR)</a></h3>
+<h3><a name="XSS_REQUEST_PARAMETER_TO_SEND_ERROR">XSS: Servlet reflected cross site scripting vulnerability in error page (XSS_REQUEST_PARAMETER_TO_SEND_ERROR)</a></h3>
- <p>This code directly writes an HTTP parameter to a Server error page (using HttpServletResponse.sendError). Echoing this untrusted input allows
+ <p>This code directly writes an HTTP parameter to a Server error page (using HttpServletResponse.sendError). Echoing this untrusted input allows
for a reflected cross site scripting
vulnerability. See <a href="http://en.wikipedia.org/wiki/Cross-site_scripting">http://en.wikipedia.org/wiki/Cross-site_scripting</a>
for more information.</p>
<p>FindBugs looks only for the most blatant, obvious cases of cross site scripting.
If FindBugs found <em>any</em>, you <em>almost certainly</em> have more cross site scripting
-vulnerabilities that FindBugs doesn't report. If you are concerned about cross site scripting, you should seriously
+vulnerabilities that FindBugs doesn't report. If you are concerned about cross site scripting, you should seriously
consider using a commercial static analysis or pen-testing tool.
</p>
@@ -4080,12 +4455,12 @@
<h3><a name="XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER">XSS: Servlet reflected cross site scripting vulnerability (XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER)</a></h3>
- <p>This code directly writes an HTTP parameter to Servlet output, which allows for a reflected cross site scripting
+ <p>This code directly writes an HTTP parameter to Servlet output, which allows for a reflected cross site scripting
vulnerability. See <a href="http://en.wikipedia.org/wiki/Cross-site_scripting">http://en.wikipedia.org/wiki/Cross-site_scripting</a>
for more information.</p>
<p>FindBugs looks only for the most blatant, obvious cases of cross site scripting.
If FindBugs found <em>any</em>, you <em>almost certainly</em> have more cross site scripting
-vulnerabilities that FindBugs doesn't report. If you are concerned about cross site scripting, you should seriously
+vulnerabilities that FindBugs doesn't report. If you are concerned about cross site scripting, you should seriously
consider using a commercial static analysis or pen-testing tool.
</p>
@@ -4121,7 +4496,18 @@
<p>
This cast is unchecked, and not all instances of the type casted from can be cast to
-the type it is being cast to. Ensure that your program logic ensures that this
+the type it is being cast to. Check that your program logic ensures that this
+cast will not fail.
+</p>
+
+
+<h3><a name="BC_UNCONFIRMED_CAST_OF_RETURN_VALUE">BC: Unchecked/unconfirmed cast of return value from method (BC_UNCONFIRMED_CAST_OF_RETURN_VALUE)</a></h3>
+
+
+<p>
+This code performs an unchecked cast of the return value of a method.
+The code might be calling the method in such a way that the cast is guaranteed to be
+safe, but FindBugs is unable to verify that the cast is safe. Check that your program logic ensures that this
cast will not fail.
</p>
@@ -4130,7 +4516,7 @@
<p>
-This instanceof test will always return true (unless the value being tested is null).
+This instanceof test will always return true (unless the value being tested is null).
Although this is safe, make sure it isn't
an indication of some misunderstanding or some other logic error.
If you really want to test the value for being null, perhaps it would be clearer to do
@@ -4165,7 +4551,7 @@
<p>
This method uses the same code to implement two branches of a conditional branch.
- Check to ensure that this isn't a coding mistake.
+ Check to ensure that this isn't a coding mistake.
</p>
@@ -4174,8 +4560,8 @@
<p>
This method uses the same code to implement two clauses of a switch statement.
- This could be a case of duplicate code, but it might also indicate
- a coding mistake.
+ This could be a case of duplicate code, but it might also indicate
+ a coding mistake.
</p>
@@ -4199,7 +4585,7 @@
<p>
-This statement assigns to a local variable in a return statement. This assignment
+This statement assigns to a local variable in a return statement. This assignment
has effect. Please verify that this statement does the right thing.
</p>
@@ -4213,6 +4599,18 @@
</p>
+<h3><a name="DLS_DEAD_LOCAL_STORE_SHADOWS_FIELD">DLS: Dead store to local variable that shadows field (DLS_DEAD_LOCAL_STORE_SHADOWS_FIELD)</a></h3>
+
+
+<p>
+This instruction assigns a value to a local variable,
+but the value is not read or used in any subsequent instruction.
+Often, this indicates an error, because the value computed is never
+used. There is a field with the same name as the local variable. Did you
+mean to assign to that variable instead?
+</p>
+
+
<h3><a name="DMI_HARDCODED_ABSOLUTE_FILENAME">DMI: Code contains a hard coded reference to an absolute pathname (DMI_HARDCODED_ABSOLUTE_FILENAME)</a></h3>
@@ -4241,7 +4639,7 @@
<h3><a name="DMI_THREAD_PASSED_WHERE_RUNNABLE_EXPECTED">Dm: Thread passed where Runnable expected (DMI_THREAD_PASSED_WHERE_RUNNABLE_EXPECTED)</a></h3>
- <p> A Thread object is passed as a parameter to a method where
+ <p> A Thread object is passed as a parameter to a method where
a Runnable is expected. This is rather unusual, and may indicate a logic error
or cause unexpected behavior.
</p>
@@ -4263,7 +4661,7 @@
<h3><a name="EQ_UNUSUAL">Eq: Unusual equals method (EQ_UNUSUAL)</a></h3>
- <p> This class doesn't do any of the patterns we recognize for checking that the type of the argument
+ <p> This class doesn't do any of the patterns we recognize for checking that the type of the argument
is compatible with the type of the <code>this</code> object. There might not be anything wrong with
this code, but it is worth reviewing.
</p>
@@ -4294,7 +4692,7 @@
This feature of format strings is strange, and may not be what you intended.
</p>
-
+
<h3><a name="IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD">IA: Ambiguous invocation of either an inherited or outer method (IA_AMBIGUOUS_INVOCATION_OF_INHERITED_OR_OUTER_METHOD)</a></h3>
@@ -4320,7 +4718,7 @@
<p>
This code casts the result of an integral division (e.g., int or long division)
-operation to double or
+operation to double or
float.
Doing division on integers truncates the result
to the integer value closest to zero. The fact that the result
@@ -4346,26 +4744,22 @@
<p>
This code performs integer multiply and then converts the result to a long,
-as in:
-<code>
-<pre>
- long convertDaysToMilliseconds(int days) { return 1000*3600*24*days; }
-</pre></code>
+as in:</p>
+<pre>
+ long convertDaysToMilliseconds(int days) { return 1000*3600*24*days; }
+</pre>
+<p>
If the multiplication is done using long arithmetic, you can avoid
the possibility that the result will overflow. For example, you
-could fix the above code to:
-<code>
-<pre>
- long convertDaysToMilliseconds(int days) { return 1000L*3600*24*days; }
-</pre></code>
-or
-<code>
-<pre>
- static final long MILLISECONDS_PER_DAY = 24L*3600*1000;
- long convertDaysToMilliseconds(int days) { return days * MILLISECONDS_PER_DAY; }
-</pre></code>
-</p>
-
+could fix the above code to:</p>
+<pre>
+ long convertDaysToMilliseconds(int days) { return 1000L*3600*24*days; }
+</pre>
+or
+<pre>
+ static final long MILLISECONDS_PER_DAY = 24L*3600*1000;
+ long convertDaysToMilliseconds(int days) { return days * MILLISECONDS_PER_DAY; }
+</pre>
<h3><a name="IM_AVERAGE_COMPUTATION_COULD_OVERFLOW">IM: Computation of average could overflow (IM_AVERAGE_COMPUTATION_COULD_OVERFLOW)</a></h3>
@@ -4374,7 +4768,7 @@
<p>The code computes the average of two integers using either division or signed right shift,
and then uses the result as the index of an array.
If the values being averaged are very large, this can overflow (resulting in the computation
-of a negative average). Assuming that the result is intended to be nonnegative, you
+of a negative average). Assuming that the result is intended to be nonnegative, you
can use an unsigned right shift instead. In other words, rather that using <code>(low+high)/2</code>,
use <code>(low+high) >>> 1</code>
</p>
@@ -4404,6 +4798,15 @@
</p>
+<h3><a name="INT_VACUOUS_BIT_OPERATION">INT: Vacuous bit mask operation on integer value (INT_VACUOUS_BIT_OPERATION)</a></h3>
+
+
+<p> This is an integer bit operation (and, or, or exclusive or) that doesn't do any useful work
+(e.g., <code>v & 0xffffffff</code>).
+
+</p>
+
+
<h3><a name="INT_VACUOUS_COMPARISON">INT: Vacuous comparison of integer value (INT_VACUOUS_COMPARISON)</a></h3>
@@ -4431,7 +4834,7 @@
one instance of a struts Action class is created by the Struts framework, and used in a
multithreaded way, this paradigm is highly discouraged and most likely problematic. Consider
only using method local variables. Only instance fields that are written outside of a monitor
- are reported.
+ are reported.
</p>
@@ -4470,7 +4873,7 @@
</p>
-<h3><a name="NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE">NP: Possible null pointer dereference on path that might be infeasible (NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE)</a></h3>
+<h3><a name="NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE">NP: Possible null pointer dereference on branch that might be infeasible (NP_NULL_ON_SOME_PATH_MIGHT_BE_INFEASIBLE)</a></h3>
<p> There is a branch of statement that, <em>if executed,</em> guarantees that
@@ -4478,7 +4881,8 @@
would generate a <code>NullPointerException</code> when the code is executed.
Of course, the problem might be that the branch or statement is infeasible and that
the null pointer exception can't ever be executed; deciding that is beyond the ability of FindBugs.
-Due to the fact that this value had been previously tested for nullness, this is a definite possibility.
+Due to the fact that this value had been previously tested for nullness,
+this is a definite possibility.
</p>
@@ -4491,12 +4895,22 @@
</p>
+<h3><a name="NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD">NP: Read of unwritten public or protected field (NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD)</a></h3>
+
+
+ <p> The program is dereferencing a public or protected
+field that does not seem to ever have a non-null value written to it.
+Unless the field is initialized via some mechanism not seen by the analysis,
+dereferencing this value will generate a null pointer exception.
+</p>
+
+
<h3><a name="NS_DANGEROUS_NON_SHORT_CIRCUIT">NS: Potentially dangerous use of non-short-circuit logic (NS_DANGEROUS_NON_SHORT_CIRCUIT)</a></h3>
<p> This code seems to be using non-short-circuit logic (e.g., &
or |)
-rather than short-circuit logic (&& or ||). In addition,
+rather than short-circuit logic (&& or ||). In addition,
it seem possible that, depending on the value of the left hand side, you might not
want to evaluate the right hand side (because it would have side effects, could cause an exception
or could be expensive.</p>
@@ -4594,6 +5008,16 @@
each of whose catch blocks is identical, but this construct also accidentally catches RuntimeException as well,
masking potential bugs.
</p>
+ <p>A better approach is to either explicitly catch the specific exceptions that are thrown,
+ or to explicitly catch RuntimeException exception, rethrow it, and then catch all non-Runtime Exceptions, as shown below:</p>
+ <pre>
+ try {
+ ...
+ } catch (RuntimeException e) {
+ throw e;
+ } catch (Exception e) {
+ ... deal with all non-runtime exceptions ...
+ }</pre>
<h3><a name="RI_REDUNDANT_INTERFACES">RI: Class implements same interface as superclass (RI_REDUNDANT_INTERFACES)</a></h3>
@@ -4636,7 +5060,7 @@
you may need to change your code.
If you know the divisor is a power of 2,
you can use a bitwise and operator instead (i.e., instead of
-using <code>x.hashCode()%n</code>, use <code>x.hashCode()&(n-1)</code>.
+using <code>x.hashCode()%n</code>, use <code>x.hashCode()&(n-1)</code>.
This is probably faster than computing the remainder as well.
If you don't know that the divisor is a power of 2, take the absolute
value of the result of the remainder operation (i.e., use
@@ -4655,6 +5079,37 @@
</p>
+<h3><a name="RV_RETURN_VALUE_IGNORED_INFERRED">RV: Method ignores return value, is this OK? (RV_RETURN_VALUE_IGNORED_INFERRED)</a></h3>
+
+
+<p>This code calls a method and ignores the return value. The return value
+is the same type as the type the method is invoked on, and from our analysis it looks
+like the return value might be important (e.g., like ignoring the
+return value of <code>String.toLowerCase()</code>).
+</p>
+<p>We are guessing that ignoring the return value might be a bad idea just from
+a simple analysis of the body of the method. You can use a @CheckReturnValue annotation
+to instruct FindBugs as to whether ignoring the return value of this method
+is important or acceptable.
+</p>
+<p>Please investigate this closely to decide whether it is OK to ignore the return value.
+</p>
+
+
+<h3><a name="SA_FIELD_DOUBLE_ASSIGNMENT">SA: Double assignment of field (SA_FIELD_DOUBLE_ASSIGNMENT)</a></h3>
+
+
+<p> This method contains a double assignment of a field; e.g.
+</p>
+<pre>
+ int x,y;
+ public void foo() {
+ x = x = 17;
+ }
+</pre>
+<p>Assigning to a field twice is useless, and may indicate a logic error or typo.</p>
+
+
<h3><a name="SA_LOCAL_DOUBLE_ASSIGNMENT">SA: Double assignment of local variable (SA_LOCAL_DOUBLE_ASSIGNMENT)</a></h3>
@@ -4696,6 +5151,8 @@
<p> This method contains a switch statement where default case is missing.
Usually you need to provide a default case.</p>
+ <p>Because the analysis only looks at the generated bytecode, this warning can be incorrect triggered if
+the default case is at the end of the switch statement and doesn't end with a break statement.
<h3><a name="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD">ST: Write to static field from instance method (ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)</a></h3>
@@ -4719,29 +5176,29 @@
<p> The field is marked as transient, but the class isn't Serializable, so marking it as transient
-has absolutely no effect.
+has absolutely no effect.
This may be leftover marking from a previous version of the code in which the class was transient, or
it may indicate a misunderstanding of how serialization works.
</p>
-<h3><a name="TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK">TQ: Explicit annotation inconsistent with use (TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK)</a></h3>
+<h3><a name="TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK">TQ: Value required to have type qualifier, but marked as unknown (TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_ALWAYS_SINK)</a></h3>
<p>
A value is used in a way that requires it to be always be a value denoted by a type qualifier, but
- there is an explicit annotation stating that it is not known where the value is required to have that type qualifier.
- Either the usage or the annotation is incorrect.
+ there is an explicit annotation stating that it is not known where the value is required to have that type qualifier.
+ Either the usage or the annotation is incorrect.
</p>
-<h3><a name="TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK">TQ: Explicit annotation inconsistent with use (TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK)</a></h3>
+<h3><a name="TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK">TQ: Value required to not have type qualifier, but marked as unknown (TQ_EXPLICIT_UNKNOWN_SOURCE_VALUE_REACHES_NEVER_SINK)</a></h3>
<p>
A value is used in a way that requires it to be never be a value denoted by a type qualifier, but
- there is an explicit annotation stating that it is not known where the value is prohibited from having that type qualifier.
- Either the usage or the annotation is incorrect.
+ there is an explicit annotation stating that it is not known where the value is prohibited from having that type qualifier.
+ Either the usage or the annotation is incorrect.
</p>
@@ -4755,8 +5212,8 @@
block for an <code>if</code> statement:</p>
<pre>
if (argv.length == 0) {
- // TODO: handle this case
- }
+ // TODO: handle this case
+ }
</pre>
@@ -4774,17 +5231,42 @@
</pre>
-<h3><a name="UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR">UwF: Field not initialized in constructor (UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR)</a></h3>
+<h3><a name="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD">UrF: Unread public/protected field (URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD)</a></h3>
+
+
+ <p> This field is never read.
+The field is public or protected, so perhaps
+ it is intended to be used with classes not seen as part of the analysis. If not,
+consider removing it from the class.</p>
+
+
+<h3><a name="UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD">UuF: Unused public or protected field (UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD)</a></h3>
+
+
+ <p> This field is never used.
+The field is public or protected, so perhaps
+ it is intended to be used with classes not seen as part of the analysis. If not,
+consider removing it from the class.</p>
+
+
+<h3><a name="UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR">UwF: Field not initialized in constructor but dereferenced without null check (UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR)</a></h3>
<p> This field is never initialized within any constructor, and is therefore could be null after
-the object is constructed.
+the object is constructed. Elsewhere, it is loaded and dereferenced without a null check.
This could be a either an error or a questionable design, since
it means a null pointer exception will be generated if that field is dereferenced
before being initialized.
</p>
+<h3><a name="UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD">UwF: Unwritten public or protected field (UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD)</a></h3>
+
+
+ <p> No writes were seen to this public/protected field. All reads of it will return the default
+value. Check for errors (should it have been initialized?), or remove it if it is useless.</p>
+
+
<h3><a name="XFB_XML_FACTORY_BYPASS">XFB: Method directly allocates a specific implementation of xml interfaces (XFB_XML_FACTORY_BYPASS)</a></h3>
diff --git a/tools/findbugs-1.3.9/doc/buggy-sm.png b/tools/findbugs/doc/buggy-sm.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/buggy-sm.png
rename to tools/findbugs/doc/buggy-sm.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/contributing.html b/tools/findbugs/doc/contributing.html
similarity index 97%
rename from tools/findbugs-1.3.9/doc/contributing.html
rename to tools/findbugs/doc/contributing.html
index 03b22a3..a22b3ab 100644
--- a/tools/findbugs-1.3.9/doc/contributing.html
+++ b/tools/findbugs/doc/contributing.html
@@ -16,6 +16,7 @@
<tr><td> </td></tr>
<tr><td><b>Docs and Info</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="findbugs2.html">FindBugs 2.0</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
diff --git a/tools/findbugs-1.3.9/doc/customers/ITAsoftware.png b/tools/findbugs/doc/customers/ITAsoftware.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/customers/ITAsoftware.png
rename to tools/findbugs/doc/customers/ITAsoftware.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/customers/geoLocation.png b/tools/findbugs/doc/customers/geoLocation.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/customers/geoLocation.png
rename to tools/findbugs/doc/customers/geoLocation.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/customers/geoMap.png b/tools/findbugs/doc/customers/geoMap.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/customers/geoMap.png
rename to tools/findbugs/doc/customers/geoMap.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/customers/glassfish.png b/tools/findbugs/doc/customers/glassfish.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/customers/glassfish.png
rename to tools/findbugs/doc/customers/glassfish.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/customers/google.png b/tools/findbugs/doc/customers/google.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/customers/google.png
rename to tools/findbugs/doc/customers/google.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/customers/logo_umd.png b/tools/findbugs/doc/customers/logo_umd.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/customers/logo_umd.png
rename to tools/findbugs/doc/customers/logo_umd.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/customers/nsf.png b/tools/findbugs/doc/customers/nsf.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/customers/nsf.png
rename to tools/findbugs/doc/customers/nsf.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/customers/sat4j.png b/tools/findbugs/doc/customers/sat4j.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/customers/sat4j.png
rename to tools/findbugs/doc/customers/sat4j.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/customers/sleepycat.png b/tools/findbugs/doc/customers/sleepycat.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/customers/sleepycat.png
rename to tools/findbugs/doc/customers/sleepycat.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/customers/sun.png b/tools/findbugs/doc/customers/sun.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/customers/sun.png
rename to tools/findbugs/doc/customers/sun.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/demo.html b/tools/findbugs/doc/demo.html
similarity index 98%
rename from tools/findbugs-1.3.9/doc/demo.html
rename to tools/findbugs/doc/demo.html
index 09f187b..83ce7a3 100644
--- a/tools/findbugs-1.3.9/doc/demo.html
+++ b/tools/findbugs/doc/demo.html
@@ -17,6 +17,7 @@
<tr><td> </td></tr>
<tr><td><b>Docs and Info</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="findbugs2.html">FindBugs 2.0</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
diff --git a/tools/findbugs-1.3.9/doc/downloads.html b/tools/findbugs/doc/downloads.html
similarity index 62%
rename from tools/findbugs-1.3.9/doc/downloads.html
rename to tools/findbugs/doc/downloads.html
index 4b6fa91..d1299ab 100644
--- a/tools/findbugs-1.3.9/doc/downloads.html
+++ b/tools/findbugs/doc/downloads.html
@@ -16,6 +16,7 @@
<tr><td> </td></tr>
<tr><td><b>Docs and Info</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="findbugs2.html">FindBugs 2.0</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
@@ -56,33 +57,45 @@
<h1>FindBugs downloads</h1>
<p> This page contains links to downloads
-of Findbugs version 1.3.9,
-released on 16:39:49 EDT, 21 August, 2009. Download links
+of FindBugs version 2.0.2,
+released on 21:04:38 EST, 25 February, 2013. Download links
for all FindBugs versions and files
are <a href="http://sourceforge.net/project/showfiles.php?group_id=96405">available
on the sourceforge download page</a>.
<ul>
-<li>FindBugs tool (standard version with command line, ant, and Swing interfaces)
-<ul>
-<li><a href="http://prdownloads.sourceforge.net/findbugs/findbugs-1.3.9.tar.gz?download">findbugs-1.3.9.tar.gz</a>
-<li><a href="http://prdownloads.sourceforge.net/findbugs/findbugs-1.3.9.zip?download">findbugs-1.3.9.zip</a>
-
-<li><a href="http://prdownloads.sourceforge.net/findbugs/findbugs-1.3.9-source.zip?download">findbugs-1.3.9-source.zip</a>
-</ul>
-<li>Eclipse plugin for FindBugs version 1.3.9.20090821 (requires Eclipse 3.3 or later)
-<ul>
-<li><a href="http://prdownloads.sourceforge.net/findbugs/edu.umd.cs.findbugs.plugin.eclipse_1.3.9.20090821.zip?download">edu.umd.cs.findbugs.plugin.eclipse_1.3.9.20090821.zip</a>
-
-<li><a href="http://prdownloads.sourceforge.net/findbugs/eclipsePlugin-1.3.9.20090821-source.zip?download">eclipsePlugin-1.3.9.20090821-source.zip</a>
-</ul>
+ <li>
+ FindBugs tool (standard version with command line, ant, and Swing interfaces)
+ <ul>
+ <li><a href="http://prdownloads.sourceforge.net/findbugs/findbugs-2.0.2.tar.gz?download">findbugs-2.0.2.tar.gz</a></li>
+ <li><a href="http://prdownloads.sourceforge.net/findbugs/findbugs-2.0.2.zip?download">findbugs-2.0.2.zip</a></li>
+ <li><a href="http://prdownloads.sourceforge.net/findbugs/findbugs-2.0.2-source.zip?download">findbugs-2.0.2-source.zip</a></li>
+ </ul>
+ </li>
+ <li>
+ The following versions of FindBugs are pre-configured to disable <a href="updateChecking.html">checks for updated versions</a>
+ of FindBugs, and
+ the plugin that allows communication with the FindBugs community cloud is disabled by default.
+ Such configurations are appropriate in situations where it is important that no information about the use of FindBugs
+ be disclosed outside of the organization where it is used.
+ <ul>
+ <li><a href="http://prdownloads.sourceforge.net/findbugs/findbugs-noUpdateChecks-2.0.2.tar.gz?download">findbugs-2.0.2.tar.gz</a></li>
+ <li><a href="http://prdownloads.sourceforge.net/findbugs/findbugs-noUpdateChecks-2.0.2.zip?download">findbugs-2.0.2.zip</a></li>
+ </ul>
+ </li>
+ <li>Eclipse plugin for FindBugs version 2.0.2.20130225 (requires Eclipse 3.6 or later)
+ <ul>
+ <li><a href="http://prdownloads.sourceforge.net/findbugs/edu.umd.cs.findbugs.plugin.eclipse_2.0.2.20130225.zip?download">edu.umd.cs.findbugs.plugin.eclipse_2.0.2.20130225.zip</a>
+ <li><a href="http://prdownloads.sourceforge.net/findbugs/eclipsePlugin-2.0.2.20130225-source.zip?download">eclipsePlugin-2.0.2.20130225-source.zip</a>
+ </ul>
+ </li>
</ul>
The Eclipse plugin may also be obtained from one of the FindBugs Eclipse plugin update sites:
<ul>
-<li><a href="http://findbugs.cs.umd.edu/eclipse">http://findbugs.cs.umd.edu/eclipse</a> update site for official releases</li>
-<li><a href="http://findbugs.cs.umd.edu/eclipse-candidate">http://findbugs.cs.umd.edu/eclipse-candidate</a> update site for candidate releases and official releases</li>
-<li><a href="http://findbugs.cs.umd.edu/eclipse-daily">http://findbugs.cs.umd.edu/eclipse-daily</a> update site for all releases, including developmental ones</li>
+ <li><a href="http://findbugs.cs.umd.edu/eclipse">http://findbugs.cs.umd.edu/eclipse</a> update site for <b>official</b> releases</li>
+ <li><a href="http://findbugs.cs.umd.edu/eclipse-candidate">http://findbugs.cs.umd.edu/eclipse-candidate</a> update site for <b>candidate</b> releases and official releases</li>
+ <li><a href="http://findbugs.cs.umd.edu/eclipse-daily">http://findbugs.cs.umd.edu/eclipse-daily</a> update site for <b>all</b> releases, including developmental ones</li>
</ul>
diff --git a/tools/findbugs-1.3.9/doc/eclipse-filters-icon.png b/tools/findbugs/doc/eclipse-filters-icon.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/eclipse-filters-icon.png
rename to tools/findbugs/doc/eclipse-filters-icon.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/factSheet.html b/tools/findbugs/doc/factSheet.html
similarity index 98%
rename from tools/findbugs-1.3.9/doc/factSheet.html
rename to tools/findbugs/doc/factSheet.html
index e790f75..029cd18 100644
--- a/tools/findbugs-1.3.9/doc/factSheet.html
+++ b/tools/findbugs/doc/factSheet.html
@@ -16,6 +16,7 @@
<tr><td> </td></tr>
<tr><td><b>Docs and Info</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="findbugs2.html">FindBugs 2.0</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
diff --git a/tools/findbugs-1.3.9/doc/findbugs.css b/tools/findbugs/doc/findbugs.css
similarity index 100%
rename from tools/findbugs-1.3.9/doc/findbugs.css
rename to tools/findbugs/doc/findbugs.css
diff --git a/tools/findbugs/doc/findbugs2.html b/tools/findbugs/doc/findbugs2.html
new file mode 100644
index 0000000..fc4066d
--- /dev/null
+++ b/tools/findbugs/doc/findbugs2.html
@@ -0,0 +1,283 @@
+<html>
+<head>
+<title>FindBugs 2™ - Find Bugs in Java Programs</title>
+<link rel="stylesheet" type="text/css" href="findbugs.css" />
+
+</head>
+
+<body>
+
+ <table width="100%">
+ <tr>
+
+
+<td bgcolor="#b9b9fe" valign="top" align="left" width="20%">
+<table width="100%" cellspacing="0" border="0">
+<tr><td><a class="sidebar" href="index.html"><img src="umdFindbugs.png" alt="FindBugs"></a></td></tr>
+
+<tr><td> </td></tr>
+
+<tr><td><b>Docs and Info</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="findbugs2.html">FindBugs 2.0</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="factSheet.html">Fact sheet</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="manual/index.html">Manual</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="ja/manual/index.html">Manual(ja/日本語)</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="FAQ.html">FAQ</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="bugDescriptions.html">Bug descriptions</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="mailingLists.html">Mailing lists</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="publications.html">Documents and Publications</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="links.html">Links</a></font></td></tr>
+
+<tr><td> </td></tr>
+
+<tr><td><a class="sidebar" href="downloads.html"><b>Downloads</b></a></td></tr>
+
+<tr><td> </td></tr>
+
+<tr><td><a class="sidebar" href="http://www.cafeshops.com/findbugs"><b>FindBugs Swag</b></a></td></tr>
+
+<tr><td> </td></tr>
+
+<tr><td><b>Development</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://sourceforge.net/tracker/?group_id=96405">Open bugs</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="reportingBugs.html">Reporting bugs</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="contributing.html">Contributing</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="team.html">Dev team</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="api/index.html">API</a> <a class="sidebar" href="api/overview-summary.html">[no frames]</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="Changes.html">Change log</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://sourceforge.net/projects/findbugs">SF project page</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://code.google.com/p/findbugs/source/browse/">Browse source</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://code.google.com/p/findbugs/source/list">Latest code changes</a></font></td></tr>
+</table>
+</td>
+
+ <td align="left" valign="top">
+
+ <p></p>
+ <table>
+ <tr>
+ <td valign="center"><a href="http://findbugs.sourceforge.net/"><img src="buggy-sm.png" alt="FindBugs logo"
+ border="0" /> </a></td>
+ <td valign="center"><a href="http://www.umd.edu/"><img src="informal.png"
+ alt="UMD logo" border="0" /> </a></td>
+ </tr>
+ </table>
+
+ <h1>FindBugs 2</h1>
+
+ <p>This page describes the major changes in FindBugs 2. We are well aware that the documentation on
+ the new features in FindBugs 2.0 have not kept up with the implementation. We will be working to
+ improve the documentation, but don't want to hold up the release any longer to improve the
+ documentation.</p>
+ <p>Anyone currently using FindBugs 1.3.9 should find FindBugs 2.0 to largely be a drop-in
+ replacement that offers better accuracy and performance.</p>
+
+
+ <p>
+ Also check out <a href="http://code.google.com/p/findbugs/w/list">http://code.google.com/p/findbugs/w/list</a>
+ for more information about some recent features/changes in FindBugs.
+ </p>
+
+ <p>The major new features in FindBugs 2 are as follows:</p>
+ <ul>
+ <li>Bug Rank - bugs are given a rank 1-20, and grouped into the categories scariest (rank 1-4),
+ scary (rank 5-9), troubling (rank 10-14), and of concern (rank 15-20).
+ <ul>
+ <li>priority renamed confidence - many people were confused by the priority reported by
+ FindBugs, and considered all HIGH priority issues to be important. To reflect the
+ actually meaning of this attribute of issues, it has been renamed confidence. Issues of
+ different bug patterns should be compared by there rank, not their confidence.</li>
+ </ul>
+
+ </li>
+ <li><a href="#cloud">Cloud storage</a> - having a convent way for developers to share
+ information about when an issue was first seen, and whether it is believed to be a serious
+ problem, is important to successful and cost-effective deployment of static analysis in a large
+ software project.</li>
+ <li><a href="#updateChecks">update checks</a> - FindBugs will check for releases of new
+ versions of FindBugs. Note: we leverage this capability to count the number of FindBugs users.
+ These update checks can easily be disabled.</li>
+ <li><a href="#plugins">Plugins</a> - FindBugs 2.0 makes it much easier to define plugins that
+ provide various capabilities, and install these plugins either on a per user or per installation
+ basis.</li>
+ <li><code>fb</code> command - rather than using the rather haphazard collection of command line
+ scripts developed over the years for running various FindBugs commands, you can now use just
+ one: <code>fb</code>.
+ <ul>
+ <li><code>fb analyze</code> - invokes the FindBugs analysis</li>
+ <li><code>fb gui</code> - launches the FindBugs GUI
+ <li><code>fb list</code> - lists the issues from a FindBugs analysis file</li>
+ <li><code>fb help</code> - lists the command available.</li>
+ </ul>
+ <p>
+ Plugins can be used to extend the commands that can be invoked via
+ <code>fb</code>.
+ </p>
+ </li>
+ <li><a href="#newBugPatterns">New bug patterns and detectors</a>,
+ and improved accuracy
+ </li>
+ <li><a href="#performance">Improved performance</a>: overall, we've seen an average 10%
+ performance improvement over a large range of benchmarks, although a few users have experienced
+ performance regressions we are still trying to understand.</li>
+ <li id="guava">Guava support - working with Kevin Bourrillion, we have provided additional support for the
+ <a href="http://code.google.com/p/guava-libraries/">Guava library</a>, recognizing many common
+ misuse patterns.
+ </li>
+ <li id="jsr305">JSR-305 support - improved detection of problems identified by JSR-305 annotations. In
+ particular, we've significantly improved both the accuracy and performance of the analysis of
+ type qualifiers.</li>
+ </ul>
+
+ <h2 id="cloud">Cloud storage of issue evaluations</h2>
+ <p>For many years, you could store evaluations of FindBugs issues within the XML containing the
+ analysis results. However, this approach did not work well for a team of distributed developers.
+ Instead, we now provide a cloud based mechanism for storing this information. We are providing a
+ free communal cloud (hostied by Google appengine) for storing evaluations of FindBugs issues. You
+ can set up your own private cloud for storing issues, but at the moment this checking out a copy of
+ FindBugs, making some modifications and building the cloud storage plugin from source. We hope to
+ make it easier to have your own private cloud in FindBugs 2.0.1.</p>
+ <p>We have analyzed several large open source projects, and provide Java web start links to allow
+ you to view the results. We'd be happy to work with projects to make the results available from a
+ continuous build:</p>
+ <ul>
+ <li><a href="http://findbugs.cs.umd.edu/cloud/jdk.jnlp">Sun's JDK 8</a></li>
+ <li><a href="http://findbugs.cs.umd.edu/cloud/eclipse.jnlp">Eclipse 3.8</a></li>
+ <li><a href="http://findbugs.cs.umd.edu/cloud/tomcat.jnlp">Apache Tomcat 7.0</a></li>
+ <li><a href="http://findbugs.cs.umd.edu/cloud/intellij.jnlp">IntelliJ IDEA</a></li>
+ <li><a href="http://findbugs.cs.umd.edu/cloud/jboss.jnlp">JBoss</a></li>
+ </ul>
+
+ <h2 id="updateChecks">FindBugs update checks</h2>
+ <p>
+ FindBugs now checks to see if a new version of FindBugs or a plugin has been released. We make use
+ of this check to collect statistics on the operating system, java version, locale and FindBugs entry
+ point (e.g., ant, command line, GUI). <a href="updateChecking.html">More information is
+ available</a>, including information about how to disable update checks if your organization has a
+ policy against allowing the collection of such information. No information about the code being
+ analyzed is reported.
+
+ </p>
+
+ <h2 id="plugins">Plugins</h2>
+ <p>FindBugs 2.0 makes it much easier to customize FindBugs with plugins.</p>
+ <p>FindBugs looks for plugins in two places: your personal home directory, and in FindBugs home
+ (plugins installed in your home directory take precedence). In both places, it looks in two places:
+ the plugin directory, which contains plugins that are enabled by default, and the optionalPlugin
+ directory, which contains plugins that are disabled by default but can be enabled for a particular
+ project.</p>
+ <p>The FindBugs project includes several plugins:</p>
+ <ul>
+ <li><i>Cloud plugins</i>: These plugins provide ways to persist and share information about
+ issues seen in an analysis (e.g., when was this issue first seen, and any evaluations as to
+ whether this is harmless or a must fix issue, as well as comments about the issue from
+ developers)
+ <ul>
+ <li><code>bugCollectionCloud</code> - stores issue evaluations in the XML. The way
+ issue evaluations were always stored before FindBugs 2.0. Distributed in the
+ optionalPlugin directory.</li>
+ <li><code>findbugsCommunalCloud</code> Stores issue evaluations in the communal cloud
+ hosted at findbugs.appspot.com. Distributed in the plugin directory.</li>
+ <li><code>jdbcCloudClient</code> an older, deprecated cloud that stored information in
+ an SQL database. Not distributed, most be built from source.</li>
+ </ul></li>
+ <li><code>noUpdateChecks</code> - Disables checks for updated versions and usage counting.
+ Distributed in the optionalPlugin directory.</li>
+ <li><code>poweruser</code> - provides a number of additional commands for the <code>fb</code>
+ command. It is believed most of these commands are used by few people outside of the FindBugs
+ development team. Distributed in the optionalPlugin directory.</li>
+ <li><i>Bug filing plugins</i>: these plugins assist in the filing of FindBugs issues in built
+ trackers. The bug filing framework is designed to be extensible to other bug filing systems. At
+ the moment, these plugins are not supported, and must be built from source.
+ <ul>
+ <li><code>jira</code></li>
+ <li><code>google code</code></li>
+ </ul></li>
+ </ul>
+ <h2 id="performance">Performance Improvements/regressions</h2>
+ <p>
+ In our own testing, <a href="performance.html">we've seen an overall improvement of 9% in
+ FindBugs performance from 1.3.9 to 2.0.0, with the majority of benchmarks seeing improvements</a>. A
+ few users have reported significant performance regressions and we are <a href="performance.html">asking
+ for more information from anyone seeing significant performance regressions</a>.
+
+ </p>
+ <h2 id="newBugPatterns">New Bug patterns</h2>
+ <ul>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION">AT_OPERATION_SEQUENCE_ON_CONCURRENT_ABSTRACTION</a>
+ </li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#BX_UNBOXING_IMMEDIATELY_REBOXED">BX_UNBOXING_IMMEDIATELY_REBOXED</a>
+ </li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#CO_COMPARETO_RESULTS_MIN_VALUE">CO_COMPARETO_RESULTS_MIN_VALUE</a>
+ </li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#DLS_DEAD_LOCAL_STORE_SHADOWS_FIELD">DLS_DEAD_LOCAL_STORE_SHADOWS_FIELD</a>
+ </li>
+ <li><a href="http://findbugs.sourceforge.net/bugDescriptions.html#DMI_ARGUMENTS_WRONG_ORDER">DMI_ARGUMENTS_WRONG_ORDER</a>
+ </li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#DMI_BIGDECIMAL_CONSTRUCTED_FROM_DOUBLE">DMI_BIGDECIMAL_CONSTRUCTED_FROM_DOUBLE</a>
+ </li>
+ <li><a href="http://findbugs.sourceforge.net/bugDescriptions.html#DMI_DOH">DMI_DOH</a></li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS">DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS</a>
+ </li>
+ <li><a href="http://findbugs.sourceforge.net/bugDescriptions.html#DM_DEFAULT_ENCODING">DM_DEFAULT_ENCODING</a>
+ </li>
+ <li><a href="http://findbugs.sourceforge.net/bugDescriptions.html#ICAST_INT_2_LONG_AS_INSTANT">ICAST_INT_2_LONG_AS_INSTANT</a>
+ </li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#INT_BAD_COMPARISON_WITH_INT_VALUE">INT_BAD_COMPARISON_WITH_INT_VALUE</a>
+ </li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#JML_JSR166_CALLING_WAIT_RATHER_THAN_AWAIT">JML_JSR166_CALLING_WAIT_RATHER_THAN_AWAIT</a>
+ </li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD">NP_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD</a>
+ </li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE">OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE</a>
+ </li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#PZ_DONT_REUSE_ENTRY_OBJECTS_IN_ITERATORS">PZ_DONT_REUSE_ENTRY_OBJECTS_IN_ITERATORS</a>
+ </li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#RV_CHECK_COMPARETO_FOR_SPECIFIC_RETURN_VALUE">RV_CHECK_COMPARETO_FOR_SPECIFIC_RETURN_VALUE</a>
+ </li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#RV_NEGATING_RESULT_OF_COMPARETO">RV_NEGATING_RESULT_OF_COMPARETO</a>
+ </li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#RV_RETURN_VALUE_IGNORED_INFERRED">RV_RETURN_VALUE_IGNORED_INFERRED</a>
+ </li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#SA_LOCAL_SELF_ASSIGNMENT_INSTEAD_OF_FIELD">SA_LOCAL_SELF_ASSIGNMENT_INSTEAD_OF_FIELD</a>
+ </li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD">URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD</a>
+ </li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD">UUF_UNUSED_PUBLIC_OR_PROTECTED_FIELD</a>
+ </li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD">UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD</a>
+ </li>
+ <li><a
+ href="http://findbugs.sourceforge.net/bugDescriptions.html#VA_FORMAT_STRING_USES_NEWLINE">VA_FORMAT_STRING_USES_NEWLINE</a>
+ </li>
+ <li><a href="http://findbugs.sourceforge.net/bugDescriptions.html#VO_VOLATILE_INCREMENT">VO_VOLATILE_INCREMENT</a>
+ </li>
+ </ul>
+
+ </td>
+ </tr>
+ </table>
+
+</body>
+</html>
diff --git a/tools/findbugs-1.3.9/doc/guaranteedDereference.png b/tools/findbugs/doc/guaranteedDereference.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/guaranteedDereference.png
rename to tools/findbugs/doc/guaranteedDereference.png
Binary files differ
diff --git a/tools/findbugs/doc/index.html b/tools/findbugs/doc/index.html
new file mode 100644
index 0000000..de1e760
--- /dev/null
+++ b/tools/findbugs/doc/index.html
@@ -0,0 +1,320 @@
+<html>
+<head>
+<title>FindBugs™ - Find Bugs in Java Programs</title>
+<link rel="stylesheet" type="text/css" href="findbugs.css" />
+
+</head>
+
+<body>
+
+ <table width="100%">
+ <tr>
+
+
+<td bgcolor="#b9b9fe" valign="top" align="left" width="20%">
+<table width="100%" cellspacing="0" border="0">
+<tr><td><a class="sidebar" href="index.html"><img src="umdFindbugs.png" alt="FindBugs"></a></td></tr>
+
+<tr><td> </td></tr>
+
+<tr><td><b>Docs and Info</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="findbugs2.html">FindBugs 2.0</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="factSheet.html">Fact sheet</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="manual/index.html">Manual</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="ja/manual/index.html">Manual(ja/日本語)</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="FAQ.html">FAQ</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="bugDescriptions.html">Bug descriptions</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="mailingLists.html">Mailing lists</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="publications.html">Documents and Publications</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="links.html">Links</a></font></td></tr>
+
+<tr><td> </td></tr>
+
+<tr><td><a class="sidebar" href="downloads.html"><b>Downloads</b></a></td></tr>
+
+<tr><td> </td></tr>
+
+<tr><td><a class="sidebar" href="http://www.cafeshops.com/findbugs"><b>FindBugs Swag</b></a></td></tr>
+
+<tr><td> </td></tr>
+
+<tr><td><b>Development</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://sourceforge.net/tracker/?group_id=96405">Open bugs</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="reportingBugs.html">Reporting bugs</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="contributing.html">Contributing</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="team.html">Dev team</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="api/index.html">API</a> <a class="sidebar" href="api/overview-summary.html">[no frames]</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="Changes.html">Change log</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://sourceforge.net/projects/findbugs">SF project page</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://code.google.com/p/findbugs/source/browse/">Browse source</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://code.google.com/p/findbugs/source/list">Latest code changes</a></font></td></tr>
+</table>
+</td>
+
+ <td align="left" valign="top">
+
+ <p></p>
+ <table>
+ <tr>
+ <td valign="center"><a href="http://findbugs.sourceforge.net/"><img src="buggy-sm.png" alt="FindBugs logo"
+ border="0" /> </a></td>
+ <td valign="center"><a href="http://www.umd.edu/"><img src="informal.png"
+ alt="UMD logo" border="0" /> </a></td>
+ </tr>
+ </table>
+
+ <h1>FindBugs™ - Find Bugs in Java Programs</h1>
+
+ <p>
+ This is the web page for FindBugs, a program which uses static analysis to look for bugs in Java
+ code. It is free software, distributed under the terms of the <a
+ href="http://www.gnu.org/licenses/lgpl.html">Lesser GNU Public License</a>. The name
+ FindBugs™ and the <a href="buggy-sm.png">FindBugs logo</a> are trademarked by <a
+ href="http://www.umd.edu">The University of Maryland</a>. FindBugs has been downloaded more than
+ a million times.
+ </p>
+
+ <p>The current version of FindBugs is 2.0.2.</p>
+
+ <p>
+ FindBugs requires JRE (or JDK) 1.5.0 or later to run. However, it can analyze programs
+ compiled for any version of Java, from 1.0 to 1.8. The current version of FindBugs is 2.0.2,
+ released on 21:04:38 EST, 25 February, 2013. <a href="reportingBugs.html">We are very interested in getting
+ feedback on how to improve FindBugs</a>. File bug reports on <a
+ href="http://sourceforge.net/tracker/?func=browse&group_id=96405&atid=614693"> our
+ sourceforge bug tracker</a>
+ </p>
+
+ <p>
+ <a href="#changes">Changes</a> | <a href="#talks">Talks</a> | <a href="#papers">Papers </a> | <a
+ href="#sponsors">Sponsors</a> | <a href="#support">Support</a>
+ </p>
+ <h1>FindBugs 2.0 Release</h1>
+ <p>After many delays, we have released FindBugs 2.0. We are pretty happy and confident about the
+ functionality, although we know the documentation of the changes in 2.0 is lacking. We decided that
+ releasing 2.0 took precedence over fixing the documentation. Anyone currently using FindBugs 1.3.9
+ should find FindBugs 2.0 to largely be a drop-in replacement that offers better accuracy and
+ performance.</p>
+
+ <p>
+ Also check out <a href="http://code.google.com/p/findbugs/w/list">http://code.google.com/p/findbugs/w/list</a>
+ for more information about some recent features/changes in FindBugs.
+ </p>
+
+
+ <h3>
+ <a href="findbugs2.html">Major changes in FindBugs 2.0</a>
+ </h3>
+ <ul>
+ <li><a href="findbugs2.html#cloud">FindBugs Communal cloud</a></li>
+ <li><a href="findbugs2.html#updateChecks">checks for updated versions of FindBugs</a></li>
+ <li><a href="findbugs2.html#plugins">Powerful plugin capabilities</a></li>
+ <li><a href="findbugs2.html#newBugPatterns">new bug patterns</a>,
+ including new/improved support for <a href="findbugs2.html#guava">Guava</a>
+ and <a href="findbugs2.html#jsr305">JSR-305</a>
+ </li>
+ <li><a href="findbugs2.html#performance">improved performance</a></li>
+ </ul>
+
+
+ <h2>Ways to run FindBugs</h2>
+ <p>Here are various ways to run FindBugs. For plugins not supported by the FindBugs team, check to
+ see what version of FindBugs they provide; it might take a little while for the plugins to update to
+ FindBugs 2.0.</p>
+ <dl>
+ <dt>Command line, ant, GUI</dt>
+ <dd>Provided in FindBugs download</dd>
+ <dt>
+ <a href="http://www.eclipse.org/">Eclipse</a>
+ </dt>
+ <dd>
+ Update site for Eclipse plugin: <a href="http://findbugs.cs.umd.edu/eclipse">http://findbugs.cs.umd.edu/eclipse</a>.
+ Supported by the FindBugs project.
+ </dd>
+ <dt>
+ <a href="http://maven.apache.org/">Maven</a>
+ </dt>
+ <dd>
+ <a href="http://mojo.codehaus.org/findbugs-maven-plugin/">http://mojo.codehaus.org/findbugs-maven-plugin/</a>
+ </dd>
+ <dt>
+ <a href="http://netbeans.org/">Netbeans</a>
+ </dt>
+ <dd>
+ <a href="http://kenai.com/projects/sqe/pages/Home">SQE: Software Quality Environment</a>
+ </dd>
+ <dt>
+ <a href="http://wiki.hudson-ci.org/display/HUDSON/Home">Hudson</a>
+ </dt>
+ <dd>
+ <a href="http://wiki.hudson-ci.org/display/HUDSON/FindBugs+Plugin">http://wiki.hudson-ci.org/display/HUDSON/FindBugs+Plugin</a>
+ </dd>
+ <dt>
+ <a href="http://www.jetbrains.com/idea/">IntelliJ</a>
+ </dt>
+ <dd>
+ Several plugins, see <a href="http://code.google.com/p/findbugs/wiki/IntellijFindBugsPlugins">http://code.google.com/p/findbugs/wiki/IntellijFindBugsPlugins</a>
+ for a descrption.
+
+ </dd>
+ </dl>
+
+
+ <h1>New</h1>
+ <ul>
+ <li>We've released FindBugs 2.0.2.
+ Mostly small changes to address false positives, with one important fix to the Eclipse plugin
+ to fix a problem that had prevented the plugin from running in some versions of Eclipse.
+ Check the <a href="Changes.html">change log</a> for more details.
+
+ <li>We've released <a href="findbugs2.html">FindBugs 2.0</a>
+ </li>
+ <li>FindBugs communal cloud and Java web start links:. We have analyzed several large open
+ source projects, and provide Java web start links to allow you to view the results. We'd be
+ happy to work with projects to make the results available from a continuous build:
+ <p></p>
+ <ul>
+ <li><a href="http://findbugs.cs.umd.edu/cloud/jdk.jnlp">Sun's JDK 8</a></li>
+ <li><a href="http://findbugs.cs.umd.edu/cloud/eclipse.jnlp">Eclipse 3.8</a></li>
+ <li><a href="http://findbugs.cs.umd.edu/cloud/tomcat.jnlp">Apache Tomcat 7.0</a></li>
+ <li><a href="http://findbugs.cs.umd.edu/cloud/intellij.jnlp">IntelliJ IDEA</a></li>
+ <li><a href="http://findbugs.cs.umd.edu/cloud/jboss.jnlp">JBoss</a></li>
+ </ul>
+ </li>
+ </ul>
+
+
+
+ <h1>Experience with FindBugs</h1>
+ <ul>
+ <li><b>Google FindBugs Fixit</b>: Google has a tradition of <a
+ href="http://www.nytimes.com/2007/10/21/jobs/21pre.html">engineering fixits</a>, special days where
+ they try to get all of their engineers focused on some specific problem or technique for improving
+ the systems at Google. A fixit might work to improve web accessibility, internal testing, removing
+ TODO's from internal software, etc.
+
+ <p>On May 13-14, Google held a global fixit for UMD's FindBugs tool a static analysis tool for
+ finding coding mistakes in Java software. The focus of the fixit was to get feedback on the
+ 4,000 highest confidence issues found by FindBugs at Google, and let Google engineers decide
+ which issues, if any, needed fixing.</p>
+ <p>More than 700 engineers ran FindBugs from dozens of offices. More than 250 of them entered
+ more than 8,000 reviews of the issues. A review is a classification of an issue as must-fix,
+ should-fix, mostly-harmless, not-a-bug, and several other categories. More than 75% of the
+ reviews classified issues as must fix, should fix or I will fix. Many of the scariest issues
+ received more than 10 reviews each.</p>
+ <p>Engineers have already submitted changes that made more than 1,100 of the 3,800 issues go
+ away. Engineers filed more than 1,700 bug reports, of which 600 have already been marked as
+ fixed Work continues on addressing the issues raised by the fixit, and on supporting the
+ integration of FindBugs into the software development process at Google.</p>
+ <p>The fixit at Google showcased new capabilities of FindBugs that provide a cloud computing /
+ social networking backdrop. Reviews of issues are immediately persisted into a central store,
+ where they can be seen by other developers, and FindBugs is integrated into the internal Google
+ tools for filing and viewing bug reports and for viewing the version control history of source
+ files. For the Fixit, FindBugs was configured in a mode where engineers could not see reviews
+ from other engineers until they had entered their own; after the fixit, the configuration will
+ be changed to a more open configuration where engineers can see reviews from others without
+ having to provide their own review first. These capabilities have all been contributed to UMD's
+ open source FindBugs tool, although a fair bit of engineering remains to prepare the
+ capabilities for general release and make sure they can integrate into systems outside of
+ Google. The new capabilities are expected to be ready for general release in Fall 2009.</p>
+ </li>
+ </ul>
+
+ <h2>
+ <a name="talks">Talks about FindBugs</a>
+ </h2>
+ <ul>
+ <p>
+ <a href="http://www.cs.umd.edu/~pugh/MistakesThatMatter.pdf">Mistakes That Matter</a>, JavaOne,
+ 2009
+ </p>
+ <li><a href="http://youtu.be/1AJjwsuESno?hd=1">Youtube video</a> showing of demo
+ of our 2.0 Eclipse plugin (16 minutes)</li>
+ <li><a href="http://findbugs.cs.umd.edu/talks/findbugs.mov">Quicktime movie</a> showing of demo
+ of our new GUI to view some of the null pointer bugs in Eclipse (Big file warning: 23 Megabytes)</li>
+ <li><a href="http://findbugs.cs.umd.edu/talks/JavaOne2007-TS2007.pdf">JavaOne 2007 talk on
+ Improving Software Quality Using Static Analysis</a></li>
+ <li><a href="http://findbugs.cs.umd.edu/talks/fb-sdbp-2006.pdf">Talk</a> Bill Pugh gave at <a
+ href="http://www.sdexpo.com/2006/sdbp/">SD Best Practices</a>, Sept 14th (more of a handle on
+ tutorial about using FindBugs)</li>
+ <li><a href="http://findbugs.cs.umd.edu/talks/fb-Sept1213-2006.pdf">Talk</a> Bill Pugh gave at
+ <a href="http://itasoftware.com/">ITA Software</a> and <a href="http://www.csail.mit.edu/">MIT</a>,
+ Sept 12th and 13th (more of a research focus)</li>
+ <li><a href="http://video.google.com/videoplay?docid=-8150751070230264609">Video of talk</a>
+ Bill Pugh gave at <a href="http://www.google.com">Google</a>, July 6th, 2006</li>
+ <li><a href="http://javaposse.com/index.php?post_id=95780">Java Posse podcast interview
+ with Bill Pugh and Brian Goetz</a></li>
+ </ul>
+ <h2>
+ <a name="papers">Papers about FindBugs</a>
+ </h2>
+ <ul>
+ <li><a href="http://findbugs.cs.umd.edu/papers/MoreNullPointerBugs07.pdf">Finding More Null
+ Pointer Bugs, But Not Too Many</a>, by <a href="http://faculty.ycp.edu/~dhovemey/">David
+ Hovemeyer</a>, York College of Pennsylvania and <a href="http://www.cs.umd.edu/~pugh/">William
+ Pugh</a>, Univ. of Maryland, <a href="http://paste07.cs.washington.edu/">7th ACM
+ SIGPLAN-SIGSOFT Workshop on Program Analysis for Software Tools and Engineering</a>, June, 2007</li>
+ <li><a href="http://findbugs.cs.umd.edu/papers/FindBugsExperiences07.pdf">Evaluating Static
+ Analysis Defect Warnings On Production Software,</a> <a href="http://www.cs.umd.edu/~nat/">Nathaniel
+ Ayewah</a> and <a href="http://www.cs.umd.edu/~pugh/">William Pugh</a>, Univ. of Maryland, and
+ J. David Morgenthaler, John Penix and YuQian Zhou, Google, Inc., <a
+ href="http://paste07.cs.washington.edu/">7th ACM SIGPLAN-SIGSOFT Workshop on Program
+ Analysis for Software Tools and Engineering</a>, June, 2007
+ </li>
+ </ul>
+
+ <h1>
+ <a name="sponsors">Contributors and Sponsors</a>
+ </h1>
+ <p>
+ The <a href="team.html">current development team</a> consists of <a
+ href="http://www.cs.umd.edu/~pugh">Bill Pugh</a> and <a
+ href="http://andrei.gmxhome.de/privat.html">Andrey Loskutov</a>.
+ </p>
+ <p>Current funding for FindBugs comes from a Google Faculty Research Awards. We'd be interested in
+ any offers of support or sponsorship.</p>
+ <h2>
+ <a name="support">Additional Support</a>
+ </h2>
+ <p>
+ Numerous <a =href="team.html">people</a> have made significant contributions to the FindBugs
+ project, including founding work by <a href="http://goose.ycp.edu/~dhovemey/">David Hovemeyer</a>
+ and the web cloud infrastructure by Keith Lea.
+ </p>
+ <p>
+ YourKit is kindly supporting open source projects with its full-featured Java Profiler. YourKit, LLC
+ is creator of innovative and intelligent tools for profiling Java and .NET applications. Take a look
+ at YourKit's leading software products: <a href="http://www.yourkit.com/java/profiler/index.jsp">YourKit
+ Java Profiler</a> and <a href="http://www.yourkit.com/.net/profiler/index.jsp">YourKit .NET
+ Profiler</a>.
+ </p>
+ <p>
+ The FindBugs project also uses <a href="http://www.atlassian.com/software/fisheye/">FishEye</a> and
+ <a href="http://www.atlassian.com/software/clover/">Clover</a>, which are generously provided by <a
+ href="http://www.cenqua.com/">Cenqua/Atlassian</a>.
+ </p>
+ <p>
+ Additional financial support for the FindBugs project was provided by <a href="http://www.nsf.gov">National
+ Science Foundation</a> grants ASC9720199 and CCR-0098162,
+ </p>
+ <p>Any opinions, findings and conclusions or recommendations expressed in this material are those of
+ the author(s) and do not necessarily reflect the views of the National Science Foundation (NSF).
+
+<hr> <p>
+<script language="JavaScript" type="text/javascript">
+<!---//hide script from old browsers
+document.write( "Last updated "+ document.lastModified + "." );
+//end hiding contents --->
+</script>
+<p> Send comments to <a class="sidebar" href="mailto:findbugs@cs.umd.edu">findbugs@cs.umd.edu</a>
+<p>
+<A href="http://sourceforge.net"><IMG src="http://sourceforge.net/sflogo.php?group_id=96405&type=5" width="210" height="62" border="0" alt="SourceForge.net Logo" /></A></p>
+ </td>
+ </tr>
+ </table>
+
+</body>
+</html>
diff --git a/tools/findbugs-1.3.9/doc/infiniteRecursiveLoops.png b/tools/findbugs/doc/infiniteRecursiveLoops.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/infiniteRecursiveLoops.png
rename to tools/findbugs/doc/infiniteRecursiveLoops.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/informal.png b/tools/findbugs/doc/informal.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/informal.png
rename to tools/findbugs/doc/informal.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/example-code.png b/tools/findbugs/doc/ja/manual/example-code.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/ja/manual/example-code.png
rename to tools/findbugs/doc/ja/manual/example-code.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/example-details.png b/tools/findbugs/doc/ja/manual/example-details.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/ja/manual/example-details.png
rename to tools/findbugs/doc/ja/manual/example-details.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/example.png b/tools/findbugs/doc/ja/manual/example.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/ja/manual/example.png
rename to tools/findbugs/doc/ja/manual/example.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/important.png b/tools/findbugs/doc/ja/manual/important.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/ja/manual/important.png
rename to tools/findbugs/doc/ja/manual/important.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/infiniteRecursiveLoops.png b/tools/findbugs/doc/ja/manual/infiniteRecursiveLoops.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/ja/manual/infiniteRecursiveLoops.png
rename to tools/findbugs/doc/ja/manual/infiniteRecursiveLoops.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/note.png b/tools/findbugs/doc/ja/manual/note.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/ja/manual/note.png
rename to tools/findbugs/doc/ja/manual/note.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/project-dialog.png b/tools/findbugs/doc/ja/manual/project-dialog.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/ja/manual/project-dialog.png
rename to tools/findbugs/doc/ja/manual/project-dialog.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/ja/manual/warning.png b/tools/findbugs/doc/ja/manual/warning.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/ja/manual/warning.png
rename to tools/findbugs/doc/ja/manual/warning.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/links.html b/tools/findbugs/doc/links.html
similarity index 90%
rename from tools/findbugs-1.3.9/doc/links.html
rename to tools/findbugs/doc/links.html
index 2e806a8..87884b8 100644
--- a/tools/findbugs-1.3.9/doc/links.html
+++ b/tools/findbugs/doc/links.html
@@ -16,6 +16,7 @@
<tr><td> </td></tr>
<tr><td><b>Docs and Info</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="findbugs2.html">FindBugs 2.0</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
@@ -66,10 +67,10 @@
generated by any third-party plugin.
<li> <a href="http://www.tobject.de/development/findbugs.html">FindBugs Eclipse plugin</a>.
This is now included as part of FindBugs.
-<li> <a href="http://maven-plugins.sourceforge.net/maven-findbugs-plugin/index.html">Maven FindBugs plugin</a>.
- Maven is a Java project management and project comprehension tool.
- The Maven FindBugs plugin allows FindBugs reports to be generated
- from within Maven.
+<!--<li> <a href="http://maven-plugins.sourceforge.net/maven-findbugs-plugin/index.html">Maven FindBugs plugin</a>. -->
+ <!--Maven is a Java project management and project comprehension tool. -->
+ <!--The Maven FindBugs plugin allows FindBugs reports to be generated-->
+ <!--from within Maven.-->
<li> <a href="http://mojo.codehaus.org/findbugs-maven-plugin/">Maven2 FindBugs plugin</a>.
Maven2 is the latest version of the Java project management and project comprehension tool.
The Maven2 FindBugs plugin allows FindBugs reports to be generated
@@ -97,15 +98,13 @@
<h3>Commercial tools and services</h3>
<ul>
-<li><a href=" http://www.surelogic.com/findbugs"> SureLogic Sierra</a>, an advanced interface and collaborative auditing and report
- system for static analysis tools, including FindBugs.
<li> <a href="http://www.jutils.com">lint4j</a>: lint tool for Java programs
<li> <a href="http://www.parasoft.com/">JTest</a>: automatically generates
<a href="http://junit.org/">JUnit</a> tests for Java classes.
Also checks for many kinds of coding errors.
<li> <a href="http://www.sureshotsoftware.com/javalint/">JiveLint</a>. Another
lint utility for Java programs. Finds hashcode/equals problems,
- string reference comparisions, and more. Free 15 day demo.
+ string reference comparisons, and more. Free 15 day demo.
</ul>
diff --git a/tools/findbugs-1.3.9/doc/mailingLists.html b/tools/findbugs/doc/mailingLists.html
similarity index 97%
rename from tools/findbugs-1.3.9/doc/mailingLists.html
rename to tools/findbugs/doc/mailingLists.html
index 08cba2f..4c619c9 100644
--- a/tools/findbugs-1.3.9/doc/mailingLists.html
+++ b/tools/findbugs/doc/mailingLists.html
@@ -16,6 +16,7 @@
<tr><td> </td></tr>
<tr><td><b>Docs and Info</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="findbugs2.html">FindBugs 2.0</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
diff --git a/tools/findbugs-1.3.9/doc/manual-fo.xsl b/tools/findbugs/doc/manual-fo.xsl
similarity index 90%
rename from tools/findbugs-1.3.9/doc/manual-fo.xsl
rename to tools/findbugs/doc/manual-fo.xsl
index 78a36d4..48df542 100644
--- a/tools/findbugs-1.3.9/doc/manual-fo.xsl
+++ b/tools/findbugs/doc/manual-fo.xsl
@@ -5,7 +5,7 @@
exclude-result-prefixes="#default">
<!-- build.xml will substitute the real path to fo/docbook.xsl here. -->
-<xsl:import href="/fs/pugh/pugh/docbook-xsl-1.71.1/fo/docbook.xsl"/>
+<xsl:import href="/Users/msamuel/work/findbugs-read-only/software-home/docbook-xsl-1.76.1/fo/docbook.xsl"/>
<!-- Enumerate sections. -->
<xsl:variable name="section.autolabel">1</xsl:variable>
diff --git a/tools/findbugs-1.3.9/doc/manual.xml b/tools/findbugs/doc/manual.xml
similarity index 73%
rename from tools/findbugs-1.3.9/doc/manual.xml
rename to tools/findbugs/doc/manual.xml
index 6aa6efd..7023ec6 100644
--- a/tools/findbugs-1.3.9/doc/manual.xml
+++ b/tools/findbugs/doc/manual.xml
@@ -8,9 +8,9 @@
<!ENTITY FBHomeWin "<replaceable>%FINDBUGS_HOME%</replaceable>">
<!ENTITY nbsp " ">
]>
-
+
<book lang="en" id="findbugs-manual">
-
+
<bookinfo>
<title>&FindBugs;™ Manual</title>
@@ -20,19 +20,15 @@
<othername>H.</othername>
<surname>Hovemeyer</surname>
</author>
- <author>
- <firstname>William</firstname>
- <othername>W.</othername>
- <surname>Pugh</surname>
- </author>
+ <author>
+ <firstname>William</firstname>
+ <othername>W.</othername>
+ <surname>Pugh</surname>
+ </author>
</authorgroup>
<copyright>
- <year>2003</year>
- <year>2004</year>
- <year>2005</year>
- <year>2006</year>
- <year>2008</year>
+ <year>2003 - 2012</year>
<holder>University of Maryland</holder>
</copyright>
@@ -48,9 +44,9 @@
</para>
</legalnotice>
-<edition>1.3.9</edition>
+<edition>2.0.2</edition>
-<pubdate>16:39:49 EDT, 21 August, 2009</pubdate>
+<pubdate>21:04:38 EST, 25 February, 2013</pubdate>
</bookinfo>
@@ -59,14 +55,14 @@
Introduction
**************************************************************************
-->
-
+
<chapter id="introduction">
<title>Introduction</title>
<para> &FindBugs;™ is a program to find bugs in Java programs. It looks for instances
of "bug patterns" --- code instances that are likely to be errors.</para>
-<para> This document describes version 1.3.9 of &FindBugs;.We
+<para> This document describes version 2.0.2 of &FindBugs;.We
are very interested in getting your feedback on &FindBugs;. Please visit
the <ulink url="http://findbugs.sourceforge.net">&FindBugs; web page</ulink> for
the latest information on &FindBugs;, contact information, and support resources such
@@ -82,7 +78,7 @@
<para>You should have at least 512 MB of memory to use &FindBugs;.
To analyze very large projects, more memory may be needed.</para>
</sect1>
-
+
</chapter>
<!--
@@ -104,31 +100,31 @@
<para>
The easiest way to install &FindBugs; is to download a binary distribution.
Binary distributions are available in
-<ulink url="http://prdownloads.sourceforge.net/findbugs/findbugs-1.3.9.tar.gz?download">gzipped tar format</ulink> and
-<ulink url="http://prdownloads.sourceforge.net/findbugs/findbugs-1.3.9.zip?download">zip format</ulink>.
+<ulink url="http://prdownloads.sourceforge.net/findbugs/findbugs-2.0.2.tar.gz?download">gzipped tar format</ulink> and
+<ulink url="http://prdownloads.sourceforge.net/findbugs/findbugs-2.0.2.zip?download">zip format</ulink>.
Once you have downloaded a binary distribution, extract it into a directory of your choice.
</para>
<para>
Extracting a gzipped tar format distribution:
<screen>
-<prompt>$ </prompt><command>gunzip -c findbugs-1.3.9.tar.gz | tar xvf -</command>
+<prompt>$ </prompt><command>gunzip -c findbugs-2.0.2.tar.gz | tar xvf -</command>
</screen>
</para>
<para>
Extracting a zip format distribution:
<screen>
-<prompt>C:\Software></prompt><command>unzip findbugs-1.3.9.zip</command>
+<prompt>C:\Software></prompt><command>unzip findbugs-2.0.2.zip</command>
</screen>
</para>
<para>
Usually, extracting a binary distribution will create a directory ending in
-<filename class="directory">findbugs-1.3.9</filename>. For example, if you extracted
+<filename class="directory">findbugs-2.0.2</filename>. For example, if you extracted
the binary distribution from the <filename class="directory">C:\Software</filename>
directory, then the &FindBugs; software will be extracted into the directory
-<filename class="directory">C:\Software\findbugs-1.3.9</filename>.
+<filename class="directory">C:\Software\findbugs-2.0.2</filename>.
This directory is the &FindBugs; home directory. We'll refer to it as
&FBHome; (or &FBHomeWin; for Windows) throughout this manual.
</para>
@@ -159,13 +155,13 @@
<itemizedlist>
<listitem>
<para>
- The <ulink url="http://prdownloads.sourceforge.net/findbugs/findbugs-1.3.9-source.zip?download"
+ The <ulink url="http://prdownloads.sourceforge.net/findbugs/findbugs-2.0.2-source.zip?download"
>&FindBugs; source distribution</ulink>
</para>
</listitem>
<listitem>
<para>
- <ulink url="http://java.sun.com/j2se/">JDK 1.5.0 beta or later</ulink>
+ <ulink url="http://java.sun.com/j2se/">JDK 1.5.0 or later</ulink>
</para>
</listitem>
<listitem>
@@ -177,15 +173,15 @@
</para>
<warning>
- <para>
- The version of &Ant; included as <filename>/usr/bin/ant</filename> on
- Redhat Linux systems will <emphasis>not</emphasis> work for compiling
- &FindBugs;. We recommend you install a binary distribution of &Ant;
- downloaded from the <ulink url="http://ant.apache.org/">&Ant; website</ulink>.
- Make sure that when you run &Ant; your <replaceable>JAVA_HOME</replaceable>
- environment variable points to the directory in which you installed
- JDK 1.5 (or later).
- </para>
+ <para>
+ The version of &Ant; included as <filename>/usr/bin/ant</filename> on
+ Redhat Linux systems will <emphasis>not</emphasis> work for compiling
+ &FindBugs;. We recommend you install a binary distribution of &Ant;
+ downloaded from the <ulink url="http://ant.apache.org/">&Ant; website</ulink>.
+ Make sure that when you run &Ant; your <replaceable>JAVA_HOME</replaceable>
+ environment variable points to the directory in which you installed
+ JDK 1.5 (or later).
+ </para>
</warning>
<para>
@@ -222,7 +218,7 @@
a working directory. A typical command to do this is:
<screen>
-<prompt>$ </prompt><command>unzip findbugs-1.3.9-source.zip</command>
+<prompt>$ </prompt><command>unzip findbugs-2.0.2-source.zip</command>
</screen>
</para>
@@ -238,7 +234,7 @@
If you do not want to build the FindBugs documentation, then you
can ignore this file.
</para>
-
+
<para>
The <filename>local.properties</filename> overrides definitions
in the <filename>build.properties</filename> file.
@@ -256,7 +252,7 @@
xsl.stylesheet.home =${local.software.home}/docbook/docbook-xsl-1.71.1
# Set this to the directory where Saxon (http://saxon.sourceforge.net/)
-# is installed.
+# is installed.
saxon.home =${local.software.home}/java/saxon-6.5.5
]]>
@@ -313,27 +309,27 @@
</para>
</listitem>
</varlistentry>
-
+
<varlistentry>
- <term><command>runjunit</command></term>
- <listitem>
- <para>
- This target compiles and runs the internal JUnit tests included
- in &FindBugs;. It will print an error message if any unit
- tests fail.
- </para>
- </listitem>
+ <term><command>runjunit</command></term>
+ <listitem>
+ <para>
+ This target compiles and runs the internal JUnit tests included
+ in &FindBugs;. It will print an error message if any unit
+ tests fail.
+ </para>
+ </listitem>
</varlistentry>
-
+
<varlistentry>
- <term><command>bindist</command></term>
- <listitem>
- <para>
- Builds a binary distribution of &FindBugs;.
- The target creates both <filename>.zip</filename> and
- <filename>.tar.gz</filename> archives.
- </para>
- </listitem>
+ <term><command>bindist</command></term>
+ <listitem>
+ <para>
+ Builds a binary distribution of &FindBugs;.
+ The target creates both <filename>.zip</filename> and
+ <filename>.tar.gz</filename> archives.
+ </para>
+ </listitem>
</varlistentry>
</variablelist>
</para>
@@ -355,7 +351,7 @@
<sect1>
<title>Running &FindBugs;™ from a source directory</title>
<para>
-The &Ant; build script for &FindBugs; is written such that after
+The &Ant; build script for &FindBugs; is written such that after
building the <command>build</command> target, the working directory
is set up just like a binary distribution. So, the information about
running &FindBugs; in <xref linkend="running" />
@@ -377,16 +373,16 @@
<para>
&FindBugs; has two user interfaces: a graphical user interface (GUI) and a
-command line user interface. This chapter describes
+command line user interface. This chapter describes
how to run each of these user interfaces.
</para>
- <warning>
- <para>
- This chapter is in the process of being re-written.
- The rewrite is not complete yet.
- </para>
- </warning>
+ <warning>
+ <para>
+ This chapter is in the process of being re-written.
+ The rewrite is not complete yet.
+ </para>
+ </warning>
<!--
<sect1>
@@ -395,160 +391,160 @@
-->
<sect1>
- <title>Quick Start</title>
- <para>
- If you are running &FindBugs; on a Windows system,
- double-click on the file <filename>&FBHomeWin;\lib\findbugs.jar</filename> to start the &FindBugs; GUI.
- </para>
-
- <para>
- On a Unix, Linux, or Mac OS X system, run the <filename>&FBHome;/bin/findbugs</filename>
- script, or run the command <screen>
+ <title>Quick Start</title>
+ <para>
+ If you are running &FindBugs; on a Windows system,
+ double-click on the file <filename>&FBHomeWin;\lib\findbugs.jar</filename> to start the &FindBugs; GUI.
+ </para>
+
+ <para>
+ On a Unix, Linux, or Mac OS X system, run the <filename>&FBHome;/bin/findbugs</filename>
+ script, or run the command <screen>
<command>java -jar &FBHome;/lib/findbugs.jar</command></screen>
- to run the &FindBugs; GUI.
- </para>
-
- <para>
- Refer to <xref linkend="gui"/> for information on how to use the GUI.
- </para>
+ to run the &FindBugs; GUI.
+ </para>
+
+ <para>
+ Refer to <xref linkend="gui"/> for information on how to use the GUI.
+ </para>
</sect1>
<sect1>
-
- <title>Executing &FindBugs;</title>
- <para>
- This section describes how to invoke the &FindBugs; program.
- There are two ways to invoke &FindBugs;: directly, or using a
- wrapper script.
- </para>
+ <title>Executing &FindBugs;</title>
+
+ <para>
+ This section describes how to invoke the &FindBugs; program.
+ There are two ways to invoke &FindBugs;: directly, or using a
+ wrapper script.
+ </para>
- <sect2 id="directInvocation">
- <title>Direct invocation of &FindBugs;</title>
-
- <para>
- The preferred method of running &FindBugs; is to directly execute
- <filename>&FBHome;/lib/findbugs.jar</filename> using the <command>-jar</command>
- command line switch of the JVM (<command>java</command>) executable.
- (Versions of &FindBugs; prior to 1.3.5 required a wrapper script
- to invoke &FindBugs;.)
- </para>
-
- <para>
- The general syntax of invoking &FindBugs; directly is the following:
+ <sect2 id="directInvocation">
+ <title>Direct invocation of &FindBugs;</title>
+
+ <para>
+ The preferred method of running &FindBugs; is to directly execute
+ <filename>&FBHome;/lib/findbugs.jar</filename> using the <command>-jar</command>
+ command line switch of the JVM (<command>java</command>) executable.
+ (Versions of &FindBugs; prior to 1.3.5 required a wrapper script
+ to invoke &FindBugs;.)
+ </para>
+
+ <para>
+ The general syntax of invoking &FindBugs; directly is the following:
<screen>
- <command>java <replaceable>[JVM arguments]</replaceable> -jar &FBHome;/lib/findbugs.jar <replaceable>options...</replaceable></command>
+ <command>java <replaceable>[JVM arguments]</replaceable> -jar &FBHome;/lib/findbugs.jar <replaceable>options...</replaceable></command>
</screen>
- </para>
+ </para>
-<!--
- <para>
- By default, executing <filename>findbugs.jar</filename> runs the
- &FindBugs; graphical user interface (GUI). On windows systems,
- you can double-click on <filename>findbugs.jar</filename> to launch
- the GUI. From a command line, the command
- <screen>
+<!--
+ <para>
+ By default, executing <filename>findbugs.jar</filename> runs the
+ &FindBugs; graphical user interface (GUI). On windows systems,
+ you can double-click on <filename>findbugs.jar</filename> to launch
+ the GUI. From a command line, the command
+ <screen>
java -jar <replaceable>&FBHome;</replaceable>/lib/findbugs.jar</screen>
- will launch the GUI.
- </para>
+ will launch the GUI.
+ </para>
-->
- <sect3 id="chooseUI">
- <title>Choosing the User Interface</title>
-
- <para>
- The first command line option chooses the &FindBugs; user interface to execute.
- Possible values are:
- </para>
- <itemizedlist>
- <listitem>
- <para>
- <command>-gui</command>: runs the graphical user interface (GUI)
- </para>
- </listitem>
-
- <listitem>
- <para>
- <command>-textui</command>: runs the command line user interface
- </para>
- </listitem>
+ <sect3 id="chooseUI">
+ <title>Choosing the User Interface</title>
- <listitem>
- <para>
- <command>-version</command>: displays the &FindBugs; version number
- </para>
- </listitem>
+ <para>
+ The first command line option chooses the &FindBugs; user interface to execute.
+ Possible values are:
+ </para>
+ <itemizedlist>
+ <listitem>
+ <para>
+ <command>-gui</command>: runs the graphical user interface (GUI)
+ </para>
+ </listitem>
- <listitem>
- <para>
- <command>-help</command>: displays help information for the
- &FindBugs; command line user interface
- </para>
- </listitem>
+ <listitem>
+ <para>
+ <command>-textui</command>: runs the command line user interface
+ </para>
+ </listitem>
- <listitem>
- <para>
- <command>-gui1</command>: executes the original (obsolete)
- &FindBugs; graphical user interface
- </para>
- </listitem>
- </itemizedlist>
-
- </sect3>
-
- <sect3 id="jvmArgs">
- <title>Java Virtual Machine (JVM) arguments</title>
-
- <para>
- Several Java Virtual Machine arguments are useful when invoking
- &FindBugs;.
- </para>
-
- <variablelist>
- <varlistentry>
- <term><command>-Xmx<replaceable>NN</replaceable>m</command></term>
- <listitem>
- <para>
- Set the maximum Java heap size to <replaceable>NN</replaceable>
- megabytes. &FindBugs; generally requires a large amount of
- memory. For a very large project, using 1500 megabytes
- is not unusual.
- </para>
- </listitem>
- </varlistentry>
+ <listitem>
+ <para>
+ <command>-version</command>: displays the &FindBugs; version number
+ </para>
+ </listitem>
- <varlistentry>
- <term><command>-D<replaceable>name</replaceable>=<replaceable>value</replaceable></command></term>
- <listitem>
- <para>
- Set a Java system property. For example, you might use the
- argument <command>-Duser.language=ja</command> to display
- GUI messages in Japanese.
- </para>
- </listitem>
- </varlistentry>
+ <listitem>
+ <para>
+ <command>-help</command>: displays help information for the
+ &FindBugs; command line user interface
+ </para>
+ </listitem>
- <!--
- <varlistentry>
- <term></term>
- <listitem>
- <para>
- </para>
- </listitem>
- </varlistentry>
- -->
- </variablelist>
- </sect3>
-
- </sect2>
-
- <sect2 id="wrapperScript">
- <title>Invocation of &FindBugs; using a wrapper script</title>
+ <listitem>
+ <para>
+ <command>-gui1</command>: executes the original (obsolete)
+ &FindBugs; graphical user interface
+ </para>
+ </listitem>
+ </itemizedlist>
- <para>
- Another way to run &FindBugs; is to use a wrapper script.
- </para>
+ </sect3>
+
+ <sect3 id="jvmArgs">
+ <title>Java Virtual Machine (JVM) arguments</title>
+
+ <para>
+ Several Java Virtual Machine arguments are useful when invoking
+ &FindBugs;.
+ </para>
+
+ <variablelist>
+ <varlistentry>
+ <term><command>-Xmx<replaceable>NN</replaceable>m</command></term>
+ <listitem>
+ <para>
+ Set the maximum Java heap size to <replaceable>NN</replaceable>
+ megabytes. &FindBugs; generally requires a large amount of
+ memory. For a very large project, using 1500 megabytes
+ is not unusual.
+ </para>
+ </listitem>
+ </varlistentry>
+
+ <varlistentry>
+ <term><command>-D<replaceable>name</replaceable>=<replaceable>value</replaceable></command></term>
+ <listitem>
+ <para>
+ Set a Java system property. For example, you might use the
+ argument <command>-Duser.language=ja</command> to display
+ GUI messages in Japanese.
+ </para>
+ </listitem>
+ </varlistentry>
+
+ <!--
+ <varlistentry>
+ <term></term>
+ <listitem>
+ <para>
+ </para>
+ </listitem>
+ </varlistentry>
+ -->
+ </variablelist>
+ </sect3>
+
+ </sect2>
+
+ <sect2 id="wrapperScript">
+ <title>Invocation of &FindBugs; using a wrapper script</title>
+
+ <para>
+ Another way to run &FindBugs; is to use a wrapper script.
+ </para>
<para>
On Unix-like systems, use the following command to invoke the wrapper script:
@@ -558,7 +554,7 @@
</para>
<para>
-On Windows systems, the command to invoke the wrapper script is
+On Windows systems, the command to invoke the wrapper script is
<screen>
<prompt>C:\My Directory></prompt><command>&FBHomeWin;\bin\findbugs.bat <replaceable>options...</replaceable></command>
</screen>
@@ -570,14 +566,14 @@
FindBugs using the <command>findbugs</command> command.
</para>
- <sect3 id="wrapperOptions">
- <title>Wrapper script command line options</title>
- <para>The &FindBugs; wrapper scripts support the following command-line options.
- Note that these command line options are <emphasis>not</emphasis> handled by
- the &FindBugs; program per se; rather, they are handled by the wrapper
- script.
- </para>
- <variablelist>
+ <sect3 id="wrapperOptions">
+ <title>Wrapper script command line options</title>
+ <para>The &FindBugs; wrapper scripts support the following command-line options.
+ Note that these command line options are <emphasis>not</emphasis> handled by
+ the &FindBugs; program per se; rather, they are handled by the wrapper
+ script.
+ </para>
+ <variablelist>
<varlistentry>
<term><command>-jvmArgs <replaceable>args</replaceable></command></term>
<listitem>
@@ -634,9 +630,9 @@
</listitem>
</varlistentry>
- </variablelist>
-
- </sect3>
+ </variablelist>
+
+ </sect3>
</sect2>
@@ -663,9 +659,9 @@
-->
<para>
- This section describes the command line options supported by &FindBugs;.
- These command line options may be used when invoking &FindBugs; directly,
- or when using a wrapper script.
+ This section describes the command line options supported by &FindBugs;.
+ These command line options may be used when invoking &FindBugs; directly,
+ or when using a wrapper script.
</para>
<sect2>
@@ -676,7 +672,7 @@
</para>
<variablelist>
-
+
<varlistentry>
<term><command>-effort:min</command></term>
<listitem>
@@ -688,14 +684,14 @@
</para>
</listitem>
</varlistentry>
-
+
<varlistentry>
<term><command>-effort:max</command></term>
<listitem>
<para>
- Enable analyses which increase precision and find more bugs, but which
- may require more memory and take more time to complete.
+ Enable analyses which increase precision and find more bugs, but which
+ may require more memory and take more time to complete.
</para>
</listitem>
</varlistentry>
@@ -710,15 +706,15 @@
</para>
</listitem>
</varlistentry>
-
+
<!--
<varlistentry>
- <term><command></command></term>
- <listitem>
- <para>
-
- </para>
- </listitem>
+ <term><command></command></term>
+ <listitem>
+ <para>
+
+ </para>
+ </listitem>
</varlistentry>
-->
@@ -737,7 +733,7 @@
<term><command>-look:</command><replaceable>plastic|gtk|native</replaceable></term>
<listitem>
<para>
- Set Swing look and feel.
+ Set Swing look and feel.
</para>
</listitem>
</varlistentry>
@@ -787,7 +783,7 @@
<term><command>-onlyAnalyze</command> <replaceable>com.foobar.MyClass,com.foobar.mypkg.*</replaceable></term>
<listitem>
<para>
- Restrict analysis to find bugs to given comma-separated list of
+ Restrict analysis to find bugs to given comma-separated list of
classes and packages.
Unlike filtering, this option avoids running analysis on
classes and packages that are not explicitly matched:
@@ -831,15 +827,15 @@
</para>
</listitem>
</varlistentry>
-
+
<varlistentry>
- <term><command>-relaxed</command></term>
- <listitem>
- <para>
- Relaxed reporting mode. For many detectors, this option
- suppresses the heuristics used to avoid reporting false positives.
- </para>
- </listitem>
+ <term><command>-relaxed</command></term>
+ <listitem>
+ <para>
+ Relaxed reporting mode. For many detectors, this option
+ suppresses the heuristics used to avoid reporting false positives.
+ </para>
+ </listitem>
</varlistentry>
<varlistentry>
@@ -864,16 +860,16 @@
<ulink url="http://www.w3.org/TR/xslt">XSLT</ulink>
stylesheet to generate the HTML: you can find this file in <filename>findbugs.jar</filename>,
or in the &FindBugs; source or binary distributions. Variants of this option include
- <command>-html:plain.xsl</command>, <command>-html:fancy.xsl</command> and <command>-html:fancy-hist.xsl</command>.
- The <filename>plain.xsl</filename> stylesheet does not use Javascript or DOM,
- and may work better with older web browsers, or for printing. The <filename>fancy.xsl</filename>
- stylesheet uses DOM and Javascript for navigation and CSS for
- visual presentation. The <command>fancy-hist.xsl</command> an evolution of <command>fancy.xsl</command> stylesheet.
- It makes an extensive use of DOM and Javascript for dynamically filtering the lists of bugs.
- </para>
-
- <para>
- If you want to specify your own
+ <command>-html:plain.xsl</command>, <command>-html:fancy.xsl</command> and <command>-html:fancy-hist.xsl</command>.
+ The <filename>plain.xsl</filename> stylesheet does not use Javascript or DOM,
+ and may work better with older web browsers, or for printing. The <filename>fancy.xsl</filename>
+ stylesheet uses DOM and Javascript for navigation and CSS for
+ visual presentation. The <command>fancy-hist.xsl</command> an evolution of <command>fancy.xsl</command> stylesheet.
+ It makes an extensive use of DOM and Javascript for dynamically filtering the lists of bugs.
+ </para>
+
+ <para>
+ If you want to specify your own
XSLT stylesheet to perform the transformation to HTML, specify the option as
<command>-html:<replaceable>myStylesheet.xsl</replaceable></command>,
where <replaceable>myStylesheet.xsl</replaceable> is the filename of the
@@ -961,11 +957,11 @@
</chapter>
<chapter id="gui">
- <title>Using the &FindBugs; GUI</title>
+ <title>Using the &FindBugs; GUI</title>
- <para>
- This chapter describes how to use the &FindBugs; graphical user interface (GUI).
- </para>
+ <para>
+ This chapter describes how to use the &FindBugs; graphical user interface (GUI).
+ </para>
<sect1>
<title>Creating a Project</title>
@@ -981,7 +977,7 @@
</para>
<para>
-Use the "Add" button next to the "Class archives and directories to analyze" text field to select a Java archive
+Use the "Add" button next to "Classpath to analyze" to select a Java archive
file (zip, jar, ear, or war file) or directory containing java classes to analyze for bugs. You may add multiple
archives/directories.
</para>
@@ -1013,7 +1009,7 @@
<title>Running the Analysis</title>
<para>
Once you have added all of the archives, directories, and source directories,
-click the "Finish" button to analyze the classes contained in the
+click the "Analyze" button to analyze the classes contained in the
Jar files. Note that for a very large program on an older computer,
this may take quite a while (tens of minutes). A recent computer with
ample memory will typically be able to analyze a large program in only a
@@ -1194,20 +1190,20 @@
<screen>
<prompt>[daveho@noir]$</prompt> <command>ant findbugs</command>
Buildfile: build.xml
-
+
init:
-
+
compile:
-
+
examples:
-
+
jar:
-
+
findbugs:
[findbugs] Running FindBugs...
[findbugs] Bugs were found
[findbugs] Output saved to bcel-fb.xml
-
+
BUILD SUCCESSFUL
Total time: 35 seconds
</screen>
@@ -1230,11 +1226,17 @@
<term><literal>class</literal></term>
<listitem>
<para>
- A nested element specifying which classes to analyze. The <literal>class</literal>
+ A optional nested element specifying which classes to analyze. The <literal>class</literal>
element must specify a <literal>location</literal> attribute which names the
archive file (jar, zip, etc.), directory, or class file to be analyzed. Multiple <literal>class</literal>
elements may be specified as children of a single <literal>findbugs</literal> element.
</para>
+ <para>In addition to or instead of specifying a <literal>class</literal> element,
+ the &FindBugs; task can contain one or more <literal>fileset</literal> element(s) that
+ specify files to be analyzed.
+ For example, you might use a fileset to specify that all of the jar files in a directory
+ should be analyzed.
+ </para>
</listitem>
</varlistentry>
@@ -1289,9 +1291,9 @@
<listitem>
<para>
An optional attribute. It specifies
- the priority threshold for reporting bugs. If set to "low", all bugs are reported.
- If set to "medium" (the default), medium and high priority bugs are reported.
- If set to "high", only high priority bugs are reported.
+ the confidence/priority threshold for reporting issues. If set to "low", confidence is not used to filter bugs.
+ If set to "medium" (the default), low confidence issues are supressed.
+ If set to "high", only high confidence bugs are reported.
</para>
</listitem>
</varlistentry>
@@ -1303,13 +1305,13 @@
Optional attribute.
It specifies the output format. If set to "xml" (the default), output
is in XML format.
- If set to "xml:withMessages", output is in XML format augmented with
- human-readable messages. (You should use this format if you plan
- to generate a report using an XSL stylesheet.)
- If set to "html", output is in HTML formatted (default stylesheet is default.xsl).
- If set to "text", output is in ad-hoc text format.
+ If set to "xml:withMessages", output is in XML format augmented with
+ human-readable messages. (You should use this format if you plan
+ to generate a report using an XSL stylesheet.)
+ If set to "html", output is in HTML formatted (default stylesheet is default.xsl).
+ If set to "text", output is in ad-hoc text format.
If set to "emacs", output is in <ulink url="http://www.gnu.org/software/emacs/">Emacs</ulink> error message format.
- If set to "xdocs", output is xdoc XML for use with Apache Maven.
+ If set to "xdocs", output is xdoc XML for use with Apache Maven.
</para>
</listitem>
</varlistentry>
@@ -1321,7 +1323,7 @@
It specifies the stylesheet to use to generate html output when the output is set to html.
Stylesheets included in the FindBugs distribution include default.xsl, fancy.xsl, fancy-hist.xsl, plain.xsl, and summary.xsl.
The default value, if no stylesheet attribute is provided, is default.xsl.
-
+
</para>
</listitem>
</varlistentry>
@@ -1358,17 +1360,17 @@
</para>
</listitem>
</varlistentry>
-
+
<varlistentry>
- <term><literal>effort</literal></term>
- <listitem>
- <para>
- Set the analysis effort level. The value specified should be
- one of <literal>min</literal>, <literal>default</literal>,
- or <literal>max</literal>. See <xref linkend="commandLineOptions"/>
- for more information about setting the analysis level.
- </para>
- </listitem>
+ <term><literal>effort</literal></term>
+ <listitem>
+ <para>
+ Set the analysis effort level. The value specified should be
+ one of <literal>min</literal>, <literal>default</literal>,
+ or <literal>max</literal>. See <xref linkend="commandLineOptions"/>
+ for more information about setting the analysis level.
+ </para>
+ </listitem>
</varlistentry>
<varlistentry>
@@ -1384,7 +1386,7 @@
<para>Synonym for effort="max".</para>
</listitem>
</varlistentry>
-
+
<varlistentry>
<term><literal>visitors</literal></term>
<listitem>
@@ -1474,7 +1476,7 @@
that the Java process executing &FindBugs; may run before it is
assumed to be hung and is terminated. The default is 600,000
milliseconds, which is ten minutes. Note that for very large
- programs, &FindBugs; may require more than ten minutes to complete its
+ programs, &FindBugs; may require more than ten minutes to complete its
analysis.
</para>
</listitem>
@@ -1484,7 +1486,7 @@
<term><literal>failOnError</literal></term>
<listitem>
<para>
- Optional boolean attribute. Whether to abort the build process if there is an
+ Optional boolean attribute. Whether to abort the build process if there is an
error running &FindBugs;. Defaults to "false"
</para>
</listitem>
@@ -1499,16 +1501,16 @@
</para>
</listitem>
</varlistentry>
-
+
<varlistentry>
- <term><literal>warningsProperty</literal></term>
- <listitem>
- <para>
- Optional attribute which specifies the name of a property
- that will be set to "true" if any warnings are reported by
- &FindBugs; on the analyzed program.
- </para>
- </listitem>
+ <term><literal>warningsProperty</literal></term>
+ <listitem>
+ <para>
+ Optional attribute which specifies the name of a property
+ that will be set to "true" if any warnings are reported by
+ &FindBugs; on the analyzed program.
+ </para>
+ </listitem>
</varlistentry>
</variablelist>
@@ -1557,19 +1559,19 @@
<para>
We provide update sites that allow you to automatically install FindBugs into Eclipse and also query and install updates.
There are three different update sites</para>
-
+
<variablelist><title>FindBugs Eclipse update sites</title>
- <varlistentry><term><ulink url="http://findbugs.cs.umd.edu/eclipse/">http://findbugs.cs.umd.edu/eclipse/</ulink></term>
-
+ <varlistentry><term><ulink url="http://findbugs.cs.umd.edu/eclipse/">http://findbugs.cs.umd.edu/eclipse/</ulink></term>
+
<listitem>
<para>
Only provides official releases of FindBugs.
</para>
</listitem>
</varlistentry>
-
- <varlistentry><term><ulink url="http://findbugs.cs.umd.edu/eclipse-candidate/">http://findbugs.cs.umd.edu/eclips-candidate/</ulink></term>
-
+
+ <varlistentry><term><ulink url="http://findbugs.cs.umd.edu/eclipse-candidate/">http://findbugs.cs.umd.edu/eclipse-candidate/</ulink></term>
+
<listitem>
<para>
Provides official releases and release candidates of FindBugs.
@@ -1577,22 +1579,22 @@
</listitem>
</varlistentry>
- <varlistentry><term><ulink url="http://findbugs.cs.umd.edu/eclipse-daily/">http://findbugs.cs.umd.edu/eclipse-daily/</ulink></term>
-
+ <varlistentry><term><ulink url="http://findbugs.cs.umd.edu/eclipse-daily/">http://findbugs.cs.umd.edu/eclipse-daily/</ulink></term>
+
<listitem>
<para>
- Provides the daily build of FindBugs. No testing other than that it compiles.
+ Provides the daily build of FindBugs. No testing other than that it compiles.
</para>
</listitem>
</varlistentry>
</variablelist>
-
+
<para>You can also manually
download the plugin from the following link:
-<ulink url="http://prdownloads.sourceforge.net/findbugs/edu.umd.cs.findbugs.plugin.eclipse_1.3.9.20090821.zip?download"
->http://prdownloads.sourceforge.net/findbugs/edu.umd.cs.findbugs.plugin.eclipse_1.3.9.20090821.zip?download</ulink>.
+<ulink url="http://prdownloads.sourceforge.net/findbugs/edu.umd.cs.findbugs.plugin.eclipse_2.0.2.20130225.zip?download"
+>http://prdownloads.sourceforge.net/findbugs/edu.umd.cs.findbugs.plugin.eclipse_2.0.2.20130225.zip?download</ulink>.
Extract it in Eclipse's "plugins" subdirectory.
-(So <eclipse_install_dir>/plugins/edu.umd.cs.findbugs.plugin.eclipse_1.3.9.20090821/findbugs.png
+(So <eclipse_install_dir>/plugins/edu.umd.cs.findbugs.plugin.eclipse_2.0.2.20130225/findbugs.png
should be the path to the &FindBugs; logo.)
</para>
@@ -1620,10 +1622,10 @@
of bug patterns.
</para>
<para>
-You can also run &FindBugs; on existing java archives (jar, ear, zip, war etc). Simply
+You can also run &FindBugs; on existing java archives (jar, ear, zip, war etc). Simply
create an empty Java project and attach archives to the project classpath. Having that, you
-can now right click the archive node in Package Explorer and select the option labeled
-"Find Bugs". If you additionally configure the source code locations for the binaries,
+can now right click the archive node in Package Explorer and select the option labeled
+"Find Bugs". If you additionally configure the source code locations for the binaries,
&FindBugs; will also link the generated warnings to the right source files.
</para>
<para>
@@ -1663,16 +1665,90 @@
</sect1>
<sect1>
+<title>Extending the Eclipse Plugin (since 2.0.0)</title>
+<para>
+Eclipse plugin supports contribution of custom &FindBugs; detectors (see also
+<ulink url="http://code.google.com/p/findbugs/source/browse/trunk/findbugs/src/doc/AddingDetectors.txt">AddingDetectors.txt</ulink>
+for more information). There are two ways to contribute custom plugins to the Eclipse:
+</para>
+<itemizedlist>
+ <listitem>
+ <para>
+ Existing standard &FindBugs; detector packages can be configured via
+ <menuchoice>
+ <guimenu>Window</guimenu>
+ <guimenuitem>Preferences</guimenuitem>
+ <guimenuitem>Java</guimenuitem>
+ <guimenuitem>&FindBugs;</guimenuitem>
+ <guimenuitem>Misc. Settings</guimenuitem>
+ <guimenuitem>Custom Detectors</guimenuitem>
+ </menuchoice>.
+ Simply specify there locations of any additional plugin libraries.
+ </para>
+
+ <para>
+ The benefit of this solution is that already existing detector packages can be
+ used "as is", and that you can quickly verify the quality of third party detectors.
+ The drawback is that you have to apply this settings in each
+ new Eclipse workspace, and this settings can't be shared between team members.
+ </para>
+ </listitem>
+
+ <listitem>
+ <para>
+ It is possible to contribute custom detectors via standard Eclipse extensions mechanism.
+ </para>
+
+ <para>
+ Please check the documentation of the
+ <ulink url="http://code.google.com/p/findbugs/source/browse/trunk/eclipsePlugin/schema/detectorPlugins.exsd">
+ findBugsEclipsePlugin/schema/detectorPlugins.exsd</ulink>
+ extension point how to update the plugin.xml. Existing &FindBugs; detector plugins can
+ be easily "extended" to be full featured &FindBugs; AND Eclipse detector plugins.
+ Usually you only need to add META-INF/MANIFEST.MF and plugin.xml to the jar and
+ update your build scripts to not to override the MANIFEST.MF during the build.
+ </para>
+
+ <para>
+ The benefit of this solution is that for given (shared) Eclipse installation
+ each team member has exactly same detectors set, and there is no need to configure
+ anything anymore. The (really small) precondition
+ is that you have to convert your existing detectors package to the valid
+ Eclipse plugin. You can do this even for third-party detector packages.
+ Another major differentiator is the ability to extend the default FindBugs
+ classpath at runtime with required third party libraries (see
+ <ulink url="http://code.google.com/p/findbugs/source/browse/trunk/findbugs/src/doc/AddingDetectors.txt">AddingDetectors.txt</ulink>
+ for more information).
+ </para>
+ </listitem>
+
+</itemizedlist>
+
+</sect1>
+
+<sect1>
<title>Troubleshooting</title>
<para>
-The &FindBugs; Eclipse plugin is still experimental. This section
-lists common problems with the plugin and (if known) how to resolve them.
+This section lists common problems with the plugin and (if known) how to resolve them.
</para>
<itemizedlist>
<listitem>
<para>
+ If you see OutOfMemory error dialogs after starting &FindBugs; analysis in Eclipse,
+ please increase JVM available memory: change eclipse.ini and add the lines below
+ to the end of the file:
+ <programlisting>
+ -vmargs
+ -Xmx1000m
+ </programlisting>
+ Important: the configuration arguments starting with the line "-vmargs" must
+ be last lines in the eclipse.ini file, and only one argument per line is allowed!
+ </para>
+ </listitem>
+ <listitem>
+ <para>
If you do not see any &FindBugs; problem markers (in your source
windows or in the Problems View), you may need to change your
Problems View filter settings. See
@@ -1752,80 +1828,101 @@
<varlistentry>
<term><literal><Bug></literal></term>
<listitem><para>
- This element specifies a particular bug pattern or patterns to match.
- The <literal>pattern</literal> attribute is a comma-separated list of
- bug pattern types. You can find the bug pattern types for particular
- warnings by looking at the output produced by the <command>-xml</command>
- output option (the <literal>type</literal> attribute of <literal>BugInstance</literal>
- elements), or from the <ulink url="../bugDescriptions.html">bug
- descriptions document</ulink>.
+ This element specifies a particular bug pattern or patterns to match.
+ The <literal>pattern</literal> attribute is a comma-separated list of
+ bug pattern types. You can find the bug pattern types for particular
+ warnings by looking at the output produced by the <command>-xml</command>
+ output option (the <literal>type</literal> attribute of <literal>BugInstance</literal>
+ elements), or from the <ulink url="../bugDescriptions.html">bug
+ descriptions document</ulink>.
</para><para>
- For more coarse-grained matching, use <literal>code</literal> attribute. It takes
- a comma-separated list of bug abbreviations. For most-coarse grained matching use
- <literal>category</literal> attriute, that takes a comma separated list of bug category names:
- <literal>CORRECTNESS</literal>, <literal>MT_CORRECTNESS</literal>,
- <literal>BAD_PRACTICICE</literal>, <literal>PERFORMANCE</literal>, <literal>STYLE</literal>.
- </para><para>
- If more than one of the attributes mentioned above are specified on the same
- <literal><Bug></literal> element, all bug patterns that match either one of specified
- pattern names, or abreviations, or categories will be matched.
- </para><para>
- As a backwards compatibility measure, <literal><BugPattern></literal> and
- <literal><BugCode></literal> elements may be used instead of
- <literal><Bug></literal> element. Each of these uses a
- <literal>name</literal> attribute for specifying accepted values list. Support for these
- elements may be removed in a future release.
+ For more coarse-grained matching, use <literal>code</literal> attribute. It takes
+ a comma-separated list of bug abbreviations. For most-coarse grained matching use
+ <literal>category</literal> attriute, that takes a comma separated list of bug category names:
+ <literal>CORRECTNESS</literal>, <literal>MT_CORRECTNESS</literal>,
+ <literal>BAD_PRACTICICE</literal>, <literal>PERFORMANCE</literal>, <literal>STYLE</literal>.
+ </para><para>
+ If more than one of the attributes mentioned above are specified on the same
+ <literal><Bug></literal> element, all bug patterns that match either one of specified
+ pattern names, or abreviations, or categories will be matched.
+ </para><para>
+ As a backwards compatibility measure, <literal><BugPattern></literal> and
+ <literal><BugCode></literal> elements may be used instead of
+ <literal><Bug></literal> element. Each of these uses a
+ <literal>name</literal> attribute for specifying accepted values list. Support for these
+ elements may be removed in a future release.
</para></listitem>
</varlistentry>
<varlistentry>
- <term><literal><Priority></literal></term>
- <listitem>
- <para>
- This element matches warnings with a particular priority.
- The <literal>value</literal> attribute should be an integer value:
- 1 to match high-priority warnings, 2 to match medium-priority warnings,
- or 3 to match low-priority warnings.
- </para>
- </listitem>
+ <term><literal><Confidence></literal></term>
+ <listitem>
+ <para>
+ This element matches warnings with a particular bug confidence.
+ The <literal>value</literal> attribute should be an integer value:
+ 1 to match high-confidence warnings, 2 to match normal-confidence warnings,
+ or 3 to match low-confidence warnings. <Confidence> replaced
+ <Priority> in 2.0.0 release.
+ </para>
+ </listitem>
</varlistentry>
+ <varlistentry>
+ <term><literal><Priority></literal></term>
+ <listitem>
+ <para>
+ Same as <literal><Confidence></literal>, exists for backward compatibility.
+ </para>
+ </listitem>
+ </varlistentry>
+
+ <varlistentry>
+ <term><literal><Rank></literal></term>
+ <listitem>
+ <para>
+ This element matches warnings with a particular bug rank.
+ The <literal>value</literal> attribute should be an integer value
+ between 1 and 20, where 1 to 4 are scariest, 5 to 9 scary, 10 to 14 troubling,
+ and 15 to 20 of concern bugs.
+ </para>
+ </listitem>
+ </varlistentry>
<varlistentry>
<term><literal><Package></literal></term>
- <listitem>
- <para>
- This element matches warnings associated with classes within the package specified
- using <literal>name</literal> attribute. Nested packages are not included (along the
- lines of Java import statement). However matching multiple packages can be achieved
- easily using regex name match.
- </para>
- </listitem>
+ <listitem>
+ <para>
+ This element matches warnings associated with classes within the package specified
+ using <literal>name</literal> attribute. Nested packages are not included (along the
+ lines of Java import statement). However matching multiple packages can be achieved
+ easily using regex name match.
+ </para>
+ </listitem>
</varlistentry>
-
+
<varlistentry>
<term><literal><Class></literal></term>
- <listitem>
- <para>
- This element matches warnings associated with a particular class. The
- <literal>name</literal> attribute is used to specify the exact or regex match pattern
- for the class name.
- </para>
-
- <para>
- As a backward compatibility measure, instead of element of this type, you can use
- <literal>class</literal> attribute on a <literal>Match</literal> element to specify
- exact an class name or <literal>classregex</literal> attribute to specify a regular
- expression to match the class name against.
- </para>
-
- <para>
- If the <literal>Match</literal> element contains neither a <literal>Class</literal> element,
- nor a <literal>class</literal> / <literal>classregex</literal> attribute, the predicate will apply
- to all classes. Such predicate is likely to match more bug instances than you want, unless it is
- refined further down with apropriate method or field predicates.
- </para>
- </listitem>
+ <listitem>
+ <para>
+ This element matches warnings associated with a particular class. The
+ <literal>name</literal> attribute is used to specify the exact or regex match pattern
+ for the class name.
+ </para>
+
+ <para>
+ As a backward compatibility measure, instead of element of this type, you can use
+ <literal>class</literal> attribute on a <literal>Match</literal> element to specify
+ exact an class name or <literal>classregex</literal> attribute to specify a regular
+ expression to match the class name against.
+ </para>
+
+ <para>
+ If the <literal>Match</literal> element contains neither a <literal>Class</literal> element,
+ nor a <literal>class</literal> / <literal>classregex</literal> attribute, the predicate will apply
+ to all classes. Such predicate is likely to match more bug instances than you want, unless it is
+ refined further down with apropriate method or field predicates.
+ </para>
+ </listitem>
</varlistentry>
<varlistentry>
@@ -1837,8 +1934,8 @@
of the types of the method's parameters. The <literal>returns</literal> attribute is
the method's return type. In <literal>params</literal> and <literal>returns</literal>, class names
must be fully qualified. (E.g., "java.lang.String" instead of just
- "String".) If one of the latter attributes is specified the other is required for creating a method signature.
- Note that you can provide either <literal>name</literal> attribute or <literal>params</literal>
+ "String".) If one of the latter attributes is specified the other is required for creating a method signature.
+ Note that you can provide either <literal>name</literal> attribute or <literal>params</literal>
and <literal>returns</literal> attributes or all three of them. This way you can provide various kinds of
name and signature based matches.
</para></listitem>
@@ -1853,7 +1950,7 @@
of these attributes in order to perform name / signature based matches.
</para></listitem>
</varlistentry>
-
+
<varlistentry>
<term><literal><Local></literal></term>
@@ -1861,7 +1958,7 @@
the exact or regex match pattern for the local variable name. Local variables are variables defined within a method.
</para></listitem>
</varlistentry>
-
+
<varlistentry>
<term><literal><Or></literal></term>
<listitem><para>
@@ -1869,6 +1966,22 @@
<literal>Method</literal> elements in an <literal>Or</literal> clause in order to match either method.
</para></listitem>
</varlistentry>
+ <varlistentry>
+ <term><literal><And></literal></term>
+ <listitem><para>
+ This element combines <literal>Match</literal> clauses which both must evaluate to true. I.e., you can put
+ <literal>Bug</literal> and <literal>Priority</literal> elements in an <literal>And</literal> clause in order
+ to match specific bugs with given priority only.
+ </para></listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><literal><Not></literal></term>
+ <listitem><para>
+ This element inverts the included child <literal>Match</literal>. I.e., you can put a
+ <literal>Bug</literal> element in a <literal>Not</literal> clause in order to match any bug
+ excluding the given one.
+ </para></listitem>
+ </varlistentry>
</variablelist>
</sect1>
@@ -1878,8 +1991,8 @@
<para>
If the <literal>name</literal> attribute of <literal>Class</literal>, <literal>Method</literal> or
-<literal>Field</literal> starts with the ~ character the rest of attribute content is interpreted as
-a Java regular expression that is matched against the names of the Java element in question.
+<literal>Field</literal> starts with the ~ character the rest of attribute content is interpreted as
+a Java regular expression that is matched against the names of the Java element in question.
</para>
<para>
@@ -1888,7 +2001,7 @@
</para>
<para>
-See <ulink url="http://java.sun.com/j2se/1.5.0/docs/api/java/util/regex/Pattern.html"><literal>java.util.regex.Pattern</literal></ulink>
+See <ulink url="http://java.sun.com/j2se/1.5.0/docs/api/java/util/regex/Pattern.html"><literal>java.util.regex.Pattern</literal></ulink>
documentation for pattern syntax.
</para>
</sect1>
@@ -2008,8 +2121,8 @@
</para>
<para>
- 6. Match a particular bug pattern in a particular method.
-
+ 6. Match a particular bug pattern in a particular method.
+
<programlisting>
<![CDATA[
<!-- A method with an open stream false positive. -->
@@ -2023,8 +2136,8 @@
</para>
<para>
- 7. Match a particular bug pattern with a given priority in a particular method.
-
+ 7. Match a particular bug pattern with a given priority in a particular method.
+
<programlisting>
<![CDATA[
<!-- A method with a dead local store false positive (medium priority). -->
@@ -2039,12 +2152,12 @@
</para>
<para>
- 8. Match minor bugs introduced by AspectJ compiler (you are probably not interested in these unless
- you are an AspectJ developer).
-
+ 8. Match minor bugs introduced by AspectJ compiler (you are probably not interested in these unless
+ you are an AspectJ developer).
+
<programlisting>
<![CDATA[
- <Match>
+ <Match>
<Class name="~.*\$AjcClosure\d+" />
<Bug pattern="DLS_DEAD_LOCAL_STORE" />
<Method name="run" />
@@ -2058,12 +2171,12 @@
</para>
<para>
- 9. Match bugs in specific parts of the code base
-
+ 9. Match bugs in specific parts of the code base
+
<programlisting>
<![CDATA[
<!-- match unused fields warnings in Messages classes in all packages -->
- <Match>
+ <Match>
<Class name="~.*\.Messages" />
<Bug code="UUF" />
</Match>
@@ -2082,24 +2195,44 @@
</para>
<para>
- 10. Match bugs on fieds or methods with specific signatures
+ 10. Match bugs on fields or methods with specific signatures
<programlisting>
<![CDATA[
- <!-- match System.exit(...) usage warnings in void main(String[]) methods in all classes -->
- <Match>
- <Method returns="void" name="main" params="java.lang.String[]" />
- <Method pattern="DM_EXIT" />
- </Match>
- <!-- match UuF warnings on fields of type com.foobar.DebugInfo on all classes -->
- <Match>
- <Field type="com.foobar.DebugInfo" />
- <Bug code="UuF" />
- </Match>
+ <!-- match System.exit(...) usage warnings in void main(String[]) methods in all classes -->
+ <Match>
+ <Method returns="void" name="main" params="java.lang.String[]" />
+ <Bug pattern="DM_EXIT" />
+ </Match>
+ <!-- match UuF warnings on fields of type com.foobar.DebugInfo on all classes -->
+ <Match>
+ <Field type="com.foobar.DebugInfo" />
+ <Bug code="UuF" />
+ </Match>
]]>
-</programlisting>
-
+</programlisting>
</para>
-
+
+
+<para>
+ 11. Match bugs using the Not filter operator
+<programlisting>
+<![CDATA[
+<!-- ignore all bugs in test classes, except for those bugs specifically relating to JUnit tests -->
+<!-- i.e. filter bug if ( classIsJUnitTest && ! bugIsRelatedToJUnit ) -->
+<Match>
+ <!-- the Match filter is equivalent to a logical 'And' -->
+
+ <Class name="~.*\.*Test" />
+ <!-- test classes are suffixed by 'Test' -->
+
+ <Not>
+ <Bug code="IJU" /> <!-- 'IJU' is the code for bugs related to JUnit test code -->
+ </Not>
+</Match>
+]]>
+</programlisting>
+</para>
+
</sect1>
<sect1>
@@ -2140,6 +2273,15 @@
<Bug pattern="DLS_DEAD_LOCAL_STORE" />
<Priority value="2" />
</Match>
+
+ <!-- All bugs in test classes, except for JUnit-specific bugs -->
+ <Match>
+ <Class name="~.*\.*Test" />
+ <Not>
+ <Bug code="IJU" />
+ </Not>
+ </Match>
+
</FindBugsFilter>
]]>
</programlisting>
@@ -2675,9 +2817,9 @@
Data mining
**************************************************************************
-->
-
+
<chapter id="datamining">
- <title>Data mining of bugs with &FindBugs;™</title>
+ <title>Data mining of bugs with &FindBugs;™</title>
<para>
FindBugs incorporates an ability to perform sophisticated queries on bug
@@ -2690,16 +2832,16 @@
These techniques all depend upon the XML format used by FindBugs for storing warnings.
These XML files usually contain just the warnings from one particular analysis run, but
they can also store the results from analyzing a sequence of software builds or versions.
- </para>
+ </para>
<para>
-Any FindBugs XML bug database contains a version name and timestamp.
+Any FindBugs XML bug database contains a version name and timestamp.
FindBugs tries to compute a timestamp from the timestamps of the files that
are analyzed (e.g., the timestamp is intended to be the time the class files
were generated, not analyzed). Each bug database also contains a version name.
-Both the version name and timestamp can be set manually using the
+Both the version name and timestamp can be set manually using the
<command>setBugDatabaseInfo</command> (<xref linkend="setBugDatabaseInfo" />) command.
- </para>
+ </para>
<para>A multiversion bug database assigns a sequence number to each version of
the analyzed code. These sequence numbers are simply successive integers,
@@ -2732,10 +2874,10 @@
]]>
</programlisting>
- <sect1 id="commands">
- <title>Commands</title>
-
- <para>
+ <sect1 id="commands">
+ <title>Commands</title>
+
+ <para>
All tools for FindBugs data mining are can be invoked from the command line,
and some of the more useful tools can also be invoked from an
ant build file.</para>
@@ -2743,89 +2885,89 @@
<para>
Briefly, the command-line tools are:</para>
- <variablelist>
- <varlistentry>
- <term><command><link linkend="unionBugs">unionBugs</link></command></term>
- <listitem>
- <para>
- combine the results from separate analysis of disjoint
- classes
- </para>
- </listitem>
- </varlistentry>
- <varlistentry>
- <term><command><link linkend="computeBugHistory">computeBugHistory</link></command></term>
- <listitem>
- <para>Merge bug warnings from multiple versions of
- analyzed code into
- a single multiversion bug database. This can either be used
- to add more versions to an existing multiversion database,
- or to create a multiversion database from a sequence of single version
- bug warning databases.</para>
- </listitem>
- </varlistentry>
- <varlistentry>
- <term><command><link linkend="setBugDatabaseInfo">setBugDatabaseInfo</link></command></term>
- <listitem>
- <para>Set information such as the revision name or
+ <variablelist>
+ <varlistentry>
+ <term><command><link linkend="unionBugs">unionBugs</link></command></term>
+ <listitem>
+ <para>
+ combine the results from separate analysis of disjoint
+ classes
+ </para>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><command><link linkend="computeBugHistory">computeBugHistory</link></command></term>
+ <listitem>
+ <para>Merge bug warnings from multiple versions of
+ analyzed code into
+ a single multiversion bug database. This can either be used
+ to add more versions to an existing multiversion database,
+ or to create a multiversion database from a sequence of single version
+ bug warning databases.</para>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><command><link linkend="setBugDatabaseInfo">setBugDatabaseInfo</link></command></term>
+ <listitem>
+ <para>Set information such as the revision name or
timestamp in an XML bug database</para>
- </listitem>
- </varlistentry>
- <varlistentry>
- <term><command><link linkend="listBugDatabaseInfo">listBugDatabaseInfo</link></command></term>
- <listitem>
- <para>List information such as the revision name and
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><command><link linkend="listBugDatabaseInfo">listBugDatabaseInfo</link></command></term>
+ <listitem>
+ <para>List information such as the revision name and
timestamp for a list of XML bug databases</para>
- </listitem>
- </varlistentry>
- <varlistentry>
- <term><command><link linkend="filterBugs">filterBugs</link></command></term>
- <listitem>
- <para>Select a subset of a bug database</para>
- </listitem>
- </varlistentry>
- <varlistentry>
- <term><command><link linkend="mineBugHistory">mineBugHistory</link></command></term>
- <listitem>
- <para>Generate a tabular listing of the number of warnings in each
- version of a multiversion bug database</para>
- </listitem>
- </varlistentry>
- <varlistentry>
- <term><command><link linkend="defectDensity">defectDensity</link></command></term>
- <listitem>
- <para>List information about defect density
- (warnings per 1000 NCSS)
- for the entire project and each class and package</para>
- </listitem>
- </varlistentry>
- <varlistentry>
- <term><command><link linkend="convertXmlToText">convertXmlToText</link></command></term>
- <listitem>
- <para>Convert bug warnings in XML format to
- a textual one-line-per-bug format, or to HTML</para>
- </listitem>
- </varlistentry>
- </variablelist>
-
-
- <sect2 id="unionBugs">
- <title>unionBugs</title>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><command><link linkend="filterBugs">filterBugs</link></command></term>
+ <listitem>
+ <para>Select a subset of a bug database</para>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><command><link linkend="mineBugHistory">mineBugHistory</link></command></term>
+ <listitem>
+ <para>Generate a tabular listing of the number of warnings in each
+ version of a multiversion bug database</para>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><command><link linkend="defectDensity">defectDensity</link></command></term>
+ <listitem>
+ <para>List information about defect density
+ (warnings per 1000 NCSS)
+ for the entire project and each class and package</para>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><command><link linkend="convertXmlToText">convertXmlToText</link></command></term>
+ <listitem>
+ <para>Convert bug warnings in XML format to
+ a textual one-line-per-bug format, or to HTML</para>
+ </listitem>
+ </varlistentry>
+ </variablelist>
- <para>
- If you have, for example, separately analyzing each jar file used in an application,
- you can use this command to combine the separately generated xml bug warning files into
- a single file containing all of the warnings.</para>
- <para>Do <emphasis>not</emphasis> use this command to combine results from analyzing different versions of the same
- file; use <command>computeBugHistory</command> instead.</para>
+ <sect2 id="unionBugs">
+ <title>unionBugs</title>
- <para>Specify the xml files on the command line. The result is sent to standard output.</para>
- </sect2>
+ <para>
+ If you have, for example, separately analyzing each jar file used in an application,
+ you can use this command to combine the separately generated xml bug warning files into
+ a single file containing all of the warnings.</para>
- <sect2 id="computeBugHistory">
- <title>computeBugHistory</title>
-
+ <para>Do <emphasis>not</emphasis> use this command to combine results from analyzing different versions of the same
+ file; use <command>computeBugHistory</command> instead.</para>
+
+ <para>Specify the xml files on the command line. The result is sent to standard output.</para>
+ </sect2>
+
+ <sect2 id="computeBugHistory">
+ <title>computeBugHistory</title>
+
<para>Use this command to generate a bug database containing information from different builds or versions
of software you are analyzing.
History is taken from the first file provided as input; any following
@@ -2861,17 +3003,17 @@
]]>
</programlisting>
- <table id="computeBugHistoryTable">
- <title>Options for computeBugHistory command</title>
- <tgroup cols="3" align="left">
- <thead>
- <row>
- <entry>Command-line option</entry>
- <entry>Ant attribute</entry>
- <entry>Meaning</entry>
- </row>
- </thead>
- <tbody>
+ <table id="computeBugHistoryTable">
+ <title>Options for computeBugHistory command</title>
+ <tgroup cols="3" align="left">
+ <thead>
+ <row>
+ <entry>Command-line option</entry>
+ <entry>Ant attribute</entry>
+ <entry>Meaning</entry>
+ </row>
+ </thead>
+ <tbody>
<row><entry>-output <file></entry> <entry>output="<file>"</entry> <entry>save output in the named file (may also be an input file)</entry></row>
<row><entry>-overrideRevisionNames[:truth]</entry> <entry>overrideRevisionNames="[true|false]"</entry><entry>override revision names for each version with names computed from the filenames</entry></row>
<row><entry>-noPackageMoves[:truth]</entry> <entry>noPackageMoves="[true|false]"</entry><entry>if a class has moved to another package, treat warnings in that class as seperate</entry></row>
@@ -2879,13 +3021,13 @@
<row><entry>-precisePriorityMatch[:truth]</entry> <entry>precisePriorityMatch="[true|false]"</entry><entry>consider two warnings as the same only if priorities match exactly</entry></row>
<row><entry>-quiet[:truth]</entry> <entry>quiet="[true|false]"</entry><entry>don't generate any output to standard out unless there is an error</entry></row>
<row><entry>-withMessages[:truth]</entry> <entry>withMessages="[true|false]"</entry><entry>include human-readable messages describing the warnings in XML output</entry></row>
- </tbody>
- </tgroup>
- </table>
+ </tbody>
+ </tgroup>
+ </table>
- </sect2>
- <sect2 id="filterBugs">
- <title>filterBugs</title>
+ </sect2>
+ <sect2 id="filterBugs">
+ <title>filterBugs</title>
<para>This command is used to select a subset of warnings from a FindBugs XML warning file
and write the selected subset to a new FindBugs warning file.</para>
<para>
@@ -2923,17 +3065,17 @@
]]>
</programlisting>
- <table id="filterOptionsTable">
- <title>Options for filterBugs command</title>
- <tgroup cols="3" align="left">
- <thead>
- <row>
- <entry>Command-line option</entry>
- <entry>Ant attribute</entry>
- <entry>Meaning</entry>
- </row>
- </thead>
- <tbody>
+ <table id="filterOptionsTable">
+ <title>Options for filterBugs command</title>
+ <tgroup cols="3" align="left">
+ <thead>
+ <row>
+ <entry>Command-line option</entry>
+ <entry>Ant attribute</entry>
+ <entry>Meaning</entry>
+ </row>
+ </thead>
+ <tbody>
<row><entry></entry> <entry>input="<file>"</entry> <entry>use file as input</entry></row>
<row><entry></entry> <entry>output="<file>"</entry> <entry>output results to file</entry></row>
<row><entry>-not</entry> <entry>not="[true|false]"</entry> <entry>reverse (all) switches for the filter</entry></row>
@@ -2954,19 +3096,20 @@
<row><entry>-newCode[:truth]</entry> <entry>newCode="[true|false]"</entry> <entry>allow only warnings introduced by the addition of a new class</entry></row>
<row><entry>-removedCode[:truth]</entry> <entry>removedCode="[true|false]"</entry> <entry>allow only warnings removed by removal of a class</entry></row>
<row><entry>-priority <level></entry> <entry>priority="<level>"</entry> <entry>allow only warnings with this priority or higher</entry></row>
+<row><entry>-maxRank <rank></entry> <entry>rank="[1..20]"</entry> <entry>allow only warnings with this rank or lower</entry></row>
<row><entry>-class <pattern></entry> <entry>class="<class>"</entry> <entry>allow only bugs whose primary class name matches this pattern</entry></row>
<row><entry>-bugPattern <pattern></entry> <entry>bugPattern="<pattern>"</entry> <entry>allow only bugs whose type matches this pattern</entry></row>
<row><entry>-category <category></entry> <entry>category="<category>"</entry> <entry>allow only warnings with a category that starts with this string</entry></row>
<row><entry>-designation <designation></entry> <entry>designation="<designation>"</entry> <entry>allow only warnings with this designation (e.g., -designation SHOULD_FIX)</entry></row>
<row><entry>-withMessages[:truth] </entry> <entry>withMessages="[true|false]"</entry> <entry>the generated XML should contain textual messages</entry></row>
- </tbody>
- </tgroup>
- </table>
-
- </sect2>
-
- <sect2 id="mineBugHistory">
- <title>mineBugHistory</title>
+ </tbody>
+ </tgroup>
+ </table>
+
+ </sect2>
+
+ <sect2 id="mineBugHistory">
+ <title>mineBugHistory</title>
<para>This command generates a table containing counts of the numbers of warnings
in each version of a multiversion bug database.</para>
@@ -2998,66 +3141,66 @@
]]>
</programlisting>
- <table id="mineBugHistoryOptionsTable">
- <title>Options for mineBugHistory command</title>
- <tgroup cols="3" align="left">
- <thead>
- <row>
- <entry>Command-line option</entry>
- <entry>Ant attribute</entry>
- <entry>Meaning</entry>
- </row>
- </thead>
- <tbody>
+ <table id="mineBugHistoryOptionsTable">
+ <title>Options for mineBugHistory command</title>
+ <tgroup cols="3" align="left">
+ <thead>
+ <row>
+ <entry>Command-line option</entry>
+ <entry>Ant attribute</entry>
+ <entry>Meaning</entry>
+ </row>
+ </thead>
+ <tbody>
<row><entry></entry> <entry>input="<file>"</entry> <entry>use file as input</entry></row>
<row><entry></entry> <entry>output="<file>"</entry> <entry>write output to file</entry></row>
<row><entry>-formatDates</entry> <entry>formatDates="[true|false]"</entry> <entry>render dates in textual form</entry></row>
<row><entry>-noTabs</entry> <entry>noTabs="[true|false]"</entry> <entry>delimit columns with groups of spaces instead of tabs (see below)</entry></row>
<row><entry>-summary</entry> <entry>summary="[true|false]"</entry> <entry>output terse summary of changes over the last ten entries</entry></row>
- </tbody>
- </tgroup>
- </table>
+ </tbody>
+ </tgroup>
+ </table>
- <para>
- The <option>-noTabs</option> output can be easier to read from a shell
- with a fixed-width font.
- Because numeric columns are right-justified, spaces may precede the
- first column value. This option also causes <option>-formatDates</option>
- to render dates in terser format without embedded whitespace.
- </para>
+ <para>
+ The <option>-noTabs</option> output can be easier to read from a shell
+ with a fixed-width font.
+ Because numeric columns are right-justified, spaces may precede the
+ first column value. This option also causes <option>-formatDates</option>
+ to render dates in terser format without embedded whitespace.
+ </para>
- <para>The table is a tab-separated (barring <option>-noTabs</option>)
- table with the following columns:</para>
+ <para>The table is a tab-separated (barring <option>-noTabs</option>)
+ table with the following columns:</para>
- <table id="mineBugHistoryColumns">
- <title>Columns in mineBugHistory output</title>
- <tgroup cols="2" align="left">
- <thead>
- <row>
- <entry>Title</entry>
- <entry>Meaning</entry>
- </row>
- </thead>
- <tbody>
- <row><entry>seq</entry><entry>Sequence number (successive integers, starting at 0)</entry></row>
- <row><entry>version</entry><entry>Version name</entry></row>
- <row><entry>time</entry><entry>Release timestamp</entry></row>
- <row><entry>classes</entry><entry>Number of classes analyzed</entry></row>
- <row><entry>NCSS</entry><entry>Non Commenting Source Statements</entry></row>
- <row><entry>added</entry><entry>Count of new warnings for a class that existed in the previous version</entry></row>
- <row><entry>newCode</entry><entry>Count of new warnings for a class that did not exist in the previous version</entry></row>
- <row><entry>fixed</entry><entry>Count of warnings removed from a class that remains in the current version</entry></row>
- <row><entry>removed</entry><entry>Count of warnings in the previous version for a class that is not present in the current version</entry></row>
- <row><entry>retained</entry><entry>Count of warnings that were in both the previous and current version</entry></row>
- <row><entry>dead</entry><entry>Warnings that were present in earlier versions but in neither the current version or the immediately preceeding version</entry></row>
- <row><entry>active</entry><entry>Total warnings present in the current version</entry></row>
- </tbody>
- </tgroup>
- </table>
- </sect2>
-
- <sect2 id="defectDensity">
- <title>defectDensity</title>
+ <table id="mineBugHistoryColumns">
+ <title>Columns in mineBugHistory output</title>
+ <tgroup cols="2" align="left">
+ <thead>
+ <row>
+ <entry>Title</entry>
+ <entry>Meaning</entry>
+ </row>
+ </thead>
+ <tbody>
+ <row><entry>seq</entry><entry>Sequence number (successive integers, starting at 0)</entry></row>
+ <row><entry>version</entry><entry>Version name</entry></row>
+ <row><entry>time</entry><entry>Release timestamp</entry></row>
+ <row><entry>classes</entry><entry>Number of classes analyzed</entry></row>
+ <row><entry>NCSS</entry><entry>Non Commenting Source Statements</entry></row>
+ <row><entry>added</entry><entry>Count of new warnings for a class that existed in the previous version</entry></row>
+ <row><entry>newCode</entry><entry>Count of new warnings for a class that did not exist in the previous version</entry></row>
+ <row><entry>fixed</entry><entry>Count of warnings removed from a class that remains in the current version</entry></row>
+ <row><entry>removed</entry><entry>Count of warnings in the previous version for a class that is not present in the current version</entry></row>
+ <row><entry>retained</entry><entry>Count of warnings that were in both the previous and current version</entry></row>
+ <row><entry>dead</entry><entry>Warnings that were present in earlier versions but in neither the current version or the immediately preceeding version</entry></row>
+ <row><entry>active</entry><entry>Total warnings present in the current version</entry></row>
+ </tbody>
+ </tgroup>
+ </table>
+ </sect2>
+
+ <sect2 id="defectDensity">
+ <title>defectDensity</title>
<para>
This command lists information about defect density (warnings per 1000 NCSS) for the entire project and each class and package.
It can either be invoked with no files specified on the command line (in which case it reads from standard input)
@@ -3065,33 +3208,33 @@
<para>It generates a table with the following columns, and with one
row for the entire project, and one row for each package or class that contains at least
4 warnings.</para>
- <table id="defectDensityColumns">
- <title>Columns in defectDensity output</title>
- <tgroup cols="2" align="left">
- <thead>
- <row>
- <entry>Title</entry>
- <entry>Meaning</entry>
- </row>
- </thead>
- <tbody>
- <row><entry>kind</entry><entry>project, package or class</entry></row>
- <row><entry>name</entry><entry>The name of the project, package or class</entry></row>
- <row><entry>density</entry><entry>Number of warnings generated per 1000 lines of NCSS.</entry></row>
- <row><entry>bugs</entry><entry>Number of warnings</entry></row>
- <row><entry>NCSS</entry><entry>Calculated number of NCSS</entry></row>
- </tbody>
- </tgroup>
- </table>
- </sect2>
-
- <sect2 id="convertXmlToText">
- <title>convertXmlToText</title>
-
- <para>
- This command converts a warning collection in XML format to a text
- format with one line per warning, or to HTML.
- </para>
+ <table id="defectDensityColumns">
+ <title>Columns in defectDensity output</title>
+ <tgroup cols="2" align="left">
+ <thead>
+ <row>
+ <entry>Title</entry>
+ <entry>Meaning</entry>
+ </row>
+ </thead>
+ <tbody>
+ <row><entry>kind</entry><entry>project, package or class</entry></row>
+ <row><entry>name</entry><entry>The name of the project, package or class</entry></row>
+ <row><entry>density</entry><entry>Number of warnings generated per 1000 lines of NCSS.</entry></row>
+ <row><entry>bugs</entry><entry>Number of warnings</entry></row>
+ <row><entry>NCSS</entry><entry>Calculated number of NCSS</entry></row>
+ </tbody>
+ </tgroup>
+ </table>
+ </sect2>
+
+ <sect2 id="convertXmlToText">
+ <title>convertXmlToText</title>
+
+ <para>
+ This command converts a warning collection in XML format to a text
+ format with one line per warning, or to HTML.
+ </para>
<para>This functionality may also can be accessed from ant.
First create a taskdef for <command>convertXmlToText</command> in your
@@ -3107,45 +3250,45 @@
</programlisting>
<para>Attributes for this ant task are listed in the following table.</para>
-
- <table id="convertXmlToTextTable">
- <title>Options for convertXmlToText command</title>
- <tgroup cols="3" align="left">
- <thead>
- <row>
- <entry>Command-line option</entry>
- <entry>Ant attribute</entry>
- <entry>Meaning</entry>
- </row>
- </thead>
- <tbody>
+
+ <table id="convertXmlToTextTable">
+ <title>Options for convertXmlToText command</title>
+ <tgroup cols="3" align="left">
+ <thead>
+ <row>
+ <entry>Command-line option</entry>
+ <entry>Ant attribute</entry>
+ <entry>Meaning</entry>
+ </row>
+ </thead>
+ <tbody>
<row><entry></entry> <entry>input="<filename>"</entry> <entry>use file as input</entry></row>
<row><entry></entry> <entry>output="<filename>"</entry> <entry>output results to file</entry></row>
<row><entry>-longBugCodes</entry> <entry>longBugCodes="[true|false]"</entry> <entry>use the full bug pattern code instead of two-letter abbreviation</entry></row>
<row><entry></entry> <entry>format="text"</entry> <entry>generate plain text output with one bug per line (command-line default)</entry></row>
<row><entry>-html[:stylesheet]</entry> <entry>format="html:<stylesheet>"</entry> <entry>generate output with specified stylesheet (see below), or default.xsl if unspecified</entry></row>
- </tbody>
- </tgroup>
- </table>
-
- <para>
- You may specify plain.xsl, default.xsl, fancy.xsl, fancy-hist.xsl,
- or your own XSL stylesheet for the -html/format option.
- Despite the name of this option, you may specify
- a stylesheet that emits something other than html.
- When applying a stylesheet other than those included
- with FindBugs (listed above), the -html/format option should be used
- with a path or URL to the stylesheet.
- </para>
- </sect2>
-
- <sect2 id="setBugDatabaseInfo">
- <title>setBugDatabaseInfo</title>
-
- <para>
- This command sets meta-information in a specified warning collection.
- It takes the following options:
- </para>
+ </tbody>
+ </tgroup>
+ </table>
+
+ <para>
+ You may specify plain.xsl, default.xsl, fancy.xsl, fancy-hist.xsl,
+ or your own XSL stylesheet for the -html/format option.
+ Despite the name of this option, you may specify
+ a stylesheet that emits something other than html.
+ When applying a stylesheet other than those included
+ with FindBugs (listed above), the -html/format option should be used
+ with a path or URL to the stylesheet.
+ </para>
+ </sect2>
+
+ <sect2 id="setBugDatabaseInfo">
+ <title>setBugDatabaseInfo</title>
+
+ <para>
+ This command sets meta-information in a specified warning collection.
+ It takes the following options:
+ </para>
<para>This functionality may also can be accessed from ant.
First create a taskdef for <command>setBugDatabaseInfo</command> in your
@@ -3174,80 +3317,80 @@
]]>
</programlisting>
- <table id="setBugDatabaseInfoOptions">
- <title>setBugDatabaseInfo Options</title>
- <tgroup cols="3" align="left">
- <thead>
- <row>
- <entry>Command-line option</entry>
- <entry>Ant attribute</entry>
- <entry>Meaning</entry>
- </row>
- </thead>
- <tbody>
- <row><entry></entry> <entry>input="<file>"</entry> <entry>use file as input</entry></row>
- <row><entry></entry> <entry>output="<file>"</entry> <entry>write output to file</entry></row>
- <row><entry>-name <name></entry> <entry>name="<name>"</entry> <entry>set name for (last) revision</entry></row>
- <row><entry>-timestamp <when></entry> <entry>timestamp="<when>"</entry> <entry>set timestamp for (last) revision</entry></row>
- <row><entry>-source <directory></entry> <entry>source="<directory>"</entry> <entry>add specified directory to the source search path</entry></row>
- <row><entry>-findSource <directory></entry> <entry>findSource="<directory>"</entry> <entry>find and add all relevant source directions contained within specified directory</entry></row>
- <row><entry>-suppress <filter file></entry> <entry>suppress="<filter file>"</entry> <entry>suppress warnings matched by this file (replaces previous suppressions)</entry></row>
- <row><entry>-withMessages</entry> <entry>withMessages="[true|false]"</entry> <entry>add textual messages to XML</entry></row>
- <row><entry>-resetSource</entry> <entry>resetSource="[true|false]"</entry> <entry>remove all source search paths</entry></row>
- </tbody>
- </tgroup>
- </table>
- </sect2>
-
- <sect2 id="listBugDatabaseInfo">
- <title>listBugDatabaseInfo</title>
-
- <para>This command takes a list of zero or more xml bug database filenames on the command line.
+ <table id="setBugDatabaseInfoOptions">
+ <title>setBugDatabaseInfo Options</title>
+ <tgroup cols="3" align="left">
+ <thead>
+ <row>
+ <entry>Command-line option</entry>
+ <entry>Ant attribute</entry>
+ <entry>Meaning</entry>
+ </row>
+ </thead>
+ <tbody>
+ <row><entry></entry> <entry>input="<file>"</entry> <entry>use file as input</entry></row>
+ <row><entry></entry> <entry>output="<file>"</entry> <entry>write output to file</entry></row>
+ <row><entry>-name <name></entry> <entry>name="<name>"</entry> <entry>set name for (last) revision</entry></row>
+ <row><entry>-timestamp <when></entry> <entry>timestamp="<when>"</entry> <entry>set timestamp for (last) revision</entry></row>
+ <row><entry>-source <directory></entry> <entry>source="<directory>"</entry> <entry>add specified directory to the source search path</entry></row>
+ <row><entry>-findSource <directory></entry> <entry>findSource="<directory>"</entry> <entry>find and add all relevant source directions contained within specified directory</entry></row>
+ <row><entry>-suppress <filter file></entry> <entry>suppress="<filter file>"</entry> <entry>suppress warnings matched by this file (replaces previous suppressions)</entry></row>
+ <row><entry>-withMessages</entry> <entry>withMessages="[true|false]"</entry> <entry>add textual messages to XML</entry></row>
+ <row><entry>-resetSource</entry> <entry>resetSource="[true|false]"</entry> <entry>remove all source search paths</entry></row>
+ </tbody>
+ </tgroup>
+ </table>
+ </sect2>
+
+ <sect2 id="listBugDatabaseInfo">
+ <title>listBugDatabaseInfo</title>
+
+ <para>This command takes a list of zero or more xml bug database filenames on the command line.
If zero file names are provided, it reads from standard input and does not generate
a table header.</para>
<para>There is only one option: <option>-formatDates</option> renders dates
- in textual form.
- </para>
-
-<para>The output is a table one row per bug database and the following columns:</para>
- <table id="listBugDatabaseInfoColumns">
- <title>listBugDatabaseInfo Columns</title>
- <tgroup cols="2" align="left">
- <thead>
- <row>
- <entry>Column</entry>
- <entry>Meaning</entry>
- </row>
- </thead>
- <tbody>
- <row><entry>version</entry><entry>version name</entry></row>
- <row><entry>time</entry><entry>Release timestamp</entry></row>
- <row><entry>classes</entry><entry>Number of classes analyzed</entry></row>
- <row><entry>NCSS</entry><entry>Non Commenting Source Statements analyzed</entry></row>
- <row><entry>total</entry><entry>Total number of warnings of all kinds</entry></row>
- <row><entry>high</entry><entry>Total number of high priority warnings of all kinds</entry></row>
- <row><entry>medium</entry><entry>Total number of medium/normal priority warnings of all kinds</entry></row>
- <row><entry>low</entry><entry>Total number of low priority warnings of all kinds</entry></row>
- <row><entry>filename</entry><entry>filename of database</entry></row>
-<!--
- <row><entry></entry><entry></entry></row>
- <row><entry></entry><entry></entry></row>
- <row><entry></entry><entry></entry></row>
- <row><entry></entry><entry></entry></row>
- <row><entry></entry><entry></entry></row>
- <row><entry></entry><entry></entry></row>
--->
- </tbody>
- </tgroup>
- </table>
-
- </sect2>
+ in textual form.
+ </para>
- </sect1>
-
- <sect1 id="examples">
- <title>Examples</title>
+<para>The output is a table one row per bug database and the following columns:</para>
+ <table id="listBugDatabaseInfoColumns">
+ <title>listBugDatabaseInfo Columns</title>
+ <tgroup cols="2" align="left">
+ <thead>
+ <row>
+ <entry>Column</entry>
+ <entry>Meaning</entry>
+ </row>
+ </thead>
+ <tbody>
+ <row><entry>version</entry><entry>version name</entry></row>
+ <row><entry>time</entry><entry>Release timestamp</entry></row>
+ <row><entry>classes</entry><entry>Number of classes analyzed</entry></row>
+ <row><entry>NCSS</entry><entry>Non Commenting Source Statements analyzed</entry></row>
+ <row><entry>total</entry><entry>Total number of warnings of all kinds</entry></row>
+ <row><entry>high</entry><entry>Total number of high priority warnings of all kinds</entry></row>
+ <row><entry>medium</entry><entry>Total number of medium/normal priority warnings of all kinds</entry></row>
+ <row><entry>low</entry><entry>Total number of low priority warnings of all kinds</entry></row>
+ <row><entry>filename</entry><entry>filename of database</entry></row>
+<!--
+ <row><entry></entry><entry></entry></row>
+ <row><entry></entry><entry></entry></row>
+ <row><entry></entry><entry></entry></row>
+ <row><entry></entry><entry></entry></row>
+ <row><entry></entry><entry></entry></row>
+ <row><entry></entry><entry></entry></row>
+-->
+ </tbody>
+ </tgroup>
+ </table>
+
+ </sect2>
+
+ </sect1>
+
+ <sect1 id="examples">
+ <title>Examples</title>
<sect2 id="unixscriptsexamples">
<title>Mining history using proveded shell scrips</title>
<para>In all of the following, the commands are given in a directory that contains
@@ -3258,7 +3401,7 @@
computeBugHistory jdk1.6.0-b* | filterBugs -bugPattern IL_ | mineBugHistory -formatDates
</screen>
<para>to generate the following output:</para>
-
+
<screen>
seq version time classes NCSS added newCode fixed removed retained dead active
0 jdk1.6.0-b12 "Thu Nov 11 09:07:20 EST 2004" 13128 811569 0 4 0 0 0 0 4
@@ -3320,9 +3463,9 @@
recursive loops in that build, the red area above it indicates the number of infinite recursive loops that existed
in some previous version but not in the current version (thus, the combined height of the red and blue areas
is guaranteed to never decrease, and goes up whenever a new infinite recursive loop bug is introduced). The height
-of the red area is computed as the sum of the fixed, removed and dead values for each version.
+of the red area is computed as the sum of the fixed, removed and dead values for each version.
The reductions in builds 13 and 14 came after Sun was notified about the bugs found by FindBugs in the JDK.
- </para>
+ </para>
<mediaobject>
<imageobject>
<imagedata fileref="infiniteRecursiveLoops.png" />
@@ -3392,7 +3535,7 @@
</sect2>
<sect2 id="incrementalhistory">
- <title>Incremental history maintenance</title>
+ <title>Incremental history maintenance</title>
<para>
If db.xml contains the results of running findbugs over builds b12 - b60, we can update db.xml to include the results of analyzing b61 with the commands:
@@ -3401,9 +3544,9 @@
computeBugHistory -output db.xml db.xml jdk1.6.0-b61/jre/lib/rt.xml
</screen>
</sect2>
-
- </sect1>
-
+
+ </sect1>
+
<sect1 id="antexample">
<title>Ant example</title>
<para>
@@ -3416,12 +3559,12 @@
<property name="findbugs.home" value="/Users/ben/Documents/workspace/findbugs/findbugs" />
<property name="jvmargs" value="-server -Xss1m -Xmx800m -Duser.language=en -Duser.region=EN -Dfindbugs.home=${findbugs.home}" />
- <path id="findbugs.lib">
+ <path id="findbugs.lib">
<fileset dir="${findbugs.home}/lib">
<include name="findbugs-ant.jar"/>
</fileset>
</path>
-
+
<taskdef name="findbugs" classname="edu.umd.cs.findbugs.anttask.FindBugsTask">
<classpath refid="findbugs.lib" />
</taskdef>
@@ -3467,10 +3610,10 @@
<!-- Set info to the latest analysis -->
<setBugDatabaseInfo home="${findbugs.home}"
- withMessages="true"
- name="asm-util-3.0.jar"
- input="out.xml"
- output="out-rel.xml"/>
+ withMessages="true"
+ name="asm-util-3.0.jar"
+ input="out.xml"
+ output="out-rel.xml"/>
<!-- Checking if history file already exists (out-hist.xml) -->
<condition property="mining.historyfile.available">
@@ -3504,18 +3647,18 @@
<target name="history" if="mining.historyfile.available">
<!-- Merging ${data.file} into ${hist.file} -->
<computeBugHistory home="${findbugs.home}"
- withMessages="true"
- output="${hist.file}">
- <dataFile name="${hist.file}"/>
- <dataFile name="${data.file}"/>
+ withMessages="true"
+ output="${hist.file}">
+ <dataFile name="${hist.file}"/>
+ <dataFile name="${data.file}"/>
</computeBugHistory>
<!-- Compute history into ${hist.summary.file} -->
<mineBugHistory home="${findbugs.home}"
- formatDates="true"
+ formatDates="true"
noTabs="true"
- input="${hist.file}"
- output="${hist.summary.file}"/>
+ input="${hist.file}"
+ output="${hist.summary.file}"/>
</target>
</project>
@@ -3636,42 +3779,42 @@
<para>Greg Bentz provided a fix for the hashcode/equals detector.</para>
<para>K. Hashimoto contributed internationalization fixes and several other
- bug fixes.</para>
+ bug fixes.</para>
<para>
- Glenn Boysko contributed support for ignoring specified local
- variables in the dead local store detector.
-</para>
-
-<para>
- Jay Dunning contributed a detector to find equality comparisons
- of floating-point values, and overhauled the analysis summary
- report and its representation in the saved XML format.
+ Glenn Boysko contributed support for ignoring specified local
+ variables in the dead local store detector.
</para>
<para>
- Olivier Parent contributed updated French translations for bug descriptions and
- Swing GUI.
+ Jay Dunning contributed a detector to find equality comparisons
+ of floating-point values, and overhauled the analysis summary
+ report and its representation in the saved XML format.
</para>
<para>
- Chris Nappin contributed the <filename>plain.xsl</filename>
- stylesheet.
+ Olivier Parent contributed updated French translations for bug descriptions and
+ Swing GUI.
</para>
<para>
- Etienne Giraudy contributed the <filename>fancy.xsl</filename> and <filename>fancy-hist.xsl</filename>
- stylesheets, and made improvements to the <command>-xml:withMessages</command>
- option.
+ Chris Nappin contributed the <filename>plain.xsl</filename>
+ stylesheet.
</para>
-
+
<para>
- Takashi Okamoto fixed bugs in the project preferences dialog
- in the Eclipse plugin, and contributed to its internationalization and localization.
+ Etienne Giraudy contributed the <filename>fancy.xsl</filename> and <filename>fancy-hist.xsl</filename>
+ stylesheets, and made improvements to the <command>-xml:withMessages</command>
+ option.
</para>
-
+
+<para>
+ Takashi Okamoto fixed bugs in the project preferences dialog
+ in the Eclipse plugin, and contributed to its internationalization and localization.
+</para>
+
<para>Thomas Einwaller fixed bugs in the project preferences dialog in the Eclipse plugin.</para>
-
+
<para>Jeff Knox contributed support for the warningsProperty attribute
in the Ant task.</para>
@@ -3680,7 +3823,7 @@
<para>Mark McKay contributed an Ant task to launch the findbugs frame.</para>
-<para>Dieter von Holten (dvholten) contributed
+<para>Dieter von Holten (dvholten) contributed
some German improvements to findbugs_de.properties.</para>
@@ -3761,7 +3904,7 @@
<blockquote>
<para>
-Copyright 2001 (C) MetaStuff, Ltd. All Rights Reserved.
+Copyright 2001 (C) MetaStuff, Ltd. All Rights Reserved.
</para>
<para>
diff --git a/tools/findbugs-1.3.9/doc/manual.xsl b/tools/findbugs/doc/manual.xsl
similarity index 86%
rename from tools/findbugs-1.3.9/doc/manual.xsl
rename to tools/findbugs/doc/manual.xsl
index 8d3ca2c..1b47067 100644
--- a/tools/findbugs-1.3.9/doc/manual.xsl
+++ b/tools/findbugs/doc/manual.xsl
@@ -5,14 +5,14 @@
exclude-result-prefixes="#default">
<!-- build.xml will substitute the real path to chunk.xsl here. -->
-<xsl:import href="/fs/pugh/pugh/docbook-xsl-1.71.1/html/chunk.xsl"/>
+<xsl:import href="/Users/msamuel/work/findbugs-read-only/software-home/docbook-xsl-1.76.1/html/chunk.xsl"/>
<xsl:template name="user.header.content">
</xsl:template>
<!-- This causes the stylesheet to put chapters in a single HTML file,
- rather than putting individual sections into seperate files. -->
+ rather than putting individual sections into separate files. -->
<xsl:variable name="chunk.section.depth">0</xsl:variable>
<!-- Put the HTML in the "manual" directory. -->
diff --git a/tools/findbugs-1.3.9/doc/manual/example-code.png b/tools/findbugs/doc/manual/example-code.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/manual/example-code.png
rename to tools/findbugs/doc/manual/example-code.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/manual/example-details.png b/tools/findbugs/doc/manual/example-details.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/manual/example-details.png
rename to tools/findbugs/doc/manual/example-details.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/manual/example.png b/tools/findbugs/doc/manual/example.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/manual/example.png
rename to tools/findbugs/doc/manual/example.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/manual/important.png b/tools/findbugs/doc/manual/important.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/manual/important.png
rename to tools/findbugs/doc/manual/important.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/manual/infiniteRecursiveLoops.png b/tools/findbugs/doc/manual/infiniteRecursiveLoops.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/manual/infiniteRecursiveLoops.png
rename to tools/findbugs/doc/manual/infiniteRecursiveLoops.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/manual/note.png b/tools/findbugs/doc/manual/note.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/manual/note.png
rename to tools/findbugs/doc/manual/note.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/manual/project-dialog.png b/tools/findbugs/doc/manual/project-dialog.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/manual/project-dialog.png
rename to tools/findbugs/doc/manual/project-dialog.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/manual/warning.png b/tools/findbugs/doc/manual/warning.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/manual/warning.png
rename to tools/findbugs/doc/manual/warning.png
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/manual_ja.xml b/tools/findbugs/doc/manual_ja.xml
similarity index 80%
rename from tools/findbugs-1.3.9/doc/manual_ja.xml
rename to tools/findbugs/doc/manual_ja.xml
index 33aada0..2c68e0f 100644
--- a/tools/findbugs-1.3.9/doc/manual_ja.xml
+++ b/tools/findbugs/doc/manual_ja.xml
@@ -9,7 +9,7 @@
<!ENTITY nbsp " ">
]>
<book lang="ja" id="findbugs-manual">
-
+
<bookinfo>
<title>&FindBugs;™ マニュアル</title>
@@ -19,11 +19,11 @@
<othername>H.</othername>
<surname>Hovemeyer</surname>
</author>
- <author>
- <firstname>William</firstname>
- <othername>W.</othername>
- <surname>Pugh</surname>
- </author>
+ <author>
+ <firstname>William</firstname>
+ <othername>W.</othername>
+ <surname>Pugh</surname>
+ </author>
</authorgroup>
<copyright>
@@ -40,9 +40,9 @@
<para>名称「FindBugs」および FindBugs のロゴは、メリーランド大学の登録商標です。</para>
</legalnotice>
-<edition>1.3.9</edition>
+<edition>2.0.2</edition>
-<pubdate>16:39:49 EDT, 21 August, 2009</pubdate>
+<pubdate>21:04:38 EST, 25 February, 2013</pubdate>
</bookinfo>
@@ -51,13 +51,13 @@
Introduction
**************************************************************************
-->
-
+
<chapter id="introduction">
<title>はじめに</title>
<para>&FindBugs;™ は、Java プログラムの中のバグを見つけるプログラムです。このプログラムは、「バグ パターン」の実例を探します。「バグ パターン」とは、エラーとなる可能性の高いコードの事例です。</para>
-<para>この文書は、&FindBugs; バージョン 1.3.9 について説明してます。私たちは、 &FindBugs; に対するフィードバックを心待ちにしています。どうぞ、 <ulink url="http://findbugs.sourceforge.net">&FindBugs; Web ページ</ulink> にアクセスしてください。&FindBugs; についての最新情報、連絡先および &FindBugs; メーリングリストなどのサポート情報を入手することができます。</para>
+<para>この文書は、&FindBugs; バージョン 2.0.2 について説明してます。私たちは、 &FindBugs; に対するフィードバックを心待ちにしています。どうぞ、 <ulink url="http://findbugs.sourceforge.net">&FindBugs; Web ページ</ulink> にアクセスしてください。&FindBugs; についての最新情報、連絡先および &FindBugs; メーリングリストなどのサポート情報を入手することができます。</para>
<sect1>
<title>必要条件</title>
@@ -65,7 +65,7 @@
<para>&FindBugs; を使用するためには、少なくとも 512 MB のメモリが必要です。巨大なプロジェクトを解析するためには、それより多くのメモリが必要とされることがあります。</para>
</sect1>
-
+
</chapter>
<!--
@@ -82,19 +82,19 @@
<sect1>
<title>配布物の展開</title>
-<para>&FindBugs; をインストールする最も簡単な方法は、バイナリ配布物をダウンロードすることです。 バイナリ配布物は、 <ulink url="http://prdownloads.sourceforge.net/findbugs/findbugs-1.3.9.tar.gz?download">gzipped tar 形式</ulink> および <ulink url="http://prdownloads.sourceforge.net/findbugs/findbugs-1.3.9.zip?download">zip 形式</ulink> がそれぞれ入手可能です。バイナリ配布物をダウンロードしてきたら、それを任意のディレクトリーに展開します。</para>
+<para>&FindBugs; をインストールする最も簡単な方法は、バイナリ配布物をダウンロードすることです。 バイナリ配布物は、 <ulink url="http://prdownloads.sourceforge.net/findbugs/findbugs-2.0.2.tar.gz?download">gzipped tar 形式</ulink> および <ulink url="http://prdownloads.sourceforge.net/findbugs/findbugs-2.0.2.zip?download">zip 形式</ulink> がそれぞれ入手可能です。バイナリ配布物をダウンロードしてきたら、それを任意のディレクトリーに展開します。</para>
<para>gzipped tar 形式配布物の展開方法例:<screen>
-<prompt>$ </prompt><command>gunzip -c findbugs-1.3.9.tar.gz | tar xvf -</command>
+<prompt>$ </prompt><command>gunzip -c findbugs-2.0.2.tar.gz | tar xvf -</command>
</screen>
</para>
<para>zip 形式配布物の展開方法例:<screen>
-<prompt>C:\Software></prompt><command>unzip findbugs-1.3.9.zip</command>
+<prompt>C:\Software></prompt><command>unzip findbugs-2.0.2.zip</command>
</screen>
</para>
-<para>バイナリ配布物の展開すると、通常は <filename class="directory">findbugs-1.3.9</filename> ディレクトリーが作成されます。例えば、ディレクトリー <filename class="directory">C:\Software</filename> でバイナリ配布物を展開すると、ディレクトリー <filename class="directory">C:\Software\findbugs-1.3.9</filename> に &FindBugs; は展開されます。このディレクトリーが &FindBugs; のホームディレクトリーになります。このマニュアルでは、このホームディレクトリーを &FBHome; (Windowsでは &FBHomeWin;) を用いて参照します。</para>
+<para>バイナリ配布物の展開すると、通常は <filename class="directory">findbugs-2.0.2</filename> ディレクトリーが作成されます。例えば、ディレクトリー <filename class="directory">C:\Software</filename> でバイナリ配布物を展開すると、ディレクトリー <filename class="directory">C:\Software\findbugs-2.0.2</filename> に &FindBugs; は展開されます。このディレクトリーが &FindBugs; のホームディレクトリーになります。このマニュアルでは、このホームディレクトリーを &FBHome; (Windowsでは &FBHomeWin;) を用いて参照します。</para>
</sect1>
</chapter>
@@ -115,7 +115,7 @@
<para>ソースから &FindBugs; をコンパイルするためには、以下のものが必要です。<itemizedlist>
<listitem>
- <para><ulink url="http://prdownloads.sourceforge.net/findbugs/findbugs-1.3.9-source.zip?download">&FindBugs; のソース配布物</ulink>
+ <para><ulink url="http://prdownloads.sourceforge.net/findbugs/findbugs-2.0.2-source.zip?download">&FindBugs; のソース配布物</ulink>
</para>
</listitem>
<listitem>
@@ -131,7 +131,7 @@
</para>
<warning>
- <para>Redhat Linux システムの <filename>/usr/bin/ant</filename> に同梱されている &Ant; のバージョンでは、 &FindBugs; のコンパイルは<emphasis>うまくできません</emphasis>。<ulink url="http://ant.apache.org/">&Ant; web サイト</ulink>からバイナリ配布物をダウンロードしてインストールすることを推奨します。&Ant; を実行する場合は、 環境変数 <replaceable>JAVA_HOME</replaceable> が JDK 1.5 (またはそれ以降)をインストールしたディレクトリーを指していることを確認してください。</para>
+ <para>Redhat Linux システムの <filename>/usr/bin/ant</filename> に同梱されている &Ant; のバージョンでは、 &FindBugs; のコンパイルは<emphasis>うまくできません</emphasis>。<ulink url="http://ant.apache.org/">&Ant; web サイト</ulink>からバイナリ配布物をダウンロードしてインストールすることを推奨します。&Ant; を実行する場合は、 環境変数 <replaceable>JAVA_HOME</replaceable> が JDK 1.5 (またはそれ以降)をインストールしたディレクトリーを指していることを確認してください。</para>
</warning>
<para>体裁の整った &FindBugs; のドキュメントを生成したい場合は、以下のソフトウェアも必要となります:<itemizedlist>
@@ -155,7 +155,7 @@
<sect1>
<title>ソース配布物の展開</title>
<para>ソース配布物をダウンロードした後に、それを作業用ディレクトリーに展開する必要があります。通常は、次のようなコマンドで展開を行います:<screen>
-<prompt>$ </prompt><command>unzip findbugs-1.3.9-source.zip</command>
+<prompt>$ </prompt><command>unzip findbugs-2.0.2-source.zip</command>
</screen>
</para>
@@ -164,7 +164,7 @@
<sect1>
<title><filename>local.properties</filename> の修正</title>
<para>FindBugs のドキュメントをビルドするためには、 <filename>local.properties</filename> ファイルを修正する必要があります。このファイルは、 &FindBugs; をビルドする際に <ulink url="http://ant.apache.org/">&Ant;</ulink> <filename>build.xml</filename> ファイルが参照します。FindBugs のドキュメントをビルドしない場合は、このファイルは無視してもかまいません。</para>
-
+
<para><filename>local.properties</filename> での定義は、 <filename>build.properties</filename> ファイルでの定義に優先します。<filename>build.properties</filename> は次のような内容です:<programlisting>
<![CDATA[
# User Configuration:
@@ -178,7 +178,7 @@
xsl.stylesheet.home =${local.software.home}/docbook/docbook-xsl-1.71.1
# Set this to the directory where Saxon (http://saxon.sourceforge.net/)
-# is installed.
+# is installed.
saxon.home =${local.software.home}/java/saxon-6.5.5
]]>
@@ -208,19 +208,19 @@
<para>このターゲットは、ドキュメントの整形を行います(また、副作用としていくつかのソースのコンパイルも行います。)</para>
</listitem>
</varlistentry>
-
+
<varlistentry>
- <term><command>runjunit</command></term>
- <listitem>
- <para>このターゲットは、コンパイルを行い &FindBugs; が持っている JUnit テストを実行します。ユニットテストが失敗した場合は、エラーメッセージが表示されます。</para>
- </listitem>
+ <term><command>runjunit</command></term>
+ <listitem>
+ <para>このターゲットは、コンパイルを行い &FindBugs; が持っている JUnit テストを実行します。ユニットテストが失敗した場合は、エラーメッセージが表示されます。</para>
+ </listitem>
</varlistentry>
-
+
<varlistentry>
- <term><command>bindist</command></term>
- <listitem>
- <para>&FindBugs; のバイナリ配布物を構築します。このターゲットは、 <filename>.zip</filename> および <filename>.tar.gz</filename> のアーカイブをそれぞれ作成します。</para>
- </listitem>
+ <term><command>bindist</command></term>
+ <listitem>
+ <para>&FindBugs; のバイナリ配布物を構築します。このターゲットは、 <filename>.zip</filename> および <filename>.tar.gz</filename> のアーカイブをそれぞれ作成します。</para>
+ </listitem>
</varlistentry>
</variablelist>
</para>
@@ -254,9 +254,9 @@
<para>&FindBugs; には2つのユーザーインタフェースがあります。すなわち、グラフィカルユーザーインタフェース (GUI) および コマンドラインインタフェースです。この章では、それぞれのインタフェースの実行方法について説明します。</para>
- <warning>
- <para>この章は、現在書き直し中です。書き直しはまだ完了していません。</para>
- </warning>
+ <warning>
+ <para>この章は、現在書き直し中です。書き直しはまだ完了していません。</para>
+ </warning>
<!--
<sect1>
@@ -265,115 +265,115 @@
-->
<sect1>
- <title>クイック・スタート</title>
- <para>Windows システムで &FindBugs; を起動する場合は、 <filename>&FBHomeWin;\lib\findbugs.jar</filename> ファイルをダブルクリックしてください。 &FindBugs; GUI が起動します。</para>
-
- <para>Unix 、 Linux または Mac OS X システムの場合は、<filename>&FBHome;/bin/findbugs</filename> スクリプトを実行するか、以下のコマンドを実行します。<screen>
+ <title>クイック・スタート</title>
+ <para>Windows システムで &FindBugs; を起動する場合は、 <filename>&FBHomeWin;\lib\findbugs.jar</filename> ファイルをダブルクリックしてください。 &FindBugs; GUI が起動します。</para>
+
+ <para>Unix 、 Linux または Mac OS X システムの場合は、<filename>&FBHome;/bin/findbugs</filename> スクリプトを実行するか、以下のコマンドを実行します。<screen>
<command>java -jar &FBHome;/lib/findbugs.jar</command></screen>これで、 &FindBugs; GUI が起動します。</para>
-
- <para>GUI の使用方法については、 <xref linkend="gui"/> を参照してください。</para>
+
+ <para>GUI の使用方法については、 <xref linkend="gui"/> を参照してください。</para>
</sect1>
<sect1>
-
- <title>&FindBugs; の起動</title>
- <para>このセクションでは、 &FindBugs; の起動方法を説明します。&FindBugs; を起動するには2つの方法があります。すなわち、直接起動する方法、および、ラップしているスクリプトを使用する方法です。</para>
+ <title>&FindBugs; の起動</title>
+
+ <para>このセクションでは、 &FindBugs; の起動方法を説明します。&FindBugs; を起動するには2つの方法があります。すなわち、直接起動する方法、および、ラップしているスクリプトを使用する方法です。</para>
- <sect2 id="directInvocation">
- <title>&FindBugs; の直接起動</title>
-
- <para>最初に述べる &FindBugs; の起動方法は、 <filename>&FBHome;/lib/findbugs.jar</filename> を直接実行する方法です。JVM (<command>java</command>) 実行プログラムの <command>-jar</command> コマンドラインスイッチを使用します。(&FindBugs;のバージョンが 1.3.5 より前の場合は、ラップしているスクリプトを使用する必要があります。)</para>
-
- <para>&FindBugs; を直接起動するための、一般的な構文は以下のようになります。<screen>
- <command>java <replaceable>[JVM 引数]</replaceable> -jar &FBHome;/lib/findbugs.jar <replaceable>オプション…</replaceable></command>
+ <sect2 id="directInvocation">
+ <title>&FindBugs; の直接起動</title>
+
+ <para>最初に述べる &FindBugs; の起動方法は、 <filename>&FBHome;/lib/findbugs.jar</filename> を直接実行する方法です。JVM (<command>java</command>) 実行プログラムの <command>-jar</command> コマンドラインスイッチを使用します。(&FindBugs;のバージョンが 1.3.5 より前の場合は、ラップしているスクリプトを使用する必要があります。)</para>
+
+ <para>&FindBugs; を直接起動するための、一般的な構文は以下のようになります。<screen>
+ <command>java <replaceable>[JVM 引数]</replaceable> -jar &FBHome;/lib/findbugs.jar <replaceable>オプション…</replaceable></command>
</screen>
- </para>
+ </para>
-<!--
- <para>
- By default, executing <filename>findbugs.jar</filename> runs the
- &FindBugs; graphical user interface (GUI). On windows systems,
- you can double-click on <filename>findbugs.jar</filename> to launch
- the GUI. From a command line, the command
- <screen>
+<!--
+ <para>
+ By default, executing <filename>findbugs.jar</filename> runs the
+ &FindBugs; graphical user interface (GUI). On windows systems,
+ you can double-click on <filename>findbugs.jar</filename> to launch
+ the GUI. From a command line, the command
+ <screen>
java -jar <replaceable>&FBHome;</replaceable>/lib/findbugs.jar</screen>
- will launch the GUI.
- </para>
+ will launch the GUI.
+ </para>
-->
- <sect3 id="chooseUI">
- <title> ユーザーインタフェースの選択</title>
-
- <para>1 番目のコマンドラインオプションは、起動する &FindBugs; ユーザーインタフェースを選択するためのものです。指定可能な値は次の通りです:</para>
- <itemizedlist>
- <listitem>
- <para>
- <command>-gui</command>: グラフィカルユーザーインタフェース (GUI) を起動します。</para>
- </listitem>
-
- <listitem>
- <para>
- <command>-textui</command>: コマンドラインインタフェースを起動します。</para>
- </listitem>
+ <sect3 id="chooseUI">
+ <title> ユーザーインタフェースの選択</title>
- <listitem>
- <para>
- <command>-version</command>: &FindBugs; のバージョン番号を表示します。</para>
- </listitem>
+ <para>1 番目のコマンドラインオプションは、起動する &FindBugs; ユーザーインタフェースを選択するためのものです。指定可能な値は次の通りです:</para>
+ <itemizedlist>
+ <listitem>
+ <para>
+ <command>-gui</command>: グラフィカルユーザーインタフェース (GUI) を起動します。</para>
+ </listitem>
- <listitem>
- <para>
- <command>-help</command>: &FindBugs; コマンドラインインタフェースのヘルプ情報を表示します。</para>
- </listitem>
+ <listitem>
+ <para>
+ <command>-textui</command>: コマンドラインインタフェースを起動します。</para>
+ </listitem>
- <listitem>
- <para>
- <command>-gui1</command>: 最初に作成された &FindBugs; グラフィカルユーザーインタフェース(すでに廃止されサポートされていない)を起動します。</para>
- </listitem>
- </itemizedlist>
-
- </sect3>
-
- <sect3 id="jvmArgs">
- <title>Java 仮想マシン (JVM) 引数</title>
-
- <para>&FindBugs; を起動する際に有用な Java 仮想マシン 引数をいくつか紹介します。</para>
-
- <variablelist>
- <varlistentry>
- <term><command>-Xmx<replaceable>NN</replaceable>m</command></term>
- <listitem>
- <para>Java ヒープサイズの最大値を <replaceable>NN</replaceable> メガバイトに設定します。&FindBugs; は一般的に大容量のメモリサイズを必要とします。大きなプロジェクトでは、 1500 メガバイトを使用することも珍しくありません。</para>
- </listitem>
- </varlistentry>
+ <listitem>
+ <para>
+ <command>-version</command>: &FindBugs; のバージョン番号を表示します。</para>
+ </listitem>
- <varlistentry>
- <term><command>-D<replaceable>name</replaceable>=<replaceable>value</replaceable></command></term>
- <listitem>
- <para>Java システムプロパティーを設定します。例えば、引数 <command>-Duser.language=ja</command> を使用すると GUI 文言が日本語で表示されます。</para>
- </listitem>
- </varlistentry>
+ <listitem>
+ <para>
+ <command>-help</command>: &FindBugs; コマンドラインインタフェースのヘルプ情報を表示します。</para>
+ </listitem>
- <!--
- <varlistentry>
- <term></term>
- <listitem>
- <para>
- </para>
- </listitem>
- </varlistentry>
- -->
- </variablelist>
- </sect3>
-
- </sect2>
-
- <sect2 id="wrapperScript">
- <title>ラップしているスクリプトを使用した &FindBugs; の起動</title>
+ <listitem>
+ <para>
+ <command>-gui1</command>: 最初に作成された &FindBugs; グラフィカルユーザーインタフェース(すでに廃止されサポートされていない)を起動します。</para>
+ </listitem>
+ </itemizedlist>
- <para>&FindBugs; を起動するもうひとつの方法は、ラップしているスクリプトを使用する方法です。</para>
+ </sect3>
+
+ <sect3 id="jvmArgs">
+ <title>Java 仮想マシン (JVM) 引数</title>
+
+ <para>&FindBugs; を起動する際に有用な Java 仮想マシン 引数をいくつか紹介します。</para>
+
+ <variablelist>
+ <varlistentry>
+ <term><command>-Xmx<replaceable>NN</replaceable>m</command></term>
+ <listitem>
+ <para>Java ヒープサイズの最大値を <replaceable>NN</replaceable> メガバイトに設定します。&FindBugs; は一般的に大容量のメモリサイズを必要とします。大きなプロジェクトでは、 1500 メガバイトを使用することも珍しくありません。</para>
+ </listitem>
+ </varlistentry>
+
+ <varlistentry>
+ <term><command>-D<replaceable>name</replaceable>=<replaceable>value</replaceable></command></term>
+ <listitem>
+ <para>Java システムプロパティーを設定します。例えば、引数 <command>-Duser.language=ja</command> を使用すると GUI 文言が日本語で表示されます。</para>
+ </listitem>
+ </varlistentry>
+
+ <!--
+ <varlistentry>
+ <term></term>
+ <listitem>
+ <para>
+ </para>
+ </listitem>
+ </varlistentry>
+ -->
+ </variablelist>
+ </sect3>
+
+ </sect2>
+
+ <sect2 id="wrapperScript">
+ <title>ラップしているスクリプトを使用した &FindBugs; の起動</title>
+
+ <para>&FindBugs; を起動するもうひとつの方法は、ラップしているスクリプトを使用する方法です。</para>
<para>Unix 系のシステムにおいては、次のようなコマンドでラップしているスクリプトを起動します :<screen>
<prompt>$ </prompt><command>&FBHome;/bin/findbugs <replaceable>オプション…</replaceable></command>
@@ -387,10 +387,10 @@
<para>Unix 系システム および Windows システムのどちらにおいても、ディレクトリー <filename><replaceable>$FINDBUGS_HOME</replaceable>/bin</filename> を環境変数 <filename>PATH</filename> に追加するだけで、 <command>findbugs</command> コマンドを使用して FindBugs を起動することができます。</para>
- <sect3 id="wrapperOptions">
- <title>ラップしているスクリプトのコマンドラインオプション</title>
- <para>&FindBugs; のラップしているスクリプトは、次のようなコマンドラインオプションをサポートしています。これらのコマンドラインオプションは &FindBugs; プログラム 自体が操作するのでは<emphasis>なく</emphasis>、どちらかといえば、ラップしているスクリプトの方が処理を行います。</para>
- <variablelist>
+ <sect3 id="wrapperOptions">
+ <title>ラップしているスクリプトのコマンドラインオプション</title>
+ <para>&FindBugs; のラップしているスクリプトは、次のようなコマンドラインオプションをサポートしています。これらのコマンドラインオプションは &FindBugs; プログラム 自体が操作するのでは<emphasis>なく</emphasis>、どちらかといえば、ラップしているスクリプトの方が処理を行います。</para>
+ <variablelist>
<varlistentry>
<term><command>-jvmArgs <replaceable>引数</replaceable></command></term>
<listitem>
@@ -429,9 +429,9 @@
</listitem>
</varlistentry>
- </variablelist>
-
- </sect3>
+ </variablelist>
+
+ </sect3>
</sect2>
@@ -465,14 +465,14 @@
<para>ここで示すオプションは、 GUI および コマンドラインインタフェースの両方で使用できます。</para>
<variablelist>
-
+
<varlistentry>
<term><command>-effort:min</command></term>
<listitem>
<para>このオプションを指定すると、精度を上げるために大量のメモリーを消費する分析が無効になります。&FindBugs; の実行時にメモリー不足になったり、分析を完了するまでに異常に長い時間がかかる場合に試してみてください。</para>
</listitem>
</varlistentry>
-
+
<varlistentry>
<term><command>-effort:max</command></term>
@@ -487,15 +487,15 @@
<para>分析するプロジェクトを指定します。指定するプロジェクトファイルには、 GUI を使って作成したものを使用してください。ファイルの拡張子は、一般的には <filename>.fb</filename> または <filename>.fbp</filename> です。</para>
</listitem>
</varlistentry>
-
+
<!--
<varlistentry>
- <term><command></command></term>
- <listitem>
- <para>
-
- </para>
- </listitem>
+ <term><command></command></term>
+ <listitem>
+ <para>
+
+ </para>
+ </listitem>
</varlistentry>
-->
@@ -570,12 +570,12 @@
<para>優先度 (高) のバグのみが報告されます。</para>
</listitem>
</varlistentry>
-
+
<varlistentry>
- <term><command>-relaxed</command></term>
- <listitem>
- <para>手抜き報告モードです。このオプションを指定すると、多くのディテクタにおいて 誤検出を回避するためのヒューリスティック機能が抑止されます。</para>
- </listitem>
+ <term><command>-relaxed</command></term>
+ <listitem>
+ <para>手抜き報告モードです。このオプションを指定すると、多くのディテクタにおいて 誤検出を回避するためのヒューリスティック機能が抑止されます。</para>
+ </listitem>
</varlistentry>
<varlistentry>
@@ -588,9 +588,9 @@
<varlistentry>
<term><command>-html</command></term>
<listitem>
- <para>HTML 出力が生成されます。デフォルトでは &FindBugs; は <filename>default.xsl</filename> <ulink url="http://www.w3.org/TR/xslt">XSLT</ulink> スタイルシートを使用して HTML 出力を生成します: このファイルは、 <filename>findbugs.jar</filename> の中、または、 &FindBugs; のソース配布物もしくはバイナリ配布物の中にあります。このオプションには、次のようなバリエーションも存在します。すなわち、 <command>-html:plain.xsl</command> 、 <command>-html:fancy.xsl</command> および <command>-html:fancy-hist.xsl</command> です。<filename>plain.xsl</filename> スタイルシートは Javascript や DOM を利用しません。したがって、古いWeb ブラウザ使用時や印刷時にも比較的うまく表示されるでしょう。<filename>fancy.xsl</filename> スタイルシートは DOM と Javascript を利用してナビゲーションを行います。また、ビジュアル表示に CSS を使用します。<command>fancy-hist.xsl</command> は <command>fancy.xsl</command> スタイルシートを更に進化させたものです。DOM や Javascript をふんだんに駆使して、バグの一覧を動的にフィルタリングします。</para>
-
- <para>ユーザー自身の XSLT スタイルシートを用いて HTML への変換を行いたい場合は、 <command>-html:<replaceable>myStylesheet.xsl</replaceable></command> のように指定してください。ここで、 <replaceable>myStylesheet.xsl</replaceable> はユーザーが使用したいスタイルシートのファイル名です。</para>
+ <para>HTML 出力が生成されます。デフォルトでは &FindBugs; は <filename>default.xsl</filename> <ulink url="http://www.w3.org/TR/xslt">XSLT</ulink> スタイルシートを使用して HTML 出力を生成します: このファイルは、 <filename>findbugs.jar</filename> の中、または、 &FindBugs; のソース配布物もしくはバイナリ配布物の中にあります。このオプションには、次のようなバリエーションも存在します。すなわち、 <command>-html:plain.xsl</command> 、 <command>-html:fancy.xsl</command> および <command>-html:fancy-hist.xsl</command> です。<filename>plain.xsl</filename> スタイルシートは Javascript や DOM を利用しません。したがって、古いWeb ブラウザ使用時や印刷時にも比較的うまく表示されるでしょう。<filename>fancy.xsl</filename> スタイルシートは DOM と Javascript を利用してナビゲーションを行います。また、ビジュアル表示に CSS を使用します。<command>fancy-hist.xsl</command> は <command>fancy.xsl</command> スタイルシートを更に進化させたものです。DOM や Javascript をふんだんに駆使して、バグの一覧を動的にフィルタリングします。</para>
+
+ <para>ユーザー自身の XSLT スタイルシートを用いて HTML への変換を行いたい場合は、 <command>-html:<replaceable>myStylesheet.xsl</replaceable></command> のように指定してください。ここで、 <replaceable>myStylesheet.xsl</replaceable> はユーザーが使用したいスタイルシートのファイル名です。</para>
</listitem>
</varlistentry>
@@ -655,9 +655,9 @@
</chapter>
<chapter id="gui">
- <title>&FindBugs; GUI の使用方法</title>
+ <title>&FindBugs; GUI の使用方法</title>
- <para>この章では、&FindBugs; グラフィカルユーザーインタフェース (GUI) の使用方法を説明します。</para>
+ <para>この章では、&FindBugs; グラフィカルユーザーインタフェース (GUI) の使用方法を説明します。</para>
<sect1>
<title>プロジェクトの作成</title>
@@ -780,20 +780,20 @@
<para>コマンドラインから &Ant; を起動する例を次に示します。前述の <literal>findbugs</literal> ターゲットを使用しています。<screen>
<prompt>[daveho@noir]$</prompt> <command>ant findbugs</command>
Buildfile: build.xml
-
+
init:
-
+
compile:
-
+
examples:
-
+
jar:
-
+
findbugs:
[findbugs] Running FindBugs...
[findbugs] Bugs were found
[findbugs] Output saved to bcel-fb.xml
-
+
BUILD SUCCESSFUL
Total time: 35 seconds
</screen>この事例においては、XML ファイルでバグ検索結果を保存しているので、 &FindBugs; GUI を使って結果を参照することができます。 <xref linkend="running"/> を参照してください。</para>
@@ -877,12 +877,12 @@
<para>任意指定のブール値属性です。true に設定すると、 &FindBugs; は 診断情報を出力します。どのクラスを分析しているか、どのパグパターンディテクタが実行されているか、という情報が表示されます。デフォルトは、 false です。</para>
</listitem>
</varlistentry>
-
+
<varlistentry>
- <term><literal>effort</literal></term>
- <listitem>
- <para>分析の活動レベルを設定します。<literal>min</literal> 、<literal>default</literal> または <literal>max</literal> のいずれかの値を設定してください。分析レベルの設定に関する詳細情報は、 <xref linkend="commandLineOptions"/> を参照してください。</para>
- </listitem>
+ <term><literal>effort</literal></term>
+ <listitem>
+ <para>分析の活動レベルを設定します。<literal>min</literal> 、<literal>default</literal> または <literal>max</literal> のいずれかの値を設定してください。分析レベルの設定に関する詳細情報は、 <xref linkend="commandLineOptions"/> を参照してください。</para>
+ </listitem>
</varlistentry>
<varlistentry>
@@ -898,7 +898,7 @@
<para>effort="max" と同義です。</para>
</listitem>
</varlistentry>
-
+
<varlistentry>
<term><literal>visitors</literal></term>
<listitem>
@@ -968,12 +968,12 @@
<para>任意指定の属性です。&FindBugs; の実行中にエラーが発生した場合に、「true」が設定されるプロパティーの名前を指定します。</para>
</listitem>
</varlistentry>
-
+
<varlistentry>
- <term><literal>warningsProperty</literal></term>
- <listitem>
- <para>任意指定の属性です。&FindBugs; が分析したプログラムにバグ報告が 1 件でもある場合に、「true」が設定されるプロパティーの名前を指定します。</para>
- </listitem>
+ <term><literal>warningsProperty</literal></term>
+ <listitem>
+ <para>任意指定の属性です。&FindBugs; が分析したプログラムにバグ報告が 1 件でもある場合に、「true」が設定されるプロパティーの名前を指定します。</para>
+ </listitem>
</varlistentry>
</variablelist>
@@ -1011,31 +1011,31 @@
<title>インストール</title>
<para>更新サイトが提供されています。更新サイトを利用して、機械的に FindBugs を Eclipse にインストールできます。また自動的に、最新版のアップデートを照会してインストールすることもできます。内容の異なる 3 つの更新サイトが存在します。</para>
-
+
<variablelist><title>FindBugs Eclipse 更新サイト一覧</title>
- <varlistentry><term><ulink url="http://findbugs.cs.umd.edu/eclipse/">http://findbugs.cs.umd.edu/eclipse/</ulink></term>
-
+ <varlistentry><term><ulink url="http://findbugs.cs.umd.edu/eclipse/">http://findbugs.cs.umd.edu/eclipse/</ulink></term>
+
<listitem>
<para>FindBugs の公式リリース物を提供します。</para>
</listitem>
</varlistentry>
-
- <varlistentry><term><ulink url="http://findbugs.cs.umd.edu/eclipse-candidate/">http://findbugs.cs.umd.edu/eclips-candidate/</ulink></term>
-
+
+ <varlistentry><term><ulink url="http://findbugs.cs.umd.edu/eclipse-candidate/">http://findbugs.cs.umd.edu/eclips-candidate/</ulink></term>
+
<listitem>
<para>FindBugsの公式リリース物に加えて、公式リリース候補版を提供します。</para>
</listitem>
</varlistentry>
- <varlistentry><term><ulink url="http://findbugs.cs.umd.edu/eclipse-daily/">http://findbugs.cs.umd.edu/eclipse-daily/</ulink></term>
-
+ <varlistentry><term><ulink url="http://findbugs.cs.umd.edu/eclipse-daily/">http://findbugs.cs.umd.edu/eclipse-daily/</ulink></term>
+
<listitem>
<para>FindBugsの日次ビルド物を提供します。コンパイルができること以上のテストは行われていません。</para>
</listitem>
</varlistentry>
</variablelist>
-
-<para>また、次に示すリンクから手動でプラグインをダウンロードすることもできます : <ulink url="http://prdownloads.sourceforge.net/findbugs/edu.umd.cs.findbugs.plugin.eclipse_1.3.9.20090821.zip?download">http://prdownloads.sourceforge.net/findbugs/edu.umd.cs.findbugs.plugin.eclipse_1.3.9.20090821.zip?download</ulink>. 展開して Eclipse の「plugins」サブディレクトリーに入れてください。(そうすると、 <eclipse インストールディレクトリー >/plugins/edu.umd.cs.findbugs.plugin.eclipse_1.3.9.20090821/findbugs.png が &FindBugs; のロゴファイルへのパスになるはずです。)</para>
+
+<para>また、次に示すリンクから手動でプラグインをダウンロードすることもできます : <ulink url="http://prdownloads.sourceforge.net/findbugs/edu.umd.cs.findbugs.plugin.eclipse_2.0.2.20130225.zip?download">http://prdownloads.sourceforge.net/findbugs/edu.umd.cs.findbugs.plugin.eclipse_2.0.2.20130225.zip?download</ulink>. 展開して Eclipse の「plugins」サブディレクトリーに入れてください。(そうすると、 <eclipse インストールディレクトリー >/plugins/edu.umd.cs.findbugs.plugin.eclipse_2.0.2.20130225/findbugs.png が &FindBugs; のロゴファイルへのパスになるはずです。)</para>
<para>プラグインの展開ができたら、 Eclipse を起動して <menuchoice> <guimenu>Help</guimenu> <guimenuitem>About Eclipse Platform</guimenuitem> <guimenuitem>Plug-in Details</guimenuitem> </menuchoice> を選択してください。「FindBugs Project」から提供された「FindBugs Plug-in」というプラグインがあることを確認してください。</para>
</sect1>
@@ -1124,29 +1124,29 @@
</varlistentry>
<varlistentry>
- <term><literal><Priority></literal></term>
- <listitem>
- <para>この要素は、特定の優先度をもつ警告を照合します。<literal>value</literal> 属性には、整数値を指定します : 1 は優先度(高)、また、 2 は優先度(中) 、 3 は優先度(低) を示します。</para>
- </listitem>
+ <term><literal><Priority></literal></term>
+ <listitem>
+ <para>この要素は、特定の優先度をもつ警告を照合します。<literal>value</literal> 属性には、整数値を指定します : 1 は優先度(高)、また、 2 は優先度(中) 、 3 は優先度(低) を示します。</para>
+ </listitem>
</varlistentry>
<varlistentry>
<term><literal><Package></literal></term>
- <listitem>
- <para>この要素は、 <literal>name</literal> 属性で指定した特定のパッケージ内にあるクラスに関連した警告を照合します。入れ子のパッケージは含まれません (Java import 文に従っています) 。しかしながら、正規表現を使うと複数パッケージにマッチさせることは簡単にできます。</para>
- </listitem>
+ <listitem>
+ <para>この要素は、 <literal>name</literal> 属性で指定した特定のパッケージ内にあるクラスに関連した警告を照合します。入れ子のパッケージは含まれません (Java import 文に従っています) 。しかしながら、正規表現を使うと複数パッケージにマッチさせることは簡単にできます。</para>
+ </listitem>
</varlistentry>
-
+
<varlistentry>
<term><literal><Class></literal></term>
- <listitem>
- <para>この要素は、特定のクラスに関連した警告を照合します。<literal>name</literal> 属性を使用して、照合するクラス名をクラス名そのものか、または、正規表現で指定します。</para>
-
- <para>下位互換性を持たせたい場合は、この要素の代わりに <literal>Match</literal> 要素を使用してください。クラス名そのものの指定は <literal>class</literal> 属性を、クラス名を正規表現で指定する場合は <literal>classregex</literal> 属性をそれぞれ使用してください</para>
-
- <para>もし <literal>Match</literal> 要素に <literal>Class</literal> 要素が無かったり、 <literal>class</literal> / <literal>classregex</literal> 属性が無かったりした場合は、すべてのクラスに適用されます。その場合、想定外に多くのバグ検索結果が一致してしまうことがあり得ます。その場合は、適当なメソッドやフィールドで絞り込んでください。</para>
- </listitem>
+ <listitem>
+ <para>この要素は、特定のクラスに関連した警告を照合します。<literal>name</literal> 属性を使用して、照合するクラス名をクラス名そのものか、または、正規表現で指定します。</para>
+
+ <para>下位互換性を持たせたい場合は、この要素の代わりに <literal>Match</literal> 要素を使用してください。クラス名そのものの指定は <literal>class</literal> 属性を、クラス名を正規表現で指定する場合は <literal>classregex</literal> 属性をそれぞれ使用してください</para>
+
+ <para>もし <literal>Match</literal> 要素に <literal>Class</literal> 要素が無かったり、 <literal>class</literal> / <literal>classregex</literal> 属性が無かったりした場合は、すべてのクラスに適用されます。その場合、想定外に多くのバグ検索結果が一致してしまうことがあり得ます。その場合は、適当なメソッドやフィールドで絞り込んでください。</para>
+ </listitem>
</varlistentry>
<varlistentry>
@@ -1160,13 +1160,13 @@
<listitem><para>この要素は、フィールドを指定します。<literal>name</literal> 属性を使用して、照合するフィールド名をフィールド名そのものか、または、正規表現で指定します。また、フィールドのシグニチャーに照らしたフィルタリングをすることができます。 <literal>type</literal> 属性を使用して、フィールドの型を完全修飾名で指定してください。名前とシグニチャーに基づく条件を規定するために、その2つの属性を両方とも指定することができます。</para></listitem>
</varlistentry>
-
+
<varlistentry>
<term><literal><Local></literal></term>
<listitem><para>この要素は、ローカル変数を指定します。<literal>name</literal> 属性を使用して、照合するローカル変数名をローカル変数名そのものか、または、正規表現で指定します。ローカル変数とは、メソッド内で定義した変数です。</para></listitem>
</varlistentry>
-
+
<varlistentry>
<term><literal><Or></literal></term>
<listitem><para>この要素は、論理和として <literal>Match</literal> 条項を結合します。すなわち、2つの <literal>Method</literal> 要素を <literal>Or</literal> 条項に入れることで、どちらか一方のメソッドでマッチさせることができます。</para></listitem>
@@ -1289,7 +1289,7 @@
<para>8. AspectJ コンパイラーによって引き起こされるマイナーバグに一致させます (AspectJ の開発者でもない限り、それらのバグに関心を持つことはないと考えます)。<programlisting>
<![CDATA[
- <Match>
+ <Match>
<Class name="~.*\$AjcClosure\d+" />
<Bug pattern="DLS_DEAD_LOCAL_STORE" />
<Method name="run" />
@@ -1305,7 +1305,7 @@
<para>9. 基盤コードの特定の部分に対するバグに一致させます<programlisting>
<![CDATA[
<!-- すべてのパッケージにある Messages クラスに対する unused fields 警告に一致。 -->
- <Match>
+ <Match>
<Class name="~.*\.Messages" />
<Bug code="UUF" />
</Match>
@@ -1325,21 +1325,21 @@
<para>10. 特定のシグニチャーを持つフィールドまたはメソッドのバグに一致させます。<programlisting>
<![CDATA[
- <!-- すべてのクラスの main(String[]) メソッドに対する System.exit(...) usage 警告に一致。 -->
- <Match>
- <Method returns="void" name="main" params="java.lang.String[]" />
- <Method pattern="DM_EXIT" />
- </Match>
- <!-- すべてのクラスの com.foobar.DebugInfo 型のフィールドに対する UuF 警告に一致。 -->
- <Match>
- <Field type="com.foobar.DebugInfo" />
- <Bug code="UuF" />
- </Match>
+ <!-- すべてのクラスの main(String[]) メソッドに対する System.exit(...) usage 警告に一致。 -->
+ <Match>
+ <Method returns="void" name="main" params="java.lang.String[]" />
+ <Method pattern="DM_EXIT" />
+ </Match>
+ <!-- すべてのクラスの com.foobar.DebugInfo 型のフィールドに対する UuF 警告に一致。 -->
+ <Match>
+ <Field type="com.foobar.DebugInfo" />
+ <Bug code="UuF" />
+ </Match>
]]>
-</programlisting>
+</programlisting>
</para>
-
+
</sect1>
<sect1>
@@ -1812,9 +1812,9 @@
Data mining
**************************************************************************
-->
-
+
<chapter id="datamining">
- <title>&FindBugs;™ によるデータ・マイニング</title>
+ <title>&FindBugs;™ によるデータ・マイニング</title>
<para>バグデータベースへの高機能の問い合わせ機能、および、調査対象のコードの複数のバージョンにわたる警告の追跡記録機能を、 FindBugs は内蔵しています。これらを使って次のようなことができます。すなわち、いつバグが最初持ち込まれたかを捜し出すこと、最終リリース以後持ち込まれた警告の分析を行うこと、または、無限再起ループの数を時間軸でグラフにすることです。</para>
@@ -1840,78 +1840,78 @@
]]>
</programlisting>
- <sect1 id="commands">
- <title>コマンド</title>
-
- <para>FindBugs データ・マイニング ツールはすべてコマンドラインから実行することができます。また、いくつかのより有用なコマンドは、 ant ビルドファイルから実行することができます。</para>
+ <sect1 id="commands">
+ <title>コマンド</title>
+
+ <para>FindBugs データ・マイニング ツールはすべてコマンドラインから実行することができます。また、いくつかのより有用なコマンドは、 ant ビルドファイルから実行することができます。</para>
<para>コマンドラインツールについて簡単に説明します :</para>
- <variablelist>
- <varlistentry>
- <term><command><link linkend="unionBugs">unionBugs</link></command></term>
- <listitem>
- <para>別のクラスに対する別個の分析結果を結合します。</para>
- </listitem>
- </varlistentry>
- <varlistentry>
- <term><command><link linkend="computeBugHistory">computeBugHistory</link></command></term>
- <listitem>
- <para>複数バージョンから得られた複数のバグ警告を、マージして 1 個の複数バージョンバグデータベースにします。これを使って、既存の複数バージョンバグデータベースに更にバージョンを追加したり、 1 バージョンを格納するバグデータベースの集合から 1 個の複数バージョンバグデータベースを作成したり、できます。</para>
- </listitem>
- </varlistentry>
- <varlistentry>
- <term><command><link linkend="setBugDatabaseInfo">setBugDatabaseInfo</link></command></term>
- <listitem>
- <para>リビジョン名やタイム・スタンプなどの情報を XML データベースに設定します。</para>
- </listitem>
- </varlistentry>
- <varlistentry>
- <term><command><link linkend="listBugDatabaseInfo">listBugDatabaseInfo</link></command></term>
- <listitem>
- <para>XML データベースにあるリビジョン名やタイム・スタンプなどの情報を一覧表示します。</para>
- </listitem>
- </varlistentry>
- <varlistentry>
- <term><command><link linkend="filterBugs">filterBugs</link></command></term>
- <listitem>
- <para>バグデータベースの部分集合を選択します。</para>
- </listitem>
- </varlistentry>
- <varlistentry>
- <term><command><link linkend="mineBugHistory">mineBugHistory</link></command></term>
- <listitem>
- <para>複数バージョンバグデータベースの各バージョン毎の警告数を一覧にした表を作成します。</para>
- </listitem>
- </varlistentry>
- <varlistentry>
- <term><command><link linkend="defectDensity">defectDensity</link></command></term>
- <listitem>
- <para>プロジェクト全体およびクラス毎・パッケージ毎の不良密度 (1000 NCSS 毎の警告数) に関する情報を一覧表示します。</para>
- </listitem>
- </varlistentry>
- <varlistentry>
- <term><command><link linkend="convertXmlToText">convertXmlToText</link></command></term>
- <listitem>
- <para>XML 形式のバグ警告を、 1 行 1 バグのテキスト形式、または、HTML形式に変換します。</para>
- </listitem>
- </varlistentry>
- </variablelist>
-
-
- <sect2 id="unionBugs">
- <title>unionBugs</title>
+ <variablelist>
+ <varlistentry>
+ <term><command><link linkend="unionBugs">unionBugs</link></command></term>
+ <listitem>
+ <para>別のクラスに対する別個の分析結果を結合します。</para>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><command><link linkend="computeBugHistory">computeBugHistory</link></command></term>
+ <listitem>
+ <para>複数バージョンから得られた複数のバグ警告を、マージして 1 個の複数バージョンバグデータベースにします。これを使って、既存の複数バージョンバグデータベースに更にバージョンを追加したり、 1 バージョンを格納するバグデータベースの集合から 1 個の複数バージョンバグデータベースを作成したり、できます。</para>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><command><link linkend="setBugDatabaseInfo">setBugDatabaseInfo</link></command></term>
+ <listitem>
+ <para>リビジョン名やタイム・スタンプなどの情報を XML データベースに設定します。</para>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><command><link linkend="listBugDatabaseInfo">listBugDatabaseInfo</link></command></term>
+ <listitem>
+ <para>XML データベースにあるリビジョン名やタイム・スタンプなどの情報を一覧表示します。</para>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><command><link linkend="filterBugs">filterBugs</link></command></term>
+ <listitem>
+ <para>バグデータベースの部分集合を選択します。</para>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><command><link linkend="mineBugHistory">mineBugHistory</link></command></term>
+ <listitem>
+ <para>複数バージョンバグデータベースの各バージョン毎の警告数を一覧にした表を作成します。</para>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><command><link linkend="defectDensity">defectDensity</link></command></term>
+ <listitem>
+ <para>プロジェクト全体およびクラス毎・パッケージ毎の不良密度 (1000 NCSS 毎の警告数) に関する情報を一覧表示します。</para>
+ </listitem>
+ </varlistentry>
+ <varlistentry>
+ <term><command><link linkend="convertXmlToText">convertXmlToText</link></command></term>
+ <listitem>
+ <para>XML 形式のバグ警告を、 1 行 1 バグのテキスト形式、または、HTML形式に変換します。</para>
+ </listitem>
+ </varlistentry>
+ </variablelist>
- <para>分析するのにアプリケーションの jar ファイルを分割している場合、このコマンドを使用することで、別個に生成された XML バグ警告ファイルをすべての警告を含んでいる 1 つの ファイルにすることができます。</para>
- <para>同じファイルの異なるバージョンを分析した結果を結合する場合は、このコマンドを<emphasis>使用しないでください</emphasis>。代わりに <command>computeBugHistory</command> を使用してください。</para>
+ <sect2 id="unionBugs">
+ <title>unionBugs</title>
- <para>XML ファイルは、コマンドラインで指定してください。結果は、標準出力に送られます。</para>
- </sect2>
+ <para>分析するのにアプリケーションの jar ファイルを分割している場合、このコマンドを使用することで、別個に生成された XML バグ警告ファイルをすべての警告を含んでいる 1 つの ファイルにすることができます。</para>
- <sect2 id="computeBugHistory">
- <title>computeBugHistory</title>
-
+ <para>同じファイルの異なるバージョンを分析した結果を結合する場合は、このコマンドを<emphasis>使用しないでください</emphasis>。代わりに <command>computeBugHistory</command> を使用してください。</para>
+
+ <para>XML ファイルは、コマンドラインで指定してください。結果は、標準出力に送られます。</para>
+ </sect2>
+
+ <sect2 id="computeBugHistory">
+ <title>computeBugHistory</title>
+
<para>このコマンドを使用することで、分析するソフトウェアの異なるビルドまたはバージョンの情報を含むバグデータベースを生成することができます入力として提供したファイルの 1 番目のファイルから履歴が取得されます。後に続くファイルは 1 バージョンのバグデータベースであるようにしてください (もし、履歴を持っていたとしても無視されます) 。</para>
<para>デフォルトでは、結果は標準出力に送られます。</para>
@@ -1936,17 +1936,17 @@
]]>
</programlisting>
- <table id="computeBugHistoryTable">
- <title>computeBugHistory コマンドのオプション一覧</title>
- <tgroup cols="3" align="left">
- <thead>
- <row>
- <entry>コマンドラインオプション</entry>
- <entry>Ant 属性</entry>
- <entry>目的</entry>
- </row>
- </thead>
- <tbody>
+ <table id="computeBugHistoryTable">
+ <title>computeBugHistory コマンドのオプション一覧</title>
+ <tgroup cols="3" align="left">
+ <thead>
+ <row>
+ <entry>コマンドラインオプション</entry>
+ <entry>Ant 属性</entry>
+ <entry>目的</entry>
+ </row>
+ </thead>
+ <tbody>
<row><entry>-output <file></entry> <entry>output="<file>"</entry> <entry>出力結果を保存するファイル名を指定します。 (同時に入力ファイルにもなりえます)</entry></row>
<row><entry>-overrideRevisionNames[:truth]</entry> <entry>overrideRevisionNames="[true|false]"</entry><entry>ファイル名から算出されるそれぞれのバージョン名を指定変更します。</entry></row>
<row><entry>-noPackageMoves[:truth]</entry> <entry>noPackageMoves="[true|false]"</entry><entry>パッケージを移動したクラスがある場合、当該クラスの警告は別の存在として扱われます。</entry></row>
@@ -1954,13 +1954,13 @@
<row><entry>-precisePriorityMatch[:truth]</entry> <entry>precisePriorityMatch="[true|false]"</entry><entry>優先度が正確に一致した場合のみ警告が同一であると判断されます。</entry></row>
<row><entry>-quiet[:truth]</entry> <entry>quiet="[true|false]"</entry><entry>エラーが発生しない限り、標準出力には何も表示されません。</entry></row>
<row><entry>-withMessages[:truth]</entry> <entry>withMessages="[true|false]"</entry><entry>出力 XML に人間が読むことができるバグメッセージが含まれます。</entry></row>
- </tbody>
- </tgroup>
- </table>
+ </tbody>
+ </tgroup>
+ </table>
- </sect2>
- <sect2 id="filterBugs">
- <title>filterBugs</title>
+ </sect2>
+ <sect2 id="filterBugs">
+ <title>filterBugs</title>
<para>このコマンドを使用することで、 FindBugs XML 警告ファイルから一部分を選び出して新規 FindBugs 警告ファイルに選択された部分を書き込むことができます。</para>
<para>このコマンドには、オプション群に続いて 0 個から 2 個の findbugs xml バグファイルを指定することができます。</para>
<para>ファイル名をひとつも指定しない場合は、標準入力から読んで標準出力に出力されます。ファイル名を 1 個 指定した場合は、指定したファイルから読んで標準出力に出力されます。ファイル名を 2 個 指定した場合は、 1 番目に指定したファイルから読んで 2 番目に指定したファイルに出力されます。</para>
@@ -1985,17 +1985,17 @@
]]>
</programlisting>
- <table id="filterOptionsTable">
- <title>filterBugs コマンドのオプション一覧</title>
- <tgroup cols="3" align="left">
- <thead>
- <row>
- <entry>コマンドラインオプション</entry>
- <entry>Ant 属性</entry>
- <entry>目的</entry>
- </row>
- </thead>
- <tbody>
+ <table id="filterOptionsTable">
+ <title>filterBugs コマンドのオプション一覧</title>
+ <tgroup cols="3" align="left">
+ <thead>
+ <row>
+ <entry>コマンドラインオプション</entry>
+ <entry>Ant 属性</entry>
+ <entry>目的</entry>
+ </row>
+ </thead>
+ <tbody>
<row><entry/> <entry>input="<file>"</entry> <entry>入力ファイルを指定します。</entry></row>
<row><entry/> <entry>output="<file>"</entry> <entry>出力ファイルを指定します。</entry></row>
<row><entry>-not</entry> <entry>not="[true|false]"</entry> <entry>フィルターのスイッチを反転します。</entry></row>
@@ -2021,14 +2021,14 @@
<row><entry>-category <category></entry> <entry>category="<category>"</entry> <entry>指定した文字列で始まるカテゴリーの警告のみ出力されます。</entry></row>
<row><entry>-designation <designation></entry> <entry>designation="<designation>"</entry> <entry>指定したバグ分類指定をもつ警告のみ出力されます。 (例、 -designation SHOULD_FIX)</entry></row>
<row><entry>-withMessages[:truth] </entry> <entry>withMessages="[true|false]"</entry> <entry>テキストメッセージを含んだ XML が生成されます。</entry></row>
- </tbody>
- </tgroup>
- </table>
-
- </sect2>
-
- <sect2 id="mineBugHistory">
- <title>mineBugHistory</title>
+ </tbody>
+ </tgroup>
+ </table>
+
+ </sect2>
+
+ <sect2 id="mineBugHistory">
+ <title>mineBugHistory</title>
<para>このコマンドを使用することで、複数バージョンバグデータベースの各バージョン毎の警告数を一覧にした表を作成することができます。</para>
@@ -2052,85 +2052,85 @@
]]>
</programlisting>
- <table id="mineBugHistoryOptionsTable">
- <title>mineBugHistory コマンドのオプション一覧</title>
- <tgroup cols="3" align="left">
- <thead>
- <row>
- <entry>コマンドラインオプション</entry>
- <entry>Ant 属性</entry>
- <entry>目的</entry>
- </row>
- </thead>
- <tbody>
+ <table id="mineBugHistoryOptionsTable">
+ <title>mineBugHistory コマンドのオプション一覧</title>
+ <tgroup cols="3" align="left">
+ <thead>
+ <row>
+ <entry>コマンドラインオプション</entry>
+ <entry>Ant 属性</entry>
+ <entry>目的</entry>
+ </row>
+ </thead>
+ <tbody>
<row><entry/> <entry>input="<file>"</entry> <entry>入力ファイルを指定します。</entry></row>
<row><entry/> <entry>output="<file>"</entry> <entry>出力ファイルを指定します。</entry></row>
<row><entry>-formatDates</entry> <entry>formatDates="[true|false]"</entry> <entry>データがテキスト形式で描画されます。</entry></row>
<row><entry>-noTabs</entry> <entry>noTabs="[true|false]"</entry> <entry>タブの代わりに複数スペースでカラムが区切られます (下記参照)。</entry></row>
<row><entry>-summary</entry> <entry>summary="[true|false]"</entry> <entry>最新 10 件の変更の要約が出力されます。</entry></row>
- </tbody>
- </tgroup>
- </table>
+ </tbody>
+ </tgroup>
+ </table>
- <para><option>-noTabs</option> 出力を使うことで、固定幅フォントのシェルで読み易くなります。数値カラムは右寄せされるので、スペースがカラム値の前に挿入されます。また、このオプションを使用した場合、 <option>-formatDates</option> を指定したときに要約の日付を描画するのに空白が埋め込まれなくなります。</para>
+ <para><option>-noTabs</option> 出力を使うことで、固定幅フォントのシェルで読み易くなります。数値カラムは右寄せされるので、スペースがカラム値の前に挿入されます。また、このオプションを使用した場合、 <option>-formatDates</option> を指定したときに要約の日付を描画するのに空白が埋め込まれなくなります。</para>
- <para>出力される表は、 (<option>-noTabs</option> が無ければ) タブ区切りで次に示すカラムから成ります :</para>
+ <para>出力される表は、 (<option>-noTabs</option> が無ければ) タブ区切りで次に示すカラムから成ります :</para>
- <table id="mineBugHistoryColumns">
- <title>mineBugHistory 出力のカラム一覧</title>
- <tgroup cols="2" align="left">
- <thead>
- <row>
- <entry>表題</entry>
- <entry>目的</entry>
- </row>
- </thead>
- <tbody>
- <row><entry>seq</entry><entry>シーケンス番号 (0 始まりの連続した整数値)</entry></row>
- <row><entry>version</entry><entry>バージョン名</entry></row>
- <row><entry>time</entry><entry>リリースされた日時</entry></row>
- <row><entry>classes</entry><entry>分析されたクラス数</entry></row>
- <row><entry>NCSS</entry><entry>コメント文を除いた命令数 (Non Commenting Source Statements)</entry></row>
- <row><entry>added</entry><entry>前回のバージョンに存在したクラスにおける新規警告数</entry></row>
- <row><entry>newCode</entry><entry>前回のバージョンに存在しなかったクラスにおける新規警告数</entry></row>
- <row><entry>fixed</entry><entry>現在のバージョンに存在するクラスにおける除去された警告数</entry></row>
- <row><entry>removed</entry><entry>現在のバージョンに存在しないクラスの前回のバージョンにおける警告数</entry></row>
- <row><entry>retained</entry><entry>現在のバージョンと前回のバージョンの両方に存在する警告の数</entry></row>
- <row><entry>dead</entry><entry>以前のバージョンに存在したが現在のバージョンにも直前のバージョンにも存在しない警告の数</entry></row>
- <row><entry>active</entry><entry>現在のバージョンに存在する警告総数</entry></row>
- </tbody>
- </tgroup>
- </table>
- </sect2>
-
- <sect2 id="defectDensity">
- <title>defectDensity</title>
+ <table id="mineBugHistoryColumns">
+ <title>mineBugHistory 出力のカラム一覧</title>
+ <tgroup cols="2" align="left">
+ <thead>
+ <row>
+ <entry>表題</entry>
+ <entry>目的</entry>
+ </row>
+ </thead>
+ <tbody>
+ <row><entry>seq</entry><entry>シーケンス番号 (0 始まりの連続した整数値)</entry></row>
+ <row><entry>version</entry><entry>バージョン名</entry></row>
+ <row><entry>time</entry><entry>リリースされた日時</entry></row>
+ <row><entry>classes</entry><entry>分析されたクラス数</entry></row>
+ <row><entry>NCSS</entry><entry>コメント文を除いた命令数 (Non Commenting Source Statements)</entry></row>
+ <row><entry>added</entry><entry>前回のバージョンに存在したクラスにおける新規警告数</entry></row>
+ <row><entry>newCode</entry><entry>前回のバージョンに存在しなかったクラスにおける新規警告数</entry></row>
+ <row><entry>fixed</entry><entry>現在のバージョンに存在するクラスにおける除去された警告数</entry></row>
+ <row><entry>removed</entry><entry>現在のバージョンに存在しないクラスの前回のバージョンにおける警告数</entry></row>
+ <row><entry>retained</entry><entry>現在のバージョンと前回のバージョンの両方に存在する警告の数</entry></row>
+ <row><entry>dead</entry><entry>以前のバージョンに存在したが現在のバージョンにも直前のバージョンにも存在しない警告の数</entry></row>
+ <row><entry>active</entry><entry>現在のバージョンに存在する警告総数</entry></row>
+ </tbody>
+ </tgroup>
+ </table>
+ </sect2>
+
+ <sect2 id="defectDensity">
+ <title>defectDensity</title>
<para>このコマンドを使用することで、プロジェクト全体およびクラス毎・パッケージ毎の不良密度 (1000 NCSS 毎の警告数) に関する情報を一覧表示できます。標準入力から読み込む場合はファイル指定なしで、そうでなければ、コマンドラインでファイルを指定して、このコマンドを実行します。</para>
<para>出力される表は、次に示すカラムから成ります。また、プロジェクト全体情報の行、および、4 個以上の警告を含んでいる各パッケージ情報または各クラス情報の行も出力されます。</para>
- <table id="defectDensityColumns">
- <title>defectDensity 出力のカラム一覧</title>
- <tgroup cols="2" align="left">
- <thead>
- <row>
- <entry>表題</entry>
- <entry>目的</entry>
- </row>
- </thead>
- <tbody>
- <row><entry>kind</entry><entry>プロジェクト (project)、パッケージ (package) またはクラス (class)</entry></row>
- <row><entry>name</entry><entry>プロジェクト、パッケージまたはクラスの名前</entry></row>
- <row><entry>density</entry><entry> 1000 NCSS 毎の警告数</entry></row>
- <row><entry>bugs</entry><entry>警告数</entry></row>
- <row><entry>NCSS</entry><entry>コメント文を除いた命令数 (Non Commenting Source Statements) </entry></row>
- </tbody>
- </tgroup>
- </table>
- </sect2>
-
- <sect2 id="convertXmlToText">
- <title>convertXmlToText</title>
-
- <para>このコマンドを使用することで、XML 形式のバグ警告を、 1 行 1 バグのテキスト形式、または、HTML形式に変換することができます。</para>
+ <table id="defectDensityColumns">
+ <title>defectDensity 出力のカラム一覧</title>
+ <tgroup cols="2" align="left">
+ <thead>
+ <row>
+ <entry>表題</entry>
+ <entry>目的</entry>
+ </row>
+ </thead>
+ <tbody>
+ <row><entry>kind</entry><entry>プロジェクト (project)、パッケージ (package) またはクラス (class)</entry></row>
+ <row><entry>name</entry><entry>プロジェクト、パッケージまたはクラスの名前</entry></row>
+ <row><entry>density</entry><entry> 1000 NCSS 毎の警告数</entry></row>
+ <row><entry>bugs</entry><entry>警告数</entry></row>
+ <row><entry>NCSS</entry><entry>コメント文を除いた命令数 (Non Commenting Source Statements) </entry></row>
+ </tbody>
+ </tgroup>
+ </table>
+ </sect2>
+
+ <sect2 id="convertXmlToText">
+ <title>convertXmlToText</title>
+
+ <para>このコマンドを使用することで、XML 形式のバグ警告を、 1 行 1 バグのテキスト形式、または、HTML形式に変換することができます。</para>
<para>この機能は、 ant からも使用することができます。まず次に示すように、ビルドファイルに <command>convertXmlToText</command> を taskdef で定義します :</para>
@@ -2143,34 +2143,34 @@
</programlisting>
<para>この ant タスクに指定できる属性を、下表に一覧で示します。</para>
-
- <table id="convertXmlToTextTable">
- <title>convertXmlToText コマンドのオプション一覧</title>
- <tgroup cols="3" align="left">
- <thead>
- <row>
- <entry>コマンドラインオプション</entry>
- <entry>Ant 属性</entry>
- <entry>目的</entry>
- </row>
- </thead>
- <tbody>
+
+ <table id="convertXmlToTextTable">
+ <title>convertXmlToText コマンドのオプション一覧</title>
+ <tgroup cols="3" align="left">
+ <thead>
+ <row>
+ <entry>コマンドラインオプション</entry>
+ <entry>Ant 属性</entry>
+ <entry>目的</entry>
+ </row>
+ </thead>
+ <tbody>
<row><entry/> <entry>input="<filename>"</entry> <entry>入力ファイルを指定します。</entry></row>
<row><entry/> <entry>output="<filename>"</entry> <entry>出力ファイルを指定します。</entry></row>
<row><entry>-longBugCodes</entry> <entry>longBugCodes="[true|false]"</entry> <entry>2 文字のバグ略称の代わりに、省略なしのバグパターンコードを使用します。</entry></row>
<row><entry/> <entry>format="text"</entry> <entry>プレーンテキストの出力が作成されます。1 行につき 1 つのバグが出力されます。コマンドライン時のデフォルトです。</entry></row>
<row><entry>-html[:stylesheet]</entry> <entry>format="html:<stylesheet>"</entry> <entry>指定されたスタイルシートを使用して出力が作成されます (下記参照) 。省略した場合は、 default.xsl が使用されます。</entry></row>
- </tbody>
- </tgroup>
- </table>
-
- <para>-html/format オプションには、plain.xsl 、 default.xsl 、 fancy.xsl 、 fancy-hist.xsl または ユーザ自身が作成した XSL スタイルシートのいずれかを指定することができます。オプション名をよそに、 html 以外の形式を出力するスタイルシートを指定することもできます。FindBugs に含まれているスタイルシート(上述)以外のスタイルシートを使用する場合は、オプション -html/format で当該スタイルシートへのパスまたは URL を指定してください。</para>
- </sect2>
-
- <sect2 id="setBugDatabaseInfo">
- <title>setBugDatabaseInfo</title>
-
- <para>このコマンドを使用することで、指定したバグ警告にメタ情報を設定することができます。このコマンドには次に示すオプションがあります:</para>
+ </tbody>
+ </tgroup>
+ </table>
+
+ <para>-html/format オプションには、plain.xsl 、 default.xsl 、 fancy.xsl 、 fancy-hist.xsl または ユーザ自身が作成した XSL スタイルシートのいずれかを指定することができます。オプション名をよそに、 html 以外の形式を出力するスタイルシートを指定することもできます。FindBugs に含まれているスタイルシート(上述)以外のスタイルシートを使用する場合は、オプション -html/format で当該スタイルシートへのパスまたは URL を指定してください。</para>
+ </sect2>
+
+ <sect2 id="setBugDatabaseInfo">
+ <title>setBugDatabaseInfo</title>
+
+ <para>このコマンドを使用することで、指定したバグ警告にメタ情報を設定することができます。このコマンドには次に示すオプションがあります:</para>
<para>この機能は、 ant からも使用することができます。まず次に示すように、ビルドファイルに <command>setBugDatabaseInfo</command> を taskdef で定義します :</para>
@@ -2192,76 +2192,76 @@
]]>
</programlisting>
- <table id="setBugDatabaseInfoOptions">
- <title>setBugDatabaseInfo オプション一覧</title>
- <tgroup cols="3" align="left">
- <thead>
- <row>
- <entry>コマンドラインオプション</entry>
- <entry>Ant 属性</entry>
- <entry>目的</entry>
- </row>
- </thead>
- <tbody>
- <row><entry/> <entry>input="<file>"</entry> <entry>入力ファイルを指定します。</entry></row>
- <row><entry/> <entry>output="<file>"</entry> <entry>出力ファイルを指定します。</entry></row>
- <row><entry>-name <name></entry> <entry>name="<name>"</entry> <entry>最新リビジョンの名前を設定します。</entry></row>
- <row><entry>-timestamp <when></entry> <entry>timestamp="<when>"</entry> <entry>最新リビジョンのタイム・スタンプを設定します。</entry></row>
- <row><entry>-source <directory></entry> <entry>source="<directory>"</entry> <entry>ソースを検索するディレクトリーを追加指定します。</entry></row>
- <row><entry>-findSource <directory></entry> <entry>findSource="<directory>"</entry> <entry>指定したディレクトリー内を検索して関連するソースの場所を追加します。</entry></row>
- <row><entry>-suppress <filter file></entry> <entry>suppress="<filter file>"</entry> <entry>指定したファイルに一致する警告を抑止します (以前に指定した抑止設定は置き換えられます)。</entry></row>
- <row><entry>-withMessages</entry> <entry>withMessages="[true|false]"</entry> <entry>XMLにテキストメッセージを追加します。</entry></row>
- <row><entry>-resetSource</entry> <entry>resetSource="[true|false]"</entry> <entry>ソース検索パスをすべて削除します。</entry></row>
- </tbody>
- </tgroup>
- </table>
- </sect2>
-
- <sect2 id="listBugDatabaseInfo">
- <title>listBugDatabaseInfo</title>
-
- <para>このコマンドの実行においては、コマンドラインで 0 個以上の xml バグデータベースファイル名を指定します。ファイル名を1つも指定しなければ、標準出力から読み込みを行いテーブルのヘッダーは生成されません。</para>
+ <table id="setBugDatabaseInfoOptions">
+ <title>setBugDatabaseInfo オプション一覧</title>
+ <tgroup cols="3" align="left">
+ <thead>
+ <row>
+ <entry>コマンドラインオプション</entry>
+ <entry>Ant 属性</entry>
+ <entry>目的</entry>
+ </row>
+ </thead>
+ <tbody>
+ <row><entry/> <entry>input="<file>"</entry> <entry>入力ファイルを指定します。</entry></row>
+ <row><entry/> <entry>output="<file>"</entry> <entry>出力ファイルを指定します。</entry></row>
+ <row><entry>-name <name></entry> <entry>name="<name>"</entry> <entry>最新リビジョンの名前を設定します。</entry></row>
+ <row><entry>-timestamp <when></entry> <entry>timestamp="<when>"</entry> <entry>最新リビジョンのタイム・スタンプを設定します。</entry></row>
+ <row><entry>-source <directory></entry> <entry>source="<directory>"</entry> <entry>ソースを検索するディレクトリーを追加指定します。</entry></row>
+ <row><entry>-findSource <directory></entry> <entry>findSource="<directory>"</entry> <entry>指定したディレクトリー内を検索して関連するソースの場所を追加します。</entry></row>
+ <row><entry>-suppress <filter file></entry> <entry>suppress="<filter file>"</entry> <entry>指定したファイルに一致する警告を抑止します (以前に指定した抑止設定は置き換えられます)。</entry></row>
+ <row><entry>-withMessages</entry> <entry>withMessages="[true|false]"</entry> <entry>XMLにテキストメッセージを追加します。</entry></row>
+ <row><entry>-resetSource</entry> <entry>resetSource="[true|false]"</entry> <entry>ソース検索パスをすべて削除します。</entry></row>
+ </tbody>
+ </tgroup>
+ </table>
+ </sect2>
+
+ <sect2 id="listBugDatabaseInfo">
+ <title>listBugDatabaseInfo</title>
+
+ <para>このコマンドの実行においては、コマンドラインで 0 個以上の xml バグデータベースファイル名を指定します。ファイル名を1つも指定しなければ、標準出力から読み込みを行いテーブルのヘッダーは生成されません。</para>
<para>このコマンドには 1 つだけオプションがあります : <option>-formatDates</option> を指定するとテキスト形式でデータが描画されます。</para>
-
-<para>出力される表は、各バグデータベースごとに行を持ち、次に示すカラムから成ります :</para>
- <table id="listBugDatabaseInfoColumns">
- <title>listBugDatabaseInfo カラム一覧</title>
- <tgroup cols="2" align="left">
- <thead>
- <row>
- <entry>カラム</entry>
- <entry>目的</entry>
- </row>
- </thead>
- <tbody>
- <row><entry>version</entry><entry>バージョン名</entry></row>
- <row><entry>time</entry><entry>リリースされた日時</entry></row>
- <row><entry>classes</entry><entry>分析されたクラス数</entry></row>
- <row><entry>NCSS</entry><entry>コメント文を除いた命令数 (Non Commenting Source Statements)</entry></row>
- <row><entry>total</entry><entry>全警告数</entry></row>
- <row><entry>high</entry><entry>優先度(高)の警告の総数</entry></row>
- <row><entry>medium</entry><entry>優先度(中)の警告の総数</entry></row>
- <row><entry>low</entry><entry>優先度(低)の警告の総数</entry></row>
- <row><entry>filename</entry><entry>データベースのファイル名</entry></row>
-<!--
- <row><entry></entry><entry></entry></row>
- <row><entry></entry><entry></entry></row>
- <row><entry></entry><entry></entry></row>
- <row><entry></entry><entry></entry></row>
- <row><entry></entry><entry></entry></row>
- <row><entry></entry><entry></entry></row>
--->
- </tbody>
- </tgroup>
- </table>
-
- </sect2>
- </sect1>
-
- <sect1 id="examples">
- <title>例</title>
+<para>出力される表は、各バグデータベースごとに行を持ち、次に示すカラムから成ります :</para>
+ <table id="listBugDatabaseInfoColumns">
+ <title>listBugDatabaseInfo カラム一覧</title>
+ <tgroup cols="2" align="left">
+ <thead>
+ <row>
+ <entry>カラム</entry>
+ <entry>目的</entry>
+ </row>
+ </thead>
+ <tbody>
+ <row><entry>version</entry><entry>バージョン名</entry></row>
+ <row><entry>time</entry><entry>リリースされた日時</entry></row>
+ <row><entry>classes</entry><entry>分析されたクラス数</entry></row>
+ <row><entry>NCSS</entry><entry>コメント文を除いた命令数 (Non Commenting Source Statements)</entry></row>
+ <row><entry>total</entry><entry>全警告数</entry></row>
+ <row><entry>high</entry><entry>優先度(高)の警告の総数</entry></row>
+ <row><entry>medium</entry><entry>優先度(中)の警告の総数</entry></row>
+ <row><entry>low</entry><entry>優先度(低)の警告の総数</entry></row>
+ <row><entry>filename</entry><entry>データベースのファイル名</entry></row>
+<!--
+ <row><entry></entry><entry></entry></row>
+ <row><entry></entry><entry></entry></row>
+ <row><entry></entry><entry></entry></row>
+ <row><entry></entry><entry></entry></row>
+ <row><entry></entry><entry></entry></row>
+ <row><entry></entry><entry></entry></row>
+-->
+ </tbody>
+ </tgroup>
+ </table>
+
+ </sect2>
+
+ </sect1>
+
+ <sect1 id="examples">
+ <title>例</title>
<sect2 id="unixscriptsexamples">
<title>提供されたシェル・スクリプトを使用しての履歴マイニング</title>
<para>以下はすべて、 jdk1.6.0-b12, jdk1.6.0-b13, ..., jdk1.6.0-b60 のディレクトリに対してコマンドを実行しています。</para>
@@ -2271,7 +2271,7 @@
computeBugHistory jdk1.6.0-b* | filterBugs -bugPattern IL_ | mineBugHistory -formatDates
</screen>
<para>すると、次のような出力が行われます :</para>
-
+
<screen>
seq version time classes NCSS added newCode fixed removed retained dead active
0 jdk1.6.0-b12 "Thu Nov 11 09:07:20 EST 2004" 13128 811569 0 4 0 0 0 0 4
@@ -2392,16 +2392,16 @@
</sect2>
<sect2 id="incrementalhistory">
- <title>増分履歴メンテナンス</title>
+ <title>増分履歴メンテナンス</title>
<para>仮に、 db.xml がビルド b12 - b60 に対する findbugs 実行結果を保持している場合、次に示すコマンドを実行することで、 db.xml に b61 に対する実行結果を追加することができます :</para>
<screen>
computeBugHistory -output db.xml db.xml jdk1.6.0-b61/jre/lib/rt.xml
</screen>
</sect2>
-
- </sect1>
-
+
+ </sect1>
+
<sect1 id="antexample">
<title>Ant の例</title>
<para>findbugs の実行とその後のデータ・マイニングツールの活用の両方を実行している ant スクリプトの完全な例を以下に示します :</para>
@@ -2412,12 +2412,12 @@
<property name="findbugs.home" value="/Users/ben/Documents/workspace/findbugs/findbugs" />
<property name="jvmargs" value="-server -Xss1m -Xmx800m -Duser.language=en -Duser.region=EN -Dfindbugs.home=${findbugs.home}" />
- <path id="findbugs.lib">
+ <path id="findbugs.lib">
<fileset dir="${findbugs.home}/lib">
<include name="findbugs-ant.jar"/>
</fileset>
</path>
-
+
<taskdef name="findbugs" classname="edu.umd.cs.findbugs.anttask.FindBugsTask">
<classpath refid="findbugs.lib" />
</taskdef>
@@ -2463,10 +2463,10 @@
<!-- 最新の分析結果に情報を設定する -->
<setBugDatabaseInfo home="${findbugs.home}"
- withMessages="true"
- name="asm-util-3.0.jar"
- input="out.xml"
- output="out-rel.xml"/>
+ withMessages="true"
+ name="asm-util-3.0.jar"
+ input="out.xml"
+ output="out-rel.xml"/>
<!-- 履歴ファイル (out-hist.xml) が既に存在するかどうかを確認する -->
<condition property="mining.historyfile.available">
@@ -2500,18 +2500,18 @@
<target name="history" if="mining.historyfile.available">
<!-- ${data.file} を ${hist.file} にマージします -->
<computeBugHistory home="${findbugs.home}"
- withMessages="true"
- output="${hist.file}">
- <dataFile name="${hist.file}"/>
- <dataFile name="${data.file}"/>
+ withMessages="true"
+ output="${hist.file}">
+ <dataFile name="${hist.file}"/>
+ <dataFile name="${data.file}"/>
</computeBugHistory>
<!-- 履歴を算出して ${hist.summary.file} に出力します -->
<mineBugHistory home="${findbugs.home}"
- formatDates="true"
+ formatDates="true"
noTabs="true"
- input="${hist.file}"
- output="${hist.summary.file}"/>
+ input="${hist.file}"
+ output="${hist.summary.file}"/>
</target>
</project>
@@ -2622,42 +2622,42 @@
<para>Greg Bentz provided a fix for the hashcode/equals detector.</para>
<para>K. Hashimoto contributed internationalization fixes and several other
- bug fixes.</para>
+ bug fixes.</para>
<para>
- Glenn Boysko contributed support for ignoring specified local
- variables in the dead local store detector.
-</para>
-
-<para>
- Jay Dunning contributed a detector to find equality comparisons
- of floating-point values, and overhauled the analysis summary
- report and its representation in the saved XML format.
+ Glenn Boysko contributed support for ignoring specified local
+ variables in the dead local store detector.
</para>
<para>
- Olivier Parent contributed updated French translations for bug descriptions and
- Swing GUI.
+ Jay Dunning contributed a detector to find equality comparisons
+ of floating-point values, and overhauled the analysis summary
+ report and its representation in the saved XML format.
</para>
<para>
- Chris Nappin contributed the <filename>plain.xsl</filename>
- stylesheet.
+ Olivier Parent contributed updated French translations for bug descriptions and
+ Swing GUI.
</para>
<para>
- Etienne Giraudy contributed the <filename>fancy.xsl</filename> and <filename>fancy-hist.xsl</filename>
- stylesheets, and made improvements to the <command>-xml:withMessages</command>
- option.
+ Chris Nappin contributed the <filename>plain.xsl</filename>
+ stylesheet.
</para>
-
+
<para>
- Takashi Okamoto fixed bugs in the project preferences dialog
- in the Eclipse plugin, and contributed to its internationalization and localization.
+ Etienne Giraudy contributed the <filename>fancy.xsl</filename> and <filename>fancy-hist.xsl</filename>
+ stylesheets, and made improvements to the <command>-xml:withMessages</command>
+ option.
</para>
-
+
+<para>
+ Takashi Okamoto fixed bugs in the project preferences dialog
+ in the Eclipse plugin, and contributed to its internationalization and localization.
+</para>
+
<para>Thomas Einwaller fixed bugs in the project preferences dialog in the Eclipse plugin.</para>
-
+
<para>Jeff Knox contributed support for the warningsProperty attribute
in the Ant task.</para>
@@ -2666,7 +2666,7 @@
<para>Mark McKay contributed an Ant task to launch the findbugs frame.</para>
-<para>Dieter von Holten (dvholten) contributed
+<para>Dieter von Holten (dvholten) contributed
some German improvements to findbugs_de.properties.</para>
@@ -2746,7 +2746,7 @@
<blockquote>
<para>
-Copyright 2001 (C) MetaStuff, Ltd. All Rights Reserved.
+Copyright 2001 (C) MetaStuff, Ltd. All Rights Reserved.
</para>
<para>
@@ -2803,4 +2803,4 @@
</chapter>
-</book>
\ No newline at end of file
+</book>
diff --git a/tools/findbugs/doc/performance.html b/tools/findbugs/doc/performance.html
new file mode 100644
index 0000000..12718f0
--- /dev/null
+++ b/tools/findbugs/doc/performance.html
@@ -0,0 +1,114 @@
+<html>
+<head>
+<title>FindBugs Performance Improvements and Regressions</title>
+<link rel="stylesheet" type="text/css" href="findbugs.css">
+
+</head>
+<body>
+
+ <table width="100%">
+ <tr>
+
+
+<td bgcolor="#b9b9fe" valign="top" align="left" width="20%">
+<table width="100%" cellspacing="0" border="0">
+<tr><td><a class="sidebar" href="index.html"><img src="umdFindbugs.png" alt="FindBugs"></a></td></tr>
+
+<tr><td> </td></tr>
+
+<tr><td><b>Docs and Info</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="findbugs2.html">FindBugs 2.0</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="factSheet.html">Fact sheet</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="manual/index.html">Manual</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="ja/manual/index.html">Manual(ja/日本語)</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="FAQ.html">FAQ</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="bugDescriptions.html">Bug descriptions</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="mailingLists.html">Mailing lists</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="publications.html">Documents and Publications</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="links.html">Links</a></font></td></tr>
+
+<tr><td> </td></tr>
+
+<tr><td><a class="sidebar" href="downloads.html"><b>Downloads</b></a></td></tr>
+
+<tr><td> </td></tr>
+
+<tr><td><a class="sidebar" href="http://www.cafeshops.com/findbugs"><b>FindBugs Swag</b></a></td></tr>
+
+<tr><td> </td></tr>
+
+<tr><td><b>Development</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://sourceforge.net/tracker/?group_id=96405">Open bugs</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="reportingBugs.html">Reporting bugs</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="contributing.html">Contributing</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="team.html">Dev team</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="api/index.html">API</a> <a class="sidebar" href="api/overview-summary.html">[no frames]</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="Changes.html">Change log</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://sourceforge.net/projects/findbugs">SF project page</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://code.google.com/p/findbugs/source/browse/">Browse source</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://code.google.com/p/findbugs/source/list">Latest code changes</a></font></td></tr>
+</table>
+</td>
+
+ <td align="left" valign="top">
+
+ <h1>FindBugs Performance Improvements and Regressions</h1> I did a performance check against 179
+ benchmarks applications I regularly test against. Overall (total the total time to analyze all 179
+ benchmarks), FindBugs 2.0 gives a 9% performance improvement over 1.3.9. 154 of the 179 benchmarks saw
+ performance improvements; 24 saw regressions. All of the benchmarks that saw regressions of more than
+ 10% were small benchmarks (analyzed in less than 60 seconds), which makes consistent benchmarking
+ particularly difficult. I'm working to repeat the benchmarks, see if the results are consistent. I took
+ a look, and couldn't find anything that stood out as being a performance glitch in FindBugs. I haven't
+ yet done benchmarking with constrained memory. It is possible that you may need to increase the heap
+ size for FindBugs 2.0.
+
+ <h2>Important Request</h2>
+ <p> If you are seeing any significant performance regressions in FindBugs 2.0,
+ I very much need your help. Please either email <a href="mailto:findbugs@cs.umd.edu">findbugs@cs.umd.edu</a>
+ or file <a href="http://sourceforge.net/tracker/?atid=614693&group_id=96405&func=browse">a
+ bug report</a>. with the following information from the xml file for your project (from both the
+ 1.3.9 and 2.0.0 version if possible). Sending me your code or pointing me to a open source repository
+ would be great, but I know that isn't feasible for a lot of projects. The information I'm requesting
+ doesn't include any information about the code being analyzed other than the total size of the code
+ being analyzed and the total number of issues found at the different confidence levels. The
+ <FindBugsSummary ... > start tag. For example: <quote> <pre>
+ <FindBugsSummary timestamp="Tue, 30 Dec 2008 21:29:52 -0500"
+ total_classes="206" referenced_classes="325" total_bugs="72" total_size="7654" num_packages="21"
+ vm_version="20.4-b02-402" cpu_seconds="62.52" clock_seconds="22.01"
+ peak_mbytes="112.21" alloc_mbytes="1683.38" gc_seconds="1.19"
+ priority_3="56" priority_2="14" priority_1="2">
+</pre> </quote> The <FindBugsProfile>...</FindBugsProfile> element. For example: <quote>
+ <pre>
+ <FindBugsProfile>
+ <ClassProfile name="edu.umd.cs.findbugs.detect.IncompatMask" totalMilliseconds="11"
+ invocations="206" avgMicrosecondsPerInvocation="55" maxMicrosecondsPerInvocation="475"
+ standardDeviationMircosecondsPerInvocation="75"/>
+ <ClassProfile name="edu.umd.cs.findbugs.detect.FindFinalizeInvocations" totalMilliseconds="11"
+ invocations="206" avgMicrosecondsPerInvocation="55" maxMicrosecondsPerInvocation="402"
+ standardDeviationMircosecondsPerInvocation="69"/>
+ <ClassProfile name="edu.umd.cs.findbugs.classfile.engine.bcel.LockDataflowFactory" totalMilliseconds="11"
+ invocations="23" avgMicrosecondsPerInvocation="515" maxMicrosecondsPerInvocation="2637"
+ standardDeviationMircosecondsPerInvocation="639"/>
+ ...
+ </FindBugsProfile>
+</pre> </quote>
+<hr> <p>
+<script language="JavaScript" type="text/javascript">
+<!---//hide script from old browsers
+document.write( "Last updated "+ document.lastModified + "." );
+//end hiding contents --->
+</script>
+<p> Send comments to <a class="sidebar" href="mailto:findbugs@cs.umd.edu">findbugs@cs.umd.edu</a>
+<p>
+<A href="http://sourceforge.net"><IMG src="http://sourceforge.net/sflogo.php?group_id=96405&type=5" width="210" height="62" border="0" alt="SourceForge.net Logo" /></A>
+
+ </td>
+
+ </tr>
+ </table>
+
+</body>
+</html>
diff --git a/tools/findbugs-1.3.9/doc/performingARelease.txt b/tools/findbugs/doc/performingARelease.txt
similarity index 100%
rename from tools/findbugs-1.3.9/doc/performingARelease.txt
rename to tools/findbugs/doc/performingARelease.txt
diff --git a/tools/findbugs/doc/pluginStructure.txt b/tools/findbugs/doc/pluginStructure.txt
new file mode 100644
index 0000000..f61e983
--- /dev/null
+++ b/tools/findbugs/doc/pluginStructure.txt
@@ -0,0 +1,28 @@
+
+We have a list of plugins.
+
+In any particular context, some plugins are enabled.
+
+DetectorFactoryCollection:
+ Core plugin
+ Collection of plugins
+ Collection of DetectorFactories
+ Adjustment ranker
+
+I18N
+ ResourceBundles
+ bugPatternMap
+ bugCodeMap
+ categoryDescriptionMap
+
+Plugin
+ collection of DetectorFactory
+ bug patterns, codes, etc.
+ component plugins
+ bug ranker
+ enabled
+ plugin loader
+
+CloudFactory
+ registeredClouds
+
diff --git a/tools/findbugs/doc/plugins.txt b/tools/findbugs/doc/plugins.txt
new file mode 100644
index 0000000..a307b14
--- /dev/null
+++ b/tools/findbugs/doc/plugins.txt
@@ -0,0 +1,9 @@
+
+Plugins can be specified in three different ways:
+* For a standard FindBugd distro, they can be put into the plugins directory
+* For a JAWS distro, the file pluginlist.properties contains
+ a list of URLs to plugins. These URLs can be relative or absolute. If they
+ are absolute, they are relative to jar file that contained the pluginlist.properties
+ file.
+* You can define properties findbugs.plugin.*. Each such property defines a URL
+ for a plugin
diff --git a/tools/findbugs-1.3.9/doc/pressRelease.pdf b/tools/findbugs/doc/pressRelease.pdf
similarity index 100%
rename from tools/findbugs-1.3.9/doc/pressRelease.pdf
rename to tools/findbugs/doc/pressRelease.pdf
Binary files differ
diff --git a/tools/findbugs-1.3.9/doc/publications.html b/tools/findbugs/doc/publications.html
similarity index 98%
rename from tools/findbugs-1.3.9/doc/publications.html
rename to tools/findbugs/doc/publications.html
index a914b1e..2a06a19 100644
--- a/tools/findbugs-1.3.9/doc/publications.html
+++ b/tools/findbugs/doc/publications.html
@@ -16,6 +16,7 @@
<tr><td> </td></tr>
<tr><td><b>Docs and Info</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="findbugs2.html">FindBugs 2.0</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
diff --git a/tools/findbugs-1.3.9/doc/reportingBugs.html b/tools/findbugs/doc/reportingBugs.html
similarity index 97%
rename from tools/findbugs-1.3.9/doc/reportingBugs.html
rename to tools/findbugs/doc/reportingBugs.html
index d4a94db..c2bd70b 100644
--- a/tools/findbugs-1.3.9/doc/reportingBugs.html
+++ b/tools/findbugs/doc/reportingBugs.html
@@ -16,6 +16,7 @@
<tr><td> </td></tr>
<tr><td><b>Docs and Info</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="findbugs2.html">FindBugs 2.0</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
diff --git a/tools/findbugs-1.3.9/doc/mailingLists.html b/tools/findbugs/doc/sourceInfo.html
similarity index 68%
copy from tools/findbugs-1.3.9/doc/mailingLists.html
copy to tools/findbugs/doc/sourceInfo.html
index 08cba2f..3b847d0 100644
--- a/tools/findbugs-1.3.9/doc/mailingLists.html
+++ b/tools/findbugs/doc/sourceInfo.html
@@ -1,8 +1,7 @@
<html>
<head>
-<title>FindBugs Mailing Lists</title>
+<title>FindBugs sourceInfo file</title>
<link rel="stylesheet" type="text/css" href="findbugs.css">
-
</head>
<body>
@@ -16,6 +15,7 @@
<tr><td> </td></tr>
<tr><td><b>Docs and Info</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="findbugs2.html">FindBugs 2.0</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
@@ -53,17 +53,48 @@
<td align="left" valign="top">
-<h1>FindBugs Mailing Lists</h1>
+<h1>FindBugs sourceInfo file</h1>
-<p> There are two mailing lists for FindBugs.
+<p>The FindBugs analysis engine can be invoked with an optional sourceInfo
+file. This file gives line number ranges for classes, files and methods. This
+information is an alternative to getting line number information
+from the classfiles for methods. Since classfiles only contain line number
+information
+for methods, without a sourceInfo file we can't provide line numbers for fields,
+and for classes we just use the line numbers of the methods in the class.
+
+<p>The first line of the file should be
+<pre>
+sourceInfo version 1.0
+</pre>
+
+<p>Following that are a series of lines, each describing a class, field, or method. For each, a starting and ending line number is provided. For example, the following sourceInfo file:
+<pre>
+sourceInfo version 1.0
+a.C,3,8
+a.C,x,4,4
+a.C,y,4,4
+a.C,<init>()V,8,8
+a.C,f(I)I,5,5
+a.C,g(Ljava/lang/Object;)I,6,7
+</pre>
+provides the following information about the class a.C:
<ul>
-<li> <a href="http://www.cs.umd.edu/mailman/listinfo/findbugs-announce">Findbugs-announce</a>
-is a low volume (moderated) list for announcements of new releases.
-</li><li> <a href="http://www.cs.umd.edu/mailman/listinfo/findbugs-discuss">Findbugs-discuss</a>
-is for discussion of planned features, bugs, development issues, etc. Note
-that you must be a subscriber in order to post messages to the list.
-</li>
+<li> fields x and y are both declared on line 4.
+<li> the method <code>int f(int)</code> is defined on line 5.
+<li> the method <code>int g(Object)</code> is defined on lines 6-7.
+<li> the void constructor for a.C is defined on line 8.
</ul>
+The classnames should be the same format as used by Class.getName():
+packages are separated by ., inner class names are separated by $.
+Thus, if the class a.C had an inner class X and it was onb lines 10-15 of the file, the sourceInfo file might contain:
+
+<pre>
+a.C$X,10,15
+</pre>
+
+
+</table>
<hr> <p>
diff --git a/tools/findbugs-1.3.9/doc/sysprops.html b/tools/findbugs/doc/sysprops.html
similarity index 98%
rename from tools/findbugs-1.3.9/doc/sysprops.html
rename to tools/findbugs/doc/sysprops.html
index c8bcb87..ad55622 100644
--- a/tools/findbugs-1.3.9/doc/sysprops.html
+++ b/tools/findbugs/doc/sysprops.html
@@ -15,6 +15,7 @@
<tr><td> </td></tr>
<tr><td><b>Docs and Info</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="findbugs2.html">FindBugs 2.0</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
@@ -96,10 +97,6 @@
<td>Report on local variables that mask fields.</td>
</tr>
<tr>
- <td>findbugs.noSummary</td>
- <td>Don't create the report summary</td>
- </tr>
- <tr>
<td>findbugs.nullderef.assumensp</td>
<td>sets value for IsNullValueAnalysisFeatures.UNKNOWN_VALUES_ARE_NSP, but is not used by FindBugs</td>
</tr>
diff --git a/tools/findbugs-1.3.9/doc/team.html b/tools/findbugs/doc/team.html
similarity index 84%
rename from tools/findbugs-1.3.9/doc/team.html
rename to tools/findbugs/doc/team.html
index 23fdf3a..a97f46c 100644
--- a/tools/findbugs-1.3.9/doc/team.html
+++ b/tools/findbugs/doc/team.html
@@ -16,6 +16,7 @@
<tr><td> </td></tr>
<tr><td><b>Docs and Info</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="findbugs2.html">FindBugs 2.0</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
@@ -55,13 +56,21 @@
<h1>FindBugs Development Team</h1>
-<p> These are the current members of the FindBugs development team:
+<p> These are the current active members of the FindBugs development team:
<ul>
-<li> Bill Pugh (project admin)
-<li> David Hovemeyer (project admin)
-<li> Ben Langmead (project admin)
-<li> Andrei Loskutov (Eclipse plugin)
+<li> <a href="http://www.cs.umd.edu/~pugh">Bill Pugh</a> (project lead and primary developer)
+<li> <a href="http://andrei.gmxhome.de/privat.html">Andrey Loskutov</a>(Eclipse plugin)
+<li> <a href="http://keithlea.com">Keith Lea</a> (web cloud)
+</li>
+</ul>
+
+<p>Previous and/or inactive members of the FindBugs development team include
+<ul>
+<li> <a href="http://goose.ycp.edu/~dhovemey/">David Hovemeyer</a> (project founder),
+ did Ph.D. thesis on FindBugs
+<li> Nay Ayewah
+<li> Ben Langmead
<li> Tomas Pollak (Eclipse plugin tests)
<li> Phil Crosby
<li> Peter Friese (Eclipse plugin)
diff --git a/tools/findbugs-1.3.9/doc/umdFindbugs.png b/tools/findbugs/doc/umdFindbugs.png
similarity index 100%
rename from tools/findbugs-1.3.9/doc/umdFindbugs.png
rename to tools/findbugs/doc/umdFindbugs.png
Binary files differ
diff --git a/tools/findbugs/doc/updateChecking.html b/tools/findbugs/doc/updateChecking.html
new file mode 100644
index 0000000..85384c3
--- /dev/null
+++ b/tools/findbugs/doc/updateChecking.html
@@ -0,0 +1,123 @@
+<html>
+<head>
+<title>Update checking in FindBugs</title>
+<link rel="stylesheet" type="text/css" href="findbugs.css" />
+
+</head>
+
+<body>
+
+ <table width="100%">
+ <tr>
+
+
+<td bgcolor="#b9b9fe" valign="top" align="left" width="20%">
+<table width="100%" cellspacing="0" border="0">
+<tr><td><a class="sidebar" href="index.html"><img src="umdFindbugs.png" alt="FindBugs"></a></td></tr>
+
+<tr><td> </td></tr>
+
+<tr><td><b>Docs and Info</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="findbugs2.html">FindBugs 2.0</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="factSheet.html">Fact sheet</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="manual/index.html">Manual</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="ja/manual/index.html">Manual(ja/日本語)</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="FAQ.html">FAQ</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="bugDescriptions.html">Bug descriptions</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="mailingLists.html">Mailing lists</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="publications.html">Documents and Publications</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="links.html">Links</a></font></td></tr>
+
+<tr><td> </td></tr>
+
+<tr><td><a class="sidebar" href="downloads.html"><b>Downloads</b></a></td></tr>
+
+<tr><td> </td></tr>
+
+<tr><td><a class="sidebar" href="http://www.cafeshops.com/findbugs"><b>FindBugs Swag</b></a></td></tr>
+
+<tr><td> </td></tr>
+
+<tr><td><b>Development</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://sourceforge.net/tracker/?group_id=96405">Open bugs</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="reportingBugs.html">Reporting bugs</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="contributing.html">Contributing</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="team.html">Dev team</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="api/index.html">API</a> <a class="sidebar" href="api/overview-summary.html">[no frames]</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="Changes.html">Change log</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://sourceforge.net/projects/findbugs">SF project page</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://code.google.com/p/findbugs/source/browse/">Browse source</a></font></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="http://code.google.com/p/findbugs/source/list">Latest code changes</a></font></td></tr>
+</table>
+</td>
+
+ <td align="left" valign="top">
+
+ <h1>Update checking in FindBugs</h1>
+
+ <p>When FindBugs is run, it now checks for updated versions of FindBugs or plugins. As a side effect
+ of this, our server sees a request for whether there are any updated version of FindBugs available.
+ Third party plugins can independently receive this same information. We are recording
+ information about the operating system, Java version, locale, and Findbugs entry point (ant, command line,
+ GUI, etc), in order to better understand our users.
+
+ <p>For example, here is an example of the information that would be sent to the server:
+ <pre>
+<?xml version="1.0" encoding="UTF-8"?>
+
+<findbugs-invocation version="2.0.0-rc1" app-name="UpdateChecker" app-version="" entry-point="UpdateChecker" os="Mac OS X"
+ java-version="1.6" language="en" country="US" uuid="-4bcf8f48ba2842d2">
+ <plugin id="edu.umd.cs.findbugs.plugins.core" name="Core FindBugs plugin" version="2.0.0-rc1"/>
+ <plugin id="edu.umd.cs.findbugs.plugins.appengine" name="FindBugs Cloud Plugin" version=""/>
+ <plugin id="edu.umd.cs.findbugs.plugins.poweruser" name="Power user commnand line tools" version=""/>
+</findbugs-invocation>
+</pre>
+
+<p>You can run the main method of edu.umd.cs.findbugs.updates.UpdateChecker to see what would be reported
+for you, and whether update checking is disabled and/or redirected (e.g., run
+<pre> java -classpath ~/findbugs/lib/findbugs.jar edu.umd.cs.findbugs.updates.UpdateChecker</pre>
+
+<p>There is one element of the information sent that needs explanation: the uuid. Since we don't report anything like username,
+when we receive a bunch of update checks from a particular ip address, we don't know if that is one person running FindBugs many times
+on a single machine, or many users running FindBugs on many different machines So we generate a random 64 bit integer,
+store it in the Java user preferences, and report that on each use.
+
+<h2>Disabling or redirecting update checks</h2>
+<p>Some organizations or individuals may have policies or preferences to not let us know any information about
+their running of FindBugs. Note that we do not collect any information about the code being analuzed.
+Even so, we understand that is very important for a few of our users,
+ and provide several ways for you to disable or redirect FindBugs update checks.
+<ul>
+<li>There is a FindBugs plugin, noUpdateChecks.jar, which is in findbugs/optionalPlugin in the standard distribution.
+If this plugin enabled, all update checks are disabled. You can move that plugin from findbugs/optionalPlugin to findbugs/plugin,
+to disable it for all users of that distribution. You can also copy it to <pre>~/.findbugs/plugin</pre>,
+which will disable it for your account for any distribution of FindBugs you invoke (NOTE: double check location
+of personal FindBugs plugin installation for Windows User).
+<li>There are noUpdateChecks distributions of FindBugs available from SourceForge. This come with the noUpdateChecks plugin
+already moved to findbugs/plugin, and the webCloudClient.jar plug in the optional plugin directory (where it is disabled by default).
+
+<li>You can also redirect all update checks to a local server. This allows you to collect information about who is using
+what versions of FindBugs in your organization, and keep all of that information private.
+<li>All of the plugins from the FindBugs project use <pre>http://update.findbugs.org/update-check</pre> as the
+host we use for update checks. If you wish to ensure that no one from your organization accidently reports any usage
+information to the FindBugs project, you can blacklist that URL in your firewall
+<ul>
+<li>You can also block <pre>http://findbugs-cloud.appspot.com</pre>, the host we use for our publicly hosted
+repository of bug evaluations (e.g., evaluations in open source projects such as the JDK, Eclipse and GlassFish).
+While people have to explicitly request that their evaluations be stored into the FindBugs cloud, you
+can block it to ensure that no one accidently shares evaluations of your own code to the FindBugs cloud. You can also
+remove the WebCloudClient
+
+</ul>
+</li>
+</ul>
+
+
+ </tr>
+ </table>
+
+</body>
+</html>
diff --git a/tools/findbugs-1.3.9/doc/users.html b/tools/findbugs/doc/users.html
similarity index 97%
rename from tools/findbugs-1.3.9/doc/users.html
rename to tools/findbugs/doc/users.html
index a9641ff..37efe15 100644
--- a/tools/findbugs-1.3.9/doc/users.html
+++ b/tools/findbugs/doc/users.html
@@ -18,6 +18,7 @@
<tr><td> </td></tr>
<tr><td><b>Docs and Info</b></td></tr>
+<tr><td><font size="-1"><a class="sidebar" href="findbugs2.html">FindBugs 2.0</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="demo.html">Demo and data</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="users.html">Users and supporters</a></font></td></tr>
<tr><td><font size="-1"><a class="sidebar" href="http://findbugs.blogspot.com/">FindBugs blog</a></font></td></tr>
@@ -149,14 +150,7 @@
</p>
<table cellpadding="10pt" align="center">
- <tr>
- <td align="center">
- <a href="http://www.surelogic.com/findbugs"><img
- src="surelogic.png" alt="SureLogic">
- </a>
- </td>
- </tr>
-
+
<tr>
<td align="center">
<a href="http://www.google.com"><img
diff --git a/tools/findbugs/lib/.cvsignore b/tools/findbugs/lib/.cvsignore
new file mode 100644
index 0000000..5eb85a8
--- /dev/null
+++ b/tools/findbugs/lib/.cvsignore
@@ -0,0 +1,13 @@
+*.bugs
+*.count
+findbugs-ant.jar
+findbugs.jar
+findbugsGUI.jar
+findbugsAttributes.jar
+findbugsAnnotations.jar
+oneFourCompatibility.jar
+foo
+log
+foo2
+*.categories
+annotations.jar
diff --git a/tools/findbugs/lib/.ignorethis b/tools/findbugs/lib/.ignorethis
new file mode 100644
index 0000000..e69de29
--- /dev/null
+++ b/tools/findbugs/lib/.ignorethis
diff --git a/tools/findbugs/lib/AppleJavaExtensions.jar b/tools/findbugs/lib/AppleJavaExtensions.jar
new file mode 100644
index 0000000..160d62b
--- /dev/null
+++ b/tools/findbugs/lib/AppleJavaExtensions.jar
Binary files differ
diff --git a/tools/findbugs/lib/LICENSE_AppleJavaExtensions.txt b/tools/findbugs/lib/LICENSE_AppleJavaExtensions.txt
new file mode 100644
index 0000000..ee60804
--- /dev/null
+++ b/tools/findbugs/lib/LICENSE_AppleJavaExtensions.txt
@@ -0,0 +1,67 @@
+
+AppleJavaExtensions
+v 1.2
+
+ http://developer.apple.com/samplecode/AppleJavaExtensions/AppleJavaExtensions.html
+
+This is a pluggable jar of stub classes representing the new Apple
+eAWT and eIO APIs for Java 1.4 on Mac OS X. The purpose of these
+stubs is to allow for compilation of eAWT- or eIO-referencing code on
+platforms other than Mac OS X. These stubs are not intended for the
+runtime classpath on non-Mac platforms. Please see the OSXAdapter
+sample for how to write cross-platform code that uses eAWT.
+
+There is no license file provided for AppleJavaExtensions.jar. Below
+is a response from Apple to a question about the license.
+
+On 13 Aug 2004, at 12:33 AM, mdrance@apple.com wrote:
+
+> Thank you for bringing this up. AppleJavaExtensions is subject to all
+> the same terms as the other sample code projects from Apple. We will
+> update the readme to contain the boilerplate legal info. Of course you
+> can use them on other platforms -- the readme explicitly says this is
+> their purpose. But I appreciate your caution and attention to detail.
+
+Below is a copy of the standard Apple sample code disclaimer from another
+piece of sample code on the same site:
+
+-------------------------------------------------------------------------
+Disclaimer: IMPORTANT: This Apple software is supplied to you by Apple
+Computer, Inc. ("Apple") in consideration of your agreement to the
+following terms, and your use, installation, modification or
+redistribution of this Apple software constitutes acceptance of these
+terms. If you do not agree with these terms, please do not use,
+install, modify or redistribute this Apple software.
+
+In consideration of your agreement to abide by the following terms, and
+subject to these terms, Apple grants you a personal, non-exclusive
+license, under Apple's copyrights in this original Apple software (the
+"Apple Software"), to use, reproduce, modify and redistribute the Apple
+Software, with or without modifications, in source and/or binary forms;
+provided that if you redistribute the Apple Software in its entirety and
+without modifications, you must retain this notice and the following
+text and disclaimers in all such redistributions of the Apple Software.
+Neither the name, trademarks, service marks or logos of Apple Computer,
+Inc. may be used to endorse or promote products derived from the Apple
+Software without specific prior written permission from Apple. Except
+as expressly stated in this notice, no other rights or licenses, express
+or implied, are granted by Apple herein, including but not limited to
+any patent rights that may be infringed by your derivative works or by
+other works in which the Apple Software may be incorporated.
+
+The Apple Software is provided by Apple on an "AS IS" basis. APPLE
+MAKES NO WARRANTIES, EXPRESS OR IMPLIED, INCLUDING WITHOUT LIMITATION
+THE IMPLIED WARRANTIES OF NON-INFRINGEMENT, MERCHANTABILITY AND FITNESS
+FOR A PARTICULAR PURPOSE, REGARDING THE APPLE SOFTWARE OR ITS USE AND
+OPERATION ALONE OR IN COMBINATION WITH YOUR PRODUCTS.
+
+IN NO EVENT SHALL APPLE BE LIABLE FOR ANY SPECIAL, INDIRECT, INCIDENTAL
+OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+INTERRUPTION) ARISING IN ANY WAY OUT OF THE USE, REPRODUCTION,
+MODIFICATION AND/OR DISTRIBUTION OF THE APPLE SOFTWARE, HOWEVER CAUSED
+AND WHETHER UNDER THEORY OF CONTRACT, TORT (INCLUDING NEGLIGENCE),
+STRICT LIABILITY OR OTHERWISE, EVEN IF APPLE HAS BEEN ADVISED OF THE
+POSSIBILITY OF SUCH DAMAGE.
+
+Copyright © 2004 Apple Computer, Inc., All Rights Reserved
diff --git a/tools/findbugs/lib/annotations.jar b/tools/findbugs/lib/annotations.jar
new file mode 100644
index 0000000..36c6dc5
--- /dev/null
+++ b/tools/findbugs/lib/annotations.jar
Binary files differ
diff --git a/tools/findbugs/lib/ant.jar b/tools/findbugs/lib/ant.jar
new file mode 100644
index 0000000..f68c9cf
--- /dev/null
+++ b/tools/findbugs/lib/ant.jar
Binary files differ
diff --git a/tools/findbugs/lib/asm-3.3.jar b/tools/findbugs/lib/asm-3.3.jar
new file mode 100644
index 0000000..7638ae0
--- /dev/null
+++ b/tools/findbugs/lib/asm-3.3.jar
Binary files differ
diff --git a/tools/findbugs/lib/asm-analysis-3.3.jar b/tools/findbugs/lib/asm-analysis-3.3.jar
new file mode 100644
index 0000000..852d981
--- /dev/null
+++ b/tools/findbugs/lib/asm-analysis-3.3.jar
Binary files differ
diff --git a/tools/findbugs/lib/asm-commons-3.3.jar b/tools/findbugs/lib/asm-commons-3.3.jar
new file mode 100644
index 0000000..6f9d40f
--- /dev/null
+++ b/tools/findbugs/lib/asm-commons-3.3.jar
Binary files differ
diff --git a/tools/findbugs/lib/asm-src-3.3.zip b/tools/findbugs/lib/asm-src-3.3.zip
new file mode 100644
index 0000000..fb8a940
--- /dev/null
+++ b/tools/findbugs/lib/asm-src-3.3.zip
Binary files differ
diff --git a/tools/findbugs/lib/asm-tree-3.3.jar b/tools/findbugs/lib/asm-tree-3.3.jar
new file mode 100644
index 0000000..4a5daa6
--- /dev/null
+++ b/tools/findbugs/lib/asm-tree-3.3.jar
Binary files differ
diff --git a/tools/findbugs/lib/asm-util-3.3.jar b/tools/findbugs/lib/asm-util-3.3.jar
new file mode 100644
index 0000000..115bcc7
--- /dev/null
+++ b/tools/findbugs/lib/asm-util-3.3.jar
Binary files differ
diff --git a/tools/findbugs/lib/asm-xml-3.3.jar b/tools/findbugs/lib/asm-xml-3.3.jar
new file mode 100644
index 0000000..61d6a8c
--- /dev/null
+++ b/tools/findbugs/lib/asm-xml-3.3.jar
Binary files differ
diff --git a/tools/findbugs/lib/bcel.jar b/tools/findbugs/lib/bcel.jar
new file mode 100644
index 0000000..fef26b1
--- /dev/null
+++ b/tools/findbugs/lib/bcel.jar
Binary files differ
diff --git a/tools/findbugs/lib/bug-logo.icns b/tools/findbugs/lib/bug-logo.icns
new file mode 100644
index 0000000..072b67a
--- /dev/null
+++ b/tools/findbugs/lib/bug-logo.icns
Binary files differ
diff --git a/tools/findbugs-1.3.9/lib/buggy.icns b/tools/findbugs/lib/buggy.icns
similarity index 100%
rename from tools/findbugs-1.3.9/lib/buggy.icns
rename to tools/findbugs/lib/buggy.icns
Binary files differ
diff --git a/tools/findbugs-1.3.9/lib/commons-lang-2.4.jar b/tools/findbugs/lib/commons-lang-2.4.jar
similarity index 100%
rename from tools/findbugs-1.3.9/lib/commons-lang-2.4.jar
rename to tools/findbugs/lib/commons-lang-2.4.jar
Binary files differ
diff --git a/tools/findbugs-1.3.9/lib/dom4j-1.6.1.jar b/tools/findbugs/lib/dom4j-1.6.1.jar
similarity index 100%
rename from tools/findbugs-1.3.9/lib/dom4j-1.6.1.jar
rename to tools/findbugs/lib/dom4j-1.6.1.jar
Binary files differ
diff --git a/tools/findbugs/lib/findbugs-ant.jar b/tools/findbugs/lib/findbugs-ant.jar
new file mode 100644
index 0000000..de156f9
--- /dev/null
+++ b/tools/findbugs/lib/findbugs-ant.jar
Binary files differ
diff --git a/tools/findbugs/lib/findbugs.jar b/tools/findbugs/lib/findbugs.jar
new file mode 100644
index 0000000..a8c22b2
--- /dev/null
+++ b/tools/findbugs/lib/findbugs.jar
Binary files differ
diff --git a/tools/findbugs/lib/jFormatString.jar b/tools/findbugs/lib/jFormatString.jar
new file mode 100644
index 0000000..62f6c02
--- /dev/null
+++ b/tools/findbugs/lib/jFormatString.jar
Binary files differ
diff --git a/tools/findbugs-1.3.9/lib/jaxen-1.1.1.jar b/tools/findbugs/lib/jaxen-1.1.1.jar
similarity index 100%
rename from tools/findbugs-1.3.9/lib/jaxen-1.1.1.jar
rename to tools/findbugs/lib/jaxen-1.1.1.jar
Binary files differ
diff --git a/tools/findbugs/lib/jcip-annotations.jar b/tools/findbugs/lib/jcip-annotations.jar
new file mode 100644
index 0000000..bb07c0c
--- /dev/null
+++ b/tools/findbugs/lib/jcip-annotations.jar
Binary files differ
diff --git a/tools/findbugs-1.3.9/lib/jdepend-2.9.jar b/tools/findbugs/lib/jdepend-2.9.jar
similarity index 100%
rename from tools/findbugs-1.3.9/lib/jdepend-2.9.jar
rename to tools/findbugs/lib/jdepend-2.9.jar
Binary files differ
diff --git a/tools/findbugs-1.3.9/lib/jsr305.jar b/tools/findbugs/lib/jsr305.jar
similarity index 69%
rename from tools/findbugs-1.3.9/lib/jsr305.jar
rename to tools/findbugs/lib/jsr305.jar
index a9afc66..43807b0 100644
--- a/tools/findbugs-1.3.9/lib/jsr305.jar
+++ b/tools/findbugs/lib/jsr305.jar
Binary files differ
diff --git a/tools/findbugs/lib/junit.jar b/tools/findbugs/lib/junit.jar
new file mode 100644
index 0000000..7339216
--- /dev/null
+++ b/tools/findbugs/lib/junit.jar
Binary files differ
diff --git a/tools/findbugs/lib/yjp-controller-api-redist.jar b/tools/findbugs/lib/yjp-controller-api-redist.jar
new file mode 100644
index 0000000..490695f
--- /dev/null
+++ b/tools/findbugs/lib/yjp-controller-api-redist.jar
Binary files differ
diff --git a/tools/findbugs-1.3.9/LICENSE-ASM.txt b/tools/findbugs/licenses/LICENSE-ASM.txt
similarity index 100%
rename from tools/findbugs-1.3.9/LICENSE-ASM.txt
rename to tools/findbugs/licenses/LICENSE-ASM.txt
diff --git a/tools/findbugs-1.3.9/LICENSE-AppleJavaExtensions.txt b/tools/findbugs/licenses/LICENSE-AppleJavaExtensions.txt
similarity index 100%
rename from tools/findbugs-1.3.9/LICENSE-AppleJavaExtensions.txt
rename to tools/findbugs/licenses/LICENSE-AppleJavaExtensions.txt
diff --git a/tools/findbugs-1.3.9/LICENSE-bcel.txt b/tools/findbugs/licenses/LICENSE-bcel.txt
similarity index 100%
rename from tools/findbugs-1.3.9/LICENSE-bcel.txt
rename to tools/findbugs/licenses/LICENSE-bcel.txt
diff --git a/tools/findbugs-1.3.9/LICENSE-commons-lang.txt b/tools/findbugs/licenses/LICENSE-commons-lang.txt
similarity index 100%
rename from tools/findbugs-1.3.9/LICENSE-commons-lang.txt
rename to tools/findbugs/licenses/LICENSE-commons-lang.txt
diff --git a/tools/findbugs-1.3.9/LICENSE-docbook.txt b/tools/findbugs/licenses/LICENSE-docbook.txt
similarity index 100%
rename from tools/findbugs-1.3.9/LICENSE-docbook.txt
rename to tools/findbugs/licenses/LICENSE-docbook.txt
diff --git a/tools/findbugs-1.3.9/LICENSE-dom4j.txt b/tools/findbugs/licenses/LICENSE-dom4j.txt
similarity index 100%
rename from tools/findbugs-1.3.9/LICENSE-dom4j.txt
rename to tools/findbugs/licenses/LICENSE-dom4j.txt
diff --git a/tools/findbugs-1.3.9/LICENSE-jFormatString.txt b/tools/findbugs/licenses/LICENSE-jFormatString.txt
similarity index 100%
rename from tools/findbugs-1.3.9/LICENSE-jFormatString.txt
rename to tools/findbugs/licenses/LICENSE-jFormatString.txt
diff --git a/tools/findbugs-1.3.9/LICENSE-jaxen.txt b/tools/findbugs/licenses/LICENSE-jaxen.txt
similarity index 100%
rename from tools/findbugs-1.3.9/LICENSE-jaxen.txt
rename to tools/findbugs/licenses/LICENSE-jaxen.txt
diff --git a/tools/findbugs-1.3.9/LICENSE-jcip.txt b/tools/findbugs/licenses/LICENSE-jcip.txt
similarity index 100%
rename from tools/findbugs-1.3.9/LICENSE-jcip.txt
rename to tools/findbugs/licenses/LICENSE-jcip.txt
diff --git a/tools/findbugs-1.3.9/LICENSE-jdepend.txt b/tools/findbugs/licenses/LICENSE-jdepend.txt
similarity index 100%
rename from tools/findbugs-1.3.9/LICENSE-jdepend.txt
rename to tools/findbugs/licenses/LICENSE-jdepend.txt
diff --git a/tools/findbugs-1.3.9/LICENSE-jsr305.txt b/tools/findbugs/licenses/LICENSE-jsr305.txt
similarity index 100%
rename from tools/findbugs-1.3.9/LICENSE-jsr305.txt
rename to tools/findbugs/licenses/LICENSE-jsr305.txt
diff --git a/tools/findbugs-1.3.9/LICENSE.txt b/tools/findbugs/licenses/LICENSE.txt
similarity index 100%
rename from tools/findbugs-1.3.9/LICENSE.txt
rename to tools/findbugs/licenses/LICENSE.txt
