Google Git
Sign in
android / platform / external / openthread / ab28127a2
commitab28127a2a9e7b7212e1bd943d3f55a4d9db5f4a[log] [tgz]
authorZhangwx <zhangwenxu@espressif.com>Thu Jan 25 07:05:36 2024 +0800
committerGitHub <noreply@github.com>Wed Jan 24 15:05:36 2024 -0800
treea4cd0e4e4dfb70f0c2440f1d4d1c65eff2d02c01
parent7a2983b01c81009d4be26b3db8a6c7d2257aaa6e [diff]
[spinel] fix passing an unexpected transmit error to mac layer (#9745)

For the Spinel layer, when the state is transmitting, if the received
Spinel frame fails parsing, the current implementation passes the
`OT_ERROR_PARSE` error code to the sub_mac layer via the tx done
handler. This causes an assert because the error code `OT_ERROR_PARSE`
is not a valid one for `SubMac::HandleTransmitDone`. Additionally, I
believe that when the received Spinel frame fails parsing, we should
not trigger a transmit done to the sub_mac layer, as the `TxFrame` and
the `AckFrame` may not be valid for further processing.

In this corner case, I suggest considering ignoring the parsing-failed
received packets, waiting for the tx timeout, and then raising a tx
timeout failure to recover the RCP. This might be a reasonable
approach.
1 file changed
tree: a4cd0e4e4dfb70f0c2440f1d4d1c65eff2d02c01
  1. .github/
  2. doc/
  3. etc/
  4. examples/
  5. include/
  6. script/
  7. src/
  8. tests/
  9. third_party/
  10. tools/
  11. zephyr/
  12. .clang-format
  13. .clang-tidy
  14. .code-spell-ignore
  15. .codecov.yml
  16. .default-version
  17. .gitattributes
  18. .gitignore
  19. .gn
  20. .prettierrc
  21. AUTHORS
  22. BUILD.gn
  23. CMakeLists.txt
  24. CODE_OF_CONDUCT.md
  25. CONTRIBUTING.md
  26. LICENSE
  27. NOTICE
  28. README.md
  29. SECURITY.md
  30. STYLE_GUIDE.md
README.md

OpenThread Build Simulation Docker Coverage Status

What is OpenThread?

OpenThread released by Google is...

...an open-source implementation of the Thread networking protocol. Google Nest has released OpenThread to make the technology used in Nest products more broadly available to developers to accelerate the development of products for the connected home.

...OS and platform agnostic, with a narrow platform abstraction layer and a small memory footprint, making it highly portable. It supports both system-on-chip (SoC) and network co-processor (NCP) designs.

...a Thread Certified Component, implementing all features defined in the Thread 1.3.0 specification, including all Thread networking layers (IPv6, 6LoWPAN, IEEE 802.15.4 with MAC security, Mesh Link Establishment, Mesh Routing) and device roles, as well as Border Router support.

More information about Thread can be found at threadgroup.org. Thread is a registered trademark of the Thread Group, Inc.

Who supports OpenThread?

Getting started

All end-user documentation and guides are located at openthread.io. If you're looking to do things like...

  • Learn more about OpenThread features and enhancements
  • Use OpenThread in your products
  • Learn how to build and configure a Thread network
  • Port OpenThread to a new platform
  • Build an application on top of OpenThread
  • Certify a product using OpenThread

...then openthread.io is the place for you.

Note: For users in China, end-user documentation is available at openthread.google.cn.

If you're interested in contributing to OpenThread, read on.

Contributing

We would love for you to contribute to OpenThread and help make it even better than it is today! See our Contributing Guidelines for more information.

Contributors are required to abide by our Code of Conduct and Coding Conventions and Style Guide.

License

OpenThread is released under the BSD 3-Clause license. See the LICENSE file for more information.

Please only use the OpenThread name and marks when accurately referencing this software distribution. Do not use the marks in a way that suggests you are endorsed by or otherwise affiliated with Nest, Google, or The Thread Group.

Need help?

OpenThread support is available on GitHub: