| commit | 6d3d0bccbd7aabf490db3a7f4c45ed39c1100a6d | [log] [tgz] |
|---|---|---|
| author | btolsch <btolsch@chromium.org> | Mon Dec 10 18:59:28 2018 -0800 |
| committer | Commit Bot <commit-bot@chromium.org> | Tue Dec 11 03:06:10 2018 +0000 |
| tree | 69d3e5bc60d41ca9b3cdd2be531474d810562711 | |
| parent | ce942da9323c38f9c370605edc117c91d6636955 [diff] |
Add QuicClient+QuicServer+MessageDemuxer
This change adds a basic QUIC layer which includes a CBOR message
demuxer. It also includes a number of other changes due to varying
degrees of necessity.
1. A few .cc files were moved from api/public to api/impl when they
relied on other api/impl files to clean up the build dependencies.
2. Binding a UDP socket now uses the address of the IPEndpoint.
3. A platform LogInit function is added to optionally open a log file
or pipe instead of always using stdout.
Bug: openscreen:14
Change-Id: I18dae59d1a961328c45644f68f1e529d0cdb0e68
Reviewed-on: https://chromium-review.googlesource.com/c/1336451
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
This library implements the Open Screen Protocol. Information about the protocol can be found in the Open Screen GitHub repository.
Open Screen uses LUCI builders to monitor the build and test health of the library.
Coming soon: tryjob and submit queue integration with Gerrit code review.
Open Screen Library code should follow the Open Screen Library Style Guide. In addition, you should also run //PRESUBMIT.sh before uploading changes for review (which primarily checks formatting).
Run ./tools/install-build-tools.sh from the root source directory to obtain a copy of the following build tools:
gnclang-formatYou will have to obtain and install these yourself:
Compiler toolchain: Currently, this is gcc on Linux, and clang on Mac (from Xcode).
Builder: ninja
After checking out the Open Screen library, make sure to initialize the submodules for the dependencies. The following commands will checkout all the necessary submodules:
git submodule init
git submodule update
The following commands will build the current example executable and run it.
./gn gen out/Default # Creates the build directory and necessary ninja files ninja -C out/Default # Builds the executable with ninja ./out/Default/hello # Runs the executable
The -C argument to ninja works just like it does for GNU Make: it specifies the working directory for the build. So the same could be done as follows:
./gn gen out/Default cd out/Default ninja ./hello
After editing a file, only ninja needs to be rerun, not gn.
The following sections contain some tips about dealing with Gerrit for code reviews, specifically when pushing patches for review.
There is official Gerrit documentation for this which essentially amounts to:
git push origin HEAD:refs/for/master
You may also wish to install the Change-Id commit-msg hook. This adds a Change-Id line to each commit message locally, which Gerrit uses to track changes. Once installed, this can be toggled with git config gerrit.createChangeId <true|false>.
To download the commit-msg hook for the Open Screen repository, use the following command:
curl -Lo .git/hooks/commit-msg https://chromium-review.googlesource.com/tools/hooks/commit-msg
Gerrit keeps track of changes using a Change-Id line in each commit.
When there is no Change-Id line, Gerrit creates a new Change-Id for the commit, and therefore a new change. Gerrit's documentation for replacing a change describes this. So if you want to upload a new patchset to an existing review, it should contain the matching Change-Id line in the commit message.
By default, each commit to your local branch will get its own Gerrit change when pushed, unless it has a Change-Id corresponding to an existing review.
If you need to modify commits on your local branch to ensure they have the correct Change-Id, you can do one of two things:
After committing to the local branch, run:
git commit --amend git show
to attach the current Change-Id to the most recent commit. Check that the correct one was inserted by comparing it with the one shown on chromium-review.googlesource.com for the existing review.
If you have made multiple local commits, you can squash them all into a single commit with the correct Change-Id:
git rebase -i HEAD~4 git show
where ‘4’ means that you want to squash three additional commits onto an existing commit that has been uploaded for review.