commit a3a60e03e2bf7b79683517584a9a7b3e4c8cd297
author Baranov Victor <bar.victor.2002@gmail.com> Sun Jun 29 22:34:32 2025 +0300
committer GitHub <noreply@github.com> Sun Jun 29 22:34:32 2025 +0300
tree eeb59dcef0562ea9dd223ee44bf4a3aa63280671
parent 40525fb4c78a9020c0cb39c9ec4fb0b14e88eba4

[clang-tidy] add new check: modernize-use-scoped-lock (#126434)

Add new clang-tidy check that finds uses of `std::lock_guard` and suggests
replacing them with C++17's more flexible and safer alternative
`std::scoped_lock`.

Here is a small description of how it works for better understanding of
the code:
Two separate AST matchers are registered:

- The first one matches declarations of `std::lock_guard` that are
single in their scope (only one `std::lock_guard` in `CompoundStmt`).
It's an easy case, we can emit warning right away.

- The second one matches `CompoundStmt`'s that have multiple
`std::lock_guard` declarations, which means that we may have consecutive
declarations of `std::lock_guard` that can be replaced by a single
`std::scoped_lock`. In order to ensure that declarations are
consecutive, we need to loop over `Stmt`'s in `CompoundStmt`. Here is a
small example:
```cpp
{
  std::mutex m1, m2;
  std::lock(m1, m2);
  std::lock_guard<std::mutex> l1(m, std::adopt_lock); // first declaration of 'std::lock_guard'
  std::lock_guard<std::mutex> l2(m, std::adopt_lock); // second declaration of 'std::lock_guard' that can be merged with first using 'scoped_lock'
}
```

This PR closes https://github.com/llvm/llvm-project/issues/107839.