commit ef68f740a67fd1824e44a67d1023e7937fce0cf3
author Jason Ekstrand <jason@jlekstrand.net> Thu Oct 08 02:27:24 2020 -0500
committer Karol Herbst <kherbst@redhat.com> Tue Oct 20 23:46:42 2020 +0200
tree 43e3664d0164c38a464424b4ff83f1f955c0ceee
parent 589d918a4f9da83e3ae441aa674372a141d23349

nir/lower_io: Assert non-zero power-of-two alignments

The way the ALIGN_POT macro works, an alignment of 0 may cause
ALIGN_POT(x, 0) to return 0 for any x.  Throw in an assert to guard
against this case.

Reviewed-by: Karol Herbst <kherbst@redhat.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7069>

src/compiler/nir/nir_lower_io.c

diff --git a/src/compiler/nir/nir_lower_io.c b/src/compiler/nir/nir_lower_io.c
index 9d9e320..318e2a0 100644
--- a/src/compiler/nir/nir_lower_io.c
+++ b/src/compiler/nir/nir_lower_io.c
@@ -1889,6 +1889,7 @@
       if (explicit_type != var->type)
          var->type = explicit_type;
 
+      assert(util_is_power_of_two_nonzero(align));
       var->data.driver_location = ALIGN_POT(offset, align);
       offset = var->data.driver_location + size;
       progress = true;