commit c64cd6988f1a1d00969472273a293cd0dd0bb629
author Jonathan Marek <jonathan@marek.ca> Tue Sep 29 22:21:43 2020 -0400
committer Marge Bot <eric+marge@anholt.net> Thu Nov 05 18:06:15 2020 +0000
tree 8744418870f3c10e5f4b73e0a4da3f51ae9e9352
parent dfaa8b9ae7200b34c9cb6f320731fbc869282cb5

turnip: remove useless tu_image asserts

Validation layer already catches these errors, so don't bother.

Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6940>

src/freedreno/vulkan/tu_image.c

diff --git a/src/freedreno/vulkan/tu_image.c b/src/freedreno/vulkan/tu_image.c
index d47112e..1895593 100644
--- a/src/freedreno/vulkan/tu_image.c
+++ b/src/freedreno/vulkan/tu_image.c
@@ -205,20 +205,6 @@
    const struct tu_sampler_ycbcr_conversion *conversion = ycbcr_conversion ?
       tu_sampler_ycbcr_conversion_from_handle(ycbcr_conversion->conversion) : NULL;
 
-   switch (image->type) {
-   case VK_IMAGE_TYPE_1D:
-   case VK_IMAGE_TYPE_2D:
-      assert(range->baseArrayLayer + tu_get_layerCount(image, range) <=
-             image->layer_count);
-      break;
-   case VK_IMAGE_TYPE_3D:
-      assert(range->baseArrayLayer + tu_get_layerCount(image, range) <=
-             u_minify(image->extent.depth, range->baseMipLevel));
-      break;
-   default:
-      unreachable("bad VkImageType");
-   }
-
    iview->image = image;
 
    memset(iview->descriptor, 0, sizeof(iview->descriptor));
@@ -514,15 +500,6 @@
    }
 #endif
 
-   assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO);
-
-   assert(pCreateInfo->mipLevels > 0);
-   assert(pCreateInfo->arrayLayers > 0);
-   assert(pCreateInfo->samples > 0);
-   assert(pCreateInfo->extent.width > 0);
-   assert(pCreateInfo->extent.height > 0);
-   assert(pCreateInfo->extent.depth > 0);
-
    image = vk_object_zalloc(&device->vk, alloc, sizeof(*image),
                             VK_OBJECT_TYPE_IMAGE);
    if (!image)
@@ -788,9 +765,6 @@
 {
    TU_FROM_HANDLE(tu_image, image, _image);
 
-   assert(pProperties->sType ==
-          VK_STRUCTURE_TYPE_IMAGE_DRM_FORMAT_MODIFIER_PROPERTIES_EXT);
-
    /* TODO invent a modifier for tiled but not UBWC buffers */
 
    if (!image->layout[0].tile_mode)