commit 62eea2b34ca21278a0ec85acfef543546b07222b
author Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Sat Dec 12 11:59:40 2020 -0500
committer Dylan Baker <dylan.c.baker@intel.com> Mon Dec 14 09:23:05 2020 -0800
tree edb94de3674c8f09eae10839820748d6bac02861
parent f9bc767bdc5eb7cfa2fc2188beae7f5729ec0587

zink: really fix direct image mapping offset (I mean it this time)

I got confused and:
* used the vkformat instead of the pipe format for getting format description
* incorrectly calculated bpp

but this time it's definitely 100% fixed I promise

Fixes: 456b57802ea ("zink: fix direct image mapping offset")

Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8074>
(cherry picked from commit dfd0f042e0d8faa374629ea0a67422edff6d48c3)

.pick_status.json

diff --git a/.pick_status.json b/.pick_status.json
index 1d545ba..4c70eb9 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -166,7 +166,7 @@
         "description": "zink: really fix direct image mapping offset (I mean it this time)",
         "nominated": true,
         "nomination_type": 1,
-        "resolution": 0,
+        "resolution": 1,
         "master_sha": null,
         "because_sha": "456b57802eaf95d36e7b950bdb5ffd86a1c0dc63"
     },

src/gallium/drivers/zink/zink_resource.c

diff --git a/src/gallium/drivers/zink/zink_resource.c b/src/gallium/drivers/zink/zink_resource.c
index d9de6c7..dc4442f 100644
--- a/src/gallium/drivers/zink/zink_resource.c
+++ b/src/gallium/drivers/zink/zink_resource.c
@@ -599,11 +599,11 @@
          vkGetImageSubresourceLayout(screen->dev, res->image, &isr, &srl);
          trans->base.stride = srl.rowPitch;
          trans->base.layer_stride = srl.arrayPitch;
-         const struct util_format_description *desc = util_format_description(res->format);
+         const struct util_format_description *desc = util_format_description(res->base.format);
          unsigned offset = srl.offset +
                            box->z * srl.depthPitch +
                            (box->y / desc->block.height) * srl.rowPitch +
-                           (box->x / desc->block.width) * (util_format_get_blocksize(res->format) / desc->nr_channels);
+                           (box->x / desc->block.width) * (desc->block.bits / 8);
          ptr = ((uint8_t *)ptr) + offset;
       }
    }