commit 4cc7d6a85f2eccf90307989bbdae6fc9b0a301c0
author Iago Toral Quiroga <itoral@igalia.com> Tue Sep 01 08:56:47 2020 +0200
committer Marge Bot <eric+marge@anholt.net> Tue Oct 13 21:21:33 2020 +0000
tree ae94840a6830446a3d4a34db3b3d0d4058944759
parent fdcc36aad4002fc9536b5a793f4211acdfb9b084

v3dv: expose DRM modifiers based on supported features

So far we have only been exposing linear for WSI formats and UIF on
everythig else, but we should instead expose linear or UIF based
on whether the underlying format supports any features for the given
layout.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6766>

src/broadcom/vulkan/v3dv_formats.c

diff --git a/src/broadcom/vulkan/v3dv_formats.c b/src/broadcom/vulkan/v3dv_formats.c
index 75c4c43..3e898d6 100644
--- a/src/broadcom/vulkan/v3dv_formats.c
+++ b/src/broadcom/vulkan/v3dv_formats.c
@@ -529,16 +529,13 @@
          struct VkDrmFormatModifierPropertiesListEXT *list = (void *)ext;
          VK_OUTARRAY_MAKE(out, list->pDrmFormatModifierProperties,
                           &list->drmFormatModifierCount);
-         /* Only expose LINEAR for winsys formats.
-          * FIXME: is this correct?
-          */
-         if (format == VK_FORMAT_B8G8R8A8_SRGB ||
-             format == VK_FORMAT_B8G8R8A8_UNORM) {
+         if (pFormatProperties->formatProperties.linearTilingFeatures) {
             vk_outarray_append(&out, mod_props) {
                mod_props->drmFormatModifier = DRM_FORMAT_MOD_LINEAR;
                mod_props->drmFormatModifierPlaneCount = 1;
             }
-         } else {
+         }
+         if (pFormatProperties->formatProperties.optimalTilingFeatures) {
             vk_outarray_append(&out, mod_props) {
                mod_props->drmFormatModifier = DRM_FORMAT_MOD_BROADCOM_UIF;
                mod_props->drmFormatModifierPlaneCount = 1;