tree 7e0cafaaf2d7379bc5647766eeb64c15a4b2680c
parent 9ce31c466d181848f31ba932428db3d4da398a6d
author Gilles Peskine <Gilles.Peskine@arm.com> 1565704716 +0200
committer Gilles Peskine <Gilles.Peskine@arm.com> 1565704716 +0200

Clean up status code handling inside psa_destroy_key

Adopt a simple method for tracking whether there was a failure: each
fallible operation sets overall_status, unless overall_status is
already non-successful. Thus in case of multiple failures, the
function always reports whatever failed first. This may not always be
the right thing, but it's simple.

This revealed a bug whereby if the only failure was the call to
psa_destroy_se_key(), i.e. if the driver reported a failure or if the
driver lacked support for destroying keys, psa_destroy_key() would
ignore that failure.

For a key in a secure element, if creating a transaction file fails,
don't touch storage, but close the key in memory. This may not be
right, but it's no wronger than it was before. Tracked in
https://github.com/ARMmbed/mbed-crypto/issues/215